[00:24:30] (03PS1) 10Malvineous: Actually stop previewing once the maximum number of pages has been reached [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/87700 [00:25:58] (03CR) 10Malvineous: [C: 032 V: 032] "Trivial change" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/87700 (owner: 10Malvineous) [02:31:06] (03PS1) 10Stwalkerster: (Bug 52590) Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 [02:53:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=55359 [03:19:32] (03PS1) 10Stwalkerster: Fix git repository viewer URLs so they support more variants of the Wikimedia URLs [core] - 10https://gerrit.wikimedia.org/r/87702 [04:25:16] (03PS1) 10Aaron Schulz: Avoid section edit links when needed [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/87703 [05:43:34] (03CR) 10Physikerwelt: [C: 04-2] "I thin we defenitly need some kind of state handling for the child process. I'm still unhappy about the required timeout. However this doe" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87699 (owner: 10Physikerwelt) [06:09:53] (03PS1) 10Mattflaschen: Fix ordering of db updates and syntax errors. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 [06:13:56] (03PS2) 10Mattflaschen: Fix ordering of db updates and syntax errors. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 [07:06:00] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [07:15:47] (03CR) 10Nikerabbit: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [07:17:07] (03CR) 10Nikerabbit: "Having $this in the parameters makes it nightmare to maintain BC for this hook. Are there any stats that depend on the context for anythin" [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [07:18:36] (03CR) 10Legoktm: "Not any that I can think of. I was trying to keep it as similar as possible to APIQuerySiteInfoGeneralInfo called above." [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [07:19:00] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [07:26:33] (03CR) 10Nikerabbit: [C: 031] Use a more standard "Forgot your password?" in userlogin-resetpassword-link [core] - 10https://gerrit.wikimedia.org/r/87656 (owner: 10Nemo bis) [07:26:55] (03CR) 10Nikerabbit: [C: 032] Fix spelling (occurred) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87668 (owner: 10Shirayuki) [07:26:59] (03Merged) 10jenkins-bot: Fix spelling (occurred) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87668 (owner: 10Shirayuki) [07:27:44] (03Abandoned) 10Isarra: Add link to description page on mw.org [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [07:41:19] (03CR) 10Nikerabbit: "Your comment makes me feel that code review is not appreciated." [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [07:42:51] Nikerabbit: It's not you, it's gerrit. [07:50:02] (03CR) 10Isarra: "Gerrit is not appreciated. That gerrit makes code review also not appreciated because it results in further pain of having to deal with ge" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [07:54:25] (03PS1) 10Yuvipanda: Add link to description page on mw.org [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87706 [07:54:39] (03CR) 10Yuvipanda: [C: 032] Add link to description page on mw.org [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87706 (owner: 10Yuvipanda) [07:54:44] Athyria: ^ [07:54:54] don't know if jenkins-bot is setup for that [07:55:10] I'll merge manually in a bit if not [07:55:32] (03CR) 10Yuvipanda: [V: 032] Add link to description page on mw.org [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87706 (owner: 10Yuvipanda) [07:55:32] okay [07:55:37] looks like it wasn't [07:56:45] (03CR) 10Yuvipanda: "Merged from GH in https://gerrit.wikimedia.org/r/#/c/87706/" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [08:01:36] YuviPanda: jenkins would +1 if it were set up. [08:35:20] oh, man. [08:35:36] so, gerrit has a new UI for changes [08:35:41] it's coming in version 2.8 [08:35:56] and, um... i'll just leave this here: https://android-review.googlesource.com/#/c2/66020/ [08:36:31] oh god that's horrible [08:36:44] yeah, like, wat? [08:37:14] https://android-review.googlesource.com/#/c/66020/1/libc/arch-arm/cortex-a15/bionic/__strcat_chk.S,cm <-- there's like a blinking cursor [08:37:37] oh, vim keybinds, that i like [08:37:52] keybindings [08:38:18] anyways, you know, it's so awful that you have to figure the people working on this actually have a different visual system in their head [08:38:35] It's very impressive. [08:39:08] it's basically impossible to see diffs between patchsets now [08:39:31] oh [08:39:34] you have to do it in diff view [08:39:36] ugh [08:39:39] Probably more than just a different visual system. I don't even know what... [08:40:35] But it has a lot of colours! [08:41:52] i really wish we had gone with phabricator [08:42:14] MaxSem will appreciate this [08:42:26] MaxSem: look, new gerrit ui, coming in 2.8: https://android-review.googlesource.com/#/c2/67060/ [08:42:27] hi [08:44:11] http://i.imgur.com/3I7ubzF.png [08:44:13] ugh, that's a lot of changes [08:44:22] 'someone said something somewhere, maybe' [08:49:37] (03CR) 10Legoktm: "It says "Need Rebase or Has Dependency", but there's nothing to rebase against since it's a new repository..." [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 (owner: 10Liangent) [09:27:35] blinking cursor?!?! [09:29:01] ‽‽ [11:14:54] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [11:19:04] (03PS4) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [11:48:26] (03CR) 10Rtdwivedi: [C: 031] Implement ContentHandler facility for page pages [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 (owner: 10Tpt) [12:22:21] (03CR) 10Helder.wiki: [C: 031] (Bug 52590) Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [12:56:27] (03CR) 10Liangent: "Ah, it's not a new repo anymore. Reedy added .gitignore and .gitreview for me, and created a conflict. Fixed." [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 (owner: 10Liangent) [12:56:36] (03PS5) 10Liangent: Initial version of the extension [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 [13:21:55] (03CR) 10Shirayuki: [C: 031] "I have tested this patchset in three modes: "always", "never", and "user"." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 (owner: 10Wikinaut) [13:35:18] (03PS1) 10Bartosz Dziewoński: Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 [13:40:13] (03CR) 10Kelson: [C: 031] Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [13:47:41] (03CR) 10Liangent: [C: 032 V: 032] "Self-merge, given that:" [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 (owner: 10Liangent) [13:57:07] (03CR) 10Raimond Spekking: [C: 031] "+1 from i18n side." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 (owner: 10Wikinaut) [14:27:10] anyone online know how to run unit tests for an extension? i have registered the hook. created an onUnitTestsList static function. created a special suite.extensions.xml that only has the extensions section in it, but when i run tests/phpunit/phpunit.php --testdox --configuration tests/phpunit/suite.extensions.xml [14:27:16] nothing happnes [14:51:29] anyone online know how to run unit tests for an extension? [14:56:48] (03PS11) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [15:14:13] (03CR) 10Bartosz Dziewoński: "> 1) The other notice boxes that are shown in that location are multi-line (caption and explanation)." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [15:15:45] ori-l: ^ [15:28:49] Hi, I've downloaded MediaWiki-Vagrant, and 'vagrant up' is stuck at "/Stage[main]/Git/Package[git]/ensure: ensure changed 'purged' to 'latest'". I'm running the latest Vagrant and VB - any ideas? [15:56:13] (03PS11) 10Bartosz Dziewoński: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [16:14:33] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/APC] - 10https://gerrit.wikimedia.org/r/87721 (owner: 10L10n-bot) [16:16:15] (03PS2) 10Aklapper: Remove custom CSS for duplicates.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/87057 [16:17:19] (03CR) 10Aklapper: [C: 031] Remove custom CSS for duplicates.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/87057 (owner: 10Aklapper) [16:19:31] (03PS4) 10Wikinaut: problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 [16:20:44] (03CR) 10Wikinaut: [C: 031 V: 031] problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 (owner: 10Wikinaut) [16:23:45] (03CR) 10Wikinaut: [C: 032 V: 032] problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 (owner: 10Wikinaut) [16:27:06] ComradeStakhanov: Hmmm, not sure. ori-l is the one you want to talk to. [16:27:10] ComradeStakhanov: But he may not be around for a bit. [16:37:35] Elsie: OK, thanks [16:45:22] (03PS1) 10Kipcool: resurrected special importTSV and exportTSV [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/87723 [16:46:26] (03CR) 10Kipcool: [C: 032 V: 032] resurrected special importTSV and exportTSV [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/87723 (owner: 10Kipcool) [16:52:40] (03PS10) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [16:53:25] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/87726 (owner: 10L10n-bot) [16:53:29] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/APC] - 10https://gerrit.wikimedia.org/r/87727 (owner: 10L10n-bot) [16:53:35] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/87728 (owner: 10L10n-bot) [17:15:54] (03PS15) 10Siebrand: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [17:38:29] (03PS2) 10Siebrand: (Bug 52590) Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [17:45:39] (03CR) 10Siebrand: [C: 04-1] "(3 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [17:47:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Trivial." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [17:48:06] (03CR) 10Siebrand: [C: 031] Remove unused or incognito mwe-upwiz-campaigns-editing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87628 (owner: 10Nemo bis) [17:48:52] (03PS2) 10Siebrand: Add a config flag, $wgAllowGlobalMessaging, to allow global messaging [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [17:52:47] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [17:55:10] (03CR) 10Bartosz Dziewoński: "@Siebrand: Done in https://gerrit.wikimedia.org/r/87731" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 (owner: 10Bartosz Dziewoński) [18:03:38] (03CR) 10Siebrand: "Thanks, Matmarex. I added Max as reviewer there, because he's a deployer." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 (owner: 10Bartosz Dziewoński) [18:32:56] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86879 (owner: 10Hashar) [18:35:52] siebrand: https://gerrit.wikimedia.org/r/#/c/80769/ look OK to you? [18:36:52] ori-l: Can you add me as reviewer? WIll look at it before Monday morning PDT> [18:37:32] siebrand: done [18:38:06] (03CR) 10Ori.livneh: "LGTM; waiting for Siebrand to have a look." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [18:38:27] (03CR) 10Ori.livneh: [C: 031] "Should be merged if i18n is OK." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [18:39:49] the i18n there is rather trivial, isn't it? [18:39:51] thanks, ori-l [18:40:44] probably, but i've misjudged that before, and if siebrand can take a look before monday then why not [18:42:07] :) [18:44:06] MatmaRex: btw this is interesting: http://wilsonpage.co.uk/preventing-layout-thrashing/ [18:44:54] ori-l: https://bugzilla.wikimedia.org/show_bug.cgi?id=55376 I'm going to add a patch for that in core, to help with the varnish patch for vagrant [18:45:20] YuviPanda: oh, I missed the report. Yeah, that makes sense, especially since there's the dynamic value specified in defaultsettings [18:45:31] yeah [18:45:31] I think it's a bug in the CLI installer; the web installer's behavior is correct IIRC [18:45:51] ori-l: yeah, true [18:55:27] ori-l: Hi, I was told you're the one to ask about MW-Vagrant problems - can I ask now or later? [18:55:54] ComradeStakhanov: yeah, what's up? [18:56:23] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [18:56:25] 'vagrant up' is stuck at "/Stage[main]/Git/Package[git]/ensure: ensure changed 'purged' to 'latest'". I'm running vagrant 1.3.3 and VB 4.2.18 [18:56:57] ori-l: 1st pass done. [18:57:08] siebrand: thanks! [18:57:52] ComradeStakhanov: how long has it been stuck? [18:57:59] I gave it 1 hour [18:58:17] the puppet log file in /vagrant/logs/puppet seems to say nothing about it [18:58:21] what OS are you running, and do you have git installed? [18:58:21] gah [18:58:29] seriously. D: [18:58:47] Debian 7, git 1.7.10.4 [18:59:49] ComradeStakhanov: okay, so you can ctrl+break to abort the puppet run (you might have to do it a couple of times) [19:00:09] then rm -rf mediawiki/ in case there's an incomplete clone [19:00:44] and run 'git clone https://gerrit.wikimedia.org/r/mediawiki/core' [19:00:52] (03PS12) 10Bartosz Dziewoński: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [19:00:53] siebrand: ^ [19:00:57] or rather 'git clone https://gerrit.wikimedia.org/r/mediawiki/core mediawiki' [19:01:08] in the virtual machine or on the host? [19:01:11] the host [19:01:18] Okay thanks, doing [19:01:41] what happens is that the git-clone operation in the VM is thrashing because it requires creating lots of files on the mountpoint shared between the guest and host [19:02:29] I see - could it be due to the hardware (SSD)? [19:02:30] this is OK if the virtualbox modules on the guest are up-to-date, but since this is your first run they're not [19:02:57] no, I don't think so; i've seen it on spinning disks too [19:03:20] if you clone git into mediawiki/ puppet should just pick it up, though [19:03:30] anyways once you're done that run 'vagrant provision' again [19:03:56] OK [19:04:21] have to run for a bit, but i'll check here later to see if you had follow-up questions [19:04:29] if it doesn't fix things please file a bug [19:04:50] (https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki-Vagrant) [19:04:53] Thanks =) [19:04:59] np! [19:07:58] (03CR) 10Ebrahim: "@Santhosh: Hi, can you have a closer look? I explained to Amir that I wanted someone per MediaWiki guideline make the patch suitable to me" [core] - 10https://gerrit.wikimedia.org/r/86018 (owner: 10Ebrahim) [19:09:37] (03PS1) 10Raimond Spekking: Revert "Localisation updates from http://translatewiki.net." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87883 [19:19:07] Ew, 32 KiB/s cloning speed [19:21:02] ori-l: we should probably switch to github for cloning by default. [19:21:09] much faster, at least for people not in the US [19:21:12] (03PS1) 10Raimond Spekking: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87884 [19:21:32] (03CR) 10Raimond Spekking: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87884 (owner: 10Raimond Spekking) [19:21:35] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87884 (owner: 10Raimond Spekking) [19:22:21] YuviPanda: no way github is evil :D [19:22:31] strange... I used to have a clone from gerrit earlier and that downloaded much faster [19:22:53] hashar: for read only clones? [19:23:04] YuviPanda: is that for vagrant-mediawiki ? [19:23:12] YuviPanda: maybe you could use shallow clone [19:23:15] hashar: no, primarily mediawiki/core [19:23:23] shallow clones are useless if you want to hack on things, no [19:23:29] yeah true [19:26:10] And I guess git.wikimedia.org is not good if one wants to hack on stuff as well? [19:26:11] we could also have ^demon unbreak gerrit [19:26:18] (he loves to hear all about it) [19:26:44] MatmaRex: I think his last response to a question like that was 'no, really, please do not bug me about Gerrit anymore' [19:26:57] ComradeStakhanov: git.wikimedia org and github.com/wikimedia are perfect mirrors of all (most) repositories on gerrit.wikimedia.org [19:27:04] ComradeStakhanov: oh, that should work too. It's just broken more often than github. [19:27:06] indeed [19:27:11] it doesn't matter where you clone from [19:27:23] YuviPanda: i think it was more along the lines of, 'yeah well, fuck gerrit' :D [19:27:30] And then I'd just add a gerrit remote, no? [19:27:44] ComradeStakhanov: indeed. 'git review -s' adds it automatically, IIRC [19:27:49] Awesome [19:29:43] wow, git.wikimedia.org cloning seems to fail [19:29:48] (03PS1) 10MarkTraceur: jquery audit for mw.LanguageUpWiz.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87885 [19:30:22] ComradeStakhanov: fail how? [19:30:34] (03CR) 10Siebrand: [C: 032] "phpcs has a load of errors and warnings on the files touched in this patch. Maybe give some attention to that? Many hands make light work." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [19:30:36] error: RPC failed; result=22, HTTP code = 405 fatal: The remote end hung up unexpectedly [19:31:04] try again, it would work [19:31:06] highly intermittent [19:31:12] hence my preference for github ;) [19:31:53] siebrand: yeah, i'm planning to clean up the template a bit, it's awful (and you don't need phpcs to see that :D) [19:32:12] MatmaRex: heh. [19:32:20] Yeah, github gives 3.10 MiB/s [19:32:36] (it would be better to just kill the templates, but some whitespace fixup in the meantime can't hurt) [19:32:46] thanks for the merge [19:32:49] sure [19:33:11] * siebrand goes back to American Horror Story. [19:33:41] ComradeStakhanov: where are you geographically? (if I may ask). Checking for bandwidth comparisons [19:34:28] (03Merged) 10jenkins-bot: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [19:37:16] (03PS3) 10Bartosz Dziewoński: Backport information boxes' styles from vforms to shared CSS [core] - 10https://gerrit.wikimedia.org/r/82828 [19:37:41] YuviPanda: Hungary [19:37:47] hah! ok [19:38:03] (03CR) 10Bartosz Dziewoński: "Rebased with https://github.com/matmarex/mediawikireleasenotes-driver" [core] - 10https://gerrit.wikimedia.org/r/82828 (owner: 10Bartosz Dziewoński) [19:43:48] (03PS1) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [19:44:02] ori-l: ^ when you're bac [19:44:03] k [19:45:42] (03CR) 10Yuvipanda: "Seems to not break WebInstaller in my test." [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [19:47:15] (03PS12) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [19:57:26] (03CR) 10Alex Monk: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87885 (owner: 10MarkTraceur) [20:00:38] (03PS15) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [20:11:20] Krenair: Quoth Krinkle|detached, prop is always better than attr [20:12:17] (03PS13) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [20:12:25] I think there was something about this on CC/JS wasn't there? [20:12:38] yeah, Pitfalls: "Use attr() and prop() appropriately. Read more at http://javascript.info/tutorial/attributes-and-custom-properties" [20:12:43] Yeah [20:13:34] Krenair: Unless you think I've done it wrong... [20:14:11] marktraceur, no, I just forgot about differences and couldn't figure it out myself [20:21:17] anyone know how to get wiki tests to test with an extension's tests? [20:29:06] (03PS1) 10Foxtrott: Load Bootstrap only for HTML5 and only when enabled [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/87889 [20:30:56] (03CR) 10Nemo bis: "Isarra, next time gerrit frustrates you please don't complain to/with those helping. :) If you need help with a rebase or amendment, just " [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [20:31:03] so MW-Vagrant works, thanks all =) [20:31:24] (03PS2) 10Foxtrott: Load Bootstrap only for HTML5 and only when enabled [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/87889 [20:31:30] (03PS3) 10Foxtrott: Udate to Bootstrap3, load Bootstrap only for HTML5 and only when enabled [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/87889 [20:31:47] (03CR) 10Foxtrott: [C: 032 V: 032] Update to Bootstrap3, load Bootstrap only for HTML5 and only when enabled [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/87889 (owner: 10Foxtrott) [20:38:08] (03CR) 10Krinkle: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87885 (owner: 10MarkTraceur) [20:43:19] i have discovered a new and exciting way of nicely messing up your git repo: https://www.kernel.org/pub/software/scm/git/docs/git-read-tree.html#_sparse_checkout [20:43:31] (massively speeding up checkout on non-ssd disks in the process) [20:43:40] (03PS1) 10Foxtrott: Rework and update to Bootstrap 3 [skins/chameleon] - 10https://gerrit.wikimedia.org/r/87890 [20:43:57] just make it not check out message files, and presto. [20:45:09] marktraceur, also changing mw.message( 'mwe-upwiz-code-unknown' ).escaped() to use .text... [20:46:26] marktraceur, nvm, works fine if you're using it in $.text actually [20:48:18] 'kay [20:50:21] (03PS2) 10Foxtrott: Rework and update to Bootstrap 3 [skins/chameleon] - 10https://gerrit.wikimedia.org/r/87890 [20:51:20] (03CR) 10Foxtrott: [C: 032 V: 032] Rework and update to Bootstrap 3 [skins/chameleon] - 10https://gerrit.wikimedia.org/r/87890 (owner: 10Foxtrott) [21:00:13] (03CR) 10Isarra: "If that's an offer to actually help with that in the future, that would be appreciated, since all my requests for such help so far have pr" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 (owner: 10Isarra) [21:06:25] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [21:18:17] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87894 [21:18:24] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87894 (owner: 10Siebrand) [21:18:26] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87894 (owner: 10Siebrand) [21:18:48] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87895 [21:19:00] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87895 (owner: 10Siebrand) [21:19:05] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87895 (owner: 10Siebrand) [21:19:31] * YuviPanda spots an ori-l making commits [21:20:19] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87897 [21:20:25] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87897 (owner: 10Siebrand) [21:20:28] :o [21:20:33] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87897 (owner: 10Siebrand) [21:24:24] that's a lot of reverts. [21:26:20] MatmaRex: apparently it started exporting en [21:26:30] qchris: around? [21:26:40] Hi ori. [21:26:53] hello :) do you know if we can rename repositories in gerrit? [21:27:00] We cannot. [21:27:07] Well ... not easily at least :-( [21:27:22] yeah, I know it requires some manual queries, was wondering if it is something we had done before [21:27:28] I guess the answer is not.. bummer. [21:27:37] Yes, the answer is "No" [21:27:45] We tried to get support for that into master. [21:28:02] But they never got around to review it, as it's a rather big undertaking. [21:28:27] oh well. I appreciate the effort. [21:28:38] ori-l: So what can be done is deleting the old repo and creating it again under a new name. [21:29:17] Hi guys. I have a question, which may in fact be a bug report, I'm not sure. Have a look at the sortkey for "Branches of Physics" in this API query: https://en.wikipedia.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:Physics&cmprop=title|sortkey [21:29:31] qchris: yes, I think that is what I'll end up doing. [21:29:45] Is the sortkey supposed to include a linefeed followed by the all-caps page name? [21:29:58] ori-l: Ok. Sorry. :-/ [21:30:15] qchris: not your fault! thanks for the info. [21:30:28] RobinHood70: Yes, I think you're looking for something else though, one minute [21:31:05] RobinHood70: https://en.wikipedia.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:Physics&cmprop=title|sortkeyprefix <-- you want the human readable sortkey I think [21:31:12] RobinHood70: See also https://www.mediawiki.org/wiki/API:Categorymembers [21:32:19] Yeah, I found that. The API query was actually mostly to verify what I'm seeing in a category extension that I'm trying to debug. I'm getting something similar there. [21:32:30] Ah. [21:32:38] Not sure then :P [21:32:42] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87902 [21:32:51] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87902 (owner: 10Siebrand) [21:33:00] I don't entirely know what I'm doing, as I didn't write the code, but it's in a CategoryPage extension and I'm getting duplicate values in the sortkey. [21:33:33] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87902 (owner: 10Siebrand) [21:34:16] Are sortkeys guaranteed to be unique? I'm not sure about that... [21:34:41] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/87904 [21:34:47] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/87904 (owner: 10Siebrand) [21:35:12] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/87904 (owner: 10Siebrand) [21:36:18] legoktm: What I mean is that if I look at the sortkey on a page with [[Category:Bla| Test]], the value I'm getting back, at least visually, is "Test Test". I'm just looking up how to check in PHP if that middle "space" is actually the linefeed I see in the API. [21:36:18] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87905 [21:36:24] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87905 (owner: 10Siebrand) [21:36:27] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87905 (owner: 10Siebrand) [21:36:35] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87906 [21:36:40] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87906 (owner: 10Siebrand) [21:36:59] okay. I'm not sure! >.> [21:37:28] RobinHood70: sortkeys don't have to be unique [21:37:42] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/87907 [21:37:47] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/87907 (owner: 10Siebrand) [21:37:48] RobinHood70: and the way they are composed depends on $wgCategoryCollation [21:37:49] !wg CategoryCollation [21:37:49] https://www.mediawiki.org/wiki/Manual:%24wgCategoryCollation [21:37:53] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/87907 (owner: 10Siebrand) [21:38:11] some collations put binary data in the sortkey, so it's encoded in this way in the API results [21:38:31] (for example pl.wikipedia uses such a collation, if you want to test) [21:38:53] (03CR) 10Siebrand: [V: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87906 (owner: 10Siebrand) [21:40:20] MatmaRex: I'm not worried about uniqueness, I'm worried about getting "Test Test" with a sortkey of only " Test". (Part of the purpose of the extension is to allow category groups to be customized instead of just a single letter.) [21:40:57] You may have a point about the composition, though. I'll look into that some more. [21:42:06] RobinHood70: i'm pretty sure that what you want is a custom collation [21:42:32] RobinHood70: there's some work in progress about letting wikis use multiple collations at the same time, per-category and per-user [21:42:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=44667 (don't be fooled by the summary) [21:43:20] night [21:43:59] RobinHood70: i'm off for now, sorry. good night! [21:44:03] That would be nice! :) In the meantime, I still have to debug the existing extension. I basically just need to know what the incoming data will look like so I can parse it properly. [21:44:09] Thanks for the help, good night! [21:44:47] RobinHood70: you basically don't for the uca- collations, it's a black box really [21:45:00] RobinHood70: you can have a look at includes/Collation.php in core [21:45:02] !master includes/Collation.php [21:45:02] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/includes%2fCollation.php [21:45:24] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87910 [21:45:29] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87910 (owner: 10Siebrand) [21:45:31] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87910 (owner: 10Siebrand) [21:45:36] I just checked, and the data I'm getting is indeed linefeed separated, so that's the main issue I need to deal with. Now that I understand that, I can do something about it. [21:47:36] RobinHood70: good luck :) see you later [21:47:44] Thanks! [21:51:57] Meh, the new bugzilla skin mozilla is using isn't bad. [21:51:58] https://bugzilla.mozilla.org/show_bug.cgi?id=403510 [21:52:40] https://bugzilla.mozilla.org/ [22:13:01] (03CR) 10Krinkle: "FIXME: This incorrectly uses mw.hook, please refactor ASAP." [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [22:15:43] (03PS1) 10Krinkle: mediawiki.page.gallery: Clean up documentation for hook [core] - 10https://gerrit.wikimedia.org/r/87912 [22:15:54] (03CR) 10Krinkle: [C: 032] mediawiki.page.gallery: Clean up documentation for hook [core] - 10https://gerrit.wikimedia.org/r/87912 (owner: 10Krinkle) [22:16:51] (03PS2) 10Krinkle: mediawiki.page.gallery: Clean up documentation for hook [core] - 10https://gerrit.wikimedia.org/r/87912 [22:22:25] (03CR) 10Alex Monk: [C: 032] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87885 (owner: 10MarkTraceur) [22:22:26] (03PS1) 10Luis Felipe Schenone: Uploading updated and improved files [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/87914 [22:22:34] (03Merged) 10jenkins-bot: jquery audit for mw.LanguageUpWiz.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87885 (owner: 10MarkTraceur) [22:25:22] (03PS1) 10Krinkle: postEdit: Add documentation for hook so it shows up in the index [core] - 10https://gerrit.wikimedia.org/r/87916 [22:28:46] (03PS1) 10Krinkle: mediawiki.action.edit.preview: Clean up and optimisation [core] - 10https://gerrit.wikimedia.org/r/87917 [22:30:08] (03PS2) 10Krinkle: mediawiki.action.edit.preview: Clean up and optimisation [core] - 10https://gerrit.wikimedia.org/r/87917 [22:33:46] ori-l: I wouldn't oppose a poll of top committers on staying with Gerrit or switching to Phabricator. [22:34:16] Though I very much doubt anyone wants to incur the costs of a switch. [22:34:21] I thought about writing an e-mail. [22:34:30] There other options, of course. [22:34:36] Like simply not upgrading our version. [22:34:38] Indefinitely. [22:34:44] That's the usual corporate solution, I'm finding, heh. [22:34:56] You just pick a good enough version and leave it alone. [22:35:09] I dunno. I've gotten used to Gerrit. [22:35:17] I'm not sure I want to get used to it again, though. [22:35:24] Once is surely enough. [22:35:40] Saying, you know: yes, Gerrit works; it's not pretty, but we don't need to hyperventilate about how bad it is. But something friendlier could have a real impact about the quality of interactions people have with one another, and that could in turn improve the quality of code. [22:35:53] Eh. [22:35:56] Eh..., rather. [22:36:02] Yeah, I thought the same. [22:36:15] I think if you want more social coding, developing your own theme park is probably not the best use of resources when there's already GitHub and Bitbucket. [22:36:35] They're all using Git. Surely integration among them is doable. [22:36:53] And future tools, if they emerge. [22:37:11] I suppose some of the auth work will help with this. [22:38:14] * YuviPanda|zzz should start his bot back up [22:38:28] i've been just pulling them through manually, because there's so few of them [22:38:53] The bot is great. :-) [22:38:59] Though I wonder if it's the best solution long-term. [22:39:12] there's a gerrit plugin that's going nowhere right now [22:39:12] I dunno enough about the various problems involved in integration to say. [22:40:13] (03PS1) 10Legoktm: Add patch for 1.21.2 [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/87918 [22:40:24] Isarra: ^ [22:40:28] i didn't test it though [22:41:18] (03Abandoned) 10Isarra: (Bug 35785) Make enhanced (collapsible) recentchanges the default [core] - 10https://gerrit.wikimedia.org/r/49082 (owner: 10Isarra) [22:44:18] YuviPanda|zzz: Got a link, by chance? [22:44:25] hmm? [22:44:28] oh [22:44:31] the gerrit plgin [22:44:33] moment [22:45:29] Elsie: https://groups.google.com/forum/#!topic/repo-discuss/Q0E4R6u76tI/discussion [22:45:54] not sure how complete it is [22:45:56] or anything [22:46:01] qchris: might know [22:46:05] Thanks. :-) [22:47:19] legoktm: Did you apply it? [22:47:23] Did anything explode? [22:47:28] Crap, we need to test it. [22:47:35] I just generated the patch by editing it [22:47:36] I'm tired of testing things. [22:47:38] it should apply cleanly [22:47:41] I want to eat cake and go to bed. [22:48:04] Aye, I mean the patched stuff, does that still work... [22:48:10] Or should we just find out tomorrow? [22:48:27] hrm [22:51:11] YuviPanda|zzz: It meanwhile got his own repo: [22:51:28] https://gerrit-review.googlesource.com/#/admin/projects/plugins/github [22:51:30] I should stop pretending to be trying tos lseep [22:51:36] Elsie: ^ [22:51:57] That plugin now even does a first stab at pulling commits over from github [22:52:07] nice! [22:52:07] but I haven't found time to look at that in detail [22:52:14] Welcome back, Yuvi. [22:52:37] We definitely need YuviPanda's plugin for some more time ;-) [22:53:21] If YuviPanda is not using his bed ... I will. [22:53:26] heh [22:53:27] Good night! [22:53:35] I couldn't really sleep, my hand hurts too much [22:53:38] so am typing instead :| [22:53:55] qchris: I'm anxious to get reviewer stats out of Gerrit. :-) [22:54:08] We're waiting on a Gerrit upgrade now, I think. [22:54:11] And a merge of your change. [22:54:28] Elsie: Agreed. I pinged ^demon about that already. [22:54:35] Cool, thanks. [22:54:41] But he's always busy. [22:54:51] Aren't we all. [22:56:21] (03PS1) 10Luis Felipe Schenone: Uploading updated and improved version of the MpDisqus extension [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/87919 [23:00:57] (03CR) 10Ori.livneh: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/87916 (owner: 10Krinkle) [23:03:51] (03Merged) 10jenkins-bot: postEdit: Add documentation for hook so it shows up in the index [core] - 10https://gerrit.wikimedia.org/r/87916 (owner: 10Krinkle) [23:14:40] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur) [23:17:36] (03PS1) 10Krinkle: Follow-up d94d29a920: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/87920 [23:19:41] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur) [23:22:26] ori-l: marktraceur: Can one of you merge this typo fix? https://gerrit.wikimedia.org/r/#/c/87920/ [23:24:43] (03CR) 10Yuvipanda: [C: 032] Follow-up d94d29a920: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/87920 (owner: 10Krinkle) [23:26:26] Krinkle: I guess jenkins bot will eventually get to it [23:26:32] Yep [23:26:42] https://integration.wikimedia.org/zuul/ [23:27:42] (03Merged) 10jenkins-bot: Follow-up d94d29a920: Fix typo in release notes [core] - 10https://gerrit.wikimedia.org/r/87920 (owner: 10Krinkle) [23:29:08] (03CR) 10Yuvipanda: "Needs I5436dd8c340604cbb59406a507188e11c8f86e86 to work" [vagrant] - 10https://gerrit.wikimedia.org/r/86214 (owner: 10Yuvipanda) [23:30:44] Krinkle: speaking of typo fixes, got a moment for https://gerrit.wikimedia.org/r/#/c/87921/ ? [23:31:31] ori-l: speaking of typo fixes, got a moment for https://gerrit.wikimedia.org/r/#/c/87887/? [23:31:40] not right now, necessarily [23:31:50] but at some point [23:32:04] it's not a typo fix [23:32:09] and it needs a better commit message [23:32:38] but sure, I'll review in a bit [23:33:11] okay, updating commit message [23:33:45] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [23:33:53] clicked wrong one [23:34:12] heh [23:34:28] ori-l: how can I verify that that format is the right one? e.g. where is it parsed. [23:34:51] it seems a convention in general for such headers, but where is this one in particular used [23:35:11] hmm, phpstorm is nice, except when it decides to lock up [23:35:17] Krinkle: nowhere yet, though the patch to log it is almost ready (i was in the process of testing it) [23:35:23] Krinkle: i'll submit it as a draft and add you as reviewer, hang on [23:36:18] ori-l: nvm, verified it with MWParserEnvironment.prototype.getPerformanceHeader in Parsoid. [23:36:33] usage or 'original' definition, both qualify for me :) [23:36:41] either [23:36:47] cool, thanks [23:37:17] actually, original format by Parsoid is probably worth more points. Silly me. [23:38:13] git grep is nice, I used to never use it because I like ack. But most of the downsides of grep don't apply since it is already reduced to the subset of repo files (even better than ack in terms of subset) [23:38:55] gotta run [23:45:27] (03PS1) 10Legoktm: Remove redundant parentheses [core] - 10https://gerrit.wikimedia.org/r/87922 [23:45:51] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [23:46:57] (03PS2) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [23:47:15] (03PS2) 10Legoktm: Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 [23:47:16] (03CR) 10Yuvipanda: [C: 032] Remove redundant parentheses [core] - 10https://gerrit.wikimedia.org/r/87922 (owner: 10Legoktm) [23:47:35] ty [23:48:17] :) [23:51:10] (03CR) 10Alex Monk: [C: 032] jshint fixes for mw.ConfirmCloseWindow.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86776 (owner: 10MarkTraceur) [23:51:20] (03Merged) 10jenkins-bot: jshint fixes for mw.ConfirmCloseWindow.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86776 (owner: 10MarkTraceur) [23:51:31] (03Merged) 10jenkins-bot: Remove redundant parentheses [core] - 10https://gerrit.wikimedia.org/r/87922 (owner: 10Legoktm) [23:52:49] (03PS3) 10Krinkle: alert: Make selectors less overly specific and clean up js [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 [23:53:09] (03PS3) 10Krinkle: Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 [23:54:46] (03CR) 10Alex Monk: [C: 032] jshint fixes for mw.UploadWizardDescription.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86778 (owner: 10MarkTraceur) [23:55:16] (03Merged) 10jenkins-bot: jshint fixes for mw.UploadWizardDescription.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86778 (owner: 10MarkTraceur) [23:55:26] Krinkle: <3 [23:55:43] marktraceur: don't you mean Krenair? [23:56:01] Also yes [23:56:08] Krenair: <3 [23:56:14] :D [23:56:25] those were the easiest ones. It's almost 1AM so I should go... [23:57:48] (03PS4) 10Krinkle: Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 [23:57:57] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [23:58:20] (03CR) 10Siebrand: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [23:59:10] (03CR) 10Siebrand: [C: 031] "L10n change reviewed." [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [23:59:58] (03CR) 10MZMcBride: "I think you'll have to re-do this as LESS. :-/" [core] - 10https://gerrit.wikimedia.org/r/50594 (owner: 10Isarra)