[00:00:20] ori-l: If you have control over the reference, you could do yours = $.Deferred(), and jqxhr = $.when(jqxhr, yours); [00:01:03] (03PS5) 10MarkTraceur: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 [00:01:09] ori-l: Hm.. what do you mean 1 tick after readyState === 4 [00:01:31] from which callback are you reading readyState [00:01:49] (03CR) 10MarkTraceur: "Krinkle, the tests are ready for re-review." [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [00:02:00] (03PS15) 10GWicke: Adding mathoid as tex to MathML and SVG renderer [extensions/Math] - 10https://gerrit.wikimedia.org/r/87611 (owner: 10Physikerwelt) [00:02:02] Krinkle: $.get('..').done( function () { /* no resource timing information available here */ } ); [00:02:32] Krinkle: $.get('..').done( function () { setTimeout( function () { /* resource timing information *is* available here */ }, 0 ); } ); [00:03:43] (03PS16) 10GWicke: Adding mathoid as tex to MathML and SVG renderer [extensions/Math] - 10https://gerrit.wikimedia.org/r/87611 (owner: 10Physikerwelt) [00:05:59] (03CR) 10Physikerwelt: [C: 032 V: 032] "Tested and works now." [extensions/Math] - 10https://gerrit.wikimedia.org/r/87611 (owner: 10Physikerwelt) [00:08:02] ori-l: How is resource timing data exposed for xhr's ? [00:09:05] performance.getEntries* [00:09:21] try checking performance.getEntriesByType('resource').length a) before xhr, b) in done, c) immediately after done [00:09:54] this assumes that that the page is otherwise quiet; obviously if you have multiple requests going off at once all bets are off [00:11:40] i wonder if i could do this with a custom $.ajaxTransport() [00:12:26] ori-l: http://cl.ly/image/403F0T2B0t3m [00:12:32] indeed, annoying [00:12:47] i know, right?!@#190283 [00:12:57] seems like a pretty obvious fucking hole in the spec [00:13:12] or a chrome bug [00:13:33] * ori-l rages [00:13:35] isn't there an event? [00:13:41] no :( [00:13:52] "check back soon" [00:14:01] ori-l: There is performance.addEventListener though I guess it doesn't have many useful events [00:14:12] but I can't imagine Dev Tools doing a lazy poll either [00:14:20] but they might have a deeper API [00:19:30] ori-l: what's the context for this btw, any xhr in particular you're measuring? [00:21:17] Krinkle: no, was trying to implement a generic thing [00:21:23] (03PS6) 10MarkTraceur: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 [00:21:26] k [00:26:08] (03PS3) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [00:26:39] thanks for confirming [00:27:37] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [00:55:33] So EditPage::getCopyrightWarning returns wikitext…but HTMLForm wants raw HTML. Is there a function go from wikitext-->HTML (i dont want to do all the $wgParser calls myself…)? [00:55:52] Your ellipses are Unicode. [00:56:01] i'd use $out->addWikiText except it adds it at the top instead of inside the form [00:56:15] Elsie: yeah, its an OSX thing [00:57:25] This I know. [00:59:57] http://cl.ly/image/0A2Q1D0C011r [01:00:09] i'm not a fan of where it is [01:01:35] Yeah, probably should be near the send button. [01:02:05] erg [01:02:08] html form sucks [01:02:23] Urgh. [01:05:33] ok [01:05:40] so we can put it after the send button. [01:06:30] if we want it inside the fieldset though, we need to parse the message ourself. [01:06:31] argh [01:07:39] http://cl.ly/image/170I122w2o30 [01:17:23] Elsie: http://cl.ly/image/273q3X1p3Y2I [01:18:42] It's ugly, but whatever. [01:19:18] What's the parsing issue? [01:19:32] There's a wrapper function for getting the copyright info, isn't there? [01:19:42] Whatever MatmaRex mentioned. [01:19:46] HTMLForm wants everything as HTML, but EditPage::getCopyrightWarning returns wikitext [01:20:00] getCopyrightWarning could have an HTML flag, couldn't it? [01:20:15] Or HTMLForm could be less silly. [01:20:22] Perhaps ask Ori. [01:20:32] it doesnt, and getCopyrightWarning doesnt interact with the parser at all [01:20:36] it just figures out the message name [01:20:36] I suppose HTMLForm only accepting HTML isn't unreasonable. [01:21:14] So when does it get parsed? [01:21:20] In the edit form? [01:21:52] well normally you can jsut do $output->addWikiText [01:22:02] except since this is HTMLForm, we can't >.> [01:22:43] Aren't you already calling the parser? [01:22:46] On form submission? [01:23:07] yes [01:23:09] You have to render a preview. That can't also render the footer? [01:23:15] not at the same time [01:23:18] Gay. [01:23:20] i dont think its a performance issue [01:23:51] I just have to copy OutputPage::addWikiTextTitle to work outside of the OutputPage class [01:23:56] bbl in 10 [01:34:04] * varnent would like to be one of the first 100 told if our servers ever turn gay [01:55:40] (03PS1) 10Lambdafu: Fix #switch #default to match next (not last) named parameter. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 [02:00:13] (03PS1) 10Legoktm: Add EditPage::getCopyrightWarning before "Send" button [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 [02:00:37] (03PS1) 10Physikerwelt: Fix: Glyphs are not copied [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 [02:01:37] (03CR) 10Legoktm: "Example screenshot: http://cl.ly/image/362L1X2q3S2u" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm) [02:02:53] Elsie: ^ [02:03:20] (03PS2) 10Physikerwelt: Fix: Glyphs are not copied [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 [02:03:43] legoktm, thanks for quickly working through all the stuff discussed in the bugs :) [02:03:59] no problem! [02:11:38] (03PS3) 10Physikerwelt: Fix: Glyphs are not copied [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 [02:12:21] (03CR) 10Physikerwelt: [V: 031] "so now it seems to work" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 (owner: 10Physikerwelt) [02:24:04] (03PS1) 10Lambdafu: Do not crash on invalid codepoint references in style attributes. [core] - 10https://gerrit.wikimedia.org/r/87648 [02:35:57] (03PS1) 10TTO: Make edit toolbar Signature button optional in content namespaces [core] - 10https://gerrit.wikimedia.org/r/87649 [03:30:23] (03PS4) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [03:30:47] (03PS5) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [03:30:54] (03CR) 10Legoktm: "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [03:31:15] (03PS6) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [03:31:31] (03CR) 10Legoktm: "PS6 was a rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [03:33:53] (03CR) 10Aaron Schulz: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [03:49:46] (03PS1) 10Aaron Schulz: Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 [03:50:58] (03CR) 10jenkins-bot: [V: 04-1] Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [03:54:15] (03CR) 10Legoktm: "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm) [03:54:36] (03PS11) 10Legoktm: Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [03:55:27] (03PS2) 10Aaron Schulz: Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 [04:29:14] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [04:36:32] (03PS1) 10Rfaulk: fix - staging files in _dulwich_stage_all. [sartoris] - 10https://gerrit.wikimedia.org/r/87651 [04:36:53] (03CR) 10Rfaulk: [C: 032 V: 032] fix - staging files in _dulwich_stage_all. [sartoris] - 10https://gerrit.wikimedia.org/r/87651 (owner: 10Rfaulk) [04:41:24] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [04:54:29] (03PS4) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [04:54:37] (03CR) 10jenkins-bot: [V: 04-1] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [04:59:19] (03PS5) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [05:00:26] woot :D [05:06:51] (03PS6) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [05:07:10] (03PS4) 10Physikerwelt: Fix: Glyphs are not copied [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 [05:12:09] (03CR) 10Physikerwelt: [V: 04-1] "This still does not work." [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 (owner: 10Physikerwelt) [05:44:32] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [05:50:13] (03CR) 10Aaron Schulz: [C: 032] Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [05:50:38] (03CR) 10jenkins-bot: [V: 04-1] Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [05:52:25] (03PS3) 10Ori.livneh: Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 [05:53:41] Thanks Aaron; I appreciate that you took the time to look this over. [05:54:42] (03CR) 10Aaron Schulz: [C: 032] Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [05:55:21] * Aaron|home listens to http://www.youtube.com/watch?v=DWfY9GRe7SI [05:57:35] (03Merged) 10jenkins-bot: Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [05:57:57] doesn't load for me, for some reason [05:58:45] * ori-l contemplates fixing zuul so that it knows how to deal with RELEASE-NOTES [05:59:12] i have a small aneurysm every time that happens [06:38:28] (03PS1) 10Ebrahim: Reversed question mark for RTL languages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87654 [06:49:37] ori-l: deal as in rebase? [07:00:17] (03CR) 10Nemo bis: "Thank you for your patch, there are some feature requests which I imagine using this." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [07:47:53] (03CR) 10Nikerabbit: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86974 (owner: 10Manybubbles) [07:48:38] (03CR) 10Nikerabbit: "Why CR-2?" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 (owner: 10Nemo bis) [07:51:57] (03CR) 10Nemo bis: "Nikerabbit, 2013-10-01 19.20 < siebrand> Nemo_bis: I want to take a very good look at it, and block anyone from merging it before that's d" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 (owner: 10Nemo bis) [08:06:58] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87187 (owner: 10Anomie) [08:11:55] (03CR) 10Liangent: "(1 comment)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:26:35] (03PS1) 10Umherirrender: Move release note for meta=filerepoinfo into api section [core] - 10https://gerrit.wikimedia.org/r/87655 [08:26:58] (03CR) 10Umherirrender: "Release note is in the wrong section, moved to api section in patch set I83e393aca85ae215f515024322942acafa20462b" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur) [09:16:36] (03PS1) 10Nemo bis: Use a more standard "Forgot your password?" in userlogin-resetpassword-link [core] - 10https://gerrit.wikimedia.org/r/87656 [09:26:26] (03PS1) 10Rfaulk: add - methods _git_commit_list, _dulwich_status. [sartoris] - 10https://gerrit.wikimedia.org/r/87657 [09:26:27] (03PS1) 10Rfaulk: add/fix - _git_revert / revert functionality. [sartoris] - 10https://gerrit.wikimedia.org/r/87658 [09:26:28] (03PS1) 10Rfaulk: mod - update readme. [sartoris] - 10https://gerrit.wikimedia.org/r/87659 [09:26:29] (03PS1) 10Rfaulk: mod - ensure that commit sha matches tag commit sha on rollback / make _dulwich_reset_to_tag default reset to HEAD. [sartoris] - 10https://gerrit.wikimedia.org/r/87660 [09:26:32] (03CR) 10jenkins-bot: [V: 04-1] add - methods _git_commit_list, _dulwich_status. [sartoris] - 10https://gerrit.wikimedia.org/r/87657 (owner: 10Rfaulk) [09:26:44] (03CR) 10jenkins-bot: [V: 04-1] add/fix - _git_revert / revert functionality. [sartoris] - 10https://gerrit.wikimedia.org/r/87658 (owner: 10Rfaulk) [09:29:23] (03CR) 10Rfaulk: [C: 032 V: 032] add - methods _git_commit_list, _dulwich_status. [sartoris] - 10https://gerrit.wikimedia.org/r/87657 (owner: 10Rfaulk) [09:29:29] (03CR) 10jenkins-bot: [V: 04-1] add - methods _git_commit_list, _dulwich_status. [sartoris] - 10https://gerrit.wikimedia.org/r/87657 (owner: 10Rfaulk) [09:30:13] (03CR) 10Rfaulk: [C: 032 V: 032] add/fix - _git_revert / revert functionality. [sartoris] - 10https://gerrit.wikimedia.org/r/87658 (owner: 10Rfaulk) [09:30:27] (03CR) 10Rfaulk: [C: 032 V: 032] mod - update readme. [sartoris] - 10https://gerrit.wikimedia.org/r/87659 (owner: 10Rfaulk) [09:30:47] (03CR) 10Rfaulk: [C: 032 V: 032] mod - ensure that commit sha matches tag commit sha on rollback / make _dulwich_reset_to_tag default reset to HEAD. [sartoris] - 10https://gerrit.wikimedia.org/r/87660 (owner: 10Rfaulk) [09:44:05] (03PS1) 10Tpt: Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 [09:44:43] (03PS14) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [09:56:59] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm) [10:06:22] (03CR) 10Yuvipanda: "Upon learning of the way varnish does logs (varnish newbie here!), I think we shouldn't log varnish output to /vagrant/logs. If people wan" [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda) [10:07:16] (03PS4) 10Yuvipanda: [HEAVY WIP] Add varnish role [vagrant] - 10https://gerrit.wikimedia.org/r/87623 [10:30:59] (03PS1) 10Mattflaschen: Fixes of current logging, and cleanup of out of date code [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 [10:32:39] (03CR) 10Mattflaschen: "On piramido for testing. Please also cross-check with the updated schema (doc changes only) at https://meta.wikimedia.org/wiki/Schema:Get" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [10:40:17] Nemo_bis: the config file name is hardcoded into the bot. so https://gerrit.wikimedia.org/r/#/c/87663/1 needs a change in the bot too, to work [10:40:29] Nemo_bis: submit that if you can, if not I'll take a shot later [10:40:54] for some definition of later - heading to a clinic to check up on my hand/wrist, so might not be too responsive [11:12:27] YuviPanda|zzz: yes, I thought the name was hardcoded but you convinced me I only had to upload a config ;) [11:12:39] And I'm glad you're taking care of the wrist, good luck [11:41:36] (03PS1) 10Shirayuki: Fix spelling (occurred) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87668 [12:25:31] @seen qgil [12:25:31] liangent: Last time I saw qgil they were quitting the network with reason: Quit: Leaving N/A at 10/4/2013 10:11:58 PM (14h13m33s ago) [12:37:02] @notify qgil [12:37:02] I'll let you know when I see qgil around here [13:01:37] (03CR) 10Aklapper: [C: 031] Misc. CSS typo fixes; Firefox compatibility fixes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86884 (owner: 10Aklapper) [13:02:45] (03CR) 10Aklapper: [C: 04-1] "Needs more iterations after feedback from design team. See items in bug report. -1" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper) [13:25:49] (03CR) 10Aklapper: [C: 04-1] "Yeah, using Firefox' "Style Editor" and disabling our custom CSS file there's no difference whatsoever in rendering of https://bugzilla.wi" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/87057 (owner: 10Aklapper) [13:58:38] (03CR) 10Addshore: [C: 031] installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 (owner: 10Hashar) [14:06:45] (03CR) 10Stwalkerster: "I'm planning on using it myself with en:WP:ACC :P" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [14:27:41] (03PS2) 10Addshore: (bug 54980) Remove toolbox UserRights if anon user [core] - 10https://gerrit.wikimedia.org/r/87672 [14:38:37] (03CR) 10Hoo man: [C: 04-1] "(9 comments)" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [14:41:31] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87672 (owner: 10Addshore) [14:44:53] (03PS3) 10Addshore: (bug 54980) Remove toolbox UserRights if anon user [core] - 10https://gerrit.wikimedia.org/r/87672 [14:48:52] (03CR) 10Hoo man: [C: 032] (bug 54980) Remove toolbox UserRights if anon user [core] - 10https://gerrit.wikimedia.org/r/87672 (owner: 10Addshore) [14:51:46] (03Merged) 10jenkins-bot: (bug 54980) Remove toolbox UserRights if anon user [core] - 10https://gerrit.wikimedia.org/r/87672 (owner: 10Addshore) [15:12:44] (03PS1) 10Santhosh: Number format the translation and proofread stats of user [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87675 [15:20:15] (03PS1) 10Jack Phoenix: Fix SystemGifts' CSS and backlink on Special:ViewSystemGift. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/87677 [15:21:04] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix SystemGifts' CSS and backlink on Special:ViewSystemGift. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/87677 (owner: 10Jack Phoenix) [15:29:45] (03PS1) 10Santhosh: Set an explicit line height for stats number [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87679 [15:36:11] (03CR) 10Siebrand: [C: 032] Number format the translation and proofread stats of user [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87675 (owner: 10Santhosh) [15:36:20] (03Merged) 10jenkins-bot: Number format the translation and proofread stats of user [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87675 (owner: 10Santhosh) [15:36:45] (03CR) 10Siebrand: [C: 032] Set an explicit line height for stats number [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87679 (owner: 10Santhosh) [15:36:52] (03Merged) 10jenkins-bot: Set an explicit line height for stats number [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87679 (owner: 10Santhosh) [15:37:13] (03CR) 10Siebrand: [C: 032] Moving shared code to mediawiki-selenium Ruby gem [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87542 (owner: 10Zfilipin) [15:37:18] (03Merged) 10jenkins-bot: Moving shared code to mediawiki-selenium Ruby gem [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/87542 (owner: 10Zfilipin) [15:42:57] (03CR) 10MZMcBride: "Have you tested this changed? The presence of interlanguage links is context-dependent: "[[en:hello]]" on a subject-space page acts differ" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [15:44:13] (03CR) 10MZMcBride: "s/changed/change/ && s/different/differently/" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [15:55:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [16:36:19] (03CR) 10MZMcBride: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm) [17:01:42] (03PS10) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [17:17:48] anyone here could answer a question concerning echo? [17:17:49] !ping [17:17:50] Pong. [17:17:51] .ping [17:25:42] Maybe. [17:26:09] You'll never know unless you ask the question... [17:27:22] T13|: well in our local pub (NLwiki) a question was asked wheter it's possible to add other notifications to echo (such as title changes/deletions) [17:28:15] Those show up on watchlists, why would there be notifications too? [17:28:39] i dont know but would it be possible? [17:29:19] Anything is 'possible', but I don't see the use case. [17:29:43] neither do I, but I thought let's ask [17:29:55] So I think you'd have a hard time convincing developers to implement it. [17:30:04] indeed [17:31:20] I suppose you could request it on Bugzilla if you really wanted to be certain. [17:32:01] too much effort for me, i was just wondering nothing special [17:32:08] https://nl.wikipedia.org/wiki/Wikipedia:De_kroeg#Extra_mogelijkheden_met_het_notificatiesysteem [17:32:15] oh you can't read that :( [17:32:41] I can't. [17:33:28] but thx for the help [17:34:15] I'd say add page to watchlist and make sure notify when something on my watchlist is changed is best case there [17:35:08] fully agree with that [17:49:55] siebrand: Nemo_bis deployed [17:50:08] grrrit-wm: wb [18:03:25] (03PS2) 10Tpt: Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 [18:25:25] (03CR) 10Legoktm: "Right, it is context dependent, but the issue is we don't have that context. So it's safer to assume that one of the pages might be a non-" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [18:25:40] (03PS3) 10Legoktm: Check for unescaped language links [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 [18:59:50] (03PD2) 10Wikinaut: problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 [19:06:26] (03PS3) 10Wikinaut: problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 [19:06:48] (03PD3) 10Wikinaut: problem fix w/ label text preferences tab; inverted hide/show OpenID property and default [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 [19:08:38] (03CR) 10Wikinaut: [C: 031 V: 031] "Siebrand, please can you help and code-review this, it fixes the reported https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Op" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87689 (owner: 10Wikinaut) [19:08:49] (03PS3) 10Rtdwivedi: Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 (owner: 10Tpt) [19:28:37] (03CR) 10Tpt: "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 (owner: 10Tpt) [19:34:26] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [19:35:44] (03CR) 10Bartosz Dziewoński: [C: 031] Replacing Function.prototype.bind with anonymous function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke) [19:37:40] MatmaRex: No +2+ [19:37:41] ? [19:39:35] (03CR) 10Yuvipanda: [C: 032] Replacing Function.prototype.bind with anonymous function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke) [19:39:45] (03Merged) 10jenkins-bot: Replacing Function.prototype.bind with anonymous function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke) [19:39:52] tyg, marktraceur [19:40:09] marktraceur: i'm too tired to match parentheses right now. :P [19:40:17] Grazie, YuviPanda [19:40:19] (03CR) 10Ori.livneh: [C: 032] mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Bartosz Dziewoński) [19:40:27] hey OrenBochman [19:40:28] err [19:40:29] ori-l: [19:40:39] (03PS4) 10Ori.livneh: mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Bartosz Dziewoński) [19:40:48] poor oren [19:40:58] poor ori [19:40:58] hi yuvi [19:41:06] ori-l: thoughts on the varnish patch? [19:41:08] or is it NOTTODAY [19:41:17] i looked at it; it looks too big [19:41:28] that's a lot of VCL; i'm not sure what parts of it are the default [19:41:33] yay, a +2, thanks ori-l [19:41:42] ori-l: that's just copy pasted vcl from mw.org [19:41:56] oh, and it's gone [19:41:56] ori-l: should put a link to it there, I think [19:42:00] easy come, easy go, eh. [19:42:05] MatmaRex: I forgot to rebase [19:42:12] I'll +2 it again [19:42:17] it has two unmerged dependencies anyway [19:42:20] (03CR) 10Ori.livneh: [C: 032] mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Bartosz Dziewoński) [19:42:28] ah, no [19:42:32] th eother way [19:42:36] did i mention i'm tired. [19:42:42] yeah, I worked my way back :P [19:42:54] (03PS8) 10Ori.livneh: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [19:43:06] there should be a clear separation between a module that gives a puppet API for setting up varnish and the actual configs for it [19:43:17] anyways, I need to look at it more carefully [19:43:32] ori-l: right, I guess this isn't too useful as is if you want to hack *on* varnish [19:43:56] but in general you should write the best patch you can and then solicit feedback :P [19:44:05] ori-l: right :P [19:44:25] it's hard to know how much time to investment in identifying and pointing out issues since the 'WIP' tag indicates that you presumably are aware of some issues already [19:44:31] *to invest [19:44:39] ori-l: I like reviews as-i-go, because I don't want to spend time polishing something that then is completely killed [19:44:50] ori-l: hmm, usually when I put a WIP I note the issues in the commit messages [19:44:52] (which I have) [19:45:00] but if you spend time polishing it then it's less likely to be completely killed :P [19:45:41] sure, but doing something with 'no code' is better than doing it with polished code :) [19:45:50] anyway, I'll work on it some more before pinging you again, then. [19:46:01] (03Merged) 10jenkins-bot: mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Bartosz Dziewoński) [19:46:13] thanks; I'm (honestly) thankful you're working on this stuff [19:46:42] :D [19:46:57] MatmaRex: https://gerrit.wikimedia.org/r/#/c/80769/ looks good too but I need to test it one more time [19:47:49] (03PS4) 10Rtdwivedi: Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 (owner: 10Tpt) [19:49:25] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [19:49:26] (03CR) 10Tpt: [C: 032] Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 (owner: 10Tpt) [19:49:35] (03Merged) 10jenkins-bot: Fix a fatal error when the Page image doesn't exit [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87661 (owner: 10Tpt) [19:49:42] ^^ MatmaRex small question inline if you're still around [19:50:29] looking [19:50:56] gerrit decided that it will not load the diff :/ [19:51:02] $template->set( 'loggedin', (bool)$user->isLoggedIn() ); [19:51:05] why the cast to bool? [19:51:06] (03PS1) 10Isarra: Add link to description page on mw.org [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/87690 [19:51:12] isLoggedIn returns a bool afaict [19:51:31] [10/5/2013 9:51:13 PM] JavaScript - https://gerrit.wikimedia.org/r/gerrit_ui/27D198747A6EDA7FCA86AD1FF0D657DE.cache.html [19:51:32] Inline script compilation [19:51:34] Syntax error at line 5709 while loading: expected ';', got [19:51:35] for (s [19:51:36] wat [19:52:18] ori-l: i don't think i've ever looked at the function, i just simplified the if() that was there before [19:52:38] i like explicit casts [19:52:44] but okay, let's kill that one [19:52:55] i like explicit casts over implicit casts, but there's no implicit cast [19:52:59] you're casting a bool to a bool [19:53:07] :D [19:55:46] wtf is wrong with gerrit today [19:56:03] downloading and checking out that patch took literally 2 minutes [19:57:03] (03PS9) 10Bartosz Dziewoński: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [19:57:07] ori-l: ^ [19:57:23] i don't know, but vaguely related tangent [19:57:35] i looked at zuul yesterday and i think it would be straightforward to make it rebase patches before merging [19:57:47] ori-l: gerrit has that built-in, i believe [19:57:59] and to make it deal with RELEASE-NOTES in a manner that doesn't make you pray for the end of humanity [19:57:59] (or at least ensuring patches not based on master can't merge) [19:58:19] those are two *very* different things :P [19:58:24] ori-l: you aware of https://github.com/MatmaRex/mediawikireleasenotes-driver [19:58:43] uh, wow [19:58:45] that's nice! [19:58:53] it needs someone porting it to java to be deployed on gerrit, though [19:58:54] docs and all [19:59:03] the driver itself is dead simple [19:59:07] no, I don't think so [19:59:24] the merging is done by zuul using git-python [19:59:32] (i mean, my driver is dead simple :) ) [19:59:41] yeah, but you wrote it [20:00:05] just fetching a link for you, hang on [20:00:21] * YuviPanda heads off to Coursera and nursing my wrist [20:00:30] waves [20:00:44] the amount of code I write is going to dimnish from its already low point as i try to do more content consumption, to not tax my hand [20:00:45] sigh [20:01:12] MatmaRex: see http://git.wikimedia.org/blob/integration%2Fzuul.git/ac3ba4fe9f9dace5673a6537ef0d3ccf5a054ac7/zuul%2Fmerger.py#L71 [20:01:17] and [20:01:33] all of http://git.wikimedia.org/blob/integration%2Fzuul.git/ac3ba4fe9f9dace5673a6537ef0d3ccf5a054ac7/zuul%2Fmodel.py [20:02:22] actually model.py is not that useful [20:02:26] it's mostly merger.py [20:02:37] where your work would need to be either integrated or ported [20:03:32] ok, i have to walk the dog, will give your updated patch another run on my dev box and merge it if all looks good [20:03:37] later today, i mean [20:03:39] PDT [20:03:57] yay [20:04:07] hmmm, so zuul doesn't use jgit at all? [20:04:30] no, it does everything locally using vanilla git and python [20:04:33] and then pushes it [20:04:41] at least that's how i understand it, i was just poking around a little last night [20:04:47] hmm. that is actually very sane, dunno why i thought it would [20:04:49] but i'm pretty sure that's right [20:05:03] things like "self.repo.git.merge("FETCH_HEAD")" are just wrappers for sheling out? [20:05:09] yeah [20:05:55] as usual with openstack python abstractions the value they add over the tools they wrap is, um, questionable [20:06:03] * ori-l coughs git-review cough [20:06:05] heh [20:06:06] don't tell them i said that [20:06:13] well, shelling out in pythin is pretty awkward, isn't it? [20:06:56] and in ruby i can do `system *%W[git merge #{variable_with_branch_name}]` and i get escaping and everything for free [20:07:01] (funny syntax, though. :P) [20:07:24] much more awkward than ruby [20:07:26] (03PS1) 10Isarra: CHANGES - ashley this needs a sanity check please. [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87691 [20:07:28] i agree [20:07:37] that's one aspect in which ruby is clearly superior [20:07:46] ok dog is miserable, must go out, bbl [20:07:49] see you [20:09:29] Bahahah I love how kate automatically cleans up extra whitespace. [20:13:45] (03CR) 10Jack Phoenix: [C: 032 V: 032] ""Because we're in core/grabbers instead of core/maintenance" is very confusing to me. I much prefer my somewhat lengthier explanation (the" [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87691 (owner: 10Isarra) [20:15:31] Athyria: ^^ [20:15:37] ashley: Aye, thank you. [20:15:55] now go turn it into a pretty special page that doesn't suck :D [20:16:05] What wouldn't be confusing? Because the images one was shoutwiki-specific, the other one was... not descriptive, this one is also pretty arbitrary... [20:16:23] I thought you were going to make the special page. [20:16:49] I don't want to make a special page. Making special pages is hard... and that's when they're not acting as ridiculous frontends for complete insanity. [20:17:22] Dammit ashley, I'm a graphic designer, not a bloody backend developer. [20:18:13] that's what they all say at first ;-) [20:20:40] You may think that, but why do you think I went into graphic design in the first place? [20:20:50] I was trying to GET AWAY from horrible backend crap. [20:21:36] And egg timers on cocaine, but that's a separate issue. [21:18:38] (03CR) 10MZMcBride: "Okay." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [21:18:58] I'm doing expert code review. [21:19:30] Elsie: MERGE MY CORE PATCHES [21:19:31] (-; [21:19:43] Are any lingering? [21:19:44] I know people. [21:19:56] no, the joke is that I have no core patches :p [21:20:12] https://gerrit.wikimedia.org/r/#/q/owner:%22Jack+Phoenix+%253Cjack%2540countervandalism.net%253E%22+status:open,n,z [21:20:18] Oh. [21:20:20] Well, [21:21:04] * legoktm points Elsie to https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MassMessage,n,z [21:21:16] https://gerrit.wikimedia.org/r/#/c/87509/ is ready for merging [21:21:43] Hah, I forgot you can't self-merge any longer. [21:22:49] I have half of those commits starred. [21:30:49] that's a lot of open changesets. [21:32:35] (03CR) 10Bartosz Dziewoński: [C: 032] Use PROTO_CANONICAL correctly. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87509 (owner: 10Legoktm) [21:32:47] (03Merged) 10jenkins-bot: Use PROTO_CANONICAL correctly. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87509 (owner: 10Legoktm) [21:32:51] thanks :D [21:33:26] https://gerrit.wikimedia.org/r/#/c/87512/ needs a review, reasonably simple [21:33:40] well, if you know how the logformatter works. [21:33:57] (03CR) 10Ori.livneh: "Space above/below text is unequal because p { margin: .4em 0 .5em 0; }" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [21:34:58] (03PS1) 10Legoktm: Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 [21:35:55] ^ MatmaRex [21:36:09] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [21:36:29] legoktm: i have no idea how it works, sadly [21:36:45] ori-l: D: [21:37:18] it's so annoying to have to fix things like that that i didn't even have the heart to -1 [21:37:38] i'm pretty sure it didn't look like that when i tested [21:37:42] but i think we (read: you) should fix it [21:37:56] lemmesee. [21:37:57] oh hrm, let me make absolutely sure it's not a local change that is causing that [21:38:35] yep, clean master [21:39:31] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [21:40:07] ori-l: okay, the margins are unequal, but the box definitely shouldn't be red [21:40:45] http://i.imgur.com/1h0Z4VQ.png [21:42:56] maybe you special-cased your username? :P [21:43:24] it is a 'warningbox', which means yellow, not an 'errorbox' [21:43:28] (03PS10) 10Bartosz Dziewoński: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [21:43:36] (per the changeset you merged a few hours ago :) ) [21:43:44] ori-l: ^ i killed the

[21:43:48] oh, duhhhhh. [21:44:49] yeah, the color is just because i forgot i reset my branch before the merge [21:50:45] (03PS1) 10Legoktm: Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 [21:56:59] (03CR) 10Ori.livneh: "This looks good, but --" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Bartosz Dziewoński) [21:57:36] (03CR) 10Legoktm: "Example usage: https://gerrit.wikimedia.org/r/#/c/87695/" [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [22:06:45] Reedy: https://gerrit.wikimedia.org/r/#/c/86395/ ? [23:30:14] (03PS2) 10Stwalkerster: Add an API module for querying the AntiSpoof results without having to attempt to create an account. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 [23:31:15] (03PS3) 10Stwalkerster: Add an API module for querying the AntiSpoof results without having to attempt to create an account. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 [23:32:49] (03CR) 10Stwalkerster: "@Hoo man - I've fixed the issues you raised, thanks :)" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [23:54:36] (03PS1) 10Physikerwelt: WIP: Ideas to make the node worker more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/87699 [23:55:01] (03CR) 10jenkins-bot: [V: 04-1] WIP: Ideas to make the node worker more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/87699 (owner: 10Physikerwelt)