[00:00:50] (03PS2) 10Cmcmahon: id changed for searchButton in master; also had bogus step [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87292 [00:16:06] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [00:17:13] (03CR) 10Werdna: "I'm still very confused about this ApiQueryRevisionContent API module. What does it do that can't be done generally by ApiQueryFlow?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87291 (owner: 10EBernhardson (WMF)) [00:18:09] (03PS1) 10Mattflaschen: Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/87296 [00:20:33] (03CR) 10Mattflaschen: "Copied from https://gerrit.wikimedia.org/r/#/c/70740/ at Ori's request, so the Gerrit owner could be changed to me." [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [00:20:50] (03CR) 10Mattflaschen: "Moved to https://gerrit.wikimedia.org/r/#/c/87296/ per Ori's request. Sorry for not replying earlier." [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [00:37:37] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [00:38:51] (03CR) 10Parent5446: [C: 04-1] "Agreed with Daniel. Why would a blocked user not be able to purge?" [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [00:40:58] (03CR) 10MZMcBride: "There's no associated bug report, so I guess it's acceptable to discuss here." [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [00:44:34] (03CR) 10Werdna: "(13 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [00:44:37] (03PS1) 10Bsitu: Adding missing message params [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87299 [00:46:03] (03PS4) 10Chad: Minor refactor of ElasticaConnection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 [00:46:51] (03PS2) 10Chad: Add functionality to force connections even if a single one fails [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86719 [00:50:19] (03CR) 10Daniel Friesen: "Purge is not a write action. Quite frankly it's actually closer go being a read action. It's used sometimes on pages using things like SMW" [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [00:50:36] (03CR) 10Springle: [C: 031] Removed more FORCE INDEX clauses for logging [core] - 10https://gerrit.wikimedia.org/r/87168 (owner: 10Aaron Schulz) [00:51:49] (03CR) 10Aaron Schulz: [C: 04-2] "Purge needs rate limiting alone. That should be independent of user blocking, since they are not semantically editing anything (just slowi" [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [00:53:45] (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [00:54:10] (03CR) 10Manybubbles: [C: 032] Minor refactor of ElasticaConnection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [00:55:37] (03CR) 10Manybubbles: [C: 032] Add functionality to force connections even if a single one fails [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86719 (owner: 10Chad) [00:55:39] (03Merged) 10jenkins-bot: Add functionality to force connections even if a single one fails [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86719 (owner: 10Chad) [00:56:07] (03CR) 10Chad: [V: 032] Minor refactor of ElasticaConnection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [00:57:21] (03CR) 10Manybubbles: [C: 032] "Makes sense to me. I'll probably end up replicating this in CirrusSearch as well." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87292 (owner: 10Cmcmahon) [01:01:42] (03CR) 10Reedy: "Why should a blocked user be able to purge?" [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [01:03:54] (03CR) 10Reedy: ""Purge is not a write action. Quite frankly it's actually closer go being a read action. It's used sometimes on pages using things like SM" [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [01:04:21] (03CR) 10Aaron Schulz: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [01:04:50] (03CR) 10EBernhardson (WMF): "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [01:06:26] (03PS2) 10Reedy: Add page purge limiter [core] - 10https://gerrit.wikimedia.org/r/87269 [01:06:41] (03CR) 10EBernhardson (WMF): "Would make sense, probably mw.flow.api.readBlock ?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87291 (owner: 10EBernhardson (WMF)) [01:06:44] (03PS1) 10PleaseStand: Remove $wgBlockOpenProxies [core] - 10https://gerrit.wikimedia.org/r/87302 [01:12:07] (03PS2) 10PleaseStand: Remove $wgBlockOpenProxies [core] - 10https://gerrit.wikimedia.org/r/87302 [01:13:16] (03PS1) 10Chad: Forgot to unmark these static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87303 [01:13:36] (03CR) 10Chad: [C: 032 V: 032] Forgot to unmark these static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87303 (owner: 10Chad) [01:17:54] (03CR) 10Werdna: "Yeah, that's the code I wrote for that. I think when Matthias implemented the editor change he didn't know about it. Maybe today I should " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87291 (owner: 10EBernhardson (WMF)) [01:23:30] (03CR) 10Daniel Friesen: "It is a read action in the reader/editor context. We're not talking about read-only mode here. Readers and blocked users are blocked from " [core] - 10https://gerrit.wikimedia.org/r/87268 (owner: 10MaxSem) [01:26:30] (03PS1) 10Catrope: Update VisualEditor to wmf19 branch to pick up cherry-pick of Ia585b42 [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87305 [01:45:55] (03CR) 10Werdna: "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [02:19:47] (03CR) 10Werdna: "Doesn't look like you've added something to AbuseFilterVariableHolder to actually generate the PST'd wikitext?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [02:23:40] (03CR) 10Liangent: "It's already there." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [02:28:11] (03CR) 10Werdna: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 (owner: 10Bsitu) [02:28:53] (03CR) 10Werdna: [C: 032] "Oops, thanks for catching this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87299 (owner: 10Bsitu) [02:28:58] (03Merged) 10jenkins-bot: Adding missing message params [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87299 (owner: 10Bsitu) [03:08:39] (03PS1) 10Physikerwelt: Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 [03:08:53] (03CR) 10jenkins-bot: [V: 04-1] Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 (owner: 10Physikerwelt) [03:11:12] (03PS1) 10Legoktm: Add public getters for special page variables [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87310 [03:11:13] (03PS1) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [03:11:44] Elsie: ^ [03:12:19] legoktm: Neat. [03:21:08] what, no JSON namespace? [03:22:45] for what? [03:23:41] (03PS1) 10Mattflaschen: Update README and clarify licensing [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/87312 [03:23:42] <^d> We really should just add a core NS_JSON for all this silly json people write nowadays ;-) [03:26:14] (03PS3) 10Werdna: Attach workflows to non-existent titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:26:16] (03CR) 10jenkins-bot: [V: 04-1] Attach workflows to non-existent titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:28:58] (03PS4) 10Werdna: Attach workflows to non-existent titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:36:05] (03CR) 10Werdna: [C: 04-1] "PS4: Rebase, corrected spelling in the commit message, and took advantage of it by making nonexistent talkpages occupied." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:38:46] (03PS1) 10Legoktm: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 [03:38:50] Isarra: ^ [03:40:02] Yay! [03:40:24] Do I need to test it now? [03:40:27] yeah [03:40:37] i'm not sure if i need to add a $dbw->commit() [03:40:50] Ideally it would do multi inserts [03:40:53] lemme fix that. [03:40:55] I have no idea! [03:41:37] (03CR) 10Werdna: [C: 032] "Never mind, I didn't update my database." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:41:42] (03Merged) 10jenkins-bot: Attach workflows to non-existent titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87258 (owner: 10EBernhardson (WMF)) [03:43:25] (03PS2) 10Legoktm: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 [03:43:44] Isarra: ^ try that version [03:44:12] (03CR) 10Werdna: [C: 032] Prevent recalculation of UUID representations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87021 (owner: 10EBernhardson (WMF)) [03:44:17] (03Merged) 10jenkins-bot: Prevent recalculation of UUID representations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87021 (owner: 10EBernhardson (WMF)) [03:45:09] Okay. [03:45:15] legoktm: How do I download that? >.> [03:45:28] git review -d 87313 [03:48:15] * Isarra beats legoktm over the head with an include path. [03:48:22] :/ [03:48:28] I just copied that from one of the other scripts [03:48:58] Must have been the wrong one. [03:49:00] Oh well. [03:49:06] fix plz? :D [03:50:00] * Isarra beats legoktm over the head with output. [03:50:06] heh [03:50:12] i dont think there is any. [03:50:17] There isn't. [03:50:18] Anywhere. [03:50:47] Nothing happened. [03:53:43] legoktm: Different wikis call groups all manner of things. Any way to get anything that isn't just *? [03:53:50] Er, just * and user. [03:54:07] I suppose you'd need to get a list of valid user groups first [03:54:10] Which can be done [03:54:32] shouldn't be that hard... [03:54:43] Please do. [03:54:57] * Isarra adds output everywhere. [03:57:31] https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=usergroups&format=jsonfm [03:58:17] Can we forcibly make folks autoconfirmed? [03:58:27] Not sure. [03:58:35] Be neat if we could. [03:58:54] (03PS9) 10Werdna: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 (owner: 10Bsitu) [03:59:12] Isarra: I think that enwiki has a group for that [03:59:27] <^d> You can change autoconfirmed settings, or create a group with the same settings and hand it out (like some wikis have done) [03:59:28] There's a confirmed user group on some wikis, yeah. [03:59:36] Aye, there's confirmed, but what if you want to actually make people autoconfirmed directly? [03:59:36] <^d> But the point of autogroups is the *auto* bit :) [03:59:41] (03CR) 10Werdna: "PS9: Addressed my comments from PS8." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 (owner: 10Bsitu) [03:59:46] ^d: we're importing users from another wiki [03:59:57] so users who are autoconfirmed there should be autoconfirmed on our wiki [04:00:01] Basically when inserting them into a new wiki, they loose their autoconfirmedness. [04:00:05] <^d> Then make a group with the same rights as autoconfirmed and grant it to them. [04:00:07] indeed. [04:00:16] Or just wait a few days? [04:00:19] well, you could also toy with their account data to make them meet the requirements [04:00:20] <^d> Or that :) [04:00:21] But then there's an extra group and it's messy. [04:00:30] or you could adjust the autoconfirmed requirements. [04:00:35] Even temporarily. [04:00:38] <^d> Well there's a couple of options available to you :) [04:00:44] they're quire flexible. [04:00:44] You could make autoconfirmed 0 days for four days. [04:00:50] We have spambot problems, though. [04:00:50] Or whatever. [04:00:54] * Elsie shrugs. [04:00:56] So that's not a very good option. [04:00:57] Actions have consequences. [04:01:01] Pick your poison. [04:01:01] Ayuh. [04:01:05] * Isarra poisons Elsie. [04:01:12] Now the other cheek. [04:01:20] * Isarra poisons the other cheek. [04:01:28] Aren't you a bit young for botox? [04:04:12] (03PS3) 10Legoktm: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 [04:04:13] legoktm: For some reason the script is just dying. Isn't saying anything, just... splat. [04:04:23] :/ [04:04:24] well [04:04:30] is it inserting? [04:04:37] how many users does this wiki have? [04:04:44] I mean it's not even getting past the class setup. [04:04:45] it might be able to get them all in one request [04:04:51] oh [04:05:11] Oh, nevermind. [04:05:43] Maintenance needs maintenance stuff. [04:06:57] It needs... error handlinh. [04:07:01] * Isarra pokes it. [04:08:14] l [04:08:18] legoktm: [04:08:20] Query: INSERT INTO `user_groups` (ug_user,ug_group) VALUES ('19','sysop'),('459','sysop'),('57','sysop'),('474','phantom'),('474','sysop'),('2','manager'),('2','sysop'),('2','bureaucrat'),('2','checkuser'),('2','manager'),('2','bureaucrat'),('2','sysop'),('2','checkuser'),('632','phantom'),('632','sysop'),('3','sysop'),('16','bureaucrat'),('16','bureaucrat'),('16','sysop'),('16','sysop'),('36','Phantom'),('36','sysop'),('6','checkuser'),('6','sysop') [04:08:22] ,('6','bureaucrat'),('6','checkuser'),('6','bureaucrat'),('6','sysop'),('13','sysop'),('4','sysop') [04:08:24] Function: DatabaseBase::insert [04:08:27] Error: 1062 Duplicate entry '2-manager' for key 'ug_user_group' (localhost) [04:08:31] errrrrrrrr [04:08:43] i wonder how we make it do an insert ignore [04:09:13] Or just have it only add things to the array once, but an ignore might be faster, inded. [04:09:15] e [04:10:09] Is there any way to diff two pachsets with gerrit? >.< [04:10:14] yes [04:10:24] Reference version: [04:10:33] in that select box, choose the one you want to diff with [04:10:50] Eh? [04:11:18] h. [04:11:20] A [04:11:27] http://cl.ly/image/282f2K1f352M [04:12:18] (03PS4) 10Legoktm: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 [04:12:24] ^ that should fix tie ignore issue [04:12:27] the* [04:14:29] Bloody gerrit. [04:15:43] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [04:16:53] Okay, that worked. [04:17:07] How do I, er, push this thing back now? [04:17:17] Also what if the user ids changed since the import? [04:17:38] But that's stupid. Why should they? [04:18:06] ...because if we're using a dump, we can't guarantee it was made from a sane configuration? [04:18:22] * Isarra clings to the API. [04:19:07] (03PS5) 10Isarra: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 (owner: 10Legoktm) [04:19:45] woot [04:19:47] LGTM [04:20:04] Agh dammit I suck at this. [04:20:37] LGTM? [04:20:43] (03PS6) 10Isarra: convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 (owner: 10Legoktm) [04:20:54] IF I SCREWED UP THAT ONE TOO JUST SHOOT ME. [04:20:57] Isarra: it means "let's get those motherf-" [04:21:03] Ah. [04:21:16] no, it's "looks good to me" [04:21:27] Oh. [04:21:34] But that was the screwed up one. [04:21:37] I screwed that up! [04:22:00] Sorry. [04:23:04] Agh how do you use this horrible thing? [04:23:27] Bloody gerrit. [04:23:30] * Isarra collapses on legoktm. [04:27:07] What are you trying to do? [04:27:13] * Jasper_Deng_busy lifts Isarra off legoktm [04:27:24] (falling on legos isn't exactly painless) [04:27:29] I'unno. [04:27:36] Can you merge that or whatever? [04:27:58] * Isarra sticks a lego up Jasper_Deng_busy's nose. [04:28:05] sure [04:28:13] (03CR) 10Legoktm: [C: 032 V: 032] convert user_groups_table.py into PHP [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87313 (owner: 10Legoktm) [04:29:37] * Jasper_Deng_busy sneezes [04:30:12] lego snot. [04:30:25] o.O [04:30:45] Did that eat my thingy? [04:30:50] There was a thingy. [04:31:10] I mean, I made a change to another file. >.> [04:31:29] bbl [04:37:05] (03PS2) 10Physikerwelt: Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 [04:37:15] (03CR) 10jenkins-bot: [V: 04-1] Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 (owner: 10Physikerwelt) [05:08:19] at last https://gerrit-review.googlesource.com/#/c/50460/ [05:08:30] ^d: ^ [05:11:43] <^d> Hehe [05:19:52] When it says a maintenance script is only to be run from the command line, how important is that? [05:22:17] Isarra: "important" is a nebulous word. What script? [05:22:41] Something to rebuild the database. [05:22:47] Er, the secondary tables. [05:22:50] Links? [05:23:03] Or was it rebuildall? [05:24:02] Oh, interesting... have these things gotten smarter? [05:24:03] <^d> All the maintenance scripts are meant to be run from the command line. [05:24:20] <^d> In fact, none of them should work from the web, they should all abort if PHP_SAPI != cli [05:24:39] Hmm... [05:24:49] So I need to find a way to go around that? *shifty eyes* [05:26:07] Isarra: If there's something that you think should be run from the web, either use the class/function that's being called from the script or refactor the nastily script-only bits into an includes/ file. [05:26:55] (03CR) 10GWicke: "(3 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 (owner: 10Physikerwelt) [05:27:02] Well, generally speaking these shouldn't be run from the web, but... [05:27:46] But sometimes you get tired of having to ssh into the server to run 20 scripts that take three weeks to finish and you want a damn interface where you can just press a button and then wander off and come back and oggle it. [05:27:51] <^d> eval.php, the tool to run anything you want :) [05:28:05] * Isarra grins. [05:28:26] <^d> Isarra: If you're running things that take a long time, have you considered something like screen? [05:28:32] <^d> Then you don't have to stay connected. [05:28:57] I don't want to ssh in at all. [05:29:04] I want a BUTTON. [05:29:22] (03PS1) 10Werdna: Deprecate ApiQueryRevisionContentFlow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 [05:29:30] (03CR) 10jenkins-bot: [V: 04-1] Deprecate ApiQueryRevisionContentFlow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 (owner: 10Werdna) [05:29:31] But that would require some way for the button to tell something else to off and just go... [05:29:50] Right. [05:29:59] * Isarra puts a button on Elsie. [05:30:02] (03CR) 10Chad: "I love how you're deprecating something in an extension that's not even complete yet ;-)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 (owner: 10Werdna) [05:30:13] ^d: :D [05:30:30] <^d> :) [05:30:35] ^d: The fun part is that actually in all cases when it was called, the data being requested was already in memory [05:32:08] (03CR) 10Werdna: [C: 04-2] "I think this is superseded by I834ab83e532b14c957d629e1a2de161b1180d9ca" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87291 (owner: 10EBernhardson (WMF)) [05:42:30] (03PS2) 10Werdna: Deprecate ApiQueryRevisionContentFlow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 [05:51:34] (03CR) 10Physikerwelt: "I can remove them. But what's about the jshint warning. I tried to remove them all. But I could not get rid or the last one." [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 (owner: 10Physikerwelt) [05:52:16] * Elsie wraps Isarra in a large grey hoodie. [05:54:25] (03PS3) 10Physikerwelt: Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 [05:54:34] (03CR) 10jenkins-bot: [V: 04-1] Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 (owner: 10Physikerwelt) [06:30:56] (03CR) 10Springle: [C: 032] Removed more FORCE INDEX clauses for logging [core] - 10https://gerrit.wikimedia.org/r/87168 (owner: 10Aaron Schulz) [06:34:04] (03Merged) 10jenkins-bot: Removed more FORCE INDEX clauses for logging [core] - 10https://gerrit.wikimedia.org/r/87168 (owner: 10Aaron Schulz) [06:34:20] (03PS1) 10PleaseStand: Use HPHP_VERSION constant to detect HipHop [core] - 10https://gerrit.wikimedia.org/r/87317 [07:00:16] (03PS1) 10PleaseStand: Maintenance: detect missing parent::__construct() [core] - 10https://gerrit.wikimedia.org/r/87320 [07:18:17] (03CR) 10Siebrand: [C: 031] "Leaving merge to TimStarling. Code was previously reviewed and merged in a branch." [core] - 10https://gerrit.wikimedia.org/r/87273 (owner: 10Liangent) [07:23:48] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [07:25:31] (03CR) 10Siebrand: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/87276 (owner: 10MarkTraceur) [07:45:11] (03PS2) 10PleaseStand: Installer: properly override default $wgLogo value [core] - 10https://gerrit.wikimedia.org/r/85959 [07:54:32] (03PS4) 10Physikerwelt: Adding svgtex to run MathJax on sererside [extensions/Math] - 10https://gerrit.wikimedia.org/r/87309 [07:58:33] (03PD3) 10Wikinaut: renamed $wgHideOpenIDLoginLink to $wgOpenHideOpenIDLoginLink (harmonizing names) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87321 [07:58:48] (03CR) 10Wikinaut: [C: 032 V: 032] renamed $wgHideOpenIDLoginLink to $wgOpenHideOpenIDLoginLink (harmonizing names) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87321 (owner: 10Wikinaut) [08:10:31] (03PS1) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [08:21:18] (03CR) 10Zfilipin: [C: 032] id changed for searchButton in master; also had bogus step [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87292 (owner: 10Cmcmahon) [08:36:36] (03PS1) 10Hashar: test: remove date from @author docs statements [core] - 10https://gerrit.wikimedia.org/r/87323 [08:47:33] (03PS2) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [08:49:14] (03PS2) 10Hashar: tests: remove date from @author docs statements [core] - 10https://gerrit.wikimedia.org/r/87323 [08:49:18] (03PS12) 10Mattflaschen: OB6: Show a popup CTA to onboarders in test group [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [08:50:00] (03CR) 10jenkins-bot: [V: 04-1] OB6: Show a popup CTA to onboarders in test group [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [08:55:38] (03CR) 10Mattflaschen: "(4 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [09:10:34] (03PS13) 10Mattflaschen: OB6: Show a popup CTA to onboarders in test group [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [09:12:03] (03PS1) 10Hashar: mw-run-phpunit.sh replace mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 [09:17:07] grr, now to change a single link (helppage, making external) I have to learn qunit [09:31:55] (03PS6) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [09:32:35] (03CR) 10Liangent: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [09:56:39] (03PS3) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [09:57:09] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [09:57:19] if anyone is awake around here, in wikimedia-tech there is a report of [09:57:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=54915 [10:04:08] (03CR) 10Swalling: "(5 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [10:17:40] (03PS4) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:18:39] (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:19:19] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [10:21:37] (03PS5) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [10:33:07] (03CR) 10Nemo bis: "PS4 and PS5 are rebase and rebase fix." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [12:01:59] (03CR) 10Matthias Mullie: [C: 032] Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 (owner: 10Bsitu) [12:03:07] (03Merged) 10jenkins-bot: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 (owner: 10Bsitu) [12:04:09] (03CR) 10Matthias Mullie: [C: 032] Typo fix + conditional fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86738 (owner: 10Bsitu) [12:04:24] (03Merged) 10jenkins-bot: Typo fix + conditional fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86738 (owner: 10Bsitu) [12:17:54] (03CR) 10Helder.wiki: "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [12:46:06] (03CR) 10Matthias Mullie: "(2 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 (owner: 10Bsitu) [12:51:02] (03CR) 10Matthias Mullie: [C: 031] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 (owner: 10Bsitu) [12:53:36] (03PS6) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [13:03:26] (03CR) 10Matthias Mullie: [C: 032] Fix some notification badge related issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85942 (owner: 10Bsitu) [13:03:36] (03Merged) 10jenkins-bot: Fix some notification badge related issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85942 (owner: 10Bsitu) [13:06:07] (03PS2) 10Zfilipin: Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 [13:33:48] (03CR) 10Matthias Mullie: [C: 032] Better error handling for memc and some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF)) [13:33:53] (03Merged) 10jenkins-bot: Better error handling for memc and some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF)) [13:47:51] (03CR) 10Matthias Mullie: [C: 032] Deprecate ApiQueryRevisionContentFlow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 (owner: 10Werdna) [13:47:59] (03Merged) 10jenkins-bot: Deprecate ApiQueryRevisionContentFlow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87314 (owner: 10Werdna) [13:59:41] (03CR) 10Siebrand: [C: 032] Fix typo. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87334 (owner: 10L10n-bot) [13:59:45] (03Merged) 10jenkins-bot: Fix typo. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87334 (owner: 10L10n-bot) [13:59:52] (03PS1) 10Matthias Mullie: Convert wikitext to html, depending on editor needs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87335 [14:05:51] (03CR) 10Reedy: [C: 032 V: 032] Update VisualEditor to wmf19 branch to pick up cherry-pick of Ia585b42 [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87305 (owner: 10Catrope) [14:12:25] (03PS9) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [14:13:02] (03CR) 10Wikinaut: [V: 04-1] "can someone help to find why it does not work ?" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 (owner: 10Wikinaut) [14:29:14] (03CR) 10Yuvipanda: [C: 04-1] "Brion's right, I've convinced myself that there is a possible race condition (when a new language is just being cached with older version " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 (owner: 10Yuvipanda) [14:40:26] (03PS3) 10Zfilipin: Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 [14:42:27] (03PS4) 10Zfilipin: Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 [14:48:55] (03CR) 10Helder.wiki: "(1 comment)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/87044 (owner: 10Tpt) [14:50:35] (03CR) 10Anomie: [C: 04-1] "(10 comments)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [14:54:57] (03CR) 10MaxSem: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [14:57:30] (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/87343 [14:59:09] (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/87343 (owner: 10Cscott) [15:02:08] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/87343 (owner: 10Cscott) [15:08:24] (03PS1) 10Jackmcbarn: Allow appending text to redirects from moved pages [core] - 10https://gerrit.wikimedia.org/r/87345 [15:09:47] (03CR) 10Zfilipin: [C: 032] Print/export open by default on test2wiki. see Bug 54886 for beta [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87198 (owner: 10Cmcmahon) [15:29:03] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [15:29:51] (03CR) 10Anomie: [C: 04-1] "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [15:31:10] (03CR) 10Chad: "information_schema is not a mysqlism, its part of the standard. This should at least in theory work for everyone but Sqlite." [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [15:34:16] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [15:40:39] (03CR) 10Rtdwivedi: [C: 031] Major refactoring of the JS part of the page edition system [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/87044 (owner: 10Tpt) [15:40:44] (03CR) 10Parent5446: "@Chad: actually sqlite has information_schema as well." [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [15:42:36] (03PS8) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [15:43:26] (03CR) 10Parent5446: "Quit edit: the difference in that SQLite you have to use INFORMATION_SCHEMA_TABLES." [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [15:46:13] (03PS7) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [15:46:31] (03CR) 10Liangent: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [15:47:28] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [15:47:51] (03CR) 10BryanDavis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [15:50:50] (03CR) 10Tpt: "(1 comment)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/87044 (owner: 10Tpt) [15:52:22] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [15:59:34] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [16:05:37] (03CR) 10Parent5446: [C: 032] Use HPHP_VERSION constant to detect HipHop [core] - 10https://gerrit.wikimedia.org/r/87317 (owner: 10PleaseStand) [16:07:04] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [16:08:31] (03Merged) 10jenkins-bot: Use HPHP_VERSION constant to detect HipHop [core] - 10https://gerrit.wikimedia.org/r/87317 (owner: 10PleaseStand) [16:08:55] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87320 (owner: 10PleaseStand) [16:10:48] (03CR) 10Chad: "So yeah I was going to see if we even need wfIsHipHop() anymore rather than just updating this..." [core] - 10https://gerrit.wikimedia.org/r/87317 (owner: 10PleaseStand) [16:10:53] (03CR) 10Jackmcbarn: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [16:14:12] (03PS1) 10Aaron Schulz: Avoid extra HEADs for stash clearing [core] - 10https://gerrit.wikimedia.org/r/87349 [16:15:47] apparently in https://gerrit.wikimedia.org/r/87345 that's not a good place to inject the extra text, but the page content is already saved anywhere later, and earlier it's too vague where it's being called from. what can i do about that? [16:16:33] (03CR) 10Siebrand: [C: 031] "L10n/i18n changes LGTM." [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [16:20:38] (03CR) 10Parent5446: ":P Well it can always be removed in another commit. Might be best to have it there. You never know when an extension or somebody will want" [core] - 10https://gerrit.wikimedia.org/r/87317 (owner: 10PleaseStand) [16:24:17] (03CR) 10Parent5446: [C: 031] Remove $wgBlockOpenProxies [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [16:25:02] (03CR) 10Qgil: "I just want to comment that I have been convinced that this is patch is a good idea. I just haven't got the time to test it myself, and I " [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [16:25:07] (03CR) 10Parent5446: [C: 031] Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 (owner: 10Ori.livneh) [16:34:30] (03Abandoned) 10EBernhardson (WMF): Allow querying of summary content via api [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87291 (owner: 10EBernhardson (WMF)) [16:34:47] (03CR) 10Dan-nl: "(8 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [16:38:33] (03PS8) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [16:42:11] (03PS1) 10Tpt: Implement ContentHandler for page pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/87352 [16:42:47] (03PS9) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [16:43:10] (03Abandoned) 10Tpt: Implement ContentHandler for page pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/87352 (owner: 10Tpt) [16:44:41] (03CR) 10Liangent: "Finally resolved conflicts :)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [16:45:32] (03PS2) 10Tpt: Implement ContentHandler facility for page pages [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 [16:48:49] (03PS4) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [16:56:20] (03CR) 10MaxSem: "@Parent5446 I don't think you should use ugly custom views to partially emulate the standard because at the end of the day you still have " [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [16:57:13] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [16:57:27] (03CR) 10Aaron Schulz: [C: 04-1] Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [17:00:05] (03PS25) 10MarkTraceur: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:00:50] (03CR) 10jenkins-bot: [V: 04-1] Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:03:29] (03PS2) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [17:05:43] (03CR) 10Legoktm: "PS2 is some stuff I was working on locally. Working on Anomie's comments now." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [17:09:55] anomie: what is the intended purpose of getResultProperties? [17:10:15] * duh looks for an example [17:10:36] oh [17:10:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [17:11:05] found one in ApiBlock [17:11:48] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [17:13:52] (03CR) 10Legoktm: "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [17:14:30] duh: No idea. Bug 18771 may give some slight insight. [17:14:45] (03PS3) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [17:16:10] anomie: so that's for errors, not results? [17:16:48] duh: Well, that bug is more about getPossibleErrors. I can't find any explanation for the adding of getResultProperties. [17:17:00] heh >.> [17:17:07] But they seem of a piece. [17:17:17] yeah [17:19:34] RoanKattouw: Do you have any idea what the purpose of the API methods getResultProperties or getPossibleErrors is supposed to be? [17:19:49] Giving users information about what might go wrong [17:19:52] (for errors) [17:20:08] ie this is a list of errors (and their messages) which this module can tell you [17:20:11] not conclusive [17:20:15] Reedy: Except it's impossible to make it comprehensive, because the rest of MediaWiki doesn't offer that sort of introspection. [17:20:21] Indeed [17:20:29] Tough? [17:20:33] API halting problem! [17:20:40] We control and transform some of the errors we get before sending them out [17:20:40] (03PS1) 10Siebrand: Test. Do not merge. [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/87362 [17:20:49] getResultProperties is related to output format I believe [17:20:59] ori-l: http://xkcd.com/1266/ [17:21:09] Reedy: bored? [17:21:13] hahahaha [17:21:24] anomie: or you? :) [17:21:31] i need someone to merge https://gerrit.wikimedia.org/r/#/c/86319/ and dep before 1.22 [17:21:44] what am i, chopped liver? [17:21:52] Yeah they document the possible errors and the structure of the result, respectively [17:22:12] ori-l: why, you're bored too? :D [17:22:19] I didn't think of that kind of stuff as a very big deal, but someone wanted it and I said they could have it if they wrote all the code for it [17:22:57] ori-l: some members of the team formerly known as E2 promised me to merge https://gerrit.wikimedia.org/r/#/c/82828/ and two deps a month ago, maybe you could do it instead? :P [17:23:17] MatmaRex: I'm preparing for todays deployment [17:23:30] RoanKattouw: Unfortunately, it doesn't seem to work very well. Does anyone actually know what getResultProperties is supposed to be returning, or is it all randomly adapted from other examples? [17:23:50] Reedy: so, you are bored? those are routine things ;) [17:24:08] anomie: I just copied mine from ApiBlock :P [17:24:16] It's dinner time in a few minutes I believe [17:24:20] well duh [17:24:23] I don't know [17:24:59] jdlrobson: edsanders is remarking that the typography update makes the sidebar links black [17:25:12] Of course you two aren't in a bloody channel together, so [17:25:21] marktraceur: that is correct yes that is intentional [17:25:25] * anomie considers whether he has time to actually pursue deprecating and removing getResultProperties and getPossibleErrors [17:25:46] jdlrobson: Did someone make that decision on a high level? Was there a conversation about it somewhere? [17:25:59] marktraceur: it's all in the mediawiki page linked off of that commit [17:26:11] Mumble grumble [17:26:28] it's still part of the page typography [17:27:02] jdlrobson: It doesn't appear that "link" or "color" or "black" turns up anything helpful on that page [17:27:03] black links? unsexy. :( [17:27:20] * MatmaRex awaits lingerie jokes [17:27:28] MatmaRex: Once you go blue and underlined, you never go back [17:27:38] Not as catchy, but [17:29:44] <^d> So *thats* why the links went black? [17:29:54] <^d> And here I was thinking it was my eyes or my monitor. [17:29:56] * ^d sighs [17:30:06] ^d: It still could be [17:31:02] marktraceur: i'll poke jared - it should be documented on that page, there was a discussion around contrast ratios maybe it's still on another wiki page somewhere. Anyway in short summary, the goal was to have less contrast on the chrome and higher contrast on the content to differentiate them. [17:32:29] (03CR) 10Matthias Mullie: [C: 032] Bundle message should show diff of all included revisions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 (owner: 10Bsitu) [17:32:40] (03Merged) 10jenkins-bot: Bundle message should show diff of all included revisions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 (owner: 10Bsitu) [17:35:10] 'kay [17:35:19] (03PS5) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [17:35:49] (03Abandoned) 10Siebrand: Test. Do not merge. [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/87362 (owner: 10Siebrand) [17:36:11] (03CR) 10CSteipp: "(1 comment)" [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87274 (owner: 10CSteipp) [17:37:08] ori-l: https://gist.github.com/jdlrobson/6813794 < alternative schema syntax suggestion [17:41:37] (03PS2) 10Legoktm: Check for unescaped language links [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 [17:42:15] (03CR) 10Legoktm: "PS2: Added punctuation per comment on https://gerrit.wikimedia.org/r/#/c/87183/" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [17:44:57] (03PS2) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [17:45:30] (03CR) 10Legoktm: "PS2: Added punctuation to error message." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [17:47:16] (03PS3) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [17:47:57] (03CR) 10Swalling: "Pau had some comments that are relevant. If they conflict with any of my suggestions, let's go with his." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [17:51:24] (03PS1) 10Legoktm: Add punctuation to two error messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87379 [17:54:06] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [17:54:44] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 (owner: 10Legoktm) [17:54:57] (03PS4) 10Legoktm: Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 [17:55:53] (03PS1) 10Siebrand: Test. Do not merge. [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/87384 [17:56:56] (03PS1) 10Siebrand: Test. Do not merge. [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/87388 [17:57:17] (03Abandoned) 10Siebrand: Test. Do not merge. [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/87388 (owner: 10Siebrand) [17:57:25] (03Abandoned) 10Siebrand: Test. Do not merge. [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/87384 (owner: 10Siebrand) [17:58:47] (03PS6) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [18:00:56] whelp, I now need to enable UW and Scribunto [18:00:57] ugh [18:11:02] Cloning from GitHub is 25 times faster than cloning from gerrit. Wow. [18:11:50] yay mirrors [18:13:09] siebrand: that's jgit for you [18:13:22] MatmaRex: jgit? [18:13:31] Reimplementation of git in Java [18:13:39] That's what Gerrit is built on [18:13:49] siebrand: have ^demon run `git gc --aggressive` or whatever the equivalent is on teh servers [18:14:01] <^demon> MatmaRex: Useless pings are useless. [18:14:03] it helped the last time, i think [18:14:09] (To be fair, I've heard that the git library in C is horrible and full of if(somethingBadHappened) { print error message; exit(1); } type of stuff) [18:14:11] <^demon> I run gc every weekend kthnx. [18:14:25] I'm moving to GitHub for origin, and will use gerrit only for patches. [18:14:56] siebrand: toldyaso :) [18:15:01] YuviPanda: Yes. [18:15:08] ^demon: oh, sorry. well, fix jgit then? :D [18:15:14] YuviPanda: I finally got fed up with my fscked up workflow. [18:15:16] siebrand: and lag is imperceptible too [18:15:39] clone from github, send patches to gerrit. [18:16:13] <^demon> You know what, I'm officially not caring about gerrit complaints anymore. Someone else can bust their ass on it. [18:16:59] quick, someone complain to ^demon about search! [18:17:04] <^demon> Search is cool. [18:17:08] does gitblit even have search? [18:17:10] I just use github [18:17:11] <^demon> I'll spend the next 6 months on search. [18:18:40] (03PS1) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [18:19:10] (03CR) 10jenkins-bot: [V: 04-1] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [18:19:15] :< [18:19:53] (03PS2) 10Umherirrender: Use always content language for localized ContentModel [core] - 10https://gerrit.wikimedia.org/r/84138 [18:20:38] <^demon> Aw :( http://p.defau.lt/?ospQb_hhgwTuVpHkgXDpBw [18:21:12] ^demon: are you actively working on hphp, or is just a side project of sorts? [18:21:19] just curious [18:21:30] (03PS1) 10Reedy: Add missing default true value for 'vector-simplesearch' preference [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87419 [18:21:45] <^demon> YuviPanda: Side project that I'm getting sucked into :) [18:21:57] where have I heard that before... ;) [18:22:02] good luck :) [18:22:20] <^demon> The platform team has been talking about doing some work on scap & other deployment thingies. [18:22:31] <^demon> Dropping hhvm in the l10n-recache stuff might be nice. [18:22:52] ^demon: whatever happened to the 'move to git-deploy!' thing? [18:23:04] <^demon> Well git-deploy is nice. [18:23:13] <^demon> But rebuilding l10n is still slow, however you do it. [18:23:16] right [18:23:20] so they're orthogonal issues. [18:23:23] <^demon> Yeah [18:23:31] I really should learn more about our deployment system [18:23:34] <^demon> But part of the same "let's make syncing not take 30 minutes" project :) [18:23:36] and maybe even get deploy rights [18:23:41] ^demon: heh, right. [18:24:24] (03CR) 10Reedy: [C: 032] Add missing default true value for 'vector-simplesearch' preference [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87419 (owner: 10Reedy) [18:25:36] <^demon> YuviPanda: That compile failure is from me trying to port the dba_* and xdiff_* functions :) [18:25:44] <^demon> Both of which we need for 100% unit test passing. [18:26:10] at least our unit tests run [18:26:20] iirc something like magneto still doesn't get to run its unit tests [18:28:20] (03Merged) 10jenkins-bot: Add missing default true value for 'vector-simplesearch' preference [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87419 (owner: 10Reedy) [18:28:30] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87320 (owner: 10PleaseStand) [18:33:51] (03CR) 10MaxSem: [C: 032] Add missing default true value for 'vector-simplesearch' preference [core] - 10https://gerrit.wikimedia.org/r/87024 (owner: 10Bartosz Dziewoński) [18:35:34] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [18:39:04] (03PS1) 10Physikerwelt: Try to introduce some error handling [extensions/Math] - 10https://gerrit.wikimedia.org/r/87429 [18:42:23] (03PS32) 10Physikerwelt: Waits for LaTeXML to become stable.... [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [18:42:49] (03Merged) 10jenkins-bot: Add missing default true value for 'vector-simplesearch' preference [core] - 10https://gerrit.wikimedia.org/r/87024 (owner: 10Bartosz Dziewoński) [18:43:30] (03CR) 10jenkins-bot: [V: 04-1] Waits for LaTeXML to become stable.... [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [18:49:08] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [18:50:25] (03CR) 10Parent5446: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87320 (owner: 10PleaseStand) [18:51:04] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [18:51:52] <^demon> Grrr, Tyler needs to hang out on IRC more :) [18:52:09] Yeah [18:52:14] yeah. [18:52:34] "If you're going to be merging patches, deploying things, or submitting patchsets, log on to IRC for at least five minutes so we can mob you about it" [18:53:19] (03Merged) 10jenkins-bot: Maintenance: detect missing parent::__construct() [core] - 10https://gerrit.wikimedia.org/r/87320 (owner: 10PleaseStand) [18:56:25] <^demon> My entire gerrit dashboard is now fitting on one page! That's incoming, outgoing and closed :) [18:56:30] <^demon> Whew. [18:56:46] * YuviPanda adds ^demon to a bunch of unrelated patchsets [18:57:15] * ^demon removes himself [18:58:59] <^demon> YuviPanda: http://p.defau.lt/?z4XPFvahbX8A_nj3MyDAIA only 6 errors left \o/ [18:59:20] <^demon> (1) is probably because 87281 is broken on sqlite :) [18:59:27] ^demon: not bad! [18:59:47] <^demon> I've got 19 failures, some of which are in zend as well. [18:59:52] <^demon> I wonder who broke Timestamp tests. [19:00:21] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [19:02:05] i hate it when i accidentally start checking out core inside an extension when testing some patchset [19:02:06] (03PS2) 10Chad: Rewrite tableExists() [core] - 10https://gerrit.wikimedia.org/r/87281 [19:03:28] (03CR) 10jenkins-bot: [V: 04-1] Rewrite tableExists() [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [19:03:36] (03CR) 10Anomie: "(1 comment)" [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87274 (owner: 10CSteipp) [19:05:03] (03PS4) 10Reedy: Maintenance script to remove entries from globalimagelinks when a wiki has been deleted [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87262 [19:06:49] (03PS2) 10Reedy: Add public getters for special page variables [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87310 (owner: 10Legoktm) [19:06:53] (03CR) 10Reedy: [C: 032] Add public getters for special page variables [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87310 (owner: 10Legoktm) [19:07:14] (03Merged) 10jenkins-bot: Add public getters for special page variables [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87310 (owner: 10Legoktm) [19:07:40] <^demon> YuviPanda: https://www.mediawiki.org/wiki/User:%5Edemon/timestamp-failures :\ [19:08:06] (03PS2) 10Reedy: Give an error if the wiki is not recognized [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87013 (owner: 10Legoktm) [19:08:11] (03CR) 10Reedy: [C: 032] Give an error if the wiki is not recognized [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87013 (owner: 10Legoktm) [19:08:21] (03Merged) 10jenkins-bot: Give an error if the wiki is not recognized [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87013 (owner: 10Legoktm) [19:08:37] (03PS2) 10Reedy: Add punctuation to two error messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87379 (owner: 10Legoktm) [19:08:42] (03CR) 10Reedy: [C: 032] Add punctuation to two error messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87379 (owner: 10Legoktm) [19:09:03] ^demon: uh, I didn't even know we had tests for that [19:09:07] bisect? [19:09:17] <^demon> Tests haven't changed in some time. [19:09:29] <^demon> I don't think it's failing in jenkins either. [19:09:32] (03Merged) 10jenkins-bot: Add punctuation to two error messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87379 (owner: 10Legoktm) [19:10:29] (03CR) 10Brion VIBBER: [C: 04-1] "Looks good except one thing -- the collapsed arrow icon isn't being embedded in output. On the plus side, it is flipping correctly for RTL" [core] - 10https://gerrit.wikimedia.org/r/86691 (owner: 10Jdlrobson) [19:10:56] csteipp: around? any chance we get https://bugzilla.wikimedia.org/show_bug.cgi?id=28419 fixed on occasion of the leak? (or at least use something else for hashing than md5?) [19:12:09] MatmaRex: I am actually working on it [19:12:26] (03PS5) 10Reedy: Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 (owner: 10Legoktm) [19:12:30] (03CR) 10Reedy: [C: 032] Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 (owner: 10Legoktm) [19:12:41] (03Merged) 10jenkins-bot: Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 (owner: 10Legoktm) [19:13:22] (03PS2) 10Reedy: Fix language links not being parsed properly due to talk pages escaping them [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87167 (owner: 10Legoktm) [19:13:26] (03CR) 10Reedy: [C: 032] Fix language links not being parsed properly due to talk pages escaping them [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87167 (owner: 10Legoktm) [19:13:31] <^demon> csteipp: Let's just get rid of user accounts. [19:13:36] <^demon> No passwords, no problems :) [19:13:37] and users [19:13:43] no users, even lesser problems ;) [19:13:44] csteipp: yay, lovely [19:13:46] (03Merged) 10jenkins-bot: Fix language links not being parsed properly due to talk pages escaping them [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87167 (owner: 10Legoktm) [19:14:38] csteipp: can i quote you on this? ;) [19:17:34] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [19:19:23] (03PS1) 10Reedy: Update MassMessage to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87435 [19:19:48] (03CR) 10Reedy: [C: 032 V: 032] Update MassMessage to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87435 (owner: 10Reedy) [19:24:13] (03PS1) 10Plavi: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 [19:25:19] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87165 (owner: 10Jdlrobson) [19:35:15] anyone knows where the int parserfunction comes from? [19:35:48] YuviPanda: is it not in CoreParserFunctions.php? [19:36:04] hmm [19:36:04] it is [19:36:08] not sure why it doesn't work [19:36:14] * YuviPanda tries importing more things to test [19:38:08] (03CR) 10Plavi: "Hi," [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [19:41:47] Hi YuviPanda! [19:41:50] Did you talk with Dan? [19:42:08] hey multichill, not yet. y'day and today was littered with hospital visits and such [19:42:15] (wrist / hand problems) [19:42:23] he sent an email, i'll try and respond tomorrow [19:42:28] sorry! [19:42:29] Owh, what is it? RSI or something like thaT? [19:42:35] probably, yeah. [19:42:39] No, take care [19:42:47] now enforcing breaks and stuff. hopefully better tomorrow [19:43:23] hmm, RSI suck, be really careful with that [19:43:25] (03PS2) 10Ori.livneh: Update lessphp to 261f1bd28 [core] - 10https://gerrit.wikimedia.org/r/86616 [19:43:55] (03CR) 10Ori.livneh: "Pull request merged; this should be good to go." [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [19:43:57] yeah [19:43:59] ^^ brion [19:44:22] Damn that database issue I ran into earlier this week has quite some impact.... [19:44:48] \o/ [19:45:26] multichill: heh, labsdb non-redaction? [19:46:35] Yeah, I just wanted to see the most active accounts so I ran a SELECT (*) FROM user ORDER BY user_editcount DESC LIMIT 20; and wondered why the hell my terminal exploded [19:46:42] (normally that's 3 columns, not 10) [19:50:21] YuviPanda: emailaddresses and password hashes, that's gold if you're blackhat... [19:50:35] yeah, indeed. [19:50:48] although I guess it is somewhat restricted [19:51:15] Not sure what kind of hash is used and if it's salted. [19:52:21] (03PS5) 10Reedy: Maintenance script to remove entries from globalimagelinks when a wiki has been deleted [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87262 [19:52:57] WTF, MD5? We're not seriously using MD5? [19:53:18] :) [19:54:55] ori-l: ping [19:55:20] multichill: md5( salt + md5(pw)) [19:55:21] brion: https://gerrit.wikimedia.org/r/#/c/86616/ < is this ready to merge? [19:55:27] multichill: https://bugzilla.wikimedia.org/show_bug.cgi?id=28419 [20:00:15] (03PS6) 10Reedy: Maintenance script to remove entries from globalimagelinks when a wiki has been deleted [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87262 [20:02:02] legoktm: Yeah, I was just reading that one. [20:07:52] M$ says that with md5 your passwords must be at least 15 characters long [20:08:34] gawdddd gerrit so slow these days [20:11:38] (03CR) 10Swalling: [C: 031] "We've got some style work to do, but the basic logic and logging is working for me on piramido. I think this can go out in our window toda" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [20:11:57] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87165 (owner: 10Jdlrobson) [20:13:10] (03PS7) 10Yuvipanda: [WIP] Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [20:16:37] brion: updated https://gerrit.wikimedia.org/r/#/c/86960/ [20:16:43] to use cache invalidation timestamps [20:17:01] brion: I thought about the method I was using, and noted that there's a small possibility of a race (mentioned that in my -1 comment) [20:17:08] whee [20:17:36] brion: so this seems to work, although I'm not sure if I'm passing the language through properly. ParserOptions isn't too well commented [20:17:51] ok i'll poke it in a bit [20:17:54] brion: ty [20:20:39] (03CR) 10Reedy: [C: 032] "Already run on the cluster" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87262 (owner: 10Reedy) [20:20:42] (03Merged) 10jenkins-bot: Maintenance script to remove entries from globalimagelinks when a wiki has been deleted [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87262 (owner: 10Reedy) [20:21:19] (03PS2) 10Reedy: Add wfWaitForSlaves() call to refreshMessageBlobs.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/85346 [20:21:24] (03CR) 10Reedy: [C: 032] Add wfWaitForSlaves() call to refreshMessageBlobs.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/85346 (owner: 10Reedy) [20:21:26] (03Merged) 10jenkins-bot: Add wfWaitForSlaves() call to refreshMessageBlobs.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/85346 (owner: 10Reedy) [20:24:32] (03PS10) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 [20:24:33] (03PS4) 10Jdlrobson: Rewrite collapsibleNav as LESS file [core] - 10https://gerrit.wikimedia.org/r/86691 [20:24:34] (03PS26) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 [20:24:35] (03PS3) 10Jdlrobson: Update lessphp to 261f1bd28 [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [20:27:00] (03PS9) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [20:27:29] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [20:27:57] (03PS10) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [20:32:42] (03PS7) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [20:35:30] (03PS2) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [20:35:36] (03CR) 10jenkins-bot: [V: 04-1] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [20:36:35] (03PS3) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [20:36:45] (03CR) 10jenkins-bot: [V: 04-1] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [20:37:06] (03PS10) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [20:37:31] (03PS2) 10Brion VIBBER: Rewrite mediawiki.special.preferences.less with nesting [core] - 10https://gerrit.wikimedia.org/r/87171 (owner: 10Jdlrobson) [20:40:14] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87171 (owner: 10Jdlrobson) [20:46:54] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [20:51:52] (03PS8) 10Yuvipanda: [WIP] Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [20:54:30] (03PS11) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [20:58:44] (03PS1) 10Ori.livneh: Don't point Apache's ErrorLog at vboxsf mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/87445 [20:59:02] yurik: this is the issue you ran into; brion discovered the underlying cause ^ [20:59:37] (03CR) 10Ori.livneh: [C: 032] Don't point Apache's ErrorLog at vboxsf mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [20:59:40] (03Merged) 10jenkins-bot: Don't point Apache's ErrorLog at vboxsf mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [21:02:54] ^d: https://gerrit.wikimedia.org/r/#/c/87349/ [21:03:59] (03CR) 10Chad: [C: 032] Avoid extra HEADs for stash clearing [core] - 10https://gerrit.wikimedia.org/r/87349 (owner: 10Aaron Schulz) [21:06:50] (03Merged) 10jenkins-bot: Avoid extra HEADs for stash clearing [core] - 10https://gerrit.wikimedia.org/r/87349 (owner: 10Aaron Schulz) [21:07:36] (03PS12) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [21:10:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [21:15:01] (03CR) 10CSteipp: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [21:17:14] (03CR) 10Siebrand: [C: 04-1] "(4 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [21:18:03] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [21:18:35] (03PS9) 10Yuvipanda: [WIP] Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [21:18:48] MaxSem: added documentation! and removed potential (but rare!) race condition that brion pointed out. ^ [21:19:05] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [21:19:44] (03CR) 10Ori.livneh: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [21:20:57] (03PS14) 10Mattflaschen: OB6: Show a popup CTA to onboarders in test group [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [21:21:48] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87288 (owner: 10Liangent) [21:22:34] (03CR) 10JGonera: [C: 031] Update lessphp to 261f1bd28 [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [21:24:26] (03CR) 10Mattflaschen: "That uses most of Pau's suggestions. But I didn't use position: fixed so it would still look tolerable in IE6." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [21:24:35] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [21:25:14] (03CR) 10Ori.livneh: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/87445 (owner: 10Ori.livneh) [21:27:11] (03PS10) 10Liangent: (bug 35378) Support multiple collations at the same time [core] - 10https://gerrit.wikimedia.org/r/87288 [21:27:20] (03PS1) 10Aaron Schulz: Added wiki ID to getCoalesceLocationInternal() for sanity [core] - 10https://gerrit.wikimedia.org/r/87451 [21:31:16] alright, i'm out [21:31:56] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87345 (owner: 10Jackmcbarn) [21:44:44] (03CR) 10Mattflaschen: [C: 032] "Self-merging. Partially reviewed by Pau and S." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [21:44:48] (03Merged) 10jenkins-bot: OB6: Show a popup CTA to onboarders in test group [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [21:47:08] (03PS1) 10Nemo bis: Clarify that "continue" means leaving the editing drafts-view-warn [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87456 [21:50:07] (03PS2) 10Nemo bis: Clarify that "continue" means leaving the editing drafts-view-warn [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87456 [21:59:16] (03PS9) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [22:00:02] (03PS13) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [22:00:30] (03CR) 10Dan-nl: "(4 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [22:03:36] greg-g: OK for VE to do a lightning deploy? Two cherry-picks (for both wmf19 and wmf20). :-( [22:03:39] (03PS1) 10Mattflaschen: Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87461 [22:04:29] (03PS1) 10Mattflaschen: Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87463 [22:07:29] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [22:11:58] James_F: yeah, just check in with superm401 to make sure he's done [22:12:54] greg-g: Of course. [22:13:19] James_F: he was running over, is all [22:14:12] greg-g: Understood. [22:20:33] ori-l, is the error reporting patch already included in the lessphp that we use in the core? [22:21:08] yes [22:29:38] (03CR) 10Mattflaschen: [C: 032] Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87461 (owner: 10Mattflaschen) [22:29:44] (03CR) 10Mattflaschen: [C: 032] Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87463 (owner: 10Mattflaschen) [22:32:43] (03Merged) 10jenkins-bot: Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87461 (owner: 10Mattflaschen) [22:34:16] (03Merged) 10jenkins-bot: Bump GettingStarted for Growth team deployment [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87463 (owner: 10Mattflaschen) [22:41:51] (03CR) 10Siebrand: [C: 032] Clarify that "continue" means leaving the editing on drafts-view-warn [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87456 (owner: 10Nemo bis) [22:42:07] (03CR) 10saper: [C: 04-1] "Looking at history of wfExpandUrl, I believe it should be fixed there." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/87293 (owner: 10Bpetty) [22:42:08] (03CR) 10Siebrand: [V: 032] Clarify that "continue" means leaving the editing on drafts-view-warn [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87456 (owner: 10Nemo bis) [22:45:33] (03PS33) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [22:57:48] (03CR) 10EBernhardson (WMF): [C: 04-2] "It looks like what was commited to core is LESS, rather than SASS?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [22:58:55] (03PS6) 10Aaron Schulz: Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [23:03:36] greg-g: apparently roan's computer died for a minute but he will do the deploy after it's fixed [23:03:45] (03PS1) 10MarkTraceur: Fix mistake in fundraising zuul config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/87475 [23:03:47] * AaronSchulz was told IRL to relay this message [23:03:52] mwalker: Care to +1 ^ [23:04:39] (03CR) 10Mwalker: [C: 032] Fix mistake in fundraising zuul config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/87475 (owner: 10MarkTraceur) [23:04:57] Or +2 I guess [23:05:00] You know [23:05:02] Whatever [23:05:14] (03Merged) 10jenkins-bot: Fix mistake in fundraising zuul config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/87475 (owner: 10MarkTraceur) [23:07:11] (03PS1) 10Legoktm: Support non-English namespace names in DicussionParser::getUserFromLine [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 [23:07:20] MatmaRex: ^ [23:07:48] (03Abandoned) 10Jdlrobson: Allow filtering of notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [23:08:36] (03PS2) 10Nemo bis: Support non-English namespace names in DicussionParser::getUserFromLine [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm) [23:08:59] Nemo_bis: heh, thanks. [23:10:23] legoktm: np, it's just for my own sanity; merged typos make me cry [23:11:09] legoktm: heh [23:11:15] legoktm: have you tested that? i didn't [23:11:27] not yet, i'm going to as soon as i get home [23:11:40] but once its in gerrit, it'll get reviews much faster [23:11:49] orly. [23:12:03] well, hopefully. [23:12:41] bbl [23:14:23] (03PS34) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [23:14:39] (03PS1) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [23:19:47] (03PS1) 10Catrope: Update VisualEditor to wmf19 branch for cherry-picks [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87480 [23:20:48] (03PS1) 10Catrope: Update VisualEditor to wmf20 branch for cherry-picks [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87481 [23:20:52] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf19 branch for cherry-picks [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87480 (owner: 10Catrope) [23:21:02] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf20 branch for cherry-picks [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/87481 (owner: 10Catrope) [23:26:57] regarding sass, i should probably assume /resources/mediawiki.ui/sourcefiles/scss in mediawiki core is going away? [23:27:09] ori-l: regarding sass, i should probably assume /resources/mediawiki.ui/sourcefiles/scss in mediawiki core is going away? [23:30:18] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [23:35:29] ebernhardson: yes, as soon as someone does that [23:35:31] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/35871 (owner: 10Wizardist) [23:35:42] ebernhardson: i think superm401 was working on it, and there might be a bug for it too [23:36:08] (it = rewriting that scss in less) [23:36:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=54485 [23:36:38] ebernhardson, yeah, it's on my shortlist. [23:37:16] * MatmaRex lurks too much [23:38:25] ori-l: https://ganglia.wikimedia.org/latest/?r=week&cs=&ce=&tab=v&vn=Static+assets is that from the world or from e.g. phantomjs ? [23:39:05] Krinkle: phantomjs; you looked at the script, remember? [23:39:21] yeah, but didn't know whether that'd be live already [23:40:14] ebernhardson: or someone could replace resources/mediawiki.ui with Flow's agora2-override.less ;) https://bugzilla.wikimedia.org/show_bug.cgi?id=54360 [23:40:17] yep [23:40:48] ori-l: btw, I'm thinking of doing a front-end performance sprint some time soon. Focus on core and wmf-deployed extensions. I expect to do things like looking at dev tool charts and finding code that do bad things for e.g. layout trashing, slow repaints, the typical paul_irish kinda stuff. [23:41:41] including whatever else we find (e.g. fouc or something) [23:42:19] Krinkle: excellent; do you want to pair up in any way? [23:42:20] Krinkle: Is your mw.Title work going well? [23:42:22] * MatmaRex throws https://bugzilla.wikimedia.org/show_bug.cgi?id=51561 at Krinkle [23:42:26] (sorry to bust in) [23:42:32] Hah, you're popular today. [23:42:36] marktraceur: Ask RoanKattouw, he's supposed to review it [23:42:51] I reviewed it, did you respond already? [23:42:55] I'm done with it afaik, unless he tells me I'm not: https://gerrit.wikimedia.org/r/#/c/83047/ [23:42:57] Krinkle: do you know a fast way to hide 1000 radio buttons at once? i didn't come up with anything. :P [23:43:05] MatmaRex: css [23:43:16] .common input[type=radio] { display: none; } [23:43:20] If so I'll look after I'm done with Trevor's large change [23:43:27] Krinkle: not that easy, y'know. [23:43:40] MatmaRex: Tell me about it [23:43:42] Krinkle: i came up with a rule that would work and it was slower than the JS [23:43:47] :D [23:43:52] Krinkle: https://en.wikipedia.org/wiki/User:Ori.livneh/common.js <-- i'd love to package that as a module and put it in core [23:44:20] Krinkle: its load can always be deferred [23:44:52] ori-l: $.byteLength btw, or is it no good? [23:45:11] meh, I suppose you don't want to add dependencies :P [23:45:13] heh, I just didn't know about it [23:45:17] OK, in-person conversation ends with "RoanKattouw will get to it soon and we'll see if it's actually working now" [23:45:19] check out : http://i.imgur.com/HgdpeRp.png [23:45:24] ^ RoanKattouw / Krinkle [23:45:28] nice [23:45:54] ori-l: that reminds me of a unrelated mental picture for an rl cache idea [23:46:02] last year I was experimenting with local storage [23:46:06] Nice [23:46:11] putting mw.loader.implement's functions and css blobs in local storage [23:46:12] Krinkle: ...like, say: https://gerrit.wikimedia.org/r/#/c/86867/ [23:46:19] and executing it from there if the verison number is the same :) [23:46:25] Krinkle: I'm not sure that helps much in light of the browsers' own cache [23:46:28] size was the main concern, and not having time :) [23:46:31] RoanKattouw: sure it does [23:46:37] Although per-module I suppose it does [23:46:42] RoanKattouw: well,it'd save a 304 round trip [23:46:43] that makes a huge difference [23:46:52] (03PS1) 10saper: wfExpandUrl should expand relative URLs, too [core] - 10https://gerrit.wikimedia.org/r/87482 [23:46:53] most modules aren't updated all that often [23:47:01] Krinkle: No, there wouldn't be a 304 round-trip at all, if the browser cache knows about that URL it satisfies it from cache [23:47:14] right [23:47:15] but whenever a module is touched the URLs change and we throw away everything [23:47:18] Yes [23:47:28] yeah, it might keep the module load smaller by requesting fewer [23:47:29] That's what I meant by "Although per-module I suppose it does" [23:47:37] yep [23:47:45] the patch i linked to above shaves 100k from most page loads for me [23:47:56] page loads after the initial one i mean [23:47:59] FYI, Krinkle, I'm planning on sticking basically https://commons.wikimedia.org/wiki/MediaWiki:Gadget-libUtil.js into mw.Title as an mw.Title.fromFileURL method or so [23:48:05] I would be interested to see if eval()ing localStorage code is faster than real execution from browser cache [23:48:23] Specifically "titleFromImageSrc" [23:48:42] hmm, trying out less i'm getting @import directives from the .less file output by resource loader, but i was thinking those should have been resolved server side? Better question might be, how can i test that my .less is working? [23:48:45] But probably with some tweaks [23:48:54] ori-l: Surely that's not actually accurate and the browser is faking network data about things it really got from its cache? [23:49:10] RoanKattouw: it's with debug tools open (and thus browser cache disabled) [23:49:15] ori-l: no way! that's pretty much what I had in mind, yes. [23:49:16] RoanKattouw: so you're right, in that respect it's a fake benchmark [23:49:45] Have you looked at execution time? [23:49:53] eval vs.