[00:00:22] (03PS13) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 [00:01:35] (03CR) 10MarkTraceur: "Issues inline fall under https://bugzilla.wikimedia.org/show_bug.cgi?id=53245 IMHO" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 (owner: 10MarkTraceur) [00:01:50] (03Merged) 10jenkins-bot: Move 'main page as default title' further down to unbreak diff urls [core] - 10https://gerrit.wikimedia.org/r/86381 (owner: 10Nikerabbit) [00:07:18] (03PS1) 10MarkTraceur: jshint fixes for mw.ConfirmCloseWindow.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86776 [00:07:56] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 [00:08:21] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardDescription.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86778 [00:10:06] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardDetails.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 [00:11:24] Splitting patches, yay. [00:11:44] One-line patch anyone? https://gerrit.wikimedia.org/r/86776 [00:12:09] Also https://gerrit.wikimedia.org/r/86778 is only 20-odd [00:25:10] (03PS1) 10Manybubbles: Allow aggressive splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86781 [00:26:11] (03PS1) 10Manybubbles: Tests for programmer friendly word splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86782 [00:26:13] (03PS1) 10Mwalker: Re updating CentralNotice to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86783 [00:26:59] (03CR) 10Mwalker: [C: 032] Re updating CentralNotice to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86783 (owner: 10Mwalker) [00:35:56] (03PS3) 10Manybubbles: If SearchUpdate can't find page try on master. [core] - 10https://gerrit.wikimedia.org/r/86704 [00:36:39] (03PS2) 10Manybubbles: Allow aggressive splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86781 [00:38:08] (03PS2) 10Manybubbles: Tests for programmer friendly word splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86782 [00:39:58] (03CR) 10Manybubbles: "I do not know if we should just leave this on on all English wikis or if it'd be better only to turn it on for mediawiki.org." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86781 (owner: 10Manybubbles) [00:42:17] Isarra: manybubbles appears to be doing your bidding, there? :P [00:42:51] it needed to be done [00:42:52] Cool! [00:42:58] * Isarra hugs manybubbles. [00:42:58] (03PS2) 10Krinkle: jshint: Log jshint version to console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86710 [00:43:04] (03CR) 10Krinkle: [C: 032] jshint: Log jshint version to console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86710 (owner: 10Krinkle) [00:43:24] Isarra: I'll let you know when it is deployed and working [00:43:30] Awesome, thanks. [00:43:42] (03Merged) 10jenkins-bot: jshint: Log jshint version to console [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86710 (owner: 10Krinkle) [00:43:45] (03PS4) 10Manybubbles: SearchUpdate should read from master. [core] - 10https://gerrit.wikimedia.org/r/86704 [01:05:14] (03PS1) 10Hiong3-eng5: is_the_job bug I forgot to add this so the current status of up-to-date files became outdated [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/86786 [01:10:13] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 [01:16:49] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardUpload.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 [01:17:45] (03PS2) 10MarkTraceur: jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 [01:18:54] (03Abandoned) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 (owner: 10MarkTraceur) [01:22:27] (03PS3) 10Werdna: Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 [01:22:28] (03CR) 10jenkins-bot: [V: 04-1] Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [01:26:04] (03PS1) 10MarkTraceur: Ignore unused jasmine tests for jshint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86791 [01:26:31] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardPage.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86792 [01:27:01] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardUploadInterface.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86793 [01:27:20] (03PS1) 10MarkTraceur: jshint fixes for mw.UploadWizardUtil.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86794 [01:27:40] (03PS1) 10MarkTraceur: jshint fixes for mw.UtilitiesTime.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86797 [01:28:24] (03PS1) 10MarkTraceur: jshint fixes for mw.fileApi.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86798 [01:32:52] (03PS4) 10Werdna: Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 [01:36:17] (03PS1) 10TTO: Update Bugzilla comment field border to match Vector skin [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86799 [01:47:04] TimStarling, around? I'm trying to figure out how to inject a user right dynamically for a specific page (entire namespace is readonly, but one page should be editable) [01:48:19] yurik, do it using the userCan hook? [01:48:51] yeah, injecting user rights into users depending on what page they are viewing is not the right way to do it [01:50:09] TimStarling, MaxSem thx, but i can't figure out any other way -- zero ns is readonly except for a few admins, but we want to give edit rights to the specific set of users for each zero page -- partner registers an account and gives us their name - we add that name into json blob, and thereafter they can manage it themselves [01:50:42] so give the specific set of users a new right [01:50:59] TimStarling, but we don't want partners to edit each other's settings :) [01:51:02] and then add a userCan hook giving people with that right the ability to edit the page [01:51:29] why is that difficult? [01:52:06] you mean allow editing for a subgroup which will contain all partners, but then prohibit unless they are listed for that specific page? [01:52:09] that might work [01:52:20] yes [01:52:36] that also means that we will have to create "zerouser" sec group [01:52:38] or don't even bother with the group [01:52:48] and just use the separate list [01:52:52] is this meant for a wikimedia wiki? [01:53:01] yes [01:53:03] meta [01:53:35] well, don't do that then [01:53:44] e.g. this page should be editable by zero admins + vimpelcom's reps: https://meta.wikimedia.org/wiki/Zero:410-01 [01:54:28] looks like a nasty hack to me [01:54:39] TimStarling, can you suggest a better approach? [01:55:09] would love to do it in a different manner [01:55:40] but the best i have came up with is to store users that have the right to edit zero page inside that page itself :) [01:55:46] use a separate domain name [01:56:24] ideally write a proper UI for editing this configuration [01:56:29] can't - it has to be on the same cluster and whitelisted [01:56:42] there will be UI - javascript based [01:56:55] whitelisted? [01:57:01] it will work as a separate tab [01:57:11] you mean you are actually delivering this page text to clients? [01:57:21] correct [01:57:32] don't do that, use ResourceLoader [01:57:55] TimStarling: does https://gerrit.wikimedia.org/r/#/c/71966/ look ok now? [01:59:00] (03CR) 10Mattflaschen: [C: 04-1] "Patch set 12 looks okay." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [01:59:59] AaronSchulz: so it is tested now? [02:01:09] TimStarling, the original (partially implemented) idea was to rewrite all links to external resources to point to a special page, and have javascript on the client side download relevant settings using http://en.wikipedia.org/w/api.php?action=zeroconfig&type=config [02:02:00] and use those settings to dynamically convert some of those links to dirrect links [02:02:23] RL is the obvious way to efficiently configure client-side scripts [02:02:32] and if javascript is not available or doesn't work, the links will still function properly - the redirect page would either show warning or redirect silently [02:02:46] (03CR) 10MarkTraceur: "That's odd. I'll grep myself and remove it in the new commit." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [02:03:27] TimStarling, btw, that zeroconfig api call doesn't return entire json blob, only the relevant portions after doing some server-side checks [02:03:39] and its cachable per X-CS [02:03:47] +1 to Tim. you don't need to call API on every page load (or at least potentially call) [02:04:21] Wait - superm401, do you want to +2 the other files' commits, or should we just merge this big one after I take out the dead code? [02:04:34] I split all the jshint ones today because nobody wanted to review them [02:04:35] MaxSem, i would love to hear more about your idea - or better yet - talk to Adam - he is the one implementing that part [02:04:38] it's possible to cache API requests, but RL is built for that one job [02:05:12] and RL allows bundling of requests, to reduce the number of RTTs [02:05:36] marktraceur, I'll +2 assuming you verify whether or not this is dead code, and proceed accordingly. [02:05:40] Dead code sucks. :) [02:05:49] But you can do it in a separate commit. [02:05:57] yurik, see examples e.g. in ResourceLoaderUserOptionsModule [02:06:35] Ah K [02:06:47] superm401: It sure looks like it's dead, but I'll verify [02:07:05] varying RL requests per custom headers works, we used to do that for MF [02:07:10] superm401: Or you could set about +2ing the split commits [02:07:16] Some of them are tiny [02:07:17] Anyway [02:07:18] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/UploadWizard+branch:master+topic:bug/47161,n,z [02:07:25] marktraceur, didn't you split another one, not the one I've been doing? [02:07:31] I've split them all now [02:07:36] I just failed to abandon this last one [02:07:37] :( [02:07:45] I reviewed all the files in that one. [02:07:50] It's OK, it's the same code, it's just a matter of rebasing [02:07:54] I think [02:08:10] Anyway [02:08:23] Give me ten minutes to investigate this thing [02:08:27] No problem [02:11:05] (03PS14) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 [02:11:11] superm401: Sorry about that [02:17:43] (03CR) 10Swalling: "(4 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [02:20:50] superm401: Any chance we can merge that bad boy tonight and finish up with the split patches? :D [02:21:02] I mean, the split patches can be over time [02:23:49] (03CR) 10Nikerabbit: "(2 comments)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 (owner: 10Nemo bis) [02:28:40] (03CR) 10Mattflaschen: [C: 032] "Same as patch set 11, which I reviewed completely, except that .error (dead code) is removed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [02:28:44] (03Merged) 10jenkins-bot: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [02:28:48] marktraceur, yeah, I was going to. [02:28:55] Just got onto something else temporarily. [02:29:48] Coolio [02:29:59] I'll abandon the rest of those patches then [02:30:57] (03Abandoned) 10MarkTraceur: jshint fixes for mw.UploadWizardUploadInterface.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86793 (owner: 10MarkTraceur) [02:31:05] (03Abandoned) 10MarkTraceur: jshint fixes for mw.UploadWizardUtil.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86794 (owner: 10MarkTraceur) [02:31:10] (03Abandoned) 10MarkTraceur: jshint fixes for mw.UtilitiesTime.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86797 (owner: 10MarkTraceur) [02:31:14] (03Abandoned) 10MarkTraceur: jshint fixes for mw.fileApi.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86798 (owner: 10MarkTraceur) [02:31:17] (03Abandoned) 10MarkTraceur: jshint fixes for mw.UploadWizardPage.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86792 (owner: 10MarkTraceur) [02:31:44] (03Abandoned) 10MarkTraceur: Ignore unused jasmine tests for jshint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86791 (owner: 10MarkTraceur) [03:17:18] TimStarling: in eval.php, yes [03:18:50] (03PS6) 10Tim Starling: jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs() [core] - 10https://gerrit.wikimedia.org/r/71966 (owner: 10Aaron Schulz) [03:18:59] (03CR) 10Tim Starling: [C: 032] jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs() [core] - 10https://gerrit.wikimedia.org/r/71966 (owner: 10Aaron Schulz) [03:23:48] (03Merged) 10jenkins-bot: jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs() [core] - 10https://gerrit.wikimedia.org/r/71966 (owner: 10Aaron Schulz) [03:40:10] (03PS1) 10MarkTraceur: jquery audit of mw.ApiUploadHandler.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 [03:56:30] (03PS1) 10MarkTraceur: jquery audit of mw.DestinationChecker.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 [04:08:05] (03PS1) 10MarkTraceur: jquery audit of mw.ErrorDialog.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86805 [04:20:47] (03PS1) 10Rfaulk: mod - use dulwich deps in revert. [sartoris] - 10https://gerrit.wikimedia.org/r/86807 [04:20:48] (03PS1) 10Rfaulk: add - method _make_author for formatting commiter ID. [sartoris] - 10https://gerrit.wikimedia.org/r/86808 [04:21:04] (03CR) 10Rfaulk: [C: 032 V: 032] mod - use dulwich deps in revert. [sartoris] - 10https://gerrit.wikimedia.org/r/86807 (owner: 10Rfaulk) [04:21:15] (03CR) 10Rfaulk: [C: 032 V: 032] add - method _make_author for formatting commiter ID. [sartoris] - 10https://gerrit.wikimedia.org/r/86808 (owner: 10Rfaulk) [04:37:01] (03PS1) 10Aaron Schulz: Cleaned up https redirect code to be more consistent [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 [04:43:15] (03CR) 10Aaron Schulz: [C: 032] Add Vary: X-Forwarded-Proto for https redirects [core] - 10https://gerrit.wikimedia.org/r/86697 (owner: 10CSteipp) [04:43:51] (03PS1) 10MarkTraceur: jquery audit of mw.GroupProgressBar.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 [04:44:44] (03CR) 10Nemo bis: "(2 comments)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 (owner: 10Nemo bis) [04:46:03] (03Merged) 10jenkins-bot: Add Vary: X-Forwarded-Proto for https redirects [core] - 10https://gerrit.wikimedia.org/r/86697 (owner: 10CSteipp) [04:50:04] (03PS3) 10Aaron Schulz: jobqueue: various cleanups to JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/69448 [04:50:34] (03CR) 10jenkins-bot: [V: 04-1] jobqueue: various cleanups to JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/69448 (owner: 10Aaron Schulz) [04:51:51] (03PS6) 10Spage: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [04:56:51] (03CR) 10Spage: "(5 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [04:59:23] (03PS2) 10Hiong3-eng5: is_the_job bug and POST regeneration [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/86786 [05:06:08] (03PS1) 10MarkTraceur: jquery audit on mw.IframeTransport.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 [05:07:05] (03CR) 10MarkTraceur: "I haven't tested this one, and I'm a liiiiittle unsure it still works. I need an IE user to test it out. Rillke? :D" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (owner: 10MarkTraceur) [05:52:17] (03PS5) 10Werdna: Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 [05:54:32] (03CR) 10Spage: [C: 031] "Chris, PS6 passes for me on ee-flow.wmflabs.org \o/ ! But flow_logged_in.feature fails on beta labs because on that wiki, Selenium_user h" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [05:56:55] (03CR) 10Werdna: "Updated to address comments, rebased. Should be ready for a second review now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [05:57:08] (03CR) 10Werdna: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [06:34:36] (03PS1) 10MarkTraceur: jquery audit and code convention fixes for mw.UWUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86814 [06:34:41] Fucking. Code. Formatting. [06:35:01] * marktraceur spent about ten minutes looking stupidly at a broken interface because of poorly formatted HTML [06:39:07] <4 [06:46:52] Nikerabbit: >3 [06:49:11] ouch, natural impossibility [07:09:12] (03PS1) 10Liangent: New diff variables regarding pre-save transformed wikitext [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 [07:27:32] (03CR) 10Swalling: "(1 comment)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [07:28:51] (03PS7) 10Werdna: Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 [07:39:08] (03CR) 10Werdna: "I made Benny's changes apply across all notifications, refactored UrlGenerator to allow you to pull a Title and query string, took advanta" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [07:41:20] (03PS29) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [07:41:36] (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:20:47] (03CR) 10Hashar: [C: 032] "I am wondering what was happening before .... Anyway that is fine, deploying." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:23:34] (03CR) 10Hashar: "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:23:37] (03PS2) 10Hashar: Make pyflakes work on all files by default [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:24:39] (03PS3) 10Hashar: Make pyflakes work on all files by default [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:28:51] (03CR) 10Hashar: [C: 032] "deployed :-] Thank you!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:29:08] (03Merged) 10jenkins-bot: Make pyflakes work on all files by default [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86727 (owner: 10Merlijn van Deen) [08:31:59] (03PS30) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [09:04:19] (03CR) 10Aklapper: [C: 031] "Looks good to me" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86799 (owner: 10TTO) [09:31:36] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke) [09:40:16] (03PS1) 10Yurik: Zero Ext Update [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86825 [09:40:46] (03PS1) 10Yurik: Zero Ext Update [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86826 [09:41:19] (03CR) 10Yurik: [C: 032 V: 032] Zero Ext Update [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86826 (owner: 10Yurik) [09:41:21] (03CR) 10Yurik: [C: 032 V: 032] Zero Ext Update [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86825 (owner: 10Yurik) [10:13:40] MaxSem: ping? [10:14:35] MaxSem: so, I'm going to 1. Update templatelinks on PageContentSaveComplete, 2. invalidate the cache via LinksUpdate, which on the cluster will be run via the JobQueue [10:14:40] sounds good? [10:15:11] it does [10:15:54] okay, let me get the patch done [10:16:07] took me a while to figure out how LinksUpdate actually runs. grrr. [10:16:41] MaxSem: this way I also don't need to recursively track dependencies! [10:17:02] pfft [10:34:56] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [10:37:07] (03PS1) 10Rillke: Use $.toJSON instead of JSON.parse for compatability and [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86828 [10:48:02] (03CR) 10Yuvipanda: [C: 032] "LGTM" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86828 (owner: 10Rillke) [10:48:06] (03Merged) 10jenkins-bot: Use $.toJSON instead of JSON.parse for compatability and [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86828 (owner: 10Rillke) [10:48:45] (03CR) 10Yuvipanda: "Didn't catch the mistake in the commit message (says .toJSON rather than .parseJSON). Oh well." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86828 (owner: 10Rillke) [10:52:28] is there some tool to split a mediawiki dump file [10:53:07] so the resulting files are still valid dump files and can be imported one by one [10:54:02] (03CR) 10Rillke: "Arghhh, sorry! At Commons I work with the jQuery.json plugin all the time." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86828 (owner: 10Rillke) [11:07:55] (03PS1) 10Zfilipin: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 [11:22:22] liangent: I might have something around, it's not hard to do though by the command line [11:22:43] the problem is speed, if you want the file sitting on disk (as opposed to stdin to something) there's all the recompression time [11:23:14] (03PS1) 10Zfilipin: Deleted Jenkins jobs that run ULS tests at sandbox.translatewiki.net [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86832 [11:24:21] basically you have to cat the mediawikitag and the siteinfo stuff, then as many pages out of the file as you want (skipping over as many as you want)... then a close mediawikitag. but all this means uncompressing the original file to read and (unless you have lots of space) recompressing it to write it back out [11:26:34] apergos: piping them into another program is fine [11:26:40] ok [11:26:53] the issue is that the second program doesn't work well with a huge dump [11:26:57] ah [11:27:04] what platform are you on? [11:27:20] apergos: linux [11:27:23] on tool lab [11:27:45] ok I have a cheesy program writeupto or something like that, give it page id ranges and it will write out with headers and close tag for you [11:29:58] apergos: so is there another helper program to get the maximum page id? [11:30:20] um actually there is a program that will dump the last bz2 block and you can grep for it [11:30:20] :-D [11:30:52] I have a bunch of these weird little toosl from having to whack at the bz2 files so much in the past [11:31:21] they are in the operations/dumps git repo. all the little c programs 'mwbzutils' directory I think it is. you want my branch (ariel) [11:32:58] yurik: did you ever get to find how to profile php code in vagrant with phpstorm? [11:34:08] apergos: btw another idea than page id range: if it's known that the second program works well with 1/10 size of the original file, I can start 10 processes, and let the Nth processes pages with pageid%10==N [11:34:29] sure [11:35:53] apergos: in operations / dumps, it seems branches are not really branches... [11:36:01] they're used as individual repos? [11:36:05] eh [11:36:16] it's cause I started out developing there [11:36:29] and then was ever too chicken to actually just commit it all to master :- [11:36:32] :-/ [11:36:43] and so years later we've been running this code in production forever... [11:37:01] (03PS1) 10Zfilipin: @language tag is now only used in ULS repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86837 [11:38:42] * werdna waves [11:39:29] apergos: how can I use it now? I've done clone, checkout, make [11:40:53] oh. well there's a readme I think [11:40:56] sec [11:42:10] nice I don't document that writeupto script cause it wasn' part of the original utils [11:42:31] give --help or -h and it will tell you [11:42:41] pretty much all my scripts are like that [11:44:34] I just cannot seem to get any profiling data what so ever :| [11:48:33] hello werdna [11:48:36] now I see the wave [11:48:38] ello [11:48:49] where in the world is werdna today? [11:48:57] back in Sydney [11:49:10] finally [11:49:44] resting up for the next trip? [11:51:48] (03CR) 10Rillke: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86811 (owner: 10MarkTraceur) [11:56:36] legoktm: do you have a small script of sorts that can easily mass null edit pages for me? Need it to test something in my dev-wiki. [11:58:06] apergos: http://pastebin.com/ZG1NJ8AK is there more places to change? [12:01:40] gaaaah [12:01:43] profiler just refuses to exist [12:01:49] * YuviPanda stabs mediawiki [12:02:46] (03CR) 10Dzahn: [C: 032] "just a border color / CSS" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86799 (owner: 10TTO) [12:02:55] (03CR) 10Dzahn: [V: 032] "just a border color / CSS" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86799 (owner: 10TTO) [12:03:19] seems like that's it [12:04:50] I should come back to this when more people are actually awake. [12:04:50] uh when do you return AtLastPageID then? [12:05:55] I guess you don't, just wait for NULL from the fgets? [12:09:24] (03PS1) 10Zfilipin: There is new repository with browser tests, TwnMainPage [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 [12:14:58] (03PS1) 10Zfilipin: Run tests at dev.translatewiki.net [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 [12:18:55] (03PS1) 10Hashar: remove git-setup [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86843 [12:19:19] (03CR) 10Hashar: [C: 032] remove git-setup [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86843 (owner: 10Hashar) [12:28:22] (03PS1) 10Zfilipin: Updated the repository to the latest version of shared test files [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86845 [12:47:59] Are dzahn, lcarr or rhalsell around? [12:49:18] (03Merged) 10jenkins-bot: remove git-setup [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86843 (owner: 10Hashar) [12:49:56] Krenair: what's up [12:50:08] pm [13:30:09] (03PS2) 10Hashar: lint jobs for wikimedia/fundraising repos [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86703 (owner: 10Adamw) [13:32:53] (03CR) 10Hashar: [C: 032] "Deployed. Thank you :)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86703 (owner: 10Adamw) [13:33:10] (03Merged) 10jenkins-bot: lint jobs for wikimedia/fundraising repos [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86703 (owner: 10Adamw) [13:34:02] (03PS2) 10Hashar: jobs for wikimedia/fundraising/crm* [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86705 (owner: 10Adamw) [13:35:36] (03CR) 10Hashar: [C: 032] "Deploying, thanks Adam." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86705 (owner: 10Adamw) [13:35:41] (03Merged) 10jenkins-bot: jobs for wikimedia/fundraising/crm* [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86705 (owner: 10Adamw) [13:41:40] anyone who has done stuff with the profiler before? [13:41:41] (03CR) 10Alex Monk: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/64216 (owner: 10Pgehres) [13:41:46] i can't seem to get it to work, no matter what :| [13:43:04] (03CR) 10Alex Monk: [C: 032] Complete rename to EmailableUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86421 (owner: 10Nemo bis) [13:43:08] (03Merged) 10jenkins-bot: Complete rename to EmailableUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86421 (owner: 10Nemo bis) [13:45:12] (03CR) 10Siebrand: [C: 04-1] "Please add message documentation for all newly added messages. Currently 3/10. See https://www.mediawiki.org/wiki/I18n#Message_documentati" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [13:45:28] siebrand: yeah, that's mentioned in a comment [13:45:32] but I had an appointment [13:46:00] werdna: Sure. Just going through my mediawiki-commits mail. [13:46:05] :p [13:46:14] I didn't realise people still read that [13:46:32] werdna: It's the only way to find out what i18n and L10n changes... [13:46:37] siebrand is a commit-reading ninja [13:46:46] that's how he tells us what we did wrong in i18n :) [13:46:50] * werdna wonders if the two descriptors are related. [13:46:57] he is commit-reading and he is also a ninja [13:47:08] ;) [13:47:16] Your pings distract me ;) [13:47:21] Siebrand is an instance of Ninja [13:47:21] or he is a ninja of the commit-reading variety [13:47:23] 132 to go... [13:47:58] class Siebrand extends Ninja implements ICommitReader [13:48:04] meanwhile, cooked are being clicked... [13:48:14] cookies, that is. [13:48:15] :o [13:48:26] damn Nikerabbit and his cookies. [13:48:40] he stopped! [13:48:57] Nemo_bis: That's a secret! Amir can't know! [13:49:22] ohnoes [13:57:11] (03PS1) 10Manybubbles: Switch English to kstem. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86853 [13:57:19] (03PS1) 10Manybubbles: Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 [13:57:56] (03CR) 10KartikMistry: [C: 031] "LGTM." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [14:03:45] (03CR) 10Chad: [C: 032] Tests for programmer friendly word splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86782 (owner: 10Manybubbles) [14:03:48] (03Merged) 10jenkins-bot: Tests for programmer friendly word splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86782 (owner: 10Manybubbles) [14:04:07] oh, its chad's breakfast time [14:04:58] mmmm breakfast [14:05:32] (03CR) 10Chad: [C: 032] SearchUpdate should read from master. [core] - 10https://gerrit.wikimedia.org/r/86704 (owner: 10Manybubbles) [14:06:54] (03CR) 10Chad: [C: 032] Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 (owner: 10Manybubbles) [14:06:57] (03CR) 10jenkins-bot: [V: 04-1] Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 (owner: 10Manybubbles) [14:08:21] (03CR) 10Chad: [C: 032] "We can start with mw.org and then see if others need it too." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86781 (owner: 10Manybubbles) [14:08:24] (03Merged) 10jenkins-bot: Allow aggressive splitting. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86781 (owner: 10Manybubbles) [14:09:13] (03Merged) 10jenkins-bot: SearchUpdate should read from master. [core] - 10https://gerrit.wikimedia.org/r/86704 (owner: 10Manybubbles) [14:09:39] (03CR) 10Chad: "Needs rebase, otherwise ok." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86853 (owner: 10Manybubbles) [14:10:00] (03CR) 10Chad: "Needs rebase, otherwise ok." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 (owner: 10Manybubbles) [14:11:37] (03PS2) 10Manybubbles: Switch English to kstem. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86853 [14:21:46] (03PS1) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [14:27:51] (03CR) 10Chad: [C: 032] Switch English to kstem. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86853 (owner: 10Manybubbles) [14:27:52] (03Merged) 10jenkins-bot: Switch English to kstem. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86853 (owner: 10Manybubbles) [14:31:37] (03PS2) 10Nemo bis: User words in twnmp-*-per-month and add PLURAL [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 [14:32:04] (03PS3) 10Nemo bis: User words in twnmp-*-per-month and add PLURAL [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 [14:32:56] (03PS4) 10Nemo bis: Use words in twnmp-*-per-month and add PLURAL [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 [14:34:02] (03PS2) 10Manybubbles: Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 [14:44:51] (03PS2) 10Anomie: Remove $wgCentralAuthSilentLogin, defaulted to true [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/69312 [14:45:03] (03PS5) 10Anomie: Remove Special:AutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/64253 [14:45:15] (03CR) 10Nikerabbit: [C: 04-1] "We need to discuss this on one of our meetings." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86832 (owner: 10Zfilipin) [14:46:44] (03CR) 10Nikerabbit: [C: 031] @language tag is now only used in ULS repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86837 (owner: 10Zfilipin) [14:48:39] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 (owner: 10Aaron Schulz) [14:50:36] (03PS3) 10Manybubbles: Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 [14:52:45] (03CR) 10Zfilipin: [C: 032] "Looks good to me. I will not merge it into master myself, since this is a big change, I would like to leave enough time for Chris to take " [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86740 (owner: 10Plavi) [14:54:54] (03CR) 10Zfilipin: "The Jenkins jobs are already deleted, this is just the documentation. We have a lot of failing jobs, and we have to get them back to green" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86832 (owner: 10Zfilipin) [14:59:10] (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [15:00:07] (03CR) 10Siebrand: [C: 032] Correct twnmp-show-more-projects to say "all projects" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86755 (owner: 10Nemo bis) [15:00:14] (03Merged) 10jenkins-bot: Correct twnmp-show-more-projects to say "all projects" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86755 (owner: 10Nemo bis) [15:06:19] (03CR) 10Chad: [C: 032] Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 (owner: 10Manybubbles) [15:06:21] (03Merged) 10jenkins-bot: Tests for places where kstem beats porter stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86854 (owner: 10Manybubbles) [15:15:43] (03PS2) 10Zfilipin: Run tests at dev.translatewiki.net [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 [15:16:48] (03CR) 10Zfilipin: "Updated the commit according to comment at QA mailing list:" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 (owner: 10Zfilipin) [15:20:59] (03PS2) 10Isarra: Split grabText into text, newtext, and namespaceinfo scripts [tools/grabbers] - 10https://gerrit.wikimedia.org/r/86768 [15:22:53] (03PS3) 10Zfilipin: Run tests at sandbox.translatewiki.net [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 [15:24:47] (03CR) 10Isarra: [C: 032 V: 032] "WHOO PROGRESS or something." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/86768 (owner: 10Isarra) [15:26:08] MaxSem: ping? [15:26:14] pong [15:26:15] (03PS2) 10Zfilipin: There is new repository with browser tests, TwnMainPage [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 [15:26:39] MaxSem: I'm trying to profile locally with caching on, and failing miserably in getting it to do any form of profiling at all [15:26:51] MaxSem: am following https://www.mediawiki.org/wiki/Manual:How_to_debug#Profiling [15:26:55] MaxSem: is there anything I'm missing? [15:27:02] profiling table on db is empty, debuglog also doesn't have anything [15:27:21] I could go try to setup xdebug and stuff, but this should really answer the questions I have... [15:27:31] (03CR) 10Zfilipin: "Updated the commit according to comment at QA mailing list:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [15:28:43] YuviPanda: pywikibot's touch.py [15:29:05] legoktm: ah, hmm. let me look [15:29:41] YuviPanda, I simply do $wgProfiler['class'] = 'Profiler'; and have a debug log set uo [15:29:46] *set up [15:29:51] i've got the same thing. [15:30:08] maybe I should clear out all the things and start from scratch agian [15:30:21] or maybe just make the changes blind. [15:30:31] can't you just disable caching? [15:30:44] legoktm: well, this patch is *adding* caching :P [15:30:54] so I want to profile so I can find out how much of an effect it is having [15:31:33] heh. [15:54:06] (03PS1) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [15:57:09] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [15:58:22] hashar: Hi, sorry for the delay. I thought it was at 18:00 [15:59:20] (03PS1) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [15:59:35] (03PS2) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [16:00:08] Krinkle: it is ok [16:02:01] Krinkle: https://gerrit.wikimedia.org/r/86868 [16:02:06] Krinkle: lamely copy pasted from qunit [16:03:27] csteipp: https://gerrit.wikimedia.org/r/#/c/86809/ [16:06:39] (03CR) 10CSteipp: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 (owner: 10Aaron Schulz) [16:06:40] (03PS1) 10Nemo bis: Fix typo in comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86869 [16:12:34] (03CR) 10Manybubbles: [C: 032] Fix typo in comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86869 (owner: 10Nemo bis) [16:12:36] (03Merged) 10jenkins-bot: Fix typo in comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86869 (owner: 10Nemo bis) [16:14:15] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/86870 [16:14:53] (03PS2) 10Chad: Refactor Elastica [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 [16:15:01] Krinkle: lame change against REL1_19 https://gerrit.wikimedia.org/r/#/c/86870/ [16:16:43] (03PS2) 10Aaron Schulz: Cleaned up https redirect code to be more consistent [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 [16:20:58] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86832 (owner: 10Zfilipin) [16:21:37] Krinkle: (?!REL1_19)^(\.jshint|.*\.(js|json)$) [16:21:47] (03PS1) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86873 [16:21:53] (03PS4) 10Cmcmahon: Run tests at sandbox.translatewiki.net [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 (owner: 10Zfilipin) [16:22:20] (03CR) 10Cmcmahon: [C: 032] "run language tests in sandbox wiki" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 (owner: 10Zfilipin) [16:23:00] (03PS3) 10Cmcmahon: There is new repository with browser tests, TwnMainPage [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [16:23:04] (03Merged) 10jenkins-bot: Run tests at sandbox.translatewiki.net [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86842 (owner: 10Zfilipin) [16:23:10] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [16:24:14] (03PS2) 10Cmcmahon: @language tag is now only used in ULS repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86837 (owner: 10Zfilipin) [16:24:27] (03CR) 10Cmcmahon: [C: 032] "maintenance for language tests" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86837 (owner: 10Zfilipin) [16:24:59] (03PS1) 10Anomie: Add centralauth-welcomecreation-msg [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86874 [16:25:21] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86873 (owner: 10Krinkle) [16:26:12] (03CR) 10Manybubbles: [C: 04-1] "(2 comments)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [16:27:26] (03PS2) 10Cmcmahon: Updated the repository to the latest version of shared test files [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86845 (owner: 10Zfilipin) [16:27:35] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86845 (owner: 10Zfilipin) [16:29:53] (03CR) 10MarkTraceur: "> I think this could use some documentation..." [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [16:30:08] brion: tl;dr I'm still trying to understand it myself [16:31:51] (03PS2) 10Cmcmahon: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [16:32:05] (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [16:33:37] (03PS1) 10Aklapper: Remove ugly background images of buttons when changing search result columns. Can be seen on https://bugzilla.wikimedia.org/colchange.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86877 [16:35:51] (03PS2) 10Cmcmahon: Created the MEDIAWIKI_USER environment variable [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86740 (owner: 10Plavi) [16:36:36] (03CR) 10Aklapper: [C: 031] "Change can be seen by comparing https://boogs.wmflabs.org/colchange.cgi to https://bugzilla.wikimedia.org/colchange.cgi" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86877 (owner: 10Aklapper) [16:39:51] (03CR) 10Cmcmahon: [C: 032] "this is a good idea, thank you! We are changing the Jenkins builds to use MEDIAWIKI_USERNAME environment variable also" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86740 (owner: 10Plavi) [16:43:47] I'm trying to submit a patch, and my console just hangs after I do 'git review'. [16:43:57] Any ideas why that happens? [16:44:19] ragesoss: what OS? [16:44:26] ragesoss: and is this the first patch? [16:44:28] (03CR) 10Chad: "(1 comment)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [16:44:50] YuviPanda: Debian, and not the first patch on this system. [16:45:11] ragesoss: try ctrl-c'ing it, and just doing 'git push gerrit HEAD:refs/for/master' instead? [16:46:24] YuviPanda: is 'refs/for/master' something I replace with actual refs for master? [16:46:31] ragesoss: nope, just verbatim [16:47:16] did that, same thing is happening. [16:47:26] ragesoss: try just doing 'ssh gerrit.wikimedia.org'? [16:48:28] YuviPanda: I cannot connect. so I guess I have a key problem. bah. [16:48:33] yeah [16:48:42] thanks for pointing me in the right direction. [16:48:42] (03PS6) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [16:49:03] ragesoss: if you do 'ssh -v gerrit.wikimedia.org', you can narrow it down even further [16:49:08] ragesoss: try that? [16:49:12] ragesoss: and pastebin the output? [16:50:57] ok i'm forgetfull whats mflaschen's irc name (or is he just not on irc, possible too :) [16:51:06] ebernhardson: superm401 [16:51:15] ebernhardson: he's always on IRC :D [16:51:15] ahh perfect :) [16:51:33] YuviPanda: also was curious, what do i file the bug against to ask for grrit in #wikimedia-corefeatures ? [16:51:49] ebernhardson: bugzilla, wikimedia general [16:51:56] ebernhardson: remember to cc me [16:52:04] superm401: hi, is there a google hangouts setup yet for the interview? [16:52:08] YuviPanda: ok, gotcha [16:52:20] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/86870 (owner: 10Hashar) [16:52:26] ebernhardson: need list of extensions for which to send the messages there. [16:52:38] ebernhardson: and also wether they should also be sent to -dev, or just to -corefeatures [16:52:49] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86879 [16:52:51] ebernhardson, yeah, it's linked from the calendar entry "Onsite interview for Todd Treece- Software Engineer - Core Features" [16:53:06] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86393 (owner: 10MarkTraceur) [16:53:45] (03PS2) 10Umherirrender: Use always context for messages on ImagePage [core] - 10https://gerrit.wikimedia.org/r/86008 [16:54:04] superm401: ok, i'll be heading over and setting up my laptop there in a minute. benny isn't in the office yet(neither is todd, afaik) but he usually walks in right at 10 [16:54:32] (03CR) 10MarkTraceur: "Urgh that's annoying." [core] - 10https://gerrit.wikimedia.org/r/86393 (owner: 10MarkTraceur) [16:56:02] (03CR) 10Siebrand: [C: 032] Modules should be in English (while docs are not) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/65998 (owner: 10Liangent) [16:57:26] (03Merged) 10jenkins-bot: Modules should be in English (while docs are not) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/65998 (owner: 10Liangent) [16:57:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86879 (owner: 10Hashar) [16:57:59] (03CR) 10CSteipp: [C: 032] Cleaned up https redirect code to be more consistent [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 (owner: 10Aaron Schulz) [16:58:04] (03Merged) 10jenkins-bot: Cleaned up https redirect code to be more consistent [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86809 (owner: 10Aaron Schulz) [17:02:07] (03CR) 10Bartosz Dziewoński: [C: 031] "These could probably be fixed to at least display one arrow per button and not display the default text ones, but it'd still look ugly." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86877 (owner: 10Aklapper) [17:18:20] (03CR) 10Siebrand: [C: 04-2] Use words in twnmp-*-per-month and add PLURAL [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86747 (owner: 10Nemo bis) [17:18:36] (03PS1) 10Ragesoss: Increase limits to Special:MyCourses activity feeds [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/86880 [17:19:43] siebrand: want me to abandon it? [17:20:09] Nemo_bis: I want to take a very good look at it, and block anyone from merging it before that's done. [17:20:52] oki [17:20:58] thanks for looking into it [17:36:39] (03CR) 10CSteipp: [C: 032] "Looks good, and working great in test. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/69312 (owner: 10Anomie) [17:36:44] (03Merged) 10jenkins-bot: Remove $wgCentralAuthSilentLogin, defaulted to true [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/69312 (owner: 10Anomie) [17:38:39] (03PS6) 10CSteipp: Remove Special:AutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/64253 (owner: 10Anomie) [17:40:54] (03PS1) 10BryanDavis: New maintenance script to purge edited pages. [core] - 10https://gerrit.wikimedia.org/r/86883 [17:47:57] (03CR) 10CSteipp: [C: 032] "Looks good, working in test. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/64253 (owner: 10Anomie) [17:48:00] (03Merged) 10jenkins-bot: Remove Special:AutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/64253 (owner: 10Anomie) [17:48:25] (03CR) 10Bartosz Dziewoński: [C: 031] "(Added S Page as reviewer; please add anyone else who might be interested.) Assuming nobody is opposed, I'm going to merge this on Friday." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [17:50:12] (03CR) 10Kipcool: [C: 032 V: 032] is_the_job bug and POST regeneration [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/86786 (owner: 10Hiong3-eng5) [17:50:18] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [17:52:11] csteipp: is that an automatic summary? [17:54:00] more notes to self [17:55:16] (03PS1) 10Aklapper: Misc. CSS typo fixes; Firefox compatibility fixes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86884 [17:55:21] (03CR) 10Bartosz Dziewoński: "I've filed bug 54835 about consistency of links to mw.org, but I don't consider it to be a blocker." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [17:56:07] greg-g: Any chance of an urgent deploy cherry-pick window for VE? I see the calendar's open… (bug 54443). [17:57:13] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [17:57:32] James_F: sure thing. [17:57:40] James_F: please add to calendar. [17:57:41] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [17:57:49] greg-g: Kk. Thanks. :-) [17:58:42] np, go forth and fix arrow keys [17:59:00] (03PS1) 10Krinkle: Fix comma errors in various js files (new jshint warning) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86885 [17:59:16] (03CR) 10Krinkle: [C: 032] "Backport from master." [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86885 (owner: 10Krinkle) [18:00:48] (03CR) 10Nemo bis: "Siebrand, MatmaRex answered you in the bug above. :)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:02:35] (03PS1) 10Krinkle: Fix comma errors in various js files (new jshint warning) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86886 [18:03:13] (03CR) 10Krinkle: [C: 032] "Fixes the build, backport from master." [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86886 (owner: 10Krinkle) [18:03:42] siebrand: also, as the commit says, the prefix *is* part of the default [18:03:59] (of course one can still not like it; just saying) [18:04:21] (03Merged) 10jenkins-bot: Fix comma errors in various js files (new jshint warning) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86885 (owner: 10Krinkle) [18:04:42] (03PS2) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86873 [18:07:41] (03PS7) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 [18:10:32] (03Merged) 10jenkins-bot: Fix comma errors in various js files (new jshint warning) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86886 (owner: 10Krinkle) [18:10:42] (03PS2) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/86879 (owner: 10Hashar) [18:11:57] (03PS1) 10Manybubbles: Remove index named after alias. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86888 [18:17:21] (03CR) 10Brion VIBBER: [C: 04-2] "Interwiki prefixes should never be used in default messages, as you cannot guarantee any of them will be present or set the way you expect" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:18:15] (03CR) 10Cmcmahon: "So I did this at least for now:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [18:19:08] (03CR) 10Bartosz Dziewoński: "They *should* be there, and removing them would be something akin to removing one of the default namespaces (in other words, extraordinari" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:20:08] ori-l: Paging you to 6 [18:20:15] coming [18:21:05] (03CR) 10MaxSem: "Nope, removing interwikis is perfectly fine and relying on users not doing so is bound to fail." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:22:33] (03PS1) 10MaxSem: Fix comment typos from I733b53171dca77f50a30e5bd0bd5f1b456e4c85d [core] - 10https://gerrit.wikimedia.org/r/86890 [18:22:59] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [18:23:38] (03PS3) 10Cmcmahon: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [18:23:43] (03CR) 10Krinkle: [C: 04-1] "Cleaning interwiki prefixes is afaik far more common (and sensible) than cleaning namespaces. I know that at least in my case, for wikis I" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:23:51] (03CR) 10Cmcmahon: [C: 032] Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [18:24:11] (03PS4) 10Cmcmahon: There is new repository with browser tests, TwnMainPage [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [18:24:18] (03CR) 10Cmcmahon: [C: 032] There is new repository with browser tests, TwnMainPage [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86841 (owner: 10Zfilipin) [18:24:56] (03CR) 10Nemo bis: "Hey, Brion's -2 is enough, I'm amending the patch. :)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:28:53] (03CR) 10Krinkle: "Using URLs seems like an established approach in this case, though beware though that linking to MediaWiki.org here (regardless of how) wo" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:30:13] (03PS4) 10Cmcmahon: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [18:30:30] (03CR) 10Cmcmahon: [C: 032] Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86830 (owner: 10Zfilipin) [18:33:57] (03PS2) 10Manybubbles: Remove index named after alias. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86888 [18:36:04] (03CR) 10Nemo bis: "Krinkle, there isn't any inconsistency, please see the bug and its parent bug." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:43:39] (03CR) 10MaxSem: [C: 031] New maintenance script to purge edited pages. [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [18:46:24] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [18:47:03] (03CR) 10Catrope: [C: 04-1] "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [18:48:57] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [18:51:35] (03PS2) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 [18:55:51] (03CR) 10Nemo bis: "Comments addressed by PS2. Brion, I think you can lift your -2 now?" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:56:20] (03CR) 10Parent5446: [C: 04-2] "...isn't this what browser caching is for? Unless by "modules" you mean something other than JS and CSS will be cached." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [18:56:38] MaxSem: Thanks for the +1. [19:02:29] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:02:53] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [19:08:19] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [19:14:08] (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [19:15:32] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [19:25:26] MaxSem: thanks for that comment :) [19:26:32] (03CR) 10Parent5446: "@Ori: Thanks for the explanation. I understand now." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:28:20] bleh [19:28:22] my bouncer's dead [19:28:48] (03PS1) 10Manybubbles: More efficient alias maintenance. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86974 [19:29:00] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [19:30:06] (03CR) 10Parent5446: [C: 032] Fix comment typos from I733b53171dca77f50a30e5bd0bd5f1b456e4c85d [core] - 10https://gerrit.wikimedia.org/r/86890 (owner: 10MaxSem) [19:30:54] back! [19:31:01] brion: saw the patchset? [19:31:26] YuviPanda: ? [19:31:32] brion: https://gerrit.wikimedia.org/r/#/c/86960/ [19:31:39] <^d> Whee, https://bugzilla.wikimedia.org/show_bug.cgi?id=54840 [19:31:45] (03CR) 10Yuvipanda: [C: 04-1] "Doesn't do per language cache" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 (owner: 10Yuvipanda) [19:32:13] apple's gotta find a better way to switch monitors in their remote desktop client. [19:32:24] or i gotta turn off my second monitor when using the other computer from upstairs [19:32:29] brion: heh [19:32:29] i say more work for apple, less for me [19:32:34] (03PS2) 10Aaron Schulz: Fix comment typos from I733b53171dca77f50a30e5bd0bd5f1b456e4c85d [core] - 10https://gerrit.wikimedia.org/r/86890 (owner: 10MaxSem) [19:32:47] ok will look over the caching patch shortly :D [19:32:51] * brion nom nom noms for lunch [19:33:42] (03CR) 10MaxSem: "@Aaron Schulz: requests like ones containing most of wiki's modules easily contain dozens of stylesheets, each minified separately. This c" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [19:34:01] (03CR) 10Aaron Schulz: "Changed hash to the git one instead of the gerrit -specific one in the summary" [core] - 10https://gerrit.wikimedia.org/r/86890 (owner: 10MaxSem) [19:36:55] (03CR) 10Aaron Schulz: "Any example numbers from requests? Like 30, 50, 70 modules?" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [19:37:26] (03CR) 10Aaron Schulz: [C: 032] Fix comment typos from 5c51cb96eaea76d22b9c48928044a942c4be2feb [core] - 10https://gerrit.wikimedia.org/r/86890 (owner: 10MaxSem) [19:37:57] (03CR) 10Aaron Schulz: [C: 04-1] "In any case, can this at least use class constants?" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [19:38:48] AaronSchulz, what's the point of constants used precisely 1 time? That actually reduces readability, not vice versa [19:39:12] <^d> Who's got two thumbs and can run all of MediaWiki's unit tests in < 2m? [19:39:14] <^d> This guy. [19:40:18] ...by blanking parserTests.txt, ^d?:P [19:40:28] <^d> hhvm :p [19:40:30] (03Merged) 10jenkins-bot: Fix comment typos from 5c51cb96eaea76d22b9c48928044a942c4be2feb [core] - 10https://gerrit.wikimedia.org/r/86890 (owner: 10MaxSem) [19:40:43] xDD [19:40:52] <^d> https://www.mediawiki.org/wiki/User:%5Edemon/hiphop-phpunit [19:41:00] <^d> My goal is 100% passing. [19:41:03] echo phpunit.php [19:42:20] MaxSem: using constants or local variables makes the expressions more about the concept than random specific numbers and is more self-documenting [19:43:18] <^d> Platonides: That's with me suppressing a notice though... I don't think DBO_IGNORE works :\ [19:43:54] ^d: btw, I'd like to kill DBO_IGNORE [19:44:06] for some time [19:44:15] <^d> Long as whatever you replace it with works in hhvm....I don't care much :) [19:49:20] <^demon|lunch> Somebody broke timestamps: http://p.defau.lt/?fYnwWudgIZ_2Mp26F61svA [19:49:23] <^demon|lunch> Same with hhvm. [19:49:41] <^demon|lunch> Ok, food. [19:51:19] (03PS2) 10Yuvipanda: Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [19:51:58] (03PS8) 10Legoktm: Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [19:52:46] (03CR) 10Manybubbles: "Master nodes in Elasticsearch as just cluster state masters, not document masters. That page you linked suggests sending all requests to " [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [19:52:51] (03CR) 10jenkins-bot: [V: 04-1] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm) [19:55:00] (03CR) 10Krinkle: [C: 031] "The removal of that unused code in WebOutput looks good (confirmed not used anywhere else, not since at least v1.19)" [core] - 10https://gerrit.wikimedia.org/r/86696 (owner: 10PleaseStand) [19:56:18] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [19:57:09] (03CR) 10Krinkle: "https://github.com/leafo/lessphp/pull/480" [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [19:57:21] (03Abandoned) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/86873 (owner: 10Krinkle) [19:58:23] (03PS2) 10BryanDavis: New maintenance script to purge edited pages. [core] - 10https://gerrit.wikimedia.org/r/86883 [19:59:17] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86991 [19:59:18] (03PS1) 10MaxSem: Update GeoData to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86992 [19:59:19] (03PS1) 10MaxSem: Update ZeroRatedMobileAccess to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86993 [20:00:35] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86991 (owner: 10MaxSem) [20:00:46] (03CR) 10MaxSem: [C: 032 V: 032] Update GeoData to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86992 (owner: 10MaxSem) [20:00:57] (03CR) 10MaxSem: [C: 032 V: 032] Update ZeroRatedMobileAccess to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86993 (owner: 10MaxSem) [20:02:19] why does MobileFrontend have a $dbr->ignoreErrors( true ); call but it doesn't reset it [20:02:27] * AaronSchulz remembers why he hates ignoreErrors() being public [20:02:56] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/65319 (owner: 10Luis Felipe Schenone) [20:05:55] (03CR) 10Krinkle: "What is "[out]" supposed to mean? (used in various instances of @param documentation)." [core] - 10https://gerrit.wikimedia.org/r/72866 (owner: 10Parent5446) [20:06:22] (03CR) 10BryanDavis: "Updated to address review feedback. Looking for consensus on a better script name." [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [20:06:52] (03CR) 10BryanDavis: "(8 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [20:09:28] (03PS1) 10Aaron Schulz: Added comment about not using ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/86998 [20:10:19] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [20:10:25] (03CR) 10Brion VIBBER: "coupla notes" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 (owner: 10Yuvipanda) [20:10:52] brion: where... are the notes?! [20:11:08] agh [20:11:12] YuviPanda: they're…. on the wrong patchset [20:11:14] yuvipanda: They're under there [20:11:15] lemme try that again :D [20:11:47] marktraceur: over there? [20:11:52] No, under there. [20:12:26] marktraceur: i don't see 'em [20:12:32] * marktraceur sighs [20:12:34] I tried [20:12:53] oh god there's both =& and &= in PHP? [20:12:59] is &= same as &&= ? [20:13:03] or does &&= work [20:13:24] marktraceur: it whooshed past me [20:13:29] brion: o_O O_o [20:13:31] (03PS1) 10Legoktm: Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 [20:13:44] brion, try not to think about it, you might die [20:13:55] yuvipanda: When someone says "under there", likely they're trying to get you to say "under where" [20:14:01] Which is hilarious. [20:14:04] marktraceur: oh [20:14:19] marktraceur: why is under where funny? [20:14:24] oh [20:14:26] nevermind [20:14:29] * marktraceur snrks [20:14:48] (03PS3) 10BryanDavis: Add script to purge edited pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [20:15:57] gerrit-->bugzilla bot down? [20:16:17] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [20:16:21] (03PS1) 10MaxSem: Update Thanks to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87000 [20:16:33] (03CR) 10MaxSem: [C: 032 V: 032] Update Thanks to master tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87000 (owner: 10MaxSem) [20:18:41] (03CR) 10Brion VIBBER: "(5 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 (owner: 10Yuvipanda) [20:20:30] legoktm: why? [20:20:46] https://gerrit.wikimedia.org/r/86999 didn't leave a comment on the associated bug [20:21:06] gr, wrong button [20:22:21] brion: will fix, thanks! [20:22:23] (03PS1) 10Legoktm: [WIP] Notify a user via Echo once their job is done [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87001 [20:22:24] brion: also, do test! [20:22:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Notify a user via Echo once their job is done [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87001 (owner: 10Legoktm) [20:22:44] (03CR) 10MaxSem: [C: 032] Added comment about not using ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/86998 (owner: 10Aaron Schulz) [20:22:45] :/ [20:22:55] brion: i only now need to figure out a way to make sure that the cache can be done properly varying on language, and also invalidate that properly without running into race conditions [20:23:22] :) [20:23:40] brion: if we had Redis, things like 'cache but vary on language' will be super trivial [20:24:26] legoktm: you have an empty line between the Bug: and the Change-ID: [20:24:34] you should not [20:24:39] so say the gerrit gods [20:24:41] >.> [20:24:46] blame ^demon|lunch [20:24:49] or qchris [20:25:07] (03PS2) 10Legoktm: [WIP] Notify a user via Echo once their job is done [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87001 [20:25:26] No empty line between Change-Id: and Bug: . So says gerrit source code. [20:25:34] (03Merged) 10jenkins-bot: Added comment about not using ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/86998 (owner: 10Aaron Schulz) [20:25:41] (03PS2) 10Legoktm: Add links for the user once the special page has been submitted [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86999 [20:25:43] heh [20:25:53] well it worked [20:25:57] thats silly >.> [20:26:17] we never should have switched to bug numbers in the footer. oh well. [20:26:18] legoktm, MatmaRex: Gerrit picks up what's in the last paragraph. (That's roughly last part after empty line) [20:26:26] ok [20:26:51] qchris: yeah, i assumed that's what it does, i merely don't know why [20:27:18] Someone should fix the COMMIT_MSG hook to avoid this [20:27:21] (03PS9) 10Legoktm: Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [20:27:26] (apart from philosophical "correctness", which might be enough of a reason.) [20:27:36] PleaseStand: this never happened to me using the hook [20:27:41] legoktm: how did you produce that? [20:27:49] How did I what? [20:28:02] the empty line. you added it yourself / intentionally? [20:28:06] oh [20:28:10] yeah, it was me [20:28:13] i committed it [20:28:20] and then added the bug number in an --amend [20:28:26] yeah. [20:28:30] maybe jenkins should check for that [20:28:42] anybody wanna make it? [20:28:49] *crickets* [20:29:22] [V: -2] Commit message formatted incorrectly [20:29:37] makes more sense than just not working [20:33:14] MatmaRex: You're right, the hook does seem to handle this correctly. legoktm's explanation makes sense. [20:34:37] (03PS3) 10Yuvipanda: Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [20:34:41] (03CR) 10EBernhardson (WMF): "I'm submitting a new patchset is just a slight tweak moving the global variable out of TalkpageManager and having it passed in from the co" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [20:35:00] brion: updated with some of the fixes you mentioned. Need to figure out a clean solution for unique [20:35:19] ok [20:36:14] (03PS6) 10EBernhardson (WMF): Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [20:36:32] (03CR) 10EBernhardson (WMF): [C: 032] Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna) [20:37:40] (03CR) 10Aaron Schulz: "Meh, or not, the functions essentially take the role of constants in this case." [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [20:38:39] (03PS4) 10Yuvipanda: [WIP] Add caching & cache invalidation for Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86960 [20:40:42] brion: heading to sleep now. night. [20:41:56] (03PS1) 10EBernhardson (WMF): Merge "Occupy talk pages!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87002 [20:42:05] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87003 [20:42:06] (03PS1) 10MaxSem: Update Thanks to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87004 [20:42:07] (03PS1) 10MaxSem: Update ZeroRatedMobileAccess to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87005 [20:42:08] (03PS1) 10MaxSem: Update GeoData to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87006 [20:42:22] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87003 (owner: 10MaxSem) [20:42:35] (03CR) 10MaxSem: [C: 032 V: 032] Update Thanks to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87004 (owner: 10MaxSem) [20:42:47] (03CR) 10MaxSem: [C: 032 V: 032] Update ZeroRatedMobileAccess to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87005 (owner: 10MaxSem) [20:42:59] (03CR) 10MaxSem: [C: 032 V: 032] Update GeoData to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87006 (owner: 10MaxSem) [20:43:29] (03CR) 10EBernhardson (WMF): [C: 032] "This commit just fixes an accidental change of the $wgFlowOccupyPages default value" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87002 (owner: 10EBernhardson (WMF)) [20:43:51] (03Abandoned) 10EBernhardson (WMF): Merge "Occupy talk pages!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87002 (owner: 10EBernhardson (WMF)) [20:44:36] (03PS1) 10Mwalker: Pushing security updates to donation interface [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/87007 [20:44:56] (03CR) 10Mwalker: [C: 032 V: 032] Pushing security updates to donation interface [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/87007 (owner: 10Mwalker) [20:48:50] (03PS8) 10EBernhardson (WMF): Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [20:49:00] (03CR) 10EBernhardson (WMF): "rebased against most recent master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [20:53:20] (03PS1) 10Mwalker: Another big scary patch - DonationMethod [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/87009 [20:53:26] (03PS1) 10Aaron Schulz: Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 [20:54:11] (03CR) 10Mwalker: [C: 032 V: 032] Another big scary patch - DonationMethod [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/87009 (owner: 10Mwalker) [20:54:38] (03PS2) 10Aaron Schulz: Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 [20:55:02] (03CR) 10EBernhardson (WMF): [C: 032] Move post actions into their own class. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86072 (owner: 10Werdna) [21:00:21] (03PS3) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 [21:02:02] (03PS19) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 [21:03:01] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [21:04:19] (03PS16) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [21:04:32] (03CR) 10Krinkle: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [21:05:24] (03PS3) 10Aaron Schulz: Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 [21:09:06] (03PS17) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [21:09:08] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [21:09:34] (03CR) 10Parent5446: "File name is the only issue. Not sure what it should be..." [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [21:10:32] (03CR) 10Nemo bis: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [21:10:42] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [21:13:34] (03CR) 10Parent5446: "[out] is an indication that the parameter is used to return a value rather than pass something into the function. There's also [in,out] to" [core] - 10https://gerrit.wikimedia.org/r/72866 (owner: 10Parent5446) [21:20:38] Eloquence: Coren wants you for something [21:21:39] heh, something [21:21:53] I dunno why, Coren asked in -staff [21:22:00] see #mediawiki [21:22:20] marktraceur: I didn't notice he was on. Pinged him directly. [21:22:25] 'kay [21:23:04] jdlrobson: Why was 'closed' renamed to arrow-collapsed but 'open' still named 'open' ? [21:23:24] so the problem is it seems we have that image twice in the repository [21:23:30] i wanted to use the same name to point this out [21:23:53] i also think arrow-collapsed is a more descriptive name [21:24:03] open has many meanings [21:25:43] sure [21:26:09] jdlrobson: But you renamed, closed, not open. [21:26:57] huh? Krinkle it's possible that things got confused as in an earlier patch set MatmaRex suggested using the same resource [21:27:01] let me take a look now [21:27:21] there's arrow-collapsed-{ltr,rtl}.{png,svg} and open.{png,svg} [21:27:36] the extension had closed-{ltr,rtl}.{png,svg} and open.{png,svg} [21:29:06] Krinkle: i'm confused with what the issue is - i've simply replaced closed with arrow-collapsed- [21:29:17] so, why not rename open as well? [21:29:38] well my goal was to highlight files that were the same [21:29:48] as far as a i know open doesn't duplicate anything [21:30:10] and i'm not sure what a better name would be [21:30:17] arrow-expanded ? [21:30:21] or arrow-uncollapsed [21:30:29] i try and avoid name bike shedding where possible :) [21:30:31] Just be consistent :) [21:30:45] well in a way i'm being consistent.. with the last patch set ;-) [21:31:00] is that the only thing stopping you merging - i'm happy to fix that up now if so [21:31:04] and if you suggest a name [21:31:06] it's consistent with another file somewhere that is unlikely to be seen in the same context, unless you're explicitly compareing the two files. [21:31:08] as i really don't care [21:31:43] arrow-expanded seems sensible [21:31:47] Just looking through [21:31:48] ok i'll do that now [21:32:47] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [21:35:09] (03PS20) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 [21:35:14] ^ Krinkle [21:35:17] hey AaronSchulz, yt? [21:35:53] ori-l: slightly panicked [21:36:09] oh, ok, i have a non-urgent question, so go panic instead :P [21:38:27] what is it? [21:39:00] AaronSchulz: in StatCounter.php, what's the purpose of: array_unshift( $lines, "stats/{$id} - 1 1 1 1 1 -total\n" ); [21:39:03] (03PS18) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [21:39:15] Krinkle: still there ? [21:39:24] is it to act as a message boundary, or to count the number of total datagrams sent, or? [21:40:13] jdlrobson: Yes, I'm working on other things, I'm not waiting idle while you did that. [21:40:19] Will get back to it in a sec [21:40:43] ok cool just keen to get it off my list of things to do [21:40:52] consider it done [21:40:52] the list is growing rapidly [21:41:45] jdlrobson: Looks like contrary to earlier components moved to core, this one doesn't conflict. [21:42:08] I'm runing on master vector and your patch in core, both run side-by-side. leading to a never-collapsing sidebar (e.g. both click handlers fire) [21:42:15] collapse-expand-collapse [21:42:16] :) [21:42:41] testing with I47950b5375ca as vector patch instead [21:42:51] ori-l: it's like a header, so it has to go first [21:43:10] sweet [21:43:17] (03PS1) 10Legoktm: Give an error if the wiki is not recognized [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87013 [21:43:27] AaronSchulz: k, thanks [21:44:04] or maybe not [21:44:53] ori-l: never mind that, I think it's just an aggregate [21:45:04] the order probably doesn't matter [21:45:18] I was probably just trying to preserve how it worked before packet batching [21:46:25] (03CR) 10PleaseStand: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [21:46:25] it used to send that line separately before everything else, and each stat change was its own packet [21:47:13] (03CR) 10Krinkle: [C: 032] Remove collapsibleNav module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [21:47:26] (03Merged) 10jenkins-bot: Remove collapsibleNav module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [21:47:34] \o/ [21:47:37] thanks Krinkle [21:47:42] jdlrobson: I'm adding release notes [21:48:54] ori-l: now that I think about it, I can think of some bugs for that total hit counter [21:49:00] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87015 [21:49:03] (03PS4) 10BryanDavis: Add script to purge edited pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [21:49:17] (03Abandoned) 10Jdlrobson: Hygiene: Make user login form HTML more semantically correct [core] - 10https://gerrit.wikimedia.org/r/83429 (owner: 10Jdlrobson) [21:49:34] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87015 (owner: 10MaxSem) [21:49:58] (03CR) 10BryanDavis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [21:49:59] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87017 [21:50:03] Krinkle: jdlrobson: yay [21:50:23] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87017 (owner: 10MaxSem) [21:50:28] so vector is now officially defunct? :D [21:50:32] only took 8 months, eh [21:50:35] ori-l: or not, $socket is still static, so I guess that works [21:50:41] MatmaRex, mobile roolz now! [21:50:47] (03CR) 10PleaseStand: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [21:50:54] for a moment it seemed like the -total line would get sent more than once per request [21:51:10] AaronSchulz: it counts numbers of batched submissions to the server [21:51:14] but i'm not sure how useful that is [21:51:39] (03PS21) 10Krinkle: Vector: Add navigation collapsing feature [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [21:51:49] anyhow, i'm going to submit a patch to change the format to https://github.com/b/statsd_spec [21:51:53] (03CR) 10Krinkle: [C: 032] Vector: Add navigation collapsing feature [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [21:51:59] ori-l: it counts the number of page requests that where involving in incrementing anything [21:52:03] (03CR) 10Chad: [C: 04-2] "Will refactor. This was all based on a massive misunderstanding on my part." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/86718 (owner: 10Chad) [21:52:16] though cli script runs are also counted, though possibly drowned out, maybe not [21:52:16] AaronSchulz: ah right, thats a subtle point [21:52:16] i wonder is there anything else in Vector that could be deleted now [21:52:20] it was probably never that useful [21:52:25] MatmaRex: thanks for the reviews on that patch [21:52:27] appreciate it [21:53:14] my pleasure [21:54:48] brion: So when you looked at the extended metadata patch, did the code basically look good? I have a few issues marked up, but considering the purpose I explained, did it seem pretty much to do what it said? [21:55:24] (03CR) 10MarkTraceur: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [21:58:02] AaronSchulz: there's a job on professor that listens for these stats and pipes them into Graphite; do you know if they go anywhere else? [22:02:08] (03Merged) 10jenkins-bot: Vector: Add navigation collapsing feature [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [22:06:51] (03PS9) 10Bsitu: Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [22:06:52] (03PS1) 10Bsitu: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 [22:09:28] Can anyone assist, several people have tried and failed, but picture select template just will not function on http://no.wikinews.org/ [22:09:52] The template is here https://en.wikinews.org/wiki/Template:Picture_select [22:10:10] If someone may help this would be very handy for the article [22:10:50] (03PS2) 10Bsitu: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 [22:11:45] marktraceur: around? [22:11:52] Sort of! [22:11:54] What's up? [22:12:09] i'm killing Vector, and [22:12:20] Murder...murder most foul [22:12:22] there's basically one thing left in there [22:12:23] https://github.com/wikimedia/mediawiki-extensions-Vector/blob/master/Vector.hooks.php#L15 [22:12:28] (the extension :) ) [22:12:32] Ah, fine [22:12:39] this pref is currently used by Thanks and maybe something else [22:12:45] it definitely doesn't belong in Vector [22:12:57] does it belong to BetaFeatures, maybe? or where? i though you might know [22:13:00] nope [22:13:28] MatmaRex: Tell -corefeatures that Thanks should register its own preference, and if anyone else uses it, that they should register *their* own preference [22:13:33] (03PS3) 10Bsitu: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 [22:13:46] marktraceur: you tell 'em? :) [22:13:47] BetaFeatures is one option of what sort of preference to register, but we haven't deployed it yet [22:13:50] Sigh [22:13:55] that pref might be useful in the long run, though [22:14:03] as a catch-all [22:14:27] some users who checked it might expect it to work for future experiments [22:14:54] it made sense in Vector when it was introduced, but there are no features in it anymore, experimental or not [22:15:34] MatmaRex: I've poked them [22:15:59] (03PS8) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [22:16:00] (03CR) 10jenkins-bot: [V: 04-1] Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [22:18:05] marktraceur: thanks [22:18:20] marktraceur/MatmaRex can either one of you look into my problem? [22:18:45] Computron_: Not I said the Mark [22:18:56] Sorry, most other days I might have, but busy today :( [22:19:34] :/ [22:20:26] marktraceur any other regulars who help in here? [22:20:49] Computron_: For templates? Ummm... [22:21:10] Not that I can think of, and who aren't otherwise busy [22:21:12] Sorry :( [22:22:20] marktraceur, well I was told something about monobook.css needing changing and apparently its a quick copy/paste but it all goes over my head :s [22:22:21] Computron_: i'm just off to sleep, sorry as well :( [22:22:36] :/ [22:22:43] good night everyone [22:23:27] (03PS31) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [22:25:14] anyone else around? [22:27:16] (03PS1) 10Marco: No error anymore on uploading files with same base name [core] - 10https://gerrit.wikimedia.org/r/87020 [22:28:23] (03PS4) 10Bsitu: Topic creator should be notified on post reply/edit/moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87018 [22:28:52] AaronSchulz: https://github.com/gwicke/storoid/ [22:29:47] ? [22:30:03] ? [22:30:35] Computron_: Do you have a link to an example of it not working on nowikinews? [22:30:47] Heh, NowikiNews. [22:31:02] Hah, Wiknytt? [22:31:14] * RoanKattouw is mildly surprised that "news" is singular in Norwegian [22:32:55] (svwikinews is closed and seems to have called itself "Wikinews" as opposed to "Wikinyheter", though) [22:33:18] gwicke, what's the benefit of having another layer of abstraction on top of cassandra? [22:35:22] MaxSem: having a sane API and independence from the backend [22:36:06] why abstract it with a service rather than with a PHP library? [22:36:11] MaxSem: see https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage [22:36:38] that's WIP and not very detailed currently [22:37:57] (03PS5) 10BryanDavis: Add script to purge edited pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [22:38:12] MaxSem: curious what you think, especially about the key/value storage part [22:39:28] (03CR) 10BryanDavis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [22:42:25] (03PS1) 10EBernhardson (WMF): Cache a couple UUID values [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87021 [22:43:39] Anyone have a better name for my maintenance script than 'purgeEditedFiles'? [22:43:57] Parent5446 and AaronSchulz don't like me pseudo-random name generation technique. :) [22:44:06] s/me/my/ [22:47:23] something like purgePagesByEditTimestamp or such [22:48:10] or purgeChangedPages [22:48:50] AaronSchulz: Either works for me. purgeChangedPages is less typing but tab-completion doesn't care either way. [22:49:39] Any objections to 'purgeChangedPages`? [22:52:17] meh, you can try it :) [22:59:26] (03PS1) 10Bsitu: Remove the deprecated user preference: 'vector-noexperiments' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/87023 [22:59:28] (03PS1) 10Bartosz Dziewoński: Add missing default true value for 'vector-simplesearch' preference [core] - 10https://gerrit.wikimedia.org/r/87024 [22:59:55] (03PS2) 10Bsitu: Remove the deprecated user preference: 'vector-noexperiments' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/87023 [23:00:06] (03PS6) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [23:04:13] (03CR) 10EBernhardson (WMF): [C: 032] Remove the deprecated user preference: 'vector-noexperiments' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/87023 (owner: 10Bsitu) [23:04:24] (03Merged) 10jenkins-bot: Remove the deprecated user preference: 'vector-noexperiments' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/87023 (owner: 10Bsitu) [23:06:23] (03CR) 10EBernhardson (WMF): "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [23:06:49] (03CR) 10EBernhardson (WMF): "doh, ignore the bundling comment thats not for this patch :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [23:09:05] (03CR) 10Parent5446: [C: 031] Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [23:09:20] (03PS1) 10Catrope: Update VisualEditor to wmf19 branch to pick up I7bddcfa9 cherry-pick [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87025 [23:11:42] (03PS1) 10Catrope: Update VisualEditor to wmf18 branch to pick up I7bddcfa9 cherry-pick [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87026 [23:12:51] (03CR) 10Bsitu: [C: 032] Add hooks for EchoEvent's [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86351 (owner: 10Legoktm) [23:13:00] (03Merged) 10jenkins-bot: Add hooks for EchoEvent's [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86351 (owner: 10Legoktm) [23:17:30] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf18 branch to pick up I7bddcfa9 cherry-pick [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/87026 (owner: 10Catrope) [23:17:54] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf19 branch to pick up I7bddcfa9 cherry-pick [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/87025 (owner: 10Catrope) [23:20:22] (03PS1) 10Bartosz Dziewoński: Remove 'vector-noexperiments' preference [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 [23:20:28] (03PS1) 10Bartosz Dziewoński: Remove dead code [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87028 [23:22:53] AaronSchulz: no rush, but when you have an oportunity would love your opinion on a patchset i have in gerrit, it's about replacing rc_type in recentchanges with a string so its easily extensible(unlike the NS_* constants): https://gerrit.wikimedia.org/r/#/c/85787/ [23:26:36] (03PS1) 10Bartosz Dziewoński: Remove everything except for short information in README and Vector.php [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 [23:28:37] (03CR) 10MaxSem: "Since this and the following patchset essentially leave an extension boilerplate, why not just undeploy this extension and forget about it" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 (owner: 10Bartosz Dziewoński) [23:28:43] (03CR) 10Krinkle: "Addressed mentioned issues and increased test coverage." [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [23:30:29] (03CR) 10Bartosz Dziewoński: "For the three people or so worldwide that might run the git master of it. And for posterity :)" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 (owner: 10Bartosz Dziewoński) [23:31:05] (03CR) 10Bartosz Dziewoński: "(https://gerrit.wikimedia.org/r/#/c/87029/ kills everything but empty Vector.php and a README.)" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 (owner: 10Bartosz Dziewoński) [23:32:02] (03PS1) 10Ori.livneh: Make the format of UDP-logged stats configurable [core] - 10https://gerrit.wikimedia.org/r/87030 [23:32:27] ^ AaronSchulz (no rush, just flagging) [23:35:54] (03CR) 10MaxSem: [C: 032] "Sounds like a plan:)" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 (owner: 10Bartosz Dziewoński) [23:35:57] (03Merged) 10jenkins-bot: Remove 'vector-noexperiments' preference [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87027 (owner: 10Bartosz Dziewoński) [23:36:10] (03CR) 10MaxSem: [C: 032] Remove dead code [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87028 (owner: 10Bartosz Dziewoński) [23:36:41] (03Merged) 10jenkins-bot: Remove dead code [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87028 (owner: 10Bartosz Dziewoński) [23:37:03] (03CR) 10MaxSem: [C: 032] Remove everything except for short information in README and Vector.php [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 (owner: 10Bartosz Dziewoński) [23:37:06] (03Merged) 10jenkins-bot: Remove everything except for short information in README and Vector.php [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 (owner: 10Bartosz Dziewoński) [23:40:43] (03CR) 10Siebrand: "Wikimedia still uses this code. Should probably be removed from http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/87029 (owner: 10Bartosz Dziewoński) [23:43:07] TimStarling: does https://gerrit.wikimedia.org/r/#/c/87010/ seem sane? [23:43:26] hang on, have to finish raging on wikitech-l first [23:43:33] haha [23:44:43] * MaxSem grabs popcorn [23:44:48] ok, done [23:45:20] * siebrand thinks he may have a muted thread that's being discussed at the moment... [23:45:58] AaronSchulz: could you revisit https://gerrit.wikimedia.org/r/#/c/84897/ some time soon? I'd really like to see this go through. [23:46:35] TimStarling, there will be no RFC review tomorrow, right? I don't see any replies about your proposal, but have to be sure:) [23:46:54] there will be an RFC review meeting, even if I am the only one in it [23:47:37] Oct 2 6:00 UTC? [23:49:32] chrismcmahon: it was already -1ed, and I added some more comments [23:49:47] am I supposed to do something else to Reedy's patch? [23:49:59] MaxSem: yes, 6 hours 10 minutes from now [23:50:12] AaronSchulz: I'm not sure how to get it from -1 to +2. is it only the variable name that is an issue? [23:50:32] * chrismcmahon should re-read the comments [23:50:56] who is maintaining that patch? [23:51:49] AaronSchulz: re 87010, you would think the existing code would lock the index gap [23:51:54] AaronSchulz: I think it's a collaborative effort. This is the first time we've wanted to support an extension on beta labs not deployed to production that also has i18n messages. [23:52:30] TimStarling: no, I remember messing around with similar code with lock managers [23:52:37] ah right, I suppose that's why you wrote your comment "SELECT FOR UPDATE only locks records not the gaps where there are none." [23:52:39] two people do FOR UPDATE on some non-existing rows [23:52:45] that does nothing at all :) [23:52:58] that's pretty stupid [23:53:13] (03PS4) 10Tim Starling: Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 (owner: 10Aaron Schulz) [23:53:31] TimStarling: can I turn this that you wrote into a bugzilla request? http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072185.html [23:53:54] (03CR) 10Tim Starling: [C: 032] Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 (owner: 10Aaron Schulz) [23:54:39] Nemo_bis: as long as you don't claim that I am requesting it [23:54:53] Nemo_bis: can you CC me? [23:55:22] it is a bit of a vexed issue, a fight will probably start at some point [23:55:58] TimStarling: over what? [23:56:22] installer privacy policy [23:57:05] should be possible to collect only aggregate data? [23:57:11] (03CR) 10Bsitu: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86356 (owner: 10Legoktm) [23:57:20] Nemo_bis: no; you have to aggregate *something* [23:57:48] um [23:57:51] ori-l: so? [23:57:54] there is already a bug for that i think [23:57:57] (03Merged) 10jenkins-bot: Make sure LocalFile::lock() works for brand new uploads [core] - 10https://gerrit.wikimedia.org/r/87010 (owner: 10Aaron Schulz) [23:58:01] (03CR) 10MaxSem: [C: 031] Add missing default true value for 'vector-simplesearch' preference [core] - 10https://gerrit.wikimedia.org/r/87024 (owner: 10Bartosz Dziewoński) [23:58:02] legal cleared it for MediaWiki-Vagrant (I implemented it but never merged it because I thought it might alienate users) [23:58:18] but with the web installer you could simply explicitly ask the user if they mind [23:58:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=54425 [23:58:58] I oic thanks [23:59:45] https://www.mediawiki.org/wiki/Requests_for_comment/Opt-in_site_registration_during_installation [23:59:56] well, actually that's a fairly different thing