[00:58:30] (03PS6) 10Physikerwelt: Add local LaTeXML webservice for the Math role [vagrant] - 10https://gerrit.wikimedia.org/r/86420 [01:04:18] (03CR) 10Physikerwelt: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [01:09:44] (03Abandoned) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [01:40:13] (03PS4) 10MaxSem: Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 [02:05:09] (03PS1) 10Gnosygnu: v0.9.4.0 [xowa] - 10https://gerrit.wikimedia.org/r/86632 [02:05:41] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/86632 (owner: 10Gnosygnu) [08:45:20] (03PS28) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:45:33] (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:47:05] (03PS1) 10Aaron Schulz: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 [08:48:01] (03CR) 10jenkins-bot: [V: 04-1] Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 (owner: 10Aaron Schulz) [08:48:02] (03CR) 10Yuvipanda: "Still seeing the following error in the apache logs when I try to curl:" [vagrant] - 10https://gerrit.wikimedia.org/r/86420 (owner: 10Physikerwelt) [09:31:52] (03CR) 10Zfilipin: [C: 032] README: mention BROWSER_LABEL [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85812 (owner: 10Hashar) [09:46:53] (03PS1) 10Hashar: mwext-Flow-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86649 [09:49:08] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [10:45:24] (03CR) 10Matthias Mullie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson (WMF)) [12:04:57] so yeah that would fix it [12:06:09] Dereckson: could you amend the commit summary of https://gerrit.wikimedia.org/r/#/c/86653/ ? Simply add a sentence saying that using a 128px width make the logos fit in the 160px height of the p-logo element. [12:06:12] for historical purposes [12:06:16] Okay. [12:06:22] I am heading out to grab a lunch then will deploy both changes [12:06:29] just wanted to understand the issue being solved :-] [12:06:34] hashar: just before, a quick question [12:06:34] thank you Nemo_bis and Dereckson ! [12:06:37] sure [12:07:04] For the 56 others projects, I were going to submit a new change, but wouldn't it be better to amend https://gerrit.wikimedia.org/r/#/c/86653/ ? [12:07:17] My first intent were to separate SVG fix and SVG -> PNG. [12:07:24] (PNG -> SVG) [12:08:15] we will have to make sure that all SVG are protected [12:08:43] just get a new patch to migrate the png ones to svg ? [12:08:49] Okay, so another change will be more comfortable I guess. [12:09:04] Perfect. Bon app' [12:09:06] we might even write a script that load the $wgLogo array and verify that the logos are properly protected using the API :-] [12:09:22] then whenever a logo is not protected, we could fail the build in Jenkins. [12:09:38] though I am not sure whether querying the API half a thousand of time is that much of a good idea [12:09:46] but yeah, submit another change [12:10:00] this way if something screw up, we still have the 128 px ones :-] [12:15:40] T13|needsCoffee: hashar isn't the pffice intern >.> [12:18:38] hashar: there is a bug for that, "write a logo checker" or something [12:19:11] I may have closed it because with odder I've already fixed all the logos (well, few hundreds) [12:19:47] Dereckson can easily upload-protect all those files if they're not already ;) [12:42:22] Nemo_bis: Dereckson I am deploying the wiktionary logo update (135px -> 128px [12:42:41] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF)) [12:46:04] Ok. [12:46:50] p858snake|l: why not? :p [14:53:37] (03PS1) 10Krinkle: gitignore: Add more jjb job name patterns [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86668 [14:53:50] (03CR) 10Krinkle: [C: 032] gitignore: Add more jjb job name patterns [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86668 (owner: 10Krinkle) [15:06:45] (03CR) 10Krinkle: [V: 032] gitignore: Add more jjb job name patterns [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86668 (owner: 10Krinkle) [15:16:04] * brion wonders if wikidata policy allows him to edit his own node [15:57:42] (03CR) 10Esanders: [C: 032] Fix comma errors in various js files (new jshint warning) [core] - 10https://gerrit.wikimedia.org/r/86669 (owner: 10Krinkle) [16:14:08] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to tip of wmf19 branch to pick up cherry-pick [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86679 (owner: 10Catrope) [17:26:30] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [17:49:41] (03PS1) 10Manybubbles: Tests for redirect scoring. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86693 [17:51:25] (03PS1) 10Manybubbles: Update link counts on linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86694 [17:54:42] (03CR) 10Brion VIBBER: [C: 032] "Being bold... submitting" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [17:55:59] (03PS1) 10PleaseStand: Installer: remove dependency on JSON extension [core] - 10https://gerrit.wikimedia.org/r/86696 [17:58:01] (03CR) 10Brion VIBBER: "Seems to work for me -- I tweaked the MobileFrontend menu icons in the LESS version to go back to @embed entries and it works as expected." [core] - 10https://gerrit.wikimedia.org/r/86616 (owner: 10Ori.livneh) [17:59:47] (03PS2) 10PleaseStand: Installer: remove dependency on JSON extension [core] - 10https://gerrit.wikimedia.org/r/86696 [18:01:16] (03PS9) 10MarkTraceur: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [18:02:15] anomie: Re: Extended metadata - I'll be taking that set of patches over from bawolff, and I'm wondering if you think I should reconsider the HTML return values [18:02:45] We intended to tear out a lot of the formatting on the client side, but if you think it's not worth saving any of that metadata at all, I could look into that [18:04:38] marktraceur: It'd be nice if the API would return data in a format useful for the client program to format as it needs it for display, without first having to scrape the data out of HTML. [18:05:05] Oh, that's what you're on about [18:05:13] (03PS2) 10Aaron Schulz: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 [18:05:33] I'll look into it, but dealing with template parsing isn't particularly trivial and I'm not sure it's a good use of my time to write *another* solution for that [18:06:02] "Screen scraping" gives us a sane-ish format without having to parse the templates ourselves [18:06:09] (03CR) 10Hashar: "Go for it Timo!!!!!" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86675 (owner: 10Krinkle) [18:06:27] anomie: I'm more concerned with the dependency, https://gerrit.wikimedia.org/r/78926 [18:06:33] (03CR) 10Aaron Schulz: [C: 032] Make thumb_handler.php use MediaHandler::parseParamString [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [18:07:04] (03PS1) 10CSteipp: Add Vary: X-Forwarded-Proto for https redirects [core] - 10https://gerrit.wikimedia.org/r/86697 [18:07:41] (03PS5) 10MarkTraceur: Extension to screen scrape metadata out of commons [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/80403 (owner: 10Brian Wolff) [18:30:25] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86381 (owner: 10Nikerabbit) [18:30:43] (03PS2) 10Nikerabbit: Move 'main page as default title' further down to unbreak diff urls [core] - 10https://gerrit.wikimedia.org/r/86381 [18:30:46] (03PS1) 10Adamw: lint jobs for wikimedia/fundraising repos [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86703 [18:31:18] awight: Nice - are they passing? [18:31:28] Too much to hope for maybe. :P [18:31:53] (03PS1) 10Manybubbles: If SearchUpdate can't find page try on master. [core] - 10https://gerrit.wikimedia.org/r/86704 [18:32:23] (03PS2) 10Manybubbles: If SearchUpdate can't find page try on master. [core] - 10https://gerrit.wikimedia.org/r/86704 [18:32:26] (03PS1) 10Adamw: jobs for wikimedia/fundraising/crm* [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86705 [18:33:30] anomie: When's good for you to hash this out? I'd like to get this merged so I can move on to reviewing and improving CommonsMetadata. [18:33:32] (03CR) 10Nikerabbit: [C: 032] Add a check that the statsbars don't appear [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86348 (owner: 10Amire80) [18:34:09] marktraceur: hehe, good one ;) Nah, I'm just trying to block any progress in that repo so I can move on with my life [18:34:10] (03CR) 10Krinkle: "In the future, avoid changing files from unforked upstream libraries. These will be undone next time they are updated. They also make it h" [core] - 10https://gerrit.wikimedia.org/r/82116 (owner: 10MaxSem) [18:34:43] awight: Good plan - need review/merge/deploy? [18:34:56] sure! [18:35:33] u know if phplint analyzes all files in the repo, or only those changed by the commit? [18:36:10] (03PS1) 10Platonides: More dates fixing, in line with https://commons.wikimedia.org/wiki/Commons:Wiki_Loves_Monuments_2013/Upload_campaigns/Time [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/86706 [18:36:28] Hm [18:36:29] awight: The default phplint macro only lints changed files. [18:36:30] I think all [18:36:33] Oh, I lied [18:36:49] Contrary to most other linters (e.g. jshint and python do all afaik) [18:36:53] Because phplint is super slow [18:36:58] (03Merged) 10jenkins-bot: Add a check that the statsbars don't appear [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86348 (owner: 10Amire80) [18:37:41] awight: I wanted to say there was a shorter way to enable linting for a repository, but I guess it's only for extensions [18:37:46] Krinkle: cool, at least I won't be chasing typos in 3rd-party libraries all afternoon [18:37:52] (03CR) 10Krinkle: [C: 032 V: 032] "Allons-y, Alonso!" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/86675 (owner: 10Krinkle) [18:38:05] (03PS1) 10Anomie: Reset $wgTitle in AbuseFilter::filterAction() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86707 [20:13:12] brion: our current method of generating HTML is an affront to... uh, something. [20:13:13] sigh [20:13:20] (03CR) 10Hashar: [C: 032] Make pywikibot-core-pep8 voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86722 (owner: 10Merlijn van Deen) [20:13:50] heh [20:14:15] greg-g: i'm going to go ahead and make the cherry-pick commits but i won't merge them unless you ok it [20:14:43] (03Merged) 10jenkins-bot: Make pywikibot-core-pep8 voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86722 (owner: 10Merlijn van Deen) [20:15:21] (03CR) 10EBernhardson (WMF): [C: 032] Add primary/secondary link, email, bundling to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 (owner: 10Bsitu)