[00:02:00] (03CR) 10BryanDavis: [V: 031] "Works for me on both vagrant and labs instances." [vagrant] - 10https://gerrit.wikimedia.org/r/86338 (owner: 10BryanDavis) [00:13:04] (03CR) 10Ori.livneh: [C: 04-1] "Come on, don't kludge. It doesn't make sense to specify a value (via mediawiki::role's $server_url) for $wgServer and then act surprised w" [vagrant] - 10https://gerrit.wikimedia.org/r/86338 (owner: 10BryanDavis) [00:15:17] ori-l: so how do we "correctly" set a value that is unknown at puppet run? [00:16:18] Also code in a web container (apache/nginx/tomcat/whatever) that needs to know a "cannonical url" is the real kludge [00:16:57] I should be able to compose a web app with any number of proxies and have it "just work" [00:18:15] well, one option is to remove $server_url (and the '--server' arg to the installer) [00:18:49] and use a different strategy for configuring parsoid [00:19:00] Can the parsoid script use a relative url? [00:19:27] maybe, dunno. [00:20:34] the config file is a node JS javascript file, though, so it can execute arbitrary code [00:20:42] or do whatever else it needs to do to get that value [00:21:09] ori-l: Ok, good feedback. I'll try a more invasive change. And I agree that I was just slapping on a bandaid here. [00:21:55] bd808: cool, thank you :) it might be simplest to make the mediawiki::parsoid class require a server url parameter [00:22:25] (03PS2) 10Nikerabbit: Run comments through formatComment [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/86080 (owner: 10Siebrand) [00:22:29] and then hard-code it in the role, or figure it out in some other fashion via puppet [00:23:10] (03CR) 10Siebrand: [C: 031] "Chris, if you agree, please merge." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/86080 (owner: 10Siebrand) [00:23:18] gotta run, ttyl [00:23:33] * bd808 waves bye to ori-l [00:23:38] csteipp: Please have a look at https://gerrit.wikimedia.org/r/86080 [00:24:42] (03CR) 10BryanDavis: [C: 04-1] "Ori's right (what does that hurt to say?). I'll try harder." [vagrant] - 10https://gerrit.wikimedia.org/r/86338 (owner: 10BryanDavis) [00:26:52] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/86336 (owner: 10Yurik) [00:27:55] (03CR) 10Adamw: [C: 031] "Awesome legacy function!" [core] - 10https://gerrit.wikimedia.org/r/86339 (owner: 10PleaseStand) [00:28:29] (03CR) 10Yurik: "I think both Eclipse & phpStorm support this approach (later being by far my fav). Enjoy proper debugging :)" [vagrant] - 10https://gerrit.wikimedia.org/r/86336 (owner: 10Yurik) [00:29:54] (03CR) 10Yurik: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/86336 (owner: 10Yurik) [00:40:02] (03CR) 10Adamw: [C: 031] Redirect to https for signup [core] - 10https://gerrit.wikimedia.org/r/86314 (owner: 10CSteipp) [00:40:25] (03CR) 10BryanDavis: [C: 031] "I don't have swift setup to fully test yet, but unittests for FileBackend pass and code looks reasonable." [core] - 10https://gerrit.wikimedia.org/r/85765 (owner: 10Aaron Schulz) [00:55:59] yuvipanda: https://www.mediawiki.org/wiki/User:BDavis_(WMF)/Notes/Labs-vagrant [00:56:00] (03CR) 10Adamw: "Um... good change, but who is feeding strings to wfArrayDiff2" [core] - 10https://gerrit.wikimedia.org/r/86298 (owner: 10Reedy) [00:59:41] (03CR) 10Reedy: "It's only used by wfArrayDiff2 as a callback. The name is slightly confusing as it will be comparing array elements (can be strings, array" [core] - 10https://gerrit.wikimedia.org/r/86298 (owner: 10Reedy) [01:03:41] (03CR) 10Adamw: [C: 032] In wfArrayDiff2_cmp only compare $a and $b as string if they both are strings [core] - 10https://gerrit.wikimedia.org/r/86298 (owner: 10Reedy) [01:49:12] (03CR) 10Amire80: [C: 032] All source language tests implemented [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86328 (owner: 10Nikerabbit) [01:49:21] (03Merged) 10jenkins-bot: All source language tests implemented [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86328 (owner: 10Nikerabbit) [01:52:49] (03PS1) 10Amire80: WIP: Add a check that the statsbars don't appear [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86348 [01:53:20] (03PS1) 10PleaseStand: Remove calls to wfDebugDieBacktrace [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 [01:53:29] (03CR) 10jenkins-bot: [V: 04-1] Remove calls to wfDebugDieBacktrace [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [02:03:51] yuvipanda: hi [02:03:55] hi Krenair [02:04:20] yuvipanda: is your bot supposed to be moving all github pull requests to gerrit now? [02:04:30] it's been down for a bit. let me kick it back up [02:04:50] let me move number 13 manually first [02:05:59] Because it seems mediawiki-core has 3 open [02:06:31] yeah [02:07:45] (03PS1) 10Yuvipanda: A description, how to use this, is essential and should be right in the 'redirect-summary'. [core] - 10https://gerrit.wikimedia.org/r/86350 [02:09:08] Krenair: two more to go [02:11:07] (03PS2) 10Alex Monk: A description, how to use this, is essential and should be right in the 'redirect-summary'. [core] - 10https://gerrit.wikimedia.org/r/86350 (owner: 10Yuvipanda) [02:11:34] (03CR) 10PleaseStand: "Test failures, which are tracked as bug 54126, are NOT caused by this change." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [02:22:32] (03PS1) 10Legoktm: Add hooks for EchoEvent's [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86351 [02:52:38] yuvipanda, you going to finish them..? [02:53:04] bah, one of them stuck at push [02:53:05] pushing [02:53:15] (03PS1) 10Yuvipanda: Update README [core] - 10https://gerrit.wikimedia.org/r/86352 [02:53:44] done, Krenair [02:53:47] one more on the way [02:53:58] (03PS1) 10Yuvipanda: Capitalized bullet points and updated last sentence to say MediaWiki instead of WikiMedia [core] - 10https://gerrit.wikimedia.org/r/86353 [02:54:13] (03PS2) 10Alex Monk: Update README [core] - 10https://gerrit.wikimedia.org/r/86352 (owner: 10Yuvipanda) [03:15:40] (03CR) 10MZMcBride: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86353 (owner: 10Yuvipanda) [03:23:25] (03PS1) 10Shirayuki: Fix spelling "sizable" (American English) [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/86354 [03:45:45] (03PS1) 10Yuvipanda: Adding new CREDITS and LICENSE files, and license headers to all files, per bug 49313. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86355 [03:59:34] (03PS2) 10Legoktm: Add hooks for EchoEvent's [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86351 [04:09:13] (03PS1) 10Legoktm: Prevent Echo mention notifications for MassMessage messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86356 [04:09:42] (03CR) 10Legoktm: "An example usage of these hooks is at https://gerrit.wikimedia.org/r/#/c/86356/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86351 (owner: 10Legoktm) [04:37:48] (03CR) 10Parent5446: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86314 (owner: 10CSteipp) [04:42:03] (03CR) 10Parent5446: [C: 032] Deprecate wfDebugDieBacktrace [core] - 10https://gerrit.wikimedia.org/r/86339 (owner: 10PleaseStand) [04:44:53] (03Merged) 10jenkins-bot: Deprecate wfDebugDieBacktrace [core] - 10https://gerrit.wikimedia.org/r/86339 (owner: 10PleaseStand) [06:02:40] (03CR) 10Adamw: [C: 032 V: 032] "/me squints menacingly at the semicolons ;)" [core] - 10https://gerrit.wikimedia.org/r/86353 (owner: 10Yuvipanda) [06:06:27] (03CR) 10Adamw: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86350 (owner: 10Yuvipanda) [06:10:19] (03CR) 10Adamw: [C: 032] "(1 comment)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [06:10:29] (03CR) 10jenkins-bot: [V: 04-1] Remove calls to wfDebugDieBacktrace [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [06:17:20] (03CR) 10Spage: "Krinkle, https://gerrit.wikimedia.org/r/#/c/52169/ adds mw-ui classes to more buttons in core, https://gerrit.wikimedia.org/r/#/c/65346/ a" [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [06:18:06] (03Abandoned) 10Ori.livneh: Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [06:21:55] (03PS2) 10Ori.livneh: lessphp: Update to upstream 6e8e724fc7 [core] - 10https://gerrit.wikimedia.org/r/86246 (owner: 10Krinkle) [06:22:44] (03CR) 10Ori.livneh: [C: 032] "PS2: Kept modified comment header; added some details to commit message." [core] - 10https://gerrit.wikimedia.org/r/86246 (owner: 10Krinkle) [06:23:03] (03PS2) 10Ori.livneh: less: Add '@since 1.22' comments [core] - 10https://gerrit.wikimedia.org/r/86248 (owner: 10Krinkle) [06:23:11] (03CR) 10Ori.livneh: [C: 032] less: Add '@since 1.22' comments [core] - 10https://gerrit.wikimedia.org/r/86248 (owner: 10Krinkle) [06:26:51] (03Merged) 10jenkins-bot: lessphp: Update to upstream 6e8e724fc7 [core] - 10https://gerrit.wikimedia.org/r/86246 (owner: 10Krinkle) [06:29:55] (03Merged) 10jenkins-bot: less: Add '@since 1.22' comments [core] - 10https://gerrit.wikimedia.org/r/86248 (owner: 10Krinkle) [06:52:07] (03PS1) 10Rfaulk: fix - revert logic, add general flow. [sartoris] - 10https://gerrit.wikimedia.org/r/86357 [06:52:08] (03PS1) 10Rfaulk: rm - .deploy file logic - not needed. [sartoris] - 10https://gerrit.wikimedia.org/r/86358 [06:52:09] (03PS1) 10Rfaulk: add - new revert logic. [sartoris] - 10https://gerrit.wikimedia.org/r/86359 [06:52:37] (03CR) 10Rfaulk: [C: 032 V: 032] fix - revert logic, add general flow. [sartoris] - 10https://gerrit.wikimedia.org/r/86357 (owner: 10Rfaulk) [06:52:52] (03CR) 10Rfaulk: [C: 032 V: 032] rm - .deploy file logic - not needed. [sartoris] - 10https://gerrit.wikimedia.org/r/86358 (owner: 10Rfaulk) [06:53:02] (03CR) 10Rfaulk: [C: 032 V: 032] add - new revert logic. [sartoris] - 10https://gerrit.wikimedia.org/r/86359 (owner: 10Rfaulk) [07:08:41] (03CR) 10Adamw: [C: 031] "(3 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/86229 (owner: 10Hashar) [07:13:24] (03PS1) 10Ori.livneh: Use lessc::addParsedFile instead of custom attribute [core] - 10https://gerrit.wikimedia.org/r/86360 [07:22:47] (03CR) 10Adamw: [C: 031] "(2 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/86259 (owner: 10Hashar) [07:27:20] (03CR) 10Adamw: [C: 031] "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [07:41:51] (03PS1) 10MaxSem: Maintenance script to check LESS files for validity [core] - 10https://gerrit.wikimedia.org/r/86361 [07:42:20] (03CR) 10jenkins-bot: [V: 04-1] Maintenance script to check LESS files for validity [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [07:53:56] (03PS2) 10MaxSem: Maintenance script to check LESS files for validity [core] - 10https://gerrit.wikimedia.org/r/86361 [07:55:28] (03PS1) 10Rfaulk: add - logic to revert handling extraction of latest tag. [sartoris] - 10https://gerrit.wikimedia.org/r/86362 [07:55:53] (03CR) 10Rfaulk: [C: 032 V: 032] add - logic to revert handling extraction of latest tag. [sartoris] - 10https://gerrit.wikimedia.org/r/86362 (owner: 10Rfaulk) [08:56:28] (03PS1) 10Rfaulk: mod - cleanup sync logic, rm .deploy file - not needed. [sartoris] - 10https://gerrit.wikimedia.org/r/86363 [08:56:50] (03CR) 10Rfaulk: [C: 032 V: 032] mod - cleanup sync logic, rm .deploy file - not needed. [sartoris] - 10https://gerrit.wikimedia.org/r/86363 (owner: 10Rfaulk) [08:58:21] (03PS1) 10TTO: Fix wording of action-import/action-importupload messages [core] - 10https://gerrit.wikimedia.org/r/86364 [09:12:46] (03CR) 10Physikerwelt: "Nice" [vagrant] - 10https://gerrit.wikimedia.org/r/84860 (owner: 10BryanDavis) [09:53:27] (03PS1) 10Rfaulk: add - methods _dulwich_stage & _dulwich_commit. [sartoris] - 10https://gerrit.wikimedia.org/r/86367 [09:55:13] (03CR) 10Rfaulk: [C: 032 V: 032] add - methods _dulwich_stage & _dulwich_commit. [sartoris] - 10https://gerrit.wikimedia.org/r/86367 (owner: 10Rfaulk) [10:06:52] (03PS1) 10Rfaulk: add - method _dulwich_reset_to_tag. [sartoris] - 10https://gerrit.wikimedia.org/r/86370 [10:07:14] (03CR) 10Rfaulk: [C: 032 V: 032] add - method _dulwich_reset_to_tag. [sartoris] - 10https://gerrit.wikimedia.org/r/86370 (owner: 10Rfaulk) [11:39:18] (03CR) 10Bartosz Dziewoński: [C: 032] Fix wording of action-import/action-importupload messages [core] - 10https://gerrit.wikimedia.org/r/86364 (owner: 10TTO) [11:42:02] (03Merged) 10jenkins-bot: Fix wording of action-import/action-importupload messages [core] - 10https://gerrit.wikimedia.org/r/86364 (owner: 10TTO) [11:49:56] (03PS26) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [11:50:09] (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [11:53:40] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] "Overriding jenkins, it's broken." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [12:00:11] MatmaRex: PleaseStand: https://gerrit.wikimedia.org/r/86349 [12:00:50] hoo: bah. D: [12:01:00] hoo: i'm submitting a patch to kill those stupid tests that are failing, btw [12:01:08] go ahead [12:01:12] @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ [12:01:12] @ WARNING: POSSIBLE DNS SPOOFING DETECTED! @ [12:01:12] @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ [12:01:14] woot. [12:01:22] gerrit? [12:01:26] yeah [12:01:52] yeah, something's been up with it for a while [12:01:53] there's a bug, I think [12:02:21] Just one? [12:02:25] :p [12:03:49] now, how do i work around that? on windows? [12:04:46] anyone call tell me what's gerrit's ip for them? [12:05:03] PING gerrit.wikimedia.org (208.80.154.81): 56 data bytes [12:05:14] same for me [12:05:27] meh [12:05:34] whatever [12:10:33] (03PS2) 10Helder.wiki: Use mediaWiki.message( ... ).plain() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/82092 [12:11:36] (03PS1) 10Bartosz Dziewoński: Fix string interpolation [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 [12:11:42] (03CR) 10jenkins-bot: [V: 04-1] Fix string interpolation [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 (owner: 10Bartosz Dziewoński) [12:11:44] (03PD1) 10Bartosz Dziewoński: Remove CategoryTree integration tests [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86371 [12:11:52] hoo: ^^^ [12:11:55] MatmaRex: Is this what you suggested? https://gerrit.wikimedia.org/r/#/c/82092/1..2/modules/jquery.wikiEditor.js,unified [12:13:26] helderwiki: yes [12:13:37] great! :-) [12:13:38] helderwiki: have you tested that, btw? [12:13:43] yep [12:13:48] MatmaRex: :) Going to look at them later, probably fine [12:13:49] (does it work or do i have to test myself? :P) [12:13:50] it is working [12:14:19] MatmaRex: The signature message is now parsed correctly [12:15:27] i really wonder what is "if ( $.isArray( p ) && p.length >= 2 ) {" supposed to do there, though [12:16:19] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/86372" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86349 (owner: 10PleaseStand) [12:18:36] (03CR) 10Bartosz Dziewoński: [C: 032] Use mediaWiki.message( ... ).plain() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/82092 (owner: 10Helder.wiki) [12:18:40] (03Merged) 10jenkins-bot: Use mediaWiki.message( ... ).plain() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/82092 (owner: 10Helder.wiki) [12:18:40] helderwiki: ^ [12:19:11] :-) [12:20:47] (03PS1) 10TTO: Fix grammar of action-patrol message [core] - 10https://gerrit.wikimedia.org/r/86373 [12:25:58] (03CR) 10Yuvipanda: "Parsoid shouldn't really be a consideration here, since it is okay with a private / local IP, no?" [vagrant] - 10https://gerrit.wikimedia.org/r/86338 (owner: 10BryanDavis) [12:26:41] (03CR) 10Bartosz Dziewoński: [C: 032] "Message changes really shouldn't require the code review process, eh." [core] - 10https://gerrit.wikimedia.org/r/86373 (owner: 10TTO) [12:29:24] (03Merged) 10jenkins-bot: Fix grammar of action-patrol message [core] - 10https://gerrit.wikimedia.org/r/86373 (owner: 10TTO) [14:21:59] (03CR) 10MZMcBride: "Adam: why was this merged? Did you read my comment?" [core] - 10https://gerrit.wikimedia.org/r/86353 (owner: 10Yuvipanda) [14:23:22] (03CR) 10Yuvipanda: "(I'll note that this came from https://github.com/wikimedia/mediawiki-core/pull/10)" [core] - 10https://gerrit.wikimedia.org/r/86353 (owner: 10Yuvipanda) [14:24:21] That was a really bad merge. [14:26:30] YuviPanda: Thanks for the cross-reference. Is the GitHub <--> Gerrit bot broken? [14:26:46] more like I forgot to start it back up after a refactor. [14:26:52] Ah. [14:26:54] I should. soon. [14:26:54] Can I test it now? [14:26:57] the bot? [14:27:05] I was going to revert that change via GitHub. [14:27:15] But if the bot is down, I can just do a regular commit. [14:27:21] consider the bot down :) [14:27:24] :-) [14:27:29] I'll also consider this Adam's mess to clean up. [14:27:32] I sent him an e-mail. [14:27:33] I consider that merge mostly my fault for not referencing where it came from [14:27:51] I left an explicit comment on the Gerrit changeset. [14:27:54] but hey, be the defender of the integrity of git history if that is what you want to be today! [14:27:56] :) [14:28:14] yeah, I was surprised it got merged. [14:28:18] oh welll. [14:28:23] *well [14:28:28] Star Trek 3 is pretty shitty, sadly :( Should go on to 4. [14:28:42] It's not a huge deal as it's only a README, but it's worrying behavior. [14:28:53] Anyway, it's Saturday. I'm going outside. [14:29:05] heh [14:29:43] huh, wtf is happening here: https://commons.wikimedia.org/wiki/File:%D0%9A%D0%B8%D1%97%D0%B2%D1%81%D1%8C%D0%BA%D0%B8%D0%B9_%D0%BF%D0%BE%D0%BB%D1%96%D1%82%D0%B5%D1%85%D0%BD%D1%96%D1%87%D0%BD%D0%B8%D0%B9_%D1%96%D0%BD%D1%81%D1%82%D0%B8%D1%82%D1%83%D1%82_%D0%91%D1%83%D0%B4%D0%B8%D0%BD%D0%BE%D0%BA_%D0%B6%D0%B8%D1%82%D0%BB%D0%BE%D0%B2%D0%B8%D0%B9_%E2%84%96_1_%D1%81%D0%BB%D1%83%D0%B6%D0%B1%D0%BE%D0%B2%D1 [14:29:45] %86%D1%96%D0%B2.JPG#filehistory [14:32:51] didn't you find a longer url? :P [14:33:28] It looked short in my web browser bar :P [14:33:33] xD [14:33:36] Why can't everyone just write in ascii [14:33:46] I suspect the first image was rotated [14:34:00] https://commons.wikimedia.org/wiki/?curid=28611474 [14:34:07] then the user noticed it, rotated and reuploaded but it was not shown in the image page [14:34:09] More, why is the first image dissapeared [14:34:22] then Turelio, seeing it wrong, asked for rotation [14:34:25] and why is it a different size file, but with exact same dimensions [14:34:38] but the bot rotated the last image, which was already right [14:35:07] bawolff: different color depth? [14:35:09] I think the first image is missing because it was uploaded at the same minute than the second [14:35:28] the user probably used a normal editing program for rotation [14:35:36] thus the file size change [14:36:09] oh, and the reupload doesn't appear in the history, either [14:36:25] but it's in the upload log [14:37:28] both have same timestamp down to the second [14:37:51] but different sha1's [14:43:20] for my curiosity, why does https://lists.wikimedia.org/mailman/listinfo/wikitech-announce look so different from https://lists.wikimedia.org/mailman/listinfo/wikitech-l [14:43:31] and can we have the latter as pretty as the former [14:46:03] I think the list owner can change the subscribe page and put arbitrary html [15:04:05] (03PS1) 10Jackmcbarn: Allow descending-order sort of Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/86376 [15:06:06] Platonides: Hmm, it gets weirder - On the toolserver, the log entry for the re-upload isn't present, but it is present on special:log [15:11:55] Platonides: Hmm, nevermind, it just has the wrong log_page parameter set in toolserver [15:29:09] (03CR) 10Hashar: "(3 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/86229 (owner: 10Hashar) [15:35:38] Platonides: I ended up filing that as https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 [15:54:01] (03CR) 10Parent5446: [C: 04-1] "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/86361 (owner: 10MaxSem) [15:56:39] (03CR) 10Parent5446: [C: 032] Allow descending-order sort of Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/86376 (owner: 10Jackmcbarn) [15:57:42] (03CR) 10Parent5446: [C: 031] Use lessc::addParsedFile instead of custom attribute [core] - 10https://gerrit.wikimedia.org/r/86360 (owner: 10Ori.livneh) [15:59:28] (03Merged) 10jenkins-bot: Allow descending-order sort of Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/86376 (owner: 10Jackmcbarn) [17:00:45] can any db guy comment on adding an index to logging.log_user_text ? [17:01:37] jackmcbarn: Why would you want that? Are anons making log entries somehow now? [17:01:54] yes [17:01:55] feedback [17:02:03] (03PS1) 10Nikerabbit: Move 'main page as default title' further down to unbreak diff urls [core] - 10https://gerrit.wikimedia.org/r/86381 [17:02:11] (it's always been possible, just never on any wmf wiki) [17:02:31] !b 54432 [17:02:31] https://bugzilla.wikimedia.org/54432 [17:03:04] jackmcbarn: I'm not a dba, I just like responding to people [17:03:24] jackmcbarn: You may want to talk to someone like springle-away [17:03:25] lol [17:03:50] blargh [17:06:00] wow, you even updated the mssql schema in your patch [17:06:56] Too advanced. Declined .. :p j/k [17:10:00] jackmcbarn: For that index to work, it also needs the sorting fields in it to [17:10:22] bawolff: i know, those are going in with the patch that adds the functionality to enable searching [17:10:31] i deliberately kept this one as minimal as possible [17:11:58] I mean, you need an index either on (log_user_text, log_timestamp) or (log_user_text, log_type, log_timestamp) in order for this to be efficient [17:12:24] * jackmcbarn looks [17:13:20] The first being if you just want to filter by user, the second being if you want to filter by user and logging type [17:13:59] The timestamp needed because when you do a query for the first 50 entries, you want to get the first 50 entries in order (Important if an anon happens to make 200000 log entries) [17:14:29] 20120308195646 is the first timestamp on enwiki with log_user = 0 [17:14:42] (03PS1) 10Bartosz Dziewoński: Restrict formatting to where a title attribute is present [core] - 10https://gerrit.wikimedia.org/r/86382 [17:14:43] so this has been an issue for at least 18 months [17:15:45] AFT (logging) is known broken https://bugzilla.wikimedia.org/show_bug.cgi?id=44377 [17:15:55] (03CR) 10Bartosz Dziewoński: [C: 031] "Submitting Entlinkt's patch from the bug. Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/86382 (owner: 10Bartosz Dziewoński) [17:15:58] Nemo_bis: i know, that's what this is fixing [17:16:03] anybody wanna +2? ^ i don't want to self-merge [17:16:42] bawolff: should i go user-type-time or user-time-type? [17:17:25] or do i need user-type-time and user-time, like userids have now? [17:17:55] jackmcbarn: I know you know, I was replying to Krenair ;) [17:18:26] It depends, are you ever going to want to have all the log entries a specific anon made, or is always going to be entries by an anon for a specific type of log entry (aka feedback, or move log) [17:18:39] if you want both those types of searches, then you need both [17:18:46] ok, then i need both [17:18:54] * jackmcbarn goes to fix his patch [17:19:34] * bawolff sometimes thinks life would be easier if anons had user ids... [17:20:12] if only registered userids started at 2^128+1 [17:20:24] lol [17:20:51] I'm going to mark your patch -1 for this issue, but that will go away as soon as you upload a new version [17:21:44] (03CR) 10Brian Wolff: [C: 04-1] "The index should be a composite index on either (log_usertext, log_timestamp), (log_usertext, log_type, log_timestamp) or possibly both de" [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [17:23:35] am i allowed to have one patch script create two indexes, or do i need two patch scripts now? [17:25:44] you're allowed to have one [17:26:15] do i call it with two entries in the updater script then, or just one? [17:30:58] I think its fine to call it with just one [17:31:19] since both schema changes are happening at the same time [17:41:58] (03PS1) 10Brian Wolff: Make image on desc page not clickable if $file->mustRender() true. [core] - 10https://gerrit.wikimedia.org/r/86383 [17:44:47] bawolff: unexpected T_RIGHT_PARENTHESIS in last paragraph. [17:45:38] (03PS2) 10Brian Wolff: Make image on desc page not clickable if $file->mustRender() true. [core] - 10https://gerrit.wikimedia.org/r/86383 [17:45:39] (03PS2) 10Jackmcbarn: Add index on logging.log_user_text [core] - 10https://gerrit.wikimedia.org/r/85508 [17:45:40] lol [17:46:02] Hmm, should I email design about this, it is a UI change [17:46:18] looking closer, i think i need two patches because it checks for existence of one index per file [17:46:22] anyway, there it is [17:46:23] but if I do that, they'll probably try and redesign the entire image description page... [17:46:50] mailing design is useless, don't do it [17:47:35] bawolff: i'm not sure if relying on mustRender() is a good idea (but of course i know nothing about that stuff) [17:47:50] jackmcbarn: looks better now. Hopefully one of the dba's will comment on it soon [17:47:56] SVG images are pretty widely supported by now (to the point that we use them as CSS backgrounds etc) [17:47:59] thanks [17:48:12] also, BMPs apparnetly have mustRender on. heh. [17:48:25] MatmaRex: Yeah, svgs are the case I'm a little worried about [17:48:37] Easy fix is to just not let BMP's ever.. :P [17:49:15] mustRender is supposed to mean, if user types [[File:Foo.ext]], is there any situation where we could just return the original file [17:49:32] which in principle sounds like what we want [17:50:25] In theory, if the user things clicking image on description page => higher resolution version of the same type of file that the preview is, then svgs should be clickable [17:50:49] As there's a large difference between an svg and a high resolution rendered version of the svg [17:51:00] but I'm not sure if users will see it that way [17:51:03] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [core] - 10https://gerrit.wikimedia.org/r/86383 (owner: 10Brian Wolff) [17:52:07] i dunno. [17:52:09] * MatmaRex hides [17:59:24] MatmaRex: Well I asked on commons, odder said they are likely to have my head if I do that [18:00:14] haha [18:06:53] (03CR) 10PleaseStand: [C: 04-1] "If you look at the old version of the code, there were serialize calls for both $this->croak()s, that I didn't mean to remove. Let me add " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 (owner: 10Bartosz Dziewoński) [18:18:49] (03PS3) 10Brian Wolff: Make image on desc page not clickable if $file->mustRender() true. [core] - 10https://gerrit.wikimedia.org/r/86383 [18:19:10] (03CR) 10Brian Wolff: "Hold off on merging this until I consult with commons community." [core] - 10https://gerrit.wikimedia.org/r/86383 (owner: 10Brian Wolff) [18:34:20] (03PS2) 10PleaseStand: Add back serialize() calls for internal errors [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 (owner: 10Bartosz Dziewoński) [18:34:28] (03CR) 10jenkins-bot: [V: 04-1] Add back serialize() calls for internal errors [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 (owner: 10Bartosz Dziewoński) [18:56:37] (03PS1) 10Brian Wolff: Add the full resolution of a file to the list of "Other resolutions:" [core] - 10https://gerrit.wikimedia.org/r/86387 [19:24:46] (03CR) 10Aaron Schulz: [C: 032] Use HTTPS for Special:MWOAuth/token [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 (owner: 10Anomie) [19:24:53] (03Merged) 10jenkins-bot: Use HTTPS for Special:MWOAuth/token [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 (owner: 10Anomie) [19:39:34] (03CR) 10Hashar: [C: 032] "We coud inject the CategoryTree extension when running the Cite test. As Bartosz says, it is much better done in a PHPUnit test if we want" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86371 (owner: 10Bartosz Dziewoński) [19:39:40] (03Merged) 10jenkins-bot: Remove CategoryTree integration tests [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86371 (owner: 10Bartosz Dziewoński) [19:40:19] (03PS3) 10Hashar: Add back serialize() calls for internal errors [extensions/Cite] - 10https://gerrit.wikimedia.org/r/86372 (owner: 10Bartosz Dziewoński) [19:58:01] (03CR) 10Hashar: [C: 031] "go for it :-)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85812 (owner: 10Hashar) [20:48:22] (03PS3) 10Brian Wolff: Add way of including all stderr output when executing command [core] - 10https://gerrit.wikimedia.org/r/83974 [20:49:11] (03CR) 10Brian Wolff: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83974 (owner: 10Brian Wolff) [21:34:24] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke) [21:36:31] (03PS1) 10Brian Wolff: Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 [22:11:47] (03PS1) 10MarkTraceur: Recursive filerepoinfo [core] - 10https://gerrit.wikimedia.org/r/86393 [22:11:52] ^ probably one of the most fun patches I've ever written [22:25:40] (03PS1) 10Adamw: Correct attribution for Wikimedia project visitors [core] - 10https://gerrit.wikimedia.org/r/86394 [22:29:38] (03PS1) 10Ori.livneh: Haskell syntax: omit single quotes from QUOTEMARKS [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/86395 [22:30:02] (03CR) 10Adamw: "I defer to others on this change, my merge was hasty. I missed MZMcBride's comment #1--I agree that "Wikimedia" is more accurate, let's f" [core] - 10https://gerrit.wikimedia.org/r/86353 (owner: 10Yuvipanda) [22:31:56] (03CR) 10Adamw: [C: 032] wrap most functions in a class [tools/release] - 10https://gerrit.wikimedia.org/r/86229 (owner: 10Hashar) [22:32:36] (03CR) 10Adamw: [C: 032] extract parse_args out of the class [tools/release] - 10https://gerrit.wikimedia.org/r/86255 (owner: 10Hashar) [22:33:09] (03CR) 10Adamw: [C: 032] ask() no more need a skip parameter, use context instead [tools/release] - 10https://gerrit.wikimedia.org/r/86256 (owner: 10Hashar) [23:32:07] (03PS6) 10Brian Wolff: Make thumb_handler.php use MediaHandler::parseParamString [core] - 10https://gerrit.wikimedia.org/r/69027 [23:33:41] (03CR) 10Brian Wolff: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [23:42:52] (03PS1) 10Brian Wolff: Add a header on thumb.php saying which thumb server on error. [core] - 10https://gerrit.wikimedia.org/r/86397 [23:44:08] bawolff: You're busy today, not much schoolwork? [23:44:36] Its the calm before midterm season [23:44:44] Also I was missing programming a little bit [23:44:53] :) [23:46:27] * marktraceur should probably split up his bloody UploadWizard patches today so they're not so huge anymore [23:59:00] I'm about to file an upload wizard bug for you :)