[00:00:16] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85544 (owner: 10Ori.livneh)
[00:06:10] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/85544 (owner: 10Ori.livneh)
[00:09:55] <grrrit-wm>	 (03CR) 10Werdna: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[00:16:06] <T13|sleeps>	 StevenW: Are you available for a pm?
[00:16:14] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update schema; remove 'mobileTargets'. [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 
[00:19:09] <grrrit-wm>	 (03PS20) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[00:21:47] <grrrit-wm>	 (03PS1) 10Amire80: Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 
[00:22:04] <grrrit-wm>	 (03PS3) 10Ori.livneh: Clean-up of skins/common/IEFixes.js [core] - 10https://gerrit.wikimedia.org/r/85544 
[00:22:18] <ori-l>	 jgonera: any progress?
[00:23:15] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:23:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:25:53] <grrrit-wm>	 (03PS1) 10MarkTraceur: Use Hooks class instead of wgHooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 
[00:25:57] <marktraceur>	 Blam
[00:26:07] <marktraceur>	 jdlrobson: ^^ you can review and merge if you'd like
[00:27:57] <grrrit-wm>	 (03CR) 10Nikerabbit: "recheck" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:28:09] <jdlrobson>	 marktraceur: \o/
[00:28:21] <jdlrobson>	 will take a look tomorrow winding down now
[00:28:54] <grrrit-wm>	 (03Abandoned) 10Nikerabbit: Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:29:02] <grrrit-wm>	 (03Restored) 10Nikerabbit: Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:29:31] <grrrit-wm>	 (03CR) 10Nikerabbit: Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:29:38] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:29:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add id to stats tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86054 (owner: 10Amire80)
[00:31:14] <grrrit-wm>	 (03PS3) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 
[00:31:14] <grrrit-wm>	 (03PS19) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 
[00:33:40] <grrrit-wm>	 (03PS1) 10Nikerabbit: Implement first scenario for main page [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86056 
[00:34:45] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Implement first scenario for main page [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86056 (owner: 10Nikerabbit)
[00:35:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement first scenario for main page [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86056 (owner: 10Nikerabbit)
[00:35:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "I like it, let's go for it." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO)
[00:38:59] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Rename lessc->embeddedImages to lessc->embeddedFiles [core] - 10https://gerrit.wikimedia.org/r/85775 (owner: 10Ori.livneh)
[00:43:19] <ori-l>	 brion: since you're on a roll, want to look at https://gerrit.wikimedia.org/r/#/c/86053/ ?
[00:45:45] <grrrit-wm>	 (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur)
[00:57:24] <grrrit-wm>	 (03CR) 10Brion VIBBER: "I hate to be that guy that's like "hey can you split this into two commits?" but .... Can you split this into two commits? :)" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 (owner: 10Ori.livneh)
[00:57:33] <grrrit-wm>	 (03CR) 10Werdna: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF))
[00:57:51] <werdna>	 brion: lol
[00:58:07] <ori-l>	 brion: np :)
[00:58:09] <ori-l>	 & thanks
[00:58:15] <brion>	 :)
[01:02:37] <grrrit-wm>	 (03CR) 10Nikerabbit: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF))
[01:02:49] <grrrit-wm>	 (03PS1) 10Mattflaschen: Stop using config.json for easier path specification [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 
[01:03:39] <grrrit-wm>	 (03PS2) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 
[01:05:16] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen)
[01:07:45] <jdlrobson>	 ori-l: ping
[01:07:57] <jdlrobson>	 seems that LESS parse errors do not invalidate cache for me.. LESS error: parse error: failed at `.list-style-image(images/bullet-icon.png);` /Users/jrobson/Sites/w/skins/vector/screen.less on line 664
[01:08:28] <ori-l>	 LESS parse errors are cached for 5 minutes
[01:10:03] <jdlrobson>	 ori-l: ok
[01:10:11] <jdlrobson>	 debug=true should override it though no?
[01:10:20] <grrrit-wm>	 (03PS4) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 
[01:10:22] <grrrit-wm>	 (03PS20) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 
[01:10:26] <jdlrobson>	 ^ ori-l fixed the embeds :D
[01:10:49] <jdlrobson>	 .background-image-gradient now handles vendor prefixes as well
[01:11:09] <jdlrobson>	 :D
[01:11:22] <ori-l>	 ah, cool
[01:11:33] <ori-l>	 brion: check out https://github.com/atdt/lessphp/commit/62dd2c7e7da2d8a1a598840890fd41dcca70877a !
[01:11:38] <ori-l>	 test suite & everything
[01:11:40] <jdlrobson>	 ori-l: so the transformation to screen.less should be ready to go :D
[01:12:12] <jdlrobson>	 ori-l: i guess we need to design some conventions of how we name less files though
[01:12:45] <brion>	 whee
[01:13:29] <ori-l>	 jdlrobson: looking, sec
[01:13:34] <ori-l>	 let me just split up the nav timing patch
[01:14:02] <brion>	 ori-l: so those exceptions will end up killing the file transformation and outputting a comment with the exception info into the css, right?
[01:14:32] <grrrit-wm>	 (03PS2) 10Ori.livneh: Update schema to 5832704 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 
[01:14:37] <ori-l>	 brion: yep
[01:15:00] <brion>	 spiff. i wonder if we could do something more Magical™ though… :)
[01:15:19] <brion>	 like output a rule that sets a string content for a magic div so the error message is visible ;)
[01:15:37] <ori-l>	 brion: hey, that was my idea!
[01:15:41] <brion>	 :DD
[01:15:56] <ori-l>	 .mw-debug { content: "..."; }
[01:16:03] <ori-l>	 er, would have to be:
[01:16:08] <ori-l>	 .mw-debug:before { content: "..."; }
[01:16:47] <ori-l>	 alternately a piece of JS code that runs in debug mode could inspect <style> tags and linked stylesheets for some error-reporting pattern
[01:16:52] <ori-l>	 and surface the errors somehow
[01:16:52] <brion>	 of course you'd only get one message at a time that way
[01:16:55] <brion>	 oooooh
[01:16:56] <brion>	 yes true
[01:17:02] <brion>	 a debug panel could be … handy
[01:17:03] <ori-l>	 but the CSS hack is way neater :P
[01:17:08] <brion>	 hehehe
[01:17:56] <grrrit-wm>	 (03PS1) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[01:19:11] <grrrit-wm>	 (03Abandoned) 10Kaldari: Adding capitalized i18n message for button context [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76538 (owner: 10Kaldari)
[01:19:17] <grrrit-wm>	 (03PS1) 10Ori.livneh: Drop obsolete 'mobileTargets' from module declarations [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86060 
[01:20:37] <ori-l>	 jdlrobson: looks OK, would like to test tho, can do that later tonight
[01:21:44] <jdlrobson>	 \o/
[01:23:33] <grrrit-wm>	 (03PS2) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[01:38:30] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[01:42:47] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[01:43:22] <grrrit-wm>	 (03CR) 10Brian Wolff: "(8 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl)
[01:48:12] <grrrit-wm>	 (03PS3) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[01:48:23] <grrrit-wm>	 (03PS1) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 
[01:49:38] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[01:53:56] <grrrit-wm>	 (03PS1) 10Bsitu: Add primary/secondary link, email support to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 
[01:55:39] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] Add primary/secondary link, email support to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 (owner: 10Bsitu)
[01:59:28] <T13|sleeps>	 @seen AzaToth
[01:59:28] <wm-bot>	 T13|sleeps: Last time I saw AzaToth they were quitting the network with reason: Remote host closed the connection N/A at 9/17/2013 11:57:39 PM (8d2h1m49s ago)
[01:59:35] <T13|sleeps>	 Hrmm.
[02:00:26] <T13|sleeps>	 Anyone here familiar with Twinkle's code? I'm wondering what the variable is for last edit timestamp.
[02:01:00] <T13|sleeps>	 Is this available as a mw.config.get() maybe even?
[02:01:54] <RoanKattouw>	 Probably
[02:02:01] <RoanKattouw>	 VisualEditor uses this so let me look at that code
[02:02:53] <RoanKattouw>	 Oh, it just gets it from the API
[02:02:59] <RoanKattouw>	 That's kind of cheating
[02:03:20] <RoanKattouw>	 But better for robustness given that we're also fetching the content from the API at the same time
[02:04:50] <T13|sleeps>	 What's wfTimestamp() ?
[02:05:55] <T13|sleeps>	 Php variable, of no use to me...
[02:06:52] <RoanKattouw>	 It's the current time
[02:13:38] <Krinkle>	 https://doc.wikimedia.org/mediawiki-core/master/php/html/search.php?query=wfTimestamp
[02:13:44] <Krinkle>	 https://doc.wikimedia.org/mediawiki-core/master/php/html/GlobalFunctions_8php.html#a3d101e5175d086c96923cbaf66fd3545
[02:25:06] <grrrit-wm>	 (03PS3) 10Werdna: Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 
[02:27:30] <T13|sleeps>	 RoanKattouw: who would I have to bribe with cookies to get a wgCurRevisionTimestamp added to the mw.config variables? ;)
[02:27:39] <grrrit-wm>	 (03PS1) 10Werdna: Distinguish "formatted" from "unformatted" post revisions, and do not bother storing HTML for unformatted post revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86066 
[02:34:23] <T13|sleeps>	 Okay, can anyone tell me what such a request would go under in Bugzilla? ?product=MediaWiki&component=  ???
[02:38:55] <T13|sleeps>	 brion: Do you like cookies or brownies?  :D
[02:40:06] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446)
[02:43:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add wgRevisionId variable to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446)
[02:49:51] <p858snake|l_>	 T13|needsCoffee: stroopwafels are the choice of bribes in here
[02:51:46] <T13|needsCoffee>	 Ahhh.. I see.. 
[02:52:17] <T13|needsCoffee>	 !bribe is Stroopwafels for everyone!!!
[02:52:17] <wm-bot>	 Key was added
[02:52:20] <T13|needsCoffee>	 :)
[03:22:12] <grrrit-wm>	 (03PS3) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 
[03:23:15] <grrrit-wm>	 (03CR) 10Mattflaschen: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen)
[03:46:51] <ebernhardson>	 is there a, for lack of better description, louder logging method than wfDebugLog?  Essentially i'd like to log something that cannot be missed during development(loud, like an uncaught exception loud) but wont blow up if somehow reached in production(like an uncaught exception)
[03:47:59] <ori-l>	 well,
[03:48:05] <ori-l>	 you can define a custom log group
[03:48:19] <ori-l>	 and have it either go to a tcp / udp destination where you have a listener that does something fancy
[03:48:22] <ori-l>	 or to a file
[03:48:32] <ori-l>	 and tail -f the file piping into, say, growl
[03:49:41] <ori-l>	 or 'say', if you're on a mac
[03:50:15] <ori-l>	 you're welcome
[03:51:34] <ori-l>	 http://growl.info/downloads#growlnotify
[03:52:27] <legoktm>	 there's also a ruby gem to work with notification center
[03:52:37] <legoktm>	 https://github.com/alloy/terminal-notifier
[03:52:51] <ori-l>	 right
[03:53:05] <legoktm>	 and there is Hiss which forwards growl --> notification center
[03:54:50] <ori-l>	 so: $wgDebugLogGroups = array( 'growl', 'tcp://localhost:1337/mw' );
[03:55:06] <ebernhardson>	 interesting
[03:55:21] <ori-l>	 have something listening at that address
[03:55:35] <ebernhardson>	 yea, basically even a netcat piping to the desktop notifications should work
[03:55:44] <ori-l>	 yes
[03:56:09] <ebernhardson>	 i will do that, thanks! :)
[03:56:14] <ori-l>	 :)
[04:02:16] <bawolff>	 There's also wfWarn, but its really not very loud...
[04:04:37] <aude>	 ebernhardson: wfWarn ?
[04:07:12] * ebernhardson  starts tracing what wfWarn does, but will aparently just have to try it :)

[04:08:41] <bawolff>	 If you have $wgDevelopmentWarnings on, it outputs into the page I think
[04:09:36] <ebernhardson>	 oh nice, yea with wgDevelopmentWarnings on that does make it quite obvious
[04:09:50] <ebernhardson>	 although even just in the console is better than mixed up in the debug log
[04:10:02] <ebernhardson>	 (which is the other thing i see it does)
[04:12:30] <aude>	 in production, you usually find out about warnings, if they occur
[04:14:29] <grrrit-wm>	 (03CR) 10Mattflaschen: "However, we have to use addModuleStyles, to ensure it works without JavaScript. I've been telling people to *only* use addModuleStyles fo" [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh)
[04:22:09] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[04:37:28] <grrrit-wm>	 (03PS1) 10Legoktm: Add dependency on 'mediawiki.jqueryMsg' so mw.message will work [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86067 
[05:03:59] <grrrit-wm>	 (03PS2) 10Werdna: Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 
[05:04:24] <grrrit-wm>	 (03PS1) 10Spage: sample API call tweak [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86069 
[05:07:33] <grrrit-wm>	 (03PS1) 10Ori.livneh: In OutPutPage->getJSVars, maintain symmetry between JS & PHP var names [core] - 10https://gerrit.wikimedia.org/r/86070 
[05:07:48] <ori-l>	 ^ Elsie
[05:08:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] In OutPutPage->getJSVars, maintain symmetry between JS & PHP var names [core] - 10https://gerrit.wikimedia.org/r/86070 (owner: 10Ori.livneh)
[05:08:11] <ori-l>	 sigh.
[05:08:47] <Elsie>	 dint of
[05:09:21] <Elsie>	 That sentence is a bit puzzling.
[05:10:09] <grrrit-wm>	 (03PS2) 10Ori.livneh: In OutPutPage->getJSVars, maintain symmetry between JS & PHP var names [core] - 10https://gerrit.wikimedia.org/r/86070 
[05:10:11] <ori-l>	 yeah, i think i'm dehydrated
[05:10:47] <grrrit-wm>	 (03PS1) 10Spage: Improve INITIAL_WORKFLOWS [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86071 
[05:10:48] <grrrit-wm>	 (03CR) 10MZMcBride: "Does it make any difference whether the function is protected, private, or public when deciding to change variable names?" [core] - 10https://gerrit.wikimedia.org/r/86070 (owner: 10Ori.livneh)
[05:10:58] <grrrit-wm>	 (03CR) 10MZMcBride: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86070 (owner: 10Ori.livneh)
[05:13:07] <grrrit-wm>	 (03CR) 10Ori.livneh: "No. Visibility has to do with whether code outside the class can call the function or not. It doesn't apply to the function's internal sco" [core] - 10https://gerrit.wikimedia.org/r/86070 (owner: 10Ori.livneh)
[05:14:17] <Elsie>	 Interesting.
[05:14:30] <ori-l>	 feel free to edit the commit message
[05:14:40] <ori-l>	 i don't disagree, i'm just tired
[05:14:54] <Elsie>	 Sleeeeeeeeeep.
[05:15:07] <ori-l>	 oh, i accidentally a word
[05:15:12] <ori-l>	 ok, i sleep, you fix it
[05:15:14] <ori-l>	 good night
[05:18:07] <grrrit-wm>	 (03PS1) 10Werdna: Move post actions into their own file. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86072 
[05:37:17] <grrrit-wm>	 (03PS1) 10Mattflaschen: Add 95% width on title so x is still top-right when title wraps [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86073 
[05:38:13] <grrrit-wm>	 (03CR) 10Krinkle: "(5 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen)
[05:39:26] <grrrit-wm>	 (03PS2) 10Mattflaschen: Add 95% width on title so x is still top-right when title wraps [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86073 
[05:44:42] <grrrit-wm>	 (03PS4) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 
[05:54:49] <grrrit-wm>	 (03PS3) 10Fantasticfears: Role: Add MLEB role [vagrant] - 10https://gerrit.wikimedia.org/r/85876 
[05:59:44] <grrrit-wm>	 (03PS4) 10Fantasticfears: Role: Add MLEB role [vagrant] - 10https://gerrit.wikimedia.org/r/85876 
[05:59:49] <grrrit-wm>	 (03CR) 10Mattflaschen: "(5 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen)
[06:00:44] <grrrit-wm>	 (03PS5) 10Mattflaschen: Updates to jsduck setup and comments [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 
[06:06:25] <grrrit-wm>	 (03PS1) 10PleaseStand: Use utf8 charset for searchindex MySQL table [core] - 10https://gerrit.wikimedia.org/r/86075 
[06:10:00] <grrrit-wm>	 (03CR) 10Swalling: [C: 031] "Working on Chrome, FF, Safari, and IE." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86073 (owner: 10Mattflaschen)
[06:13:21] <grrrit-wm>	 (03CR) 10PleaseStand: "Followed up with Ib4f30fd2730839af1323295898e6dce47b27068d. Does it still make sense to use 'utf8' even when the user selects 'binary' now" [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun)
[06:31:14] <YuviPanda>	 !logs
[06:31:14] <wm-bot>	 channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki
[06:33:52] <grrrit-wm>	 (03PS1) 10Pastakhov: Add array support. step 1 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/86077 
[06:38:00] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] Add array support. step 1 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/86077 (owner: 10Pastakhov)
[06:38:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add array support. step 1 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/86077 (owner: 10Pastakhov)
[06:44:02] <grrrit-wm>	 (03PS1) 10Ori.livneh: Fix typo in comment block in mediawiki.js [core] - 10https://gerrit.wikimedia.org/r/86078 
[06:44:19] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fix typo in comment block in mediawiki.js [core] - 10https://gerrit.wikimedia.org/r/86078 (owner: 10Ori.livneh)
[06:45:31] <Elsie>	 Scandalous.
[06:47:02] <ori-l>	 self merging like a gangsta
[06:48:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix typo in comment block in mediawiki.js [core] - 10https://gerrit.wikimedia.org/r/86078 (owner: 10Ori.livneh)
[06:49:27] <Elsie>	 <jenkins-bot> Hello. I'm here.
[06:50:15] <ori-l>	 i'm experimenting
[06:50:19] <ori-l>	 but not on editors, so it's ok
[06:51:27] <grrrit-wm>	 (03PS4) 10Tim Starling: Parse Ogg Opus files and enable playback if supported [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J)
[06:51:33] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Parse Ogg Opus files and enable playback if supported [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J)
[06:51:42] <Elsie>	 Someone linked this from WP:VPT today:
[06:51:43] <Elsie>	 http://www.dilbert.com/strips/comic/1994-12-17/
[06:51:46] <Elsie>	 I thought it was cute.
[06:51:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Parse Ogg Opus files and enable playback if supported [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J)
[07:03:43] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Add dependency on 'mediawiki.jqueryMsg' so mw.message will work [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86067 (owner: 10Legoktm)
[07:03:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add dependency on 'mediawiki.jqueryMsg' so mw.message will work [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/86067 (owner: 10Legoktm)
[07:27:24] <grrrit-wm>	 (03PS1) 10Siebrand: Run comments through formatComment [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/86080 
[09:15:19] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add labsvagrant.rb helper script [vagrant] - 10https://gerrit.wikimedia.org/r/86086 
[09:15:20] <YuviPanda>	 ori-l: ^
[09:16:01] <ori-l>	 six months from now, if there's a bug in that script, are you going to fix it?
[09:16:13] <YuviPanda>	 yes
[09:16:36] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add labsvagrant.rb helper script [vagrant] - 10https://gerrit.wikimedia.org/r/86086 (owner: 10Yuvipanda)
[09:16:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add labsvagrant.rb helper script [vagrant] - 10https://gerrit.wikimedia.org/r/86086 (owner: 10Yuvipanda)
[09:16:41] <YuviPanda>	 thank you!
[09:39:24] <YuviPanda>	 ori-l: ruby wtfism - there's no clean way to say 'load this other file in this path relative to the source file', before 1.9 :|
[09:41:46] * YuviPanda  grumbles

[09:44:02] <grrrit-wm>	 (03PS1) 10Yuvipanda: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 
[09:44:42] <grrrit-wm>	 (03PS2) 10Yuvipanda: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 
[09:50:44] <grrrit-wm>	 (03PS21) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[09:59:59] <grrrit-wm>	 (03CR) 10Hashar: "This most probably causes https://bugzilla.wikimedia.org/show_bug.cgi?id=54628" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/84333 (owner: 10Nemo bis)
[10:00:55] <hashar>	 Nemo_bis: if you are around, a change you made in GlobalBlocking ( https://gerrit.wikimedia.org/r/#/c/84333/ ) is most probably the cause of some backtrace on the beta cluster : https://bugzilla.wikimedia.org/show_bug.cgi?id=54628
[10:02:40] <grrrit-wm>	 (03PS3) 10Yuvipanda: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 
[10:07:08] <grrrit-wm>	 (03PS4) 10Yuvipanda: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 
[10:09:34] <grrrit-wm>	 (03PS5) 10Yuvipanda: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 
[10:22:01] <grrrit-wm>	 (03Abandoned) 10Physikerwelt: First test to replace png->svg [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 (owner: 10Physikerwelt)
[10:54:27] <grrrit-wm>	 (03PS1) 10Matthias Mullie: (bug 54520) Remove message 'articlefeedbackv5-error-email' from ArticleFeedbackv5.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 
[11:08:11] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_19) - 10https://gerrit.wikimedia.org/r/82574 (owner: 10CSteipp)
[11:08:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_19) - 10https://gerrit.wikimedia.org/r/82574 (owner: 10CSteipp)
[11:08:17] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_20) - 10https://gerrit.wikimedia.org/r/82573 (owner: 10CSteipp)
[11:08:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_20) - 10https://gerrit.wikimedia.org/r/82573 (owner: 10CSteipp)
[11:08:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_21) - 10https://gerrit.wikimedia.org/r/82572 (owner: 10CSteipp)
[11:08:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_21) - 10https://gerrit.wikimedia.org/r/82572 (owner: 10CSteipp)
[11:10:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 207 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84704 (owner: 10Reedy)
[11:10:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 207 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84704 (owner: 10Reedy)
[11:10:14] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 83 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84703 (owner: 10Reedy)
[11:10:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 83 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84703 (owner: 10Reedy)
[11:12:44] <zeljkof>	 ori-l: awake? :)
[11:14:18] <YuviPanda>	 zeljkof: hopefully not :P
[11:14:47] <zeljkof>	 YuviPanda: he replied to my e-mail 40 minutes ago 
[11:14:52] <zeljkof>	 just checking :)
[11:14:58] <YuviPanda>	 zeljkof: indeed, hence my 'hopefully' not :P
[11:16:06] <grrrit-wm>	 (03CR) 10Matthias Mullie: [V: 04-1] "These entries in `logging` are not only used by WMF's core logging code, but also to fetch a list of all actions performed on feedback ent" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/85338 (owner: 10Jackmcbarn)
[11:29:36] <grrrit-wm>	 (03PS22) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[11:29:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt)
[11:38:17] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 (owner: 10Yuvipanda)
[11:38:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use a hack to make labsvagrant import files relative to source [vagrant] - 10https://gerrit.wikimedia.org/r/86088 (owner: 10Yuvipanda)
[12:17:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/86095 (owner: 10L10n-bot)
[12:18:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/86095 (owner: 10L10n-bot)
[12:44:00] <dan-nl>	 anyone know of a tutorial or run down of how to use UploadStash?
[12:50:52] <YuviPanda>	 dan-nl: there are no docs that I could find, but poke bawolff, marktraceur, bd808|BUFFER perhaps
[12:52:10] <dan-nl>	 YuviPanda: k, thanks
[12:56:23] <grrrit-wm>	 (03CR) 10Matthias Mullie: "(1 comment)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84476 (owner: 10Reedy)
[13:06:38] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Adding a space character between links in the special page [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup)
[13:06:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding a space character between links in the special page [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup)
[13:08:26] <grrrit-wm>	 (03PS1) 10Aklapper: Distinguish 'MediaWiki' and 'MediaWiki extensions' in search results [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86097 
[13:10:12] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "(1 comment)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84476 (owner: 10Reedy)
[13:11:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Consistency updates in capitalisation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/86098 (owner: 10L10n-bot)
[13:11:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Consistency updates in capitalisation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/86098 (owner: 10L10n-bot)
[13:14:53] <grrrit-wm>	 (03CR) 10Aklapper: [C: 031] "Tested on boogs.wmflabs.org." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86097 (owner: 10Aklapper)
[13:50:45] <grrrit-wm>	 (03CR) 10Aude: "(1 comment)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/85986 (owner: 10Tobias Gritschacher)
[14:09:12] <hashar>	 can you believe that git version 1.7.9.5 is already too old for me ? 
[14:09:17] <hashar>	 it is missing a bunch of features :-(
[14:17:48] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna)
[14:20:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 (owner: 10Bsitu)
[14:30:09] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n LGTM." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[14:31:01] <grrrit-wm>	 (03PS1) 10Anomie: Explicitly clear forceHTTPS cookie when insecure [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86101 
[14:31:40] <marktraceur>	 YuviPanda|Away, dan-nl pretty sure the stashing API is still not well documented, sorry
[14:32:41] <dan-nl>	 marktraceur: thanks, i looked for a bit, but couldn't find anything either. for now i'm just reading through the code.
[14:35:23] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix boosts on prefix queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86103 
[14:38:13] <bd808>	 dan-nl: I haven't found any good overview of stashing yet either. Reading code is unfortunately your best bet at this point.
[14:38:52] <bd808>	 If you learn anything about I'd love to see your notes. Maybe we can get some better docs started somewhere.
[14:40:33] <bd808>	 I started tracing out ApiUpload but didn't get very far yet: https://www.mediawiki.org/wiki/User:BDavis_(WMF)/Notes/ApiUpload
[14:44:31] <marktraceur>	 Salut bawolff - how are things?
[14:45:00] <bawolff>	 Good
[14:45:22] <bawolff>	 How goes things with you and the multimedia team?
[14:45:55] <dan-nl>	 bd808: i agree, i imagine we could start a manual page for it ...
[14:47:18] <bawolff>	 Hi dan-nl, how are things coming with gwtoolset?
[14:48:08] <dan-nl>	 bawolff: so-so, i've been able to overcome getting a draft of using template data into the code. now it's the hurdle of overcoming how to handle the metadata sets
[14:49:02] <dan-nl>	 bawolff: had a meeting this morning with multichill to try and sort out another option. https://commons.wikimedia.org/wiki/Commons:GLAMToolset_project/Technical_Architecture/Maintain_versioned_Metadata_Sets
[14:50:33] <dan-nl>	 bawolff: i looked at score and saw how it was storing its files and after the discussion with multichill we both felt another approach might be better 
[14:51:54] <bawolff>	 So you would have for each image, an Original_metadata:Filename.jpg page that has the original metadata for that image?
[14:57:09] <marktraceur>	 bawolff: BetaFeatures and MultimediaViewer are approaching deployable states - BF is pretty much ready, MMV needs a few more additional bits of information. Still need to get your extension up and ready.
[14:57:20] <manybubbles>	  /join #wikimedia-meetbot
[14:57:45] <manybubbles>	 copy and paste you betray my intentions!
[14:58:09] * bd808  notices that manybubbles has evil plans

[14:58:30] <dan-nl>	 bawolff: yes, we were thinking of stashing the original xml, process it as a batch job to create individual original metadata content handler objects, which would contain the original metadata as a json. another batch job would upload the media file and a second content handler object would be an index/reference to the entire metadata set
[14:59:07] * multichill  waves

[14:59:11] <bawolff>	 marktraceur: Btw, fabrice invited me to a scrum meeting on november 6, where I think he meant to invite bd808 instead
[15:00:05] <manybubbles>	 bd808: I just listen to hashar :)
[15:00:53] <bd808>	 manybubbles: that sounds like a good plan. I read the email but went no farther
[15:01:28] <manybubbles>	 bd808: I get a perverse joy out of dealing with irc bots
[15:01:33] <manybubbles>	 I thank the log bots sometimes
[15:02:20] <bd808>	 bawolff, marktraceur: The meeting invite I have for 11/6 lists me but also bawolff. Maybe Fabrice is just trying to lure you back bawolff.
[15:02:48] <bawolff>	 bd808: The invite I got didn't have your name on it I'm pretty sure, although both could be true
[15:03:30] <bd808>	 manybubbles: bots need attention lest they turn evil and enslave us
[15:03:39] <bawolff>	 dan-nl / multichill : Hmm, I guess an alternate to that would be to add something like <originalMetadata>JsonHere</originalMetadata>  to the file description page (And possibly have that get plopped into page_props table), but then editors might accidentally edit it
[15:04:49] <multichill>	 bawolff: Nicest way would be multipart content handler, but afaik that isn't implemented yet
[15:06:16] <grrrit-wm>	 (03CR) 10Dzahn: [C: 031] "yea, because this is copied from ./default/ to ./custom/ the actual diff is:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86097 (owner: 10Aklapper)
[15:06:20] <bawolff>	 Which in theory should be not too hard to implement, but we really don't want to be adding more features to this project at this point
[15:06:24] <multichill>	 Embedding json in wikitext is, ehm, evil :P
[15:06:29] <marktraceur>	 Heh.
[15:06:55] <multichill>	 If multipart ever comes available, we can just merge the old pages with a bot
[15:07:33] <grrrit-wm>	 (03CR) 10Dzahn: [C: 032 V: 032] "yea, because this is copied from ./default/ to ./custom/ the actual diff is:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86097 (owner: 10Aklapper)
[15:08:56] <bawolff>	 marktraceur: So I had this really embarassing moment the other day, where I realized back in 2011 I redirected my talk page on commons to a subpage, and since then I haven't gotten any new message notifications
[15:30:56] <grrrit-wm>	 (03PS1) 10Parent5446: Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86107 
[15:32:28] <marktraceur>	 bawolff: Wow. :P
[15:32:51] <bawolff>	 yeah
[15:33:02] <mutante>	 good to know ...
[15:34:54] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(8 comments)" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur)
[15:35:06] <marktraceur>	 Woot
[15:37:56] <grrrit-wm>	 (03PS1) 10Parent5446: Fix error in call to wfRunHooks() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/86109 
[15:42:47] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86021 (owner: 10Brion VIBBER)
[15:45:39] <grrrit-wm>	 (03PS2) 10Brion VIBBER: bug 54378: remove duplicate file extensions from output messages [core] - 10https://gerrit.wikimedia.org/r/86021 
[15:45:50] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86021 (owner: 10Brion VIBBER)
[15:49:00] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Use utf8 charset for searchindex MySQL table [core] - 10https://gerrit.wikimedia.org/r/86075 (owner: 10PleaseStand)
[15:50:29] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] bug 54378: remove duplicate file extensions from output messages [core] - 10https://gerrit.wikimedia.org/r/86021 (owner: 10Brion VIBBER)
[15:51:01] <grrrit-wm>	 (03CR) 10Anomie: "Oops, hit the button before commenting: Code looks good, haven't tested the non-API code paths yet." [core] - 10https://gerrit.wikimedia.org/r/86021 (owner: 10Brion VIBBER)
[15:56:20] <grrrit-wm>	 (03PS1) 10Hashar: jobs for mw/ext/Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86114 
[15:56:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] jobs for mw/ext/Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86114 (owner: 10Hashar)
[15:56:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: jobs for mw/ext/Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86114 (owner: 10Hashar)
[15:57:30] <grrrit-wm>	 (03PS1) 10Manybubbles: Don't use SearchResult->initText. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86115 
[15:59:54] <grrrit-wm>	 (03PS1) 10Hashar: triggers jobs for Flow extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86117 
[16:00:33] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] triggers jobs for Flow extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86117 (owner: 10Hashar)
[16:00:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: triggers jobs for Flow extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86117 (owner: 10Hashar)
[16:02:07] <grrrit-wm>	 (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 
[16:02:11] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] "We don't already do that‽" [core] - 10https://gerrit.wikimedia.org/r/86028 (owner: 10Hoo man)
[16:05:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clear legacy restriction field on page restriction update [core] - 10https://gerrit.wikimedia.org/r/86028 (owner: 10Hoo man)
[16:08:02] <grrrit-wm>	 (03PS1) 10Hashar: empty jshintrc, make sure we use the jshint defaults [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86119 
[16:08:14] <grrrit-wm>	 (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 
[16:09:05] <grrrit-wm>	 (03CR) 10Hashar: "Whenever this is merged in, we can make the jshint Jenkins job voting." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86119 (owner: 10Hashar)
[16:12:22] <grrrit-wm>	 (03PS1) 10Hashar: Flow unit tests now voting (there is none) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86120 
[16:12:46] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Flow unit tests now voting (there is none) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86120 (owner: 10Hashar)
[16:12:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Flow unit tests now voting (there is none) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/86120 (owner: 10Hashar)
[16:13:26] <grrrit-wm>	 (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 
[16:15:44] <grrrit-wm>	 (03PS2) 10Hashar: empty jshintrc, make sure we use the jshint defaults [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86119 
[16:19:56] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] empty jshintrc, make sure we use the jshint defaults [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86119 (owner: 10Hashar)
[16:20:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: empty jshintrc, make sure we use the jshint defaults [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86119 (owner: 10Hashar)
[16:23:02] <marktraceur>	 anomie: Do you want to make the call as to whether "ApiQueryFileRepoInfo" makes more sense than "query.data.repos.file" or whatever?
[16:23:53] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Improve INITIAL_WORKFLOWS [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86071 (owner: 10Spage)
[16:25:04] * ebernhardson  would convert everything to dotted notation given the choice :)

[16:26:03] <marktraceur>	 ebernhardson: Well, I mean, there'll be dots no matter what, it's JSON, but I may need to separate the API modules, depending on what anomie thinks makes sense
[16:26:18] <marktraceur>	 Or just have methods in one class that get different types
[16:26:29] <anomie>	 marktraceur: Both have their advantages. ApiQueryFileRepoInfo, I suppose, although I could easily be talked out of it.
[16:26:51] <marktraceur>	 I have neither the interest nor the caffeine to do so
[16:27:05] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Tests for quotes turning of stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85910 (owner: 10Manybubbles)
[16:27:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests for quotes turning of stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85910 (owner: 10Manybubbles)
[16:28:03] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Quotes turn off stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85908 (owner: 10Manybubbles)
[16:28:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Quotes turn off stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85908 (owner: 10Manybubbles)
[16:33:07] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032] sample API call tweak [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86069 (owner: 10Spage)
[16:33:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: sample API call tweak [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86069 (owner: 10Spage)
[16:38:08] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix boosts on prefix queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86103 (owner: 10Manybubbles)
[16:38:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix boosts on prefix queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86103 (owner: 10Manybubbles)
[16:42:00] <manybubbles>	 thanks for the reviews ^d
[16:43:01] <grrrit-wm>	 (03CR) 10Nemo bis: "Needs rebase" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83673 (owner: 10Anubhavagarwal)
[16:43:22] <grrrit-wm>	 (03CR) 10Krinkle: "Reedy/Umherirrender: I'd recommend phrasing the commit subject in a more imperative mood next time (so it is clear and consise what actual" [core] - 10https://gerrit.wikimedia.org/r/84137 (owner: 10Umherirrender)
[16:43:23] <grrrit-wm>	 (03CR) 10Chad: "This potentially forces an extra parse per search result :\" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86115 (owner: 10Manybubbles)
[16:43:38] <^d>	 manybubbles: yw. I'm a little leery of 86115.
[16:43:57] <manybubbles>	 ^d: let me have another look.
[16:44:21] <manybubbles>	 ^d: It is pretty rare that we even get there but I noticed it today when verifying something else on cawiki
[16:45:58] <^d>	 I hate everything about this part of the code.
[16:46:02] <^d>	 And it's all my fault :)
[16:47:33] <manybubbles>	 ^d: awe!  if its any consolation at some point we'll get a fix from elasticsearch and that whole else block can be dropped
[16:47:48] <^d>	 Indeed.
[16:48:13] <marktraceur>	 anomie: I like the riprop thing, but I'm making sure the default is "all the properties"
[16:48:22] <grrrit-wm>	 (03CR) 10Chad: [C: 032] "It's ugly. We hate it. But we're fixing it elsewhere so it'll be ok for now." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86115 (owner: 10Manybubbles)
[16:48:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't use SearchResult->initText. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86115 (owner: 10Manybubbles)
[16:48:47] <manybubbles>	 ^d: I was just about to change it!
[16:48:51] <manybubbles>	 not like it'd been much better
[16:49:10] <anomie>	 marktraceur: I'm just a little concerned that if we have some other bit of information to add to one of the FileRepo subclasses, then we also have to add it as an option to riprop or it's not usable.
[16:49:19] <^d>	 manybubbles: If you have to call getTextFromContent() you're already screwed :)
[16:49:21] <manybubbles>	 In most cases we display search results without parsing the page at all
[16:49:27] <manybubbles>	 yeah
[16:50:40] <marktraceur>	 anomie: Well, true
[16:51:01] <marktraceur>	 I could also have it default to "don't limit the information I get back"
[16:51:27] <grrrit-wm>	 (03PS1) 10Chad: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86132 
[16:51:52] <grrrit-wm>	 (03PS1) 10Chad: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86133 
[16:52:05] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86133 (owner: 10Chad)
[16:52:10] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86132 (owner: 10Chad)
[16:52:21] <Reedy>	 ^d: Might wanna change wmf19 is up to date now...
[16:52:30] <Reedy>	 s/change/check/
[16:52:45] <^d>	 Dangit, I thought we were still on wmf17/18.
[16:52:50] <^d>	 That's what wikiversions said :)
[16:53:48] <Reedy>	 It's branched as of sometime in the last half an hour
[16:54:02] <manybubbles>	 Reedy: what would we do without you?
[16:54:18] <^d>	 Reedy: Ah, so nothing on it yet? Still couple of things lagging on 17?
[16:54:33] <Reedy>	 Deployment window isn't for another 66 minutes
[16:54:44] <manybubbles>	 ^d: we can probably get away without rebuilding anything with this release.
[16:54:44] <Reedy>	 MediaWiki 1.22wmf19, from 1.22wmf19, successfully checked out.
[16:55:23] <grrrit-wm>	 (03PS1) 10Chad: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86134 
[16:55:38] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86134 (owner: 10Chad)
[16:55:50] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86133 (owner: 10Chad)
[16:55:56] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86132 (owner: 10Chad)
[16:56:16] <^d>	 Reedy: Yeah I knew it was in an ~hour. I was trying to ride your scap :)
[16:57:08] <manybubbles>	 "ride your scap" I'm not sure about this phrase
[16:57:29] <Reedy>	 Just go along with it
[16:57:34] <Reedy>	 It's easier in the long run
[16:57:47] <grrrit-wm>	 (03CR) 10Nikerabbit: "It's not guaranteed but more likely. Wikis in different languages have the main page named differently." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86069 (owner: 10Spage)
[16:59:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86133 (owner: 10Chad)
[16:59:36] <grrrit-wm>	 (03CR) 10MaxSem: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[17:00:37] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add explicit plural support for limit report messages [core] - 10https://gerrit.wikimedia.org/r/86135 (owner: 10L10n-bot)
[17:00:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86132 (owner: 10Chad)
[17:02:02] <grrrit-wm>	 (03PS3) 10CSteipp: added a hook on articleDelete [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83673 (owner: 10Anubhavagarwal)
[17:03:48] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] "PS3 was a manual rebase, otherwise looks good" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83673 (owner: 10Anubhavagarwal)
[17:03:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cirrus to master (5e4b5f2) [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86134 (owner: 10Chad)
[17:04:14] <MaxSem>	 AaronSchulz, I discovered the source of PoolCounter errors in mobile - Title::exists() returning true for pages deleted days ago:P
[17:05:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add explicit plural support for limit report messages [core] - 10https://gerrit.wikimedia.org/r/86135 (owner: 10L10n-bot)
[17:07:17] <grrrit-wm>	 (03PS4) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[17:08:30] <grrrit-wm>	 (03CR) 10Nikerabbit: "(1 comment)" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/86080 (owner: 10Siebrand)
[17:13:01] <grrrit-wm>	 (03PS5) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[17:16:39] <gwicke>	 mwalker: ping
[17:16:44] <mwalker>	 pong
[17:16:54] <gwicke>	 hey, I have a question about varnish
[17:17:04] <gwicke>	 we currently store full HTML document
[17:17:43] <gwicke>	 and am wondering if we could use varnish to strip the head and footer so that we can use the same cached HTML as an ESI fragment
[17:18:28] <gwicke>	 one option might be to return a header with the range offsets of the body.innerHTML, and then rewrite the request as a range request if some parameter is given
[17:19:16] <gwicke>	 the other option might be to use regexps to find and extract the body
[17:19:38] <gwicke>	 do you think any of those options will work?
[17:19:39] <mwalker>	 hmm; I'm wondering how that would work with gzip encoding -- we could have the content served uncompressed and then compress it on the way out -- but that seems wasteful
[17:19:56] <gwicke>	 range requests seem to work on compressed content
[17:20:33] <grrrit-wm>	 (03CR) 10CSteipp: [V: 032] added a hook on articleDelete [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83673 (owner: 10Anubhavagarwal)
[17:21:12] <mwalker>	 its worth a try then; there is the be_req and be_resp hooks that we can use to detect if we're in an esi call and then figure out how to stream a range
[17:21:13] <^d>	 manybubbles: So re: bug 54643...I'm inclined to say no, but I could see the argument. How about we ask the channel? :)
[17:21:16] <gwicke>	 curl -H 'Range: bytes=94-150' http://en.wikipedia.org/wiki/Main_Page
[17:21:17] <gwicke>	 <title>Wikipedia, the free encyclopedia</title>
[17:21:46] <mwalker>	 are we running varnish on the cluster now?
[17:21:55] <^d>	 Hi everyone. So in searches, "incategory:" doesn't search subcats. Should it? Why or why not.
[17:21:58] <manybubbles>	 ^d: fair enough.
[17:21:59] <gwicke>	 afaik yes, but without ESI
[17:22:38] <^d>	 If nobody has opinions I'm going to start pinging indiscriminately ;-)
[17:22:56] <manybubbles>	 ^d: it looks like it doesn't do that now
[17:23:02] <manybubbles>	 as in, lucenesearch doesn't do it
[17:23:15] <legoktm>	 ^d: as in recursive searching? or just subcat names?
[17:23:21] <^d>	 The former.
[17:23:37] <brion>	 gwicke: that curl line grabs an uncompressed page
[17:23:41] <^d>	 manybubbles: My first intuition would be to do the same and not recurse.
[17:23:54] <gwicke>	 brion: yeah, good point
[17:23:59] <manybubbles>	 legoktm: so if you search incategory:films you get nothing
[17:24:03] <legoktm>	 hm
[17:24:07] <^d>	 brion: Thoughts?
[17:24:10] <manybubbles>	 legoktm: but if you search in incategory:"reboot films" you get something
[17:24:12] <legoktm>	 well, some categories can be really deep
[17:24:15] <mwalker>	 ^d: I would recurse -- seems more intuitive
[17:24:19] <legoktm>	 and others have loops :/
[17:24:21] <brion>	 ^d: did it used to search subcats?
[17:24:27] <^d>	 No it doesn't now.
[17:24:31] <^d>	 We're trying to decide if we should.
[17:24:44] <manybubbles>	 brion: I don't know if it used to long ago, but it doesn't now.
[17:24:48] <brion>	 i wouldn't even touch that until the new search is stable and at feature-parity
[17:24:55] <legoktm>	 if it works, it would be cool
[17:25:10] <brion>	 we also need to kill the entire category system with fire and replace it
[17:25:21] <gwicke>	 brion: and doing the same range request with Accept-Encoding: gzip gets compressed bytes
[17:25:23] <brion>	 with wikidata :D
[17:25:27] <legoktm>	 brion: yes :D
[17:25:28] <brion>	 gwicke: darn :(
[17:25:38] <^d>	 Mmk. Sounds reasonable.
[17:25:39] <gwicke>	 for ESI requests that should not be a problem though
[17:25:44] <manybubbles>	 sounds good to me.  not for now
[17:25:46] <^d>	 manybubbles: So let's lower priority and revisit it later.
[17:25:49] <manybubbles>	 yeah
[17:25:56] <gwicke>	 as we can simply make sure that Accept-Encoding does not include gzip
[17:25:59] <brion>	 ^d: but broadly speaking…. i'd say including sub cats makes sense from what i think users expect
[17:26:07] <^d>	 Indeed.
[17:26:07] <brion>	 so it's not a bad idea to look at :)
[17:27:16] <manybubbles>	 I've lowered the priority.  I can ask on the ambassadors mailing list as well.
[17:27:25] <manybubbles>	 I don't _think_ it'd be that big a project.
[17:27:46] <mwalker>	 gwicke: I have a hammer currently -- what if we proxied the response through node/nginx to strip the bits we didn't want?
[17:27:50] <manybubbles>	 it might require some more db hitting on search update and we already are slow enough
[17:27:59] <manybubbles>	 but the search engine wouldn't mind the extra data
[17:28:01] <gwicke>	 mwalker: haha ;)
[17:28:15] <gwicke>	 but yes, certainly an option
[17:29:27] <gwicke>	 it seems that we'll find a way to do it in any case, so storing / caching a full document should be fine
[17:30:35] <^d>	 ori-l: Ping.
[17:31:26] <^d>	 Or anyone who knows vagrant, really.
[17:31:46] <Reedy>	 bd808 ^
[17:33:08] <Reedy>	 lol
[17:33:11] <Reedy>	 Is that hiding?
[17:33:20] <bd808|MEETING>	 Reedy: not exactly :)
[17:35:06] <bd808|MEETING>	 ^d: what help do you need. I have some puppet fu
[17:35:25] <^d>	 I have puppet fu :)
[17:35:26] <^d>	 Do I have to use VirtualBox or is there a way to massage Parallels into handling the virtualization?
[17:35:28] <dan-nl>	 bd808|MEETING: i think we need to be invited to our gmail addresses
[17:35:49] <dan-nl>	 bd808|MEETING: the others are not working
[17:35:57] <bd808|MEETING>	 dan-nl: ok I'll poke Fabrice
[17:36:50] <bd808|MEETING>	 dan-nl: Fabrice is working on getting something figured out
[17:37:07] <legoktm>	 ^d: http://stackoverflow.com/questions/14087966/switch-vagrant-to-use-parallels-instead-of-virtualbox
[17:37:43] <legoktm>	 and https://github.com/yshahin/vagrant-parallels
[17:37:46] <dan-nl>	 bd808|MEETING: if fabrice can set the chat to public that should take care of it
[17:38:38] <multichill>	 greg-g: Stupid hangout
[17:38:43] <^d>	 legoktm: Sweet, thanks! That github plugin looks like it'll work perfect!
[17:39:07] <brion>	 ^d: so i just asked yuvi that an hour ago; sounds like you can use VMWare but parallels ain't integrated with vagrant yet
[17:39:19] <brion>	 just don't run parallels and virtual box VMs at the same time
[17:39:22] <brion>	 it may crash your mac :)
[17:39:31] <^d>	 I'm trying https://github.com/yshahin/vagrant-parallels
[17:39:37] <brion>	 ooooh
[17:39:42] <brion>	 ok that's worth investigating \o/
[17:40:03] <bd808|MEETING>	 brion: kernel panics are likely with multiple vm providers for sure
[17:40:24] <bd808|MEETING>	 dan-nl: Fabrice is trying to add all of you to his circles
[17:40:47] <^d>	 Awww :(
[17:40:50] <^d>	 The box you attempted to add doesn't match the provider you specified.
[17:40:50] <^d>	 Provider expected: parallels
[17:40:50] <^d>	 Provider of box: virtualbox
[17:40:56] <bd808|MEETING>	 Apparently starting hangout from google apps for domains account causes wonkyness
[17:40:58] <dan-nl>	 bd808|MEETING: i think he has to invite us with the gmail address … but there should be a way to make the hangout public
[17:41:27] <manybubbles>	 ^d: I'm going to head out.  Give me a call if the CirrusSearch deloy goes badly.
[17:41:29] <bd808|MEETING>	 technology is hard
[17:41:32] <^d>	 mmk.
[17:41:54] <greg-g>	 multichill: no kidding :(
[17:41:59] <legoktm>	 ^d: try editing the Vagrantfile?
[17:43:29] <grrrit-wm>	 (03PS5) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 
[17:43:30] <grrrit-wm>	 (03PS13) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 
[17:43:31] <grrrit-wm>	 (03PS21) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 
[17:43:52] <bd808|MEETING>	 dan-nl: Fabrice is starting a new chat. Apparently you can't add "public" after it's running
[17:44:51] <grrrit-wm>	 (03CR) 10Jdlrobson: "Ok I created a new generic mixin which supports any kind of gradients and images. We might want to revisit this mixin later in favour of a" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[17:45:03] <multichill>	 greg-g: New one works
[17:45:30] <multichill>	 dan-nl: New one works
[17:45:51] <bd808|MEETING>	 multichill: link?
[17:46:01] <greg-g>	 link?
[17:47:46] <multichill>	 dan-nl: Link is in the mail
[17:47:46] <bd808|MEETING>	 greg-g: should I cut over?
[17:50:29] <greg-g>	 bd808|MEETING: try this one 6~https://plus.google.com/hangouts/_/55ba7a70088bfc83eaef0f169e39a4a46ea53092?authuser=0&hl=en
[17:50:45] <greg-g>	 marktraceur: https://plus.google.com/hangouts/_/55ba7a70088bfc83eaef0f169e39a4a46ea53092?authuser=0&hl=en
[17:51:35] <marktraceur>	 This is going SUPER WELL
[17:51:42] <greg-g>	 marktraceur: lol
[17:52:05] <multichill>	 It's decided: FUCK THIS, we're doing it on irc
[17:52:21] <marktraceur>	 Eff it, #wikimedia-multimedia is nice and quiet this time of year
[17:52:34] <marktraceur>	 multichill, dan-nl, greg-g, etc. ^
[17:55:53] <marktraceur>	 AaronSchulz: #wikimedia-multimedia
[18:15:27] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[18:15:50] <grrrit-wm>	 (03PS1) 10Anubhavagarwal: fixed the column name, added a hook LoadExtensionSchemaUpdate, fixed the join condition in dbHandler [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/86149 
[18:16:46] <grrrit-wm>	 (03PS1) 10Chad: Moving classes out of top level, things were getting crowded [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86150 
[18:18:09] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032 V: 032] "Thanks!" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/86149 (owner: 10Anubhavagarwal)
[18:18:20] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[18:26:51] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 (owner: 10Werdna)
[18:26:57] <grrrit-wm>	 (03PS6) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 
[18:26:58] <grrrit-wm>	 (03PS14) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 
[18:26:59] <grrrit-wm>	 (03PS22) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 
[18:28:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson)
[18:29:13] <grrrit-wm>	 (03CR) 10Jdlrobson: "fixed kaldari's comments" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[18:29:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[18:35:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Something weird happened in the rebase.. fixing now." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[18:35:39] <grrrit-wm>	 (03PS2) 10Bsitu: Bundle message should show diff of all included revisions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 
[18:37:59] <grrrit-wm>	 (03PS15) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 
[18:42:36] <grrrit-wm>	 (03PS1) 10Chad: Clean up language test cases objection construction [core] - 10https://gerrit.wikimedia.org/r/86151 
[18:43:31] <Reedy>	       6 Catchable fatal error:  Argument 2 passed to wfRunHooks() must be an array, string given, called in /usr/local/apache/common-local/php-1.22wmf19/extensions/Glob
[18:43:31] <Reedy>	 alBlocking/GlobalBlocking.class.php on line 79 and defined in /usr/local/apache/common-local/php-1.22wmf19/includes/GlobalFunctions.php on line 3897
[18:43:53] <andre__>	 Reedy, I guess the popularity of "[0041230f] 2013-09-26 18:41:11: Fatal exception of type MWException" on random pages is known and being worked on?
[18:43:58] * andre__  just got back home and online

[18:44:14] <Reedy>	 I haven't looked
[18:44:20] <Reedy>	 But I presume they're what i just posted
[18:44:38] <andre__>	 see https://bugzilla.wikimedia.org/show_bug.cgi?id=54628
[18:44:54] <andre__>	 has two patches
[18:45:20] <andre__>	 e.g. https://www.mediawiki.org/wiki/Special:NewMessages triggers "[0041230f] 2013-09-26 18:41:11: Fatal exception of type MWException" for me
[18:45:21] <Reedy>	 ffs
[18:46:21] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86107 (owner: 10Parent5446)
[18:46:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86107 (owner: 10Parent5446)
[18:46:43] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix error in call to wfRunHooks() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/86109 (owner: 10Parent5446)
[18:46:44] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86072 (owner: 10Werdna)
[18:46:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix error in call to wfRunHooks() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/86109 (owner: 10Parent5446)
[18:46:48] <hoo>	 Login is broken...
[18:46:55] <andre__>	 many things are broken...
[18:47:10] <Reedy>	      49 Fatal error:  Base lambda function for closure not found in /usr/local/apache/common-local/php-1.22wmf19/includes/DefaultSettings.php on line 3331
[18:47:12] <Reedy>	 Ugh
[18:47:15] <Reedy>	 Things are seriously broken
[18:47:23] <grrrit-wm>	 (03PS2) 10Chad: Clean up language test cases objection construction [core] - 10https://gerrit.wikimedia.org/r/86151 
[18:47:24] <grrrit-wm>	 (03PS1) 10Reedy: Update GlobalBlocking to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86152 
[18:47:37] <Reedy>	 $wgResourceLoaderLESSFunctions
[18:47:50] <Reedy>	 brion ^
[18:47:56] <marktraceur>	 Guys
[18:47:59] <hoo>	 Reedy: Can't you revert for now?
[18:48:06] <Reedy>	 yup, just doing
[18:48:12] <marktraceur>	 $wgResourceLoaderFEWERFunctions. Seriously.
[18:48:32] <brion>	 base lambda function for closure not found?
[18:48:32] <andre__>	 LESS: https://gerrit.wikimedia.org/r/#/c/78669/ ?
[18:48:34] <brion>	 wtf does that mean
[18:49:21] <brion>	 Reedy: so easiest ways to fix this are either 'figure out what's throwing this false error' or 'move the functions from lambdas to global functions or a class'
[18:49:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update GlobalBlocking to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86152 (owner: 10Reedy)
[18:50:10] <brion>	 https://bugs.php.net/bug.php?id=52144
[18:50:21] <Reedy>	 brion: PHP 5.3 issue?
[18:50:28] <grrrit-wm>	 (03PS1) 10Reedy: Update TorBlock to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86153 
[18:50:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update TorBlock to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86153 (owner: 10Reedy)
[18:51:17] <brion>	 Reedy: looks like
[18:51:27] <brion>	 Reedy: want me to do a quick patch that moves the functions to a class, see if that helps?
[18:51:39] <Reedy>	 I wonder why Jenkins didn't catch it...
[18:51:52] <brion>	 well it's apparently intermittent judging by that bug comments
[18:51:55] <brion>	 *bug's
[18:52:08] <Reedy>	 gg PHP
[18:52:13] <PleaseStand>	 brion: Sure, this code doesn't belong in DefaultSettings anyway
[18:52:49] <brion>	 ok gimme a couple mins
[18:57:00] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Move LESS function definitions from DefaultSettings to LESSFunctions.php [core] - 10https://gerrit.wikimedia.org/r/86154 
[18:57:01] <brion>	 Reedy: PleaseStand: ^
[18:57:16] <grrrit-wm>	 (03PS5) 10MarkTraceur: Add meta=filerepoinfo for getting file repo info [core] - 10https://gerrit.wikimedia.org/r/85344 
[18:57:27] <marktraceur>	 Watch it fail to rebase
[18:57:31] <brion>	 heh
[18:58:49] <marktraceur>	 rmoen, James_F is gossipping about https://gerrit.wikimedia.org/r/85344 in particular.
[18:59:00] <grrrit-wm>	 (03PS1) 10Reedy: Move LESS function definitions from DefaultSettings to LESSFunctions.php [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86155 
[19:01:41] * marktraceur  cannot load Gerrit

[19:01:49] <marktraceur>	 Or at least not that change
[19:02:01] <brion>	 ok i gotta run and wander down to the office to catch up with monte -- be back later
[19:02:04] <marktraceur>	 Oh FFS
[19:03:56] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Move LESS function definitions from DefaultSettings to LESSFunctions.php [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86155 (owner: 10Reedy)
[19:07:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move LESS function definitions from DefaultSettings to LESSFunctions.php [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86155 (owner: 10Reedy)
[19:11:01] <grrrit-wm>	 (03PS1) 10Rfaulk: rm / fix - TODOs that are no longer needed / fix call to _sync in revert. [sartoris] - 10https://gerrit.wikimedia.org/r/86157 
[19:11:25] <grrrit-wm>	 (03CR) 10Rfaulk: [C: 032 V: 032] rm / fix - TODOs that are no longer needed / fix call to _sync in revert. [sartoris] - 10https://gerrit.wikimedia.org/r/86157 (owner: 10Rfaulk)
[19:22:09] <grrrit-wm>	 (03PS6) 10EBernhardson (WMF): See that a post has been edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 
[19:22:21] <ori-l>	 my computer died, am using a spare while mountain lion is reinstalling
[19:22:35] <ori-l>	 I see some LESS hubub above but I don't have enough context
[19:22:43] <ori-l>	 can someone give me an update?
[19:22:48] <ori-l>	 Reedy: ?
[19:23:16] <Reedy>	 Your LESS stuff breaks in PHP 5.3
[19:23:24] <Reedy>	 Well, your LESS lamdba stuff does
[19:23:35] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Distinguish "formatted" from "unformatted" post revisions, and do not bother storing HTML for unformatted post revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86066 (owner: 10Werdna)
[19:23:36] <Reedy>	 https://gerrit.wikimedia.org/r/86154 is brion-away fix
[19:24:19] <MatmaRex>	 lolphp.
[19:24:29] <Reedy>	 Warning:  array_map() [<a href='function.array-map'>function.array-map</a>]: An error occurred while invoking the map callback in /usr/local/apache/common-local/php-1.22wmf19/includes/Exception.php on line 413
[19:25:29] <ori-l>	 what the hell, PHP.
[19:27:16] <ori-l>	 so, I'm not one to kick the can, but really, it's PHP that is broken here
[19:27:26] <ori-l>	 brion-away / Reedy thanks for the fix
[19:28:00] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Moving classes out of top level, things were getting crowded [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86150 (owner: 10Chad)
[19:28:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moving classes out of top level, things were getting crowded [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/86150 (owner: 10Chad)
[19:29:45] <grrrit-wm>	 (03PS1) 10Nikerabbit: Test "General statistics about the user's contributions are shown" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86159 
[19:42:02] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Test "General statistics about the user's contributions are shown" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86159 (owner: 10Nikerabbit)
[19:42:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test "General statistics about the user's contributions are shown" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86159 (owner: 10Nikerabbit)
[19:42:43] <grrrit-wm>	 (03PS1) 10Hashar: releasing experiment [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86160 
[19:44:06] <grrrit-wm>	 (03CR) 10Reedy: "There is/was another on line 100" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86107 (owner: 10Parent5446)
[19:44:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[19:45:41] <grrrit-wm>	 (03PS1) 10Reedy: Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86161 
[19:46:38] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86161 (owner: 10Reedy)
[19:46:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix error in call to wfRunHooks() [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/86161 (owner: 10Reedy)
[19:47:27] <grrrit-wm>	 (03PS1) 10Reedy: Update GlobalBlocking to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86163 
[19:47:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update GlobalBlocking to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86163 (owner: 10Reedy)
[19:55:01] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Added some qqq messages. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86165 
[19:56:34] <MaxSem>	 manybubbles, are you subscribed to ops@ ?
[19:56:42] <manybubbles>	 MaxSem: yes
[19:56:47] <manybubbles>	 have I missed something?
[19:57:09] <MaxSem>	 nope, just wanted to be sure that I won't miss you in my email:)
[20:09:26] <grrrit-wm>	 (03PS7) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 
[20:09:27] <grrrit-wm>	 (03PS23) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 
[20:20:42] <Nemo_bis>	 Reedy: thanks for cleaning up my mess again.
[20:31:30] <grrrit-wm>	 (03PS2) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 
[20:34:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Added some qqq messages. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86165 (owner: 10Aaron Schulz)
[20:34:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added some qqq messages. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/86165 (owner: 10Aaron Schulz)
[20:36:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n LGTM." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF))
[20:36:44] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n LGTM." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[20:38:06] <MatmaRex>	 hey guys, history question
[20:38:20] <MatmaRex>	 what year were the categories added to mediawiki?
[20:38:38] <MatmaRex>	 before or after 2004?
[20:39:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Drop obsolete 'mobileTargets' from module declarations [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86060 (owner: 10Ori.livneh)
[20:42:16] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Add 95% width on title so x is still top-right when title wraps [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86073 (owner: 10Mattflaschen)
[20:42:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 (owner: 10Ori.livneh)
[20:42:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 95% width on title so x is still top-right when title wraps [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86073 (owner: 10Mattflaschen)
[20:44:31] <grrrit-wm>	 (03PS3) 10Jdlrobson: Update schema to 5832704 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 (owner: 10Ori.livneh)
[20:45:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Checked with Ori in person about the comment I added." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 (owner: 10Ori.livneh)
[20:45:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update schema to 5832704 [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86053 (owner: 10Ori.livneh)
[20:45:37] <grrrit-wm>	 (03PS2) 10Jdlrobson: Drop obsolete 'mobileTargets' from module declarations [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86060 (owner: 10Ori.livneh)
[20:45:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Drop obsolete 'mobileTargets' from module declarations [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86060 (owner: 10Ori.livneh)
[20:45:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Drop obsolete 'mobileTargets' from module declarations [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86060 (owner: 10Ori.livneh)
[20:46:33] <^d>	 Someone wanna do a code review? It's easy I promise.
[20:46:57] <^d>	 And fixes ~400 failing tests in hhvm :)
[20:47:00] * marktraceur  isn't sure he should trust ^d

[20:47:43] <^d>	 Thanks for volunteering :)
[20:47:45] <^d>	 https://gerrit.wikimedia.org/r/#/c/86151/
[20:49:13] <grrrit-wm>	 (03PS1) 10Mattflaschen: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86171 
[20:50:13] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Latest" [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86171 (owner: 10Mattflaschen)
[20:50:58] <grrrit-wm>	 (03Abandoned) 10Reedy: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86171 (owner: 10Mattflaschen)
[20:51:44] <marktraceur>	 RoanKattouw: You once said "I'm sure terrorists use Microsoft Excel to manage stuff, that doesn't mean Microsoft supports terrorism, right? ;)" well, we're now closer to proving it: http://www.cnn.com/2013/09/26/world/london-bombing-plot-qaeda/index.html
[20:51:58] <marktraceur>	 "The Word document, written in English, which CNN understands was stored on a thumb drive, was found when Fazul Abdullah Mohammed -- architect of the U.S. Embassy bombings in Nairobi and in Dar es Salaam, Tanzania, in 1998 -- was killed at a government checkpoint in the Somali capital, Mogadishu..."
[20:53:43] <RoanKattouw>	 Nice! :)
[20:53:58] <grrrit-wm>	 (03PS1) 10MarkTraceur: Put username into title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 
[20:54:25] <^d>	 Do they use powerpoint for training seminars?
[20:55:38] * ^d  still needs a code review :\

[20:57:37] <grrrit-wm>	 (03CR) 10Jdlrobson: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[20:57:58] <helderwiki>	 What is the maximum length allowed for an URI of the form https://pt.wikipedia.org/w/api.php?action=query&format=json&prop=revisions&rvdiffto=prev&revids=123|456|789|...? 
[20:58:14] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032] Modify ldap schema for hosts. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 (owner: 10Andrew Bogott)
[20:58:15] <grrrit-wm>	 (03PS16) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 
[20:58:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Modify ldap schema for hosts. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 (owner: 10Andrew Bogott)
[20:58:26] <helderwiki>	 (I used a long list of revids and got "414 Request-URI Too Large")
[20:58:35] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032] Rename 'hostname' to 'instanceid' in a bunch of places. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/85991 (owner: 10Andrew Bogott)
[20:58:46] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032] Clear the host array for each IP. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/85992 (owner: 10Andrew Bogott)
[20:58:47] <Reedy>	 255
[20:59:07] <helderwiki>	 Is tis number defined by some config variable?
[20:59:09] <helderwiki>	 *this
[20:59:10] <Reedy>	 No
[20:59:16] <Reedy>	 https://www.google.co.uk/search?q=HTTP+GET+Limit&oq=HTTP+GET+Limit&aqs=chrome..69i57j0l2j5.2238j0&sourceid=chrome&ie=UTF-8
[20:59:18] <Reedy>	 Have a read
[20:59:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename 'hostname' to 'instanceid' in a bunch of places. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/85991 (owner: 10Andrew Bogott)
[20:59:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clear the host array for each IP. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/85992 (owner: 10Andrew Bogott)
[21:01:12] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] "Tests pass for me on mediawiki-vagrant dev server." [core] - 10https://gerrit.wikimedia.org/r/86151 (owner: 10Chad)
[21:01:17] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 (owner: 10Bsitu)
[21:01:39] <bd808>	 ^d: I gave it a +1 to get the ball rolling
[21:02:10] <^d>	 bd808: Thanks :)
[21:02:15] <helderwiki>	 Thanks Reedy!
[21:03:20] <bd808>	 ^d: we need a role::hhvm for vagrant
[21:03:58] <^d>	 bd808: Not a bad idea. It's still kind of a pain in the ass to build though :\
[21:04:40] <bd808>	 That's what you were telling me. How unpossible would a PPA for it be to setup?
[21:05:28] <^d>	 Not unpossible.
[21:05:40] <^d>	 ubuntu as of raring only has one weird dependency.
[21:05:50] <^d>	 Everything else is in apt.
[21:06:12] <grrrit-wm>	 (03PS1) 10Mattflaschen: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86173 
[21:07:01] <bd808>	 Mediawiki-vagrant is still precise. Which is probably a good idea if that's the dominant server version
[21:08:42] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Latest GuidedTour" [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86173 (owner: 10Mattflaschen)
[21:11:07] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[21:11:23] <grrrit-wm>	 (03PS1) 10Mattflaschen: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86174 
[21:11:34] <MatmaRex>	 ori-l: around? we need a LESS expert ;) https://gerrit.wikimedia.org/r/#/c/83591/16/resources/mediawiki.less/mediawiki.mixins.less
[21:11:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86173 (owner: 10Mattflaschen)
[21:11:56] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Latest GuidedTour" [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86174 (owner: 10Mattflaschen)
[21:12:27] <marktraceur>	 I guess I should be changing my extensions' stylesheets to LESS
[21:13:12] <MatmaRex>	 meh, plain old CSS is still in fashion ;)
[21:13:47] <marktraceur>	 Yeah, but there are valid reasons for this
[21:14:00] <marktraceur>	 MatmaRex: Is there documentation on mw.org somewhere?
[21:14:33] <MatmaRex>	 marktraceur: documentation of what? less?
[21:14:53] <marktraceur>	 Yeah - well, less in ResourceLoader.
[21:14:54] <MatmaRex>	 i doubt it :P but there's not that much to document
[21:15:15] <superm401>	 marktraceur, we have a stub: https://www.mediawiki.org/wiki/Manual:Coding_conventions/LESS
[21:15:19] <superm401>	 But it's out of date.
[21:15:20] <MatmaRex>	 rename your .css file to .less, fix the path in resource, presto
[21:15:50] <marktraceur>	 Wexcellent.
[21:15:50] <MatmaRex>	 the custom functions and mixins need documenting, but they're still in flux
[21:16:02] <MatmaRex>	 jon's patch above is adding a mixin, for example
[21:16:08] <superm401>	 MatmaRex, if you do that @embed won't work.
[21:16:30] <marktraceur>	 Mostly I just want the nesting stuff
[21:16:33] <MatmaRex>	 superm401: yeah
[21:16:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump GuidedTour for Growth team deployment [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86174 (owner: 10Mattflaschen)
[21:17:00] <MatmaRex>	 marktraceur: if you use @noflip or @embed, they don't work anymore
[21:17:10] <MatmaRex>	 @noflip currently has no replacement, @embed has a mixin
[21:17:24] <MatmaRex>	 see resources/mediawiki.less/somehting.less for list
[21:17:35] <marktraceur>	 I use neither of those things
[21:18:01] <hoo>	 https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap needs updating...
[21:18:34] <MatmaRex>	 hoo: there's been a trouble with today's test deployment, i think
[21:18:50] <MatmaRex>	 php can't handle toplevel closures. :D
[21:19:00] <hoo>	 but I think that has been fixed
[21:19:04] <MatmaRex>	 so the less stuff broke it
[21:19:05] <MatmaRex>	 dunno
[21:19:09] <MatmaRex>	 ask Reedy
[21:19:12] <MatmaRex>	 brb
[21:19:31] <superm401>	 It's at 18 and 19.
[21:20:53] <superm401>	 hoo, updated.
[21:21:40] <hoo>	 thx... I hope Reedy can do that next time :P
[21:21:40] <grrrit-wm>	 (03PS1) 10Nikerabbit: Tests for translate recent and proofread recent button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 
[21:22:58] <superm401>	 marktraceur, https://www.mediawiki.org/wiki/Manual:Coding_conventions/LESS updated
[21:22:59] <Nemo_bis>	 MatmaRex: have you checked Denny's and Mathias' paper? :) Categories were in use since UseMod, just not with specific support. I believe they were among the first namespaces introduced?
[21:23:15] <marktraceur>	 Thanks
[21:26:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 (owner: 10Kaldari)
[21:33:15] <grrrit-wm>	 (03CR) 10Amire80: [C: 04-1] "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 (owner: 10Nikerabbit)
[21:35:24] <spagewmf>	 HTMLForm passes $formData and $form to your submit callback, but FormSpecialPage declares the callback abstract function onSubmit( $formData ). Is there some l33t way to get the second parameter despite the signature?
[21:36:00] <Nikerabbit>	 is gerrit slow for other people as well?
[21:36:16] <Nikerabbit>	 git pull takes a while for me and amir
[21:40:54] <spagewmf>	 spagewmf, PHP's func_get_args() reveals the second parameter missing from the callback declaration (bug 54666) yw :)
[21:44:07] <ori-l>	 MatmaRex: so, that's not entirely accurate -- @noflip comments work as before, with the proviso that they work when applied to entire selector blocks rather than individual rules
[21:44:29] <ori-l>	 the reason being that LESS reorders rules within blocks so if you're reliant on your comment being above some specific rule LESS may upset it
[21:44:59] <ori-l>	 for embed stuff, I'm dragging my feet a little bit because I have a hunch there's a better across-the-board solution that doesn't involve adding 20 mixins
[21:45:53] <ori-l>	 adding the 20 mixins (not actually 20 but, you know, $fooNumber) would be OK, because it wouldn't cause any bloating of the generated CSS, but it's still a bit gross
[21:46:53] <ori-l>	 so one of the things i've been thinking about is.. do we really need embed? maybe we should just call embeddable() on every image reference and embed everything we can without relying on the person writing the styles to actually remember to put /* @embed */ annotations everywhere
[21:47:05] <grrrit-wm>	 (03PS1) 10Nikerabbit: Replace Proofread with Review for consistenct terminology in UI [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86181 
[21:47:30] <grrrit-wm>	 (03PS2) 10Amire80: Replace Proofread with Review for consistenct terminology in UI [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86181 (owner: 10Nikerabbit)
[21:47:38] <ori-l>	 if we did that, maybe we could get rid of both syntaxes (i.e., both /* @embed */ and embed()) and just modify CSSMin to grep for url() instead
[21:48:01] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Replace Proofread with Review for consistent terminology in UI [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86181 (owner: 10Nikerabbit)
[21:48:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Proofread with Review for consistent terminology in UI [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86181 (owner: 10Nikerabbit)
[21:48:11] <ori-l>	 ^ MatmaRex
[21:48:20] <ori-l>	 (pinging because i'm interested to know what you think.)
[21:48:22] <MatmaRex>	 Nemo_bis: no, what paper?
[21:48:31] <MatmaRex>	 ori-l: (reading scrollback…)
[21:50:16] <MatmaRex>	 ori-l: re @noflip – well, then it clearly needs documenting :P
[21:50:34] <ori-l>	 MatmaRex: yes, I'm sorry about that, just haven't gotten to it
[21:50:35] <MatmaRex>	 ori-l: re @embed – it is theoretically possible that certain resources should not be embedded
[21:50:51] <ori-l>	 like what?
[21:50:58] <MatmaRex>	 maybe fonts, for example, dunno how we handle these now
[21:51:07] <RoanKattouw>	 @embed should be the default, most likely
[21:51:16] <RoanKattouw>	 And fonts are too large to embed anyway
[21:51:17] <MatmaRex>	 or large images
[21:51:28] <RoanKattouw>	 Things >24KB can't be embedded without breaking IE
[21:51:28] <MatmaRex>	 full-page backgrounds, maybe?
[21:51:30] <RoanKattouw>	 And so we don't
[21:51:46] <MatmaRex>	 Nikerabbit was doing something like that in his twnmainpage, i believe
[21:51:48] <ori-l>	 MatmaRex: the IE size limit exempts all of these things anyway
[21:51:49] <RoanKattouw>	 (URLs, including data URLs, are limited to 32K chars in IE)
[21:51:55] <MatmaRex>	 and the ULS team was doing fonts
[21:52:21] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Sometimes we search for nonexistent hosts; be polite. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86182 
[21:52:23] <MatmaRex>	 i dunno, it might be a good idea
[21:52:26] <ori-l>	 the fonts are too large to embed, so their annotations had no effect on the behavior of cssmin, most likely
[21:52:33] <Nikerabbit>	 hmm?
[21:52:38] <MatmaRex>	 you're right about the size limit, i forgot about it
[21:52:57] <ori-l>	 Nikerabbit: did you explicitly specify that fonts should or should not be embedded somewhere?
[21:53:16] <Nemo_bis>	 MatmaRex: http://edouard-lopez.com/fac/ICPS%20-%20S8/Maiw/Introducing%20new%20features%20to%20Wikipedia%20-%20Case%20studies%20for%20Web%20science.pdf
[21:53:19] <ori-l>	 (it doesn't matter much either way, just curious.)
[21:53:29] <Nikerabbit>	 ori-l: huh?
[21:53:57] <MatmaRex>	 Nemo_bis: looks fun, i'm gonna read it, thanks
[21:53:59] <ori-l>	 Nikerabbit: nevermind, ignore me :P i wasn't suggesting you did anything wrong
[21:54:05] <MatmaRex>	 "The category system was introduced to MediaWiki in 2004 in order to solve that problem"  – this also answers my question. :D
[21:54:28] <Nikerabbit>	 ori-l: we (uls) are generating font css dynamically, so it is not relevant to this discussion
[21:54:38] <ori-l>	 aha, OK
[21:55:25] <ori-l>	 so it seems like if nothing else, if we have any annotation at all, it should be @noembed rather than @embed
[21:55:42] <ori-l>	 but we could potentially do without any embed annotations at all
[21:57:46] <ori-l>	 you know what would be really cool and fortuitous...  I wonder what would happen if we defined a 'url' as a function
[21:57:52] <ori-l>	 would LESS invoke it for every URL property?
[21:57:56] <ori-l>	 that would be awesome.
[21:58:19] <grrrit-wm>	 (03PS2) 10Bsitu: Add primary/secondary link, email, bundling to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 
[21:59:26] <MatmaRex>	 ori-l: making @embed default makes sense to me
[21:59:52] <MatmaRex>	 ori-l: i guess we'd want to keep behavior the same for .css and .less? this would technically break backawrds-compatibility
[21:59:57] <grrrit-wm>	 (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86151 (owner: 10Chad)
[22:00:20] <grrrit-wm>	 (03PS3) 10Bsitu: Add primary/secondary link, email, bundling to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 
[22:00:43] <RoanKattouw>	 We could just make embedding the default in LESS, right?
[22:00:55] <RoanKattouw>	 Then as we migrate things from CSS to LESS, they'll start embedding by default
[22:01:00] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Fixed wrong include path [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/86186 
[22:01:05] <grrrit-wm>	 (03PS2) 10Nikerabbit: Tests for translate recent and proofread recent button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 
[22:02:10] <Nemo_bis>	 MatmaRex: yes it does but I wanted you to open the link to find it :P
[22:02:45] <ori-l>	 RoanKattouw: yes, I think so
[22:04:13] <MatmaRex>	 RoanKattouw: yeah, but that would be kinda uncool imo
[22:05:10] <grrrit-wm>	 (03PS2) 10Ryan Lane: Sometimes we search for nonexistent hosts; be polite. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86182 (owner: 10Andrew Bogott)
[22:05:42] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032] Sometimes we search for nonexistent hosts; be polite. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86182 (owner: 10Andrew Bogott)
[22:05:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Sometimes we search for nonexistent hosts; be polite. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86182 (owner: 10Andrew Bogott)
[22:06:00] <Reedy>	 User:Reedy/vector.less
[22:07:44] <grrrit-wm>	 (03PS4) 10Bsitu: Add primary/secondary link, email, bundling to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 
[22:07:51] <ori-l>	 Reedy mocks our hipster pretentions
[22:08:27] <ori-l>	 MediaWiki:Common.coffee
[22:09:03] <ori-l>	 RoanKattouw: soooooo.... defining a 'url' function actually works
[22:09:29] <ori-l>	 and having it return a 'url(...)' value doesn't lead to infinite recursion, because the LESS interpreter doesn't parse the output of functions
[22:10:51] <RoanKattouw>	 Nice!
[22:11:23] <ori-l>	 yeah, that seems like a win
[22:12:42] <grrrit-wm>	 (03PS3) 10Amire80: Tests for translate recent and proofread recent button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 (owner: 10Nikerabbit)
[22:16:51] <grrrit-wm>	 (03PS1) 10Ori.livneh: Use $.each instead of [].forEach to avoid distracting reviewers [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/86189 
[22:19:52] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Explicitly clear forceHTTPS cookie when insecure [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86101 (owner: 10Anomie)
[22:19:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly clear forceHTTPS cookie when insecure [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86101 (owner: 10Anomie)
[22:20:19] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032 V: 032] Fixed wrong include path [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/86186 (owner: 10Aaron Schulz)
[22:20:49] <grrrit-wm>	 (03CR) 10Ori.livneh: "Would it be too annoying at this stage to ask that the file be renamed to ResourceLoaderLESSFunctions? That makes it more consistent with " [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[22:21:25] <grrrit-wm>	 (03PS7) 10EBernhardson (WMF): See that a post has been edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 
[22:21:53] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Tests for translate recent and proofread recent button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 (owner: 10Nikerabbit)
[22:21:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests for translate recent and proofread recent button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86175 (owner: 10Nikerabbit)
[22:22:39] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 04-1] "Has a bug where if you edit a post, the response via api has the content, but not the marker about the post being edited. Reloading the p" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF))
[22:24:47] <grrrit-wm>	 (03CR) 10Mgrover: [C: 032 V: 032] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[22:25:24] <grrrit-wm>	 (03PS23) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[22:25:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt)
[22:27:50] <grrrit-wm>	 (03PS6) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/86059 
[22:39:10] <grrrit-wm>	 (03PS1) 10Yurik: Updating zero ext [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86190 
[22:40:09] <grrrit-wm>	 (03PS1) 10Yurik: Updating zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86191 
[22:40:23] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna)
[22:40:50] <grrrit-wm>	 (03PS1) 10Yurik: Updating zero ext [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86192 
[22:41:04] <grrrit-wm>	 (03Abandoned) 10Yurik: Updating zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/86191 (owner: 10Yurik)
[22:41:12] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Use utf8 charset for searchindex MySQL table [core] - 10https://gerrit.wikimedia.org/r/86075 (owner: 10PleaseStand)
[22:41:17] <grrrit-wm>	 (03CR) 10Yurik: [C: 032 V: 032] Updating zero ext [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/86190 (owner: 10Yurik)
[22:45:30] <grrrit-wm>	 (03CR) 10CSteipp: "Yes, that fixes the issue." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/86080 (owner: 10Siebrand)
[22:47:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use utf8 charset for searchindex MySQL table [core] - 10https://gerrit.wikimedia.org/r/86075 (owner: 10PleaseStand)
[22:53:24] <grrrit-wm>	 (03CR) 10Yurik: [C: 032 V: 032] Updating zero ext [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86192 (owner: 10Yurik)
[22:54:15] <grrrit-wm>	 (03CR) 10Brion VIBBER: "I was thinking of doing that rename, yes that'd be fine I think. :)" [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[22:55:21] <grrrit-wm>	 (03PS1) 10Nikerabbit: Tests for project card actions [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86194 
[22:56:08] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] "See code comments :(" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86194 (owner: 10Nikerabbit)
[22:58:14] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Move LESS function definitions from DefaultSettings to ResourceLoaderLESSFunctions.php [core] - 10https://gerrit.wikimedia.org/r/86154 
[22:59:51] <grrrit-wm>	 (03CR) 10Ori.livneh: "Looks OK to merge. Do we need to do anything special to account for the fact that Reedy cherry-picked an earlier patchset to the deploymen" [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[23:00:40] <grrrit-wm>	 (03CR) 10Brion VIBBER: "I'll add a fix to that wmf branch so we don't look inconsistent, it'll be a separate changeset." [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[23:01:22] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Move LESS function definitions from DefaultSettings to ResourceLoaderLESSFunctions.php [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[23:02:41] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Remove an extra ) that was breaking some ldap searches. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86197 
[23:04:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move LESS function definitions from DefaultSettings to ResourceLoaderLESSFunctions.php [core] - 10https://gerrit.wikimedia.org/r/86154 (owner: 10Brion VIBBER)
[23:05:01] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Update cherry-picked LESSFunctions.php to final ResourceLoaderFunctions.php [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/86198 
[23:07:14] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032] Remove an extra ) that was breaking some ldap searches. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86197 (owner: 10Andrew Bogott)
[23:07:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove an extra ) that was breaking some ldap searches. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/86197 (owner: 10Andrew Bogott)
[23:09:48] <grrrit-wm>	 (03PS1) 10Nikerabbit: Test for project selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86199 
[23:09:56] <grrrit-wm>	 (03PS3) 10Chad: Clean up language test cases objection construction [core] - 10https://gerrit.wikimedia.org/r/86151 
[23:10:05] <grrrit-wm>	 (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86151 (owner: 10Chad)
[23:12:57] <grrrit-wm>	 (03PS2) 10Nikerabbit: Test for project selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86199 
[23:17:16] <grrrit-wm>	 (03PS17) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 
[23:18:02] <grrrit-wm>	 (03CR) 10Jdlrobson: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:18:08] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Test for project selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86199 (owner: 10Nikerabbit)
[23:18:28] <grrrit-wm>	 (03PS3) 10Nikerabbit: Test for project selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86199 
[23:23:45] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 031] "The style mixins look correct now, will test shortly to confirm all works. :D" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:26:09] <grrrit-wm>	 (03PS3) 10Bsitu: Bundle message should show diff of all included revisions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/86031 
[23:27:28] <grrrit-wm>	 (03PS1) 10Amire80: Add ids to the search box and the button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86202 
[23:27:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add ids to the search box and the button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86202 (owner: 10Amire80)
[23:28:40] <grrrit-wm>	 (03CR) 10Nikerabbit: "recheck" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86202 (owner: 10Amire80)
[23:28:52] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Add ids to the search box and the button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86202 (owner: 10Amire80)
[23:29:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add ids to the search box and the button [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86202 (owner: 10Amire80)
[23:36:38] <grrrit-wm>	 (03PS1) 10Nikerabbit: Implement test for search [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86203 
[23:37:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: "SVG icon using the new mixin works as expected on current Firefox and Safari, and the CSS markup looks correct for the fallbacks but I hav" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:38:03] <brion>	 whee
[23:42:12] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 04-1] "The collapsed arrow is in the wrong direction in RTL." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:47:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Aww, that's probably because it's embedded before CSSJanus gets to it :/" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:47:40] <MatmaRex>	 ori-l: ^ sad :(
[23:47:52] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Ok I think the bad RTL display is because the LESS embedding mixins run before the CSSJanus filter; this means CSSJanus doesn't see the '-" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[23:48:06] <brion>	 heh
[23:48:11] <brion>	 yes same conclusion :D
[23:48:13] <MatmaRex>	 ha, i was faster :D
[23:48:24] <MatmaRex>	 hmm
[23:48:31] <RoanKattouw>	 Eek, whoops
[23:48:35] <RoanKattouw>	 Yeah I see what you're saying
[23:48:42] <MatmaRex>	 i think that overriding url() as ori proposed earlier would solve this
[23:48:48] <brion>	 worst case we can add more manual rules… but that's nasty
[23:48:51] <MatmaRex>	 it's starting to sound like a seriously good idea
[23:48:58] <brion>	 MatmaRex: hmm, overriding how exactly?
[23:49:19] <MatmaRex>	 brion: ori-l claims you an define a url() function in less and it Just Works
[23:49:20] <ori-l>	 brion: creating a url() custom function actually makes LESS delegate to that function whenever it encounters url() attributes, a happy accident
[23:49:39] <brion>	 hmmmmm
[23:49:40] <ori-l>	 and if the output is a url() value, it does not cause an infinite loop, because the output of functions is not parsed
[23:49:50] <brion>	 well we could define a function, but i'm not sure how that function can expand to produce multiple rules
[23:49:52] <ori-l>	 but i'm missing the context (your patches above, which i haven't read)
[23:49:59] <ori-l>	 brion: that's the question, yeah
[23:50:09] <RoanKattouw>	 ori-l: url(foo-ltr.png);
[23:50:13] <ori-l>	 i think it could but it's a bit hairy
[23:50:23] <brion>	 so
[23:50:31] <grrrit-wm>	 (03PS5) 10Bsitu: Add primary/secondary link, email, bundling to post reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86064 
[23:50:38] <brion>	 another alternative is to make sure the /* @embed */ comments make it through to output in the expected place :PP
[23:50:52] <brion>	 and let CSSMin do the embed instead of less 
[23:51:00] <RoanKattouw>	 Surely if we made url() a LESS function, you'd still have to run Janus before less in order to make url(foo-ltr.png) work
[23:51:03] <brion>	 but i'm not sure how hard that'll be to fix in lessc
[23:51:27] <ori-l>	 not super-hard, and that's probably right
[23:51:46] <grrrit-wm>	 (03PS2) 10Nikerabbit: Implement test for search [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/86203 
[23:51:54] <ori-l>	 i think i'd still like to have a nicer solution, but it sounds like it would take a while to get right, and in the mean time it'd be good not to introduce temporary syntaxes
[23:52:29] <MatmaRex>	 (i'll test it on IE6 in the meantime)
[23:52:35] <brion>	 ah thanks MatmaRex 
[23:52:41] <brion>	 i've got some more VMs around somewhere but i have to dig them up
[23:53:02] <brion>	 i don't do a lot of "old IE" testing anymore what with all this mobile stuff :)
[23:53:12] <MatmaRex>	 my laptop is not swapping hard enough, let's fire up a VM
[23:54:41] <ori-l>	 would anyone like to take a stab at the lessc embed change? i'll take it on if there's no one else since it's my responsibility that the annotations don't work, but if there's interest i can pinpoint what in lessc.inc.php needs to change
[23:55:38] <ori-l>	 I'll file a bug with the details
[23:57:31] <brion>	 ori-l: i'll peek at it later but it might explode my brain :)
[23:57:41] <brion>	 gotta run some errands, see y'all alter
[23:58:08] <grrrit-wm>	 (03PS1) 10CSteipp: Remove returnto for basic login test [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86207