[00:03:25] ori-l: doing a destory /up test [00:03:36] ori-l: gonna be a while [00:03:45] wait [00:03:48] did you already destroy? [00:03:57] YuviPanda: ^ [00:03:58] ori-l: yeah? [00:04:01] oh well [00:04:03] why? [00:04:10] you could have copied the .debs to the /apt-cache folder [00:04:13] i bet the apt cache thing won't work for me [00:04:13] yeah [00:04:14] :P [00:04:15] but it's okay [00:04:19] simulating first run! [00:04:21] well, they'll go there from now on [00:04:24] true [00:04:30] but you could have saved yourself some bandwidth [00:06:27] ori-l: interesting. it's failing now, and the error messages seemt o point towards the cache as a culprit [00:06:49] all apt operations fail with E: Archives directory /vagrant/apt-cache/partial is missing. - Acquire (2: No such file or directory) [00:06:59] ori-l: http://dpaste.de/eHEpK/ [00:07:31] Such pretty, if to useless, highlighting. [00:07:42] to --> not [00:07:45] Typing is the worst. [00:08:21] gj, Elsie [00:09:03] (03PS1) 10Ori.livneh: Add apt-cache/partial/.gitignore [vagrant] - 10https://gerrit.wikimedia.org/r/85797 [00:09:10] ty [00:09:12] np [00:09:13] yw [00:09:20] gl [00:09:21] hf [00:09:28] (03CR) 10Ori.livneh: [C: 032] Add apt-cache/partial/.gitignore [vagrant] - 10https://gerrit.wikimedia.org/r/85797 (owner: 10Ori.livneh) [00:10:12] (03Merged) 10jenkins-bot: Add apt-cache/partial/.gitignore [vagrant] - 10https://gerrit.wikimedia.org/r/85797 (owner: 10Ori.livneh) [00:10:22] YuviPanda: fixed. [00:10:26] heh :D [00:10:28] * YuviPanda pulls [00:11:48] Elsie: I top-posted [00:11:52] on wikitech-l [00:11:55] i noticed too late [00:12:09] * ori-l turns himself in [00:12:48] OH GOD. [00:13:06] (03PS1) 10Krinkle: alert: Make selectors less overly specific and clean up js [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 [00:17:28] (03PS2) 10EBernhardson (WMF): Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 [00:20:52] (03PS16) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [00:24:36] (03PS1) 10Brion VIBBER: Bump to 1.0.0.31 (revision 8); fix missing en-us locale [apps/win8/wikipedia] (win8) - 10https://gerrit.wikimedia.org/r/85799 [00:25:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Earlier update to language list was missing en-us locale, which is where the default store description was. Don't lose it!" [apps/win8/wikipedia] (win8) - 10https://gerrit.wikimedia.org/r/85799 (owner: 10Brion VIBBER) [00:27:13] marktraceur: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Wikipedia_talk:File_Upload_Wizard.23Origin_of_empty_stuff [00:27:21] UploadWizard UploadWizard UploadWizard [00:28:46] cscott: that's from enwiki's 'File Upload Wizard', which is very very different from Extension:UploadWizard [00:28:46] cscott: see https://en.wikipedia.org/wiki/Wikipedia:File_Upload_Wizard [00:28:48] (03PS1) 10Physikerwelt: Conflicts: Math.i18n.php Math.php MathMathML.php MathRenderer.php MathTexvc.php modules/ext.math.mathjax.enabler.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/85800 [00:28:49] (03PS1) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [00:29:05] (03CR) 10jenkins-bot: [V: 04-1] Conflicts: Math.i18n.php Math.php MathMathML.php MathRenderer.php MathTexvc.php modules/ext.math.mathjax.enabler.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/85800 (owner: 10Physikerwelt) [00:29:07] YuviPanda: oh. never mind, then marktraceur [00:29:17] :) [00:29:35] Also we already fixed an issue for UW today [00:29:36] * cscott repents from the summoning [00:29:46] fixed last week, deployed again today... [00:29:53] also I need to check the data! [00:29:58] OH MAN [00:30:05] Datum sounds like a good idea. [00:30:18] marktraceur: Y U NO HAVE stat1 ACCESS? [00:30:21] also, cee lo green's head tatoo is quite striking. [00:30:28] cee lo green? [00:30:54] ori-l: also, I'm guessing apt-cache doesn't make sense unless you're on vbox [00:30:58] (as in, on labs) [00:31:07] * cscott is watching the voice [00:31:19] (03PS3) 10PleaseStand: Remove LanguageEo::checkTitleEncoding() [core] - 10https://gerrit.wikimedia.org/r/85410 [00:31:31] YuviPanda: Because, um...don't need it? [00:32:03] marktraceur: eerr, even now that you're sending EL data up? [00:32:10] do you have access to the analytics slaves otherwise? [00:32:14] No [00:32:22] YuviPanda: I'm not using the data yet. So...sure [00:32:33] sure, but do you plan on asking for it? [00:32:35] RT ticket, IIRC [00:33:32] marktraceur: ^ [00:35:12] random question ... is it possible to get grrrit-wm to announce things related to specific extensions in additional rooms? Not even sure we would want to yet, just curious [00:36:01] (03PS7) 10PleaseStand: Add /S modifier to remaining uses of ASCII check regex [core] - 10https://gerrit.wikimedia.org/r/85105 [00:36:32] ebernhardson: totally, yes. [00:36:51] (03CR) 10PleaseStand: "Rebased on top of of the other change to reduce the size of this commit slightly." [core] - 10https://gerrit.wikimedia.org/r/85105 (owner: 10PleaseStand) [00:37:00] ebernhardson: trivial config change. you can either send patches to labs/tools/grrrit or just poke me :) [00:37:28] YuviPanda: thats excellent. I'll bring it up to the team :) Seems it may be usefull [00:37:38] :) [00:38:16] (03PS3) 10Yuvipanda: Box Virtualbox-specific configs in 'virtualbox' module [vagrant] - 10https://gerrit.wikimedia.org/r/84431 (owner: 10Ori.livneh) [00:38:20] ori-l: okay, ^ seems to work for me [00:41:20] (03CR) 10PleaseStand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun) [00:42:57] YuviPanda: reviewing [00:43:23] (03CR) 10Ori.livneh: [C: 032] "Thanks for the rebase" [vagrant] - 10https://gerrit.wikimedia.org/r/84431 (owner: 10Ori.livneh) [00:43:32] ty, ori-l [00:43:37] (03Merged) 10jenkins-bot: Box Virtualbox-specific configs in 'virtualbox' module [vagrant] - 10https://gerrit.wikimedia.org/r/84431 (owner: 10Ori.livneh) [00:46:57] (03Abandoned) 10Physikerwelt: Conflicts: Math.i18n.php Math.php MathMathML.php MathRenderer.php MathTexvc.php modules/ext.math.mathjax.enabler.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/85800 (owner: 10Physikerwelt) [00:48:04] (03PS2) 10Physikerwelt: Conflicts: Math.i18n.php Math.php MathMathML.php MathRenderer.php MathTexvc.php modules/ext.math.mathjax.enabler.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [00:48:10] (03CR) 10jenkins-bot: [V: 04-1] Conflicts: Math.i18n.php Math.php MathMathML.php MathRenderer.php MathTexvc.php modules/ext.math.mathjax.enabler.js [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [00:48:50] ori-l: hmm, 'err: /Stage[main]/Mediawiki/Git::Clone[mediawiki/core]/Exec[git clone mediawiki/core]/returns: change from notrun to 0 failed: git clone https://gerrit.wikimedia.org/r/p/mediawiki/core.git /vagrant/mediawiki returned 128 instead of one of [0] at /vagrant/puppet/modules/git/manifests/clone.pp:38' [00:48:52] hand cloning works [00:48:52] * YuviPanda chalks that up to gerrit being flaky [00:51:51] * ^d chalks it up to YuviPanda being flakey ;-) [00:52:07] * YuviPanda chalks it up to labs and Ryan_Lane being flaky :P [00:52:24] why would git return 128? is that just -1? [00:53:06] hmm, 128 cant be -1. 256 could be [00:53:21] so 128 is 128? [00:53:26] well, hmm. [00:54:20] 128 is -127, iirc [00:54:23] in 8-bit :) [00:58:32] <^d> YuviPanda: http://stackoverflow.com/questions/4917871/does-git-return-specific-return-error-codes [00:58:41] i've already landed there :P [00:58:49] i found the same one :P [00:58:52] i'm going to guess that it is a permission issue [00:58:55] <^d> The one that begins with "In short, no" is probably it. [00:59:08] bash also has a list of "reserved exit codes" : http://tldp.org/LDP/abs/html/exitcodes.html [00:59:09] heh [01:00:27] <^d> The verbiage there almost makes it sound like you shouldn't exit 1 either ;-) [01:00:56] don't exit at all! [01:01:10] <^d> Ah yes, the obvious solution. [01:01:19] indeed [01:02:04] ori-l: where is the 'vagrant' user created? [01:02:23] YuviPanda: you're too young [01:02:36] awww [01:02:47] ask me when you're older [01:02:54] joking aside, it's part of the initial bootstrapping that happens in vagrant [01:03:00] right [01:03:00] in fact i think .box files have vagrant users [01:03:14] and i guess they've passwordless sudo enabled [01:03:23] i can set that up on labs too, I guess [01:04:17] ori-l: hmm, i am trying to find out how vagrant can do passwordless sudo [01:04:38] i see nothing in sudoers [01:04:39] man sudoers [01:05:01] is it part of a proper group? [01:05:01] (03PS3) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [01:05:09] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [01:05:14] <^d> Haha. [01:05:16] <^d> https://github.com/facebook/hiphop-php/commit/93ba44b96c19e27584c605d9f714ffebd64d9792 [01:05:33] groups returns just vagrant [01:05:37] YuviPanda: /etc/sudoers.d/vagrant [01:06:06] ori-l: sure, but '#includedir /etc/sudoers.d' [01:06:15] in /etc/sudoers [01:06:26] if that is actually not a comment but 'directives start with #', I'll be pissed [01:06:49] :) [01:09:47] (03CR) 10Bsitu: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF)) [01:13:54] YuviPanda: I didn't plan to, no [01:13:59] err, okay [01:14:45] (03PS4) 10PleaseStand: MysqlInstaller: use default character set of utf8 [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun) [01:15:14] * YuviPanda shrugs [01:17:34] (03PS4) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [01:20:24] holy crap, have you guys seen this? http://docs.emmet.io/abbreviations/ [01:21:03] werdna: You mean...like any sane templating language? [01:21:12] new to me :D [01:21:26] <^d> I've seen the sublime plugin for that before. [01:21:44] werdna: old news :P https://code.google.com/p/zen-coding/ [01:22:23] Oh, hm, it's a thing for text editors, not a templating language. [01:22:25] * werdna is behind the times [01:22:31] That's pretty cool, but templating would be nicer and more editable [01:22:41] HINT HINT MEDIAWIKI [01:22:47] <^d> It's basically a tool for HTML/CSS developers to type less. [01:22:54] <^d> Which is cool I guess if you write a lot of HTML and CSS. [01:22:59] I don't see the point for most people. [01:23:00] ^d: I'm insulted you call them developers [01:23:08] <^d> Sorry, "webmasters" [01:23:09] <^d> ;-) [01:23:10] If you're writing out that much HTML, you're probably doing something wrong... [01:23:22] not necessarily [01:23:25] (03CR) 10PleaseStand: "The installer still seems to work, though I don't think this patch will completely fix bug 47191, because the user may decide to use an ex" [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun) [01:23:34] <^d> If you're making a static site it might make sense. [01:23:52] Do people still make those? o; [01:24:03] sure [01:24:06] hehe, 'the user may decide to use an ex' [01:24:15] Hi werdna. [01:24:23] VE is dead. Long live VE. [01:24:56] <^d> marktraceur: Remember when webmaster was a legit job title? :p [01:25:40] So is/was Web mistress. [01:25:56] also, I would rather type div.flow-topic-container>div.flow-topic-opener+div.flow-titlebar>div.flow-topic-title>div.flow-realtitle^^div.flow-topiccontrols^div.flow-metabar etc etc [01:26:01] than actually type all that shit down [01:26:12] "Elsie: VE is dead. Long live VE." ?? [01:26:31] <^d> I prefer writing backend stuff. No silly HTML/CSS/JS required :) [01:26:31] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#VisualEditor_now_opt-in_only_for_all_users_on_English_Wikipedia [01:26:51] werdna: How often would you type that, though? [01:27:13] Elsie: well, when you're writing display templates, quite frequently [01:27:31] If you say so. :-) [01:28:48] <^d> Hehe, I think you can spot where I started indexing cawiki and enwikisource :p [01:28:50] <^d> http://ganglia.wikimedia.org/latest/?r=day&cs=&ce=&c=Miscellaneous+eqiad&h=testsearch1001.eqiad.wmnet&tab=m&vn=&mc=2&z=small&metric_group=ALLGROUPS [01:28:53] I imagine within the next year we'll see the Wikimedia Foundation try to remove site CSS/JS editing powers from local admins. [01:29:07] Anyone want to take that bet? I think it's already been proposed. [01:29:10] "Super-protection." [01:29:33] yeah, we all are evil. [01:29:37] gj on busting 'us' [01:30:00] ty [01:30:04] np [01:30:12] yw [01:31:20] (03CR) 10PleaseStand: "Any reason we can't/shouldn't escape all newlines, given their significance in list syntax?" [core] - 10https://gerrit.wikimedia.org/r/85233 (owner: 10Anomie) [01:32:16] ^d: Hell yeah man. Well, sorta. [01:33:24] (03PS1) 10Hashar: trigger qa-browsertests-build (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85810 [01:33:40] <^d> Speaking of hell yeah. yhager rocks. https://github.com/facebook/hiphop-php/issues/1051#issuecomment-24966672 [01:35:04] (03PS1) 10Hashar: browsertests runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85811 [01:35:19] (03CR) 10Hashar: [C: 032] trigger qa-browsertests-build (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85810 (owner: 10Hashar) [01:35:25] (03Merged) 10jenkins-bot: trigger qa-browsertests-build (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85810 (owner: 10Hashar) [01:39:09] (03PS1) 10Hashar: README: mention BROWSER_LABEL [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85812 [01:39:28] werdna !!! [01:39:37] ??? [01:40:13] * hashar whistles [01:40:43] hey, how was your break? Did you erik's email about moving Tuesdays meeting 30 minutes later? [01:42:24] yeah, I saw. [01:42:29] did you see my reply in -corefeatures [01:42:34] hashar: :) [01:42:37] there's a -corefeatures?! [01:42:46] sii [01:42:51] where all the cool kids hang out [01:42:56] except you, YuviPanda. [01:43:05] pffft [01:43:19] werdna: everyone knows that the actual cool kids hang out on -growth :P [01:43:20] <^d> ...another channel? [01:43:24] <^d> werdna: You know better? [01:43:40] <^d> Why does every team of 3 people need their own dang channel? [01:43:45] ^d: it used to be called -ee, I believe. [01:43:54] ^d: so this isn't *directly* werdna's fault [01:44:06] <^d> I don't care who's fault it is. [01:44:07] ^d: I find it annoying sometimes in -dev, too much crosstalk [01:44:27] cabalfrench-l is the only place [01:44:31] <^d> Making a new damn channel for each new micro-grouping we can come up with is so incredibly lame. [01:44:42] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [01:45:10] ^d: well most of the generic channels tends to be overbusy during peak hours :/ [01:45:17] yeah, they do. [01:45:29] during European morning I am mostly in mediawiki-i18n and wikimedia-operations where people are awake :D [01:46:26] <^d> Ok, so it's noisy during working hours. Creating a new channel and not announcing it to anyone is not cool. Discussions in #my_awesome_channel are less likely to be logged. Less likely to be shared. Less likely for $goodNumbers of people to see. [01:46:32] (03PS5) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [01:46:55] <^d> Completely likely to be referred to as fiat. "We discussed it in #cool_place_you_werent_invited" [01:47:08] NOOOO GlusterFS has hit me again :( [01:47:28] hashar: why are you still using it? [01:47:39] good question [01:49:41] (03PS1) 10Hashar: tie to ruby 1.9.3 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85813 [01:50:30] (03PS2) 10Hashar: browsertests runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85811 [01:52:03] cscott: https://gerrit.wikimedia.org/r/85814 is work that'll eventually let you use the vagrant stuff on labs. so VE can be as easy as vagrant enable-role visualeditor :) [01:52:06] should be merged in a day or so [01:53:01] ^d: Well, I'm not sure there *is* a place to announce these things [01:53:16] ^d: And actually, our rule is that no decision ever happened unless it happened on the mailing list. [01:53:37] ^d: It's mostly for just chatting and keeping up with each other [02:31:45] (03CR) 10Chad: [C: 032] Overhaul wikitext formatting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85135 (owner: 10Chad) [02:31:48] (03Merged) 10jenkins-bot: Overhaul wikitext formatting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85135 (owner: 10Chad) [02:47:22] (03CR) 10Krinkle: "Note that this only works for wikis that have a 404 handler set up for their thumbnail urls. Otherwise it will still become a 404 after th" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [03:04:14] Do any projects, use non-western-numerals as links to [footnotes/citations] ? Eg. ١‎ ٢‎ ٣‎ instead of 1 2 3. Or is the Blue [1] a universal symbol? [03:04:58] Check ar.wiki? [03:05:06] did [03:05:18] Check translatewiki.net? [03:05:22] https://mr.wikipedia.org/wiki/%E0%A4%AC%E0%A4%B0%E0%A4%BE%E0%A4%95_%E0%A4%93%E0%A4%AC%E0%A4%BE%E0%A4%AE%E0%A4%BE [03:05:38] ^ uses non-arabic numerals [03:05:51] or whatever the number system is called... [03:05:51] aha, perfect, ty legoktm. [03:06:01] Nice, legoktm. [03:06:04] (completely foils my plan, but it's good info) [03:06:07] :) [03:18:05] (03PS3) 10Hashar: browsertests runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85811 [03:20:00] (03CR) 10Hashar: [C: 032] "I got the jobs deployed. The first run is https://integration.wikimedia.org/ci/job/qa-browsertests-run/14/console :-)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85811 (owner: 10Hashar) [03:20:21] (03Merged) 10jenkins-bot: browsertests runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85811 (owner: 10Hashar) [03:21:36] spagewmf: since I remember talking to you earlier about vagrant + labs, https://gerrit.wikimedia.org/r/#/c/85814 [03:21:44] I also keep confusing you and superm401, sorry! [03:21:46] is there a RoanKattouw_away or a Krinkle about? [03:21:52] or a James_F|Away ? [03:21:54] There is [03:22:05] Krinkle: Is ext.visualEditor.data a thing? [03:22:09] has it recently been removed? [03:22:14] Yes [03:22:15] No [03:22:15] Flow is starting to complain about its absence [03:22:28] localhost:VisualEditor andrew$ ack ext.visualEditor.data [03:22:29] localhost:VisualEditor andrew$ [03:22:29] hmm [03:22:40] Why would flow be interacting with that module? [03:22:44] no idea [03:22:46] I didn't write that code [03:22:56] link to code? What error? Bug report? [03:23:09] I'm updating iTunes. [03:23:10] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/VisualEditor.php#L257 [03:23:35] !codesearch ext.visualEditor.data [03:23:35] https://github.com/search?l=&q=ext.visualEditor.data+%40wikimedia&ref=advsearch&type=Code [03:23:51] That answers that second question [03:24:01] https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/modules/editor/editors/ext.flow.editors.visualeditor.js#L81 [03:24:16] Flow should not list that module, that's an internal dependency and implementation detail [03:24:37] werdna: Is this in production? [03:24:43] nope [03:25:48] werdna: mw.flow.editors.visualeditor.prototype.getModules looks like it is in a state that should not reach production. [03:26:07] well, the change is this one if you wanna leave a comment [03:26:07] https://gerrit.wikimedia.org/r/#/c/83056/8 [03:26:24] Why does that repo not have tests? [03:26:31] like, at all. Of any kind. [03:26:42] (03CR) 10Kaldari: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 (owner: 10Krinkle) [03:26:57] (I mean, not running from Gerrit) [03:27:41] It's not really in a testable state yet. [03:28:06] and we don't really have endless resources like VE does, either. [03:28:59] werdna: I confused part of it with Echo for a it. I was about to say that part of Flow is deployed, but it isn't. [03:29:11] Right? [03:29:17] (03CR) 10Krinkle: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 (owner: 10Krinkle) [03:29:47] not on production. [03:29:51] so don't stress about it [03:29:55] no worries [03:30:15] if you do have feedback, feel free to leave gerrit / mailing list comments. I can't exactly respond to everything you don't like about Flow personally right now on IRC. [03:30:53] Sure. [03:32:07] Though I can't speak for the entire VE team, it appears that at least part of this was implemented without using VE documentation and/or asking VE members about how to load it (lacking documentation). I don't know if that's the case, but if it was I'd recommend (nothing personal) to avoid that in the future as it'll only lead to having to do it over again. [03:32:14] Krinkle, I think Matthias Mullie wrote that code. He was trying to make Flow use VE if available [03:32:35] Krinkle: would you mind leaving that as a gerrit comment on the appropriate rev? [03:32:38] link is above [03:32:50] .. or it going unnoticed and it breaking months later and blaming VE. [03:33:02] yeah [03:33:07] woooo Uncaught TypeError: Cannot read property 'surface' of undefined [03:33:28] ah fixed it [03:33:40] werdna: Back to the specific data module not existing, maybe update to latest master? It is fairly new. [03:34:32] Krinkle: nobody's blaming VE, just trying to use it (and Parsoid). We expect to have to roll withit [03:34:51] Krinkle: yeah, I was on the wrong branch. [03:38:44] (03CR) 10Krinkle: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 (owner: 10Matthias Mullie) [03:42:08] (03PS1) 10Nathan Douglas: Adds support for setting per-term CSS styles. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 [03:42:09] (03PS6) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [03:49:24] (03PS1) 10Hashar: qa-browsertests-run now has test reports [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85821 [03:49:40] (03CR) 10Hashar: [C: 032] qa-browsertests-run now has test reports [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85821 (owner: 10Hashar) [03:49:59] (03Merged) 10jenkins-bot: qa-browsertests-run now has test reports [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85821 (owner: 10Hashar) [03:58:33] (03CR) 10Santhosh: "If we want to support mw.translate.loadLanguageStats, the changes should be at Translate extension where this method is defined. So defini" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85366 (owner: 10Santhosh) [03:59:19] (03CR) 10Santhosh: "If we want to support query-continue in mw.translate.loadLanguageStats...." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85366 (owner: 10Santhosh) [04:07:12] <^d> Elsie: I see you read about our search work :) [04:07:40] I did! [04:07:59] > Find as you type article name completion [04:08:08] That struck me as a very silly header. [04:08:25] Perhaps it should just be "Autocompletion" or "Search suggestions"? [04:08:29] <^d> Feel free to rephrase :) [04:08:30] From https://www.mediawiki.org/wiki/Search/CirrusSearchFeatures [04:08:34] Be bold! [04:08:49] I'm writing an e-mail to Erik. [04:08:57] To discuss VisualEditor. [04:09:17] I have no intention of hearing back from him or anyone else who I'm e-mailing. [04:09:23] But I'll write the note anyway. [04:09:27] To say that I tried. [04:09:39] s/intention/expectation/ ? [04:09:49] Indeed! [04:09:51] intention is perhaps closer here :P [04:09:58] It's getting late. [04:10:21] I got brass in pocket / Got bottle, I'm gonna use it. / Intention / I feel inventive, / Gonna make you, make you, make you notice [04:10:31] <^d> Elsie: Clarified, went with "Search suggestions" [04:11:01] <^d> Also, did you see the other item we snuck in? I'm particular happy with it. [04:11:05] (03PS1) 10Hashar: mwext-Math-testextensions-master are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85822 [04:11:17] <^d> * incategory:"musicals" incategory:"1920" [04:11:18] <^d> ** Find articles that are in both Category:Musicals and Category:1920 [04:11:27] <^d> Emphasis on "both" :) [04:11:42] o: [04:11:45] Category intersection? [04:11:54] <^d> Basically yes :) [04:11:56] Sweet! [04:12:00] (03CR) 10Hashar: [C: 032] mwext-Math-testextensions-master are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85822 (owner: 10Hashar) [04:12:04] I didn't understand the term "stemming". [04:12:06] (03CR) 10Physikerwelt: [C: 031] mwext-Math-testextensions-master are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85822 (owner: 10Hashar) [04:12:08] It was used a few times. [04:12:08] (03Merged) 10jenkins-bot: mwext-Math-testextensions-master are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85822 (owner: 10Hashar) [04:12:15] And the quotation behavior seemed weird to me. [04:12:37] But without fully understanding what I was reading, everything seemed a little weird. [04:12:51] <^d> Stemming is dealing with the roots of words. [04:12:53] (03PS7) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [04:13:01] (03PS8) 10Hashar: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [04:13:05] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [04:13:07] <^d> For an example, treating "swim" and "swimming" as effectively the same. [04:13:20] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [04:14:12] <^d> Elsie: But it's not just conjugations. Parts of words and so forth--words making up other words. [04:14:28] Ah, right. [04:14:42] > intitle:"foo bar" [04:14:48] >> Find articles who's title contains foo and bar. Stemming is enabled for foo and bar. [04:14:49] Elsie: SyntaxError: Unexpected identifier [04:14:54] That seemed strange to me. [04:14:57] ecmabot-wm: Shut up. [04:14:58] Elsie: There is no command: Shut up. [04:15:18] (03CR) 10Hashar: "congratulations :)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [04:15:23] <^d> Elsie: Basically it means it'll find "Fooing barber" [04:15:42] off for a nap [04:15:47] It read as though it meant it'll find intitle:foo and intitle:bar. [04:15:48] <^d> night hashar [04:16:22] <^d> Elsie: With titles the effect is basically the same. Either way you end up looking for titles containing both. [04:16:42] Well, [04:16:52] with quotation marks, I'd expect it to be exact. [04:17:07] But perhaps I have flawed expectations. [04:17:25] <^d> Not an unreasonable expectation. Maybe Nik can explain a bit better when he's around. [04:18:14] CamelCasePageTitlesHeyyyyyyyyyy [04:21:50] ^d: I updated the page a bit. [04:22:36] <^d> Looks good, ty. [04:43:57] hmm, I always thought Parsoid put in nice little markers for links… [04:44:24] gwicke_away: poke? [04:45:21] For non-existent pages, etc., you mean? [04:45:27] It's not implemented yet, I don't think. [04:45:32] VE still only shows blue links. [04:47:00] ahh never mind [04:47:03] this is never hitting parsoid [04:53:38] (03PS3) 10Adamw: Illustrate two ways to crash-land namespacing [core] - 10https://gerrit.wikimedia.org/r/61174 [05:32:37] (03CR) 10Krinkle: "It has been rumoured that this commit scores 42ku (Krinkle units). That's all we know." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/74484 (owner: 10Bartosz Dziewoński) [05:32:57] ori-l: [05:33:30] (03PS1) 10Werdna: Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 [05:50:55] :D [05:58:10] (03PS9) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [05:58:27] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [06:01:29] (03PS1) 10Pastakhov: add operator 'elseif' [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85824 [06:02:34] (03CR) 10Pastakhov: [C: 032] add operator 'elseif' [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85824 (owner: 10Pastakhov) [06:02:40] (03Merged) 10jenkins-bot: add operator 'elseif' [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85824 (owner: 10Pastakhov) [06:19:14] (03PS1) 10Rfaulk: add - git_config_global_set method. [sartoris] - 10https://gerrit.wikimedia.org/r/85826 [06:19:21] (03CR) 10jenkins-bot: [V: 04-1] add - git_config_global_set method. [sartoris] - 10https://gerrit.wikimedia.org/r/85826 (owner: 10Rfaulk) [06:21:31] (03PS2) 10Rfaulk: add - git_config_global_set method. [sartoris] - 10https://gerrit.wikimedia.org/r/85826 [06:22:00] (03CR) 10Rfaulk: [C: 032 V: 032] add - git_config_global_set method. [sartoris] - 10https://gerrit.wikimedia.org/r/85826 (owner: 10Rfaulk) [06:41:27] (03PS1) 10Rfaulk: add - calls to set git config. [sartoris] - 10https://gerrit.wikimedia.org/r/85827 [06:41:28] (03PS1) 10Rfaulk: add / mod - calls to git config in init.py / use of project path. [sartoris] - 10https://gerrit.wikimedia.org/r/85828 [06:41:49] (03CR) 10Rfaulk: [C: 032 V: 032] add - calls to set git config. [sartoris] - 10https://gerrit.wikimedia.org/r/85827 (owner: 10Rfaulk) [06:42:01] (03CR) 10Rfaulk: [C: 032 V: 032] add / mod - calls to git config in init.py / use of project path. [sartoris] - 10https://gerrit.wikimedia.org/r/85828 (owner: 10Rfaulk) [06:46:37] is that ryan faulkner? [06:46:45] werdna: yup [06:46:57] huh [06:47:00] there's a bunch of commits from him to sartoris almost every night [06:50:05] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 (owner: 10Werdna) [06:50:19] siebrand: there's a first for everything. [06:50:37] werdna: hmm? [06:50:48] siebrand: Andrew submits patch with no i18n issues. That must be a first. [06:50:55] werdna: ah. [06:51:08] * siebrand congratulates werdna  [06:51:12] :p [06:51:18] how's NL? Freezing again? [06:51:59] y'day was a coatless day ~18C or so) [06:52:05] No idea what today will bring. [06:52:12] I'll probayl have little reason to be outsie. [06:52:15] outside. [06:52:39] Funeral tomorrow, so I hope we can keep it dry. [06:53:27] oh, gecondoleerd… [06:53:48] 28 in Sydney, in early Spring :) [06:57:25] * YuviPanda|code checks weather [06:57:39] 34C! summer's winding down... [06:57:51] where do you live again YuviPanda|code ? [06:58:01] werdna: Southern India. Chennai right now. [06:58:06] right [06:58:10] for some reason I had NYC in my brain [06:58:20] werdna: you were thinking of Yuri [06:58:23] who does live in NYC [06:58:31] Yuri, Yuvi, what's the difference? [06:58:43] a couple of oceans :P [06:59:45] what's a few oceans between friends? [07:00:04] a few too many, as it turns out :( [07:00:22] I wonder if I'm closer to Sydney or NYC [07:00:39] i doubt gmaps will give me an estimate tho [07:00:43] Too many oceans! [07:01:23] gcmap.com [07:01:54] says: [07:02:01] SYD-MAA 5668 mi [07:02:10] MAA-NYC 8382 mi [07:02:17] so Sydney, by quite a margin. [07:02:28] heh [07:02:29] yeah [07:02:49] should get there some day. Perhaps the next time cricket turns up [07:03:23] that's not too expensive, actually! [07:03:29] 500$ for a flight [07:03:44] you can fly Air India on the 787 flight [07:04:05] wtf [07:04:09] New York is also the same price!?! [07:04:22] of course, I'm looking for prices 5 months out... [07:04:23] but stil [07:04:23] l [07:13:10] India-NY is higher traffic than India-SYD I can only assume [07:13:29] aaand you got me distracted for 20 minutes trying to find the perfect great circle routes in each direction from Sydney to London and NY [07:13:37] yw :D [07:28:00] (03PS1) 10Yuvipanda: Remove unused files enumerate-roles & puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/85830 [07:34:11] zeljkof: hey :) [07:34:27] hashar: morning :) [07:34:47] went for a nap at 6am :/ [07:34:54] BUT [07:35:05] I get browser tests running on Jenkins with phantomjs! [07:35:14] * hashar feels like a pro [07:35:35] wow! :) [07:35:49] link to the job? [07:36:01] see qa-l :-D [07:37:02] reading... [07:39:00] will reboot jenkins right now [07:39:37] ok, that one should be easy to fix [07:39:49] will try on my machine and let you know [07:40:35] what is this? [07:40:36] ERROR: Reference path does not exist: /srv/ssd/gerrit/qa/browsertests.git [07:43:25] (03PS1) 10Hiong3-eng5: owAddSyntrans typo; Downloads minor corrections [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/85831 [07:46:34] (03PS1) 10Werdna: Occupy talk pages! [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85832 [07:50:08] (03PS2) 10Werdna: Flow: Add Mention notification. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85823 [07:51:48] hashar: is http://en.wikipedia.beta.wmflabs.org/ down? [07:52:07] zeljkof: labs NFS is down. [07:52:13] so i wouldn't be surprised if it is down [07:52:32] YuviPanda: thanks [07:54:39] hashar: selenium tests are running just fine on my machine with phantomjs [07:54:54] is phantomjs installed on jenkins machine? [07:57:03] hold on :-D [07:57:05] ugprading jenkins [07:57:17] yes it is installed [07:57:18] :-D [07:57:22] hm [07:57:23] some tests are even passing hehe [07:57:28] strange [07:57:44] let me know when it is back up, I will take a look at job config [07:58:34] zeljkof: the conf is described at https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/master/qa.yaml [07:58:57] the first job (shell starting line 12), takes care of installing bundle + gem dependencies [07:59:10] it then tarball the result and archive that [07:59:30] the second job (shell at line 50), grab the archive and run the tests [08:00:37] and of course I am missing most of the configuration such as the MEDIAWIKI_PASSWORD :D [08:01:09] hashar: is there a way for us to keep that password private? [08:01:15] or it has to be in the config file? [08:04:04] we can find a way to have it published by puppet [08:04:56] (03PS1) 10Zfilipin: Output warning that MEDIAWIKI_PASSWORD variable is needed only for tests tagged @login [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85833 [08:06:00] (03CR) 10jenkins-bot: [V: 04-1] Output warning that MEDIAWIKI_PASSWORD variable is needed only for tests tagged @login [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85833 (owner: 10Zfilipin) [08:22:00] (03PS1) 10Zfilipin: Renamed @does_not_exist_page_name variable to a more descriptive @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 [08:26:06] hashar: did you see this? [08:26:07] Unable to find phantomjs executable. (Selenium::WebDriver::Error::WebDriverError) [08:26:12] https://integration.wikimedia.org/ci/job/qa-browsertests-run/lastCompletedBuild/console [08:27:33] (03PS10) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:27:48] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:34:49] (03PS2) 10Zfilipin: Output warning that MEDIAWIKI_PASSWORD variable is needed only for tests tagged @login [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85833 [08:35:16] (03PS2) 10Zfilipin: Renamed @does_not_exist_page_name variable to a more descriptive @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 [08:35:52] (03PS3) 10Zfilipin: Output warning that MEDIAWIKI_PASSWORD variable is needed only for tests tagged @login [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85833 [08:37:58] (03PS11) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:38:11] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:38:34] (03PS3) 10Zfilipin: Renamed @does_not_exist_page_name variable to a more descriptive @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 [08:40:16] zeljkof: so I got Jenkins updated :-] [08:40:56] (03PS12) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:41:09] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:42:17] zeljkof: the last run I did is at https://integration.wikimedia.org/ci/job/qa-browsertests-run/15/ [08:43:03] zeljkof: the qa-browsertests-run job takes the artifacts from the last qa-browsertests-build build (which right now can be any patchset hehe [08:43:21] failures reports: [08:43:29] https://integration.wikimedia.org/ci/job/qa-browsertests-run/15/artifact/report.html [08:43:29] https://integration.wikimedia.org/ci/job/qa-browsertests-run/15/console [08:44:37] hashar: looks like phantomjs is not installed [08:44:40] "Unable to find phantomjs executable." [08:44:51] it must be somewhere under vendor/ [08:44:58] path issue I guess [08:46:01] hashar: can you run something like "which phantoms" [08:46:32] ah there is none [08:46:38] isn't it installed as part of the bundle ? [08:47:08] hashar: phantomjs? no [08:47:18] bah [08:47:20] it is not a ruby gem, it is an executable [08:47:31] installing phantomjs 1.4.0+dfsg-1 0 [08:47:32] like firefox, you have to install the browser separately [08:49:11] :-( [08:49:53] zeljkof: if you go to https://integration.wikimedia.org/ci/job/qa-browsertests-run/ and log with your labs account, you should be able to rebuild the last build [08:49:54] (03PS13) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:50:05] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:50:09] I did retrigger it [08:51:05] hashar: [08:51:11] unable to connect to phantomjs @ http://127.0.0.1:8910 after 20 seconds (Selenium::WebDriver::Error::WebDriverError) [08:51:12] :-D [08:51:14] better! [08:51:18] I see now, so there are three qa jenkins jobs [08:51:25] yes, an improvement! :) [08:52:05] is port 8910 the selenium instance or is it expected to be some mediawiki install ? [08:52:39] I think the way selenium works is that it installs a server inside a browser [08:52:55] so that would be the port of the phantomjs selenium driver [08:53:29] vendor/ruby/1.9.1/gems/selenium-webdriver-2.35.0/lib/selenium/webdriver/phantomjs/service.rb [08:53:30] 12: DEFAULT_PORT = 8910 [08:54:42] (03PS14) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:54:53] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:56:32] zeljkof: we probably need a fresher phantomjs :/ [08:57:20] hashar: probably :) which one did you install? [08:57:27] 1.4 [08:57:46] I have 1.9.2 :) [08:57:54] (03PS15) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:57:56] http://phantomjs.org/release-1.8.html talks about GhostDriver which is an implementation of WebDriver Wire Protocol [08:58:03] so yes, selenium _might_ expect a more recent version :) [08:58:10] (03CR) 10jenkins-bot: [V: 04-1] Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [08:58:25] upstream bug is http://code.google.com/p/phantomjs/issues/detail?id=49 [08:58:27] ghost driver is phantomjs selenium driver [08:58:27] so yeah [08:58:38] * hashar fill in yet another bug grmblblb [08:58:49] and ghost driver is installed by default with phantomjs [08:58:52] and yet another package that need to be back ported huhu [08:59:35] i think ghost driver is bundled with phantomjs [08:59:44] you just need to install a recent version of phantomjs [08:59:53] (03PS16) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [09:02:49] ahh [09:03:00] luckily phantoms 1.9 has been packaged for Ubuntu [09:03:08] though in Saucy which is the latest grbb [09:05:45] ahah [09:05:55] the qunit jobs do not even use the phantomjs package :-] [09:08:03] * hashar whistles while back porting package [09:08:18] zeljkof: sometime I feel like I am doing the same things over and over [09:08:57] are you installing ghost driver? [09:09:08] because I think it is bundler with phantomjs [09:09:18] you just need a recent version of it [09:11:18] (03CR) 10Foxtrott: "I really like the idea of this patch, but I am generally wary of hard-coding the style of html elements. What is your use case for this pa" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [09:12:30] zeljkof: unlikely to be packaged in our current ubuntu version since phantomJS was not supporting web driver at that time [09:12:40] I am attempting to backport the package [09:12:55] hashar: have fun :) [09:13:47] zeljkof: took me a while to figure it out but I now have a copy & paste guide at https://wikitech.wikimedia.org/wiki/Backport_packages :-D [09:21:46] hashar: hop in to #selenium [09:22:00] I am talking with _detronizator, ghost driver dev [09:31:07] (cd src/qt && ./preconfig.sh --..... [09:31:38] zeljkof: building phantomJS involves compiling QT, it is apparently embedded [09:32:04] fun times :) [09:42:11] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [09:42:13] * hashar shoots self [09:42:42] virtual memory exhausted: Cannot allocate memory [09:42:43] virtual memory exhausted: Cannot allocate memory [09:42:44] seriousl [09:42:45] y [09:42:54] need mooaar memory [09:44:45] "nobody will ever need more than 640 kb ram" or something like that :) [09:45:23] :-D [09:45:52] back in the 1990's a good friend of mine told me that nobody would ever need more than 800ps x 600px for video game [09:46:08] just after he bough a Voodoo video card (3D acceleration for game yeahhh) [09:46:18] the game were indeed way nicer than everything we have seen before [09:47:43] hashar: you should add me and/or chris to reviewers when you push a commit to browser tests repo [09:48:02] zeljkof: aren't you already watching the repo? [09:48:07] I almost missed your commits, I have noticed e-mail notification [09:48:19] zeljkof: Gerrit let you watch a repo, so you receive any notifiertions from them [09:48:20] but I do not see the commits in my incoming reviews [09:48:32] unless I am explicitly a reviewer [09:48:41] have a look at https://gerrit.wikimedia.org/r/#/settings/projects [09:48:44] then "Watched Projects" [09:49:00] you can add qa/browsertests there and get email notification on "new changes" , "new patch sets", "all comments" .. [09:49:51] and sometimes I get a lot of e-mail, so I just delete gerrit notifications since I expect to see everything in gerrit incoming reviews :) [09:50:04] yes, I am receiving e-mail notifications for browsertests [09:50:29] but just for an extra security (belts and suspenders) feel free to add me explicitly as a reviewer [09:50:37] will :-D [09:51:04] thanks [10:01:18] bah instance building up the Ubuntu images. .. [10:20:58] (03PS3) 10J: Parse Ogg Opus files and enable playback if supported [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 [10:24:00] yes, hello. black_male here [10:24:20] !ops I would like to become a Wikimedia Developer. As a member of the black community, promoting a minority will create a more diverse community and encourage multicultural harmony. [10:24:20] There is no such key, you probably want to try: !anonnotice, !oversight, !svnprops, !opsschool, [10:24:26] !anonnotice [10:24:26] Anonnotice is a wiki-wide message viewable by all logged out users at the top of every page. Similar to sitenotice, if anonnotice exists only logged out users will see anonnotice and only logged in users will see Sitenotice, they will not see each other. Anonnotice is editable by sysops at [[MediaWiki:Anonnotice]]. See also: !sitenotice [10:24:28] !oversight [10:24:28] Oversighting removes revisions from access by normal users and sysops. More information is available here: . Note: This extension has been superseded by a core feature: . [10:24:31] !svnprops [10:24:32] When commiting to the MediaWiki SVN repository, please make sure you set SVN properties on the new files. You can do this automagically using the instructions at http://www.mediawiki.org/wiki/Subversion/auto-props [10:24:35] !opsschool [10:24:35] http://www.opsschool.org/en/latest/index.html [10:24:38] !help [10:24:38] There are a lot of topics you could be asking about. Besides, this bot is mostly for experienced users to quickly answer common questions. Please just ask your question and wait patiently, as the best person to answer your question may be away for a few minutes or longer. If you're looking for help pages, we moved that to !helpfor. [10:24:45] !commands [10:24:45] I don't know everything about everything. I am mostly for lazy experienced users to echo quick answers to very common mediawiki questions. Please don't randomly experiment with me for help. Everything I know is at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm and you can visit #mwbot which shares the same db (read only) [10:25:19] Jasper_Deng: ^ [10:25:26] MatmaRex: hello [10:25:33] Jasper_Deng is a racist, please don't encourage him [10:25:59] !racism [10:26:29] heh [10:40:15] (03PS1) 10Hashar: linting jobs no more process submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85842 [10:48:43] (03PS1) 10Hashar: operations-puppet-validate no more use submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85843 [12:24:35] (03CR) 10Aklapper: [C: 031] "I see. +1 then (and we can still merge if upstream accepts the patch)." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm) [12:32:52] (03CR) 10Anomie: "Size and readability, which admittedly aren't hugely compelling. Which newlines are you concerned about, specifically?" [core] - 10https://gerrit.wikimedia.org/r/85233 (owner: 10Anomie) [13:35:37] (03PS1) 10Anomie: API: Add output of wgLogo to meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/85846 [13:36:45] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76457 (owner: 10Bartosz Dziewoński) [13:38:34] (03CR) 10Nathan Douglas: "Sure, you're right about that. I'll change that (and try to fix the formatting issues as well... not sure why my text editor is thwarting" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [13:39:09] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/72937 (owner: 10Bartosz Dziewoński) [13:41:17] (03PS1) 10Manybubbles: Tests for pulling suggestions from redirect names. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85847 [13:42:41] (03CR) 10Dzahn: [C: 032 V: 032] Add support for sf.net Allura URLs to Bugzilla's 'See also' field [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm) [13:45:16] (03CR) 10Dzahn: "deployed" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm) [13:53:20] (03PS2) 10Nathan Douglas: Adds support for setting per-term CSS styles. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 [13:53:40] (03PS1) 10Raimond Spekking: Fix descripion message key [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/85848 [13:56:44] (03CR) 10Dzahn: "unfortunately doesn't seem to match properly yet. conflict with the existing SourceForge.pm? please verify" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm) [13:57:02] (03CR) 10Manybubbles: [C: 032 V: 032] Fix descripion message key [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/85848 (owner: 10Raimond Spekking) [14:04:59] (03PS1) 10Chad: Elastica to master to pick up i18n + message fix [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85849 [14:05:13] (03CR) 10Chad: [C: 032] Elastica to master to pick up i18n + message fix [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85849 (owner: 10Chad) [14:05:45] (03CR) 10Foxtrott: "(1 comment)" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:06:24] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/72937 (owner: 10Bartosz Dziewoński) [14:09:45] (03Merged) 10jenkins-bot: Elastica to master to pick up i18n + message fix [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85849 (owner: 10Chad) [14:19:39] (03PS3) 10Nathan Douglas: Adds support for setting per-term CSS styles. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 [14:20:04] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76457 (owner: 10Bartosz Dziewoński) [14:23:05] (03CR) 10Nathan Douglas: "Er, was that what you wanted? Because now the whole tool-tip is styled like that, and I was trying to style only the abbreviation." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:23:32] (03CR) 10Nathan Douglas: "Ah, okay, I think I see." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:26:36] (03CR) 10Nathan Douglas: "Apparently I've been out of the web-dev world too long -- I didn't even think about using it that way, even with your earlier message abou" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:30:06] (03CR) 10Foxtrott: [C: 032] "Yes, that's exactly what I wanted. You can now select what element you want by combining classes in your css rules, e.g. for the term you " [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:30:08] (03Merged) 10jenkins-bot: Adds support for setting per-term CSS styles. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:32:18] (03CR) 10Foxtrott: "Oh, and thanks for the patch! It's a really nice improvement." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/85819 (owner: 10Nathan Douglas) [14:33:27] (03PS1) 10Manybubbles: Build suggestions from titles and redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85852 [14:41:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Let's merge!" [core] - 10https://gerrit.wikimedia.org/r/85410 (owner: 10PleaseStand) [14:53:17] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85855 [14:55:24] (03CR) 10Yurik: [C: 032] Updated Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85855 (owner: 10Yurik) [14:58:26] (03Merged) 10jenkins-bot: Updated Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85855 (owner: 10Yurik) [14:59:05] (03PS2) 10Manybubbles: Some tests for redirect loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85375 [15:04:11] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85852 (owner: 10Manybubbles) [15:04:26] ^d: search isn't looking inside templates anymore? https://www.mediawiki.org/w/index.php?search=AllowImageTag&button=&title=Special%3ASearch (used to find a result) [15:04:56] also it doesn't find the page, unless you search its exact title either... https://www.mediawiki.org/w/index.php?search=wgAllowImageTag&button=&title=Special%3ASearch [15:04:58] <^d> Hmm, should. Let's have a looksee. [15:06:08] it should find https://www.mediawiki.org/wiki/Manual:$wgAllowExternalImages#See_also at least [15:06:35] <^d> Right. File a bug, that looks...wrong. [15:07:08] <^d> p858snake|l: Thanks for spotting those two issues. [15:07:11] but bugzilla is hard [15:08:10] * Reedy kicks p858snake|l [15:08:31] * p858snake|l ticks Reedy [15:12:21] bugzilla wraps quoted text now =( [15:12:51] (03PS2) 10Manybubbles: Build suggestions from titles and redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85852 [15:16:29] (03CR) 10Chad: [C: 032] Build suggestions from titles and redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85852 (owner: 10Manybubbles) [15:16:31] (03Merged) 10jenkins-bot: Build suggestions from titles and redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85852 (owner: 10Manybubbles) [15:17:14] (03CR) 10Chad: [C: 032] Some tests for redirect loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85375 (owner: 10Manybubbles) [15:17:17] (03Merged) 10jenkins-bot: Some tests for redirect loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85375 (owner: 10Manybubbles) [15:17:51] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85858 [15:18:27] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85858 (owner: 10Yurik) [15:23:16] (03CR) 10BryanDavis: [C: 031] "Looks good to me. I can't find anywhere that these files are still used. Role management and provisioning still work with patch applied." [vagrant] - 10https://gerrit.wikimedia.org/r/85830 (owner: 10Yuvipanda) [15:23:52] (03CR) 10Ori.livneh: [C: 032] Remove unused files enumerate-roles & puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/85830 (owner: 10Yuvipanda) [15:23:56] (03Merged) 10jenkins-bot: Remove unused files enumerate-roles & puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/85830 (owner: 10Yuvipanda) [15:24:15] YuviPanda / bd808: thanks [15:26:14] ori-l: what's your workflow for testing vagrant changes (especially new roles)? [15:26:40] (03CR) 10Chad: [C: 032] Tests for pulling suggestions from redirect names. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85847 (owner: 10Manybubbles) [15:26:41] (03Merged) 10jenkins-bot: Tests for pulling suggestions from redirect names. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85847 (owner: 10Manybubbles) [15:27:15] bd808: provisioning it on an existing VM is usually adequate if it's a new role. if it modifies existing stuff, esp. the core classes, then vagrant destroy / vagrant up [15:27:28] destroying & recreating VMs is much faster now with the apt-cache trick [15:27:56] (i moved the apt cache archives to the share folder, so it persists after the vm is destroyed, so the next time you create a VM packages don't need to be re-downloaded) [15:27:56] <^d> p858snake|l: Soo, your first link (https://www.mediawiki.org/w/index.php?search=wgAllowImageTag&button=&title=Special%3ASearch) works now. [15:28:14] <^d> I think I had some un-sync'd code. I could've sworn that had been working before, and it is again :) [15:28:26] <^d> The second one's still a bug (not matching partial page title) [15:29:02] ori-l: Seems reasonable. I think I need to test the math role without having other roles enabled. I've got a suspicion that it needs more apt packages if enabled in isolation. [15:29:29] bd808: build-essential or whatever? [15:30:27] imagemagick I think [15:31:35] (03CR) 10Cmcmahon: "we will want to do this in the VE repo also" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 (owner: 10Zfilipin) [15:31:55] Reedy: https://gerrit.wikimedia.org/r/#/q/project:operations/apache-config,n,z fyi, thanks [15:34:34] (03CR) 10Aklapper: [C: 031] "Testing this on boogs.wmflabs.org it works for me, hence I give my +1." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/76105 (owner: 10Aklapper) [15:35:09] (03PS7) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:35:24] (03CR) 10Dan-nl: "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [15:35:39] (03PS1) 10MaxSem: Profiling + rm pointless var assignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85860 [15:38:38] (03PS8) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:52:09] (03CR) 10Aaron Schulz: [C: 032] Improve wfEscapeWikiText, part 2 [core] - 10https://gerrit.wikimedia.org/r/85233 (owner: 10Anomie) [15:55:38] (03Merged) 10jenkins-bot: Improve wfEscapeWikiText, part 2 [core] - 10https://gerrit.wikimedia.org/r/85233 (owner: 10Anomie) [16:00:02] (03CR) 10Zfilipin: [C: 04-1] "-1 because I did not have the time to test it yet on all platforms. I am pretty sure this would cause a problem on Windows, but I will hav" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85813 (owner: 10Hashar) [16:03:50] (03CR) 10Yaron Koren: [C: 032 V: 031] Added generating pages with page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/80863 (owner: 10Himeshi) [16:09:03] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85765 (owner: 10Aaron Schulz) [16:10:08] (03CR) 10Aaron Schulz: "I'd eventually like to dependency inject the mime handler and also support extension-less files better." [core] - 10https://gerrit.wikimedia.org/r/85765 (owner: 10Aaron Schulz) [16:20:00] (03CR) 10Aaron Schulz: [C: 032] MysqlInstaller: use default character set of utf8 [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun) [16:22:50] (03Merged) 10jenkins-bot: MysqlInstaller: use default character set of utf8 [core] - 10https://gerrit.wikimedia.org/r/67422 (owner: 10Karun) [16:23:05] (03PS3) 10Aaron Schulz: Support rate limiting backlink purges, including null edits [core] - 10https://gerrit.wikimedia.org/r/85358 [16:23:15] (03CR) 10Yaron Koren: [V: 032] "Why doesn't this get tested/verified automatically?" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/80863 (owner: 10Himeshi) [16:23:19] <^d> Elsie: Sooo, quoting and stemming. It was late and I forgot we had a bug. https://bugzilla.wikimedia.org/show_bug.cgi?id=54020 [16:24:09] (03PS2) 10MaxSem: Profiling + rm pointless var assignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85860 [16:26:04] (03CR) 10Yuvipanda: [C: 032] "Data!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85860 (owner: 10MaxSem) [16:26:10] (03Merged) 10jenkins-bot: Profiling + rm pointless var assignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85860 (owner: 10MaxSem) [16:32:57] (03CR) 10BryanDavis: "I'll retract my -1, but personally forward looking function signatures make me itchy. Especially for a protected method it seems better to" [core] - 10https://gerrit.wikimedia.org/r/85765 (owner: 10Aaron Schulz) [16:33:27] * YuviPanda pokes around for an ori-l [16:33:30] (03PS1) 10Fantasticfears: Role: Add Universal Language Selector(ULS) role [vagrant] - 10https://gerrit.wikimedia.org/r/85876 [16:35:29] stupid crappy-ass irc. [16:37:42] (03PS2) 10Zfilipin: README: mention BROWSER_LABEL [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85812 (owner: 10Hashar) [16:38:48] (03CR) 10Zfilipin: [C: 031] "I have changed the readme file so it looks like the suggestion that I have made. I think this can now be merged into master." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85812 (owner: 10Hashar) [16:39:26] (03CR) 10CSteipp: [C: 032] Avoid sending cookies when using OAuth since they are useless [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85139 (owner: 10Aaron Schulz) [16:39:34] (03Merged) 10jenkins-bot: Avoid sending cookies when using OAuth since they are useless [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85139 (owner: 10Aaron Schulz) [16:42:20] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [16:43:42] (03PS2) 10Anomie: Fix secure handling in setGlobalCookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/85776 [16:46:17] (03CR) 10Cmcmahon: [C: 032] Renamed @does_not_exist_page_name variable to a more descriptive @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 (owner: 10Zfilipin) [16:49:02] (03CR) 10Cmcmahon: [C: 032] Output warning that MEDIAWIKI_PASSWORD variable is needed only for tests tagged @login [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85833 (owner: 10Zfilipin) [16:49:33] (03CR) 10Cmcmahon: "resolved dependency" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85834 (owner: 10Zfilipin) [16:54:32] anomie: interesting how getCentralSession() gets prefs from the local user on the central wiki [16:55:02] ori-l: any ideas on that less compilation failure? i seem to remember seeing it before but it unbroken somehow [16:55:20] AaronSchulz: Seems better than just forcing an arbitrary default on the user. [16:55:34] do those get set in flight somewhere? [16:55:50] well, that could get tricky too [16:56:09] really this just needs global prefs [16:56:14] oh well [16:56:18] AaronSchulz: Not sure. I think the "remember" one does. [16:56:49] if "remember me" on one wiki gets that set centrally, then that could work decently [16:56:54] maybe https does the same [16:57:11] * AaronSchulz looks [16:59:10] * AaronSchulz doesn't see where "remember" does [16:59:17] ori-l: I'm heading to sleep now (again!), but a cursory look from you on https://gerrit.wikimedia.org/r/#/c/85814/ would be helpful. I know it is not the most clean way to do it, but it is IMO a good intermediate step for people who are using 'sudo git clone' to deploy mw on labs [16:59:21] (03PS1) 10Manybubbles: Prevent redirect loops from crashing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85880 [16:59:37] ori-l: it also needs work to figure out a proper 'vagrant provision', 'enable-role', 'list-roles', 'disable-role' commands [16:59:40] (03CR) 10Aaron Schulz: [C: 032] Fix secure handling in setGlobalCookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/85776 (owner: 10Anomie) [16:59:42] (03Merged) 10jenkins-bot: Fix secure handling in setGlobalCookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/85776 (owner: 10Anomie) [17:01:46] (03CR) 10MarkTraceur: [C: 04-1] "(12 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [17:07:00] (03PS10) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 [17:09:18] ok it looks like round() isn't implemented in php lessc 0.4 [17:21:30] (03PS1) 10Legoktm: Optional / at the end of the url [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85883 [17:23:12] (03PS2) 10Legoktm: Optional / at the end of the url [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85883 [17:24:59] ori-l: ping me when you are around :) [17:27:43] (03CR) 10Legoktm: "Followed up in: https://gerrit.wikimedia.org/r/#/c/85883" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm) [17:30:32] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [17:30:59] (03CR) 10Kaldari: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:31:35] (03CR) 10Tpt: [C: 04-1] "(4 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 (owner: 10Rtdwivedi) [17:32:21] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:32:33] (03CR) 10CSteipp: [C: 032] "It might be nice to move this logic into a utility function for core.. but good for us for now." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85771 (owner: 10Aaron Schulz) [17:32:41] (03Merged) 10jenkins-bot: Added a loop sanity check to $wgMWOAuthSecureTokenTransfer redirect [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85771 (owner: 10Aaron Schulz) [17:32:45] (03PS1) 10Yaron Koren: Version 0.4-alpha [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/85885 [17:33:04] csteipp_afk: Beep, have you had a chance to look at BetaFeatures? [17:33:05] ori-l: ok the embed() works but the .background-image mixin has something wrong with it, lemme investigate [17:33:29] anomie: seems like there are a few bits left on https://gerrit.wikimedia.org/r/#/c/85218/ [17:34:08] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85886 [17:34:29] (03CR) 10Reedy: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [17:35:25] (03CR) 10Yaron Koren: [C: 032 V: 032] Version 0.4-alpha [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/85885 (owner: 10Yaron Koren) [17:36:11] (03CR) 10Andrew Bogott: [V: 04-1] "Found a bug in this, stay tuned..." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 (owner: 10Andrew Bogott) [17:37:01] durrrr we're not importing it are we [17:38:14] ok got it [17:38:23] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85887 [17:41:25] (03PS1) 10Brion VIBBER: Implement LESS round() function, needed by MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/85888 [17:42:42] (03PS1) 10Manybubbles: Extra guards around suggestion parsing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85889 [17:43:33] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85886 (owner: 10Bsitu) [17:46:32] (03Merged) 10jenkins-bot: Update Echo and Thanks to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85886 (owner: 10Bsitu) [17:47:22] (03CR) 10Chad: [C: 032] Extra guards around suggestion parsing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85889 (owner: 10Manybubbles) [17:47:23] (03Merged) 10jenkins-bot: Extra guards around suggestion parsing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85889 (owner: 10Manybubbles) [17:47:36] (03PS8) 10Rtdwivedi: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 [17:48:05] ^d: I think we're probably ok waiting until the html formatter goes live to deploy both together [17:48:09] because that is today [17:48:18] <^d> Yeah [17:48:26] <^d> If not, we can just cherry pick in, nbd [17:48:31] but we'll want to push after they do. yeah [17:49:31] <^d> Hope today was a learning experience for deploying :) [17:51:12] (03CR) 10Alex Monk: "Krinkle, please respond to my in-line replies" [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [17:51:31] (03CR) 10Tpt: [C: 032] Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 (owner: 10Rtdwivedi) [17:51:41] (03Merged) 10jenkins-bot: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 (owner: 10Rtdwivedi) [17:52:39] jdlrobson, I'm trying to publish a comment at https://gerrit.wikimedia.org/r/#/c/79948/16/skins/vector/screenBeta.css but it says "Draft saved". I can't see a way to publish (unless it's already published). Help, please. :) [17:52:41] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [17:53:01] qgil_: confusingly you have to click review [17:54:17] jdlrobson, "Reply 'Done'", you mean? [17:54:38] no.. you hit review then publish comments and review it 0 [17:55:37] (03CR) 10Qgil: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:56:00] jdlrobson, gosh, who would have thought.... Thanks! [17:56:41] i know :/ [17:58:42] anomie: Hey, do you have thoughts about how to do lists-of-things in an API module? I want it to be an object in JSON and a collection of tags in XML, e.g. [17:58:56] It would be silly to have or whatever else [17:59:19] (03CR) 10Aude: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [17:59:22] But it makes perfect sense to say { repos: { wikimediacommons: {} } } [18:03:03] marktraceur: List-of-things is usually done by making an array of things to put in the result, but first you call $result->setIndexedTagName( $array, 'repo' ) to tell the XML formatter to put each element of the array inside tags. Is that not what you're wanting? [18:03:20] Roughly yes [18:03:28] I just need to shift some things around [18:10:29] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF)) [18:15:18] (03PS1) 10Rfaulk: add - docs update and git-deploy cp to init. [sartoris] - 10https://gerrit.wikimedia.org/r/85893 [18:15:41] (03CR) 10Rfaulk: [C: 032 V: 032] add - docs update and git-deploy cp to init. [sartoris] - 10https://gerrit.wikimedia.org/r/85893 (owner: 10Rfaulk) [18:17:42] anomie: Is there a silver-bullet tutorial for such things? I am apparently doing it wrong [18:18:03] Oh, wait, maybe not [18:18:05] marktraceur: Not really. What problem are you getting? [18:18:18] Aha [18:18:35] Never mind, I didn't move my path backwards enough [18:19:26] anomie: But here's my problem - list-of-things in XML because is silly, but in JSON, wikimediacommons: { .... } makes perfect sense [18:19:44] (03PS9) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [18:20:28] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85887 (owner: 10Bsitu) [18:20:36] marktraceur: Unfortunately, you have to pick one or the other. [18:21:17] Mrr. [18:21:26] 'kay, list-of-things is mildly less shitty [18:23:12] (03PS2) 10Brion VIBBER: Implement LESS round() function, needed by MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/85888 [18:23:45] (03Merged) 10jenkins-bot: Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85887 (owner: 10Bsitu) [18:24:42] ori-l: Does the standard MW Vagrant stuff include the Math extension? [18:24:56] I ask because it's a PITA to set up and a scripted setup for that would be very nice [18:25:30] RoanKattouw: funny you should ask, bd808|LUNCH added a role last week [18:25:36] Nice! [18:26:04] so 'vagrant-enable role math && vagrant provision' should be all that is required [18:26:11] Awesome [18:26:12] err, vagrant enable-role [18:26:18] * RoanKattouw goes about setting up vagrant in the first place [18:26:42] RoanKattouw: cool cool. i'd welcome feedback about things that were unintuitive / annoying / broken [18:27:02] brion: I just got off a phone interview with a candidate, catching up with the scrollback [18:27:36] ori-l: so i seem to have it working, had to implement round() function and add an @import for the mixin [18:28:41] yep, looking at your patch [18:29:25] at some point we might want to double-check what is/isn't implemented in the php lessc in case there's any more surprises :D [18:29:30] and we can definitely improve the error reporting... [18:29:51] it seems like round is in fact implemented? [18:29:58] well if it is i can't find it [18:30:14] ' protected function lib_round($arg) { ' in lessc.inc.php [18:30:26] ah [18:30:31] ok it is implemented for single parameter [18:30:34] but not for two parameters [18:30:42] there's an open pull request for that, it seems: https://github.com/leafo/lessphp/pull/399 [18:30:46] \o/ [18:31:35] (03CR) 10EBernhardson (WMF): "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF)) [18:31:43] the guy who wrote lessphp has been pretty quick to merge most of my pull requests, and i've been meaning to e-mail him to let him know about mediawiki integration [18:31:54] so i can mention this pull request and explain that it'd be especially useful for us [18:31:59] (03CR) 10Brion VIBBER: "Alternately, upstream fix: https://github.com/leafo/lessphp/pull/399" [core] - 10https://gerrit.wikimedia.org/r/85888 (owner: 10Brion VIBBER) [18:32:26] (03PS1) 10MaxSem: Update UploadWizard to master tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85894 [18:32:46] ori-l: awesome [18:34:39] (03PS1) 10MaxSem: Update UploadWizard to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85895 [18:34:44] marktraceur: Sorry, not yet. Security bug got in the way. [18:37:08] (03PS2) 10MarkTraceur: Add meta=repoinfo for getting image repo metadata [core] - 10https://gerrit.wikimedia.org/r/85344 [18:39:59] (03PS1) 10Chad: Fixing Cirrus for 1.22wmf17 [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85897 [18:46:40] brion: saw your comment. I think upstream might merge this request pretty quickly now. would you mind waiting 24 hours or so before we go ahead with the custom implementation? [18:46:43] (03PS1) 10MaxSem: Cherry-pick HtmlFormatter into production [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85899 [18:46:59] ori-l: sure [18:47:05] (03PS3) 10MarkTraceur: Add meta=repoinfo for getting image repo metadata [core] - 10https://gerrit.wikimedia.org/r/85344 [18:47:22] cool, i sent an email as well [18:47:25] (03PS5) 10EBernhardson (WMF): See that a post has been edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 [18:47:48] (03CR) 10Kaldari: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:47:52] (03CR) 10jenkins-bot: [V: 04-1] Add meta=repoinfo for getting image repo metadata [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur) [18:48:00] (03PS1) 10MaxSem: Cherry-pick HtmlFormatter into production [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85900 [18:48:47] MatmaRex: How do I poke your release-notes updater? I've added her as a reviewer, but... [18:49:04] "If you reclaim the extra space, the virtual machine size will be reduced by 14.5 GB." aaaaaaaah that's an improvement [18:52:36] (03CR) 10Qgil: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:53:52] marktraceur: ughhh… the bot is currently mostly defunct, sorry [18:54:16] marktraceur: i suggest installing the driver locally and just doing git review -d; git rebase master; git review -f [18:54:56] marktraceur: https://github.com/MatmaRex/mediawikireleasenotes-driver#readme [18:55:23] Hm [18:55:31] (sorry, brb) [18:55:34] I'll just...rebase [18:55:52] marktraceur: `curl https://raw.github.com/MatmaRex/mediawikireleasenotes-driver/master/mediawikireleasenotes-driver-installer.sh | sh`, then rebase :) [18:56:25] (03PS4) 10MarkTraceur: Add meta=repoinfo for getting image repo metadata [core] - 10https://gerrit.wikimedia.org/r/85344 [18:56:29] MatmaRex: Meh [18:56:34] Took three seconds of my life [19:00:38] jdlrobson: you rang? [19:00:55] marktraceur: awful. how much do you charge for that amount? :P [19:00:55] ori-l: so i'm playing around with less in core [19:01:12] i'm in the middle of a patch and was running into issues with using embed [19:01:18] there are some unusual uses of it [19:01:36] (03CR) 10Ori.livneh: [C: 04-1] "As we agreed on IRC, let's wait 24 hours to see if upstream beats us to the punch." [core] - 10https://gerrit.wikimedia.org/r/85888 (owner: 10Brion VIBBER) [19:01:51] https://gerrit.wikimedia.org/r/#/c/83591/ < see fixmes ori-l [19:01:51] MatmaRex: Well, let's see, my usual rate is $25 an hour for freelancing, so...a few cents, probably [19:02:20] Then again, the freelancing rate is from a year ago, when I was poor as all hell, and requires me to have time for freelancing. [19:02:45] ori-l: i have to relocate though.. losing my hotel room :/ [19:02:58] jdlrobson: OK, ping me when you get back. [19:03:07] ;) [19:06:10] RoanKattouw: let me know if you have any problems with the role::math stuff. It worked for me but I'm not 100% it doesn't have some dependencies that were satisfied indirectly by other roles enabled on my vm. [19:06:44] (03CR) 10Nikerabbit: "How about adding role for MLEB ? It's available via git as well." [vagrant] - 10https://gerrit.wikimedia.org/r/85876 (owner: 10Fantasticfears) [19:07:08] (03CR) 10Ori.livneh: [C: 04-1] "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/85876 (owner: 10Fantasticfears) [19:08:55] wat [19:09:03] There is a syntax error in the following Vagrantfile. The syntax error [19:09:04] message is reproduced below for convenience: [19:09:06] /home/catrope/git/mediawiki/vagrant/Vagrantfile:45: syntax error, unexpected ':', expecting kEND [19:09:07] ip: '10.11.12.13' [19:09:09] And a couple more [19:09:11] ori-l: halp? [19:09:43] Ooooh nm [19:09:49] Got version 1.0 [19:10:15] yes, was just about to ask [19:11:29] The 90s called and they want their "download a .deb from this random web site" workflow back [19:12:19] hahaha [19:12:39] RoanKattouw: yeah. :/ [19:12:59] * bd808 just had a SUSE rpm flashback [19:14:28] RoanKattouw: it gets worse: I'd also recommend a newer VirtualBox, if you planned on using the one in apt [19:14:36] I did use the one in APT [19:14:38] What's wrong with it? [19:14:50] (v4.2) [19:14:58] I think the performance of virtualbox shared folders (the file-sharing protocol) got dramatically better in 4.2 [19:15:00] oh, 4.2, hrm [19:15:06] might be fine then! [19:26:00] ori-l: "Merged #399." :D [19:26:34] \o/ [19:27:11] i'll submit a patch; the license portion needs to be updated as well (https://github.com/leafo/lessphp/pull/473) [19:34:35] brion: https://gerrit.wikimedia.org/r/#/c/85904/ [19:37:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good! This replaces I1efc5bef47efd33b3caaebf0f241fbf81a0209f2." [core] - 10https://gerrit.wikimedia.org/r/85904 (owner: 10Ori.livneh) [19:37:30] (03Abandoned) 10Brion VIBBER: Implement LESS round() function, needed by MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/85888 (owner: 10Brion VIBBER) [19:50:38] ori-l: i could do with your less expertise in a bit - i'm trying to swap out a list of defined variables based on a user preference [19:55:02] jdlrobson: you might have to define a custom resource loader module type for that, and invoke lessc manually [19:55:33] ok. I'm going to submit a patch for inspection so people can guide me better :) [19:56:08] wheeeee :D [19:56:10] csteipp: Herro [19:59:01] (03CR) 10MaxSem: [C: 032 V: 032] Update UploadWizard to master tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85895 (owner: 10MaxSem) [20:01:54] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85906 [20:02:01] (03CR) 10MaxSem: [C: 032 V: 032] Cherry-pick HtmlFormatter into production [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85899 (owner: 10MaxSem) [20:02:29] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85906 (owner: 10MaxSem) [20:08:38] (03CR) 10MarkTraceur: "Reedy, your help merging the initial commit would be greatly appreciated :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/85367 (owner: 10MarkTraceur) [20:16:03] sumanah: is there a page I can point someone to who wants to get there feet wet with development? [20:16:15] *their feet [20:16:28] mwalker: yes! [20:16:31] !howto [20:16:31] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [20:16:54] mwalker: so, are you thinking of someone who's never coded before, or a programmer who is interested in jumping into MW/Wikimedia? [20:17:19] (03PS1) 10Manybubbles: Quotes turn off stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85908 [20:17:37] I don't actually know; I'm fullfilling a shell request for labs and the person has in their justification "I would like to help fixing bugs and so on. It would be nice to be able to become part of a project or create a new projects, and help with MediaWiki extensions." [20:18:08] mwalker: aha! ok, in that case, I think it would be good to point her or him to https://www.mediawiki.org/wiki/How_to_contribute [20:18:19] thank you for being so conscientious! [20:19:19] (03PS1) 10Manybubbles: Tests for quotes turning of stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85910 [20:22:02] (03PS2) 10Manybubbles: Quotes turn off stemming. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85908 [20:33:58] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85426 (owner: 10Tpt) [20:35:44] (03CR) 10Hashar: [C: 032] "deployed earlier today" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85842 (owner: 10Hashar) [20:35:51] (03CR) 10Hashar: [C: 032] "deployed earlier today" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85843 (owner: 10Hashar) [20:36:05] (03Merged) 10jenkins-bot: linting jobs no more process submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85842 (owner: 10Hashar) [20:36:20] (03Merged) 10jenkins-bot: operations-puppet-validate no more use submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85843 (owner: 10Hashar) [20:37:43] (03CR) 10Chad: [C: 032] Fixing Cirrus for 1.22wmf17 [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85897 (owner: 10Chad) [20:38:13] (03CR) 10Chad: [C: 032] Prevent redirect loops from crashing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85880 (owner: 10Manybubbles) [20:38:17] (03Merged) 10jenkins-bot: Prevent redirect loops from crashing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85880 (owner: 10Manybubbles) [20:40:24] (03Merged) 10jenkins-bot: Fixing Cirrus for 1.22wmf17 [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85897 (owner: 10Chad) [20:51:26] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85916 [20:51:45] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85916 (owner: 10MaxSem) [20:57:03] (03PS1) 10Aaron Schulz: Reduce chance for parser cache race conditions [core] - 10https://gerrit.wikimedia.org/r/85917 [20:58:08] RoanKattouw: did it work out in the end? [20:58:25] Yeah I got it to work [20:58:33] BTW, thanks for magically showing up when I have another question [20:58:36] did it have to be persuaded? :) [20:58:44] Is there an automated way for me to add a no-frills extension? [20:58:47] (Extension:MathJax in my case) [20:59:03] It was really easy actually, once I got the right version of vagrant. Super usable, nice job [20:59:33] create puppet/manifests/manifests.d/extra.pp [20:59:34] with contents: [20:59:44] @mediawiki::extension { 'MathJax': } [20:59:56] that should be sufficient [21:00:09] And then 'vagrant provision' ? [21:00:12] yep [21:00:30] see puppet/manifests/roles.pp if you need to run update.php or provide config values [21:00:37] Can I do 'MathJax': ensure => absent to disable it again? [21:01:10] you don't even need to do that; just removing the line/file that declares it will remove it the next time you run vagrant provision [21:01:33] it doesn't delete the directory because that's taking more liberty with users' files than i care to take, but it will remove the include_once line for the extension [21:01:39] (03PS11) 10Jdlrobson: Vector: Add code for navigation collapsing [core] - 10https://gerrit.wikimedia.org/r/83591 [21:01:40] (03PS17) 10Jdlrobson: WIP Experimental: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 [21:01:41] (03PS1) 10Jdlrobson: Turn screen.css into screen.less [core] - 10https://gerrit.wikimedia.org/r/85920 [21:01:56] Oh OK [21:02:11] So it's not like the normal puppet thing where if you don't explicitly tell it to go away, it'll be there forever? [21:02:31] (03CR) 10Jdlrobson: [C: 04-1] "Need some input from Ori on how to do embeds" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [21:02:45] (03CR) 10MaxSem: [C: 032 V: 032] Update UploadWizard to master tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85894 (owner: 10MaxSem) [21:02:52] no, i used a trick to work around that. extensions are loaded by files in settings.d/puppet-managed, and that directory is managed recursively by puppet, so it always reflects the roster of enabled extensions [21:03:03] (03CR) 10MaxSem: [C: 032 V: 032] Cherry-pick HtmlFormatter into production [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85900 (owner: 10MaxSem) [21:03:09] it's a neat trick: http://christian.hofstaedtler.name/blog/2008/11/puppet-managing-directories-recursively.html [21:04:08] ^ ori-l less stuff [21:04:15] brb [21:06:50] (03PS1) 10Bsitu: Fix incorrect reference to error message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85921 [21:07:15] RoanKattouw: MathJax is not in gerrit? [21:07:24] ori-l: recurse is very expensive [21:07:24] Meh [21:07:29] It looks like I just need the Math extension [21:07:31] And turn on a $wg [21:07:34] and we limit its use heavily [21:07:35] So I've done that now [21:08:04] ah, this is for vagrant? [21:08:12] Ryan_Lane: ruby is very expensive; puppet is very expensive; virtualization is very expensive. but convenient :) [21:08:17] yeah [21:08:22] nevermind, then :) [21:12:39] (03CR) 10Ori.livneh: "All you need to do is replace each instance of" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [21:13:20] (03PS3) 10EBernhardson (WMF): Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 [21:13:25] (03CR) 10Ori.livneh: "...or rather:" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [21:15:46] (03CR) 10EBernhardson (WMF): "We are taking another path with this change, similar but slightly different." [core] - 10https://gerrit.wikimedia.org/r/81396 (owner: 10Aude) [21:20:55] ori-l: what about using embed with "background" property [21:21:14] and does embed support arguments such as background-image: -webkit-linear-gradient(transparent, transparent), url(images/arrow-down-icon.svg); [21:21:33] (03Abandoned) 10EBernhardson (WMF): Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [21:21:45] also was wondering how i should do noflip - i suspect we need a mixin for that? [21:22:19] for 'background', we could support it, but the simplest solution is to just not use the shorthand [21:22:24] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Fix incorrect reference to error message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/85921 (owner: 10Bsitu) [21:23:01] you don't need a mixin for noflip; the comment annotations should work, but with the proviso that they work when applied to a block of rules, not to an individual rule [21:23:17] for "background-image: -webkit-linear-gradient(transparent, transparent), url(images/arrow-down-icon.svg);", not sure yet, let me read about what that does exactly [21:23:22] * jdlrobson nods [21:23:35] ori-l: yeh i was thinking that would make sense (using background-image) [21:23:46] my plan is to complete overhaul the vector code into nice less code [21:24:44] (03CR) 10EBernhardson (WMF): [C: 031] When logging feedback, use the page as the target [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/85338 (owner: 10Jackmcbarn) [21:25:26] we could add new mixins that use 'embed()', but i think we should be a bit conservative for now [21:25:40] did you see juliusz and brion's comments on the mobilefrontend patch? seems like that's one to solve first [21:27:34] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85924 [21:29:27] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85924 (owner: 10MaxSem) [21:31:24] AaronSchulz: /* falls through */ [21:31:46] I do that in PHP sometimes [21:36:57] (03PS3) 10Legoktm: Optional / at the end of the url, allow for - to be in bugtype [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85883 [21:45:59] (03PS1) 10MarkTraceur: Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 [21:47:50] (03CR) 10Aude: [C: 031] "looks fine, assuming db queries are efficient enough" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson (WMF)) [21:48:35] (03Abandoned) 10Aude: postgresql schema update for rc_external_type column [core] - 10https://gerrit.wikimedia.org/r/81396 (owner: 10Aude) [21:48:51] (03CR) 10jenkins-bot: [V: 04-1] Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [21:49:36] (03PS2) 10MarkTraceur: Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 [21:50:15] (03PS3) 10MarkTraceur: Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 [21:50:51] Woo 64 parser test failures [21:51:29] just 64? amateur. :D [21:51:58] MatmaRex: Well I'm only breaking image parsing [21:52:03] So it's not like I can break everything [21:52:49] (Merged) jenkins-bot: Break all the parser tests [core] - https://gerrit.wikimedia.org/r/99999 (owner: MatmaRex) [21:53:12] (03CR) 10jenkins-bot: [V: 04-1] Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [21:53:54] well, i did break quite a lot when changing section edit links [21:53:57] and the tocs [21:54:19] also, marktraceur, can i have the short version of "why" on that changeset? :D [21:54:35] the filename is already present in the HTML in a few ways usually [21:55:19] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85928 [21:55:36] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85928 (owner: 10MaxSem) [21:56:49] MatmaRex: Usually in the middle of a useless URL that I don't want to have to parse [21:57:06] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85929 [21:57:13] marktraceur: heh [21:57:19] MatmaRex: Plus, the DOM spec is pretty well accepted at this point, no need to put off implementing it [21:57:22] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85929 (owner: 10MaxSem) [21:57:30] Brings us closer to unified PHP and Parsoid parser tests [21:57:35] almost all images link to their image [21:57:49] (and those that don't you probably don't want to handle in that extension anyway) [21:58:12] also, a possibly helpful comment instead: what about -s? [21:59:10] What about them? [21:59:31] um, i dunno? you want to handle them, maybe? (or do you already?) [21:59:48] MatmaRex: I don't need to link to the image itself, I want to call the API to get imageinfo, which requires the title but not the URL [22:00:02] MatmaRex: I don't know about galleries, let me check if those tests failed. [22:00:08] Seems like they did [22:00:25] i think galleries are mostly generated by a separate file [22:00:30] but who knows [22:00:52] okay, i should check what that does before commenting, but i'm not going to do that now, so i'll shut up. :) [22:00:55] * bawolff hears the word gallery [22:01:55] bawolff: Ssshhhh [22:02:16] MatmaRex: I'll tell you when I get to the gallery tests in parserTests.txt [22:02:27] I can run, but I can't hide from them [22:02:42] * bawolff doesn't actually know what you are talking about, having just joined [22:02:51] bawolff: mark's breaking images [22:03:00] https://gerrit.wikimedia.org/r/85926 [22:03:00] fun! [22:03:09] i suggested that he break galleries as well [22:03:10] :D [22:03:22] me is off to #-rfc [22:03:26] (03CR) 10Aaron Schulz: [C: 04-1] "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [22:03:28] gmrblsasdhjk. [22:03:32] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85931 [22:03:33] * MatmaRex is off to #-rfc [22:03:47] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85931 (owner: 10MaxSem) [22:04:11] yeah, that is going to be a PITA unit test wise [22:04:38] (03PS17) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [22:04:51] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85932 [22:05:07] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85932 (owner: 10MaxSem) [22:06:12] (03PS1) 10Physikerwelt: New Feature: size of output [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/85933 [22:06:38] (03CR) 10Physikerwelt: [C: 032 V: 032] New Feature: size of output [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/85933 (owner: 10Physikerwelt) [22:09:53] (03CR) 10Aaron Schulz: [C: 032] Improve mw.text.nowiki, part 2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85234 (owner: 10Anomie) [22:11:41] (03Merged) 10jenkins-bot: Improve mw.text.nowiki, part 2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85234 (owner: 10Anomie) [22:17:37] (03PS18) 10Physikerwelt: Backup [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [22:34:02] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85936 [22:35:53] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85937 [22:36:17] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85936 (owner: 10MaxSem) [22:36:38] (03CR) 10MaxSem: [C: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85937 (owner: 10MaxSem) [22:36:45] (03CR) 10MaxSem: [V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85937 (owner: 10MaxSem) [22:43:18] (03CR) 10Aaron Schulz: [C: 032] API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 (owner: 10Anomie) [22:46:03] (03Merged) 10jenkins-bot: API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 (owner: 10Anomie) [23:05:54] (03PS2) 10EBernhardson (WMF): Better error handling for memc and some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 [23:21:09] (03PS2) 10Brian Wolff: Add option to chose what language to fetch file description in. [core] - 10https://gerrit.wikimedia.org/r/82085 [23:21:18] (03PS1) 10Ori.livneh: Add replace() function to LESS [core] - 10https://gerrit.wikimedia.org/r/85939 [23:25:14] (03CR) 10Ori.livneh: [C: 04-1] "Pending outcome of discussion over at change I068686854." [core] - 10https://gerrit.wikimedia.org/r/85939 (owner: 10Ori.livneh) [23:36:08] (03PS4) 10Parent5446: Add wgRevisionId variable to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/81032 [23:37:05] (03CR) 10Parent5446: "Yeah I was being stupid and forgot that timezones were unnecessary." [core] - 10https://gerrit.wikimedia.org/r/45677 (owner: 10Parent5446) [23:39:59] (03PS4) 10MarkTraceur: Stick the resource attribute into image elements [core] - 10https://gerrit.wikimedia.org/r/85926 [23:41:24] (03PS13) 10Parent5446: Added new MWTimestamp::getRelativeTimestamp for pure relative. [core] - 10https://gerrit.wikimedia.org/r/45677 [23:41:57] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/66366 (owner: 10Parent5446) [23:46:30] (03PS2) 10Amire80: Added rank column [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/85678 (owner: 10Mattsmith321) [23:47:55] quit [23:55:01] (03CR) 10CSteipp: [C: 032] "This seems to be mostly working in my test environment. Going to merge this for now, so new issues can be based on this." [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal) [23:55:20] (03CR) 10Amire80: [C: 031] "I tested it and it looks OK in RTL (I also added a Hebrew translation for complete testing). Forcing numbers to right-align and without fl" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/85678 (owner: 10Mattsmith321) [23:55:30] (03CR) 10Amire80: "s/has/have/" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/85678 (owner: 10Mattsmith321) [23:55:43] (03CR) 10CSteipp: [V: 032] almost final code [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal)