[00:29:08] <JeroenDeDauw>	 https://poser.pugx.org/mediawiki/core/version.png
[00:42:58] <grrrit-wm>	 (03CR) 10Legoktm: "(4 comments)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn)
[00:43:09] <legoktm>	 jackmcbarn: ^ just code style stuff, let me actually test it
[00:44:09] <jackmcbarn>	 legoktm: the copyright names are all real names and i dont want to put my real name
[00:44:24] <legoktm>	 you can just put "jackmcbarn"
[00:54:26] <legoktm>	 jackmcbarn: i also created https://www.mediawiki.org/wiki/Extension:SpamBlacklist/API
[00:55:16] <grrrit-wm>	 (03PS6) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 
[00:55:24] <jackmcbarn>	 legoktm: thanks
[00:59:49] <legoktm>	 jackmcbarn: now that that exists, you can override public function getHelpUrls() { return array('url'); }
[09:47:56] <grrrit-wm>	 (03PS6) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 
[09:48:17] <grrrit-wm>	 (03CR) 10Dan-nl: "(14 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl)
[10:56:52] <hashar>	 hello
[10:58:27] <T13|needsCoffee>	 Mornin has
[11:09:08] <grrrit-wm>	 (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT)... [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/60646 (owner: 10Hashar)
[11:10:09] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT)... [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/60646 (owner: 10Hashar)
[11:10:40] <hashar>	 PissedPanda: the notifications sent to #wikimedia-qa are missing colors :D
[11:11:01] <PissedPanda>	 hashar: they have colors, the channel is set to a mode that strips colors
[11:11:07] <hashar>	 ohhhhh
[11:11:12] <PissedPanda>	 hashar: I'm not too suer how to unset the mode. 
[11:11:15] <hashar>	 so works for me
[11:11:46] <PissedPanda>	 whee, hashar :)
[11:11:49] <PissedPanda>	 hashar: thanks for the patches
[11:11:55] <hashar>	 yw!
[11:12:47] <p858snake|l>	 its -C iirc
[11:13:27] <PissedPanda>	 hashar: ^
[11:15:54] <hashar>	 I get to take over the channel first :D
[11:16:50] <PissedPanda>	 hehe
[11:16:59] <PissedPanda>	 and then paint it with all the colors!
[11:35:35] <grrrit-wm>	 (03PS1) 10TTO: Provide nice new arrows to replace bad old [+] [-] [x] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 
[11:43:42] <grrrit-wm>	 (03CR) 10Peachey88: "um, wrong bug number?" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO)
[11:55:47] <grrrit-wm>	 (03PS2) 10TTO: Provide nice new arrows to replace bad old [+] [-] [x] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 
[12:04:31] <YuviPanda>	 Amgine_: also props to prtksxna, who designed the campaign pages :)
[12:05:02] <Amgine_>	 It's a sexy layout... much too cool for commons. srs.
[12:05:41] <YuviPanda>	 Amgine_: hehe :D 
[12:06:00] <prtksxna>	 Amgine_: Sexy :O
[12:06:04] <YuviPanda>	 Amgine_: imagine if category pages looked like that in the future
[12:07:03] <Amgine_>	 <blinks> Well, on commons... unless... <considers what txt articles could look like> well, yah, that'd excellent... widthing on popularity... 
[12:07:41] <Amgine_>	 Mmm, then tag-cloud-like weighting...
[12:07:52] * YuviPanda  gives Amgine_ a pipe, lets him dream

[12:08:13] <Amgine_>	 <laughs> Okay, so I'm exhuberant!
[12:08:46] <YuviPanda>	 :D
[12:50:58] <grrrit-wm>	 (03CR) 10Aklapper: "Patch works fine for me, but is there a reason to not integrate this into the existing SourceForge.pm file? Feels a bit weird to have two " [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm)
[12:52:04] <grrrit-wm>	 (03CR) 10Aklapper: "Ah, sorry for the -1 spam. Gerrit's interface confused me." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm)
[12:52:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Provide nice new arrows to replace bad old [+] [-] [x] [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO)
[12:53:07] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl)
[12:53:49] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/85441 (owner: 10Raimond Spekking)
[12:57:15] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85604 (owner: 10Rahul21)
[12:58:59] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85425 (owner: 10Rahul21)
[13:02:09] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Replace single to double-quotation marks [core] - 10https://gerrit.wikimedia.org/r/85515 (owner: 10Shirayuki)
[13:02:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Give grep a chance to find the usages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84970 (owner: 10Shirayuki)
[13:06:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace single to double-quotation marks [core] - 10https://gerrit.wikimedia.org/r/85515 (owner: 10Shirayuki)
[13:10:38] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 (owner: 10Raimond Spekking)
[13:11:09] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/84957 (owner: 10Raimond Spekking)
[13:15:11] <grrrit-wm>	 (03PS1) 10Pastakhov: fix for doble 'if' operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85666 
[13:22:50] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 (owner: 10saper)
[13:24:20] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] fix for doble 'if' operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85666 (owner: 10Pastakhov)
[13:24:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: fix for doble 'if' operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/85666 (owner: 10Pastakhov)
[13:33:53] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Changing default copyright notice per WMF Legal's suggestion. [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[13:33:57] <grrrit-wm>	 (03PS2) 10Raimond Spekking: Add missing message [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 
[13:36:31] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add missing message [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 (owner: 10Raimond Spekking)
[13:36:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing message [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 (owner: 10Raimond Spekking)
[13:37:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Changing default copyright notice per WMF Legal's suggestion. [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[13:53:00] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85153 (owner: 10Mattflaschen)
[14:40:59] <grrrit-wm>	 (03PS1) 10Alex Monk: Add maintenance script to restore missing log entries for each filter history entry [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 
[14:42:08] <grrrit-wm>	 (03PS2) 10Alex Monk: Add maintenance script to restore missing log entries for each filter history entry [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 
[14:46:27] <grrrit-wm>	 (03PS3) 10Alex Monk: Add maintenance script to restore missing log entries for each filter history entry [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 
[15:08:43] <grrrit-wm>	 (03Abandoned) 10BryanDavis: Add switch to log eventlogging-devserver output to file. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 (owner: 10BryanDavis)
[15:11:43] <grrrit-wm>	 (03CR) 10Helder.wiki: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 (owner: 10Alex Monk)
[15:14:39] <grrrit-wm>	 (03CR) 10Alex Monk: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 (owner: 10Alex Monk)
[15:22:02] <grrrit-wm>	 (03PS4) 10Alex Monk: Add maintenance script to restore missing log entries for each filter history entry [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/85675 
[15:23:18] <grrrit-wm>	 (03CR) 10Aaron Schulz: "(1 comment)" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/84911 (owner: 10Aaron Schulz)
[15:27:41] <grrrit-wm>	 (03PS1) 10Mattsmith321: Added rank column. Change-Id: If4da3aedb2a472150a93385bf2d349d16812603d [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/85678 
[15:35:36] <bd808>	 hashar: You asked me to remind you about https://bugzilla.wikimedia.org/show_bug.cgi?id=49884, so I am. :)
[15:38:23] <bd808>	 @seen dan-nl
[15:38:23] <wm-bot>	 bd808: Last time I saw dan-nl they were quitting the network with reason: Quit: dan-nl N/A at 9/21/2013 10:05:28 AM (2d5h32m55s ago)
[15:41:23] <helderwiki>	 MaxSem: what was this used for? https://gerrit.wikimedia.org/r/#/c/85651/1/wmf-config/InitialiseSettings.php,unified
[15:41:49] <helderwiki>	 (I mean, why the MobileFrontend needed to remove that and doesn't need anymore?)
[15:42:39] <helderwiki>	 I'm asking because the hiddenStructure class is still in use outside English Wikipedia (e.g. at ptwiki)
[15:52:51] <grrrit-wm>	 (03PS1) 10Pginer: CSS fix to avoid long labels to break project tile layout [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85680 
[15:54:02] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove extra / [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85111 (owner: 10Reedy)
[15:54:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove extra / [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85111 (owner: 10Reedy)
[15:55:05] <hashar>	 bd808: ah indeed math on jenkins
[15:55:53] <MaxSem>	 helderwiki, great! this way we will force you too to move out of it! :P
[15:56:00] <bd808>	 hashar: I don't think it's urgent, but it would be nice to have the jenkins tests actually execute instead of skipping
[15:56:01] <hashar>	 bd808: mind you, I have no idea how we recompile texvc in production :/  
[15:56:13] <grrrit-wm>	 (03PS2) 10Rahul21: Provide the link to the File page after the successfully uploading the pronunciation [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 
[15:56:14] <helderwiki>	 We are already, but it is taking too long
[15:56:32] <bd808>	 Nor do I. I know what I hacked into vagrant, but that's where my knowledge ends
[15:56:39] <helderwiki>	 MaxSem: https://pt.wikipedia.org/wiki/Wikip%C3%A9dia:Projetos/Padroniza%C3%A7%C3%A3o/hiddenStructure
[15:57:23] <hashar>	 bd808: $ dpkg -S scap-recompile
[15:57:23] <hashar>	 wikimedia-task-appserver: /usr/bin/scap-recompile
[15:58:12] <helderwiki>	 MaxSem: Should I expect that commit to break anything? 
[15:58:31] <helderwiki>	 (I could use this as one more reason not to use that classe :-)
[15:58:47] <MaxSem>	 helderwiki, you can do a local override in Mobile.css
[15:59:07] <grrrit-wm>	 (03PS3) 10Rahul21: Provide the link to the File page after the successfully uploading the pronunciation [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 
[15:59:21] <helderwiki>	 something like display: none?
[15:59:36] <bd808>	 hashar: I love that it installs to /usr/local/apache/uncommon
[15:59:36] <MaxSem>	 though at some point we should add display: block !important to it to prevent people from doing that terrible hack;)
[16:00:13] <AaronSchulz>	 csteipp: https://gerrit.wikimedia.org/r/#/c/85139/ small commit
[16:01:34] <helderwiki>	 Indeed, MaxSem  :-)
[16:01:50] <helderwiki>	 I proposed we did something like https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=81176060 on Portuguese Wikipedia, but some users didn't like the idea
[16:02:02] <helderwiki>	 (at least not before fixing the articles and templates)
[16:02:08] <hashar>	 bd808: yeah that is a crazy hack :-(
[16:02:19] <hashar>	 bd808: updated https://bugzilla.wikimedia.org/show_bug.cgi?id=49884#c4
[16:02:51] <hashar>	 bd808: I am not sure what to do. The script and the package dependencies (tex*) are provided by wikimedia-task-appserver package which we most probably don't want installed on the Jenkins box.
[16:03:11] <hashar>	 Krinkle: :)
[16:03:19] <Krinkle>	 I'm in the hangout
[16:03:23] <hashar>	 ahh
[16:03:38] * hashar  stops black sabbath

[16:04:35] <hashar>	 bd808: conf call, sent myself a self reminder, will ping ops list later tonight
[16:04:41] <bd808>	 hashar: I don't know if it helps, but my vagrant puppet config is at https://gerrit.wikimedia.org/r/#/c/84860/
[16:04:47] <bd808>	 hashar: sounds good
[16:05:04] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(7 comments)" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur)
[16:05:12] <hashar>	 bd808: basically we could copy paste the script + dependencies as a new puppet manifest
[16:05:24] <hashar>	 bd808: and clean up the wikimedia-task-appserver.  Not sure what ops want though
[16:05:43] * bd808  nods

[16:06:01] <hashar>	 bd808: yeah that role::math at https://gerrit.wikimedia.org/r/#/c/84860/ could land in operations/puppet . Feel free to amend the bug report
[16:06:07] <hashar>	 I am in a conf call with timo now
[16:10:09] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:10:33] <MaxSem>	 Krinkle, are you satisfied with ^^^ now?
[16:13:11] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Infrastructure for quotes turning off stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85383 (owner: 10Manybubbles)
[16:13:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Infrastructure for quotes turning off stemmer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85383 (owner: 10Manybubbles)
[16:13:17] <marktraceur>	 anomie: Thanks for the CR, I like meta=repoinfo better too :)
[16:13:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Turn test for sorted redirects back on. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85384 (owner: 10Manybubbles)
[16:13:34] <anomie>	 marktraceur: You're welcome!
[16:13:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Turn test for sorted redirects back on. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85384 (owner: 10Manybubbles)
[16:14:52] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Add Elastica to .gitignore due to clone location being into the extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85348 (owner: 10Reedy)
[16:14:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Elastica to .gitignore due to clone location being into the extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85348 (owner: 10Reedy)
[16:17:20] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85358 (owner: 10Aaron Schulz)
[16:22:32] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(10 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 (owner: 10Rahul21)
[16:28:55] <grrrit-wm>	 (03CR) 10MarkTraceur: "(5 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl)
[16:32:21] <grrrit-wm>	 (03PS1) 10Anomie: Add "Create accounts" grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85681 
[16:42:58] <grrrit-wm>	 (03PS4) 10Rahul21: Provide the link to the File page after the successfully uploading the pronunciation [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 
[16:44:13] <^d>	 brion: Wanna review something totally cool that will make mobile & search both very happy? :)
[16:44:33] <brion>	 sure!
[16:44:36] <brion>	 link it on up
[16:45:03] <^d>	 https://gerrit.wikimedia.org/r/#/c/84342/
[16:45:37] <marktraceur>	 csteipp: So, BetaFeatures is absolutely ready for security review
[16:46:54] <brion>	 ^d: does that need a corresponding change in MF?
[16:47:02] <brion>	 or does existing MF survive that change compatibly?
[16:47:24] <^d>	 Lemme double check. I want to say it's fine either way
[16:47:29] <brion>	 work checking ;)
[16:48:52] <csteipp>	 marktraceur: I'll try and get to it today.
[16:49:15] <marktraceur>	 Thanks!
[16:49:30] <brion>	  Fatal error: Call to undefined method MobileFormatterHTML::removeImages() in /Library/WebServer/Documents/core/extensions-all/MobileFrontend/includes/formatters/MobileFormatter.php on line 75
[16:50:46] <^d>	 Agh, I see what happened.
[16:50:54] <^d>	 In process of moving to core some stuff got renamed :)
[16:51:01] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "Breaks MobileFrontend:" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:51:35] <grrrit-wm>	 (03CR) 10Euvl: "Added documentation https://www.mediawiki.org/wiki/GSOC_2013_Improvement_of_glossary_tools#Documentation" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/82870 (owner: 10Euvl)
[16:51:52] <^d>	 Core classes always take priority over extension classes, so it's inheriting from something other than what it expects.
[16:52:03] <MaxSem>	 brion, obviously. but I need an agreed - upon interface to create a plumbing class, so merge to core first;)
[16:52:28] <brion>	 MaxSem: i'd prefer to land both patches at once if possible, but …. if that's what you guys want :)
[16:52:55] <^d>	 Easy workaround is just rename the class(es) in MF for now, let core land, then refactor MF as needed.
[16:52:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:53:03] <MatmaRex>	 ^d: ^
[16:53:35] <MaxSem>	 brion, I prefer to create class FormatterPlumbing extends HtmlFormatter { function removeImages() { $this->removeMedia(); } }
[16:54:48] <brion>	 MaxSem: sounds workable
[16:54:56] <brion>	 you want me to land core first?
[16:55:28] <grrrit-wm>	 (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:56:03] <MaxSem>	 brion, yes. otherwise, it will keep changing
[16:56:08] <brion>	 ok
[16:56:13] <ori-l>	 speaking of that... :P
[16:56:35] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Per IRC discussion with MaxSem, he prefers to land this first and then fix MobileFrontend to use the slightly different interface." [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:56:42] <brion>	 let's see what happens \o/
[16:56:55] <^d>	 Yay \o/
[16:57:14] <^d>	 Now I can land https://gerrit.wikimedia.org/r/#/c/85135/
[16:57:15] <^d>	 :)
[16:57:55] <MaxSem>	 thanks, Brion!:)
[16:58:17] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger)
[16:58:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:58:53] <MatmaRex>	 dammit, guys
[16:58:59] <MatmaRex>	 at least let someone review that stuff
[16:59:12] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032 V: 032] "Looks good" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 (owner: 10Rahul21)
[16:59:14] <MatmaRex>	 wtf is this: if ( wfIsWindows() ) { $html = str_replace( '&#13;', '', $html ); }
[16:59:27] <ori-l>	 wtfIsWindows()
[16:59:34] <MatmaRex>	 MaxSem: ^
[16:59:36] <MatmaRex>	 brion: ^
[16:59:48] <ori-l>	 caret: ^
[16:59:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[16:59:57] * MatmaRex  slaps ori-l around a bit with a large trout

[17:00:05] <ori-l>	 ok, i'll behave
[17:00:26] <MatmaRex>	 we have enough shitty uncommented code in core already
[17:00:36] <ori-l>	 but i have so much to give!
[17:00:56] * ori-l  sits down.

[17:01:14] <MatmaRex>	 code conventions seems to go out the window every time some wmf project "needs" something
[17:01:26] <MaxSem>	 MatmaRex, how 'bout attempting to understand the code before WTFing?
[17:01:27] <MatmaRex>	 Ve needs this, MobileFrontend needs that
[17:01:33] <brion>	 MatmaRex: it's existing code. you want to improve it, awesome
[17:01:35] <ori-l>	 MatmaRex: it's almost like real-world software development!
[17:01:43] <brion>	 but don't hold it up just to hold it up
[17:01:44] <MatmaRex>	 MaxSem: i would try to understand if i had more than two minutes for it
[17:02:07] <MaxSem>	 prolly you shouldn't CR it then. it was up for review for a week
[17:02:09] <MatmaRex>	 sadly i missed that patch existing in gerrit before
[17:02:14] <^d>	 And if it was a case of "we need this right naow" I would've just self-merged and not bothered asking for feedback.
[17:02:20] <MatmaRex>	 my fault, true
[17:02:27] <MatmaRex>	 i should add AutoLoader.php to my wathclist
[17:02:31] <MaxSem>	 that you noticed it 2 minutes ago is your problem, not everyone else's
[17:02:40] <MaxSem>	 sorry if I sound like a dick
[17:04:01] <^d>	 MaxSem: So, you've got between now and next wmf branch to fix MF :)
[17:04:25] <MaxSem>	 oh noes!
[17:04:32] <brion>	 MaxSem: got that fix yet? time's a-ticking ;)
[17:04:36] * MatmaRex  files a bug

[17:06:25] <Krenair>	 Reedy_, how did you reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=54254 ?
[17:07:35] <Krenair>	 hm, idle 25:39:41. maybe I should post on the gerrit changeset
[17:10:05] <grrrit-wm>	 (03CR) 10Mwjames: "Umm, well if you only want to check private methods you can to do this by (it is a 15 sec example, I haven't checked it):" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/82870 (owner: 10Euvl)
[17:11:43] <brion>	 MaxSem: how's this look? https://gerrit.wikimedia.org/r/85685
[17:13:11] <MaxSem>	 brion, that patch would mean that we'll have to merge the HF patch into all deployment branches
[17:13:28] <grrrit-wm>	 (03PS6) 10Rtdwivedi: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 
[17:14:08] <brion>	 MaxSem: if you don't have an alternate patch coming in the next few minutes, let me know and I'll undo the first merge
[17:14:54] <MaxSem>	 brion, standup's over, patching:)
[17:15:00] <brion>	 \o/
[17:15:04] <brion>	 brb must move cat
[17:15:09] <MartijnH>	 brion (and or-i, but I don't want to ping needlessly), thanks for the work on LESS
[17:15:23] <grrrit-wm>	 (03PS1) 10Rahul21: Fixed a few i18n issues and removed the "id" attribute [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 
[17:16:50] <MaxSem>	 move cat?:P
[17:17:12] <brion>	 handyman's here to work on the house, i gotta keep one of the cats upstairs so he doesn't run outside and get lost :)
[17:17:19] <mutante>	 i think he means literal cat, the animal, not a mediawiki category :)
[17:17:42] <^d>	 Category moves don't work that well anyway.
[17:17:58] <^d>	 manybubbles: Do you have anything you're working on that you want to make sure we get in before the deploy in ~3h?
[17:18:00] <mutante>	 heh, no
[17:18:42] <grrrit-wm>	 (03PS2) 10Rahul21: Fixed a few i18n issues and removed the "id" attribute [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 
[17:19:41] <grrrit-wm>	 (03CR) 10Alex Monk: "How do you reproduce the error that this patch fixes?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84703 (owner: 10Reedy)
[17:20:03] <MatmaRex>	 brion: it was existing code in MobileFrontend, not in core (until you merged it). clearly MobileFrontend has lower standards
[17:20:39] <ebernhardson>	 is there some sort of Option return type(like haskel Maybe) in mediawiki?  I feel like i saw one previously but cant remember the name
[17:22:00] <brion>	 hehe
[17:22:38] <MatmaRex>	 brion: MaxSem: ^d: https://bugzilla.wikimedia.org/show_bug.cgi?id=54473
[17:23:21] <MatmaRex>	 the elementsToFlatten thing is particularly insidious.
[17:26:02] <brion>	 MatmaRex: i'm adding some comments...
[17:26:29] <MaxSem>	 MatmaRex, doesn't support tags with attributes? have you actually tried it?
[17:29:16] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[17:30:44] <MatmaRex>	 MaxSem: do you want me to provide HTML that, when passed through HtmlFormatter that removes <script> tags, will yield <script> tags?
[17:31:12] <MaxSem>	 MatmaRex, HF is for parser output only
[17:31:27] <MatmaRex>	 MaxSem: i realized that when i saw that regex, ofcourse
[17:31:32] <manybubbles>	 ^d: no
[17:31:37] <MatmaRex>	 it doesn't say it anywhere, though
[17:31:38] <MaxSem>	 it had never been designed for anything else, but patches are welcome!
[17:31:44] <MatmaRex>	 that's while i filed a documentation bug
[17:31:48] <MatmaRex>	 why*
[17:31:52] <manybubbles>	 ^d: I was working on an issue in Elasticsearch this morning
[17:31:56] <^d>	 Mmk.
[17:32:15] <brion>	 MatmaRex: are you referring to the 'elementsToFlatten' transformation?
[17:32:16] <brion>	 that's the only regex-related one i see
[17:32:51] <MatmaRex>	 yeah
[17:33:04] <brion>	 'Adds one or more element name to the list to flatten (remove tag, but not its content)'
[17:33:10] <brion>	 definitely not suitable for usage on script tags
[17:33:16] <MatmaRex>	 i assume parser escapes < and > in attribute values, but i don't think it's stirctly required to
[17:34:13] <MatmaRex>	 brion: that's why i filed a documentation bug, not a security bug.
[17:34:19] <MatmaRex>	 it's still a bug.
[17:34:48] <brion>	 sure, that's why i'm trying to figure out what the bug actually is so i can document it
[17:34:52] <grrrit-wm>	 (03CR) 10Legoktm: "The existing SourceForge.pm is not a Wikimedia modification, and I was unsure about what the guidelines were on editing existing files fro" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/85399 (owner: 10Legoktm)
[17:34:54] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] "The code looks good to me, but I don't have a machine setup to test it." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/84911 (owner: 10Aaron Schulz)
[17:36:08] <MatmaRex>	 brion: it fails when attribute values contain literal '>' or when applying the regex results in new valid tags appearing in the source
[17:37:07] <MatmaRex>	 maybe in other cases too
[17:38:00] <MatmaRex>	 it might fail when there are newlines between the < and > in a tag, i forgot what the PHP flags for dot-matches-newlines are
[17:38:11] <MaxSem>	 MatmaRex, now find me a case when Sanitizer outputs attributes with a literal ">";)
[17:38:26] <MatmaRex>	 <MatmaRex> that's why i filed a documentation bug
[17:38:40] <MatmaRex>	 MaxSem: that said, it's likely that some extensions might output such tags
[17:39:19] <MatmaRex>	 we have like a hundred different ones enabled on wikimedia wikis alone
[17:39:22] <brion>	 hmmm, remind me : is literal ">" allowed in quoted attribute values? (or "allowed" by html5 parsing rules")
[17:39:32] <MaxSem>	 as I've already said, patches are welcome!
[17:39:33] <MatmaRex>	 brion: it will parse and work, validator will probably complain
[17:44:14] <grrrit-wm>	 (03PS1) 10Brion VIBBER: bug 54473: doc fixes for HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85687 
[17:44:31] <brion>	 MatmaRex, MaxSem: there's a first pass at updating doc comments
[17:47:00] <grrrit-wm>	 (03CR) 10Raimond Spekking: "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85643 (owner: 10Rahul21)
[17:47:49] <grrrit-wm>	 (03PS1) 10KartikMistry: WIP: Added integration tests boiler plate for TwnMainPage. [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85688 
[17:48:40] <grrrit-wm>	 (03CR) 10Reedy: "I didn't. I just added protection to make sure the item that was giving the non-object wouldn't be called if it was." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84703 (owner: 10Reedy)
[17:51:26] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] bug 54473: doc fixes for HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85687 (owner: 10Brion VIBBER)
[17:52:32] <grrrit-wm>	 (03PS2) 10Krinkle: bug 54473: doc fixes for HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85687 (owner: 10Brion VIBBER)
[17:52:41] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix doc for HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85687 (owner: 10Brion VIBBER)
[17:57:41] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Change Ie0e05a4c45181e608f5143dd1f9370fcc45fff06 on mediawiki/extensions/MobileFrontend updated MF to use the slightly modified core versi" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[17:58:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix doc for HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85687 (owner: 10Brion VIBBER)
[17:58:59] <brion>	 \o/
[17:59:39] <grrrit-wm>	 (03PS1) 10Chad: Cirrus to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85690 
[17:59:56] <grrrit-wm>	 (03CR) 10Chad: [C: 032 V: 032] Cirrus to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85690 (owner: 10Chad)
[18:01:28] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[18:05:37] <grrrit-wm>	 (03CR) 10Mattflaschen: "(3 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 (owner: 10Rahul21)
[18:15:43] <grrrit-wm>	 (03CR) 10Jdlrobson: "We could swap the h3 out for a strong tag." [core] - 10https://gerrit.wikimedia.org/r/83429 (owner: 10Jdlrobson)
[18:19:21] <Reedy>	 manybubbles: ^demon
[18:19:28] <Reedy>	 Sep 23 18:03:52 10.64.32.41 apache2[31548]: PHP Fatal error:  require_once() [<a href='function.require'>function.require</a>]: Failed opening required '/usr/local/apache/common-local/php-1.22wmf17/extensions/Elastica/Elastica.php' (include_path='/usr/local/apache/common-local/php-1.22wmf17/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/usr/local/apache/common-local/php-1.22wmf17:/usr/local/lib/php:/usr/share/php') in 
[18:19:28] <Reedy>	 /usr/local/apache/common-local/wmf-config/CirrusSearch-common.php on line 14
[18:19:32] <Reedy>	 Only on that apache seemingly..
[18:20:00] <Reedy>	 Noting wmf17 doesn't have it
[18:20:17] <Reedy>	 require_once( "$IP/extensions/Elastica/Elastica.php" );
[18:20:21] <grrrit-wm>	 (03PS3) 10Rahul21: Fixed a few i18n issues and removed the "id" attribute [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 
[18:20:23] <Reedy>	 https://noc.wikimedia.org/conf/highlight.php?file=CirrusSearch-common.php
[18:20:37] * Reedy  wraps in file_exists for the moment

[18:28:30] <^demon>	 What 1.17 wiki has it?
[18:28:35] <^demon>	 wmf17, rather?
[18:29:43] <grrrit-wm>	 (03CR) 10Mattflaschen: "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 (owner: 10Rahul21)
[18:30:03] <grrrit-wm>	 (03PS7) 10Kaldari: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 
[18:30:04] <^demon>	 Why is itwiktionary back on 1.22wmf17?
[18:30:09] <^demon>	 I moved it to 18 on purpose.
[18:30:18] <Reedy>	 no idea
[18:30:29] <Reedy>	 wiktionaries are all going to wmf18 now anyway
[18:31:30] <^demon>	 Hmm, nevermind...my local copy was outdated.
[18:32:03] <ori-l>	 Nemo_bis: which wikis have crazy JS in the mw: namespace?
[18:32:29] <^demon>	 Reedy: Only that apache? Which apache?
[18:32:34] <^demon>	 Sounds like something didn't get sync'd.
[18:32:40] <Reedy>	 10.64.32.41
[18:32:46] <Reedy>	 I ran sync-common on it manually, twice
[18:32:56] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari)
[18:32:57] <Reedy>	 But the file isn't there on tin etc for wmf17
[18:33:06] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] CSS fix to avoid long labels to break project tile layout [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85680 (owner: 10Pginer)
[18:33:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari)
[18:33:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: CSS fix to avoid long labels to break project tile layout [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85680 (owner: 10Pginer)
[18:33:29] <^demon>	 Reedy: Well yes. Which comes back to my original question: what wmf17 wiki is using Cirrus?
[18:33:55] <Reedy>	 Dunno
[18:35:15] <Reedy>	 officewiki apparently
[18:35:29] <Reedy>	 [23-Sep-2013 18:03:52] Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required '/usr/local/apache/common-local/php-1.22wmf17/extensions/Elastica/Elastica.php' (include_path='/usr/local/apache/common-local/php-1.22wmf17/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/usr/local/apache/common-local/php-1.22wmf17:/usr/local/lib/php:/usr/share/php') at /usr/local/apache/common-
[18:35:29] <Reedy>	 local/wmf-config/CirrusSearch-common.php on line 14
[18:35:29] <Reedy>	 Server: mw1171
[18:35:29] <Reedy>	 Method: GET
[18:35:31] <Reedy>	 URL: http://office.wikimedia.org/w/index.php?title=MediaWiki:ImageAnnotatorConfig.js&action=raw&ctype=text/javascript&dummy=95830
[18:37:16] <^demon>	 I turned it off on officewiki for other reasons.
[18:37:22] <^demon>	 Should be commented out.
[18:40:04] <grrrit-wm>	 (03PS5) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:40:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:40:34] <grrrit-wm>	 (03PS6) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:40:48] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Not quite ready on the mobile end yet." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/73529 (owner: 10Kaldari)
[18:41:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:42:34] <grrrit-wm>	 (03PS7) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:44:36] <grrrit-wm>	 (03CR) 10CSteipp: "It seemed to me like the consumer object *should* keep track of the private key. But adding it to the signature is fine too. I'll update i" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 (owner: 10CSteipp)
[18:46:35] <grrrit-wm>	 (03PS4) 10Rahul21: Fixed a few i18n issues and removed the "id" attribute [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 
[18:47:08] <grrrit-wm>	 (03PS8) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[18:47:20] <grrrit-wm>	 (03PS2) 10Catrope: When a module is blocking (position=top), never defer its execution [core] - 10https://gerrit.wikimedia.org/r/75270 
[18:48:30] <grrrit-wm>	 (03PS3) 10Catrope: When a module is blocking (position=top), never defer its execution [core] - 10https://gerrit.wikimedia.org/r/75270 
[18:54:42] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Try catch to avoid adBlock problems [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/85702 
[18:56:44] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Bump to 1.1 alpha [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85703 
[18:56:45] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update docs [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85704 
[18:56:46] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Add parsing option to the runners [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85705 
[18:57:01] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032 V: 032] "Works" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 (owner: 10Rahul21)
[18:57:16] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Bump to 1.1 alpha [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85703 (owner: 10Jeroen De Dauw)
[18:57:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add parsing option to the runners [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85705 (owner: 10Jeroen De Dauw)
[18:57:22] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Update docs [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85704 (owner: 10Jeroen De Dauw)
[18:57:34] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Add parsing option to the runners [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85705 (owner: 10Jeroen De Dauw)
[18:57:40] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [V: 032] Add parsing option to the runners [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85705 (owner: 10Jeroen De Dauw)
[18:58:37] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Fix test case [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85706 
[18:58:47] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Fix test case [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/85706 (owner: 10Jeroen De Dauw)
[19:00:04] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 (owner: 10Rtdwivedi)
[19:03:20] <grrrit-wm>	 (03CR) 10Aaron Schulz: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:05:34] <hashar>	 re
[19:06:08] <grrrit-wm>	 (03PS9) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:06:09] <grrrit-wm>	 (03PS2) 10Awjrichards: added additional logic to grep the output file for Story and Bug [tools/release] - 10https://gerrit.wikimedia.org/r/75280 (owner: 10Mgrover)
[19:06:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:06:18] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:06:32] <brion>	 ori-l: ^ looks pretty good; only a couple minor nits
[19:06:46] <ori-l>	 cool, looking
[19:07:03] <grrrit-wm>	 (03PS10) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:07:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:07:21] <ori-l>	 brion: I had the path in DefaultSettings.php but Krinkle pointed out that LocalSettings.php is allowed to change $IP
[19:07:26] <ori-l>	 so I'll document it
[19:07:32] <brion>	 hmm
[19:07:40] <brion>	 is it allowed to change $IP after loading DefaultSettings.php?
[19:07:46] <brion>	 cause i'm pretty sure that would fuck shit up if you did that
[19:07:58] <ori-l>	 probably, because there are other paths in DefaultSettings.php that reference $IP
[19:08:22] <grrrit-wm>	 (03CR) 10Awjrichards: "wtf... having some git troubles..." [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:08:24] <ori-l>	 which Timo noticed, but I think he still preferred not to exacerbate the problem
[19:08:47] <ori-l>	 which do you prefer? (document or relocate back, that is)
[19:09:03] <grrrit-wm>	 (03PS11) 10Awjrichards: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:09:22] <brion>	 ori-l: i prefer relocate back, but doc is fine too
[19:09:29] <brion>	 what matters is that it works :)
[19:09:37] <brion>	 and doesn't surprise people :D
[19:09:38] <grrrit-wm>	 (03CR) 10Awjrichards: "There we go. Directory renamed to git-logs, addressed hashar's comments." [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover)
[19:09:46] <ori-l>	 I prefer not having it in two places too, so if I can blame the decision on you I'll move it
[19:09:54] <brion>	 haha
[19:09:59] <brion>	 works for me
[19:10:34] * ori-l  takes a photo of his computer display next to today's newspaper

[19:11:05] <grrrit-wm>	 (03CR) 10CSteipp: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:12:08] <MaxSem>	 csteipp, lol "patch before it goes into production" - it was for 2 years;)
[19:12:23] <MaxSem>	 now it's just in a different directory
[19:12:48] <MaxSem>	 but yeah, needs to be fixed before someone uses it for something other than parser output
[19:12:51] <MaxSem>	 :)
[19:12:52] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:15:34] <grrrit-wm>	 (03PS2) 10CSteipp: Better support for RSA Key clients [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 
[19:15:35] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Fix missing wfProfileOut call in HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85708 
[19:15:56] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:16:05] <ori-l>	 brion: re: $wgShowExceptionDetails, that's a subtle point. You'd have to wait 5 minutes for it to fall out of the cache. a) is that OK? b) should I document it in a comment or the generated error?
[19:16:29] <brion>	 a) no that's pretty not ok :(   b) in the error if there's no workaround
[19:16:37] <brion>	 one possibility is to check against $wgCacheEpoch
[19:16:50] <brion>	 since that by default updates when you touch LocalSettings.php, that's a good catch for config changes too
[19:16:53] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix missing wfProfileOut call in HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85708 (owner: 10Brion VIBBER)
[19:17:09] <ori-l>	 brion: what about factoring $wgShowExceptionDetails into the cache key?
[19:17:19] <ori-l>	 so that if it changes, the cache is invalidated?
[19:17:21] <brion>	 ori-l: yeah that'd work too
[19:17:28] <ori-l>	 cool.
[19:17:36] <brion>	 ori-l: i recommend breaking out the cache-key generation to a function so it's easier to see where that comes from :)
[19:18:14] <grrrit-wm>	 (03PS1) 10MaxSem: libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 
[19:18:29] <brion>	 whee
[19:18:31] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 (owner: 10MaxSem)
[19:18:40] <brion>	 heh… disable -> true
[19:18:50] <MaxSem>	 omg self-merges!
[19:19:00] <brion>	 i would have +2d that for ya ;)
[19:19:51] <grrrit-wm>	 (03PS7) 10Rtdwivedi: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 
[19:20:20] <grrrit-wm>	 (03PS1) 10Ebrahim: Native digits for human timestamp [core] - 10https://gerrit.wikimedia.org/r/85711 
[19:22:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix missing wfProfileOut call in HtmlFormatter [core] - 10https://gerrit.wikimedia.org/r/85708 (owner: 10Brion VIBBER)
[19:23:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 (owner: 10MaxSem)
[19:25:38] <grrrit-wm>	 (03CR) 10Brion VIBBER: "This looks wrong to me; Language::formatNum() is meant to take a number or numeric string, but if I'm reading this correctly $ts is alphan" [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim)
[19:26:05] <grrrit-wm>	 (03PS2) 10MaxSem: libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 
[19:31:04] <grrrit-wm>	 (03CR) 10CSteipp: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:31:35] <MatmaRex>	 lol MaxSem
[19:32:26] <grrrit-wm>	 (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:33:43] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(I filed my comments to this as bug 54473, now fixed.)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem)
[19:37:04] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update dependencies in composer.json [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85714 
[19:40:56] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 (owner: 10MaxSem)
[19:44:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: libxml_disable_entity_loader() just in case... [core] - 10https://gerrit.wikimedia.org/r/85709 (owner: 10MaxSem)
[19:44:31] <grrrit-wm>	 (03PS35) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[19:45:23] <grrrit-wm>	 (03PS36) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[19:47:45] <grrrit-wm>	 (03CR) 10Ori.livneh: "PS35:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:47:51] <ori-l>	 brion: ^
[19:47:59] <brion>	 whee
[19:48:19] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update readme [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85763 
[19:49:11] <brion>	 hmm
[19:49:16] <grrrit-wm>	 (03PS11) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[19:49:24] <ori-l>	 (rebase)
[19:49:38] <brion>	 ori-l: why is getLESSCacheKey defined on ResourceLoaderModule when it's dependent on filenames, which are specific to ResourceLoaderFileModule?
[19:49:38] <ori-l>	 brion: no hmms! hmms bad!
[19:49:59] <ori-l>	 brion: because it seems like LESS support could plausibly be extended to non-files at some point
[19:50:10] <ori-l>	 I wouldn't mind renaming the parameter
[19:50:22] <brion>	 well, it would have different cache keys i assume if it had different sources
[19:50:28] <brion>	 i wouldn't expect them to use the same key
[19:50:53] <ori-l>	 hmm, that's a good point.
[19:50:59] <ori-l>	 OK, relocating.
[19:51:18] <grrrit-wm>	 (03CR) 10Ebrahim: "@Brion VIBBER: Thanks for review. Can you fix it? It is okay if you want rewrite the patch totally and even removing my name from it." [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim)
[19:51:49] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Clean up extra temp files that build up on the servers [extensions/timeline] - 10https://gerrit.wikimedia.org/r/84911 (owner: 10Aaron Schulz)
[19:52:17] <grrrit-wm>	 (03CR) 10Aaron Schulz: [V: 032] "Tested manually" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/84911 (owner: 10Aaron Schulz)
[19:52:20] <matanya>	 is kaladri around?
[19:54:38] <matanya>	 jorm: echo issue :) can you have a look please?
[19:54:49] <jorm>	 what's up?
[19:55:00] <matanya>	 hi there
[19:55:06] <matanya>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=54343
[19:55:28] <grrrit-wm>	 (03PS37) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[19:55:31] <jorm>	 nice.  i'll point benny at it.
[19:55:31] <matanya>	 this ^ is very annoying for a few users of RTL langs 
[19:55:36] <jorm>	 bsitu, maryana: ^
[19:56:08] <matanya>	 gladly, i don't use IE nor monobook, but supprisingly many people do
[19:56:28] <matanya>	 Thanks a lot jorm :)
[19:56:41] <grrrit-wm>	 (03CR) 10Ori.livneh: "PS37: Move getLESSCacheKey to from ResourceLoaderModule to ResourceLoaderFileModule, since it is specific to LESS *file* compilation." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:56:49] <ori-l>	 ^ brion
[19:56:59] <ori-l>	 remember: no hmms!
[19:57:05] <ori-l>	 hmms very bad!
[19:57:06] <jorm>	 np, matanya
[19:57:14] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Factored out a small filebackend getContentType() function [core] - 10https://gerrit.wikimedia.org/r/85765 
[19:57:45] <^demon>	 ori-l: That's how brion tells you it's wrong ;-)
[19:57:49] <grrrit-wm>	 (03CR) 10Mwalker: "(1 comment)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85426 (owner: 10Tpt)
[19:57:53] <^demon>	 "Hmm...so this isn't going to work..."
[19:58:11] <ori-l>	 thus: no hmms!
[19:58:32] <brion>	 looks good :D checking out for final test
[19:58:33] <^demon>	 We've all got to have our share of hmms :)
[19:59:07] <grrrit-wm>	 (03PS12) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[19:59:12] <ori-l>	 (rebase ^)
[19:59:47] <^demon>	 So, I've seen all this talk about LESS CSS for core.
[19:59:50] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] ""Less is more!" Dropping the +2 hammer on this. WHEE!!!!!" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:59:54] <^demon>	 What about those of us who want less CSS period?
[19:59:58] <ori-l>	 YAYYY
[20:00:06] <brion>	 ^demon: git rm
[20:00:11] <ori-l>	 WOoOOOOO
[20:00:23] <brion>	 ok and lemme check the image embedding...
[20:00:24] <^demon>	 brion: I git rm all the time, but more people like git add.
[20:00:29] <^demon>	 I think I'm losing the battle.
[20:00:43] <brion>	 ^demon: just remove all the comments, the codebase will be a lot smaller
[20:00:54] <^demon>	 Then we'll never fix bug 1 :(
[20:01:32] <ori-l>	 brion: i just walked over to your desk so i can spin you in your chair and jump up and down and say thank you
[20:01:36] <ori-l>	 but you're not around :(
[20:01:41] <brion>	 haha
[20:01:52] <brion>	 welcome…. to local remoteness
[20:02:13] <ori-l>	 git remote set-url origin /projects/local/path
[20:02:52] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Going ahead and landing this along with Id052a04dd2f76a1f4aef39fbd454bd67f5fd282f ... if there's any objections to the function naming let" [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[20:03:21] <ori-l>	 wooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooot.
[20:05:00] <MatmaRex>	 hell's frozen over
[20:05:56] <spagewmf>	 well done!
[20:06:01] <ori-l>	 :)
[20:06:13] <ori-l>	 thanks very much to all reviewers
[20:06:13] <^demon>	 Now my goal of ripping all CSS out of MediaWiki will never come true! :(
[20:07:03] <brion>	 :)
[20:07:36] <AaronSchulz>	 csteipp: for https://gerrit.wikimedia.org/r/#/c/85128/2 why would someone use the MW classes?
[20:08:44] <hashar>	 brion: ori-l: \O/ :-]
[20:08:51] <hashar>	 less is good!
[20:10:16] <csteipp>	 AaronSchulz: Because have to do the same thing if they use their own?
[20:10:41] <AaronSchulz>	 wouldn't they use the base classes?
[20:10:42] <csteipp>	 But yeah, it could be done in another class
[20:10:55] <Tpt__>	 mwalker: Hi! Just a (maybe silly) question about your comment here: https://gerrit.wikimedia.org/r/#/c/85426/1/engines/LuaCommon/JsonLibrary.php You are talking about the interface of the PHP class or the Lua interface of functions implemented in PHP?
[20:10:58] <ori-l>	 hashar: :D
[20:11:16] <csteipp>	 Right, the library doesn't come with a concrete class for rsa signature
[20:11:20] <hashar>	 brion: ori-l: now get the mobilefrontend less patch merged in and you will get it on beta :-D
[20:12:10] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Decrease dependencies in some tests [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85767 
[20:12:11] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Set main NS to have subpages in test run [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85768 
[20:12:18] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update dependencies in composer.json [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85714 (owner: 10Jeroen De Dauw)
[20:12:26] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update readme [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85763 (owner: 10Jeroen De Dauw)
[20:12:37] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Decrease dependencies in some tests [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85767 (owner: 10Jeroen De Dauw)
[20:12:44] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Set main NS to have subpages in test run [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85768 (owner: 10Jeroen De Dauw)
[20:14:42] <AaronSchulz>	 csteipp: not sure it's worth it though
[20:15:20] <AaronSchulz>	 they'd just need to subclass the base class so fetch_private_cert() returns the cert and fetch_public_cert() returns the public cert (or does nothing)
[20:16:09] <AaronSchulz>	 "return $this->store->getRSAKey( $consumerKey );" would probably not be useful for fetch_public_cert(), so that would have to be unused or overridden anyway
[20:16:26] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "As mentioned, this doesn't work, since the return value of MWTimestamp::getHumanTimestamp() is the final timestamp, not a number." [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim)
[20:20:44] <grrrit-wm>	 (03PS2) 10Aaron Schulz: lockmanager: QuorumLockManager subclasses can now EX/SH locks at once [core] - 10https://gerrit.wikimedia.org/r/69021 
[20:21:02] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update docs [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/85769 
[20:21:51] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "Code looks sane, haven't tested." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 (owner: 10CSteipp)
[20:25:04] <AaronSchulz>	 meh
[20:25:08] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Better support for RSA Key clients [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 (owner: 10CSteipp)
[20:25:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better support for RSA Key clients [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 (owner: 10CSteipp)
[20:25:41] <mwalker>	 Tpt__: lua interface of functions implemented in php; maybe I just missed something; but it looked like there was no way to namespace your php.encode/decode() calls in mw.json.lua -- unless that is somehow automagically namespaced which would be cool
[20:28:12] <Tpt__>	 mwalker: I believe that only the functions of the current module are loaded by php = mw_interface (but I may have wrong). In that case there won't be any issues. The other modules doesn't adds namespaces to their functions
[20:28:25] <grrrit-wm>	 (03CR) 10Ebrahim: "@Parent5446: You are right, I just traced the bug I see on Persian Wikipedia http://imgur.com/hi4uPTW (21 should be ۲۱ on Persian Wikipedi" [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim)
[20:30:05] <mwalker>	 Tpt__: if so -- yay! intelligence! write that in a comment reply and I'll +1; tim or brad will still have to +2 it
[20:32:44] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Added a loop sanity check to $wgMWOAuthSecureTokenTransfer redirect [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85771 
[20:32:51] <grrrit-wm>	 (03CR) 10Tpt: "(1 comment)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85426 (owner: 10Tpt)
[20:33:07] <Tpt__>	 mwalker: Done. Thanks :-)
[20:35:55] <grrrit-wm>	 (03CR) 10Mwalker: [C: 031] "(1 comment)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85426 (owner: 10Tpt)
[20:43:36] <grrrit-wm>	 (03PS1) 10Reedy: Update UploadWizard to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85772 
[20:44:03] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update UploadWizard to master [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85772 (owner: 10Reedy)
[20:45:09] <marktraceur>	 Sorry about that, Reedy, I'd meant to update it before it got rolled out and forgot :(
[20:45:56] <Reedy>	 np
[20:46:06] <Reedy>	 I just touched everything in the dir for good luck ;)
[20:46:13] <marktraceur>	 Usually a good plan...
[20:46:24] <marktraceur>	 Bloody UploadWizard always seems to get caching troubles when it deploys
[20:47:01] <Reedy>	 Uncaught Error: Unknown dependency: schema.UploadWizardTutorialActions load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki%2CSpinner%7Cjque…%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130919T174450Z:150
[20:48:44] <marktraceur>	 Still?
[20:48:52] <marktraceur>	 Grumble grumble
[20:49:25] <marktraceur>	 Reedy: It's on testwiki now?
[20:49:53] <marktraceur>	 Because I see it working
[20:49:55] <Reedy>	 Should be...
[20:50:17] <Reedy>	 Working now for me too
[20:50:21] <marktraceur>	 Huzzah
[20:50:23] <Reedy>	 bits caching presumably
[20:51:45] <marktraceur>	 Frickin' caching
[20:51:48] <marktraceur>	 Ruins everything
[21:00:39] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "L10n looks fine. i18n may be fine, but I cannot assess." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis)
[21:02:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1 V: 04-1] "Needs rebase." [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff)
[21:06:49] <Krenair>	 YuviPanda, how come https://github.com/wikimedia/mediawiki-core/pull/11 didn't get transferred to Gerrit?
[21:10:42] <grrrit-wm>	 (03CR) 10Siebrand: "Thanks." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85686 (owner: 10Rahul21)
[21:11:25] <gwicke_away>	 AaronSchulz: https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage#History_compression
[21:12:17] <superm401>	 ori-l, congrats on getting LESS merged.
[21:12:40] <superm401>	 To quote Joe Biden, ""this is a big f*ng deal""
[21:12:55] <ori-l>	 hahaha
[21:13:11] <StevenW>	 Was this brion https://www.mediawiki.org/w/index.php?title=Requests_for_comment%2FLESS&diff=789288&oldid=788424 ?
[21:13:30] <Reedy>	 heh
[21:15:12] <grrrit-wm>	 (03PS4) 10EBernhardson (WMF): See that a post has been edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 
[21:16:11] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl)
[21:18:55] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/85678 (owner: 10Mattsmith321)
[21:19:01] <brion>	 it's really time to kill IP editing dudes
[21:20:31] <ebernhardson>	 it will never die, it will just be called anon editing instead :P
[21:22:18] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 031] "The change looks fine, I'm not so sure about the commit message though :) It's not clear what the motivation is for moving the defaults f" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/85329 (owner: 10Bsitu)
[21:27:22] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] "I agree that the change looks fine, but I'm not sure what the reason for moving it is. Could you explain that in more detail?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/85329 (owner: 10Bsitu)
[21:28:08] <superm401>	 Will it cause a problem that $wgResourceLoaderLESSImportPaths was moved back to DefaultSettings?
[21:28:14] <superm401>	 Per Krinkle's comment at https://gerrit.wikimedia.org/r/#/c/78669/17..37/includes/DefaultSettings.php .
[21:28:49] <superm401>	 Though I suppose it's inconsistent already, per his examples, so just one more to override if you change $IP.
[21:28:56] <MatmaRex>	 per the second part of his comment, probably not
[21:29:04] <MatmaRex>	 ah, foiled. :)
[21:29:10] <superm401>	 ^ ori-l
[21:29:31] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Update to CLDR 24 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy)
[21:29:33] <MatmaRex>	 hey spagewmf, why are seemingly all Echo bugs now being mingled?
[21:29:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update to CLDR 24 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy)
[21:29:43] <Reedy>	 yay
[21:29:51] <MatmaRex>	 (and in particular, why are they mingled under the 'flow' project?)
[21:29:56] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Update indenting to use tabs (updated rebuild.php) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84906 (owner: 10Reedy)
[21:30:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update indenting to use tabs (updated rebuild.php) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84906 (owner: 10Reedy)
[21:30:22] <ori-l>	 superm401 / MatmaRex: https://dpaste.de/QvVHi/raw/
[21:30:44] <ori-l>	 this was on here on -dev, about two and a half hours ago
[21:31:02] <MatmaRex>	 heh
[21:31:35] <superm401>	 ori-l, ostensibly it's still allowed, just not "needed".
[21:31:38] <superm401>	 https://www.mediawiki.org/wiki/Manual:$IP
[21:31:53] <superm401>	 Maybe we should just say "Don't do that then".
[21:31:57] <ebernhardson>	 MatmaRex: short answer:  the flow mingle install is actually the corefeatures mingle 
[21:32:50] <ori-l>	 dunno, I don't know enough about non-WMF deployments and how they use $IP to say
[21:33:28] <MatmaRex>	 ebernhardson: hmm. okay. was Echo transferred to a different group of people? or did somebody new adopt mingle?
[21:33:29] <MatmaRex>	 (just wondering)
[21:33:38] <ebernhardson>	 MatmaRex: the ee team was renamed core features
[21:33:44] <ebernhardson>	 MatmaRex: and the core features team still maintains Echo :)
[21:33:47] <MatmaRex>	 yeah, this i've heard of :)
[21:33:55] <MatmaRex>	 last time i asked, it was only bsitu working on it
[21:34:14] <ebernhardson>	 MatmaRex: then i'm not sure what the question is?  Flow was always an ee project, so was Echo.  Naming the mingle board 'flow' is just a naming issue
[21:34:15] <MatmaRex>	 i've never seen mingle being linked from the Echo bugs, so i was curious
[21:34:40] <ebernhardson>	 MatmaRex: because the ee team never before used mingle :)
[21:35:01] <MatmaRex>	 right. okay, all's clear now :)
[21:40:25] <grrrit-wm>	 (03PS3) 10Reedy: Add myself to authors (maintenance done etc) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84938 
[21:42:33] <grrrit-wm>	 (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 (owner: 10Anomie)
[21:42:51] <grrrit-wm>	 (03CR) 10Bsitu: "'echo-subscriptions-web-edit-thank' and 'echo-subscriptions-email-edit-thank' preferences have no meaning to the users unless 'edit-thank'" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/85329 (owner: 10Bsitu)
[21:45:16] <superm401>	 $IP todo: https://bugzilla.wikimedia.org/show_bug.cgi?id=54483
[21:45:17] <spagewmf>	 ebernhardson thx for explaining it to MatmaRex. Since the same WMF engineers maintaining Echo (and Page curation) are working on Flow, it makes sense to prioritize them along with Flow work.
[21:45:25] <grrrit-wm>	 (03Abandoned) 10Bsitu: Echo subscription should be set after category definition [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/85329 (owner: 10Bsitu)
[21:49:24] <cscott>	 is echo the notifications stuff on en.wiki?
[21:49:40] <cscott>	 are there any plans for push-type notifications (ie, not requiring page reload)?
[21:54:05] <grrrit-wm>	 (03PS1) 10Ori.livneh: Rename lessc->embeddedImages to lessc->embeddedFiles [core] - 10https://gerrit.wikimedia.org/r/85775 
[21:54:26] <MatmaRex>	 cscott: yes, that's the stuff, and it's on a few other wikis too
[21:54:58] <cscott>	 is it easy to install?  i think i'd like to integrate togetherjs's invite system w/ wp notifications
[21:55:22] <ebernhardson>	 cscott: i dont think there have been any plans for push-type notifications, as that would require push infrastructure first
[21:55:24] <MatmaRex>	 as in, on your wiki? for me it Just Worked
[21:55:38] <cscott>	 yeah, on my wiki.
[21:55:42] <ebernhardson>	 cscott: once infrastructure is in place to push data to user browsers, integrating echo with it should be very simple (its already strictly API based)
[21:56:30] <ebernhardson>	 i've heard a few brief chats between engineers about pushing data to users browsers, but nothing at the implementation stage
[21:57:24] <cscott>	 hm, ok.
[21:57:32] <cscott>	 https://www.mediawiki.org/wiki/Extension:Echo right?
[21:57:48] <MatmaRex>	 yep
[21:57:49] <ebernhardson>	 cscott: yup, thats the one
[21:58:11] <cscott>	 wow, lots of configuration options.  hopefully the defaults are sane?
[21:58:13] <grrrit-wm>	 (03PS1) 10Anomie: Fix secure handling in setGlobalCookies [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/85776 
[21:58:38] <ebernhardson>	 cscott: heh, yea :)  You can actually create new notifications just by tweaking those config variables,  but for a default install just leave as is
[22:01:36] <superm401>	 spagewmf, mind if I broaden https://bugzilla.wikimedia.org/show_bug.cgi?id=47662 to all WMF wikis?
[22:01:45] <superm401>	 FYI, it already works for English Wikipedia.
[22:03:04] <spagewmf>	 superm401: sure, thanks.  It'll be a test if bingle updates Mingle with new comments.
[22:04:53] <superm401>	 spagewmf, done
[22:04:56] <cscott>	 ebernhardson: hm, no easy way to create notifications from client-side js though?
[22:07:48] <cscott>	 if user:a wants to invite user:b to co-edit a page with them, i was hoping to tie into echo
[22:13:07] <grrrit-wm>	 (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 (owner: 10Anomie)
[22:16:27] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson)
[22:20:05] <YuviPanda>	 hey cscott.
[22:20:11] <YuviPanda>	 i know you pinged me but I... have no idea where
[22:20:26] <cscott>	 YuviPanda: on the internets somewhere
[22:20:34] <YuviPanda>	 i lost scrollback, sortof.
[22:21:27] <cscott>	 http://i.imgur.com/Yna2BEf.png
[22:21:30] <cscott>	 whoops
[22:21:35] <cscott>	 YuviPanda: in this channel?  i think i pinged you in #-labs
[22:21:50] <YuviPanda>	 ah, okay
[22:22:40] <ebernhardson>	 cscott: sorry was elsewhere, no there is currently no way to create client-side notifications because the product manager was *very* worried that the initial deployment would spam the heck out of people and they would all turn it off
[22:22:43] <cscott>	 Ryan_Lane was explaining to me how vagrant puppet != puppet and i was crying.
[22:23:01] <ebernhardson>	 cscott: the plan was basically to start with as  few notifications as possible and allow the natural progression of things to turn it into a big pile of spam :)
[22:23:25] * YuviPanda  is still sad that Gadgets / 3rd party tools can't really use Echo

[22:23:37] <cscott>	 ebernhardson: seems like the real answer is to allow granuar un/subscriptions.  but regardless:
[22:23:49] * MatmaRex  is sad gadgets can't use change tagging

[22:23:51] <cscott>	 do you have any suggestions for using echo for my use case?
[22:23:56] <Ryan_Lane>	 I'd surely like vagrant == labs
[22:24:01] <YuviPanda>	 +1 to cscott
[22:24:03] <MatmaRex>	 there's a bug for that, though, so if anyone feels like implementing it…
[22:24:19] <ebernhardson>	 cscott: what was your use case?  In general you can create a very simple extension (look at the Thanks extension for example) that adds notifications
[22:24:23] <cscott>	 ebernhardson: user:a wants to invite user:b to co-edit a page with them.  (sorry, we're having two different conversations at once)
[22:24:33] <cscott>	 ebernhardson: in real time, or as close to that as possible.
[22:24:44] <YuviPanda>	 Ryan_Lane: cscott it shouldn't be too hard to run an instance from two sets of puppet repos (ops/puppet and vagrant)
[22:24:51] <YuviPanda>	 cscott: which instance are you trying to setup now?
[22:25:01] <ebernhardson>	 cscott: i suppose the other problem with real time,  Echo notifications are delivered via the job queue.  Lately that queue has been millions of jobs long.
[22:25:10] <cscott>	 YuviPanda, Ryan_Lane: let's talk about this on -labs, so i can talk to ebernhardson here.
[22:25:16] <YuviPanda>	 hehe ok
[22:27:48] <ebernhardson>	 cscott: hmm...tbh i'm not sure echo can currently fill the requirement of a near-real time notifications of the sort where another user is waiting for the recipient to do something.  I would expect notifications to be delivered in a 5 to 10 minute timeframe
[22:32:34] <ebernhardson>	 well, i should say worst case ... there are times when they go through nearly instantaneous.  Given the existing infrastructure there arn't really any other options, and its a reasonable place to start.
[22:33:39] <cscott>	 yeah, i don't think there's any current way to do notifications faster, right?  if the job queue is backlogged, even sending email will take that long.
[22:33:57] <cscott>	 so i might as well try to do the integration, and leave "speeding up notifications" as an orthogonal task.
[22:34:26] <cscott>	 basically, i'm trying to prototype a couple of different ways that people might use to find other editors to co-edit with
[22:37:10] <ebernhardson>	 sounds like a plan.  Currently the best "documentation" for how to add custom notifications the mentioned https://www.mediawiki.org/wiki/Extension:Thanks .  If you have any particular issues feel free to ping the team ( we are on #wikimedia-corefeatures, but also generally here)
[22:38:05] <cscott>	 ebernhardson: ok.  i've got myself quite a bit of a backlog of things to hack on, hopefully i'll find this conversation in my chat logs and remember who to ping when i get around to doing the integration. ;)
[22:38:12] <ebernhardson>	 :)
[22:38:15] <cscott>	 maybe i should mention a couple of keywords here. ;)
[22:38:23] <ebernhardson>	 cscott: backlog? you just started :P
[22:38:41] <cscott>	 visualeditor, togetherjs, echo, flow, nsa, spook, random, keywords, here
[22:39:19] <cscott>	 ebernhardson: well, i've been working on the backend stuff, i'd like to spend some more time making the UX integration work nicer and there's a couple of items on my list there.
[22:39:47] <cscott>	 ebernhardson: and in #wikimedia-labs, Ryan_Lane and YuviPanda are giving me another backlog of things to do to make the demo server fast(er)
[22:41:30] <ebernhardson>	 cscott: heh, yea sounds like it will be a few weeks :)
[22:42:15] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] Add "Create accounts" grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85681 (owner: 10Anomie)
[22:42:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add "Create accounts" grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85681 (owner: 10Anomie)
[22:55:29] <grrrit-wm>	 (03PS4) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[23:02:45] <grrrit-wm>	 (03PS5) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[23:12:29] <grrrit-wm>	 (03CR) 10Aaron Schulz: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/85776 (owner: 10Anomie)
[23:13:18] <grrrit-wm>	 (03PS1) 10EBernhardson (WMF): Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 
[23:14:03] <Elsie>	 Gabriel seems to be suggest that I flooded a queue he doesn't care about.
[23:14:06] <Elsie>	 It's quite boggle some.
[23:14:11] <Elsie>	 Bogglesome.
[23:14:21] <Elsie>	 suggesting
[23:17:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson (WMF))
[23:18:08] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Bump version number, update signing key [apps/win8/wikipedia] (win8) - 10https://gerrit.wikimedia.org/r/85788 
[23:18:34] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Bump version number, update signing key [apps/win8/wikipedia] (win8) - 10https://gerrit.wikimedia.org/r/85788 (owner: 10Brion VIBBER)
[23:19:21] <YuviPanda>	 legoktm: re: 'just put it in memcached' - it needs updating when 1. a new image is uploaded, 2. templates used in the JSON change
[23:21:32] <marktraceur>	 csteipp: Reping re: BetaFeatures? :)
[23:22:33] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] "Looks good to me" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[23:22:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[23:25:57] <marktraceur>	 Woo
[23:26:05] * marktraceur  checks that bad boy off the tracking bug

[23:26:40] <ori-l>	 Krinkle: http://ganglia.wikimedia.org/latest/graph.php?r=hour&z=xlarge&title=Main+page+JavaScript+payload&vl=bytes&x=&n=&hreg[]=client-side&mreg[]=assets_javascript_bytes_%2A&gtype=stack&glegend=show&aggregate=1&embed=1&_=1379978661920
[23:27:32] <ori-l>	 Ryan_Lane: ^ :)
[23:27:37] <ori-l>	 your +2 dollars hard at work
[23:28:06] <Ryan_Lane>	 nice
[23:28:58] <grrrit-wm>	 (03PS1) 10Catrope: Update VisualEditor to wmf17 branch for cherry-picks [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85791 
[23:29:46] <mwalker>	 subbu: can you tell me what version of node y'all have deployed on the cluster?
[23:30:04] <subbu>	 node 0.8 /cc gwicke_away 
[23:30:15] <ori-l>	 0.8.2-1chl1~precise1
[23:32:34] <grrrit-wm>	 (03PS1) 10Catrope: Update VisualEditor to wmf18 branch for cherry-picks [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85793 
[23:33:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf17 branch for cherry-picks [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/85791 (owner: 10Catrope)
[23:33:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf18 branch for cherry-picks [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85793 (owner: 10Catrope)
[23:33:41] <mwalker>	 subbu|away / ori-l: do you know where that package is coming from? ubuntu precise default is 0.6
[23:34:35] <mwalker>	 according to gerrit we might be using a ppa version; but that seems very strange
[23:34:39] <ori-l>	 mwalker: probably a PPA that somebody imported from into our apt repo. here's the entry: https://dpaste.de/o3qXg/raw/
[23:35:21] <ori-l>	 possibly a backport from raring
[23:36:55] <Reedy>	 Raring is 0.6.19~dfsg1-5ubuntu1
[23:37:14] <Reedy>	 saucy is 0.10.15~dfsg1-4
[23:41:48] <gwicke_away>	 Parsoid is all on 0.8
[23:42:12] <gwicke>	 we'd like to move to 0.10 once that becomes available on the cluster
[23:42:32] <mwalker>	 ok; so in that case; better question -- does it make more sense for me to develop the centralnotice proxy on 0.8 or 0.10
[23:42:39] <gwicke>	 0.10
[23:43:16] <gwicke>	 most things work both in 0.10 and 0.8
[23:43:37] <gwicke>	 and 0.10 has been out for a while now- it is in Debian unstable for example
[23:44:37] <mwalker>	 kk
[23:46:03] <YuviPanda>	 ori-l: I forgot https://gerrit.wikimedia.org/r/84431 never got merged
[23:46:14] <YuviPanda>	 arr, can't rebase now
[23:46:21] * YuviPanda  rebases manually

[23:50:31] <ori-l>	 YuviPanda: i'll test it and merge if it's OK. testing should be much easier now with the apt-cache on the shared folder
[23:50:38] <ori-l>	 you can vagrant destroy / vagrant up in a fraction of the time
[23:50:42] <YuviPanda>	 ori-l: sweet.
[23:50:47] <YuviPanda>	 ori-l: i'm almost done rebasing. 
[23:51:01] <YuviPanda>	 ori-l: i'm writing a labsvagrant module in ops/puppet, so should be useful there too
[23:51:33] <ori-l>	 oooo, cool
[23:58:46] <grrrit-wm>	 (03PS2) 10Yuvipanda: Box Virtualbox-specific configs in 'virtualbox' module [vagrant] - 10https://gerrit.wikimedia.org/r/84431 (owner: 10Ori.livneh)
[23:58:50] <YuviPanda>	 ori-l: ^