[00:00:09] <YuviPanda>	 ori-l: you can rock back and forth in a sofa?
[00:02:28] <AaronSchulz>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/84911/ random commit
[00:07:51] <grrrit-wm>	 (03PS1) 10Santhosh: Use gravatar for user profile image [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85146 
[00:17:37] <MatmaRex>	 AaronSchulz: umm, thanks. any interpretation tips?
[00:17:47] <MatmaRex>	 because to me that looks like "not enough wfProfileIn()"
[00:19:03] <MatmaRex>	 also, 201.89%? wat?
[00:20:45] <grrrit-wm>	 (03PS3) 10Physikerwelt: First test to replace png->svg [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 
[00:21:07] <AaronSchulz>	 that always happens
[00:21:10] <AaronSchulz>	 ignore those
[00:21:26] <MatmaRex>	 heh
[00:23:24] <MatmaRex>	 77.45% 90.457027  27727 - Parser::callParserFunction - this probably comes from all the {{#tag: calls, but i wonder if the time is spent in the Parser itself on in Cite which handles these
[00:25:35] <MatmaRex>	 i need to set that up locally, eh.
[00:29:03] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Complete Implementation of additionalProperties [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84011 (owner: 10DMaggot)
[00:29:11] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] Adding capitalized i18n message for button context [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76538 (owner: 10Kaldari)
[00:29:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Complete Implementation of additionalProperties [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84011 (owner: 10DMaggot)
[00:31:12] <grrrit-wm>	 (03PS1) 10Nikerabbit: Pull in more hook points [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85149 
[00:32:05] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/81503 (owner: 10Rahul21)
[00:38:53] <grrrit-wm>	 (03PS2) 10Amire80: Pull in more hook points [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85149 (owner: 10Nikerabbit)
[00:39:12] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Pull in more hook points [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85149 (owner: 10Nikerabbit)
[00:39:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Pull in more hook points [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85149 (owner: 10Nikerabbit)
[00:45:15] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(4 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 (owner: 10Rahul21)
[00:45:42] <ori-l>	 Krinkle: I think I got it, and it's pretty elegant
[00:45:47] <ori-l>	 'embed' I mean
[00:45:56] * Krinkle  adds tests for less var, functions and import dir

[00:46:57] <grrrit-wm>	 (03PS25) 10Krinkle: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[00:47:40] <grrrit-wm>	 (03PS9) 10Rahul21: Added upload permissions for accessing Special:PronunciationRecording [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/81503 
[00:47:49] <grrrit-wm>	 (03CR) 10Krinkle: "Add tests to assert that our interface for less variables, functions and import dirs works properly. Also makes sure that those vars are n" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[00:47:56] <ori-l>	 Krinkle: wow, <3
[00:48:19] <ori-l>	 check out https://dpaste.de/ncpXs/raw/
[00:48:39] <ori-l>	 if the image is embeddable, both the guarded mixin and the unguarded one match, and you get both
[00:48:47] <Krinkle>	 nice
[00:53:21] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/81503 (owner: 10Rahul21)
[00:53:33] <ori-l>	 do we have a generic means of making functions memoizing, a la http://docs.python.org/3.4/library/functools.html#functools.lru_cache ?
[00:53:39] <ori-l>	 in PHP, I mean
[00:54:02] <grrrit-wm>	 (03CR) 10Mattflaschen: [V: 032] Added upload permissions for accessing Special:PronunciationRecording [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/81503 (owner: 10Rahul21)
[00:54:49] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ)
[00:55:59] <grrrit-wm>	 (03PS2) 10Amire80: Fix some RTL issue and add sans-serif as fallback font [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84680 (owner: 10Bsitu)
[00:56:00] <Krinkle>	 ori-l: Hm.. how does less deal with extra arguments
[00:56:04] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Fix some RTL issue and add sans-serif as fallback font [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84680 (owner: 10Bsitu)
[00:56:07] <grrrit-wm>	 (03PS1) 10Nikerabbit: Fix infite loop in user stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85152 
[00:56:08] <Krinkle>	 ori-l: box-shadow: 0 2px 5px 0 #ccc;
[00:56:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix some RTL issue and add sans-serif as fallback font [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84680 (owner: 10Bsitu)
[00:56:22] <Krinkle>	 on the web I see mixins that take only 1 argument, are those bad, or does it merge them in 1 if ther eis only 1 declared
[00:56:30] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] Cleanup code for sending tokens [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85131 (owner: 10Aaron Schulz)
[00:56:32] <Krinkle>	 .box-shadow (@string) {{
[00:56:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup code for sending tokens [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85131 (owner: 10Aaron Schulz)
[00:56:58] <ori-l>	 Krinkle: http://leafo.net/lessphp/docs/#arguments_variable and '...'
[00:57:05] <ori-l>	 see the bit that starts with 'Additionally, a vararg value' ..
[00:58:05] <Krinkle>	 Hm.. is that lessphp specific?
[00:58:14] * Krinkle  tets

[00:58:16] <Krinkle>	 tests
[00:59:46] <Krinkle>	 Yep, it seems to automatically turn the argument into .. and/or @arguments-like behaviour
[00:59:46] <Krinkle>	 http://less2css.org/
[01:00:02] <Krinkle>	 ori-l: http://cl.ly/image/2E1t0f2A293z
[01:00:10] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Fix infite loop in user stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85152 (owner: 10Nikerabbit)
[01:00:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix infite loop in user stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85152 (owner: 10Nikerabbit)
[01:00:24] <Krinkle>	 interesting, not sure we should (ab)use that. Though various less libs I see on the web do use that
[01:00:56] <ori-l>	 yeah, they should be comma-separated to treat them as individual args
[01:02:31] <Krinkle>	 well, not if you only want to pass it through.
[01:02:56] <grrrit-wm>	 (03CR) 10Bsitu: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[01:02:59] <grrrit-wm>	 (03PS1) 10Mattflaschen: jqueryMsg: Allow the same paired tags allowed by Saniitzer.php [core] - 10https://gerrit.wikimedia.org/r/85153 
[01:03:44] <grrrit-wm>	 (03PS25) 10Rahul21: Added Upload API support [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[01:09:18] <grrrit-wm>	 (03PS26) 10Rahul21: Added Upload API support [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[01:09:25] <grrrit-wm>	 (03PS1) 10DMaggot: Uncomment the options Schema Definition [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85154 
[01:14:39] <Krinkle>	 ori-l: I'm converting (locally only) module postEdit.css to less to see how it works in reality (added a transition() mixin and swapped the prefixed ones for calling the mixin). =
[01:14:42] <Krinkle>	 Works as expected
[01:14:45] <Krinkle>	 but debug mode is a bit weird
[01:15:00] <Krinkle>	 It isn't a separate request (I thought it was supposed to be?)
[01:15:09] <Krinkle>	 nor does it have any indication where it came from
[01:15:42] <ori-l>	 it gets the embeddedCSS (or whatever that function in mediawiki.js is called) treatment
[01:15:50] <Krinkle>	 ori-l: http://cl.ly/image/3U0V3T3b0v2i
[01:15:50] <ori-l>	 and injected into a <style> tag
[01:16:18] <Krinkle>	 shouldn't it (like other non-static file modules) require a load.php only=styles call instead?
[01:16:41] <Krinkle>	 that would make it as debuggable as wikipage modules and other dynamically generated modules, in that the stylesheet url has the module name in it.
[01:17:00] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[01:17:10] <ori-l>	 it's how ResourceLoader decides to handle it if I set $debugRaw = true;
[01:17:12] <ori-l>	 not sure why
[01:17:23] <ori-l>	 err, $debugRaw = false, I mean.
[01:18:56] <grrrit-wm>	 (03PS27) 10Rahul21: Added Upload API support [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[01:19:05] <Krinkle>	 Hm.. I don't think that one should be toggled.
[01:19:07] <Krinkle>	 Checking..
[01:26:18] <Krinkle>	 ori-l: fixed it
[01:26:28] <Krinkle>	 http://cl.ly/image/1j3y10162A37
[01:26:40] <ori-l>	 what was it?
[01:27:02] <Krinkle>	 like wikimodule, used getStyleURLsForDebug instead of debugRaw. debugRaw for something else
[01:27:46] <grrrit-wm>	 (03PS26) 10Krinkle: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[01:29:57] <ori-l>	 huh
[01:30:24] <ori-l>	 hm. thanks
[01:30:34] <ori-l>	 what is debugRaw for, then?
[01:30:50] <grrrit-wm>	 (03PS27) 10Krinkle: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[01:30:51] <Krinkle>	 I don't remember
[01:32:22] <grrrit-wm>	 (03PS1) 10Krinkle: (DRAFT) mediawiki.action.view.postEdit: Convert to use LESS [core] - 10https://gerrit.wikimedia.org/r/85161 
[01:32:51] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[01:32:57] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-2] "Just an example. Works fine for mixin purposes, but broken as it needs @embed." [core] - 10https://gerrit.wikimedia.org/r/85161 (owner: 10Krinkle)
[01:33:49] <Krinkle>	 ori-l: Could you review https://gerrit.wikimedia.org/r/#/c/78669/24..27//COMMIT_MSG and file-nav onwards?
[01:35:29] <Krinkle>	 ori-l: debugRaw is used for mediawiki.js and jquery.js modules through the startup module
[01:36:06] <Krinkle>	 in debug mode it can't respond with either mw.loader.implement([ url to load.php ]) or mw.loader.implement([ url to file  ]) because mw.loader doesn't exist yet :)
[01:36:12] <Krinkle>	 so that forces it to be inlined
[01:37:40] <grrrit-wm>	 (03PS2) 10MaxSem: Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 
[01:37:45] <Krinkle>	 self-loading from .load.php?module=x back to load.php?module=x&only=styles is relatively new, so that didn't exist yet when that was written
[01:38:10] <ori-l>	 ah, that makes sense
[01:40:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem)
[01:40:38] <Krinkle>	 debugRaw has confusing documentation indeed, because it documents what is was used for back then, as oppossed to what it actually does. The use back then was to avoid the file being loaded directly. The actual meaning is not "don't load this from disk" but "don't load() this in any way"
[01:43:43] <Krinkle>	 bbl 
[01:44:55] <grrrit-wm>	 (03PS28) 10Rahul21: Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[01:46:23] <grrrit-wm>	 (03PS28) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[01:46:46] <grrrit-wm>	 (03PS2) 10Ori.livneh: (WIP) Implement image embedding as a custom LESS function [core] - 10https://gerrit.wikimedia.org/r/85143 
[01:49:40] <Nikerabbit>	 AaronSchulz: with your patch I get:
[01:49:41] <Nikerabbit>	 [20-Sep-2013 01:48:38 UTC] PHP Notice:  DB transaction with writes still pending. in /www/translatewiki.net/w/includes/db/Database.php on line 3862
[01:49:44] <Nikerabbit>	 [20-Sep-2013 01:48:38 UTC] PHP Notice:  DB transaction idle or pre-commit callbacks still pending. in /www/translatewiki.net/w/includes/db/Database.php on line 3865
[01:58:35] <Elsie>	 ori-l: If you didn't have that off-by-one error in your commit message, I bet Roan would've merged already. :P
[01:58:41] * Elsie  stops taunting.

[01:59:09] <ori-l>	 nah, probably not
[01:59:38] <Elsie>	 You have a few more patchsets to go before you reach a record.
[01:59:48] <Elsie>	 Brownie time!
[02:01:24] <grrrit-wm>	 (03PS3) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[02:09:18] <grrrit-wm>	 (03PS2) 10Ejegg: LinkSearch: use default protocol if unsupported [core] - 10https://gerrit.wikimedia.org/r/84475 
[03:28:25] <grrrit-wm>	 (03CR) 10Krinkle: "I'm not sure I understand what this is for. If an extension (e.g. VisualEditor or UploadWizard) has beta features, which it would register" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84909 (owner: 10MarkTraceur)
[03:29:20] <grrrit-wm>	 (03CR) 10Krinkle: "That way the setting in question also becomes generic without depending on BetaFeatures (BetaFeatures would promote the user preference fr" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84909 (owner: 10MarkTraceur)
[04:53:03] <grrrit-wm>	 (03CR) 10Mattflaschen: "It seems to silently drop blocks if there's a syntax error in a mixin:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[05:05:10] <grrrit-wm>	 (03PS4) 10Physikerwelt: First test to replace png->svg [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 
[05:12:15] <grrrit-wm>	 (03PS2) 10Nikerabbit: jqueryMsg: Allow the same paired tags allowed by Saniitzer.php [core] - 10https://gerrit.wikimedia.org/r/85153 (owner: 10Mattflaschen)
[05:31:37] <superm401>	 ori-l, the StackOverflow test of language viability: http://stackoverflow.com/questions/18909455/how-do-i-execute-a-less-guard-when-a-boolean-is-not-true
[05:31:52] <superm401>	 I am interested to see if anyone answers/how fast, but it's not just a test.
[05:31:54] <superm401>	 I also don't knw.
[05:40:50] <grrrit-wm>	 (03PS1) 10Legoktm: Only show badhtml warning once per page load [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 
[05:41:42] <grrrit-wm>	 (03CR) 10Legoktm: "I'm unsure if this is the best way to remove the handler, according to http://api.jquery.com/unbind/ this would remove all handlers..." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 (owner: 10Legoktm)
[05:44:32] <grrrit-wm>	 (03PS2) 10Legoktm: Only show badhtml warning once per page load [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 
[05:45:04] <grrrit-wm>	 (03CR) 10Legoktm: "PS2: Spaces --> tabs" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 (owner: 10Legoktm)
[05:47:36] <grrrit-wm>	 (03PS5) 10Physikerwelt: First test to replace png->svg [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 
[05:56:14] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 04-1] "(2 comments)" [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 (owner: 10Physikerwelt)
[06:32:02] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Unbreak translatewiki.net scripts [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85176 
[06:32:40] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Unbreak translatewiki.net scripts [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85176 (owner: 10Raimond Spekking)
[07:11:27] <Nemo_bis>	 no hoo
[08:21:18] <grrrit-wm>	 (03PS1) 10Aude: add message for Commons site link section on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/85183 
[08:38:23] <grrrit-wm>	 (03PS2) 10Aude: add message for Commons site link section on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/85183 
[08:40:30] <legoktm>	 MatmaRex: have some time to look at https://gerrit.wikimedia.org/r/#/c/85174/ ?
[08:41:19] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "+1ing Timo's emendations" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[08:43:02] <MatmaRex>	 legoktm: there's a delayedBindUnbind() function
[08:43:45] <legoktm>	 MatmaRex: The comment with that function wasn't very clear…is that a delayedBind version of .unbind? or does it unbind delayedBind stuff?
[08:44:33] <MatmaRex>	 yes
[08:44:36] <MatmaRex>	 and yes
[08:44:46] <MatmaRex>	 just call it with the same arguments as delayedBind()
[08:44:55] <legoktm>	 heh
[08:44:56] <legoktm>	 ok
[08:45:00] <MatmaRex>	 to remove the hooks and timers and stuff delayedbind added
[08:45:08] <MatmaRex>	 (i think.)
[08:45:31] <MatmaRex>	 not sure why you want to od this, though
[08:45:33] <grrrit-wm>	 (03PS13) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 
[08:45:44] <grrrit-wm>	 (03PS1) 10Hiong3-eng5: Jobs cleaning and improvements [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/85184 
[08:45:51] <MatmaRex>	 why shouldn't the warning be shown twice if there are two mistakes made?
[08:47:11] <legoktm>	 if someone makes two mistakes, they'll both be shown in one notification
[08:47:13] <grrrit-wm>	 (03CR) 10Rjain: "I rebased the core MW again and it works now." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain)
[08:47:24] <MatmaRex>	 ugh, i mean. a mistake is made twice.
[08:47:34] <legoktm>	 but if someone keeps a mistake in, it'll make the current notification disappear and then flash a new one which is annoying
[08:47:36] <MatmaRex>	 so they get the notif, fix the troublesome code, then mess up again
[08:47:59] <legoktm>	 hopefully they'll be sane enough to hit preview again, at which point they'll get a new warning
[08:48:22] <MatmaRex>	 you might want to use something that isn't mw.notify
[08:48:32] <legoktm>	 like…? :P
[08:48:42] <MatmaRex>	 similarly to how the new Translate UI displays warning messages next to inputs, maybe?
[08:49:02] <MatmaRex>	 a small reddish bar below or above the textarea
[08:49:17] <MatmaRex>	 let me get a screenshot (or a link to working example)
[08:50:29] <legoktm>	 how do i get a warning to show up?
[08:50:56] <legoktm>	 i dont use translate much…doesn't help that i really only speak english :/
[08:51:21] <MatmaRex>	 code it up? :P
[08:51:22] <MatmaRex>	 one sec
[08:51:35] <MatmaRex>	 ah, you mean in translate. one sec.
[08:51:57] <legoktm>	 yeah, i opened up a window to translate something from en to en-ca :P
[08:52:23] <MatmaRex>	 http://i.imgur.com/d09Pgq6.png
[08:52:35] <MatmaRex>	 it complains that the link on [[$1]] is missing, for example
[08:52:46] <MatmaRex>	 it complains about missing variables or unmatched parentheses as well
[08:52:55] <legoktm>	 oh hmmm
[08:53:14] <MatmaRex>	 core has styles for class=warningbox
[08:53:26] <MatmaRex>	 which are different and suck badly, but i have a patch pending to make them better
[08:53:44] <legoktm>	 i dont think something like that would work for this, since the textbox for inputting the message can get rather long so it can easily be pushed off the screen
[08:53:50] <legoktm>	 so it would need to be a floating notification
[08:53:50] <MatmaRex>	 current: http://i.imgur.com/DN7LX1W.png my version: http://i.imgur.com/pNCTxtr.png https://gerrit.wikimedia.org/r/#/c/82828/
[08:54:14] <MatmaRex>	 hmmm, is the textbox autosized or something?
[08:54:25] <MatmaRex>	 you could put that next to the "Save" button (or whatever button you have)
[08:54:50] <legoktm>	 ah
[08:54:53] <legoktm>	 that would work
[08:55:15] <legoktm>	 so just stick an empty <div id="errormessage"></div>
[08:55:27] <legoktm>	 and then call $('#errormessage').text(blah); ?
[08:58:36] <MatmaRex>	 yeah, i guess
[08:58:48] <MatmaRex>	 might want to .hide() or .show() it too
[09:01:46] <legoktm>	 ah, yeah that too. now time to mess with html form :/
[09:02:25] <grrrit-wm>	 (03CR) 10Nemo bis: "(Needs rebase.)" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff)
[09:05:21] <grrrit-wm>	 (03PS1) 10Reedy: Fix comment about Math compnent to report bugs etc [extensions/Math] - 10https://gerrit.wikimedia.org/r/85185 
[09:13:19] <grrrit-wm>	 (03PS2) 10Physikerwelt: Fix comment about Math compnent to report bugs etc [extensions/Math] - 10https://gerrit.wikimedia.org/r/85185 (owner: 10Reedy)
[09:13:40] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032] "thanks." [extensions/Math] - 10https://gerrit.wikimedia.org/r/85185 (owner: 10Reedy)
[09:24:56] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Add missing message [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 
[09:27:53] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] add message for Commons site link section on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/85183 (owner: 10Aude)
[09:27:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: add message for Commons site link section on Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/85183 (owner: 10Aude)
[09:28:12] <grrrit-wm>	 (03PS3) 10Legoktm: Use our own warning system instead of mw.notify [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 
[09:28:20] <legoktm>	 MatmaRex: ^
[09:28:59] <aude>	 DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/84857/
[09:29:37] <grrrit-wm>	 (03CR) 10Raimond Spekking: "(1 comment)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/69303 (owner: 10Legoktm)
[09:30:07] <aude>	 errr wrong channel
[09:30:09] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] "Thanks!" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85186 (owner: 10Raimond Spekking)
[09:47:52] <MatmaRex>	 legoktm: nice. you probably want to style that message a little, no? (to make it more noticeable)
[09:48:20] <legoktm>	 probably
[09:48:23] <MatmaRex>	 legoktm: also, for a negligible performance improvement ;), you could cache the `warnings` element
[09:48:30] <legoktm>	 but i'm not a very designery person
[09:48:40] <legoktm>	 cache how?
[09:48:50] <MatmaRex>	 like: var warnings = $('<div></div>').attr('id', 'mw-massmessage-form-warnings'); msg.after(warnings);
[09:49:04] <MatmaRex>	 then you don't need to `warnings = $('#mw-massmessage-form-warnings');` every time within the event handler
[09:49:09] <legoktm>	 ah
[09:50:03] <MatmaRex>	 you don't need to be designery to slap a yellow background on something. :D
[09:55:21] <grrrit-wm>	 (03PS4) 10Legoktm: Use our own warning system instead of mw.notify [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/85174 
[09:55:29] <legoktm>	 ok, fixed that
[09:55:36] <legoktm>	 ill add some styling in the morning
[09:55:57] <legoktm>	 thanks for the help MatmaRex 
[09:55:58] <legoktm>	 gnite
[09:56:30] <MatmaRex>	 night
[10:00:58] <p858snake|l>	 <legoktm> but i'm not a very designery person <pfft, working > design
[11:51:18] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz)
[12:07:32] <grrrit-wm>	 (03PS1) 10Hashar: Revert "debian glue triggers jobs by itself" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85194 
[12:07:53] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Revert "debian glue triggers jobs by itself" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85194 (owner: 10Hashar)
[12:08:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "debian glue triggers jobs by itself" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/85194 (owner: 10Hashar)
[13:08:09] <grrrit-wm>	 (03PS1) 10Ejegg: LinkFilter: use wfMakeUrlIndexes in makeLikeArray [core] - 10https://gerrit.wikimedia.org/r/85199 
[13:09:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] LinkFilter: use wfMakeUrlIndexes in makeLikeArray [core] - 10https://gerrit.wikimedia.org/r/85199 (owner: 10Ejegg)
[13:23:12] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Remove some no longer needed scrutinizer config [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85201 
[13:24:01] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Remove some no longer needed scrutinizer config [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85201 (owner: 10Jeroen De Dauw)
[13:34:02] <grrrit-wm>	 (03PS2) 10Himeshi: Added unit tests for the SFFormPrinter class [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 
[13:36:58] <grrrit-wm>	 (03PS1) 10Hashar: fix testextensions clone destination [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85202 
[13:38:07] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Tobias, addshore, that is the crazy issue you have reported in #wikimedia-wikidata. Really sorry about that and thank you very much to ha" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85202 (owner: 10Hashar)
[13:38:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: fix testextensions clone destination [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/85202 (owner: 10Hashar)
[13:54:40] <grrrit-wm>	 (03PS1) 10Rtdwivedi: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 
[13:55:06] <grrrit-wm>	 (03CR) 10Hashar: "The basedir ZUUL_PROJECT Is incorrect for extension. Got fixed by https://gerrit.wikimedia.org/r/#/c/85202/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84918 (owner: 10Hashar)
[13:55:17] <grrrit-wm>	 (03CR) 10Mwjames: "Now it might be a good time to request to put SF on the Jenkins integration list (Hashar)." [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 (owner: 10Himeshi)
[13:55:23] <grrrit-wm>	 (03PS1) 10Manybubbles: Highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85206 
[13:56:25] <grrrit-wm>	 (03CR) 10Mwjames: "Your $mockTitle should at least contain:" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 (owner: 10Himeshi)
[13:56:31] <grrrit-wm>	 (03PS1) 10Manybubbles: Tests for highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85207 
[13:58:59] <grrrit-wm>	 (03CR) 10Mwjames: "Just run it locally and it returns with:" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 (owner: 10Himeshi)
[14:03:36] <grrrit-wm>	 (03CR) 10Mwjames: "(2 comments)" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 (owner: 10Himeshi)
[14:07:20] <Denny_WMDE>	 denny here
[14:08:19] <thisAndThat>	 hi danny
[14:08:23] <thisAndThat>	 I choose this nick :)
[14:08:29] <Denny_WMDE>	 ok :)
[14:08:40] <Denny_WMDE>	 public or private?
[14:08:47] <thisAndThat>	 yes that was my next question
[14:08:49] <thisAndThat>	 as you wish
[14:08:51] <Denny_WMDE>	 we can also go to #wikimedia-wikidata 
[14:08:59] <Denny_WMDE>	 i think it fits better there
[14:09:03] <thisAndThat>	 ok let sgo there
[14:12:08] <grrrit-wm>	 (03CR) 10Mwjames: "Getting the unit test working properly might be a bit daunting at first but you will be rewarded in the long-run, so don't get demotivated" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/83213 (owner: 10Himeshi)
[14:29:19] <grrrit-wm>	 (03PS11) 10Hashar: debian-glue macros and jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71245 (owner: 10AzaToth)
[14:32:35] <grrrit-wm>	 (03CR) 10Hashar: "In PS11 I have made all three job templates to be triggered by Zuul. That let us report back in Gerrit the status of each job, example on " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71245 (owner: 10AzaToth)
[14:32:51] <hexmode>	 ??
[15:16:00] <grrrit-wm>	 (03PS1) 10Mwjames: Reorder RL loading [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85216 
[15:16:59] <grrrit-wm>	 (03PS2) 10Mwjames: Reorder RL loading [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85216 
[15:19:53] <grrrit-wm>	 (03CR) 10Mwjames: [C: 032] Reorder RL loading [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85216 (owner: 10Mwjames)
[15:20:44] <grrrit-wm>	 (03CR) 10Tpt: "(4 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 (owner: 10Rtdwivedi)
[15:21:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorder RL loading [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85216 (owner: 10Mwjames)
[15:23:46] <grrrit-wm>	 (03Abandoned) 10Mwjames: Fix flashy unstyled content in MW 1.22 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/64128 (owner: 10Mwjames)
[15:28:39] <grrrit-wm>	 (03PS1) 10Anomie: Add RSA key support to maintenance/testOAuthConsumer.php [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85217 
[15:30:07] <grrrit-wm>	 (03PS1) 10Anomie: Use HTTPS for Special:MWOAuth/token [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 
[15:31:15] <grrrit-wm>	 (03CR) 10Anomie: "Note I didn't implement the exemption for RSA in this patch, see comment on the bug. If it turns out that we can do that after all, this a" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85218 (owner: 10Anomie)
[15:34:44] <grrrit-wm>	 (03PS1) 10Umherirrender: Pass user to Title::userCan in ApiFeedContributions [core] - 10https://gerrit.wikimedia.org/r/85220 
[15:38:04] <grrrit-wm>	 (03PS1) 10Umherirrender: Allow passing a user to SearchEngine::getTextSnippet [core] - 10https://gerrit.wikimedia.org/r/85221 
[15:43:59] <grrrit-wm>	 (03PS20) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[15:44:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi)
[15:48:44] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85128 (owner: 10CSteipp)
[16:10:21] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Pass user to Title::userCan in ApiFeedContributions [core] - 10https://gerrit.wikimedia.org/r/85220 (owner: 10Umherirrender)
[16:12:36] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] Allow passing a user to SearchEngine::getTextSnippet [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[16:13:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Pass user to Title::userCan in ApiFeedContributions [core] - 10https://gerrit.wikimedia.org/r/85220 (owner: 10Umherirrender)
[16:13:46] <grrrit-wm>	 (03PS1) 10Cmcmahon: make string check very generic [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85225 
[16:16:48] <ori-l>	 brion: thoughts re https://gerrit.wikimedia.org/r/#/c/85143/ ?
[16:17:08] <brion>	  will take a peek at it momentarily
[16:17:43] <ori-l>	 thanks
[16:20:48] <grrrit-wm>	 (03PS1) 10Cmcmahon: AFT pref is n/a for test2 now [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85226 
[16:21:05] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85225 (owner: 10Cmcmahon)
[16:21:19] <grrrit-wm>	 (03PS2) 10Cmcmahon: AFT pref is n/a for test2 now [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85226 
[16:21:29] <grrrit-wm>	 (03CR) 10Cmcmahon: [V: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85226 (owner: 10Cmcmahon)
[16:21:50] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85226 (owner: 10Cmcmahon)
[16:23:57] <grrrit-wm>	 (03PS21) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[16:25:28] <grrrit-wm>	 (03CR) 10Cmcmahon: "Would like to see this fixed, as UW now shows the same behavior on test2wiki and beta commons." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85008 (owner: 10MarkTraceur)
[16:28:48] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[16:29:17] <brion>	 ori-l: looks workable, though it looks to me like it'll include the !ie in the single fallback rule if a file comes up as non-embeddable
[16:29:36] <brion>	 i think that should be fixable though
[16:29:45] <ori-l>	 well, i'm trying to figure out what that !ie is for; it might be voodoo
[16:31:29] <brion>	 heh
[16:34:49] <brion>	 ori-l: ok this is my understanding of the !ie thing
[16:35:05] <ori-l>	 before you start:
[16:35:08] <ori-l>	 is this going to make me cry?
[16:35:13] <ori-l>	 i'd just like to prepare, emotionally
[16:35:17] <brion>	 you might
[16:35:23] <ori-l>	 ok, hit me
[16:35:25] <brion>	 1) if you just feed data: URIs to IE 6/7 it will just fail to load them
[16:35:35] <brion>	 2) so we have to put the data: URIs before the http/s URIs for IE
[16:35:44] <brion>	 3) but then we have to break the http/s URI for non-IE
[16:35:48] <brion>	 4) which i think is what the !ie does
[16:35:55] <brion>	 5) profit!
[16:36:11] <ori-l>	 are you exclaiming 'profit' or breaking profit for non IE browsers?
[16:36:16] <brion>	 lol
[16:36:27] <ori-l>	 anyhow, i thought so too, but the credible reference i found involved putting ! in property names
[16:36:33] <ori-l>	 b!ackground-image, things like that
[16:36:42] <brion>	 yeah lemme see if i can find how/why the !ie actually works
[16:36:44] <Nemo_bis>	 !
[16:36:44] <wm-bot>	 ok, you just typed an exclamation mark with no meaning in the channel, good job. If you want to see a list of all keys, check !botbrain
[16:36:52] <Nemo_bis>	 grr
[16:36:52] <ori-l>	 !ie
[16:36:52] <wm-bot>	 There is no such key, you probably want to try: !actionpaths, !ancient, !anglebrackets, !anonnotice, !api, !authentication, !autothumb, !blank, !bleedingedge, !bot, !botnoob, !categories, !cms, !codereview, !cookies, !debug, !deleteuser, !deployments, !documentation, !download, !draft, !extensions, !filesize, !fu, !gitrepo, !git-review, !hello, !help, !hiddencategories, !ie6, !IE9, !install, !line, !lsb, !lua, !mainpagetitle, !moderation, !multiplecommits, !newgit, !next, !nightly, !nosql, !paranoid, !passwordsql, !phpinfo, !pywikipediabot, !queue, !recaptcha, !redlinks, !refresh, !revdelete, !reviewqueue, !rfc, !safemode, !sal, !security, !sm, !sortkey, !sqllog, !srv193, !stroopwafels, !sul, !svnprops, !test, !the_mask, !tias, !toolserver, !tooquiet, !transclusion, !unreviewedcode, !viewvc, !vulnerability, !wikieditor, !wptemplates, !wysiwyg, !xampp, !cs, !apiclient, !templateproblems, !packagessimple, 
[16:37:00] <brion>	 hehe
[16:37:13] <Nemo_bis>	 ori-l: I think !ie is a swear word hence not known to the bot
[16:38:03] <ori-l>	 probably
[16:38:06] <marktraceur>	 Krenair: Up for reviewing that critical UW bug? Apparently it got pushed to test2 yesterday.
[16:38:16] <marktraceur>	 Krenair: The fix is at https://gerrit.wikimedia.org/r/85008
[16:39:12] <brion>	 ori-l: http://browserhacks.com/#hack-90ce8e1eeeb5f3d0971df30d412934b4
[16:39:45] <ori-l>	 'Acts as an !important; string after ! can be anything'
[16:40:09] <brion>	 how awful :)
[16:40:46] <marktraceur>	 Maybe a good way to detect IE, though :P
[16:41:32] <ori-l>	 more info at http://reference.sitepoint.com/css/importantdeclarations
[16:41:39] <ori-l>	 'Internet Explorer 6 and 7 give importance to a declaration when an illegal identifier is used in place of the keyword important, instead of ignoring the declaration as they should.'
[16:43:16] <grrrit-wm>	 (03PS2) 10Santhosh: Use gravatar for user profile image [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85146 
[16:43:54] <brion>	 nice
[16:44:50] <ori-l>	 well, according to http://theie7countdown.com/, ie 7 is at less than %1 worldwide
[16:45:23] <ori-l>	 including asia (i remembering hearing that it was popular in china, though i admit this is hearsay and possibly apocryphal)
[16:46:14] <ori-l>	 background images are not essential (i.e., if they were missing the site would not be unusable)
[16:46:44] <ori-l>	 you see where i'm going -- i think you're right that some workaround could be found but i'm wondering if it wouldn't be better to just remove the !ie
[16:46:45] <brion>	 in theory yes
[16:46:52] <brion>	 kill oldie !
[16:47:33] <brion>	 (i think you could just flip the predicate and move the !ie line up to the embedable-only case, with a plain version in the non-embed)
[16:48:32] <ori-l>	 hrm, yes, i think you're right
[16:48:48] <ori-l>	 i still want to kill it because i'm hateful like that, doing a bit more research tho
[16:48:54] <grrrit-wm>	 (03PS2) 10Umherirrender: update.php clears caches twice [core] - 10https://gerrit.wikimedia.org/r/84137 
[16:59:38] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[17:00:05] <grrrit-wm>	 (03CR) 10Nikerabbit: "Running this on twn, it just displays to notices instead of one." [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz)
[17:00:50] <grrrit-wm>	 (03PS22) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[17:01:16] <ori-l>	 brion: sigh. we can't kill it. i'll take your suggestion to flip the predicate.
[17:01:43] <ori-l>	 !ie is sadness.
[17:01:44] <wm-bot>	 Key was added
[17:01:45] <brion>	 ;_;
[17:01:48] <brion>	 lol
[17:01:51] <ori-l>	 !ie | brion
[17:01:51] <wm-bot>	 brion: sadness.
[17:02:15] <ori-l>	 !del ie
[17:02:15] <wm-bot>	 There is no such key, you probably want to try: !deleteuser, !extensiondistributor, !protect, !resourceloader, !revdelete, !security, !uploadbyurl, !worstcase, !memoserv, 
[17:02:18] <ori-l>	 !del !ie
[17:02:18] <wm-bot>	 There is no such key, you probably want to try: !deleteuser, !extensiondistributor, !protect, !resourceloader, !revdelete, !security, !uploadbyurl, !worstcase, !memoserv, 
[17:02:23] <ori-l>	 well, okay.
[17:02:32] <^d>	 !del ie
[17:02:32] <wm-bot>	 There is no such key, you probably want to try: !deleteuser, !extensiondistributor, !protect, !resourceloader, !revdelete, !security, !uploadbyurl, !worstcase, !memoserv, 
[17:02:39] <ori-l>	 maybe wm-bot is implemented in vbscript
[17:03:24] <grrrit-wm>	 (03CR) 10Nikerabbit: "For those who do not know php regular expression by hand, it would have been nice to explain what S does." [core] - 10https://gerrit.wikimedia.org/r/85105 (owner: 10PleaseStand)
[17:04:08] <robla>	 yhager: nice work on your first HipHop patch!
[17:04:20] <robla>	 ^d: https://github.com/facebook/hiphop-php/commit/e41dfc1c8fbfb03982090efdb38d3a5a17dcfb31
[17:04:46] <yhager>	 robla: thanks. That's a direct result of our phone call a couple of weeks ago
[17:05:10] <brion>	 clearly i.e. really *IS* integrated into the system
[17:06:37] <Nemo_bis>	 M$ has a backdoor in wm-bot 
[17:09:12] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032] Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 (owner: 10Bsitu)
[17:10:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 (owner: 10Bsitu)
[17:11:21] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Given that the implementation of SearchEngine::userHighlightPrefs returns constants and ignores user object I'd advocate going the other w" [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[17:16:31] <grrrit-wm>	 (03PS1) 10Aude: Update Wikibase and WikimediaMessages [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85231 
[17:18:01] <grrrit-wm>	 (03PS1) 10Umherirrender: Add continue editing link also to js and css pages [core] - 10https://gerrit.wikimedia.org/r/85232 
[17:19:54] <grrrit-wm>	 (03PS23) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[17:20:06] <grrrit-wm>	 (03PS9) 10BryanDavis: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt)
[17:20:16] <grrrit-wm>	 (03PS1) 10Anomie: Improve wfEscapeWikiText, part 2 [core] - 10https://gerrit.wikimedia.org/r/85233 
[17:20:27] <grrrit-wm>	 (03PS1) 10Anomie: Improve mw.text.nowiki, part 2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/85234 
[17:23:35] <grrrit-wm>	 (03CR) 10Umherirrender: "The user param from userHighlightPrefs was removed with r87215, also remove the $wgUser? (feel free to do it)" [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[17:40:26] <grrrit-wm>	 (03PS4) 10Bsitu: Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 
[17:40:39] <grrrit-wm>	 (03PS24) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[17:42:47] <Krenair>	 marktraceur, you should ask ori-l for eventlogging stuff
[17:43:08] <marktraceur>	 Krenair: I didn't actually change the eventlogging stuff, but if ori-l wants to review it that's cool too
[17:43:20] <marktraceur>	 Basically I just want to get it out so we don't, you know, break UploadWizard.
[17:44:36] <Krenair>	 marktraceur, it needs EventLogging to be installed to test. I am not the person you should be asking about this.
[17:44:49] <grrrit-wm>	 (03PS25) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 
[17:45:01] <grrrit-wm>	 (03PS1) 10Hoo man: Add 'spamblacklistlog' to the list of available rights [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85238 
[17:45:23] <marktraceur>	 Krenair: No, it doesn't, EventLogging is installed on betacommons and it was crashing there too
[17:45:31] <marktraceur>	 It's about the order of extension installation, and the patch fixes it
[17:45:49] <marktraceur>	 Ignore the EL-specific stuff and think of it as a pure extension dependency fix.
[17:45:58] <hoo>	 trivial one ^
[17:46:06] <Krenair>	 if ( array_key_exists( 'ext.eventLogging', $wgResourceModules ) ) { ummmm...
[17:46:10] <hoo>	 marktraceur: You merged the original one, so please take a look at that :P
[17:46:38] <marktraceur>	 Krenair: That's the same as "if ( /* EventLogging is bloody well installed */ ) {
[17:46:51] <marktraceur>	 It's *just* a dependency
[17:48:01] <marktraceur>	 Krenair: If you're not comfortable with it that's fine, I can hunt ori-l down
[17:48:26] <Krenair>	 okay
[17:48:46] <grrrit-wm>	 (03PS5) 10Bsitu: Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 
[17:49:24] <grrrit-wm>	 (03CR) 10Anomie: Allow passing a user to SearchEngine::getTextSnippet [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[17:50:40] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi)
[17:50:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi)
[17:51:21] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Nearly trivial, but still." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85238 (owner: 10Hoo man)
[17:51:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'spamblacklistlog' to the list of available rights [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85238 (owner: 10Hoo man)
[17:51:31] <marktraceur>	 hoo: {{done}}
[17:51:38] <marktraceur>	 No bug?
[17:52:09] <hoo>	 marktraceur: Not aware of one... only saw it myself when trying to alter global rights
[17:52:19] <marktraceur>	 'kay
[17:53:06] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt)
[17:53:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt)
[17:56:38] <grrrit-wm>	 (03PS4) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[18:00:38] <grrrit-wm>	 (03CR) 10Ori.livneh: "PS4 turns the logic on its head a little to ensure '!ie' is only generated when the data URI is, too. This is accomplished by calling embe" [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[18:01:02] <liangent>	 does this happen to me only? https://bugzilla.wikimedia.org/show_bug.cgi?id=53329
[18:02:21] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85206 (owner: 10Manybubbles)
[18:03:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85206 (owner: 10Manybubbles)
[18:06:31] <grrrit-wm>	 (03PS1) 10Anomie: Handle the case when only hidden grants are requested [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85248 
[18:09:07] <grrrit-wm>	 (03CR) 10Ori.livneh: "@Mattflaschen:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[18:09:25] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Tests for highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85207 (owner: 10Manybubbles)
[18:09:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests for highlight changed words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85207 (owner: 10Manybubbles)
[18:09:31] <grrrit-wm>	 (03CR) 10BryanDavis: "(1 comment)" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/84911 (owner: 10Aaron Schulz)
[18:10:32] <grrrit-wm>	 (03PS2) 10BryanDavis: Simplified some code and broke lines in thumb.php [core] - 10https://gerrit.wikimedia.org/r/81860 (owner: 10Aaron Schulz)
[18:10:36] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032] Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 (owner: 10Bsitu)
[18:18:19] <grrrit-wm>	 (03PS2) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[18:18:34] <marktraceur>	 bd808: OK, I don't think that patch will piss off siebrand anymore
[18:18:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[18:20:21] <grrrit-wm>	 (03PS3) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 (owner: 10Krinkle)
[18:22:25] <grrrit-wm>	 (03CR) 10MarkTraceur: "Krinkle, the per-wiki disabling was requested by Fabrice, he thinks it might be politically necessary in the future. I'll poke him to comm" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84909 (owner: 10MarkTraceur)
[18:28:14] <grrrit-wm>	 (03PS1) 10Santhosh: Fix empty message group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85254 
[18:28:51] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add RSA key support to maintenance/testOAuthConsumer.php [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85217 (owner: 10Anomie)
[18:28:52] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Start of extension. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles)
[18:29:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add RSA key support to maintenance/testOAuthConsumer.php [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85217 (owner: 10Anomie)
[18:29:55] <grrrit-wm>	 (03CR) 10Chad: [V: 032] Start of extension. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles)
[18:30:20] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove Elastica. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 (owner: 10Manybubbles)
[18:30:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove Elastica. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 (owner: 10Manybubbles)
[18:36:53] <grrrit-wm>	 (03CR) 10Andrew Bogott: "This works on labs. I don't love the way I've split things up between public/private hostname/ip, the code seems kind of baffling as is. " [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 (owner: 10Andrew Bogott)
[18:37:54] <grrrit-wm>	 (03CR) 10J: "(1 comment)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/83996 (owner: 10J)
[18:38:22] <grrrit-wm>	 (03PS1) 10Kaldari: Changing default copyright notice per WMF legal's suggestion. [core] - 10https://gerrit.wikimedia.org/r/85255 
[18:38:28] <grrrit-wm>	 (03PS3) 10J: Use TitleMove hook to cleanup transcodes before move [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/83996 
[18:38:39] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] "Message could probably be improved, but works as advertised." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85248 (owner: 10Anomie)
[18:39:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle the case when only hidden grants are requested [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/85248 (owner: 10Anomie)
[18:41:45] <YuviPanda>	 manybubbles: ping?
[18:41:48] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032] Fix a mysteriously-not-broken case typo. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/83947 (owner: 10Andrew Bogott)
[18:41:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix a mysteriously-not-broken case typo. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/83947 (owner: 10Andrew Bogott)
[18:41:55] <manybubbles>	 YuviPanda: hi!
[18:42:07] <YuviPanda>	 manybubbles: was looking through https://bugzilla.wikimedia.org/show_bug.cgi?id=54376
[18:42:39] <YuviPanda>	 manybubbles: that looks like a bug in OutputPage.php, rather than UW, but I'll try to work around it now anyway.
[18:42:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Huh... if this commit fixes an actual issue without introducing a new one, I'm for merging it, disregarding problems people not using the " [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/64128 (owner: 10Mwjames)
[18:43:03] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] "This seems to work well on my dev server. I'd like to see someone else test as well." [core] - 10https://gerrit.wikimedia.org/r/81860 (owner: 10Aaron Schulz)
[18:43:12] <manybubbles>	 YuviPanda: ah! sorry, I didn't realize.
[18:43:32] <YuviPanda>	 manybubbles: the interface for parseInline does not let me set a page, so there's not much I can do right there.
[18:43:54] <YuviPanda>	 manybubbles: so this is a bug in the way 'current page' is being set in the request context when the search engine tries to index them
[18:44:28] <YuviPanda>	 manybubbles: however, since I'm abusing OutputPage there anyway, I'll rewrite it to not use OutputPage there, and I guess that *could* fix your issue.
[18:44:58] <manybubbles>	 thanks.
[18:45:09] <YuviPanda>	 manybubbles: yw. i'll poke you when the patch is out.
[18:46:59] <grrrit-wm>	 (03CR) 10Mwjames: "[1] I went ahead since I got so annoyed by this." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/64128 (owner: 10Mwjames)
[18:48:11] <grrrit-wm>	 (03CR) 10Slaporte: [C: 031] "Approved by legal." [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[18:48:27] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix phrase rescore. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85257 
[18:52:21] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "What we have now is totally busted and making more work difficult so I'm just going to merge this. Sorry." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85257 (owner: 10Manybubbles)
[18:52:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix phrase rescore. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85257 (owner: 10Manybubbles)
[18:53:17] <grrrit-wm>	 (03PS5) 10MaxSem: Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 
[18:53:25] <grrrit-wm>	 (03CR) 10RobLa: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[18:54:01] <grrrit-wm>	 (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur)
[18:55:38] <grrrit-wm>	 (03PS2) 10Umherirrender: SearchEngine::userHighlightPrefs needs no user [core] - 10https://gerrit.wikimedia.org/r/85221 
[18:56:24] <YuviPanda>	 marktraceur: comment from rillke on UW bug https://github.com/wikimedia/mediawiki-extensions-UploadWizard/commit/325b5ce20e82d00594480f10f749379c3549a65e#commitcomment-4144579
[18:56:40] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Changed the patch to remove the unneeded $wgUser instead to pass a user object from outside" [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[18:57:58] <grrrit-wm>	 (03CR) 10MaxSem: "I don't like this wording: first, for wikis using something other than CC, "subject to public domain" sounds weird, and second, the remova" [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[18:59:07] <marktraceur>	 I heard
[19:00:30] <grrrit-wm>	 (03PS29) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[19:00:39] <grrrit-wm>	 (03PS1) 10Santhosh: Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 
[19:01:09] <grrrit-wm>	 (03CR) 10Kaldari: "@MaxSem: I'll see if we can improve it per your suggestions." [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[19:01:22] <grrrit-wm>	 (03PS5) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[19:03:20] <grrrit-wm>	 (03PS4) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 
[19:04:56] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Waiting for further feedback from legal regarding Max's comments." [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[19:05:09] <grrrit-wm>	 (03PS5) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 
[19:06:50] <MatmaRex>	 !profiling
[19:06:50] <wm-bot>	 For information on how to enable profiling for MediaWiki, see <http://www.mediawiki.org/wiki/Profiling#Profiling>
[19:08:34] <grrrit-wm>	 (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:09:06] <ori-l>	 robla: I replied at https://gerrit.wikimedia.org/r/#/c/78669/28/includes/libs/lessc.inc.php
[19:09:19] <grrrit-wm>	 (03PS2) 10Nikerabbit: Fix empty message group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85254 (owner: 10Santhosh)
[19:10:20] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Fix empty message group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85254 (owner: 10Santhosh)
[19:10:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix empty message group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85254 (owner: 10Santhosh)
[19:10:32] <grrrit-wm>	 (03PS2) 10Nikerabbit: Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:10:53] <grrrit-wm>	 (03PS1) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[19:12:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:14:16] <grrrit-wm>	 (03CR) 10Mwjames: "???" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:14:41] <grrrit-wm>	 (03PS3) 10Nikerabbit: Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:14:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:18:13] <grrrit-wm>	 (03CR) 10Nikerabbit: "recheck" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:18:22] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] "Makes sense to me." [core] - 10https://gerrit.wikimedia.org/r/85221 (owner: 10Umherirrender)
[19:18:40] <grrrit-wm>	 (03CR) 10Santhosh: [C: 032] Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:18:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the message group selector work [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85260 (owner: 10Santhosh)
[19:21:05] <grrrit-wm>	 (03PS30) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[19:21:19] <manybubbles>	 ^d: looks like that phrase score boost stuff has still broken stuff.  I'm stil looking into it but we shouldn't push :)
[19:21:49] <Reedy>	 score += 9000
[19:22:04] <grrrit-wm>	 (03CR) 10Ori.livneh: "PS30: In comment header of lessc.inc.php, include full MIT license and a link to <https://github.com/leafo/lessphp/blob/master/LICENSE>." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[19:23:45] <MatmaRex>	 !maintenance
[19:23:45] <wm-bot>	 https://www.mediawiki.org/wiki/Manual:Maintenance_scripts
[19:23:54] <brion>	 should we be adding libraries like less to special:version?
[19:24:06] <grrrit-wm>	 (03PS10) 10Mwjames: SMW\Lua add framework to support Scribunto extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/56393 
[19:24:44] <ori-l>	 brion: I have no idea if it's a legal requirement (if that's what you're asking), but it's certainly a nice gesture
[19:24:59] <grrrit-wm>	 (03CR) 10Mwjames: "just a rebase" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/56393 (owner: 10Mwjames)
[19:25:02] <MatmaRex>	 Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 34951701 bytes) in /home/WWW/matmarex/WWW/testwiki/includes/profiler/ProfilerSimpleTrace.php on line 77
[19:25:05] <brion>	 yeah, in theory it's probably ok to just label lots of source :)
[19:25:06] * MatmaRex  stabs the profiler

[19:25:08] <brion>	 but it'd be ncie
[19:25:09] <Reedy>	 DENIED
[19:25:14] <grrrit-wm>	 (03PS3) 10Nikerabbit: Use gravatar for user profile image [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85146 (owner: 10Santhosh)
[19:25:35] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Use gravatar for user profile image [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85146 (owner: 10Santhosh)
[19:25:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use gravatar for user profile image [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85146 (owner: 10Santhosh)
[19:26:03] <ori-l>	 brion: should I update the patch? I'd prefer to submit a separate patch for that, I think.
[19:26:30] * ori-l  knows he's being over-eager but can't help it anyway.

[19:27:12] <MatmaRex>	 345.60% 63.363376  71014 - PPFrame_DOM::expand
[19:27:18] <brion>	 ori-l: yeah let's do that later
[19:27:19] <MatmaRex>	 can somebody tell me why this happens?
[19:27:27] <MatmaRex>	 i understand that it does and i should ignore these, okay
[19:27:28] <MatmaRex>	 but why.
[19:27:29] <MatmaRex>	 D:
[19:30:03] <ori-l>	 :Ɑ
[19:30:30] <Reedy>	 :D:
[19:30:59] <quiddity>	 Extension:CodeEditor - could some kind soul help Jafeluv with his query at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Disable_JS.2FCSS_highlighting_and_toolbar - I suspect he just wants a few lines to paste into his [[meta:User:Jafeluv/global.js]]
[19:31:14] <grrrit-wm>	 (03PS2) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[19:31:19] <quiddity>	 (see last post in thread)
[19:31:23] <mooeypoo>	 ori-l: D-: is what I often send my parents when I forget I'm in RTL. end up having to explain that, no, I'm not crying, I'm fine. Really. ... the troubles of rtl'ers are endless D-:
[19:31:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:31:49] <MatmaRex>	 graaaah
[19:31:51] <MatmaRex>	 14.29% 2.619880    788 - Parser::braceSubstitution-title-Szablon:Odn/id
[19:32:02] <MatmaRex>	 why in gods name does this template take so long when it's so trivial
[19:32:04] <MatmaRex>	 https://pl.wikipedia.org/w/index.php?title=Szablon:Odn/id&action=edit
[19:32:12] <MatmaRex>	 t's a single small #switch
[19:33:03] <MatmaRex>	 i'm profiling a different fish article today! (a smaller one)
[19:35:35] <grrrit-wm>	 (03PS6) 10Physikerwelt: First test to replace png->svg [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84925 
[19:36:47] <MatmaRex>	 stab stab stab
[19:36:53] <MatmaRex>	 can i trigger page rendering from command line?
[19:37:40] <Reedy>	 parse.php?
[19:37:58] <MatmaRex>	 actually, nevermind, i need to import that baby first
[19:38:27] <MatmaRex>	 thanks Reedy
[19:42:35] * hashar  gives MatmaRex some diapers

[19:43:34] <MatmaRex>	 gah
[19:43:47] <MatmaRex>	 how do i trigger rendering of an existing page from command line?
[19:44:05] <Reedy>	 Patch parse.php?
[19:44:06] <Reedy>	 :p
[19:44:51] <Reedy>	 php getText.php --title=foobar | php parse.php --title=foobar
[19:44:58] <Reedy>	 parse takes stdin
[19:45:00] <hashar>	 oh that is evil
[19:45:28] <Reedy>	 lets invoke mediawiki twice!
[19:45:49] <MatmaRex>	 if it works… thanks.
[19:45:53] <hashar>	 bah getText is hopefully pretty fast
[19:46:02] <Reedy>	 Other than that, it's a faux request to the api
[19:46:08] <hashar>	 I wrote parse.php to earn some karma on stackoverflow :-]
[19:47:25] <hashar>	 http://stackoverflow.com/questions/9343931/ 
[19:47:32] <hashar>	 "Convert Mediawiki wikitext format to HTML using command line"
[19:47:33] <Reedy>	 hashar: Do you want https://bugzilla.wikimedia.org/show_bug.cgi?id=54395 assigning to you? :p
[19:47:41] <hashar>	 I was like hmm.. lets not point the user to the evil eval.php
[19:47:55] <hashar>	 Reedy: unless it is related to browser testing the VisualEditor .. nop :-]
[19:48:47] <MatmaRex>	 matmarex@users:~/WWW/testwiki/maintenance$ php getText.php "Polskie nazewnictwo popularne ryb" | php parse.php --title "Polskie nazewnictwo popularne ryb"
[19:48:47] <MatmaRex>	 parse.php: warning: reading wikitext from STDIN. Press CTRL+D to parse.
[19:48:50] <MatmaRex>	 wtf.
[19:49:22] <Reedy>	 CTRL+D looks useful
[19:50:00] <MatmaRex>	 it doesn't need any ctrl+d if i passed the stdin via pipe
[19:50:08] <MatmaRex>	 fact: mediawiki sucks.
[19:50:09] <Reedy>	 lols
[19:50:18] <Reedy>	 Add a page parameter to parse.php
[19:50:26] <hashar>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=54395#c1 :D
[19:50:39] <hashar>	 MatmaRex: ahhh that is a bug
[19:51:05] <hashar>	 MatmaRex: it should not display that message if tty is not interactive
[19:52:02] <hashar>	 function Wikitext() it is
[19:52:08] <hashar>	 then use something like    Maintenance::posix_isatty( 0 /*STDIN*/ )
[19:52:14] <hashar>	 +easy
[19:52:24] <MatmaRex>	 +stab
[19:52:47] * hashar  ducks

[19:54:24] <grrrit-wm>	 (03PS3) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[19:56:28] <MatmaRex>	 oh crap, i ran it with profiler and it generated two megabytes of text
[19:56:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:57:39] <MatmaRex>	 63.59% 57.892496   4105 - Parser::callParserFunction-pfunc-tag
[19:57:42] <MatmaRex>	 oookay
[19:57:45] <MatmaRex>	 now somebody tell me
[19:57:57] <MatmaRex>	 is #tag this slow, or is it Cite's <ref>?
[19:58:10] <MatmaRex>	 who here knows how Parser works?
[19:58:15] <MatmaRex>	 oh right, i forgot, no onbe
[19:58:17] <MatmaRex>	 no one*
[19:58:18] <grrrit-wm>	 (03CR) 10Mwjames: "19:56:33 There was 1 error:" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:58:43] <grrrit-wm>	 (03PS1) 10Manybubbles: Another fix to phrase query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85321 
[19:59:07] <MatmaRex>	 why is the function that replaces templates called replaceVariables() D:
[19:59:42] <grrrit-wm>	 (03CR) 10Mwjames: "Not sure why this is happening." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[19:59:53] <T13>	 #tag is that slow MatmaRex 
[20:00:13] <Reedy>	 https://www.mediawiki.org/wiki/Manual:External_editors
[20:01:24] <grrrit-wm>	 (03PS2) 10Ejegg: LinkFilter: use wfMakeUrlIndexes in makeLikeArray [core] - 10https://gerrit.wikimedia.org/r/85199 
[20:01:55] <MatmaRex>	 T13: do you happen to know why?
[20:02:44] <T13>	 I don't
[20:03:24] <grrrit-wm>	 (03CR) 10Nikerabbit: "And the idiom "subject to" is more difficult to translate than the current wording." [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[20:06:49] <grrrit-wm>	 (03PS4) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[20:10:01] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase and WikimediaMessages [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85231 (owner: 10Aude)
[20:12:01] <^demon>	 MatmaRex: You gave me a good laugh :)
[20:12:03] <^demon>	 Thanks!
[20:12:40] * MatmaRex  stabs ^demon

[20:12:51] <^demon>	 For a compliment?
[20:12:55] <MatmaRex>	 ^demon: can you tell me why PPFrame_DOM::expand takes 300% of execution time?
[20:12:58] <^demon>	 Ok, I won't thank you next time :)
[20:12:58] <grrrit-wm>	 (03CR) 10Mwjames: "The registration was not quite right but thanks to our unit tests, they saved the day." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:13:02] <MatmaRex>	 ;)
[20:13:32] <MatmaRex>	 because i am completely unable to comprehend that
[20:13:45] <^demon>	 Maybe it ran 300% more times? ;-)
[20:14:10] <^demon>	 I would just assume it runs upwards of 95+% of the time and leave it at that.
[20:14:16] <grrrit-wm>	 (03PS5) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[20:14:19] <MatmaRex>	 278.96% 253.957631 270768 - PPFrame_DOM::expand
[20:14:20] <MatmaRex>	 231.82% 211.048667  35685 - Parser::braceSubstitution
[20:14:20] <MatmaRex>	 122.05% 111.112730   4186 - Parser::internalParse
[20:14:20] <MatmaRex>	 109.55% 99.737067  35674 - Parser::braceSubstitution-pfunc
[20:14:20] <MatmaRex>	 107.54% 97.905469  27721 - Parser::callParserFunction
[20:14:20] <MatmaRex>	 100.00% 91.038842      1 - -total
[20:14:22] <MatmaRex>	 WHYYYY
[20:15:50] <robla>	 heya ori-l - regarding the license of less, we have to actually include the full text of the GPLv3 somewhere
[20:16:25] <ori-l>	 really? even if lessphp's LICENSE says we're free to choose between it and MIT?
[20:16:36] <grrrit-wm>	 (03PS3) 10MaxSem: Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 
[20:16:50] <robla>	 ori-l: do we want to create an MIT-only fork of the code?
[20:16:53] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[20:17:22] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:18:09] <robla>	 ori-l: I suppose we might be able to get away with a URL reference to the GPLv3 since we'd be using it under the terms of MIT ourselves
[20:18:12] <ori-l>	 robla: we're not modifying it in any way, so if it's temporary, why not? I don't mind changing it once we update MediaWiki's COPYING. I'm happy to submit a patch for that, even.
[20:18:21] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:19:08] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:21:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make ResourceLoader minifiers extendable [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem)
[20:24:04] <robla>	 ori-l: ok, how about this.  Include up to line 37 of https://github.com/leafo/lessphp/blob/master/LICENSE and then...
[20:24:15] <grrrit-wm>	 (03PS1) 10Rillke: Replacing function.prototype.bind with jQuery.proxy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 
[20:24:23] <grrrit-wm>	 (03CR) 10Mattflaschen: "> not() is valid CSS <https://developer.mozilla.org/en-US/docs/Web/CSS/:not>." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[20:24:55] <robla>	 ...say "Please refer to http://www.gnu.org/licenses/gpl-3.0.html for the full text of the GPL version 3"
[20:25:26] <ori-l>	 robla: sure, OK. I think docs/licenses is a good idea too. I'll submit that as well as a follow-up patch.
[20:25:37] <ori-l>	 but I'll update the current patch per your suggestion right now.
[20:25:44] <robla>	 ori-l: perfect, thanks!
[20:25:56] <grrrit-wm>	 (03PS2) 10Rillke: Replacing function.prototype.bind with jQuery.proxy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 
[20:26:13] <grrrit-wm>	 (03PS3) 10Rillke: Replacing function.prototype.bind with jQuery.proxy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 
[20:28:33] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Replacing function.prototype.bind with jQuery.proxy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[20:28:56] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(I killed the github link and added change-id of that patch instead.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[20:30:42] <grrrit-wm>	 (03PS6) 10Mwjames: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 
[20:34:00] <grrrit-wm>	 (03CR) 10Rillke: "I like the github links because they allow me to link to line number directly." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[20:34:28] <grrrit-wm>	 (03CR) 10Mwjames: "(2 comments)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:34:59] <grrrit-wm>	 (03CR) 10Mwjames: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:40:42] <MatmaRex>	 is there a way to display profiler data in some sexier format than 30 megabytes of function calls?
[20:41:56] <ori-l>	 MatmaRex: xdebug can output traces in a format viewable in kcachegrind
[20:42:06] <ori-l>	 http://www.xdebug.org/docs/profiler
[20:42:15] <MatmaRex>	 (i mean the mediawiki profiler)
[20:42:22] <ori-l>	 there's also https://code.google.com/p/webgrind/, if you prefer, which is particular to PHP
[20:43:12] <marktraceur>	 anomie, I was supposed to chat with you about bawolff's extended image metadata API business - do you have some time to review it in the near future?
[20:43:21] <MatmaRex>	 hm, okay, there might be.
[20:43:32] <ori-l>	 MatmaRex: if you're intent on using that, you can use $wgProfileToDatabase = true; , i guess, and at least have something queryable
[20:43:44] <anomie>	 marktraceur: Link?
[20:43:48] <MatmaRex>	 yeah, i've found it now
[20:44:19] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[20:44:23] <grrrit-wm>	 (03PS1) 10Bsitu: Echo subscription should be set after category definition [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/85329 
[20:45:11] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:45:30] <marktraceur>	 anomie: https://gerrit.wikimedia.org/r/80403 and the linked core patches
[20:46:43] <grrrit-wm>	 (03PS31) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 
[20:48:04] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 031] \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[20:48:13] <grrrit-wm>	 (03PS5) 10Nemo bis: Replacing function.prototype.bind with jQuery.proxy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[20:48:21] <grrrit-wm>	 (03CR) 10Ori.livneh: "PS31: Updated copyright notice in comment header of lessc.inc.php to match robla's specifications." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[20:48:40] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Remove Settings::newFromGlobals [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 
[20:48:53] <grrrit-wm>	 (03PS4) 10Jeroen De Dauw: Deprecate assertException in MediaWikiTestCase as it adds no value [core] - 10https://gerrit.wikimedia.org/r/64499 
[20:49:45] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Work on cleaning up the diff code [DO NOT MERGE] [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/54868 (owner: 10Jeroen De Dauw)
[20:49:50] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Added PHPUnit test configuration file [DO NOT MERGE] [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/63897 (owner: 10Jeroen De Dauw)
[20:50:49] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Add getTablePrefix method to DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/52177 (owner: 10Jeroen De Dauw)
[20:52:09] <grrrit-wm>	 (03CR) 10Ejegg: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg)
[20:53:11] <MatmaRex>	 hmm. what mysql version does MW require?
[20:53:13] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Allow registration of special pages using a callback that returns an instance of SpecialPage [core] - 10https://gerrit.wikimedia.org/r/49777 (owner: 10Jeroen De Dauw)
[20:53:22] <MatmaRex>	 or, which is WMF using?
[20:53:33] <grrrit-wm>	 (03CR) 10Rillke: "Oh dear, git actually works this evening! How surprising. However, this is still not the diff-link :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[20:53:51] <Reedy>	 https://www.mediawiki.org/wiki/Special:Version
[20:53:53] <anomie>	 MatmaRex: Look at Special:Version.
[20:53:53] <legoktm>	 MatmaRex: Special:Version
[20:54:09] <ori-l>	 MatmaRex: Special:Version
[20:54:24] <MatmaRex>	 …
[20:54:30] <MatmaRex>	 asking, because
[20:54:35] <MatmaRex>	 // When we upgrade to mysql 4.1, the insert+update
[20:54:35] <MatmaRex>	 // can be merged into just a insert with this construct added:
[20:54:35] <MatmaRex>	 //     "ON DUPLICATE KEY UPDATE ".
[20:54:35] <MatmaRex>	 //     "pf_count=pf_count + VALUES(pf_count), ".
[20:54:35] <MatmaRex>	 //     "pf_time=pf_time + VALUES(pf_time)";
[20:54:37] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "It appears you need to make the same change in ForeignDBFile." [core] - 10https://gerrit.wikimedia.org/r/82085 (owner: 10Brian Wolff)
[20:54:57] <grrrit-wm>	 (03PS1) 10Yuvipanda: Use parser directly to parse wikitext [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 
[20:54:57] <MatmaRex>	 ^ that's a comment from Profiler.php.
[20:55:52] <YuviPanda>	 we've 'upsert' now
[20:56:05] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Another fix to phrase query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85321 (owner: 10Manybubbles)
[20:56:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Another fix to phrase query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85321 (owner: 10Manybubbles)
[20:56:11] <grrrit-wm>	 (03PS2) 10Yuvipanda: Use parser directly to parse wikitext [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 
[20:56:17] <YuviPanda>	 manybubbles: https://gerrit.wikimedia.org/r/#/c/85330/
[20:56:19] <ori-l>	 MatmaRex: file a bug, assign to springle
[20:56:23] <marktraceur>	 YuviPanda: That commit summary worries me
[20:56:28] <MatmaRex>	 also
[20:56:32] <YuviPanda>	 marktraceur: which one?
[20:56:32] <Reedy>	 Database Server
[20:56:32] <Reedy>	 MySQL 5.0.2 or later (*)
[20:56:35] <MatmaRex>	 Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 130968 bytes) in /home/WWW/matmarex/WWW/testwiki/includes/parser/Parser.php on line 1228
[20:56:37] <marktraceur>	 Oh, it's campaigns, never mind
[20:56:38] <YuviPanda>	 marktraceur: gah, english fail
[20:56:40] <Reedy>	 https://www.mediawiki.org/wiki/Installation
[20:56:43] <MatmaRex>	 that's it for profiling to database
[20:57:03] <ori-l>	 MatmaRex: /WWW/matmarex/WWW ?
[20:57:13] <grrrit-wm>	 (03PS3) 10Yuvipanda: Explicitly use $wgParser to parse wikitext [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 
[20:57:14] <MatmaRex>	 ori-l: i didn't come up with that structure
[20:57:15] <YuviPanda>	 marktraceur: better now!
[20:57:25] <marktraceur>	 No no, that wasn't my worry
[20:57:32] <MatmaRex>	 YuviPanda: no, worse. :D
[20:57:33] <marktraceur>	 I was worried we were trying to parse something user-provided
[20:57:35] <YuviPanda>	 marktraceur: what was?
[20:57:39] <YuviPanda>	 marktraceur: aaah
[20:57:41] <YuviPanda>	 marktraceur: well, I am :P
[20:57:52] <grrrit-wm>	 (03PS1) 10Chad: New extension [tools/release] - 10https://gerrit.wikimedia.org/r/85332 
[20:57:55] <marktraceur>	 YuviPanda: Yeah, but after form submit is long over
[20:58:03] <marktraceur>	 Not like...frickin...descriptions or something
[20:58:24] <YuviPanda>	 marktraceur: :P
[20:58:40] <YuviPanda>	 brion: have a patch for that UW issue: https://gerrit.wikimedia.org/r/#/c/85330/
[20:58:47] <brion>	 \o/
[20:58:48] <YuviPanda>	 brion: waiting for manybubbles to confirm if that fixes things
[20:58:52] * marktraceur  relocates to ze couch

[20:59:06] <manybubbles>	 oh, sorry, let me look
[20:59:26] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 031] "Looks good, but I don't have the stuff setup to confirm it fixes the issue. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 (owner: 10Yuvipanda)
[21:02:30] <grrrit-wm>	 (03PS2) 10Rtdwivedi: Added zoom buttons to the toolbar. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85205 
[21:02:51] <grrrit-wm>	 (03PS29) 10Rahul21: Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[21:03:23] <grrrit-wm>	 (03PS1) 10Chad: Updating Cirrus to master, grabbing new Elastica extension [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85334 
[21:03:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032 V: 032] Updating Cirrus to master, grabbing new Elastica extension [core] (wmf/1.22wmf18) - 10https://gerrit.wikimedia.org/r/85334 (owner: 10Chad)
[21:03:47] <anomie>	 marktraceur: Started looking, but I ran out of time for today. I already reviewed the API bit of 78926, FYI, although I haven't looked at it since PS7. Also, there's bug 53663 that seems to be related to all this metadata work.
[21:04:42] <marktraceur>	 'kay, thanks
[21:05:19] <marktraceur>	 anomie|away: We're looking to get the multimedia viewer business in a sane state around the end of october, if not deployed around then, so it would be amazing to merge the dependencies :)
[21:06:25] <grrrit-wm>	 (03CR) 10Nemo bis: "At your service! https://code.google.com/p/gitblit/issues/detail?id=313" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85324 (owner: 10Rillke)
[21:14:31] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[21:15:17] <Reedy>	 <div id="catlinks" class="catlinks catlinks-allhidden"></div>
[21:15:21] <Reedy>	 https://it.wiktionary.org/wiki/Speciale:Versione
[21:15:26] <Reedy>	 The category box is showing...
[21:16:11] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 
[21:16:12] <Nemo_bis>	 Reedy: empty?
[21:16:14] <^d>	 Shouldn't be my fault :p
[21:16:18] <Reedy>	 indeed
[21:16:22] <Reedy>	 It's not there on mediawiki.org
[21:16:23] <grrrit-wm>	 (03CR) 10Manybubbles: "Me too, unfortunately. The simplest way for me to confirm it is to push to beta and try it there." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 (owner: 10Yuvipanda)
[21:16:27] <Reedy>	 so presumably not a wmf18 issue
[21:16:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 (owner: 10Jeroen De Dauw)
[21:16:50] <^d>	 "<elasticsearchsearch-desc>"
[21:16:58] <^d>	 I should've rebuild l10n.
[21:17:20] <YuviPanda>	 brion: +2 patch, maybe? https://gerrit.wikimedia.org/r/85330
[21:17:30] <YuviPanda>	 brion: i'm also thinking of adding a parseInline to Parser.php
[21:19:12] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "Welp, let's go for it!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 (owner: 10Yuvipanda)
[21:19:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly use $wgParser to parse wikitext [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85330 (owner: 10Yuvipanda)
[21:19:19] <YuviPanda>	 manybubbles: ^
[21:19:27] <marktraceur>	 Leeeeroooooyyyyy Jeeeeeenkinnnnns
[21:19:28] <brion>	 worst case it breaks worse ;)
[21:19:30] <marktraceur>	 Wait
[21:19:39] <YuviPanda>	 hehe :P
[21:19:55] <marktraceur>	 Why didn't...OK, can you also merge the fix for the critical bug, since we apparently have a FUCK IT SHIP NOW attitude today?
[21:20:11] <YuviPanda>	 manybubbles: which one?
[21:20:30] <marktraceur>	 https://gerrit.wikimedia.org/r/85008
[21:20:31] <manybubbles>	 marktraceur: I think ^ was directed at you 
[21:20:34] <marktraceur>	 I assume that was a tabfail
[21:20:40] <marktraceur>	 6 line patch
[21:20:43] <marktraceur>	 Pretty bloody selfevident
[21:21:46] <manybubbles>	 ^d: beta isnt happywith you
[21:22:03] <Reedy>	 What's up with it?
[21:22:34] <manybubbles>	 Fatal error: require_once(): Failed opening required '/data/project/apache/common-local/php-master/extensions/Elastica/Elastica.php'
[21:22:59] <aude>	 :(
[21:23:08] <manybubbles>	 yeah
[21:23:27] <Reedy>	 eh
[21:23:32] <Reedy>	 Oh
[21:23:37] <Reedy>	 Does it need adding to the meta repo?
[21:23:53] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] Fix module loads to be in the hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85008 (owner: 10MarkTraceur)
[21:23:53] <Reedy>	 I suspect that'll be it
[21:23:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix module loads to be in the hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85008 (owner: 10MarkTraceur)
[21:25:14] <grrrit-wm>	 (03PS1) 10Reedy: Add Elastica [extensions] - 10https://gerrit.wikimedia.org/r/85335 
[21:25:30] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Add Elastica [extensions] - 10https://gerrit.wikimedia.org/r/85335 (owner: 10Reedy)
[21:25:44] <YuviPanda>	 marktraceur: that was merged :)
[21:26:16] <aude>	 someone can trigger https://integration.wikimedia.org/ci/job/beta-code-update/
[21:26:21] <aude>	 then it should update
[21:26:56] * Reedy  finds his labs password

[21:27:01] <YuviPanda>	 aude: it's building
[21:27:08] <aude>	 YuviPanda: ok
[21:27:08] <YuviPanda>	 aude: https://integration.wikimedia.org/ci/job/beta-code-update/12235/
[21:27:15] <aude>	 i see :)
[21:27:28] <marktraceur>	 Woot
[21:27:34] <marktraceur>	 YuviPanda: My heeeero
[21:28:28] <Reedy>	 https://integration.wikimedia.org/ci/job/beta-code-update/12235/
[21:28:29] <YuviPanda>	 spagewmf: were you telling me something about georgia yesterday?
[21:28:32] <Reedy>	 	
[21:28:32] <Reedy>	 Started by timer
[21:28:32] <Reedy>	 	
[21:28:32] <Reedy>	 Aborted by user reedy
[21:28:36] <Reedy>	 YuviPanda: YOU DID NOTHING
[21:28:46] <YuviPanda>	 Reedy: i did nothing! it was running!
[21:29:34] <Reedy>	 https://www.youtube.com/watch?v=puTtnqoqHLQ
[21:30:53] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 
[21:31:14] <spagewmf>	 YuviPanda: Ray Charles, Gladys Knight and the Pips, Randy Crawford or John Mayer? all fine songs, Ray's is a classic.
[21:31:34] <YuviPanda>	 spagewmf: the font, more like :P
[21:32:19] * marktraceur  likes Cartel's. Is a heretic.

[21:32:46] <grrrit-wm>	 (03PS1) 10Santhosh: Hide the pointing triangle of group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85336 
[21:35:12] <spagewmf>	 YuviPanda, prtksxna : I mentioned that https://commons.wikimedia.org/wiki/Special:UserLogin/signup uses 'Georgia,serif' for its numbers, so maybe teh awesome campaigns page should too.
[21:35:23] <YuviPanda>	 spagewmf: why not!
[21:35:31] * YuviPanda  makes change

[21:40:03] <grrrit-wm>	 (03PS4) 10Jeroen De Dauw: Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 
[21:40:16] <marktraceur>	 Damn it all to hell
[21:40:22] <marktraceur>	 Inconsistent behaviour.
[21:40:46] <YuviPanda>	 spagewmf: it looks weird with georgia
[21:40:57] <marktraceur>	 $result->setIndexedTagName( $allRepos, 'repo' ); $result->addValue( 'query', 'repos', $allRepos ); // seems consistent with how ['query']['pages'] is created, e.g.
[21:41:04] <marktraceur>	 But for some reason it comes out all wrong
[21:41:18] <marktraceur>	 Hm, maybe I need bloody integer indices for this to work.
[21:41:20] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[21:41:41] <spagewmf>	 YuviPanda, I'm not a designer, no worries. cf. Charlie Daniels on font: " 'cause hell's broke loose in Georgia and the devil deals it hard"
[21:42:05] <marktraceur>	 Great, but now the stupid JSON is fucked up.
[21:42:17] <grrrit-wm>	 (03PS1) 10Jackmcbarn: When logging feedback, use the page as the target [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/85338 
[21:43:11] <YuviPanda>	 spagewmf: heh
[21:43:48] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update dependency checks and magic loading [extensions/Maps] - 10https://gerrit.wikimedia.org/r/85339 
[21:51:34] <grrrit-wm>	 (03PS1) 10Manybubbles: Whitespace fixes in tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85341 
[21:54:31] <grrrit-wm>	 (03PS1) 10Manybubbles: Some more tests for phrase rescore. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85343 
[21:54:32] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add iiprop=repo for getting in-depth repo info [core] - 10https://gerrit.wikimedia.org/r/85344 
[21:55:49] <grrrit-wm>	 (03CR) 10MarkTraceur: "Could use review on how I'm indexing them - I tried to mimic how the page lists are done in imageinfo, but I'm not sure that's "correct" -" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur)
[21:56:29] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 (owner: 10EBernhardson (WMF))
[21:56:48] <grrrit-wm>	 (03CR) 10MarkTraceur: "With a healthy dash of ego, I've been using $wgInstantCommons and this URL to test the module:" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur)
[22:04:24] <grrrit-wm>	 (03PS1) 10Reedy: Add wfWaitForSlaves() call to refreshMessageBlobs.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/85346 
[22:06:18] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Added support for ctrl+a in the export code window. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/74594 (owner: 10Netbrain)
[22:07:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added support for ctrl+a in the export code window. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/74594 (owner: 10Netbrain)
[22:07:36] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] added extended copycoords parameter support. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78010 (owner: 10Netbrain)
[22:07:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: added extended copycoords parameter support. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78010 (owner: 10Netbrain)
[22:08:56] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[22:11:18] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:11:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:11:50] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] New extension [tools/release] - 10https://gerrit.wikimedia.org/r/85332 (owner: 10Chad)
[22:11:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: New extension [tools/release] - 10https://gerrit.wikimedia.org/r/85332 (owner: 10Chad)
[22:14:15] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:14:31] <grrrit-wm>	 (03PS1) 10Reedy: Add Elastica to .gitignore due to clone location being into the extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/85348 
[22:15:44] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:15:54] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:16:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added method to toggle kml (geoxml3) layers on and off. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/75839 (owner: 10Netbrain)
[22:16:12] <grrrit-wm>	 (03PS30) 10Rahul21: Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[22:17:15] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Draw polygon from $cur_data [extensions/Maps] - 10https://gerrit.wikimedia.org/r/38734 (owner: 10Nischayn22)
[22:17:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Draw polygon from $cur_data [extensions/Maps] - 10https://gerrit.wikimedia.org/r/38734 (owner: 10Nischayn22)
[22:17:21] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[22:17:25] <grrrit-wm>	 (03PS7) 10Jeroen De Dauw: Autocenter on Polygons and other shapes. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/36700 (owner: 10Nischayn22)
[22:18:47] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] "Nischayn22, can this be abandoned, or will you get it through?" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/36700 (owner: 10Nischayn22)
[22:18:53] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-2] Autocenter on Polygons and other shapes. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/36700 (owner: 10Nischayn22)
[22:21:56] <quiddity>	 MatmaRex: you get points for trying to help him at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Odd_access_issue   and bonus points for a funny (albeit snarky) youtube reposte, 
[22:21:59] <quiddity>	 but, I agree someone is needed who can really describe all the mistakes he has made in that pile of gibberish. 
[22:26:54] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Fix Leaflet problem with resource loader [extensions/Maps] - 10https://gerrit.wikimedia.org/r/85350 
[22:27:02] <YuviPanda>	 quiddity: i'm tempted to ask for proof of his 500mi claim
[22:27:07] <YuviPanda>	 but that'd just be trolling
[22:27:28] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: fix Leaflet problem with resource loader [extensions/Maps] - 10https://gerrit.wikimedia.org/r/49202 (owner: 10Pastakhov)
[22:28:28] <grrrit-wm>	 (03PS5) 10Jeroen De Dauw: Work on Element classes and their tests Change-Id: I4c826f360b1fa09ac5fe9c5d0bbdbdfd3ea400bf [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 
[22:28:31] <grrrit-wm>	 (03PS6) 10Jeroen De Dauw: Work on Element classes and their tests [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 
[22:30:40] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Abandon?" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/48084 (owner: 10Nischayn22)
[22:32:25] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Abandon?" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/38734 (owner: 10Nischayn22)
[22:32:57] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Needs a rebase" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain)
[22:33:50] <grrrit-wm>	 (03PS1) 10Qgil: Note about removing portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/85351 
[22:34:14] <Nemo_bis>	 quiddity: the user in question is in my mental ignore list; it's easy to implement thanks to the consistent use of bold
[22:35:03] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Conflicts with master, either fix or abandon" [extensions/SemanticExtraSpecialProperties] - 10https://gerrit.wikimedia.org/r/39041 (owner: 10Rotsee)
[22:35:26] <quiddity>	 indeed. But he really does spread gibberish quite regularly, and could use a trouting from someone he might listen to. 
[22:35:46] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "This commit is effectively obsolete now right?" [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/22064 (owner: 10Mtyeh411)
[22:36:32] <grrrit-wm>	 (03PS5) 10Jeroen De Dauw: Handling of shapes in Semantic Maps. [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/38696 (owner: 10Nischayn22)
[22:39:14] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Issues still not resolved plus not compatible with master without fixing - abandon?" [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/38696 (owner: 10Nischayn22)
[22:39:42] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-2] Handling of shapes in Semantic Maps. [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/38696 (owner: 10Nischayn22)
[22:40:01] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[22:40:04] <MatmaRex>	 quiddity: if i were omnipotent, it'd topic-ban him from answering questions at VPT
[22:40:10] <MatmaRex>	 just… food for thought.
[22:40:34] <Nemo_bis>	 good idea, let's not let the en.wiki ArbCom idle
[22:41:00] <Nemo_bis>	 usually he just posts on Jimbo's talk
[22:41:08] <Nemo_bis>	 which is the wiki's trashbin, so it makes sense
[22:42:09] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/85351 (owner: 10Qgil)
[22:42:16] <legoktm>	 I suppose we could just block him for spreading enough misinformation.
[22:42:56] <MatmaRex>	 one day, i will move Jimbo's talk page to WP:VIllage pump (Jimbo's talk page).
[22:43:13] <RoanKattouw>	 heh
[22:43:47] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Add current value into the textbox for googlemapsEditor [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/85352 
[22:44:36] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: add current value into the textbox for googlemapsEditor [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/38735 (owner: 10Nischayn22)
[22:45:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Note about removing portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/85351 (owner: 10Qgil)
[22:45:12] <quiddity>	 ha!
[22:45:20] <grrrit-wm>	 (03Abandoned) 10Mwjames: updateData() use Title->invalidateCache() instead of direct db-access [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/57853 (owner: 10Mwjames)
[22:45:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[22:46:28] <grrrit-wm>	 (03Abandoned) 10Mwjames: Split up responsibility and move diff update into DiffData [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/57701 (owner: 10Mwjames)
[22:47:07] <grrrit-wm>	 (03CR) 10Mwjames: [C: 032] \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[22:47:50] <grrrit-wm>	 (03PS31) 10Rahul21: Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[22:47:57] <grrrit-wm>	 (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[22:48:17] <superm401>	 ori-l, just a minor thing for the LESS embed mixin.
[22:48:32] <superm401>	 I'd prefer the spacing be exactly the same as CSSMin so I don't have to go test old versions of IE. :)
[22:48:42] <grrrit-wm>	 (03Abandoned) 10Mwjames: (Bug 53034) Handling redirects ($redirid == 0) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79790 (owner: 10Mwjames)
[22:49:19] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(5 comments)" [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82219 (owner: 10Netbrain)
[22:49:54] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "grmbl" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/81878 (owner: 10MaxSem)
[22:49:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: \SMW\Setup + \SMW\SetupTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/85263 (owner: 10Mwjames)
[22:50:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Profiling [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/81878 (owner: 10MaxSem)
[22:50:31] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "grmbl" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81880 (owner: 10MaxSem)
[22:50:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move hooks to a separate file [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81880 (owner: 10MaxSem)
[22:51:03] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "grmbl" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81881 (owner: 10MaxSem)
[22:51:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Profiling [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81881 (owner: 10MaxSem)
[22:52:04] <grrrit-wm>	 (03PS32) 10Rahul21: Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 
[22:52:41] <grrrit-wm>	 (03Abandoned) 10Mwjames: (Bug 54289) \SMW\CsvResultPrinter UTF-8 byte order mark [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84907 (owner: 10Mwjames)
[22:54:22] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Set correct default-value for offset [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/71324 (owner: 10MathiasLidal)
[22:54:59] <grrrit-wm>	 (03PS2) 10Kaldari: Changing default copyright notice per WMF Legal's suggestion. [core] - 10https://gerrit.wikimedia.org/r/85255 
[22:55:57] * MaxSem  attracts YuviPanda's attention to https://gerrit.wikimedia.org/r/#/c/82116/

[22:56:14] <grrrit-wm>	 (03PS2) 10Yuvipanda: optipng -o7 "$png" && advpng -z -4 "$png" && advdef -z -4 "$png" [core] - 10https://gerrit.wikimedia.org/r/82116 (owner: 10MaxSem)
[22:56:27] * MaxSem  thanks YuviPanda

[22:56:34] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] optipng -o7 "$png" && advpng -z -4 "$png" && advdef -z -4 "$png" [core] - 10https://gerrit.wikimedia.org/r/82116 (owner: 10MaxSem)
[22:56:41] <YuviPanda>	 yw, MaxSem
[22:57:31] <grrrit-wm>	 (03CR) 10Slaporte: [C: 031] "Approved by legal." [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[22:58:53] <YuviPanda>	 -dev bout to get less noisy!
[22:59:01] * YuviPanda  kills SMW messages to -dev

[22:59:24] <^d>	 YuviPanda: Can we send them to #wikimedia-staff? ;-)
[22:59:47] <YuviPanda>	 ^d: i need to convince someone to let grrrit-wm in...
[23:01:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: optipng -o7 "$png" && advpng -z -4 "$png" && advdef -z -4 "$png" [core] - 10https://gerrit.wikimedia.org/r/82116 (owner: 10MaxSem)
[23:01:39] <Nemo_bis>	 aww SMW messages are nice :(
[23:01:46] <grrrit-wm>	 (03CR) 10Yuvipanda: "Testing" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/85008 (owner: 10MarkTraceur)
[23:01:52] <Nemo_bis>	 am I now forced to join yet another channel
[23:03:33] <grrrit-wm>	 (03PS6) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[23:04:34] <grrrit-wm>	 (03CR) 10Nemo bis: "What if a wiki owner doesn't want to allow wiki pages with a different copyright? Perhaps this could be a separate message, triggered by I" [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[23:05:10] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Hide the pointing triangle of group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85336 (owner: 10Santhosh)
[23:05:13] <marktraceur>	 YuviPanda: Can't you reload the config without disconnecting?
[23:06:17] <YuviPanda>	 marktraceur: I could after writing code for live config reload. It isn't much, really.
[23:06:22] <YuviPanda>	 marktraceur: but I am lazy.
[23:06:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide the pointing triangle of group selector [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85336 (owner: 10Santhosh)
[23:07:56] <Nemo_bis>	 YuviPanda: hmpf, I thought you promised us 12 nines availability of grrrit-wm 
[23:08:07] <YuviPanda>	 Nemo_bis: it was in base 13
[23:08:19] <YuviPanda>	 Nemo_bis: and it still doesn't drop any messages sent in the interim
[23:08:23] <Nemo_bis>	 damn, I should read the clauses in small font
[23:08:42] <YuviPanda>	 :)
[23:10:40] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good. :)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[23:10:52] <grrrit-wm>	 (03CR) 10Mattflaschen: [V: 032] Enables user to upload pronunciations to the wiki. [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[23:11:37] <grrrit-wm>	 (03CR) 10Ori.livneh: "@Mattflaschen: Hm, I think I like your version better; the logic is clearer. I'll update and tweak the spacing while I'm at it." [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[23:12:28] <grrrit-wm>	 (03PS1) 10Nikerabbit: Use 180 days for language inactivity period [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85356 
[23:13:07] <grrrit-wm>	 (03PS7) 10Ori.livneh: Implement LESS image embedding [core] - 10https://gerrit.wikimedia.org/r/85143 
[23:13:48] <ori-l>	 superm401: ^
[23:14:15] <superm401>	 ori-l, alright, will review the main one later.
[23:17:22] <grrrit-wm>	 (03CR) 10MaxSem: [C: 031] Changing default copyright notice per WMF Legal's suggestion. [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[23:19:31] <grrrit-wm>	 (03CR) 10Kaldari: "They could always override the message with their own at MediaWiki:copyright. It's not just relevant to wikis that use InstantCommons, but" [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[23:19:53] <YuviPanda>	 manybubbles: did that patch fix testing on commons for you?
[23:20:06] <grrrit-wm>	 (03CR) 10Reedy: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur)
[23:20:09] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Support rate limiting backlink purges, including null edits [core] - 10https://gerrit.wikimedia.org/r/85358 
[23:22:13] <legoktm>	 MatmaRex: for some reason i'm getting errors like [16:20:54.152] TypeError: warnings is undefined @ http://127.0.0.1:8080/w/extensions/MassMessage/ext.MassMessage.badhtml.js:59
[23:22:26] <legoktm>	 that line is the warnings.show();
[23:23:01] <MatmaRex>	 legoktm: codeplz
[23:23:19] <legoktm>	 https://gerrit.wikimedia.org/r/#/c/85174/
[23:25:01] <grrrit-wm>	 (03CR) 10Nemo bis: "FWIW, not all wikis are as legalistic as Wikimedia projects. Even on Meta-Wiki, pre-2006-12-29 uploads are considered GFDL by default ({{G" [core] - 10https://gerrit.wikimedia.org/r/85255 (owner: 10Kaldari)
[23:26:52] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Support rate limiting backlink purges, including null edits [core] - 10https://gerrit.wikimedia.org/r/85358 
[23:27:24] <grrrit-wm>	 (03PS1) 10Rahul21: Fixed a small issue with the entry of "Pronunciation Recording Tool" in Special:SpecialPages [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85360 
[23:29:31] <MatmaRex>	 ori-l: the "embeddedImages" propertly on lessc instance is not used at all in the LESS patch. this is intended as a future placeholder, or just a holdover from something?
[23:29:33] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85360 (owner: 10Rahul21)
[23:30:02] <ori-l>	 MatmaRex: it is used by the follow-up patch, https://gerrit.wikimedia.org/r/#/c/85143/
[23:30:03] <MatmaRex>	 ori-l: apart from that it looks okay, haven't tested ;)
[23:30:05] <grrrit-wm>	 (03PS1) 10MarkTraceur: Reverse the colour scheme for MediaWiki [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/85361 
[23:30:16] <marktraceur>	 Hm, I should change that commit summary.
[23:30:23] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[23:30:28] <grrrit-wm>	 (03PS2) 10MarkTraceur: Reverse the colour scheme for MediaWiki [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/85361 
[23:30:40] <MatmaRex>	 ori-l: okay
[23:30:40] <ori-l>	 yay
[23:31:49] <MatmaRex>	 ori-l: i was also going to complain how you json_encode() stuff only to md5() it later, but i looked around a bit and it seems like PHP doesn't have a more appropriate function to do this :/
[23:32:21] <MatmaRex>	 (apparently serialize() is a lot slower)
[23:32:23] <ori-l>	 MatmaRex: json_encode is also (oddly) slightly more performant than PHP serialization for small arrays, at least by my benchmarks
[23:32:28] <ori-l>	 heh
[23:32:48] <MatmaRex>	 (i didn't do benchmarks, tbh, i just googled a bit)
[23:33:06] <grrrit-wm>	 (03PS1) 10Nikerabbit: Add link to add new project [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85363 
[23:33:07] <grrrit-wm>	 (03PS1) 10Nikerabbit: Replace link to special pages with link to support [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85364 
[23:33:08] <grrrit-wm>	 (03PS1) 10Nikerabbit: Remove the language name subtitle for user stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85365 
[23:33:36] <MatmaRex>	 ori-l: json_encode also has the issue that it depends on a PHP extension and might be missing,  but
[23:33:45] <ori-l>	 not as of 5.3, AFAIK
[23:33:48] <MatmaRex>	 but we have a core patch pending that implements a fallback, so whatever
[23:34:00] <ori-l>	 5.2, in fact
[23:34:37] <ori-l>	 http://php.net/manual/en/function.json-encode.php : (PHP 5 >= 5.2.0, PECL json >= 1.2.0) 
[23:35:02] <MatmaRex>	 ori-l: apparently some distros don't include it because of the 'not for evil' clause, or something
[23:35:07] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/78941/
[23:35:33] <ori-l>	 huh, odd
[23:36:20] <MatmaRex>	 http://www.json.org/license.html "The Software shall be used for Good, not Evil."
[23:36:34] <MatmaRex>	 these words have caused a lot of people a lot of trouble :D
[23:37:02] <grrrit-wm>	 (03PS1) 10Santhosh: Move statsbar construction to frontend [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85366 
[23:37:18] <grrrit-wm>	 (03CR) 10Swalling: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[23:38:49] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Much better" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85364 (owner: 10Nikerabbit)
[23:39:23] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "Wonderful patch, in my 100% cool-headed and objective assessment." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[23:40:02] <YuviPanda>	 ori-l: i'm tempted to +2
[23:40:18] <grrrit-wm>	 (03PS1) 10MarkTraceur: Play with the information sent back from the hook [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/85367 
[23:40:20] <ori-l>	 that's for brion, i think
[23:40:45] <YuviPanda>	 ori-l: heh, rue
[23:40:55] <grrrit-wm>	 (03PS2) 10Rahul21: Fixed a small issue with the entry of "Pronunciation Recording Tool" in Special:SpecialPages [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/85360 
[23:41:02] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 031] "Chocolate!" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[23:41:15] <ori-l>	 we need someone wiki-notable to blame if things go south
[23:41:40] <YuviPanda>	 ori-l: https://en.wikipedia.org/wiki/Brion_Vibber
[23:41:42] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] "Looks good to me. I don't quite understand why did we have the Special pages link there." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85364 (owner: 10Nikerabbit)
[23:41:48] <ori-l>	 right, that's what I mean
[23:41:52] <YuviPanda>	 heh :)
[23:42:13] <YuviPanda>	 ori-l: heh, interesting how https://en.wikipedia.org/wiki/Tim_Starling is elsewhere
[23:42:34] <MatmaRex>	 ori-l: in https://gerrit.wikimedia.org/r/#/c/85143/7 (the embed patch), are you checking for remote URIs? (do you need to check for them?)
[23:42:49] <MatmaRex>	 not sure if file_exists( $file ) is enough
[23:44:38] <ori-l>	 MatmaRex: do you mean that remote images should be fetched and embedded?
[23:44:52] <ori-l>	 or that URLs should be explicitly checked to ensure they are not remote?
[23:44:56] <MatmaRex>	 ori-l: no, i mean that they shouldn't
[23:44:57] <MatmaRex>	 yes
[23:45:29] <MatmaRex>	 unless you can prove to me that then don't need to be
[23:45:30] <ori-l>	 I mean, that's what the mixin is for; embedding local files. You'd just use background-image: otherwise
[23:45:57] <ori-l>	 I'd be amenable to renaming it to make it explicit, if you think it's potentially ambiguous
[23:46:03] <grrrit-wm>	 (03PS2) 10Nikerabbit: Add link to add new project [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85363 
[23:46:14] <ori-l>	 to something like '.embeded-background-image' or whatever
[23:46:17] <MatmaRex>	 encodeImageAsDataURI's file_get_contents() will happily send HTTP requests to get the "file" afaik
[23:46:48] <MatmaRex>	 same with filesize, apparently
[23:47:03] <RoanKattouw>	 Yeah, PHP's file handlers will load URLs
[23:47:08] <RoanKattouw>	 if PHP is configured to do so
[23:47:28] <RoanKattouw>	 I thought file_exists guarded against that though
[23:48:19] <grrrit-wm>	 (03PS1) 10Pginer: Font size and spacing adjustments [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85370 
[23:48:27] <RoanKattouw>	 Yup, it does
[23:48:38] <MatmaRex>	 hm, yeah
[23:48:43] <RoanKattouw>	 php > var_dump( file_get_contents('http://www.example.com/') );
[23:48:45] <RoanKattouw>	 string(1270) "<!doctype html>\n<html>\n"...
[23:48:47] <RoanKattouw>	 php > var_dump( file_exists('http://www.example.com/') );
[23:48:48] <RoanKattouw>	 bool(false)
[23:49:14] <MatmaRex>	 but, "As of PHP 5.0.0, this function can also be used with some URL wrappers. Refer to Supported Protocols and Wrappers to determine which wrappers support stat() family of functionality."
[23:49:29] <MatmaRex>	 http: doesn't seem to be one of the "wrappers", though
[23:51:03] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Font size and spacing adjustments [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85370 (owner: 10Pginer)
[23:51:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Font size and spacing adjustments [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85370 (owner: 10Pginer)
[23:53:11] <ori-l>	 MatmaRex: keep in mind that the URL also has to pass through getMimeType
[23:53:22] <ori-l>	 which must return a mime-type
[23:53:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Looks sane at a glance. I like it. (Didn't test.)" [core] - 10https://gerrit.wikimedia.org/r/85143 (owner: 10Ori.livneh)
[23:54:08] <MatmaRex>	 ori-l: i prefer explicit to implicit in cases like this :)
[23:54:24] <MatmaRex>	 ori-l: but yeah, file_exists won't get external URLs
[23:55:32] <MatmaRex>	 hmmm.
[23:55:57] <grrrit-wm>	 (03PS2) 10Amire80: Replace link to special pages with link to support [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85364 (owner: 10Nikerabbit)
[23:56:10] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Replace link to special pages with link to support [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/85364 (owner: 10Nikerabbit)
[23:56:35] <MatmaRex>	 ori-l: this might turn out to be an issue when we allow user-provided less to be compiled, though
[23:56:46] <MatmaRex>	 ori-l: as some of the wrappers are quite… exotic
[23:56:59] <MatmaRex>	 and will work with filesize, if one believes the manual
[23:57:38] <MatmaRex>	 file_exist*
[23:57:45] <MatmaRex>	 http://pl1.php.net/manual/en/wrappers.php.php http://pl1.php.net/manual/en/wrappers.ssh2.php http://pl1.php.net/manual/en/wrappers.ftp.php
[23:58:52] <MatmaRex>	 i say, let's reject anything with // or \\, unless php contains some useful function to actually check if something is a local file on a local filesystem without crazy uri wrappers