[00:00:21] (03PS2) 10Jackmcbarn: Store boolean values as integers with SQLite [core] - 10https://gerrit.wikimedia.org/r/84658 [00:04:03] (03CR) 10Aaron Schulz: [C: 032] Store boolean values as integers with SQLite [core] - 10https://gerrit.wikimedia.org/r/84658 (owner: 10Jackmcbarn) [00:04:21] mwalker: yes [00:05:51] Nikerabbit: ne'r mind; awight took care or something [00:07:04] greg-g: may I deploy another centralnotice thing? (https://gerrit.wikimedia.org/r/#/c/84673/) it turns out I deployed a small bug today [00:07:24] (03CR) 10Nikerabbit: [C: 032] Language aliases for Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 (owner: 10EBernhardson (WMF)) [00:07:58] (03Merged) 10jenkins-bot: Store boolean values as integers with SQLite [core] - 10https://gerrit.wikimedia.org/r/84658 (owner: 10Jackmcbarn) [00:10:58] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [00:12:06] (03CR) 10Nikerabbit: "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [00:17:16] (03PS1) 10Nikerabbit: Remove unused message [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/84683 [00:18:28] (03PS1) 10Manybubbles: Turn on phrase suggestion test. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84684 [00:22:39] (03PS1) 10MaxSem: Add package.json [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/84688 [00:22:56] (03CR) 10MaxSem: [C: 032 V: 032] Add package.json [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/84688 (owner: 10MaxSem) [00:23:11] (03PS1) 10Mwalker: Update CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84689 [00:23:29] (03CR) 10Mwalker: [C: 032] Update CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84689 (owner: 10Mwalker) [00:23:44] hasharBusy, is there a way to see the backtrace at https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/12256/consoleText ? [00:24:21] (03PS1) 10MarkTraceur: Add tests for HTML fields [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84691 [00:24:28] (03CR) 10jenkins-bot: [V: 04-1] Add tests for HTML fields [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84691 (owner: 10MarkTraceur) [00:24:28] bd808: ^^ FYI [00:24:35] Aw, never mind. [00:24:39] hahahaha! :P [00:25:53] MaxSem: can't look at it this week sorry :/ Bug fill it, I guess we are messing something like $wgShowExceptionDetails [00:25:57] or php dies :-D [00:26:19] YuviPanda: Apparently I have an old version of core, so while *I* thought it was passing, it wasn't. [00:26:24] I should probably cut that bit out. [00:26:29] jenkinsbot knows better [00:26:55] If I'm going to continue masquerading as having written unit tests, I should at least do a better job of pretending [00:27:33] (03PS1) 10Mwalker: Update CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84692 [00:27:46] (03CR) 10Mwalker: [C: 032] Update CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84692 (owner: 10Mwalker) [00:28:20] (03CR) 10CSteipp: "(3 comments)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal) [00:29:19] (03CR) 10Siebrand: [C: 032] Remove unused message [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/84683 (owner: 10Nikerabbit) [00:29:55] (03Merged) 10jenkins-bot: Remove unused message [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/84683 (owner: 10Nikerabbit) [00:36:25] (03PS3) 10BryanDavis: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 (owner: 10MarkTraceur) [00:37:15] (03CR) 10Siebrand: [C: 031] "I got a reply by email to my comment from Jared Zimmerman \\ Director of User Experience \\ Wikimedia Foundation:" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [00:37:32] (03CR) 10BryanDavis: [C: 032] "Approving especially for the "Something something beta." tagline." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 (owner: 10MarkTraceur) [00:37:44] (03Merged) 10jenkins-bot: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 (owner: 10MarkTraceur) [00:39:10] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [00:39:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "-1 per PS15." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [00:40:24] (03CR) 10Krinkle: "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [00:42:24] (03PS1) 10BryanDavis: Revert "Make final design changes" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84695 [00:44:00] (03CR) 10BryanDavis: "Sorry for the +2 abuse." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 (owner: 10MarkTraceur) [00:45:44] (03CR) 10Siebrand: "For future reference: This change was made to indicate that final copy will hit the repo soon. That's not a Good Thing (tm), though. This " [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 (owner: 10MarkTraceur) [00:46:10] (03PS3) 10Bsitu: Split the Echo API into their own write/read APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 [00:49:08] (03PS1) 10Physikerwelt: Fixing problem in the LaTeXMLImage class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84697 [00:49:09] (03CR) 10jenkins-bot: [V: 04-1] Fixing problem in the LaTeXMLImage class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84697 (owner: 10Physikerwelt) [00:49:19] (03CR) 10Krinkle: [C: 032] Revert "Make final design changes" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84695 (owner: 10BryanDavis) [00:49:28] (03Merged) 10jenkins-bot: Revert "Make final design changes" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84695 (owner: 10BryanDavis) [00:49:52] Krinkle: thanks [00:49:53] (03PS1) 10Krinkle: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84698 [00:50:04] yw [00:50:38] Hm.. strange, no Change-Id. Oh oh. [00:51:06] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [00:51:13] (03PS2) 10Physikerwelt: Fixing problem in the LaTeXMLImage class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84697 [00:51:41] (03PS1) 10Krinkle: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84699 [00:52:48] (03CR) 10Krinkle: "Used the Cherry-pick functionality to re-submit the change and removed the Change-Id since the old one was already closed expecting Gerrit" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84698 (owner: 10Krinkle) [00:52:51] (03PS5) 10Reedy: Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 (owner: 10Legoktm) [00:52:53] (03Abandoned) 10Krinkle: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84698 (owner: 10Krinkle) [00:52:56] (03CR) 10Reedy: [C: 032] Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 (owner: 10Legoktm) [00:52:57] * Krinkle files bug upstream to gerrit [00:53:08] (03Merged) 10jenkins-bot: Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 (owner: 10Legoktm) [00:54:06] (03PS2) 10Reedy: Display how many pages we have queued messages to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/84661 (owner: 10Legoktm) [00:54:10] (03CR) 10Reedy: [C: 032] Display how many pages we have queued messages to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/84661 (owner: 10Legoktm) [00:54:17] (03Merged) 10jenkins-bot: Display how many pages we have queued messages to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/84661 (owner: 10Legoktm) [00:54:44] Krinkle: Is it fixed now? I don't want Siebrand to hunt me down. [00:54:47] (03CR) 10Reedy: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [00:55:33] bd808: You're learning well [00:55:34] :D [00:55:36] bd808: I approved your revert, and submitted a new commit that matches the commit you originally had. From here you can change that commit again and have it go through the regular process. I didn't change any code. [00:56:38] (03CR) 10Physikerwelt: [C: 032] Fixing problem in the LaTeXMLImage class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84697 (owner: 10Physikerwelt) [00:56:53] Ok. So it's back to unmerged and ready for Mark to actually put in the text when it is delivered. Perfect. [00:57:38] (03PS4) 10Legoktm: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 [00:57:45] (03CR) 10jenkins-bot: [V: 04-1] Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [00:57:48] Reedy: I'd feel safer if I was back at home. He's a big dude. [00:59:31] Reedy: https://code.google.com/p/gerrit/issues/detail?id=2130 [01:01:45] (03PS5) 10Legoktm: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 [01:01:53] (03CR) 10jenkins-bot: [V: 04-1] Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [01:02:42] (03PS2) 10MarkTraceur: Add tests for HTML fields [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84691 [01:03:38] (03CR) 10Reedy: "Jenkins lies:" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [01:05:51] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [01:10:38] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle) [01:15:37] (03CR) 10Ori.livneh: "@Bartosz: OK. I'll try to think of a better solution." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [01:33:21] (03CR) 10Reedy: "0.008% on enwiki" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [01:37:58] /* @goddamnit */ [01:38:19] For what? The stats? :p [01:38:28] Are you still in the building? [01:38:35] no, @home [01:39:36] the far side of three is like the dark side of the moon [01:42:23] (03PS8) 10Krinkle: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [01:42:33] At least we know we can get there and back again [01:43:14] I should organize a third floor field trip to the other side of the third floor [01:43:22] to convince people it is capable of sustaining life [01:43:34] (03PS9) 10Krinkle: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [01:43:44] atmosphere 80% nitrogen, 20% oxygen [01:46:50] (03PS5) 10Krinkle: Move code for navigation collapsing to core [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [01:46:54] (03PS1) 10Reedy: Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 83 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84703 [01:47:37] (03CR) 10Krinkle: "Why does this depend on adding vector.collapsibleNav to core?" [core] - 10https://gerrit.wikimedia.org/r/83429 (owner: 10Jdlrobson) [01:50:49] (03PS1) 10Reedy: Fix Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 207 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/84704 [01:54:50] (03CR) 10Krinkle: "Better topic name than 'z'?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [02:03:40] (03CR) 10Krinkle: "Maybe use a directory named 'common' instead? Could potentially be used for other things, but as a start it would contain files made avail" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [02:07:37] (03CR) 10Krinkle: "@RoanKattouw: There's a few caching things going on (some of which may have changed since previous patch sets) that I'd like your review o" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [02:09:28] (03CR) 10Krinkle: [C: 04-1] "Don't reference files outside the module' scope. This causes a 404 error in debug mode, and is generally unpredictable and hard to maintai" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [02:10:03] (03PS4) 10MZMcBride: Adding a space character between links in the special page [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup) [02:10:32] (03CR) 10MZMcBride: ""Wrap the body of the message between 70 and 100 characters."" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup) [02:12:52] (03CR) 10MZMcBride: "Did you mean to abandon this?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [03:51:08] Krinkle: I took out the hook in PS12; explained why in PS11 [03:51:26] Krinkle: 'ResourceLoaderGetLESSVars', I mean [03:52:40] I like the font change on php.net [03:52:48] (I say apropos of nothing) [03:52:51] (03CR) 10Krinkle: "FIXME: It doesn't make sense to use either $.when or Promise#then here." [core] - 10https://gerrit.wikimedia.org/r/82615 (owner: 10Bartosz Dziewoński) [04:02:56] ori-l: OK [04:03:35] Yeah, php.net has been in beta for a month or 2 or so. Still changing every now and then. I opted-in when I first saw the banner. Are they default now? [04:04:03] Incognito says not yet [04:04:39] Yeah, I just deleted my cookies to check [04:04:43] I guess I opted in at some point [04:04:45] (03PS2) 10Krinkle: doc: Clean up documentation for StringUtils classes [core] - 10https://gerrit.wikimedia.org/r/84490 [04:07:01] (03PS13) 10Krinkle: ajaxify watch links on SpecialUnwatchedpages. [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [04:07:32] (03CR) 10Legoktm: "Not really. I think the concept (show stats on preview) and most of the implementation is good, just that breakdown by namespace is not ac" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [04:07:40] (03CR) 10jenkins-bot: [V: 04-1] Ajaxify watch links on SpecialUnwatchedpages [core] - 10https://gerrit.wikimedia.org/r/6143 (owner: 10Eranroz) [04:07:42] (03PS1) 10Ori.livneh: Make CSSMin::getMimeType public rather than protected [core] - 10https://gerrit.wikimedia.org/r/84716 [04:09:22] (03PS2) 10Krinkle: Make CSSMin::getMimeType public rather than protected [core] - 10https://gerrit.wikimedia.org/r/84716 (owner: 10Ori.livneh) [04:09:45] (03CR) 10Krinkle: [C: 031] "Avoid references to gerrit's numerical change ids." [core] - 10https://gerrit.wikimedia.org/r/84716 (owner: 10Ori.livneh) [04:10:09] noted [04:10:24] (03CR) 10Yuvipanda: [C: 032] "sense it makes." [core] - 10https://gerrit.wikimedia.org/r/84716 (owner: 10Ori.livneh) [04:10:47] ori-l: also noted on https://www.mediawiki.org/wiki/Git/Commit_message_guidelines [04:10:54] YuviPanda: you tested it that quickly? [04:11:20] I guess I shouldn't complain :P [04:11:38] ori-l: git grep showed me being used only at one place [04:11:45] in the same fle [04:11:46] so [04:11:58] yes, I'm just heckling as usual [04:12:08] Such a heckler. [04:12:12] i know, I also checked it only after merging :P [04:12:37] * ori-l heckles Elsie. [04:12:48] No kinky stuff! [04:12:50] :P [04:13:10] We can only guess what heckles is a euphemism for. [04:14:43] 'public static' [04:14:46] (03Merged) 10jenkins-bot: Make CSSMin::getMimeType public rather than protected [core] - 10https://gerrit.wikimedia.org/r/84716 (owner: 10Ori.livneh) [04:30:25] (03CR) 10Krinkle: "Can this be closed? Since this pending gerrit patch set is unlikely to get traction (the change is apparently not trivial nor resolves an " [core] - 10https://gerrit.wikimedia.org/r/9804 (owner: 10Platonides) [04:34:40] (03PS1) 10Krinkle: RefreshLinksJob: Replace use of empty() with explicit check [core] - 10https://gerrit.wikimedia.org/r/84720 [04:35:09] (03CR) 10Krinkle: "Untested." [core] - 10https://gerrit.wikimedia.org/r/84720 (owner: 10Krinkle) [04:35:36] (03CR) 10Krinkle: "Removed use of empty() in I561f03b0526685f5." [core] - 10https://gerrit.wikimedia.org/r/80064 (owner: 10Aaron Schulz) [04:38:56] (03PS1) 10Krinkle: Sanitizer: Remove redundant @private tags [core] - 10https://gerrit.wikimedia.org/r/84722 [04:39:22] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [04:40:04] (03CR) 10Yuvipanda: [C: 032] Sanitizer: Remove redundant @private tags [core] - 10https://gerrit.wikimedia.org/r/84722 (owner: 10Krinkle) [04:40:48] Krinkle: woah, 166 @private tags [04:41:12] most of them are from before private static existed in PHP so they are used on non-private members, that's fine [04:41:30] basically those are TODO: Figure out where it is used and make it really private [04:41:36] yeah [04:41:40] most using it on an actual private item, yeah, :P [04:41:49] easy enough to grep for [04:43:55] (03Merged) 10jenkins-bot: Sanitizer: Remove redundant @private tags [core] - 10https://gerrit.wikimedia.org/r/84722 (owner: 10Krinkle) [04:47:18] (03PS1) 10Krinkle: jquery.makeCollapsible: Use promise().done instead of when().then [core] - 10https://gerrit.wikimedia.org/r/84723 [04:47:37] (03CR) 10Krinkle: "Fix in I4df755a32c12448." [core] - 10https://gerrit.wikimedia.org/r/82615 (owner: 10Bartosz Dziewoński) [04:48:03] (03PS2) 10Krinkle: jquery.makeCollapsible: Use promise().done instead of when().then [core] - 10https://gerrit.wikimedia.org/r/84723 [04:59:34] YuviPanda: uga [04:59:40] Nikerabbit: booga [04:59:43] going to sleep now [04:59:45] but what's up [04:59:58] YuviPanda: ceiling fan [05:00:16] i don't have one [05:00:22] I eo [05:00:40] oho [05:03:54] sleep? now? [05:04:35] YuviPanda: oho as in Finnish oho? [05:07:42] ori-l: i seem to be completely drained of mental and physical energy [05:07:54] mitä oho on [05:07:59] Nikerabbit: what is the finnish oho? [05:08:13] YuviPanda: I just call that state 'San Francisco' [05:10:13] YuviPanda: Are you still up? We are on 11 but you should go to sleep. [05:10:36] bd808: yeah, was in bed for about 30-45 mins [05:10:42] couldn't seem to get proper sleep [05:10:45] but going to try again [05:10:56] Do. [05:11:26] night [05:11:26] YuviPanda: whoops [05:11:53] Nikerabbit: no response from or yet. I'll try to make the meeting but if not go on without me, I guess? [05:13:04] YuviPanda: :( [05:13:28] will try to make it, i promise :) [05:13:30] off now [05:13:33] second attempt at sleep [05:21:35] (03PS18) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [05:21:36] (03PS1) 10Ori.livneh: Make LESS embed() actually embed images [core] - 10https://gerrit.wikimedia.org/r/84726 [05:23:19] (03CR) 10Ori.livneh: "PS18: Rebase; I still need to address Krinkle's comments and provide better embed()." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [05:23:55] (03CR) 10jenkins-bot: [V: 04-1] Make LESS embed() actually embed images [core] - 10https://gerrit.wikimedia.org/r/84726 (owner: 10Ori.livneh) [05:24:06] whatever, jenkins. [05:28:11] i should probably leave the office [05:29:51] Reedy: Yes, you should. You should probably also eat. [05:30:09] yuri_k gave me a cookie [05:31:22] Reedy is on a mediawiki-config tear! [05:32:37] See if I can get most of the docroots condensed this week if mutante and I have more luck tomorrow [05:32:41] Fix all the things! [05:33:47] (03CR) 10Pginer: [C: 031] Better styling for login form [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82801 (owner: 10Santhosh) [05:49:14] (03PS1) 10Spage: README.md: mention sudo, other browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84729 [06:55:00] (03PS1) 10Rfaulk: fix - align client default hook call. [sartoris] - 10https://gerrit.wikimedia.org/r/84732 [06:55:01] (03PS1) 10Rfaulk: mod - refactor ssh_command to use SSHClient. [sartoris] - 10https://gerrit.wikimedia.org/r/84733 [06:55:21] (03CR) 10Rfaulk: [C: 032 V: 032] fix - align client default hook call. [sartoris] - 10https://gerrit.wikimedia.org/r/84732 (owner: 10Rfaulk) [06:55:30] (03CR) 10Rfaulk: [C: 032 V: 032] mod - refactor ssh_command to use SSHClient. [sartoris] - 10https://gerrit.wikimedia.org/r/84733 (owner: 10Rfaulk) [07:18:14] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [07:19:03] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [07:19:22] (03PS6) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [07:24:12] (03PS1) 10Legoktm: Only use wfWikiId() when submitting the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/84734 [07:28:17] (03PS7) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [07:29:02] (03CR) 10Mattflaschen: [C: 04-1] "See comment regarding @embed." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [07:47:36] hashar: hi, do you know why https://gerrit.wikimedia.org/r/#/c/81468/ keeps failing? when running them locally they pass for both Reedy and I [07:47:56] :x [07:48:19] gj legoktm [07:50:43] (03PS2) 10Legoktm: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 [07:56:03] ohai Reedy. whatcha think of https://gerrit.wikimedia.org/r/#/c/81468/ ? [07:56:32] i'm not sure why i didnt think of it originally, its a much simpler solution [08:03:34] meh, gnite [08:12:01] (03CR) 10Reedy: "As another note, the api module is list=allusers too..." [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [08:39:02] Heh... Why'd I have to come up with an idea for Gareth that involves replacing/rewriting some parts of it before I even have the time to continue the project. [08:39:17] Stupid nickserv... [08:42:13] (03PS2) 10Reedy: Make number of threads a configuration option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/84493 (owner: 10J) [08:42:19] (03CR) 10Reedy: [C: 032] Make number of threads a configuration option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/84493 (owner: 10J) [08:42:21] (03Merged) 10jenkins-bot: Make number of threads a configuration option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/84493 (owner: 10J) [08:43:39] (03CR) 10Reedy: "Need to make a changeset for the concurrent jobs to the puppet repo." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/84493 (owner: 10J) [08:48:54] (03CR) 10Reedy: [C: 04-1] "(2 comments)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [08:57:03] (03PS1) 10Mattflaschen: Declare tour as requiring wikitext, but it doesn't work yet. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84735 [09:06:04] (03PS2) 10Mattflaschen: Declare tour as requiring wikitext, but it doesn't work yet. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84735 [09:11:47] (03CR) 10J: "(2 comments)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [09:11:57] (03PS6) 10J: add unique constraint on transcode name, key [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 [09:11:58] (03PS1) 10Mattflaschen: Enable logging for firstedit tour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84736 [09:13:09] (03CR) 10Mattflaschen: [C: 032] "Self-merging simple config change after testing." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84736 (owner: 10Mattflaschen) [09:13:31] (03Merged) 10jenkins-bot: Enable logging for firstedit tour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84736 (owner: 10Mattflaschen) [09:13:52] (03PS1) 10Ori.livneh: CSSMin: factor out image encoding into encodeImageAsDataURI method [core] - 10https://gerrit.wikimedia.org/r/84737 [09:14:29] (03PS3) 10Mattflaschen: Declare tour as requiring wikitext, but it doesn't work yet. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/84735 [09:15:56] Reedy: 84737 is an easy one (mostly just moving a few lines) if you're up for it :P [09:17:02] oh wait, you're in this timezone, i forgot [09:17:10] go to sleep! [09:21:52] DanielFriesen: use SASL or a client certificate [09:21:59] and you'll never have to worry about nickserv [09:22:19] http://freenode.net/sasl/ , http://freenode.net/certfp/ [09:22:48] CertFP is nicer (you have your cloak immediately on login), SASL is easier to set up [09:28:47] ori-l: Lol... I don't think I can set either of those up on this client. [09:29:51] ori-l: I think I have my cloak on login with sasl [09:30:45] (03PS1) 10Rfaulk: fixes - to ssh_command_target and replace shelling in _check_lock. [sartoris] - 10https://gerrit.wikimedia.org/r/84739 [09:30:51] (03CR) 10jenkins-bot: [V: 04-1] fixes - to ssh_command_target and replace shelling in _check_lock. [sartoris] - 10https://gerrit.wikimedia.org/r/84739 (owner: 10Rfaulk) [09:32:08] (03PS2) 10Rfaulk: fixes - to ssh_command_target and replace shelling in _check_lock. [sartoris] - 10https://gerrit.wikimedia.org/r/84739 [09:32:26] (03CR) 10Rfaulk: [C: 032 V: 032] fixes - to ssh_command_target and replace shelling in _check_lock. [sartoris] - 10https://gerrit.wikimedia.org/r/84739 (owner: 10Rfaulk) [09:39:43] saper: yes, you're right -- SASL gets you that too. [09:41:20] (03PS1) 10Liangent: bug 54264 [core] - 10https://gerrit.wikimedia.org/r/84740 [09:42:34] (03CR) 10jenkins-bot: [V: 04-1] bug 54264 [core] - 10https://gerrit.wikimedia.org/r/84740 (owner: 10Liangent) [09:44:29] (03Abandoned) 10Liangent: bug 54264 [core] - 10https://gerrit.wikimedia.org/r/84740 (owner: 10Liangent) [10:10:53] ori-l: oh, at last they added some docs other than a blogpost linking another blogpost [10:17:15] (03PS8) 10Rjain: Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 [11:37:17] (03PS1) 10VitaliyFilippov: Disable type enforcement for properties with names equal to type names. [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84744 [11:45:54] (03PS3) 10Helder.wiki: jquery.makeCollapsible: Use promise().done instead of when().then [core] - 10https://gerrit.wikimedia.org/r/84723 (owner: 10Krinkle) [11:46:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84490 (owner: 10Krinkle) [11:46:48] (03PS3) 10Bartosz Dziewoński: doc: Clean up documentation for StringUtils classes [core] - 10https://gerrit.wikimedia.org/r/84490 (owner: 10Krinkle) [11:47:35] (03CR) 10Bartosz Dziewoński: [C: 032] doc: Clean up documentation for StringUtils classes [core] - 10https://gerrit.wikimedia.org/r/84490 (owner: 10Krinkle) [11:52:39] (03Merged) 10jenkins-bot: doc: Clean up documentation for StringUtils classes [core] - 10https://gerrit.wikimedia.org/r/84490 (owner: 10Krinkle) [11:53:05] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84737 (owner: 10Ori.livneh) [11:58:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, thanks. Will remember for the future :)" [core] - 10https://gerrit.wikimedia.org/r/84723 (owner: 10Krinkle) [12:01:59] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Use promise().done instead of when().then [core] - 10https://gerrit.wikimedia.org/r/84723 (owner: 10Krinkle) [12:05:59] (03PS1) 10Shirayuki: Add a full-stop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84745 [12:19:28] (03PS4) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [14:18:06] (03CR) 10Cscott: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [14:33:36] (03CR) 10Brion VIBBER: "Regarding the embed function:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [14:35:45] (03PS4) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [14:41:00] (03PS5) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [14:47:18] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Add a full-stop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84745 (owner: 10Shirayuki) [14:47:37] (03CR) 10EBernhardson (WMF): [V: 032] Language aliases for Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 (owner: 10EBernhardson (WMF)) [14:52:11] whats the best way to notify other teams of breaking changes from your extension that will probably effect them? Within Echo the read and write API calls were mixed into one, we are splitting into two calls and most likely, at a minimum, mobile will have to adjust [14:53:25] ebernhardson: start with a ping to wikitech-l i guess? [14:53:31] and maybe engineering@ also :) [14:53:45] just in case people aren't up on their public mailing lists [14:53:52] ok, makes sense will do :) [14:53:59] whee [14:54:26] hi ebernhardson [14:54:36] aude: hi! had a question for you too :) [14:54:41] yeah [14:54:48] how is it with adding the column? [14:55:25] aude: well, after talking it over with bsitu and mlitn, we just arn't convinced the kinds of queries required once we add the column make sense and just complicate the indexes involved [14:55:49] aude: what we were wondering, is what the benefit is of having RC_EXTERNAL + another flag, rather than continuing with more RC_* fields? Figured you probably thought about that before [14:55:49] hmmmmm [14:56:40] well, it's odd to have these constants in core and then be extension specific [14:56:49] if there was a way for extensions to better hook into it, that would be nice [14:56:57] e.g. define additional types [14:57:09] hmm, how is that handled with say, content namespaces? [14:57:38] namespaces? [14:57:44] like Wikipedia:Foo [14:57:55] don't some extensions have their own custom namespace (before the : ) [14:57:57] there is rc_namespace [14:59:09] rc_namespace looks to be an integer, whats the process for extensions to register their own integer for use there? [14:59:17] (sorry, i know very little about core stil :( ) [14:59:23] well, it's registering additional namespaces [14:59:43] easy to do, even in just local settings and no extensions [15:00:31] i'm wondering if we could do similar, but not quite sure [15:00:39] !wg NamespaceNames [15:00:39] https://www.mediawiki.org/wiki/Manual:$wgNamespaceNames [15:00:41] or something [15:01:20] https://www.mediawiki.org/wiki/Manual:$wgExtraNamespaces [15:01:51] this sort of implies that you are actually using that namespace to store content, not sure what flow is doing now [15:01:57] (but i think i suggested doing that) [15:02:13] hmm, that seems to avoid the real problem. Who defines the NS_* constants and makes sure they dont collide :) [15:02:24] no one :D [15:02:31] there's a huge list somewhere on mw.org [15:02:33] but thats the only problem i'm trying to solve :P [15:02:37] try to use something that isn't used yet [15:02:46] (but not for namespaces, for RC_* recentchanges log types) [15:02:51] https://www.mediawiki.org/wiki/Extension_default_namespaces [15:02:52] namespace constants are an issue that someday will be a problem [15:02:59] someday somehow [15:03:02] :) [15:03:08] there should be a registry of these [15:03:16] and managed so they do not collide [15:03:35] there are already a few conflicts listed there [15:03:50] (luckily in extensions basically no one uses anyway) [15:03:51] for rc_type it would be nice to do it in a more robust way to allow extensions to register types [15:03:55] MatmaRex: right [15:03:56] yea [15:04:07] i'm not liking the idea anymore of copying what mediawiki does already :P [15:04:09] for example, please don't take the wikibase namespaces :) [15:05:42] i'm not really sure how though, without some sort of on-wiki registry. Because the constants are not just used in runtime but written to a DB that have to be consistent regardless of how its initialize [15:05:57] ebernhardson: right [15:06:03] * ebernhardson has mediocre english skills in the morning :P [15:09:13] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84737 (owner: 10Ori.livneh) [15:09:13] ooh new seed of Safari 6.1 [15:10:50] sandboxed plugins! finally :P [15:11:03] ooooh CSS regions in the web engine [15:11:19] so, you can use that on prod in what, 8 years ? :) [15:11:27] and vertical text! [15:11:30] hehe seriously [15:11:58] image-set ….. but no srcset that i see listed [15:12:03] vertical text :) [15:12:29] (03PS5) 10KartikMistry: Show "For all languages" and no stats bar for source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84107 (owner: 10Amire80) [15:12:52] <^d> Safari. Heh, < 5% of our traffic. [15:13:11] yep, definitely no srcset [15:13:21] guess that'll be safari 6.1 or 7 :P [15:13:31] er [15:13:33] 6.2 or 7 [15:14:06] <^d> When do we get Mavericks? [15:14:55] they haven't announced yet :( [15:15:07] <^d> :( [15:15:12] but we get iOS 7 today! [15:15:28] i'll pack up my other iPad and refresh incessantly until it shows up [15:15:43] or i could download it myself from the dev site, but that's cheating [15:16:09] aude: well, i guess i'll have to think about it. Maybe bsitu will have some ideas when he gets into work today [15:16:14] (03PS1) 10Luis Felipe Schenone: Updated and renamed version of AvbDisqus [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 [15:16:57] <^d> brion: I don't own any iOS devices :p [15:17:07] ebernhardson: ok [15:17:08] ^d: good! iOS is evil [15:17:26] i'm not sure about an extra lookup table [15:17:34] yet another thing to join [15:17:36] * brion withholds qualcomm drivers from ^d [15:17:52] but for vast majority of rc entries, rc_external_type would be null [15:19:34] <^d> brion: Qualcomm is evil :( [15:19:51] <^d> And from what I hear, a their SoCs are a bitch to develop on. [15:19:59] can't you just get a Raspberry Pi and hack a cell phone onto it? [15:20:23] <^d> I'm not 1337 enough. [15:20:39] aude: well, vast for now :) talk NS edits account for ~20% of the recent changes table. We will start out small but if Flow works well it should eventually at least match that 20% [15:20:54] oooh [15:21:06] i suppose wikidata changes are a lot also [15:21:38] if they were small, probably wouldn't need the filter that hides them by default in Special:Recentchanges :) [15:22:19] http://dpaste.com/1386354/ [15:22:24] that is random wiki, svwiki [15:23:24] * aude queries enwiki [15:23:31] enwiki: http://dpaste.com/1386355/ [15:23:38] lol, more than a few :) [15:23:48] yeah [15:25:36] that's why we are not using something like change tags [15:25:40] definitely thought about it [15:25:53] but don't know how it scales [15:28:33] (03CR) 10EBernhardson (WMF): "One thought, when we deploy this change anything that integrates with the Echo API (mobile) will start doing the "wrong thing" in regard" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [15:43:21] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 (owner: 10Luis Felipe Schenone) [15:48:29] (03PS1) 10Physikerwelt: Failsave method for highlighting [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/84755 [15:49:36] (03CR) 10Physikerwelt: [V: 032] Failsave method for highlighting [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/84755 (owner: 10Physikerwelt) [15:49:49] (03CR) 10Physikerwelt: [C: 032] Failsave method for highlighting [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/84755 (owner: 10Physikerwelt) [15:50:59] (03PS2) 10Luis Felipe Schenone: First commits and fixes to new extension [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 [15:51:58] (03CR) 10Krinkle: [C: 04-1] "If the heading is optional (or rather, Mobile intends to use they own heading, it should never be without a heading, just not this heading" [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt) [15:52:15] (03CR) 10Krinkle: "Also, what kind of heading do you intend to create for mobile?" [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt) [15:53:41] (03PS2) 10Krinkle: Make the "Categories:" HTML heading optional in getCategoryLinks() [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt) [15:55:54] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 (owner: 10Luis Felipe Schenone) [15:58:02] (03CR) 10Krinkle: "These comments are all about the existing code. I've made a ton of changes already. I'd prefer to only include more changes in this commit" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [15:58:38] (03CR) 10Siebrand: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [15:59:26] (03PS5) 10Krinkle: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 [16:00:56] (03PS3) 10Luis Felipe Schenone: First commits and fixes to new extension [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 [16:00:57] (03PS6) 10Krinkle: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 [16:01:06] (03CR) 10Krinkle: "Rebased patch set 4, resolved merge conflict." [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:01:43] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "Did some last fixes, I think it's ready now." [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/84751 (owner: 10Luis Felipe Schenone) [16:01:45] (03CR) 10Krinkle: "Removed window. host from clearTimeout and setTimeout calls." [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:04:55] (03CR) 10Siebrand: "I see that Flow does not have Jenkins jobs yet. Is it time to add them? If so, create a request in bugzilla for that, please." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 (owner: 10EBernhardson (WMF)) [16:08:15] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [16:10:03] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [16:15:49] (03CR) 10Mwjames: "I haven't looked at the change itself but a behavioural change (as described in the commit message) should be accompanied by a unit test." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84744 (owner: 10VitaliyFilippov) [16:16:34] (03PS4) 10Krinkle: Use wfResetOutputBuffers in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74570 (owner: 10Hoo man) [16:18:10] Nemo_bis: hey! have you guys seen anything wrong with CirrusSearch in itwiktionary? I ask because I want to start rolling it out to other interested parties but if you've found something horrible I should fix it first. [16:20:54] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:22:07] (03PS1) 10Manybubbles: Highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84761 [16:24:20] (03PS1) 10Manybubbles: Tests for highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84762 [16:26:23] (03PS3) 10Anomie: Fix SQLite being incompatible with AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 (owner: 10Jackmcbarn) [16:26:32] (03CR) 10Anomie: [C: 032] Avoid connecting to central database when not necessary [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 (owner: 10Jackmcbarn) [16:26:40] (03Merged) 10jenkins-bot: Avoid connecting to central database when not necessary [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 (owner: 10Jackmcbarn) [16:26:51] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:26:52] (03PS7) 10Krinkle: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 [16:30:18] (03PS2) 10Krinkle: Fully log exceptions within resource loader (including traces) [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [16:31:04] (03CR) 10Krinkle: [C: 031] "Looks good, but wondering why you want these in particular (we don't call logException by default, so why for these?). Fine to merge I gue" [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [16:32:46] (03PS6) 10Krinkle: Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [16:32:47] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, let's do this. There are like 20 people on the reviewer list, if any of them had any comments, they would speak up during those two " [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:33:12] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [16:37:07] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Fix async issues with postWithEditToken [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [16:37:14] (03PS1) 10Krinkle: mediawiki.api: Simplify done/fail calls by chaining [core] - 10https://gerrit.wikimedia.org/r/84765 [16:38:32] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [16:38:53] (03Merged) 10jenkins-bot: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [16:41:39] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82122 (owner: 10Hoo man) [16:42:50] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Simplify done/fail calls by chaining [core] - 10https://gerrit.wikimedia.org/r/84765 (owner: 10Krinkle) [16:43:22] (03PS1) 10Manybubbles: Default to two replicas per shard. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84766 [16:43:49] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82122 (owner: 10Hoo man) [16:45:47] (03Merged) 10jenkins-bot: mediawiki.api: Simplify done/fail calls by chaining [core] - 10https://gerrit.wikimedia.org/r/84765 (owner: 10Krinkle) [16:48:15] (03CR) 10Chad: [C: 032 V: 032] Remove dl() usage [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/83938 (owner: 10Chad) [16:48:56] (03CR) 10Aaron Schulz: "I see DB exceptions in dberrors but not the exception log, meaning something is catching them and leaving no backtrace. Tweaking these kin" [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [16:49:15] (03CR) 10Chad: [C: 032] RefreshLinksJob: Replace use of empty() with explicit check [core] - 10https://gerrit.wikimedia.org/r/84720 (owner: 10Krinkle) [16:49:50] (03CR) 10Krinkle: [C: 032] Fully log exceptions within ResourceLoader (including traces) [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [16:50:57] (03CR) 10Chad: "Needs rebase." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 (owner: 10Manybubbles) [16:52:03] (03CR) 10Krinkle: "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 (owner: 10MarkTraceur) [16:52:37] (03Merged) 10jenkins-bot: RefreshLinksJob: Replace use of empty() with explicit check [core] - 10https://gerrit.wikimedia.org/r/84720 (owner: 10Krinkle) [16:52:53] (03PS2) 10Manybubbles: Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 [16:54:01] (03CR) 10Bsitu: "That's a good point. In addition, It may take some time for the js code to be updated during deploy, that will result in js code making A" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [16:54:22] (03Merged) 10jenkins-bot: Fully log exceptions within ResourceLoader (including traces) [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [16:54:41] (03CR) 10Bsitu: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [16:55:09] (03CR) 10Chad: [C: 032] Escape queries that use ~ incorrectly. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 (owner: 10Manybubbles) [16:55:22] (03Merged) 10jenkins-bot: Escape queries that use ~ incorrectly. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 (owner: 10Manybubbles) [16:55:23] (03CR) 10Chad: [C: 032] Turn on phrase suggestion test. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84684 (owner: 10Manybubbles) [16:55:29] (03Merged) 10jenkins-bot: Turn on phrase suggestion test. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84684 (owner: 10Manybubbles) [16:56:40] (03CR) 10Chad: [C: 032] Highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84761 (owner: 10Manybubbles) [16:56:44] (03Merged) 10jenkins-bot: Highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84761 (owner: 10Manybubbles) [16:57:24] (03CR) 10Chad: [C: 032] Tests for highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84762 (owner: 10Manybubbles) [16:57:34] (03Merged) 10jenkins-bot: Tests for highlighting and search operator fixes. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84762 (owner: 10Manybubbles) [16:57:41] (03CR) 10Chad: [C: 032] Default to two replicas per shard. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84766 (owner: 10Manybubbles) [16:57:44] (03Merged) 10jenkins-bot: Default to two replicas per shard. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84766 (owner: 10Manybubbles) [16:57:52] (03CR) 10Chad: [C: 032] Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 (owner: 10Manybubbles) [16:57:53] (03CR) 10jenkins-bot: [V: 04-1] Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 (owner: 10Manybubbles) [16:58:10] (03CR) 10Aaron Schulz: [C: 032] Use wfResetOutputBuffers in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74570 (owner: 10Hoo man) [16:58:26] (03CR) 10Chad: "If we've upgraded on all nodes, can this go in now?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79087 (owner: 10Manybubbles) [16:58:37] ^d: https://gerrit.wikimedia.org/r/#/c/84670/ [16:59:09] (03CR) 10Chad: [C: 032] Removed b/c code that triggered long key errors [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/84670 (owner: 10Aaron Schulz) [16:59:11] (03Merged) 10jenkins-bot: Removed b/c code that triggered long key errors [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/84670 (owner: 10Aaron Schulz) [16:59:47] ^d: and https://gerrit.wikimedia.org/r/#/c/84675/ [17:00:17] (03CR) 10Chad: [C: 032] Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/84675 (owner: 10Aaron Schulz) [17:00:35] ^d: oh, and https://gerrit.wikimedia.org/r/#/c/84678/ :) [17:00:36] (03Merged) 10jenkins-bot: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/84675 (owner: 10Aaron Schulz) [17:01:07] (03CR) 10Krinkle: "Untested, but looks fine overal from a generic js point of view. Someone else should review though." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 (owner: 10MarkTraceur) [17:01:22] (03Merged) 10jenkins-bot: Use wfResetOutputBuffers in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74570 (owner: 10Hoo man) [17:01:22] bd808: https://gerrit.wikimedia.org/r/#/c/84655/ [17:01:26] (03CR) 10Chad: [C: 032] Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84678 (owner: 10Aaron Schulz) [17:03:24] (03Merged) 10jenkins-bot: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84678 (owner: 10Aaron Schulz) [17:25:20] (03CR) 10Anomie: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [17:25:32] (03PS5) 10Anomie: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 [17:25:33] (03PS4) 10Anomie: Separate RevDel logic from UI [core] - 10https://gerrit.wikimedia.org/r/70748 [17:25:45] (03PS6) 10Anomie: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 [17:25:47] (03PS5) 10Anomie: Separate RevDel logic from UI [core] - 10https://gerrit.wikimedia.org/r/70748 [17:26:14] (03CR) 10Anomie: "PS4: Rebase" [core] - 10https://gerrit.wikimedia.org/r/70748 (owner: 10Anomie) [17:26:31] (03CR) 10Anomie: "PS5: Rebase" [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [17:32:35] (03PS1) 10Chad: Remove xdiff-backed HistoryBlob implementation [core] - 10https://gerrit.wikimedia.org/r/84770 [17:33:26] stab stab stab [17:39:04] Reedy: commonswiki transcode 1558 duplicates on transcode_image_name,transcode_key (90K total) [17:39:09] jfyi [17:40:16] (03PS3) 10Manybubbles: Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 [17:44:26] (03CR) 10Manybubbles: [C: 032] "Rebased pretty clean and Chad already approved of it so I'll self +2." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 (owner: 10Manybubbles) [17:44:29] (03Merged) 10jenkins-bot: Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 (owner: 10Manybubbles) [17:47:53] (03PS2) 10Nikerabbit: Make the project tiles go to project page if one exists [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83081 [17:49:25] (03CR) 10PleaseStand: [C: 04-1] "You can't delete even the code to *decode* DiffHistoryBlobs, since they are definitely still in external storage (unless I'm unaware of so" [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [17:50:12] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84771 [17:52:47] (03Abandoned) 10Chad: Remove xdiff-backed HistoryBlob implementation [core] - 10https://gerrit.wikimedia.org/r/84770 (owner: 10Chad) [17:53:59] springle: the duplicate rows can go. Everything is the same bar transcode_id (obviously) [17:54:11] Only addjob time differs (who cares), the other times are the same [17:54:18] Reedy: right. thanks [17:54:22] (03PS1) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 [17:54:36] Presumably due to an update using where transcode_image_name, transcode_key which updates all the rows [17:55:50] (03CR) 10Manybubbles: "I think we should wait until we upgrade production but I'll get to it as soon after that as I can." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79087 (owner: 10Manybubbles) [18:10:57] (03CR) 10Springle: "Schema changes are done." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [18:11:16] Reedy: AaronSchulz ^ [18:11:31] I'll deploy the change to commons [18:11:43] so it picks up the INSERT IGNORE [18:11:52] (03CR) 10Reedy: [C: 032] add unique constraint on transcode name, key [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [18:11:56] (03Merged) 10jenkins-bot: add unique constraint on transcode name, key [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [18:13:21] (03PS1) 10Reedy: Update TimedMediaHandler to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84773 [18:13:39] (03CR) 10Reedy: [C: 032 V: 032] Update TimedMediaHandler to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84773 (owner: 10Reedy) [18:17:25] (03PS1) 10Bsitu: Reviving the lost gerrit patch - 82800 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84774 [18:17:54] greg-g: I have yet another CentralNotice patch that I'd love to push at noon today [18:18:11] :) [18:18:14] https://gerrit.wikimedia.org/r/#/c/84676/ [18:18:27] patches patches everywhere and not a one to merge [18:18:28] or something [18:19:26] damn you zuul! taking away all the merges! [18:21:11] greg-g: ok; updated! also; I have a grand master plan to have the local time deployment column be in the autodetected local time :D [18:22:12] mwalker: whoa! [18:22:52] (03PS2) 10Ori.livneh: CSSMin: factor out image encoding into encodeImageAsDataURI method [core] - 10https://gerrit.wikimedia.org/r/84737 [18:22:58] mwalker: and yeah, just make sure csteipp is done with his stuff before you start (I assume he will be, he just started) [18:23:05] yep yep [18:23:08] mwalker: Sounds like voodoo to me... [18:23:13] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84776 [18:23:28] Reedy: it'll be an update to Common.js [18:23:38] mwalker: Sounds like voodoo to me... [18:23:43] truth [18:24:00] (03PS2) 10BryanDavis: Fixed check of BagOStuff set() return value in mctest [core] - 10https://gerrit.wikimedia.org/r/84655 (owner: 10Aaron Schulz) [18:24:50] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84776 (owner: 10CSteipp) [18:26:14] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84777 [18:26:48] (03CR) 10BryanDavis: [C: 032] "Looks good to me. MemCachedClientforWiki::set() returns bool and this accounts for that." [core] - 10https://gerrit.wikimedia.org/r/84655 (owner: 10Aaron Schulz) [18:29:20] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84777 (owner: 10CSteipp) [18:30:54] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Reviving the lost gerrit patch - 82800 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84774 (owner: 10Bsitu) [18:33:22] (03Merged) 10jenkins-bot: Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84776 (owner: 10CSteipp) [18:36:34] (03Merged) 10jenkins-bot: Fixed check of BagOStuff set() return value in mctest [core] - 10https://gerrit.wikimedia.org/r/84655 (owner: 10Aaron Schulz) [18:39:41] (03PS5) 10Bsitu: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [18:39:43] (03CR) 10jenkins-bot: [V: 04-1] Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [18:42:15] YuviPanda_zz: wakie wakie [18:45:51] Part of me wants to replace most of the wiki docroots with smylinks... [18:46:35] (03PS6) 10Bsitu: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [18:48:16] Who owns GettingStarted? [18:48:22] <^d> Newbies? [18:48:27] * Reedy beats ^d [18:48:32] /who do I need to ask about enabling it on commons/wikimania2014wiki [18:48:50] E[23] [18:48:58] spagewmf: ^ [18:50:48] (03CR) 10Bsitu: [C: 031] Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [18:51:21] Reedy, talk to PM Steven Walling, for tech issues superm401. The trick is configuring GettingStarted to maintain sets of pages for the appropriate easy tasks, plus having guided tours for those easy tasks for the user to [Show help] [18:51:38] (03PS3) 10EBernhardson (WMF): Display post creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83032 [18:51:46] (03CR) 10Bsitu: "Kaldari, I rebased the patch and removed some png files. Feel free to merge it if you agree with these changes, :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [18:52:03] See https://meta.wikimedia.org/wiki/Growth (formerly E3) [18:52:40] (03Abandoned) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84771 (owner: 10Chad) [18:53:25] Reedy, Commons probably has suitable categories that can be used for a backlog. [18:53:35] If so, the first step is to identify them. [18:54:10] By way of comparison, on enwiki we use All_articles_needing_copy_edit, All_Wikipedia_articles_needing_clarification, and All_articles_with_too_few_wikilinks [18:54:13] I've CC'd him on the 2 bugs [18:54:20] The more newbie friendly the better. [18:54:44] Reedy: as an alternative, if the wiki has pages/templates with a [Sign up now!] link, then page owners can manipulate returnto param to go to some "Now you've signed up...(read a 5,000 word introduction to scare you off)" page. [18:57:53] (03CR) 10Chad: [C: 032] Fixed OracleUpdater::doPageRestrictionsPKUKFix prefix [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66042 (owner: 10Freakolowsky) [18:58:58] (03CR) 10Chad: [C: 032] Changed quoting function for oracleDB. [core] - 10https://gerrit.wikimedia.org/r/65626 (owner: 10Freakolowsky) [18:59:29] (03CR) 10Chad: [C: 032] Changed tableName so it returns uppercased table names (+prefix) Changed tableExists so it returns boolean (and closes resource when it's do [core] - 10https://gerrit.wikimedia.org/r/65630 (owner: 10Freakolowsky) [18:59:37] (03CR) 10Chad: [C: 032] Fixed EZConnect string regex in OracleInstaller class. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66324 (owner: 10Freakolowsky) [19:00:35] (03CR) 10Chad: [C: 032] fixed wrong version number in HISTORY [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/81007 (owner: 10Emwiemaikel) [19:00:46] (03CR) 10Bsitu: "ready to be merged?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/73529 (owner: 10Kaldari) [19:01:07] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84789 [19:01:14] (03CR) 10Chad: [C: 032] Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80508 (owner: 10MarkAHershberger) [19:01:21] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84789 (owner: 10Mwalker) [19:02:31] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84790 [19:02:40] (03PS24) 10Parent5446: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [19:02:41] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84790 (owner: 10Mwalker) [19:03:11] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/84788 (owner: 10L10n-bot) [19:04:33] (03Merged) 10jenkins-bot: Fixed OracleUpdater::doPageRestrictionsPKUKFix prefix [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66042 (owner: 10Freakolowsky) [19:05:08] (03PS12) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [19:09:33] (03CR) 10Mwalker: [V: 032] Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84790 (owner: 10Mwalker) [19:09:43] (03CR) 10Mwalker: [V: 032] Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84789 (owner: 10Mwalker) [19:10:53] (03Merged) 10jenkins-bot: Changed quoting function for oracleDB. [core] - 10https://gerrit.wikimedia.org/r/65626 (owner: 10Freakolowsky) [19:11:05] (03Merged) 10jenkins-bot: Changed tableName so it returns uppercased table names (+prefix) Changed tableExists so it returns boolean (and closes resource when it's done in case it fails) [core] - 10https://gerrit.wikimedia.org/r/65630 (owner: 10Freakolowsky) [19:11:33] Reedy, did you say there was a bug about GettingStarted on Commons and wikimania2014? Or were you talking about something else? [19:15:03] (03PS2) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 [19:18:12] (03CR) 10jenkins-bot: [V: 04-1] Fixed EZConnect string regex in OracleInstaller class. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66324 (owner: 10Freakolowsky) [19:18:14] (03CR) 10Raimond Spekking: [C: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/84788 (owner: 10L10n-bot) [19:18:35] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [19:20:44] (03Merged) 10jenkins-bot: fixed wrong version number in HISTORY [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/81007 (owner: 10Emwiemaikel) [19:20:58] csteipp: https://bugzilla.wikimedia.org/show_bug.cgi?id=54288 may be related to the change you just pushed [19:22:23] mwalker: No, that was spamming the logs before I started [19:23:05] whoooo :) it was the efRaiseAccountCreationThrottle() bit that got me wondering [19:24:27] Nikerabbit: ok -- I just pushed the message field caching patch for centralnotice [19:24:37] and it seems like the job completes a lot quicker now [19:25:38] mwalker: wow you are so fast [19:26:08] 2.5 seconds, that's wow! [19:26:19] yay memcache! [19:28:29] mwalker: is the delayedJob global still set to true? [19:28:53] nah; I tore it out from CN because it didn't seem like I needed it anymore [19:29:25] ;) [19:33:26] (03Merged) 10jenkins-bot: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80508 (owner: 10MarkAHershberger) [19:33:41] Krenair: I dont know if you'll be able to do anything about it; but https://bugzilla.wikimedia.org/show_bug.cgi?id=54288 is a regression affecting code that you were the last one to touch [19:39:44] MatmaRex: could you re-review https://gerrit.wikimedia.org/r/#/c/84737/ ? [19:40:58] (03CR) 10Aaron Schulz: [C: 032] Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [19:41:02] ori-l: it looked okay apart from that thing, i'll look in a second [19:41:14] i'm doing some botting on a wikipedia :) [19:41:46] np, thanks [19:56:08] (03CR) 10Kelson: [C: 032 V: 031] "Stub files" [openzim] - 10https://gerrit.wikimedia.org/r/84432 (owner: 10Reedy) [19:56:30] (03CR) 10Kelson: [V: 032] "Stub files" [openzim] - 10https://gerrit.wikimedia.org/r/84432 (owner: 10Reedy) [20:02:08] (03Merged) 10jenkins-bot: Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [20:02:59] (03Restored) 10Hashar: jenkins job validation (DO NOT SUBMIT) [sartoris] - 10https://gerrit.wikimedia.org/r/46450 (owner: 10Hashar) [20:03:24] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [sartoris] - 10https://gerrit.wikimedia.org/r/46450 [20:06:15] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [sartoris] - 10https://gerrit.wikimedia.org/r/46450 [20:07:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [sartoris] - 10https://gerrit.wikimedia.org/r/46450 (owner: 10Hashar) [20:09:00] (03CR) 10Bsitu: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83202 (owner: 10Matthias Mullie) [20:10:27] (03PS1) 10Hashar: some jobs now use git proto to fetch Zuul reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84855 [20:13:10] Re: language settings: Does anyone know - Are there any *actual* uses of/for the en-gb and en-ca settings, anywhere in Wikimedia? (The only variable words I cna think of, that might crop up in our interfaces, are "centre, color, gray, organisation") [20:13:11] It's always seemed like a good way for tripling the amount of work that has to be done in keeping things updated... Couldn't we just apply WP:ENGVAR, and remove those 2 options entirely? [20:13:11] Or go crazy, and add en-aus, en-nz, en-sa, etc... [20:13:27] There's more than that [20:13:47] aus, nz and sa can be added if necessary [20:14:43] more words yes, https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Spelling#English_spelling_comparison_chart but not many that'd be used in Mediawiki interfaces. [20:15:09] wanna bet? [20:15:20] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/26bc9ba9c8bc436c8ef9fda665f0f87470e3044d/languages%2Fmessages%2FMessagesEn_gb.php [20:15:35] 55 [20:15:47] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/26bc9ba9c8bc436c8ef9fda665f0f87470e3044d/languages%2Fmessages%2FMessagesEn_ca.php [20:15:48] 20 [20:16:37] quiddity: are you familiar with the notion of language variants in mediawiki? [20:17:25] quiddity: like, e.g. sr.wp has latin and cyrillic variant - https://sr.wikipedia.org/sr-el/Главна_страна and https://sr.wikipedia.org/sr/Главна_страна [20:17:29] I understand that all foreign languages need their own translations, for sure. I'm just wondering how much the en-gb and en-ca are used. Those 2 links from reedy help [20:17:34] quiddity: there has been some initial works [20:17:40] quiddity: And that's just core [20:17:54] quiddity: there has been some initial work towards making similar variant conversion for english possible [20:18:11] I'd found the statistics page at https://www.mediawiki.org/wiki/Localisation_statistics but it didn't give any links to the actual specifics (possibly it should/could?) [20:18:30] Do you know about translatewiki? [20:18:35] and/or have visited it? [20:18:43] I know of, but haven't experimented with. [20:19:32] quiddity: it's just that not much has been done because it turned out that enabling language variant conversion breaks some obscure behavior in parser :P [20:19:52] quiddity: so this just has to wait until someone rewrites some nasty code [20:20:00] (sadly monolingual). I'm asking mainly because of the regular problems that seem to crop up at En.Wikipedia, regarding editors who have en-gb set, not getting certain updates because someone forgot to update the non-en [20:20:26] (en/en-us, whatever) [20:20:27] (03CR) 10Adamw: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [20:20:37] quiddity: https://bugzilla.wikimedia.org/show_bug.cgi?id=31015 [20:22:31] (03CR) 10Catrope: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [20:23:26] okay, thanks. I'll look into those links a bit further. [20:23:46] ori-l: is the issue with event logging volume graphs tracked somewhere? [20:25:09] (03PS25) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [20:25:32] (03PS26) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [20:31:48] (03PS1) 10Aude: Reduce complexity of SiteSQLStore saveSites method [core] - 10https://gerrit.wikimedia.org/r/84858 [20:36:24] (03CR) 10Jdlrobson: "So would we prefer a duplicate image in the resources and the skins folder or is there a better way to do this?" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [20:40:42] (03CR) 10Hashar: [C: 032] some jobs now use git proto to fetch Zuul reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84855 (owner: 10Hashar) [20:41:04] (03Merged) 10jenkins-bot: some jobs now use git proto to fetch Zuul reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84855 (owner: 10Hashar) [20:41:46] (03PS6) 10Catrope: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [20:48:59] mwalker, what was my commit? [20:51:57] (03PS1) 10Hashar: yaml/ruby/perl linter now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84859 [20:53:02] (03CR) 10CSteipp: [C: 032] Simplified Special:MWOAuthManageMyGrants listings [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84474 (owner: 10Aaron Schulz) [20:53:20] (03Merged) 10jenkins-bot: Simplified Special:MWOAuthManageMyGrants listings [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84474 (owner: 10Aaron Schulz) [20:53:56] (03CR) 10Catrope: "The test failures in Tim's version were mostly cosmetic, they were due to:" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [20:54:09] (03CR) 10Hashar: [C: 032] yaml/ruby/perl linter now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84859 (owner: 10Hashar) [20:54:29] (03Merged) 10jenkins-bot: yaml/ruby/perl linter now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84859 (owner: 10Hashar) [20:56:58] (03PS1) 10BryanDavis: Add role::math. [vagrant] - 10https://gerrit.wikimedia.org/r/84860 [20:59:04] (03PS1) 10Hashar: more linters now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84861 [20:59:16] (03CR) 10Hashar: [C: 032] more linters now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84861 (owner: 10Hashar) [20:59:42] (03Merged) 10jenkins-bot: more linters now use git proto to fetch zuul ref [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84861 (owner: 10Hashar) [21:02:44] (03CR) 10Jdlrobson: "...because it was convenient" [core] - 10https://gerrit.wikimedia.org/r/83429 (owner: 10Jdlrobson) [21:02:56] (03PS3) 10Jdlrobson: Hygiene: Make user login form HTML more semantically correct [core] - 10https://gerrit.wikimedia.org/r/83429 [21:07:27] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [21:08:25] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [21:10:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [21:10:49] (03CR) 10Aaron Schulz: [C: 032] Separate RevDel logic from UI [core] - 10https://gerrit.wikimedia.org/r/70748 (owner: 10Anomie) [21:11:33] (03PS4) 10Bsitu: Split the Echo API into their own write/read APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 [21:12:48] (03PS1) 10CSteipp: Remove table from ManageMyGrants list [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84864 [21:15:56] (03CR) 10Santhosh: [C: 032] Make the project tiles go to project page if one exists [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83081 (owner: 10Nikerabbit) [21:16:42] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [21:16:43] (03Merged) 10jenkins-bot: Make the project tiles go to project page if one exists [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83081 (owner: 10Nikerabbit) [21:16:44] (03CR) 10Santhosh: "Niklas, ping" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82801 (owner: 10Santhosh) [21:17:54] (03PS1) 10Hashar: rm mwext whitespaces jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84865 [21:18:31] (03CR) 10Hashar: [C: 032] rm mwext whitespaces jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84865 (owner: 10Hashar) [21:20:21] (03Merged) 10jenkins-bot: Separate RevDel logic from UI [core] - 10https://gerrit.wikimedia.org/r/70748 (owner: 10Anomie) [21:22:32] (03Merged) 10jenkins-bot: rm mwext whitespaces jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84865 (owner: 10Hashar) [21:24:11] (03PS1) 10Aaron Schulz: Do not use invalid IPs from XFFs to avoid exceptions [core] - 10https://gerrit.wikimedia.org/r/84866 [21:24:14] (03CR) 10Brion VIBBER: [C: 031] "I like this; a couple notes off the top of my head:" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [21:24:15] Reedy: ^ [21:25:02] Reedy: not sure if that's better [21:25:07] (03PS2) 10Reedy: Do not use invalid IPs from XFFs to avoid exceptions [core] - 10https://gerrit.wikimedia.org/r/84866 (owner: 10Aaron Schulz) [21:25:09] it might makes sense to just blow up though [21:25:44] Krenair: it was in oct of 2012 -- in wmf-config/throttle.php: line 65+; you created a section called skip when throttle does not apply to the client IP [21:25:55] I have no idea why wfGetIP is failing [21:26:00] csteipp: empty css? [21:26:12] (03PS4) 10PleaseStand: Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF [core] - 10https://gerrit.wikimedia.org/r/48743 (owner: 10Platonides) [21:27:07] Krenair: but as of the last couple of days it has started to do so [21:27:14] (03CR) 10PleaseStand: "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/48743 (owner: 10Platonides) [21:28:25] Leslie synced it yesterday, with an IP address change, which fits in with my timeline of when it started to break; but I dont see anything that would cause this behaviour [21:28:33] but I'm not familiar with this part of MW [21:28:36] Reedy: maybe I can make that an exception instead and mention the xff [21:28:53] (03PS5) 10Bsitu: Split the Echo API into their own write/read APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 [21:29:00] that would avoid using squid IPs for edits [21:30:21] Krenair: ah; should have read more intently the backscroll; looks like reedy_ is doing things about it [21:33:13] (03PS1) 10Physikerwelt: Merge advanced database write method [extensions/Math] - 10https://gerrit.wikimedia.org/r/84868 [21:33:57] (03PS3) 10Aaron Schulz: Detect invalid IPs in XFFs and give a more useful error message [core] - 10https://gerrit.wikimedia.org/r/84866 [21:34:32] (03CR) 10Adamw: "The registration function should be an improvement, actually--we are currently making many dozens of insertions into the wgAutoloadClasses" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [21:35:07] csteipp: https://gerrit.wikimedia.org/r/#/c/84864/1/frontend/modules/ext.MWOAuth.BasicStyles.css ? [21:36:04] AaronSchulz: I could leave that off... I was playing around, and ended up not wanting any styling [21:36:20] I did remove the only reference to -body [21:36:46] would be better to remove them then :) [21:37:51] (03CR) 10Bartosz Dziewoński: "The mediawiki.icon one probably has to stay there and be duplicated. The skins/vector/images one could be reused for this, I guess." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [21:37:52] Yeah, I'll do that [21:38:07] (03PS1) 10Hashar: rm analytics.disabled, not used [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84869 [21:38:17] (03CR) 10Hashar: [C: 032] rm analytics.disabled, not used [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84869 (owner: 10Hashar) [21:38:25] (03PS1) 10Bsitu: Remove markread action from the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 [21:38:47] (03Merged) 10jenkins-bot: rm analytics.disabled, not used [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84869 (owner: 10Hashar) [21:38:51] (03CR) 10Siebrand: [C: 032] Add missing cc-by/cc-by-sa-3.0 licenses (China and more) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 (owner: 10Multichill) [21:38:55] (03Merged) 10jenkins-bot: Add missing cc-by/cc-by-sa-3.0 licenses (China and more) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 (owner: 10Multichill) [21:39:11] (03PS4) 10Santhosh: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [21:39:51] (03PS2) 10CSteipp: Remove table from ManageMyGrants list [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84864 [21:39:59] csteipp: https://gerrit.wikimedia.org/r/#/c/84866/ [21:40:00] (03CR) 10Bsitu: [C: 04-2] Remove markread action from the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [21:40:02] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [21:40:16] (03CR) 10Aaron Schulz: [C: 032] Remove table from ManageMyGrants list [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84864 (owner: 10CSteipp) [21:40:24] (03Merged) 10jenkins-bot: Remove table from ManageMyGrants list [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84864 (owner: 10CSteipp) [21:41:21] (03CR) 10BryanDavis: [C: 031] "I read the code and ran the unit tests but did not use it to interact with a live LaTeXML server." [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [21:41:31] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84737 (owner: 10Ori.livneh) [21:41:35] ori-l: ^ [21:41:45] sorry i'm only doing it now, i got distracted then forgot about it [21:42:09] MatmaRex: no problem. i know what the issue is [21:42:14] <^d> ori-l: yo [21:42:15] Can someone with LaTeXML setup give https://gerrit.wikimedia.org/r/75828 a live test? [21:42:19] ^d: hey [21:42:26] <^d> ori-l: You 'round the office? [21:42:38] yep, other side of 3 [21:42:49] the dark side of the moon [21:42:55] <^d> That's the scary side! [21:42:58] the "wrong" side of 3 [21:43:23] we have kitchen + lego + hammock [21:43:31] <^d> ori-l: Wanna hack hhvm stuff? :) [21:44:29] (03CR) 10Bartosz Dziewoński: "FYI, you can do that straight from gerrit using the "Cherry Pick To" button and cherry-picking to master. (It'll do what you mean, updatin" [core] - 10https://gerrit.wikimedia.org/r/83429 (owner: 10Jdlrobson) [21:44:30] (03PS3) 10Ori.livneh: CSSMin: factor out image encoding into encodeImageAsDataURI method [core] - 10https://gerrit.wikimedia.org/r/84737 [21:44:53] ^d: sure; i'll pm [21:46:33] (03CR) 10Bsitu: [C: 032 V: 032] Display the correct info in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83033 (owner: 10EBernhardson (WMF)) [21:48:11] (03CR) 10Aaron Schulz: "(4 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/84868 (owner: 10Physikerwelt) [21:48:29] MatmaRex: PS3 should fix it, sorry bout that [21:50:09] ori-l: okay, let me just test it [21:50:10] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82219 (owner: 10Netbrain) [21:51:18] (03CR) 10Siebrand: "Removed myself as reviewer. Not in my area of expertise." [extensions/Maps] - 10https://gerrit.wikimedia.org/r/74594 (owner: 10Netbrain) [21:51:19] (03CR) 10CSteipp: [C: 04-1] "Doesn't seem like the right place to track down that bug, and seems like the right fix either. Shouldn't you just use the last valid ip in" [core] - 10https://gerrit.wikimedia.org/r/84866 (owner: 10Aaron Schulz) [21:52:55] (03PS3) 10Santhosh: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 [21:52:56] (03PS2) 10Santhosh: Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 [21:52:57] (03PS5) 10Santhosh: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [21:54:16] (03CR) 10Siebrand: [C: 031] "Nice. i18n/L10n reviewed." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [21:54:59] (03PS2) 10MarkTraceur: Fix portlet link [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 [21:55:03] Tadaaa [21:55:29] ori-l: hmm [21:55:54] ori-l: it still seems to break stuff :/ or there's something wrong with my cache [21:56:10] i get CSS like this output: background: linear-gradient(to bottom, transparent, transparent) no-repeat, url("data:;base64,data:image/svg+xm…") no-repeat transparent; [21:56:30] huh, let me try and reproduce this [21:56:31] maybe it's a false alarm. [21:56:36] and i broke something [21:56:38] let me tyr again [21:56:57] i think it might be your cache, yeah [21:57:09] because that's consistent with the problem PS3 fixed [21:57:27] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed: Trivial L10n change." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [21:58:29] …i think i should try turning it off and on again. some images show up, some don't, wtf [21:59:25] (03PS2) 10Physikerwelt: Merge advanced database write method [extensions/Math] - 10https://gerrit.wikimedia.org/r/84868 [21:59:37] (03CR) 10Hashar: "I have deleted all such jobs" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84865 (owner: 10Hashar) [22:01:36] (03PS2) 10MarkTraceur: Increment and decrement memcached on pref save [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 [22:02:09] ori-l: okay, it works. just one thing [22:02:18] (03PS7) 10Catrope: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [22:02:42] ori-l: you changed "filesize( $file ) < self::EMBED_SIZE_LIMIT" to "! filesize( $file ) > $sizeLimit", which is technically different :P do we want to bother ourselves with the change? [22:03:56] (03CR) 10Aaron Schulz: "That's what I did in the first version of this patch, but I'm not sure using squid IPs is better than erroring out." [core] - 10https://gerrit.wikimedia.org/r/84866 (owner: 10Aaron Schulz) [22:04:05] (03PS1) 10Hashar: php exts jobs now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84877 [22:04:29] (03CR) 10Hashar: [C: 032] php exts jobs now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84877 (owner: 10Hashar) [22:04:31] MatmaRex: good catch, but I think it's OK. The comment in CSSMin says: "24,576 is used because Internet Explorer has a 32,768 byte limit for data URIs, which when base64 encoded will result in a 1/3 increase in size. " but 24576 * 1.33 = 32686.08, so there's some margin there. [22:05:28] well, actually, let me just update the patch. [22:05:37] there's no reason to change the maximum unless we have to. [22:05:53] Eek, right [22:06:19] ori-l: Isn't that margin consumed by the other parts of the URL though? [22:06:20] (03Merged) 10jenkins-bot: php exts jobs now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84877 (owner: 10Hashar) [22:06:38] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84878 [22:06:55] 82 characters? [22:07:08] ori-l: okay [22:07:11] I mean, maybe. But that's a lot of characters. [22:07:20] Bytes. Whatever. [22:07:28] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84879 [22:07:39] (03PS1) 10Aaron Schulz: Allow for cancellation of deferred updates [core] - 10https://gerrit.wikimedia.org/r/84880 [22:07:39] <^d> marktraceur: 82 characters is more than 81 characters. [22:07:40] <^d> fyi. [22:07:52] RoanKattouw: the longest mime-type is 'image/x-xbitmap', so the longest prefix is 'data:image/x-xbitmap;base64,' = 28. what about base64 padding, though? [22:08:10] ^d: Whatever. I rounded down, but 81 is still a lot. [22:08:14] (03PS1) 10CSteipp: Improve instructions for developers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84881 [22:08:18] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84878 (owner: 10Yurik) [22:09:26] (03PS4) 10Ori.livneh: CSSMin: factor out image encoding into encodeImageAsDataURI method [core] - 10https://gerrit.wikimedia.org/r/84737 [22:09:38] MatmaRex: changed '>' to '>=' [22:10:48] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84881 (owner: 10CSteipp) [22:12:13] ori-l: alright, let's do this, then [22:12:22] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84879 (owner: 10Yurik) [22:12:25] (03CR) 10Bartosz Dziewoński: [C: 032] CSSMin: factor out image encoding into encodeImageAsDataURI method [core] - 10https://gerrit.wikimedia.org/r/84737 (owner: 10Ori.livneh) [22:12:43] i bet someone will find some issues with the doc comments after it's merged. [22:13:08] <^d> YOU DIDN'T PUT ENOUGH SPACES [22:13:53] CAN NEVER HAVE TOO MANY SPACES [22:15:13] Oh, our docs. [22:15:23] <^d> We have too many docs. [22:15:25] "newFromURL\nTHIS IS NOT THE FUNCTION YOU WANT" [22:15:26] <^d> Can't read them all. [22:15:28] <^d> Need less docs. [22:15:36] Need fewer ducks. [22:15:53] spacearenotthatusefulafterall [22:17:13] hashar: Syntax error, line 0. [22:17:23] [22:17:54] <^d> marktraceur: https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2FGlobalFunctions.php#L2616 best function doc we have [22:18:03] (03CR) 10jenkins-bot: [V: 04-1] Allow for cancellation of deferred updates [core] - 10https://gerrit.wikimedia.org/r/84880 (owner: 10Aaron Schulz) [22:19:41] ^d: I liked writing https://gerrit.wikimedia.org/r/#/c/84451/1/BetaFeaturesHooks.php [22:19:58] Patchset two is better and less vulgar. [22:20:02] best class doc is hands-down https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2FEditPage.php#L35 , though. [22:20:31] Winner. [22:20:53] (03PS1) 10Hashar: operations-apache-config-lint bound to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84883 [22:20:54] (03PS1) 10Hashar: resurect wikimedia-bugzilla-wikibugs-perllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84884 [22:20:55] (03PS1) 10Hashar: operations-dns-lint now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84885 [22:21:13] marktraceur: haha, i remember doing something like that with sidebar mangling for cologneblue [22:21:38] (03CR) 10Hashar: [C: 032] operations-apache-config-lint bound to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84883 (owner: 10Hashar) [22:21:38] marktraceur: i went through three iterations, all commited to gerrit and merged, and it still sucks [22:21:44] (03CR) 10Hashar: [C: 032] resurect wikimedia-bugzilla-wikibugs-perllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84884 (owner: 10Hashar) [22:21:48] (03CR) 10Hashar: [C: 032] operations-dns-lint now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84885 (owner: 10Hashar) [22:21:53] Heh [22:21:55] marktraceur: (afair i'm just foreaching over the array and rewriting it from scratch, bleh) [22:22:03] MatmaRex: I'm in that boat too [22:22:24] i mena, IN GODS NAME WHY DO WE DEPEND ON THE ORDER OF AN ASSOCIATIVE ARRAY [22:22:51] also, WHY DOES PHP EVEN ORDER THEM [22:22:57] cause they are ordered ? [22:23:02] that's gotta be the shittiest idea ever [22:23:04] (03Merged) 10jenkins-bot: operations-apache-config-lint bound to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84883 (owner: 10Hashar) [22:23:25] (03Merged) 10jenkins-bot: resurect wikimedia-bugzilla-wikibugs-perllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84884 (owner: 10Hashar) [22:23:29] but oh well, i'm taking about a language that has one single non-primitive data type for everything [22:23:46] lists, arrays, hashtables, whatever, just use array() [22:23:46] (03Merged) 10jenkins-bot: operations-dns-lint now fetch Zuul ref via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84885 (owner: 10Hashar) [22:24:09] even javascript has at least two [22:25:25] (03PS1) 10MarkTraceur: Fix use of deprecated getSkin [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84886 [22:25:31] bd808: Fix ^^ [22:25:33] (03CR) 10BryanDavis: "(14 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/84868 (owner: 10Physikerwelt) [22:29:29] (03PS1) 10Hashar: operations puppet jobs fetches Zuul ref with git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84887 [22:29:53] (03CR) 10Hashar: [C: 032] operations puppet jobs fetches Zuul ref with git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84887 (owner: 10Hashar) [22:30:11] (03Merged) 10jenkins-bot: operations puppet jobs fetches Zuul ref with git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84887 (owner: 10Hashar) [22:35:21] (03PS2) 10BryanDavis: Fix use of deprecated getSkin [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84886 (owner: 10MarkTraceur) [22:36:16] (03PS19) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [22:36:32] (03CR) 10BryanDavis: [C: 032] "Fixes the deprecation warning I was seeing." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84886 (owner: 10MarkTraceur) [22:37:08] (03Abandoned) 10Ori.livneh: Make LESS embed() actually embed images [core] - 10https://gerrit.wikimedia.org/r/84726 (owner: 10Ori.livneh) [22:37:16] (03Merged) 10jenkins-bot: Fix use of deprecated getSkin [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84886 (owner: 10MarkTraceur) [22:38:50] (03CR) 10Ori.livneh: "PS19: embed() that actually embeds. Still need to investigate debug mode issue reported by Matt Flaschen." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [22:39:06] ^ MatmaRex :P [22:39:17] ori-l: thanks :D [22:40:26] (03PS1) 10Hashar: more jobs to fetch Zuul refs via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84888 [22:40:35] (03CR) 10Hashar: [C: 032] more jobs to fetch Zuul refs via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84888 (owner: 10Hashar) [22:41:04] (03Merged) 10jenkins-bot: more jobs to fetch Zuul refs via git protocol [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84888 (owner: 10Hashar) [22:41:06] ori-l: btw, is this kind of hacking (using things technically not passed as arguments inside function definition) considered "kosher"? ;) [22:41:16] ^d: can we delete repositories in Gerrit ? I got a couple that could use a total phase out (git repo + changes) [22:41:26] MatmaRex: what do you mean? [22:41:30] OrenBochman: (or am i misunderstanding the code?) [22:41:35] <^d> hashar: Send me an e-mail, it's kind of a pain to clean up. [22:41:37] <^d> But yes [22:41:45] ^d: thanks :-] [22:41:56] ori-l: what does "background-image: embed('../images/button-bg.png');" expand to? [22:42:02] ahazeh [22:42:09] (that's the example from the comment in DefaultSettings) [22:42:12] MatmaRex: if you have embed('images/bg.png') there are two function calls happening: the LESS function invocation with the parameter 'images/bg.png' [22:42:18] * hashar heads to ops chan to scream [22:42:43] which is translated by lessphp into a call to $wgResourceLoaderLESSFunctions['embed'] with a frame object as the first argument and the compiler instance as the second [22:43:08] it's actually quite similar to the interface Scribunto exposes to wikitext [22:43:50] (what i meant is, it seems that you have access to the "background-image: " part - how and why and is this considered okay?) [22:43:51] you write {{#invoke:MyModule|MyFunc|first_arg|second_arg}} [22:44:02] no, I don't have access to background image [22:44:12] the pre / post stuff is [22:44:39] because you need to duplicate other rules for both the data and fallback uris [22:44:45] when you're using the background: shorthand [22:44:57] so background: white url('foo.png'); [22:45:00] the @embed annotation handles more complicated stuff like "/*@embed*/ background: red url(red.png) no-repeat;", expanding it in two full rules, one with dara: uri, second with !ie; [22:45:16] right, so you need to include those in the invocation of embed, but they are supported [22:45:27] so you'd do background: embed('red.png', '', 'no-repeat') [22:45:49] ah. hm. [22:45:55] err, embed('red.png', 'red', 'no-repeat') [22:46:00] kinda weird, but fair enough [22:46:10] i didn't make the signature embed(before, url, after) because the most common case is just to have a URL [22:46:11] but you still need to double the "background: " part. [22:46:26] as in, [22:46:40] background: red url(data:image/png,…) no-repeat; background: red url(red.png) no-repeat!ie; [22:46:44] * ori-l cries [22:47:02] (03CR) 10MarkTraceur: [C: 04-1] "Agh, no, crap." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [22:47:11] * MatmaRex hugs ori-l [22:47:18] isn't it the case that you could always rewrite those rules using the non-shorthand version? [22:47:24] i.e. separate background-color: and background-image: rules? [22:47:34] it is, yes [22:47:40] (03PS1) 10Hashar: lint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84889 [22:47:50] (i think, some css3 rules only have shorthand versions) [22:48:00] but you still need to duplicate background-image: in those [22:48:06] so maybe we either settle for embed() only being suitable for background-image [22:48:28] or have a mix-in that calls the function and generates the rule (i'm not sure this is possible, but have a hunch it may be) [22:49:00] so you'd do .background(red, red.png, no-repeat) [22:49:09] (which is a parametrized mix-in, not the same as a function) [22:49:13] and that would expand to multiple rules [22:49:16] is it not possible to do "embed(background: red url(red.png) no-repeat;)" ? [22:49:29] it may be, i'm not sure [22:49:32] yeah, or that [22:49:44] i've only had brief contant with less [22:50:07] (03CR) 10Hashar: [C: 032] lint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84889 (owner: 10Hashar) [22:50:19] i'll experiment with it and see [22:50:26] (03Merged) 10jenkins-bot: lint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84889 (owner: 10Hashar) [22:50:44] (03CR) 10Hashar: "refreshing jobs..." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84889 (owner: 10Hashar) [22:51:07] MatmaRex, Reedy, Just a quick followup: I compiled and clarified some notes at https://www.mediawiki.org/wiki/Talk:Localisation_statistics#en-GB_and_en-CA_-_notes (that seems to be the only place that really mentions them, onwiki) [22:53:04] (03PS4) 10Aaron Schulz: Detect invalid IPs in XFFs and give a more useful error message [core] - 10https://gerrit.wikimedia.org/r/84866 [22:53:47] ori-l: thanks. i'm disappearing in ~30 minutes, i'll be waiting to see what you come up with :) [22:54:38] quiddity: if you ask me, let's kill those with fire, but i'm not a native speaker of any english variant ;) [22:55:17] (03PS2) 10Aaron Schulz: Allow for cancellation of deferred updates [core] - 10https://gerrit.wikimedia.org/r/84880 [22:55:53] quiddity: british english and american english can usually be converted in automated manner, so we should use existing language converter functionality for this [22:56:11] quiddity: (for cases where they can't be, the converter supports defining local exceptions to the rules) [22:56:47] quiddity: it's just that the converter kinda sucks and several parser tests break when it's enabled [22:57:09] quiddity: we tried that with https://gerrit.wikimedia.org/r/#/c/72053/ [22:57:31] (03CR) 10jenkins-bot: [V: 04-1] Detect invalid IPs in XFFs and give a more useful error message [core] - 10https://gerrit.wikimedia.org/r/84866 (owner: 10Aaron Schulz) [22:57:33] sorry, crashed out right after I sent the message. [22:57:39] quiddity: (which doesn't add en-br and en-am or anything, different thing entirely, but it uses the language converter as well) [22:57:49] quiddity: argh. let me paste it all back [22:57:52] (03PS1) 10EBernhardson (WMF): See that a post has been edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 [22:57:53] actually, let me not [22:57:57] !htmllogs [22:57:57] http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [22:58:50] (03PS13) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [22:58:51] actually. [22:58:54] [00:54] quiddity: if you ask me, let's kill those with fire, but i'm not a native speaker of any english variant ;) [22:58:54] [00:55] quiddity: british english and american english can usually be converted in automated manner, so we should use existing language converter functionality for this [22:58:54] [00:56] quiddity: (for cases where they can't be, the converter supports defining local exceptions to the rules) [22:58:54] [00:56] quiddity: it's just that the converter kinda sucks and several parser tests break when it's enabled [22:58:54] [00:57] quiddity: we tried that with https://gerrit.wikimedia.org/r/#/c/72053/ [22:58:54] [00:57] quiddity: (which doesn't add en-br and en-am or anything, different thing entirely, but it uses the language converter as well) [22:59:46] got the logs, ty though. and yes, fire! [23:00:09] quiddity_: so. what you need to do is, poke cscott and liangent to fix the language converter, and then we can start implementing that. :D [23:00:20] perfect, ty MatmaRex :) [23:00:20] (03PS3) 10MarkTraceur: Increment and decrement memcached on pref save [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 [23:00:41] (liangent is the resident expert on language converter, and cscott is the resident expert on the parser) [23:00:49] (03CR) 10MarkTraceur: [C: 031] "Better." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [23:01:21] quiddity_: i think i linked https://bugzilla.wikimedia.org/show_bug.cgi?id=31015 already today? [23:01:42] you might want to track that bug :) [23:01:54] (03PS1) 10Reedy: Added $wgMessageFileList for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 [23:01:56] chrismcmahon: hashar ^ [23:02:04] oh [23:02:13] yup, but most of en.wiki is thoroughly opposed to that idea (afaik) [23:03:20] quiddity: well, that's kind of the same idea as variant conversion in the interface [23:03:25] isn't it? [23:03:32] quiddity: what isn't enwiki opposed to? ;) [23:03:32] en.wp people are weird [23:03:49] legoktm: Puppies? [23:03:55] Maybe that's optimistic. [23:04:35] MatmaRex, a) yes b) we don't want any variants! [[WP:ENGVAR]] works well, and more templates = more pain. [23:04:42] marktraceur: all of the wikilove options are cats :| [23:04:56] marktraceur, puppies need housetraining, they pee on everything. [23:05:59] (03PS1) 10Catrope: Update VisualEditor for cherry-picks in wmf/1.22wmf17 branch [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84899 [23:07:20] enwikians need house training. :P [23:07:28] cmjohnson1: Ok, so that's commit to mediawiki core, puppet and mediawiki-config to handle this change [23:07:51] fail [23:07:56] he left [23:07:58] * Technical_13 doesn't pee on the floor, any more. [23:08:08] quiddity: the point of automated language conversion is that you wouldn't have to do anything. (hopefully :P) [23:08:28] (03CR) 10Cmcmahon: [C: 031] "This allows us to support a new extension on beta labs cluster only and not in production in any way at all. Note that this is not intend" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [23:08:30] quiddity: anyway, that's irrelevant, i think it can be enabled separately for interface and content [23:08:34] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84881 (owner: 10CSteipp) [23:08:35] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-picks in wmf/1.22wmf17 branch [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84899 (owner: 10Catrope) [23:08:38] quiddity: (and if it can't it should be) [23:08:40] Reedy: reviewing [23:10:16] (03CR) 10Siebrand: "How is this feature made discoverable? Is it documented somewhere?" [core] - 10https://gerrit.wikimedia.org/r/78468 (owner: 10Brian Wolff) [23:12:35] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF)) [23:13:34] marktraceur: this is for you :P https://www.mediawiki.org/w/index.php?title=Manual:Messages_API&diff=0&oldid=774570 [23:15:07] (03PS6) 10Amire80: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 [23:15:19] (03CR) 10Siebrand: "If this were to be merged, https://www.mediawiki.org/wiki/Manual:Messages_API#Parameters should be updated." [core] - 10https://gerrit.wikimedia.org/r/80663 (owner: 10Parent5446) [23:15:28] (03CR) 10Amire80: [C: 032] Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [23:15:29] (03PS14) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [23:16:02] (03CR) 10Hashar: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [23:16:04] (03CR) 10Spage: "(5 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [23:16:08] (03CR) 10Amire80: "Edited by Santhosh, and pair-reviewed by Niklas and me with a verbal +2 from Niklas." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [23:16:10] Reedy: reviewed https://gerrit.wikimedia.org/r/#/c/84897/ [23:19:32] (03PS3) 10Amire80: Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 (owner: 10Santhosh) [23:19:45] (03Merged) 10jenkins-bot: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [23:22:10] (03PS4) 10BryanDavis: Increment and decrement memcached on pref save [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [23:22:49] (03CR) 10Siebrand: "Technically okay, but needs consensus on change request bug 53617. Adding -1 to indicate something needs to be done, although not to this " [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [23:22:56] (03CR) 10Siebrand: [C: 04-1] Change namespageNames and namespaceAliases in Korean [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [23:24:06] (03CR) 10Reedy: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [23:24:18] hashar: Never mind the fact it won't work ;) [23:25:03] (03CR) 10Mattflaschen: [C: 04-1] "(9 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [23:25:29] Reedy: maybe we could use --extension-dir and whenever mw-update-l10n is running in beta, we would point --list-file to extension-list-labs ? [23:25:43] Reedy: the extension-list-labs would contains the Wikibase entry points for example [23:26:01] bu they're still needed for production [23:26:25] and then we'd need an exception in the bash script for labs [23:26:49] I've suggested a way we can just have the -labs file to have additional entries for labs [23:26:52] (03CR) 10BryanDavis: [C: 032] "Looks good to me." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [23:27:01] Rather than a duplicate of extension-list with additional lines [23:27:03] (03Merged) 10jenkins-bot: Increment and decrement memcached on pref save [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 (owner: 10MarkTraceur) [23:27:57] (03PS4) 10Amire80: Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 (owner: 10Santhosh) [23:29:24] (03PS1) 10Mwjames: SMW 1.9 alpha-3 (autumn sprint) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84904 [23:29:30] (03CR) 10Amire80: [C: 032] Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 (owner: 10Santhosh) [23:29:34] Reedy: yeah that make sense [23:29:53] (03Merged) 10jenkins-bot: Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 (owner: 10Santhosh) [23:30:31] (03PS4) 10Amire80: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [23:30:38] (03PS1) 10Reedy: Update to CLDR 24 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 [23:31:37] (03PS2) 10Reedy: Update to CLDR 24 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 [23:31:46] there you go siebrand ;) [23:32:06] Reedy: You're quick. [23:32:13] The whitespace changes are annoying [23:32:26] Reedy: Huge diff. [23:32:34] yeah [23:32:37] Reedy: Could you update the indentation first, and then the content? [23:32:44] looks like rebuild.php has been changed to use tabs [23:32:47] at some point [23:32:48] Reedy: I assume the build script changed a bit. [23:32:55] indeed [23:32:59] let me see [23:33:13] $output .= "\t$key => '$value',\n"; [23:34:25] (03CR) 10Mwjames: [C: 032] SMW 1.9 alpha-3 (autumn sprint) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84904 (owner: 10Mwjames) [23:35:51] (03Merged) 10jenkins-bot: SMW 1.9 alpha-3 (autumn sprint) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84904 (owner: 10Mwjames) [23:36:06] (03PS3) 10Reedy: Update to CLDR 24 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 [23:36:07] (03PS1) 10Reedy: Update indenting to use tabs (updated rebuild.php) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84906 [23:36:08] * Reedy waits [23:36:26] (03PS3) 10BryanDavis: Fix portlet link [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [23:36:44] +11555, -9220 [23:36:59] +90715, -90715 [23:37:19] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84893 (owner: 10EBernhardson (WMF)) [23:37:59] (03PS3) 10Cmcmahon: POC for flow browser test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 [23:38:19] (03PS1) 10Mwjames: (Bug 54289) \SMW\CsvResultPrinter UTF-8 byte order mark [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84907 [23:38:47] (03CR) 10BryanDavis: "Patch set was a manual rebase to current master due to conflicts in BetaFeaturesHooks.php." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [23:38:54] (03CR) 10Cmcmahon: "see if these changes work for you" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [23:39:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Please add message documentation in MessagesQqq.php when adding message keys. See https://www.mediawiki.org/wiki/I18n#" [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [23:40:50] (03PS5) 10Amire80: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [23:41:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n review" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [23:42:01] (03CR) 10Amire80: [C: 032] If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [23:42:08] marktraceur: Is https://gerrit.wikimedia.org/84451 good to go for +2? I don't want Seibrand to chase me down again for merging an i18n change out of turn [23:42:09] (03Merged) 10jenkins-bot: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [23:42:29] (03PS2) 10Mwjames: (Bug 54289) \SMW\CsvResultPrinter UTF-8 byte order mark [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84907 [23:44:29] (03CR) 10Siebrand: "Added Katie as reviewer for CldrCurrency/Symbols.php specifically." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy) [23:44:49] (03CR) 10Santhosh: [C: 04-1] "If you look at the diffs , all files removes the $timeunits. I am not sure to where that data went, but I can imagine it breaking TimeUnit" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy) [23:44:55] (03PS4) 10Mwjames: SMWHooks::onSpecialStatsAddExtra -> SMW\SpecialStatsAddExtra [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83608 [23:45:14] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy) [23:47:40] I wonder if it's a format change [23:48:00] http://unicode.org/Public/cldr/24/core.zip [23:48:37] (03PS1) 10Hashar: jslint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84908 [23:48:50] (03CR) 10Hashar: [C: 032] jslint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84908 (owner: 10Hashar) [23:48:59] (03CR) 10Mwjames: [C: 032] SMWHooks::onSpecialStatsAddExtra -> SMW\SpecialStatsAddExtra [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83608 (owner: 10Mwjames) [23:50:08] (03CR) 10BryanDavis: [C: 031] "Php looks good. Will +2 as soon as Mark or Siebrand confirms this is 100% ready." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [23:50:32] (03Merged) 10jenkins-bot: jslint jobs now fetches Zuul ref over git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/84908 (owner: 10Hashar) [23:50:55] (03Merged) 10jenkins-bot: SMWHooks::onSpecialStatsAddExtra -> SMW\SpecialStatsAddExtra [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83608 (owner: 10Mwjames) [23:51:30] (03PS3) 10Amire80: Remove hardcoded percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [23:51:35] (03CR) 10jenkins-bot: [V: 04-1] Remove hardcoded percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [23:51:40] siebrand: Yup, looks like a file format change [23:51:51] 23.1 [23:51:51] [23:51:51] [23:51:53] 24 [23:52:03] [23:52:03] [23:52:03] [23:52:58] * AaronSchulz shoves pastebin at Reedy [23:53:08] (03CR) 10Siebrand: "So I discussed this with Jarod, and he explained what "Interact with pages" is supposed to mean. The code however was merged without messa" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 (owner: 10Aaron Schulz) [23:53:09] (03PS4) 10Amire80: Remove hardcoded percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [23:53:23] I can paste all 5474 lines if you want ;) [23:53:37] (03CR) 10Amire80: [C: 032] Remove hardcoded percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [23:53:46] (03Merged) 10jenkins-bot: Remove hardcoded percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 (owner: 10Santhosh) [23:54:27] (03CR) 10Reedy: "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84905 (owner: 10Reedy) [23:55:18] (03PS4) 10Aaron Schulz: jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs() [core] - 10https://gerrit.wikimedia.org/r/71966 [23:55:52] TimStarling: any chance you can look at https://gerrit.wikimedia.org/r/#/c/71966/ ? [23:56:11] chrismcmahon: What do we need to do to get texvc setup on the jenkins nodes? See https://integration.wikimedia.org/ci/job/mwext-Math-testextensions-master/285/console [23:56:54] /usr/bin/scap-recompile [23:56:59] AaronSchulz: after my meeting with robla, I guess I can [23:57:11] bd808: There's an outstanding TODO to package it and distribute it properly [23:57:41] Ok. I got it installed via puppet in vagrant with minimal fuss [23:57:51] Reedy: see https://gerrit.wikimedia.org/r/#/c/84860/ [23:57:53] we use a customised version (ish) [23:57:59] Depending on where $wgTexvc is actually set... [23:58:12] TimStarling: I always ping you when you having meetings with him :) [23:58:19] (03PS6) 10Amire80: Show "For all languages" when the page is in the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84107 [23:58:25] AaronSchulz: Can't you see robla is on the phone!? [23:58:36] heh [23:58:44] doesn't mean I know who it is [23:58:53] (03PS1) 10MarkTraceur: Add dependency management for features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84909 [23:58:54] (on the other end) [23:59:16] bd808: Though, we could just install mediawiki-math on gallium