[00:01:01] Maybe [00:01:08] I didn't see anything obvious [00:01:49] includes/job/jobs/RefreshLinksJob.php [00:05:34] Iiiinterestink. [00:05:41] I will take a stab at that tomorrow [00:05:54] Still trying to make this bloody form look nice. :) [00:06:16] (03PS1) 10Bsitu: Split the Echo API into their own write/read APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 [00:12:19] (03CR) 10Bsitu: "I submitted a patch for splitting the API in here: https://gerrit.wikimedia.org/r/#/c/84468/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [00:14:24] (03PS2) 10Bsitu: Split the Echo API into their own write/read APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 [00:19:33] (03CR) 10Siebrand: [C: 04-1] "I'm not sure if the L10n change will clarify the meaning of the tab. "Beta features" are a technical concept that most users are not aware" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur) [00:27:23] (03PS2) 10Reedy: Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 [00:29:29] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [00:29:32] (03PS2) 10Reedy: Add AllUsers alias to ListUsers.. [core] - 10https://gerrit.wikimedia.org/r/83584 [00:37:53] (03PS3) 10Reedy: Rename ListUsers to AllUsers [core] - 10https://gerrit.wikimedia.org/r/83584 [00:40:48] (03PS1) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 [00:40:52] Like a boss [00:42:35] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84468 (owner: 10Bsitu) [00:48:14] (03PS1) 10Aaron Schulz: Simplified Special:MWOAuthManageMyGrants listings [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84474 [00:54:15] (03PS2) 10MarkTraceur: Make final design changes [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84473 [00:55:27] (03PS1) 10Ejegg: LinkSearch: allow searching for URLs with ':' [core] - 10https://gerrit.wikimedia.org/r/84475 [01:05:54] (03PS1) 10Reedy: Add UserGetReservedNames hook subscriber [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84476 [01:07:57] ori-l: vagrant question: is there a good reason why helpers.rb converts colons to octothorpes in role names? [01:08:39] it's breaking the role::eventlogger::server thing we talked about [01:10:35] (03Restored) 10Chad: Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Chad) [01:11:53] (03PS2) 10Chad: Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 [01:12:24] 'kay, I think...home, then food and UploadWizard hacking. YuviPanda, will you be around tonight? [01:29:22] (03CR) 10Manybubbles: [C: 032] Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 (owner: 10Reedy) [01:29:23] (03CR) 10jenkins-bot: [V: 04-1] Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 (owner: 10Reedy) [01:30:57] hello [01:33:22] Back to bed! [01:34:29] manybubbles|away: http://p.defau.lt/?_HJ_53w0dB2Qpp1ClzZcDw [01:34:39] Warning: Search backend error during full text search for 'gro~s'. Error message is: SearchPhaseExecutionException[Failed to execute phase [dfs], total failure [01:34:48] Reedy: I can't, woke up an hour ago fully operational [01:35:05] I just had my pick_from( dinner/lunch/breakfast ) :D [01:35:50] Warning: CirrusSearch couldn't get parser output for Growth/status. Returning null text which should be skipped. [Called from CirrusSearchTextSanitizer::getSantizedTextFromTitle in /usr/local/apache/common-local/php-1.22wmf17/extensions/CirrusSearch/CirrusSearchTextSanitizer.php at line 41] in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296 [01:35:52] hashar: wow - good morning [01:36:11] Warning: Search update called with false or null text for growth status. Ignoring search update. [01:36:21] * Reedy looks for a chainsaw [01:37:19] for json, python -mjson.tool [01:37:25] Reedy: so that is "fine" in that we're not blowing up. [01:37:31] that usually gives some human readable garbage [01:37:36] s/garbage/json/ [01:37:56] Reedy: that bug for that is still open though [01:38:18] so we plan on fixing it. It is with Chad right now. I'll update the bug and send him an email. [01:41:13] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=54199 for the gro~s error. [01:44:35] (03CR) 10MarkAHershberger: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [01:47:51] manybubbles: and while around, beta shows up some exception while doing some http request [01:48:15] manybubbles: http://paste.openstack.org/show/47134/ :-D [01:48:49] /extensions/Solarium/lib/Client/Adapter/Http.php, line 80: Solr HTTP error: HTTP request failed [01:48:56] ApiQueryGeoSearchSolr [01:49:06] Don't those want to go to MaxSem? [01:49:11] probably [01:49:15] Solr != Elastic [01:51:09] so we have both solr and el ? [01:51:11] damn [01:52:06] indeed [01:52:15] Noting mobile and translate use it [01:52:38] presumably when elastic is more in production usage (with server capactiy) it should be moved [01:52:39] guess they started using it when we advertised we will eventually use solr as a search backend [01:52:40] * Reedy logs some bugs [01:54:15] manybubbles: I guess that's another reason to move Elastica to it's own extension (like Solarium) [01:55:02] Reedy: I've almost finished with the first commit for that [01:55:05] Bug 52993 - Add support for ElasticSearch backend for ttmserver - Niklas is one step ahead [01:55:11] Has Chad created the repo already? [01:55:38] I can create a Gerrit repo if need be [01:56:13] Reedy: he said he'd created it after his lunch but I haven't checked [01:57:35] (03PS5) 10MarkAHershberger: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 [01:58:03] (03CR) 10jenkins-bot: [V: 04-1] Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [01:59:29] I can't see an obvious repo for it... [02:06:15] (03PS3) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 [02:14:40] YuviPanda: Rebased [02:14:48] (03PS6) 10MarkAHershberger: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 [02:16:20] (03CR) 10jenkins-bot: [V: 04-1] Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [02:17:26] (03CR) 10Reedy: "02:16:11 PHP Parse error: syntax error, unexpected T_STRING, expecting ')' in includes/installer/Installer.i18n.php on line 20184" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [02:22:41] (03PS7) 10MarkAHershberger: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 [02:37:42] (03CR) 10Mattflaschen: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [02:42:53] hashar, is there a way to exclude a directory from PHP linting? [02:43:45] superm401: nop :-] [02:44:03] iirc the command is something like: find . -name (php|php5|inc|sample) -exec php -l {} \; [02:44:12] Hmm, then PHP linting will remain non-voting for a little longer still. [02:44:26] superm401: do you have any example? [02:44:33] Thinking of the third-party LESS library we're importing in https://gerrit.wikimedia.org/r/#/c/78669/ [02:45:01] ahhh LESS [02:45:02] :-D [02:45:18] superm401: the phpcs are always failing due to our code [02:45:34] Yeah, I know. [02:45:35] we might one day eventually start documenting our style and write the phpcs rules to enforce them [02:45:44] It's more an issue if we finally want to make at least leninent non-voting. [02:45:46] meanwhile, the jobs are mostly useless and can be ignored [02:45:46] I mean voting [02:46:22] I have split the tests in two [02:46:37] to potentially let us fix all the errors [02:46:49] but there are too many of them and nobody agrees on which one are important [02:46:59] maybe I should remove most of them from the style definition [02:47:17] and make the lenient one voting, then add rules one by one :-D [02:47:33] """ Class name "lessc_formatter_lessjs" is not in camel caps format """ :-( [02:48:07] superm401: I should probably make phpcs ignore includes/libs/ [02:48:57] hashar, yeah, that would work, though not sure if it covers too much. [02:49:51] and I don't think phpcs let us tweak the rules configuration on a per repo basis [02:50:12] jshint let you tweak settings using a .jshintrc and .jshintignore [02:50:19] maybe should come with something similar for phpcs [02:51:27] Perhaps, but it could be good to have the uniformity if it's feasible. [03:03:38] (03PS1) 10Reedy: Fix Call to a member function getContent() on a non-object [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 [03:16:19] (03PS1) 10Reedy: Fixup parameter type hints [core] - 10https://gerrit.wikimedia.org/r/84480 [03:17:11] (03PS1) 10Physikerwelt: Cleanup of Code [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/84481 [03:18:53] (03CR) 10Physikerwelt: [C: 032 V: 032] Cleanup of Code [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/84481 (owner: 10Physikerwelt) [03:25:23] (03PS1) 10Reedy: More function level type hints [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84482 [04:17:45] (03PS2) 10MarkAHershberger: Initial attempt at backporting [extensions/Scribunto] (REL1_19) - 10https://gerrit.wikimedia.org/r/75142 [04:18:30] (03CR) 10MarkAHershberger: "(3 comments)" [extensions/Scribunto] (REL1_19) - 10https://gerrit.wikimedia.org/r/75142 (owner: 10MarkAHershberger) [04:18:45] (03CR) 10jenkins-bot: [V: 04-1] Initial attempt at backporting [extensions/Scribunto] (REL1_19) - 10https://gerrit.wikimedia.org/r/75142 (owner: 10MarkAHershberger) [04:34:51] (03CR) 10Hashar: [C: 032] "Make sense now :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński) [04:35:02] (03Merged) 10jenkins-bot: Whitelist Kevin Israel (PleaseStand) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński) [04:35:55] (03CR) 10Hashar: "deployed :) let me know if there is any issue." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński) [04:41:38] (03PS15) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [04:42:32] (03CR) 10PleaseStand: "Rebase only, let's see if the tests pass..." [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [04:42:54] PleaseStand: you should be whitelisted by Zuul now:) [04:43:15] PleaseStand: I am out for breakfast with family though, mail me (hashar at free dot fr) if anything is wrong :) [04:45:39] hashar: thanks [04:54:40] (03PS13) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [04:56:40] (03CR) 10Ori.livneh: "PS13: Unless $wgShowExceptionDetails is true, don't disclose file path or other exception details when LESS compilation fails." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [05:14:41] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [05:17:45] (03PS14) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [05:18:50] (03CR) 10Ori.livneh: "PS14: Remember to declare global." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [05:25:03] (03PS1) 10PleaseStand: API: JSON specific syntax highlighting [core] - 10https://gerrit.wikimedia.org/r/84484 [05:25:26] (03CR) 10PleaseStand: [C: 04-1] "Work in progress; don't merge yet." [core] - 10https://gerrit.wikimedia.org/r/84484 (owner: 10PleaseStand) [09:50:27] (03PS5) 10Mattflaschen: Parse mwe-upwiz-tooltip-skiptutorial containing link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 (owner: 10Rillke) [10:00:52] (03CR) 10Mattflaschen: [C: 032] "I got rid of the unwanted i18n changes by using:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 (owner: 10Rillke) [10:00:58] (03Merged) 10jenkins-bot: Parse mwe-upwiz-tooltip-skiptutorial containing link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 (owner: 10Rillke) [10:08:46] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [10:27:03] (03PS1) 10Krinkle: Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 [10:35:09] (03CR) 10Krinkle: "Just for the record, where do you intend to use this for?" [core] - 10https://gerrit.wikimedia.org/r/83942 (owner: 10Aaron Schulz) [10:48:30] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [11:11:40] (03CR) 10Parent5446: [C: 031] "Try not to rebase and submit new changes at the same time. Then it becomes hard to look at inter-patchset diffs." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [11:13:08] (03CR) 10Parent5446: [C: 031] Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [11:14:02] (03CR) 10Parent5446: [C: 031] Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Chad) [11:29:23] marktraceur: Yes (re: test utility for js coding style) [11:30:26] marktraceur: Since jQuery devs were looking into it as well I decided to see what comes out of that instead and (if it passes our sanity test) roll with it. [11:31:13] Though it is still pending, the best suggestion made there so far imho is node-jscs. I've filed https://bugzilla.wikimedia.org/show_bug.cgi?id=54218 [11:48:20] (03CR) 10Krinkle: "Getting rather close to pushing that button. Got a few minor things to test still (which might result in further comments), but I think th" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [11:50:14] (03CR) 10Krinkle: "Also, perhaps in a separate commit, but converting at least 1 module to use LESS in core would demonstrate how it should be used and would" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [11:51:25] (03CR) 10Krinkle: [C: 04-1] "Needs unit tests (instantiate a module using less and assert the getStyles returns the expected strings)." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [13:18:47] (03CR) 10Manybubbles: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [13:31:25] (03CR) 10Manybubbles: "(3 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84482 (owner: 10Reedy) [14:10:38] anyone online know why ./configure for luasandbox would not find lua when it's installed in /usr/bin/? [14:42:21] dan-nl: You could just ignore Commons policy on your local wiki and use the output option to get the raw JSON [14:42:43] I say "policy" loosely here [14:44:35] marktraceur: thanks but i'm missing the context of your suggestion … [14:45:27] dan-nl: Rather than using the complicated system they've built to generate TemplateData from a TemplateBox call, you can use the output option to TemplateBox to output raw JSON and copy that to your wiki. [14:45:53] marktraceur: ah, now i see what you mean [14:47:17] marktraceur: locally i figured out the issue … for some reason the TemplateBox generation of the section requires luasandbox … i got luasandbox to work locally but not on the wikitech server yet, that's what my question above is in reference to ... [14:47:47] dan-nl: Yeah, I know - but Commons-specific policy shouldn't slow down your development. [14:48:16] Sorry, did it again. "policy" [14:48:23] Scare quotes. Important. [14:48:29] :) [15:08:44] (03PS2) 10Manybubbles: Fix Call to a member function getContent() on a non-object [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [15:11:06] (03CR) 10Manybubbles: "So I've added a log to the guard as I requested of Reedy because we're seeing more of this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [15:28:52] (03CR) 10Manybubbles: "So another option is rather than ignore the update we issue a delete. I kind of like the idea because it makes sense but I can't test it " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [15:35:34] (03CR) 10Brion VIBBER: [C: 031] "Looks ok, but I haven't tested." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/84493 (owner: 10J) [15:47:12] (03CR) 10Parent5446: [C: 031] Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [15:48:16] (03CR) 10Parent5446: [C: 032] Add TitleMove hook [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [15:52:28] (03Merged) 10jenkins-bot: Add TitleMove hook [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [16:18:46] (03CR) 10Chad: [C: 032] Fix Call to a member function getContent() on a non-object [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [16:18:54] (03Merged) 10jenkins-bot: Fix Call to a member function getContent() on a non-object [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84479 (owner: 10Reedy) [16:20:05] (03CR) 10Bartosz Dziewoński: "How will this affect translations of the page name?" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [16:23:02] (03PS1) 10Multichill: Add the cc-by-sa-3.0 for China Change-Id: Icca0f3a279ffe7d060f56339973d570a8020022b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 [16:23:46] Yeah, it's true, setting up Gerrit on Windows is a PITA :P [16:24:02] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 (owner: 10Jackmcbarn) [16:24:41] Krinkle|detached: wtf [16:24:45] Math isn't in extension-list [16:27:47] Reedy: root cause of https://bugzilla.wikimedia.org/show_bug.cgi?id=50971 ? [16:28:02] Possibly [16:28:09] need to run scap to confirm [16:34:31] (03PS2) 10Nikerabbit: Add the cc-by-sa-3.0 for China Change-Id: Icca0f3a279ffe7d060f56339973d570a8020022b [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 (owner: 10Multichill) [16:35:10] morning [16:35:31] mogge [16:35:40] hi Nikerabbit [16:35:48] ohnoes I hope that won't cause a merge conflict with my WikimediaMessages commit [16:36:03] hopefully not, it's another file :) [16:36:29] Just did a small change to see if it works in Windows. Setting up Gerrit in Windows really sucks [16:36:49] are you aspiring to martyrdom? [16:37:57] interesting http://wiki.creativecommons.org/China_Mainland [16:38:24] I wonder if anyone at WMF knows those guys [16:38:44] yeah i got git-review mostly installed on windows but then it didn't like my ssh key and i didn't get around to finding and fixing it [16:38:48] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84537 [16:38:54] not when i could just push to github, then pull on mac os x and do git-review there ;) [16:38:57] <^d> Reedy: ^ [16:39:56] It'd be cool if you could email patches to an address and have them appear in Gerrit attributed to you [16:40:05] Nemo_bis: I know, already fixed it in the next patchset [16:40:14] <^d> brion: So I started poking DeferredUpdates. [16:40:17] <^d> I got depressed. [16:40:21] aww [16:40:38] brion: I had the git gui generate another ssh key and that worked [16:41:11] openssh vs not? [16:41:21] i'm using the github gui… i'm not quite sure the git CLI it installed plays nicely with git-review [16:41:40] {{sofixit}} [16:41:46] anyway, i'll mess with it later when i've got time to poke the windows 8 app again :) [16:41:55] it's an android day today [16:43:31] <^d> brion: On a totally different subject....TitleKey. [16:43:55] whee [16:47:38] (03CR) 10Nemo bis: [C: 031] Add the cc-by-sa-3.0 for China [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 (owner: 10Multichill) [16:50:49] (03CR) 10Aaron Schulz: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83974 (owner: 10Brian Wolff) [16:56:16] (03CR) 10Bartosz Dziewoński: [C: 031] Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [16:57:51] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [16:58:25] (03CR) 10Jdlrobson: "ping.." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [16:58:30] (03PS3) 10Jdlrobson: Allow filtering of notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 [16:58:40] (03CR) 10Anomie: "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/48743 (owner: 10Platonides) [17:00:26] (03PS3) 10Multichill: Add missing cc-by/cc-by-sa-3.0 licenses (China and more) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84535 [17:00:33] (03CR) 10Reedy: [C: 04-1] Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [17:03:05] ^d: Why do I get fetch failures on my SSH origin about half the time? [17:03:05] error: RPC failed; result=22, HTTP code = 405 [17:03:11] Wait. [17:03:13] HTTP. [17:03:14] Wat. [17:03:23] <^d> HTTP != SSH ;-) [17:03:25] * marktraceur fixes that [17:03:26] (03CR) 10CSteipp: "(7 comments)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal) [17:03:31] Well, then s/SSH/HTTP/ [17:04:35] "Method not allowed" [17:04:51] <^d> Yeah. [17:04:53] Which is what some really stupid routers sometimes call "File not found" [17:06:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84491 (owner: 10Krinkle) [17:07:48] <^d> marktraceur: I have some suspicions. Would it make you feel better to know it's not you? [17:08:37] (03PS2) 10Bartosz Dziewoński: mediawiki.user: Clean up documentation and minor optimisation [core] - 10https://gerrit.wikimedia.org/r/84491 (owner: 10Krinkle) [17:08:53] ^d: *sniff* a little [17:09:00] :P [17:09:04] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.user: Clean up documentation and minor optimisation [core] - 10https://gerrit.wikimedia.org/r/84491 (owner: 10Krinkle) [17:09:19] ^d: I'm pretty sure my 3-5 patches a day aren't bringing down Gerrit :) [17:12:48] (03CR) 10Bartosz Dziewoński: [C: 032] Removed unneeded else branches in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/80788 (owner: 10IAlex) [17:14:28] (03Merged) 10jenkins-bot: mediawiki.user: Clean up documentation and minor optimisation [core] - 10https://gerrit.wikimedia.org/r/84491 (owner: 10Krinkle) [17:14:45] (03CR) 10Aaron Schulz: [C: 032] "The state here is a bit confusing, but it works" [core] - 10https://gerrit.wikimedia.org/r/75891 (owner: 10IAlex) [17:15:21] gah, i was reviewing that. okay. [17:16:24] (03Merged) 10jenkins-bot: Removed unneeded else branches in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/80788 (owner: 10IAlex) [17:16:41] (03CR) 10Aaron Schulz: [C: 032] Guard against non-object returns from File::getHander() [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis) [17:17:22] (03CR) 10Alex Monk: [C: 04-1] "my comment on PS33 still applies" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/3808 (owner: 10Drecodeam) [17:17:55] bd808's first merge to core! Woo! [17:18:04] \o/ [17:18:10] *clap clap* [17:18:33] * bd808 waits to see if this unlocks the "bring down site" achievement [17:19:05] (03CR) 10Alex Monk: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 (owner: 10Grunny) [17:20:05] Oh, sorry. [17:20:05] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [17:20:09] He lied to me. [17:20:24] (03Merged) 10jenkins-bot: Show the revision ID on error message when content is missing on difference page [core] - 10https://gerrit.wikimedia.org/r/75891 (owner: 10IAlex) [17:21:05] (03CR) 10EBernhardson (WMF): "One more thing, could you link the related gerrit patch to mobile which uses this code?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [17:21:38] (03PS4) 10Jdlrobson: Allow filtering of notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 [17:21:53] (03CR) 10Chad: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84537 (owner: 10Chad) [17:21:55] Apparently I had a core patch approved last time I was in SF but my feeble brain forgot [17:22:20] bd808: oh, don't worry, just wait. sooner or later you will break the sites :D [17:22:26] (03CR) 10Jdlrobson: [C: 04-1] "Ok.. sounds like we need to rethink this. There was talk about showing the last thank action. Would this be possible? Is there any functio" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [17:22:42] mediawiki just *loves* breaking in fun and unexpected ways [17:22:45] (03Merged) 10jenkins-bot: Guard against non-object returns from File::getHander() [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis) [17:23:11] "* This function should *not* be called outside of JobQueueDB" Hm, isn't there a word for that? [17:24:01] (03CR) 10Reedy: [C: 032 V: 032] Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84537 (owner: 10Chad) [17:24:06] <^d> marktraceur: "I want to make this private but I made mistakes when designing it so I can't." [17:24:28] (and so does my irc client.) [17:24:34] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84542 [17:24:39] marktraceur: design by social contract [17:24:56] <^d> Who wants an easy patch? [17:24:57] !htmllogs [17:24:57] http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [17:25:05] <^d> It'll fix 25 errors in hhvm. [17:25:17] A tes souhaits [17:25:23] <^d> *25 test errors, that is [17:26:06] ^d: ori-l is excited about hhvm improvements this week [17:26:15] (03CR) 10Physikerwelt: "ok... I think I'll move this to the dev branch as well... so that we can see something. Otherwise we are speaking apart from each other" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [17:26:15] <^d> Oh? [17:26:57] he was trying to recruit me to become an hhvm fixer-of-extensions [17:26:57] ^d: i've just been trying to get a handle on what needs to happen by filing bugs for each outstanding thing i come across. i've been using the meeting notes from when you guys went to facebook [17:27:03] Reedy: I think the dedup stuff you found in RefreshLinksJob.php is only applicable when you're pushing a batch of jobs onto the queue [17:27:17] <^d> ori-l: That's what I do. The upstream guys have fixed most of my bugs :) [17:27:17] e.g. you push a bunch of jobs at once - the jobs I add only come in one at a time anyway [17:27:28] <^d> I'm working my way through the unit tests now trying to get 100% passing. [17:27:44] Unless I add a PushJobsToJobQueueJob or something equally meta and crazy. [17:27:50] see blockers for https://bugzilla.wikimedia.org/show_bug.cgi?id=40926 [17:27:56] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84543 [17:28:16] <^d> ori-l: https://gerrit.wikimedia.org/r/#/c/80759/2 is trivial and fixes 25 unit tests :) [17:30:46] ^d: looks good, but better to only call it once rather than call it once for the falsey check and once for the foreach [17:31:04] <^d> Tried that, see comments on previous patchset. [17:31:24] <^d> The overhead from calling it twice isn't that big a deal. [17:32:22] ^d: tyler's suggestion seems reasonable [17:33:12] (03PS1) 10Andrew Bogott: Modify ldap schema for hosts. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 [17:33:18] springle: so where the tables changed for https://gerrit.wikimedia.org/r/#/c/57536/ ? [17:33:24] Wait. [17:33:30] GitBlit shows code as...images? [17:33:52] Or Firefox is just confused [17:33:55] <^d> huh? [17:33:56] (03CR) 10Andrew Bogott: [C: 04-1] "Needs more testing -- not ready for merge yet." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/83947 (owner: 10Andrew Bogott) [17:34:38] <^d> ori-l: k, will amend [17:34:54] ^d: I can show you [17:35:41] Like, with the power of real life [17:35:49] * ^d hides under his desk [17:36:29] ^d: don't let my nitpicking discourage you, it's a cool patch and i'm happy to hear you're working on the hhvm stuff [17:37:05] (03CR) 10Manybubbles: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem) [17:37:56] Aaron|home: sorry, don't follow. do you mean where are the tables themselves, or have the changes been made yet? [17:38:09] (03PS3) 10Manybubbles: Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 (owner: 10Reedy) [17:38:20] (03CR) 10Manybubbles: [C: 032] Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 (owner: 10Reedy) [17:38:23] (03Merged) 10jenkins-bot: Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 (owner: 10Reedy) [17:38:31] (03PS3) 10Chad: Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 [17:38:43] <^d> ori-l: Amended, way nicer you're right ^ [17:39:05] (03CR) 10Frédéric Wang: "So you are saying that the TeX string has its whitespace trimmed? If so, you can use strpos but be sure that the command is at position 0." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [17:40:38] springle: have the changes been made? [17:41:35] Aaron|home: no. high priority? [17:42:36] springle: if you have time, it's been rotting for a long time [17:43:00] Aaron|home: ok. i'll mov eit up the list and ping you when done. this week [17:43:37] (03CR) 10Ori.livneh: [C: 032] Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Chad) [17:43:57] ^d: Thankee [17:45:13] <^d> yw [17:48:08] (03Merged) 10jenkins-bot: Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Chad) [17:49:43] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84542 (owner: 10Bsitu) [17:52:11] (03CR) 10Andrew Bogott: "Needs more testing -- not ready for merge yet." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/83947 (owner: 10Andrew Bogott) [17:52:33] (03CR) 10Andrew Bogott: [C: 04-1] Modify ldap schema for hosts. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/84546 (owner: 10Andrew Bogott) [17:53:07] (03CR) 10Bsitu: [V: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84542 (owner: 10Bsitu) [17:53:52] <^d> ori-l: Boom! http://p.defau.lt/?l6rpm8jbqLjmR8BsY7lvkw [17:54:42] You need a bigger stack [17:55:01] (03CR) 10EBernhardson (WMF): "There does not currently exist any methods for fetching a specific type of notification." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 (owner: 10Jdlrobson) [17:55:08] <^d> Reedy: obvs. [17:55:32] (03CR) 10Mwalker: [C: 032] Bug 52331: Prevent navbars from appearing in diff view. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/84293 (owner: 10Mollywhite) [17:55:36] (03Merged) 10jenkins-bot: Bug 52331: Prevent navbars from appearing in diff view. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/84293 (owner: 10Mollywhite) [17:55:47] hhvm ./recursion_test.php -vEval.VMStackElms=65536 [18:00:16] (03PS1) 10Mwjames: \SMW\DefaultContext implements \SMW\ContextInterface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 [18:00:38] <^d> Reedy: I think they might've broken something upstream. This stack overflow just started in the last 24-48h. [18:01:05] multichill: Romaine where are the WLM stats? [18:01:36] https://toolserver.org/~emijrp/wlm/stats.php [18:02:27] yes like that tool [18:02:32] orange line = 2013 [18:03:32] other tools are mentioned there: https://commons.wikimedia.org/wiki/User:Romaine/Wiki_Loves_Monuments/2013#Tools [18:04:12] (03CR) 10jenkins-bot: [V: 04-1] \SMW\DefaultContext implements \SMW\ContextInterface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 (owner: 10Mwjames) [18:05:33] I was looking for the upload stats [18:07:15] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84543 (owner: 10Bsitu) [18:07:28] (03CR) 10Mwjames: "Interesting ... issue is due to Language::isValidBuiltInCode" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 (owner: 10Mwjames) [18:10:49] ^d: I don't remember, is prefix: supposed to work in CirrusSearch? [18:11:17] <^d> Supposed to. [18:12:17] qgil: http://korma.wmflabs.org/browser/notes.html#note:charts:people:lines 404s [18:12:55] Same as the other 4 links under the graph on http://korma.wmflabs.org/browser/people.html?id=554&name=Munagala%20Ramanath [18:13:52] Reedy, ack [18:14:41] (03PS2) 10Mwjames: \SMW\DefaultContext implements \SMW\ContextInterface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 [18:14:47] (03Merged) 10jenkins-bot: Update Echo and Thanks to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84543 (owner: 10Bsitu) [18:15:30] (03CR) 10Mwjames: "I'll have a hunch as to why this is causing an issue." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 (owner: 10Mwjames) [18:20:22] marktraceur: ping [18:20:34] marktraceur: 1 class per event feels like overkill to me [18:20:41] copypastaish [18:20:46] Whine whine whine. [18:21:04] very copypastaish [18:21:08] YuviPanda: The copypasta feel will be better once I've stopped doing poor classical inheritance and figure a better system [18:21:29] * YuviPanda hums don't stuff class hierarchies where they aren't needed [18:21:43] It seems easier to me. [18:22:05] The *interface* is useful, it's just the implementation that needs work [18:22:26] And really, I'm not spending that much extra space on it [18:22:46] marktraceur: why not UploadWizardEvent.logEvent( 'choose', 'something', 'something' ); [18:22:50] and then route based on first param? [18:23:46] YuviPanda: There are a lot of possible forms of payload, and each class handles its own [18:23:58] there *aren't* that many possible forms of payloud [18:24:02] it is essentially 'type' and 'data' [18:24:05] where data is a hash [18:24:13] 'kay [18:24:15] route based on type into data [18:24:19] err [18:24:20] I'll rewrite it into a function [18:24:26] route data based on type [18:24:30] (03PS3) 10Mwjames: \SMW\DefaultContext implements \SMW\ContextInterface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 [18:24:41] marktraceur: you don't have to route that into one big function [18:24:57] marktraceur: since only the schema name differs, it should be trivial to have a *short* function [18:25:06] (03PS1) 10EBernhardson (WMF): Language aliases for Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 [18:26:57] (03CR) 10Yuvipanda: [C: 04-1] "Too many classes. A class per event is unnecessary, since there is essentially just 'type' and 'data' associated with each event. Having a" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 (owner: 10MarkTraceur) [18:27:45] * marktraceur ignores UW for a while [18:27:48] Werk time [18:29:17] (03PS1) 10Manybubbles: Start of extension. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 [18:31:39] (03CR) 10Mattflaschen: [C: 04-1] "(3 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [18:33:04] (03PS1) 10Manybubbles: Remove Elastica. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 [18:33:05] (03CR) 10jenkins-bot: [V: 04-1] Remove Elastica. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 (owner: 10Manybubbles) [18:33:56] (03CR) 10Mwjames: "I guess my hunch was right, the DIC used RequestContext::getMain() instead of new RequestContext() which forced the RequestContext to rema" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/84551 (owner: 10Mwjames) [18:34:00] (03CR) 10Manybubbles: "This change can't be merged until https://gerrit.wikimedia.org/r/#/c/84559/ is merged and after this one we'll have a mediawiki-config cha" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 (owner: 10Manybubbles) [18:34:34] (03CR) 10Reedy: [C: 04-1] "(6 comments)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [18:38:55] (03CR) 10Aaron Schulz: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [18:39:33] (03Abandoned) 10Mwjames: [DIC]: ObjectInjector a configurable injector class (ServiceLocator pattern) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83402 (owner: 10Mwjames) [18:39:52] (03CR) 10Manybubbles: "(6 comments)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [18:39:57] ^d: does it want space after prefix: or not? and underscores in the title or not? [18:40:43] (03PS2) 10Manybubbles: Start of extension. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 [18:41:10] * Nemo_bis is getting confused [18:46:03] <^d> Nemo_bis: Maybe prefix: isn't working. [18:46:05] <^d> Actually. [18:46:06] <^d> Hmm [18:50:56] (03PS2) 10Manybubbles: Remove Elastica. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 [18:51:22] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [18:51:39] (03CR) 10Manybubbles: "I had to manually rebuild this change from a diff file because the rebase went so so badly." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84560 (owner: 10Manybubbles) [19:03:40] AaronSchulz: ping [19:07:21] AaronSchulz: nm, found what I was looking for [19:14:14] (03CR) 10Reedy: [C: 031] "(1 comment)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [19:29:30] Reedy, good catch on the Math bug. [19:29:47] Weird, considering Math has been an extension since 2011. [19:41:35] (03PS2) 10Santhosh: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [19:42:44] (03PS2) 10EBernhardson (WMF): Display post creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83032 [19:45:25] (03PS3) 10Santhosh: Add a language selector when the main page language is the source language [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [19:47:44] (03CR) 10CSteipp: "Can we add a ; separated list of the rights (like on /authorize, but without being broken into the headings) to the list view?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84474 (owner: 10Aaron Schulz) [19:48:58] (03CR) 10Santhosh: "Addressed Niklas comments, did some refactoring." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [19:54:30] (03CR) 10Aaron Schulz: "I ended up nuking that since it still seemed like too much information to show on the list view." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84474 (owner: 10Aaron Schulz) [19:55:54] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [19:56:51] "haven't tested" is going to be the most comment on that changeset. [19:57:04] Reedy: https://gerrit.wikimedia.org/r/#/c/79852/ [19:57:06] most common comment*. english hard. [19:57:15] hey Aaron|home [19:57:30] Aaron|home: i need you to check out the part of https://gerrit.wikimedia.org/r/#/c/84315/ that's in DifferenceEngine [19:57:42] Aaron|home: because that's your hook i think i fixed there [20:00:23] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [20:05:58] (03PS1) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84623 [20:05:59] (03PS1) 10Kaldari: Update MobileFrontend to production, pick up core dependency [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84624 [20:06:42] (03CR) 10Kaldari: [C: 032] Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84623 (owner: 10Kaldari) [20:06:53] (03CR) 10Kaldari: [C: 032] Update MobileFrontend to production, pick up core dependency [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84624 (owner: 10Kaldari) [20:09:36] Reedy: Given the existing deduplication code doesn't apply to BetaFeatures, are there any other points that need addressing? [20:10:04] I don't think so [20:10:17] Cool. [20:10:35] The SQL query isn't great, but you're caching the results and not running it on every request [20:10:43] Yup [20:10:51] So you're mitigating any potential problems [20:10:58] (03CR) 10jenkins-bot: [V: 04-1] Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84623 (owner: 10Kaldari) [20:11:15] Reedy: I could also bucket it and only update one count per job, but that seems only questionably useful [20:12:20] It would mean not using an "IN" condition [20:12:29] Using redis/memc -> incr() etc might be worth exploring [20:12:49] (03CR) 10jenkins-bot: [V: 04-1] Update MobileFrontend to production, pick up core dependency [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84624 (owner: 10Kaldari) [20:13:04] (03PS1) 10MarkTraceur: WIP Add notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 [20:13:14] (03CR) 10Kaldari: [V: 032] Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84623 (owner: 10Kaldari) [20:13:33] Reedy: Actually yeah - then I wouldn't need to run a database query for the planned increment/decrement actions. [20:13:52] (03CR) 10Kaldari: [V: 032] Update MobileFrontend to production, pick up core dependency [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84624 (owner: 10Kaldari) [20:14:00] I'll stick that on the roadmap for MVP, seems doable. [20:20:34] (03PS1) 10BryanDavis: Add switch to log eventlogging-devserver output to file. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 [20:21:12] ori-l: ^ got tired of fighting upstart and went to the source [20:22:12] (03CR) 10Nikerabbit: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 (owner: 10EBernhardson (WMF)) [20:25:26] (03PS1) 10BryanDavis: Add role for EventLogging that runs a local server. [vagrant] - 10https://gerrit.wikimedia.org/r/84627 [20:28:19] (03PS1) 10Physikerwelt: Displaystyle [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84629 [20:29:40] bd808|MEETING: is that the '>' output redirection operator implemented in 20 lines of python? [20:30:11] (03Abandoned) 10Physikerwelt: Displaystyle [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [20:31:15] (03CR) 10Ori.livneh: "(1 comment)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 (owner: 10BryanDavis) [20:31:41] (03CR) 10Nikerabbit: [C: 04-1] Language aliases for Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 (owner: 10EBernhardson (WMF)) [20:31:50] Nikerabbit: à propos, the alias translation on twn is still broken for the randomincategory duplicate [20:34:52] marktraceur, are you there? [20:36:57] (03CR) 10Physikerwelt: [C: 032] "(3 comments)" [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84629 (owner: 10Physikerwelt) [20:38:34] (03PS1) 10Manybubbles: Escape queries that use ~ incorrectly. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 [20:38:35] (03CR) 10jenkins-bot: [V: 04-1] Escape queries that use ~ incorrectly. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 (owner: 10Manybubbles) [20:41:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81684 (owner: 10Ori.livneh) [20:42:23] (03PS2) 10Bartosz Dziewoński: Clean up legacy protect.js & remove from .jshintignore [core] - 10https://gerrit.wikimedia.org/r/81684 (owner: 10Ori.livneh) [20:43:30] (03CR) 10Bartosz Dziewoński: [C: 032] "Doesn't look like it's gonna break anything… mostly whitespace and apostrophe changes, some non-troublesome weak -> strict equality check " [core] - 10https://gerrit.wikimedia.org/r/81684 (owner: 10Ori.livneh) [20:45:10] (03CR) 10Manybubbles: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 (owner: 10Manybubbles) [20:45:11] (03CR) 10Bartosz Dziewoński: "So, y'all doing this? Because I'm *itching* to see it in production." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/76105 (owner: 10Aklapper) [20:46:24] (03PS2) 10Reedy: Add bmo extension InlineHistory [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/76105 (owner: 10Aklapper) [20:46:32] (03CR) 10Bartosz Dziewoński: "This is being moved to core, btw, per https://gerrit.wikimedia.org/r/#/c/83590/ ." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80927 (owner: 10Hoo man) [20:46:33] rebase all the things! [20:46:37] silly jenkins bot [20:46:56] It told me I had to rebase but I convinced it I didn't\ [20:49:01] (03Merged) 10jenkins-bot: Clean up legacy protect.js & remove from .jshintignore [core] - 10https://gerrit.wikimedia.org/r/81684 (owner: 10Ori.livneh) [20:49:18] thanks MatmaRex [20:49:46] does someone know how to profile php requests on the cluster? [20:50:05] ori-l: my pleasure [20:50:17] Nemo_bis: don't do that [20:50:18] Nikerabbit: does your code already have wfProfile{In|Out} calls? [20:50:26] ori-l: nope [20:50:35] (03PS1) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84633 [20:50:36] (03PS1) 10Kaldari: Updating MobileFrontend to production [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84634 [20:50:41] ori-l: i fell behind on crstats, gotta work on that https://toolserver.org/~nemobis/crstats/core.txt ;) [20:51:02] (03CR) 10Kaldari: [C: 032 V: 032] Adding support for query string params to mw.util.wikiGetlink [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84633 (owner: 10Kaldari) [20:51:15] (03CR) 10Kaldari: [C: 032 V: 032] Updating MobileFrontend to production [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84634 (owner: 10Kaldari) [20:51:18] Nikerabbit: you need to add those first [20:51:25] ori-l: yes I can do that [20:51:27] Nikerabbit: then you can see them in graphite (graphite.wikimedia.org) [20:52:21] ori-l: assuming something triggers the code often enough to end up in the sampling... which is quite unlikely for my case [20:52:51] Nikerabbit: see PM [20:59:42] Nikerabbit: don't do what? [21:00:19] (03CR) 10Bartosz Dziewoński: [C: 04-1] "New hook needs documenting in docs/hooks.txt." [core] - 10https://gerrit.wikimedia.org/r/45677 (owner: 10Parent5446) [21:00:23] (03PS15) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [21:00:26] (03CR) 10Manybubbles: [C: 04-1] "Found more cases I have to address in this commit. Consider it a work in progress for a bit. :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 (owner: 10Manybubbles) [21:00:51] (03CR) 10Ori.livneh: "PS15: Rebase; needs more work per Krinkle's comments on PS14." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [21:05:01] Nemo_bis: taunting "oh X is broken" [21:06:14] mwalker: can you find a third reviewer for the CN cleanup patch? [21:06:57] Nikerabbit: yes; I'll have adam look at it tomorrow [21:07:13] unless you feel it really needs to be pushed today; in which case I can bug kaldari [21:07:20] The guy in the pic kind of looks familiar, marktraceur https://blog.wikimedia.org/2013/09/16/call-for-wikimedia-tech-projects-needing-contributors/ [21:10:46] mwalker: I'm supposed to fix the performance issues in this sprint, by end of next week [21:12:23] (03CR) 10Anomie: [C: 04-1] "(7 comments)" [core] - 10https://gerrit.wikimedia.org/r/84484 (owner: 10PleaseStand) [21:12:57] Nikerabbit: I don't understand what you mean by taunting [21:13:37] Nikerabbit: gotcha [21:16:37] (03PS1) 10Santhosh: Refactor login form submit handler [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 [21:23:59] Nikerabbit: adam just merged it -- I'll get a deployment window from greg sometime today and push it [21:24:50] (03PS1) 10Bsitu: Add check for empty summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84641 [21:28:10] (03PS1) 10Cmcmahon: remove VE tests now that they reside in /mediawiki/extensions/VisualEditor [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84643 [21:31:55] (03PS1) 10Manybubbles: Tests for proximity and fuzzy search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84645 [21:32:41] (03PS2) 10Manybubbles: Escape queries that use ~ incorrectly. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84630 [21:34:36] (03CR) 10Chad: [C: 032] Regression tests for javascript injection. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84347 (owner: 10Manybubbles) [21:34:39] (03Merged) 10jenkins-bot: Regression tests for javascript injection. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84347 (owner: 10Manybubbles) [21:34:47] (03PS2) 10Anubhavagarwal: almost final code [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 [21:36:02] (03CR) 10Chad: [C: 032] Easier index maintenance. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84424 (owner: 10Manybubbles) [21:36:04] (03Merged) 10jenkins-bot: Easier index maintenance. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84424 (owner: 10Manybubbles) [21:38:53] (03PS2) 10EBernhardson (WMF): Language aliases for Special:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84557 [21:39:49] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Add check for empty summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84641 (owner: 10Bsitu) [21:41:02] * greg-g waves [21:43:50] (03CR) 10CSteipp: "(3 comments)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal) [21:46:14] (03CR) 10Chad: [C: 04-1] "(1 comment)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [21:47:23] qgil_: I heard! :) [21:49:30] (03CR) 10Legoktm: [C: 04-2] "After looking at this again, it most likely won't provide accurate statistics because $wgNamespacesToConvert isn't applied and a few other" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [21:50:23] hey does anybody remember how the hell log entries get added for uploads? [21:50:35] i want to double-check there's no subtypes i don't know about [21:54:40] (03PS2) 10BryanDavis: Add role for EventLogging that runs a local server. [vagrant] - 10https://gerrit.wikimedia.org/r/84627 [21:54:57] aha! [21:55:05] 'ManualLogEntry' [21:55:16] instead of LogPage::addEntry [21:56:09] ok i think it's just upload and overwrite... [21:56:36] brion: there is also 'revert' [21:56:52] hmm [21:56:58] well that's sorta like an overwrite :) [21:57:00] (03PS16) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [21:57:02] truedat [21:57:05] anyway it'll do for now i think [21:58:37] (03PS3) 10BryanDavis: Add role for EventLogging that runs a local server. [vagrant] - 10https://gerrit.wikimedia.org/r/84627 [22:02:20] (03CR) 10Ori.livneh: "PS16:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [22:02:43] Krinkle: ^^ [22:03:01] doesn't have tests yet, but makes some substantial changes that you should review [22:04:05] (03PS1) 10Rahul21: Comment out the redundant check (title.getExtension() === null) as the body of the if is already commented [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:04:36] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84510 (owner: 10Krinkle) [22:04:38] (03PS2) 10Krinkle: Add gzdecode fallback to GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/84510 [22:04:59] 1 Warning: Search backend highlighted a redirect (Wikimedia Mobile engineering/imported/Mobile projects/Web Features & Roadmap) but didn't return it. [Called from CirrusSearchResult::findRedirectTitle in /usr/local/apache/common-local/php-1.22wmf17/extensions/CirrusSearch/CirrusSearchSearcher.php at line 589] in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296 [22:04:59] 1 Warning: Search backend highlighted a redirect (Wikimedia Mobile engineering/imported/Mobile projects/App Features & Roadmap) but didn't return it. [Called from CirrusSearchResult::findRedirectTitle in /usr/local/apache/common-local/php-1.22wmf17/extensions/CirrusSearch/CirrusSearchSearcher.php at line 589] in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296 [22:05:02] manybubbles: ^ [22:05:35] (03PS4) 10Legoktm: Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 [22:06:28] aude: ping? [22:06:39] Reedy: Setting and getting a bunch of keys isn't very intensive, right? Just the DB query? I'm reorganizing it so I can use the incr/decr business [22:07:27] If you're getting/updating rows that are indexed... [22:08:44] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84649 [22:08:45] (03PS2) 10Rahul21: Comment out the redundant check (title.getExtension() === null) as the body of the if is already commented [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:09:13] (03PS1) 10Santhosh: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 [22:09:27] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84651 [22:09:32] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84649 (owner: 10Mwalker) [22:09:50] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84651 (owner: 10Mwalker) [22:13:30] (03CR) 10Legoktm: [C: 032] Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 (owner: 10Legoktm) [22:14:04] (03Merged) 10jenkins-bot: Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 (owner: 10Legoktm) [22:15:30] Special:MWOAuthManageConsumers/proposed [22:15:53] (03CR) 10Mattflaschen: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 (owner: 10Rahul21) [22:16:34] (03Merged) 10jenkins-bot: Updating CentralNotice to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84649 (owner: 10Mwalker) [22:16:51] (03PS2) 10Santhosh: If UI and source languages are same, show total number of messages [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 [22:18:08] (03Merged) 10jenkins-bot: Updating CentralNotice to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84651 (owner: 10Mwalker) [22:19:17] (03PS3) 10Rahul21: Comment out the redundant check (title.getExtension() === null) as the body of the if is already commented [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:20:02] (03PS1) 10Santhosh: Remove hardcode percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 [22:22:29] Nikerabbit: want to run the translation group job now? [22:22:35] I just ran my maintenance script [22:22:43] (03PS3) 10Legoktm: Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 [22:22:44] (03CR) 10jenkins-bot: [V: 04-1] Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 (owner: 10Legoktm) [22:22:57] Reedy or any core deployer, what triggers DB updates when you add a new extension in production? Does deployment automatically run maintenance/update.php ? [22:23:04] Nothing [22:23:08] and definitely not!! [22:23:12] spagewmf: you run your sql manually [22:23:25] if approved etc [22:23:40] (03CR) 10BryanDavis: "(1 comment)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 (owner: 10BryanDavis) [22:23:41] yeah we don't use update.php in production because those updaters can be slow, and don't play too well with replication [22:23:55] (03PS2) 10BryanDavis: Add switch to log eventlogging-devserver output to file. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 [22:23:59] and because RoanKattouw will "fly over to sf and hit you" [22:24:02] hehehe [22:24:16] thanks... so for extra bonus points is it also manual on the beta labs cluster? [22:24:17] IIRC you can't run update.php now [22:24:26] (03PS3) 10BryanDavis: Add switch to log eventlogging-devserver output to file. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 [22:24:52] I think it might be for beta as it just updates to master [22:25:14] (03PS1) 10Aaron Schulz: Fixed check of BagOStuff set() return value in mctest [core] - 10https://gerrit.wikimedia.org/r/84655 [22:25:33] (03PS2) 10Santhosh: Remove hardcode percent signs [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84653 [22:25:45] mwalker: Clearly that documentation needs to be improved ;) [22:25:50] (03PS4) 10Legoktm: Use wfWikiID() so we also get any $wgDBprefix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83595 [22:26:02] mwalker: oh sure let me see [22:26:13] Reedy: where'd you go? [22:26:27] (03PS2) 10Santhosh: Add logout link to company login link [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83079 (owner: 10Nikerabbit) [22:26:41] to find out what one of my colleagues are doing [22:26:53] heh [22:26:56] * mwalker hides [22:27:00] Reedy: well, can you try testing https://gerrit.wikimedia.org/r/#/c/83595/? [22:27:17] (03CR) 10BryanDavis: "Ori: I resorted to this after trying 4 different methods of redirecting stdout under upstart and not find any of them that resulted in a l" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84626 (owner: 10BryanDavis) [22:27:36] Testing is hard [22:27:37] :p [22:28:00] And I'm in the middle of updating all the repos [22:28:02] * Reedy waits [22:28:05] mwalker: hmph, are you sure? I don't see any speedup :( [22:28:43] (03CR) 10MaxSem: "(1 comment)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [22:29:50] Nikerabbit: ya; it ran -- CN is only trying to create 212 groups now -- but clearly that didn't have as big a benefit as I would have hoped [22:30:21] (03CR) 10Nikerabbit: [C: 04-1] "(3 comments)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [22:30:21] so the big bottleneck is still the parsing of the banners [22:30:25] (03PS4) 10Rahul21: Commented out the redundant check (title.getExtension() === null). [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:32:57] (03CR) 10Mattflaschen: "Sorry, just noticed an indent issue." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 (owner: 10Rahul21) [22:33:21] (03CR) 10Nikerabbit: "Seen while testing: Strict Standards: Non-static method MessageGroups::haveSingleSourceLanguage() should not be called statically, assumin" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84190 (owner: 10Amire80) [22:33:31] (03CR) 10Mattflaschen: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 (owner: 10Rahul21) [22:34:33] (03PS5) 10Rahul21: Comment out the redundant check (title.getExtension() === null) as the body of the if is already commented [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:39:09] (03CR) 10Nikerabbit: [C: 031] "OK but needs rebased after dependency has been merged." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84637 (owner: 10Santhosh) [22:41:48] (03CR) 10Nikerabbit: "I thought we wanted to show the number of languages instead of number of messages?" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84650 (owner: 10Santhosh) [22:43:42] (03PS2) 10Jackmcbarn: Fix SQLite being incompatible with AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 [22:43:45] (03CR) 10Santhosh: [C: 032] Add logout link to company login link [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83079 (owner: 10Nikerabbit) [22:43:56] (03Merged) 10jenkins-bot: Add logout link to company login link [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83079 (owner: 10Nikerabbit) [22:45:14] (03PS6) 10Rahul21: Comment out the redundant check. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 [22:46:51] (03CR) 10Mattflaschen: [C: 032] "Thanks, fm is good now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 (owner: 10Rahul21) [22:46:55] (03Merged) 10jenkins-bot: Comment out the redundant check. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84647 (owner: 10Rahul21) [22:47:25] (03PS1) 10MarkTraceur: Increment and decrement memcached on pref save [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84657 [22:48:05] Reedy: See ^ for the incr/decr business [22:48:12] It's frickin' magical, thanks for the tip [22:48:36] Though I'm a mite disappointed in the method for checking whether an option was just changed, I may toy with that [22:48:50] But it can happen later. [22:54:18] checking with Reedy about username preferences ori-l [22:54:21] (03PS1) 10Jackmcbarn: Store boolean values as integers with SQLite [core] - 10https://gerrit.wikimedia.org/r/84658 [22:54:24] * user preferences [22:56:43] Reedy: wpvector-collapsiblenav so guess the preference is vector-collapsiblenav ? [22:57:31] (03CR) 10Jackmcbarn: "Though it's always sane to only connect to remote databases when you need to, it's only necessary with SQLite, so that's why I phrased it " [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84185 (owner: 10Jackmcbarn) [23:01:34] (03PS6) 10Jdlrobson: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 [23:01:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:01:49] ori-l: ^ :( [23:06:04] (03CR) 10Bsitu: [C: 032 V: 032] I18N message cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 (owner: 10EBernhardson (WMF)) [23:06:18] (03PS1) 10Legoktm: Display how many pages we have queued messages to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/84661 [23:09:35] (03PS3) 10Jdlrobson: Move code for navigation collapsing to core [core] - 10https://gerrit.wikimedia.org/r/83591 [23:11:13] (03PS7) 10Jdlrobson: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 [23:13:14] Reedy, Brion: FYI beta labs now has the new extension's tables (yay); Željko thinks it runs a script periodically. [23:13:45] (03CR) 10jenkins-bot: [V: 04-1] Move code for navigation collapsing to core [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [23:15:30] hashar: dormez-vous, otherwise can you comment on ^beta labs question? [23:15:45] (03CR) 10Jdlrobson: [C: 04-2] "Oop something broke with this change. fixing up now." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [23:16:38] hashar, chrismcmahon : also, http://en.wikipedia.beta.wmflabs.org/wiki/Special:Flow/Sandbox doesn't have strings, is there a similar "periodically update i18n cache on beta labs" script ? [23:18:06] spagewmf: I sent hashar email, I restarted memcached on beta but it didn't dtrt [23:18:33] (03CR) 10Zfilipin: [C: 032] remove VE tests now that they reside in /mediawiki/extensions/VisualEditor [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84643 (owner: 10Cmcmahon) [23:20:25] spagewmf: hey :) [23:21:07] ah l18n cache not updated grblbmbm [23:21:57] hasharBusy, chrismcmahon: no worries, I'll file a bug about l10n cache. Interestingly, Flow on beta labs is using VE! [23:22:05] chrismcmahon: spagewmf : the i18n cache refresh is part of the beta-code-update job which update core and extensions. [23:22:23] it runs every 6 minutes or so https://integration.wikimedia.org/ci/job/beta-code-update/? [23:22:47] spagewmf hasharBusy rawk! [23:22:53] hasharBusy: is that also the script that updated the SQL? At first the tables were missing, then they appeared! [23:23:05] greg-g: just fyi ^^ [23:23:31] ah no the SQL is updated only once per hour :( [23:23:45] https://integration.wikimedia.org/ci/job/beta-update-databases/ [23:23:56] triggering it manually now [23:24:15] the jobs are described at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated which is reachable from the front page https://wikitech.wikimedia.org/wiki/Beta [23:25:24] (03PS4) 10Jdlrobson: Move code for navigation collapsing to core [core] - 10https://gerrit.wikimedia.org/r/83591 [23:25:49] spagewmf: so this then https://integration.wikimedia.org/ci/job/beta-update-databases/label=betacluster,wikidb=enwiki/lastBuild/console [23:27:16] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson) [23:27:29] neat! [23:28:33] the l10n cache entries got last updated on Sep 17 22:37 UTC [23:28:47] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [23:32:02] > var_dump( wfMessage('flow-specialpage')->exists() ); [23:32:03] bool(false) [23:32:03] :( [23:32:26] (03PS1) 10Physikerwelt: Make inline mode the default option [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84667 [23:33:16] hasharBusy: Mash F5 till it works [23:33:27] (03CR) 10Physikerwelt: [C: 032] Make inline mode the default option [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84667 (owner: 10Physikerwelt) [23:33:31] :-] [23:34:50] > return array_key_exists('Flow',$wgExtensionMessagesFiles); [23:34:51] bool(false) [23:34:59] that is on enwiki beta :( [23:38:13] (03PS17) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [23:38:24] jdlrobson: on stat1, mysql, use log; then select * from ServerSideAccountCreation_5487345 where event_campaign = 'mobile_uploadPageActionCta'; [23:39:03] and my goto show values: select event_campaign, count(1) from ServerSideAccountCreation_5487345 GROUP BY 1; [23:40:06] (03PS1) 10Aaron Schulz: Removed b/c code that triggered long key errors [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/84670 [23:43:19] spagewmf: sorry I have no clue why the Flow i18n file is not in $wgExtensionMessagesFiles :( [23:43:39] (03CR) 10Platonides: "(8 comments)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal) [23:45:58] (03CR) 10Ori.livneh: "PS17:" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:48:15] (03PS1) 10Aaron Schulz: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/84675 [23:51:57] (03CR) 10Manybubbles: "(3 comments)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/84559 (owner: 10Manybubbles) [23:52:24] (03PS1) 10Aaron Schulz: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/84678 [23:52:29] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:55:44] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84658 (owner: 10Jackmcbarn) [23:55:52] (03PS1) 10Bsitu: Fix some RTL issue and add sans-serif as fallback font [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84680 [23:56:38] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:58:26] Nikerabbit: you still around? [23:59:17] (03CR) 10Jdlrobson: [C: 031] "@Krinkle in response to "Also, perhaps in a separate commit, but converting at least 1 module to use LESS in core would demonstrate how i" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:59:52] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 (owner: 10MarkTraceur)