[01:33:45] (03PS1) 10Gnosygnu: v0.9.2.0 [xowa] - 10https://gerrit.wikimedia.org/r/84291 [01:34:32] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving my commit" [xowa] - 10https://gerrit.wikimedia.org/r/84291 (owner: 10Gnosygnu) [02:06:56] (03PS1) 10Ori.livneh: Create a packages namespace for role package dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/84292 [02:09:12] (03CR) 10Ori.livneh: [C: 032] "I'm self-merging for reasons of hubris and haste, but ex post gerrito reviews are welcome." [vagrant] - 10https://gerrit.wikimedia.org/r/84292 (owner: 10Ori.livneh) [02:09:15] (03Merged) 10jenkins-bot: Create a packages namespace for role package dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/84292 (owner: 10Ori.livneh) [02:48:34] (03CR) 10Jackmcbarn: "Currently, autopatrolled users can mark patrolled any pages they made before becoming autopatrolled. Wouldn't this stop them from doing so" [core] - 10https://gerrit.wikimedia.org/r/74855 (owner: 10Hoo man) [02:58:04] (03PS1) 10Mollywhite: Bug 52331: Prevent navbars from appearing in diff view. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/84293 [03:00:03] (03PS2) 10Mollywhite: Bug 52331: Prevent navbars from appearing in diff view. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/84293 [04:13:37] (03CR) 10Parent5446: [C: 031] Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [04:14:47] (03CR) 10Parent5446: "I'll let Matt take a look at this for the userId thing, although usually 0 is the user id for anonymous users. Everything else looks good." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [04:34:14] (03PS2) 10PleaseStand: Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF [core] - 10https://gerrit.wikimedia.org/r/48743 (owner: 10Platonides) [04:49:24] (03CR) 10PleaseStand: "Made "[...] the implementation more strict" in I56ae496d17ffc3747550e06a72dacab3ac55da61." [core] - 10https://gerrit.wikimedia.org/r/65300 (owner: 10JanZerebecki) [05:08:19] (03CR) 10AndyRussG: "OK...! How would you suggest it be taken into account? Maybe mouseenter/mouseleave handlers shouldn't be attached in a touch context?" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/83363 (owner: 10AndyRussG) [06:55:59] (03PS1) 10Rfaulk: add - paramiko dependecy. [sartoris] - 10https://gerrit.wikimedia.org/r/84294 [06:56:00] (03PS1) 10Rfaulk: rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 [06:56:01] (03CR) 10jenkins-bot: [V: 04-1] add - paramiko dependecy. [sartoris] - 10https://gerrit.wikimedia.org/r/84294 (owner: 10Rfaulk) [06:56:06] (03CR) 10jenkins-bot: [V: 04-1] rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 (owner: 10Rfaulk) [06:57:33] (03CR) 10Rfaulk: [C: 032 V: 032] rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 (owner: 10Rfaulk) [06:57:37] (03CR) 10jenkins-bot: [V: 04-1] rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 (owner: 10Rfaulk) [06:59:46] (03PS1) 10Ori.livneh: Improve styling of schema code samples dialog [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84296 [07:00:33] (03PS2) 10Ori.livneh: Improve styling of schema code samples dialog [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84296 [07:01:46] (03PS2) 10Rfaulk: add - paramiko dependecy. [sartoris] - 10https://gerrit.wikimedia.org/r/84294 [07:02:37] (03PS2) 10Rfaulk: rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 [07:02:48] ori-l: you should go to sleep now [07:02:58] (03CR) 10Rfaulk: [C: 032 V: 032] rm - _get_current_lock_user, obsolete. [sartoris] - 10https://gerrit.wikimedia.org/r/84295 (owner: 10Rfaulk) [07:03:12] undoubtedly [07:04:25] (03CR) 10Rfaulk: [C: 032 V: 032] add - paramiko dependecy. [sartoris] - 10https://gerrit.wikimedia.org/r/84294 (owner: 10Rfaulk) [07:04:57] hey look! ori-l & YuviPanda are on irc [07:05:13] bd808: you're on a phone; it doesn't count [07:05:13] bd808: sushhh, don't ping ori -l, he should sleep [07:06:14] bd808: also, that chinese food place was a bad idea. let's not go there again [07:06:23] I'm actually on a laptop at the moment. I started poking at https://bugzilla.wikimedia.org/54042 [07:06:50] ah, nifty [07:06:53] thanks! [07:06:55] YuviPanda: Agreed. Bad Chinese food is bad jsut as obious toll is obvious [07:07:03] true. [07:07:22] in other news, I can't type well while laying in bed [07:07:33] bd808: yeah, that's nice bug to fix. Perhaps we can also convince UploadWizard to run vagrant on his machine [07:07:37] instead of doing it all by hand [07:07:54] Ah christ [07:08:01] bad chinese food : bad :: obvious troll : obvious [07:08:02] It's probably possible after you make it not need vagrant [07:08:21] bd808: He meant me [07:09:26] marktraceur: I know. The subtle ping [07:09:30] *nod* [07:09:45] Then maybe I've misunderstood [07:10:03] marktraceur: no, mostly it is to attempt to convince you to run vagrant [07:10:08] but that was a side issue [07:10:11] bd808: ori-l https://bugzilla.wikimedia.org/show_bug.cgi?id=54160 [07:10:23] i already replied [07:10:27] you're too slow [07:10:29] yeah, that [07:10:45] YuviPanda: I have no reason to run vagrant [07:10:54] Because I can run useful software on my computer without hacks [07:11:11] but you could run puppet config direct on host os with a few tweaks [07:11:16] oh look, the new guy at the mosque is convinced we're all infidel sellouts [07:11:19] bd808: yeah, that's what *I* want to do [07:11:28] And without loads of overhead that my hardware doesn't particularly like running all the time [07:11:57] bd808: although I can't do halt / up, but that's acceptable [07:12:20] bd808: hmm, I would like a variant of halt / up even if it is my host OS though, because I don't want apache and mysql running all the time [07:12:23] * YuviPanda ponders [07:12:45] `service X stop`? [07:12:57] bd808: for n number of services [07:13:24] if only there was a way to alias a group of shell commands rather than just one [07:13:30] * bd808 makes not to introduce YuviPanda to the concept of shell scripting [07:13:36] s/not/note/ [07:13:47] bd808: pfft, that's so 1990s [07:13:56] '70s actually [07:14:17] bd808: i didn't exist then :P [07:14:44] E_INVALIDEPOCH [07:14:56] bingo! [07:15:14] YuviPanda: edit the upstart job definition files (in /etc/init) and add a 'stop on vagrant-halt' directive [07:15:23] then 'initctl emit vagrant-halt' to stop [07:15:28] aha! [07:15:35] that should work [07:15:38] wizardry! [07:15:39] but something tells me you're looking for an excuse to futz around with LXC containers :P [07:15:59] ori-l: i swear that up until this point I hadn't thought of it, but now that you mention it.... :D [07:16:06] ori-l: of course, all this is dependent on me getting a new latpop [07:16:08] *laptop [07:16:25] the upstart trick will work for starting services too [07:16:55] i didn't know you could emit things that way [07:16:55] start on vagrant-up ; stop on vagrant-halt [07:17:06] my linuxfu has grown weaker [07:17:13] yeah you can make up any random signals you want [07:17:37] and emit them manually or as part of another upstart script [07:17:40] right [07:17:42] too bad the dbus python API is so awful [07:17:51] s/linux/upstart/ [07:17:53] that's an insult to the word awful [07:18:12] marktraceur: yeah, but my linuxfo in general has grown weaker [07:18:25] 'i want the pid of running service X' is like 30 lines [07:19:01] heh [07:19:57] ori-l: in python dbus-ese? [07:21:46] (03CR) 10Yury Katkov: [C: 04-1] "I don't see where do you check the origin of the term. As we've told , if the text comes from the template, you should show the cancellati" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [07:22:00] bd808: yeah [07:22:28] `ps ax|grep upstart|awk '{print $1}'` [07:22:44] shell ftw [07:23:48] https://git.wikimedia.org/blob/operations%2Fpuppet.git/f2c64d9d3aa21d4d7decda8b9fb92124d4d50de8/modules%2Feventlogging%2Ffiles%2Feventloggingctl [07:24:04] i was trying to improve on that [07:24:50] ended up with https://dpaste.de/YVN4f/ [07:24:56] but it's too ugly and verbose [07:32:49] ok kids I gotta try to sleep so I can got to work in the morning. l8r [07:33:17] Niiight [07:37:28] (03CR) 10jenkins-bot: [V: 04-1] Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [07:42:18] (03PS1) 10Spage: Add a missing /*_*/ prefix on a CREATE INDEX [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84297 [07:44:03] hmmm [07:44:19] anybody here familiar with wl_notificationtimestamp functionality? [07:44:34] (03PS4) 10Netbrain: Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 [07:44:44] (03CR) 10jenkins-bot: [V: 04-1] Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [07:45:15] i'm trying to figure out how that stuff works for https://bugzilla.wikimedia.org/show_bug.cgi?id=41759 [07:49:02] (03PS3) 10PleaseStand: Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF [core] - 10https://gerrit.wikimedia.org/r/48743 (owner: 10Platonides) [07:49:13] Reedy: there? :D [07:50:04] Reedy: hypothetically, if i wanted to make watchlist.wl_notificationtimestamp NOT NULL and fill in default values in update.php, how bad would that be on wikimedia cluster? [08:03:25] (03PS5) 10Netbrain: Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 [08:03:29] (03CR) 10jenkins-bot: [V: 04-1] Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [08:04:52] (03PS6) 10Netbrain: Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 [08:07:39] MatmaRex: s.pringle_away is probably the best person to ask [08:07:58] probably not very bad; filling in default values could be done in batches [08:11:57] ori-l: i dug a little and i probably don't want to do that anyway [08:12:14] the email notification / page view marking code sucks, btw. :/ [08:12:29] i don't think i ever looked at it [08:14:20] i'd really love to do https://www.mediawiki.org/wiki/Requests_for_comment/Support_for_user-specific_page_lists_in_core some time [08:14:48] ori-l: didn't that get on someone's roadmap? [08:15:03] did it? [08:15:24] YuviPanda: ori-l: that or something similar was implemented by a GSOC student last year and is rotting in gerrit [08:15:40] ori-l: not sure. vague hearing memories. [08:15:45] MatmaRex: don't remember that happening [08:15:51] https://gerrit.wikimedia.org/r/#/c/16419/ [08:15:55] YuviPanda: ^ [08:15:55] woo [08:16:02] Uploaded Jul 23, 2012 6:02 PM [08:16:14] MatmaRex: 'rotting in gerrit' is not a fair description, IMO, since it suggests the patch was neglected by reviewers, whereas it was in fact abandoned by the author [08:16:39] ori-l: 'rotting' as in 'bit-rot' [08:16:49] too big to be one change, perhaps [08:17:05] I'll note that my GSoC code is even worse - rotting in *SVN* [08:17:06] so [08:17:06] MatmaRex: i probably read into your statement more than you were actually saying [08:17:08] ori-l: but a change not being merged for a year is probably a fault of both sides :) [08:17:29] i didn't read through the reviews / patchsets, you may be right [08:17:40] i just know it's there and it's a thousand-line patch that doesn't merge anymore [08:18:07] MatmaRex: it seems to be mostly Reedy uploading new patchsets there now [08:18:17] "now" [08:18:20] "2012" [08:18:20] :D [08:18:27] :D [08:18:28] okay, february 2013. close enough [08:19:01] * YuviPanda wonders if his GSoC code will ever see the light of day [08:19:54] * MatmaRex wonders what was YuviPanda's GSOC code [08:20:12] I am not proud enough of it to tell you that :P [08:20:16] but you can easily dig around and find it [08:20:28] jesus, I don't even remember the name anymore. [08:21:01] heh [08:21:07] (03PS4) 10Netbrain: enabled parameter "transpose" and added phpunit test. [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 [08:22:00] MatmaRex: heh, random mirror: https://github.com/svn2github/wikia/tree/master/extensions/SelectionSifter [08:22:11] MatmaRex: dont' judge me! That wasn't the best code I've written. [08:23:15] YuviPanda: heh, you can find some of my code from 2011 online too (but please don't) [08:23:21] hehe :P [08:24:01] MatmaRex: http://yuvipanda.blogspot.com/ is my blog from 2005-2007... [08:24:13] i even had a post there saying how much better IE6 was than Firefox... [08:24:24] (http://yuvipanda.blogspot.com/2005_05_01_archive.html) [08:24:30] but in my defence I was 14 [08:24:39] and my english was a lot worse too! [08:25:08] thankfully my blog from a few years back has gone down, i think [08:25:26] mine from 2007-09 is down, sadly [08:25:35] it was a very fun, interesting period of my life. [08:25:40] hurr durr to not backing up [08:25:41] but the site is still up :D http://matma-rex.prv.pl/?lang=en [08:26:04] nice! [08:26:20] also by the time I was writing code that I wanted to show off / put up, github was already a thing [08:26:26] my svn experiences were very limited [08:27:40] i should sleep [08:27:42] night [08:31:51] (03CR) 10Mwjames: "(2 comments)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [08:33:06] (03CR) 10Netbrain: "Yeah something went wrong during rebase..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [08:45:13] (03PS5) 10Netbrain: Do not run code coverage as we can still not do a full Composer install with MW [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 [08:46:01] (03CR) 10Netbrain: "Oh, god.. im royally messing this up. Let me try to fix." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [08:49:02] (03PS6) 10Netbrain: enabled parameter "transpose" and added phpunit test. [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 [08:52:01] (03CR) 10TheDJ: "https://bugs.webkit.org/show_bug.cgi?id=116046" [core] - 10https://gerrit.wikimedia.org/r/80799 (owner: 10TheDJ) [08:52:50] (03PS7) 10Mwjames: enabled parameter "transpose" and added phpunit test. [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [08:53:52] hmmmm [08:54:16] does HTMLFileCache have no concept of revision id? [08:55:53] or, in other words, can is assume that if there's a hit in HTMLFileCache, then that hit is for the latest revision of the page? [09:05:08] (03CR) 10Mwjames: "Not sure why but the test should have failed on Jenkins (locally it does fail) because use $labels... instead of $random ..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [09:10:32] (03CR) 10TheDJ: "I can't do code review if I don't have time. I'm sorry, but that's how it is. I know the feeling though, it's frustrating as hell." [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [09:26:07] (03CR) 10Tpt: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 (owner: 10Rtdwivedi) [09:43:16] (03CR) 10Netbrain: "wow, thats wierd. php tests passes when i try to run them locally." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [09:49:30] (03PS8) 10Netbrain: enabled parameter "transpose" and added phpunit test. [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 [09:50:40] (03CR) 10Netbrain: "MWJames, would you mind adding the proper matching data? i can't seem to get it to work." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/74329 (owner: 10Netbrain) [10:34:50] (03PS1) 10TTO: Update default contents of interwiki table [core] - 10https://gerrit.wikimedia.org/r/84303 [11:03:59] (03CR) 10Legoktm: [C: 04-1] "This list is used by 3rd party sites as well, so Wikimedia sites should not be marked as local." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [11:16:18] (03CR) 10Nemo bis: [C: 04-1] "I don't think it's a good idea to remove interwikis just because the website disappered: in this way, the user doesn't even know what the " [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [11:26:03] huh… wtf is that code [11:26:05] !hook NewDifferenceEngine [11:26:05] https://www.mediawiki.org/wiki/Manual:Hooks/NewDifferenceEngine [11:26:43] guess when that hook is actually called. [11:26:53] there's a condition [11:26:56] or even two [11:27:51] only when you're doing diff=12345, but not when diff=prev or diff=next [11:27:52] wtf [11:32:24] AaronSchulz: explain yourself, that's your fault. :D [11:33:02] (03CR) 10Esanders: "Could we separate PS5 into a separate optimisation commit? It looked like Timo & David's version worked, even if it wasn't necessarily the" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [11:33:18] ah, or maybe not… [11:33:32] actually, yes [11:33:38] http://mediawiki.org/wiki/Special:Code/MediaWiki/45518 [11:34:52] AaronSchulz: so, is NewDifferenceEngine supposed to only be run in this case, or always? [11:35:22] (03CR) 10TTO: "Legoktm: The iw_local was already set up that way; I just followed the pattern of what was already there. Don't ask me why. I think that c" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [12:14:37] (03CR) 10Nemo bis: "TTO, which of the two files is actually used to make the interwiki map? Chad once removed the sql as unused." [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [12:19:57] (03CR) 10TTO: "I would like to know that myself. Evidently Chad removed the sql version, but noticed some breakage and so restored it. I'll have to go hu" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [12:21:21] (03CR) 10Peachey88: "Please fix up your commit message: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup) [12:24:22] (03CR) 10TTO: "Here we go: interwiki.sql is run at line 303 of includes/installer/MysqlUpdater.php. Presumably the intention is to eventually replace it " [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [12:25:19] (03PS2) 10Ladsgroup: Adding a space character between links in the special page in order to avoid bad rendereing in languages like Persian [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 [12:27:44] (03PS3) 10Ladsgroup: Adding a space character between links in the special page [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 [12:28:07] (03CR) 10Ladsgroup: "Thank you. Is it okay now?" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup) [12:29:32] (03CR) 10Peachey88: "It's not scrolling off my screen, So i'm fine with it." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 (owner: 10Ladsgroup) [12:29:34] (03PS1) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [12:29:43] ^ that's one beautiful long commit message i wrote. [12:54:03] (03PS2) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [13:18:36] (03CR) 10Karima Rafes: [C: 032 V: 031] If the SPARQL response gives a empty value the $variable won't be set and will trigger a notice. This fix prevents the notice. [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/83612 (owner: 10Your1) [13:18:39] (03Merged) 10jenkins-bot: If the SPARQL response gives a empty value the $variable won't be set and will trigger a notice. This fix prevents the notice. [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/83612 (owner: 10Your1) [13:18:50] (03CR) 10Yury Katkov: "sorry, you should NOT show the cancellation button if the text comes from the template" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [13:18:57] (03PS1) 10Manybubbles: Warn over api when prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 [13:21:03] (03CR) 10Manybubbles: "This won't rebase cleanly with https://gerrit.wikimedia.org/r/#/c/83807/ and, if they are both good, I'd prefer to rebase this change on t" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 (owner: 10Manybubbles) [13:38:11] (03PS1) 10Manybubbles: Test for warning if prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84322 [14:11:07] (03PS5) 10Rtdwivedi: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 [15:20:27] This page looks slightly neglected https://www.mediawiki.org/w/index.php?title=Extension_hook_registry&action=history [15:23:11] "slightly" [15:26:23] @seen bawolff [15:26:23] MatmaRex: Last time I saw bawolff they were quitting the network with reason: Quit: ChatZilla 0.9.90.1 [Iceweasel 3.5.16/20121207230533] N/A at 9/12/2013 2:25:02 AM (4d13h1m21s ago) [15:31:31] (03PS1) 10Aude: Update DataValues to fix JS rendering of coordinate values [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84329 [15:35:23] hmmm. i need someone for some interesting multidisciplinary code review. maybe brion? :D [15:37:43] (03PS1) 10Nemo bis: Allow to customise the torblock-blocked message [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/84331 [15:37:48] oh that sounds fun :) [15:38:39] brion: https://gerrit.wikimedia.org/r/#/c/84315/ :D [15:39:30] brion: there's also https://gerrit.wikimedia.org/r/#/c/82100/ , if you prefer, but that's way more interesting and multidisciplinary and fun [15:45:47] manybubbles: ping [15:47:30] lemme add those to my list :D [15:48:40] (03PS1) 10Nemo bis: Allow to customise the globalblocking-ipblocked* messages [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/84333 [15:49:29] first, some food… then probably head into the office, and then some code review \o/ [15:50:57] <^d> brion: Code review + breakfast is fun :) [15:51:26] ^d has code review for breakfast [15:51:44] <^d> nom nom nom. [15:51:59] "I love the smell of a +2 in the morning" [15:58:07] (03CR) 10Chad: [C: 032] Implement morelike: for more like this. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83807 (owner: 10Manybubbles) [15:58:10] (03Merged) 10jenkins-bot: Implement morelike: for more like this. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83807 (owner: 10Manybubbles) [15:58:18] (03CR) 10Chad: [C: 032] Tests for morelike:. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83819 (owner: 10Manybubbles) [15:58:20] (03Merged) 10jenkins-bot: Tests for morelike:. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83819 (owner: 10Manybubbles) [15:59:22] (03CR) 10Chad: [C: 032] Test for warning if prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84322 (owner: 10Manybubbles) [15:59:25] (03Merged) 10jenkins-bot: Test for warning if prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84322 (owner: 10Manybubbles) [16:03:37] (03PS2) 10Chad: Warn over api when prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 (owner: 10Manybubbles) [16:04:25] (03PS3) 10Chad: Warn over api when prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 (owner: 10Manybubbles) [16:04:34] (03CR) 10Chad: [C: 032] Warn over api when prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 (owner: 10Manybubbles) [16:04:36] (03Merged) 10jenkins-bot: Warn over api when prefix search too long [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84320 (owner: 10Manybubbles) [16:12:22] (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [16:12:55] MatmaRex: i'm not sure it's actually a problem to reset the timestamp in this way when viewing an old rev, but it feels odd [16:14:05] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [16:14:07] D: [16:14:14] no, i'm just dumb and forgot about this [16:14:27] thanks for the CR :D [16:14:45] :D [16:15:57] (03CR) 10JanZerebecki: "Yes, after that patch is merged I will pick this up again." [core] - 10https://gerrit.wikimedia.org/r/65300 (owner: 10JanZerebecki) [16:22:09] (03CR) 10Tpt: [C: 032] Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 (owner: 10Rtdwivedi) [16:22:21] (03Merged) 10jenkins-bot: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 (owner: 10Rtdwivedi) [16:22:41] hmm [16:22:51] I can't get $wgVectorUseSimpleSearch to work on my install, wtf? [16:23:36] huh. [16:23:47] checked for typos? :P [16:23:56] oh god dammit [16:23:59] there's a user option that was off [16:24:00] WHYYYYYY [16:24:36] (03PS1) 10Manybubbles: Escape highlighted snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 [16:25:52] hmm [16:26:08] for future reference: prefix searching on latin names in RTL mode doesn't look so hot [16:26:32] ok that's def not a new bug though, is ee it in production [16:26:34] will make ante for later [16:26:35] *a note [16:27:19] hmmmm no wait [16:27:20] <^d> Ugh. [16:27:23] ugh anyway i'll make a note to look later [16:27:26] RTL fun :D [16:27:46] <^d> I can't build PHP :\ [16:27:54] ouch [16:28:13] <^d> Damn OSX. [16:28:19] <^d> ./configure: no such file or directory [16:29:47] (03CR) 10Brion VIBBER: [C: 031] "So far so good in ad-hoc testing (needs double-checking in various browsers though)." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [16:30:03] no surprises that i noticed so far :) [16:30:49] yay [16:30:53] wow did i not notice PHP 5.5? [16:30:58] * brion goes to download [16:31:14] the search suggestion position is a little on on IE6, but only in LTR mode [16:31:24] i didn't pull my hair out over this, though [16:31:29] ugh i need to find my windows xp VM [16:31:38] it's either on this external hard drive, or an SD card that I forget where i put it [16:31:58] well i can always reinstall… xp is small :D [16:33:11] fun fact: an entire XP VM takes less ram than your browser. [16:33:44] (03CR) 10Chad: "I'm not sure I see the reason in escaping the unescaping the pre/post bits?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 (owner: 10Manybubbles) [16:33:57] (03CR) 10Chad: "*escaping then unescaping" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 (owner: 10Manybubbles) [16:34:05] ok, looks like it'l be easier to install a fresh one… i can find my ISOs but not the last VM i installed [16:37:36] oh wow, XP had the old-school blue text-mode installer portion [16:37:41] reminds me of win 3.1 :D [16:39:17] (03CR) 10Manybubbles: "The post/pre bits have to go out to the client unescaped but come back from elasticsearch mixed with content we don't trust. Since we don" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 (owner: 10Manybubbles) [16:39:23] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Add a missing /*_*/ prefix on a CREATE INDEX [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84297 (owner: 10Spage) [16:47:10] (03CR) 10Chad: [C: 032] Escape highlighted snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 (owner: 10Manybubbles) [16:47:12] (03Merged) 10jenkins-bot: Escape highlighted snippets [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84340 (owner: 10Manybubbles) [16:47:21] mwalker|away, good news for HTML printing with phantomjs, in the longer term: http://blog.qt.digia.com/blog/2013/09/12/introducing-the-qt-webengine/ [16:48:29] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84341 [16:49:56] (03CR) 10Chad: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84341 (owner: 10Chad) [16:52:20] hmm, will qt end up shipping both webkit and chromium/blink for back-compatibility? heh [16:53:06] gaaaaah, i hate wl_notificationtimestamp [16:53:10] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84341 (owner: 10Chad) [16:53:14] the nulls have me write twice as much code as i should [16:54:59] (03PS1) 10MaxSem: Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 [16:55:26] (03PS1) 10Nemo bis: Add custom error messages to blocked users for global and Tor blocks [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/84343 [16:55:48] (03CR) 10jenkins-bot: [V: 04-1] Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem) [16:56:12] null checks everywhere. dammit, i'm not writing c [16:56:14] (03PS1) 10Rahul21: Making all handler handlers return $.Promise objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 [16:56:38] <^d> brion: How do you build php on osx? [16:56:45] <^d> I have memories of this working before... [16:56:59] (03CR) 10Nemo bis: "Alternative fix: https://gerrit.wikimedia.org/r/#/c/84343/" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/31672 (owner: 10Alex Monk) [16:57:12] ^d: ./configure works for me on php 5.5.3 ... [16:57:30] <^d> Grrr. [16:57:37] <^d> I'm using php-src. [16:57:41] <^d> From git. [16:57:53] (03CR) 10Nemo bis: "Ahem, sorry, that's not really related, this commit was just mentioned as example." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/31672 (owner: 10Alex Monk) [16:58:29] ick. need auto tools or some shit? [16:58:44] <^d> Hmm, downloaded tar works fine. [16:58:59] yay for broken source [17:01:47] (03PS2) 10DMaggot: Complete Implementation of additionalProperties [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84011 [17:02:31] (03CR) 10DMaggot: "Fixed commit message for better formatting." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84011 (owner: 10DMaggot) [17:02:41] hmmmm [17:02:56] if i need to handle rows that contain nulls specifically in an update query [17:03:17] should i first select them for update and have the logic php-side, or should i implement that in the sql query itself? [17:04:08] brion: ^ [17:10:27] (03CR) 10Bsitu: [C: 04-1] Notification with a later timestamp should be set as bundle base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82768 (owner: 10Bsitu) [17:11:07] The Man Who Would Build a Computer the Size of the Entire Internet http://www.wired.com/wiredenterprise/2013/09/docker/ [17:12:18] Reedy: Hopefully he doesn't connect it to the internet, or that article will only be half right [17:12:23] Nemo_bis: your bug was worse than expected. it has been fixed. [17:17:30] (03CR) 10MarkTraceur: [C: 04-1] "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 (owner: 10Rahul21) [17:18:30] manybubbles: thanks; yeah, I suspected some ugly escaping problems but better not give suggestions to evil attackers :) [17:19:28] Nemo_bis: indeed. all better now though. [17:20:45] (03PS4) 10Kaldari: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 [17:21:53] (03CR) 10Krinkle: [C: 031] "Untested." [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:22:31] that's the third +1. anyone wanna +2 it? :P [17:22:49] +1+1+1 != +3 [17:23:28] ty Reedy [17:24:41] MediaWiki is sexy and y'all should be proud of the things you've done. [17:24:46] ou [17:25:11] Isarra: WE MADE A FRICKEN ENCYCLOPEDIA [17:25:27] You made a bloody enablist piece of php horror! [17:25:38] Isarra: Is it random-statement time already? [17:25:39] And it's enabling me to be really lazy. It's awesome. [17:25:43] I'm barely into my first coffee [17:25:55] What sort of crazy timezone you in? [17:26:00] (03CR) 10Jdlrobson: "It is pretty useful for language links. I'd favour doing the move then reworking it slowly. It would be good for example to add tests firs" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [17:26:05] The timezone where I forgot to make coffee last night [17:26:08] Ah. [17:26:54] (03CR) 10Jdlrobson: "Bartosz what are the preference options? Are they used (widely?) Can we kill those? (killing preferences is always good)" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [17:27:18] Seriously, if you actually look at the things, they're often pretty damn neat. Like galleries! [17:27:22] Sexy! [17:27:27] * Isarra bounces off happily. [17:27:48] Isarra: I think you need to tell bawolff that. :P [17:28:48] marktraceur: I'll be sure to creep him out with a big hug when I see him, then. [17:29:03] Isarra: I'm sure he would have expected it anyway, but sure [17:29:17] (03CR) 10Physikerwelt: "even if this is not important... both your examples would not be touched because guessDisplaystyleFromTex would have found explicit style " [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [17:29:20] What if I put on another face first? Would he still expect it? [17:31:02] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:31:40] (03PS4) 10Krinkle: Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:31:46] It depends entirely on the type of face [17:32:00] (03PS5) 10Krinkle: Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:32:21] (03CR) 10Krinkle: [C: 032] Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:33:45] (03CR) 10Bartosz Dziewoński: "They're in Vector.hooks.php. Just grep the entire extension for 'collapsiblenav' (case-insensitive). IMO we can kill them (I said this muc" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson) [17:36:06] hmmm [17:36:15] what does mysql do when i call max() on a potentially null value? [17:36:55] select MAX(null) AS lol; [17:36:56] null! [17:38:20] (03Merged) 10jenkins-bot: Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Bartosz Dziewoński) [17:40:26] (03Abandoned) 10Krinkle: (DRAFT) Script to export redirects from a wiki [core] - 10https://gerrit.wikimedia.org/r/78001 (owner: 10Krinkle) [17:40:45] null to the MAX [17:43:21] (03PS3) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [17:45:33] brion: that should work, probably. ^ [17:45:59] i hate eveyrthing related to WatchedItem#resetNotificationTimestamp now. it's awful. [17:47:09] heh [17:48:42] i'm not sure what is that stupid $force parameter even for [17:49:06] Only update the timestamp if the page is being watched. [17:49:06] The query to find out if it is watched is cached both in memcached and per-invocation, [17:49:06] and when it does have to be executed, it can be on a slave [17:49:06] If this is the user's newtalk page, we always update the timestamp [17:49:12] is that even english? D: [17:50:29] heh, that comment is straight from 2005. [17:50:37] (03PS1) 10Manybubbles: Regression tests for javacscript injection. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84347 [17:51:38] of course the code it's commentng changed [17:51:54] http://mediawiki.org/wiki/Special:Code/MediaWiki/111190 [17:55:39] (03PS2) 10Nemo bis: Regression tests for javacscript injection. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84347 (owner: 10Manybubbles) [18:02:33] Fatal error: Class 'ResourceLoaderSchemaModule' not found in /var/www/DevWiki/core/includes/resourceloader/ResourceLoader.php on line 405 [18:02:34] * AaronSchulz hmms [18:02:50] that's an EventLogging class [18:02:55] are you using something that depends on EventLogging? [18:04:32] no [18:10:04] (03PS1) 10Aaron Schulz: Added simplified special page aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84348 [18:10:15] csteipp: ^ [18:13:31] @notify stevenw [18:13:31] I'll let you know when I see stevenw around here [18:13:34] @seenrx superm [18:13:34] MatmaRex: Last time I saw superm401 they were joining the channel, they are still in the channel #wikimedia-e3 at 9/16/2013 5:52:34 AM (12h21m0s ago) (multiple results were found: TB|supermarkt, TB|echtsupermark, superm401Temp, superm401_) [18:13:41] @notify superm401 [18:13:41] This user is now online in #wikimedia-e3. I'll let you know when they show some activity (talk, etc.) [18:14:08] (03CR) 10MaxSem: "recheck" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem) [18:18:13] (03PS1) 10Aude: Update DataValues with fix for coordinates in JS [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84349 [18:18:31] 180 Warning: Recursion detected in RequestContext::getLanguage in /usr/local/apache/common-local/php-1.22wmf16/includes/context/RequestContext.php on line 281 [18:18:35] These are getting silly [18:18:39] Reedy: https://gerrit.wikimedia.org/r/#/c/84349/ [18:18:49] when you update wikidata to wmf17 [18:19:00] ori-l: I see some other exts use it [18:19:23] disable UploadWizard makes it go away [18:19:31] * AaronSchulz looks at marktraceur [18:20:38] AaronSchulz: What do you mean, "disable UploadWizard"? [18:20:52] as in remove from localsettings [18:20:52] Oh, I see [18:21:06] * marktraceur looks at YuviPanda [18:21:13] I haven't touched the PHP for UW for a while [18:21:17] marktraceur: you need to make sure EventLogging is present before attempting to load schema modules. [18:21:19] maybe f930fb38ebbe490ab0068229df698dd03a107dfb [18:21:26] ori-l: I thought I did! [18:21:42] marktraceur: hmm, I think it's the modules that were added [18:21:49] you can take a look at how some other extensions do it like ULS [18:21:51] Oh. [18:21:51] RL modules [18:21:53] Crap. [18:21:55] (03CR) 10CSteipp: [C: 032] "Working great in test. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 (owner: 10Anomie) [18:22:04] (03Merged) 10jenkins-bot: Re-do edge login when JS login check succeeds [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 (owner: 10Anomie) [18:22:29] (03PS2) 10MaxSem: Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 [18:22:41] * marktraceur will write a fix in the next hour [18:22:53] If someone else gets to it first I won't be jealous, I'm in a meeting though [18:26:35] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis) [18:29:03] (03CR) 10Reedy: [C: 032 V: 032] Update DataValues with fix for coordinates in JS [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84349 (owner: 10Aude) [18:30:10] (03CR) 10CSteipp: [C: 032] Added simplified special page aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84348 (owner: 10Aaron Schulz) [18:30:33] (03CR) 10Manybubbles: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem) [18:30:46] (03Merged) 10jenkins-bot: Added simplified special page aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84348 (owner: 10Aaron Schulz) [18:34:57] Reedy: i think some old, broken js is stuck in caches [18:35:09] can you touch the extensions/DataValues/DataValues/resources/globeCoordinate.js/src/globeCoordinate.GlobeCoordinate.js file? [18:35:36] https://www.wikidata.org/wiki/Q30645 for example still has an error, but with debug=true it works [18:35:55] (03PS1) 10Reedy: Update VE to head of wmf/1.22wmf16 VE branch [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84353 [18:36:05] hmmm it seems to work now [18:36:08] maybe it's just me [18:36:25] (03CR) 10Reedy: [C: 032 V: 032] Update VE to head of wmf/1.22wmf16 VE branch [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84353 (owner: 10Reedy) [18:37:43] Reedy: seems okay [18:40:59] (03PS1) 10Reedy: Move VE to branched extensions [tools/release] - 10https://gerrit.wikimedia.org/r/84357 [18:41:38] (03CR) 10Reedy: [C: 032] Move VE to branched extensions [tools/release] - 10https://gerrit.wikimedia.org/r/84357 (owner: 10Reedy) [18:41:42] (03Merged) 10jenkins-bot: Move VE to branched extensions [tools/release] - 10https://gerrit.wikimedia.org/r/84357 (owner: 10Reedy) [18:46:05] (03PS3) 10MaxSem: Move HtmlFormatter from MobileFrontend [core] - 10https://gerrit.wikimedia.org/r/84342 [18:46:43] (03CR) 10CSteipp: [C: 032] "Working in test for me. Thanks!" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83849 (owner: 10Anomie) [18:46:44] (03CR) 10MaxSem: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84342 (owner: 10MaxSem) [18:47:07] (03Merged) 10jenkins-bot: Make ManageMyGrants look more like /authorize [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83849 (owner: 10Anomie) [18:56:07] manybubbles: ^d seems Cirrus isn't impressed with Translate stufff [18:56:19] Warning: CirrusSearch couldn't get parser output for MediaWiki 1.21/wmf5/as. Returning null text which should be skipped. [Called from CirrusSearchTextSanitizer::getSantizedTextFromTitle in /usr/local/apache/common-local/php-1.22wmf17/extensions/CirrusSearch/CirrusSearchTextSanitizer.php at line 38] in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296 [18:56:32] <^d> Full stacktrace? [18:57:02] we don't get them for warnings [18:57:22] there was numerous of htem for different pages [18:58:33] <^d> Ugh. [18:58:39] <^d> This is part of the code I hate anyway. [19:03:17] (03PS1) 10Reedy: Update VE to head of VE wmf/1.22wmf17 branch [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84365 [19:03:35] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 (owner: 10Bsitu) [19:04:11] (03CR) 10Reedy: [C: 032 V: 032] Update VE to head of VE wmf/1.22wmf17 branch [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84365 (owner: 10Reedy) [19:04:57] ugh [19:05:04] why is that happening? [19:07:17] (03PS1) 10Aaron Schulz: Made grants management page available everywhere [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84366 [19:17:21] YuviPanda / tfinc: data recovery mostly done, should be done by end of day today [19:18:43] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [19:18:52] Reedy: still on marking for translation, or even in normal user view? [19:19:03] No idea [19:19:16] What I pasted is all the information we have [19:19:32] (03CR) 10Parent5446: [C: 032] Don't ask users to mark own page creations as patrolled [core] - 10https://gerrit.wikimedia.org/r/74855 (owner: 10Hoo man) [19:20:41] (03CR) 10Parent5446: [C: 04-1] "What's the purpose of this? Can't you just override the message on-wiki?" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/84331 (owner: 10Nemo bis) [19:20:42] (03PS3) 10Bsitu: Make html email look prettier on mobile device [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 [19:21:57] (03CR) 10Nemo bis: "Parent5446, on 800 wikis? Have you read the bug?" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/84331 (owner: 10Nemo bis) [19:22:31] (03Merged) 10jenkins-bot: Don't ask users to mark own page creations as patrolled [core] - 10https://gerrit.wikimedia.org/r/74855 (owner: 10Hoo man) [19:22:55] (03CR) 10Nemo bis: "Subsequent commit = Id45385f8dc3edaaef049c535ea6037c42e56ccd2" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/84331 (owner: 10Nemo bis) [19:23:04] (03CR) 10Nemo bis: "Subsequent commit = Id45385f8dc3edaaef049c535ea6037c42e56ccd2" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/84333 (owner: 10Nemo bis) [19:28:31] #0 /usr/local/apache/common-local/php-1.22wmf16/languages/Language.php(200): Language::newFromCode('') [19:29:12] hmpf [19:29:33] so it must be something passing {{int:lang}} from a uselang for which it doesn't exist [19:30:14] on what wiki is it happening? though LangSwitch spread everywhere anyway [19:31:39] <^d> A-ha! [19:31:46] <^d> I think I might have almost fixed this double parsing bug [19:34:12] ^d: great! [19:34:40] ^d: I just submitted the change to turn on cirrus for itwiktionary [19:35:21] 2013-09-16 15:07:16 mw1185 enwiki: [3fe078ba] /wiki/Special:Book Exception from line 1216 of /usr/local/apache/common-local/php-1.22wmf16/includes/api/ApiBase.php: You have been blocked from editing [19:35:23] lol [19:39:44] csteipp: [19:39:45] 2013-09-16 15:19:02 mw1078 loginwiki: [fa16818f] /wiki/Special:CentralLogin/start?token=3d0d50579ff38a96e9f7d6ce9cd0b87a Exception from line 61 of /usr/local/apache/common-local/php-1.22wmf17/extensions/CentralAuth/specials/SpecialCentralLogin.php: Global user 'Soledadpaz' does not exist. [19:40:23] 2013-09-16 18:09:21 mw1215 ruwiki: [f074231b] /wiki/Special:CentralLogin/complete?token=redacted Exception from line 186 of /usr/local/apache/common-local/php-1.22wmf16/extensions/CentralAuth/specials/SpecialCentralLogin.php: The user account logged into does not exist. [19:40:24] Do we care? [19:40:56] urk? [19:43:40] Reedy: could that be a lockhid accounted? [19:44:00] *account [19:45:08] ah no it isn't [19:46:31] (03PS2) 10Rahul21: Making all handlers return $.Promise objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 [19:46:37] (03CR) 10Parent5446: [C: 031] "Ah I see. The bug was not linked here so I didn't know." [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/84331 (owner: 10Nemo bis) [19:46:43] CentralAuth doesn't know about it but GlobalUsers does, sigh [19:47:15] (03CR) 10Parent5446: [C: 031] Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [19:55:23] (03PS1) 10Chad: Improve reindexing speed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84413 [19:55:25] (03CR) 10Parent5446: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [19:55:36] <^d> manybubbles: ^ 84413 :) [19:57:43] (03PS2) 10Chad: Improve reindexing speed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84413 [19:58:20] (03CR) 10Manybubbles: [C: 031] Improve reindexing speed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84413 (owner: 10Chad) [20:02:16] <^d> manybubbles: Feel free to +2 if you think it'll work :) [20:03:04] ^d: so long as it works on your machine I'm happy to +2 [20:03:15] <^d> We'll test on labs [20:03:20] (03CR) 10Manybubbles: [C: 032] Improve reindexing speed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84413 (owner: 10Chad) [20:03:22] (03Merged) 10jenkins-bot: Improve reindexing speed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84413 (owner: 10Chad) [20:03:50] now it'll be on beta in a few [20:06:42] (03CR) 10Bartosz Dziewoński: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [20:07:07] (03CR) 10Parent5446: [C: 032] Minor bugfix to IP::prettifyIP. [core] - 10https://gerrit.wikimedia.org/r/84002 (owner: 10Cscott) [20:07:10] (03PS4) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [20:15:55] (03Merged) 10jenkins-bot: Minor bugfix to IP::prettifyIP. [core] - 10https://gerrit.wikimedia.org/r/84002 (owner: 10Cscott) [20:18:56] (03CR) 10Divec: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [20:21:29] (03PS1) 10Chad: Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84417 [20:22:06] (03CR) 10Chad: [C: 032 V: 032] Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84417 (owner: 10Chad) [20:25:33] ' [20:25:35] (03CR) 10EBernhardson (WMF): [V: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/84188 (owner: 10Spage) [20:25:44] ' [20:28:07] (03PS1) 10Chad: Need rev id not page id [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84418 [20:30:10] Krinkle|detached: Have you / are you / do you want to write a test utility for JS code conventions? [20:30:18] (03CR) 10Manybubbles: [C: 032] Need rev id not page id [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84418 (owner: 10Chad) [20:30:21] (03Merged) 10jenkins-bot: Need rev id not page id [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84418 (owner: 10Chad) [20:31:35] (03PS1) 10Chad: Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84419 [20:35:13] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Boilerplate code to allow adding editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 (owner: 10Matthias Mullie) [20:45:07] brion: LESS? :) [20:45:32] MOAR CSS [20:47:31] Oh, carp, YuviPanda, did someone get to that UW bug? [20:53:56] marktraceur: which one? [20:57:25] (03CR) 10Chad: [C: 032] Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84419 (owner: 10Chad) [20:58:14] (03PS1) 10Manybubbles: Easier index maintenance. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84424 [20:59:39] (03CR) 10Manybubbles: "The now describes all kinds of ways in which we can run upgrades and I added some logic to make them easier. No more figuring out what id" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84424 (owner: 10Manybubbles) [21:00:13] (03Merged) 10jenkins-bot: Cirrus to master [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84419 (owner: 10Chad) [21:00:13] The bug with eventlogging [21:00:18] Or rather, without eventlogging [21:04:01] marktraceur: no, did not. [21:06:12] Crap [21:06:15] I should do that [21:06:22] possibly, yeah [21:06:49] But...rrg, code review [21:06:53] * marktraceur explodes [21:07:24] (03PS1) 10Physikerwelt: Adding gittattributes file [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84426 [21:08:13] (03CR) 10Physikerwelt: [C: 032 V: 032] Adding gittattributes file [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84426 (owner: 10Physikerwelt) [21:10:51] (03PS1) 10Cscott: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/84428 [21:13:50] (03PS2) 10Manybubbles: Easier index maintenance. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/84424 [21:13:54] (03CR) 10MarkTraceur: [C: 04-1] "(19 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [21:14:18] (03PS1) 10Physikerwelt: Fix: If a wrong root element is returned a misleading Debug message was returned [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84429 [21:15:10] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix: If a wrong root element is returned a misleading Debug message was returned [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/84429 (owner: 10Physikerwelt) [21:19:06] (03PS1) 10MarkTraceur: Fix EventLogging module loads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84430 [21:19:11] AaronSchulz: ^^ [21:20:59] hey YuviPanda, let me know when you can do url->port remapping and i can move the websocket server to pinklake [21:21:07] cscott: sure! [21:21:09] not up yet [21:21:17] but I've the concepts done in 'my head' [21:22:59] (03PS1) 10Ori.livneh: Box Virtualbox-specific configs in 'virtualbox' module [vagrant] - 10https://gerrit.wikimedia.org/r/84431 [21:25:19] Or, you know, YuviPanda could review my fix for the warnings in prod. [21:25:29] marktraceur: they're in 'prod'? [21:25:50] marktraceur: you mean master? [21:27:00] I thought they got deployed somewhere and that's why we were worried [21:28:25] (03PS1) 10Reedy: Add .gitignore and .gitreview [openzim] - 10https://gerrit.wikimedia.org/r/84432 [21:29:17] Oh, maybe AaronSchulz just had a local issue. [21:29:19] Fine then [21:30:10] marktraceur: :) [21:30:23] marktraceur: also, it wouldn't be warning in prod because everywhere we have UW we also have EL [21:30:29] Right [21:30:32] Hence, confusion. [21:30:46] i'm reviewing it anyway [21:32:04] <3 [21:32:09] It's practically trivial [21:33:31] marktraceur: true [21:34:01] (03CR) 10Yuvipanda: [C: 032] Fix EventLogging module loads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84430 (owner: 10MarkTraceur) [21:34:05] (03Merged) 10jenkins-bot: Fix EventLogging module loads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84430 (owner: 10MarkTraceur) [21:34:34] Huzzahhhh [21:34:40] Has the next WMF branched? [21:37:38] (03PS3) 10Rahul21: Making all handlers return $.Promise objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 [21:38:49] Rahul21: Function.prototype.bind() doesn't work in early IEs, and you've not solved...most of the problems [21:40:27] marktraceur: in the first level of scoping I have used "handler" [21:40:59] Yeah, which is wrong [21:42:33] heh, weirdass bug [21:42:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=54187 [21:44:27] You found an assbug? [21:46:38] marktraceur: sortof [21:46:45] i set a user configurable variable sarting with $wg in the LocalSettings.php an in my extensions setup file, how can i use that var in a hook for ex.? [21:46:47] YuviPanda: I commented [21:46:57] legoktm: does it work yet? [21:47:05] does what work yet? [21:47:34] <^d> marktraceur: You need to go to the doctor for those kind of bugs. [21:47:40] legoktm: mosh? [21:47:47] YuviPanda: Oh, let me try it! [21:47:51] yeah [21:47:52] :D [21:48:08] ori-l: /msg chanserv clear #wikimedia-e3 users [21:48:51] Remaining text will be the reason. [21:48:54] You're welcome. :) [21:49:14] bash: mosh-server: command not found [21:49:14] Connection to bastion.wmflabs.org closed. [21:49:14] /usr/local/bin/mosh: Did not find mosh server startup message. [21:49:18] YuviPanda: :( [21:49:23] hurr durr [21:49:27] maybe it wasn't run yet [21:53:47] (03PS6) 10Reedy: Follow-up I49b7d8a - Add api module for common metadata [core] - 10https://gerrit.wikimedia.org/r/78815 (owner: 10Brian Wolff) [21:56:56] (03PS1) 10saper: bug 54179: Fix exception on collection save [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 [21:58:44] (03CR) 10saper: [C: 031] "Wish I could somehow just refer to EditPage::attemptSave() instead." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 (owner: 10saper) [21:59:59] (03CR) 10Subramanya Sastry: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/84428 (owner: 10Cscott) [22:00:26] yuri_k: see legoktm's response on the bug [22:00:39] 2005 is a long time ago :P [22:03:09] legoktm: i got a patch committed to fix a bug from 2004. [22:03:09] * cscott is still psyched [22:03:15] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/84428 (owner: 10Cscott) [22:03:17] :D [22:03:45] (03PS2) 10saper: bug 54179: Fix exception on collection save [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 [22:07:37] (03CR) 10Bartosz Dziewoński: "(2 comments)" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/84435 (owner: 10saper) [22:12:51] (03PS1) 10Reedy: Minor additions to function paramter type documentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84445 [22:12:51] (03PS1) 10Reedy: Remove $complete variable and conditional. Code will always be executed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84446 [22:12:55] marktraceur: you should add the EL check for the next patch too [22:13:06] YuviPanda: I'll do that...tonight prolly [22:13:13] ok ok [22:13:14] Ta, Reedy [22:13:18] Oh, he not here. [22:15:16] (03CR) 10MarkTraceur: [C: 032] Minor additions to function paramter type documentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84445 (owner: 10Reedy) [22:15:47] (03CR) 10MarkTraceur: [C: 032] Remove $complete variable and conditional. Code will always be executed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84446 (owner: 10Reedy) [22:15:54] <3 [22:15:56] (03Merged) 10jenkins-bot: Minor additions to function paramter type documentation [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84445 (owner: 10Reedy) [22:16:42] (03Merged) 10jenkins-bot: Remove $complete variable and conditional. Code will always be executed [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84446 (owner: 10Reedy) [22:29:03] (03CR) 10CSteipp: [C: 032] Made grants management page available everywhere [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84366 (owner: 10Aaron Schulz) [22:29:09] (03Merged) 10jenkins-bot: Made grants management page available everywhere [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/84366 (owner: 10Aaron Schulz) [22:30:01] (03CR) 10MaxSem: [C: 04-2] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:36:53] (03PS1) 10Reedy: Use database column aliasing code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84449 [22:38:35] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 (owner: 10Bsitu) [22:41:43] (03PS3) 10Reedy: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 (owner: 10Brian Wolff) [22:41:51] (03PS4) 10Reedy: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 (owner: 10Brian Wolff) [22:42:01] (03CR) 10Reedy: [C: 032] Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 (owner: 10Brian Wolff) [22:42:06] (03PS3) 10Reedy: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 (owner: 10Brian Wolff) [22:42:14] (03PS4) 10Reedy: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 (owner: 10Brian Wolff) [22:42:39] (03CR) 10Reedy: [C: 032] Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 (owner: 10Brian Wolff) [22:42:44] (03PS1) 10MarkTraceur: Fix portlet link [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84451 [22:45:56] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:47:56] (03Merged) 10jenkins-bot: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 (owner: 10Brian Wolff) [22:49:16] (03PS10) 10Reedy: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff) [22:51:38] (03PS1) 10Yurik: Updating Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84455 [22:53:02] (03PS1) 10Yurik: Updating Zero ext [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84456 [22:55:01] (03Merged) 10jenkins-bot: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 (owner: 10Brian Wolff) [22:58:03] (03CR) 10Yurik: [C: 032 V: 032] Updating Zero ext [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84456 (owner: 10Yurik) [23:01:42] Where the hell has the bug for RequestContext::getLanguage gone? [23:02:28] (03CR) 10Yurik: [C: 032 V: 032] Updating Zero ext [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84455 (owner: 10Yurik) [23:05:23] (03PS4) 10Rahul21: Making all handlers return $.Promise objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84344 [23:06:49] Rahul21: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind [23:07:04] Nemo_bis: if you are around we're converting itwiktionary now. I don't speak italian but it _seems_ better. [23:08:00] Nemo_bis: Cirrus is still a secondary [23:08:12] <^d> Idle for 2h, he's probably gone for the night :) [23:08:23] <^d> If things look good, we can swap it to primary tomorrow. [23:08:25] marktraceur: yes, will look at that, I hope the new patchset has no probs [23:08:39] NO SLEEP ALLOWED. [23:08:50] <^d> Hi Elsie :) [23:09:09] Elsie: 'til Brooklyn? [23:09:15] Hi ^d. [23:09:18] marktraceur: EVER. [23:09:42] Where are my Beastie Boys songs [23:09:46] This is a travemesty [23:09:53] To the cloud! [23:11:11] Good plan [23:11:45] YuviPanda: /j #mediawiki-parsoid ? [23:12:47] (03CR) 10MarkTraceur: [C: 032] Use database column aliasing code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84449 (owner: 10Reedy) [23:13:14] (03Merged) 10jenkins-bot: Use database column aliasing code [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84449 (owner: 10Reedy) [23:24:10] marktraceur: night :) [23:25:07] Good night! [23:28:57] marktraceur: What's the all-beta.png supposed to be? [23:29:59] (03PS1) 10Mattflaschen: Have GuidedTour depend on EventLogging [vagrant] - 10https://gerrit.wikimedia.org/r/84462 [23:31:11] (03CR) 10Ori.livneh: [C: 032] Have GuidedTour depend on EventLogging [vagrant] - 10https://gerrit.wikimedia.org/r/84462 (owner: 10Mattflaschen) [23:31:24] Reedy: It's a logo that represents the feature - it's going to be stripped out in this next patch, actually, so you could probably ignore it [23:31:27] (03Merged) 10jenkins-bot: Have GuidedTour depend on EventLogging [vagrant] - 10https://gerrit.wikimedia.org/r/84462 (owner: 10Mattflaschen) [23:31:46] Other features will have different ones - VE has a pretty nice one, for example [23:31:52] I was looking at it trying to work it out [23:32:04] https://gerrit.wikimedia.org/r/#/c/78795/7/logo-experimental.png [23:32:52] The auto-enroll preference is going to become a new-style checkbox in the next hour or so [23:38:08] marktraceur: [23:38:09] Using index condition; Using where; Using temporary; Using filesort [23:38:10] :( [23:39:46] * Reedy looks for up_property value [23:40:34] Reedy: What's up? [23:40:36] csteipp: having to set setSquidMaxage() sounds right [23:40:47] SELECT COUNT(up_property) AS number, up_property AS feature FROM user_properties WHERE up_value = '1' AND up_property = '' GROUP BY up_property; [23:40:53] with explain gives all of the usings [23:41:12] granted, up_property = '' which is somewhat useless [23:41:27] Hm, yeah, what's that doing in there? [23:41:54] I just used that as a value for testing on enwiki [23:41:56] 'beta-feature-auto-enroll' [23:41:58] Ah. [23:42:43] Of course, SELECT COUNT(up_property) AS number, up_property AS feature FROM user_properties WHERE up_property = 'beta-feature-auto-enroll'AND up_value = '1' GROUP BY up_property; is no better [23:42:50] TRue [23:43:19] Reedy: This is what I warned you about, no? But I'm not sure I can make it particularly better, unless you have an obvious idea that I missed [23:43:58] that's why i was poking around [23:44:09] let me try it on a pmtpa slave [23:44:09] :D [23:44:12] Fun [23:44:40] Reedy: I haven't implemented the increment/decrement bits yet, which might be faster, but I still wanted to have the periodic updates in there in case they got out of sync [23:44:56] It could at least bump up my confidence in the numbers so I can increase the cache length [23:46:51] mysql:wikiadmin@db60 [enwiki]> SELECT COUNT(up_property) AS number, up_property AS feature FROM user_properties WHERE up_property = 'beta-feature-auto-enroll'AND up_value = '1' GROUP BY up_property; [23:46:51] Empty set (0.03 sec) [23:46:54] that's helpful :D [23:47:04] I don't see a space between ' and "AND". [23:47:10] gj Elsie [23:47:13] AND? [23:47:24] mysql can work without spaces [23:47:27] it's pretty clever [23:47:43] That's not the word I would use to describe MySQL's query parser. [23:49:07] marktraceur: I guess it can work out from the up_property index that there's no rows and hence nothing to do [23:49:22] Integers break, but strings are fine next to "AND". [23:49:24] All right. [23:49:49] * Reedy uses a value that has rows [23:51:03] Reedy: I could also ax the feature for now, stick the job registration behind a config variable, if you wind up being too uncomfortable with it [23:51:22] But I think design really wanted that personal, "oh my goodness other people are using this" feel [23:52:07] Other options: Moar caching, updating separate counts in separate jobs [23:52:11] 1 row in set (2 min 25.34 sec) [23:52:36] yeah, when the mysql server has done the query it can re do it (even with a different value) in under 2s [23:53:21] Well, and 2 minutes isn't so bad, given it's a job and not running in a page load (assuming we don't run jobs in page-load context on the cluster) [23:53:30] nope, we don't [23:53:35] not sure about beta, but whatever [23:53:37] Yeah that'd be awful [23:54:33] (03CR) 10BryanDavis: [C: 031] "I'd love to +2 this but I probably shouldn't since I did the work for Patch Set 9." [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff) [23:54:33] The other way would be to do it as a maintenance script in a cronjob [23:54:51] Reedy: Every time I say that, three people yell "Gods not another maintenance script" :P [23:55:02] And that's *basically* what it is now [23:55:05] You added a new preference and preference tab [23:55:12] Hope Chad doesn't notice :D [23:55:18] Except I'm just hooking into the existing job queue [23:55:21] Ssshhhhh [23:55:49] Reedy: I have no opinions on this, I'm merely a hammer [23:56:28] I wonder what the chances of a race condition and 2 (or more) jobs getting into the queue [23:56:37] It's not destructive or anything [23:56:53] Reedy: There will never be 2 of this type of job in the queue [23:57:00] The registration checks [23:57:18] Or...oh, I see what you mean [23:57:21] 2 different apaches hitting the same code at the same time... [23:57:29] Seems somewhat unlikely, but possible [23:57:45] Possible, yeah. Maybe kill the job if it's run in the last 30 minutes? [23:58:02] How to do that, I haven't figured yet. [23:59:04] Hmm [23:59:14] Don't some of the other job types have de-duplication?