[00:45:02] <grrrit-wm>	 (03PS1) 10BryanDavis: Documentation: fix apt-get install instructions. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84210 
[01:11:00] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Cool, thanks!" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84210 (owner: 10BryanDavis)
[01:11:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Documentation: fix apt-get install instructions. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84210 (owner: 10BryanDavis)
[02:17:55] <grrrit-wm>	 (03PS1) 10Santhosh: Format the stats number [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84211 
[02:33:38] <grrrit-wm>	 (03Abandoned) 10Santhosh: Format the stats number [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/84211 (owner: 10Santhosh)
[02:36:23] <grrrit-wm>	 (03CR) 10TTO: "WTF? This doesn't need to be rebased..." [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO)
[02:36:27] <grrrit-wm>	 (03PS2) 10TTO: Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 
[02:49:36] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Delete the ext.vector.expandableSearch module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/84195 (owner: 10Bartosz Dziewoński)
[02:49:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Delete the ext.vector.expandableSearch module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/84195 (owner: 10Bartosz Dziewoński)
[02:50:37] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Delete the ext.vector.sectionEditLinks module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/84196 (owner: 10Bartosz Dziewoński)
[02:50:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Delete the ext.vector.sectionEditLinks module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/84196 (owner: 10Bartosz Dziewoński)
[04:50:29] <grrrit-wm>	 (03CR) 10Jdlrobson: "\o/ :D" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/84195 (owner: 10Bartosz Dziewoński)
[05:05:34] <marktraceur>	 Romaine: I suppose a "welcome back" is in order :)
[06:27:47] <grrrit-wm>	 (03PS1) 10Ara: Change namespageNames and namespaceAliases in Korean [core] - 10https://gerrit.wikimedia.org/r/84212 
[06:48:04] <marktraceur>	 YuviPanda: Am I crazy or are tutorial-continue and upload-load the same bloody thing? Should I just use "load" and not "continue"?
[06:48:15] <YuviPanda>	 marktraceur: hmm?
[06:48:17] <YuviPanda>	 marktraceur: oh, hmm
[06:48:18] <YuviPanda>	 yes
[06:48:21] <marktraceur>	 Heh.
[06:48:22] <marktraceur>	 Great.
[06:48:24] <YuviPanda>	 marktraceur: as in
[06:48:27] <YuviPanda>	 marktraceur: not use the same thing
[06:48:29] <YuviPanda>	 marktraceur: i meant no
[06:48:31] <YuviPanda>	 when i said yes
[06:48:37] <YuviPanda>	 marktraceur: because they go into different funnels
[06:48:37] <YuviPanda>	 so
[06:49:03] <quiddity>	 YuviPanda, http://www.gocomics.com/calvinandhobbes/1988/06/02
[06:49:33] <marktraceur>	 Um wat
[06:49:48] <marktraceur>	 YuviPanda: So I'd make two requests to represent the same thing
[06:50:11] <YuviPanda>	 marktraceur: this is a drawback of the 'one funnel for every page' model
[06:50:20] <marktraceur>	 Ah.
[06:50:35] <marktraceur>	 YuviPanda: There's no way to cross the funnels easily?
[06:50:46] <YuviPanda>	 marktraceur: there is but I wouldn't call them 'easy'
[06:50:51] <marktraceur>	 Heh.
[06:50:57] <YuviPanda>	 quiddity: :D
[06:51:36] * marktraceur  is a fan

[06:53:52] <marktraceur>	 Byeeee
[06:56:03] <marktraceur>	 YuviPanda: Can I poke you and ask whether an upload page event has fired at some point?
[06:56:10] <YuviPanda>	 marktraceur: indeeeed
[06:56:12] * YuviPanda  ssh's

[06:56:15] <marktraceur>	 K
[06:56:22] <marktraceur>	 There should be...3-5 of them now
[06:56:26] <YuviPanda>	 looking
[06:56:35] <marktraceur>	 Load, choose, uploaded, continue. 4.
[06:56:55] <YuviPanda>	 marktraceur: name of schema?
[06:58:40] <marktraceur>	 https://meta.wikimedia.org/wiki/Schema:UploadWizardUploadActions
[06:59:06] <marktraceur>	 Hm
[06:59:19] <marktraceur>	 Won't work, sorry, stupid bug. Sec.
[07:06:27] <marktraceur>	 YuviPanda: OK now it should have worked.
[07:07:00] <YuviPanda>	 marktraceur: yup, i has an event
[07:07:02] <marktraceur>	 Cool
[07:07:05] <marktraceur>	 Load, right?
[07:07:12] <YuviPanda>	 marktraceur: yeah
[07:07:14] <marktraceur>	 Cool.
[07:07:17] <YuviPanda>	 marktraceur: also you're en-gb?!
[07:07:23] <marktraceur>	 Hm, type isn't working...aw, it's filetye
[07:07:25] <marktraceur>	 Yeah
[07:08:26] <marktraceur>	 YuviPanda: Two more events, choose and failure
[07:08:38] <marktraceur>	 Or....hm
[07:08:42] <YuviPanda>	 marktraceur: I see a load and a fial
[07:08:43] <YuviPanda>	 *faikl
[07:08:49] <YuviPanda>	 marktraceur: with pi-error-duplicate
[07:08:50] <YuviPanda>	 *a
[07:09:00] <marktraceur>	 Ah.
[07:09:34] <marktraceur>	 My choose event didn't have an action
[07:09:36] <marktraceur>	 Stupid
[07:09:41] <marktraceur>	 ONE MORE TIME
[07:09:50] <marktraceur>	 OK, there
[07:10:08] <YuviPanda>	 marktraceur: yup, load, choose, uploaded
[07:10:20] <marktraceur>	 Cool
[07:10:29] <marktraceur>	 I'm happy with that
[07:10:32] <YuviPanda>	 marktraceur: sweet
[07:10:44] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 
[07:12:18] <quiddity>	 marktraceur, https://www.youtube.com/watch?v=FGBhQbmPwH8 (daft punk, one more time)
[07:20:14] <grrrit-wm>	 (03PS1) 10Rtdwivedi: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 
[07:20:16] <marktraceur>	 quiddity: I love that you got that
[07:20:30] <marktraceur>	 You just got me feelin' so free, I gotta celebraaate
[07:20:58] <quiddity>	 great movie. if i wasn't watching game review videos, i'd fire it up
[07:21:46] <grrrit-wm>	 (03PS3) 10BryanDavis: Guard against non-object returns from File::getHander() [core] - 10https://gerrit.wikimedia.org/r/83010 
[07:22:51] <grrrit-wm>	 (03PS4) 10BryanDavis: Guard against non-object returns from File::getHander() [core] - 10https://gerrit.wikimedia.org/r/83010 
[07:23:04] <marktraceur>	 quiddity: https://en.wikipedia.org/wiki/Interstella_5555:_The_5tory_of_the_5ecret_5tar_5ystem ?
[07:23:10] <quiddity>	 yup
[07:23:32] <marktraceur>	 Interesting.
[07:24:02] <marktraceur>	 In other news, I don't know how much capacity I have remaining for being awake
[07:24:11] <marktraceur>	 I should maybe let YuviPanda et al. finish the hack night
[07:24:22] * bd808  agrees that sleep should come soon

[07:24:26] <quiddity>	 turn the alarm on, and lock them in ;)
[07:24:31] <YuviPanda>	 i'm just getting started :(
[07:24:33] <YuviPanda>	 but that's ok
[07:27:16] <grrrit-wm>	 (03PS2) 10Ara: Change namespageNames and namespaceAliases in Korean [core] - 10https://gerrit.wikimedia.org/r/84212 
[07:29:46] <grrrit-wm>	 (03CR) 10Rtdwivedi: "Right now, it has text links instead of image links. Also, if the page does not exist, it doesn't point to a action=edit link. Putting the" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 (owner: 10Rtdwivedi)
[07:31:10] <grrrit-wm>	 (03CR) 10BryanDavis: "Ori pointed out that my first attempt had some really bad side effects. Now that I've actually read the code outside the narrow path I was" [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis)
[08:55:38] <grrrit-wm>	 (03PS1) 10Ladsgroup: Adding a space character between links in the special page in order to avoid bad rendereing in languages like Persian [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/84216 
[09:15:31] <Nemo_bis>	 https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_newbie_owner
[09:34:09] <grrrit-wm>	 (03PS2) 10Rtdwivedi: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 
[10:07:46] <grrrit-wm>	 (03PS3) 10Rtdwivedi: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 
[10:20:32] <grrrit-wm>	 (03Abandoned) 10Ori.livneh: Make DYKBox query performant for large categories [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/13937 (owner: 10Tychay)
[11:00:12] <ori-l>	 bd808|BUFFER: tip o' the hat.
[11:08:42] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "There's some stuff related to collapsiblenav (grep for it) which may or may not cause fatals if left alone. Preference options need moving" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:09:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Preference options need moving, i18n needs moving." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[11:09:14] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:09:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:09:50] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Bucket testing code needs removing as well." [core] - 10https://gerrit.wikimedia.org/r/83591 (owner: 10Jdlrobson)
[11:11:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Fixed merge conflict." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:12:07] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Move collapsibleNav to core [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:12:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Ah, no, that was a typo. :)" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[11:56:08] <grrrit-wm>	 (03CR) 10Frédéric Wang: [C: 04-1] "(6 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt)
[12:01:41] <grrrit-wm>	 (03CR) 10Frédéric Wang: "Alternatively, if you don't want to do the regexp check, you could just append set displaystyle="true" on the MathML element sent back by " [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt)
[12:43:31] <grrrit-wm>	 (03CR) 10Anomie: "> We already get rid of the local localStorage on login." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 (owner: 10Anomie)
[12:44:32] <grrrit-wm>	 (03PS2) 10Anomie: Re-do edge login when JS login check succeeds [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 
[14:11:49] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi)
[14:13:27] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(5 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 (owner: 10Rtdwivedi)
[16:27:39] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The wfEscapeWikiText bug was fixed in the meantime – why doesn't this just use that function?" [core] - 10https://gerrit.wikimedia.org/r/82356 (owner: 10PleaseStand)
[16:43:05] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: mediawiki.util: Detect Iceweasel for accesskeys [core] - 10https://gerrit.wikimedia.org/r/84225 
[17:04:06] <grrrit-wm>	 (03CR) 10Ori.livneh: "Should we remove it entirely instead?" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[17:21:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This fixed bug 44241." [core] - 10https://gerrit.wikimedia.org/r/75478 (owner: 10Krinkle)
[17:23:26] <grrrit-wm>	 (03CR) 10Physikerwelt: "..mh.. I'm not sure if we agree on what should be achieved." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt)
[17:42:02] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Drop unnecessary CSS selectors for a.external[href^="gopher://"] [core] - 10https://gerrit.wikimedia.org/r/84228 
[17:43:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "What, the module? It has quite a bunch of open bugs (https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=collapsiblenav), so killing it" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[17:50:15] <grrrit-wm>	 (03CR) 10Ori.livneh: "Is the functionality it implements popular / useful?" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[17:55:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "It's enabled by default on all Wikimedia wikis, so I'd risk a guess that, useful or not, it is for some reason wanted ;) It makes some ver" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/83590 (owner: 10Jdlrobson)
[17:58:45] <grrrit-wm>	 (03CR) 10PleaseStand: "We do want to let through some formatting (e.g. list formatting, headings, URL autolinking) but not all." [core] - 10https://gerrit.wikimedia.org/r/82356 (owner: 10PleaseStand)
[18:05:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Stupid PHP… wouldn't it be enough to provide an upper bound the assertion's length, like (?<!&[#a-zA-Z0-9]{1,999}), to make it parse and w" [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:07:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Okay. Add a test for this (InstallDocFormatterTest.php) and I'll merge :)" [core] - 10https://gerrit.wikimedia.org/r/82356 (owner: 10PleaseStand)
[18:11:26] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:12:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:13:22] <grrrit-wm>	 (03PS4) 10PleaseStand: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:15:05] <grrrit-wm>	 (03CR) 10PleaseStand: "Here's a way to hack around it. I haven't written any tests for it, though it seems to work in manual testing. Of course, it would be nice" [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:16:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Okay, it wouldn't be enough. Stupid PHP, this could easily be split into 999 separate lookbehind assertions that would be okay for it." [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:16:55] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent)
[18:30:49] <grrrit-wm>	 (03PS2) 10PleaseStand: Web installer: correctly show note for I4ecd0659 [core] - 10https://gerrit.wikimedia.org/r/82356 
[18:31:46] <grrrit-wm>	 (03PS3) 10PleaseStand: Web installer: correctly show note for I4ecd0659 [core] - 10https://gerrit.wikimedia.org/r/82356 
[18:32:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Untested, code looks good." [core] - 10https://gerrit.wikimedia.org/r/45506 (owner: 10Liangent)
[18:35:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/82356 (owner: 10PleaseStand)
[18:38:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Web installer: correctly show note for I4ecd0659 [core] - 10https://gerrit.wikimedia.org/r/82356 (owner: 10PleaseStand)
[18:50:16] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Whitelist Kevin Israel (PleaseStand) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 
[18:53:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Didn't scan the code rigorously, but it looks like a clear improvement. Adding our i18n guys to give their opinion." [core] - 10https://gerrit.wikimedia.org/r/80663 (owner: 10Parent5446)
[18:53:39] <grrrit-wm>	 (03CR) 10PleaseStand: "Previous change: I4f59e019d31d2b70782bff6933d9200e495e7ece" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński)
[18:55:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Well, if I'm the second person to actually go through the trouble to submit this change, then I guess that constitutes peer approval ;)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński)
[18:58:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "-1 per Matt." [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446)
[19:04:09] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Remove remaining calls to MWInit methods [core] - 10https://gerrit.wikimedia.org/r/78202 (owner: 10PleaseStand)
[19:15:31] <martinseener>	 how can i add a link in the top-right user menu from within my own extension?
[19:16:22] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Changes seem trivial, my wiki and update.php still work after applying this. Let's get it merged at last." [core] - 10https://gerrit.wikimedia.org/r/78202 (owner: 10PleaseStand)
[19:16:23] <marktraceur>	 !hook PersonalUrls
[19:16:23] <wm-bot>	 https://www.mediawiki.org/wiki/Manual:Hooks/PersonalUrls
[19:16:37] <marktraceur>	 martinseener: ^^
[19:16:48] <marktraceur>	 You could also use addPortletLinks from JavaScript
[19:17:17] <martinseener>	 ah cool, thx! searched for it for some hours now but searched for the wrong terms it seems :P
[19:17:36] <MatmaRex>	 hi marktraceur, bored? :D
[19:17:52] <marktraceur>	 ...
[19:17:54] <marktraceur>	 It's a tarp
[19:18:11] <marktraceur>	 MatmaRex: Not really, I still have to finish my scripts
[19:18:24] <marktraceur>	 But I could be convinced to review UP TO 40 lines of code
[19:18:48] <MatmaRex>	 i'm going to ask you to review a total of four, in two changes. added you as reviewer :)
[19:18:54] <MatmaRex>	 of six*, bah.
[19:19:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove remaining calls to MWInit methods [core] - 10https://gerrit.wikimedia.org/r/78202 (owner: 10PleaseStand)
[19:19:39] <marktraceur>	 Hm, K
[19:21:14] <MatmaRex>	 (added you as reviewer)
[19:21:28] <MatmaRex>	 or i can link them here, i guess
[19:21:32] <marktraceur>	 Better
[19:21:43] <marktraceur>	 Because my gerritmail is currently in a temporary void
[19:21:44] <MatmaRex>	 https://gerrit.wikimedia.org/r/84225 https://gerrit.wikimedia.org/r/84228
[19:22:28] <MatmaRex>	 there's also https://gerrit.wikimedia.org/r/#/c/82100/ , but that one is way more fascinating - something for these long autumn evenings ;)
[19:23:02] <marktraceur>	 Yeah, that'll be a RESOLVED LATER for me
[19:23:53] <grrrit-wm>	 (03CR) 10Frédéric Wang: "Examples:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt)
[19:29:41] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Again, per Mark." [core] - 10https://gerrit.wikimedia.org/r/78468 (owner: 10Brian Wolff)
[19:37:07] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Seems good to me. Ta, Bartosz." [core] - 10https://gerrit.wikimedia.org/r/84225 (owner: 10Bartosz Dziewoński)
[19:38:31] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Great catch, MatmaRex." [core] - 10https://gerrit.wikimedia.org/r/84228 (owner: 10Bartosz Dziewoński)
[19:38:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add optional message to define default description for Upload [core] - 10https://gerrit.wikimedia.org/r/78468 (owner: 10Brian Wolff)
[19:39:25] <marktraceur>	 Look at all these merges.
[19:39:31] <marktraceur>	 There must be five thousand merges here.
[19:41:01] <MatmaRex>	 thanks marktraceur
[19:41:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki.util: Detect Iceweasel for accesskeys [core] - 10https://gerrit.wikimedia.org/r/84225 (owner: 10Bartosz Dziewoński)
[19:41:33] <Nemo_bis>	 oh, "only" 688 unreviewed commits, we're below 700 at last
[19:42:06] <hoo>	 mh
[19:42:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Drop unnecessary CSS selectors for a.external[href^="gopher://"] [core] - 10https://gerrit.wikimedia.org/r/84228 (owner: 10Bartosz Dziewoński)
[19:43:21] <Nemo_bis>	 of which 488 from outside WMF
[19:44:05] <MatmaRex>	 hi hoo, wanna review some vaguely accessibility-related stuff?
[19:44:16] <MatmaRex>	 (and by vaguely, i mean very vaguely :D )
[19:44:55] <hoo>	 ewk
[19:45:09] <hoo>	 I can have a quick look, though...
[19:45:51] <MatmaRex>	 hoo: https://gerrit.wikimedia.org/r/#/c/82100/ is big and fascinating, something to comb through on a long evening with a cup of tea
[19:46:25] <marktraceur>	 MatmaRex: D'you want to close the bugs for those patches? I didn't.
[19:46:26] <MatmaRex>	 hoo: https://gerrit.wikimedia.org/r/#/c/48252/ and its dependency are rather small, but touching some seriously awful code
[19:46:33] <MatmaRex>	 marktraceur: i just did :)
[19:46:57] <marktraceur>	 Ah, good
[19:47:04] * marktraceur  goes to locate food

[19:47:22] <MatmaRex>	 i tend to be the only non-wmf person on bugzilla weekly reports' "Top 5 bug report closers" list ;)
[19:47:55] <Nemo_bis>	 egocentric
[19:47:58] <hoo>	 :P
[19:48:03] <hoo>	 I've been there once or twice :D
[19:48:21] <hoo>	 MatmaRex: Also you forgot WMDE staff :P
[19:48:32] <MatmaRex>	 hoo: ;)
[19:49:07] <Nemo_bis>	 MatmaRex: I'm in 12 of them exactly like you ;)
[19:49:07] <hoo>	 I guess I can take a quick look at the search suggestion thing and test it for regressions, but you wont see anything else than [-1,0,1]
[19:49:33] <MatmaRex>	 hoo: sure, thanks
[19:52:35] <grrrit-wm>	 (03PS4) 10Rtdwivedi: Moved the display of links to previous, next and index page to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/84214 
[19:59:18] <grrrit-wm>	 (03CR) 10Nemo bis: "Needs rebase. :(" [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy)
[20:02:33] <grrrit-wm>	 (03CR) 10Nemo bis: "That change is not progressing, are you going to look at this again?" [core] - 10https://gerrit.wikimedia.org/r/65300 (owner: 10JanZerebecki)
[20:08:50] <grrrit-wm>	 (03CR) 10Nemo bis: "(Also needs rebase.)" [core] - 10https://gerrit.wikimedia.org/r/23064 (owner: 10Karun)
[20:54:13] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Warn if page was edited while deletion was being confirmed [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy)
[20:56:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Resolved the conflict, it was caused by Ie33446a228dd6ed0114730935c1bf65667f5ce01 and was easy to solve. There was also some silly Qqq stu" [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy)
[20:58:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Rationale? The heading shouldn't be removed for accessibility reasons, IMO (but it should be wrapped in some element so that it can be hid" [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt)
[21:07:14] <Nemo_bis>	 thanks MatmaRex 
[21:08:01] <MatmaRex>	 my pleasure
[21:30:54] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] Whitelist Kevin Israel (PleaseStand) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/84230 (owner: 10Bartosz Dziewoński)
[21:42:03] <martinseener>	 can someone tell me how i can make the link of my extension in the specialpages overview bold?
[21:44:11] <MatmaRex>	 martinseener: probably, give me a second to check how it's done :D
[21:44:42] <martinseener>	 sorry for those dumb questions but its my first attempt to write an extension ;)
[21:44:51] <martinseener>	 but iam quite far ;)
[21:45:52] <martinseener>	 another one, how can i prevent the link to the specialpage of my extension being shown when the rights are not given (ie anonymous user)?
[21:46:25] <MatmaRex>	 martinseener: it seem like the bolding is for restricted special pages
[21:46:40] <martinseener>	 ah okay...then ill leave it as is
[21:46:40] <MatmaRex>	 hm, so actually both of your questions might have one answer :)
[21:46:48] <martinseener>	 ah okay
[21:47:17] <martinseener>	 so you mean i can just use the second parameter of the constructor to limit the visibility?
[21:47:29] <martinseener>	 would be too easy....^^ maybe should go to bed for today :P
[21:48:14] <MatmaRex>	 martinseener: actually, it seems that yes
[21:48:20] <martinseener>	 thanks alot :P
[21:48:21] <MatmaRex>	 @param string $restriction User right required, e.g. "block" or "delete"
[21:48:48] <MatmaRex>	 martinseener: or you define a method called isRestricted() on the special page class
[21:49:05] <martinseener>	 i call that the forest-tree-problem (iam german, here its called "Ich seh den Wald for lauter Bäumen nicht mehr") :P
[21:49:26] <martinseener>	 yeah no, i think the restriction in the constructor is just enough for me ;)
[21:49:29] <martinseener>	 thank you!
[21:50:00] <MatmaRex>	 martinseener: can't see the forest behind the trees, or something like that? i think english has that proverb
[21:50:11] <MatmaRex>	 (but i'm not a native speaker either)
[21:50:13] <martinseener>	 yeah thats it ;)
[21:50:32] <MatmaRex>	 :) happy to help
[21:50:36] <martinseener>	 will close my work for today (its almost midnight here) ;)
[21:50:52] <martinseener>	 need to work tomo at 8, so probab not the worst idea ;)
[22:12:39] <grrrit-wm>	 (03PS1) 10Ori.livneh: (WIP) CSS-driven collapsible nav in Vector [core] - 10https://gerrit.wikimedia.org/r/84290 
[22:13:44] <grrrit-wm>	 (03CR) 10Jdlrobson: "On mobile the heading needs to be marked up differently so the categories can be collapsible. Also more generic code is always a good thin" [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt)
[22:14:09] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-2] "This is the result of a five-minute hacking session and nowhere close to being reviewable, but I'm putting it up to have something to go b" [core] - 10https://gerrit.wikimedia.org/r/84290 (owner: 10Ori.livneh)
[22:25:17] <grrrit-wm>	 (03CR) 10Daniel Friesen: "Any idea how screen readers perceive this technique?" [core] - 10https://gerrit.wikimedia.org/r/84290 (owner: 10Ori.livneh)
[22:38:36] <martinseener>	 is there a way for my extension to add a link into the main navigation (any hook?)
[22:39:04] <martinseener>	 and without a separate subsection - directly the main sidebar navigation below "Main page" for ex.
[22:45:02] <MatmaRex>	 martinseener: i'm not sure. wiki admins can modify the navigation links by modifying [[mediawiki:sidebar]]
[22:45:03] <MatmaRex>	 !sidebar
[22:45:03] <wm-bot>	 To edit the navigation menu on the left, edit page [[MediaWiki:Sidebar]] on your wiki using its special syntax (see https://www.mediawiki.org/wiki/Manual:Interface/Sidebar for details). If you need more control, you can use the SkinBuildSidebar hook (https://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar).
[22:45:14] <MatmaRex>	 hey, turns out there is a way :P ^
[22:45:39] <martinseener>	 yeah found that hook but with that, i can only add new subtitles
[22:46:28] <martinseener>	 if you see the sample for that hook, adds a new sub-bar instead of "adding" it to the main "navigation" bar. but i want to add one to the "navgigation" bar....
[22:49:47] <martinseener>	 maybe i need to read the $bar['navigation'] array first - add my part - then overwrite it and done....or is there an easier way?
[22:50:33] <MatmaRex>	 hmm
[22:50:53] <MatmaRex>	 i think the items of $bar are either full HTML snippets like in the example, or associative arrays of stuff
[22:51:05] <MatmaRex>	 it sucks that it's not documented, eh
[22:51:07] <martinseener>	 i did a var dump of it....
[22:51:10] <MatmaRex>	 try var_dumping th-
[22:51:10] <MatmaRex>	 ah
[22:51:12] <MatmaRex>	 and?
[22:51:19] <martinseener>	 its an array^^
[22:51:46] <martinseener>	 so - just rearraging game^^
[22:51:53] <martinseener>	 a bit of array playing ;)
[22:52:00] <martinseener>	 but will do that later - need to sleep
[22:52:17] <MatmaRex>	 so do i. good night ;)
[22:52:24] <martinseener>	 gn8!
[22:54:18] <grrrit-wm>	 (03PS2) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 
[23:13:32] <grrrit-wm>	 (03CR) 10Platonides: "(38 comments)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/83619 (owner: 10Anubhavagarwal)