[00:03:19] ori-l: wouldn't you want to not cache failed compilations? [00:05:33] (03PS4) 10Krinkle: Add "category name" parameter [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/73719 (owner: 10Shirayuki) [00:06:38] (03CR) 10Krinkle: [C: 032] Add "category name" parameter [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/73719 (owner: 10Shirayuki) [00:06:55] (03CR) 10Krinkle: [V: 032] Add "category name" parameter [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/73719 (owner: 10Shirayuki) [00:11:14] (03PS2) 10Legoktm: Add a README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83063 [00:12:14] (03CR) 10Legoktm: [C: 032] Add a README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83063 (owner: 10Legoktm) [00:14:23] (03Merged) 10jenkins-bot: Add a README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83063 (owner: 10Legoktm) [00:21:55] (03PS5) 10Legoktm: Display stats on preview of how many pages we are posting to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 [00:21:56] (03PS1) 10Legoktm: Merge normalizeTargets and normalizeSpamList together [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83968 [00:23:18] (03CR) 10Legoktm: [C: 032] Merge normalizeTargets and normalizeSpamList together [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83968 (owner: 10Legoktm) [00:23:25] (03Merged) 10jenkins-bot: Merge normalizeTargets and normalizeSpamList together [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83968 (owner: 10Legoktm) [00:25:22] (03PS1) 10Reedy: Improve method parameter type hints [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83969 [00:27:52] (03PS1) 10Reedy: Update Elastica from 04d676299e to db7c85f5af [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83970 [00:33:55] (03PS6) 10Legoktm: Display stats on preview of how many pages we are posting to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 [00:34:34] (03CR) 10Legoktm: "PS5: Split commit into two" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [00:51:01] (03CR) 10MZMcBride: "I imagine you added a README.md for GitHub, but I wonder if, generally, MediaWiki extensions should only have a README that's equivalent t" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83063 (owner: 10Legoktm) [00:54:26] ewwww https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMassMessage.git/90df1f9c418d5481b1e9310ec7b93ebcecc4b621/README.md [00:54:57] whatever markdown parser gitblit uses, its messed up. [01:12:08] lol [01:20:07] ori-l: 5ish mins should be good enough [01:20:16] Other RL short-term caching times are also set at 5 mins [01:20:37] Just, you know, long enough that it doesn't blow up performance-wise, short enough it doesn't get stuck forever [01:33:18] RoanKattouw: yep, sounds good to me. [01:37:48] legoktm: Just noticed I got a mention in the README. Thanks. :-) [01:37:53] :) [01:42:17] (03CR) 10Anomie: [C: 031] "(1 comment)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [01:45:00] (03CR) 10Jackmcbarn: "(1 comment)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [01:48:45] (03PS1) 10Brian Wolff: Add way of including all stderr output when executing command [core] - 10https://gerrit.wikimedia.org/r/83974 [02:17:42] (03CR) 10Anomie: "(1 comment)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [02:40:58] (03PS6) 10Jackmcbarn: Allow changing name of template being previewed [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 [02:43:27] (03CR) 10Jackmcbarn: "(1 comment)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [02:43:29] "I prefer not to detail" ? [02:44:46] we should really hire some people who speak english [02:50:46] https://gerrit.wikimedia.org/r/#/c/30756/ [02:56:06] amazing how we can have about 20 CR comments with nobody realising that the word "detail" is not used in that sense [03:03:12] (03PS1) 10Tim Starling: Fix English gender-unknown message [core] - 10https://gerrit.wikimedia.org/r/83978 [03:08:07] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83974 (owner: 10Brian Wolff) [04:00:11] (03PS2) 10Brian Wolff: Add way of including all stderr output when executing command [core] - 10https://gerrit.wikimedia.org/r/83974 [04:00:37] (03CR) 10Brian Wolff: "PS2: per Reedy" [core] - 10https://gerrit.wikimedia.org/r/83974 (owner: 10Brian Wolff) [04:00:43] heh [04:00:50] (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83974 (owner: 10Brian Wolff) [04:02:57] (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [04:16:00] (03PS1) 10Reedy: Update TemplateData to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83983 [04:16:19] (03CR) 10Reedy: [C: 032 V: 032] Update TemplateData to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83983 (owner: 10Reedy) [04:18:41] !php [04:18:41] MediaWiki is written in PHP. PHP's website is http://php.net. For a full list of MediaWiki requirements, see http://www.mediawiki.org/wiki/Manual:Installation_requirements [04:19:22] James_F: gz issue solved :-] [04:19:37] James_F: (by Sam using a fallback that hopefully works) [04:27:25] hashar: Yeah. :-) [04:29:47] anomie: what are you working on ? :_D [04:30:04] hashar: Rewriting https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap [04:30:13] anomie: niiice :-]  Good luck ! [04:33:33] (03PS1) 10Mwjames: \SMW\FunctionHookRegistry register WebRequest object [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83985 [04:49:14] (03PS1) 10Santhosh: Remove convertPlural methods already served by CLDR plural system [core] - 10https://gerrit.wikimedia.org/r/83986 [05:44:59] (03CR) 10Tim Starling: [C: 04-1] "(9 comments)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J) [06:21:24] (03PS1) 10Rfaulk: add - method for scping. [sartoris] - 10https://gerrit.wikimedia.org/r/83987 [06:21:25] (03PS1) 10Rfaulk: add - ssh_command method. [sartoris] - 10https://gerrit.wikimedia.org/r/83988 [06:21:47] (03CR) 10Rfaulk: [C: 032 V: 032] add - method for scping. [sartoris] - 10https://gerrit.wikimedia.org/r/83987 (owner: 10Rfaulk) [06:21:59] (03CR) 10Rfaulk: [C: 032 V: 032] add - ssh_command method. [sartoris] - 10https://gerrit.wikimedia.org/r/83988 (owner: 10Rfaulk) [06:31:36] (03CR) 10Tim Starling: [C: 04-1] "The string processing style in convertByteClassToUnicodeClass() looks like a bit of a bodge to me. I think you could do a proper job of it" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [07:51:39] (03CR) 10Nemo bis: [C: 031] "We could bikeshed without limits but, if someone is confused, a small correction like this to use a more obvious verb is ok as incremental" [core] - 10https://gerrit.wikimedia.org/r/83978 (owner: 10Tim Starling) [07:52:54] (03CR) 10Nemo bis: "I meant the syntax of GENDER, of course. https://translatewiki.net/wiki/Gender#Magic_word" [core] - 10https://gerrit.wikimedia.org/r/83978 (owner: 10Tim Starling) [09:27:59] (03CR) 10Foxtrott: [C: 04-1] "(8 comments)" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [09:33:07] (03PS2) 10Bartosz Dziewoński: Fix English gender-unknown message [core] - 10https://gerrit.wikimedia.org/r/83978 (owner: 10Tim Starling) [09:33:24] (03CR) 10Bartosz Dziewoński: [C: 032] "Linked a relevant bug." [core] - 10https://gerrit.wikimedia.org/r/83978 (owner: 10Tim Starling) [09:34:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Parentheses stuff aside, this is a clear improvement. LGTM." [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [09:39:38] (03Merged) 10jenkins-bot: Fix English gender-unknown message [core] - 10https://gerrit.wikimedia.org/r/83978 (owner: 10Tim Starling) [09:41:10] (03Merged) 10jenkins-bot: Clarify "unknown gender" option is a non-answer and resort [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [09:42:21] MatmaRex: you see, by not changing the message I saved us a merge conflict ^^ [09:43:09] Nemo_bis: ;) [09:50:54] Nemo_bis: which bugs can we close now? [10:02:10] (03PS5) 10Tim Starling: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [10:03:27] (03CR) 10Tim Starling: "PS5: I mean something like this. Most of the new tests fail, but I think my changes are mostly beneficial." [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [10:05:16] (03CR) 10jenkins-bot: [V: 04-1] Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [10:09:11] MatmaRex: at least the one you mentioned from Tim's patch I think [10:09:31] the other can be decided by Jared [10:10:11] (03CR) 10Tim Starling: "In particular, I think it is incorrect to escape a (forward) slash, since that may also be done by the JSON encoder, leading to double-esc" [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [10:15:17] (03PS1) 10J: Add TitleMove hook [core] - 10https://gerrit.wikimedia.org/r/83995 [10:19:39] (03PS1) 10J: Use TitleMove hook to cleanup transcodes before move [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/83996 [10:20:46] (03PS2) 10J: Use TitleMove hook to cleanup transcodes before move [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/83996 [11:04:07] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [11:37:38] anyone happen to know if there's a copy of the LocalSettings.php file for commons available online? [11:39:26] dan-nl: https://git.wikimedia.org/tree/operations%2Fmediawiki-config [11:39:45] Raymond_: thanks! [11:40:14] dan-nl: look into the wmf-config directory for InitialiseSettings.php and CommonSettings.php [11:40:49] dan-nl: no LocalSettings.php for Commons alone huge config files for all projects [11:41:32] Raymond_: wow, i see ... [11:49:05] (03CR) 10J: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [11:51:21] Raymond_: do you happen to know which extension(s) provide the tags and [11:51:59] dan-nl: the translate extension [11:52:12] https://www.mediawiki.org/wiki/Help:Extension:Translate [11:52:32] for such questions you should check [[Special:Version]] :) [11:52:42] (hi Raymond_ ) [11:52:54] (hi Nemo_bis ) [11:57:04] Raymond_: Nemo_bis thanks … looks like it's an involved install. will see what i can do ... [12:00:05] Raymond_: Nemo_bis one issue i'm running into has to do with Lua and Template:TemplateBox/doc i keep getting a script error. Lua error in Module:Languages at line 297: attempt to index a nil value. but it doesn't really tell me what exactly is missing from the wiki … i thought it might be related to the Template:TemplateBox/i18n because the and tags are not being parsed but it seems like it might be something else … [12:00:05] ideas? [12:02:15] dan-nl: sorry, I am not very familar with Lua .... [12:02:42] Raymond_: no worries … thanks for answering [12:06:59] (03CR) 10Euvl: "Concerning the picture, i've painted it" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [12:10:45] dan-nl: that module was made by basile [12:10:50] (03CR) 10Peachey88: [C: 04-1] "Please look at our commit message guidelines." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [12:11:31] dan-nl: where exactly do you see the error? probably it's a wrong subpage name being fed to some function [12:20:34] Nemo_bis: anytime an invoke is done in this manner … {{#invoke:Languages|autolang |base=TemplateBox/i18n [12:21:36] why are you doing that? [12:21:55] aren't you using {{Translatable template}} from Meta? [12:21:58] Nemo_bis: so on the Template:TemplateBox page, Template:Documentation, which uses TemplateBox [12:22:45] Nemo_bis: i have a clean wiki … then i imported the templates directly from commons … did an export of Template:Artwork for example and imported it in [12:23:12] imported how? [12:23:17] you have to mark it for translation [12:23:26] Nemo_bis: i don't know what {{Translatable template}} from Meta? is [12:23:30] or how did you import all the translations [12:23:48] it's the template which invokes the module which chooses the subpage from which to transclude the template [12:23:59] (03CR) 10Peachey88: "You can probably already pull a cross icon from 'skins/common/images' (without checking but I would be surprised if there wasn't one in th" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 (owner: 10Euvl) [12:23:59] Nemo_bis: exported from here https://commons.wikimedia.org/wiki/Special:Export [12:24:06] I doubt that works [12:24:20] maybe it does but you need all the subpages [12:24:32] assuming you want a static copy of the translations [12:24:51] Nemo_bis: the import does seem to pull in all the necessary templates [12:25:00] I doubt it [12:25:03] Nemo_bis: not sure where i should get the translations from [12:25:07] subpages [12:26:10] Nemo_bis: you mean all of the /en subpages for example? [12:26:46] Nemo_bis: it used to work without issue, two months ago for example … no script errors [12:27:36] Nemo_bis: it looks like what happens is that Module:Languages gets stuck on line 297 [12:28:29] Nemo_bis: so you think that one of the Template: subpages hasn't been imported and that's the issue? i agree, just wish lua would tell me which Template page is missing [12:29:14] I still haven't see this error [12:29:23] if you could link it would be helpful [12:29:56] hmm, i'll have to set it up on an internet accessible server … hold on. [12:30:44] well, or paste it [12:30:47] describe it [12:31:12] if it's a blank page, for instance, you should file a bug [12:45:46] Nemo_bis: http://gwtoolset.wmflabs.org/wiki/Template:TemplateBox [13:07:16] Nemo_bis: does that link help explain anything? [13:14:01] dan-nl: sorry, got an email I have to answer immediately [13:14:09] Nemo_bis: np [13:54:27] dan-nl: you lack at least 2 things: 1) {{int:lang}} http://gwtoolset.wmflabs.org/wiki/Special:PrefixIndex/MediaWiki:Lang , 2) Template:TemplateBox/i18n language subpages [13:54:34] perfect timing [14:09:30] (03CR) 10Parent5446: [C: 031] Show whether tags are active on Special:Tags [core] - 10https://gerrit.wikimedia.org/r/81830 (owner: 10Bartosz Dziewoński) [14:17:27] Nemo_bis: thanks for the talk page msg … the network connection went out for a moment. the main idea is to get template data working in the site and using the artwork template to start so i've copied over the templates from commons hoping to mimic the environment [14:20:31] Nemo_bis: i added in the missing templates you mentioned and that did get me a bit further. the problem now is that the artwork template shows a json error so it looks like i'm missing the template data page fro artwork … have no idea of where it is … do you? [14:20:38] http://gwtoolset.wmflabs.org/wiki/Template:Artwork [14:21:15] Nemo_bis: the goal would be for the api to return the artwork template data structure http://gwtoolset.wmflabs.org/w/api.php?action=templatedata&titles=Template:Artwork [14:25:05] dan-nl: my knowledge of Commons templates is not so deep as to immediately remember what piece is missing in each part of the infrastructure.. [14:25:32] templatedata is always in /TemplateData dubpage [14:25:35] * subpage [14:26:07] you should probably move these questions to #wikimedia-commons ;) [14:26:45] Nemo_bis: cool, thanks [14:29:57] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83995 (owner: 10J) [14:38:01] (03CR) 10Petr Onderka: "It looks like this change isn't going to get approved, so I'm abandoning it. Though the relevant bug 34356 is still open, maybe someone wi" [core] - 10https://gerrit.wikimedia.org/r/5588 (owner: 10Petr Onderka) [14:38:21] (03Abandoned) 10Petr Onderka: Added missing query element to watchlistraw [core] - 10https://gerrit.wikimedia.org/r/5588 (owner: 10Petr Onderka) [15:04:15] (03CR) 10Cscott: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [15:06:02] (03PS4) 10Cscott: Make line breaks in
behave like
(bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 [15:06:37] (03CR) 10jenkins-bot: [V: 04-1] Make line breaks in
behave like
(bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [15:09:54] (03PS5) 10Cscott: Make line breaks in
behave like
(bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 [15:10:23] (03CR) 10Cscott: "Patch set 5 is just a rebase to fix the RELEASE-NOTES conflict." [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [15:20:05] (03PS1) 10Cscott: Minor bugfix to IP::prettifyIP. [core] - 10https://gerrit.wikimedia.org/r/84002 [15:33:46] (03PS1) 10Rillke: Add checkboxShiftClick to "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 [16:05:38] (03CR) 10Nikerabbit: [C: 04-1] "(10 comments)" [core] - 10https://gerrit.wikimedia.org/r/83986 (owner: 10Santhosh) [16:46:30] (03PS6) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [16:48:05] (03PS1) 10Jack Phoenix: UserStatus: made this actually work w/ MW 1.21. [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/84008 [16:49:20] (03CR) 10Jack Phoenix: [C: 032 V: 032] UserStatus: made this actually work w/ MW 1.21. [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/84008 (owner: 10Jack Phoenix) [16:53:22] (03PS1) 10Aude: Update Wikibase and DataValues [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84009 [16:54:05] (03PS1) 10Jack Phoenix: SportsTeams: made this work w/ MW 1.21. [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/84010 [16:54:16] (03CR) 10Jack Phoenix: [C: 032 V: 032] SportsTeams: made this work w/ MW 1.21. [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/84010 (owner: 10Jack Phoenix) [17:00:42] (03PS1) 10DMaggot: Implement additionalProperties => true according to [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/84011 [17:10:28] RoanKattouw_away: noting your away... Is VE alright to be branched? [17:14:15] Reedy: https://gerrit.wikimedia.org/r/#/c/84009/ :) [17:14:24] if you have any free time [17:14:40] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase and DataValues [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84009 (owner: 10Aude) [17:14:44] thanks! [17:19:37] (03CR) 10Brion VIBBER: "Hmm, another note: the description field is not marked with an asterisk, but if you don't fill it out you get a warning when you try to su" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 (owner: 10Yuvipanda) [17:21:01] (03CR) 10Brion VIBBER: [C: 032] "That's not new though, the missing * on the description was not there before either. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 (owner: 10Yuvipanda) [17:21:09] (03Merged) 10jenkins-bot: Set page title to parsed title of the Campaign [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83568 (owner: 10Yuvipanda) [17:21:10] (03Merged) 10jenkins-bot: Set red asterisk on field labels only if it is marked required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 (owner: 10Yuvipanda) [17:21:17] * Reedy branches wmf17 [17:23:12] branch day! [17:23:31] it's branch day [17:23:33] it's branch day [17:23:36] got branch on branch day [17:23:41] :) [17:24:24] i would be more excited if any of the changes i made this week were merged. :P [17:24:36] You broke something last week [17:24:41] No deploy for you [17:26:40] :( [17:26:47] it's hashar's fault [17:26:53] having jenkins on different php [17:26:58] it's not [17:27:04] no? D: [17:27:10] MatmaRex: jenkins is using the same version as the production cluster :-] [17:27:10] weren't there tests for this? [17:27:22] yup no test was triggering the gz* function hehe [17:27:22] hashar wrote you a test [17:27:35] woot. [17:27:40] the test I added is pretty lame, just meant to call the function which does not exist in PHP 5.3.x [17:28:04] it should be enhanced to actually verify that passing via gzencode / gzdecode yields back the original json [17:28:51] whoops. well, poop. sorry :D [17:32:44] i'd add a real test for this, but i don't even know how to make phpunit pick it up [17:33:00] actually, i could change hashar's one [17:33:32] MatmaRex: the unit tests under tests/ are registered with some hook (something like UnitTestFiles hook) [17:33:47] MatmaRex: you can run the extension tests using : php tests/phpunit.php extensions/NameOfExt [17:33:53] that should work [17:34:23] hashar: heh, do you actually believe i managed to install phpunit anywhere? i just use jenkins [17:34:39] i tried, believe me, i tried [17:36:39] Reedy: i'm imagining a version of the geico hump day ad, except with trees. [17:45:27] (03CR) 10Jdlrobson: [C: 032] Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [17:49:37] MatmaRex, or AaronSchulz , do you know if https://bugzilla.wikimedia.org/show_bug.cgi?id=52510 (Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled) is Resolved, or needs further work? [17:49:38] I just tried to explain the sequence of events in the bugzilla thread, to Atlasowa at https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#New_notification_.22gesichtet.22_needed_for_deWP.2C_plWP.2C_ruWP.2C_arWP_etc but it's not clear if Aaron's patch is all that is needed, to get "Your revision has been approved" Notifications, or if further work is needed. (By either you folk, or Echo devs, or other). Please update the bugticket, if [17:49:38] you know f'sure. :) [17:49:56] quiddity: not resolved yet [17:50:15] quiddity: all that was done is handling flaggedrevs-reverts in the same way as other reverts [17:50:58] MatmaRex, any suggestions for which devs I should poke/nag about this? [17:51:24] quiddity: i attempted to implement notifications for reviewing using flaggedrevs, but that attempt was rather half-hearted and incomplete [17:51:32] needs work by the FlaggedRevs devs IIRC [17:51:46] quiddity: AaronSchulz is the flaggedrevs dude in general, and bsitu is the echo dude in general [17:52:04] quiddity: but you should actually poke fflorin (echo project lead) to prioritize this [17:52:16] (Ffabrice Florin) [17:52:16] perfect, ty. Will do. [17:52:35] Fabrice* [17:52:58] I think rejection notifications were added and that part is resolved fixed [17:53:39] reedy@ubuntu64-web-esxi:~/git/mediawiki/core$ git submodule update --init extensions/Wikibase [17:53:39] fatal: reference is not a tree: cb1644d5e66586d3e9964de82abc370f50dd9b26 [17:53:39] Unable to checkout 'cb1644d5e66586d3e9964de82abc370f50dd9b26' in submodule path 'extensions/Wikibase' [17:53:39] :/ [17:53:57] wtf? [17:54:11] * aude see which one that is [17:54:50] approved notifications code is abandoned in gerrit as it doesn't account for some important cases [17:54:55] https://gerrit.wikimedia.org/r/79775 [17:56:36] Reedy: when did you make the branch? just now? [17:56:40] that commit is https://gerrit.wikimedia.org/r/#/c/83835/ [17:57:03] I'm getting that on my local checkout I use for updating wmf branches and extension [17:57:06] on wmf16 [17:57:11] huh [17:57:14] trying to update the changelogs [17:58:16] * aude made an error :/ [17:58:22] give me a sec [17:59:27] i cherry picked it but not pushed it [17:59:51] o_0 [17:59:52] haha [18:00:14] it is in the branch now [18:01:12] I guess I should fix/check production too [18:01:26] (03CR) 10Bartosz Dziewoński: [C: 032] Update extension description to include recent email blacklisting feature [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/78642 (owner: 10Nemo bis) [18:01:31] (03Merged) 10jenkins-bot: Update extension description to include recent email blacklisting feature [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/78642 (owner: 10Nemo bis) [18:01:35] sure [18:01:52] i know i didn't point the extensions to master [18:02:00] the commit was in my local branch [18:02:11] not sure what happens in that case [18:02:53] omg, brion doing commits in operations/puppet.git! [18:03:12] or rather abandoning them [18:03:23] Nemo_bis: he was abandoning his own [18:03:23] it's an old one i'm just killing it out :) [18:03:28] brion: heh [18:03:41] (03Abandoned) 10Brion VIBBER: Update ZeroRatedMobileAccess for i18n updates [core] (wmf/1.21wmf10) - 10https://gerrit.wikimedia.org/r/51806 (owner: 10Brion VIBBER) [18:04:01] Woah [18:04:02] https://www.mediawiki.org/wiki/MediaWiki_1.22/wmf17/Changelog [18:04:10] That's a small changelog [18:04:22] everyone on holiday [18:04:38] quick, git rm -r api/ [18:04:53] hah [18:05:38] (03PS2) 10Brion VIBBER: Switch SVGEdit to use the master copy from Google Code instead of a local copy. [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/43238 [18:06:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Eh I'll merge this myself then. :P" [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/43238 (owner: 10Brion VIBBER) [18:12:09] Reedy: i told you, no one is merging my patches :( [18:12:44] and i have some really fascinating stuff there [18:12:49] like this one-line change https://gerrit.wikimedia.org/r/#/c/82029/ [18:13:30] oe this simple UI fix swalling promised to get merged last week https://gerrit.wikimedia.org/r/#/c/80769/ [18:13:46] StevenW: ^ hmpf ;) [18:14:19] or this 13-line trivial improvement https://gerrit.wikimedia.org/r/#/c/81830/ [18:14:52] or this preferences cleanup that's waiting for a month now https://gerrit.wikimedia.org/r/78410 [18:15:22] or this i18n fix that's waiting for half a year https://gerrit.wikimedia.org/r/#/c/55496/ [18:16:03] or this cssjanus improvement that's waiting for i can't even tell how long, because it was reverted for arbitrary reasons and everybody is seemingly afraid to merge it back https://gerrit.wikimedia.org/r/#/c/52611/ [18:19:13] hmph. [18:21:21] i poked around the tangle of links that surrounds 52611 [18:21:46] krinkle seemed appeased by the fix and trevor explicitly stated he was OK with it [18:22:31] but i'm not sure about krinkle, and he opposed it strongly enough before that you probably want to make sure it's resolved as far as he's concerned [18:23:16] so if i were you, i would add a comment to https://bugzilla.wikimedia.org/show_bug.cgi?id=45677 summarizing where things stand right now [18:23:50] (bug fixed, trevor OK, krinkle possibly OK, arguments against, arguments for) [18:24:17] and do a 'speak now or forever hold your peace' thing [18:25:22] (it's not that these things haven't been said before; it's that they've been said in different places and at different times and so it's difficult to get a handle on things) [18:25:37] anyways, just my 2 cents. [18:28:05] ori-l: sorry, i was afk [18:28:34] i don't care about that patch enough to do any more appeasing, and it's hard to get krinkle to reply to anything anyway [18:28:55] (see e.g. https://bugzilla.wikimedia.org/show_bug.cgi?id=46956) [18:43:54] YuviPanda: Is the upload schema good-looking? [18:44:08] marktraceur: let me look at it again [18:44:12] marktraceur: have a link? [18:44:13] (he says, vainly attempting to get werk done) [18:44:22] marktraceur: i've gotten a patch done, and starting on another [18:44:22] so [18:44:26] https://meta.wikimedia.org/wiki/Schema:UploadWizardUploadActions [18:44:35] YuviPanda: I meant me :) [18:44:44] i know, i was just showing off :P [18:44:52] Sigh [18:45:30] marktraceur: Type of the file being acted upon (only for delete and complete, no others) [18:45:34] marktraceur: also for failure [18:47:20] Argh [18:47:58] And "complete" got renamed [18:48:02] Bloody details [18:48:34] :D [18:48:44] K, done [18:48:51] * marktraceur starts writing a patch maybe [19:03:09] (03PS2) 10Nemo bis: (bug #43509) Special:Whatlinkshere pagination broken [core] - 10https://gerrit.wikimedia.org/r/41386 (owner: 10Jarry1250) [19:03:34] YuviPanda: I'm doing this wrong [19:03:47] (03CR) 10jenkins-bot: [V: 04-1] Special:Whatlinkshere pagination broken [core] - 10https://gerrit.wikimedia.org/r/41386 (owner: 10Jarry1250) [19:03:53] I don't know what I need to do to make it right, but it's wrong [19:04:01] I should probably write a patch to fix the framework [19:04:09] (03PS4) 10Nemo bis: (bug 42246) allow hiding patrol entries from main Special:log [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [19:04:42] marktraceur: doing what wrong? [19:05:00] marktraceur: which framework? [19:05:39] The eventlogging thing in UW [19:05:45] The inheritance is painful [19:05:48] And it shouldn't be [19:05:51] marktraceur: TOLD YOU SO! [19:05:53] :P [19:06:02] No, I should be doing inheritance [19:06:07] But I'm not doing it correctly [19:06:10] i see [19:06:23] i don't think you should be, but let's see what your idea of doing it correctly is [19:06:30] Heh [19:06:36] I'm gonna do another one wrong first [19:06:40] Then write a patch to fix it all up [19:07:24] (03CR) 10Catrope: [C: 032] jquery.tablesorter: Support genitive month names [core] - 10https://gerrit.wikimedia.org/r/55496 (owner: 10Bartosz Dziewoński) [19:09:50] marktraceur: hurr durr :P [19:09:52] ok [19:12:30] RoanKattouw: wooooot. thanks. [19:13:25] (03Merged) 10jenkins-bot: jquery.tablesorter: Support genitive month names [core] - 10https://gerrit.wikimedia.org/r/55496 (owner: 10Bartosz Dziewoński) [19:13:55] (03CR) 10Catrope: [C: 032] SpecialPrefixindex: Try not to generate unclickable links [core] - 10https://gerrit.wikimedia.org/r/82029 (owner: 10Bartosz Dziewoński) [19:17:45] (03Merged) 10jenkins-bot: SpecialPrefixindex: Try not to generate unclickable links [core] - 10https://gerrit.wikimedia.org/r/82029 (owner: 10Bartosz Dziewoński) [19:19:24] (03CR) 10Catrope: [C: 032] Remove "Misc" tab from Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/78410 (owner: 10Bartosz Dziewoński) [19:22:17] (03Merged) 10jenkins-bot: Remove "Misc" tab from Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/78410 (owner: 10Bartosz Dziewoński) [19:24:57] <^d> Yo brion. Do you remember what the heck xdiff was used for? [19:25:10] xdiff… hmm [19:25:21] <^d> We don't even use it. [19:25:21] no clue [19:25:31] <^d> And the pecl project is abandoned afaict. [19:25:32] 53 usages [19:25:46] (03CR) 10Catrope: "Krinkle: Are you still oppposed to this? If not, or if you don't respond within a week, I'm just gonna merge this." [core] - 10https://gerrit.wikimedia.org/r/52611 (owner: 10Bartosz Dziewoński) [19:25:53] * Diff-based history compression [19:25:53] * Requires xdiff 1.5+ and zlib [19:25:56] <^d> Reedy: I mean MW has optional support for it. We don't have xdiff installed on cluster was what I meant. [19:26:05] Aha [19:26:11] Wondering if it's crap we should strip? [19:26:21] <^d> Sounds like a Tim project from ages ago :p [19:26:23] <^d> Yep. [19:28:31] MatmaRex: Re CSSJanus shadow flipping: I'm tired of that languishing forever, I think it's a good idea, so I'm giving people a week to object before I just go and merge it [19:28:51] RoanKattouw: yay, thanks [19:28:57] I'll ask Krinkle about his thoughts as well, will try and do that while he's still here in SF [19:31:05] https://gerrit.wikimedia.org/r/#/c/80769/ and the associated stack of changes is beyond me [19:31:22] IMO it's the design team's responsibility to get back to you on those [19:31:45] Steven said he'll get someone to look at them [19:31:49] OK cool [19:35:56] <^d> Reedy: xdiff has no support in hhvm, that's why I noticed. [19:36:34] being abandoned seems an even better reason to remove it [19:37:02] <^d> Indeed. [20:33:07] Elsie: did you get that list of reviewers counts? [20:36:08] Ah, we need an op https://gerrit.wikimedia.org/r/#/c/78944/ [20:47:14] (03PS1) 10Reedy: Update MoodBar to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84090 [20:47:56] (03CR) 10Reedy: [C: 032 V: 032] Update MoodBar to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84090 (owner: 10Reedy) [21:09:56] say if I want to set a wiki read-only except for user talk pages (and permit logins though), is there some easy way to do that? [21:10:21] !e Lockdown [21:10:21] https://www.mediawiki.org/wiki/Extension:Lockdown [21:10:35] a wmf wiki [21:10:36] i've heard this works [21:10:40] ah, actually, it's easier [21:10:45] !wg NamespaceProtection [21:10:45] https://www.mediawiki.org/wiki/Manual:$wgNamespaceProtection [21:12:44] huh, was !ask changed again, or does #-operations have a separate database? [21:12:46] !ask [21:12:46] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [21:13:07] okay. [21:13:42] well here I need to point to a right that no one has I guess, and then make sure all namespaces but user:talk have it [21:13:43] <^demon> I have a question. [21:13:44] pita [21:13:48] <^demon> !ask | ^demon [21:13:49] ^demon: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [21:13:55] <^demon> Thanks wm-bot! [21:13:55] Hey ^demon, you are welcome, but keep in mind I am just a stupid bot, it was actually ^demon who helped you :-) [21:13:58] I have an answer, and probably a wiseass one [21:14:22] <^demon> apergos: Any clue where data:// stream wrappers are implemented in PHP? I can't find them. [21:14:42] no, I'd have to grep -r just like you [21:15:32] can I make up user rights? [21:15:54] I mean, give an arbitrary string and then just not have any user groups have that right? [21:16:06] I guess it would be a group permission but whatever [21:16:28] yes [21:16:36] (i think.) [21:16:46] <^demon> apergos: Yes, you can. [21:16:57] I'll give that a try then, I want this to avoid turning into a big deal [21:16:58] thanks [21:17:31] <^demon> Ah, I think it's in ./main/streams/streams.c [21:18:22] <^demon> >2300 loc. yeah, that looks about right. [21:18:57] don't have a current copy of php src? must have wiped it last reorg of my disk [21:31:57] * @deprecated since 1.14 [21:31:57] */ [21:31:57] $wgProxyKey = false; [21:32:13] No brion.. [21:37:20] * ^demon sets ping trap for brion [21:38:29] I was just trying to work out how mwblocker.log was made [21:38:36] Used in $wgProxyList [21:38:49] But the file isn't checked into mediaiwki-config [21:39:09] marked as "private" [21:45:49] MatmaRex: I chatted with Timo and Trevor over lunch about the shadow flipping thing, I summarized their opinions here https://bugzilla.wikimedia.org/show_bug.cgi?id=45677#c31 [21:46:42] ^demon: putting candy in a bowl doesn't count as a ping trap [21:47:11] <^demon> It counts as a trap :) [21:55:35] RoanKattouw: thanks [21:55:52] ori-l: ping? [21:56:05] ori-l: can you dig gingle.wmflabs.org and tell me if you get back 2 IPs or 1? [21:57:38] gingle.wmflabs.org. 3301 IN A 208.80.153.190 [21:57:39] gingle.wmflabs.org. 3301 IN A 208.80.153.237 [21:58:12] grrr [21:58:14] thanks RoanKattouw [22:01:19] (03PS1) 10Mollywhite: Fix some bugs with the indentation patch. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/84093 [22:01:23] (03PS1) 10Catrope: Update VisualEditor to pick up c0650459dffda45e7c85cb9e4c57a62adee557a8 [core] (wmf/1.22wmf17) - 10https://gerrit.wikimedia.org/r/84094 [22:04:04] "dig gingle". read that aloud. [22:09:27] (03PS1) 10Catrope: Update VisualEditor to pick up 8bb72b2b91811dd53fe1cbe807d96f628a2824c6 [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/84097 [22:10:20] diggingle [22:10:22] ow [22:23:08] anybody know off the top of their head which is the faster strategy for hashing two string blobs -- concatenating two long strings and md5() the result, or md5()ing each separately? [22:26:52] ori-l: i guess concatenating likely involves copying the strings (or at least one)? although gods know how php does it [22:27:31] * MatmaRex is off. good night [22:49:15] (03PS8) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [22:57:00] (03PS1) 10Ejegg: wfMkdirParents: recover from mkdir race condition [core] - 10https://gerrit.wikimedia.org/r/84100 [23:07:59] (03PS1) 10Ori.livneh: Provide a dynamic global scope of LESS variables [core] - 10https://gerrit.wikimedia.org/r/84101 [23:15:49] (03CR) 10Ori.livneh: "PS6 gets rid of client-side compilation of LESS stylesheets and sets a five minute cache expiry for failed compilation attempts." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:21:40] (03CR) 10Tim Starling: [C: 032] Make line breaks in
behave like
(bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [23:24:34] (03Merged) 10jenkins-bot: Make line breaks in
behave like
(bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [23:43:46] (03PS2) 10Parent5446: wfMkdirParents: recover from mkdir race condition [core] - 10https://gerrit.wikimedia.org/r/84100 (owner: 10Ejegg) [23:45:54] (03CR) 10Parent5446: [C: 032] wfMkdirParents: recover from mkdir race condition [core] - 10https://gerrit.wikimedia.org/r/84100 (owner: 10Ejegg) [23:48:37] (03Merged) 10jenkins-bot: wfMkdirParents: recover from mkdir race condition [core] - 10https://gerrit.wikimedia.org/r/84100 (owner: 10Ejegg)