[00:52:15] (03CR) 10CSteipp: "This is working well in test. The only thing I would improve is adding javascript to get rid of the localStorage when we (re)login too. Bu" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 (owner: 10Anomie) [00:55:20] (03CR) 10Anomie: "We already get rid of the local localStorage on login. Checking the docs, it seems difficult to clear the localStorage on another domain; " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83655 (owner: 10Anomie) [01:03:43] (03CR) 10Anomie: "(3 comments)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [01:28:45] (03PS3) 10Jackmcbarn: Allow changing name of template being previewed [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 [01:32:24] (03CR) 10Jackmcbarn: "I switched to the method. I don't really like the idea of not outputting anything at all for it. The two long lines " [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [01:46:06] (03PS2) 10Physikerwelt: Displaystyle [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 [02:03:53] (03CR) 10Ricordisamoa: [C: 031] "useful" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 (owner: 10Bsitu) [02:56:43] (03CR) 10Ori.livneh: [C: 032] Put 'use strict' at top of outermost function in all files [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/80342 (owner: 10Mattflaschen) [02:56:48] (03Merged) 10jenkins-bot: Put 'use strict' at top of outermost function in all files [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/80342 (owner: 10Mattflaschen) [03:01:23] (03CR) 10Mwjames: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83608 (owner: 10Mwjames) [03:39:21] (03PS3) 10Mwjames: SMWHooks::onSpecialStatsAddExtra -> SMW\SpecialStatsAddExtra [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83608 [03:59:57] (03PS1) 10Ejegg: filebackend: FS needn't be so strict with names [core] - 10https://gerrit.wikimedia.org/r/83774 [04:30:51] (03PS1) 10Ori.livneh: Ensure MediaWiki has been cloned before cloning extensions [vagrant] - 10https://gerrit.wikimedia.org/r/83775 [04:32:41] (03CR) 10Ori.livneh: [C: 032] Ensure MediaWiki has been cloned before cloning extensions [vagrant] - 10https://gerrit.wikimedia.org/r/83775 (owner: 10Ori.livneh) [04:32:43] (03Merged) 10jenkins-bot: Ensure MediaWiki has been cloned before cloning extensions [vagrant] - 10https://gerrit.wikimedia.org/r/83775 (owner: 10Ori.livneh) [04:37:51] Hi ori-l. [04:38:04] hi Elsie [05:31:28] hi ori-l [05:32:48] hey [06:27:06] ori-l: in vagrant, is there an easy way to disable the Vector extension being on by default? [07:22:24] (03CR) 10TTO: "Any chance of some eyes on this?" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [07:35:17] (03PS19) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [07:35:50] (03CR) 10TTO: [C: 04-1] "The anacoluthon problem is still there, and is a bit off-putting." [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [07:46:56] (03CR) 10Mwjames: "This is one hell of a rework and probably 70% of the code is now reserved for tests." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 (owner: 10Mwjames) [08:26:01] (03CR) 10Frédéric Wang: [C: 04-1] "(2 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [08:29:05] legoktm: why do you want to disable it? [09:10:50] (03CR) 10jan: [C: 04-1] "(7 comments)" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/83628 (owner: 10Clancer) [09:33:19] (03CR) 10Frédéric Wang: "For LaTeXML, you've used the MathML "display" attribute, not the "displaystyle" attribute. I think that's what we want: only a parameter "" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [10:38:27] (03CR) 10Rillke: [C: 04-1] "(3 comments)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [11:47:00] (03CR) 10Rillke: "(1 comment)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [11:53:53] hello all [11:55:29] in the future, is possible to have a real time wiki? [11:56:57] would be possible [12:01:02] hello prageck [12:05:14] cortexA9: Hi [12:10:44] (03PS2) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [12:39:13] anyone online that happens to know why Template:Institution and Template:Artwork might give the following error message? [12:39:15] Lua error in Module:Languages at line 297: attempt to index a nil value. [13:54:02] (03PS8) 10Nemo bis: Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 [13:54:14] (03CR) 10jenkins-bot: [V: 04-1] Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [14:01:40] (03PS9) 10Nemo bis: Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 [14:22:02] Reedy: https://gerrit.wikimedia.org/r/83678 ... should be an easy one... [15:44:32] (03CR) 10Nikerabbit: [C: 04-1] "per my earlier comments" [core] - 10https://gerrit.wikimedia.org/r/83662 (owner: 10Jforrester) [16:13:53] mwalker|away: ping [16:20:38] (03PS1) 10Manybubbles: update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83806 [16:20:39] (03PS1) 10Manybubbles: Implement morelike: for more like this. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83807 [16:21:07] (03CR) 10Manybubbles: [C: 032] "Resubmit lost change." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83806 (owner: 10Manybubbles) [16:21:09] (03Merged) 10jenkins-bot: update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83806 (owner: 10Manybubbles) [16:28:37] (03PS2) 10Manybubbles: Implement morelike: for more like this. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83807 [16:54:03] (03PS2) 10Brian Wolff: use shrink instead of im_shrink [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/63862 (owner: 10J) [17:03:32] Nikerabbit: what can I do for you? [17:04:55] (03PS3) 10Manybubbles: Implement morelike: for more like this. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83807 [17:05:54] (03PS1) 10Manybubbles: Tests for morelike:. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/83819 [17:07:14] mwalker: I'd like to ask about a code in CentralNotice BannerMessageGroup, are you around? [17:07:30] yep yep; I'm currently on the north side of three [17:11:25] (03CR) 10Dan-nl: "(10 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 10Dan-nl) [17:16:49] (03PS3) 10Brian Wolff: use shrink instead of im_shrink [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/63862 (owner: 10J) [17:18:23] hey ^d [17:18:31] <^d> Yo [17:18:47] i'm looking for hashar... or anyone who can investigate a myterious jenkins failure [17:18:59] there'S n error message, and i can't get it to fail locally [17:19:08] any idea who i can ask about that? [17:19:17] https://integration.wikimedia.org/ci/job/mwext-Wikibase-testextensions-master/4374/console [17:20:19] hey rfarrand! [17:20:23] * ^d has a look [17:20:42] DanielK_WMDE: Hey! :) [17:20:59] How are you? [17:21:10] <^d> DanielK_WMDE: Ugh, I hate when it fails all vaguely like that. Lemme see if I can find hashar :) [17:21:13] ^d: --debug-tests helps if you do $wgDebugLogGroups['PHPUnitCommand'] = "/tmp/tests.log"; [17:21:30] that lets you see the last test it started [17:21:35] but if you can find hasher, much the better :) [17:21:59] rfarrand: busy, and... well, it's complicated :) [17:22:03] how'S the allhands going? [17:25:30] DanielK_WMDE: great (at least from my pov). Everyone is here and it seems productive. Lots of fun too. [17:25:46] Is busy/complicated a good thing at least? [17:26:56] sometimes, in both cases. but i'm good. [17:27:02] i'd live to be in SF with you guys though [17:28:54] (03PS1) 10Reedy: Parameter type hints [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/83825 [17:32:34] mwalker: pushed two patches [17:33:30] (03PS3) 10Reedy: Add method parameter type documentation [core] - 10https://gerrit.wikimedia.org/r/82255 [17:33:59] (03PS4) 10Reedy: Add method parameter type documentation [core] - 10https://gerrit.wikimedia.org/r/82255 [17:34:46] (03Abandoned) 10Reedy: Blocked used should be disallowed from being added to shell [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80566 (owner: 10Reedy) [17:35:52] Nikerabbit: would it not be better to make getKeys an interface? that way you can still check by type? [17:36:24] or; how much effort would it be to reparent BannerMessageGroup on top of MessageGroupBase? [17:36:48] mwalker: it doesn't make too much sense (the latter) [17:37:02] the message group calss tree is messy at the moment [17:37:47] kk; hence why probably not to introduce an interface as well [17:39:32] (03PS1) 10Reedy: Update mpdf to 5.7.1 [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/83829 [17:39:48] greg-g: is there a deploy window I can use today? [17:39:57] I want to refactor it some day, but that needs more thought to reach good results [17:40:38] Reedy: surely you didnt just write several thousand lines of code? [17:40:44] Haha. Nope [17:40:49] Update of 3rd party library [17:41:42] what was this extension using? [17:42:01] the mpdf library [17:42:42] well right; but how big of a version jump did it just take [17:43:26] 5.4 -> 5.7.1 [17:44:33] hey hashar! [17:45:09] hashar: can you solve a mystery for me? https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/3804/console [17:49:43] this library is a crazy work of love [17:50:28] Reedy: is that supposed to be cleaner and easier to install than Collection? [17:50:56] DanielK_WMDE: hey [17:51:02] DanielK_WMDE: chad told me you were looking for me :-D [17:51:10] looking [17:51:23] Nemo_bis: I don't think that would be a very high bar [17:51:29] bawolff: :D [17:51:30] Palliative Medicine Handbook [17:52:06] so mwalker was right, it is indeed about pain and love [17:52:48] bawolff: what was the old PNG thumbnail limit before VipsScaler? [17:52:59] Nemo_bis: No idea [17:53:01] 50 Megapixels [17:53:04] ok, thanks [17:53:04] Seemingly it should.. [17:53:12] we don't scale tiffs yet using vips, right? [17:53:18] correct [17:53:25] and we only use vips for big pngs [17:53:33] big being > 35 megapixels [17:53:35] bawolff: uh? wasn't it 25 just few months ago? [17:53:47] Nemo_bis: people kept increasing it [17:53:49] http://wikiapiary.com/wiki/Extension:Mpdf no use yet it seems [17:53:58] It was 35 not that long ago [17:54:05] "people" /me stares at Reedy [17:55:12] Bryan: Did you see the draft blog post that the communications folks are planning to write about vips? [17:55:19] yeah, I'm editting it [17:55:25] mwalker: from 3-4 [17:55:34] "Currently, VIPS scales PNG images from 35 to 140 megapixels and TIFF files under 50 megapixels, according to Commons contributor [https://www.mediawiki.org/wiki/User:Bawolff Brian Wolff]" [17:55:44] greg-g: awesome! Nikerabbit ^ [17:55:49] yeah that's a lie [17:55:55] (03PS1) 10Anomie: API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 [17:56:22] There's a couple other points in their draft that needs to be fixed for factual accuracy [17:56:28] (03PS1) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 [17:56:43] also all the example images in the draft are jpegs, which we don't use vips for currently [17:57:14] (03CR) 10Brian Wolff: [C: 032] "PS3: Fix typo (ouptut -> output)." [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/63862 (owner: 10J) [17:58:24] Bryan: The 140 megapixel limit seems to be not a memory limit, but the point where VIPS starts making temporary file's bigger than 400 mb. J's patch switching im_shrink -> shrink seems to push that limit up quite a bit [17:59:02] (03Merged) 10jenkins-bot: use shrink instead of im_shrink [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/63862 (owner: 10J) [17:59:20] (03CR) 10jenkins-bot: [V: 04-1] API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 (owner: 10Anomie) [17:59:35] bawolff: I hit save; could you read over it? [17:59:53] reading now [18:01:38] (03CR) 10TheDJ: "It's exactly because the method is very similar that I'd rather see it reused." [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [18:01:48] mwalker: deploying it today? cool. are you going to do it? [18:02:00] * bawolff feels like one of the images should be from someone other than Adam to make things a bit more equal [18:02:06] Nikerabbit: yep yep [18:02:33] though it would be nice if you were around to make sure it doesn't break translate :) [18:02:49] greg-g: added it to the deployment calendar [18:03:00] bawolff: lol, Adam is everywhere :) [18:03:12] (03Abandoned) 10TheDJ: TableSorter: Add option to mark rows as unsortable [core] - 10https://gerrit.wikimedia.org/r/74270 (owner: 10TheDJ) [18:03:17] (03PS2) 10Anomie: API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 [18:03:19] mwalker: thanks, was just going to ask [18:03:20] :) [18:03:21] mwalker: I will be in the office for sure [18:03:33] Adam has certainly provided many nice images, but I'm sure he's not the only one [18:03:42] couldn't they have interviewed another Commons contributor? [18:03:59] (03CR) 10Anomie: "PS2: Handle missing page, add release notes" [core] - 10https://gerrit.wikimedia.org/r/83833 (owner: 10Anomie) [18:04:01] Or perhaps a colour photo in the current sea of black and white [18:04:12] (03Abandoned) 10TheDJ: Accessibility: Add directory landmark role to our ToC [core] - 10https://gerrit.wikimedia.org/r/78950 (owner: 10TheDJ) [18:04:16] * bawolff tries to find his list of super big photos on commons he was using to test [18:04:43] yeah, I'd prefer an image from somebody who hasn't been a total dick during development [18:05:14] would someone merge this please : https://gerrit.wikimedia.org/r/#/c/80813/ [18:05:30] Adam has allegedly turned over a new leaf, and is less of a dick now [18:05:41] (03CR) 10Bsitu: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [18:06:38] sure. [18:08:03] bawolff: most of them were uncategorised [18:08:50] (03CR) 10Physikerwelt: "Now, I'm confused." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [18:08:51] or rather de- [18:09:39] https://commons.wikimedia.org/wiki/File:1863_Meeting_of_Settlers_and_Maoris_at_Hawke%27s_Bay,_New_Zealand_large.png is one [18:10:08] https://commons.wikimedia.org/wiki/File:7_sages_of_the_bamboo_grove_wittig_collectiong_painting_16.png [18:12:12] anomie: is $content->getSection( 'new' ) valid? [18:12:27] spagewmf: can the loginpage team give their +2 on that one plz ? https://gerrit.wikimedia.org/r/#/c/80813/ [18:12:36] legoktm: ... Good question. I should check that [18:12:47] since the tests are passing it seems like it... [18:13:03] bawolff: let me know when you're done; I still have to reply to comm [18:13:26] legoktm: When $params['section'] === 'new', then $section === 0, so the check isn't run. [18:13:49] ah, right. [18:14:07] lgtm, let me rebase my tests on your patchset [18:15:09] Bryan: Your changes look good. The only thing I want to change is find a non-black and white large picture [18:15:19] and link to actual pngs, instead of jpg versions of those images [18:17:01] I had a PNG word cloud amounting to some 800 MB uncompressed, somewhere [18:18:06] There's a lot of very high resoltion maps, but those are kind of boring [18:18:14] https://commons.wikimedia.org/wiki/File:Foundation-l_word_cloud.png [18:18:21] can't remember if this was actually broken [18:18:46] maybe it was another version which made my computer crash (when using silly software), or maybe not [18:18:59] Nemo_bis: That's over 50 MP [18:19:00] (03PS2) 10Matthias Mullie: Don't trigger code onUserSaveSettings when run as maintenance script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83202 [18:19:03] so it would of been [18:19:35] (03PS2) 10Legoktm: Tests for API section editing [core] - 10https://gerrit.wikimedia.org/r/83219 [18:20:41] YuviPanda: https://etherpad.wikimedia.org/p/UploadWizard-and-EventLogging [18:22:35] Hmm, I guess there is https://commons.wikimedia.org/wiki/File:Corsica_%28Landsat_7%29_-_high_definition.png [18:23:54] ah, it's still in https://commons.wikimedia.org/wiki/Category:PNG_files_affected_by_MediaWiki_restrictions [18:24:27] definitely prettier: https://commons.wikimedia.org/wiki/File:The_Helix_Nebula.png [18:24:50] oh, not over 50 [18:25:23] Nemo_bis: how could we publicize http://blog.wikimedia.org/2013/09/10/https-by-default-beta-program/ further? [18:26:04] ori-l: how much opt-in is desired? [18:26:31] the more, the merrier, i think [18:27:01] forwarding to wikitech-ambassadors would be a start, though of course most of them are supposed to read the blog [18:27:33] (03PS10) 10Merlijn van Deen: pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar) [18:27:34] good idea. what else? or you think that should suffice? [18:27:48] (03CR) 10jenkins-bot: [V: 04-1] pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar) [18:28:50] ori-l: there are several possible degrees of spamminess, I'd say wait some days and then expand if you're unhappy with response [18:29:07] (03CR) 10Legoktm: [C: 031] API: Check for nosuchsection in all code paths [core] - 10https://gerrit.wikimedia.org/r/83833 (owner: 10Anomie) [18:29:07] kk, cool. thanks for the advice. [18:29:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [18:30:19] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [18:31:34] (03PS11) 10Merlijn van Deen: pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar) [18:32:03] YuviPanda: https://www.mediawiki.org/wiki/Extension:UploadWizard/Events_to_log [18:36:41] http://etherpad.wikimedia.org/p/CSF_Katie [18:44:07] Bryan: I changed some of the images (Still mostly Adam images) [18:44:25] text is ok? [18:44:49] text sounds fine to me [18:45:03] language hackers: i want to hack on language today! can i grab some of y'all? [18:45:14] Although I don't entirely understand sumanah's comment about wiki love monuments [18:45:40] ok, thanks [18:45:48] (03CR) 10Physikerwelt: [C: 032] "OK." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [18:45:50] since really wlm doesn't involve billion pixel resolution images [18:45:59] (03Merged) 10jenkins-bot: Improvements to prepare a MathJax+PNG option [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [18:46:07] and images won't break [18:46:11] but ok [18:47:43] (03CR) 10Bsitu: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [18:52:24] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [18:54:25] (03PS3) 10Euvl: Ability to turn off the recognition of glossary terms in certain places(Lingo). Phase 2: visual interface for turning off in (involves JS) [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/83228 [18:59:22] (03PS3) 10Physikerwelt: Displaystyle [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 [19:02:14] (03CR) 10Frédéric Wang: "MathML has display inline vs block, LaTeX has $ vs $$ & environment. display=inline creates formulas in a paragraph of text with minimal h" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [19:04:17] (03PS2) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 [19:07:57] (03CR) 10Frédéric Wang: [C: 04-1] "This breaks backward compatibility and the guessDisplaytyleFromTex is just not reliable at all so I'm voting -1 for this." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 (owner: 10Physikerwelt) [19:08:35] (03CR) 10Physikerwelt: "But that's the reason why this method can not be used for my purpose. e.g." [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [19:10:36] marktraceur: https://meta.wikimedia.org/wiki/Schema:UploadWizardTutorialActions [19:16:47] (03PS1) 10Anomie: Make ManageMyGrants look more like /authorize [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83849 [19:23:28] (03PS3) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 [19:30:55] (03PS2) 10Reedy: Add CleanChanges extension [tools/release] - 10https://gerrit.wikimedia.org/r/81706 (owner: 10Nemo bis) [19:31:00] (03CR) 10Reedy: [C: 032] Add CleanChanges extension [tools/release] - 10https://gerrit.wikimedia.org/r/81706 (owner: 10Nemo bis) [19:31:02] (03Merged) 10jenkins-bot: Add CleanChanges extension [tools/release] - 10https://gerrit.wikimedia.org/r/81706 (owner: 10Nemo bis) [19:31:22] (03Abandoned) 10Reedy: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81800 (owner: 10Nemo bis) [19:31:38] (03PS2) 10Reedy: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81825 (owner: 10Nemo bis) [19:31:48] (03PS1) 10Reedy: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83850 [19:32:00] (03Abandoned) 10Reedy: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81825 (owner: 10Nemo bis) [19:32:20] (03CR) 10Reedy: [C: 032 V: 032] Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83850 (owner: 10Reedy) [19:34:14] (03PS4) 10Physikerwelt: Displaystyle [extensions/Math] - 10https://gerrit.wikimedia.org/r/83666 [19:36:27] how can i find a list of outbound links on Wikipedia? [19:37:14] I'm not sure we list it [19:37:26] You can use the api to find external links on a page [19:37:54] hexmode: special:linksearch [19:37:58] hexmode: https://en.wikipedia.org/wiki/Special:LinkSearch [19:38:01] externallinks table [19:38:03] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/83872 (owner: 10L10n-bot) [19:39:16] Reedy: yes ... hrm... ok. IDEA! [19:48:59] (03PS1) 10Reedy: Invalid argument supplied for foreach() in ApiQueryGadgets.php on line 58 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/83914 [19:49:29] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/83872 (owner: 10L10n-bot) [19:50:50] (03PS7) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 [19:53:38] (03CR) 10Hoo man: [C: 032] Invalid argument supplied for foreach() in ApiQueryGadgets.php on line 58 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/83914 (owner: 10Reedy) [19:53:42] (03Merged) 10jenkins-bot: Invalid argument supplied for foreach() in ApiQueryGadgets.php on line 58 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/83914 (owner: 10Reedy) [20:03:51] (03PS1) 10Matthias Mullie: Just like in getContentObject(), use anon-specific text if user is anon [core] - 10https://gerrit.wikimedia.org/r/83915 [20:05:37] Reedy: made any progress on your pdf front -- mine has stalled out because PhantomJS is still running Qt4 webkit which doesn't have support for a couple of features book.js needs [20:05:44] (03CR) 10Catrope: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [20:06:33] (03CR) 10Bartosz Dziewoński: [C: 031] "I'll leave it here for a while so that people have time to comment and merge by the end of the week if nobody does." [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [20:07:09] (03PS8) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 [20:07:18] RoanKattouw: 1) Thanks for the review! 2) I agree about scrapping the client-side implementation, at least for now. 3) Did you mean that noflip / embed didn't work in debug mode, or also not when relying on the server to compile LESS? [20:07:20] I got distracted with other things.. [20:09:10] distract-o-bot: Reedy https://www.wikidata.org/wiki/Q132730 [20:09:15] Reedy: fair enough [20:10:21] hmm [20:10:40] speaking of phantomjs…. i wonder if we can use it as an SVG renderer [20:10:43] mutante: Can we make travel guides on Wikivoyage? [20:10:44] screw rsvg :P [20:10:45] (03CR) 10Physikerwelt: "@TheDJ: Now I've implemented both options." [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [20:11:40] (03PS1) 10Rillke: Use SQL that SQLite 3.7.8 understands [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/83917 [20:12:13] Reedy: heh, yea:) but it sounds like you need to copy all those templates they guy wanted yesterday to "need 2 articles in 1 page" [20:15:38] ori-l: (Replied IRL, writing here for posterity): embed and noflip don't work at all, in either debug=true or debug=false. I can pastebin my test case if that helps [20:15:42] (03PS1) 10Anomie: Add StubObject::unstub, and use it for $wgAuth->getUserInstance() [core] - 10https://gerrit.wikimedia.org/r/83918 [20:16:06] (03CR) 10Rillke: "You may want to wrap this in a single commit. But I don't know about the compatibility requirements so I'd better let this to someone more" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/83917 (owner: 10Rillke) [20:16:07] (03CR) 10Bsitu: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [20:16:17] (03PS4) 10Aaron Schulz: Tweaked the OAuth /authorize UI and made other cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 [20:16:28] brion: ya; it's a very good svg renderer [20:16:41] brion: ever tested 3D stuff in mediawiki? https://github.com/lyriarte/Wiki3D/blob/master/README https://www.mediawiki.org/wiki/Extension:X3d [20:16:57] (03CR) 10Anomie: "To see the problem behind this, try the following:" [core] - 10https://gerrit.wikimedia.org/r/83918 (owner: 10Anomie) [20:17:59] Can apng files be thumbnails and still be animated? [20:18:04] "Note: Due to technical limitations, thumbnails of this file will not be animated." [20:18:06] mutante: haven't had a chance yet, but it'd be fun sometime :D [20:18:09] https://commons.wikimedia.org/wiki/File:Animated_PNG_example_bouncing_beach_ball.png [20:18:43] Reedy: in theory they could, but we'd need support in the thumbnail generators [20:18:46] which i guess we don't :) [20:19:15] I suspect it's a small use case (at least for now) [20:20:14] * brion wonders if there's alpha channel in webm [20:20:30] * brion finds http://updates.html5rocks.com/2013/07/Alpha-transparency-in-Chrome-video [20:23:00] (03CR) 10Santhosh: [C: 032] Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [20:23:01] (03CR) 10jenkins-bot: [V: 04-1] Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [20:27:36] (03PS1) 10Siebrand: Initial version of extension. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/83920 [20:28:25] * brion still wonders why we have wikibugs in #mediawiki but gerrit-wm here [20:28:31] it's a madhouse [20:28:48] brion: everytime someone tries to move wikibugs here, they get shot down by 'other people' [20:29:02] let's shoot down the other people [20:29:33] (03PS3) 10Bsitu: Render dates as headings [extensions/Echo] - 10https://gerrit.wikimedia.org/r/73529 (owner: 10Kaldari) [20:30:09] (03CR) 10Siebrand: [C: 032 V: 032] Initial version of extension. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/83920 (owner: 10Siebrand) [20:30:15] marktraceur: 5803466 [20:30:52] (03CR) 10Kaldari: [C: 04-1] "Doesn't work correctly for non-prettyURLs. Stay tuned." [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [20:32:41] (03CR) 10Bsitu: [C: 031] Render dates as headings [extensions/Echo] - 10https://gerrit.wikimedia.org/r/73529 (owner: 10Kaldari) [20:33:03] marktraceur: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEventLogging.git/HEAD/modules%2Fext.eventLogging.core.js [20:35:03] (03CR) 10Aaron Schulz: [C: 032] Add StubObject::unstub, and use it for $wgAuth->getUserInstance() [core] - 10https://gerrit.wikimedia.org/r/83918 (owner: 10Anomie) [20:36:05] (03PS2) 10Aaron Schulz: filebackend: FS needn't be so strict with names [core] - 10https://gerrit.wikimedia.org/r/83774 (owner: 10Ejegg) [20:38:52] (03Merged) 10jenkins-bot: Add StubObject::unstub, and use it for $wgAuth->getUserInstance() [core] - 10https://gerrit.wikimedia.org/r/83918 (owner: 10Anomie) [20:40:26] (03PS5) 10Aaron Schulz: Tweaked the OAuth /authorize UI and made other cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 [20:40:45] (03CR) 10Aaron Schulz: "Keep forgetting git add." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 (owner: 10Aaron Schulz) [20:41:05] (03PS4) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 [20:41:07] (03PS1) 10MarkTraceur: Add events on tutorial actions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83922 [20:44:36] (03CR) 10jenkins-bot: [V: 04-1] Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [20:44:45] (03CR) 10MaxSem: [C: 031] Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 (owner: 10Kaldari) [20:46:28] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83774 (owner: 10Ejegg) [20:46:48] Warning: Parameter 1 to CentralAuthPlugin::getUserInstance() expected to be a reference, value given in /var/www/DevWiki/core/includes/StubObject.php on line 79 Fatal error: Call to a member function isHidden() on a non-object in /var/www/DevWiki/core/includes/User.php on line 1721 [20:46:59] anomie: that's gone now \o/ [20:47:06] * AaronSchulz ran into that the other day [20:49:04] (03PS5) 10Kaldari: Adding support for query string params to mw.util.wikiGetlink [core] - 10https://gerrit.wikimedia.org/r/83834 [20:51:40] (03PS2) 10MarkTraceur: Add events on tutorial actions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83922 [20:54:08] (03PS3) 10MarkTraceur: Add events on tutorial actions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83922 [20:55:09] anomie: Fatal error: Using $this when not in object context in /var/www/DevWiki/extensions/OAuth/frontend/specialpages/SpecialMWOAuthManageMyGrants.php on line 192 :( [20:55:23] the same old closure gotcha [20:55:38] well, at least $context is there already [20:56:39] AaronSchulz: d'oh. [20:56:55] (03PS2) 10Anomie: Make ManageMyGrants look more like /authorize [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83849 [20:57:27] OuKB: I'm trying to run your minifier server, but it doesn [20:57:28] ori-l: ping [20:57:30] where you at? [20:57:35] ori-l: EL questions! [20:57:38] 't have a package.json and I don't know exactly which packages to install [20:57:42] So I can't get it to run [20:58:31] my desk [20:58:33] other side of 3rd [20:58:36] the dark side of the moon [20:58:43] ori-l: heh, okay. [20:58:48] (03CR) 10Siebrand: "Per PS3 L10n related comments." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 (owner: 10Aaron Schulz) [20:58:54] (03CR) 10Siebrand: [C: 04-1] Tweaked the OAuth /authorize UI and made other cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83589 (owner: 10Aaron Schulz) [21:04:05] (03PS1) 10Anomie: API: Enforce limit max in ApiQueryBacklinks [core] - 10https://gerrit.wikimedia.org/r/83935 [21:05:38] RoanKattouw, it's still not 100% functional anyway, I was interested in your opinion about hte overall architecture [21:06:27] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [21:06:36] OK [21:07:44] Does the node server do hash-based caching of unminified->minified pairs, or does that remain in memc? [21:10:15] I like the architecture well enough, but I'm mostly wondering what the benefit is. Is it because you want to use a minifier engine that's written in node? Is it because it's faster? [21:11:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [21:12:36] (03CR) 10Catrope: [C: 032] API: Enforce limit max in ApiQueryBacklinks [core] - 10https://gerrit.wikimedia.org/r/83935 (owner: 10Anomie) [21:13:14] ( OuKB ---^^ ) [21:14:43] (03PS5) 10Nikerabbit: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 [21:15:07] for those in the elasticsearch meeting: http://9200.elasticsearch-monitoring-playground.instance-proxy.wmflabs.org/_plugin/segmentspy/#/nikwiki_content_red/ [21:15:32] manybubbles: link again please :) [21:15:39] for those in the elasticsearch meeting: http://9200.elasticsearch-monitoring-playground.instance-proxy.wmflabs.org/_plugin/segmentspy/#/nikwiki_content_red/ [21:17:03] (03Merged) 10jenkins-bot: API: Enforce limit max in ApiQueryBacklinks [core] - 10https://gerrit.wikimedia.org/r/83935 (owner: 10Anomie) [21:17:04] (03CR) 10Santhosh: [C: 032] Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [21:17:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [21:18:11] (03CR) 10Siebrand: "Where do we want to go with this?" [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [21:18:12] (03Merged) 10jenkins-bot: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [21:19:08] (03CR) 10Siebrand: "Is the patch submitter planning on fixing the issues that were pointed out in review, or should the patch set be abandoned?" [core] - 10https://gerrit.wikimedia.org/r/65139 (owner: 10Clancer) [21:19:58] (03Abandoned) 10Siebrand: Add "taction" parameter for non-TUX [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 (owner: 10Shirayuki) [21:21:08] (03PS1) 10Yurik: Updated Zero ext to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83937 [21:21:12] ori-l: couldn't find you [21:21:37] (03PS1) 10Chad: Remove dl() usage [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/83938 [21:21:55] (03CR) 10Siebrand: "(1 comment)" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [21:22:41] (03CR) 10Siebrand: "Netbrain: Please do not score your own patch sets +1, it doesn't add information." [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [21:23:14] RoanKattouw, it has its own cache because memcached keys are per-wiki only, so by having a cache in node you get better hit rate [21:23:28] Oh right I see [21:23:38] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/73738 (owner: 10Netbrain) [21:23:56] Does that mean that in the core change you have sitting in Gerrit, there should be a facility to turn off memc caching? [21:24:05] I suppose the memc cache doesn't technically hurt [21:25:26] (03CR) 10Siebrand: "Where should this patch set go from here? It's been inactive for a month now." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [21:25:47] yup, it doesn [21:25:51] t hurt [21:26:10] I'll come by when my search talk will be over [21:27:08] (03PS4) 10MarkTraceur: Add events on tutorial actions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83922 [21:28:05] I'm in a language converter thing right now [21:28:05] I'll come find you when I'm done [21:28:11] OuKB: memcached keys aren't always per-wiki only. That's the default, but there can also be global cache keys [21:28:31] OuKB: For example, see some of the filerepo stuff for dealing with images on commons [21:28:32] BAM, eventlogging in UW [21:28:57] (03PS1) 10Hashar: disable suoshin mem handler for code coverage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/83940 [21:29:27] (03CR) 10Hashar: [C: 04-2] "Alexandros trying it out on gallium right now. Will see what happens." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/83940 (owner: 10Hashar) [21:29:30] (03PS8) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 [21:30:28] mwalker: Was the BookManagerv2.hooks.php.orig inclusion the only issue? Your comment made it sound like the rebase might have been problematic [21:31:09] I was suspicious about the rebase because it didn't look like your changes from PS5 made it into the actual hooks.php [21:31:18] * GorillaWarfare looks [21:31:58] mwalker: In the hooks file? [21:32:06] yep [21:32:09] bawolff, I knoww;) [21:32:39] :) [21:32:44] (03PS1) 10Yurik: Updated Zero ext to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83941 [21:32:52] I wont discount the possibility I just messed up doing the diff [21:33:29] i don't suppose there's some way to configure bugzilla search to show duplicate bugs only when they're duplicates of OPEN bugs... [21:34:36] (03PS3) 10Kaldari: Cleaning up Echo 'base' module. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 [21:35:30] (03CR) 10Kaldari: "Bsitu: I'm going to remove the PHP code in a follow-up commit. This at least gets the JS cleaned up." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83575 (owner: 10Kaldari) [21:35:49] (03CR) 10Yurik: [C: 032] Updated Zero ext to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83937 (owner: 10Yurik) [21:35:55] (03CR) 10Yurik: [C: 032] Updated Zero ext to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83941 (owner: 10Yurik) [21:37:19] mwalker: I'm still seeing the change [21:37:34] ok; so I'm dumb :) [21:37:40] * mwalker wanders over to gerrit [21:37:42] Or I'm missing it [21:37:51] (03CR) 10Liangent: "Still useful but no time to refactor it now." [core] - 10https://gerrit.wikimedia.org/r/22699 (owner: 10Liangent) [21:37:54] Wouldn't discount that possibility either [21:38:52] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83849 (owner: 10Anomie) [21:39:26] (03CR) 10Mwalker: [C: 032] Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [21:39:33] (03Merged) 10jenkins-bot: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [21:39:40] GorillaWarfare: nope; it was there [21:39:56] I was merely looking at the wrong file [21:40:18] Ah, that would do it [21:40:49] GorillaWarfare: hey, hows the project comming along? [21:42:16] Rahul21: It's coming :) Moved apartments and started school again, though, so the biggest challenge for me right now is time [21:43:33] GorillaWarfare: Nice :) [21:44:14] Rahul21: You? [21:46:14] (03PS1) 10Aaron Schulz: Made HTMLForm wrap the submit buttons in a container for styling [core] - 10https://gerrit.wikimedia.org/r/83942 [21:46:14] GorillaWarfare: Well, the projects complicated than I originally estimated, so the realistic chances of project completion within the time frame is very dim, but then after GSoC I'll carry on the work. It's been fun, learned and used JS for the first time. [21:46:22] ^d: ^ [21:46:50] (03CR) 10MarkAHershberger: "Thanks for the reminder, Siebrand. I do want to get this into core soon. I'll try to finish it tonight." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [21:46:58] Rahul21: Indeed; this project won't be complete within the time frame either [21:47:02] But I think that's okay [21:47:51] (03CR) 10Chad: [C: 032] Made HTMLForm wrap the submit buttons in a container for styling [core] - 10https://gerrit.wikimedia.org/r/83942 (owner: 10Aaron Schulz) [21:48:01] GorillaWarfare: yea, the broader aspect of this whole program is to make noobs like me turn their heads towards Web Development! and surely I have [21:48:09] That's good :) [21:48:30] Anyway, off to a meeting [21:48:32]