[00:07:42] (03PS12) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [00:07:43] (03PS29) 10Rasel160: Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 [00:16:13] (03PS30) 10Rasel160: Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 [00:43:31] (03Abandoned) 10Sumanah: pierwsza zmiana druga zmiana [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/79195 (owner: 10Yorg666) [00:44:48] (03CR) 10Sumanah: "Sounds like a good idea! Thanks." [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 (owner: 10QChris) [00:45:55] robla: Yo. [00:46:04] robla: I just bumped https://bugzilla.wikimedia.org/show_bug.cgi?id=31369 [01:00:48] (03PS1) 10Rfaulk: mv - init functionality into config.py. [sartoris] - 10https://gerrit.wikimedia.org/r/83382 [01:00:49] (03PS1) 10Rfaulk: mod - update to no longer ignore config.py. [sartoris] - 10https://gerrit.wikimedia.org/r/83383 [01:00:50] (03PS1) 10Rfaulk: rm - no longer needed. [sartoris] - 10https://gerrit.wikimedia.org/r/83384 [01:00:51] (03PS1) 10Rfaulk: mod - to reflect changes. [sartoris] - 10https://gerrit.wikimedia.org/r/83385 [01:01:08] (03CR) 10Rfaulk: [C: 032 V: 032] mv - init functionality into config.py. [sartoris] - 10https://gerrit.wikimedia.org/r/83382 (owner: 10Rfaulk) [01:01:20] (03CR) 10Rfaulk: [C: 032 V: 032] mod - update to no longer ignore config.py. [sartoris] - 10https://gerrit.wikimedia.org/r/83383 (owner: 10Rfaulk) [01:01:30] (03CR) 10Rfaulk: [C: 032 V: 032] rm - no longer needed. [sartoris] - 10https://gerrit.wikimedia.org/r/83384 (owner: 10Rfaulk) [01:01:39] (03CR) 10Rfaulk: [C: 032 V: 032] mod - to reflect changes. [sartoris] - 10https://gerrit.wikimedia.org/r/83385 (owner: 10Rfaulk) [02:12:30] yawn [02:29:19] Hi ori-l. [02:29:29] hi Elsie-l [02:29:39] the '-l' is honorific [02:29:50] I'm hono(u)red. [02:30:18] http://www.newyorker.com/reporting/2012/12/24/121224fa_fact_foer?currentPage=all [02:30:21] Have you read that? [02:31:23] I am now [02:34:15] are you proposing we form an editor psychonetics team? [02:34:23] because if you are, i'm in favor [02:52:53] what is the meaning of the last comment on this page? -> https://bugzilla.wikimedia.org/show_bug.cgi?id=53855 ("Change 83218 had a related patch set uploaded by TTO: Localized logo for hewikivoyage") [02:54:33] WikiJunkie: logos are set via configuration variables, which wikimedia keeps in a set of master configuration files [02:54:57] the comment is an automatic notification that someone submitting a change to the configuration files to make the change requested in the bug [02:54:59] ok [02:55:04] *submitted [02:55:29] so when do you think that change would be visable ? [02:57:08] (03PS1) 10Gnosygnu: v0.9.1.0 [xowa] - 10https://gerrit.wikimedia.org/r/83387 [02:58:19] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving my commit" [xowa] - 10https://gerrit.wikimedia.org/r/83387 (owner: 10Gnosygnu) [02:58:35] WikiJunkie: probably tomorrow [02:58:51] oh ok. thanks. [03:00:21] WikiJunkie: between 9:00 - 17:00 PDT is a good bet (19:00 - 03:00 israel time) [03:01:32] is that the office hours of the main developers ? [03:02:12] I guess so [03:02:18] ok thanks [03:02:19] for many of them, yes -- and this week especially, since there's a meeting for all staff [03:02:48] I see [03:03:10] thanks again for the help [03:03:15] bye [03:03:18] no problem, bye [03:22:46] (03PS1) 10Jackmcbarn: Allow changing name of template being previewed [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 [04:38:13] (03CR) 10Mwalker: "Ah; ya, I didn't get an indentation property in the root element when I resaved -- but that's just a migration thing; I created a new book" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [04:48:45] (03CR) 10Mwalker: [C: 04-1] "(4 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [05:25:56] (03PS1) 10Rfaulk: add - 'client_path' config property. [sartoris] - 10https://gerrit.wikimedia.org/r/83390 [05:25:57] (03PS1) 10Rfaulk: fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 [05:26:08] (03CR) 10jenkins-bot: [V: 04-1] fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 (owner: 10Rfaulk) [05:26:19] (03CR) 10Rfaulk: [C: 032 V: 032] add - 'client_path' config property. [sartoris] - 10https://gerrit.wikimedia.org/r/83390 (owner: 10Rfaulk) [05:29:47] (03Abandoned) 10Rfaulk: fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 (owner: 10Rfaulk) [05:32:28] (03Restored) 10Rfaulk: fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 (owner: 10Rfaulk) [05:36:32] (03PS2) 10Rfaulk: fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 [05:36:53] (03CR) 10Rfaulk: [C: 032 V: 032] fix - calls in _default_sync + logging. [sartoris] - 10https://gerrit.wikimedia.org/r/83391 (owner: 10Rfaulk) [06:01:56] (03CR) 10Mwalker: [C: 04-1] "(3 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81560 (owner: 10Mollywhite) [08:27:36] Hey there! How can I find out programmatically if the mediawiki installation is using pretty URLs or not? I want to insert a link to MyPage?debug=true, but without pretty URLs this needs to be MyPage&debug=true because the ? is already in index.php?title=MyPage. [08:29:03] (03PS10) 10Frédéric Wang: MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 (owner: 10Physikerwelt) [08:31:52] * legoktm looks [08:32:41] Granjow: https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&format=jsonfm the 'articlepath' key [08:33:52] legoktm: thanks a lot! [08:33:58] np [08:34:04] https://www.mediawiki.org/wiki/API:Meta might be useful as well [09:01:05] Is there also a way to access this information directly via PHP? [09:04:49] Granjow: er, what do you mean? [09:05:22] like, you want to make a link to a page? [09:06:18] https://www.mediawiki.org/wiki/Manual:Linker.php i guess then [09:06:20] Yes. My special page subpage only works with debug=true for some reason. So I want the links to the subpages to point to ?debug=true automatically. [09:06:24] Linker::makeLink [09:06:26] oh um [09:06:29] well, thats a bug :P [09:06:45] also https://www.mediawiki.org/wiki/Manual:$wgResourceLoaderDebug [09:07:53] what is a bug? :) [09:08:36] Linker seems perfect, thanks! Regarding Resource Loader, will have to investigate why this fails exactly. [09:27:20] (03PS1) 10Jeroen De Dauw: Update method names to avoid confusion and bump to 2.0 [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/83395 [09:28:00] (03CR) 10Jeroen De Dauw: [C: 032] "This was already merged but gerrit did something odd..." [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/83395 (owner: 10Jeroen De Dauw) [09:28:50] For some reason, Linker::link returns me just the second plain HTML parameter and does not create any link. [09:33:18] ah, my bad. the first one needs to be a Title object and not only a string. [09:44:33] Is there also a good way to link to api.php? [09:53:21] ah, $wgScriptPath/api.php :) [10:12:04] (03PS1) 10Frédéric Wang: Merge MathJax and texvc modes. [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 [10:19:12] (03CR) 10Krinkle: "possible fixme: Not sure if false makes sense as the default value to compare against. file_get_contents can return false in case of an er" [core] - 10https://gerrit.wikimedia.org/r/70747 (owner: 10CSteipp) [10:24:38] (03CR) 10Frédéric Wang: "This implements the change discussed between MediaWiki and the MathJax team: it makes texvc and MathJax produce the same HTML output so th" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [10:24:59] (03CR) 10Krinkle: "For reference, that module was removed in r86056 / 5c89f16552." [core] - 10https://gerrit.wikimedia.org/r/78469 (owner: 10Bartosz Dziewoński) [10:33:06] (03CR) 10Anomie: [C: 04-1] "While that's an interesting idea, it also makes the section on the edit form much more complicated. And one of the design goals for that p" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [10:44:11] (03CR) 10Anomie: "BTW, to do this sort of previewing now, you can use Special:TemplateSandbox and a redirect from Special:MyPage/sandbox/Template:X to Templ" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [10:53:32] (03PS1) 10Mwjames: [DIC]: ObjectInjector a configurable injector class (ServiceLocator pattern) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83402 [11:24:40] (03PS2) 10Mwjames: [DIC]: ObjectInjector a configurable injector class (ServiceLocator pattern) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83402 [11:45:43] (03PS1) 10Legoktm: Create new LQT thread if possible [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/83409 [14:17:46] (03PS2) 10Jackmcbarn: Allow changing name of template being previewed [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 [14:19:23] @notify bawolff [14:19:23] I'll let you know when I see bawolff around here [14:19:39] (03CR) 10Jackmcbarn: "In the new patchset, I hide the template name label and text box behind display: none, so that users who want it can easily see it with Ja" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [14:26:37] i need somebody who knows things about LinkCache. [14:35:36] (03CR) 10Jackmcbarn: "Regarding your comment about Special:TemplateSandbox, the reason I prefer this method over it is that I don't need to save changes before " [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/83389 (owner: 10Jackmcbarn) [14:54:04] @notify TimStarling [14:54:04] I'll let you know when I see TimStarling around here [15:08:37] (03PS1) 10Rillke: Copy contents of campaign fields with the copy-metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 [15:11:10] (03CR) 10Rillke: "Not sure whether this is "the right way" or whether this should be an extra-checkbox (requires new i18n string) or an extra checkbox for e" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (owner: 10Rillke) [15:13:42] [15:28:15] hi bawolff. i cc'd you on a bug. [15:28:27] * bawolff checks email [15:28:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=53945 [15:28:36] which one? [15:28:38] thanks [15:29:33] (03CR) 10Physikerwelt: [C: 04-1] "I did not test that, but for me it reads as it forces everyone to use MathJax, except if you disable javascript in your browser. Furthermo" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [15:34:50] MatmaRex: That sounds like a sane plan to me [15:35:10] Although if you're unsure, you may want to send a quick mail to wikitech-l [15:36:43] (03CR) 10Physikerwelt: "I think it is ready to merge. However I'm wondering why all the /r come into the files. Maybe it's a vagrant issue." [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 (owner: 10Physikerwelt) [15:36:47] bawolff: i cc'd a bunch of people, i'll wait for at least some of them to reply (or poke them to make them do it) [15:37:16] wikitech kind of sucks for solving problems :P [15:37:40] It didn't used to be like that... [15:39:16] last time i proposed something "revolutionary" there i received zero replies, waste of time [15:39:42] okay, maybe one or two [15:39:50] (which were rather unhelpful) [15:40:03] (that was re https://bugzilla.wikimedia.org/show_bug.cgi?id=46956) [15:40:13] You can usually take that as a go ahead and do whatever you want ;) [15:40:33] like anybody would merge that [15:40:57] hmm, yeah there is that problem [15:41:04] (the response was two people bitching with no alternatives) [15:41:11] brb, dinner [15:42:45] yeah, its sad when that happens [15:47:08] (03CR) 10Frédéric Wang: "> I did not test that, but for me it reads as it forces everyone to use MathJax, except if you disable javascript in your browser." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [15:51:47] (03CR) 10Frédéric Wang: "You mean about Math.php? On the master branch it is encoded with Unix end-of-line style while on your dev branch it was with the Windows s" [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 (owner: 10Physikerwelt) [15:59:39] MatmaRex: I had more luck on mediawiki-l (and this says it all), while wikitech-l never solved me a single problem in a thread initiated by me since 2009 [16:00:59] (03CR) 10Frédéric Wang: "Can other MediaWiki people please comment on that change and how they see the best way to make MathJax exposed to anonymous users?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [16:10:41] (03PS2) 10MarkTraceur: Copy contents of campaign fields with the copy-metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (owner: 10Rillke) [16:34:50] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83417 [16:39:01] (03CR) 10Chad: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83417 (owner: 10Chad) [16:41:45] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83417 (owner: 10Chad) [16:46:29] (03CR) 10Legoktm: [C: 032] Set 'use strict' for all JavaScript files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83065 (owner: 10Legoktm) [16:46:41] (03Merged) 10jenkins-bot: Set 'use strict' for all JavaScript files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83065 (owner: 10Legoktm) [16:52:19] (03CR) 10Jdlrobson: [C: 031 V: 031] Make the "Categories:" HTML heading optional in getCategoryLinks() [core] - 10https://gerrit.wikimedia.org/r/78000 (owner: 10Pypt) [16:55:56] (03PS11) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 [16:57:30] (03CR) 10Physikerwelt: [C: 032] MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 (owner: 10Physikerwelt) [17:06:07] (03PS2) 10MarkTraceur: Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 [17:08:15] (03CR) 10Physikerwelt: "That means you check the mode inside the matjax javascript... maybe a comment could be added to the php file?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [17:10:31] (03CR) 10Physikerwelt: "Ok I see." [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [17:28:53] morning greg-g [17:29:45] mwalker: yo [17:29:47] (03CR) 10BryanDavis: [C: 032] Make the description a little less complex [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 (owner: 10MarkTraceur) [17:29:52] (03PS3) 10MarkTraceur: Make the description a little less complex [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 [17:29:59] mwalker: andre__ and I were talking about the CN issue this morning :) [17:30:12] which one! there are many :) [17:30:23] (03PS1) 10Legoktm: Mark tests as using the database [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83420 [17:30:24] (03PS3) 10MarkTraceur: Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 [17:31:10] (03CR) 10Legoktm: [C: 032] Mark tests as using the database [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83420 (owner: 10Legoktm) [17:31:15] (03Merged) 10jenkins-bot: Mark tests as using the database [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83420 (owner: 10Legoktm) [17:31:28] where the heck I'm going to deploy the changes? I was thinking I would try and sneak in between the wmf deploy and eventlogging [17:31:30] (03CR) 10BryanDavis: [C: 032] "Even better. Let's see what happens now." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 (owner: 10MarkTraceur) [17:31:35] (03Merged) 10jenkins-bot: Make the description a little less complex [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 (owner: 10MarkTraceur) [17:31:36] which in theory is at least an hour [17:31:47] but I still dont see any dba's online [17:32:28] (03PS4) 10BryanDavis: Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 (owner: 10MarkTraceur) [17:32:34] I've also no idea if springle_away is in the office [17:40:46] PHP Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/MoodBar/include/MoodBarUtil.php on line 44 and defined in /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php on line 40 [17:40:55] Who owns MoodBar? [17:41:00] Looks like the same error as AFTv5 [17:41:07] MatmaRex: Sorry, looks like there was some issue where my bouncer marked me as not-away yesterday around 3pm PDT while actually I was very much away [17:41:17] CC kald damn it [17:42:01] Reedy: I'd poke kaldari or bsitu, I think they're over near Erik at the moment [17:42:05] RoanKattouw: no problem :) i was pinging you about some trivial CR [17:42:19] <^d> Reedy: Well, it's deployed features, so that means platform owns it now ;-) [17:42:31] <^d> Features writes things. Platform gets to maintain :) [17:42:34] atus [17:42:34] ^d: Reedy: undeploy it ~ [17:42:36] http://i.imgur.com/3CS31.jpg [17:42:41] (03CR) 10Catrope: [C: 032] mediawiki.action.edit.preview: Add .limitreport to live preview [core] - 10https://gerrit.wikimedia.org/r/83371 (owner: 10Bartosz Dziewoński) [17:42:54] <^d> MatmaRex: I'm thinking that's a good model to follow. [17:43:06] Neither of kaldari or bsitu are on the CC [17:43:09] <^d> For each fatal your extension produces you have to spend a week in time-out with your extension turned off :p [17:43:20] haha [17:43:35] Reedy: Who is, werdna? [17:44:05] echo werdna | rev [17:44:38] actually, moodbar is still deployed somewhere? [17:44:44] nlwiki apparently [17:44:47] i though it's dead and buried [17:44:54] marktraceur: andrew [17:44:56] (03PS3) 10Legoktm: Add a required footer to all messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 [17:45:08] But...Andrew Garrett, right? [17:45:11] marktraceur: yes [17:45:17] Not like andrewbogott or something equally ridiculous [17:45:21] OK [17:45:50] (03Merged) 10jenkins-bot: mediawiki.action.edit.preview: Add .limitreport to live preview [core] - 10https://gerrit.wikimedia.org/r/83371 (owner: 10Bartosz Dziewoński) [17:46:07] MatmaRex: moodbar is deployed, but not like you think :) [17:46:13] Well since werdna is at most sometimes online, best to ask ebernhardson or bsitu or kaldari. [17:46:16] MatmaRex: there is some architectural piece of it being used in other extensions or something [17:46:25] ebernhardson: heh. [17:47:05] thanks for the merge, RoanKattouw, gonna do the other one as well? :D [17:47:16] Yeah just reproducing that one so I can see what it looks like [17:48:08] (03CR) 10BryanDavis: [C: 032] Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 (owner: 10MarkTraceur) [17:48:10] RoanKattouw: want a screenshot? [17:48:12] (03CR) 10Legoktm: [C: 032] Add a required footer to all messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 (owner: 10Legoktm) [17:48:14] (03Merged) 10jenkins-bot: Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 (owner: 10MarkTraceur) [17:48:20] RoanKattouw: or just visit pl.wp and look at top of watchlist [17:48:20] (03Merged) 10jenkins-bot: Add a required footer to all messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 (owner: 10Legoktm) [17:48:25] Anyone got any ideas about what's happening with https://upload.wikimedia.org/wikipedia/commons/thumb/e/e8/Coat_of_Arms_of_Malo-les-Bains.svg/555px-Coat_of_Arms_of_Malo-les-Bains.svg.png - It displays old version of file even on varnish cache miss (Something wrong with deleting things in swift maybe?) [17:48:46] I got it [17:49:59] Yeah, I see it, it's offset to the right in master [17:50:02] This change fixes that [17:50:07] (03CR) 10Catrope: [C: 032] Remove margin from .fr-watchlist-pending-notice [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/83087 (owner: 10Bartosz Dziewoński) [17:51:33] (03PS1) 10Reedy: Comment out some overly verbose log entries [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/83422 [17:52:24] (03CR) 10Hashar: [C: 032] Comment out some overly verbose log entries [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/83422 (owner: 10Reedy) [17:52:25] (03Merged) 10jenkins-bot: Comment out some overly verbose log entries [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/83422 (owner: 10Reedy) [17:52:33] Reedy: it is in :) [17:54:57] RoanKattouw: thanks [18:00:17] (03PS1) 10Legoktm: trim() all of the input the user provides [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83424 [18:01:45] (03CR) 10Legoktm: [C: 032] trim() all of the input the user provides [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83424 (owner: 10Legoktm) [18:01:51] (03Merged) 10jenkins-bot: trim() all of the input the user provides [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83424 (owner: 10Legoktm) [18:04:13] RoanKattouw: re https://gerrit.wikimedia.org/r/#/c/83087/ - it seems that FlaggedRevs has no jenkins and needs manual merge [18:04:24] (03CR) 10Catrope: [V: 032] Remove margin from .fr-watchlist-pending-notice [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/83087 (owner: 10Bartosz Dziewoński) [18:04:28] Meh [18:04:30] Thanks for pointing that out [18:11:18] mwalker: springle is in the office now [18:11:31] mwalker: not IRC apparently [18:11:58] so if things go boom its not the end of the world? :p [18:12:05] right... [18:12:06] ;) [18:12:19] if you want him to look at it, come corner him here by the hammock :) [18:13:38] greg-g: mwalker: what's up? [18:13:57] ahh i'm not me... [18:14:21] haha [18:14:45] there he is [18:28:45] (03PS14) 10Jdlrobson: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 [18:28:46] (03PS1) 10Jdlrobson: Hygiene: Make user login form HTML more semantically correct [core] - 10https://gerrit.wikimedia.org/r/83429 [18:33:53] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:36:52] hasharSF: WTF? https://gerrit.wikimedia.org/r/#/c/83430/ [18:36:55] is there a way to profile api request on metawiki? [18:37:00] phpcs failed on me *deleting* a .php file [18:37:20] RoanKattouw: that is unfortunate :/ [18:37:24] <^d> I think phpcs is dumb and just looks for the delta :\ [18:37:51] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1285/console looks like some sort of shell script is choking on an empty parameter list or whatever [18:38:11] so /var/lib/jenkins/bin/git-changed-in-head php php5 inc sample [18:38:24] it is supposed to list all php like files that have been changed/added [18:38:30] in this case, none of them since it is a deletion [18:38:44] the shell is http://paste.openstack.org/show/46348/ [18:38:59] so whenever PHPCS_FILE variable is -z , we should skip [18:39:11] it is apparently set to something else :( [18:39:25] Could it be that changed-in-head returns the deleted file? [18:39:35] Presumably trying to run cs on a missing file will fail [18:39:47] hop because we don't care about running lint tests on delete files [18:40:01] there is something flawed in my logic somewhere. maybe it returns a string with a space/newlien :( [18:44:09] ahhh [18:44:18] soo [18:44:50] that is bash related apparently. The git-changed-inhead command returns an empty string which is supposed to be assigned to PHPCS_FILE [18:44:56] that is apparently an error in bash when running with -e [18:44:57] (03PS1) 10Robmoen: Cleanup whitespace issues and remove some overqualified and unused selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83431 [18:47:15] (03PS2) 10Robmoen: Cleanup whitespace issues and remove some overqualified and unused selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83431 [18:48:33] RoanKattouw: fixed. the shell script would return 1 whenever there is no change [18:49:34] (03PS6) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [18:49:57] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [18:49:58] hasharSF: Thanks! Trying to merge it again now [18:50:21] and the root cause is a grep command returning 1 :D [18:51:03] ^d: hey what's the procedure for adding new gerrit repos? I want to migrate our win8 app off of github [18:51:51] <^d> brion: https://www.mediawiki.org/wiki/Git/New_repositories, then me or Christian will make them for you :) [18:51:59] \o/ [18:52:15] ^d is my new search daemon [18:52:22] i just ask where pages are and i get links in return [18:53:00] <^d> Your own personal #lazyweb ;-) [18:53:04] (03PS7) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [18:54:14] (03PS1) 10Hashar: git-changed-in-head now always returns 0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/83435 [18:54:37] (03PS1) 10Raimond Spekking: Remove outdated translations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83436 [18:55:14] ok added to https://www.mediawiki.org/wiki/Git/New_repositories/Requests [18:55:16] thanks :D [18:55:31] (03CR) 10Raimond Spekking: [C: 032] Remove outdated translations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83436 (owner: 10Raimond Spekking) [18:55:54] (03Merged) 10jenkins-bot: Remove outdated translations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83436 (owner: 10Raimond Spekking) [18:57:10] (03CR) 10Jdlrobson: [C: 04-1] "Note: I'm going to move this code and css into core first after talking to Trevor and Timo. It will make life easier." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80519 (owner: 10Jdlrobson) [18:58:11] (03CR) 10Hashar: [C: 032] git-changed-in-head now always returns 0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/83435 (owner: 10Hashar) [18:59:06] (03CR) 10Hashar: [V: 032] git-changed-in-head now always returns 0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/83435 (owner: 10Hashar) [18:59:08] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:59:26] ^d: Have you been able to click the "+10" buttons in gerrit interfaces since the migration? I'm getting weird behaviour. [19:00:24] Oh, hrm, maybe it's just this file [19:01:17] ^d: http://paste.marktraceur.info/202 fuuuun [19:01:23] Seen on https://gerrit.wikimedia.org/r/#/c/78795/4/VisualEditor.i18n.php [19:01:29] (03PS2) 10Frédéric Wang: Make the MathJax mode use the MathTexvc PHP class [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 [19:03:33] (03CR) 10Krinkle: [C: 04-1] "Not rejecting anything right away, but I'd like to just mention that we should avoid duplicating this file. Perhaps just load it on top in" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:03:47] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/79948/ [19:05:06] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83437 [19:05:23] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83437 (owner: 10CSteipp) [19:05:41] greg-g, hi from Mountain View. :) I was wondering: is there any rough estimate date for mw 1.22? [19:06:05] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:07:02] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83438 [19:07:12] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83438 (owner: 10CSteipp) [19:07:17] (03CR) 10Krinkle: "Please provide a better commit subject ("update" and "refresh" don't say much of anything) and elaborate about why the previous values are" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80519 (owner: 10Jdlrobson) [19:09:25] (03CR) 10Krinkle: "Removed from Vector extension in commit I1672a830dc5e2c." [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Bartosz Dziewoński) [19:10:37] (03Merged) 10jenkins-bot: Update CentralAuth to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83437 (owner: 10CSteipp) [19:13:54] (03Merged) 10jenkins-bot: Update CentralAuth to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83438 (owner: 10CSteipp) [19:19:01] (03PS1) 10CSteipp: Revert "Update CentralAuth to master" [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83441 [19:19:11] (03PS1) 10CSteipp: Revert "Update CentralAuth to master" [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83442 [19:27:20] (03CR) 10CSteipp: [C: 032] Revert "Update CentralAuth to master" [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83441 (owner: 10CSteipp) [19:28:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(8 comments)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [19:30:26] (03Merged) 10jenkins-bot: Revert "Update CentralAuth to master" [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83441 (owner: 10CSteipp) [19:31:12] (03CR) 10CSteipp: [C: 032] Revert "Update CentralAuth to master" [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83442 (owner: 10CSteipp) [19:35:33] (03CR) 10Nikerabbit: "Hmm? Are you able to fix https://gerrit.wikimedia.org/r/64582 as well as it seems to work on almost the same code?" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [19:36:04] (03Merged) 10jenkins-bot: Revert "Update CentralAuth to master" [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83442 (owner: 10CSteipp) [19:43:22] (03PS3) 10Bartosz Dziewoński: ToC: Use display:table, so that we can behave like a block element [core] - 10https://gerrit.wikimedia.org/r/80435 (owner: 10TheDJ) [19:43:54] (03CR) 10Bartosz Dziewoński: [C: 032] "Alright, let's do this…" [core] - 10https://gerrit.wikimedia.org/r/80435 (owner: 10TheDJ) [19:48:25] (03Merged) 10jenkins-bot: ToC: Use display:table, so that we can behave like a block element [core] - 10https://gerrit.wikimedia.org/r/80435 (owner: 10TheDJ) [19:48:50] qgil: best to ask mark and markus :) [19:49:41] greg-g, ooops, you're right. Why can't I stop thinking about you? ;) [19:54:03] qgil: I know, it's hard [19:54:06] :) [19:56:26] (03CR) 10Nikerabbit: [C: 032] Comment text diff links in thread history should be protocol-relative [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/50714 (owner: 10Alex Monk) [19:56:29] (03Merged) 10jenkins-bot: Comment text diff links in thread history should be protocol-relative [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/50714 (owner: 10Alex Monk) [19:59:16] greg-g: am I free to deploy centralnotice madness? [19:59:50] mwalker: yes, just remove the madness [19:59:55] :) [20:00:02] qchris: do you have Git/New_repositories/Requests on your calendar? I have medium-priority thing that I'd like to jumpstart within the next week, if that's possible [20:00:09] I think that would only be possible with usage of nuclear arms [20:00:47] awight: Yes. I wanted to do them this evening :-) [20:02:07] qchris: thanks for letting me add to the pile! [20:15:16] (03PS1) 10Mwalker: Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83549 [20:15:54] (03CR) 10Reedy: "(1 comment)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 (owner: 10Matthias Mullie) [20:15:57] (03PS3) 10Reedy: (bug 53821) Update SpamBlacklist related code [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 (owner: 10Matthias Mullie) [20:16:01] (03CR) 10Reedy: [C: 032] (bug 53821) Update SpamBlacklist related code [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 (owner: 10Matthias Mullie) [20:16:04] (03Merged) 10jenkins-bot: (bug 53821) Update SpamBlacklist related code [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 (owner: 10Matthias Mullie) [20:16:07] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83549 (owner: 10Mwalker) [20:17:01] (03PS1) 10Mwalker: Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83550 [20:17:11] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83550 (owner: 10Mwalker) [20:20:21] (03Merged) 10jenkins-bot: Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83549 (owner: 10Mwalker) [20:21:54] (03CR) 10Qgil: "I think this might be a good idea, just not in the right place. See the full comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=538" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [20:22:21] (03CR) 10Mattflaschen: "Please "take" bug 46512 (" Merge the 'collapsiblenav' component of Vector extension into the Vector skin"), since it sounds like you plan " [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80519 (owner: 10Jdlrobson) [20:23:24] (03Merged) 10jenkins-bot: Updating CentralNotice to master for BannerClasses [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83550 (owner: 10Mwalker) [20:23:28] (03PS2) 10EBernhardson (WMF): I18N message cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 [20:26:22] (03PS1) 10CSteipp: Fix "old style" logout [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83551 [20:26:37] (03PS1) 10Siebrand: Test commit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/83552 [20:27:46] (03PS1) 10Reedy: PHP Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in MoodBarUtil.php on line 44 [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/83553 [20:31:28] (03CR) 10Mattflaschen: "I started working on this before I saw your commit https://gerrit.wikimedia.org/r/#/c/64582/ ." [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [20:32:15] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] "This all looks like quite reasonable cleanups. Were there any tools involved here(like jslint but for css?) to detect the problems so we " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83431 (owner: 10Robmoen) [20:32:22] greg-g, Jamesofur|away: centralnotice change deployed -- I should scap it too but I'm holding off for now to make sure that the 15minute banner cache window doesn't cause things to explode [20:32:38] greg-g: if all goes OK; may I scap after the LD window? [20:33:32] mwalker: yessir [20:33:41] awesome [20:35:54] (03PS2) 10Mattflaschen: Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 [20:36:10] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=45051 [20:36:53] greg-g: ok; looks like I'm stable -- so I'm calling this portion a success [20:39:11] mwalker: 8 PHP Fatal error: Call to undefined method Banner::bannerExists() in /usr/local/apache/common-local/php-1.22wmf16/extensions/CentralNotice/special/SpecialBannerLoader.php on line 98 [20:39:45] (03CR) 10jenkins-bot: [V: 04-1] Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [20:39:52] Reedy: I've been watching the exceptions log; nothing new has come up [20:39:59] Oh, transient? [20:40:04] I think so [20:41:41] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [20:43:18] (03PS1) 10Reedy: Can't override a public constructor with a protected one further down [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/83558 [20:43:22] Looks to be 14 minutes or so ago [20:43:55] ^ Anyone want to merge that EP commit? Otherwise I'm going to just self merge to fix a fatal [20:45:10] (03CR) 10Hashar: [C: 04-2] "Need to fetch using the git:// protocol which will be made available with https://gerrit.wikimedia.org/r/82625" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82603 (owner: 10Hashar) [20:45:21] (03CR) 10Yuvipanda: [C: 032] Can't override a public constructor with a protected one further down [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/83558 (owner: 10Reedy) [20:45:22] Reedy: done [20:45:24] Thanks [20:45:27] (03PS8) 10Bsitu: Archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 [20:45:31] * Reedy waits to see if it gets automerged [20:45:32] (03Merged) 10jenkins-bot: Can't override a public constructor with a protected one further down [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/83558 (owner: 10Reedy) [20:46:56] (03PS1) 10Reedy: Update EducationProgram to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83559 [20:47:49] (03CR) 10Qgil: [C: 031] "Good idea. The wiki page needs improvement but still, better than a red link by default." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [20:50:50] (03PS3) 10Mattflaschen: Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 [20:52:53] (03PS6) 10EBernhardson (WMF): Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 [20:53:26] (03PS4) 10Mattflaschen: Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 [20:55:52] (03CR) 10EBernhardson (WMF): "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81396 (owner: 10Aude) [20:57:49] (03CR) 10jenkins-bot: [V: 04-1] Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [20:58:54] (03PS5) 10Mattflaschen: Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 [21:02:04] (03CR) 10jenkins-bot: [V: 04-1] Fix async issues with postWithEditToken: [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [21:03:45] bawolff: https://commons.wikimedia.org/wiki/Campaign:wlm-in :D [21:15:53] (03CR) 10Mollywhite: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [21:19:35] (03PS6) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 [21:19:37] (03CR) 10jenkins-bot: [V: 04-1] Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [21:20:07] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Slightly better abide to MW jshint & coding standards; add docblock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83035 (owner: 10Matthias Mullie) [21:22:29] (03PS7) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 [21:23:37] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Adding Echo jobs to deferred update along with master wait [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 (owner: 10Bsitu) [21:24:24] (03CR) 10Mattflaschen: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [21:25:21] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Don't unhide when declining oversight [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/80545 (owner: 10Matthias Mullie) [21:25:40] (03CR) 10Mollywhite: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81560 (owner: 10Mollywhite) [21:28:05] ori-l: hmm I do not know if I can trust ganglia: this shows nothing: http://ganglia.wikimedia.org/latest/graph.php?r=hour&z=xlarge&title=ULS+Events+per+second&vl=&x=&n=&hreg%5B%5D=client-side&mreg%5B%5D=%5Eeventlogging.UniversalLanguageSelector_5729800%24>ype=line&glegend=hide&aggregate=1&embed=1&_=1378369049531 [21:28:38] jdlrobson: Ping me when you return from the meeting you're in, I'd like to chat briefly re BetaFeatures [21:31:07] Nikerabbit: yeah, EL integration with ganglia is still new; i'd keep an eye on the row count on db1047 for now. [21:31:33] ori-l: okay [21:32:43] Nikerabbit: i see events from fi.wiktionary.org and ru.wikitionary.org [21:33:06] but the rate is quite low -- i'm not sure the volume of data is enough to make for a very pretty graph :) [21:33:59] http://ganglia.wikimedia.org/latest/graph.php?r=week&z=xlarge&c=Miscellaneous+eqiad&h=client-side&jr=&js=&v=0&m=counts_eventlogging.UniversalLanguageSelector_5729800&vl=per+second [21:34:24] MatmaRex: If you has some time in the near-to-mid future I'd super-appreciate review on jshint fixes: https://gerrit.wikimedia.org/r/80945 [21:35:09] ori-l: do you see something from it.wikt too now? :) [21:35:38] yep! [21:35:47] though privacy policy prohibits me from identifying the user! :P [21:35:54] :D [21:36:07] I'm sure the new one will allow you to [21:36:28] marktraceur: +518, -548 :o [21:36:37] It's all pretty-much-nil changes [21:36:42] Just style and jshint [21:36:42] (03CR) 10Mattflaschen: [C: 031] "Whitespace errors are fixed. I didn't try to run the test, but we might as well correct this in my opinion." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83374 (owner: 10Rahul21) [21:36:58] I didn't change any functionality [21:37:33] But merging three patches brings jshint to 0 [21:37:41] Agh, beurk, I need to rebase [21:38:41] ugh, I've been trying to compile rsvg, and its just not working for me [21:42:09] (03CR) 10Reedy: [C: 032 V: 032] Update EducationProgram to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83559 (owner: 10Reedy) [21:44:26] ori-l: cool [21:44:30] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 (owner: 10EBernhardson (WMF)) [21:45:11] bawolff: welcome…… to glib dependency hell [21:46:10] brion: I just ran ./configure && make. failed due to syntax error in Makefile [21:46:20] ewwwww [21:46:25] that's not pretty [21:46:35] I thought the whole point of ./configure was that they were autogenerated [21:46:40] ugh [21:46:46] bawolff: apt-get builddep? [21:46:59] build-dep rather [21:48:15] bawolff: unless the dependencies have changed since the last packaged version, that should just work [21:48:19] (03CR) 10Springle: [C: 031] Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [21:48:52] Well part of the problem is that it depends on packages that seem to conflict with current packages I use [21:49:19]