[00:27:47] jdlrobson_: what's your staff username? [00:40:02] (03PS1) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [00:43:33] (03CR) 10jenkins-bot: [V: 04-1] mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [00:48:45] (03CR) 10Jforrester: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [00:53:33] (03PS1) 10MarkTraceur: Add unit tests for the hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83051 [00:53:47] Christ, is Gerrit still broken, really [00:54:35] i still can't upload my commits :/ [00:54:45] Agreed [00:54:52] Maybe this is a sign that Mark should go the eff home [00:55:01] * marktraceur does [01:15:40] (03PS1) 10Shirayuki: Replace single by double-quotation marks [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/83053 [01:43:40] (03PS2) 10Adamw: Illustrate two ways to crash-land namespacing [core] - 10https://gerrit.wikimedia.org/r/61174 [01:44:03] (03PS1) 10Matthias Mullie: Boilerplate code to allow adding editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 [01:45:14] (03Abandoned) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 (owner: 10Matthias Mullie) [01:54:53] (03PS4) 10Krinkle: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 [01:54:54] (03PS2) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [01:54:55] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [01:55:23] (03CR) 10Krinkle: "Removed redundant $message parameter in test." [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [01:59:33] (03CR) 10jenkins-bot: [V: 04-1] mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [02:03:26] (03PS21) 10Adamw: Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [02:04:01] (03PS22) 10Adamw: Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [02:09:13] (03PS1) 10Divec: jquery.byteLength: Improve documentation and tests [core] - 10https://gerrit.wikimedia.org/r/83057 [02:11:56] (03CR) 10jenkins-bot: [V: 04-1] jquery.byteLength: Improve documentation and tests [core] - 10https://gerrit.wikimedia.org/r/83057 (owner: 10Divec) [02:16:39] (03PS3) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [02:17:44] (03CR) 10Krinkle: "Fixed js comments. Apparently jsduck is not smart enough to guess the identifier when using the "var /* .. continued .. */ foo = 123, bar" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [02:18:24] (03PS4) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [02:18:47] (03CR) 10Krinkle: "Edited commit message:" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [02:21:27] (03CR) 10jenkins-bot: [V: 04-1] mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [02:29:56] (03PS2) 10Matthias Mullie: Boilerplate code to allow adding editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 [02:30:01] (03PS5) 10Krinkle: mw.Title: Rewrite from scratch (porting logic from Title.php) [core] - 10https://gerrit.wikimedia.org/r/83047 [02:30:16] (03PS23) 10Adamw: Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [02:30:29] (03CR) 10Adamw: "See also bug 53835" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [02:30:31] i can't upload my commits either :( [02:48:47] (03PS1) 10Mwjames: Improve code coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83058 [02:51:37] (03CR) 10Mwjames: [C: 032] Improve code coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83058 (owner: 10Mwjames) [02:53:01] (03Merged) 10jenkins-bot: Improve code coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83058 (owner: 10Mwjames) [03:10:07] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #308: FAILURE in 8 min 37 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/308/ [03:31:40] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #255: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/255/ [03:37:20] (03PS5) 10AndyRussG: Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 [03:37:21] (03CR) 10jenkins-bot: [V: 04-1] Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 (owner: 10AndyRussG) [03:43:39] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/83047 (owner: 10Krinkle) [03:49:14] (03CR) 10MarkTraceur: "For the record, I'm trying to upload a new patchset, but Gerrit is throwing a gorram tantrum about it and not letting me. I'll come back t" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [04:01:07] (03PS6) 10AndyRussG: Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 [04:01:12] (03CR) 10jenkins-bot: [V: 04-1] Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 (owner: 10AndyRussG) [04:04:09] (03CR) 10Santhosh: [C: 04-1] "1. User is a translator, logged in, visits home page, for MediaWiki, I see x% translated, y% proofread in the project tile." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [04:06:52] (03PS7) 10AndyRussG: Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 [04:07:47] Yippie, build fixed! [04:07:48] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #223: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/223/ [04:16:24] (03PS1) 10Mwjames: Add @covers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83059 [04:19:02] (03CR) 10Mwjames: [C: 032] Add @covers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83059 (owner: 10Mwjames) [04:20:26] (03Merged) 10jenkins-bot: Add @covers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83059 (owner: 10Mwjames) [04:33:33] Yippie, build fixed! [04:33:34] Project browsertests-en.wikipedia.org-linux-chrome build #297: FIXED in 5 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/297/ [04:39:38] Yippie, build fixed! [04:39:38] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #156: FIXED in 4 min 42 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/156/ [04:43:11] (03PS1) 10Pastakhov: Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/83061 [04:45:42] (03Abandoned) 10Pastakhov: Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/83061 (owner: 10Pastakhov) [04:50:07] Yippie, build fixed! [04:50:07] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #256: FIXED in 6 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/256/ [04:50:52] Yippie, build fixed! [04:50:52] Project browsertests-sandbox.translatewiki.net-linux-chrome build #139: FIXED in 44 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/139/ [04:50:55] Yippie, build fixed! [04:50:55] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #244: FIXED in 6 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/244/ [04:51:39] (03PS1) 10Pastakhov: Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83062 [04:51:40] Yippie, build fixed! [04:51:40] Project browsertests-sandbox.translatewiki.net-linux-firefox build #169: FIXED in 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/169/ [04:52:04] Yippie, build fixed! [04:52:04] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_6 build #114: FIXED in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_6/114/ [04:52:34] (03CR) 10Pastakhov: [V: 032] Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83062 (owner: 10Pastakhov) [04:52:49] Yippie, build fixed! [04:52:50] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_7 build #114: FIXED in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_7/114/ [04:53:11] Yippie, build fixed! [04:53:12] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_8 build #113: FIXED in 1 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_8/113/ [04:54:17] Yippie, build fixed! [04:54:17] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_9 build #113: FIXED in 1 min 27 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_9/113/ [04:56:38] (03Abandoned) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [04:57:37] (03CR) 10Pastakhov: "add blocks for operator 'if'" [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83062 (owner: 10Pastakhov) [04:57:55] (03CR) 10Pastakhov: [C: 032] Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83062 (owner: 10Pastakhov) [04:58:01] (03Merged) 10jenkins-bot: Import from commit Ia8b2150cd328a546e3ccb663d5b48a245dafe132 [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83062 (owner: 10Pastakhov) [04:59:06] (03PS1) 10Legoktm: Add a README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83063 [04:59:38] Elsie: ^ [05:03:01] (03PS1) 10Legoktm: Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83064 [05:03:39] (03Abandoned) 10Legoktm: Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 (owner: 10Legoktm) [05:05:19] (03PS2) 10Legoktm: Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83064 [05:13:47] wmf-selenium-bot is pretty noisy [05:31:07] Yippie, build fixed! [05:31:07] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #406: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/406/ [05:32:40] (03CR) 10Nikerabbit: "This patch does not change the behavior of project tiles. This patch affects only the blue stats tiles and the rankings in the translator " [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [05:37:32] (03PS1) 10Legoktm: Set 'use strict' for all JavaScript files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83065 [05:37:33] (03CR) 10jenkins-bot: [V: 04-1] Set 'use strict' for all JavaScript files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83065 (owner: 10Legoktm) [05:38:57] (03CR) 10Legoktm: "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 (owner: 10Legoktm) [05:45:10] (03CR) 10Nikerabbit: "You should try optipng or other new alternatives for possibly better compression." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [05:49:03] Yippie, build fixed! [05:49:03] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #430: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/430/ [06:06:50] (03CR) 10Nikerabbit: [C: 04-1] "(12 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 (owner: 10Matthias Mullie) [06:27:04] Yippie, build fixed! [06:27:04] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #20: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/20/ [06:39:55] Yippie, build fixed! [06:39:55] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #20: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/20/ [07:08:17] (03PS5) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [08:27:18] (03CR) 10Matmarex: "I pushed them through pngcrush with settings cranked up to the max (-reduce -l 9 -brute) and made sure they're saved as grayscale with alp" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [08:34:17] (03PS5) 10MaxSem: Change all glyphs to have a transparent background [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [08:34:43] (03CR) 10MaxSem: "Better compression." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [08:40:13] (03PS6) 10Matmarex: Change all glyphs to have a transparent background [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [08:40:30] (03CR) 10Matmarex: "Hardcore, thanks Max." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [09:00:58] (03PS1) 10Shabbir Limdiwala: changed in test1.php file Signed-off-by: Bhavin Patel [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/83072 [09:07:35] (03Abandoned) 10Shabbir Limdiwala: changed in test1.php file Signed-off-by: Bhavin Patel [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/83072 (owner: 10Shabbir Limdiwala) [09:20:47] (03PS1) 10Shabbir Limdiwala: Changed in test1.php Signed-off-by: Bhavin Patel [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/83073 [09:23:42] (03CR) 10Shabbir Limdiwala: "okay" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/83073 (owner: 10Shabbir Limdiwala) [09:29:23] (03PS1) 10Matmarex: collapsibleTabs: Minor code style fixes [core] - 10https://gerrit.wikimedia.org/r/83074 [09:29:51] (03CR) 10jenkins-bot: [V: 04-1] collapsibleTabs: Minor code style fixes [core] - 10https://gerrit.wikimedia.org/r/83074 (owner: 10Matmarex) [09:30:11] (03PS2) 10Matmarex: collapsibleTabs: Minor code style fixes [core] - 10https://gerrit.wikimedia.org/r/83074 [09:32:41] (03CR) 10Netbrain: "We are building databases with thousands of pages that all have coordinates associated with them." [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82219 (owner: 10Netbrain) [09:37:32] (03PS1) 10Pginer: CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 [09:37:38] (03CR) 10jenkins-bot: [V: 04-1] CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [09:39:09] (03PS2) 10Nikerabbit: CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [09:39:12] (03CR) 10jenkins-bot: [V: 04-1] CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [09:50:31] (03PS1) 10Nikerabbit: Rename extension entry point to match convention [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83077 [09:53:21] (03PS3) 10Nikerabbit: CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [09:53:25] (03CR) 10jenkins-bot: [V: 04-1] CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [09:57:01] (03CR) 10Pginer: [C: 032] Rename extension entry point to match convention [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83077 (owner: 10Nikerabbit) [09:57:09] (03Merged) 10jenkins-bot: Rename extension entry point to match convention [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83077 (owner: 10Nikerabbit) [10:01:59] (03PS4) 10Nikerabbit: CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [10:02:38] (03CR) 10Nikerabbit: [C: 032] CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [10:02:42] (03Merged) 10jenkins-bot: CSS fixes for MainPage [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83076 (owner: 10Pginer) [10:04:28] (03PS1) 10Nikerabbit: HTML changes to make styling with CSS easier [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83078 [10:11:28] (03PS1) 10Nikerabbit: Add logout link to company login link [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83079 [10:14:01] (03PS1) 10Pastakhov: Add 'else' operator for 'if' with blocks [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83080 [10:18:20] (03PS2) 10Pginer: HTML changes to make styling with CSS easier [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83078 (owner: 10Nikerabbit) [10:20:01] qchris: thanks for looking into the bug :) [10:20:20] legoktm: Well. Actually I am not much use here :-( [10:20:43] But it looks like a serious problem. [10:20:52] yeah :/ [10:20:56] I hope demon found the solution over night :-) [10:21:22] are you still not able to push to gerrit? [10:21:41] YuviPanda: Pushing does not work as well? [10:21:47] no, wfm [10:21:54] Oh. Ok :-) [10:21:58] i thought legoktm was telling me it wasn't working for him [10:22:04] I just ended up checking out gerrit/master and basing my commits off them [10:22:21] ah [10:22:22] ok [10:22:25] yeah, i couldn't submit a new patchset for https://gerrit.wikimedia.org/r/#/c/82799/ [10:22:36] (03CR) 10Nikerabbit: [C: 032] HTML changes to make styling with CSS easier [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83078 (owner: 10Nikerabbit) [10:22:41] so i just rebased it locally, and submitted it under a new change id [10:22:44] (03Merged) 10jenkins-bot: HTML changes to make styling with CSS easier [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83078 (owner: 10Nikerabbit) [10:23:38] Yes, it depends on your change that is marked 'Merged' in gerrit, but effectively has not been merged on master. [10:23:46] Glad to see you managed to work around that. [10:24:39] (03CR) 10Pastakhov: [C: 032] Add 'else' operator for 'if' with blocks [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83080 (owner: 10Pastakhov) [10:24:44] (03Merged) 10jenkins-bot: Add 'else' operator for 'if' with blocks [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/83080 (owner: 10Pastakhov) [10:24:50] yup [10:25:08] luckily this was a super trivial commit that got lost :P [10:25:57] Ideally, no commit get's dropped. Not even the trivial one's :-) [10:26:13] s/one's/ones/ [10:26:36] s/get's/gets/ [10:26:43] * qchris has to learn to type :-( [10:27:42] :D [10:29:13] (03CR) 10Siebrand: [C: 032] Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83064 (owner: 10Legoktm) [10:29:21] (03Merged) 10jenkins-bot: Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83064 (owner: 10Legoktm) [10:29:58] (03PS2) 10Legoktm: Set 'use strict' for all JavaScript files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/83065 [10:31:27] (03CR) 10Siebrand: [C: 032] Replace single by double-quotation marks [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/83053 (owner: 10Shirayuki) [10:31:49] (03Merged) 10jenkins-bot: Replace single by double-quotation marks [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/83053 (owner: 10Shirayuki) [10:34:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [10:35:48] (03CR) 10Siebrand: "Thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna) [10:40:42] (03CR) 10Siebrand: [C: 04-1] "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 (owner: 10EBernhardson (WMF)) [10:47:43] (03PS1) 10Nikerabbit: Make the project tiles go to project page if one exists [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/83081 [10:59:22] (03CR) 10Nikerabbit: [C: 032] "Okay, this looks good to me." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [10:59:30] (03Merged) 10jenkins-bot: Change all glyphs to have a transparent background [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [11:02:56] @notify ^d [11:02:56] I'll let you know when I see ^d around here [11:03:44] (03CR) 10Nikerabbit: [C: 032] collapsibleTabs: Minor code style fixes [core] - 10https://gerrit.wikimedia.org/r/83074 (owner: 10Matmarex) [11:06:39] (03PS1) 10Yuvipanda: Set red asterisk on field labels onlf it is marked required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 [11:07:04] (03Merged) 10jenkins-bot: collapsibleTabs: Minor code style fixes [core] - 10https://gerrit.wikimedia.org/r/83074 (owner: 10Matmarex) [11:07:12] (03CR) 10Springle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [11:12:49] (03PS5) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [11:14:53] (03CR) 10Dan-nl: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [11:24:51] (03PS1) 10Nemo bis: Clarify "unknown gender" option is a non-answer and resort [core] - 10https://gerrit.wikimedia.org/r/83083 [11:34:05] (03CR) 10Matmarex: "I would include the parens directly in the message." [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [11:48:44] (03CR) 10Nemo bis: "MatmaRex, what other examples we have in core? We have an (All) somewhere; and (Main) in Special:Search which uses the parentheses message" [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [11:56:45] (03CR) 10Matmarex: "According to a quick grep there are 44 such messages: http://pastebin.com/3LNE5ksU" [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [11:59:00] (03PS1) 10Matmarex: Move wikiprintable.css styles from core [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/83085 [12:00:03] (03CR) 10Matmarex: "Meh, I'll just fix it there. :P https://gerrit.wikimedia.org/r/#/c/83085/" [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Matmarex) [12:02:44] (03PS2) 10Matmarex: Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 [12:06:16] (03PS3) 10Matmarex: Remove 'mediawiki.legacy.wikiprintable' module [core] - 10https://gerrit.wikimedia.org/r/80716 [12:06:57] (03CR) 10Matmarex: "Rebased, fixed release notes and some comments." [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Matmarex) [12:07:39] (03CR) 10Matmarex: "UNTESTED. I hope it works." [extensions/Nostalgia] - 10https://gerrit.wikimedia.org/r/83085 (owner: 10Matmarex) [12:25:20] (03PS2) 10Yuvipanda: Set red asterisk on field labels onlf it is marked required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 [12:30:59] (03CR) 10Euvl: "yeah I deleted LingoApprovedRevs.php and icon is needed for another feature, just cant understand how it got in this patch, as far as I de" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [12:49:27] (03CR) 10MZMcBride: "Why the resort?" [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [12:52:19] (03CR) 10Nemo bis: "MZMcBride, see bug 53834 and comment there please." [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [12:53:28] (03CR) 10MZMcBride: "Nemo bis, if you looked at bug 53834, you'd see that I already looked for an explanation there and commented." [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [13:06:21] (03PS1) 10Matmarex: Remove margin from .fr-watchlist-pending-notice [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/83087 [13:06:24] ^ trivial [13:08:51] (03CR) 10Nemo bis: "MZMcBride, wasn't in my inbox yet; good, it can continue there then." [core] - 10https://gerrit.wikimedia.org/r/83083 (owner: 10Nemo bis) [13:33:00] (03PS6) 10saper: bug 44798: Don't abuse comma-separator message [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/52237 [13:35:44] (03PS7) 10saper: bug 44798: Don't abuse comma-separator message [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/52237 [13:40:17] (03PS8) 10saper: bug 44798: Don't abuse comma-separator message [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/52237 [14:04:08] qchris: hey. any idea why this is failing? https://gerrit.wikimedia.org/r/#/c/82869/ [14:04:45] (do i remember correctly that you know something about jenkins/zuul?) [14:04:46] DanielK_WMDE: That url works for me. [14:04:54] Oh the tests. [14:05:00] qchris: yes, but there's a jenkins failure. without an error message. [14:05:28] DanielK_WMDE: I know next to nothing about that :-( Sorry. [14:06:12] hm. when hashar isn't around, who can look into this? [14:06:18] the tests work for me locally [14:43:44] (03PS1) 10Shirayuki: Fix implode() parameter [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/83096 [14:54:23] (03PS3) 10Anomie: Return normalized file name on warning "exists-normalized" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [14:54:24] (03CR) 10Siebrand: "Quim, can you create a bug and link that bug from there. That creates some visibility, and a location to discuss that's a bit more easily " [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [14:54:46] (03CR) 10Anomie: [C: 032] "PS3: Rebased RELEASE-NOTES-1.22" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [14:59:18] (03Merged) 10jenkins-bot: Return normalized file name on warning "exists-normalized" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [15:22:47] need help adding the Logo of the Hebrew Wikivoyage (currently the English logo is displayed in all the pages of the Hebrew Wikivoyage) [15:32:31] WikiJunkie: file a bug? [15:32:37] ah, i see you've alreadyfiled one [15:32:45] just filled it [15:33:54] WikiJunkie: someone competent and capable of making changes will probably look at it soon (but possibly after the weekend) [15:34:09] WikiJunkie: also, it seems there's a little graphical glitch on your logo [15:34:26] yes, I am fixing it right now [15:34:33] http://i.imgur.com/VlUnxVP.png part of the blue thing is "chipped off" [15:42:50] (03CR) 10Physikerwelt: "(3 comments)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [15:45:45] (03CR) 10Physikerwelt: "Can you change the mathjax loader so that it only processes the math elements that are marked for being processed with mathjax?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [15:48:05] (03PS17) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [16:06:32] (03PS7) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [16:22:31] (03PS2) 10BryanDavis: Raise exception in File::getHander() on error. [core] - 10https://gerrit.wikimedia.org/r/83010 [16:24:03] (03CR) 10BryanDavis: "Possibly better commit message & added @throws phpdoc." [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis) [16:25:02] (03CR) 10Physikerwelt: "Maybe one could use that to some degree. However I think it would be difficult to translate" [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [16:25:21] (03PS6) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 [16:33:30] (03PS2) 10MarkTraceur: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 [16:33:37] (03PS3) 10MarkTraceur: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 [16:33:38] (03PS1) 10MarkTraceur: Use isset, not array_key_exists [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 [16:33:59] Muahahaha [16:34:16] i want a demon head on a stick! [16:34:35] really, i just want ^d's help fixing gerrit so i can get work done [16:35:11] <^d> cscott: Soooo, I know what's wrong (sorta), just trying to figure out how to fix it. [16:35:15] (03CR) 10Physikerwelt: "@Frédéric: does that needs to be changed?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/64523 (owner: 10TheDJ) [16:35:15] <^d> All the data's intact :) [16:35:28] that's always good to hear [16:35:40] did you see my comment in https://bugzilla.wikimedia.org/show_bug.cgi?id=53836 ? [16:35:43] <^d> Yep. [16:35:47] gerrit/master seems to be two days behind origin/master [16:35:56] among other things [16:36:37] anyhow, if you're working on it i'll go back to my first plan, which is to pretend i have no internet and hack disconnected for the day. [16:36:53] Yay for git [16:36:57] <^d> :) [16:38:01] <^d> Now to find someone who knows a thing or two about git to try and fix this ;-) [16:39:56] Ugh, thanks jeremyb, timezones annoy me [16:40:54] * YuviPanda accidentally delets the etherpad labs instance [16:40:57] *deletes [16:41:08] (not actually) [16:48:17] (03CR) 10BryanDavis: "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [16:51:03] (03CR) 10Physikerwelt: "Hi, maybe you should add more reviewers who can submit the code?" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [16:51:27] (03CR) 10BryanDavis: [C: 032] "I think the additional benefit of isset() when you can use it is that the code is more readable. The yoda speak order of args in array_key" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 (owner: 10MarkTraceur) [16:51:53] bd808: Awesome - that one depends on the jobqueue one, though [16:52:22] (03PS4) 10MarkTraceur: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 [16:52:30] (03PS2) 10MarkTraceur: Use isset, not array_key_exists [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 [16:56:01] (03CR) 10Physikerwelt: [C: 031] "I'm not a fan of this option. However, since I don't use MathJax by myself I don't want to block this option." [extensions/Math] - 10https://gerrit.wikimedia.org/r/64527 (owner: 10TheDJ) [17:03:50] (03CR) 10BryanDavis: [C: 032] "\o/ TESTS!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83051 (owner: 10MarkTraceur) [17:03:51] (03Merged) 10jenkins-bot: Add unit tests for the hooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83051 (owner: 10MarkTraceur) [17:04:06] <3 tests [17:04:31] I should probably have Jenkins run them thar tests [17:06:45] (03CR) 10Matthias Mullie: "(11 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 (owner: 10Matthias Mullie) [17:06:51] (03PS3) 10Matthias Mullie: Boilerplate code to allow adding editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 [17:12:54] marktraceur: like tests? wanna merge some? [17:13:11] * MatmaRex points marktraceur to https://gerrit.wikimedia.org/r/#/c/74969/ [17:14:14] Ooh ooh [17:14:36] This is *so* not what I should be doing but I'm OK with that [17:14:46] (03CR) 10BryanDavis: [C: 032] "Doing my part to keep BetaFeatures on track." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:14:47] (03CR) 10jenkins-bot: [V: 04-1] Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:15:34] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 (owner: 10Matthias Mullie) [17:15:37] (03PS4) 10Matthias Mullie: Boilerplate code to allow adding editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83056 [17:17:08] (03PS5) 10MarkTraceur: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 [17:17:18] bd808: Sorry, rebased [17:17:58] (03PS3) 10MarkTraceur: Use isset, not array_key_exists [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 [17:18:35] (03CR) 10BryanDavis: [C: 032] Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:18:37] (03Merged) 10jenkins-bot: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:18:46] Woot [17:19:02] Achievement unlocked, merged patch with "hopefully" in the summary [17:19:47] I'm still working on my "crash the site" achievement. :) [17:20:02] bd808: Don't worry, you'll get there [17:20:09] * bd808 nods [17:21:07] (03PS3) 10Yuvipanda: Set red asterisk on field labels only it is marked required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 [17:21:35] YuviPanda: Missing an "if" there maybe [17:21:41] bd808: me too, haven't crashed anything yet. [17:21:54] marktraceur: eugh, my english! [17:21:56] We should totally team up! [17:22:14] <^d> Real men crash the site 3 times before breakfast. [17:22:15] (03CR) 10BryanDavis: [C: 032] Use isset, not array_key_exists [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 (owner: 10MarkTraceur) [17:22:17] (03Merged) 10jenkins-bot: Use isset, not array_key_exists [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83107 (owner: 10MarkTraceur) [17:22:47] ^d: Shaaaaame [17:23:03] bd808: hah! twice I've thought I had crashed the site, turns out it was just caching effects that went away after a few minutes (and some touches) [17:23:20] Wait, were those both UW patches? [17:23:59] marktraceur: yeah, the ones where we needed to manually refresh the JS cache [17:24:04] Heh [17:24:07] but they weren't UW bugs, so I can't claim responsibility. [17:24:13] so I still haven't crashed the site [17:24:25] YuviPanda: UW development: Waaaay more exciting than mobile. :P [17:24:49] Obvious troll is obvious. [17:24:57] marktraceur: so when yesterday's deployment went out, all the mw.ui styles were missing. I thought I had broken it, turns out it was all Elsie's doing. [17:25:04] so not even that for me yet. sigh. [17:25:18] Elsie: Are you even on your own blame wheel? [17:25:34] marktraceur: but hey, at least I've had a 'I will do everything to make sure this does not get deployed!' bug opened (and closed!) [17:26:26] Heh [17:26:30] It's a start [17:26:53] marktraceur: true, true [17:27:10] marktraceur: {{done}} now with reviews‽ [17:27:19] (03PS4) 10Yuvipanda: Set red asterisk on field labels only if it is marked required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83082 [17:27:46] marktraceur: I think two of the four patchsets for that patch were to attempt to fix the english on the commit message. another one was to change a bug number since I had opened a duplicate bug. [17:30:08] bd808: Marry me. Yes, you're done [17:30:21] * marktraceur never gets fast code review :P [17:30:47] YuviPanda: Just get rid of the ASCII art duck [17:31:24] marktraceur: :P [17:31:30] marktraceur: think you can merge that, btw? [17:31:51] Maaaaybe [17:32:17] I have to destroy an EPL instance in thirty minutes, and I'm ostensibly reviewing MatmaRex's patch adding qunit testing [17:33:02] ^d: https://gerrit.wikimedia.org/r/#/c/81272/ is still a permissions error for me [17:33:21] I'll check with the author that it's not a draft though [17:33:25] <^d> It's not. [17:34:22] marktraceur: mmm ok [17:41:50] MatmaRex: Sanity check, these elements all get deleted after the test is done, so there's no need to use .one instead of .on, correct? [17:42:19] This is one of my frequent "gee, it'd be nice, but probably not necessary...meh, if there are no other issues it's fine" [17:42:23] ...things [17:43:14] marktraceur: yes, #qunit-fixture is .empty()-ied [17:43:23] KK [17:43:35] * marktraceur downloads patch for testing [17:43:37] marktraceur: i kind of purposefully used .on(), as i know exactly how many times the events are supposed to fire - if they fire more often, that's a bug [17:43:52] marktraceur: (a bug i found with this test and fixed in the dependency) [17:44:42] Indeed [17:44:49] Arright, looks good [17:45:02] marktraceur: Where is #qunit-fixture emptied? [17:46:00] Krinkle: Ask MatmaRex....the events definitely don't fire again, so it seems fine [17:46:41] It looks like I'll need to merge the dependency too, if I want these tests [17:47:34] Krinkle: Are you worried about the premise? I think it doesn't matter if it's emptied, it just matters that the events don't fire more than once - which MatmaRex is right about, the tests would catch that, and it would be a sign of something being pretty wrong [17:48:02] k [17:49:10] (03CR) 10MarkTraceur: [C: 032] "Thanks, MatmaRex!" [core] - 10https://gerrit.wikimedia.org/r/82615 (owner: 10Matmarex) [17:50:01] * marktraceur waits for jenkinss [17:50:06] s/s$// [17:50:48] Just making sure you don't rely on it being empty. QUnit indirectly triggers .clean and cleanData which clear all data and events from memory and binding, then empties it, and re-parses the original HTML so it does end up non-empty, but with the original elements again without any data/events. [17:50:56] (03PS1) 10Liangent: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 [17:51:15] ready to be filled again with new elements for another test and events etc. [17:51:30] (03PS2) 10Liangent: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 [17:51:37] (03Restored) 10Liangent: Add plain semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 (owner: 10Liangent) [17:52:28] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Only trigger custom events once per collapsible [core] - 10https://gerrit.wikimedia.org/r/82615 (owner: 10Matmarex) [17:53:25] Krinkle: The tests don't rely on it being empty, I just wanted to make sure he didn't mean "one" when he typed "on" :) [17:53:29] (03CR) 10jenkins-bot: [V: 04-1] Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent) [17:54:16] Krinkle: i don't realy on it being empty, but i was under impression that the elements i insert in one test are no longer there in another one - is it not the case? [17:54:35] (i don't rely on that either, so it's cool, just wondering) [17:55:31] MatmaRex: Anything that happens to the fixture during the execution of a QUnit.test gets wiped out before the next test starts. [17:55:38] That is correct. [17:55:45] okay, good [17:55:52] It get's reset to a copy of the original contents of #qunit-fixture [17:55:59] yeah, i now see that it contains "test markup, will be hidden" [17:56:15] (03CR) 10MarkTraceur: [C: 032] "And thanks again, MatmaRex! :)" [core] - 10https://gerrit.wikimedia.org/r/74969 (owner: 10Matmarex) [17:56:24] thanks marktraceur [17:56:46] Right, we can have more in there by default if we find ourselves adding the same thing in many tests, though I personally recommend keeping the fixture empty by default so that tests are more flexible and don't rely on the index.html [17:56:48] MatmaRex: You rock! Thanks for bothering me, I like merging things. [17:57:12] haha [17:57:15] especially because in MW that fixture is generated by SpecialJavaScriptTest, so it's quite nasty to mess with that [17:57:22] well, i have a lot of things to be merged, by the way [17:57:31] i am currently winning https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner in mediawiki/core [17:58:14] (03CR) 10GWicke: [C: 032] Add plain semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 (owner: 10Liangent) [17:58:23] "winning" is a funny word to use [17:58:43] MatmaRex: I have a lot of stuff on my "when I'm bored" todo list, but I'll keep your patchsets in mind [17:58:58] Oh my goodness it's almost time to kill etherpad.wmflabs.org! [17:59:03] * marktraceur is excited [17:59:14] * marktraceur gets out his service-stabbing knife [17:59:38] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Tests for collapsible ,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 (owner: 10Matmarex) [17:59:48] (03PS2) 10Matthias Mullie: Slightly better abide to MW jshint & coding standards; add docblock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83035 [18:00:40] * marktraceur stabs [18:01:16] (03Merged) 10jenkins-bot: Add plain semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 (owner: 10Liangent) [18:02:13] ^d: i'm still having gerrit issues. RoanKattouw seemed to think they should be fixed now. [18:02:26] cscott: We're looking at that error [18:02:29] <^d> No, we haven't fixed everything :) [18:02:37] The hash that you quoted as missing isn't actually missing [18:02:43] It's patchset 2 of https://gerrit.wikimedia.org/r/#/c/83048/ [18:02:58] What did you do to get that error? [18:03:17] i get a "the page your requested was not found, or you do not have permission to view this page" when I try to visit https://gerrit.wikimedia.org/r/#/c/83048/ [18:03:29] can you give me the summary of the 83048 patch? [18:04:12] I'm not getting the error. You might be getting a cached error [18:04:16] 83048 is "Extend SurfaceToolbar into TargetToolbar" [18:04:23] it's quite likely it's one of the patches missing from the head of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor (but which is present on https://git.wikimedia.org/git/mediawiki/extensions/VisualEditor.git ) [18:04:46] It's not a merged patch [18:04:47] RoanKattouw: you might have to be me in order to 'not have permission to view this page' [18:05:07] It may also go away after a bit [18:05:15] When we fixed your change, it took like 5 mins for it to start working for me [18:05:20] We suspect caching is to blame [18:05:26] i've been getting those 'not have permission' errors on various patches since yesterday [18:05:41] but i'll cross my fingers and see [18:05:45] Yeah, it looks like some patches that were submitted right before the cutover were present on manganese but not on ytterbium [18:05:52] We copied your commit over [18:06:01] no, that's not the problem [18:06:11] You were saying the heads differ? [18:06:16] or not the only problem, since i could see patches which you couldn't, and vice cersa [18:06:17] (03Abandoned) 10Physikerwelt: Enabling MathJaX in LaTeXML rendering mode except for Firefox [extensions/Math] - 10https://gerrit.wikimedia.org/r/69298 (owner: 10Physikerwelt) [18:06:24] RoanKattouw: yes, the master branch differs [18:06:48] Welcome to a world without etherpad.wmflabs.org, everyone [18:06:52] Is git.wm.o still hitting the old server perhaps? [18:07:13] I can see the head on manganese being feff1fbc24b6d3e425f9b9b035b38d26954a73d4 and on ytterbium it's 47545a5d6fb2c1701fa3ad37eace5965df143ddc [18:07:24] RoanKattouw: you should be able to reproduce with the recipe in https://bugzilla.wikimedia.org/show_bug.cgi?id=53836#c2 [18:07:28] The former being an ancestor of the latter so that's expected [18:07:29] RoanKattouw: yes, it [18:07:53] RoanKattouw: yes, it's the feff head which is plaguing me. that's also the head of gerrit/master. [18:08:07] @notify swalling [18:08:07] I'll let you know when I see swalling around here [18:08:15] remotes/gerrit/master, that is. and "git fetch gerrit" doesn't update it. [18:08:16] @seen swalling [18:08:16] MatmaRex: I have never seen swalling [18:08:20] cscott: What's your git remote -v ? And does it fix itself if you run git fetch gerrit? [18:08:22] ughhh. [18:08:24] what. [18:08:24] It's StevenW [18:08:27] :) [18:08:30] D: [18:08:38] hi, StevenW :D [18:09:12] hey [18:09:13] cscott: https works correctly for me, it gives me the right head [18:09:16] RoanKattouw: my 'git remote -v' is http://paste.debian.net/36113/ [18:09:26] I wonder if your machine has cached the DNS resolution of gerrit.wm.o or something weird like that? [18:09:45] i changed it to http://paste.debian.net/36112/ which lets me 'git fetch origin' correctly. [18:09:55] hm... yeah, maybe i stuck gerrit in my /etc/hosts. let me check. [18:10:05] # workaround wikimedia breakage [18:10:05] 208.80.154.152 gerrit.wikimedia.org manganese.wikimedia.org [18:10:11] ^^^ yup, that would do it. dammit. [18:11:01] it would be nicer if manganese just went away. that would have made this more obvious. [18:11:46] * cscott kicks /etc/hosts [18:11:48] Yeah we couldn't shut down Gerrit on manganese just yet for replication reasons [18:11:51] But we're stopping it now [18:12:08] at least shut down http://gerrit.wikimedia.org/r on manganese. [18:12:31] anyway, i expect that my problems are probably all solved, not that i'm not shooting myself in the foot anymore [18:13:16] (03PS8) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [18:18:48] (03CR) 10Mwalker: "Eeek! On viewing a book page I get:" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [18:26:16] (03PS1) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 [18:39:07] marktraceur: :-) [18:39:21] (03CR) 10CSteipp: [C: 032 V: 032] Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [18:51:44] (03PS1) 10Aaron Schulz: Fully log exceptions within resource loader (including traces) [core] - 10https://gerrit.wikimedia.org/r/83119 [19:12:04] marktraceur: btw, do you know my favorite TZ tool? as of when I found it about a year ago [19:12:14] What is it? [19:12:33] The one that gives you, like, all the timezones you could ever possibly want on one page? [19:14:26] $ zdump -v America/{Los_Angeles,New_York} Europe/{Athens,Berlin} | fgrep ':00 2013 ' | fgrep ' isdst=0 ' [19:14:29] America/Los_Angeles Sun Nov 3 09:00:00 2013 UTC = Sun Nov 3 01:00:00 2013 PST isdst=0 gmtoff=-28800 [19:14:32] America/New_York Sun Nov 3 06:00:00 2013 UTC = Sun Nov 3 01:00:00 2013 EST isdst=0 gmtoff=-18000 [19:14:35] Europe/Athens Sun Oct 27 01:00:00 2013 UTC = Sun Oct 27 03:00:00 2013 EET isdst=0 gmtoff=7200 [19:14:38] Europe/Berlin Sun Oct 27 01:00:00 2013 UTC = Sun Oct 27 02:00:00 2013 CET isdst=0 gmtoff=3600 [19:15:07] marktraceur: for every zone you give it it tells you the last time of the old offset and the first time of the new offset everytime the offset changes [19:15:46] see e.g.: zdump -v America/{Los_Angeles,New_York} Europe/{Athens,Berlin} | fgrep ' 2013 ' [19:16:33] also, https://en.wikipedia.org/wiki/Energy_Policy_Act_of_2005 and https://en.wikipedia.org/wiki/Time_in_Indiana [19:17:27] Ooh [19:18:22] every time* [19:18:28] I'm really happy about that [19:18:43] TIL, PST won't happen until November [19:20:15] UTC FOREVAH [19:21:03] (03PS1) 10MarkTraceur: Make the description a little less complex [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 [19:21:11] <^d> UTC is the only timezone that matters. [19:21:33] brion: Agreed [19:21:40] <^d> Also, [[Huge waste of time]] should redirect to [[Energy Policy Act of 2005#Change to daylight saving time]] [19:24:21] Can we start working UTC 9-17? [19:24:21] Won't be easy finding lunch places open at 12:00 UTC, maybe. [19:24:58] ooh ooh [19:25:09] we should make a late-night cafe in soma [19:25:13] and call it UTC [19:25:36] brion: It being SOMA, though, it should be open Mon-Fri 7-18 UTC or something [19:25:48] It's heresy to have a place in SOMA that's open on the weekend [19:27:09] :) [19:28:13] (03CR) 10Mollywhite: "Are you getting this message on a new book page, ore an existing one? It could be because this patch includes a schema change, so if you'r" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 (owner: 10Mollywhite) [19:40:01] (03PS1) 10MarkTraceur: Add unit tests for BetaFeatures [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/83126 [19:40:34] (03CR) 10MarkTraceur: [C: 032] Add unit tests for BetaFeatures [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/83126 (owner: 10MarkTraceur) [19:40:52] (03Merged) 10jenkins-bot: Add unit tests for BetaFeatures [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/83126 (owner: 10MarkTraceur) [19:42:24] (03PS2) 10MarkTraceur: Make the description a little less complex [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83121 [19:48:37] Krinkle: thanks for the help! [20:00:14] (03PS3) 10Bsitu: archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 [20:07:52] (03PS3) 10Qgil: Removes portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/81938 [20:08:28] (03PS4) 10Qgil: Removes portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/81938 [20:10:24] (03CR) 10Qgil: "Good point, Siebrand. Done: https://bugzilla.wikimedia.org/show_bug.cgi?id=53862" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [20:11:17] (03PS9) 10Euvl: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 [20:11:34] (03PS4) 10Bsitu: archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 [20:14:11] (03CR) 10Siebrand: [C: 032] Removes portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [20:17:17] (03Merged) 10jenkins-bot: Removes portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [20:21:53] hello, I got Yet Another Api question. How should I encode my text string for the MD5 parameter in action=edit? [20:25:50] (03PS2) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 [20:32:36] (03Abandoned) 10Umherirrender: Do not override OutputPage properties in addParserOutputNoText [core] - 10https://gerrit.wikimedia.org/r/74978 (owner: 10Umherirrender) [20:32:51] (03PS2) 10Umherirrender: Use redirect=no for links to file redirects in "file usages" section [core] - 10https://gerrit.wikimedia.org/r/80726 [20:36:03] can we ask about parsoid here? [20:36:06] (03PS10) 10Euvl: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 [20:40:23] (03PS7) 10Umherirrender: Add expensive parser functions {{REVISION*:}} [core] - 10https://gerrit.wikimedia.org/r/76534 [20:40:25] aboSamoor: sure or #mediawiki-parsoid [20:40:59] (03CR) 10Umherirrender: "Patch Set 7: Rebased" [core] - 10https://gerrit.wikimedia.org/r/76534 (owner: 10Umherirrender) [20:46:09] (03PS3) 10Physikerwelt: MathJax 2.3 upgrade and loading improvement [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/83117 [20:47:47] Hello, I need some help for adding a special page (this is not per se a problem) in Extension OpenID where Admins can trigger "account creation" by mail. This does not work as designed, and I need help to find the error. [20:47:49] https://gerrit.wikimedia.org/r/#/c/81629/ [20:48:23] The problem is, that the page shows up, but after sending all data, the page returns with "you are already logged in". So the context may be wrong [20:48:35] https://gerrit.wikimedia.org/r/#/c/81629/ [20:48:49] https://gerrit.wikimedia.org/r/#/c/81629/5/SpecialOpenIDCreateAccountByMail.body.php [20:50:02] (03PS12) 10Umherirrender: Add list=allfileusages [core] - 10https://gerrit.wikimedia.org/r/61817 [20:50:45] (03CR) 10Umherirrender: "Patch Set 12: Rebased" [core] - 10https://gerrit.wikimedia.org/r/61817 (owner: 10Umherirrender) [20:54:47] (03PS2) 10Umherirrender: Added {{REVISIONSIZE}} variable to get the current size of a revision. [core] - 10https://gerrit.wikimedia.org/r/82650 [21:11:47] (03PS5) 10Bsitu: archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 [21:13:15] (03PS13) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [21:13:19] (03CR) 10PleaseStand: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [21:18:29] (03PS14) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [21:19:29] Is https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deployability_and_feature_flags accurate? Do most extensions have a "$wgTurnOnExtensionBlah" switch? I don't think I've seen such a thing in most extensions. [21:20:18] I mean, you don't _require_ the extension on wikis that don't have it enabled AFAIK [21:23:22] * YuviPanda installs UW everywhere [21:24:12] (03CR) 10Parent5446: [C: 031] Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [21:24:32] <^d> marktraceur: You're right. I think the page is confusing. [21:24:55] YuviPanda: Upload the files to EVERY WIKI!!! [21:25:17] <^d> I'd say something like "most extensions should have a flag to enable them selectively per wiki." And "also consider whether hiding new features behind flags that allow them to be conditionally deployed." [21:26:06] ^d: And the flag should be more than "require_once or not require_once, that is the question"? [21:26:47] <^d> Huh? [21:28:16] (03CR) 10Bsitu: [C: 032] Improve footer separator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/60186 (owner: 10Nischayn22) [21:28:22] (03Merged) 10jenkins-bot: Improve footer separator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/60186 (owner: 10Nischayn22) [21:28:54] ^d: I shouldn't assume that, per-wiki, you only load extensions that are enabled? [21:29:08] (03PS1) 10Mwjames: Remove IParserData interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83136 [21:29:18] <^d> You can usually assume that. [21:29:25] <^d> Unless someone did something funny. [21:29:36] Then what's the purpose of $wgEnableExtensionAgain ? [21:33:06] <^d> marktraceur: I'd basically ignore what that section says and rewrite it based on actual practice. [21:33:46] <^d> Generally, we add $wmgUseFoobar or $wmgEnableSomeFoobaz in InitSettings to conditionally include them in CommonSettings. [21:34:03] <^d> There's a few deployed-everywhere extensions, but there's the exception, not the rule. [21:34:23] <^d> New features, especially those with performance impacts, should be hidden by feature flags when possible. This also applies to core. [21:35:28] Ah K. [21:35:48] ^d: Now I know, thanks :) [21:35:52] <^d> yw :) [21:37:02] * marktraceur plots his course for reviewing and deploying this extension [21:40:56] (03CR) 10Kaldari: [C: 031] "Looks good to me. Waiting for Nostalgia fix to be merged." [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Matmarex) [21:42:11] (03CR) 10Bsitu: [C: 032] Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 (owner: 10Alex Monk) [21:42:12] (03CR) 10jenkins-bot: [V: 04-1] Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 (owner: 10Alex Monk) [21:45:39] (03PS2) 10Bsitu: Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 (owner: 10Alex Monk) [21:46:21] (03CR) 10Mwjames: [C: 032] Remove IParserData interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83136 (owner: 10Mwjames) [21:47:42] (03Merged) 10jenkins-bot: Remove IParserData interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83136 (owner: 10Mwjames) [21:50:24] (03CR) 10Bsitu: [C: 032] Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 (owner: 10Alex Monk) [21:50:26] (03Merged) 10jenkins-bot: Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 (owner: 10Alex Monk) [21:50:39] ^d: around? busy? [21:54:17] <^d> Yo. [21:54:55] i still need my gerrit display name changed, y'know. [21:56:13] <^d> Ok, so I can do most of it. [21:56:29] it would be great if you could :) [21:56:44] to "Bartosz Dziewoński" (with an "ń") [21:57:02] i hope that whatever you'll use is unicode-compliant ;) [21:57:18] <^d> Should be fine afaik. [22:04:56] ^d: I've seen two crazy gerrit errors today, in both cases a patchset was missing from the repo. [22:05:06] for example, git fetch ssh://adamw@gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/65/82765/2 && git checkout FETCH_HEAD [22:05:06] <^d> Which repo? [22:05:18] that repo, and also mediawiki/extensions/CentralNotice [22:05:27] <^d> Ok, lemme have a look. [22:05:29] thx [22:05:39] <^d> I'm pretty sure I know what's up and what to do. [22:09:52] very mysterious. hit it hard with a bag of trout for me. [22:10:01] <^d> Ok, fundraising/tools fixed. [22:12:22] <^d> I think CentralNotice is fixed too. [22:12:24] ^d: works [22:12:46] cool, just as long at it wasn't repo corruption... [22:15:06] (03PS1) 10Raimond Spekking: Revert "Localisation updates from http://translatewiki.net." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/83190 [22:24:08] <^d> awight: Commits are all there, refs just went missing. [22:24:13] <^d> Something happened during migration. [22:24:27] (03PS11) 10Foxtrott: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [22:24:51] (03CR) 10Foxtrott: [C: 032 V: 031] Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [22:24:53] (03Merged) 10jenkins-bot: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [22:25:57] ^d: oh, gerrit was moved to another machine? [22:26:05] <^d> Yeah, newer bigger box. [22:26:20] great to hear [23:08:20] <^d> MatmaRex: You should be set now. [23:08:22] <^d> Sorry that took so long. [23:19:59] (03PS1) 10MarkTraceur: Design changes from review [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/83197 [23:22:47] ^d: yay, thanks [23:23:00] <^d> yw. Everything working ok? [23:23:08] ^d: do i need to log out and back in? [23:23:16] <^d> Oh yeah, def. [23:23:16] (or did it just not work? :P) [23:23:33] <^d> Use your new name :) [23:24:15] it worked, yay [23:24:18] thanks a lot :D [23:25:04] <^d> No problem. Glad to know it worked well for you. That's 3 users now...we can totally script this. [23:32:38] (03PS1) 10Cmcmahon: keep parity with /VisualEditor/modules/ve-mw/test/browser/ for now [qa/browsertests] - 10https://gerrit.wikimedia.org/r/83199 [23:33:20] (03CR) 10Cmcmahon: [C: 032] keep parity with /VisualEditor/modules/ve-mw/test/browser/ for now [qa/browsertests] - 10https://gerrit.wikimedia.org/r/83199 (owner: 10Cmcmahon) [23:35:56] (03PS1) 10Physikerwelt: Adjust MathDebug to lastes Math dev version [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/83200 [23:36:41] (03CR) 10Physikerwelt: [C: 032 V: 032] Adjust MathDebug to lastes Math dev version [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/83200 (owner: 10Physikerwelt) [23:57:24] (03PS1) 10Matthias Mullie: Add try/catch around statement that can cause errors when running update.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/83202