[00:07:58] is gerrit down? [00:08:10] ah, i see [00:08:45] * legoktm waits patiently [00:11:27] (03PS1) 10Yuvipanda: UploadWizard now has an optional dependency on Campaigns [vagrant] - 10https://gerrit.wikimedia.org/r/82772 [00:14:47] (03PS1) 10Yuvipanda: Use Campaigns to measure effectiveness of CTA in Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 [00:14:51] spagewmf: ^ [00:15:45] CTA stands for "Campaign Task Awareness"? xzhibit yo [00:15:56] haha! [00:16:03] that goes over 80 chars [00:16:28] (03CR) 10Yuvipanda: [C: 032] "wfm, so merging." [vagrant] - 10https://gerrit.wikimedia.org/r/82772 (owner: 10Yuvipanda) [00:16:44] spagewmf: merge / +1 that patch? :) [00:16:55] i can deploy that on blue dragon for you to test [00:17:06] (03CR) 10Yuvipanda: [V: 032] UploadWizard now has an optional dependency on Campaigns [vagrant] - 10https://gerrit.wikimedia.org/r/82772 (owner: 10Yuvipanda) [00:17:13] in the CentralNotice are country names used in the language of the preferences of someone, does anyone known how I can use them elsewhere too [00:19:04] YuviPanda: Wow, that's actually pretty cool. :P [00:19:13] wheee! :D [00:20:48] spagewmf: marktraceur deployed at http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns [00:21:09] spagewmf: is the : in the campaign name okay? [00:21:29] Cool [00:22:13] I'm guessing that deployment won't actually pick up any of the events, because i don't have EL fully setup [00:23:13] marktraceur: once our JS is in shape, we should instrument it totally and see where people drop off [00:23:46] YuviPanda, it's a bit risky, since : in query string may be URL-encoded as %3A. I'd stick to dashes [00:23:55] it ought to work (famous last words...) [00:24:02] spagewmf: it is encoded as %3A :) [00:24:05] http://blue-dragon.wmflabs.org/w/index.php?title=Special:UserLogin/signup&returnto=Campaign%3Ashow-off-campaigns&campaign=uploadCampaign%3Ashow-off-campaigns is the URL [00:24:12] and I get uploadCampaign%3Ashow-off-campaigns [00:24:15] as the campaign name [00:24:25] spagewmf: shoulnd't that work? [00:25:43] YuviPanda: what I said :) [00:25:53] 'should work'? [00:26:15] spagewmf: if it doesn't, we should file a bug against campaigns :) [00:26:36] exactly. it ought to work [00:26:46] spagewmf: are you willing to merge the patch? :D [00:27:08] YuviPanda: I'm looking at it [00:32:04] (03PS1) 10MarkTraceur: Add user counts, hopefully performant enough [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 [00:32:18] bd808|BUFFER: In case you exist before tomorrow, ^^ [00:34:14] (03CR) 10Yuvipanda: [C: 031] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [00:42:14] (03PS5) 10Bsitu: Adding Echo jobs to deferred update along with master wait [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 [00:44:12] ^d: BTW, has the gerrit/Jenkins link been broken by the IP change? [00:46:32] <^d> Shouldn't have been. I updated zuul's config. [00:47:18] "Queue lengths: 0 events, 0 results" [00:47:31] (03PS1) 10Yuvipanda: Add tracking category to UploadCampaign API call [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 [00:47:32] (03PS1) 10Yuvipanda: Add totalUploads & totalContributions to the API [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82780 [00:48:00] <^d> James_F: Maybe I had to manually reload zuul? [00:48:02] <^d> Tried that. [00:48:08] Hmm. [00:51:05] ^d: Oh, jenkinsbot is suddenly alive. I think? [00:51:51] (03CR) 10Spage: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [00:54:17] (03PS13) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [00:54:18] (03CR) 10jenkins-bot: [V: 04-1] Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [00:56:05] (03PS14) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [00:56:06] (03CR) 10jenkins-bot: [V: 04-1] Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [00:56:25] (03PS1) 10Mwjames: Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 [00:56:28] (03CR) 10jenkins-bot: [V: 04-1] Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [00:56:56] (03PS1) 10Yuvipanda: Use appropriate method to make Special Subpage URL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82782 [00:56:58] (03CR) 10jenkins-bot: [V: 04-1] Use appropriate method to make Special Subpage URL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82782 (owner: 10Yuvipanda) [00:57:25] spagewmf: responded to your comments, and added another commit for the suburl stuff [00:57:59] spagewmf: my comments haven't come through yet, but yes - that is a dbkey, and they're usually just normal ascii keys. [00:58:12] (03CR) 10Yuvipanda: "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [00:58:26] YuviPanda: I sense you really want to get this deployed. It's 6:30am ?! [00:58:43] spagewmf: my current sleep cycle means I'm going to be up for another 2 hours [00:58:49] spagewmf: and it is 6:30 AM [00:58:51] I'm cursed [00:59:10] spagewmf: well, this is going to get deployed if it gets merged before tomorrow's cut off time [00:59:11] Das Wampyr! Welcome, Children of the Night [00:59:16] (03CR) 10Mwjames: "Jenkins what?" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [00:59:17] haha! :) [00:59:37] spagewmf: this + a 35hour flight to SF this weekend is going to be... fun [00:59:39] (03PS2) 10Mwjames: Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 [00:59:41] (03CR) 10jenkins-bot: [V: 04-1] Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [01:00:32] spagewmf: none of the current Campaign pages have anything that's not an ascii char, for example. I don't expect that to change soo [01:00:32] nn [01:00:34] (03CR) 10Mwjames: "Really ???? !!!!!!" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [01:01:05] (03CR) 10Yuvipanda: "Jenkins is having a little trouble after the Gerrit upgrade. People are looking at it." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [01:01:06] Is Jenkins "automatically merged" check broken? [01:01:10] superm401: yup [01:01:14] (03PS1) 10Aaron Schulz: Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 [01:01:17] (03CR) 10jenkins-bot: [V: 04-1] Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [01:01:21] superm401: poke ^d, but I think he's already looking at it [01:01:55] YuviPanda: Yes chad is looking at it superm401 [01:02:17] p858snake|l, thanks. [01:02:56] (03CR) 10Mattflaschen: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [01:04:29] (03CR) 10Spage: [C: 032] "seems to work on the test instance" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [01:04:31] (03CR) 10jenkins-bot: [V: 04-1] Use Campaigns to measure effectiveness of CTA in Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [01:04:47] heh, ty spagewmf [01:04:54] it'll fix itself when jenkins gets unstuck [01:05:14] spagewmf: there were a couple of trivial patches after that if you want to help review :) [01:05:20] YuvampirePanda: I +2d, but "This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset." [01:05:40] oh OK [01:05:57] spagewmf: that's just jenkins ating up [01:06:22] Jenkins is broken and considers everything unmergeable right now [01:17:12] legoktm: Yo. [01:17:15] Hi [01:17:18] RIP, Jenkins. [01:17:27] legoktm: How was writing autocomplete support? Easy? Hard? [01:18:13] Wasn't that bad, took me about an hour [01:18:22] I also wrote https://www.mediawiki.org/wiki/Manual:Enabling_autocomplete_in_a_form [01:18:27] Oh, nice! [01:18:33] I have a bunch of autocomplete bugs for core. :-) [01:18:36] If you're interested. [01:20:55] Maybe. It seems like there needs to be an easy way to enable autocomplete for any random text box [01:21:58] maybe just wrap it in a
or something. Not sure really [01:29:31] (03PS15) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [01:29:32] (03CR) 10jenkins-bot: [V: 04-1] Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [01:31:27] (03CR) 10Mattflaschen: "15 is a minor change to make jshint in my editor happy. It's on toro." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [01:43:12] <^d> spagewmf, YuviPanda, others: Fixed jenkins. Turns out it had some hardcoded references to the old gerrit server. [01:43:26] yeah, saw the tweet :P [01:43:29] * YuviPanda does a recheck comment [01:43:31] ^d: thanks [01:43:34] <^d> yw [01:43:46] (03CR) 10Yuvipanda: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [01:43:58] * YuviPanda twiddles [01:46:35] (03CR) 10Bsitu: [C: 032] "This actually won't do anything, the setting is always overwritten in the configuration file: commonSettings.php, we can update it there w" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82554 (owner: 10Kaldari) [01:47:20] ^d: hmm, has C+2, yet jenkins hasn't merged? https://gerrit.wikimedia.org/r/#/c/82773/ [01:47:24] (03Merged) 10jenkins-bot: Updating eventlogging schema revision number for mobile data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82554 (owner: 10Kaldari) [01:47:33] needs another +2? [01:47:44] <^d> Recheck only does +1. [01:47:46] <^d> Tis lame. [01:47:57] okay, let me +2 again [01:48:23] rather than 'recheck', just edit the commit message [01:48:26] (03CR) 10Yuvipanda: [C: 032] "+2ing on behalf of spage (who +2'd same patchset) to work around jenkins being lame." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [01:48:37] (03Merged) 10jenkins-bot: Use Campaigns to measure effectiveness of CTA in Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82773 (owner: 10Yuvipanda) [01:48:51] okay, that was merged :) [01:48:55] thanks, spagewmf :) [01:49:09] <^d> Recheck only does +1. .> [01:49:16] <^d> I think it is a bug. [01:50:09] <^d> *has a bug filed? [01:50:11] <^d> duh it's a bug. [01:50:15] <^d> ok, I need to call it a day. [01:55:49] YuviPanda: it is setup, and used for the redis job queue currently. Last time i asked about it it didn't sound like we had any sharding setup though [01:55:57] YuviPanda: doh sorry, ignore i was scrolled way back :P [01:56:02] ebernhardson: :D [01:56:11] ebernhardson: I remember reading the flow arch docs mentioning redis [01:56:15] are those plans still on? [01:56:26] it's also used for the session cache [01:57:02] not using it yet, since i was told sharding hasn't been setup for them and would need to setup something (i know various multi-key dont work sharded, but i dont use those anyways) [01:57:17] hmm, right [01:57:47] ebernhardson: are you planning on poking people to do the required setup, or working around it and just using memcached? [01:57:53] or has it not come up yet? [01:58:12] (03CR) 10Springle: [C: 031] add unique constraint on transcode name, key [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/57536 (owner: 10J) [01:58:20] YuviPanda: well, we currently have a working memcache setup using CAS. But its dont in a composable manner where we can replace a couple classes and everything switches to redis [01:58:31] ah, sweet [01:58:52] what I was more interested in is if you explicitly use redis, you can use more of its features [01:59:04] well, we would primarily be using zset's i think [02:00:04] i know it can do fancy stuff beyond that, but not really necessary for our current use case. Currently we have a system that builds/updates lists of things in memcache at the same time they write to mysql, zset is a natural fit but have to figure out if all our cases can be sorted with a simple number [02:01:52] might use hashes to represent the actual objects (the lists are always lists of primary keys), but not sure yet how much use we would get from that [02:56:26] (03PS2) 10Legoktm: Initial commit [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/78942 [02:56:47] (03CR) 10Legoktm: [C: 032 V: 032] Initial commit [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/78942 (owner: 10Legoktm) [03:00:35] (03PS1) 10Legoktm: Set a license [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/82795 [03:00:46] (03CR) 10Legoktm: [C: 032 V: 032] Set a license [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/82795 (owner: 10Legoktm) [03:08:09] (03PS3) 10Mwjames: Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 [03:12:17] (03CR) 10Mwjames: [C: 032] Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [03:12:36] Yippie, build fixed! [03:12:37] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #283: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/283/ [03:13:57] (03Merged) 10jenkins-bot: Travis#185.2 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82781 (owner: 10Mwjames) [03:24:55] (03PS3) 10Mwjames: Remove addPropertyValue logic from ParserData (further compartmentalize of ParserData) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75295 [03:28:15] (03CR) 10Mwjames: [C: 032] Remove addPropertyValue logic from ParserData (further compartmentalize of ParserData) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75295 (owner: 10Mwjames) [03:29:43] (03Merged) 10jenkins-bot: Remove addPropertyValue logic from ParserData (further compartmentalize of ParserData) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75295 (owner: 10Mwjames) [03:37:12] Yippie, build fixed! [03:37:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #253: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/253/ [03:53:16] (03CR) 10Spage: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [03:54:15] (03CR) 10MZMcBride: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 (owner: 10Legoktm) [03:54:46] heh, oops. [03:55:36] (03PS1) 10Legoktm: Fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82796 [03:55:50] legoktm: Was there a follow-up commit? [03:55:55] For the Special page? [03:55:59] I got so confused. [03:56:43] Elsie: No..? The special page doesn't need to be changed [03:57:27] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 (owner: 10Legoktm) [03:57:38] Elsie: ^ I explained a bit more in that [03:58:03] All right. [03:58:26] (03CR) 10Legoktm: [C: 032] Fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82796 (owner: 10Legoktm) [03:58:38] (03Merged) 10jenkins-bot: Fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82796 (owner: 10Legoktm) [03:58:43] Oh. [03:58:45] I was about to do that. [03:58:47] Gay. [03:59:56] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=48240 BTW. [04:00:23] ok, i'll look into that [04:01:16] I agree with maybe genericizing the class name. [04:01:21] Maybe. [04:01:34] I'm not totally sure what benefit it would bring. [04:01:45] But it seems like it wouldn't hurt. [04:02:33] er, which class name? [04:02:39] oh, right. [04:03:00] well I was thinking that we just have JS that runs on anything that is wrapped within that class [04:03:04] mw-autocomplete or whatever. [04:03:26] But the JS has to be written to map the field to the backend... [04:03:35] And you'll need a more specific selector, I imagine. [04:03:36] I dunno. [04:03:40] :P [04:03:43] idk either [04:03:48] For Special:Contributions, you'll need to map to list=users. [04:03:56] For PrefixIndex, list=allpages. [04:04:06] For Tags... I dunno. [04:04:14] er, prefixindex would be the same as opensearch [04:04:25] Probably. [04:04:27] maybe some handling of namespace, but opensearch can do that too [04:04:42] I don't really know what opensearch is. [04:04:46] Is that from an extension? [04:04:52] https://www.mediawiki.org/wiki/API:Opensearch [04:04:55] It's in core [04:04:59] Interesting. [04:05:16] There's a reason I filed bugs rather than fixing this myself. ;-) [04:05:17] https://en.wikipedia.org/wiki/Opensearch [04:05:25] It's one of the areas of MediaWiki I don't really know very well. [04:06:14] I think the advantage of opensearch over allpages is that opensearch is caseinsensitive [04:07:36] All right. [04:17:14] Elsie: Also, did you see my comment about "don't require a separate screen to check whether invalid page list was entered"? [04:17:27] No. [04:17:30] Link? [04:18:14] https://www.mediawiki.org/wiki/Extension:MassMessage/Design#Enhancements [04:32:39] (03PS1) 10Mwjames: Rename addPropertyValue -> addDataValue [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82797 [04:50:18] Elsie: So I got the invalid html thing to work! -ish [04:51:17] Right now it is on a button press, however that means we either need to add another button [04:51:42] I'm wondering if there's a way we can run something when a user removes focus from a textbox. [04:52:03] http://stackoverflow.com/questions/18272041/javascript-event-when-user-removes-focus-on-textbox [04:52:22] (03PS2) 10Mwjames: Rename addPropertyValue -> addDataValue [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82797 [04:52:43] yup, that should work. [04:53:37] hm didn't work. [04:55:26] (03CR) 10Mwjames: [C: 032] Rename addPropertyValue -> addDataValue [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82797 (owner: 10Mwjames) [04:57:40] (03Merged) 10jenkins-bot: Rename addPropertyValue -> addDataValue [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82797 (owner: 10Mwjames) [04:57:55] Elsie: !!! http://i.imgur.com/2MAbOYS.png [05:00:30] (03CR) 10Santhosh: "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [05:03:32] legoktm: !!!!!!! [05:04:31] :D [05:09:11] Project browsertests-en.wikipedia.org-linux-chrome build #295: FAILURE in 4 min 59 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/295/ [05:23:08] (03CR) 10Nikerabbit: "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [05:25:46] (03PS1) 10Santhosh: Avoid color change for visited links in project tiles [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82798 [05:37:00] (03PS2) 10Santhosh: Avoid color change for visited links [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82798 [05:42:16] * legoktm pokes grrrit-wm  [05:42:26] Elsie: https://gerrit.wikimedia.org/r/82799 [05:49:17] (03CR) 10Amire80: [C: 032] Avoid color change for visited links [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82798 (owner: 10Santhosh) [05:49:20] (03Merged) 10jenkins-bot: Avoid color change for visited links [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82798 (owner: 10Santhosh) [05:50:02] YuviPanda_zz: grrrit-wm randomly skipped https://gerrit.wikimedia.org/r/82799 [05:52:02] (03PS1) 10Spage: Avoid abstract function errors in php 5.3.3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82800 [05:57:18] (03PS1) 10Santhosh: Better styling for login form [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82801 [06:01:02] (03PS8) 10Mattflaschen: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [06:04:23] (03CR) 10Mattflaschen: "(3 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [06:20:44] (03PS9) 10Mattflaschen: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [06:25:15] (03PS1) 10Mattflaschen: Make JSHint voting for GettingStarted [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82802 [06:37:27] quick question in case anyone is awake: how are the contentformat and contentmodel parameters in the api edit action supposed to be used? [06:38:01] should I always set a correct pair? [06:49:08] Yippie, build fixed! [06:49:09] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #428: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/428/ [06:49:29] (03PS4) 10Nikerabbit: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 [06:50:46] (03CR) 10Springle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [06:59:24] (03CR) 10Nikerabbit: "FYI there are also style changes in https://gerrit.wikimedia.org/r/#/c/69064/4/resources/css/ext.translate.mainpage.css" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82801 (owner: 10Santhosh) [07:00:43] (03PS15) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [07:02:16] (03CR) 10Pastakhov: "Add ternary operator" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [07:22:07] Yippie, build fixed! [07:22:07] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #18: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/18/ [07:26:21] (03PS16) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [07:28:18] (03CR) 10Pastakhov: "performance optimization" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [07:35:25] (03PS2) 10Nikerabbit: Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }} [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [07:35:37] (03CR) 10Nikerabbit: [C: 032] Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }} [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [07:41:29] (03CR) 10Zfilipin: [C: 032] View history link location is not reliable on Sauce browsers Bug 53728 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82632 (owner: 10Cmcmahon) [07:41:41] (03Merged) 10jenkins-bot: Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }} [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [07:42:33] (03PS2) 10Zfilipin: ULS tests now reside in the ULS extension repo, delete them from here [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 (owner: 10Cmcmahon) [07:42:40] (03CR) 10Zfilipin: [C: 032] ULS tests now reside in the ULS extension repo, delete them from here [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 (owner: 10Cmcmahon) [07:49:44] (03PS3) 10Legoktm: [WIP] Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 [07:51:35] (03PS4) 10Legoktm: [WIP] Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 [07:53:25] (03PS5) 10Legoktm: [WIP] Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 [07:54:13] (03PS6) 10Legoktm: [WIP] Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 [07:59:22] hashar_: hey! could you make the jslint job for my extension (MassMessage) voting please? :) [08:00:05] or at least point me in the right direction on how to do that :) [08:01:00] legoktm: the voting is handled in Zuul configuration :-] [08:01:22] legoktm: wanna edit the conf file ? ssh://gerrit.wikimedia.org:29418/integration/zuul-config.git [08:01:45] sure :D [08:02:06] legoktm: clone and open layout.yaml [08:02:28] that is a huge yaml file containing all the magic that controls which jobs are triggered and which are voting [08:02:32] if you search for 'mwext-Math-jslint' [08:02:37] you will find a block like: [08:02:44] - name: mwext-Math-jslint [08:02:44] voting: true [08:03:00] you need a new block there with - name: mwext-MassMessage-jslint … voting: true [08:03:33] (03Abandoned) 10Raimond Spekking: Add i18n files [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/67963 (owner: 10Raimond Spekking) [08:03:50] (03PS1) 10Legoktm: Enable voting for mwext-MassMessage-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82806 [08:03:59] hashar_: like that? ^ [08:04:16] yup [08:04:40] There is a job in Jenkins that compare the Zuul configuration before and after the change [08:04:44] https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/419/console [08:05:01] which shows that [nonvoting] got removed from mwext-MassMessage-jslint [08:05:10] ah, neat. [08:05:39] so I just have to look at that diff [08:05:42] then CR+2 [08:05:51] git pull on the server and reload Zuul [08:06:10] (03CR) 10Hashar: "Excellent! Congratulations on making your JavaScript passing JSHint." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82806 (owner: 10Legoktm) [08:06:14] (03CR) 10Hashar: [C: 032] Enable voting for mwext-MassMessage-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82806 (owner: 10Legoktm) [08:06:21] (03Merged) 10jenkins-bot: Enable voting for mwext-MassMessage-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82806 (owner: 10Legoktm) [08:06:36] one day I will have to make all of that automatic [08:07:16] legoktm: change deployed. Congratulations on passing JSHint! [08:08:22] yay, thanks :) [08:08:59] (03PS7) 10Legoktm: Use JavaScript to detect unclosed HTML tags [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 [08:09:15] (03PS1) 10Raimond Spekking: Add i18n file [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/82808 [08:09:59] (03PS1) 10Nikerabbit: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 [08:10:06] (03CR) 10jenkins-bot: [V: 04-1] TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:12:48] (03PS2) 10Nikerabbit: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 [08:12:55] (03CR) 10jenkins-bot: [V: 04-1] TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:15:06] hashar_: hmm what I am doing wrong? [08:15:15] hey :) [08:15:18] not sure [08:15:26] 08:12:50 voluptuous.voluptuous.MultipleInvalid: does not match regular expression @ data['projects'][252]['test'][2] [08:15:31] that is … cryptic hehe [08:15:44] Nikerabbit: http://ganglia.wikimedia.org/latest/graph.php?r=day&z=xlarge&title=eventlogging.UniversalLanguageSelector_5729800&vl=events+%2F+sec&x=&n=&hreg[]=client-side&mreg[]=eventlogging.UniversalLanguageSelector_5729800>ype=stack&glegend=show&aggregate=1&embed=1&_=1378368816591 [08:16:05] Nikerabbit: you are missing : [08:16:10] Nikerabbit: I will comment on line [08:16:18] you can have mine: : [08:16:49] ori-l: hmm confusing [08:16:58] (03CR) 10Hashar: [C: 04-1] "(2 comments)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:17:15] oh yeah, hang on [08:17:34] m again means milli and not million? [08:18:05] million is mega or M [08:18:51] being too voluptuous? [08:18:54] milli [08:19:23] and ganglia is always per second [08:19:28] so 500m = 1/2 an event per second [08:20:18] this one doesn't contain the superfluous 'count' thing: http://ganglia.wikimedia.org/latest/graph.php?r=day&z=xlarge&title=ULS+Events+per+second&vl=&x=&n=&hreg[]=client-side&mreg[]=%5Eeventlogging.UniversalLanguageSelector_5729800%24>ype=line&glegend=hide&aggregate=1&embed=1&_=1378369049531 [08:21:40] ori-l: that looks reasonable to me, what you think? [08:24:01] yeah, it's very light [08:24:06] this is everything: http://ganglia.wikimedia.org/latest/graph.php?r=hour&z=xlarge&title=&vl=&x=&n=&hreg[]=client-side&mreg[]=%5Eeventlogging.>ype=line&glegend=show&aggregate=1&embed=1&_=1378369345031 [08:24:58] ganglia makes ugly urls sadly [08:25:02] Nemo_bis: i have one for you too [08:25:06] i'm very excited about this, if you can't tell [08:25:14] since i just got it into ganglia earlier [08:26:10] ori-l: one ugly URL for me to do some more edit #FAIL s? [08:26:31] edit #FAILs? [08:26:44] not escaping [] [08:27:09] I'm always excited too when new stuff is added to ganglia, but let's not tell jenkins or we'll get more voluptuous errors [08:27:25] Nikerabbit: i have left inline comments on https://gerrit.wikimedia.org/r/#/c/82809/2/layout.yaml,unified you missed two trailing columns :) [08:27:58] looks ok for http://www.ietf.org/rfc/rfc1738.txt [08:28:44] just not for wikitext :) [08:29:18] (03PS20) 10Adamw: Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [08:33:40] (03PS3) 10Nikerabbit: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 [08:40:34] Yippie, build fixed! [08:40:35] Project VisualEditor-test2.wikipedia.org-linux-firefox build #16: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/16/ [08:42:28] hashar_: updated [08:45:14] (03PS4) 10Hashar: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:45:40] (03CR) 10Hashar: "Changed the check pipeline from check-only to check since there are now unit tests." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:45:44] (03PS5) 10Hashar: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:45:59] Nikerabbit: great. I did a small tweak and will merge the change in a few minutes [08:46:48] (03CR) 10Hashar: [C: 032] TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:46:53] (03Merged) 10jenkins-bot: TwnMainPage has unit tests now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82809 (owner: 10Nikerabbit) [08:47:28] Nikerabbit: deployed :-] [09:07:22] (03PS1) 10Shirayuki: Add full-stops to error messages [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/82811 [09:07:28] (03PS2) 10Hashar: Make JSHint voting for GettingStarted [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82802 (owner: 10Mattflaschen) [09:07:40] (03CR) 10Hashar: [C: 032] "Congratulations :]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82802 (owner: 10Mattflaschen) [09:08:00] (03Merged) 10jenkins-bot: Make JSHint voting for GettingStarted [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82802 (owner: 10Mattflaschen) [09:08:53] @notify ^d [09:08:53] I'll let you know when I see ^d around here [09:15:16] https://gerrit.wikimedia.org/r/#/c/59793/ appears inaccessible? [09:16:51] liangent: inaccessible? it loaded for me [09:17:17] "Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }}" [09:18:04] MatmaRex: it tells me "Code Review - Error The page you requested was not found, or you do not have permission to view this page." [09:18:35] huh. qchris, around? ^ [09:20:39] liangent: works for me. i had some random fairues earlier, reloading fixed it. [09:22:44] DanielK_WMDE: thanks. a simple reload didn't, but shift-loading fixed it for me [09:31:07] (03PS2) 10Shirayuki: Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/82602 [09:34:42] (03CR) 10Matmarex: [C: 032] Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/82602 (owner: 10Shirayuki) [09:37:35] (03Merged) 10jenkins-bot: Give grep a chance to find the usages [core] - 10https://gerrit.wikimedia.org/r/82602 (owner: 10Shirayuki) [09:55:52] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82813 [09:58:18] (03CR) 10Hashar: [C: 032] Correct directory for patch extensions [tools/release] - 10https://gerrit.wikimedia.org/r/82749 (owner: 10CSteipp) [09:58:20] (03Merged) 10jenkins-bot: Correct directory for patch extensions [tools/release] - 10https://gerrit.wikimedia.org/r/82749 (owner: 10CSteipp) [10:02:07] (03CR) 10Hashar: [C: 031] "Zeljkof, if the tests pass on beta, I guess you can deploy them. The three scenarii cover my use cases :)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78234 (owner: 10Zfilipin) [10:08:12] (03CR) 10Daniel Kinzler: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/49785 (owner: 10Jeroen De Dauw) [10:09:35] liangent: Sorry, I missed MatmaRex's ping [10:09:56] liangent: Does https://gerrit.wikimedia.org/r/#/c/59793/ still not work for you? [10:10:14] qchris: it fixed itself, i think [10:10:37] MatmaRex: Ok. [10:10:44] qchris: there were some random errors in the gerrit web interface. i guess related to last night'S maintenance. [10:10:49] seems to be fine now [10:11:03] (03Merged) 10jenkins-bot: Allow registration of Actions using a callback that returns an Action instance [core] - 10https://gerrit.wikimedia.org/r/49785 (owner: 10Jeroen De Dauw) [10:11:53] ^d did switch machines, but actually that should not affect the web interface :-/ [10:17:51] qchris: unless some bits are loaded using the internal host name, or something doesn't have the new dadtabase host, or... [10:18:05] (03CR) 10Foxtrott: "(3 comments)" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [10:18:30] :-) [10:45:53] (03PS17) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [10:47:25] (03CR) 10Pastakhov: "Add if operator ( without else and blocks )" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [10:52:34] (03PS5) 10Matmarex: jquery.suggestions, mediawiki.searchSuggest: Fix form submission [core] - 10https://gerrit.wikimedia.org/r/48252 [10:52:46] (03PS1) 10Matmarex: jquery.suggestions: Do not duplicate keypress logic [core] - 10https://gerrit.wikimedia.org/r/82814 [10:53:25] (03CR) 10Matmarex: "This is functional now, the other part of the fix is in the dependency: https://gerrit.wikimedia.org/r/82814" [core] - 10https://gerrit.wikimedia.org/r/48252 (owner: 10Matmarex) [11:25:58] (03PS7) 10Euvl: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 [11:34:51] (03PS8) 10Euvl: Added lingo support for ApprovedRevs. [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 [12:04:05] (03PS1) 10Hashar: make-release: rename script to make-release.py [tools/release] - 10https://gerrit.wikimedia.org/r/82818 [12:04:06] (03PS1) 10Hashar: make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 [12:04:24] (03CR) 10jenkins-bot: [V: 04-1] make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 (owner: 10Hashar) [12:05:39] (03CR) 10Hashar: "I have extracted some part of your patch in you two new changes:" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:15:57] (03PS3) 10Matmarex: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [12:16:25] (03CR) 10jenkins-bot: [V: 04-1] Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [12:17:35] (03CR) 10Matmarex: "I adjusted the image replacement technique." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [12:18:27] (03PS4) 10Matmarex: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [12:18:46] (03PS4) 10Hashar: --branch and --data learned [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:19:10] (03CR) 10jenkins-bot: [V: 04-1] --branch and --data learned [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:19:31] (03PS3) 10Mwjames: (Bug 52396) use getSubject()->getDBkey() instead [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77126 [12:20:02] (03PS5) 10Hashar: --branch and --data learned [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:21:07] (03PS5) 10Matmarex: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [12:21:18] (03CR) 10Hashar: [C: 031] "PS4: rebased on the split patches:" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:21:37] (03CR) 10Hashar: [C: 032] make-release: rename script to make-release.py [tools/release] - 10https://gerrit.wikimedia.org/r/82818 (owner: 10Hashar) [12:22:34] (03PS2) 10Hashar: make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 [12:24:09] (03PS2) 10Hashar: make-release: rename script to make-release.py [tools/release] - 10https://gerrit.wikimedia.org/r/82818 [12:24:38] (03CR) 10Hashar: [C: 032] "rebased, made mark the Author:" [tools/release] - 10https://gerrit.wikimedia.org/r/82818 (owner: 10Hashar) [12:24:41] (03Merged) 10jenkins-bot: make-release: rename script to make-release.py [tools/release] - 10https://gerrit.wikimedia.org/r/82818 (owner: 10Hashar) [12:25:10] (03PS3) 10Hashar: make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 [12:28:46] hashar: didn't you say tox.ini was needed? [12:29:00] Why is it still being deleted in your long lines patch? [12:29:02] (03PS4) 10Hashar: make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 [12:29:20] (03CR) 10Hashar: [C: 032] "sounds good now :)" [tools/release] - 10https://gerrit.wikimedia.org/r/82819 (owner: 10Hashar) [12:29:25] (03Merged) 10jenkins-bot: make-release: fix lines too longs [tools/release] - 10https://gerrit.wikimedia.org/r/82819 (owner: 10Hashar) [12:29:28] (03PS6) 10Hashar: --branch and --data learned [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:30:23] hashar: would have posted that on gerrit instead of asking you in IRC, but hospital's proxy is misconfigured. [12:31:51] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger) [12:33:00] (03CR) 10Hashar: "The idea is to let us define bundles in a YAML file, which would make it easier to review changes or add new bundles. I am not sure wheth" [tools/release] - 10https://gerrit.wikimedia.org/r/81573 (owner: 10Hashar) [12:33:15] hexmode: oh you are there :-] [12:33:25] hexmode: sorry I made a bit of a mess, I wanted to clean up one of your patch. [12:33:26] hashar: :) [12:33:33] np, it needed it [12:33:40] the tox.ini is to pass parameters to pep8/flake8 [12:34:00] renaming the file to make-release.py and fixing the long line means the script is non detected properly and pass the default pep8 checks [12:34:09] so I got rid of the now useless tox.ini [12:34:12] I started piling onto it last night, so this is a sanity reminder :) [12:34:35] hashar: you're managing jenkins? [12:34:36] anyway you can amend https://gerrit.wikimedia.org/r/81619 now :D [12:34:38] oh, I thought you said pep8 wasn't run (in Jenkins?) if tox.ini wasn't there [12:34:41] liangent: yes sir [12:34:42] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/2726/console what does this failure mean? [12:35:06] (03PS4) 10Mwjames: (Bug 52396) use getSubject()->getDBkey() instead [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77126 [12:35:20] liangent: some class is not properly registered apparently. #wikimedia-wikidata folks would probably be of better help [12:35:37] liangent: Class 'Wikibase\ReferenceObject' not found in /srv/ssd/jenkins-slave/workspace/mwext-Wikibase-client-tests/extensions/WikibaseDataModel/WikibaseDataModel.php on line 84 [12:37:02] hashar: oh I was seeking clues in those dots [12:37:23] (03CR) 10Mwjames: [C: 032] (Bug 52396) use getSubject()->getDBkey() instead [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77126 (owner: 10Mwjames) [12:37:32] liangent: yeah it is sometime hard to spot the root cause :-D [12:38:53] (03Merged) 10jenkins-bot: (Bug 52396) use getSubject()->getDBkey() instead [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77126 (owner: 10Mwjames) [12:55:10] (03PS6) 10Matmarex: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [12:55:41] (03CR) 10Matmarex: "And avoided the issues with .client-js with some inline JS magic. I'm not sure if it's a good idea, but it works." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [12:56:35] (03PS3) 10Hashar: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover) [12:56:51] (03CR) 10jenkins-bot: [V: 04-1] Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover) [12:58:47] (03PS2) 10Matmarex: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [12:59:23] (03PS4) 10Hashar: Created python script to git logs [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover) [12:59:40] (03CR) 10Hashar: "pass pep8 :)" [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover) [13:02:46] (03Abandoned) 10Matmarex: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Matmarex) [13:05:42] @notify swalling [13:05:42] I'll let you know when I see swalling around here [13:10:28] (03PS6) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [13:10:29] (03PS3) 10Matmarex: mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 [13:10:47] (03CR) 10Matmarex: "Just a rebase." [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Matmarex) [13:10:57] (03CR) 10Matmarex: "Just a rebase." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex) [13:12:36] (03PS7) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 [13:12:50] (03CR) 10Matmarex: "Added messages.inc." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex) [13:17:37] (03PS3) 10Ragesoss: Change course status "Passed" to "Ended" to avoid ambiguity about "passing" a course. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 [13:23:18] (03Abandoned) 10Hashar: Add Disambiguator extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/73126 (owner: 10Reedy) [13:40:03] (03CR) 10Hashar: [C: 04-1] "(4 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/59138 (owner: 10Mgrover) [13:54:22] (03PS1) 10Manybubbles: Switch queries to ANDing terms together. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82825 [13:54:53] (03PS2) 10Manybubbles: Switch queries to ANDing terms together. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82825 [13:56:29] (03PS1) 10Manybubbles: Tests for switching to ANDing query terms together [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82827 [13:56:44] (03PS2) 10Manybubbles: Tests for switching to ANDing query terms together [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82827 [13:57:33] (03PS1) 10Matmarex: Backport information boxes' styles from vforms to shared CSS [core] - 10https://gerrit.wikimedia.org/r/82828 [14:01:56] (03PS2) 10Matmarex: Backport information boxes' styles from vforms to shared CSS [core] - 10https://gerrit.wikimedia.org/r/82828 [14:05:30] (03CR) 10Matmarex: "A showcase can be seen in the file docs/uidesign/design.html. Screenshots for the lazy: before: http://i.imgur.com/DN7LX1W.png after: http" [core] - 10https://gerrit.wikimedia.org/r/82828 (owner: 10Matmarex) [14:30:55] (03PS1) 10Reedy: Update Wikidata related extension branches to use [tools/release] - 10https://gerrit.wikimedia.org/r/82831 [14:35:54] (03PS2) 10Reedy: Update Wikidata related extension branches to use [tools/release] - 10https://gerrit.wikimedia.org/r/82831 [14:36:02] (03CR) 10Reedy: [C: 032] Update Wikidata related extension branches to use [tools/release] - 10https://gerrit.wikimedia.org/r/82831 (owner: 10Reedy) [14:36:04] (03Merged) 10jenkins-bot: Update Wikidata related extension branches to use [tools/release] - 10https://gerrit.wikimedia.org/r/82831 (owner: 10Reedy) [14:39:58] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Avoid abstract function errors in php 5.3.3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82800 (owner: 10Spage) [14:56:09] !notify [14:57:55] Rtdwivedi: try @notify (nick) [14:58:15] @notify Tpt [14:58:16] I'll let you know when I see Tpt around here [14:58:25] T13|needsCoffee: Thanks! [14:58:36] ;) [14:58:40] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.1.0 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:39:59] (03PS3) 10Frédéric Wang: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 [15:40:21] (03CR) 10jenkins-bot: [V: 04-1] MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [15:44:01] (03CR) 10Tobias Gritschacher: [C: 032] Update @covers tag [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/81217 (owner: 10Jeroen De Dauw) [15:44:02] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] ""Merge it yourself" -- TOBY" [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/81217 (owner: 10Jeroen De Dauw) [15:51:46] (03PS1) 10Chad: Unregister some unused submodules [extensions] - 10https://gerrit.wikimedia.org/r/82844 [15:52:20] (03CR) 10Chad: [C: 032] Unregister some unused submodules [extensions] - 10https://gerrit.wikimedia.org/r/82844 (owner: 10Chad) [15:52:27] (03CR) 10Chad: [V: 032] Unregister some unused submodules [extensions] - 10https://gerrit.wikimedia.org/r/82844 (owner: 10Chad) [15:58:54] (03CR) 10Hashar: [C: 031] "Sorry I have no clue what relative references are . Since we have tests for this, I guess it is fine :)" [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz) [15:59:11] (03CR) 10BryanDavis: "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [16:00:36] <^d> hashar: Hii :) [16:00:45] :-] [16:00:59] <^d> Sooo, jenkins was broken last night. [16:01:17] you killed manganese, so I guess Zuul was not able to connect with Gerrit ? [16:01:30] or is it something else? [16:01:33] <^d> I had updated zuul's config and restarted zuul :) [16:01:35] <^d> So something else. [16:01:55] what was the state of Jenkins? [16:01:56] <^d> So, all the repos in /srv/ssd/zuul/git/* have remotes that pointed to manganese explicitly. [16:02:05] <^d> So it was unable to fetch anything from origin. [16:02:06] oh man [16:03:04] looks like Zuul use the server it ssh stream events to as a remote [16:03:28] (03PS4) 10Frédéric Wang: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 [16:03:35] (03CR) 10jenkins-bot: [V: 04-1] MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [16:04:04] ^d: or at least it uses to do that and I forgot to refresh the remotes :( [16:04:05] <^d> hashar: So, I updated all the .git/config's to point to gerrit.wm.o instead of mangangese.wm.o [16:04:23] <^d> Generally speaking, I think we should point to gerrit. Jenkins/zuul shouldn't care (too much) where gerrit is. [16:05:48] ^d the patch I made a long time ago: https://review.openstack.org/#/c/16884/ [16:06:20] though I am not sure why I made Zuul ssh to the host instead of the service hostname gerrit.wm.o [16:06:23] (03PS1) 10Cmcmahon: update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 [16:07:12] (03CR) 10Anomie: "(2 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 (owner: 10Anomie) [16:07:22] (03PS2) 10Anomie: Delete forceHTTPS cookies on logout [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 [16:07:40] (03CR) 10Cmcmahon: "I'm not sure how mediawiki_username got out config.yml, but let's make the tests run in Jenkins and after git clone right away" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 (owner: 10Cmcmahon) [16:09:17] ^d: anyway nice fix and sorry for the trouble :( [16:10:14] (03CR) 10Frédéric Wang: "So I've updated the patch and only kept the upgrade to MathJax 2.3 (including the new upstream fix for issue556) and the improvements to h" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [16:16:27] <^d> hashar: No worries :) [16:18:28] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 (owner: 10Cmcmahon) [16:20:31] (03PS1) 10Reedy: Update DataValues and Wikibase to head of their branches [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82851 [16:21:10] (03CR) 10Reedy: [C: 032 V: 032] Update DataValues and Wikibase to head of their branches [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82851 (owner: 10Reedy) [16:25:23] hi ^d, busy? [16:25:34] yesterday you asked me to poke you about something today ;) [16:26:42] (change my gerrit display name to "Bartosz Dziewoński" with an "ń") [16:28:00] (03PS2) 10Cmcmahon: update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 [16:28:20] (03CR) 10Cmcmahon: "I think I'm good with that, it seems to work properly" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 (owner: 10Cmcmahon) [16:30:19] (03CR) 10Manybubbles: [C: 032] update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 (owner: 10Cmcmahon) [16:30:28] (03Merged) 10jenkins-bot: update username location for running in Jenkins etc. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82848 (owner: 10Cmcmahon) [16:33:19] (03PS1) 10Reedy: Add Option to Enable Keyword Links [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/82854 [16:36:32] YuviPanda: What have you done with my hotel!? [16:36:36] Er...alpha instance [16:36:48] i didn't touch alpha! I swear! [16:37:38] i'm only doing stuff on dragons [16:37:41] brion: hey! [16:37:49] brion: commits for you to review / merge :) minor ones [16:38:26] * marktraceur is still proud of the Fawlty Towers reference [16:38:37] marktraceur: ah, too bad I didn't get it :( [16:39:07] brion: https://gerrit.wikimedia.org/r/#/c/82780/ and https://gerrit.wikimedia.org/r/#/c/82779/ and https://gerrit.wikimedia.org/r/#/c/82782/ [16:39:28] brion: ignore the -1 from jenkins, it was just hallucinating. if you +2 it'll give it a +2 fine now [16:39:40] brion: would be nice to merge those before today's deployment cutoff [16:40:44] "What you do now" "I serve breakfast!" "Right, off you go then" [16:40:55] "Where door?" "A-ha!" [16:45:07] YuviPanda: http://multimedia-alpha.wmflabs.org/wiki/ is discouraging [16:45:22] (03CR) 10CSteipp: "Ah, sorry, I wasn't thinking it all the way through either." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 (owner: 10Anomie) [16:46:08] marktraceur: ah, that. that seems to be a labs issue that's bitten, so far, spagewmf and anomie (and perhaps others) [16:46:21] marktraceur: bug/issue in mediawiki_singlenode. [16:46:29] marktraceur: doesn't affect dragons since it doesn't use mediawiki_singlenode [16:46:38] marktraceur: ask anomie / spagewmf how they fixed it? [16:46:56] Sigh [16:47:01] * marktraceur waits for their response [16:47:38] YuviPanda, marktraceur: andrewbogott and Coren fixed it, then I did sudo puppetd -tv. Ask in #wikimedia-labs? [16:47:50] Doing so [16:50:35] (03CR) 10Siebrand: [C: 032] Change course status "Passed" to "Ended" to avoid ambiguity about "passing" a course. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 (owner: 10Ragesoss) [16:50:42] (03CR) 10jenkins-bot: [V: 04-1] Change course status "Passed" to "Ended" to avoid ambiguity about "passing" a course. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 (owner: 10Ragesoss) [16:52:10] (03CR) 10Siebrand: [C: 032] Add full-stops to error messages [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/82811 (owner: 10Shirayuki) [16:52:13] (03Merged) 10jenkins-bot: Add full-stops to error messages [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/82811 (owner: 10Shirayuki) [16:53:26] (03CR) 10Siebrand: [C: 032] Give grep a chance to find the usages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82813 (owner: 10Shirayuki) [16:53:40] (03Merged) 10jenkins-bot: Give grep a chance to find the usages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82813 (owner: 10Shirayuki) [16:54:04] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/82808 (owner: 10Raimond Spekking) [16:54:31] * YuviPanda pokes brion some more [16:54:32] ^d: Why can't I access https://gerrit.wikimedia.org/r/82813 ? [16:54:46] marktraceur: wfm [16:54:47] <^d> marktraceur: wfm? [16:54:52] "The page you requested was not found, or you do not have permission to view this page." [16:55:05] <^d> I was logged in and saw it. [16:55:18] <^d> And logged out. [16:55:27] i logged out and still saw it [16:55:33] * marktraceur is more confused, then [16:56:40] (03PS1) 10Manybubbles: Sort highlighted text by score. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82856 [16:56:44] Reedy: at what time do you cut the wmf releases for testwiki? [16:57:13] re: ugly APIs - behold, https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&list=allcampaigns&format=json&ucenabledonly=&uclimit=10 [16:58:24] YuviPanda: json containing strings containing json containing html? niiiice. [16:58:41] so many backslashes. [16:59:11] yeah [16:59:46] MatmaRex: couldn't think of a better way, though - to put JSON in xml, json, everything [17:00:17] YuviPanda: do you really need the json format? [17:00:30] YuviPanda: you could disable all formats but json, templatedata does this [17:00:48] https://git.wikimedia.org/branches/mediawiki%2Fcore.git [17:01:00] MatmaRex: I'm using this in the App, and the app currently does XML [17:01:07] (horrible, I know) [17:01:08] good ol'XML [17:01:09] (03PS1) 10Jeroen De Dauw: Update method names to avoid confusion and bump to 2.0 [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/82860 [17:01:58] Reedy: aww, damn. [17:03:20] MatmaRex: think you can merge a couple of trivial patches from me, and then I can convince reedy to put them in wmf16? [17:03:50] (https://gerrit.wikimedia.org/r/#/c/82782/ and https://gerrit.wikimedia.org/r/#/c/82780/ and https://gerrit.wikimedia.org/r/#/c/82779/) [17:04:18] brion: marktraceur, perhaps even bd808 ^ [17:05:44] (03CR) 10Matmarex: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82782 (owner: 10Yuvipanda) [17:05:53] (03CR) 10Matmarex: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82780 (owner: 10Yuvipanda) [17:05:57] (03CR) 10Matmarex: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [17:06:13] YuviPanda: i tend to be afraid to touch extensionsi don't know and barely use [17:06:54] YuviPanda: I'll try to look at them. [17:07:13] they're all deployed at blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns [17:07:21] (03CR) 10Matmarex: [C: 032] Use appropriate method to make Special Subpage URL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82782 (owner: 10Yuvipanda) [17:07:28] okay, that one was trivial [17:07:36] :D [17:07:49] but i'm not touching the real stuff, especially if there's someone else willing to :D [17:08:46] MatmaRex: but thanks for merging one :) [17:08:55] (03PS1) 10Jeroen De Dauw: Update README file [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/82862 [17:08:57] MatmaRex: wanna take a look at https://gerrit.wikimedia.org/r/#/c/82799/ ? mainly for sanity :P [17:09:21] > detect unclosed HTML tags [17:09:22] > sanity [17:09:28] with regex! [17:09:46] (03CR) 10BryanDavis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [17:09:52] legoktm: http://stackoverflow.com/a/1732454/17865 [17:10:44] YuviPanda: Good luck writing a proper wikitext parser in javascript ;) [17:10:50] (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [17:10:55] legoktm: you mean, like parsoid? :P [17:11:10] https://www.youtube.com/watch?v=xECUrlnXCqk [17:11:14] (03PS1) 10Anomie: Make CentralAuthUser::deleteGlobalCookies and clearCookie static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82863 [17:11:18] bd808: doing a new patchset for that, since it crosses multiple patchset boundaries [17:11:23] (03PS1) 10Anomie: Clean up use of ->text() with HTML [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82864 [17:11:29] parsoid isn't available for public consumption yet, and i dont want a dependency on that [17:11:36] (03PS3) 10Anomie: Delete forceHTTPS cookies on logout [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 [17:11:37] YuviPanda: do you want +2 on the orginals? [17:11:43] bd808: yes [17:12:09] legoktm: parsoid is very much available for public consumption [17:12:10] (03CR) 10BryanDavis: [C: 032] "Yuvi will refactor var refs in new patch." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [17:12:12] legoktm: i'm pretty sure that #match only returns one match [17:12:16] (03Merged) 10jenkins-bot: Add tracking category to UploadCampaign API call [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82779 (owner: 10Yuvipanda) [17:12:43] (03CR) 10BryanDavis: [C: 032] "Yuvi will refactor var refs in new patch." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82780 (owner: 10Yuvipanda) [17:12:49] (03Merged) 10jenkins-bot: Use appropriate method to make Special Subpage URL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82782 (owner: 10Yuvipanda) [17:12:50] (03Merged) 10jenkins-bot: Add totalUploads & totalContributions to the API [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82780 (owner: 10Yuvipanda) [17:12:51] ty, bd808 [17:13:02] np [17:13:03] MatmaRex: you mean 'matches = code.match(regex);'? that matches all the tags in the text when I tested it [17:13:04] legoktm: brb, i'll look at it later [17:13:06] ok [17:13:16] gwicke: oh it is? :D [17:13:29] gwicke: is the public api documented anywhere? [17:14:08] legoktm: I am hoping to finish the PHP API this week [17:14:27] the JS API is as simple as requesting /en/Pagename [17:14:32] ok. i was thinking of a /w/api.php endpoint? [17:14:37] see http://parsoid.wmflabs.org/ [17:15:04] oh i see [17:15:27] hm, i guess parsoid won't be enabled on all wikis until VE gets rolled out? [17:15:28] legoktm: we'll add an api.php wrapper any time now that uses our internal parsoid cluster as the backend [17:15:36] ok :D [17:15:52] (03PS1) 10Yuvipanda: Refactor out the path of the campaign in the API result [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82865 [17:15:55] bd808: ^ [17:15:57] done! [17:16:03] but you can already use parsoid.wmflabs.org or your own install on any wiki [17:16:21] example: http://parsoid.wmflabs.org/enwikivoyage/Hong_Kong [17:16:40] ohohoh! [17:17:06] the Kiwix folks used that to create an offline copy of wikivoyage at Wikimania [17:17:17] in ~1000 lines of JS: http://sourceforge.net/p/kiwix/other/ci/master/tree/mwhtmldumper/mwhtmldumper.js [17:17:35] (03CR) 10BryanDavis: [C: 032] Refactor out the path of the campaign in the API result [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82865 (owner: 10Yuvipanda) [17:17:39] (03Merged) 10jenkins-bot: Refactor out the path of the campaign in the API result [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82865 (owner: 10Yuvipanda) [17:18:04] Reedy: can you update UploadWizard to master for wmf16 and sync again? [17:19:44] ^d: FYI it looks like the permission error in Gerrit is happening on patchsets updated in the last few hours, but not ones before...maybe to do with the upgrade? [17:20:02] <^d> I dunno. [17:20:48] Grumble grumble grumble [17:21:21] Not being able to see patchsets that have been updated recently is going to be mildly limiting. [17:21:30] marktraceur: log out and back in? [17:21:58] (03CR) 10Kaldari: [C: 032] "Brilliant." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77824 (owner: 10Matmarex) [17:22:20] Oh, hm, core patches are fine, but UW patches aren't [17:22:39] (03Merged) 10jenkins-bot: Make items on notifications flyout behave like links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77824 (owner: 10Matmarex) [17:22:59] Other extensions seem OK [17:23:09] Maybe it's patches I'm CC'd on [17:28:11] (03CR) 10CSteipp: [C: 031] "Still need to test, but I think we'll merge this" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82863 (owner: 10Anomie) [17:34:45] * YuviPanda pokes Reedy [17:34:53] (03CR) 10MarkTraceur: "(3 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:35:01] * YuviPanda pokes grrrit-wm [17:35:02] gah [17:35:12] * YuviPanda pokes greg-g [17:35:25] what? [17:35:37] greg-g: a couple of commits missed out on wmf16 for UW, think I can convince someone to update UW again? [17:35:38] YuviPanda: y u poke? [17:35:40] UploadWizard [17:35:43] ah [17:35:52] which ones? [17:36:00] give the list to Reedy [17:36:07] https://gerrit.wikimedia.org/r/#/c/82779/ https://gerrit.wikimedia.org/r/#/c/82780/ https://gerrit.wikimedia.org/r/#/c/82782/ [17:36:11] they got merged into master [17:36:15] so updating it to master should work [17:36:17] (03CR) 10Esanders: "Might make more sense to have the count after the description." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82776 (owner: 10MarkTraceur) [17:36:23] we already deployed, but, if high importance.... [17:36:42] YuviPanda: nothing else is between what is deployed and master other than those 3 commits? [17:36:59] greg-g: verifying, moment. [17:37:01] YuviPanda: are thigns broken or just not as good as they could be? [17:37:03] k [17:37:41] greg-g: i18n is broken (fixed in https://gerrit.wikimedia.org/r/#/c/82782/) and the others are required by the app. [17:37:47] * greg-g nods [17:38:58] greg-g: another change was merged, but that is effectively a no-op since that only modified comments [17:39:04] * greg-g nods [17:39:05] (https://gerrit.wikimedia.org/r/82813) [17:39:29] YuviPanda: so, can you deploy? you have rights? have you done before? [17:39:56] (03CR) 10Matmarex: "The alternate solution at https://gerrit.wikimedia.org/r/#/c/77824/ has been merged. Sorry about the wasted work I caused here." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76943 (owner: 10Alex Monk) [17:39:58] greg-g: sadly I don't have rights. but I believe marktraceur does, and perhaps I can convince him... [17:40:00] (03Abandoned) 10Matmarex: Fix middle click on notifications in the overlay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76943 (owner: 10Alex Monk) [17:40:21] Sigh [17:40:24] Yeah, you could [17:40:32] marktraceur: how do you feel about using the LD today for these? [17:40:37] Are we doing this twenty minutes before metrics? Oh, LD, better. [17:40:38] is it worth the effort, or wait until next week? [17:40:44] LD would work [17:40:47] k [17:40:49] When is it, 15:30? [17:40:54] 16:30 [17:41:01] Fine by m.eee [17:41:04] me even [17:41:08] er, 16 [17:41:12] Even better [17:41:14] until 16:30 [17:41:16] marktraceur: I won't be around by 16:00, is that okay? [17:41:25] YuviPanda: Do the changes require anything weird? [17:41:28] I've to wake up before 9pm tomorrow so I can actually change some cash into dollars [17:41:29] marktraceur: nope [17:41:41] No db updates, no maintenance scripts, no nothing? [17:41:44] nope [17:41:47] Sexy. [17:42:01] YuviPanda: Good luck with your alchemy, I'll take care of it [17:42:11] ty! [17:42:14] We'll maybe talk about training you on deployment while yer in town [17:42:26] I was supposed to wake up at 4pm today, but ended up waking up at 9pm. [17:42:26] grrr [17:42:42] Do you not have an alarm? [17:42:56] marktraceur: I've an alarm, plus 4 people in the same room who are awake and going about doing things [17:43:12] Sounds exciting [17:43:15] marktraceur: I seem to be unaffected. [17:43:19] * marktraceur walks towards metrics [17:43:22] (03PS1) 10Ori.livneh: Turn off HTTPS capability testing for now [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/82868 [17:43:44] thanks marktraceur [17:44:57] (03CR) 10CSteipp: [C: 032] "Working fine in test" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82863 (owner: 10Anomie) [17:45:00] (03Merged) 10jenkins-bot: Make CentralAuthUser::deleteGlobalCookies and clearCookie static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82863 (owner: 10Anomie) [17:45:19] thanks, greg-g :) [17:45:43] * greg-g adds to deploy calendar [17:46:34] legoktm: that code looks sane (asusming it works) [17:46:58] ok :P [17:47:00] one other question, [17:47:10] brb [17:47:19] GorillaWarfare: how goes the move? [17:47:40] greg-g: can you look at 82868? [17:47:51] right now I use the focusOut event, but if the user clicks the "preview" button right away, then they wont have time to see the notification [17:48:11] (03CR) 10Chad: [C: 032] Switch queries to ANDing terms together. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82825 (owner: 10Manybubbles) [17:48:13] (03Merged) 10jenkins-bot: Switch queries to ANDing terms together. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82825 (owner: 10Manybubbles) [17:48:23] is there any better way to run it after the user has finished typing but not hit preview yet? [17:48:46] legoktm: you could always bind to 'keyup' event, but this might be too expensive for that [17:48:46] (03CR) 10Chad: [C: 032] Tests for switching to ANDing query terms together [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82827 (owner: 10Manybubbles) [17:48:48] (03Merged) 10jenkins-bot: Tests for switching to ANDing query terms together [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82827 (owner: 10Manybubbles) [17:48:58] but we have a fun jquery plugin in core just for that, once sec [17:49:05] (03CR) 10Chad: [C: 032] Sort highlighted text by score. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82856 (owner: 10Manybubbles) [17:49:08] (03Merged) 10jenkins-bot: Sort highlighted text by score. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82856 (owner: 10Manybubbles) [17:49:30] (03CR) 10Greg Grossmeier: [C: 031] "That's fine. If we want similar data again, we might do it differently anyways. Thanks for the effort and response time with this work, Or" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/82868 (owner: 10Ori.livneh) [17:49:56] (03CR) 10BryanDavis: [C: 031] Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [17:50:06] legoktm: but we have a fun jquery plugin in core just for that, once sec [17:50:12] (03PS1) 10Euvl: Making templates work with semantic glossary and lingo [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/82870 [17:50:15] ok [17:50:16] !master resources/jquery/jquery.delayedBind.js | legoktm [17:50:16] legoktm: https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/resources%2fjquery%2fjquery.delayedBind.js [17:51:06] legoktm: i think it's used for 'resize' and 'scroll' events in a few places [17:51:14] ok, i'll try and find an example [17:51:36] !master skins/vector/collapsibleTabs.js [17:51:36] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/skins%2fvector%2fcollapsibleTabs.js [17:51:39] here's one ^ [17:52:09] heh, github code search sucks. [17:52:16] it quite does. [17:52:40] so something like [17:53:36] (03CR) 10CSteipp: [C: 032] "Working in test for me. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82864 (owner: 10Anomie) [17:53:39] (03Merged) 10jenkins-bot: Clean up use of ->text() with HTML [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82864 (owner: 10Anomie) [17:53:54] $( '#mw-massmessage-form-message' ).delayedBind( '500', 'keyup', function ( my function ) ); [17:53:56] ? [17:54:22] probably will work, try it :D [17:54:29] also, drop the quotes on 500 [17:54:38] dunno why they are there in that script, they shouldn't [17:55:29] (03CR) 10Parent5446: [C: 032] Reorder SpecialRecentChanges::webOutput [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [17:55:47] ok [17:56:08] (it doesn't matter anyway) [17:56:28] okay, now. where's swalling when i need him? [17:56:58] (03CR) 10MaxSem: "Is anyone still interested in working on this?" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [17:57:52] (03CR) 10jenkins-bot: [V: 04-1] Reorder SpecialRecentChanges::webOutput [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [17:57:56] (03PS5) 10Frédéric Wang: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 [17:58:01] MatmaRex: woot, that works :D [17:58:16] (03CR) 10jenkins-bot: [V: 04-1] MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [17:58:26] is there a way i can prevent it from sending another notification until the current one disappears? [17:58:59] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/2747/consoleFull [17:59:08] I fail to find the failure again :/ [17:59:15] and hashar is nothere now [18:00:15] (03CR) 10Parent5446: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [18:00:19] (03PS6) 10Frédéric Wang: MathJax 2.3 upgrade and loading improvement [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 [18:00:32] legoktm: yay [18:00:39] legoktm: i think yes, one sec [18:02:32] legoktm: mw.notify( 'text', { tag: 'massmessage-html-warning' } ) [18:02:36] - tag: [18:02:36] An optional string. When a notification is tagged only one message [18:02:36] with that tag will be displayed. Trying to display a new notification [18:02:36] with the same tag as one already being displayed will cause the other [18:02:36] notification to be closed and this new notification to open up inside [18:02:36] the same place as the previous notification. [18:02:54] (this is from mediawiki.notification.js) [18:02:56] !docs [18:02:57] An overview of available documentation about MediaWiki can be found at [18:02:59] ah neat. [18:03:01] thanks [18:03:11] i wonder if it's visible in the jsduck docs [18:03:25] because that script is a special little snowflake that does everything differently [18:04:13] actually yeah, it's sort of there. neat. https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.notification-property-defaults [18:04:58] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [18:05:36] (03CR) 10Matmarex: "Stupid fucking timing out shitty tests." [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [18:05:37] (03CR) 10Parent5446: "Hmm, is there any way to get Jenkins to re-run? Looks like a timeout error." [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [18:05:43] parent5446: can you +2 again? it should work now ^ [18:05:45] heh [18:05:46] nice timing [18:05:54] (03CR) 10Ori.livneh: [C: 032] Turn off HTTPS capability testing for now [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/82868 (owner: 10Ori.livneh) [18:05:58] (03Merged) 10jenkins-bot: Turn off HTTPS capability testing for now [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/82868 (owner: 10Ori.livneh) [18:06:06] parent5446: just removing jenkins as reviewer and +2-ing again should do it [18:06:29] (03CR) 10Matmarex: "Just removing jenkins as reviewer and +2-ing again should do it." [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [18:06:55] Kk, doing that now. [18:07:00] Oh already done [18:07:14] Thanks for the tip anyway. [18:08:06] (as in, remove your +2 and comment with +2 again - you can just remove yourself from reviewers list) [18:08:29] Oh, OK. [18:08:37] (03CR) 10Parent5446: [C: 032] Reorder SpecialRecentChanges::webOutput [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [18:08:53] OK, there it goes. [18:10:38] MaxSem: re https://gerrit.wikimedia.org/r/#/c/63363/ - it looks interesting, i'll try to do something similar to what he did, but with feeling :D [18:12:10] (03Merged) 10jenkins-bot: Reorder SpecialRecentChanges::webOutput [core] - 10https://gerrit.wikimedia.org/r/65325 (owner: 10Matmarex) [18:12:23] thanks parent5446 [18:13:31] MatmaRex: ok, so that works, but a little annoying that it has to hide the old one and popup a new one. i'm guessing there's no way i can just adjust the text in the notification itself? [18:14:42] legoktm: apart from hacking up some sutff yourself i don't know of any [18:15:03] legoktm: VE does some fun things with these notifications, you coulf try looking at it / asking them [18:15:14] legoktm: (the notif when you input wikitext in VE) [18:15:35] ok, ill take a look [18:19:12] wtf, gerrit wont let me update the patchset [18:19:18] To ssh://legoktm@gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage.git [18:19:18] ! [remote rejected] HEAD -> refs/publish/master/badhtml (change 82796 closed) [18:19:18] error: failed to push some refs to 'ssh://legoktm@gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage.git' [18:19:27] that's a different patchset [18:20:07] hm [18:20:09] something is wrong.. [18:20:37] <^d> The change is already merged. [18:20:44] <^d> You can't update it. [18:20:59] I'm trying to update a different patch [18:21:13] (03PS1) 10Reedy: Update UploadWizard to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82876 [18:21:17] km-mpb:MassMessage km$ git pull [18:21:17] From ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage [18:21:17] + 8587e2e...b9ccd1c master -> gerrit/master (forced update) [18:21:17] Already up-to-date. [18:21:25] i've never seen that before... [18:21:28] <^d> git status [18:21:29] <^d> ? [18:21:51] # On branch badhtml [18:21:52] nothing to commit, working directory clean [18:21:55] when i'm on master, i see [18:22:04] # Your branch is ahead of 'gerrit/master' by 1 commit. [18:22:23] legoktm: git fetch gerrit can't hurt [18:22:24] but, that commit was merged already, and when i git pull, it doesn't update [18:22:27] <^d> git fetch --all [18:22:30] <^d> git rebase gerrit/master [18:22:44] km-mpb:MassMessage km$ git fetch gerrit [18:22:44] km-mpb:MassMessage km$ git rebase gerrit/master [18:22:44] Current branch master is up to date. [18:23:08] <^d> Rebase badhtml branch on master? [18:23:10] Yippie, build fixed! [18:23:10] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #216: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/216/ [18:23:58] https://dpaste.de/SYweu/raw/ [18:24:14] but that "Fix typo" commit was merged already, and i havent changed it locally at all [18:25:33] <^d> So, git-review is confused about what's merged and what's not. [18:25:38] <^d> Git it obviously correct here. [18:25:57] <^d> Ignore git-review. Do this: `git push gerrit HEAD:refs/for/master` [18:26:21] nope, same error [18:26:23] +1 to ignoring git review [18:26:32] <^d> Bah. [18:27:54] ^d: When I did a fresh clone, the fix typo commit is missing. [18:28:28] ^d: https://dpaste.de/TSbPu/raw/ [18:28:51] <^d> Bah, wonder if this is related to my other problem... [18:28:53] Yippie, build fixed! [18:28:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #216: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/216/ [18:30:55] ok. i think if i rebase on gerrit/master, and just drop the Fix typo commit in my current one, that'll at least let me upload a new patchset [18:30:58] ^d: are you familiar with jenkins issues, or is it hashar? [18:31:18] ^d: I can't find the cause of https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/2747/console [18:32:01] cause of the failure there [18:32:18] ^d: ! [remote rejected] HEAD -> refs/publish/master/badhtml2 (n/a (unpacker error)) <-- wtf? [18:32:39] <^d> Yeah that's what I figured. [18:35:47] ok, i'll just wait then i guess. [18:41:06] (03CR) 10Reedy: [C: 032 V: 032] Update UploadWizard to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82876 (owner: 10Reedy) [18:43:07] 1 PHP Fatal error: Call to a member function parseParamString() on a non-object in /usr/local/apache/common-local/php-1.22wmf15/includes/specials/SpecialUploadStash.php on line 137 [18:45:15] Yippie, build fixed! [18:45:16] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #265: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/265/ [18:45:34] bd808: https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 might be of interest to you [18:46:50] Reedy: thanks. I'll talk a look. [18:47:18] 7 or so occurances in the last 6 or 7 hours [18:47:26] ouch [18:48:28] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #222: FAILURE in 0.85 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/222/ [18:48:32] Project browsertests-en.wikipedia.org-linux-firefox build #282: FAILURE in 0.73 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/282/ [18:48:33] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #155: FAILURE in 0.71 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/155/ [18:48:38] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #255: FAILURE in 1.4 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/255/ [18:48:39] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #243: FAILURE in 0.67 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/243/ [18:48:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #429: FAILURE in 0.56 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/429/ [18:48:51] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #19: FAILURE in 0.71 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/19/ [18:48:51] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #19: FAILURE in 0.8 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/19/ [18:48:56] Project VisualEditor-test2.wikipedia.org-linux-firefox build #17: FAILURE in 0.71 sec: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/17/ [18:49:00] (Gerrit is down if people didn't notice.) [18:53:24] Data is being moved [18:53:49] hmm? [18:55:37] jenkins 503 Service Temporarily Unavailable? [18:55:40] ^d: ^ [18:55:48] <^d> Yeah we're fixing something. [18:55:51] <^d> Oh, jenkins? [18:55:58] sorry [18:55:59] gerrit [18:56:07] ^d: ^ [18:56:08] <^d> Yeah, gerrit's down for a few mins. [18:56:10] <^d> It'll be back. [18:59:02] <^d> Ok, should all be back now. [19:02:50] ^d: ! [remote rejected] HEAD -> refs/publish/master/badhtml2 (change 82799 missing revisions) <-- or did you not fix this problem yet? [19:03:35] <^d> I don't know what would cause that. [19:03:43] :/ [19:03:52] <^d> The change has all attached commits. [19:03:53] <^d> Looks to me. [19:04:28] I just did a fresh clone, that "Fix typo" commit is still missing [19:13:42] 3 PHP Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/ [19:13:43] extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php on line 360 and defined in /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_ [19:13:43] body.php on line 40 [19:13:54] Who wants the blame for that one? [19:14:06] I guess AFTv5 [19:14:11] hmm, also https://test.wikipedia.org/w/index.php?title=Campaign:wlm-pl is missing styles. [19:16:00] hmm, weird caching issue, I guess. has styles now [19:16:12] (03CR) 10Foxtrott: "(3 comments)" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [19:20:18] Reedy: I can see how bz:53820 can happen. It's possible for MediaHandler::getHandler() [19:20:18] to return false instead of object and nothing checks along that path. Seems like it would be due to corrupt file that MimeMagic can't figure out mime type for. [19:22:27] (03PS1) 10Liangent: Add plain colon and semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 [19:26:16] (03CR) 10jenkins-bot: [V: 04-1] Add plain colon and semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 (owner: 10Liangent) [19:31:09] (03PS2) 10Liangent: Add plain semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 [19:32:24] liangent: what happened? [19:32:29] I'm here. [19:32:43] err [19:32:45] sorry liangent [19:32:46] i meant, legoktm [19:34:00] YuviPanda: [12:33:54 PM] (NEW) Campaigns 'title' key lets you mess with page layout - https://bugzilla.wikimedia.org/53822 normal; MediaWiki extensions: UploadWizard; () [19:34:03] hey anybody know why the pretty button styles seem to be missing on test.wikipedia ? [19:34:18] ugh [19:34:20] https://test.wikipedia.org/w/index.php?title=Special:UserLogin <- doesn't show the pretty blue button style [19:34:20] sidenote* [19:35:11] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82799 (owner: 10Legoktm) [19:35:42] legoktm: 'description' would also let you mess with it [19:35:47] probably [19:37:45] brion: Guess it's something broken in 1.22wmf16 [19:37:57] poop [19:37:59] YuviPanda: maybe limit it to whatever DISPLAYTITLE: does? [19:38:14] letting people add html/css like that is a pretty serious issue [19:38:26] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [19:38:58] hmm no network load errors [19:39:48] YuviPanda: https://bugzilla.wikimedia.org/53823 [19:39:54] urgh safari changed their debug tools, i can't find the damn inspector [19:39:57] (03PS1) 10Ragesoss: Add comments to clarify the structure of the extension. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 [19:39:57] legoktm: hmm, I want to be as restrictive as wikitext on a normal page [19:40:21] on a normal page, you can use {{DISPLAYTITLE:blah}} [19:40:31] ok back to chrome [19:40:34] of course, you can do some
stuff to cover it up or what not [19:40:46] enwiki has an abusefilter against that stuff though [19:41:23] legoktm: so are there any attacks people can do via title and display here that they can't do on a normal page? [19:41:36] yes [19:41:38] legoktm: the reason it is wikitext is to make i18n easier [19:41:41] or at least, easier attacks. [19:41:57] legoktm: how about if I run it through tidy? that'll fix unclosed tags [19:42:02] that should work [19:42:12] ok so it's https://test.wikipedia.org/wiki/MediaWiki:Common.css [19:42:55] YuviPanda: would that fix stuff like '''booold ? [19:43:18] legoktm: well, first i run it through the parser and then run it through tidy [19:43:24] ok [19:43:26] I already thought the parser ran it through tiday [19:44:45] brion: probably blame Elsie? [19:45:39] https://test.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=179053&oldid=176120 booyah [19:45:55] and…. we have pretty buttons again [19:46:00] fixed! [19:46:30] YuviPanda: actually, i dont think allowing wikitext is a good idea at all: https://test.wikipedia.org/wiki/Campaign:wlm-pl [19:47:08] * YuviPanda sees diff [19:47:35] (03PS16) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [19:47:48] legoktm: you can do that on a normal wiki page too [19:47:53] YuviPanda: not for the title [19:48:30] legoktm: well, the title here is still wlm-pl. This kinda vandalism would be as possible with description too [19:48:43] https://test.wikipedia.org/wiki/User:Legoktm <-- compare that with source of the page [19:50:03] legoktm: hmm, so I can put that for title, but you can still put a large image in description [19:50:14] (03PS1) 10Jeroen De Dauw: Update dependency names [extensions/Validator] - 10https://gerrit.wikimedia.org/r/82889 [19:50:15] i suppose. [19:50:34] (03CR) 10Jeroen De Dauw: [C: 032] Update dependency names [extensions/Validator] - 10https://gerrit.wikimedia.org/r/82889 (owner: 10Jeroen De Dauw) [19:51:12] legoktm: so yeah, I don't know if that'll be of any use. [19:51:24] idk [19:51:33] what was your proposed intention of allowing wikitext? [19:51:59] legoktm: i18n [19:52:13] normal pages can be vandalized the same way, see https://test.wikipedia.org/wiki/User:Legoktm now. [19:52:22] how? with a {{#switch: {{int:lang}} }} ? [19:53:16] why not just do a json object like {'title': {'en':'english', 'de':'german' } } ? [19:53:39] legoktm: moment, let me show you [19:54:46] legoktm: via https://commons.wikimedia.org/wiki/Template:Upload_campaign_use_Wiki_Loves_Monuments [19:55:01] legoktm: so if you look at https://commons.wikimedia.org/w/index.php?title=Campaign:wlm-nl&action=edit, display.headerLabel / display.thanksLabel [19:55:19] ehhhhhhh [19:55:19] you'll see that it just includes the template, and by parsing it with appropriate language I get the output in the language I want [19:55:53] I guess wgNamespaceProtection isnt cascading [19:55:59] hmmm? [19:57:01] legoktm: Campaign: is admin only mostly for now [19:57:11] Campaign pages are protected, but you can edit a template, and you will change the campaign page [19:57:16] vandalism through template transclusion [19:59:06] bbl [20:00:30] (03PS5) 10Kaldari: Removing all disambiguation code from core [core] - 10https://gerrit.wikimedia.org/r/74096 [20:00:57] (03CR) 10jenkins-bot: [V: 04-1] Removing all disambiguation code from core [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [20:01:26] legoktm: mm, true. but then again, if there's vandalism, those can be protected too. [20:02:04] no premature extra protections :P [20:02:07] If you needed to, you could always use cascading protection, but that has its own issues. [20:02:24] You could easily lock down something you shouldn't [20:04:03] (03Abandoned) 10Liangent: Add plain semicolons to wfEscapeWikitext(). [core] - 10https://gerrit.wikimedia.org/r/82887 (owner: 10Liangent) [20:05:22] (03CR) 10Matmarex: "If the issue is just release notes, you can use https://github.com/MatmaRex/mediawikireleasenotes-driver to fix it." [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [20:09:10] (03CR) 10Swalling: [C: 031] "Working fine on toro still for me." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:10:07] (03PS6) 10Kaldari: Removing all disambiguation code from core [core] - 10https://gerrit.wikimedia.org/r/74096 [20:15:26] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [20:17:50] Ugh [20:17:54] I'm live hacking that fatal [20:20:02] (03CR) 10Spage: [C: 032] "(2 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 (owner: 10Mattflaschen) [20:20:25] (03Merged) 10jenkins-bot: Filter out elements that are not :visible when attaching. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 (owner: 10Mattflaschen) [20:24:08] (03CR) 10Spage: [C: 032] "I tried it on a wiki without VE, StevenW tried it with." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:24:11] (03CR) 10jenkins-bot: [V: 04-1] Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:24:30] (03PS16) 10Spage: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:25:49] Yippie, build fixed! [20:25:49] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #307: FIXED in 9 min 50 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/307/ [20:29:12] (03PS1) 10Reedy: Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82979 [20:29:36] (03CR) 10Reedy: [C: 032 V: 032] Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/82979 (owner: 10Reedy) [20:32:45] mlitn: around? does this mean anything to you? Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /data/project/apache/common-local/php-master/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php [20:33:00] ... [20:33:16] Reedy: ??? that just started happening on beta [20:33:25] See a few lines above [20:33:29] I just lived hacked it out for production [20:33:47] Reedy: eh, wish I'd checked beta earlier then, sorry about that [20:34:04] thus we need *monitoring* of fatals and stuff [20:34:19] There's a bug for it [20:34:28] Have you seen ori-l-away's graphs? [20:34:36] not to my knowledge [20:35:03] Reedy: how did you fix it? [20:35:28] Put a return false at the top of the method in AFTv5 [20:35:48] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FArticleFeedbackv5.git/refs%2Fheads%2Fwmf%2F1.22wmf16 [20:36:15] https://ganglia3.wikimedia.org/latest/?r=hour&cs=&ce=&m=cpu_report&s=by+name&c=Miscellaneous+eqiad&h=vanadium.eqiad.wmnet&host_regex=&max_graphs=0&tab=m&vn=&sh=1&z=small&hc=4 [20:36:23] chrismcmahon: Scroll down to "mediawiki metrics" [20:39:40] ^demon|busy: Still looking into the gerrit issues? I can't push new patchsets now :( [20:39:46] At least for one patch [20:39:51] <^demon|busy> Which patch? [20:40:00] https://gerrit.wikimedia.org/r/82776 [20:40:13] Trying to fix the inline issues, git review -R with the amended patch [20:40:33] ^d: http://paste.marktraceur.info/199 output [20:40:41] (03CR) 10Spage: [C: 032] "Not sure why jenkins couldn't merge PS15; PS16 looks fine." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:43:54] chrismcmahon1: didn't ring a bell; I'll look into fixing it properly now [20:44:05] thanks for the hotfix, Reedy :) [20:44:22] Crap [20:44:23] mlitn: Reedy sorry, laptop froze just now. I do see https://gerrit.wikimedia.org/r/#/c/82979/ [20:44:32] I hotfixed it on wmf16 [20:44:39] Not wmf15 where it's actually making all the noise [20:45:36] (03Merged) 10jenkins-bot: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [20:46:31] (03PS1) 10Anomie: Fix returnto in p-personal generated by JS check [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83007 [20:48:34] (03PS1) 10Reedy: Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83009 [20:49:45] (03CR) 10Reedy: [C: 032 V: 032] Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83009 (owner: 10Reedy) [20:50:00] (03PS1) 10BryanDavis: Assert that $this->handler is not false. [core] - 10https://gerrit.wikimedia.org/r/83010 [20:50:27] (03CR) 10CSteipp: [C: 032] "Looks sane, and working well in test so far." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 (owner: 10Anomie) [20:52:57] Yippie, build fixed! [20:52:58] Project browsertests-en.wikipedia.org-linux-firefox build #283: FIXED in 4 min 50 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/283/ [20:54:03] (03PS1) 10Spage: Update GuidedTour to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83011 [20:54:41] (03Merged) 10jenkins-bot: Delete forceHTTPS cookies on logout [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 (owner: 10Anomie) [20:59:37] (03CR) 10Spage: [C: 032] Update GuidedTour to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83011 (owner: 10Spage) [20:59:58] (03PS1) 10Matthias Mullie: Update SpamBlacklist related code [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 [21:00:37] (03CR) 10Kaldari: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [21:00:56] (03CR) 10CSteipp: [C: 032] Fix returnto in p-personal generated by JS check [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83007 (owner: 10Anomie) [21:01:25] (03Merged) 10jenkins-bot: Fix returnto in p-personal generated by JS check [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/83007 (owner: 10Anomie) [21:01:30] (03PS2) 10Matthias Mullie: (bug 53821) Update SpamBlacklist related code [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 [21:02:32] (03Merged) 10jenkins-bot: Update GuidedTour to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83011 (owner: 10Spage) [21:02:33] Seems gerrit<->Zuul changed so that the "Starting gate-and-submit" doesn't appear in gerrit until it's finished. [21:03:55] actually, kaldari [21:06:48] (03CR) 10BryanDavis: "I didn't find any obvious unit tests for File.php. Did I just not dig in the right place?" [core] - 10https://gerrit.wikimedia.org/r/83010 (owner: 10BryanDavis) [21:07:58] (03PS7) 10Kaldari: Removing all disambiguation code from core [core] - 10https://gerrit.wikimedia.org/r/74096 [21:09:24] (03CR) 10Matmarex: [C: 032] "Begone!" [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [21:13:05] (03Merged) 10jenkins-bot: Removing all disambiguation code from core [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [21:15:02] (03PS1) 10Mwjames: Nicified Special:Properties search form [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83014 [21:15:16] (03CR) 10Siebrand: "'disambiguations-summary' is probably orphaned in maintenance/language/messageTypes.inc." [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [21:16:19] aww [21:17:55] (03PS10) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [21:23:36] (03CR) 10Siebrand: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna) [21:26:32] (03CR) 10Siebrand: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 (owner: 10EBernhardson (WMF)) [21:30:23] (03PS1) 10Spage: Update GuidedTour to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83016 [21:31:16] (03CR) 10Spage: [C: 032] "5ed1115 is latest" [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83016 (owner: 10Spage) [21:32:31] mwalker: Just about finished :) Finally set up our extra router so I can get a usable internet speed on my desktop [21:33:05] ^d: Much luck? [21:33:13] <^d> Still working. [21:33:21] (03CR) 10Siebrand: [C: 031] "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [21:35:09] (03Merged) 10jenkins-bot: Update GuidedTour to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83016 (owner: 10Spage) [21:36:04] GorillaWarfare: shiney! fast internet is key for productivity -- faster response times to goofing off :p But more seriously; GSOC says you have about a week and a half remaining before you should transition to a documentation phase -- how're you feeling about that? [21:39:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n is fine." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 (owner: 10Legoktm) [21:41:24] mwalker: Feeling okay. There are always things that will still need to be done, so I'll probably just stop, do documentation, etc., and pick up later [21:43:17] (03PS4) 10Kaldari: Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 (owner: 10Bsitu) [21:43:19] it'd be amazing if you were in a place to deploy something by the end; but looking at your list of open bugs there's a lot of bold in it [21:43:45] There is [21:45:38] (03CR) 10Kaldari: [C: 032] Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 (owner: 10Bsitu) [21:45:46] (03Merged) 10jenkins-bot: Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 (owner: 10Bsitu) [21:46:30] (03CR) 10Siebrand: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [21:47:32] (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [21:48:15] (03CR) 10Kaldari: "Can you add a TODO comment to the Nostalgia extension?" [core] - 10https://gerrit.wikimedia.org/r/80716 (owner: 10Matmarex) [21:48:43] (03CR) 10Siebrand: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [21:49:23] (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [21:58:59] GorillaWarfare: I guess what I'm getting at is if there is anything I can do to help you get to something that's deployable let me know -- I may take a poke at some of the bugs you havent licked this weekend [21:59:50] Alright, thank you. I can't think of anything specific; I just need the time to fix the bugs [21:59:55] The move/school starting has set me back [22:00:30] indeed; homework >>> GSOC in terms of importance [22:01:45] mwalker: Homework is shifted bitwise right GSOC times? [22:02:36] marktraceur: I can still write that script! [22:02:51] and my datacentre has a gigabit pipe! [22:02:57] * marktraceur gestures for mwalker to bring it the fuck on [22:03:12] THE GAME. IT IS AFOOT. [22:03:33] * mwalker wonders if the FSF blocks tor exit nodes [22:03:41] (03CR) 10Mwjames: [C: 032] Nicified Special:Properties search form [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83014 (owner: 10Mwjames) [22:03:48] mwalker: I actually don't know how well FSF would handle the load [22:03:53] Riseup would be angry [22:03:55] what are you goin [22:03:57] g [22:03:58] to do? [22:04:14] spam marktraceur with thousands of emails [22:04:23] from many different domains [22:04:46] (03PS1) 10Rfaulk: mod - typo + deploy.client-path git config. [sartoris] - 10https://gerrit.wikimedia.org/r/83020 [22:04:47] (03PS1) 10Rfaulk: mod - _default_sync, call hooks. [sartoris] - 10https://gerrit.wikimedia.org/r/83021 [22:04:53] (03CR) 10BryanDavis: [C: 032] "Ori gave it +2 but I think Jenkins was sick at the time." [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [22:05:04] mwalker: If I get kicked out of riseup because of you I'll be very angry...setting up a mailserver has not been successful for me so far [22:05:06] (03Merged) 10jenkins-bot: Add role for PdfHandler. [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [22:05:18] (03Merged) 10jenkins-bot: Nicified Special:Properties search form [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/83014 (owner: 10Mwjames) [22:06:07] (03CR) 10Rfaulk: [C: 032 V: 032] mod - typo + deploy.client-path git config. [sartoris] - 10https://gerrit.wikimedia.org/r/83020 (owner: 10Rfaulk) [22:06:10] it would actually be a fairly easy filter to set up for them if they use something like cloudflare [22:06:18] (03CR) 10Rfaulk: [C: 032 V: 032] mod - _default_sync, call hooks. [sartoris] - 10https://gerrit.wikimedia.org/r/83021 (owner: 10Rfaulk) [22:06:20] but... I'm guessing they probably dont [22:06:25] Heh, probably no. :) [22:06:25] so I probably shouldn't take their service down [22:06:34] * marktraceur would like it very much if you didn't [22:07:25] how does that path actually work though to your fsf address? --> --> ? [22:07:32] (03CR) 10Siebrand: [C: 04-1] "Repeating my previous review: Don't understand why you're adding hidden parameters. Chances of anyone finding out they are there are close" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598) [22:07:48] or is the fsf domain canonical at riseup? [22:08:00] No, it's an alias [22:08:15] Rfaulk \o/ [22:08:22] It could forward to a gmail.com address or an apple.com or a corp.microsoft.com address if I wanted [22:08:54] ah; so I would actually be taking down the FSF alias server through tor [22:08:57] that would be amusing [22:09:16] *ly ironic [22:09:51] ^d: fatal: Couldn't find remote ref refs/changes/83/82783/1 :( [22:10:04] <^d> I know. [22:10:07] (03CR) 10Siebrand: [C: 031 V: 04-1] "Okay to merge, but can't merge cleanly." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78372 (owner: 10Nemo bis) [22:11:45] (03CR) 10Siebrand: [C: 032] Add cache versioning to InfoAction. [core] - 10https://gerrit.wikimedia.org/r/54207 (owner: 10Parent5446) [22:13:14] hmm, siebrand is on a merge spree. haven't seen that in a while [22:13:20] (03CR) 10Siebrand: [C: 032] Special:PagesWithProp: Distinguish content from interface [core] - 10https://gerrit.wikimedia.org/r/75502 (owner: 10Matmarex) [22:13:22] (03PS2) 10Aaron Schulz: Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 [22:13:36] ^d: rebase fixed it [22:13:47] (03CR) 10Aaron Schulz: [C: 04-1] Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [22:13:51] <^d> It would. [22:14:34] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 (owner: 10Aaron Schulz) [22:15:09] (03Merged) 10jenkins-bot: Add cache versioning to InfoAction. [core] - 10https://gerrit.wikimedia.org/r/54207 (owner: 10Parent5446) [22:16:30] YuviPanda: Trying to keep incoming reviews under control on https://gerrit.wikimedia.org/r/#/dashboard/92 ... [22:16:43] :) [22:17:36] (03Merged) 10jenkins-bot: Special:PagesWithProp: Distinguish content from interface [core] - 10https://gerrit.wikimedia.org/r/75502 (owner: 10Matmarex) [22:20:17] what version of jshint Jenkins uses? [22:23:10] (03CR) 10CSteipp: [C: 032 V: 032] "Working fine in test" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82060 (owner: 10Aaron Schulz) [22:30:22] (03PS1) 10Bsitu: Update PageTriage to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83027 [22:31:24] (03CR) 10Cmcmahon: [C: 031] "This is causing fatals on beta as well, so merging quickly would be nice." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/83012 (owner: 10Matthias Mullie) [22:32:53] "grrrit"...heh [22:35:31] (03PS1) 10Bsitu: Update PageTriage to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83029 [22:37:46] (03PS3) 10Matmarex: Change all glyphs to have a transparent background [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [22:38:52] (03CR) 10Matmarex: "I have redone this with proper transparency, details in the commit message." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [22:38:54] that was interesting :D ^ [22:39:55] (03PS4) 10Matmarex: Change all glyphs to have a transparent background [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/63363 (owner: 10MichaelBillington) [22:40:09] (03PS1) 10EBernhardson (WMF): Better error handling for memc and some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83030 [22:41:33] jgonera: 1.1.0 [22:42:19] marktraceur, who should I poke to upgrade it? the current version is past 2.0 [22:43:10] (03PS1) 10EBernhardson (WMF): Display post creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83032 [22:43:42] jgonera: Krinkle would probably have an opinion [22:43:55] against it? [22:44:04] Not necessarily [22:44:08] ok, I'll ask him, thanks [22:44:16] Well, I mean, I just pinged him [22:44:40] Krinkle: More formally, jgonera wants to know what the path is for updating jshint/jslint/whatever on gallium [22:44:43] (03PS1) 10EBernhardson (WMF): Display the correct info in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83033 [22:52:57] never seen that before...my vagrant box now responds to all shell commands with "-bash: fork: cannot allocate memory" ... while i hate it as a solution i suppose a virtual reboot is in order [22:55:38] brion: For some definition of "pretty." ;-) [22:56:02] Those buttons don't match any other part of the user interface/experience. [22:56:35] reverting them on testwiki was a very obvious solution, yes :) [22:56:53] Well, [22:57:03] I'd been experimenting with how much code was needed to undo the mess. [22:57:16] why not in your Userstyles? [22:57:17] In case local wikis wanted to have a reasonable-looking login screen. [22:57:30] You know the answer to that question already, I think. [22:57:43] boom, yes [22:57:46] wait for agora2? [22:58:01] ebernhardson: Where was Agora1? [22:58:09] YuviPanda: I don't believe user CSS is loaded on Special:UserLogin. [22:58:15] indeed, that was the 'boom, yes' for [22:58:18] Oh. [22:58:20] Good! [22:58:24] Glad we're all on the same page. :-) [22:58:41] anyway, I guess someone will still keep running into it and reverting it, if you choose to revert the revert [22:58:42] Elsie: i dunno, but the css i got from jorm's prototype origionally was called agora2-override.css [22:58:47] since it makes stuff hard to test. [22:59:13] ebernhardson: The prototype that was "JUST A PROTOTYPE, STOP WORRYING!" until development started... [22:59:14] but there is still a good bit of work to do there, design has a pdf of styles they are working twords, not final yet though [22:59:30] YuviPanda: I was going to blank the stylesheet. I do it every few months. [22:59:32] Elsie: by just a prototype i think he means "nothing is set in stone, we can still change it" [22:59:42] ebernhardson: That doesn't mean anything. [23:00:22] Elsie: ok, how about "May (visual designer) and Jared(UI/UX department head) are still revisioning agora and what is in the prototype is not the final agora2" [23:01:13] * Elsie shrugs. [23:01:22] literally they are working on it today [23:01:26] ebernhardson: It seems like yet another top-down approach. [23:01:37] We'll wait for Jared and May to tell us how things should work and act. [23:01:57] Elsie: heh, you dont want to know what it would look like if i just went out on my own :P [23:02:19] for about a month flow didn't use a single line of CSS, and i was fine with it [23:02:29] ebernhardson: I think you're probably a bit too new to remember LiquidThreads. :-) [23:02:31] (no style="blah" attributes either) [23:02:34] And ArticleFeedbackv5. [23:02:36] And MoodBar. [23:02:41] And... [23:02:47] so you think i should be driving a change in how WMF works? [23:02:49] The Usability Initiative! [23:02:54] because i'm new and know nothing about it ? :P [23:03:05] Not at all. But Jared and May are probably newer. [23:03:08] And that's what concerns me. [23:03:15] <^d> I remember a time before the usability initiative when we just added things on wherever it felt right at the time :p [23:03:23] (03PS1) 10Matthias Mullie: Slightly better abide to MW jshint & coding standards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83035 [23:03:51] ^d: Who should I bother about that Gerrit query change? [23:03:55] Elsie: best i can suggest right now is https://www.dropbox.com/s/wa9uayq9j09agyh/Agora%20specs.pdf [23:03:57] Daniel Z.? Ryan L.? [23:04:10] <^d> Ryan usually merges my gerrit changes. [23:04:16] Elsie: to me, it seems like a great first approach, if you find it bad perhaps write it up and email Jared? [23:04:36] Elsie: he really is an aproachable guy, nice too :) [23:05:04] ebernhardson: You seem pretty nice yourself. :-) [23:05:10] If not a bit naive. ;-) [23:05:13] :P [23:05:27] my only paid job in programming before WMF the deliverable was an API [23:05:33] i had complete control, and asked noone what it should look like [23:05:47] so here, you have visual designers and UX people, i'm happy to defer to people who "know better than me" [23:06:00] <^d> I avoid user-facing things. [23:06:03] Hmmm, we'll see what happens. [23:06:06] <^d> Then nobody has to tell me it's ugly :) [23:06:16] LiquidThreads basically got abandoned in favor of a rewrite. [23:06:29] And history has repeatedly said that doing massive rewrites is a pretty poor idea. [23:06:30] ^d: hasn't anyone ever told you gerrit is ugly? [23:06:31] ^d: programmers will still tell you your API is ugly :P [23:06:56] <^d> YuviPanda: Yes, and I ignore them. [23:07:02] It used to be worse.™ [23:07:03] hehe [23:07:11] * YuviPanda reverts back to the puke green theme [23:07:11] <^d> Elsie: Story of my life. [23:07:23] Anyway, so have a discussion system being rebuilt. [23:07:31] And it's a pretty complex problem. [23:07:44] And I don't think many people are hopeful for a good solution. [23:07:54] But we'll see what happens. [23:08:07] i have to just ignore them, otherwise i would have to quit long before we have a deliverable :P [23:08:07] (03CR) 10Bsitu: [C: 032 V: 032] Update PageTriage to master [core] (wmf/1.22wmf16) - 10https://gerrit.wikimedia.org/r/83029 (owner: 10Bsitu) [23:08:39] there must be a dozen other people consered with how it works ... i just program the thing [23:08:44] ^d: That's a good thing! [23:08:47] * ebernhardson cant spell concerned [23:08:56] Only a dozen? [23:09:18] * Elsie stops trolling. [23:09:20] well, thats approx the number of people in our largish meeting [23:09:35] Warning: Permanently added the RSA host key for IP address '[208.80.154.81]:29418' to the list of known hosts. [23:09:37] whee new IP [23:09:43] brion: or the NSA. [23:09:46] you can never tell [23:09:48] O_O [23:09:58] <^d> brion: I can verify that's the new IP :) [23:10:07] * brion wonders if he can verify ^d [23:10:18] <^d> Dunno, I'm a shifty kind of guy. [23:10:29] ShIfTy KiNd? [23:10:30] You can't prove a negative. [23:10:45] ah, trust. it's turtles all the way down [23:10:57] thats why i prefer money :) [23:11:11] * YuviPanda gives ebernhardson some fake notes [23:11:29] (03CR) 10Bsitu: [C: 032 V: 032] Update PageTriage to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/83027 (owner: 10Bsitu) [23:11:54] okay, I should try to sleep before 6AM at least today. [23:15:43] (03CR) 10EBernhardson (WMF): "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF)) [23:18:48] (03PS1) 10Aaron Schulz: Fixed local case for ID => name lookup [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83037 [23:19:06] csteipp: https://gerrit.wikimedia.org/r/#/c/83037/ [23:28:47] mwalker: can we disable that central notice banner for wiki loves monuments on mobile? [23:28:48] it looks terrible [23:29:03] it's clearly not been tested properly.. :-( [23:29:13] not my call; Jamesofur ^ [23:29:21] there seems to be loads of banners running so it's hard to tell which one is responsible [23:29:31] I think Romaine is responsible? [23:29:34] but it's very squashed and has a huge margin underneath the banner and above the search chrome [23:31:33] (03PS1) 10EBernhardson (WMF): Gender support for Echo reply notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/83039 [23:31:44] mwalker: i'm mostly concerned as this is the first high profile banner campaign run on mobile [23:31:58] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna) [23:32:28] (03CR) 10CSteipp: [C: 032 V: 032] Fixed local case for ID => name lookup [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/83037 (owner: 10Aaron Schulz) [23:32:51] (03Abandoned) 10Matthias Mullie: Remove obsolete code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81419 (owner: 10Matthias Mullie) [23:33:22] (03PS4) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [23:37:05] (03PS3) 10Krinkle: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 [23:38:44] jdlrobson: on my mobile it looks fine [23:39:34] Romaine: I can replicate jdlrobson's report on android 2.3 firefox and native browser [23:39:38] Romaine: http://imgur.com/VfjbszL < that's how it looks for me very broken [23:39:51] text is huge and squashed and huge gap between search bar and banner [23:40:43] font-size: 120% not a good idea :) [23:42:14] Romaine: i can apply some fixes in Mobile.css as temporary measures [23:42:26] the word terrible I would use for worse looks [23:42:38] but the look can be better [23:42:46] jdlrobson: if you can, please do [23:43:33] Romaine: things are more noticeable on mobile… we need to be more careful with banner designs there [23:43:36] jdlrobson: do you have centralnotice-admin rights? [23:43:40] mwalker: nope [23:43:52] which banner is this btw so i can reference it in MediaWiki:Mobile.css [23:44:10] we have two for WLM [23:44:15] ok [23:44:20] wlm_2013 [23:44:24] wlm_2013-us [23:45:24] those are the campaign names WLMUS and wlm_2013 are the banner names [23:45:37] sorry [23:45:48] the whole system keeps me confusin [23:46:21] (03PS3) 10Aaron Schulz: Made Special:MWOAuth use HTMLForm [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82783 [23:49:06] where is that page MediaWiki:Mobile.css visible? [23:52:27] banner is a little bit better now but it's still not perfect [23:52:42] also it only applies to enwiki :( https://en.m.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&welcome=yes [23:54:01] * Jamesofur sighs [23:54:13] I think I'm better now [23:58:08] Urgh, weird. I'm not getting any errors from this hook, but it's not running. [23:58:43] Maybe the core hook tests have some insight into how I'm supposed to do this