[00:05:23] (03PS2) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 [00:06:39] (03PS3) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 [00:06:44] (03PS7) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 [00:08:30] (03PS4) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 [00:11:00] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 (owner: 10CSteipp) [00:11:56] (03PS5) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 [00:13:55] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 (owner: 10CSteipp) [00:17:54] sigh, gerrit why u so slow [00:22:36] (03CR) 10CSteipp: [C: 032] SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 (owner: 10CSteipp) [00:22:52] (03PS2) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82546 [00:23:01] (03CR) 10CSteipp: [C: 032] SECURITY: Fix extension detection with 2 .'s [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82546 (owner: 10CSteipp) [00:27:12] (03Merged) 10jenkins-bot: SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 (owner: 10CSteipp) [00:32:55] (03Merged) 10jenkins-bot: SECURITY: Fix extension detection with 2 .'s [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82546 (owner: 10CSteipp) [00:34:33] (03PS1) 10Alex Monk: Fix recent changes IRC feed [core] - 10https://gerrit.wikimedia.org/r/82558 [00:35:28] (03PS2) 10Alex Monk: Fix recent changes IRC feed [core] - 10https://gerrit.wikimedia.org/r/82558 [00:36:47] (03PS2) 10CSteipp: Updated release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82547 [00:37:39] (03CR) 10Legoktm: [C: 031] Fix recent changes IRC feed [core] - 10https://gerrit.wikimedia.org/r/82558 (owner: 10Alex Monk) [00:38:34] (03PS3) 10Ori.livneh: Fix recent changes IRC feed [core] - 10https://gerrit.wikimedia.org/r/82558 (owner: 10Alex Monk) [00:38:53] (03CR) 10Ori.livneh: [C: 032] Fix typo in property name [core] - 10https://gerrit.wikimedia.org/r/82558 (owner: 10Alex Monk) [00:39:16] ty ori-l :) [00:42:04] (03PS1) 10Ori.livneh: Fix typo in property name [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82559 [00:42:22] (03CR) 10Ori.livneh: [C: 032] Fix typo in property name [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82559 (owner: 10Ori.livneh) [00:45:05] (03Merged) 10jenkins-bot: Fix typo in property name [core] - 10https://gerrit.wikimedia.org/r/82558 (owner: 10Alex Monk) [00:46:17] i was ready to merge the large RC change commit [00:46:29] but tyler romeo swooped in at the last second and merged it [00:46:35] and as a result i get to blame him [00:46:37] it's very convenient [00:48:30] This error was made in March by me and unfortunately nobody noticed while it was in review [00:49:40] tyler's fault [00:49:45] i would have caught it given more time [00:49:46] heh [00:49:49] :D [01:02:24] (03PS1) 10MarkTraceur: Pull changes from multilightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/82561 [01:19:52] (03CR) 10Ori.livneh: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/82418 (owner: 10BryanDavis) [01:21:41] (03CR) 10Ori.livneh: "> I think the BDFL (you) needs to lay out some consistent guidelines" [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [02:34:35] (03PS5) 10Ori.livneh: Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [03:12:05] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #281: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/281/ [03:17:25] (03PS3) 10BryanDavis: Configure UploadWizard for optional chunked upload. [vagrant] - 10https://gerrit.wikimedia.org/r/82418 [03:17:54] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/82418 (owner: 10BryanDavis) [03:36:01] (03PS6) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 [03:36:31] (03CR) 10CSteipp: [C: 032] Updated release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82547 (owner: 10CSteipp) [03:42:29] (03Merged) 10jenkins-bot: Updated release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82547 (owner: 10CSteipp) [03:46:00] Yippie, build fixed! [03:46:01] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #262: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/262/ [03:46:42] (03CR) 10CSteipp: [C: 032] SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 (owner: 10CSteipp) [03:49:45] (03Merged) 10jenkins-bot: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 (owner: 10CSteipp) [03:50:06] (03PS2) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82542 [03:50:28] (03CR) 10CSteipp: [C: 032] SECURITY: Fix extension detection with 2 .'s [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82542 (owner: 10CSteipp) [03:53:57] (03PS2) 10Legoktm: [WIP] Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 [03:55:43] (03Merged) 10jenkins-bot: SECURITY: Fix extension detection with 2 .'s [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82542 (owner: 10CSteipp) [03:56:45] (03PS2) 10CSteipp: Update release notes and version [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82543 [03:56:52] (03CR) 10CSteipp: [C: 032] Update release notes and version [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82543 (owner: 10CSteipp) [03:57:41] (03PS3) 10Legoktm: Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 [04:02:07] (03Merged) 10jenkins-bot: Update release notes and version [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82543 (owner: 10CSteipp) [04:05:21] (03PS1) 10Legoktm: Add a required footer to all messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 [04:08:59] Elsie: Around? [04:09:55] Never. [04:10:47] Ok, well there are a few changes for you to review [04:10:56] And I wanted to discuss the "invalid input" thing [04:10:58] legoktm: Is $data['message'] ever trimmed? [04:11:23] Not until now, which was a bug [04:11:31] (03CR) 10MZMcBride: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 (owner: 10Legoktm) [04:12:04] Hmmm. [04:12:07] Normally all extra whitespace at the bottom is removed by MediaWiki, however since we add a at the bottom, the whitespace doesn't go away [04:12:40] It seems kind of silly (or needlessly clever) to append a footer and then trim. [04:12:47] But it's not really objectionable. [04:13:08] Is there a wiki where this extension works reliably? [04:13:20] Every time I try to test it on that fucking proxy wiki, I get annoyed. [04:13:22] on my local machine :D [04:13:23] And it gives me a headache. [04:13:27] Rage. [04:13:48] Did you sort the unsorted issues? [04:13:49] (03PS2) 10Legoktm: Add a required footer to all messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 [04:13:52] And remove the resolved ones? [04:14:19] I'll do that in a few minutes [04:14:21] Okay. [04:14:24] Do you have questions for me? [04:14:34] I think there's also some duplicate content on the /Design subpage. [04:14:44] My IP address has new messages on mediawiki.org. [04:14:59] Fascinating. [04:16:28] Yeah, so the detecting unclosed tags and stuff [04:16:50] In addition to detecting with a javascript thingy, we can add another section below the message, so if you don't close a tag and you have JS disabled, the next section would be large when you preview, and you'd hopefully notice it [04:18:12] I updated the /Design page btw [04:19:51] (03CR) 10Legoktm: "Not trimming $data['message'] is technically a bug, since the user would see different output in the preview and what is actually sent." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82570 (owner: 10Legoktm) [04:21:28] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82464 (owner: 10Bsitu) [04:28:15] bbl [04:39:29] (03PS14) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [04:45:56] (03CR) 10Pastakhov: "remove $memoryHI, rename $memoryLO to $memory" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [04:49:30] (03PS1) 10CSteipp: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_21) - 10https://gerrit.wikimedia.org/r/82572 [04:50:06] (03PS1) 10CSteipp: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_20) - 10https://gerrit.wikimedia.org/r/82573 [04:50:26] (03PS1) 10CSteipp: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] (REL1_19) - 10https://gerrit.wikimedia.org/r/82574 [04:54:23] (03PS10) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [05:06:51] Yippie, build fixed! [05:06:51] Project browsertests-en.wikipedia.org-linux-chrome build #293: FIXED in 4 min 52 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/293/ [05:09:04] (03PS11) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [05:10:21] (03CR) 10Mattflaschen: "(2 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [05:19:43] I found https://www.mediawiki.org/wiki/Manual:Enabling_autocomplete_in_search_box, but is there any documentation for developers on how to make autocomplete work on an extension form? [05:21:02] !b 1 | legoktm [05:21:02] legoktm: https://bugzilla.wikimedia.org/1 [05:21:04] >.> [05:21:08] lulz [05:21:14] i'll write it up once i figure out how [05:21:44] i wasn't expecting that to actually work in here, But i can go with it [05:34:42] found https://github.com/wikimedia/mediawiki-core/blob/master/resources/mediawiki/mediawiki.searchSuggest.js [05:38:22] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [05:39:10] hrpm, doesn't look there is any easy way to do it besides re implementing that code [05:41:33] (03CR) 10Mattflaschen: "Okay, let's try to talk about this tomorrow on IRC (I will be off Thursday and Friday, except for a separate meeting)." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [05:48:51] (03CR) 10Nikerabbit: "I still think it has been moved: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector.git/ba065b586c06bc7573f9" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [05:50:20] legoktm: {{Sofixit}} *runs* [05:50:47] this would probably be a lot easier if i knew javascript :P [06:02:07] (03PS1) 10Bsitu: Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 [06:02:37] legoktm: one doesn't simply know javascript >.> [06:12:20] (03CR) 10Bsitu: [C: 04-1] Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 (owner: 10Bsitu) [06:15:58] (03PS5) 10Bsitu: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 [06:16:58] (03PS1) 10Rfaulk: mod - refactor _configure. [sartoris] - 10https://gerrit.wikimedia.org/r/82576 [06:16:59] (03PS1) 10Rfaulk: mod - remove lock if tagging fails in start. [sartoris] - 10https://gerrit.wikimedia.org/r/82577 [06:17:00] (03PS1) 10Rfaulk: fix - formatting. [sartoris] - 10https://gerrit.wikimedia.org/r/82578 [06:17:30] (03CR) 10Rfaulk: [C: 032 V: 032] mod - refactor _configure. [sartoris] - 10https://gerrit.wikimedia.org/r/82576 (owner: 10Rfaulk) [06:17:43] (03CR) 10Rfaulk: [C: 032 V: 032] mod - remove lock if tagging fails in start. [sartoris] - 10https://gerrit.wikimedia.org/r/82577 (owner: 10Rfaulk) [06:17:57] (03CR) 10Rfaulk: [C: 032 V: 032] fix - formatting. [sartoris] - 10https://gerrit.wikimedia.org/r/82578 (owner: 10Rfaulk) [06:24:26] (03PS1) 10Legoktm: Autocomplete suggestions for spamlist input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 [06:25:28] (03PS2) 10Legoktm: Autocomplete suggestions for spamlist input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 [06:28:15] (03CR) 10Ori.livneh: [C: 032] "I'd like to do the PHP code generation a bit differently, but I'll submit that as a separate commit." [vagrant] - 10https://gerrit.wikimedia.org/r/82418 (owner: 10BryanDavis) [06:28:19] (03Merged) 10jenkins-bot: Configure UploadWizard for optional chunked upload. [vagrant] - 10https://gerrit.wikimedia.org/r/82418 (owner: 10BryanDavis) [06:33:50] (03PS1) 10Ori.livneh: Use #to_pson to generate PHP values [vagrant] - 10https://gerrit.wikimedia.org/r/82580 [06:34:29] (03CR) 10Ori.livneh: [C: 032] "Bryan: FYI" [vagrant] - 10https://gerrit.wikimedia.org/r/82580 (owner: 10Ori.livneh) [06:34:32] (03Merged) 10jenkins-bot: Use #to_pson to generate PHP values [vagrant] - 10https://gerrit.wikimedia.org/r/82580 (owner: 10Ori.livneh) [06:46:47] (03PS1) 10Rfaulk: rm - tagging from start op. [sartoris] - 10https://gerrit.wikimedia.org/r/82581 [06:46:48] (03PS1) 10Rfaulk: add - tag on sync. [sartoris] - 10https://gerrit.wikimedia.org/r/82582 [06:46:49] (03PS1) 10Rfaulk: mod - error code for tag failure. [sartoris] - 10https://gerrit.wikimedia.org/r/82583 [06:46:50] (03PS1) 10Rfaulk: add - default deploy hooks. [sartoris] - 10https://gerrit.wikimedia.org/r/82584 [06:47:08] (03CR) 10Rfaulk: [C: 032 V: 032] rm - tagging from start op. [sartoris] - 10https://gerrit.wikimedia.org/r/82581 (owner: 10Rfaulk) [06:47:18] (03CR) 10Rfaulk: [C: 032 V: 032] add - tag on sync. [sartoris] - 10https://gerrit.wikimedia.org/r/82582 (owner: 10Rfaulk) [06:47:29] (03CR) 10Rfaulk: [C: 032 V: 032] mod - error code for tag failure. [sartoris] - 10https://gerrit.wikimedia.org/r/82583 (owner: 10Rfaulk) [06:47:43] (03CR) 10Rfaulk: [C: 032 V: 032] add - default deploy hooks. [sartoris] - 10https://gerrit.wikimedia.org/r/82584 (owner: 10Rfaulk) [07:05:57] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #426: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/426/ [07:13:11] (03CR) 10Swalling: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [07:54:28] ori-l: why are these graphs showing zero: http://ganglia.wikimedia.org/latest/graph_all_periods.php?title=EventLogging&vl=events+%2F+sec&x=&n=&hreg%5B%5D=vanadium.eqiad.wmnet&mreg%5B%5D=%5E(client-generated-raw%7Cserver-generated-raw%7Cvalid-events)%24>ype=stack&glegend=show&aggregate=1 ? [07:56:28] Nikerabbit: your regex looks outdated https://ganglia.wikimedia.org/latest/?c=Miscellaneous%20eqiad&h=vanadium.eqiad.wmnet&m=cpu_report&r=hour&s=descending&hc=4&mc=2 [07:57:52] Nikerabbit: update your bookmarks/links with https://ganglia.wikimedia.org/latest/graph_all_periods.php?title=EventLogging&vl=events+%2F+sec&x=&n=&hreg[]=vanadium.eqiad.wmnet&mreg[]=^%28eventlogging_client-side-events|eventlogging_server-side-events|eventlogging_all-events%29%24>ype=stack&glegend=show&aggregate=1 [07:58:36] it's linked form wikitech and mw.org/wiki/Extension:EventLogging [07:59:10] yes, I've just updated it [08:03:34] (so little stuff happening) [08:11:48] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82587 [08:11:49] (03PS1) 10Raimond Spekking: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HSTS into i18nfixes [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82588 [08:24:20] hi zeljkof [08:28:27] Nikerabbit: good morning! :) [08:53:07] (03CR) 10Siebrand: [C: 032] Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [08:54:49] (03CR) 10Siebrand: [C: 032] Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 (owner: 10Mattflaschen) [08:55:23] (03Merged) 10jenkins-bot: Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 (owner: 10Mattflaschen) [08:55:34] (03CR) 10Siebrand: [C: 032] Parse limitation warnings as 'text' and in user language [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender) [08:56:20] (03Merged) 10jenkins-bot: Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [08:57:10] (03CR) 10Siebrand: "I'm really giving Robla a way out to get the immediate issue resolved, and get the rest done properly. This needs tests, and deduplication" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [08:59:08] (03Merged) 10jenkins-bot: Parse limitation warnings as 'text' and in user language [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender) [09:02:10] (03CR) 10Zfilipin: [C: 031] Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 (owner: 10Manybubbles) [10:38:32] What does the parameter of SpecialPage::execute($par) contain exactly? [10:39:25] for /wiki/Special:Abc/def it contains def, but what about index.php?title=Special:Abc/def? [10:40:44] ah, my bad. How can I check if short URLs are used by the server? [11:59:00] (03PS1) 10Shirayuki: Remove formatNum() from $1 of "logdelete-selected" [core] - 10https://gerrit.wikimedia.org/r/82602 [12:14:02] (03PS1) 10Hashar: make mediawiki jobs runnable on slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82603 [12:17:33] (03CR) 10Shirayuki: "I love the "tux=0" user interface." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 (owner: 10Shirayuki) [12:20:09] (03PS1) 10Raimond Spekking: Add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 [12:27:37] (03CR) 10Matmarex: "At least one gadget I know uses a "mw-disambig" class; it might be a good idea to look around a little and use something that is already t" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [12:40:49] (03PS2) 10Helder.wiki: Add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [12:47:42] (03CR) 10Matmarex: "Also, firing a query for each link on a page might not be kosher. Maybe we could instead "select * from page_props where pp_propname='disa" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [12:49:17] (03CR) 10Matmarex: "Or maybe LinkCache could be extended with some hooks?" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [13:23:31] (03PS4) 10Matmarex: jquery.makeCollapsible: Tests for collapsible ,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 [13:25:36] (03CR) 10Matmarex: "This literally changes ten lines of code. Could somebody merge it at last?" [core] - 10https://gerrit.wikimedia.org/r/55496 (owner: 10Matmarex) [13:27:00] (03CR) 10jenkins-bot: [V: 04-1] jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 (owner: 10Matmarex) [13:51:41] Nikerabbit: going through the app code now and writing an email with notes [14:00:38] gaaaah, i hate jquery [14:01:29] http://api.jquery.com/slideUp/ [14:01:36] "If supplied, the callback is fired once the animation is complete." [14:01:45] however, "If multiple elements are animated, it is important to note that the callback is executed once per matched element, not once for the animation as a whole." [14:01:47] goddammit. [14:05:13] (03CR) 10MaxSem: "If a gadget uses the mw- prefix, IT should be fixed, not PHP code." [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [14:09:39] (03CR) 10MaxSem: [C: 04-2] "(2 comments)" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [14:10:31] (03PS1) 10Platonides: Add Nepal [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/82610 [14:13:45] Nikerabbit: sent [14:14:01] YuviPanda: yaaa [14:14:11] sorry about being a slouch [14:15:27] YuviPanda: I'm not in position to complain [14:15:32] whyyy does jquery suck so bad [14:15:38] Nikerabbit: :) [14:15:44] there is not way to execute a function just once after all animations are complete using http://api.jquery.com/animate/ and friends [14:15:52] you can execute a function after anmation on each element completes [14:15:52] Nikerabbit: is there a meeting today? [14:16:04] or after all animations that anything might have ever queued on the elements complete [14:16:14] jquery is worse than php. [14:21:09] hey ori-l [14:21:10] err [14:21:10] orsa: [14:21:13] sorry, ori-l [14:28:39] (03PS1) 10Nikerabbit: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 [14:32:38] MatmaRex: can't you use use $.when? [14:38:07] Nikerabbit: doesn't seem like it [14:38:07] Nikerabbit: wanna know what i'm doing? [14:41:43] (03CR) 10Siebrand: [C: 04-1] "Please fix the items noted in https://integration.wikimedia.org/ci/job/mwext-TwnMainPage-phpcs-HEAD/84/console" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 (owner: 10Nikerabbit) [14:44:01] Nikerabbit: aaaaactually, it looks like i can use $.when [14:44:03] awesome [14:45:27] i love you. [14:52:41] (03PS5) 10Matmarex: jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 [14:52:42] (03PS1) 10Matmarex: jquery.makeCollapsible: Only trigger custom events once per collapsible [core] - 10https://gerrit.wikimedia.org/r/82615 [14:52:46] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/82580 (owner: 10Ori.livneh) [14:52:48] ^ i hate jquery. [14:53:02] Nikerabbit: wanna review? :D ^^ [14:54:42] (03CR) 10Matmarex: "Fixed the bug that was causing this to fail in https://gerrit.wikimedia.org/r/#/c/82615/ ." [core] - 10https://gerrit.wikimedia.org/r/74969 (owner: 10Matmarex) [14:56:14] (03CR) 10jenkins-bot: [V: 04-1] jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 (owner: 10Matmarex) [14:56:54] (03PS6) 10Matmarex: jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - 10https://gerrit.wikimedia.org/r/74969 [14:59:26] (03PS1) 10Cmcmahon: ULS tests now reside in the ULS extension repo, delete them from here [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 [15:01:38] (03Abandoned) 10Cmcmahon: class value for Cancel changed, also restored missing steps [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [15:08:21] (03CR) 10Siebrand: [C: 032] Remove duplidated i18n messages [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/78029 (owner: 10Bsitu) [15:08:25] (03Merged) 10jenkins-bot: Remove duplidated i18n messages [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/78029 (owner: 10Bsitu) [15:09:49] (03CR) 10Siebrand: "Yes, sorry." [core] - 10https://gerrit.wikimedia.org/r/45506 (owner: 10Liangent) [15:10:50] (03PS1) 10Jack Phoenix: PictureGame: version 3.0, which mostly works w/ current stable MW. [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/82618 [15:14:15] (03PS1) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:14:22] (03CR) 10Siebrand: [C: 032] Update ignores for some emacs tmp files [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75910 (owner: 10MarkAHershberger) [15:14:32] (03CR) 10Jack Phoenix: [C: 032 V: 032] PictureGame: version 3.0, which mostly works w/ current stable MW. [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/82618 (owner: 10Jack Phoenix) [15:14:37] Woo hoo [15:15:08] (03CR) 10Siebrand: [C: 031] ULS tests now reside in the ULS extension repo, delete them from here [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 (owner: 10Cmcmahon) [15:15:25] (03Merged) 10jenkins-bot: Update ignores for some emacs tmp files [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75910 (owner: 10MarkAHershberger) [15:16:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [15:16:22] (03CR) 10Dan-nl: "(58 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 10Dan-nl) [15:17:11] marktraceur: what's "woo hoo" awesome? [15:20:12] bd808: Patchset from dan-nl mentioning me [15:21:27] Looking at that now. It's a big pile o' change. [15:21:38] (03CR) 10Siebrand: [C: 031] "Please rebase, so we can go ahead and merge." [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [15:22:37] Indeed [15:27:54] (03CR) 10Siebrand: [C: 032] Remove duplicated blocked parts reported by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43496 (owner: 10Liangent) [15:27:59] (03Merged) 10jenkins-bot: Remove duplicated blocked parts reported by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43496 (owner: 10Liangent) [15:29:06] (03PS10) 10Liangent: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 [15:29:32] (03CR) 10jenkins-bot: [V: 04-1] Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [15:29:56] (03CR) 10Siebrand: [C: 032] Better display of parts blocked by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43494 (owner: 10Liangent) [15:29:58] (03Merged) 10jenkins-bot: Better display of parts blocked by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43494 (owner: 10Liangent) [15:31:50] (03PS11) 10Liangent: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 [15:32:30] I hate merging RELEASE-NOTES when rebasing [15:33:01] liangent: fear not! i have a solution! [15:33:12] liangent: https://github.com/MatmaRex/mediawikireleasenotes-driver [15:33:23] (03CR) 10Siebrand: [C: 032 V: 032] "Merging now. No need to have this unmerged." [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 (owner: 10Liangent) [15:33:37] https://github.com/MatmaRex/mediawikireleasenotes-driver#usage--installation [15:33:59] * siebrand agreed with liangent. Time waster. [15:34:33] MatmaRex: Cool beans. [15:35:00] i've been using it for myself for some time, works flawlessly as far as i can see :) [15:35:14] siebrand: where should I request the deployment of PageLanguage? [15:35:38] liangent: bugzilla, with community consensus link if applicable. [15:36:37] siebrand: the community doesn't say "we want this extension" but "we want language conversion on XXX pages" [15:37:12] liangent: I think you might be albe to get Nikerabbit to do review and deployment. [15:37:13] and this (seemingly unrelated) extension does it magically [15:37:39] liangent: So please create the bug, and I'll be able to prioritise it. Business case appreciated... [15:37:45] ;) [15:38:47] (03PS2) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:39:57] (03PS4) 10AndyRussG: Add animateFromPrev step prop and animation [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82209 [15:41:43] (03CR) 10Siebrand: [C: 04-1] "Only just occurred to me, but the relevant testTableName* unit tests must be updated to test the new options." [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [15:41:49] (03PS3) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:42:42] (03CR) 10Siebrand: "Can Merge is no for some reason... Why?" [extensions/PageLanguage] - 10https://gerrit.wikimedia.org/r/68852 (owner: 10Liangent) [15:42:54] MatmaRex: how does one request your bot's services? [15:43:55] MatmaRex: does your script only do the magic on git merge? [15:44:05] I usually do git cherry-pick ... [15:46:24] liangent: on everything [15:46:32] liangent: merge, rebase, cherry-pick, whatever [15:46:45] Nemo_bis: one does not right now, the bot is kind of defunct [15:47:07] (03CR) 10Siebrand: [C: 032] Use page language instead of user interface language when parsing. [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/47333 (owner: 10Liangent) [15:47:10] (03Merged) 10jenkins-bot: Use page language instead of user interface language when parsing. [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/47333 (owner: 10Liangent) [15:47:16] Nemo_bis: i'd have to set it up somewhere else than my laptop [15:47:31] Nemo_bis: you can install the merge driver for now :) [15:48:15] (03PS4) 10Dan-nl: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 [15:49:51] MatmaRex: Any way we can teach Gerrit how to do this? [15:50:27] siebrand: if you speak java, yes [15:50:27] siebrand: it uses a different implementation of git, this solution is not compatible [15:50:56] siebrand: (the algorithm itself can be used, of course, you'd just have to translate it to java and somehow hook into it, i don't know how, exactly) [15:50:59] (but it seemed possible last time i checked) [15:52:14] MatmaRex: That file is just causing too much trouble, and I think it causes devs to not update it; and I totally understand that. [15:53:12] siebrand: hey, ^d is here, make him do it. [15:53:16] hi ^d. [15:53:25] <^d> Uh oh. [15:53:27] * ^d hides [15:54:12] ^d: siebrand wants https://github.com/MatmaRex/mediawikireleasenotes-driver#readme built-in in gerrit. do eeeet. [15:55:03] <^d> How on earth am I supposed to do that? [15:55:14] ^d :) [15:55:41] magic [15:55:49] (03CR) 10Siebrand: "Just sent a mail to Daniel and Niklas asking again." [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [15:56:21] ^d: use you mad java skillz! :D [15:56:21] your* [15:56:44] <^d> Um, not it. [15:56:47] (03PS12) 10Liangent: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 [15:57:10] i think the last time i poked you about this the conclusion was that it's possible to implement custom merge drivers, but there was nobody willing to do it [15:57:33] (03CR) 10Siebrand: [C: 032] Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [15:57:44] <^d> I think you're still lacking in the willigness department. [15:58:18] mind is willing, but the skillz are weak [15:58:29] i've already done half the job for you :D [15:58:53] siebrand: you're too quick. I sometimes don't bother to run unit tests locally and simply wait for jenkins [15:59:49] <^d> MatmaRex: I'm trying to avoid spending much time on gerrit this quarter. I've got about a half dozen other projects that need me. [16:00:05] <^d> We're getting a new box today. That's all I've got planned for weeks. [16:00:44] (03CR) 10jenkins-bot: [V: 04-1] Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [16:00:49] heh. we need to get you cloned. [16:02:33] (03Abandoned) 10Matmarex: badge: Fix invalid CSS value for text-shadow [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81529 (owner: 10Krinkle) [16:03:55] (03PS13) 10Liangent: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 [16:06:03] (03CR) 10Matmarex: "Hello? Trivial stuff here, guys." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77571 (owner: 10Matmarex) [16:07:33] (03CR) 10jenkins-bot: [V: 04-1] Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [16:08:19] (03CR) 10Matmarex: [C: 032] "I wanted somebody else to look at this, but clearly no one cares. Let's get it merged." [core] - 10https://gerrit.wikimedia.org/r/71176 (owner: 10Alex Monk) [16:11:54] (03Merged) 10jenkins-bot: Make mwCustomEditButtons a no-op and mark it as deprecated [core] - 10https://gerrit.wikimedia.org/r/71176 (owner: 10Alex Monk) [16:22:37] (03CR) 10Matthias Mullie: [C: 032] ext.echo.special: Cross-skin adjustments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77571 (owner: 10Matmarex) [16:22:47] (03Merged) 10jenkins-bot: ext.echo.special: Cross-skin adjustments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77571 (owner: 10Matmarex) [16:23:00] (03PS1) 10Chad: Updating RSS extension to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82629 [16:23:52] (03CR) 10Chad: [C: 032] Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 (owner: 10Manybubbles) [16:23:55] (03Merged) 10jenkins-bot: Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 (owner: 10Manybubbles) [16:26:57] (03PS1) 10Cmcmahon: View history link location is not reliable on Sauce browsers Bug 53728 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82632 [16:27:41] (03CR) 10Chad: [C: 032] Turn tests for link count updates back on. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81850 (owner: 10Manybubbles) [16:27:43] (03Merged) 10jenkins-bot: Turn tests for link count updates back on. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81850 (owner: 10Manybubbles) [16:28:36] (03CR) 10Chad: [C: 032] Switch incategory to simple matching. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82037 (owner: 10Manybubbles) [16:28:39] (03Merged) 10jenkins-bot: Switch incategory to simple matching. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82037 (owner: 10Manybubbles) [16:28:56] (03CR) 10Chad: [C: 032] Carefully replace aliases to prevent duplicates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81866 (owner: 10Manybubbles) [16:29:00] (03Merged) 10jenkins-bot: Carefully replace aliases to prevent duplicates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81866 (owner: 10Manybubbles) [16:29:43] (03CR) 10Aaron Schulz: [C: 032] Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 (owner: 10Bsitu) [16:31:00] (03PS14) 10Liangent: Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 [16:32:40] (03Merged) 10jenkins-bot: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 (owner: 10Bsitu) [16:34:36] (03CR) 10jenkins-bot: [V: 04-1] Support using alternative tables in $wgSharedTables [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [16:34:38] (03CR) 10Nikerabbit: [C: 04-1] "I can try, but to review I need to understand the context." [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [16:41:51] (03PS1) 10Anomie: Delete forceHTTPS cookies on logout [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 [16:44:02] (03CR) 10Chad: "While I don't have numbers to back up the assumption, it's my belief that incoming link counts have a pretty long tail. There's a few high" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [16:44:42] What is a good simple example of the code for an interface message that is blank by default and gets overridden if the relevant local MediaWiki page gets created? [16:45:45] I'm using the msg() function, and it worked briefly, but now the local MW pages are not doing anything. [16:47:33] ragesoss: recentchanges-summary? [16:47:47] sorry, no [16:47:48] recentchangestext [16:48:11] and many other -summary messages, e.g. upload-summary [16:48:14] (03CR) 10Manybubbles: "Limiting the number of links would work for regular search but I think it'd make prefix search worse as that is entirely sorted by backlin" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [16:48:19] (there is one for almost every special page) [16:49:25] (03PS5) 10Chad: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [16:49:51] (03CR) 10Chad: [C: 032] Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [16:49:53] (03Merged) 10jenkins-bot: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [16:51:38] (03PS1) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82635 [16:53:10] (03CR) 10Nikerabbit: "There is likely more things in page definitions and in the interlanguage module that can also be removed if unused by other tests." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 (owner: 10Cmcmahon) [16:53:22] MatmaRex: thanks. it seems pretty ad-hoc. so, addWikiText is the basic technique for it? [16:54:17] ragesoss: dunno. probably [16:56:01] ^d: I suppose a manual COUNT() query would still better for your use, since the mysql client won't load the result into the buffer in RAM [16:56:19] it would just be a number [16:56:35] caching logic could be added in a few lines [16:57:04] <^d> So use count(*), but cache it ourselves? [16:57:12] <^d> That'd be a reasonable compromise. [16:57:45] (03CR) 10Liangent: [C: 04-1] "Just realized a core issue (bug) when writing the test:" [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [16:59:27] (03CR) 10Liangent: "https://bugzilla.wikimedia.org/show_bug.cgi?id=53760" [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [17:02:39] (03CR) 10Liangent: "When category page [[Category:(zh-hans text)]] exists while [[Category:(zh-hant text)]] doesn't, both [[Category:(zh-hans text)]] and [[Ca" [core] - 10https://gerrit.wikimedia.org/r/59793 (owner: 10Liangent) [17:03:31] (03PS2) 10Nikerabbit: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 [17:03:39] (03PS2) 10Bsitu: Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 [17:07:31] (03CR) 10Chad: "Hehe :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [17:11:33] MatmaRex: great if it works... though I don't understand why ;) [17:12:40] Nikerabbit: because jquery sucks immensely [17:12:49] it's like democracy, if you know that quote [17:13:48] (03PS3) 10Bsitu: Get rid of some javascript mw.title related code [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/82575 [17:15:01] brion: standup? [17:20:51] (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 (owner: 10Matthias Mullie) [17:24:24] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Remove relative timestamps in favor of cldr [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82525 (owner: 10EBernhardson (WMF)) [17:24:40] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Coding standards cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82432 (owner: 10EBernhardson (WMF)) [17:26:12] (03CR) 10EBernhardson (WMF): [V: 032] (bug 49285) ArticleFeedbackv5: Text is blurry due to use of CSS3 filter [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/67970 (owner: 10Matthias Mullie) [17:26:23] (03CR) 10EBernhardson (WMF): [C: 032] (bug 49285) ArticleFeedbackv5: Text is blurry due to use of CSS3 filter [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/67970 (owner: 10Matthias Mullie) [17:27:01] (03CR) 10EBernhardson (WMF): "Should we turn this off now?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/71854 (owner: 10Bsitu) [17:27:49] ebernhardson: are you in the office? [17:27:57] ori-l: yup [17:28:15] can you go bug some platform people to look at #wikimedia-operations, because swift is fucked? [17:28:31] sure, anyone in particular? [17:28:42] aaron or rob probably [17:28:46] kk [17:29:06] (03PS3) 10Chad: Stop using backlink cache for link counts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [17:29:08] ebernhardson: nm, aaron's on it it looks like [17:29:19] thank you though and sorry for the distraction [17:29:21] <^d> manybubbles: I amended your backlinks patch to add some caching fun. [17:30:23] ori-l: no robla, i told aaron. He said something about not havving access or something [17:30:39] ebernhardson: thank you [17:30:39] (03CR) 10JGonera: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [17:30:45] ori-l: np [17:33:06] (03CR) 10Manybubbles: [C: 032] Stop using backlink cache for link counts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [17:33:09] (03Merged) 10jenkins-bot: Stop using backlink cache for link counts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [17:35:23] (03PS2) 10Chad: Updating Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82635 [17:35:51] (03CR) 10Chad: [C: 032] Updating RSS extension to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82629 (owner: 10Chad) [17:36:09] (03CR) 10Cmcmahon: "I don't mind leaving behind items in the page definitions. We'll be re-organizing those at some point in the future." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82616 (owner: 10Cmcmahon) [17:40:14] (03Merged) 10jenkins-bot: Updating RSS extension to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82629 (owner: 10Chad) [17:41:09] brion: btw, bawolff has an RFC out for changing the gallery styles' defaults! [17:41:14] brion: https://commons.wikimedia.org/wiki/Commons:Requests_for_comment/Changing_default_gallery_mode [17:41:32] \o/ [17:41:34] StevenW: ^ (re: your comment about 'all category pages should look like this' on the design list about the new gallery styles) [17:42:57] ^d: makes sense to me. merged. If this becomes a problem in the future we'll address it again. [17:45:12] ^d: and gerrit seem to be down. [17:45:19] yep [17:45:23] and back [17:45:44] <^d> I can't wait to be on the new box. [17:46:05] ^d: cut a hole in a box... [17:48:41] PissedPanda, i added my 2 cents: https://commons.wikimedia.org/wiki/Commons:Requests_for_comment/Changing_default_gallery_mode#Discussion [17:48:50] brion: woo! [17:50:02] hey brion, you bored? [17:50:12] (03CR) 10Bsitu: "We are no longer capturing pref update in Echo, it has been turned off for quite a while." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/71854 (owner: 10Bsitu) [17:50:22] MatmaRex: don't know that i'd use that term exactly… ;) what's up? [17:50:34] because i have 28 open changesets in mediawiki/core and some of them could use merging ;) [17:50:39] https://gerrit.wikimedia.org/r/#/q/owner%3A%22Matmarex%22+project%3Amediawiki%2Fcore+status%3Aopen,n,z [17:50:46] nice [17:50:47] i'm currently winning in https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [17:50:50] * brion saves this link for later today :D [17:51:14] hehe [17:52:40] (03CR) 10Matmarex: [C: 032] Use canonical class name, remove unused globals. [core] - 10https://gerrit.wikimedia.org/r/81875 (owner: 10Platonides) [17:52:46] (03CR) 10Chad: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82635 (owner: 10Chad) [17:53:00] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/tools/code-utils,n,z huh, that's a lot of open changesets [17:53:09] almost all from february. nice. [17:53:53] MatmaRex: i'm going to be sneaky and do 82097 [17:53:56] * MatmaRex wonders whi to poke about it [17:53:59] who* [17:54:19] PissedPanda: sneaky you. [17:54:23] very [17:55:05] so, who do i poke about mediawiki/tools/code-utils? hashar? [17:55:35] (03Merged) 10jenkins-bot: Use canonical class name, remove unused globals. [core] - 10https://gerrit.wikimedia.org/r/81875 (owner: 10Platonides) [17:57:19] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82635 (owner: 10Chad) [17:59:26] @seen platonides [17:59:26] MatmaRex: Last time I saw platonides they were quitting the network with reason: no reason was given N/A at 8/31/2013 8:44:15 PM (3d21h15m11s ago) [17:59:28] @seen hashar [17:59:28] MatmaRex: Last time I saw hashar they were quitting the network with reason: Quit: I am a manual virus, please copy me to your quit message. N/A at 9/4/2013 4:58:54 PM (1h34s ago) [17:59:37] @notify hashar [17:59:37] I'll let you know when I see hashar around here [17:59:51] (03CR) 10Yuvipanda: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82097 (owner: 10Matmarex) [18:00:46] * MatmaRex grumbles at yuvi [18:01:20] PissedPanda: that cast isn't necessary, we're doing $count = $count + $add; in the next statement [18:01:33] wouldn't that be an implicit cast? [18:01:42] better explicit than implicit, no? [18:01:50] besides, we shouldn't be doing that in a patch that's a whitespace fix [18:02:16] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82097 (owner: 10Matmarex) [18:02:24] i guess, i can add it back [18:02:45] i think i removed two or three more [18:02:46] MatmaRex: add back the one in AjaxDispatcher too? :) [18:02:57] really? I just noticed one [18:03:02] as in, that + AjaxDispatcher [18:03:04] PissedPanda: no, that one is, like, really dumb [18:03:06] dumber than this one [18:03:08] true [18:03:09] casting to string [18:03:12] is dumb [18:03:26] PissedPanda: i also removed some (bool) casts on a $a < $b statements [18:03:32] (03PS3) 10Kaldari: Updating eventlogging schema revision number for mobile data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82554 [18:03:38] on $a < $b statements * [18:03:45] forgot which file [18:03:56] view a `git diff -s` and see [18:03:59] or is it -w [18:04:07] just 'git show' does that [18:04:14] -w [18:04:19] it ignores whitespace-only changes [18:04:32] (03PS1) 10Seb35: version 0.2 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82643 [18:04:38] the last one is in LanguageSr, there are three in total [18:04:54] MatmaRex: yeah, the bool ones were stupid [18:05:12] MatmaRex: I think having the int one makes sense, killing the rest is fine [18:05:20] alright [18:05:22] * MatmaRex amends [18:05:42] (03PS3) 10Manybubbles: Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 [18:06:11] (03PS2) 10Matmarex: No spaces after (casts) [core] - 10https://gerrit.wikimedia.org/r/82097 [18:06:14] PissedPanda: doneded [18:06:17] (03PS8) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 [18:06:45] sweet [18:07:58] (03CR) 10Yuvipanda: [C: 032] "Consistency!" [core] - 10https://gerrit.wikimedia.org/r/82097 (owner: 10Matmarex) [18:08:22] done, MatmaRex [18:08:41] yay [18:09:00] I should print a T shirt with something about 'merges trivial patches that need no testing!' [18:09:29] (03CR) 10Matthias Mullie: [C: 032] Remove Echo preference change eventlogging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/71854 (owner: 10Bsitu) [18:09:34] PissedPanda: https://gerrit.wikimedia.org/r/#/c/82099/ is one such patch, if you want ;) [18:10:00] (03Merged) 10jenkins-bot: Remove Echo preference change eventlogging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/71854 (owner: 10Bsitu) [18:10:28] doing, MatmaRex [18:11:26] (03CR) 10Matmarex: "pom pom pom" [core] - 10https://gerrit.wikimedia.org/r/52611 (owner: 10Matmarex) [18:14:06] (03Merged) 10jenkins-bot: No spaces after (casts) [core] - 10https://gerrit.wikimedia.org/r/82097 (owner: 10Matmarex) [18:16:08] MatmaRex: well, for https://gerrit.wikimedia.org/r/#/c/82099/ - there's another under #simpleSearch - a hidden submit [18:16:09] (03PS1) 10Chad: PHP 5.3 sucks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82644 [18:16:21] MatmaRex: it doesn't matter for the code, but amend the commit message? [18:16:21] (and I'll merge) [18:20:04] (03CR) 10Manybubbles: [C: 032] PHP 5.3 sucks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82644 (owner: 10Chad) [18:20:07] (03Merged) 10jenkins-bot: PHP 5.3 sucks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82644 (owner: 10Chad) [18:21:05] (03CR) 10Yuvipanda: [C: 04-1] "Super minor nitpick - there's another in #simpleSearch - the hidden submit. While it doesn't matter for CSS, it does matter in the" [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Matmarex) [18:30:07] (03PS2) 10Seb35: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82587 (owner: 10Raimond Spekking) [18:32:15] (03PS1) 10Chad: Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82645 [18:32:22] (03CR) 10Chad: [C: 032 V: 032] Cirrus to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82645 (owner: 10Chad) [18:37:14] (03PS9) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 [18:42:11] (03PS4) 10Chad: Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 (owner: 10Manybubbles) [18:42:22] (03CR) 10Chad: [C: 032] Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 (owner: 10Manybubbles) [18:42:24] (03Merged) 10jenkins-bot: Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 (owner: 10Manybubbles) [18:42:42] (03PS8) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [18:42:59] Jamesofur|away: hi [18:43:22] I am concerned about the PP banner [18:44:26] (03CR) 10Seb35: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82587 (owner: 10Raimond Spekking) [18:46:05] (03PS9) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [18:51:55] hi hashar! [18:52:12] hashar: are you by chance involved in mediawiki/tools/code-utils project, or know someone who is? [18:53:12] because it has like 20 seemingly trivial patches pending since february. https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/tools/code-utils,n,z [18:53:57] * PissedPanda pokes Romaine [18:54:04] Romaine: around? [18:54:11] yes [18:54:22] Romaine: this is incomplete, but I'm building http://tools.wmflabs.org/masscamps [18:54:36] Romaine: so you have a way to look at and manage lots of campaigns at the same time. [18:54:43] it needs work but this is an early preview [18:55:10] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #252: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/252/ [18:55:32] Romaine: let me know what other facilities you need in the campaign manager tool. [18:59:09] (03PS3) 10Legoktm: Autocomplete suggestions for spamlist input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 [19:00:07] Romaine: let me know what you think [19:00:37] my first thought at the moment is that my head is too full to consider that now [19:02:07] I do not want to disappoint you with that [19:04:52] tool is handy to quick see all pages [19:05:00] http://i.imgur.com/cepKbGC.jpg [19:05:19] Romaine: I understand. I'll poke you in a few days. [19:05:41] Romaine: that patch got merged, and will get deployed sometime next week. But I'll make sure this tool does whatever you need it to do before that. [19:05:45] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #263: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/263/ [19:05:50] (03Abandoned) 10Seb35: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HSTS into i18nfixes [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82588 (owner: 10Raimond Spekking) [19:06:39] at the moment the focus has shifted to other subjects: maintining WLM campaigns is mostly an issue in August [19:07:11] Romaine: hmm, so this tool isn't even strictly necessary? [19:07:20] (03CR) 10Seb35: "Thanks a lot for these i18n fixes." [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82587 (owner: 10Raimond Spekking) [19:07:44] currently only individual cases that require a small change are mostly the onliest issu now [19:08:15] Romaine: hmm, so I can even leave this tool as is and focus on other things? [19:08:21] that would be nice [19:08:52] as long as I can view campaigns in their table format I am fine at the moment [19:08:56] (03CR) 10Raimond Spekking: "Yeah thanks for cleaning up my mess. Now idea what I have done wrong... Git is sometimes still a black box for me ..." [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82588 (owner: 10Raimond Spekking) [19:10:15] Romaine: when that patch gets deployed next week you'll have to use this tool to view campaigns in table format. [19:11:27] (03PS3) 10Nikerabbit: Show nothing on cache miss for stats [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/82612 [19:11:52] somehow I think that is strange, why not a page onwiki? [19:12:07] someone suggested a tab for the table view [19:12:15] (03PS1) 10Umherirrender: Added {{REVISIONSIZE}} variable to get the current size of a revision. [core] - 10https://gerrit.wikimedia.org/r/82650 [19:13:24] and I certainly need to be able to link to them [19:14:01] Romaine: oh yes, I'll add a linking facility to the tool. tools.wmflabs.org/masscamps/ [19:14:04] should work [19:14:56] I miss history button [19:15:08] will link to that also [19:15:16] I can even have it show in the same page when you click it [19:15:52] and talk page link [19:16:05] Romaine: okay, will add! [19:16:08] (03CR) 10Umherirrender: "Plural is designed to work with formatted numbers, so that is not a problem." [core] - 10https://gerrit.wikimedia.org/r/82602 (owner: 10Shirayuki) [19:16:11] [21:15] I can even have it show in the same page when you click it -> what does that mean? [19:16:33] Romaine: so like how there's an 'edit' button now, I'll add 'Talk' and 'History' buttons [19:17:14] for talk page, I can just display that in the same page you are viewing, but on second thoughts i think just linking to commons might be better [19:17:20] Romaine: ignore what I said about 'show in the same page' [19:17:52] I just need all the buttons I have now [19:17:56] got it [19:18:09] incl renaming/protect/delete [19:18:56] but I still not completely happy, in my Commons screen I have added everything what I need [19:19:03] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82652 [19:19:24] Romaine: 'in my Commons screen I have added everything what I need' -> what else do you need? [19:19:59] half of my navigation would be lost with the tool [19:20:09] in my screen on Commons I have a lot of links I use often [19:20:20] like watchlist and such, but also buttons I made myself [19:21:14] can you show me a screenshot? [19:22:56] hmm, perhaps I could just make it a gadget [19:23:00] and keep you in your familiar environment [19:23:35] a screenshot, yes I can but it are just a view buttons more [19:25:52] mail send with screenshot [19:26:49] Romaine: aah, I understand now [19:26:55] Romaine: let me think of a way to get you the tables. [19:27:47] (03PS2) 10Seb35: version 0.2 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82643 [19:28:25] to me the best would just having it in a Commons page, if you really want to users not seeing the table, a extra tab, like set in preferencs, to see the table would then b the best [19:29:24] I could add a gadget easily. [19:31:17] YuviPanda: Special:AllTheCampaigns! [19:31:31] (03Abandoned) 10Umherirrender: Api: Add editnotices to prop=info [core] - 10https://gerrit.wikimedia.org/r/74963 (owner: 10Umherirrender) [19:32:22] legoktm: http://funny-animated-gifs.com/wp-content/uploads/2013/05/michael-scott-no.gif :P [19:32:36] (03PS17) 10Adamw: AutoLoader, grok namespace [core] - 10https://gerrit.wikimedia.org/r/59804 [19:32:44] hahaha [19:33:37] (03CR) 10Adamw: "PS17: rebase" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [19:33:44] (03CR) 10jenkins-bot: [V: 04-1] AutoLoader, grok namespace [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [19:38:08] (03CR) 10CSteipp: [C: 04-1] "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82634 (owner: 10Anomie) [19:42:28] (03PS1) 10Matmarex: jquery.suggestions: Add some comments [core] - 10https://gerrit.wikimedia.org/r/82664 [19:43:01] ^ trivial [19:43:25] MatmaRex: missing QUnit tests to spell check the comments [19:43:36] oh my. let me fix it. [19:43:42] :-] [19:43:56] (03CR) 10Hashar: [C: 031] jquery.suggestions: Add some comments [core] - 10https://gerrit.wikimedia.org/r/82664 (owner: 10Matmarex) [19:44:14] also, hashar [19:44:16] [20:52] hashar: are you by chance involved in mediawiki/tools/code-utils project, or know someone who is? [19:44:18] i am too afraid to merge js [19:44:21] [20:53] because it has like 20 seemingly trivial patches pending since february. https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/tools/code-utils,n,z [19:44:23] (03PS3) 10Seb35: version 0.2 [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82643 [19:44:28] i think you missed that? [19:45:04] MatmaRex: ah yeah I did comment on some of them, platonides did not follow up though [19:45:16] some patches are mixing up line of code and are tightly coupled [19:45:30] hm. [19:45:43] + I would prefer we focus on PHP CodeSniffer instead of maintaining our reinvented wheel of bad code [19:46:05] i don't care, i just want to make some open patches disappear [19:46:15] we have some sweet stats over at https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [19:46:33] and the totals at the bottom have been increasing since wmf moved to git [19:46:36] if they get cleaned up , I could approve them [19:46:36] (03CR) 10Yuvipanda: [C: 032] jquery.suggestions: Add some comments [core] - 10https://gerrit.wikimedia.org/r/82664 (owner: 10Matmarex) [19:47:01] but honestly I am not willing to invest time in maintaining our homegrown code utils when there are other alternatives [19:47:07] maybe the patches can be abandonned [19:47:23] +1 to abandoning [19:47:44] (03PS18) 10Adamw: Autodiscover classfiles via namespace heirarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [19:50:36] (03PS12) 10Swalling: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [19:51:59] (03Merged) 10jenkins-bot: jquery.suggestions: Add some comments [core] - 10https://gerrit.wikimedia.org/r/82664 (owner: 10Matmarex) [19:52:16] (03PS2) 10Matmarex: vector/screen.css: Remove some unnecessary rules [core] - 10https://gerrit.wikimedia.org/r/82099 [19:55:26] (03PS4) 10Bsitu: Adding Echo jobs to deferred update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 [19:55:30] MatmaRex: you can merge https://gerrit.wikimedia.org/r/#/c/82530/ :) [19:56:12] (03CR) 10Yuvipanda: [C: 032] Update README to note that the current version will work up to 1.21 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/82530 (owner: 10Legoktm) [19:56:33] (03CR) 10MaxSem: [C: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82652 (owner: 10MaxSem) [19:57:05] YuviPanda: :( [19:57:36] YuviPanda: you'll totally waste my crstats. https://toolserver.org/~nemobis/crstats/core.txt i've already fallen behind L10n-bot [19:57:43] :P [20:00:20] (03PS1) 10Platonides: Add support for Belarus, although it's not officially in yet. [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/82740 [20:01:26] yeah, sneaky subtle people adding... RELEASE NOTES! who would ever do such a thing without an evil purpose [20:04:28] (03PS1) 10Platonides: Fix Belarus year [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/82741 [20:07:48] (03Merged) 10jenkins-bot: Update README to note that the current version will work up to 1.21 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/82530 (owner: 10Legoktm) [20:29:58] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82746 [20:30:16] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/82746 (owner: 10MaxSem) [20:39:29] spagewmf: hello! do you know if the Campaigns extension is on the regular deployment train or does it require manual deployments? [20:44:37] (03CR) 10Legoktm: [C: 032] Autocomplete suggestions for spamlist input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 (owner: 10Legoktm) [20:44:48] (03Merged) 10jenkins-bot: Autocomplete suggestions for spamlist input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/82579 (owner: 10Legoktm) [20:58:16] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/82748 [20:59:23] chrismcmalunch, still doing lunch? :) [20:59:46] qgil: just back, what's up? [20:59:47] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/82748 (owner: 10MaxSem) [21:00:19] hi chrismcmahon did you see Renuka's email from last week? The volunteer willing to do manual testing [21:00:53] qgil: yes, I answered yesterday [21:01:49] chrismcmahon, ah yes, now I see. I got distracted with the change of topic. Sorry. Thanks! [21:04:37] chrismcmahon, the fact of having a manual testing volunteers asking what to do kept me thinking... Should we have some kind of backlog for people to look at? https://www.mediawiki.org/wiki/QA/Features_testing#Get_involved is too vague [21:05:36] greg-g: will the deployment continue running next week during all-hands meetings? [21:05:39] qgil: good question, I don't have an answer ready, I'll think about that [21:06:14] (03CR) 10Jeroen De Dauw: "@Chad:Duplication is indeed not desired. One should not have to look at the docs however to know what a function does. Its name should cle" [core] - 10https://gerrit.wikimedia.org/r/52177 (owner: 10Jeroen De Dauw) [21:07:02] greg-g: by 'deployment' i mean 'deployment train' [21:07:55] (03CR) 10Jeroen De Dauw: "Just realized that the method is a one-liner returning a field, in which case calling the primary implementation from the alias might be r" [core] - 10https://gerrit.wikimedia.org/r/52177 (owner: 10Jeroen De Dauw) [21:08:34] (03PS7) 10Jeroen De Dauw: Allow registration of Actions using a callback that returns an Action instance [core] - 10https://gerrit.wikimedia.org/r/49785 [21:08:50] (03CR) 10Chad: "Yes, I am opposed to this. Suggest abandoning." [core] - 10https://gerrit.wikimedia.org/r/52177 (owner: 10Jeroen De Dauw) [21:20:20] ^d: hey, you [21:20:29] ^d: you changed your gerrit nickname? [21:20:36] ^d: if yes, how do i? [21:21:00] <^d> I e-mailed labs-l about it ;-) [21:21:37] (03PS1) 10CSteipp: Correct directory for patch extensions [tools/release] - 10https://gerrit.wikimedia.org/r/82749 [21:23:13] eh, emailing [21:23:17] irc is so much better [21:23:28] awjr: I think you were asking (before $#@! Unity HUD/compiz froze my PC) about Campaigns and the release train? Yes, it's enabled everywhere, and master should ride the train. [21:23:54] ^d: does this mean https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 is fixed? [21:29:47] spagewmf: awesome thanks! [21:31:05] <^d> MatmaRex: Fixed as in we know how to do it now. [21:31:13] <^d> But we haven't automated it yet like we'd like. [21:32:17] ^d: can you change mine? that "Matmarex" has bee ngetting on my nerves [21:32:53] (to Bartosz Dziewoński (my full name). i hope the "ń" will come through.) [21:33:13] <^d> Today's not the best time, can you ping me about it tomorrow? [21:33:18] mkay [21:33:22] thanks [21:52:30] (03CR) 10Matmarex: "Fixed." [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Matmarex) [21:59:49] (03PS3) 10Yuvipanda: vector/screen.css: Remove some unnecessary rules [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Matmarex) [21:59:56] (03CR) 10Yuvipanda: [C: 032] vector/screen.css: Remove some unnecessary rules [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Matmarex) [22:00:10] MatmaRex: minor tweak + pushed [22:00:11] should've done this the previous time itself [22:03:11] (03Merged) 10jenkins-bot: vector/screen.css: Remove some unnecessary rules [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Matmarex) [22:09:26] * YuviPanda pokes bd808 about poking ori-l about 'comments from the BDFL re: role::multimedia and stuff' [22:10:06] * bd808 dodges the poke using crane technique [22:10:15] If do right no can defend [22:11:08] ori-l:Has the BDFL had time to ruminate on the true nature of roles in vagrant puppet? [22:12:03] * bd808 wonders if first he must realize there is no role [22:12:25] there is no role, only class? [22:12:34] or no role, only apt? [22:13:15] something about spoons and less than awesome sequels [22:13:36] There were no sequels [22:13:44] just like there have been no star trek movies in the last decade [22:13:45] :) [22:13:56] oh I like the reboots [22:14:12] Spock with a Girlfriend? Oh come on! [22:14:42] how can you get from 'Why did you marry her?' 'It seemed like the logical choice at the time' to 'Let us have a relationship fight while starting on an away mission'. [22:14:44] unforgivable! [22:14:59] * bd808 feels this may start a flame war [22:15:08] * ^d grabs some popcorn [22:15:16] new Scotty > old Scotty [22:15:36] rest his soul [22:15:38] bd808: that I think I can sortof agree with. [22:15:57] old chekov > new chekov [22:16:04] agreed [22:16:32] new McCoy has potential, but not there yet. [22:16:40] new spock is the worst. [22:16:46] Uhura vs Uhura: thoughts? [22:17:05] older one, definitely. [22:17:27] mostly because in the newer one she's just an accessory to spock than anything else. [22:17:42] point to YuviPanda [22:17:59] so, I think newer Scotty > old Scotty, and... that is about it. [22:18:02] <^d> Old earth vs new earth? [22:18:17] who cares about Earth, really? :P [22:18:34] <^d> 7.something bn people? [22:18:37] The whole point is to abandon this wilting rock [22:18:49] <^d> Rocks wilt? [22:18:52] also, honstly, if you are having a star ship fight so close to earth that when you lose power you are going to be pulled in by its gravity, and there are no defense nets / other ships to come along... [22:19:02] clearly new earth sucks :P [22:19:08] battle for sector one had way more ships. [22:19:18] despite being a bit later, but still... [22:19:31] * bd808 waits for reboot Borg [22:19:41] oh god no. [22:19:52] there will be sooo many lazers! [22:20:12] they'll emphasize the queen a lot more and the 'collective intelligence' a lot less [22:20:17] (03CR) 10Mattflaschen: [C: 04-1] "(5 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [22:20:33] bd808: they also turned Klingons into something a lot more like Predator. [22:21:13] grrr. [22:21:27] <^d> What we need is a Voyager reboot. [22:21:40] Enterprise Season on Netflix! [22:21:48] Yeah Klingons and Romulans are getting written pretty thinly [22:21:51] ^d: true, the ending was super-meh [22:22:24] <^d> Threshold in movie form? [22:22:28] <^d> Oh yes please. [22:22:41] year of hell, even [22:22:47] but year of hell was already almost movie length [22:23:04] and no threshold, no :P [22:23:11] do you have to pick the worst? :P [22:24:07] <^d> Honestly I'm just hoping there's someone here who's never heard of it and goes off to watch it. [22:24:21] people - do *not* watch threshold! [22:25:19] there were a bunch with Sarah Silverman in them. They were quite good too [22:25:44] <^d> I am not a fan of Sarah Silverman. [22:26:32] I don't know of her work outside Voyager [22:26:34] * AaronSchulz is reminded of Future's End [22:26:46] AaronSchulz: it is! [22:28:07] Ed Begley, Jr. - Henry Starling [22:28:13] * AaronSchulz always thought it was "Sterling" [22:28:21] (03PS1) 10Mwjames: (Bug 48944) RL rearrange resource dependencies [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/82757 [22:28:28] * AaronSchulz gets old [22:28:43] * YuviPanda looks at airing date [22:29:04] mm, I was 5 years old! [22:29:07] but didn't have cable tho [22:29:08] oh well [22:29:17] bd808: anyway, coming back, do poke ori-l :) [22:29:46] I had to say his name three times last week to make him appear... [22:30:40] (03CR) 10Mwjames: [C: 032] (Bug 48944) RL rearrange resource dependencies [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/82757 (owner: 10Mwjames) [22:30:42] (03Merged) 10jenkins-bot: (Bug 48944) RL rearrange resource dependencies [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/82757 (owner: 10Mwjames) [22:30:43] ori-l ori-l ori-l: BDFL decisions made yet? *YuviPanda made me ask* [22:31:00] * bd808 feels that is that doesn't work nothing will [22:31:00] snitch! :P [22:31:32] :/is/if/ [22:31:43] bd808: hey [22:31:47] give me a few [22:31:58] 3 times works again! [22:32:34] what? [22:33:01] ah you arrive after being summoned thrice [22:33:09] much like Biggie Smalls [22:35:13] all right [22:35:15] let's see here [22:36:04] I think the question on the table is "are roles to be team based catchalls or per-extension config" [22:36:04] bd808: what was that bug again? [22:36:09] the bug you linked to in gerrit wasn't the right one [22:36:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=53222 maybe? That's the package problem [22:37:05] i think the first step is to rescue you from the package conflict so we can reason about this without the 'omg halp' getting in the way [22:37:25] That would be nice. [22:37:33] mo roles mo problems [22:37:46] bd808: Why can't they be both? [22:38:23] marktraceur: I think you meant to type `` :) [22:38:29] Maybe [22:38:56] bd808: I mean, I was creating roles for DonationInterface and its ilk a while back, but also created "fundraising" [22:39:02] either ensure_packages from stdlib might help, because that could be in both without causing an error, only install if it's needed [22:39:11] and/or the problem is the roles are doing too much stuff at a time [22:39:21] and there should just be a single class for imagemagick [22:40:19] mutante: ensure_packages would work, but i'm loathe to use the stdlib [22:40:59] ori-l: we need even more roles, but they need to do less in a single one [22:41:10] I've gotten the impression that ori-l wants vagrant's puppet to be short and to the point [22:41:11] more like the Unix way, one tool for small thing [22:41:56] ori-l: why not use stdlib, it's installed and puppetlabs recommends it? [22:42:29] mutante: I tend to agree about small and many, but having "meta roles" or something to bundle for a team may be nice [22:42:59] the mechanism for picking via `vagrant list-roles` and firends will not be fun if there ar 300 to look at [22:43:15] things like "ensure_packages" are fighting with the language [22:43:38] it's like, "are you sick of puppet's fucking bullshit? use ensure_packages()" [22:43:51] to beat up puppet and get around its design [22:43:59] now, i am indeed sick of puppet's fucking bullshit [22:44:10] but [22:44:28] i still have this notion that puppet can be crockforded [22:44:32] i.e., "puppet: the good parts" [22:44:48] js being crackforded didn't mean we stopped using jQuery [22:44:57] i.e., identify the subset of puppet that works well and stick to it [22:45:08] for example, inheritance is right out; you don't need it [22:46:18] bd808: ori-l: hrmm. yeah, then we should probably just have a class for imagemagick that isn't part of either of those 2 roles [22:46:45] or insist on making all package resources @virtual [22:46:59] though bd808 ran into an issue with that and i have to confess i'm not 100% clear on all the implications of virtual resources either [22:47:07] but i'm giving it a shot to see [22:49:39] * bd808 reads stuff online [22:49:51] would `ensure => present` fix the problem? [22:50:21] or does that only effect mixed use to package/ensure_packages [22:50:32] :/to/of/ [22:50:44] maybe; site.pp makes 'present' the default implicit ensure for all Package resources [22:50:55] but that could be broken in some hidden way like so many other things in puppet [22:51:08] * ori-l reads http://docs.puppetlabs.com/puppet/2.7/reference/lang_virtual.html#behavior [22:51:25] "Virtual resources are useful for ... Overlapping sets of resources which may be required by any number of classes" [22:51:30] so I'm not completely crazy to be thinking this [22:51:34] but it's not working for me either [22:53:04] https://groups.google.com/forum/#!topic/puppet-users/BDSRwZifoYY [22:53:33] not sure it's canonical info [22:54:41] Does anyone know if there's something missing from https://www.mediawiki.org/wiki/Manual:Job_queue/For_developers ? I'm not seeing my jobs get loaded into the queue. [22:55:18] Oh, or I'm being stupid again. [22:55:23] * marktraceur brains [22:55:25] bd808: https://groups.google.com/forum/#!topic/puppet-users/DSoCopswL-s seems to confirm [22:55:26] again? i think you mean still. :) [22:55:41] ebernhardson: Thanks. :P [22:55:47] marktraceur: i'm here to help. :) [22:56:04] (but only with comedy relief :P) [22:56:11] Indeed [22:56:27] It would seem that isEmpty isn't returning what I'd expect from a queue that showJobs says is empty. [22:58:08] ori-l: so a single class that virtually defines possible packages and then include it and realize the ones you need? [22:58:30] no, it's not necessary to combine both approaches, we should choose one [22:58:58] the class-based approach relies on the fact that you can include a class in as many places as you like; it only gets instantiated once [22:59:10] so we could, for example, have a 'packages.pp' [22:59:27] and rather than package { 'imagemagick': } you'd do 'include packages::imagemagick' [23:00:30] TIL puppet [23:00:31] i wonder how ensure_packages() actually works behind the scenes [23:00:32] * ori-l looks [23:00:46] it's a parse order kludge [23:01:20] I think it's equivalent to `if !defined(Package["foo"]) {` [23:01:47] it looks like it, yeah, and if so it is indeed vulnerable to parse order [23:02:28] (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74096 (owner: 10Kaldari) [23:03:01] yes, confirmed. [23:03:39] I'm not opposed to the "everything is a class" model, but I don't have any notion of puppet-purity [23:03:58] * bd808 resists urge to google "puppet purity test" [23:04:12] heh [23:04:15] yeah, i'm coming around to that idea [23:04:25] (03CR) 10Mattflaschen: [C: 04-1] "(3 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [23:06:07] i guess it's a tossup between: [23:06:17] a) packages.pp and 'include packages::imagemagick' [23:06:36] b) packages.pp w/@virtual resources & 'realize(imagemagick)' [23:07:06] c) The Java Way -- turning everything into a class hierarchy [23:07:50] by which i mean having to scratch your head to come up with names for "that thing that both foo and bar have in common" so you can create an ancestor class that both inherit from [23:08:33] or d) ensure_packages() or some variant thereof [23:08:36] which is the direction we sort of started down with role::multimedia and it tasted bad [23:08:45] ^ meant (c) [23:08:48] right [23:09:16] (d) does have one thing going for it which is you get to express the dependency in just one place (and the appropriate place, at that) [23:09:29] meaning you don't have to jump to another file whenever you want a package [23:09:41] and no matter which we pick there will be a problem eventually if we start pulling in other peoples modules? [23:09:44] puppet::getFactoryInstance::VirtualPackageNew()->InstantiateRoleEngine.Apply() [23:10:09] spagewmf: you laugh now, but someone will get very rich implementing that [23:10:41] you know who else got very rich? Hitler [23:10:42] bd808: reusability in the world of puppet is mostly an abstract ideal anyway [23:10:57] monkey@typewriter API design :) [23:11:16] Reuse between ops-puppet and vagrant-puppet seems like a neat idea though [23:11:42] it's probably "a lot of work" but neat none the less [23:11:58] yes, that's true -- so which of these options is most compatible with that? [23:12:18] no idea at all. I haven't looked at ops-puppet much yet [23:13:26] ori-l: hmm, how about moving things into modules, and having that be the 'top level'? [23:13:38] hmm, nevermind [23:13:39] YuviPanda: what do you mean? [23:13:52] I was typing out what I thought I meant, and that just sounded dump and impractical [23:13:54] so ignore :P [23:14:00] *dumb [23:14:12] Nova->makeInstanceHTMLCheckboxes( `vagrant list-roles` ). *dumber [23:14:27] mutante is probably right [23:14:40] if ensure_packages is used in ops/puppet [23:14:41] ensure? [23:15:13] tho i hate the implementation. maybe we should just add 'package()'? [23:15:18] it wouldn't be hard to port that to operations/puppet [23:15:28] ack -l ensure_package |wc -l == 0 in ops-puppet [23:15:36] bd808: do a git grep [23:15:38] aha! so mutante has a hidden agenda :P [23:15:39] bd808: ack and puppet don't mix [23:16:01] well, that's 0 too :P [23:16:15] also ack does seem to work with puppet [23:16:19] YuviPanda: for people who don't edit ~/.ackrc, you mean [23:16:20] I don't know where I got that notion from. [23:16:23] --type-set [23:16:23] puppet=.pp,.erb [23:16:35] i am but a child [23:16:48] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #17: FAILURE in 1.3 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/17/ [23:16:54] Project VisualEditor-test2.wikipedia.org-linux-firefox build #15: FAILURE in 0.73 sec: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/15/ [23:17:28] ack -l package|wc -l == 83 OTOH [23:17:42] bd808: I was wrong. [23:18:13] * bd808 forgives YuviPanda whatever imagined sin he has commited [23:18:36] okay, i'm optimistic that we can have a small self-contained package() that does the right thing and a) doesn't require the entire stdlib b) is self-contained (i.e., doesn't delegate to a half-dozen other custom functions like ensure_package does) [23:18:58] why not use stdlib, and then fix ensure_package in stdlib? [23:19:00] it's still fighting with puppet, but maybe puppet deserves to be fought [23:19:31] Guys from PuppetLabs bought me beer a yar or so ago. They didn't seem to want to fight [23:19:42] :s/yar/year/ [23:20:05] They did want to drink a lot though [23:20:24] which often leads to fighting [23:20:37] ori-l: why not stdlib? [23:21:42] YuviPanda: because all of stdlib is like that; puppet has a certain design philosophy that it nudges you toward (however imperfectly) and stdlib is a bag of tricks for getting around that [23:22:23] you know what, fuck it, ensure_package, fine [23:22:51] it's there, already implemented, and the stdlib is loaded in operations/puppet anyhow [23:23:32] i hate it, but so what [23:23:34] eh, yea, it's loaded but not using ensure_packages yet [23:23:35] i'll get over it [23:23:38] heh [23:24:31] bd808 / YuviPanda: can you guys wait one more day? [23:24:40] * YuviPanda gives ori-l a drink and a cookie [23:24:51] Sure. [23:24:52] i don't mind merging it with the package defined in a parent class for now [23:24:53] (03PS10) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 [23:24:54] sure, sure. [23:25:10] OK, weird. http://paste.marktraceur.info/198 [23:25:18] I've got my local cherry-picked. It's not a blocker for me [23:25:28] But showjobs always shows 0 [23:25:33] And runjobs doesn't run the job [23:25:49] Not Enough Redis [23:25:53] (I kid, I kid!) [23:26:01] (03CR) 10Ori.livneh: [C: 032] Add role for PdfHandler. [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [23:26:43] AaronSchulz: ping? Is the Redis stuff on our cluster setup to be used for general caching too, and not just session cache? [23:27:11] AaronSchulz: I've a bit of code where using a redis hash to cache / invalidate would be much easier / nicer than using memcached, so thinking of using that. [23:27:12] thoughts? [23:27:30] ori-l: Thanks for the attention. I'm sure you had real work to do that we disrupted [23:28:54] bd808: fighting puppet w/another repo :P [23:29:15] sorry for being fickle [23:29:25] meh. BDFL has rights [23:29:48] bacon double flan latke? [23:30:06] mmmm bacon [23:30:14] am I the only person who finds bacon meh? [23:30:19] YuviPanda: yes [23:30:21] probably [23:30:24] * AaronSchulz doesn't like it [23:30:27] wooo! [23:30:34] no baconaise for you! [23:30:39] ewww [23:30:44] not real bacon [23:30:47] lol, yea its actually pretty horrible :) [23:30:50] * YuviPanda doesn't like mayonaise either. [23:31:04] YuviPanda: just one hash object? [23:31:04] * bd808 shuns YuviPanda's food choices [23:31:06] Maybe baconnaise would be like...two negatives multiplied? [23:31:10] AaronSchulz: one per page. [23:31:14] ahh [23:31:23] AaronSchulz: these are for pages in Campaign namespace. It has JSON that contains wikitext. [23:31:34] AaronSchulz: so I could parse the wikitext and store it in hash, with one key per language. [23:31:37] and invalidate it easily [23:33:08] you could talk to asher about setting up redis instances for general caching. I'd be worried about reusing the ones on mc1-16 due to session being there and the lack of slabbing in redis. [23:33:46] ah, hmm [23:34:01] how big are the key/values in the hashes? [23:34:01] like a few numbers, large serialized blobs? [23:34:07] ^d: re: your twitter replies, think we should start a wikitech conversation about memcached? or would that just devolve into bikeshedding? [23:34:24] AaronSchulz: keys are just lang codes, values are pages that shouldn't be more than a KB on average. [23:34:26] <^d> No, we shouldn't. [23:34:28] <^d> I got made fun of. [23:34:31] * AaronSchulz wouldn't worry about memcached being maintained [23:35:02] even minor patches have been left open for months. Surely that isn't healthy? [23:35:34] <^d> Emphasis on minor. Nobody should worry about them. [23:35:36] * AaronSchulz would imagine separate redis instances on mc1-mc16 would do for this [23:35:51] (on some other port) [23:36:05] ^d: it doesn't build on my mac, and my patch to make that build hasn't even had a comment. [23:36:27] * ^d isn't going to care anymore. [23:36:29] YuviPanda: so the main use of the hash is selective invalidation as well as invalidating all languages for a page? [23:36:37] AaronSchulz: yeah [23:36:55] ^d: what exactly were you made fun of for? [23:37:10] one could work around that in memcached with a per page key with a "touch timestamp" to compare against the per-language keys (if this key goes out then they are all assumed invalid as a special case) [23:37:23] AaronSchulz: sure, but that seems messier. [23:37:32] AaronSchulz: plus the hash seems rather perfect for this use case [23:38:04] AaronSchulz: there aren't that many pages either - around ~150 pages now, and will probably hit 500 by end of 2013. [23:38:12] perhaps, but nothing is using redis quite like this yet...it should work fine, but would require a little ops work (probably not too hard) [23:38:26] ^d: at least you could tell me and maybe I won't be made fun of. [23:38:30] I guess it depends on who has time and how long you'd want to wait [23:38:41] AaronSchulz: would it require procuring new machines? [23:38:42] * AaronSchulz has no objections to approach though [23:39:07] YuviPanda: as I mentioned, one could probably reuse the mc* boxes (which have both redis and memcached on them now) [23:39:17] ah, okay! [23:39:23] but you'd have to ask asher to be 100% [23:39:52] he might also have an opinion on the memcached based approach [23:40:08] YuviPanda: `brew install memcached` works for me. There don't seem to be any special patches applied. [23:40:15] hmm, okay. So a plan of action would be to 1. write the patch (don't merge it yet), 2. poke asher, make sure he's okay with it, 3. figure out puppet stuff to get redis on the mc machines 4. merge / test / deploy [23:40:30] bd808: OS X lion had an aclocal too new (or old?) [23:41:34] ah. I'm 10.8 not 10.7 [23:41:42] AaronSchulz: the actual 'parsing' stuff is going to get deployed with the next deployment. Without any caching for the wikitext. But at worst that's 4 parses of small-ish wikitext per page view, so that's okay enough I guess. [23:42:00] YuviPanda: one downside of hashes is that expiration is not per-language [23:42:07] AaronSchulz: I guess that's oaky? [23:42:17] AaronSchulz: would we be losing signficiant memory that way? [23:42:59] it would mean items accessed in the long-tail might stick longer than they should (if the overall hash expiry is high) [23:43:48] right. But I don't know if that will be a significant enough problem in the long run [23:44:32] of course one could store last-access times in the hash and removed rarely used keys on the fly on hash access...but that would probably be overkill as long as the TTL is not ridiculous [23:44:44] yup [23:44:45] realistically, it may be that it won't matter at all [23:44:52] yup [23:45:09] still, the memcached approach isn't too bad [23:45:40] AaronSchulz: true, but I like the redis approach better - more 'cleaner' [23:45:52] and you could getMulti both (page-lang key,page-touch key) at once to avoid serial RTTs [23:46:21] perf wise I'm guessing it won't make much of a difference [23:46:25] but the redis one is cleaner [23:46:30] neither is much cleaner than the other, they both have some tradeoffs [23:46:44] performance-wise, the memcached one might actually be better, heh [23:47:19] plus the feature is going out next week anyway, without any parser caching :P [23:47:23] not only would LRU be language-level but the LRU in general would suck less (it sucks a bit in redis in general) [23:47:42] (03PS12) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [23:47:50] as in, not really LRU, but randomish-sligtly-lru [23:48:44] heh [23:49:12] well, I guess this is a good enough place to experiment and see how it goes. [23:50:25] I probably won't get to it for another couple of weeks anyway. Unless it blows up in production when deployed next week (which I highly doubt) [23:50:25] (03PS1) 10Bsitu: Notification with a later timestamp should be set as bundle base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82768