[00:18:25] (03PS1) 10Rfaulk: mod - config is project scope not global. [sartoris] - 10https://gerrit.wikimedia.org/r/82357 [00:18:26] (03PS1) 10Rfaulk: add - standardize the way the lock file name is generated .. associate w/ user. [sartoris] - 10https://gerrit.wikimedia.org/r/82358 [00:18:27] (03PS1) 10Rfaulk: fix - logic around parsing lock file name. [sartoris] - 10https://gerrit.wikimedia.org/r/82359 [00:18:28] (03PS1) 10Rfaulk: add - echio config state. [sartoris] - 10https://gerrit.wikimedia.org/r/82360 [00:18:29] (03PS1) 10Rfaulk: add - emit config on info log-level. [sartoris] - 10https://gerrit.wikimedia.org/r/82361 [00:18:47] (03CR) 10Rfaulk: [C: 032 V: 032] mod - config is project scope not global. [sartoris] - 10https://gerrit.wikimedia.org/r/82357 (owner: 10Rfaulk) [00:18:55] (03CR) 10jenkins-bot: [V: 04-1] fix - logic around parsing lock file name. [sartoris] - 10https://gerrit.wikimedia.org/r/82359 (owner: 10Rfaulk) [00:18:57] (03CR) 10Rfaulk: [C: 032 V: 032] add - standardize the way the lock file name is generated .. associate w/ user. [sartoris] - 10https://gerrit.wikimedia.org/r/82358 (owner: 10Rfaulk) [00:19:01] (03CR) 10jenkins-bot: [V: 04-1] add - echio config state. [sartoris] - 10https://gerrit.wikimedia.org/r/82360 (owner: 10Rfaulk) [00:19:17] (03CR) 10Rfaulk: [C: 032 V: 032] fix - logic around parsing lock file name. [sartoris] - 10https://gerrit.wikimedia.org/r/82359 (owner: 10Rfaulk) [00:19:40] (03CR) 10Rfaulk: [C: 032 V: 032] add - echio config state. [sartoris] - 10https://gerrit.wikimedia.org/r/82360 (owner: 10Rfaulk) [00:20:02] (03CR) 10Rfaulk: [C: 032 V: 032] add - emit config on info log-level. [sartoris] - 10https://gerrit.wikimedia.org/r/82361 (owner: 10Rfaulk) [00:57:46] (03PS1) 10Rfaulk: fix / mod - remote & branch config / some log formatting.. [sartoris] - 10https://gerrit.wikimedia.org/r/82362 [00:58:10] (03CR) 10Rfaulk: [C: 032 V: 032] fix / mod - remote & branch config / some log formatting.. [sartoris] - 10https://gerrit.wikimedia.org/r/82362 (owner: 10Rfaulk) [01:02:35] (03CR) 10Rfaulk: [C: 032 V: 032] flake8/pep8 tox environnement [sartoris] - 10https://gerrit.wikimedia.org/r/81907 (owner: 10Hashar) [01:04:37] (03CR) 10Rfaulk: [C: 032 V: 032] sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [01:05:28] (03CR) 10Rfaulk: [C: 032 V: 032] make-release had an unused local var 'length' [sartoris] - 10https://gerrit.wikimedia.org/r/81908 (owner: 10Hashar) [01:08:55] (03CR) 10Daniel Friesen: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [01:56:33] (03PS11) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [02:08:08] Romaine: around? [03:28:50] (03PS1) 10Mwjames: \SMW\AggregatablePrinter use an explicit indicator to aggregate numbers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82364 [04:05:18] (03PS1) 10Mwjames: Renaming ResultCacheMapper -> CacheableResultMapper [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82365 [04:06:54] (03CR) 10Mwjames: [C: 032] Renaming ResultCacheMapper -> CacheableResultMapper [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82365 (owner: 10Mwjames) [04:08:20] (03Merged) 10jenkins-bot: Renaming ResultCacheMapper -> CacheableResultMapper [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82365 (owner: 10Mwjames) [05:10:11] (03PS1) 10PleaseStand: Fix parsing from CLI [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82366 [06:09:41] (03PS13) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [06:11:44] (03CR) 10Pastakhov: "refactoring equal operators" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [06:13:17] (03PS1) 10Rfaulk: fix / add - tagging via dulwich, refactor using Tag object / user.name and user.email to config. [sartoris] - 10https://gerrit.wikimedia.org/r/82367 [06:13:37] (03CR) 10Rfaulk: [C: 032 V: 032] fix / add - tagging via dulwich, refactor using Tag object / user.name and user.email to config. [sartoris] - 10https://gerrit.wikimedia.org/r/82367 (owner: 10Rfaulk) [06:35:00] (03PS1) 10Rfaulk: mod - config section. [sartoris] - 10https://gerrit.wikimedia.org/r/82368 [06:35:01] (03PS1) 10Rfaulk: add - new usage section. [sartoris] - 10https://gerrit.wikimedia.org/r/82369 [06:35:22] (03CR) 10Rfaulk: [C: 032 V: 032] mod - config section. [sartoris] - 10https://gerrit.wikimedia.org/r/82368 (owner: 10Rfaulk) [06:35:37] (03CR) 10Rfaulk: [C: 032 V: 032] add - new usage section. [sartoris] - 10https://gerrit.wikimedia.org/r/82369 (owner: 10Rfaulk) [07:16:40] hmm, there are definetly some strange things going on with http pages. peopl reporting receiving very old pages, or pages where they do not seem to be logged in. [07:17:09] i think the http browsing + centralauth magic is playing a few tricks. [08:18:31] (03PS1) 10Hashar: tweak operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82372 [08:20:51] (03PS1) 10Raimond Spekking: Add .gitreview [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82373 [08:22:58] (03PS2) 10Hashar: tweak operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82372 [08:27:22] (03CR) 10Faidon Liambotis: [C: 031] tweak operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82372 (owner: 10Hashar) [08:30:16] (03PS1) 10Raimond Spekking: Add message documentation [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/82374 [08:31:58] (03CR) 10Hashar: [C: 032] tweak operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82372 (owner: 10Hashar) [08:32:18] (03Merged) 10jenkins-bot: tweak operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82372 (owner: 10Hashar) [08:34:39] (03PS1) 10Hashar: operations-dns-lint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82375 [08:37:34] (03CR) 10Hashar: [C: 032] operations-dns-lint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82375 (owner: 10Hashar) [08:37:41] (03Merged) 10jenkins-bot: operations-dns-lint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82375 (owner: 10Hashar) [08:42:27] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/Model] - 10https://gerrit.wikimedia.org/r/82378 [08:56:53] (03CR) 10LivingShadow: [C: 032 V: 032] "Thanks for the fixes and the qqq!" [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/82374 (owner: 10Raimond Spekking) [09:00:33] (03PS3) 10Hashar: Run unit tests for SemanticMaps and Serialization [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 (owner: 10Jeroen De Dauw) [09:01:45] (03CR) 10Hashar: [C: 032] "Sorry it took so long :(" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 (owner: 10Jeroen De Dauw) [09:02:10] (03Merged) 10jenkins-bot: Run unit tests for SemanticMaps and Serialization [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 (owner: 10Jeroen De Dauw) [09:10:19] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 [09:10:44] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/82385 [09:10:55] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 (owner: 10Hashar) [09:12:04] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/82385 (owner: 10Hashar) [09:12:17] (03CR) 10Hashar: "I have create two Jenkins jobs to trigger the tests:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 (owner: 10Jeroen De Dauw) [09:15:44] (03PS1) 10Hashar: mwext-SemanticMaps-testextensions-master non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82388 [09:16:03] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 (owner: 10Hashar) [09:16:08] (03PS2) 10Hashar: mwext-SemanticMaps-testextensions-master non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82388 [09:16:15] (03CR) 10Hashar: [C: 032] mwext-SemanticMaps-testextensions-master non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82388 (owner: 10Hashar) [09:16:27] (03Merged) 10jenkins-bot: mwext-SemanticMaps-testextensions-master non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82388 (owner: 10Hashar) [09:16:38] (03CR) 10Hashar: "SemanticMaps unit tests are no more voting as of https://gerrit.wikimedia.org/r/#/c/82388/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 (owner: 10Jeroen De Dauw) [09:19:01] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 (owner: 10Hashar) [09:19:05] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 [09:22:17] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82384 (owner: 10Hashar) [09:23:58] (03PS3) 10Hashar: flake8/pep8 tox environnement [sartoris] - 10https://gerrit.wikimedia.org/r/81907 [09:24:26] (03PS3) 10Hashar: sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 [09:24:38] (03PS3) 10Hashar: make-release had an unused local var 'length' [sartoris] - 10https://gerrit.wikimedia.org/r/81908 [09:24:54] (03CR) 10Hashar: "rebased" [sartoris] - 10https://gerrit.wikimedia.org/r/81907 (owner: 10Hashar) [09:25:05] YuviPanda: who is programming grrrit-wm? [09:25:42] I /think/ you are missing color closing tag before last bracket [09:26:35] (03PS1) 10Raimond Spekking: Unbreaking translatewiki.net script [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/82391 [09:26:46] (03CR) 10Raimond Spekking: [C: 032 V: 032] Unbreaking translatewiki.net script [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/82391 (owner: 10Raimond Spekking) [09:33:25] Looks fine to me [09:33:59] (03CR) 10Nikerabbit: "Haven't we standardized on @param type $name Description. format yet?" [core] - 10https://gerrit.wikimedia.org/r/82255 (owner: 10Reedy) [09:54:26] (03CR) 10Hashar: "I am not even sure what linkprefix is for. It would be really nice to have some unit test along this change, even if they are very simple" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [10:21:24] Reedy, it shows up wrong when you are highlighted IIRC [10:21:54] it shows as all black on my client when highlighted [10:22:43] (03PS1) 10Raimond Spekking: Add i18n file [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/82394 [10:25:21] (03PS9) 10Alex Monk: Make mwCustomEditButtons a no-op and mark it as deprecated [core] - 10https://gerrit.wikimedia.org/r/71176 [10:25:39] first ( is shown as red [10:25:41] rest is normal [10:26:01] so, basically this is not what petan said. okay then.. [10:28:21] (03PS2) 10Raimond Spekking: Add i18n file [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/82394 [10:30:06] (03PS1) 10Raimond Spekking: Add i18n file [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/82395 [10:46:33] (03CR) 10Daniel Friesen: "(1 comment)" [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/82395 (owner: 10Raimond Spekking) [10:52:34] (03PS2) 10Raimond Spekking: Add i18n file [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/82395 [11:13:55] If the channel is +c it wouldn't matter. [11:21:35] If the channel was +c the bots wouldn't work [11:22:42] ... I am wrong. freenode's +c strips, not blocks, colours in messages [12:03:51] (03PS1) 10Platonides: Update url for Slovakia website [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/82397 [12:05:15] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/82395 (owner: 10Raimond Spekking) [12:06:27] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79980 (owner: 10Raimond Spekking) [12:08:04] (03CR) 10Siebrand: [C: 032 V: 032] Some consistency tweaks in preparation for adding extension to translatewiki.net [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/81015 (owner: 10Raimond Spekking) [12:08:29] (03CR) 10Siebrand: [C: 032 V: 032] Add .gitreview [extensions/HSTS] - 10https://gerrit.wikimedia.org/r/82373 (owner: 10Raimond Spekking) [12:09:42] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/Model] - 10https://gerrit.wikimedia.org/r/82378 (owner: 10Raimond Spekking) [12:13:46] (03CR) 10Siebrand: [C: 032] Fixup truncated license header [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/60439 (owner: 10Reedy) [12:13:48] (03Merged) 10jenkins-bot: Fixup truncated license header [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/60439 (owner: 10Reedy) [12:15:13] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 (owner: 10Reedy) [12:16:12] (03CR) 10Siebrand: [C: 032] Method parameter type hints [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/82355 (owner: 10Reedy) [12:16:15] (03Merged) 10jenkins-bot: Method parameter type hints [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/82355 (owner: 10Reedy) [12:18:02] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82255 (owner: 10Reedy) [12:40:01] (03CR) 10Siebrand: [C: 04-1] "-1 for previously pointed out issues." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [12:41:59] (03CR) 10Siebrand: [C: 04-2] "We probably should not introduce code that is not in the Translate extension that caters to obsolete functionality. In the Translate exten" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 (owner: 10Shirayuki) [12:48:54] hi anomie! how are you? [12:49:08] hi sumanah! I'm ok, how are you? [12:49:25] I kind of wish it had been a 4-day weekend. Is that greedy? [12:50:49] No, 4-day weekends are nice. I managed to not get anything done with my extra day yesterday, though. [12:52:08] I watched a lot of TV, honestly [12:52:58] anomie: I'm 1/3 of the way through this super interesting book http://www.amazon.com/exec/obidos/ASIN/0691157219/ [12:54:00] That seems like one to *not* put in your airplane carry-on ;) [12:55:30] Sounds like it could be interesting, though. [12:56:16] (03CR) 10Siebrand: "Doesn't this fragment parser caches?" [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender) [12:56:31] anomie: if I take it to SF it'll be with another book's dustcover I think [12:58:30] (03CR) 10Siebrand: "If there is consensus at some point this should be merged, please notify me by email. I'll have to rename extension translations, too, and" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [12:59:06] (03CR) 10Siebrand: "Just to be clear: Once there is consensus to merge, please let me merge it, so things don't go out of sync." [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [13:00:30] anomie: can you help jubo in #mediawiki ? [13:00:55] * anomie looks [13:03:26] (03PS3) 10Siebrand: (Bug 44947) Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:03:55] (03CR) 10jenkins-bot: [V: 04-1] Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:05:34] (03CR) 10Siebrand: "If someone can fix the merge conflicts, I'll merge." [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:05:42] (03CR) 10Siebrand: [C: 031] Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:06:26] (03PS3) 10Siebrand: (bug 45064) Create block log entries on HideUser blocks too [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [13:09:19] * anomie helps [13:09:54] (03CR) 10Siebrand: [C: 04-1] "I think -1 per Nischayn22." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/50714 (owner: 10Alex Monk) [13:10:37] (03PS7) 10Siebrand: (bug 36098) Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [13:10:38] (03CR) 10jenkins-bot: [V: 04-1] Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [13:13:00] (03CR) 10Siebrand: [C: 04-1 V: 04-1] "(1 comment)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [13:15:03] (03CR) 10Siebrand: "(1 comment)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [13:18:38] (03CR) 10Siebrand: [C: 032] Show entire link (including wgServer and protocol) in summary Link To box [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/66334 (owner: 10Alex Monk) [13:18:50] (03Merged) 10jenkins-bot: Show entire link (including wgServer and protocol) in summary Link To box [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/66334 (owner: 10Alex Monk) [13:27:31] (03CR) 10Siebrand: [C: 032] Don't show edit form open warning when saving thread summary [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82251 (owner: 10Alex Monk) [13:27:32] (03PS1) 10Shirayuki: Add full-stops to messages [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82404 [13:27:35] (03Merged) 10jenkins-bot: Don't show edit form open warning when saving thread summary [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82251 (owner: 10Alex Monk) [13:28:07] (03CR) 10Siebrand: [C: 032] Add full-stops to messages [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82404 (owner: 10Shirayuki) [13:28:09] (03Merged) 10jenkins-bot: Add full-stops to messages [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82404 (owner: 10Shirayuki) [13:28:43] (03CR) 10Siebrand: [C: 032] Fix comments for grep [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82230 (owner: 10Shirayuki) [13:28:49] (03Merged) 10jenkins-bot: Fix comments for grep [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82230 (owner: 10Shirayuki) [13:29:38] (03CR) 10Siebrand: [C: 032] Add/update comments for grep [core] - 10https://gerrit.wikimedia.org/r/82084 (owner: 10Shirayuki) [13:30:13] (03CR) 10Siebrand: [C: 032] Fix license name "CC BY-SA" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/82083 (owner: 10Shirayuki) [13:30:19] (03Merged) 10jenkins-bot: Fix license name "CC BY-SA" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/82083 (owner: 10Shirayuki) [13:32:30] (03Merged) 10jenkins-bot: Add/update comments for grep [core] - 10https://gerrit.wikimedia.org/r/82084 (owner: 10Shirayuki) [13:34:06] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/82074 (owner: 10Shirayuki) [13:34:50] (03CR) 10Siebrand: [C: 032] Replace "e-mail" by "email" [extensions/SemanticWatchlist] - 10https://gerrit.wikimedia.org/r/81921 (owner: 10Shirayuki) [13:34:53] (03Merged) 10jenkins-bot: Replace "e-mail" by "email" [extensions/SemanticWatchlist] - 10https://gerrit.wikimedia.org/r/81921 (owner: 10Shirayuki) [13:35:00] (03CR) 10Siebrand: [C: 032] Replace "e-mail" by "email" [extensions/SemanticTasks] - 10https://gerrit.wikimedia.org/r/81919 (owner: 10Shirayuki) [13:35:03] (03Merged) 10jenkins-bot: Replace "e-mail" by "email" [extensions/SemanticTasks] - 10https://gerrit.wikimedia.org/r/81919 (owner: 10Shirayuki) [13:35:16] (03CR) 10Siebrand: [C: 032] Replace "e-mail" by "email" [extensions/SemanticSignup] - 10https://gerrit.wikimedia.org/r/81918 (owner: 10Shirayuki) [13:35:20] (03Merged) 10jenkins-bot: Replace "e-mail" by "email" [extensions/SemanticSignup] - 10https://gerrit.wikimedia.org/r/81918 (owner: 10Shirayuki) [13:35:22] (03CR) 10Nikerabbit: "Can we have the type before the name consistently." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/82355 (owner: 10Reedy) [13:35:38] (03CR) 10Siebrand: [C: 032 V: 032] Replace "e-mail" by "email" [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/81916 (owner: 10Shirayuki) [13:36:05] (03CR) 10Siebrand: [C: 032 V: 032] Replace "e-mail" by "email" [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/81914 (owner: 10Shirayuki) [13:36:27] (03CR) 10Siebrand: [C: 032 V: 032] Use the long PHP tag [extensions/SemanticWebBrowser] - 10https://gerrit.wikimedia.org/r/81913 (owner: 10Shirayuki) [13:38:14] (03PS4) 10PleaseStand: Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:38:17] (03PS10) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 [13:38:21] (03CR) 10Siebrand: [C: 032] Only show search form if LuceneSearch is detected [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82111 (owner: 10Alex Monk) [13:39:12] (03Merged) 10jenkins-bot: Only show search form if LuceneSearch is detected [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82111 (owner: 10Alex Monk) [13:39:17] (03CR) 10Siebrand: [C: 032] Add JS hook for user scripts to add buttons to all LQT textareas as they are created [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [13:39:28] (03Merged) 10jenkins-bot: Add JS hook for user scripts to add buttons to all LQT textareas as they are created [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [13:44:37] (03CR) 10Siebrand: [C: 032] Watching and Unwatching made 'Change Subject' disappear. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/51834 (owner: 10Nischayn22) [13:44:41] (03Merged) 10jenkins-bot: Watching and Unwatching made 'Change Subject' disappear. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/51834 (owner: 10Nischayn22) [13:49:14] (03CR) 10Siebrand: [C: 032] Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [13:49:53] thank you anomie [13:50:47] (03CR) 10Siebrand: "I added Chris Steipp as reviewer, as "information disclosure" is used as a reason to change this, hence needs security review." [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [13:51:00] PleaseStand: thanks! and congrats on the blog post :-) [13:51:30] (03CR) 10Rjain: "Done the changes mentioned inline, however I cannot clearly understand what the cover comment says." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [13:52:55] (03CR) 10PleaseStand: "I don't know why I didn't add him to this change set." [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [13:54:18] (03CR) 10Siebrand: [C: 04-1] "What about "Completed" or "Ended"? I think that "Previous" may be hard(er) to translate." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 (owner: 10Ragesoss) [13:55:52] (03PS1) 10Rjain: Used /*_*/ before the table name in the db patches for renaming user_id and rev_id. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/82408 [13:58:50] (03CR) 10Siebrand: [C: 04-1] "(3 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 (owner: 10Mattflaschen) [14:01:20] (03CR) 10Yaron Koren: "Hi - how useful is this feature? I ask because (a) I don't think I've seen a case yet where a page contained an aggregating map that held " [extensions/SemanticMaps] - 10https://gerrit.wikimedia.org/r/82219 (owner: 10Netbrain) [14:01:25] (03CR) 10jenkins-bot: [V: 04-1] Removed "requires JavaScript" from preference texts [core] - 10https://gerrit.wikimedia.org/r/50614 (owner: 10Rahul21) [14:07:25] (03PS3) 10Shirayuki: Give grep a chance to find the usages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/82074 [14:09:46] (03PS4) 10Shirayuki: Give grep a chance to find the usages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/82074 [14:10:44] YuviPanda: yes [14:15:28] (03CR) 10Chad: [C: 031] Fix parsing from CLI [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82366 (owner: 10PleaseStand) [14:21:28] (03PS8) 10Burthsceh: Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 [14:21:46] (03PS3) 10Chad: Tests for searching headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81962 (owner: 10Manybubbles) [14:21:58] (03CR) 10Chad: [C: 032] Tests for searching headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81962 (owner: 10Manybubbles) [14:22:17] Chad seriously reviews code over breakfast [14:22:22] (03Merged) 10jenkins-bot: Tests for searching headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81962 (owner: 10Manybubbles) [14:22:56] manybubbles: Code review is srs bizness [14:23:31] Reedy: I'm well aware. so is breakfast. [14:35:19] (03CR) 10Chad: [C: 04-1] "(4 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [14:37:31] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar) [14:37:35] (03PS7) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 [14:46:37] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar) [14:54:01] (03CR) 10Parent5446: [C: 032] Used /*_*/ before the table name in the db patches for renaming user_id and rev_id. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/82408 (owner: 10Rjain) [14:54:04] (03Merged) 10jenkins-bot: Used /*_*/ before the table name in the db patches for renaming user_id and rev_id. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/82408 (owner: 10Rjain) [14:55:08] (03PS1) 10BryanDavis: Add role for PdfHandler. [vagrant] - 10https://gerrit.wikimedia.org/r/82417 [15:11:47] (03PS1) 10BryanDavis: Configure UploadWizard for optional chunked upload. [vagrant] - 10https://gerrit.wikimedia.org/r/82418 [15:14:24] ori-l: ^ I'd love your take on what I did here. Its "works for me" at this point but could probably be sexier. [15:26:34] siebrand, thanks for merging all that LQT stuff [15:27:14] Krenair: Yeah, I went on a spree :) [15:27:40] Krenair: everything LQT is reviewed with -[12] now, or merged. [15:27:53] ( per https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/LiquidThreads,n,z ) [15:29:35] siebrand, ugh yeah, I forgot to deal with Nischay's 1st March comment because it was not marked -1 [15:30:44] Krenair: When in doubt, score -1. Otherwise it will just rot, I've noticed. [15:31:12] Krenair: The -1 is at least a reason for continued annoyance on the red side, so it may get resolved at some point :) [15:31:38] Krenair: This one is new, I think: [03-Sep-2013 15:13:18 UTC] PHP Fatal error: __clone method called on non-object in /www/translatewiki.net/w/extensions/LiquidThreads/api/ApiFeedLQTThreads.php on line 81 [15:31:52] Krenair: Probably introduced by one of the merges. [15:32:38] Sometimes I don't mark -1 when I want to defer a decision to someone else [15:32:49] siebrand: No that's https://bugzilla.wikimedia.org/show_bug.cgi?id=48809 [15:32:50] Don't remember for this change though [15:33:14] Ah. [15:33:25] Hadn't seen it for a while; I remember... [15:33:47] haven't got around to looking into that bug yet [15:34:27] (03CR) 10Ori.livneh: [C: 04-1] "(3 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [15:34:35] bd808: ^ [15:35:29] ori-l: thanks [15:36:35] (03PS8) 10Alex Monk: Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 [15:36:43] (03CR) 10Siebrand: [C: 032 V: 032] Give grep a chance to find the usages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/82074 (owner: 10Shirayuki) [15:36:57] np! [15:37:36] (03CR) 10Alex Monk: [C: 04-1] "forgot to deal with ps7 comments on i18n/Lqt.i18n.php" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [15:43:55] I hate trying to fix one issue and running into another [15:45:50] Title::newFromText given an object, hm [15:51:58] (03PS1) 10Himeshi: Added regex for locating page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82423 [15:55:02] (03PS9) 10Alex Monk: Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 [16:03:36] hashar, what PHP version is Jenkins running now? [16:05:30] oh, 5.3.10, says it on the bug comment 26, sorry [16:06:42] (03CR) 10BryanDavis: "(3 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/82417 (owner: 10BryanDavis) [16:06:53] Krenair: PHP 5.3.10-1ubuntu3.7+wmf1 which is the production one + a few minor patches [16:07:35] (03PS3) 10Himeshi: Added generating pages with page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/80863 [16:08:10] (03PS2) 10BryanDavis: Add role for PdfHandler. [vagrant] - 10https://gerrit.wikimedia.org/r/82417 [16:11:28] liangent, ping [16:13:18] qgil: pong [16:13:53] hi liangent , I was trying to find that URL of the Wikidata team where you are posting your reports [16:15:20] liangent, I'm going through all the projects to see their status after the (default) August montlhy report. [16:15:41] liangent, if you look at the GSoC you will see that many are actually not doing monthly reports either, or bi-weekly, etc. [16:16:05] liangent, could you link to your reporting channel from your entry at the Projects table, please? [16:16:28] qgil: sorry I didn't really wrote much as "reports", but there's some technical notes at https://www.mediawiki.org/wiki/User:Liangent/wb-lang/dev and some quick one line status report at https://www.mediawiki.org/wiki/User:Liangent/wb-lang/updates [16:18:02] liangent, the "deal" with the wikidata team and you was that you would follow their reporting process. If not you can do a monthly report. It can be as short as you want, but we need to know what is the current status of your project and what you have done recently. [16:18:31] liangent, I checked the bug reports and there wasn't any movement since late June either. [16:19:05] liangent, just understand that I must follow 21 projects and don't have the luxury to dive deep in any of them to know what is going on. Thank ypou for your understanding. [16:19:19] qgil: "recently" I was trying to get stuff merged as much as possible [16:19:47] liangent, It would be really helpful if you could summarize somewhere your work during August. [16:19:52] instead of creating much new code depending on code pending merge [16:20:21] liangent, look the other reports from your fellow GSoC colleagues, please. I can't copy & paste from IRC. :) [16:22:25] (03PS2) 10BryanDavis: Configure UploadWizard for optional chunked upload. [vagrant] - 10https://gerrit.wikimedia.org/r/82418 [16:23:31] qgil: who should be expected audience? [16:23:49] program organizer, or the community waiting for this feature, or what? [16:24:04] liangent, anybody interested in your project [16:25:00] liangent, again you can see the reports written by other students to get an idea. The rest of students have been reporting regularly. [16:36:54] oh yay [16:37:10] the intersection incategory: twice for the cirrus search works now! [16:37:17] https://www.mediawiki.org/w/index.php?search=incategory%3Amanual++incategory%3Atools&title=Special%3ASearch&srbackend=CirrusSearch [16:37:29] when I went on vacation on friday it was givinng an error [16:37:39] nice going to the folks working on it! [16:47:18] (03CR) 10Yaron Koren: [C: 032 V: 031] Added regex for locating page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82423 (owner: 10Himeshi) [16:47:35] (03Merged) 10jenkins-bot: Added regex for locating page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82423 (owner: 10Himeshi) [16:50:05] zeljkof: :-) [16:50:07] greg-g: maybe publish the etherpad on the qa list ? :-D [16:50:31] hashar: see you in SF soon :) [16:50:43] hashar: good idea! Will do. [16:52:09] zeljkof: will you be there tomorrow morning/aftenroon ? [16:52:20] could ask you a bunch of question regarding cloud bee and saucelabs [16:52:29] hashar: would I be where? here? :) [16:52:36] yeah on irc :-] [16:52:57] (03CR) 10Chad: [C: 032] Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 (owner: 10Manybubbles) [16:53:00] (03CR) 10jenkins-bot: [V: 04-1] Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 (owner: 10Manybubbles) [16:53:04] I should be online tomorrow from about 9 m to about 5-6 pm [16:53:19] I am sure we could drive Saucelabs instances from the wikimedia Jenkins :-] That would make the jobs drivable via Zuul/Gerrit [16:53:20] niceee [16:53:21] lunch break around 12-2, not sure when yet [16:53:28] like me :-] [16:53:34] lets ping each other tomorrow so [16:53:49] hashar: yes, we could drive sauce labs instances from any machine, even our desktops :) [16:54:01] \O/ [16:54:13] hashar: hard part would be getting ruby 1.9 and our list of ruby gems installed there [16:54:17] I really really want to have browser tests running for ULS on merge and then on patch submission [16:54:29] the gems, we can figure it out [16:54:37] even if we have a dedicated Jenkins slave for it hehe [16:54:45] with a label like browserTest :-] [16:55:02] this is the list of gems needed for ULS [16:55:02] https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/tests/browser/Gemfile [16:55:26] and yes, probably a dedicated jenkins slave(s) would be the way to go [16:55:31] (03CR) 10Aaron Schulz: [C: 032] Actually use $ignoreInvalidDB in UserRightProxy::getDB() [core] - 10https://gerrit.wikimedia.org/r/74576 (owner: 10Reedy) [16:55:34] (03CR) 10Daniel Kinzler: [C: 04-1] "Needs manual rebase (otherwise, still +1)" [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [16:56:06] hashar: if the slave machine is linux, we could also drive the browser at the machine, no need for sauce labs then [16:56:20] hashar: headless firefox and phantomjs [16:56:32] but sauce labs has some nice features too [16:56:41] yeah we get phantomjs already for QUnit tests :-] [16:56:42] hashar: anyway, talk to you tomorrow [16:56:50] but sauce labs comes with video replay, console log and whatever [16:57:01] plus you have shown me it got windows instance and IE :-] [16:57:06] hashar: yes, screenshots, video, logs... [16:57:07] yeah familly time. [16:57:12] SauceLabs is nice [16:57:31] hashar: it is my wedding anniversary, time for some beer :) [16:57:36] just have to figure out how to get the Gerrit proposed patchset to be applied on the SauceLab instance that will run the tests [16:57:38] ohh [16:57:51] happy wedding anniversary! tip: write /quite [16:57:54] /quit [16:57:58] bah doesn't work [16:58:02] zeljkof: *wave* [16:58:06] hashar: thanks :) [16:58:11] #me waves back [16:58:16] * zeljkof waves back [17:00:12] I am off [17:00:28] qgil: am I expected to look back to find out what I've done in each month, or is a big overall report enough? [17:00:29] (03Merged) 10jenkins-bot: Actually use $ignoreInvalidDB in UserRightProxy::getDB() [core] - 10https://gerrit.wikimedia.org/r/74576 (owner: 10Reedy) [17:01:02] liangent, no need for big report in any case. The mid-term report already had the pre-August period. [17:02:00] (03CR) 10Zfilipin: [C: 032] updates to fix flakiness, post-VE link for 'Edit source' [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82109 (owner: 10Cmcmahon) [17:02:19] (03PS3) 10Zfilipin: identifier for 'restore' link updated [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82108 (owner: 10Cmcmahon) [17:02:25] (03CR) 10Zfilipin: [C: 032] identifier for 'restore' link updated [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82108 (owner: 10Cmcmahon) [17:03:15] (03CR) 10Zfilipin: [C: 032] this should make the tests for UW pass more consistently [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82107 (owner: 10Cmcmahon) [17:04:57] (03CR) 10Divec: "I can't comment on the deployment issues if we change the interface for $wgLegalTitleChars ." [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [17:10:42] (03CR) 10Matmarex: "Needs the dependency fixed to make the tests pass (which may or may not be a large undertaking, eh) and merged first :)." [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [17:11:41] (03CR) 10Siebrand: [C: 032] Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [17:11:43] (03Merged) 10jenkins-bot: Add revert link to thread move logs and success page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49790 (owner: 10Alex Monk) [17:13:03] Krenair: Any idea why this gives different results? https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/LiquidThreads,dashboards/default:open https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/LiquidThreads,n,z [17:14:12] (03CR) 10RobLa: "This is an emergency fix to correct a rather severe problem on Arabic Wikipedia (bug 52865), and Brad is needed on other work. I would re" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [17:16:11] siebrand: i think the dashboard view doesn't show very old changes - ask qchris or ^d :) [17:16:24] hmm. [17:16:42] <^d> Yeah, dashboard is time-limited. [17:22:14] the link to further results from dashboard has a -7d in it which probably means it includes the last week only? [17:30:39] hexmode: around? [17:31:09] csteipp: from a hosptial bed to you! :) [17:31:44] (03PS1) 10EBernhardson (WMF): Coding standards cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82432 [17:31:50] hexmode: Yikes! But if you're feeling up to it... [17:32:09] It seems like the make-release script isn't checking out the branch for each extension [17:32:19] Or I'm just missing where that's happening? [17:32:23] csteipp: eh, I'd be bored here if I didn't have something to do [17:33:06] (e.g., when I make 1.19.8, it's not checking out the REL1_19 branch of ConfirmEdit, etc.) [17:33:06] csteipp: I think you're right, I don't *think* I removed that, but let me look at what it would take to add it. [17:33:32] hexmode: It didn't used to... I used to do that by hand in my own version of the script :) [17:33:47] csteipp: what version of the make-release script are you using? [17:33:50] (03CR) 10Siebrand: "If there is a problem on Arabic Wikipedia only, then please only fix it for that locale." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [17:34:07] hexmode: The one hashar recommended [17:34:32] bf2467e [17:34:53] Oh, and I removed the exludes from tarignore, since that file didn't exist [17:35:51] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] (bug 53506) Protection disables feedback even if nothing is touched [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/81950 (owner: 10Matthias Mullie) [17:36:18] csteipp: poking, give me 5 [17:36:51] hey manybubbles [17:36:55] err [17:36:56] sorry [17:36:58] yo! [17:36:58] i meant marktraceur [17:37:01] nice [17:37:04] apologies manybubbles :( [17:37:06] Sigh [17:37:08] (03CR) 10Bsitu: "We decided to remove the shadow effect from the badge, this change should be abandoned" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81529 (owner: 10Krinkle) [17:37:11] np [17:37:17] YuviPanda: What can I do ya fer? [17:37:30] marktraceur: -alpha, i setup singlenode_mediawiki on it. [17:37:35] hi YuviPanda [17:37:37] Ahhherrr [17:37:39] hi Nikerabbit [17:37:43] YuviPanda: What that means? [17:37:56] (03CR) 10EBernhardson (WMF): [C: 031] "Looks good to me, it is a possible race condition. I'm not convinced this is causing the error we see in production though, because it has" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 (owner: 10Bsitu) [17:37:59] marktraceur: means it works now, and puppet can actually run, which was not the case before [17:38:04] Uhh, K [17:38:32] YuviPanda: What's the new URL? [17:39:00] marktraceur: You can take back the public IP from dragons [17:39:09] marktraceur: dragons is going through my proxy now [17:39:34] Oh, heh [17:40:26] (03PS3) 10Alex Monk: Comment text diff links in thread history should be protocol-relative [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/50714 [17:40:27] * YuviPanda names the proxy API thingy invisible-unicorn [17:40:30] YuviPanda: been busy? [17:40:32] (03CR) 10EBernhardson (WMF): [V: 032] Preventing empty payloads from being created when using summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81874 (owner: 10Kaldari) [17:40:43] (03CR) 10EBernhardson (WMF): [C: 032] Preventing empty payloads from being created when using summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81874 (owner: 10Kaldari) [17:40:51] Nikerabbit: something like that. sleep cylce messed up, plus a 'heated' bugzilla thread [17:40:52] * marktraceur waits for DNS to update [17:41:04] YuviPanda: So where should I fuck around with extensions? /srv/mediawiki? [17:41:10] yes [17:41:22] YuviPanda: aww :/ [17:41:44] KK [17:41:50] YuviPanda: just wondering whether you had chance to look at orsa's code or whether I should try my chances [17:42:10] Nikerabbit: i will timebox an hour but you should take a look at it too [17:42:30] YuviPanda: okay, I'll try to explode my calendar [17:43:28] * YuviPanda explodes Nikerabbit [17:46:07] YuviPanda: So if I wanted to add a puppet manifest, wat do? [17:46:19] marktraceur: from vagrant? [17:46:23] or from operatons/puppet.git [17:46:36] Vagrant, 'cause I'm pretty sure bd808 put it in there [17:47:57] marktraceur: betafeatures? [17:48:02] Yeah [17:48:15] marktraceur: ah, so you don't get vagrant in -alpha [17:48:20] marktraceur: because that reads puppet from ops/puppet [17:48:22] Oh. [17:48:33] marktraceur: *however*, vagrant is there in dragons [17:48:35] so you can use that :) [17:48:49] ... [17:48:53] You drive a hard bargain [17:48:55] that's why I made dragons, because I wanted vagrant [17:49:19] Also so you could say "Here there be dragons"? [17:49:29] Also, I cannot seem to get multimedia-alpha to work [17:49:29] original goal, yes [17:49:40] :D [17:49:43] Oh, it's only been ten minutes [17:49:46] * marktraceur waits moar [17:49:56] bd808: Mobile web used to have a 'dragons mode', which was our name for alpha [17:51:12] YuviPanda: In that case, I'll just manu-add it [17:51:20] boo [17:51:29] moar puppet [17:51:52] bd808: You want to get it working? [17:51:58] * bd808 hides [17:51:59] * marktraceur welcomes it [17:52:00] nope [17:52:29] I haven't poked into ops/puppet for adding extensions yet [17:53:08] * bd808 goes to look at repo [17:53:08] Shouldn't be too hard [17:53:14] * marktraceur laughs at self [17:53:32] bd808: marktraceur or I can add it to dragons [17:54:03] we should get it on dragons reguardless [17:54:11] yes yes [17:54:17] bd808: what was the role name? [17:54:36] YuviPanda: betafeatures [17:54:49] YuviPanda: Alternatively, how can we put the same software stuff on -alpha? [17:55:21] there's an interesting "feature" of vagrant's module integration. It does the initial clone of the repo but never does an update [17:55:52] hmm, bd808 [17:55:53] Could not find template 'thumb_on_404.conf.erb' at /vagrant/puppet/manifests/roles.pp:391 on node multimedia-dragons.pmtpa.wmflabs [17:55:57] * YuviPanda tries locally [17:58:36] YuviPanda: it's on disk at /vagrant/puppet/templates/thumb_on_404.conf.erb [17:58:46] maybe I messed up the selector for it? [17:58:50] hmm, indeed it is [17:58:52] and locally it runs fine [18:00:25] bd808: selector? [18:00:52] the `template('…')` declaration [18:01:04] * bd808 makes up words for stuff [18:01:39] hah [18:01:45] it looks like others in roles.pp manifest, but that doesn't mean it's right [18:01:51] I commented it [18:01:51] let's see what happens [18:02:20] marktraceur: bd808 okay, try out blue-dragon.wmflabs.org? [18:02:24] should have betafeatures enabled [18:02:54] bd808: commenting it out fixes things, but still [18:03:42] (03CR) 10Anomie: "All of the regular expressions here have the same issue. So far arwiki is the only one (as far as I know) that figured out how to complain" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [18:04:32] YuviPanda: /etc/apache2/site.d/devwiki doesn't have the thumb-php-on-404 config file now :( [18:04:47] because I commented it out? :P [18:05:17] yup. It must have worked previously right? [18:06:07] where do puppet logs end up on that box? /vagrant/logs/puppet is empty [18:06:56] YuviPanda: messed up by power problems? [18:08:55] bd808: not sure, try /var/log? [18:09:03] Nemo_bis: sleep? [18:09:28] YuviPanda: yes [18:09:57] Nemo_bis: ah, no. used to be the case. [18:09:58] not now [18:10:06] now it is just fuccked. [18:10:11] no reason [18:12:49] spagewmf: if this looks ok to you would you mind merging it? https://gerrit.wikimedia.org/r/#/c/80501/ [18:12:53] (03PS1) 10Himeshi: Modify the input to SFForm::create() in the Special:CreateClass page [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82437 [18:14:02] awjr I'm lookin [18:14:10] awesome thanks spagewmf :) [18:16:21] YuviPanda: how does one run `vagrant provision` or its equivalent on multimedia-dragons? [18:16:41] bd808: this is going to sound caveman-like, but cd /etc/puppet/manifests && puppet apply site.pp [18:17:37] heh. it could be worse [18:17:37] YuviPanda is that different/better than sudo puppetd -tv [18:17:49] spagewmf: sudo puppetd -tv doesn't work on dragons [18:18:22] spagewmf: so on dragons, I've killed all links to the labs puppetmaster. It runs off a local clone of vagrant-mediawiki [18:20:44] (03CR) 10Yaron Koren: [C: 032 V: 031] Modify the input to SFForm::create() in the Special:CreateClass page [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82437 (owner: 10Himeshi) [18:20:49] (03Merged) 10jenkins-bot: Modify the input to SFForm::create() in the Special:CreateClass page [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82437 (owner: 10Himeshi) [18:22:33] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/42880 (owner: 10Relwell) [18:25:34] YuviPanda: do you run as root or vagrant? [18:25:42] puppet? I ran as root [18:25:47] ok [18:29:07] hello mwalker [18:29:16] liangent: greetings [18:31:06] when I checked that centralnotice issue with another wikipedia user, he confused with two language related settings at first: language ( &uselang= ) and variant ( &variant= ) [18:31:32] normally variant controls language conversion within article body, but in centralnotice, it's uselang which matters [18:32:03] I'm not sure whether this happened to sugaplextw(?) too [18:32:27] Supaplextw. sorry [18:34:00] (03CR) 10Spage: [C: 032] "The comment's essential, otherwise in 2014 someone will wonder "Why isn't this using mw.user.isAnon()?" and you can't answer that from the" [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 (owner: 10Jdlrobson) [18:34:04] (03Merged) 10jenkins-bot: Enable Campaigns on mobile [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 (owner: 10Jdlrobson) [18:35:13] TBH having two switches, where each one controls some same (or similar) things at different places, is already confusing and something misleading [18:35:19] mwalker: ^ [18:35:49] liangent: yep yep -- I'm open to suggestions [18:36:03] I was not aware of a 'varient' options [18:36:16] I just thought it was all uselang magic [18:36:23] *in mediawiki core [18:39:11] mwalker: if you're interested - trying https://gerrit.wikimedia.org/r/72053 can give you a glance of another magic in core [18:40:46] (03PS1) 10Cmcmahon: class value for Cancel button changed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82440 [18:41:35] (03PS2) 10Cmcmahon: class value for Cancel button changed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82440 [18:43:53] liangent: I am laughing at this [18:43:54] but why! [18:44:01] we should also have lolspeak [18:44:19] :p [18:46:01] (03CR) 10Mglaser: [C: 04-1] "(1 comment)" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/63217 (owner: 10MarkAHershberger) [18:46:39] mwalker: it's implemtation is at https://gerrit.wikimedia.org/r/#/c/72053/13/languages/classes/LanguageEn.php [18:46:45] feel free to add more :p [18:47:40] (03PS1) 10Yaron Koren: New version: 1.3 [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/82441 [18:48:40] (03PS1) 10Kaldari: Fixing More... button so it doesn't always skip a notification Bug: 53718 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82442 [18:48:48] (03PS1) 10Spage: Explanatory comment for gerrit 80501 [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/82443 [18:49:28] (03PS1) 10CSteipp: Remove contrib directory and add gitignore to ignore it [extensions/SyntaxHighlight_GeSHi] (REL1_21) - 10https://gerrit.wikimedia.org/r/82444 [18:50:05] (03CR) 10CSteipp: [C: 032] "Already merged and running in production" [extensions/SyntaxHighlight_GeSHi] (REL1_21) - 10https://gerrit.wikimedia.org/r/82444 (owner: 10CSteipp) [18:50:09] (03PS4) 10MarkTraceur: Remove preference prefix string [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 (owner: 10Esanders) [18:50:11] (03Merged) 10jenkins-bot: Remove contrib directory and add gitignore to ignore it [extensions/SyntaxHighlight_GeSHi] (REL1_21) - 10https://gerrit.wikimedia.org/r/82444 (owner: 10CSteipp) [18:50:13] (03CR) 10Yaron Koren: [C: 032 V: 031] New version: 1.3 [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/82441 (owner: 10Yaron Koren) [18:50:14] YuviPanda: I got puppet to apply cleanly. It needed some help finding things. [18:50:20] (03Merged) 10jenkins-bot: New version: 1.3 [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/82441 (owner: 10Yaron Koren) [18:50:53] YuviPanda: `sudo /home/bd808/run-puppet.sh` [18:51:15] eating, will look in a sec [18:51:29] (03PS2) 10Kaldari: Fixing More... button so it doesn't always skip a notification Bug: 53718 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82442 [18:51:36] (03CR) 10Mglaser: "I support this change" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [18:51:45] sure. Food sounds like a good idea here on the other side of the globe too. [18:53:42] (03CR) 10Esanders: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 (owner: 10Esanders) [18:53:59] (03PS2) 10Wikinaut: Fix parsing from CLI; bumped to version 2.23 [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82366 (owner: 10PleaseStand) [18:55:02] (03CR) 10MarkTraceur: [C: 032] "Let's get this merged before the extension is deployed anywhere that would require a conversion script..." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 (owner: 10Esanders) [18:55:03] (03Merged) 10jenkins-bot: Remove preference prefix string [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 (owner: 10Esanders) [18:55:18] YuviPanda: Can has updated BetaFeatures on dragons? [18:55:27] (03CR) 10Mglaser: [C: 031] "You could test for is_object() instead, but afaik, this will work as well." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/63257 (owner: 10MarkAHershberger) [18:55:34] (03CR) 10Wikinaut: [C: 032 V: 032] "many thx for: sending bug report! committing a patch! and code review!" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82366 (owner: 10PleaseStand) [18:55:37] eating, gimme a moment [18:56:57] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #261: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/261/ [18:57:33] marktraceur: updating it to master now [18:57:58] marktraceur: done [18:58:47] (03Abandoned) 10Cmcmahon: class value for Cancel button changed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82440 (owner: 10Cmcmahon) [18:58:55] Sweet, thanks [18:59:15] Argh, registration turned off on -alpha [18:59:31] (I didn't touch alpha, only dragons) [19:00:22] hi marktraceur , I guess https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Debianize.2C_puppetize.2C_and_deploy_Etherpad_Lite can be removed now? [19:00:30] It can indeed qgil [19:00:33] ok [19:00:48] YuviPanda: Is it running from /srv/mediawiki/ or from /var/www/w/ now? [19:01:07] marktraceur: on dragons, go to /vagrant/mediawiki [19:01:12] for all your mediawiki needs [19:01:14] unsure about -alpha [19:02:36] Sigh, figured it out [19:02:54] marktraceur: are you in dragons or alpha? [19:03:14] Alpha [19:03:40] (03PD1) 10Wikinaut: RELEASE-NOTES version number fix [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82445 [19:03:56] (03CR) 10Wikinaut: [C: 032 V: 032] "trivial version number text patch" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/82445 (owner: 10Wikinaut) [19:13:04] (03CR) 10Mglaser: [C: 04-1] "(3 comments)" [extensions/Scribunto] (REL1_19) - 10https://gerrit.wikimedia.org/r/75142 (owner: 10MarkAHershberger) [19:14:29] (03CR) 10Umherirrender: "You mean the language change? I can only see a usage on preview and that does not go into parser cache and there it is confusing, when in " [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender) [19:18:08] (03CR) 10Mglaser: [C: 031] refactor a bit and add support for .tarignore [tools/release] - 10https://gerrit.wikimedia.org/r/28956 (owner: 10MarkAHershberger) [19:22:54] mwalker, please add nadsat, whilst you're at it ;) https://en.wikipedia.org/wiki/Nadsat - it looks like this contains the glossary txt required: http://www.planet-source-code.com/vb/scripts/ShowCode.asp?txtCodeId=8243&lngWid=3 [19:25:41] (03PS1) 10Kiran mathew koshy 1993: Bug 47406 Incremental update: zimdiff and zimpatch. [openzim] - 10https://gerrit.wikimedia.org/r/82449 [19:25:44] hey multichill [19:25:45] hey marktraceur [19:25:55] marktraceur: apparently UW broke on Commons, multichill tells me [19:26:49] there i am [19:26:52] YuviPanda: Not sure if it's one user or multiple, malenki reported it [19:26:54] hey malenki [19:27:02] For me it seems to work [19:27:05] marktraceur: http://malenki.ch/d/2013-09-03_212123_scr.png it apparently 'stops' there [19:27:14] malenki: can you add &debug=True to the URL [19:27:18] malenki: and try to upload again? [19:27:24] YuviPanda, sure [19:27:28] it might be a cache issue [19:27:40] oh fuck [19:27:44] Now it's broken for me too [19:27:51] Error: https://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=false&lang=en&modules=ext.uploadWizard&skin=vector&version=20130830T024003Z&* at line 0: Script error. [19:28:05] multichill: can you add debug=True [19:28:10] and tell me where the error is from? [19:28:33] YuviPanda: Easy to reproduce, go to https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-de-by . Clear you cache (CTRL-R in my case) [19:28:43] Try to upload a random file, release rights, boom [19:30:01] now it worked... [19:30:04] i'll try once more [19:30:06] boom indeed [19:30:18] <= using chromium [19:30:42] (03PS1) 10Cmcmahon: class value for Cancel changed, also restored missing steps [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 [19:30:53] malenki: did it work when you have debug=True? [19:30:58] YuviPanda, yes [19:31:19] before i had two fails at two times trying [19:31:34] * multichill can't reproduce it with debug=true [19:31:37] just using the assistent normally [19:31:44] right, let's just refresh cache [19:31:45] and it should work [19:31:53] * YuviPanda pokes Reedy [19:31:54] nice bug :) [19:32:01] can you touch the js files for UW again? [19:32:43] malenki: :) we've had this one before [19:33:05] (03CR) 10Cmcmahon: "somehow the steps that Amir created in https://gerrit.wikimedia.org/r/#/c/75328/ went missing, this commit restores those and also updates" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [19:33:08] marktraceur: no big deal, just the 'partially out of date cache' issue [19:33:15] Romaine, read above [19:33:34] YuviPanda, how come it shows up again? [19:33:34] marktraceur: we need to find someone who can do the cache flush thingy. [19:33:40] is it undead? :P [19:33:46] malenki? [19:33:51] malenki: new version of everything was deployed to commons a few minutes ago :P [19:34:01] Romaine, at upload assistent (not) working [19:34:01] so this happens when new deployments are made... but only sometimes [19:34:03] not all the times [19:34:11] YuviPanda, ok [19:34:21] * YuviPanda pokes Reedy some more [19:34:23] malenki: yes I was reading here [19:34:35] ok [19:34:36] I got this problem in several campaigns [19:34:41] just testing [19:34:55] usually i upload big heaps with commonist [19:35:08] if you add &debug=True at the end of the URL it'll still work [19:35:14] * YuviPanda pokes MaxSem [19:35:20] but for WLM i just select some special pics and contribute them by using the assistent [19:35:35] MaxSem: do you know how to touch js files to fix RL cache being out of date? [19:35:39] * Reedy touches YuviPanda [19:35:49] YuviPanda: So https://bits.wikimedia.org/commons.wikimedia.org/load.php?debug=true&lang=en&modules=ext.uploadWizard&skin=vector&version=20130830T024003Z is causing the problem ? :S [19:35:51] * YuviPanda reports Reedy for a FSP violation. [19:36:05] Reedy: can you do the refresh? [19:37:12] YuviPanda, I can (looks at deployments schedule) [19:37:26] YuviPanda, ehat do you need touched? [19:37:39] UW's cache seems to be partially outdated. [19:37:44] so all the js files under UW? [19:37:51] ah, Reedy just did that:) [19:37:56] ah! [19:38:04] ty Reedy [19:38:08] multichill: malenki can you try now? [19:38:51] YuviPanda, i am still uploading a file [19:39:06] * multichill sees the same problem [19:39:16] I'll do as soon as i have bandwith available again [19:39:18] do a refresh? ctrl+shift+r? [19:39:18] Yippie, build fixed! [19:39:18] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #218: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/218/ [19:45:15] multichill: wfm now? [19:48:39] marktraceur: looks like we didn't break UW! yay! [19:48:58] csteipp: http://pastebin.com/6nSY6zSR ... had trouble branching gerrit [19:49:20] if you can still use it, let me know if it does what you want. [19:52:05] hexmode: That is what I need... I hacked in my own version of it this morning, which I used for this release [19:52:31] But I'll check yours out in depth after this goes out. That looks a little nicer than mine :) [19:53:53] YuviPanda, seems fine again [19:53:59] woot! [19:54:05] yeah, touching them seems to have fixed it [19:54:44] I tested on several campaigns and problems seems solved [19:55:04] thank you Romaine [19:57:38] spagewmf: thanks for getting that changeset merged :D [19:58:00] btw: why does the assistent extract incredible useless long coordinates like 47.707047216644 11.400394433334 ? [19:58:34] csteipp: I'll add this to my current work. [19:58:35] if i recall correctly the normal user was asked to limit the numbers to a reasonable length [19:58:51] it picks up whatever was in the exif, IIRC [19:59:00] lol [19:59:13] then i can say: i use what i find in the data [19:59:27] malenki: accuracy? [20:00:19] legoktm, if i recall correctly 4 or 5 digits after the dot are sufficent for coordinates in WP [20:01:06] the normal users won't have high accuracy gps devices [20:01:13] they are quite expensive toys [20:01:41] and on the other hand it is not too necessary to know the coordinates to the millimeter [20:01:56] YuviPanda: Good! [20:02:00] (even if it they would be obtained by a highend device) [20:03:02] legoktm, http://en.wikipedia.org/wiki/Wikipedia:OPCOORD#Precision [20:03:45] the examples on that page have maximum 4 digits after the dot [20:03:58] oh interesting [20:14:45] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [20:17:04] (03PD1) 10CSteipp: (SECURITY) Fix user caching and login checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/82452 [20:18:17] (03PD2) 10CSteipp: Require token for CheckUser API module [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/82453 [20:18:30] (03CR) 10CSteipp: [C: 032] Require token for CheckUser API module [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/82453 (owner: 10CSteipp) [20:18:31] (03Merged) 10jenkins-bot: Require token for CheckUser API module [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/82453 (owner: 10CSteipp) [20:19:07] (03PD2) 10CSteipp: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82454 [20:19:18] (03CR) 10CSteipp: [C: 032] "Already deployed" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82454 (owner: 10CSteipp) [20:19:22] (03Merged) 10jenkins-bot: SECURITY: Escape thread subject on history page [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82454 (owner: 10CSteipp) [20:20:45] (03PS1) 10Manybubbles: Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 [20:22:49] (03PS2) 10Manybubbles: Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 [20:23:12] Project browsertests-en.wikipedia.org-linux-chrome build #292: FAILURE in 3 min 55 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/292/ [20:23:57] (03CR) 10Nikerabbit: "Ah, noticed now that this is in the qa repo. ULS tests were moved and were supposed to be purged from here." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [20:27:45] brion: any thoughts on the patch? [20:28:25] (03CR) 10Brion VIBBER: "I'm slightly paranoid about the users query... maybe we should program in a kill switch for those lookups that we can flip with a configur" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [20:28:31] YuviPanda: ^ [20:28:39] otherwise it looks fine, works for me :D [20:28:56] no obvious security issues that i see [20:29:04] brion: any unobvious ones? :P [20:29:04] ok [20:29:10] hehe not that i saw ;) [20:29:22] just the DoS if image categories are too big ;) [20:29:31] heh [20:29:38] I'll add a kill switch, yeah [20:29:55] brion: another thing I could do is perhaps make it something like 'for the last 30 days' [20:29:57] or something? [20:30:43] hmm, mebbe [20:30:50] brion: there are also two dependent commits to that one :) [20:33:12] (03PS1) 10Esanders: Replace image padding with CSS padding [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82458 [20:33:50] (03CR) 10Manybubbles: "(4 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [20:35:10] (03PS1) 10Anomie: Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 [20:35:26] (03CR) 10MarkTraceur: [C: 032] "Gotta love a new extension, review is waaaay easy." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82458 (owner: 10Esanders) [20:35:37] (03PS1) 10Anomie: Improve mw.text.nowiki [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/82462 [20:36:36] (03Merged) 10jenkins-bot: Replace image padding with CSS padding [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82458 (owner: 10Esanders) [20:36:53] ++edsanders [20:37:46] (03CR) 10jenkins-bot: [V: 04-1] Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 (owner: 10Anomie) [20:40:17] (03PS2) 10Anomie: Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 [20:40:23] GorillaWarfare: *waves* just checking in to see how you're getting along today [20:42:06] (03PS4) 10Manybubbles: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 [20:44:58] (03CR) 10Brion VIBBER: [C: 032] "I'd consider making a couple changes, but they're not required:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82091 (owner: 10Yuvipanda) [20:45:20] (03PS1) 10Bsitu: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 [20:47:19] (03PS2) 10Bsitu: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 [20:47:25] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/82443 (owner: 10Spage) [20:48:58] (03CR) 10Cmcmahon: "Niklas, this test (and others) was not moved to /UniversalLanguageSelector/tests/browser/ . I had thought it was, and apparently you did " [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82450 (owner: 10Cmcmahon) [20:53:01] (03CR) 10Brion VIBBER: [C: 032] Show anons a 'Create account to upload button' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [20:53:04] (03CR) 10Aaron Schulz: [C: 032] Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [20:53:22] (03CR) 10Brion VIBBER: [C: 032] "Let's do the kill switch as another patch..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [20:53:29] (03CR) 10jenkins-bot: [V: 04-1] Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [20:53:38] (03Merged) 10jenkins-bot: Style the 'view all uploads' link better [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82091 (owner: 10Yuvipanda) [20:53:39] (03Merged) 10jenkins-bot: Show anons a 'Create account to upload button' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82072 (owner: 10Yuvipanda) [20:53:40] (03Merged) 10jenkins-bot: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [20:55:08] YuviPanda|brb: enjoy [20:56:06] (03PS6) 10PleaseStand: Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 [20:57:18] (03PS2) 10Manybubbles: Significantly better heading tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82455 [20:58:14] (03CR) 10Aaron Schulz: [C: 032] Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [21:02:27] mwalker: Hey there [21:02:38] (03Merged) 10jenkins-bot: Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 (owner: 10PleaseStand) [21:02:45] mwalker: Haven't gotten much done today -- I'm still in the middle of moving apartments, so it's been hard to work [21:02:46] brion: wah! [21:02:48] thanks :D [21:02:56] (03CR) 10Bsitu: [C: 032] Fixing More... button so it doesn't always skip a notification Bug: 53718 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82442 (owner: 10Kaldari) [21:05:15] (03CR) 10Liangent: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82460 (owner: 10Anomie) [21:06:25] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82460 (owner: 10Anomie) [21:07:48] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [21:08:32] (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [21:09:15] (03PS1) 10Kontokostas: add a sample wikitext with all possible link cases [extensions/LightweightRDFa] - 10https://gerrit.wikimedia.org/r/82522 [21:11:33] csteipp: Have the security patches for the various API tokens not been pushed to git yet? https://github.com/wikimedia/mediawiki-core/tree/master/includes/api doesn't show anything [21:12:34] legoktm: Havn't pushed to master yet. Fighting gerrit on it right now [21:12:52] ok, thanks [21:13:08] (03PS1) 10Mwjames: \SMW\DataStore (encapsulate ParserOutput data access) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82523 [21:16:57] (03PS1) 10Yaron Koren: Un-commented $wgParser->clearState() call - necessary in some circumstances. [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82524 [21:18:57] GorillaWarfare: yay apt moving! [21:19:00] (03CR) 10Yaron Koren: [C: 032 V: 031] Un-commented $wgParser->clearState() call - necessary in some circumstances. [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82524 (owner: 10Yaron Koren) [21:19:06] hope you're going somewhere nice [21:19:21] (03CR) 10Bsitu: "When a user getter method like getUserGroups() is accessed with an invalid user_id, it would reset the user_id back to 0. In this case, t" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 (owner: 10Bsitu) [21:21:07] (03Merged) 10jenkins-bot: Fixing More... button so it doesn't always skip a notification Bug: 53718 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82442 (owner: 10Kaldari) [21:21:46] (03CR) 10Manybubbles: "Is it worth merging this and opening another bug about it being too slow for enwiki sized wikis?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles) [21:22:00] mwalker: Not yay :P And it's about the same quality-wise -- I only had a sublet for four months, otherwise I'd have stayed [21:22:26] (03PS1) 10EBernhardson (WMF): Remove relative timestamps in favor of cldr [extensions/Flow] - 10https://gerrit.wikimedia.org/r/82525 [21:23:12] (03CR) 10Yaron Koren: [V: 032] Un-commented $wgParser->clearState() call - necessary in some circumstances. [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/82524 (owner: 10Yaron Koren) [21:23:40] :'( [21:31:02] (03CR) 10MarkTraceur: [C: 031] "I will +2 on Friday if nobody objects, it looks fine to me but I'm not super well-versed in logging or SpamBlacklist." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/69303 (owner: 10Legoktm) [21:31:14] marktraceur: thanks! [21:31:44] legoktm: Thank Ironholds, he's pushing to get it in [21:32:17] just did [21:32:21] YuviPanda: D'you want to take a look at that too? [21:32:38] the code looks okay, but i've to test it. [21:33:00] i'm doing a few followups to the UW stuff that got merged, let me see if I can sneak a look after [21:33:08] KK [21:33:25] YuviPanda: Testing is surprisingly easy with that extension (once I figured out how to run git, of course) [21:33:48] (it turns out cp -R on a git repository means that any git commands update the old directory. HILARIOUS.) [21:34:25] YuviPanda: got anything more to review on those? i've gotta run but will be back online in a hour or so [21:34:44] brion: will have a couple patches before an hour, yes [21:34:47] ok spiffy [21:35:29] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82464 (owner: 10Bsitu) [21:36:39] (03PS3) 10Anomie: Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 [21:37:14] (03PS2) 10Anomie: Improve mw.text.nowiki [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/82462 [21:37:55] anomie|away: multitasking? :) [21:38:11] Aaron|home: yes [21:39:12] (03PD2) 10CSteipp: SECURITY: Prevent FPD on exceptions in load.php [core] - 10https://gerrit.wikimedia.org/r/82526 [21:39:26] (03CR) 10CSteipp: [C: 032] "Already deployed" [core] - 10https://gerrit.wikimedia.org/r/82526 (owner: 10CSteipp) [21:39:39] Aaron|home: who are the ops that review your jobrunner changes in operations/puppet ? :) [21:40:08] Aaron|home: I got a patch pending to tweak the job loop shell script for beta so it runs less threads https://gerrit.wikimedia.org/r/#/c/77034/ but not sure whom to ping [21:41:06] (03PD2) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] - 10https://gerrit.wikimedia.org/r/82527 [21:41:12] hashar: he left for Burning Man, never to return here [21:42:33] Aaron|home: what is burning man ? [21:42:54] ah a festival http://en.wikipedia.org/wiki/Burning_Man :D [21:43:21] (03PS1) 10Legoktm: Update README to note that the current version will only work with 1.22 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/82530 [21:44:06] hashar: it can't be described to someone who has never gone [21:44:10] ...so they say [21:44:25] "latest release version of MediaWiki (1.9.x as of this writing)" <-- someone didn't update it in a while :P [21:45:40] (03Merged) 10jenkins-bot: SECURITY: Prevent FPD on exceptions in load.php [core] - 10https://gerrit.wikimedia.org/r/82526 (owner: 10CSteipp) [21:47:13] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Prevent tokens in jsonp mode [core] - 10https://gerrit.wikimedia.org/r/82527 (owner: 10CSteipp) [21:52:50] (03CR) 10Kontokostas: [C: 032 V: 032] add a sample wikitext with all possible link cases [extensions/LightweightRDFa] - 10https://gerrit.wikimedia.org/r/82522 (owner: 10Kontokostas) [21:53:11] anomie|away: pong ? [21:53:19] (03PS5) 10EBernhardson (WMF): Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 [21:53:59] hashar: RST (Did I ping you? If so, I timed out) [21:54:37] anomie|away: were you the one talking about PHP version and PCRE ? [21:54:45] for scribunto [21:55:29] anomie|away: PCRE 8.10 is shipped with PHP 5.3.4 [21:55:53] and I think Aaron|home said MediaWiki core already requires PCRE 8.10 [21:56:07] so we might have to raise our PHP version requirement from 5.3.2 to 5.3.4 :-] [21:56:18] though probably nobody is still using it [21:57:08] hashar: I was saying it needs 7.2 now, the actually the patch I was thinking of wasn't merged [21:57:27] so atm, you could get away with less than that in theory [21:57:27] so PCRE 7.2 should be fine :-) [21:57:38] *though actually [21:57:41] anomie|away: on debian they got PHP 5.3.3 in old stable (Squeeze) [21:57:54] the new stable being wheezy with PHP 5.4.4 , no idea which pcre version they ship [21:58:11] hashar: you can CR that btw [21:58:16] hashar: wheezy has 8.31, IIRC from when I looked it up earlier [21:59:00] so that should be fine :) [21:59:05] hashar: Anyway, I'll just update [[mw:Extension:Scribunto]] to note the higher requirement. [21:59:15] (later) [21:59:19] :-] [22:01:17] anyway sleep :) [22:03:04] (03PS3) 10Mattflaschen: Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 [22:03:09] (03CR) 10jenkins-bot: [V: 04-1] Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 (owner: 10Mattflaschen) [22:03:16] (03CR) 10Mattflaschen: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 (owner: 10Mattflaschen) [22:05:06] (03PS3) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] - 10https://gerrit.wikimedia.org/r/82527 [22:06:35] (03PS4) 10Mattflaschen: Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 [22:07:07] (03CR) 10CSteipp: [C: 032] SECURITY: Prevent tokens in jsonp mode [core] - 10https://gerrit.wikimedia.org/r/82527 (owner: 10CSteipp) [22:10:53] (03PD2) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] - 10https://gerrit.wikimedia.org/r/82528 [22:11:07] (03Merged) 10jenkins-bot: SECURITY: Prevent tokens in jsonp mode [core] - 10https://gerrit.wikimedia.org/r/82527 (owner: 10CSteipp) [22:12:09] (03CR) 10CSteipp: [C: 032] "Already deployed" [core] - 10https://gerrit.wikimedia.org/r/82528 (owner: 10CSteipp) [22:18:21] (03Merged) 10jenkins-bot: SECURITY: Fix extension detection with 2 .'s [core] - 10https://gerrit.wikimedia.org/r/82528 (owner: 10CSteipp) [22:27:05] Yippie, build fixed! [22:27:05] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #425: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/425/ [22:34:42] (03PS1) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82536 [22:34:46] (03PS1) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82537 [22:34:52] (03PS1) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82538 [22:34:56] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.19.8 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82539 [22:37:08] (03PS9) 10Mattflaschen: Add tour to be used for first edit (other than GettingStarted). [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [22:37:10] (03PS3) 10Bsitu: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 [22:38:20] (03PS4) 10Bsitu: Add a deferrable update class for callback/closure udpates [core] - 10https://gerrit.wikimedia.org/r/82464 [22:39:19] (03PS1) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82540 [22:39:23] (03PS1) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 [22:39:27] (03PS1) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82542 [22:39:31] (03PS1) 10CSteipp: Update release notes and version [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82543 [22:42:41] (03PS1) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82544 [22:42:45] (03PS1) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 [22:42:49] (03PS1) 10CSteipp: SECURITY: Fix extension detection with 2 .'s [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82546 [22:42:53] (03PS1) 10CSteipp: Updated release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82547 [22:44:32] (03PS2) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82538 [22:45:43] (03CR) 10Swalling: "(2 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/64981 (owner: 10SuchABot) [22:48:00] (03CR) 10CSteipp: [C: 032] SECURITY: Fix extension detection with 2 .'s [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82536 (owner: 10CSteipp) [22:50:51] (03PS2) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82544 [22:51:10] (03PS2) 10CSteipp: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82540 [22:52:40] (03CR) 10CSteipp: [C: 032] SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82540 (owner: 10CSteipp) [22:53:40] (03CR) 10CSteipp: [C: 032] SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82544 (owner: 10CSteipp) [22:54:55] (03CR) 10CSteipp: [C: 032] SECURITY: Prevent tokens in jsonp mode [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82537 (owner: 10CSteipp) [22:58:13] (03CR) 10CSteipp: [C: 032] SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82538 (owner: 10CSteipp) [22:58:54] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Prevent tokens in jsonp mode [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82545 (owner: 10CSteipp) [23:01:33] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Fix extension detection with 2 .'s [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82546 (owner: 10CSteipp) [23:01:44] (03PS2) 10Legoktm: Update README to note that the current version will work up to 1.21 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/82530 [23:02:20] (03PS1) 10MarkTraceur: Fix the convenience function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82549 [23:02:33] bd808: Pretty much trivial patch ^^ [23:04:38] (03CR) 10jenkins-bot: [V: 04-1] Updated release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82547 (owner: 10CSteipp) [23:05:59] marktraceur: any way to test that at this point? [23:06:16] maybe a unit test (hint, hint)? [23:07:37] :) [23:07:49] Not currently, but I can make that my next step if you'd like [23:08:15] is that a 10 minute task or a bigger deal? [23:08:59] Hm [23:09:02] Probably not very big [23:09:33] High side is maybe 1-2 hours, but probably also includes adding it to Jenkins and Zuul and deploying those changes [23:10:13] I'll +2 if you swear to put that on your never ending stack of crap to do later :) [23:10:17] Heh [23:10:20] Sure sure [23:10:33] Even put it on a card and stuff [23:11:13] fancy. give it 5 story points for cross system overhead and communication :) [23:12:31] *shrug* [23:12:43] I can do it all unilaterally, pretty much [23:12:51] Except for unit test code review [23:16:26] (03Merged) 10jenkins-bot: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82540 (owner: 10CSteipp) [23:16:29] (03CR) 10BryanDavis: [C: 032] "Works for me. Change is in code path that is basically unused at this point. Will be important when another Extension starts relying on Be" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82549 (owner: 10MarkTraceur) [23:17:57] (03Merged) 10jenkins-bot: Fix the convenience function [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/82549 (owner: 10MarkTraceur) [23:18:18] Wuh oh [23:18:24] Yuvi|NoPower: Again? [23:18:31] yeah [23:18:38] grrr [23:20:09] (03Merged) 10jenkins-bot: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/82544 (owner: 10CSteipp) [23:22:34] :( no power is sad [23:23:18] (03Merged) 10jenkins-bot: SECURITY: Sanitize ResourceLoader exception messages [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82538 (owner: 10CSteipp) [23:24:21] Yuvi|NoPower: got stuff for me to review? [23:24:36] brion: pushing in a minute or so. [23:24:43] ok [23:24:46] brion: i switched to emacs over the weekend, so a drop in productivity [23:24:51] hehe [23:25:03] you haven't rewritten mediawiki in elisp yet? [23:26:47] Pleasegodno [23:26:59] Rewrite in Haskell if you want, but please not elisp [23:27:02] lua templates? psssssh we can do macros now [23:27:27] "templates" sort of cheapens it [23:28:33] grrr, internet flaky [23:28:53] woo, got audio to route over HDMI on my home office KVM switch [23:29:27] one less cable to deal with [23:29:28] <^d> brion: Is your home setup 100% hdmi yet? [23:29:55] ^d: yes but mainly because i haven't hooked the Wii back up to the TV :) [23:30:12] though i think the Wii U has HDMI out….. [23:30:24] <^d> Wii U is still a Wii ;-) [23:30:38] other than wii tennis, it's kinda lame platform [23:30:44] and even that gets old fast [23:31:06] <^d> Video game tennis only has so much replay value. [23:31:17] (03PS1) 10Yuvipanda: Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 [23:31:21] brion: ^ [23:31:25] whee [23:31:27] oh dear god, emacs! [23:31:35] it seems to have shitty spacing rules [23:32:13] uh-oh [23:32:18] (03CR) 10Reedy: [C: 04-1] Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 (owner: 10Yuvipanda) [23:32:22] -1 all the commits! [23:32:39] (03PS2) 10Yuvipanda: Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 [23:32:52] brion: Reedy PS2 shouldn't mix tabs and spaces [23:33:03] hmm phpcs still failing tho [23:33:14] phpcs has been failing for a long, long time [23:34:02] brion: building HTML that way needs to die. [23:34:03] ^d: the worst thing is, when i upgrade to ultra-hd i'll need a new switcher… either hdmi 2 or display port or something :P [23:34:13] just.... eugh. [23:34:19] though i can migrate the old HDMI KVM to the TV for old game consoles :) [23:34:41] (03PS3) 10Yuvipanda: Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 [23:34:43] brion: updated patchset to default to true now [23:34:50] ah good :D [23:36:04] (03PS1) 10Yuvipanda: Clarify wording on anon CTA [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82552 [23:36:20] now adding qqq [23:37:13] (03CR) 10Brion VIBBER: [C: 032] Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 (owner: 10Yuvipanda) [23:37:17] (03Merged) 10jenkins-bot: Add a 'kill switch' to kill all expensive stats computation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82550 (owner: 10Yuvipanda) [23:38:47] hmm, writing proper qqq is hard [23:41:52] (03PS1) 10Yuvipanda: Add qqq for new campaign related messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82553 [23:41:57] brion: ^ [23:42:01] (+ dependent commit) [23:42:07] whee [23:42:48] (03CR) 10Aaron Schulz: [C: 032] Improve mw.text.nowiki [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/82462 (owner: 10Anomie) [23:42:52] (03CR) 10Aaron Schulz: [C: 032] Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 (owner: 10Anomie) [23:42:58] (03CR) 10Brion VIBBER: [C: 032] Add qqq for new campaign related messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82553 (owner: 10Yuvipanda) [23:43:10] (03CR) 10Brion VIBBER: [C: 032] Clarify wording on anon CTA [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82552 (owner: 10Yuvipanda) [23:43:36] (03Merged) 10jenkins-bot: Add qqq for new campaign related messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82553 (owner: 10Yuvipanda) [23:43:37] (03Merged) 10jenkins-bot: Clarify wording on anon CTA [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/82552 (owner: 10Yuvipanda) [23:43:46] brion: I'm going to polish up the masscamps tool and make sure it is in wonderful shape by tomorrow. [23:43:50] brion: anything else I should be doing? [23:43:55] (03Merged) 10jenkins-bot: Improve mw.text.nowiki [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/82462 (owner: 10Anomie) [23:46:40] (03Merged) 10jenkins-bot: Improve wfEscapeWikiText [core] - 10https://gerrit.wikimedia.org/r/82460 (owner: 10Anomie) [23:46:46] (03PS2) 10CSteipp: Update Releasenotes and version number for 1.19.8 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82539 [23:47:03] (03CR) 10CSteipp: [C: 032] Update Releasenotes and version number for 1.19.8 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82539 (owner: 10CSteipp) [23:47:31] (03PS2) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 [23:47:56] (03CR) 10CSteipp: [C: 032] SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541 (owner: 10CSteipp) [23:48:53] (03PS1) 10Kaldari: Updating eventlogging scheme revisions number for mobile param [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82554 [23:51:56] (03PS2) 10MarkTraceur: Initial commit - working demo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/78341 [23:52:50] (03Merged) 10jenkins-bot: Update Releasenotes and version number for 1.19.8 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/82539 (owner: 10CSteipp) [23:53:11] (03PS3) 10MarkTraceur: Initial commit - working demo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/78341 [23:53:28] Yuvi|NoPower: sounds good [23:53:33] sweeet! :) [23:53:38] (03PS2) 10Kaldari: Updating eventlogging scheme revisions number for mobile param [extensions/Echo] - 10https://gerrit.wikimedia.org/r/82554 [23:54:06] (03PS1) 10MarkTraceur: Add multilightbox library import/export script [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/82555 [23:55:21] (03PS3) 10CSteipp: SECURITY: Prevent tokens in jsonp mode [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/82541