[00:22:27] (03PS1) 10Alex Monk: Only show search form if LuceneSearch is detected [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82111 [00:28:50] (03PS2) 10Alex Monk: Only show search form if LuceneSearch is detected [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82111 [02:11:52] James_F, yeah I'll take a look into that LQT bug you CC'd me on, but it might have to wait until Tuesday [02:12:03] Krenair: Sure. [03:16:37] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #145: FAILURE in 4 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/145/ [04:59:30] anyone here who can help with a CentralNotice issue? some languages aren't shown while they are created just as other languages [05:22:47] Romaine: Bug filed? [05:23:07] https://bugzilla.wikimedia.org/show_bug.cgi?id=53641 [05:45:09] marktraceur: any idea what the cause is? [05:54:07] I don't, but if you've filed a bug it'll get looked at [05:59:49] Yippie, build fixed! [05:59:50] Project browsertests-test2.wikipedia.org-linux-chrome build #564: FIXED in 35 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/564/ [06:06:29] (03PS14) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [07:46:37] (03CR) 10Nikerabbit: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [08:12:05] (03CR) 10Matmarex: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [09:18:44] (03CR) 10Matmarex: [C: 032] Cleaning up unused variables in the global space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/76253 (owner: 10Legoktm) [09:18:46] (03Merged) 10jenkins-bot: Cleaning up unused variables in the global space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/76253 (owner: 10Legoktm) [09:21:18] (03CR) 10Matmarex: [C: 04-1] "MaxSem, explain yourself. :D" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/38902 (owner: 10Legoktm) [09:23:37] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [09:25:18] (03CR) 10Matmarex: [C: 032] Remove call to deprecated MWInit::methodExists with method_exists [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/76310 (owner: 10Legoktm) [09:25:20] (03Merged) 10jenkins-bot: Remove call to deprecated MWInit::methodExists with method_exists [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/76310 (owner: 10Legoktm) [09:31:27] (03CR) 10Nikerabbit: [C: 032] Fix be-tarask prepositional case [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/81903 (owner: 10Wizardist) [09:31:33] (03Merged) 10jenkins-bot: Fix be-tarask prepositional case [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/81903 (owner: 10Wizardist) [09:40:01] (03PS6) 10Nikerabbit: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [09:40:57] (03CR) 10Nikerabbit: [C: 032] "Can someone file a bug for the splitting?" [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [09:43:33] (03CR) 10Nikerabbit: [C: 032] Replace germanism "sighted" in review levels with an equivalent [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/78647 (owner: 10Nemo bis) [09:44:48] (03Merged) 10jenkins-bot: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [09:45:25] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis) [09:47:30] (03PS3) 10Nikerabbit: Add email recipient username as a parameter to emailuser confirmation [core] - 10https://gerrit.wikimedia.org/r/78404 (owner: 10Nemo bis) [09:47:38] (03CR) 10Nikerabbit: [C: 032] Add email recipient username as a parameter to emailuser confirmation [core] - 10https://gerrit.wikimedia.org/r/78404 (owner: 10Nemo bis) [09:48:17] (03PS3) 10Nikerabbit: Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [09:48:24] (03CR) 10Nikerabbit: [C: 032] Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [09:49:52] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 (owner: 10Nemo bis) [09:51:23] (03CR) 10Nikerabbit: [C: 04-1] "(5 comments)" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/78646 (owner: 10Nemo bis) [09:52:56] (03Merged) 10jenkins-bot: Add email recipient username as a parameter to emailuser confirmation [core] - 10https://gerrit.wikimedia.org/r/78404 (owner: 10Nemo bis) [09:55:53] (03Merged) 10jenkins-bot: Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [10:26:22] (03PS1) 10MaxSem: optipng -o7 "$png" && advpng -z -4 "$png" && advdef -z -4 "$png" [core] - 10https://gerrit.wikimedia.org/r/82116 [10:29:07] (03CR) 10Daniel Friesen: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [10:53:35] (03CR) 10Seb35: [C: 031] "Checked transitions between current and future situations; all looks fine." [core] - 10https://gerrit.wikimedia.org/r/82065 (owner: 10CSteipp) [11:10:32] (03PS1) 10Martineznovo: drop unused fields rc_moved_to_ns/rc_moved_to_title [core] - 10https://gerrit.wikimedia.org/r/82117 [12:32:16] thedj: Are you around now/ today? [12:40:30] (03CR) 10Hoo man: [C: 031] "Graham87 tested this patch and is fine with it." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [12:41:00] MatmaRex: did you yet have a look at that Cite extension patch ^? [12:47:05] hoo: not really, and i'm disappearing now, sorry [12:47:11] i'll try to look at it later [12:47:16] see ya [12:58:12] (03CR) 10Hoo man: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [12:58:38] (03PS6) 10Hoo man: Add aria properties to TOC for accessibility [core] - 10https://gerrit.wikimedia.org/r/79053 [12:59:05] (03CR) 10Hoo man: "Fixed initial value of aria-expanded" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [13:30:37] (03CR) 10Hoo man: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/63387 (owner: 10Luis Felipe Schenone) [14:18:04] (03CR) 10Nemo bis: "Done at https://bugzilla.wikimedia.org/show_bug.cgi?id=53655" [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [14:23:51] (03CR) 10Matmarex: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [14:30:01] nileshc: apparently https://gerrit.wikimedia.org/r/#/c/78647/ needs submit [15:07:38] (03CR) 10Matmarex: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [15:21:44] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Matmarex) [15:24:45] (03PS4) 10Nemo bis: Add PLURAL support to push-tab-*-override [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 [15:34:48] hoo: 'round? i'm looking at the Cite patch [15:35:22] hoo: wouldn't it be better to use 'cite_references_link_many_accessibility_label' => 'Jump up to:', without the $1, and just prepend it? [15:35:22] Sure [15:35:50] It surely would be nicer, but I'm not sure about translation [15:36:10] hoo: (i know this kind of puzzling pieces of sentences together is usually frowned upon, but it seems like a much saner solution here) [15:36:30] hoo: i'll certainly be more obvious to translate than the current version [15:36:33] it'll* [15:36:58] hoo: where in practice you still can't put anything after $1, or it'll end up rather weird [15:37:11] (03PS2) 10Nemo bis: Rephrase the "help protect the wiki" CAPTCHA requests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/78646 [15:37:14] mh [15:37:33] because a) this will still be inside the link, so putting there e.g. equivalent of "and" would acts funny [15:37:38] I'm not into the various langs enough for this, but in German the most natural wording eg. would be "Zu $1 springen" [15:37:44] and b) you can't put commas or anything between the other links [15:37:49] (03CR) 10Nemo bis: "Done. Sorry, configuration on my laptop is still mostly the idiotic defaults." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/78646 (owner: 10Nemo bis) [15:38:11] hoo: but what about "Zu a springen b c d e"? is that sane? D: [15:38:24] MatmaRex: That's how it is now [15:38:34] (despite that the translation to de is missing) [15:38:55] yeah [15:38:58] (03PS5) 10Nemo bis: Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 [15:39:00] my very limited knowledge of german tells me that "Springen zu: a b c d e" would be grammatically okay as well, right? [15:39:10] Sure, for German that's totally right [15:39:51] of course i can't check every language there is, but i think that'd be translateable to other languages as well [15:39:59] we have similar formations e.g. for labels of form fields [15:40:20] (where you can't put anything after the field, only before, and they usually end with colons) [15:40:50] Nikerabbit: 'round? [15:42:18] MatmaRex: I'm ok with that either... I just fear that I change it, and then things get stuck in gerrit again until someone sometime tells me that taht's the wrong way [15:42:33] and I really want that change to make it sometime soon [15:43:37] Raymond_: around? [15:44:06] MatmaRex: was [15:44:44] Nikerabbit: We need some i18n advice, the case is a bit difficult, so I'll try to summarize it [15:45:28] You do know the "^" links for citations (from the Cite extension), these aren't accessible for screen reader users [15:45:54] (sorry, i have to leave again now for an hour or so :( ) [15:45:59] * MatmaRex afks [15:46:01] because of that we decided to add an accessibility label to it, but that's a bit awry with citations used in multiple places [15:46:11] MatmaRex: Ok, I'll try to get this sorted... [15:46:59] (like #9 here: https://en.wikipedia.org/wiki/Cyrillic_script#References ) [15:47:25] Nikerabbit: Could you follow so far? [15:47:51] yees [15:48:54] Fine, now the question is: Should we make the screen readers read those like "Jump up to a b c ..." or rather "Jump up to: a b c" (where the position of the letter isn't variable) [15:49:26] The second one is by far easier to implement and produces way nicer html, but we're not sure it's translatable in a nice way [15:52:04] hoo: we already have an example of the latter as the 'jumpto' message [15:52:59] Ok and you're not discouraging me to create a new one? ;) [15:57:59] Nikerabbit: ^ [16:01:27] hoo: I think it's workable solution [16:01:55] ok, I'm then going to again change my patch... thanks for your help ;) [16:12:45] Nikerabbit: How should I qqq that? [16:30:18] (03PS22) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 [16:30:32] MatmaRex: ^ [16:33:15] (03CR) 10Hoo man: "No longer allow $1 in the accessibility label which makes the html we produce a lot nicer." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [16:35:22] hoo: like you did to me [16:36:45] Text for screen readers to describe the jump to citation links (a b c ...) for citations which are used in multiple places. This is going to be prepended to the first link, the following ones will just be read by screen readers as they are visible. [16:36:49] Nikerabbit: ^ mh? [16:37:04] (03CR) 10Parent5446: [C: 032] Also redirect if prefixed https cookie is preset [core] - 10https://gerrit.wikimedia.org/r/82065 (owner: 10CSteipp) [16:37:15] hoo: sounds good [16:37:26] :) [16:37:33] * MatmaRex is back [16:37:36] reading scrollback [16:37:52] MatmaRex: tl;dr for you: We chose your version [16:38:35] hoo: i'm looking at the updated patch [16:38:40] :) [16:39:50] hoo: mind if i fix some whitespace issues or do you want me to point them out? :) [16:40:18] MatmaRex: Both is fine for me... ;) [16:41:09] (03Merged) 10jenkins-bot: Also redirect if prefixed https cookie is preset [core] - 10https://gerrit.wikimedia.org/r/82065 (owner: 10CSteipp) [16:41:46] hoo: okay, i'll change it myself then, it'll be easier for us both [16:42:10] i'll undo the traisling space changes in i18n as well, 'kay? [16:42:15] i'll also undo* [16:42:48] MatmaRex: Sure, go ahead... these were done by accident (I often let my IDE cut of trailing spaces...) [16:44:39] (03CR) 10Nikerabbit: [V: 032] Replace germanism "sighted" in review levels with an equivalent [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/78647 (owner: 10Nemo bis) [16:48:00] (03CR) 10Nikerabbit: [C: 032 V: 032] Add PLURAL support to push-tab-*-override [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 (owner: 10Nemo bis) [16:48:38] thedj: Around? [16:49:04] (03CR) 10Nikerabbit: [C: 032] Rephrase the "help protect the wiki" CAPTCHA requests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/78646 (owner: 10Nemo bis) [16:49:07] (03Merged) 10jenkins-bot: Rephrase the "help protect the wiki" CAPTCHA requests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/78646 (owner: 10Nemo bis) [16:50:14] (03PS23) 10Matmarex: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [16:51:35] (03CR) 10Matmarex: [C: 031] "Fixed minor syntax thingies (mostly whitespace), a few typos and an HTML escaping issue in JS. Should be functionally equivalent." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [16:51:41] hoo: double-check for me? ^ [16:51:55] i inly noticed the escaping thing after i dove into the code :) [16:52:25] we use .text() so that shouldn't cause harm [16:52:50] yeah, but you also use .escaped() :) [16:52:54] used* [16:53:05] (the issue was double-escaping) [16:53:15] (potential double-escaping, even) [16:54:13] also, funny thing, we no longer need the $ in closure. i wonder if it should be removed :P [16:56:23] hoo: hmph, it seems like i accidentally reset authorship date on the commit. let me fix it [16:56:39] ok [16:57:38] god damn stupid gerrit, it won't accept the push [16:57:54] MatmaRex: Change something in the commit message [16:58:06] that's letting the machines win [16:58:24] (03CR) 10Nikerabbit: [C: 032] Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis) [16:58:30] (03Merged) 10jenkins-bot: Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis) [16:59:01] (03PS24) 10Matmarex: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [16:59:01] but i gave in. you win this battle, gerrit. [17:00:17] :D [17:00:28] MatmaRex: Ok, PS23 works like charm in both IE and Firefox [17:02:17] hoo: i filed a bug. :D https://bugzilla.wikimedia.org/show_bug.cgi?id=53662 [17:02:43] hoo: yay [17:02:44] :D [17:03:18] also in Chromium [17:06:33] hoo: it looks good to me, i could merge if you want to get this over with [17:06:40] (03CR) 10Hoo man: [C: 031] "Amended version still works like a charm in all major Browsers (tested with Jaws and NVDA)." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [17:06:52] Yes, that would be great :) [17:06:54] (although i poked latest patchsets, so maybe someone else could) [17:07:01] 'twas only minor changes, though [17:08:25] Those were mostly style changes and I've reviewed them [17:08:35] alright, let's do it then [17:09:05] i think thedj was okay with it too? [17:10:05] AFAIK yes [17:10:28] Graham tested the old version and was fine with it either [17:12:06] mkay… [17:12:19] (03CR) 10Matmarex: [C: 032] "LET'S DO THIS" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [17:12:27] (03Merged) 10jenkins-bot: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [17:13:00] \o/ :) [17:14:51] MatmaRex: If you got the extension running now anyway, you might also want to shoot https://gerrit.wikimedia.org/r/81548 which should be trivial :P [17:17:24] hoo: hm, does anybody actually use that functionality? [17:19:16] MatmaRex: Not that I know of, enwiki has a gadget for a similar purpose, but that's a totally different implementation [17:19:43] Nemo_bis, Nikerabbit: Thanks [17:20:55] hoo: hm, why is part of that double-indented? [17:21:01] after $content.find( '.biblio-cite-link,sup.reference a' ).tooltip( { [17:21:14] good question, lemme fix [17:22:13] (03PS4) 10Hoo man: Use mw.hook( 'wikipage.content' ) for citation popup JS [extensions/Cite] - 10https://gerrit.wikimedia.org/r/81548 [17:23:08] (03CR) 10Hoo man: "Fixed indentation" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/81548 (owner: 10Hoo man) [17:23:40] MatmaRex: That patch fell of then I hacked on the extension, I don't really care to much for it, but I wanted the JS to be in a consistent state in the ext. [17:26:48] (03CR) 10Matmarex: [C: 032] Use mw.hook( 'wikipage.content' ) for citation popup JS [extensions/Cite] - 10https://gerrit.wikimedia.org/r/81548 (owner: 10Hoo man) [17:26:56] (03Merged) 10jenkins-bot: Use mw.hook( 'wikipage.content' ) for citation popup JS [extensions/Cite] - 10https://gerrit.wikimedia.org/r/81548 (owner: 10Hoo man) [17:27:11] hoo: btw, i'm writing an {{editprotected}} request on en.wp to kill those stupid carets [17:28:04] Oh, I doubt I can fulfill that myself, but I like the idea [17:34:10] hoo: https://en.wikipedia.org/wiki/Help_talk:Cite_messages#An_arrow_.E2.86.91_or_a_caret_.5E.3F if you want to look [17:34:56] thanks, MatmaRex :) [17:37:22] MatmaRex: Added my support (I'm not bold enough to touch these on my own, though... visible changes tend to get people upset... ) [17:37:33] (03PS15) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [17:40:46] hoo: thanks [17:41:03] (03PS6) 10Rjain: Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 [17:41:59] * hoo strangles MSIE [17:43:56] * YuviPanda|awake slowly pokes brion [17:54:24] heh hoo [17:55:45] hoo: i assume that means you're busy? :) [17:56:23] hoo: (because i've got a change https://gerrit.wikimedia.org/r/#/c/82100/ vaguely related to accessibility and strongly rleated to our HTML and CSS not sucking) [17:56:24] MatmaRex: Yes, but if you got something about a11y I'm happy to help out... currently experimenting and .... [17:57:04] (it also has a dependency which is rather trivial) [17:58:34] I guess I could at least do some screen reader testing for you and report any changes (hopefully no regressions) [18:05:27] YuviPanda|awake: hullo [18:05:46] brion: morning! [18:05:52] how's your weekend? or is it monday already :D [18:05:55] brion: have you seen http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns? [18:06:06] brion: well, it is 11:30PM on a sunday, but I woke up only 2 hours ago. [18:06:11] hehe [18:06:13] brion: so... I think... this is Sunday? [18:06:14] not sure [18:06:14] looking good [18:06:22] how are you getting the contributor count? [18:06:34] brion: joining categorylinks with page and user. [18:06:38] brion: it is hitting all the indexes [18:06:48] brion: it is also cached for 1 minute (configurable parameter) [18:06:59] fun [18:07:00] so if it turns out to be too much, we can always increase the cache timeout [18:07:19] brion: also, me and bawolff decided that for now, just having squid cache timeout be short (10 mins by default) is good enough [18:07:29] brion: and if we run into trouble performance wise, we can just increase it (it is configurable) [18:07:32] well that's the kind of thing that at worst case could be verrrry slow, in which case even caching it doesn't help…. but it's hard to tell without testing it on real large instance :D [18:07:36] ok [18:07:41] sounds like a plan [18:08:00] brion: it also has special functionality if you are not logged in. [18:08:05] brion: asks you to create an account. [18:08:09] yay [18:08:20] we can track that using the (unrelated, but similarly named!) Campaigns extension [18:08:27] the verbiage there needs to be tweaked, though [18:08:28] heh [18:08:34] and we perhaps need to put a 'login' button there as well [18:08:37] but it sortof looks all okay now [18:09:04] brion: and re: campaign managers, I am thinking that the solution there is to build a separate tool called 'MassCampaigns' that is suited for that audience (manages multiple campaigns) [18:09:20] aho [18:09:22] sounds good [18:09:24] brion: and it can be on toollabs, which means that we can also experiment with newer tech (I am thinking AngularJS) [18:09:28] :DD [18:10:02] hmm [18:10:33] YuviPanda|awake: one thing i notice -- if i resize the window, the gallery reflows a bit but ends up with ragged edges [18:10:42] i have to reload to get my justified margins back [18:10:54] that might be a general problem with the new gallery mode [18:10:57] brion: i think that is sortof a known bug, but i dunno if that is filed [18:11:04] oh yeah, definitely issue with gallery mode [18:11:06] and not campaigns [18:11:07] * brion goes to check bugz [18:11:25] yeah i figured it's either a general issue with the gallery or the js that does the resize isn't getting loaded for some reason [18:11:35] probably it just didn't get written in the first place, easy thing to forget :) [18:11:52] :D [18:13:50] brion: file it anyway. worst case a dupe :) [18:14:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=53664 [18:15:19] sweet [18:15:28] brion: thoughts on merging? [18:15:44] did we get any replies from mr complainy? [18:16:28] brion: he did give a big response on the bug, which mostly was 'we did not use these pages in previous years!', but considering those pages only have existed for 2 months or 3 months now... [18:16:38] :) [18:16:47] I don't see how they could've been used last year :) [18:17:07] brion: but response has been positive from every other WLM person I've poked (multichill, Jean-Fred) [18:17:22] ? [18:17:35] huzzah [18:17:45] multichill: no, just talking about the newer Campaign: pages [18:18:38] everyone except Romaine (and platonides?) seemed happy about it [18:19:38] brion: I can commit to building the MassCampaigns tool before this gets deployed. [18:20:02] awesome :D [18:20:10] sounds like we have a plan [18:20:30] but I'd want to get that merged before, so it can go on betalabs and more people can test :) [18:20:37] yeah [18:21:33] brion: I also switched to emacs earlier today :) [18:21:39] hehe [18:21:44] good luck with that [18:21:47] but with Evil Mode [18:21:52] so I still have all my vim keybindings [18:22:16] brion: also, thoughts on putting a 'login' link somewhere next to create account? [18:23:25] YuviPanda|awake: on the campaign page when not logged in? [18:23:29] brion: yes [18:23:44] yeah i'd consider having 'log in and upload' and 'create account and upload' buttons… or else just a login one that lets you easily click through [18:23:59] though… you might want to talk to the editor engagement folks if they have preferences on login/create account CTAs :) [18:24:08] hmm, that would be wise, yes :) [18:24:26] brion: I made that a separate patch though, so it is all good :) [18:24:37] ok [18:25:01] btw os x 10.9 beta has MUCH better support for full-screen mac apps on multi-monitor systems [18:25:07] i'm almost tempted to upgrade my main machine [18:25:09] almost. [18:25:17] I'm still on OS X Lion [18:25:21] and have no plans of upgrading :P [18:25:23] if it explodes i don't want to be unable to make iOS release builds :P [18:25:30] lion! omg obsolete [18:25:43] brion: I'm waiting for haswell Linux laptops [18:25:51] so I can upgrade to Linux [18:25:55] \o/ [18:26:08] okay, brb in 30 mins [18:26:53] brion: do look over the code for security stuff again if you can. I am quite confident that I won't be XSSing / SQLinjecting myself, but it's been a while... [18:27:02] the thing i'll warn on linux right now is that 'retina'-quality display support is in its infancy… but if you want a classic-density screen, go for it :D [18:27:12] ok [18:27:22] brion: well, if all I need is an editor and terminal... [18:27:23] :) [18:27:25] okay, brb for real [18:44:18] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #257: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/257/ [18:49:46] what the hell... I just kept debugging something until it went away for no reason -.- [18:49:56] fixed! [18:51:00] Yay. just checked out master again and it seems to work oO [19:00:25] brion: it is not so much I dislike the gallery, it is only the location of the gallery [19:00:43] Romaine: *nod* [19:01:00] just want to make sure it's not getting in your way [19:01:33] I think it is a strange page, also for non WLM campaigns [19:03:11] one can go either way on that :) either the gallery goes there and the raw data somewhere else or the raw data goes there and the gallery somewhere else [19:03:21] either way, it's a brand new page that didn't exist a few weeks ago [19:03:25] so workflows are what we build around them [19:03:42] before this namespace pages, there were also pages, just on another location [19:03:56] well there was a special: page that listed and allowed editing of the data [19:04:08] yes [19:04:20] had the same function [19:05:32] we had a discussion internal as well, one point that came up it that we like the idea of some kind of portal for campaigns [19:05:54] *nod* [19:06:13] if a gallery is added to campaign pages now, nobody sees it [19:06:20] besides thr managers [19:06:39] I think such gallery should be on a more prominent place [19:07:19] well, they'll be as prominent as people make them :) [19:08:00] and that is the difficulty, people do not realize that they have to be aware of the flow of the user [19:08:27] (03PS1) 10Hoo man: Add aria-live to mw notifications/jsMsg [core] - 10https://gerrit.wikimedia.org/r/82122 [19:13:35] (03PS2) 10Hoo man: Add aria-live to mw notifications/jsMsg [core] - 10https://gerrit.wikimedia.org/r/82122 [19:16:20] (03CR) 10Hoo man: "Maybe this would work in more screen reader + browser combinations without the aria-relevant(?) although that is very weird with NVDA + Fi" [core] - 10https://gerrit.wikimedia.org/r/82122 (owner: 10Hoo man) [19:33:39] brion: About the campaign thing. We usually have a tab to view and one to edit. We could just add another tab like the VE did. [19:34:39] , something like that [19:52:31] ^^ not a worse idea [19:55:58] something to consider yeah [19:59:11] Do we have someone who is to tabs what Chad is to preferences? [20:01:00] liangent: I'm not really sure what's going on here; but you might have a better idea immediately wrt the automatic language conversion patch you put in ... https://bugzilla.wikimedia.org/show_bug.cgi?id=53641 [20:01:45] 53641 is more urgent [20:04:02] (03PS1) 10Jack Phoenix: SocialProfile: restored filter feature on UserActivity. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/82199 [20:11:06] is gerrit loading for anyone? I was just going to go approve ^ and the damn page won't load... [20:11:33] slooooow [20:12:02] ashley: Doesn't look like IE is to blame [20:12:02] ;) [20:16:26] Project browsertests-en.wikipedia.org-linux-firefox build #274: FAILURE in 9 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/274/ [20:27:16] Who forgot to feed Gerrit? [20:28:01] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #247: FAILURE in 4 min 5 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/247/ [20:28:03] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #235: FAILURE in 0.92 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/235/ [20:28:10] Project browsertests-test2.wikipedia.org-linux-chrome build #565: FAILURE in 0.83 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/565/ [20:28:18] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #11: FAILURE in 0.75 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/11/ [20:28:18] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #11: FAILURE in 0.63 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/11/ [20:28:22] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome build #11: FAILURE in 0.63 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome/11/ [20:28:23] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #11: FAILURE in 0.82 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/11/ [20:28:24] Project VisualEditor-test2.wikipedia.org-linux-firefox build #9: FAILURE in 0.77 sec: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/9/ [20:32:40] Is there an easy way to mass search for: Whether a custom [[Mediawiki:Page]] exists or not in each of the language-Wikipedias? I'm specifically looking for the existence of [[MediaWiki:Histlegend]] (and a few other similar pages) in each language, or whether they're just using the default. [20:36:20] is there currently a bug in loading javascript or something, or there a new software been implemented today? [20:36:27] some javascript that worked before doesn't work anymore without local changes [20:37:11] <^d> Nothing should've been implemented/deployed today. It's a Sunday :) [20:37:37] (03PS2) 10Jack Phoenix: SocialProfile: restored filter feature on UserActivity. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/82199 [20:37:47] then something is broken somewhere [20:38:05] <^d> Something's always broken somewhere ;-) [20:38:18] (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: restored filter feature on UserActivity. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/82199 (owner: 10Jack Phoenix) [20:38:52] ^d: that does not help [20:39:31] I suspect some performance issues [20:52:56] quiddity: for a human, you can use Special:AllMessages and toggle the modified button [20:53:05] quiddity: for a bot, just check if the page exists (i think that should work) [20:54:07] just a human check. I was hoping for something faster than checking all 280 languages manually. :/ [20:57:32] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76243 (owner: 10Legoktm) [20:57:48] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/76244 (owner: 10Legoktm) [20:57:56] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/76245 (owner: 10Legoktm) [20:58:01] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/Agora] - 10https://gerrit.wikimedia.org/r/76247 (owner: 10Legoktm) [20:58:03] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/76248 (owner: 10Legoktm) [20:58:07] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/76249 (owner: 10Legoktm) [20:58:11] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/76251 (owner: 10Legoktm) [20:58:15] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/ApiSVGProxy] - 10https://gerrit.wikimedia.org/r/76254 (owner: 10Legoktm) [20:58:18] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/76255 (owner: 10Legoktm) [20:58:21] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/76256 (owner: 10Legoktm) [20:58:24] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/76257 (owner: 10Legoktm) [20:58:27] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/76258 (owner: 10Legoktm) [20:58:30] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/76259 (owner: 10Legoktm) [20:58:36] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/76261 (owner: 10Legoktm) [20:58:42] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/76262 (owner: 10Legoktm) [20:58:45] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/76264 (owner: 10Legoktm) [20:59:01] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/76265 (owner: 10Legoktm) [20:59:04] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/76266 (owner: 10Legoktm) [20:59:08] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/76267 (owner: 10Legoktm) [20:59:10] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/CategorySlideShow] - 10https://gerrit.wikimedia.org/r/76268 (owner: 10Legoktm) [20:59:14] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/CategorySortHeaders] - 10https://gerrit.wikimedia.org/r/76269 (owner: 10Legoktm) [20:59:33] (03Abandoned) 10Legoktm: Cleaning up unused variables in the global space [extensions/APC] - 10https://gerrit.wikimedia.org/r/76252 (owner: 10Legoktm) [20:59:36] {{done}} [21:00:03] * not done [21:00:08] quiddity: well, you probably just want to use a script. it really shouldn't be that hard to write [21:00:10] hoo: :P [21:00:47] why not just user __DIR__? Performance? [21:01:00] * hoo doesn't really know how PHP implements these... [21:02:14] hoo: thats what i did for https://gerrit.wikimedia.org/r/#/c/76253/ but some extensions use dirname(__FILE__) or something, and it depends what PHP version you're using and bleh. [21:03:03] no one really uses PHP 5.2 anymore, really... I hereby declare that :D [21:12:53] <^d> __DIR__ is always going to be faster than dirname(__FILE__). [21:13:03] <^d> But really it's micro-optimization so nobody should bother caring too much ;-) [21:13:26] ^d: The question is __DIR__ vs $dir... [21:13:51] well, but I also guess that doesn't really matter, so we should just use __DIR__ and stop the pollution [21:14:05] <^d> Of all the problems caused by extensions being included globally in scope, $dir is one of the least worrisome. [22:08:44] brion: put it in a repo somewhere :) [22:23:02] (03CR) 10Parent5446: [C: 032] Remove dead code [core] - 10https://gerrit.wikimedia.org/r/82080 (owner: 10Mattflaschen) [22:27:14] (03Merged) 10jenkins-bot: Remove dead code [core] - 10https://gerrit.wikimedia.org/r/82080 (owner: 10Mattflaschen) [22:44:32] (03PS2) 10Mwjames: [DIC]: SMWHooks::onInternalParseBeforeLinks to \SMW\InternalParseBeforeLinks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82066 [23:09:44] (03CR) 10Mwjames: [C: 032] [DIC]: SMWHooks::onInternalParseBeforeLinks to \SMW\InternalParseBeforeLinks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82066 (owner: 10Mwjames) [23:11:50] (03Merged) 10jenkins-bot: [DIC]: SMWHooks::onInternalParseBeforeLinks to \SMW\InternalParseBeforeLinks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82066 (owner: 10Mwjames) [23:34:31] (03PS1) 10Mwjames: Travis#180.3 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82202 [23:35:31] (03PS2) 10Mwjames: Travis#180.3 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82202 [23:35:42] (03CR) 10Mwjames: [C: 032] Travis#180.3 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82202 (owner: 10Mwjames) [23:38:18] (03Merged) 10jenkins-bot: Travis#180.3 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/82202 (owner: 10Mwjames) [23:52:45] mwalker: Romaine: just ask them to translate in zh, and translated text will be shown for users using all variants [23:53:20] in zh is also translated [23:53:44] then you shouldn't need /zh-cn and /zh-tw [23:53:52] and what's wrong if you only translate /zh? [23:54:14] Romaine: ^ [23:54:19] the people in Taiwan speak the zh-tw variant of Chinese and not purely zh itself [23:55:14] Romaine: the system should be able to convert zh to zh-tw before displaying banners for zh-tw users [23:55:30] when bannerloader is called with language=zh-tw [23:56:12] something then goes wrong but I get complaints from those zh-.. variants [23:56:56] Romaine: what goes wrong then? [23:58:04] I do not speak Chinese, the people there say they do not see the banner in zh-tw, but in other Chinese [23:58:12] if the complaint is about "they can't *write* zh-tw", ask them to use zh. if it's about "they can't *seen* zh-tw on banners", something is really going wrong then [23:58:21] *see [23:58:31] we have a /zh page created [23:58:36] yeah [23:58:44] I can speak Chinese [23:58:53] but I need a way to reproduce it [23:59:23] actually ... I don't see this banner anywhere at all [23:59:31] (maybe I closed it accidentially?) [23:59:40] https://meta.wikimedia.org/wiki/Special:PrefixIndex/MediaWiki:Centralnotice-wlm_2013-text/zh