[00:00:13] <YuviPanda>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/81485/ is rather trivial
[00:00:13] <marktraceur>	 On the multimedia "stuff"?
[00:00:18] <marktraceur>	 K, noted
[00:00:24] <YuviPanda>	 marktraceur: err, the multimedia labs instance
[00:00:48] * YuviPanda  heads to wikitech

[00:00:56] <YuviPanda>	 marktraceur: did you manage to resolve the slowness?
[00:01:01] <marktraceur>	 YuviPanda: 81485 is also *merged*
[00:01:10] <marktraceur>	 What slowness? Oh, the vim slowness? Nope.
[00:01:12] <YuviPanda>	 marktraceur: ow, wrong link
[00:01:28] <YuviPanda>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/81452/ i meant
[00:01:41] <marktraceur>	 Got it
[00:01:49] <marktraceur>	 It's on my list, I'll do it later tonight
[00:02:00] <marktraceur>	 For now, I'm gonna race home and recieve my order of two dozen buffalo wings
[00:02:01] <YuviPanda>	 marktraceur: ty, but i'll poke brion until he does it anyway :)
[00:02:08] <YuviPanda>	 marktraceur: eeew, meat with bones
[00:02:16] <YuviPanda>	 marktraceur: is there something precious in the multimedia instances?
[00:02:23] <YuviPanda>	 marktraceur: I could switch them to NFS, and then they won't suck.
[00:02:26] <marktraceur>	 YuviPanda: No, the core patches are no longer helpful
[00:02:32] <wmf-selenium-bot>	 Yippie, build fixed!
[00:02:32] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #3: FIXED in 28 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/3/
[00:02:39] <marktraceur>	 OH wait
[00:02:40] <marktraceur>	 Sorta
[00:02:44] <YuviPanda>	 marktraceur: hmm, okay
[00:02:48] <marktraceur>	 YuviPanda: We have a bot running out of /srv/irc
[00:02:53] <marktraceur>	 So long as you back 'er up
[00:03:17] <marktraceur>	 There's also a few things in /etc related to it
[00:03:21] <YuviPanda>	 marktraceur: shouldn't affect any of those. 
[00:03:23] <YuviPanda>	 marktraceur: just /home
[00:03:27] <marktraceur>	 Ah, cool
[00:03:30] <marktraceur>	 Go nuts
[00:03:41] <marktraceur>	 bd808: We're trading out data for faster /home
[00:03:43] <grrrit-wm>	 (03PS2) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[00:03:43] <grrrit-wm>	 (03PS3) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[00:03:44] <grrrit-wm>	 (03PS4) 10Brian Wolff: Follow-up I49b7d8a - Add api module for common metadata [core] - 10https://gerrit.wikimedia.org/r/78815 
[00:03:59] <YuviPanda>	 rebooting now
[00:04:33] * marktraceur  packs up

[00:04:36] <marktraceur>	 See y'all lata
[00:05:38] <bd808>	 marktraceur, YuviPanda: +2 on faster /home
[00:09:38] <YuviPanda>	 bd808: should be faster now. try?
[00:10:02] <YuviPanda>	 bd808: marktraceur there's data in /src and /etc is untouched, but I *did* reboot the machine
[00:10:07] <grrrit-wm>	 (03CR) 10Mattflaschen: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain)
[00:10:14] <YuviPanda>	 bd808: marktraceur so whatever was running won't be running anymore
[00:11:53] <Krenair>	 chrismcmahon, I'm getting "An error has occurred while searching: Error fetching URL: couldn&#39;t connect to host" when I try to load http://en.wiktionary.beta.wmflabs.org/w/index.php?title=Special:Search&search=asd+ondiscussionpage%3AUser+talk%3AKrenair&fulltext=1&ns90=1&srbackend=LuceneSearch
[00:12:11] <bd808>	 YuviPanda: still slow, but maybe I'm somewhere else?
[00:12:19] <bd808>	 "projectstorage.pmtpa.wmnet:/multimedia-home on /home type fuse.glusterfs"
[00:12:27] <YuviPanda>	 err, really?
[00:12:32] <Ryan_Lane>	 :D
[00:12:34] <YuviPanda>	 ah, hmm
[00:12:50] <YuviPanda>	 what did I do wrong now?
[00:12:53] * YuviPanda  goes to find out

[00:13:10] <YuviPanda>	 Ryan_Lane: I added the nfs client role, but this is still on glusterfs?
[00:14:09] <bd808>	 YuviPanda: I've got to head out to a play, but `time find ~bd808/.vim/bundle` is my slow benchmark. >1s is sloooow
[00:14:17] <YuviPanda>	 bd808: alright!
[00:14:29] <grrrit-wm>	 (03CR) 10MZMcBride: "I have this commit starred, so I've been seeing the bumps to try to get it reviewed and eventually merged. I'll post my thoughts on the bu" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff)
[00:14:45] <chrismcmahon>	 Krenair: search host seems to be down, I tried also with http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Search&search=asd+ondiscussionpage%3AUser+talk%3AKrenair&fulltext=1&ns90=1&srbackend=LuceneSearch 
[00:15:20] <Ryan_Lane>	 YuviPanda: did you run puppet before rebooting?
[00:15:36] <YuviPanda>	 Ryan_Lane: me and Coren already determined that I'm an idiot and hence I did not :)
[00:15:39] <Ryan_Lane>	 heh
[00:16:05] <bawolff>	 Elsie: Just so you know, what I'm doing right now is not a bump to try and get it reviewed (although that would be nice), but rebasing it, so its split into two commits, and my other commit can be dependant on what I think is the less controversial part, instead of the entire thing
[00:16:29] <Krenair>	 chrismcmahon, what is that error even generated by? core?
[00:17:48] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Efficiently reset null user tokens [core] - 10https://gerrit.wikimedia.org/r/77136 (owner: 10CSteipp)
[00:18:14] <Krenair>	 chrismcmahon, I don't even know what host it's connecting to
[00:18:36] <Elsie>	 bawolff: I commented on the bug. Whole idea seems a bit weird.
[00:18:45] <Elsie>	 The Lua part makes sense to me. The parser function itself... eh.
[00:19:18] <Elsie>	 I worry that the bug was filed as both a problem and solution when perhaps more focus is needed on what the problem is.
[00:20:06] <Elsie>	 Though perhaps a parser function is the best approach.
[00:20:17] <grrrit-wm>	 (03PS2) 10Krinkle: doc: Remove repetitive "Give grep a chance" phrase from comments [core] - 10https://gerrit.wikimedia.org/r/81440 
[00:20:20] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #3: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/3/
[00:20:42] <chrismcmahon>	 Krenair: might be a bogus error msg actually, but I'll have to follow up tomorrow
[00:20:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Efficiently reset null user tokens [core] - 10https://gerrit.wikimedia.org/r/77136 (owner: 10CSteipp)
[00:23:04] <bawolff>	 Elsie: It may very well be that I just kind of like parser functions more than I should (Stockholm syndrome style) 
[00:23:18] <bawolff>	 Elsie: At the moment what I really want merged is more the back end changes
[00:24:02] <bawolff>	 which is why I'm splitting them up (or trying to. dependant changes suck)
[00:27:59] <grrrit-wm>	 (03CR) 10Shirayuki: "You should grep the word "grep"." [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[00:28:43] <grrrit-wm>	 (03CR) 10Krinkle: "Feel fr" [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[00:29:15] <grrrit-wm>	 (03CR) 10Krinkle: "Feel free to fix those later (I might do it later). I intentionally did not do that. I'm just following up b2e2b2e016 specifically. The ot" [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[00:32:02] <Coren>	 Hm.  I have the /right/ to +2 a changeset to core; it's written well and I've tested it to work.  Am I cool enough to +2 or do I +1 and wait for someone /really/ cool to +2 behind me?  (It's in the block code with which I am fairly familiar)
[00:33:35] <YuviPanda>	 Ryan_Lane: 
[00:33:36] <YuviPanda>	 err
[00:33:38] <YuviPanda>	 sorry
[00:33:39] <grrrit-wm>	 (03CR) 10coren: [C: 031] "This appears to be correct, and prevents a (very short) window during which the block is actually removed." [core] - 10https://gerrit.wikimedia.org/r/66366 (owner: 10Parent5446)
[00:33:43] <YuviPanda>	 didn't mean to ping you, Ryan_Lane
[00:33:51] <YuviPanda>	 Coren: +2, I'd say - especially if you've tested it
[00:34:27] <Coren>	 I chickened out and +1'ed it.  I have all of 1 commit to core under my name, I'd rather get more eyes.
[00:38:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[00:38:39] <YuviPanda>	 bd808|AWAY: so it's back! and it is NFS!
[00:38:54] <YuviPanda>	 bd808|AWAY: and in the process I fixed that instance's puppet config, which was totally broken :P
[00:39:21] <YuviPanda>	 bd808|AWAY: but your home is now dead.
[00:39:25] <YuviPanda>	 bd808|AWAY: but I backed it up to /srv
[00:39:30] <YuviPanda>	 bd808|AWAY: so you should be good
[00:39:36] <YuviPanda>	 marktraceur:  on the other hand, your home directory is gone :(
[00:39:38] <YuviPanda>	 sorry about that
[00:40:03] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[00:40:48] <Reedy>	 Hmm
[00:40:55] <Reedy>	 Why is Chrome getting pissy with pages with LQT on?
[00:41:03] <Reedy>	 "You have unsaved text open.."
[00:41:05] <Reedy>	 No I don't
[00:41:38] <Elsie>	 Oh, yeah.
[00:41:42] <Elsie>	 I was getting that on mediawiki.org.
[00:41:47] <Elsie>	 A bit annoying.
[00:41:53] <YuviPanda>	 just staff breaking wikipedia again
[00:42:10] <Reedy>	 HOW DARE YOU YUVIPANDA
[00:42:16] <Reedy>	 So it's not a Chrome bug?
[00:42:25] <Reedy>	 Is there somewhere I can +1 complain?
[00:42:51] <Krenair>	 Actually I broke it this time. Sort of.
[00:43:44] <Elsie>	 :+1: :github:
[00:43:47] <Elsie>	 :twerk:
[00:44:03] <Krenair>	 I think https://gerrit.wikimedia.org/r/#/c/80803/ fixes it
[00:46:08] <grrrit-wm>	 (03CR) 10Krinkle: "@Tim: I'd like your view on this regarding the code pattern and architecture." [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446)
[00:47:25] <Krenair>	 (yeah I checked, this is definitely fixed on the latest master)
[00:48:24] <Reedy>	 Is it only broken in wmf14?
[00:49:06] <grrrit-wm>	 (03PS1) 10Reedy: Update LiquidThreads to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81606 
[00:49:08] <Krenair>	 yes Reedy 
[00:49:09] <Reedy>	 Krenair: ?
[00:49:17] <Reedy>	 Right, I'll deploy that post sleep
[00:49:18] <Krenair>	 broke august 17th
[00:49:39] <Krenair>	 1.22wmf13 was branched august 15th
[00:51:49] <wmf-selenium-bot>	 Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/3/
[00:53:38] <grrrit-wm>	 (03PS1) 10Manybubbles: Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 
[00:53:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 (owner: 10Manybubbles)
[00:53:53] <grrrit-wm>	 (03PS2) 10Manybubbles: Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 
[00:53:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 (owner: 10Manybubbles)
[00:55:14] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Setting it to -1 myself because it has a github submodule and those don't work for us but I think Chad is better suited to import it into " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 (owner: 10Manybubbles)
[00:56:27] <grrrit-wm>	 (03PS3) 10Manybubbles: Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 
[00:56:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch to xpath for page cleanup. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81607 (owner: 10Manybubbles)
[01:05:20] <wmf-selenium-bot>	 Project VisualEditor-test2.wikipedia.org-linux-firefox build #1: SUCCESS in 23 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/1/
[01:05:32] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add CodeEditor as a dependency for UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/81608 
[01:05:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add CodeEditor as a dependency for UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/81608 (owner: 10Yuvipanda)
[01:06:08] <grrrit-wm>	 (03PS1) 10Manybubbles: Test for removing the contents of <audio> tags. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81609 
[01:07:15] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add CodeEditor as a dependency for UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/81608 
[01:09:52] <grrrit-wm>	 (03PS3) 10Krinkle: Add CodeEditor as a dependency for UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/81608 (owner: 10Yuvipanda)
[01:10:47] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] make-release: use argparse, snapshot by default [tools/release] - 10https://gerrit.wikimedia.org/r/81562 (owner: 10Hashar)
[01:14:19] <grrrit-wm>	 (03PS1) 10Ori.livneh: Test for compliance with W3C spec [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81610 
[01:15:41] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Test for compliance with W3C spec [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81610 (owner: 10Ori.livneh)
[01:15:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test for compliance with W3C spec [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81610 (owner: 10Ori.livneh)
[01:25:06] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "(2 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 (owner: 10Mattflaschen)
[01:25:50] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 (owner: 10Mattflaschen)
[01:26:19] <grrrit-wm>	 (03PS1) 10Manybubbles: Test for searching incategory:"". [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81612 
[01:32:36] <grrrit-wm>	 (03PS2) 10Mattflaschen: Fix detection of VE to use isAvailable [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 
[01:34:00] <grrrit-wm>	 (03PS1) 10Mattflaschen: Fix a missing .text() on mw.message call. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/81613 
[01:36:23] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: update param names and usage message. [tools/release] - 10https://gerrit.wikimedia.org/r/81270 (owner: 10MarkAHershberger)
[01:38:18] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: * Add --smw option for packaging Semantic Bundle [tools/release] - 10https://gerrit.wikimedia.org/r/28958 (owner: 10MarkAHershberger)
[01:38:23] <YuviPanda>	 ori-l: I'm going to self-merge vagrant stuff. hopefully won't break too many things :)
[01:38:35] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "Flexing the knighthood" [vagrant] - 10https://gerrit.wikimedia.org/r/81608 (owner: 10Yuvipanda)
[01:38:52] <grrrit-wm>	 (03CR) 10Mattflaschen: "(3 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 (owner: 10Mattflaschen)
[01:39:13] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: hardcoded branch and root dir are now options [tools/release] - 10https://gerrit.wikimedia.org/r/81240 (owner: 10MarkAHershberger)
[01:45:39] <marktraceur>	 ...dragons, YuviPanda?
[01:47:05] <grrrit-wm>	 (03PS1) 10Seb35: Set a non-secure attribute when clearing a cookie [core] - 10https://gerrit.wikimedia.org/r/81614 
[01:52:10] <grrrit-wm>	 (03PS2) 10Manybubbles: Test for searching incategory:"". [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81612 
[01:54:15] <grrrit-wm>	 (03PS1) 10Manybubbles: Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 
[01:54:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[01:54:36] <grrrit-wm>	 (03PS4) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[01:54:45] <grrrit-wm>	 (03PS2) 10Manybubbles: Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 
[01:55:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[02:00:13] <grrrit-wm>	 (03PS3) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[02:00:21] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix detection of VE to use isAvailable [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 (owner: 10Mattflaschen)
[02:00:29] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix a missing .text() on mw.message call. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/81613 (owner: 10Mattflaschen)
[02:00:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix detection of VE to use isAvailable [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 (owner: 10Mattflaschen)
[02:01:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix a missing .text() on mw.message call. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/81613 (owner: 10Mattflaschen)
[02:06:16] <grrrit-wm>	 (03CR) 10Krinkle: "Why would we prefix parameters to Special pages (and why only this one?). Why would it have to matter the API? They can be different, that" [core] - 10https://gerrit.wikimedia.org/r/79299 (owner: 10Chad)
[02:14:17] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: Move extension generation so that diffs work better [tools/release] - 10https://gerrit.wikimedia.org/r/56883 (owner: 10MarkAHershberger)
[02:19:41] <grrrit-wm>	 (03PS14) 10Brian Wolff: Add {{#filemetadata:..}} to insert file metadata on to a wiki page. [core] - 10https://gerrit.wikimedia.org/r/67047 
[02:19:42] <grrrit-wm>	 (03PS5) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[02:19:51] <bawolff>	 rebasing is fun...
[02:20:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add {{#filemetadata:..}} to insert file metadata on to a wiki page. [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff)
[02:20:19] <T13>	 Freebasing is fun?
[02:20:19] <bawolff>	 fun
[02:20:24] <T13>	 Ha
[02:21:15] <bawolff>	 how could that possibly not be mergable. I just rebased it
[02:21:29] <T13>	 bawolff: when you freebase you not only hurt yourself, but you hurt those around you too...
[02:22:00] <YuviPanda>	 hey ori-l
[02:22:02] <YuviPanda>	 ori-l: http://multimedia-dragons.instance-proxy.wmflabs.org/wiki/Main_Page
[02:22:10] <YuviPanda>	 ori-l: that's vagrant running on labs :D
[02:22:16] <YuviPanda>	 well, the puppet files in vagrant.
[02:22:16] <bawolff>	 true that. Those around me are also probably going to be hurt when I have mental break down over gerrit
[02:22:19] <YuviPanda>	 needed only a two line patch
[02:22:33] * T13  wriggles in the white jacket and wanders off talking to hisself...

[02:26:29] <YuviPanda>	 marktraceur: http://multimedia-dragons.instance-proxy.wmflabs.org/wiki/Special:UploadWizard
[02:26:31] <YuviPanda>	 bwahahaha!
[02:26:37] <YuviPanda>	 I got vagrant running on labs!
[02:26:41] <marktraceur>	 Nice!
[02:26:43] <YuviPanda>	 well, the vagrant puppet files
[02:27:01] <YuviPanda>	 marktraceur: so i was able to setup a fully functional UW setup by editing one file only!
[02:27:11] <YuviPanda>	 (in the end, that is. a bit of tickling needed before that)
[02:33:16] <grrrit-wm>	 (03PS15) 10Brian Wolff: Add {{#filemetadata:..}} to insert file metadata on to a wiki page. [core] - 10https://gerrit.wikimedia.org/r/67047 
[02:33:17] <grrrit-wm>	 (03PS6) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[02:33:18] <grrrit-wm>	 (03PS2) 10Brian Wolff: Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 
[02:33:39] * bawolff  starts to hate git rebase

[02:33:49] <bawolff>	 please pass unit tests jenkins-bot...
[02:33:57] <marktraceur>	 Heh
[02:37:50] <grrrit-wm>	 (03PS1) 10Yuvipanda: Do not make apache listen on forwarded port if no port set [vagrant] - 10https://gerrit.wikimedia.org/r/81617 
[02:38:25] <grrrit-wm>	 (03PS4) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[02:38:48] <bawolff>	 ok, I think that's all the rebasing I need to do
[02:38:51] <bawolff>	 finally
[02:38:58] <bawolff>	 maybe I should test it to see if it still even works
[02:40:09] <bawolff>	 fml, I broke something in the rebasing
[02:40:43] <grrrit-wm>	 (03PS2) 10Yuvipanda: Do not make apache listen on forwarded port if no port set [vagrant] - 10https://gerrit.wikimedia.org/r/81617 
[02:49:20] <grrrit-wm>	 (03PS3) 10Yuvipanda: Do not make apache listen on forwarded port if no port set [vagrant] - 10https://gerrit.wikimedia.org/r/81617 
[02:54:31] <grrrit-wm>	 (03PS3) 10Mattflaschen: Filter out elements that are not :visible when attaching. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 
[02:54:42] <grrrit-wm>	 (03PS1) 10Yuvipanda: Do not specify hostname explicitly for node name [vagrant] - 10https://gerrit.wikimedia.org/r/81618 
[02:54:53] <grrrit-wm>	 (03CR) 10Mattflaschen: "(4 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 (owner: 10Mattflaschen)
[02:55:13] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "Seems to work for both cases - when it is set and not set." [vagrant] - 10https://gerrit.wikimedia.org/r/81617 (owner: 10Yuvipanda)
[02:55:48] <YuviPanda>	 ori-l: would still like you to review https://gerrit.wikimedia.org/r/#/c/81618/, since I'm not too sure if there are any subtle repucrussions i"m missing
[02:55:53] <YuviPanda>	 ori-l: it's a +1 -1 change.
[02:56:27] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: rename [tools/release] - 10https://gerrit.wikimedia.org/r/81588 (owner: 10MarkAHershberger)
[02:56:42] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: merge [tools/release] - 10https://gerrit.wikimedia.org/r/81587 (owner: 10MarkAHershberger)
[02:59:56] <grrrit-wm>	 (03PS5) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[02:59:57] <grrrit-wm>	 (03PS7) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[03:00:44] <marktraceur>	 YuviPanda: Re https://gerrit.wikimedia.org/r/81452 are there no other places where we construct campaign objects?
[03:00:57] <YuviPanda>	 marktraceur: grep doesn't find me anything
[03:01:03] <marktraceur>	 KK
[03:01:11] <YuviPanda>	 marktraceur: which makes sense, since it is private :P
[03:01:20] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Seems a little saner anyway!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81452 (owner: 10Yuvipanda)
[03:01:27] <YuviPanda>	 ty, marktraceur
[03:01:39] <marktraceur>	 Yup!
[03:02:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Store Title as backing identifier for UploadWizardCampaign [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81452 (owner: 10Yuvipanda)
[03:03:58] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Add and use tarignore, add gitignore, clean up make-release and rename [tools/release] - 10https://gerrit.wikimedia.org/r/81619 
[03:04:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add and use tarignore, add gitignore, clean up make-release and rename [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger)
[03:04:38] <YuviPanda>	 marktraceur: can you tell me if http://multimedia-dragons.instance-proxy.wmflabs.org/wiki/Main_page works for you?
[03:04:56] <YuviPanda>	 marktraceur: also http://multimedia-dragons.instance-proxy.wmflabs.org/
[03:05:02] <marktraceur>	 It loads
[03:05:07] <YuviPanda>	 marktraceur: both?
[03:05:15] <marktraceur>	 Yyyyes
[03:05:19] <YuviPanda>	 marktraceur: alright
[03:05:24] * YuviPanda  is fairly excited, to say the least.

[03:05:32] <marktraceur>	 The first has no text in it
[03:05:40] <YuviPanda>	 marktraceur: hmm?
[03:05:47] <YuviPanda>	 marktraceur: you don't see a mediawiki page?
[03:05:50] <marktraceur>	 You linked to [[Main page]] not [[Main Page]]
[03:05:52] <marktraceur>	 So no text
[03:05:58] <YuviPanda>	 marktraceur: right, right.
[03:07:15] <grrrit-wm>	 (03PS5) 10Brian Wolff: Follow-up I49b7d8a - Add api module for common metadata [core] - 10https://gerrit.wikimedia.org/r/78815 
[03:08:09] <bawolff>	 ha, I think I rebased everything right this time
[03:11:38] <marktraceur>	 One can only hope
[03:12:47] <bawolff>	 never going to make dependant patches in gerrit again
[03:14:47] <marktraceur>	 bawolff: But it's so much fun!
[03:14:48] <marktraceur>	 :)
[03:15:10] <YuviPanda>	 marktraceur: okay, can I take away mediawiki-alpha's public IP for a while?
[03:16:22] <YuviPanda>	 marktraceur: has that URL been shown around anywhere?
[03:16:28] <grrrit-wm>	 (03CR) 10Brian Wolff: "PS 2-5: rebase madness, still have to do Anomie's comments" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[03:20:18] <grrrit-wm>	 (03PS5) 10Brian Wolff: (DO NOT MERGE; needs I49b7d8a05) Add a lua interface for getting file metadata [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/67588 
[03:20:40] <marktraceur>	 It has been a little
[03:20:44] <marktraceur>	 But go ahead
[03:20:46] <marktraceur>	 It's labs
[03:21:38] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Do not specify hostname explicitly for node name [vagrant] - 10https://gerrit.wikimedia.org/r/81618 (owner: 10Yuvipanda)
[03:21:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not specify hostname explicitly for node name [vagrant] - 10https://gerrit.wikimedia.org/r/81618 (owner: 10Yuvipanda)
[03:36:58] <grrrit-wm>	 (03PS1) 10Legoktm: [WIP] Log skips [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81620 
[03:39:29] <wmf-selenium-bot>	 Yippie, build fixed!
[03:39:30] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #239: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/239/
[03:43:34] <grrrit-wm>	 (03PS1) 10Legoktm: Use the canonical version of the spamlist link [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81621 
[03:45:06] <legoktm>	 Elsie: ^
[03:45:35] <Elsie>	 ygg
[03:46:02] <wmf-selenium-bot>	 Yippie, build fixed!
[03:46:03] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #250: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/250/
[04:18:13] <grrrit-wm>	 (03PS1) 10Legoktm: Add a little CSS to format the save/preview buttons on the same line [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 
[04:19:05] <legoktm>	 superm401: ping
[04:19:23] <superm401>	 legoktm, hey
[04:20:28] <legoktm>	 hey, so i remember you saying something at wikimania about how if you load the CSS and JS together the CSS doesn't load if JS is disabled...
[04:20:42] <legoktm>	 how do I work around that so the css is loaded all the time, and js whenever?
[04:22:24] <superm401>	 Use a CSS-only module, then add it with addModuleStyles.
[04:22:34] <superm401>	 To avoid double-loading it, *only* add it with addModuleStyles.
[04:22:39] <superm401>	 And never put it as a dependency.
[04:22:45] <legoktm>	 ok
[04:23:23] <superm401>	 There's a convention that if you have two modules that are basically the same except for this difference you add .js
[04:23:29] <grrrit-wm>	 (03PS2) 10Esanders: Remove preference prefix string [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 
[04:23:47] <superm401>	 legoktm, e.g. core has skins.vector and skins.vector.js.
[04:23:51] <superm401>	 Hope that helps
[04:23:54] <legoktm>	 ok
[04:23:56] <legoktm>	 thanks
[04:24:01] <superm401>	 No problem
[04:26:26] <grrrit-wm>	 (03PS2) 10Legoktm: Add a little CSS to format the save/preview buttons on the same line [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 
[04:26:34] <legoktm>	 superm401: review plz? ^ :D
[04:36:28] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] "Haven't tested yet." [core] - 10https://gerrit.wikimedia.org/r/81614 (owner: 10Seb35)
[04:52:05] <grrrit-wm>	 (03PS1) 10Yuvipanda: Make sure to not repeat port 80 in apache ports.conf [vagrant] - 10https://gerrit.wikimedia.org/r/81623 
[04:59:08] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Use the canonical version of the spamlist link [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81621 (owner: 10Legoktm)
[04:59:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use the canonical version of the spamlist link [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81621 (owner: 10Legoktm)
[05:01:46] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 031] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 (owner: 10Legoktm)
[05:03:16] <grrrit-wm>	 (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 (owner: 10Legoktm)
[05:04:05] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 (owner: 10Legoktm)
[05:06:29] <grrrit-wm>	 (03CR) 10Parent5446: "Not sure how I feel about it returning false if not supported. If it doesn't support metadata, why not just return an empty array represen" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[05:08:33] <superm401>	 legoktm, the form layout is weird (empty label, etc.).
[05:08:43] <superm401>	 But I'm not that familiar with HTMLForm, so I don't know if there's a good way to avoid it.
[05:09:01] <superm401>	 There is a separate bug, though, which I'll explain iin the review.
[05:09:07] <legoktm>	 ok, thanks.
[05:09:19] <legoktm>	 HTMLForm is very useful for setting up a quick form, but very difficult to customize.
[05:14:47] <superm401>	 legoktm, also, preexisting issue, byteLimit requires a maxlength.
[05:14:58] <superm401>	 Or passing it in (but I think maxlength is probably better).
[05:15:28] <legoktm>	 superm401: that's set with HTML form, SpecialMassMessage.php:95
[05:15:48] <superm401>	 https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3f0272004cd115b07c313a8c8a17c3a841052353/resources%2Fjquery%2Fjquery.byteLimit.js#L155
[05:15:52] <superm401>	 legoktm, well, it's not getting set.
[05:16:10] <legoktm>	 hrmmmm
[05:16:25] <legoktm>	 "<input id="form-subject" name="wpsubject" size="45" value="23" maxlength="240" />" <-- wfm?
[05:17:39] <superm401>	 legoktm, never mind, you're right.
[05:17:42] <superm401>	 byteLimit removes it.
[05:18:10] <legoktm>	 ok :)
[05:31:59] <superm401>	 legoktm, uh
[05:32:19] <legoktm>	 o_O
[05:32:29] <grrrit-wm>	 (03CR) 10Mattflaschen: "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81622 (owner: 10Legoktm)
[05:33:00] <superm401>	 legoktm, well, on the plus side the most serious issue in the commit was broken already. :)
[05:33:40] <legoktm>	 heh
[05:34:06] <superm401>	 Reviewed anyway
[05:34:15] <legoktm>	 so 'remoteExtPath' => 'MassMessage'?
[05:34:18] <legoktm>	 thanks :)
[05:34:34] <superm401>	 Yep, I get tired of it, hence the shortcut (a few extensions do similar).
[05:34:49] <legoktm>	 hm. well since there are only 2 now, i don't think its a big deal
[05:34:54] <superm401>	 True
[05:36:18] <grrrit-wm>	 (03PS1) 10Legoktm: Set 'remoteExtPath' for RL modules properly [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81624 
[05:36:30] <legoktm>	 how does ^ look?
[05:41:25] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Looks good (fixes the 404)." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81624 (owner: 10Legoktm)
[05:41:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set 'remoteExtPath' for RL modules properly [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81624 (owner: 10Legoktm)
[05:42:44] <grrrit-wm>	 (03PS1) 10Legoktm: Prefix all form keys with "mw-massmessage" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81625 
[05:43:54] <legoktm>	 superm401: ^
[05:45:13] <superm401>	 The topic is a lie! :)
[05:46:15] <legoktm>	 er?
[05:46:46] <superm401>	 Not a big deal, still says remoteexpath.
[05:47:10] <legoktm>	 oh heh
[05:47:12] <legoktm>	 i'm on the same branch
[05:47:20] <superm401>	 Did you see my suggestion to put the form selector at the beginning in the CSS?
[05:47:28] <legoktm>	 Yeah, there's another patchset for that
[05:47:31] <legoktm>	 about to commit it
[05:47:32] <superm401>	 Oh, okay.
[05:48:32] <grrrit-wm>	 (03PS1) 10Legoktm: Only have the CSS apply inside "massmessage-form" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81626 
[05:48:40] <legoktm>	 superm401: that one ^ :D
[05:49:08] <superm401>	 Yep
[05:53:48] <spagewmf>	 how can I force an extension's DB update to run?  It does $updater->addPostDatabaseUpdateMaintenance( 'FlowInsertDefaultDefinitions' );
[05:54:25] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Prefix all form keys with "mw-massmessage" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81625 (owner: 10Legoktm)
[05:54:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prefix all form keys with "mw-massmessage" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81625 (owner: 10Legoktm)
[05:54:41] <spagewmf>	 but rerunning usual maintenance/update.php prints "...Update 'FlowInsertDefaultDefinitions' already logged as completed."
[05:55:55] <spagewmf>	 I bet there's some $ run_update --force FlowInsertDefaultDefinitions
[05:56:09] <spagewmf>	 I guess I'll delete it from the update log
[05:56:34] <superm401>	 Hmm, not famiiliar with addPostDatabaseUpdateMaintenance
[05:57:03] <grrrit-wm>	 (03CR) 10Mattflaschen: "Although massmessage-form was left out (has massmessage but no mw)." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81625 (owner: 10Legoktm)
[05:57:18] <legoktm>	 blah, oops.
[05:57:39] <legoktm>	 superm401: I'll just do that in the CSS patchset, give me a minute
[05:59:06] <grrrit-wm>	 (03PS2) 10Legoktm: Only have the CSS apply inside "mw-massmessage-form" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81626 
[05:59:15] <legoktm>	 superm401: done. ^
[06:00:41] <spagewmf>	 superm401: I ran mysql delete from updatelog where ul_key = 'FlowInsertDefaultDefinitions' LIMIT 1; , that worked but I bet there's a more direct way to invoke a particular maintenance function;
[06:00:54] <superm401>	 Possibly.
[06:01:06] <superm401>	 In theory that scenario (already ran but needs again) should never occur.
[06:01:11] <superm401>	 In theory... :)
[06:02:51] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Only have the CSS apply inside "mw-massmessage-form" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81626 (owner: 10Legoktm)
[06:02:54] <spagewmf>	 Well, developers updating schemas and default record insertion of brand new code; it's too much to expect every commit to cleanly update DB from any state to latest state
[06:02:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only have the CSS apply inside "mw-massmessage-form" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81626 (owner: 10Legoktm)
[06:03:18] <superm401>	 "it's too much to expect every commit to cleanly update DB from any state to latest state"
[06:03:29] <superm401>	 It's doable.  I've actually been requiring it for Annotator.
[06:03:43] <superm401>	 There have been a couple slip-ups, but they were correctable without every requiring manual futzing with the DB.
[06:04:06] <superm401>	 I agree it takes some extra work.
[06:04:28] <legoktm>	 superm401: thanks for the reviews :)
[06:04:34] <superm401>	 legoktm, no problem.
[06:04:38] <grrrit-wm>	 (03CR) 10Chad: "It's hard enough to get people to test new features. I figured just having one parameter name made it easier for me to explain to people :" [core] - 10https://gerrit.wikimedia.org/r/79299 (owner: 10Chad)
[06:04:53] <superm401>	 spagewmf, one issue is that sometimes you need to require people to rebase onto master when there commit relies on an old DB.
[06:05:03] <superm401>	 And yours is already updated to master.
[06:16:25] <grrrit-wm>	 (03PS1) 10Spage: fix missing MWEchoDbFactory::getDB() call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81628 
[06:20:24] <grrrit-wm>	 (03PS2) 10Ori.livneh: Make sure to not repeat port 80 in apache ports.conf [vagrant] - 10https://gerrit.wikimedia.org/r/81623 (owner: 10Yuvipanda)
[06:20:42] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Make sure to not repeat port 80 in apache ports.conf [vagrant] - 10https://gerrit.wikimedia.org/r/81623 (owner: 10Yuvipanda)
[06:20:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure to not repeat port 80 in apache ports.conf [vagrant] - 10https://gerrit.wikimedia.org/r/81623 (owner: 10Yuvipanda)
[06:22:04] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Bug 53105: Make the extension function independently from the schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite)
[06:22:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 53105: Make the extension function independently from the schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite)
[06:23:22] <grrrit-wm>	 (03PD1) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 
[06:24:55] <grrrit-wm>	 (03CR) 10Mwalker: [C: 04-1] "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 (owner: 10Mollywhite)
[06:25:42] <grrrit-wm>	 (03CR) 10Wikinaut: "Ryan, this is a first draft for the issue 46617 (you reported). Perhaps you can help me to get it working - the account creation by mail i" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 (owner: 10Wikinaut)
[06:34:51] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(8 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81555 (owner: 10Rjain)
[06:35:57] <grrrit-wm>	 (03PS1) 10Spage: Remove visualEditor.standalone RL dependency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81631 
[06:36:01] <grrrit-wm>	 (03CR) 10Mattflaschen: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81555 (owner: 10Rjain)
[06:36:22] <spagewmf>	 superm401: it's bedtime in Philly
[06:36:40] <superm401>	 spagewmf, yeah, I'm wrapping it up.
[06:36:57] <spagewmf>	 tthat's what I said 40 minutes ago :)
[06:37:15] <superm401>	 spagewmf, BTW, my understanding (from talking to people a while back) is Flow will work without VE
[06:37:20] <superm401>	 Albeit not the preferred mode.
[06:37:25] <superm401>	 Even without JS IIRC.
[06:38:17] <spagewmf>	 superm401 yup I'm hoping to get it working on ee-prototype, then hoping to brute-merge its CSS with mediawiki.ui
[06:51:20] <grrrit-wm>	 (03PS1) 10Rfaulk: add - basic structure of default sync, push from local, pull on target. [sartoris] - 10https://gerrit.wikimedia.org/r/81632 
[06:51:47] <grrrit-wm>	 (03CR) 10Rfaulk: [C: 032 V: 032] add - basic structure of default sync, push from local, pull on target. [sartoris] - 10https://gerrit.wikimedia.org/r/81632 (owner: 10Rfaulk)
[07:10:52] <grrrit-wm>	 (03CR) 10Mattflaschen: "Yes, you're right. It would break for anyone using a prefix. Please correct it." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain)
[07:34:53] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[07:39:37] <grrrit-wm>	 (03PS2) 10Hashar: operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74124 
[07:40:13] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74124 (owner: 10Hashar)
[07:45:14] <Nemo_bis>	 Krenair: has ondiscussionpage: ever worked in the last few years?
[07:47:22] <Nikerabbit>	 Nemo_bis: no
[07:49:39] <Nemo_bis>	 Nikerabbit: I was surprised because he complained that cirrussearch will break that
[07:51:51] <Nemo_bis>	 +peaking of which, I don't understand why we cannot have automatic tests of a real life search query corpus to spot the biggest variations in all languages
[07:54:32] <Nemo_bis>	 thedj: also, media search on client does or did show search results from Commons too, right?
[08:02:19] <Nikerabbit>	 Nemo_bis: doesn't sound too useful
[08:04:02] <wmf-selenium-bot>	 Yippie, build fixed!
[08:04:03] <wmf-selenium-bot>	 Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/4/
[08:12:25] <grrrit-wm>	 (03Abandoned) 10Hashar: Grant submit to JenkinsBot on integration/* [integration] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/74603 (owner: 10Hashar)
[08:12:55] <grrrit-wm>	 (03CR) 10Hashar: "Already applied" [integration] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/74603 (owner: 10Hashar)
[08:20:55] <Nemo_bis>	 Nikerabbit: why not? surely better than trying random test queries as we are asked now
[08:25:12] <grrrit-wm>	 (03PS3) 10Hashar: operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74124 
[08:25:17] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74124 (owner: 10Hashar)
[08:25:35] <Nemo_bis>	 (I have no idea what to try even in Italian)
[08:25:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: operations-dns-lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74124 (owner: 10Hashar)
[08:59:58] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Cleanup file metadata comment. - License blurb - Author line - Other attributes [extensions/SwarmExport] - 10https://gerrit.wikimedia.org/r/81635 
[09:02:02] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Cleanup file metadata comment. - License blurb - Author line - Other attributes [extensions/SwarmExport] - 10https://gerrit.wikimedia.org/r/81635 (owner: 10Daniel Friesen)
[09:04:03] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Other attributes [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/81636 
[09:05:25] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credit style [extensions/Negref] - 10https://gerrit.wikimedia.org/r/81637 
[09:06:42] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Other attributes [extensions/NamespacePaths] - 10https://gerrit.wikimedia.org/r/81638 
[09:07:32] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Other attributes - Path in credits [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/81639 
[09:08:51] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credits style [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/81640 
[09:09:36] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Other attributes [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/81643 
[09:10:15] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Other attributes [extensions/Description2] - 10https://gerrit.wikimedia.org/r/81644 
[09:11:55] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Link attribute - Fix broken extension url [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/81645 
[09:14:31] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - Author and license lines. [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/81646 
[09:15:29] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credits style [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/81647 
[09:15:38] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "(3 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger)
[09:17:15] <grrrit-wm>	 (03PS1) 10Daniel Friesen: Update p2wiki skin metadata and skin id handling. - Cleanup license blurb - Update author lines - Update other attributes - Cleanup credit style - Use a proper fixed 'p2wiki' for the skin name. [extensions/skins] - 10https://gerrit.wikimedia.org/r/81648 
[09:20:57] <grrrit-wm>	 (03CR) 10Nikerabbit: "I do not think this has ever worked with the built-in MediaWiki search. I haven't tested it works with Lucene." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/81601 (owner: 10Alex Monk)
[09:21:20] <grrrit-wm>	 (03CR) 10Hashar: "(2 comments)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[09:21:29] <grrrit-wm>	 (03PS8) 10Hashar: pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 
[09:21:48] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credits style [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/81647 (owner: 10Daniel Friesen)
[09:22:44] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - Author and license lines. [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/81646 (owner: 10Daniel Friesen)
[09:23:06] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Link attribute - Fix broken extension url [extensions/StarterWiki] - 10https://gerrit.wikimedia.org/r/81645 (owner: 10Daniel Friesen)
[09:23:40] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Other attributes [extensions/Description2] - 10https://gerrit.wikimedia.org/r/81644 (owner: 10Daniel Friesen)
[09:23:58] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Other attributes [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/81643 (owner: 10Daniel Friesen)
[09:24:33] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credits style [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/81640 (owner: 10Daniel Friesen)
[09:24:53] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Other attributes - Path in credits [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/81639 (owner: 10Daniel Friesen)
[09:25:14] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Other attributes [extensions/NamespacePaths] - 10https://gerrit.wikimedia.org/r/81638 (owner: 10Daniel Friesen)
[09:25:37] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Link attribute - Cleanup credit style [extensions/Negref] - 10https://gerrit.wikimedia.org/r/81637 (owner: 10Daniel Friesen)
[09:26:01] <grrrit-wm>	 (03CR) 10Daniel Friesen: [C: 032 V: 032] Update extension metadata. - License blurb - Author lines - Other attributes [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/81636 (owner: 10Daniel Friesen)
[09:26:48] <grrrit-wm>	 (03PS9) 10Hashar: pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 
[09:29:04] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "Calling $searchMySQL->supports( 'search-update' ) will return false causing to skip the update in SearchUpdate." [core] - 10https://gerrit.wikimedia.org/r/81492 (owner: 10Tobias Gritschacher)
[09:34:37] <grrrit-wm>	 (03CR) 10Hashar: "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[09:46:23] <grrrit-wm>	 (03CR) 10Merlijn van Deen: [C: 031] "I think we would run into the same problem as for just adapting the path to point at the externals directory - setuptools not recognising " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[09:48:44] <grrrit-wm>	 (03CR) 10Hashar: "Yup that should be fine. I am talking with mark about it in #wikimedia-operations will see if venv is acceptable." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[09:53:56] <Nikerabbit>	 hurrr
[10:03:46] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[10:22:44] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 031] Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis)
[10:25:26] <grrrit-wm>	 (03CR) 10Grunny: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 (owner: 10Grunny)
[10:32:46] <grrrit-wm>	 (03CR) 10Nemo bis: "I've never really managed to use it, but it seems it does work as of now: https://www.mediawiki.org/w/index.php?title=Special:Search&searc" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/81601 (owner: 10Alex Monk)
[10:39:05] <grrrit-wm>	 (03CR) 10Shirayuki: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[10:42:34] <grrrit-wm>	 (03PS1) 10Nikerabbit: Solr -> ElasticSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81655 
[11:04:48] <grrrit-wm>	 (03CR) 10Hashar: "I tried again by using:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[11:10:49] <grrrit-wm>	 (03CR) 10Raimond Spekking: "I just see this patch set: This extension is not translated on translatewiki.net due to missing message documentation. Would you like to a" [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/81643 (owner: 10Daniel Friesen)
[11:17:27] <zeljkof_>	 anybody knows is github-gerrit bot still active?
[11:17:44] <zeljkof_>	 how do I find this pull request in gerrit?
[11:17:48] <zeljkof_>	 https://github.com/wikimedia/qa-browsertests/pull/9
[11:18:09] <zeljkof_>	 I do not see it here https://gerrit.wikimedia.org/r/#/q/status:open+project:qa/browsertests,n,z
[11:20:57] <MatmaRex>	 zeljkof: ask YuviPanda_zz
[11:21:16] <MatmaRex>	 zeljkof: i think it's active, but currently only activated manually
[11:21:30] <MatmaRex>	 (doesn't synchronise all pull requests, only when explicitly run)
[11:21:31] <zeljkof>	 MatmaRex: thanks, found an e-mail from him about the bot, will ask him via e-mail
[11:25:42] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "This needs to be changed in a few other places as well, see the original change." [core] - 10https://gerrit.wikimedia.org/r/80435 (owner: 10TheDJ)
[11:30:19] <grrrit-wm>	 (03CR) 10Merlijn van Deen: "It seems packages *must* be installed as .egg - normal source distributions are not allowed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[11:37:10] <grrrit-wm>	 (03PS1) 10Rillke: Using "poll" as positioning method for first file input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81660 
[11:53:40] <grrrit-wm>	 (03PS2) 10Rillke: Using "poll" as positioning method for first file input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81660 
[11:58:32] <grrrit-wm>	 (03CR) 10Zfilipin: "Should this commit be abandoned here and moved to ULS repo?" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 (owner: 10Nikerabbit)
[13:49:36] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] "Code review -1 so I can see in my dashboard that I have reviewed this commit, and suggested it should be abandoned (and moved to ULS repo)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 (owner: 10Nikerabbit)
[13:52:03] <grrrit-wm>	 (03CR) 10AlephNull: "(bump)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull)
[13:56:22] <Nikerabbit>	 manybubbles: have you tried installing elasticsearch with the puppet module?
[13:56:49] <manybubbles>	 Nikerabbit: the one in wmf's repository or the other one?
[13:57:00] <manybubbles>	 Nikerabbit: the one in wmf's repository is how it is install everywhere
[13:57:14] <grrrit-wm>	 (03CR) 10Nikerabbit: "There is one test case which has not been migrated yet, hence I have not abandoned it yet." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 (owner: 10Nikerabbit)
[13:58:44] <Nikerabbit>	 manybubbles: dunno what wmf uses
[13:59:39] <manybubbles>	 Nikerabbit: I wrote it - it installs the deb, sets the hostname, and configures memory.  Just about nothing to it.
[13:59:40] <Nikerabbit>	 manybubbles: I've tried using https://github.com/electrical/puppet-elasticsearch
[13:59:59] <Nikerabbit>	 but it fails
[14:00:00] <Nikerabbit>	 Error: /Stage[main]/Elasticsearch::Service/Service[elasticsearch]: Could not evaluate: Could not find init script for 'elasticsearch'
[14:00:15] <Nikerabbit>	 I think I saw that error mentioned somewhere
[14:01:29] <manybubbles>	 hmmmm - I'm not sure I can help there.  We use the one I wrote and it doesn't see it.  we might could break that one off as a module for others to use more easilly.  right now it is a module, just not a subrepo.
[14:02:00] <grrrit-wm>	 (03CR) 10MarkAHershberger: "(2 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger)
[14:03:44] <Nikerabbit>	 manybubbles: well, arguably cirrussearch is not easier to install than lucene-search at the moment ;)
[14:04:45] <manybubbles>	 Nikerabbit: I take that criticism.  Is there a good puppet module for lucene search?
[14:07:14] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] make-release: notes are now in git [tools/release] - 10https://gerrit.wikimedia.org/r/81576 (owner: 10Hashar)
[14:07:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: make-release: notes are now in git [tools/release] - 10https://gerrit.wikimedia.org/r/81576 (owner: 10Hashar)
[14:10:52] <Nikerabbit>	 manybubbles: well, it's not fair comparison but lucene-search bundled the whole thing
[14:10:59] <Nikerabbit>	 only needed java
[14:17:37] <YuviPanda>	 hey zeljkof.  I made a lot of reliability improvements during wikimania, but forgot to turn it on because of my vacation after that ;)
[14:17:39] <YuviPanda>	 looking into it now
[14:18:24] <zeljkof>	 YuviPanda: thanks :)
[14:36:59] <Nikerabbit>	 manybubbles: I filed an issue there, let's see if that helps to make it work
[14:37:23] <grrrit-wm>	 (03PS2) 10MarkAHershberger: Add and use tarignore, add gitignore, clean up make-release and rename [tools/release] - 10https://gerrit.wikimedia.org/r/81619 
[14:40:58] <bd808>	 YuviPanda: Yeah! homedir rebuilt and much much faster! my `find` test is an order of magnitude faster.
[14:41:08] <YuviPanda>	 bd808: \o/
[14:41:24] <YuviPanda>	 bd808: do you use vagrant locally?
[14:41:37] <bd808>	 yes
[14:42:07] <YuviPanda>	 bd808: if so you might be interested in the multimedia-dragons instance (it now has a public ip, at blue-dragon.wmflabs.org)
[14:42:13] <YuviPanda>	 bd808: it is a labs instance setup via vagrant :)
[14:42:18] <YuviPanda>	 bd808: so much easier to setup / try stuff on
[14:42:29] <YuviPanda>	 bd808: currently showing my campaigns patch http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns
[14:42:49] <bd808>	 oooh cool
[14:43:09] <grrrit-wm>	 (03PS3) 10Hashar: SpecialPrefixindex formatting methods are now protected [core] - 10https://gerrit.wikimedia.org/r/75569 
[14:43:30] <grrrit-wm>	 (03CR) 10Hashar: "rebased" [core] - 10https://gerrit.wikimedia.org/r/75569 (owner: 10Hashar)
[14:45:21] <bd808>	 YuviPanda: My unicorn is there!
[14:45:28] <YuviPanda>	 bd808: tada! :D
[14:45:39] <YuviPanda>	 bd808: cd to /vagrant and vagrant is all there :)
[14:46:06] <YuviPanda>	 bd808: I had to make a few patches, but they're all merged into vagrant now
[14:46:14] <YuviPanda>	 bd808: exciting, since this makes setting up a new instance much easier
[14:46:26] <bd808>	 Nice. Ori was hoping that would be possible
[14:46:36] <YuviPanda>	 bd808: eventually I'll write a wikitech plugin for vagrant, so you can just *sync* your local vagrant instance to a labs instance
[14:46:44] <YuviPanda>	 but first this, I guess
[14:47:35] * bd808  schemes about user modules for setting up homedir + librarian-puppet for moar awesomesauce

[14:48:27] <bd808>	 I'm using github.com/boxen to manage my WMF laptop. Puppet is growing on me like fungus
[14:48:54] <YuviPanda>	 hahaha
[14:48:54] <YuviPanda>	 :D
[14:49:18] <YuviPanda>	 bd808: me too, yeah. I'm waiting for non-apple Haswell laptops to come out so I can ditch mine
[14:55:19] <grrrit-wm>	 (03PS1) 10Rachel99: mend [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81670 
[14:57:32] <grrrit-wm>	 (03CR) 10PleaseStand: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[14:57:59] <grrrit-wm>	 (03PS8) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 
[14:58:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[15:01:28] <grrrit-wm>	 (03PS9) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 
[15:07:37] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] "I see no way this could cause any harm." [core] - 10https://gerrit.wikimedia.org/r/80011 (owner: 10Liangent)
[15:11:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make FakeConverter more realistic [core] - 10https://gerrit.wikimedia.org/r/80011 (owner: 10Liangent)
[15:12:35] <grrrit-wm>	 (03CR) 10Seb35: "This change has no object because a non-secure cookie can be cleared by its corresponding secure cookie, unlike what I initially thought (" [core] - 10https://gerrit.wikimedia.org/r/81614 (owner: 10Seb35)
[15:15:01] <grrrit-wm>	 (03CR) 10Rillke: "@polling: Well, I actually do not know why it is mis-calculated sometimes. But here is how to reproduce:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81660 (owner: 10Rillke)
[15:20:47] <grrrit-wm>	 (03PS1) 10MarkAHershberger: gitignore [tools/release] - 10https://gerrit.wikimedia.org/r/81672 
[15:21:59] <grrrit-wm>	 (03Abandoned) 10Nikerabbit: Two scenarios for ULS settings live preview feature [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 (owner: 10Nikerabbit)
[15:26:26] <qgil>	 hashar, marktraceur hi, I was going through https://gerrit.wikimedia.org/r/#/admin/projects/?filter=integration looking for the projects we develop (as oposed to upstream)
[15:26:44] <qgil>	 and I came with this: https://wikitech.wikimedia.org/wiki/User:Qgil/Supported_projects#Integration
[15:26:52] <qgil>	 do you agree hashar marktraceur ?
[15:26:59] <hashar>	 nop
[15:27:08] <qgil>	 good, can you fix it?  :)
[15:27:14] <hashar>	 neither :]
[15:27:17] <hashar>	 list is https://www.mediawiki.org/wiki/Continuous_integration/Git_repositories
[15:27:21] <hashar>	 though it needs an update hehe
[15:27:37] <hashar>	 I will do that right now there is a few missing
[15:28:07] <qgil>	 hashar, "integration/gruntjs
[15:28:07] <qgil>	     A copy of upstream gruntjs software."
[15:28:26] <qgil>	 hashar, I'm leaving copies of upstream projects. I'm looking for the projects *we* develp
[15:29:47] <hashar>	 ahh
[15:29:53] <hashar>	 will add (fork)  next to the title :-]
[15:30:00] <hashar>	 or mirror
[15:30:01] <grrrit-wm>	 (03PS1) 10Rillke: Parse mwe-upwiz-tooltip-skiptutorial containing link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 
[15:30:35] <qgil>	 hashar, does that repo have the hole Grunt or just our diff?
[15:30:54] <qgil>	 hashar, all this is for the community metrics. 
[15:31:09] <hashar>	 that is a copy
[15:31:20] <qgil>	 hashar, then we can leave it out for the community metrics
[15:31:26] <hashar>	 we use to be able to deploy grunt on our servers without relying on ops
[15:31:58] <hashar>	 I have added fork/mirror where relevant
[15:32:17] <hashar>	 the most active ones are integration/zuul-config and integration/jenkins-job-builder-config
[15:33:03] <qgil>	 hashar, those were already listed at https://wikitech.wikimedia.org/wiki/User:Qgil/Supported_projects#Integration
[15:35:03] <Rtdwivedi>	 Hi! I need a bit of help.
[15:35:36] <Rtdwivedi>	  I am using the ArticleViewCustom hook. It works fine when I go to a page for the first time but it doesn't get called when I refresh the page.
[15:36:02] <Rtdwivedi>	 I mean the function related to the hook doesn't get called. Is that expected behavior?
[15:43:21] <p858snake|l>	 I seem to be getting a lot of page loads without css atm
[15:47:51] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[15:48:00] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "That's because SearchMySQL overwrites the supports() method. None of the other search engines (e.g. SearchSqlite, etc..) do that, so I gue" [core] - 10https://gerrit.wikimedia.org/r/81492 (owner: 10Tobias Gritschacher)
[15:53:40] <Rtdwivedi>	 umm, anyone?
[15:56:57] <legoktm>	 Rtdwivedi: are your pages cached?
[15:57:20] <Rtdwivedi>	 It happens in incognito mode as well.
[15:57:40] <legoktm>	 is there server side caching? what happens if you add ?action=purge to the url
[15:59:06] <Rtdwivedi>	 I get the desired output.
[16:00:00] <legoktm>	 ok, somewhere in your setup, the page output is being cached
[16:00:16] <legoktm>	 so the hook is working fine, just that the page is not being re-rendered each refresh.
[16:00:41] <Rtdwivedi>	 Oh Thanks!
[16:02:10] <grrrit-wm>	 (03PS1) 10Hashar: standardize pep8 jobs for mw extensions (+pyflakes) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81679 
[16:06:24] <grrrit-wm>	 (03PS1) 10Hashar: pyflakes jobs for some mediawiki extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81680 
[16:06:46] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] pyflakes jobs for some mediawiki extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81680 (owner: 10Hashar)
[16:06:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: pyflakes jobs for some mediawiki extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81680 (owner: 10Hashar)
[16:15:01] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[16:21:25] <grrrit-wm>	 (03CR) 10Alex Monk: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[16:26:01] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Remove visualEditor.standalone RL dependency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81631 (owner: 10Spage)
[16:26:08] <grrrit-wm>	 (03CR) 10Matthias Mullie: [V: 032] Remove visualEditor.standalone RL dependency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81631 (owner: 10Spage)
[16:26:20] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[16:29:31] <grrrit-wm>	 (03CR) 10Alex Monk: "The current code (before this change) will only work until CirrusSearch takes over as the default search backend. At the moment mediawiki." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/81601 (owner: 10Alex Monk)
[16:31:43] <grrrit-wm>	 (03PS2) 10EBernhardson (WMF): fix missing MWEchoDbFactory::getDB() call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81628 (owner: 10Spage)
[16:33:11] <grrrit-wm>	 (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh)
[16:33:27] <grrrit-wm>	 (03PS3) 10Ori.livneh: Add 'RedisPubSubFeedEngine' feed engine [core] - 10https://gerrit.wikimedia.org/r/80958 
[16:35:23] <wmf-selenium-bot>	 Yippie, build fixed!
[16:35:24] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #269: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/269/
[16:36:46] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] fix missing MWEchoDbFactory::getDB() call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81628 (owner: 10Spage)
[16:51:44] <grrrit-wm>	 (03PS1) 10EBernhardson (WMF): Fix compatability with php5.3.3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81682 
[17:04:07] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81660 (owner: 10Rillke)
[17:04:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Using "poll" as positioning method for first file input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81660 (owner: 10Rillke)
[17:12:26] <grrrit-wm>	 (03PS1) 10Ori.livneh: Clean up legacy protect.js & remove from .jshintignore [core] - 10https://gerrit.wikimedia.org/r/81684 
[17:12:41] <grrrit-wm>	 (03CR) 10Brian Wolff: "Re parent: I think it could be useful to distinguish between "This file has no metadata" and "It would be impossible for a file of this ty" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[17:19:39] <Nikerabbit>	 manybubbles: you have ubuntu packages for elasticsearch?
[17:19:59] <grrrit-wm>	 (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[17:20:01] <manybubbles>	 Nikerabbit: elasticsearch distributes deb packages, yes
[17:20:48] <Nikerabbit>	 manybubbles: I'n not too familiar with packaging, is it easy to set those up in ubuntu?
[17:21:26] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81685 
[17:22:27] <ori-l>	 Nikerabbit: download the .deb and sudo dpkg -i filename.deb
[17:23:28] <Nikerabbit>	 ori-l: hmm okay... though that doesn't seem to be easy to automate with puppet
[17:24:21] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update NavigationTming to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81686 
[17:24:59] <grrrit-wm>	 (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[17:25:54] <Nikerabbit>	 at least not with my skills
[17:26:00] <grrrit-wm>	 (03PS1) 10Jack Phoenix: FanBoxes: fixed to be compatible w/ MW 1.21. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/81687 
[17:26:16] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] FanBoxes: fixed to be compatible w/ MW 1.21. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/81687 (owner: 10Jack Phoenix)
[17:26:41] <grrrit-wm>	 (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[17:26:43] <ori-l>	 Nikerabbit: use the 'dpkg' package provider
[17:27:20] <ori-l>	 package { 'elasticsearch': provider => dpkg, ensure => latest, source => '/path/to/debfile.deb', }
[17:28:10] <Nikerabbit>	 ori-l: and where to put the dep file?
[17:28:38] <grrrit-wm>	 (03PS1) 10Jack Phoenix: SocialProfile: changes for FanBoxes compatibility. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/81688 
[17:28:55] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: changes for FanBoxes compatibility. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/81688 (owner: 10Jack Phoenix)
[17:28:57] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "Restoring -1 from PS1 after rebase madness ;)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[17:29:17] <Nikerabbit>	 I mean, I can just place it anywhere, but that kind of defeats the automation
[17:32:02] <Nikerabbit>	 it's 16MB... doesn't feel good putting that inside the git repo
[17:32:38] <marktraceur>	 git-annex time
[17:32:48] <marktraceur>	 cc greg-g - how's that coming? :)
[17:33:16] <Nikerabbit>	 marktraceur: hmm was that to me?
[17:33:22] <marktraceur>	 Yeah
[17:33:34] <grrrit-wm>	 (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[17:33:42] <marktraceur>	 Nikerabbit: joeyh is working on a project called git-annex, which is better for big files in git than vanilla-git
[17:33:56] <marktraceur>	 greg-g uses it and IIRC plans to use it for deploying big files
[17:34:28] <ori-l>	 marktraceur: I think Nikerabbit was talking about the conceptual confusion of mixing deployment script with software packages in the same repo
[17:34:41] <greg-g>	 Nikerabbit: if you haven't taken a look, it's pretty sweet/perfect for managing large files in a real way
[17:34:47] <greg-g>	 what ev.
[17:34:50] <marktraceur>	 ori-l: 2013-08-29 - 10:10:17  <YuviPanda> marktraceur: and perhaps, over time, you will also agree that putting HTML/CSS/JS on a mobile phone as its major 'platform' is a stupid technical decision :P
[17:34:54] <marktraceur>	 2013-08-29 - 10:10:39  <marktraceur> YuviPanda: Are you kidding!? The only thing that would work better is Wikitext.
[17:34:57] <marktraceur>	 Agh
[17:34:58] * marktraceur  cannot copy things

[17:35:04] <marktraceur>	 ori-l: 2013-08-29 - 10:30:33  <Nikerabbit> it's 16MB... doesn't feel good putting that inside the git repo
[17:36:11] <marktraceur>	 I can see why both are possible, just explaining why I thought that :)
[17:37:56] <Nikerabbit>	 I guess I should check how it is done for WMF
[17:38:42] <Reedy>	 Add the WMF repos as an apt source
[17:39:18] <Nikerabbit>	 Reedy: that could work, are they public?
[17:39:35] <Reedy>	 http://apt.wikimedia.org/
[17:41:08] <ori-l>	 Nikerabbit: i'm not sure this is better, but..
[17:41:13] <grrrit-wm>	 (03PS1) 10Mwalker: eNETS is a SG Method [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/81690 
[17:41:28] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032 V: 032] eNETS is a SG Method [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/81690 (owner: 10Mwalker)
[17:41:37] <GorillaWarfare>	 mwalker|away: You around?
[17:41:59] <Nikerabbit>	 ..bunnies?
[17:43:10] <ori-l>	 exec { 'fetch elasticsearch': command => 'rm -f /tmp/elasticsearch-0.90.3.deb && wget -O - https://download.elasticsearch.org/elasticsearch/elasticsearch/elasticsearch-0.90.3.deb | tee /tmp/elasticsearch-0.90.3.deb | md5sum - | grep -q 211fad3f1a7f886caf99bfef35f470f6', unless => 'md5sum /tmp/elasticsearch-0.90.3.deb | grep -q 211fad3f1a7f886caf99bfef35f470f6', before => Package['elasticsearch'], }
[17:43:26] <ori-l>	 i'm probably going to puppet hell for that
[17:43:39] * YuviPanda  sends ori-l to puppet hell

[17:43:50] <Nikerabbit>	 ori-l: I think I've seen those ugly things
[17:43:56] <Nikerabbit>	 if they work....
[17:43:59] <Nikerabbit>	 ...bunnies!
[17:44:23] <ori-l>	 sounds like a plan
[17:45:43] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite)
[17:46:37] <marktraceur>	 ori-l: To be fair, puppet hell sounds like a lot of fun
[17:46:46] <grrrit-wm>	 (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[17:46:51] <marktraceur>	 Oh, the configuration management system, not like, muppets
[17:48:10] <grrrit-wm>	 (03CR) 10Mollywhite: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite)
[17:48:25] <grrrit-wm>	 (03PS3) 10Krinkle: doc: Remove repetitive "Give grep a chance" phrase from comments [core] - 10https://gerrit.wikimedia.org/r/81440 
[17:48:52] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Updating headers in Echo.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81524 (owner: 10Kaldari)
[17:50:17] <mwalker>	 GorillaWarfare: yep yep -- so long as IRC doesn't kick me off again for no apparent reason
[17:50:30] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Run unit tests for SemanticMaps and Serialization [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80767 
[17:50:37] <GorillaWarfare>	 mwalker: Just hoping to clarify your comment about creating a function and binding to it
[17:50:38] <Nemo_bis>	 Nikerabbit: for our pan?
[17:50:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating headers in Echo.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81524 (owner: 10Kaldari)
[17:50:52] <Nemo_bis>	 I thought we had already had our meat dose
[17:51:01] <Nikerabbit>	 uga
[17:51:04] <GorillaWarfare>	 mwalker: Do you mean create a function and then call bind()?
[17:52:02] <mwalker>	 mostly; create a function; and then call .on( 'click', function )
[17:53:20] <mwalker>	 mostly just attach the handler at create time
[17:53:39] <GorillaWarfare>	 mwalker: Oh, ok
[17:54:07] <GorillaWarfare>	 Thanks :)
[17:54:32] <marktraceur>	 mwalker: Points for using on() and not bind()
[17:55:14] <marktraceur>	 GorillaWarfare: Beware the ides of deprecated jquery functions
[17:55:39] <mwalker>	 marktraceur: I lost points because of my habit of excessive repetition of 'mostly'
[17:55:44] <mwalker>	 so I came out neutral
[17:55:51] <marktraceur>	 mwalker: Well, mostly neutral.
[17:56:17] <GorillaWarfare>	 marktraceur: Well that's what I'd asked, because I thought he meant to use bind(), and saw on() was preferred
[17:56:29] <marktraceur>	 Arright
[17:56:58] <grrrit-wm>	 (03PD7) 10AndyRussG: Dynamic tour modification via TourController [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/81546 
[17:57:09] <marktraceur>	 PD?
[17:57:11] <marktraceur>	 The hell is PD
[17:57:22] <marktraceur>	 Whoa
[17:57:27] <marktraceur>	 What the HELL is up with that patch
[17:57:46] <GorillaWarfare>	 Er, which?
[17:57:54] <marktraceur>	 https://gerrit.wikimedia.org/r/81546
[17:58:04] <marktraceur>	 Suddenly, patchset 7
[17:58:05] <GorillaWarfare>	 Oh, not one of mine
[17:58:12] <marktraceur>	 No no
[17:58:15] <GorillaWarfare>	 Oh, that is weird
[17:58:43] <marktraceur>	 ^d: Why does that patch only have PS7? Is it tracking draft patchsets or something?
[17:59:16] <^d>	 Yep, must have older drafts you can't see ;-)
[17:59:20] <marktraceur>	 Weird.
[17:59:20] <grrrit-wm>	 (03PS6) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[17:59:21] <grrrit-wm>	 (03PS8) 10Brian Wolff: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 
[17:59:22] <grrrit-wm>	 (03PS3) 10Brian Wolff: Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 
[17:59:27] <GorillaWarfare>	 mwalker: So some of the remove buttons are added dynamically, and some of them are there from the getgo. What should I do to bind to the existing ones?
[17:59:29] <^d>	 marktraceur: Well, I can see them ;-)
[17:59:42] <marktraceur>	 Well aren't *you* special
[17:59:57] <marktraceur>	 I mean, yeah. You're an admin.
[18:00:28] <mwalker>	 GorillaWarfare: you have an 'init' function that runs at the beginning -- that's where you use your original $('#...').on('click', ...) thing
[18:00:50] <grrrit-wm>	 (03CR) 10Brian Wolff: "PS3: fix the unset, and Bryan's comment about dead code" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[18:01:05] <GorillaWarfare>	 Oh, ok
[18:01:11] <grrrit-wm>	 (03CR) 10Brian Wolff: "PS8: Anomie's whitespace concerns" [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[18:05:42] <grrrit-wm>	 (03CR) 10AndyRussG: "This is really a draft. Comments would be fantastic, though, of course." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/81546 (owner: 10AndyRussG)
[18:07:21] <YuviPanda>	 anyone know where ResultWrapper is in?
[18:07:46] <bawolff>	 DatabaseUtility.php I think
[18:08:21] <YuviPanda>	 bawolff: thank you
[18:08:25] * YuviPanda  murmurs about one class per file

[18:08:42] <bawolff>	 If in doubt, you can always look it up in AutoLoader.php
[18:08:47] <YuviPanda>	 aaah, right
[18:08:49] <YuviPanda>	 good tip
[18:10:09] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "Still have things to do. Last patch was the result of changing a patch that this one depended on (I hate dependant patchsets...)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[18:12:29] <bawolff>	 marktraceur: In your comment on https://gerrit.wikimedia.org/r/#/c/78926/1/includes/media/FormatMetadata.php - which part do you mean scares you? not using () after the new operator?
[18:12:38] <marktraceur>	 Yeah
[18:12:47] <marktraceur>	 Gives me the heebie-jeebies
[18:12:50] * bawolff  can add some brackets

[18:12:59] <marktraceur>	 Naw, it's all right
[18:13:23] <DanielK_WMDE>	 YuviPanda: your IDE should tell you (ctrl-n in PHPStorm). If all else fails: grep -R 'class ResultWrapper' *
[18:13:34] <DanielK_WMDE>	 (or use ack-grep, much nicer and faster)
[18:13:37] <YuviPanda>	 DanielK_WMDE: Vim doesn't, sadly.
[18:13:44] <DanielK_WMDE>	 YuviPanda: then don't use it.
[18:13:46] <DanielK_WMDE>	 seriously.
[18:13:47] <YuviPanda>	 DanielK_WMDE: yeah, I was about to ack, but asked anyway :)
[18:13:53] <DanielK_WMDE>	 that kind of thing kosts hours every day.
[18:14:02] <DanielK_WMDE>	 costs, even
[18:14:13] <DanielK_WMDE>	 I bet vim can be made into a full IDE. Then to that. 
[18:14:18] <YuviPanda>	 DanielK_WMDE: I can use Vim with anything, anywhere, no?
[18:14:28] <DanielK_WMDE>	 but using a plain editor for a project the size of mediawiki is a horrible waste of time.
[18:14:40] * bawolff  thinks in the long run I save time using vim

[18:14:41] <YuviPanda>	 DanielK_WMDE: plus the speed/efficiency I get in my actual text editing probably offsets that
[18:14:45] <YuviPanda>	 +1 to bawolff
[18:14:58] <YuviPanda>	 DanielK_WMDE: plus I've ctrl-p, which does wonderfully fast autocompletion for files. 
[18:15:30] <DanielK_WMDE>	 i have autocompletion for files, classes, methods, constants.. :)
[18:15:35] <bawolff>	 More then anything else, it forces me to do certain things the hard way, which results in me having a better understanding of what I'm doing (or at least I like to think so, this all could be shameless self-justification)
[18:15:38] <DanielK_WMDE>	 and ctrl-click to go to the declaration of anything.
[18:15:45] <DanielK_WMDE>	 and alt-f7 to find all usages of anything.
[18:15:47] <YuviPanda>	 bawolff: that sounds like self-justification :P
[18:16:12] <YuviPanda>	 DanielK_WMDE: does it have a proper Vim mode?
[18:16:16] <DanielK_WMDE>	 YuviPanda: not arguing against vim as an editor. just saying it's a waste not to make use of actual ide fe3atures. which do exist for vim too, i'm sure
[18:16:17] <YuviPanda>	 using arrow keys to move around is so eugh.
[18:16:40] <YuviPanda>	 DanielK_WMDE: true, true. I've ack integrated into vim, so find usage, etc is easy enough.
[18:16:41] <legoktm>	 YuviPanda: get a mouse then ;)
[18:16:54] <DanielK_WMDE>	 YuviPanda: http://plugins.jetbrains.com/plugin/164
[18:16:55] <YuviPanda>	 just that I'm used to doing ',p<classname>' to find things :)
[18:16:56] <DanielK_WMDE>	 yes, it does
[18:17:14] <YuviPanda>	 DanielK_WMDE: I use that in intelliJ. It's not too usable.
[18:17:46] <YuviPanda>	 DanielK_WMDE: but you're right, I should investigate some sortof similar functionality for php.
[18:17:48] <DanielK_WMDE>	 YuviPanda: this sounds like a good start: http://joncairns.com/2012/05/using-vim-as-a-php-ide/
[18:17:51] <YuviPanda>	 I bet ctagsc can do tha tproperly.
[18:18:30] * YuviPanda  reads

[18:18:31] <DanielK_WMDE>	 or http://www.koch.ro/blog/?archives/63-VIM-an-a-PHP-IDE.html
[18:18:31] <YuviPanda>	 thanks DanielK_WMDE
[18:18:35] <DanielK_WMDE>	 \o/
[18:18:36] <YuviPanda>	 I've until 4 covered already
[18:18:56] <YuviPanda>	 it's a bit outdated - syntastic is much better for doing the linting and stuff
[18:19:11] <DanielK_WMDE>	 yea, i bet there's more, and better, and newer.
[18:19:37] <DanielK_WMDE>	 i'm just saying, using an actual ide is worth some effort. whether you learn phpstorm or tweak vim.
[18:20:09] <bawolff>	 only feature I really miss from an IDE at the moment is an integrated spell checker
[18:20:13] <bawolff>	 as my spelling is horrid
[18:20:26] <DanielK_WMDE>	 phpstorm has that
[18:20:52] <DanielK_WMDE>	 it'S useful to be able to say whether it should be applied to identifiers, or only in comments, etc
[18:21:22] <ori-l>	 if you have to jump around the codebase eighteen times to understand how a function gets called, that's a problem with your codebase, not your editor
[18:21:23] <DanielK_WMDE>	 vim has spell checking, but i don't know whether it has a php-aware spell checker
[18:21:40] <bawolff>	 Sometimes, I do git show, and then run it through aspell, but that's not a very good method
[18:21:41] <ori-l>	 i find IDEs enable bad habits
[18:21:50] * bawolff  should learn how to use vim properly too ;)

[18:22:01] <DanielK_WMDE>	 ori-l: i find texteditors enforce bad habits (like huge classes and files)
[18:22:32] <ori-l>	 DanielK_WMDE: yes, i suppose that's a fair counterpoint :P
[18:22:52] <bawolff>	 Conclusion: Making programs enforces bad habits
[18:23:36] <DanielK_WMDE>	 :)
[18:23:40] <DanielK_WMDE>	 http://c2.com/cgi/wiki?FearOfAddingClasses
[18:23:52] <YuviPanda>	 bawolff: you can easily set that up vim, y'know :)
[18:24:11] <YuviPanda>	 bawolff: do you have your vimrc up somewhere?
[18:24:30] <bawolff>	 no, but its not very customized
[18:25:23] <YuviPanda>	 (https://dl.dropboxusercontent.com/u/8768784/.vimrc is mine, if other people have tips)
[18:36:39] <YuviPanda>	 Is there a way I can make a dbkey out of a text thing?
[18:36:52] <YuviPanda>	 'Uploaded by UploadWizard' to Uploaded_by_UploadWizard?
[18:37:44] <Reedy>	 s/ /_/
[18:37:54] <YuviPanda>	 pfft
[18:38:01] <YuviPanda>	 Reedy: anything less barbaric?
[18:38:05] <bawolff>	 YuviPanda: on the php side, that's pretty easy
[18:38:27] <YuviPanda>	 bawolff: so... just str_replace?
[18:38:44] <Reedy>	 	public function getPrefixedDBkey() {
[18:38:44] <Reedy>	 		$s = $this->prefix( $this->mDbkeyform );
[18:38:44] <Reedy>	 		$s = str_replace( ' ', '_', $s );
[18:38:44] <Reedy>	 		return $s;
[18:38:44] <Reedy>	 	}
[18:38:46] <bawolff>	 On the php side, I'd suggest Title::newFromText( $input )->getDBKey()
[18:40:21] * bawolff  wonders what happened to gerrit-wm...

[18:40:43] <^d>	 Replaced with grrrit-wm :)
[18:40:48] <YuviPanda>	 is that not working?
[18:40:50] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Replace "e-mail" by "email" [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/80701 (owner: 10Shirayuki)
[18:41:00] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Replace "e-mail" by "email" [extensions/PageCreationNotif] - 10https://gerrit.wikimedia.org/r/80700 (owner: 10Shirayuki)
[18:41:01] <YuviPanda>	 bawolff: it seems to work? :)
[18:41:06] <^d>	 grrrit-wm is working. gerrit-wm doesn't exist anymore :p
[18:41:15] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Replace "e-mail" by "email" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80699 (owner: 10Shirayuki)
[18:41:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace "e-mail" by "email" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80699 (owner: 10Shirayuki)
[18:41:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Replace "e-mail" by "email" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/80697 (owner: 10Shirayuki)
[18:41:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace "e-mail" by "email" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/80697 (owner: 10Shirayuki)
[18:41:33] <YuviPanda>	 yeah, less things for ^d to not-maintain-and-ignore :P
[18:41:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Replace "e-mail" by "email" [extensions/LookupUser] - 10https://gerrit.wikimedia.org/r/80696 (owner: 10Shirayuki)
[18:41:43] <bawolff>	 YuviPanda: Well I just comitted something and it didn't seem to do anything
[18:41:54] <YuviPanda>	 bawolff: to which repo?
[18:41:57] <Aaron|home>	 roblaAWAY: https://bugzilla.wikimedia.org/show_bug.cgi?id=43331 (ahh, there it is)
[18:41:58] <YuviPanda>	 bawolff: perhaps it is routed elsewhere?
[18:41:58] <bawolff>	 oh never mind
[18:42:06] <bawolff>	 I should read the output on console
[18:42:08] <bawolff>	 error: failed to push some refs to 'ssh://bawolff@gerrit.wikimedia.org:29418/mediawiki/core.git'
[18:42:10] <YuviPanda>	 bawolff: :P
[18:42:18] <bawolff>	 what happens when i forget to git commit --amend
[18:43:15] <grrrit-wm>	 (03PS7) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 
[18:44:45] <grrrit-wm>	 (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[18:45:09] <grrrit-wm>	 (03PS6) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[18:45:14] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Use the long PHP tag [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/80387 (owner: 10Shirayuki)
[18:45:16] <YuviPanda>	 bawolff: ^ uses categorylinks directly.
[18:45:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Use the long PHP tag [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/80391 (owner: 10Shirayuki)
[18:45:30] <YuviPanda>	 bawolff: also categorylinks uses pageid while most other tables seem to use ns:title :(
[18:45:44] <bawolff>	 huh?
[18:45:54] <bawolff>	 Most tables use page_id unless the page might not exist
[18:46:01] <MatmaRex>	 YuviPanda: tables use pageid when they require a page to exist, and title when they don't, afaik
[18:46:10] <MatmaRex>	 ah, foiled.
[18:46:30] <YuviPanda>	 hmm?
[18:46:43] <MatmaRex>	 (this is of course a major pain in the ass when you, for example, want to parse the "what links here" sql dumps)
[18:46:56] <YuviPanda>	 okay, my surveying of the tables is almost 2 years old (when I did ShortUrl)
[18:47:03] <YuviPanda>	 but that sortof makes sense, but doesn't make it any less a pain.
[18:47:35] <Wikinaut>	 Ryan_Lane: *ping*
[18:47:47] <Wikinaut>	 Ryan_Lane: Hi. I have something for you (but need your help; we can discuss on -dev, if you like) https://gerrit.wikimedia.org/r/#/c/81629/
[18:47:57] <bawolff>	 YuviPanda: might be more efficient to join on the page table
[18:48:10] <YuviPanda>	 bawolff: hmm?
[18:48:21] <YuviPanda>	 bawolff: for the campaign stuff?
[18:48:24] <bawolff>	 instead of doing an extra db query for every page
[18:48:46] * YuviPanda  looks at ImageGalleryBase

[18:49:24] <bawolff>	 you might also want to consider adding the condition cl_type = 'file', which won't be indexed, but if you assume its all images in your tracking category, that's probably ok
[18:49:40] <YuviPanda>	 bawolff: oh, I didn't realize newFromID did a select
[18:49:48] <YuviPanda>	 grumblegrumblegrumble
[18:49:51] * YuviPanda  goes to fix

[18:50:08] <YuviPanda>	 bawolff: I think it's okay, yeah.
[18:51:09] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update GettingStarted to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81702 
[18:52:19] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update GettingStarted to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81704 
[18:52:52] <grrrit-wm>	 (03PS1) 10Nemo bis: Add CleanChanges extension [tools/release] - 10https://gerrit.wikimedia.org/r/81706 
[18:54:11] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77686 (owner: 10Siebrand)
[18:55:07] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81707 
[18:55:30] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81707 (owner: 10MaxSem)
[18:57:16] <grrrit-wm>	 (03Abandoned) 10Reedy: Update GettingStarted to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81702 (owner: 10Ori.livneh)
[18:57:20] <Reedy>	 ori-l: ^
[18:57:57] <ori-l>	 13's over?
[18:58:03] <ori-l>	 we hardly knew ye
[18:59:18] <grrrit-wm>	 (03Abandoned) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81685 (owner: 10Ori.livneh)
[19:00:01] <ori-l>	 whose window is it now?
[19:00:07] <ori-l>	 mobile or platform?
[19:00:59] <Reedy>	 still my window technically
[19:01:08] <grrrit-wm>	 (03PS7) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[19:01:09] <YuviPanda>	 bawolff: ^
[19:01:34] <YuviPanda>	 bawolff: although weirdly,  gallery comes up with 'unable to find image'
[19:01:36] <ori-l>	 Reedy: if you're done i could just sync those two JS changes to wmf14 and forfeit our two hour window
[19:01:38] <Reedy>	 Also: Enable CodeEditor for JS/CSS on all wikis
[19:03:07] <YuviPanda>	 bawolff: it says 'file missing' even though clicking through takes me to the file.
[19:03:12] <YuviPanda>	 bawolff: am I using ImageGallery wrong?
[19:03:19] <Reedy>	 anomie: greg-g for ^ is that just set to wmgUseCodeEditorForCore by default?
[19:03:45] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update GettingStarted to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81704 (owner: 10Ori.livneh)
[19:03:51] <anomie>	 Reedy: That sounds about right to me, yeah.
[19:04:03] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update NavigationTming to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81686 (owner: 10Ori.livneh)
[19:04:29] <grrrit-wm>	 (03CR) 10Siebrand: [V: 032] Fix double-comma [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/80786 (owner: 10Shirayuki)
[19:04:48] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Spell check [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/80551 (owner: 10Shirayuki)
[19:05:08] <ori-l>	 Reedy: nice, thanks
[19:05:56] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Give grep a chance to find the usages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/79565 (owner: 10Shirayuki)
[19:06:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Give grep a chance to find the usages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/79559 (owner: 10Shirayuki)
[19:06:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Give grep a chance to find the usages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/79552 (owner: 10Shirayuki)
[19:06:23] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Give grep a chance to find the usages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79551 (owner: 10Shirayuki)
[19:06:42] <MatmaRex>	 https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=570702111&oldid=570700424 wat.
[19:06:57] <MatmaRex>	 the first sentence has gotta be the dumbest thing i've read today.
[19:07:04] <MatmaRex>	 (the rest is the second dumbest.)
[19:07:16] <ori-l>	 greg-g: Reedy synced our changes, so we don't need our window at all
[19:07:29] <YuviPanda>	 MatmaRex: you've not been reading much of what he(?) says, have you? :)
[19:07:44] <MatmaRex>	 YuviPanda: thankfully i only have VPT on my watchlist
[19:08:02] <YuviPanda>	 heh :)
[19:08:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Give grep a chance to find the usages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79551 (owner: 10Shirayuki)
[19:11:14] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Simplify right-* messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/78921 (owner: 10Shirayuki)
[19:11:30] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 (owner: 10Shirayuki)
[19:11:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 (owner: 10Shirayuki)
[19:12:52] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 (owner: 10Shirayuki)
[19:13:11] <grrrit-wm>	 (03PS1) 10Jack Phoenix: LinkFilter: version 3.0 - modernization & general fixes. [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/81714 
[19:13:27] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] LinkFilter: version 3.0 - modernization & general fixes. [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/81714 (owner: 10Jack Phoenix)
[19:14:20] <Krenair>	 MatmaRex, haha oh wow.
[19:14:28] <Krenair>	 MatmaRex, you should read his user profile page as well
[19:14:37] <Krenair>	 C/C++/Java programmer
[19:15:00] <MatmaRex>	 please no, i still have some faith in humanity left
[19:15:39] <Krenair>	 Also he lists under travel locations 'Great Britain' next to a UK flag
[19:16:32] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[19:17:53] <grrrit-wm>	 (03PS8) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[19:18:48] <YuviPanda>	 marktraceur: I took the Ip address from alpha for dragins (http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns) 
[19:19:15] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[19:20:08] <marktraceur>	 YuviPanda: I thought you wrote some magic to host multiple domains off of one public IP?
[19:20:21] <YuviPanda>	 marktraceur: it's awaiting packaging and deployment.
[19:20:26] <YuviPanda>	 marktraceur: hopefully next week
[19:21:02] <grrrit-wm>	 (03PS1) 10Nemo bis: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81800 
[19:21:13] <grrrit-wm>	 (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[19:21:19] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[19:21:48] <grrrit-wm>	 (03CR) 10Brian Wolff: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[19:22:56] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-2] "That is needed to configure pep8 :-D" [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:23:37] <grrrit-wm>	 (03PS1) 10Nemo bis: Add CleanChanges extension for Ib873d079d [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81825 
[19:23:50] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81679 (owner: 10Hashar)
[19:24:38] <grrrit-wm>	 (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[19:24:57] <grrrit-wm>	 (03PS9) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[19:25:28] <grrrit-wm>	 (03PS10) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[19:25:58] <MatmaRex>	 ugh
[19:26:09] <MatmaRex>	 don't we really have generic messages for 'Yes' and 'No' in core? D:
[19:26:29] <marktraceur>	 MatmaRex: I'd imagine we keep adding new ones because they could mean different things in different contexts
[19:26:33] <MatmaRex>	 ah, we do
[19:26:39] <MatmaRex>	 'htmlform-no', 'htmlform-yes'
[19:26:55] <MatmaRex>	 actually, this is supposed to be for questions
[19:27:03] <marktraceur>	 Buttons indicating a response are different from text indicating a status, for example
[19:27:19] * marktraceur  imagines a language somewhere has that distinction

[19:27:52] <MatmaRex>	 yeah, i see the point
[19:28:02] <MatmaRex>	 still bloody annoying. meh.
[19:28:23] <marktraceur>	 MatmaRex: Well, we try to be good about that sort of thing :)
[19:29:00] <MatmaRex>	 https://translatewiki.net/wiki/Template:Identical/Yes
[19:29:06] <MatmaRex>	 that's a lot of yeses.
[19:29:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: standardize pep8 jobs for mw extensions (+pyflakes) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81679 (owner: 10Hashar)
[19:32:07] <grrrit-wm>	 (03PS1) 10Hashar: trigger pep8/pyflakes on tox.ini|.pep8 change [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81828 
[19:32:14] <YuviPanda>	 brion: more changes! http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns is now actually reverse-chronological, and doesn't kill the DB!
[19:32:20] <brion>	 \o/
[19:32:22] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] trigger pep8/pyflakes on tox.ini|.pep8 change [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81828 (owner: 10Hashar)
[19:32:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: trigger pep8/pyflakes on tox.ini|.pep8 change [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81828 (owner: 10Hashar)
[19:32:46] <YuviPanda>	 brion: the default text for the CTA seems to suck, though. any other suggestions?
[19:32:52] <YuviPanda>	 StevenW: ^
[19:33:14] <brion>	 YuviPanda: as a default "have related media? upload!" is probably fine… but it should def be customizable
[19:33:26] <brion>	 maybe we could have a few defaults and rotate them :)
[19:33:38] <YuviPanda>	 brion: customizable by the campaign JSON itself, perhaps?
[19:33:54] <brion>	 yep
[19:33:56] <grrrit-wm>	 (03CR) 10Hashar: "recheck" [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:34:02] <YuviPanda>	 brion: but I'm a bit wary of that. You know what happens when you give them too many customization options :)
[19:34:20] <YuviPanda>	 brion: also, i'm happy with the current gallery format ('packed-overlay'), and don't think I should make that customizable per-campaign
[19:34:28] <grrrit-wm>	 (03PS4) 10Mollywhite: Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 (owner: 10Shirayuki)
[19:34:57] <bawolff>	 YuviPanda: One thing when I was looking at your example, I think it'd look prettier if the images in the gallery were bigger
[19:35:00] <grrrit-wm>	 (03CR) 10Mollywhite: [C: 032 V: 032] "Rebased" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 (owner: 10Shirayuki)
[19:35:06] <sumanah>	 btw YuviPanda & brion - do you want this Campaign stuff in the weekly Tech News yet? :)
[19:35:08] <YuviPanda>	 bawolff: sure. probably.
[19:35:12] <sumanah>	 I presume it's useful for WLM?
[19:35:12] <grrrit-wm>	 (03CR) 10Hashar: "The tox.ini file is needed to ignore some rules in pep8. Not sure what you wanted to achieve there :)" [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:35:16] <bawolff>	 defaults a little small (which I suppose is my fault. I didn't want to change the old default)
[19:35:26] <brion>	 uh-oh it's the press!
[19:35:28] <YuviPanda>	 bawolff: you've a suggestion for a newer number?
[19:35:43] * sumanah  is paparazzi

[19:35:45] <YuviPanda>	 sumanah: it was already in the signpost report. I don't mind it being in tech news, as long as there's no date affixed :)
[19:35:48] <bawolff>	 height and width of 180px maybe
[19:36:02] <YuviPanda>	 bawolff: doing
[19:36:09] <brion>	 bawolff: zoom on hover? …. slider to adjust size live? 
[19:36:16] * brion  comes up with wild and crazy ideas

[19:36:17] <bawolff>	 default is 120px which is tiny
[19:36:49] <YuviPanda>	 bawolff: hmm, where do I change that?
[19:36:53] * YuviPanda  rummages around code

[19:36:56] <bawolff>	 brion: Even better, lightbox on click that marktraceur is working on :P
[19:37:06] <marktraceur>	 Muahahaha.
[19:37:06] <brion>	 bawolff: yes, that one goes without saying :)
[19:37:21] * marktraceur  should get back to that

[19:37:23] <MatmaRex>	 bawolff: lightbox?
[19:37:24] <grrrit-wm>	 (03PS1) 10Matmarex: Show whether tags are active on Special:Tags [core] - 10https://gerrit.wikimedia.org/r/81830 
[19:37:29] <MatmaRex>	 bawolff: you're gonna cause some havoc. :D
[19:37:29] <YuviPanda>	 bawolff: also, how do I get rid of the 'file size' stuff?
[19:37:40] <bawolff>	 YuviPanda: the setWidths and setHeights method of image gallery
[19:38:05] <bawolff>	 YuviPanda: $ig->setShowBytes( false );
[19:38:10] <marktraceur>	 MatmaRex: Havoc? We've had nothing but good vibrations about the idea and the mockups (well, except for the details) - do you know of some dark corner of Wikipedians that will be unhappy about it?
[19:38:19] <grrrit-wm>	 (03CR) 10Bsitu: "There is another patch trying to fix this instead: https://gerrit.wikimedia.org/r/#/c/81529/, I'd rather keep it for now since the shadow " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81502 (owner: 10Matmarex)
[19:38:23] <grrrit-wm>	 (03CR) 10J: [C: 031] Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff)
[19:38:24] <bawolff>	 marktraceur: Don't tempt fate
[19:38:24] <brion>	 MatmaRex: https://en.wikipedia.org/wiki/Lightbox_%28JavaScript%29
[19:38:26] <YuviPanda>	 bawolff: ah, was looking at add
[19:38:34] <brion>	 it'll be fun :D
[19:38:59] <YuviPanda>	 bawolff: that looks nicer!
[19:39:23] <grrrit-wm>	 (03PS11) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[19:39:30] <MatmaRex>	 marktraceur: enwiki, but of course only after it's deployed. :D
[19:39:55] <marktraceur>	 MatmaRex: Well, we're being careful and making it opt-in :)
[19:39:56] <YuviPanda>	 bawolff: brion http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns
[19:39:58] <YuviPanda>	 do a hard refresh
[19:40:03] <bawolff>	 When I try to convince commons to change the default gallery, I should try and get them to change the default width/height to
[19:40:13] <brion>	 pooh they're bigger
[19:40:16] <brion>	 *oooh
[19:40:22] <bawolff>	 lol
[19:40:26] <brion>	 oh bother!
[19:40:34] <grrrit-wm>	 (03PS2) 10Matmarex: ext.echo.badge: Remove defunct CSS rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81502 
[19:40:51] <bawolff>	 hmm, I wonder if switching the gallery would cause any ops problem, with suddenly a lot of images being requested at a different size
[19:41:09] <YuviPanda>	 brion: bawolff now I need to check if this goes into parsercache
[19:41:11] <YuviPanda>	 that'll be horrible
[19:41:17] <grrrit-wm>	 (03CR) 10Matmarex: "Personally I'd prefer shadowless, there are precisely zero shadows in all of the default skins. But whatever floats designers' boats ;)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81502 (owner: 10Matmarex)
[19:41:49] <grrrit-wm>	 (03CR) 10Hashar: "Bah you mixed in the long line fixes from pep8 which make this patch slightly uglier :(" [tools/release] - 10https://gerrit.wikimedia.org/r/81619 (owner: 10MarkAHershberger)
[19:41:56] <bawolff>	 YuviPanda: Don't see no "Saved in cache with cache key"
[19:42:18] <bawolff>	 Try putting the current user name in it, then viewing it as an anon, and check if the username updates
[19:42:19] <YuviPanda>	 brion: bawolff: so, I'm thinking it needs UX work for CTA and some profiling. anything else before this can be merged?
[19:42:50] <bawolff>	 If it doesn't get put into the parser cache, it perhaps needs some caching :P (profiling will tell that)
[19:42:51] <bawolff>	 probably
[19:42:54] <YuviPanda>	 yeah
[19:43:05] <YuviPanda>	 memcached should be good enough
[19:43:14] <YuviPanda>	 as in, just the wikitext parsing
[19:43:16] <YuviPanda>	 nothing more
[19:43:29] <brion>	 yeah i _think_ this is in output that's separate from the parsed wiki page, so not in parser cache
[19:43:35] <brion>	 could easily be cached separately of course
[19:44:09] <bawolff>	 YuviPanda: You might want to consider adding the uploader's name to the caption of the photo
[19:44:20] <YuviPanda>	 brion: I was thinking 'uploaded from'
[19:44:24] <grrrit-wm>	 (03CR) 10J: [C: 032 V: 031] Fixes bug 43747 by removing z-index on menu [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/81570 (owner: 10Mdale)
[19:44:35] <YuviPanda>	 err
[19:44:37] <YuviPanda>	 bawolff: ^
[19:44:39] <YuviPanda>	 err
[19:44:40] <YuviPanda>	 i mean
[19:44:43] <grrrit-wm>	 (03CR) 10J: [V: 032] Fixes bug 43747 by removing z-index on menu [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/81570 (owner: 10Mdale)
[19:44:46] <YuviPanda>	 'uploaded X days ago'
[19:44:48] <YuviPanda>	 etc?
[19:44:56] * brion  wonders if the gallery flips order properly in RTL user language

[19:45:03] <YuviPanda>	 bawolff: also, how do you determine uploader? 
[19:45:13] <YuviPanda>	 bawolff: just user who has last edit? or first edit?
[19:45:14] <bawolff>	 You can join on image table
[19:45:23] <YuviPanda>	 image table gives me last edited.
[19:45:35] <brion>	 i'd put that sort of info in a detail popup
[19:45:40] <brion>	 no need to pull it on the join imo
[19:45:45] <YuviPanda>	 hmm, +1
[19:45:50] <grrrit-wm>	 (03CR) 10MarkAHershberger: "I liked the long line checks." [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:46:11] <bawolff>	 image table should not give you last edited, it should be last person to upload (via img_user)
[19:46:41] <YuviPanda>	 bawolff: yeah, that's what I meant.
[19:46:43] <bawolff>	 if you're going to include timestamps in the caption, you should probably also use img_timestamp for the display, not cl_timestamp, since vandalism can reset the cl_timestamp
[19:46:47] <YuviPanda>	 bawolff: so if I crop someone else's pic and then put that there...
[19:46:56] <YuviPanda>	 bawolff: it shows as me than the other person
[19:47:01] <grrrit-wm>	 (03PS1) 10Ori.livneh: Check attribute ordering only after loadEventEnd [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81846 
[19:47:03] <YuviPanda>	 bawolff: hmm, true. Best skip all that in the initial patch :P
[19:47:10] <YuviPanda>	 MVP!
[19:47:12] <bawolff>	 Arguably, you're displaying the other person's image
[19:47:23] <bawolff>	 yeah don't want to get too crazy at first
[19:47:47] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Revert "Localisation updates from http://translatewiki.net." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/81847 
[19:47:49] <bawolff>	 If you really want, you can also look in oldimage table, and try and find first uploader
[19:47:49] <grrrit-wm>	 (03CR) 10Hashar: "Well since you remove tox.ini pep8 is no more instructed to look at the make-release file, thus that disable pep8 entirely... not very hel" [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:47:59] <YuviPanda>	 bawolff: it's something I want for mobile apps too, but not right now
[19:48:01] <YuviPanda>	 brion: ^
[19:48:32] <YuviPanda>	 bawolff: there's currently no APi method that i can ask 'give me all the images I've uploaded to commons, except deleted ones, redirect the moved ones, even if someone has uploaded an image on top of it'
[19:48:47] <brion>	 YuviPanda: clearer ownership of files? yeah that's a tricky one
[19:48:58] <grrrit-wm>	 (03PS1) 10Manybubbles: Stop using backlink cache for link counts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 
[19:49:05] <bawolff>	 YuviPanda: however, Special:listfiles can now do that (as of yesterday. The patch took three months to get reviewed)
[19:49:09] <brion>	 we need to figure out a sane way for it to look on the outside and the inside :P
[19:49:11] <YuviPanda>	 hah!
[19:49:15] <YuviPanda>	 bawolff: API!
[19:49:19] <YuviPanda>	 bawolff: also API for randomincategory :)
[19:49:28] <bawolff>	 oh forgot the randomcategory one
[19:49:31] <bawolff>	 adding to todo list
[19:49:54] <YuviPanda>	 brion: suggestions for the CTA?
[19:50:08] <grrrit-wm>	 (03CR) 10MarkAHershberger: "I didn't realize that -- I told you I was new to python -- my editor was running it for me." [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:50:10] <bawolff>	 Adding the special:listfiles functionality to API seems PITA (it was a PITA to do it for the special page)
[19:50:18] <grrrit-wm>	 (03PS2) 10Manybubbles: Stop using backlink cache for link counts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 
[19:50:36] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: gitignore [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[19:50:40] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[19:51:13] <brion>	 YuviPanda: 'Got more photos like these?' / 'Contribute them!' ?
[19:51:27] <YuviPanda>	 brion: hmm, and I can make them customizable at a per-campaign level
[19:51:30] <YuviPanda>	 and that should be good too
[19:52:05] <brion>	 and then we can devise a sane UI for editing campaign data :D
[19:52:05] <YuviPanda>	 brion: also, the 'view all contributed media' looks lonely and sad and whatnot
[19:52:12] <brion>	 like clicking on something and editing it and hitting enter
[19:52:14] <YuviPanda>	 brion: pfft. people don't really care :P
[19:52:21] <YuviPanda>	 brion: yet, at least.
[19:52:22] <brion>	 yeah, our users adapt to all kinds of shit :)
[19:52:25] <grrrit-wm>	 (03PS3) 10MarkAHershberger: Add and use tarignore, add gitignore, clean up make-release [tools/release] - 10https://gerrit.wikimedia.org/r/81619 
[19:52:26] <grrrit-wm>	 (03PS1) 10Manybubbles: Turn tests for link count updates back on. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81850 
[19:52:38] <brion>	 and then whine when we make it better ;)
[19:52:42] <YuviPanda>	 brion: in fact, if you let the JSON editing stay on for a year, and then take it away, there will perhaps be a shitstorm :P
[19:52:49] <brion>	 :)
[19:52:53] <YuviPanda>	 brion: 'if you cannot edit JSON, do we really want you adminstering campaigns?'
[19:53:18] <brion>	 haha
[19:53:21] <multichill>	 YuviPanda: Romaine is our campaign master anyway ;-0
[19:53:31] <YuviPanda>	 multichill: :D true, true
[19:54:02] <YuviPanda>	 multichill: I still need to do the final stuff for the WLM app :(
[19:54:06] <YuviPanda>	 got distracted by this
[19:54:15] <multichill>	 https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&limit=500&days=30&namespace=460 <- lol
[19:54:28] <multichill>	 I also need to finish the admin levels and some other things
[19:55:15] <grrrit-wm>	 (03CR) 10J: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[19:58:31] <YuviPanda>	 multichill: hehe, lots of Romaine
[19:59:08] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Makes sense, verified locally." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81846 (owner: 10Ori.livneh)
[19:59:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check attribute ordering only after loadEventEnd [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/81846 (owner: 10Ori.livneh)
[19:59:53] <grrrit-wm>	 (03CR) 10Hashar: "I am fine guiding you through the arcane of python linting check. We can talk about it next week if you want :)" [tools/release] - 10https://gerrit.wikimedia.org/r/81672 (owner: 10MarkAHershberger)
[20:01:41] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81853 
[20:01:48] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81854 
[20:02:04] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81853 (owner: 10Ori.livneh)
[20:02:16] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81854 (owner: 10Ori.livneh)
[20:08:51] <MatmaRex>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=53556 heh
[20:09:07] <grrrit-wm>	 (03PS12) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[20:10:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update NavigationTiming to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81853 (owner: 10Ori.livneh)
[20:11:07] <YuviPanda>	 brion: okay, updated.
[20:11:14] <YuviPanda>	 brion: thoughts on merging? or do you want me to do a profiling first?
[20:11:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update NavigationTiming to master [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81854 (owner: 10Ori.livneh)
[20:12:08] <brion>	 YuviPanda: i'd recommend a quick profile comparison against existing Category: pages
[20:12:14] <YuviPanda>	 brion: alright. 
[20:12:24] <brion>	 if it's not issuing more queries than the categories already are, then we should think about caching the output
[20:12:44] <brion>	 i forget offhand if category page display has caching logic or if we leave that to the http layer
[20:13:07] <YuviPanda>	 brion: hmm, right.
[20:13:16] <YuviPanda>	 brion: also, 50 seems like a large number of images to show.
[20:13:21] <YuviPanda>	 25, perhaps
[20:13:52] <YuviPanda>	 brion: also, even to just cache the output of parsedConfig, it will need to vary on lang
[20:13:53] <YuviPanda>	 ugh
[20:13:59] <brion>	 \o/
[20:14:32] <brion>	 welcome to 'and this is why all UI should be done in javascript from language-independent API data' ;)
[20:14:42] <brion>	 course it may be a while before we reach such a utopia ;)
[20:14:54] <YuviPanda>	 brion: :D 
[20:16:28] <YuviPanda>	 brion: eugh, l10n cache does a lot of queries.
[20:16:50] <brion>	 grep -v is your friend
[20:17:03] <YuviPanda>	 brion: nah, I'm using the mediawiki debug toolbar :D
[20:17:04] <YuviPanda>	 pretty sweet
[20:17:44] <YuviPanda>	 brion: heh, 227 queries for Category page, 156 for campaign page
[20:17:47] <YuviPanda>	 with same set of images
[20:18:02] <brion>	 woohoo
[20:18:04] <YuviPanda>	 brion: most of it is because the gallery code doesn't batch selects.
[20:18:25] <YuviPanda>	 i'm going to run an explain to make sure this stuff is indexed right
[20:18:47] <grrrit-wm>	 (03PS5) 10Rjain: Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 
[20:19:14] <YuviPanda>	 |  1 | SIMPLE      | categorylinks | ref    | cl_from,cl_sortkey,cl_timestamp | cl_sortkey | 258     | const,const                |   37 | Using where; Using filesort |
[20:19:16] <YuviPanda>	 brion: ^
[20:19:20] <YuviPanda>	 is that using a bad filesort?
[20:19:21] <brion>	 file sort! oh nooooooo
[20:19:30] <YuviPanda>	 however
[20:19:33] <YuviPanda>	 if I get rid of an extra where
[20:19:33] <YuviPanda>	 |  1 | SIMPLE      | categorylinks | ref    | cl_from,cl_sortkey,cl_timestamp | cl_timestamp | 257     | const                      |   37 | Using where |
[20:19:40] <brion>	 YuviPanda: can you paste bin or gist the whole query & result?
[20:19:50] <grrrit-wm>	 (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77686 (owner: 10Siebrand)
[20:19:50] <YuviPanda>	 doing
[20:19:51] <brion>	 moment need MOAR CAFFEINE brb
[20:20:18] <YuviPanda>	 brion: https://dpaste.de/9yqDe/raw/
[20:22:25] <grrrit-wm>	 (03CR) 10Rjain: "mw.loader.using is working, I don't know what happened earlier :/" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain)
[20:22:48] <brion>	 ok lemme double-check cl_sortkey
[20:22:54] <YuviPanda>	 brion: ot
[20:22:56] <YuviPanda>	 err
[20:23:00] <YuviPanda>	 brion: it's not even in the query
[20:23:23] <brion>	 ok the cl_sortkey index is: CREATE INDEX /*i*/cl_sortkey ON /*_*/categorylinks (cl_to,cl_type,cl_sortkey,cl_from);
[20:23:23] <YuviPanda>	 brion: and I'm new to this kinda thing :) Should finish reading that book I have on query optimization...
[20:23:47] <YuviPanda>	 brion: yeah, but there's CREATE INDEX /*$wgDBprefix*/cl_timestamp ON /*$wgDBprefix*/categorylinks(cl_to,cl_timestamp); 
[20:23:52] <YuviPanda>	 brion: shouldn't this trigger that?
[20:24:21] <YuviPanda>	 brion: hmm, so if I get rid of the cl_type=file, things are in order
[20:24:21] <brion>	 YuviPanda: your where clause is hitting cl_to and cl_type so it's hitting cl_sortkey index by default
[20:24:30] <brion>	 yeah
[20:24:42] <YuviPanda>	 brion: hmm, so can I use cl_type = file and force it to use the timestamp index?
[20:24:46] <brion>	 you could force the index to the other one, see how that goes…. but that still might not be ideal
[20:24:48] <brion>	 try :D
[20:24:50] <brion>	 oh
[20:25:04] <brion>	 you could also switch 'cl_type='file'' from where to 'having' clause
[20:25:11] <brion>	 um, if we support that in our framework
[20:25:13] <brion>	 and it's standard
[20:25:14] <brion>	 i forget
[20:25:16] <YuviPanda>	 having without a group by?
[20:25:24] <YuviPanda>	 really? that sounds retarded.
[20:25:27] <YuviPanda>	 but then, this is mysql...
[20:25:31] * brion  learned sql 12 years ago, mysql was a silly place then :D

[20:25:54] <brion>	 so iirc 'having' clause is like 'where' but applied after all the selection and sorting logic
[20:26:10] <brion>	 so the rows that don't match still get processed, but they get discarded at the end
[20:26:29] <brion>	 in our case that's fine since items that don't match 'file' will be rare/nonexistent
[20:26:39] <brion>	 or...
[20:26:53] <brion>	 you could just drop it from the query entirely and do the filtering for type as a check in your client code
[20:27:38] <grrrit-wm>	 (03PS1) 10Ori.livneh: Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] - 10https://gerrit.wikimedia.org/r/81856 
[20:27:43] <ori-l>	 ^ Krenair
[20:27:52] <ori-l>	 haven't tested yet
[20:28:37] <ori-l>	 note that '$prefix' was just getting thrown on the floor
[20:29:17] <grrrit-wm>	 (03CR) 10Matmarex: [C: 032] "This was extremely boring to go through." [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[20:29:58] <YuviPanda>	 brion: true, I could do either
[20:30:50] <YuviPanda>	 brion: explain SELECT cl_from,page_namespace,page_title FROM `categorylinks` INNER JOIN `page` ON ((cl_from=page_id)) WHERE cl_to = 'Uploaded_via_Campaign:wlm-nl' ORDER BY cl_timestamp DESC HAVING cl_type='file' LIMIT 50 ; isn't legal?
[20:31:50] <greg-g>	 ori-l: noted, thanks
[20:31:51] <brion>	 hm
[20:31:56] <greg-g>	 (sorry, was at lunch with a cousin)
[20:32:09] <ori-l>	 greg-g: i have to retract that anyhow :P
[20:32:25] <greg-g>	 wha?!
[20:32:29] <greg-g>	 ok
[20:32:31] <greg-g>	 :)
[20:32:39] <brion>	 aha
[20:32:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: doc: Remove repetitive "Give grep a chance" phrase from comments [core] - 10https://gerrit.wikimedia.org/r/81440 (owner: 10Krinkle)
[20:32:45] <brion>	 YuviPanda: having goes before order by
[20:32:53] <brion>	 see if that actually works tho :)
[20:33:29] <YuviPanda>	 brion: ERROR 1054 (42S22): Unknown column 'cl_type' in 'having clause'
[20:33:30] <brion>	 https://dev.mysql.com/doc/refman/5.6/en/select.html <- ok it says the having is *applied* right before sending to client, but it in the *syntax* goes before sort
[20:33:31] <brion>	 motherfucker
[20:33:40] <YuviPanda>	 brion: I don't know if HAVING will work without group by?
[20:33:47] <brion>	 YuviPanda: oh it has to be in the selected columns
[20:33:56] <brion>	 ' The SQL standard requires that HAVING must reference only columns in the GROUP BY clause or columns used in aggregate functions. However, MySQL supports an extension to this behavior, and permits HAVING to refer to columns in the SELECT list and columns in outer subqueries as well. '
[20:33:57] <brion>	 ugh
[20:34:03] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Simplified some code and broke lines in thumb.php [core] - 10https://gerrit.wikimedia.org/r/81860 
[20:34:06] <brion>	 postgres folks will hate us if we use having
[20:34:08] <YuviPanda>	 cl_from,cl_sortkey,cl_timestamp
[20:34:11] <YuviPanda>	 |  1 | SIMPLE      | categorylinks | ref    | cl_from,cl_sortkey,cl_timestamp | cl_timestamp | 257     | const                      |   37 | Using where |
[20:34:13] <brion>	 nothing works without group by there ;)
[20:34:14] <YuviPanda>	 brion: \o/
[20:34:18] <brion>	 woohoo
[20:34:29] <YuviPanda>	 brion: this all makes me feel very queasy though ;(
[20:34:33] <YuviPanda>	 brion: can i try force index?
[20:35:06] <Krenair>	 ori-l, the old code was $address = $address ? $address : $wgRC2UDPAddress; $prefix = $prefix ? $prefix : $wgRC2UDPPrefix; $port = $port ? $port : $wgRC2UDPPort;
[20:35:07] <brion>	 YuviPanda: try the force index yeah
[20:35:12] <brion>	 but i forget offhand how to do that portably :)
[20:35:36] <brion>	 if in doubt, retreat to the client-side filter. it should be ok perf-wise and will make the query optimizer not freak out
[20:35:53] <YuviPanda>	 brion: true
[20:35:54] <ori-l>	 Krenair: ok, I'll change to that to make the diff easier to verify
[20:37:47] <grrrit-wm>	 (03PS2) 10Ori.livneh: Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] - 10https://gerrit.wikimedia.org/r/81856 
[20:37:53] <ori-l>	 Krenair: ^
[20:38:58] <Krenair>	 ori-l, well the change looks okay already
[20:39:09] <Krenair>	 I just think it's better to return to the exact original behaviour
[20:39:16] <ori-l>	 i already did
[20:39:19] <ori-l>	 check PS2
[20:39:40] <grrrit-wm>	 (03PS1) 10Mattflaschen: Bump GuidedTour for E3 deployment [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81862 
[20:39:41] <grrrit-wm>	 (03PS1) 10Reedy: Update Wikibase to head of mw1.22-wmf14 branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81863 
[20:40:11] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Latest master" [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81862 (owner: 10Mattflaschen)
[20:40:19] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] - 10https://gerrit.wikimedia.org/r/81856 (owner: 10Ori.livneh)
[20:40:25] <ori-l>	 Isarra: if you're actually IRCing as root and your identd isn't a joke, don't
[20:40:36] <YuviPanda>	 brion: weird.
[20:40:38] <YuviPanda>	 brion: SELECT cl_from,page_namespace,page_title FROM `categorylinks` INNER JOIN `page` ON ((cl_from=page_id)) FORCE INDEX (cl_timestamp) WHERE cl_to = 'Uploaded_via_Campaign:wlm-nl' AND cl_type = 'file' ORDER BY cl_timestamp DESC LIMIT 50 
[20:40:38] <Krenair>	 ori-l, +2'd
[20:40:43] <YuviPanda>	 is erroring out
[20:40:47] <YuviPanda>	 brion: and that's generated by mediawiki
[20:41:13] <grrrit-wm>	 (03PS1) 10CSteipp: Remove prefix from forceHTTPS cookie [core] - 10https://gerrit.wikimedia.org/r/81864 
[20:41:33] <brion>	 hmm
[20:41:40] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-chrome build #282: FAILURE in 7 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/282/
[20:41:56] <grrrit-wm>	 (03PS1) 10Ori.livneh: Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81865 
[20:42:37] <YuviPanda>	 brion: ah, SELECT cl_from,page_namespace,page_title FROM `categorylinks` FORCE INDEX (cl_timestamp) INNER JOIN `page` ON ((cl_from=page_id)) WHERE cl_to = 'Uploaded_via_Campaign:wlm-nl' AND cl_type = 'file' ORDER BY cl_timestamp DESC LIMIT 50	 works
[20:42:43] <ori-l>	 Krenair: can you +2 the cherry-pick to wmf15 too? https://gerrit.wikimedia.org/r/#/c/81865/
[20:43:03] <YuviPanda>	 brion: aaand https://dpaste.de/YBfHn/ :)
[20:43:07] <brion>	 \o/
[20:43:10] <Krenair>	 ori-l: Um, no.
[20:43:14] * brion  was just looking at https://dev.mysql.com/doc/refman/5.1/en/join.html and came to same conclusion :D

[20:43:17] <ori-l>	 oh, right. sorry.
[20:43:23] <YuviPanda>	 brion: heh :D
[20:43:28] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81865 (owner: 10Ori.livneh)
[20:43:29] <Aaron|home>	 ori-l: why didn't you use "a ?: b" ? :)
[20:43:29] <brion>	 YuviPanda: woot, looks good
[20:43:34] <YuviPanda>	 brion: let me commit
[20:43:57] <ori-l>	 Aaron|home: I reproduced the previous code verbatim
[20:44:19] <grrrit-wm>	 (03PS13) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[20:44:30] <YuviPanda>	 brion: done!
[20:45:05] <YuviPanda>	 brion: i'm going to look at the queries being done one more time, and then look at caching behavior
[20:45:11] <brion>	 ok
[20:45:34] <YuviPanda>	 brion: i guess this can be merged after that?
[20:45:46] <brion>	 i'd say so yeah
[20:46:21] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase to head of mw1.22-wmf14 branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81863 (owner: 10Reedy)
[20:46:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump GuidedTour for E3 deployment [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81862 (owner: 10Mattflaschen)
[20:47:08] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem)
[20:48:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] - 10https://gerrit.wikimedia.org/r/81856 (owner: 10Ori.livneh)
[20:50:05] <YuviPanda>	 brion:' Article::view using parser cache: no '
[20:50:06] <YuviPanda>	 so that's good
[20:50:14] <brion>	 whee
[20:50:21] <grrrit-wm>	 (03PS1) 10Manybubbles: Carefully replace aliases to prevent duplicates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81866 
[20:50:24] <brion>	 'no worse than existing code' is always the bar to meet ;)
[20:50:35] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove prefix from forceHTTPS cookie [core] - 10https://gerrit.wikimedia.org/r/81864 (owner: 10CSteipp)
[20:50:54] <wmf-selenium-bot>	 Yippie, build fixed!
[20:50:54] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #141: FIXED in 5 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/141/
[20:51:05] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Test for removing the contents of <audio> tags. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81609 (owner: 10Manybubbles)
[20:51:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem)
[20:51:33] <grrrit-wm>	 (03PS3) 10Chad: Test for searching incategory:"". [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81612 (owner: 10Manybubbles)
[20:51:43] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Test for searching incategory:"". [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81612 (owner: 10Manybubbles)
[20:52:12] <YuviPanda>	 brion: so, without adding a cache, we'll have to do 4 pieces of wikitext parsing on each page view
[20:52:21] <YuviPanda>	 brion: not counting anons, who I guess will get the HTMl cached version
[20:52:24] <YuviPanda>	 brion: I... think that's okay?
[20:52:30] <grrrit-wm>	 (03CR) 10Chad: [C: 04-1] "Has an unrelated change included." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[20:52:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fill in defaults for omitted parameters to RecentChange::sendToUDP [core] (wmf/1.22wmf15) - 10https://gerrit.wikimedia.org/r/81865 (owner: 10Ori.livneh)
[20:52:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Solr -> ElasticSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81655 (owner: 10Nikerabbit)
[20:53:00] <brion>	 YuviPanda: hmm….
[20:53:07] <brion>	 probably ok for our envisioned usage
[20:53:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test for removing the contents of <audio> tags. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81609 (owner: 10Manybubbles)
[20:53:48] <YuviPanda>	 brion: the parser cache parses the *output*, right?
[20:54:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test for searching incategory:"". [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81612 (owner: 10Manybubbles)
[20:54:21] <YuviPanda>	 brion: err, *caches* the output, not parses
[20:54:45] <brion>	 right
[20:54:56] <Athyria>	 ori-l: It's a joke.
[20:55:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Solr -> ElasticSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81655 (owner: 10Nikerabbit)
[20:55:35] <YuviPanda>	 brion: great part? no JS! :D
[20:55:41] <brion>	 hehe
[20:55:54] <grrrit-wm>	 (03PS3) 10MaxSem: Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 
[20:56:14] <YuviPanda>	 brion: can you do a security review? I think I've XSS and SQLInjecction mostly covered
[20:56:17] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem)
[20:56:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove prefix from forceHTTPS cookie [core] - 10https://gerrit.wikimedia.org/r/81864 (owner: 10CSteipp)
[20:56:51] <grrrit-wm>	 (03CR) 10Manybubbles: "Sneaky subrepo, where did you come from?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[20:56:52] <brion>	 YuviPanda: looked ok but i'll take a second look yes :D
[20:56:56] <YuviPanda>	 brion: okay!
[20:57:00] <YuviPanda>	 brion: this looks like we can merge it today!
[20:57:07] <brion>	 woot
[20:57:12] <grrrit-wm>	 (03PS1) 10CSteipp: Remove prefix from forceHTTPS cookie [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81867 
[20:58:01] <ori-l>	 Krenair: seems to have fixed it
[20:58:30] <Krenair>	 phew
[20:58:57] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 031] "I'm ready to merge this, any last minute concerns not already expressed?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[20:59:46] <YuviPanda>	 brion: need to add qqq :)
[20:59:54] <YuviPanda>	 brion: also, is the 'view all uploaded' link fine?
[20:59:56] <marktraceur>	 Oh my god that patch totally breaks UploadWizard in the Goflubrian language!
[20:59:59] * marktraceur  is kidding

[21:00:05] <marktraceur>	 Nobody cares about the Goflubrians
[21:00:08] <YuviPanda>	 marktraceur: 0JS patch!
[21:00:16] <brion>	 ;_;
[21:00:25] <grrrit-wm>	 (03PS3) 10Manybubbles: Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 
[21:00:34] <ori-l>	 Krenair: you almost had the full WMF experience there; you just needed people screaming at you on village pump to go along with the exceptions :D
[21:00:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem)
[21:00:48] <grrrit-wm>	 (03CR) 10Manybubbles: "Accidental subrepo banished!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[21:01:20] <Krenair>	 ori-l: haha
[21:01:35] <grrrit-wm>	 (03PS4) 10Chad: Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[21:01:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[21:02:21] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove prefix from forceHTTPS cookie [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81867 (owner: 10CSteipp)
[21:02:31] <manybubbles>	 ^d: does it only work if I use Bug: NNN?
[21:02:35] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Use srbackend=LuceneSearch on search form [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/81601 (owner: 10Alex Monk)
[21:02:48] <^d>	 Maybe. I'm mildly OCD about commit messages :p
[21:02:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ignore incategory:"" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81615 (owner: 10Manybubbles)
[21:02:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove prefix from forceHTTPS cookie [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81867 (owner: 10CSteipp)
[21:02:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use srbackend=LuceneSearch on search form [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/81601 (owner: 10Alex Monk)
[21:03:10] <grrrit-wm>	 (03PS2) 10Himeshi: Added generating pages with page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/80863 
[21:03:11] <^d>	 Go go gerrit mergetool!
[21:05:21] <grrrit-wm>	 (03PS1) 10Hashar: operations-debs-wikistats-phplint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81869 
[21:06:13] <grrrit-wm>	 (03PS2) 10Chad: Support search update for MySQL search engine [core] - 10https://gerrit.wikimedia.org/r/81492 (owner: 10Tobias Gritschacher)
[21:08:01] <grrrit-wm>	 (03PS1) 10Hashar: operations-debs-wikistats-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81870 
[21:08:07] <YuviPanda>	 brion: ugh, also needs to show something when there's no images.
[21:08:11] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] operations-debs-wikistats-phplint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81869 (owner: 10Hashar)
[21:08:13] <YuviPanda>	 grrr, edge cases
[21:08:29] <brion>	 heh yes
[21:08:37] <grrrit-wm>	 (03CR) 10Dzahn: [C: 031] "thank you, as requested :)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81869 (owner: 10Hashar)
[21:08:47] <grrrit-wm>	 (03PS2) 10Chad: Carefully replace aliases to prevent duplicates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81866 (owner: 10Manybubbles)
[21:08:53] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] operations-debs-wikistats-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81870 (owner: 10Hashar)
[21:09:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: operations-debs-wikistats-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81870 (owner: 10Hashar)
[21:09:45] <manybubbles>	 ^d: I'll use the : from now on then.  Also the gerrit merge tool is nice.
[21:11:09] <YuviPanda>	 brion: hmm, if there's no images yet, should the CTA still be there?
[21:11:18] <YuviPanda>	 'got more photos like these?' makes no sense at that point :P
[21:11:28] <brion>	 YuviPanda: well we could have an alternate cta
[21:11:34] <YuviPanda>	 hmm, yes.
[21:11:37] <brion>	 'no photos here yet, want to be the first?'
[21:11:39] <brion>	 or something
[21:11:44] <YuviPanda>	 hmm, right
[21:11:48] <YuviPanda>	 and that can have the button on the same line
[21:11:52] <YuviPanda>	 let me do that
[21:12:32] <brion>	 same line is always dangerous… wrapping, left/right, does it fit in a sentence or is it separate?
[21:12:37] <brion>	 separate line is safer ;)
[21:12:46] <YuviPanda>	 brion: pfft, alright.
[21:12:46] <grrrit-wm>	 (03CR) 10Nikerabbit: "Nobody should be using non-TUX in twn at this point." [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 (owner: 10Shirayuki)
[21:15:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "looks sane....." [core] - 10https://gerrit.wikimedia.org/r/81492 (owner: 10Tobias Gritschacher)
[21:16:40] <grrrit-wm>	 (03PS9) 10BryanDavis: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[21:18:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support search update for MySQL search engine [core] - 10https://gerrit.wikimedia.org/r/81492 (owner: 10Tobias Gritschacher)
[21:19:11] <grrrit-wm>	 (03CR) 10BryanDavis: "Fixed doh! error that J spotted and added a couple really simple tests." [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff)
[21:49:07] <manybubbles>	 ^d: what is the name of the version of mediawiki that CirrusSearch is compatible with?
[21:49:17] <^d>	 master!
[21:49:18] <^d>	 :)
[21:49:27] <^d>	 Whatever master is. 1.22alpha?
[21:49:30] <^d>	 Something like that.
[21:50:19] <manybubbles>	 cool.  whatever we have in production
[21:57:04] <grrrit-wm>	 (03CR) 10Chad: "So, this won't work well. The worst case scenario of a count(*) on pagelinks is upwards of 22 seconds for enwiki (used Wikipedia:Sandbox, " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles)
[21:57:26] <Krenair>	 WMF have 1.22wmf14 and 1.22wmf15 in production at the moment manybubbles 
[21:59:27] <^d>	 Which are all 1.22alpha. Cirrus won't work on 1.21 stable and below, too many core changes went in :)
[22:04:12] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] "Tests pass on my vagrant image." [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz)
[22:06:26] <marktraceur>	 Probably wrong thought of the day #57: "Pff, I can make that icon"
[22:08:07] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Fix compatability with php5.3.3 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81682 (owner: 10EBernhardson (WMF))
[22:09:06] <YuviPanda>	 bawolff: btw, brion was ready to merge that patch :)
[22:09:10] <YuviPanda>	 bawolff: just doing some minor fixes now.
[22:09:17] <bawolff>	 :D
[22:09:40] <YuviPanda>	 bawolff: also, by default, if I added cl_type=file, it threw off the mysql optimizer
[22:09:47] <YuviPanda>	 bawolff: had to force it to use an index, it was filesorting otherwise
[22:10:02] <bawolff>	 oh. good thing you checked that
[22:11:22] <brion>	 \o/
[22:11:42] <YuviPanda>	 bawolff: we're still not explicitly caching anything.
[22:11:47] <YuviPanda>	 bawolff: the parser cache is off too.
[22:11:53] <YuviPanda>	 so... let's hope we don't kill the cluster :)
[22:12:12] <bawolff>	 I suppose you're not expecting to have a super large amount of views to the page
[22:12:18] <^d>	 Krinkle, RoanKattouw: https://en.wikipedia.org/wiki/Wikipedia:VPT#Broken_scripts_on_pages_whose_names_begin_with_a_period :\
[22:12:19] <YuviPanda>	 you never know
[22:12:27] <YuviPanda>	 bawolff: plus I guess there'll be http caching?
[22:12:39] <RoanKattouw>	 ^d: Yeah we know, Krinkle said he was working on that today
[22:12:40] <YuviPanda>	 brion: hmm, I wonder how the http caching decides when to cache?
[22:12:46] <YuviPanda>	 brion: how does that invalidation work?
[22:12:49] <^d>	 RoanKattouw: I saw load.php and was like "NO WAY AM I TOUCHING THAT!"
[22:12:50] <grrrit-wm>	 (03PS1) 10Kaldari: Preventing empty payloads from being created when using summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81874 
[22:13:25] <bawolff>	 YuviPanda: Its based on headers. Its probably on if you haven't specificly disabled it
[22:13:44] <bawolff>	 Invalidation is usually done via HTMLCacheUpdate
[22:13:45] <YuviPanda>	 bawolff: how is that invalidated
[22:13:45] <YuviPanda>	 ?
[22:13:49] <grrrit-wm>	 (03PS1) 10Platonides: Use canonical class name, remove unused globals. [core] - 10https://gerrit.wikimedia.org/r/81875 
[22:13:54] <^d>	 RoanKattouw: I left a comment before someone spreads FUD that it is actually secure-login related ;-)
[22:13:58] <bawolff>	 or some method in title
[22:14:28] <YuviPanda>	 bawolff: hmm, so everything else does this manually? like CategoryPage, for example
[22:14:29] * YuviPanda  goes to check

[22:14:48] <YuviPanda>	 CategoryPage has no mention of the word 'cache'
[22:15:04] <bawolff>	 CategoryPage's are cached in squid
[22:15:32] <YuviPanda>	 right, but how is that invalidated when a new page/image is added to it?
[22:15:51] <bawolff>	 YuviPanda: Quick way to check, set $wgUseSquid = true; and check for the s-maxage http header
[22:16:08] <YuviPanda>	 hmm, moment
[22:16:12] <bawolff>	 Anytime you add something to a category page, I think it gets specificly purged.
[22:17:07] <RoanKattouw>	 ^d: Responded
[22:19:41] <YuviPanda>	 bawolff: Cache-Control: s-maxage=18000, must-revalidate, max-age=0
[22:20:02] * YuviPanda  goes to read up on Cache-Control

[22:20:40] <bawolff>	 Hmm, I think that means cached in squid for 5 hours, which is an odd length of time
[22:21:21] <YuviPanda>	 hmm
[22:21:22] <YuviPanda>	 Cache-Control: private, s-maxage=0, max-age=0, must-revalidate
[22:21:29] <YuviPanda>	 for curl -I https://en.wikipedia.org/wiki/India
[22:22:21] <bawolff>	 When you actually have squid/varnish installed, they change the cache-control headers
[22:22:39] <YuviPanda>	 hmm, right.
[22:22:43] <YuviPanda>	 makes sense
[22:22:44] <bawolff>	 they overwrite s-maxage, so that no shared caches that are outside of our control cache things
[22:23:31] <YuviPanda>	 ah, right. that makes sense.
[22:23:36] <YuviPanda>	 so mediawiki emits headers just for squid
[22:23:39] <YuviPanda>	 and then squid takes it from there
[22:23:58] <bawolff>	 yeah. The logic is somewhere in OutputPage.php
[22:24:32] <YuviPanda>	 must-revalidate only affects things *after* they expire
[22:24:34] <YuviPanda>	 I guess
[22:24:40] <YuviPanda>	 (or I might be reading it wrong)
[22:24:46] <bawolff>	 Title::purgeSquid is the method to purge squid caches
[22:25:24] <bawolff>	 I think the must-revalidate is for web browsers (Not 100% sure on that), since we don't purge web browsers, we ask the web browsers to check back with an if-modified-since check always
[22:25:46] <YuviPanda>	 bawolff: I could perhaps hook into 'TitleSquidURLs' and purge Campaign: something?
[22:25:52] <YuviPanda>	 hmm, I don't know *when* to do that, but.
[22:26:18] <bawolff>	 How often do anons actually look at campaign pages?
[22:26:24] <YuviPanda>	 bawolff: right now? not at all.
[22:26:31] <YuviPanda>	 bawolff: but the entire point of this is to make anons look at it more :)
[22:26:34] <bawolff>	 How often do you think they will
[22:26:36] <YuviPanda>	 bawolff: and sign up, etc.
[22:27:07] <YuviPanda>	 bawolff: hmm, maybe 100,000?
[22:27:11] <YuviPanda>	 bawolff: WLM gets a good amount of press
[22:27:18] <grrrit-wm>	 (03Abandoned) 10Seb35: Set a non-secure attribute when clearing a cookie [core] - 10https://gerrit.wikimedia.org/r/81614 (owner: 10Seb35)
[22:27:22] <bawolff>	 You could also just change the cache headers to cache it for only a day. The pages don't exactly have critical dynamic content
[22:27:36] <bawolff>	 or you could purge it everytime somebody uploads a new image during the campaign
[22:27:52] <YuviPanda>	 bawolff: hmm, so I could purge it from the Upload code?
[22:27:59] <YuviPanda>	 that sounds wrong.
[22:28:23] <YuviPanda>	 bawolff: well, reverse chronological order images uploaded is critical dynamic content, no?
[22:28:23] <bawolff>	 From upload code on the php side
[22:28:41] <bawolff>	 Not really critical, since if its a day outdated, people probably wouldn't care that much
[22:28:42] <grrrit-wm>	 (03CR) 10Manybubbles: "Backlink cache actually tries to pull all the links into memory on a cache miss which isn't too nice either." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81848 (owner: 10Manybubbles)
[22:28:47] <bawolff>	 or maybe they would
[22:28:57] <grrrit-wm>	 (03CR) 10Physikerwelt: "are there issues with this change" [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt)
[22:28:57] <YuviPanda>	 it feels wrong to me.
[22:29:13] <bawolff>	 When you upload a new image, it purges every page that uses the image, so purging the campaign page is probably not a big deal
[22:29:28] <YuviPanda>	 bawolff: ah, hmm. I need to check where that code is.
[22:29:36] <YuviPanda>	 bawolff: hopefully that has a hook.
[22:29:54] <bawolff>	 That part is deep in the bowels of the file class. Its scary
[22:31:00] <bawolff>	 It probably doesn't really matter where you hook into, provided you have somewhere where you can reliably figure out what campaign the upload is from
[22:32:00] <grrrit-wm>	 (03CR) 10Physikerwelt: "@Fredéric: Why not merge 2.3 first?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/64527 (owner: 10TheDJ)
[22:32:58] <YuviPanda>	 bawolff_away: hmm, right.
[22:33:11] * bawolff_away  will be back later

[22:33:40] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] "Don't merge yet! Investigating the effects this will have on squid / caching for anons." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[22:35:40] <grrrit-wm>	 (03CR) 10Physikerwelt: "@AlephNull" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull)
[22:37:02] <grrrit-wm>	 (03CR) 10Physikerwelt: "In general I have the feeling that it is harder to get code reviews in the summer time if everybody (me included) is on vacation." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull)
[22:46:33] <YuviPanda>	 constructing html without templates sucks.
[22:54:03] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 (owner: 10MarkTraceur)
[22:54:27] <grrrit-wm>	 (03PS8) 10MarkTraceur: Add convenience functions, fix auto-enroll [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 
[22:57:52] <grrrit-wm>	 (03PS5) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 
[22:58:11] <grrrit-wm>	 (03PS12) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 
[22:58:47] <grrrit-wm>	 (03PS3) 10MarkTraceur: Throw errors if required fields missing [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 
[22:58:50] <grrrit-wm>	 (03PS3) 10MarkTraceur: Remove preference prefix string [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81528 (owner: 10Esanders)
[23:17:40] <grrrit-wm>	 (03CR) 10BryanDavis: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 (owner: 10MarkTraceur)
[23:20:41] <grrrit-wm>	 (03PS1) 10MaxSem: Profiling [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/81878 
[23:30:07] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] "My complaints are fixed in gerrit:76198. Pushing this one so we can move forward to the next one." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 (owner: 10MarkTraceur)
[23:41:55] <grrrit-wm>	 (03PS3) 10Shirayuki: Add "taction" parameter for non-TUX [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 
[23:46:49] <grrrit-wm>	 (03PS1) 10MaxSem: Move hooks to a separate file [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81880 
[23:46:50] <grrrit-wm>	 (03PS1) 10MaxSem: Profiling [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/81881 
[23:52:02] <wmf-selenium-bot>	 Yippie, build fixed!
[23:52:02] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome build #5: FIXED in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome/5/
[23:53:07] <wmf-selenium-bot>	 Yippie, build fixed!
[23:53:08] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #5: FIXED in 1 min 5 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/5/
[23:57:55] <wmf-selenium-bot>	 Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/5/
[23:58:50] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 031] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur)
[23:59:21] <marktraceur>	 1!?!?!?!???!?!?!?!