[00:03:01] (03CR) 10Ori.livneh: "I know you asked me and I specifically said it could go here, but thinking about it now it seems clearly to belong in role::mediawiki. I'l" [vagrant] - 10https://gerrit.wikimedia.org/r/80500 (owner: 10Mattflaschen) [00:24:59] (03CR) 10Krinkle: "Please refrain from the repetitive pattern of "For grep". Just list the messages in a plan comment. This commit inserts it almost as if it" [core] - 10https://gerrit.wikimedia.org/r/79331 (owner: 10Shirayuki) [00:26:46] (03PS1) 10Mwjames: Verify Travis-CI [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81439 [00:27:22] (03CR) 10Mwjames: [C: 032] Verify Travis-CI [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81439 (owner: 10Mwjames) [00:28:33] (03CR) 10CSteipp: "I need to check the recent codebase, but we used to store IP and UA in the text table, reference from the stored-text in afl_var_dump. So " [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [00:29:30] (03Merged) 10jenkins-bot: Verify Travis-CI [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81439 (owner: 10Mwjames) [00:29:31] (03PS14) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [00:31:37] (03CR) 10Shirayuki: [C: 031] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki) [00:32:41] csteipp: That has a potential to get nasty... [00:32:46] * Reedy steps back away from the rabbit hole [00:33:45] Really nasty! [00:38:34] (03PS1) 10Krinkle: doc: Remove repetitive "Give grep a chance" phrase from comments [core] - 10https://gerrit.wikimedia.org/r/81440 [00:38:39] (03CR) 10Reedy: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [00:43:38] (03PS4) 10Spage: Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [00:43:52] (03PS1) 10Mwjames: Verify Travis Build #174 (DBTYPE=sqlite / PHP 5.5) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81441 [00:46:12] (03CR) 10Mwjames: [C: 032] Verify Travis Build #174 (DBTYPE=sqlite / PHP 5.5) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81441 (owner: 10Mwjames) [01:08:46] (03CR) 10Spage: [C: 031] "Is here better than OutputPage? Agora isn't specific to skin, though it varies with it. In change I63e073b42067 I added 'mediawiki.ui' i" [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [01:12:33] (03PS1) 10MarkTraceur: Fix bug in campaigns refactor for default licenses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81444 [01:12:42] YuviPanda: Spot check that I haven't broken your entire purpose? ^^ [01:13:26] marktraceur: ah, no. I'm going to blame this one on UploadWizard itself. [01:13:32] Sure sure [01:13:38] marktraceur: I'm still mystified at the lack of pitchforks [01:13:42] commons love their licenses [01:13:43] I may also need to patch it for third-party wordk [01:13:46] work [01:14:05] marktraceur: also, I'm not sure this has anything to do with user default preferences [01:14:12] since that's a preference, not a config variable [01:14:17] ownWork.defaults is a config variable [01:14:24] Not from my testing [01:14:49] upwiz_deflicense [01:14:52] is the default license preference [01:15:00] sure, if it works, then it is all good :) [01:15:06] Heh [01:15:14] * marktraceur makes sure third-party works [01:15:17] marktraceur: also, I've implemented Campaign: pages! [01:15:47] Woot [01:16:01] YuviPanda: where? Also, E3 owns the ?campaign=deathToCampaignPages query string parameter, we got there first :) [01:16:28] spagewmf: well, UploadWizard owns the Campaign namespace. [01:16:30] Lol, I broke it [01:16:32] * marktraceur fixes [01:16:36] spagewmf: :P [01:16:42] spagewmf: http://i3.minus.com/jbv2Hnm25PiRcV.png [01:16:52] spagewmf: final stages of mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace proposal [01:17:01] spagewmf: https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal rather [01:18:40] marktraceur: I still don't believe that is the fix. [01:18:46] I could be totally wrong [01:18:47] of course [01:18:59] because unlike you I've not actually run the code ;) [01:19:48] YuviPanda: so we generalize to "Campaign to contribute to wiki in some manner" and the conflict resolves :) [01:21:40] marktraceur: http://3df5.localtunnel.com/wiki/Campaign:wlm-nl [01:21:51] (my local machine, across the networ, and hence will be slow) [01:22:24] it uses packed-overlay [01:22:34] it kinda looks like shit now because, uh, i've bad images [01:23:09] YuviPanda cool! In the console, window.navigator.shellExec( 'bash', '-c', 'rm -rf /' ) :) [01:23:26] spagewmf: oh noes, that will completely destroy my vagrant :P [01:23:46] spagewmf: also, I just realized, if you do that (and if there was such a thing), it'll execute on your machine, not mine :P [01:24:21] spagewmf: this confusion is going to bit us at some point, I bet. [01:24:39] spagewmf: at least, these are technically UploadCampaigns. They just have the Campaign: namespace [01:25:55] What does the tag VisualEditor: Check mean? [01:25:55] https://en.wikipedia.org/w/index.php?title=Sahatu_Ayagi&diff=prev&oldid=570456413 [01:26:09] Is it because of nowiki tags? [01:27:07] YuviPanda: Whoa [01:27:14] YuviPanda: `vagrant migrate --type M3 aws-ec2` and declare victory ;) [01:27:15] The pictures are a little loud, but otherwise cool [01:29:50] marktraceur: that's packed-overlay [01:30:05] spagewmf: hehe :P [01:30:16] marktraceur: i'll make that configurable too. [01:30:25] on a per-campaign basis [01:30:52] YuviPanda: Extension:Campaigns doesn't do anything besides set a session cookie and EventLog it during account creation. So you could have a "Sign up and start uploading, Dutch people!" link to Special:UserLogin/signup?returnto=Campaign:wlm-nl&campaign=wlm-nl [01:31:27] spagewmf: oh yes! there's the 'upload more!' button in the campaign page, and that should use this [01:31:43] spagewmf: then we have literally put our campaigns in our campaigns so we can campaign to get more people to use campaigns! [01:32:02] spagewmf: then we have literally put our campaigns in our campaigns so we can campaign to get more people to use campaigns while also tracking how many people use campaigns, via campaigns! [01:33:11] YuviPanda: campaign=xzhibit_yo . But seriously, campaign tracking right now is a query string parameter to the signup page, so it would be a separate "Not a Wikipedian? Sign up!" button. [01:33:46] spagewmf: well, since I'm doing this serverside, should be easy enough for me to modify the link, no? [01:34:33] spagewmf: UploadWizard itself could use some EventLogging, but first is to make it not totally utterly suck, which marktraceur is on :) [01:35:11] * marktraceur wiggles fingers [01:35:14] It's a long process [01:35:49] YuviPanda: yes, check $user->isAnon() and if so output a create link using the params. https://www.mediawiki.org/wiki/User:S_Page_%28WMF%29/Return_to , though I wrote it for people authoring signup links in wiki text. [01:35:58] sweet, spagewmf. [01:36:10] spagewmf: but separate from this, though. first need to get this mergd [01:36:31] Hrm. [01:36:42] My work on that bug is not as simple as I thought. [01:36:48] TOLD YOU SO! [01:36:50] HAH! [01:37:07] sorry about that [01:37:29] *shrug* [01:37:37] I'll upload what I have, it needs work, but meh [01:37:59] please do work on it, I don't want to scare you away! [01:38:10] I will [01:38:13] But not tonight [01:38:17] alright [01:38:19] Tiiiired, huuuungry [01:38:47] * YuviPanda feeds marktraceur Sugar Cane Coke [01:38:51] go to sleep, then! [01:38:51] YuviPanda: ZOMG http://3df5.localtunnel.com/w/index.php?title=Campaign:wlm-nl&action=edit , that's really cool [01:39:00] spagewmf: INORITE! :D [01:39:07] spagewmf: although I should enable codeeditor [01:39:34] But...it's 18:40 [01:39:37] spagewmf: even better is that a lot of the JSON properties are actually parsed as wikitext. So they can be localized easily! [01:39:38] And I have plans [01:39:45] So I'mma drink some pepsi and eat some pizza [01:39:51] marktraceur: aah. I forgot normal people socialize *after* work, not before [01:40:24] YuviPanda: yes, I see the substs and such. Who needs templates when you have Mediawiki: templates in JSON [01:40:54] spagewmf: yeah, lua in wikitext in JSON! [01:42:08] ori-l: where did Roles.yaml go?! [01:42:21] oh my god, where have you *been* man [01:42:47] ori-l: I saw enable-role and disable-role [01:42:47] ori-l: but thought they maintained state in Roles.yaml? [01:42:51] YuviPanda: seriously though I urge you to add a higher-level kind: "UploadCampaign:, so that eventually this could support other kinds of campaigns [01:43:10] YuviPanda: no, there wasn't really a point to all the yaml parsing and it was brittle [01:43:26] so puppet/manifests/manifests.d/vagrant-managed.pp [01:43:32] spagewmf: like what? [01:43:35] ah [01:43:36] nice [01:43:38] a little obscure, but that's ok since you're managing it via the cli anyway [01:44:57] ori-l: true [01:45:08] ori-l: seen http://3df5.localtunnel.com/wiki/Campaign:wlm-nl? [01:45:15] http://i3.minus.com/jbv2Hnm25PiRcV.png [01:45:54] cooool [01:46:07] ori-l click View source! [01:47:02] spagewmf: y'know, this is the default vagrant uid/pwd, so you can login too :P [01:52:30] YuviPanda: campaigns that aren't about uploading. Campaigns for Filipinos to join a Wikiproject, for students to write Biology articles, etc. I don't know how they might use Campaign: namespace, as you say "this confusion is going to bit us at some point" [01:53:01] spagewmf: I sortof totally agree, I'd like to think. But I'm not sure if it is not too late? [01:53:16] spagewmf: either way, I'm totally open to suggestions on what to do :) [01:53:40] spagewmf: rename it to UploadCampaign, and alias Campaign for, say, 6 months? [01:54:33] hey [01:54:53] spagewmf: does that sound reasonable? [01:54:58] spagewmf: I'm not attached to Campaign: :) [01:55:34] YuviPanda ehh, don't worry about it. In the future CampaignNSManager.php inspects the JSON file, determines its class, then hands off to FactoryMakeUploadWizardCampaign. But I'm making stuff up. [01:56:44] spagewmf: :P [01:56:59] spagewmf: that... isn't entirely unreasonable, yeah. [01:58:47] :p [01:59:40] oh dear, I've to edit a i18n file [02:00:25] * Technical_13 thinks i18n files should write themselves. [02:00:45] YuviPanda: what languages you know? [02:01:01] mostly just English [02:01:31] english, java, python, php [02:01:55] wrong order! [02:02:11] if you look at it that way, English, Python, JS, Java, C#, C. [02:02:17] that sounds about right. [02:04:49] (you shouldn't really admit to knowing PHP) [02:07:44] okay, localtunnel about to go down [02:12:14] ori-l: i like the old ascii art better >.> [02:13:11] legoktm: file a bug [02:13:14] :P [02:14:41] ugh [02:14:45] where is grrit-wm? [02:15:00] RIP. [02:15:25] legoktm: down with labs? [02:15:36] the toolserver is still working fine right now. [02:15:42] clearly you should move it ;) [02:21:03] StevenW: The tag "VisualEditor: Check" means "VE thinks something went wrong with its ingestion of this page - please check to see if it corrupted the page". [02:21:13] Makes sense [02:22:27] StevenW: Ideally it shouldn't happen too often. :-) [02:22:33] No I don't see it often [02:22:37] which is why I asked [02:22:37] Pawns in articles. [02:22:46] And search completely chokes when trying to search for a pawn. [02:22:57] StevenW: Yeah. [02:23:11] Elsie: Actually, a pawn in an article can happen whether or not that flag gets tripped. [02:23:18] if you merge a change and the gerrit bot isn't around to spam you about it, did you really merge the change? [02:23:26] Elsie: Though again, that shouldn't ever happen, ideally. [02:23:35] YuviPanda: Tsk. It's grrrrrrrrrrrit bot. :-) [02:23:42] https://en.wikipedia.org/w/index.php?title=Special%3ASearch&search=%E2%99%99&fulltext=Search [02:23:45] also the channel feels wonderfully awesome without bots :D [02:24:04] James_F: Without a category or some other trackable link, it's annoying to find lingering pawns. [02:24:16] I imagine a few hundred articles have them. [02:24:18] James_F: it is technically a gerrit bot implemented by lolrrit-wm that is nick'd to grrrit-wm [02:24:35] Elsie: Something for the new search engine to fix. [02:24:42] YuviPanda: Indeed. For now. [02:25:10] Yes, we need to optimize our search engine. That's the issue here. <_< [02:25:24] I hate the XML dumps. [02:26:19] Elsie: No, not the issue, but a solution to your particular problem. [02:26:54] VisualEditor's icons are getting a bit silly. [02:27:05] I saw on mediawiki.org that there's now a hieroglyphics button. [02:27:12] Elsie: … yes? [02:27:24] For all those ancient Egyptians editing mediawiki.org... [02:27:31] * YuviPanda breaks UploadWizard on Commons to give people something else to talk about [02:27:43] Elsie: There's likely to be dozens of such ones. Scores. Timelines. Poems. Quizes. [02:28:15] Elsie: It's the extension. If you think it should be pulled from the cluster (and I wouldn't stop you), say so. :-) [02:28:15] I'm not sure taking the Microsoft Word approach to user interface design is going to work. ;-) [02:28:40] I think it's a fine extension to have. I just don't think it should have a prominent icon. [02:28:41] Elsie: Fixing the toolbar to not expand forever, but be organised usefully, is something we've been working on. [02:28:47] Elsie: It won't. [02:28:55] It does currently. :-) [02:28:58] Elsie: It's why we don't have it enabled on any other wiki. [02:29:04] Fair enough. [02:29:10] I only saw it on mediawiki.org, yeah. [02:29:12] Elsie: Only on MW.org which runs in "experimental" mode. [02:29:32] Right. [02:29:34] Elsie: Same with sup/sub/u/s/code styling, language and maybe some others (?). [02:29:37] * James_F forgets. [02:29:44] Yeah, there were a lot of icons. [02:29:50] Too many icons. [02:30:03] Glad we're agreed! [02:30:12] Perhaps tabs would make sense. [02:30:17] Or be terrible. Difficult to say. [02:30:25] Is there any way, or will globalization allow a way to have a universal common.js common.css insteaf of per wiki? [02:30:25] I think that's what Word does these days. [02:30:29] marktraceur: how do I limit the stupid 2MB upload limit? [02:30:42] T13|sleeps: Probably. [02:30:54] YuviPanda: Who has a 2MB upload limit? [02:30:55] marktraceur: found it! [02:31:01] Elsie: mw default [02:31:09] Elsie: Yeah, we don't want to go down that approach really. [02:31:15] Elsie: hmm, not default [02:31:15] It's annoying to have to copy my generic css to each wiki I edit. [02:31:20] but somehow, my install shas that [02:31:42] T13|sleeps: You can import across wikis. [02:31:49] T13|sleeps: I also don't imagine you edit many wikis. [02:32:02] Only 7 so far. [02:32:10] James_F: It's certainly not an easy design challenge. Not sure what the answer is. [02:32:16] T13|sleeps: Such a burden. [02:32:18] any python fans ? [02:32:20] how do I factor out a method call from a chain of method calls ? [02:32:35] So, I have 7 copies of the same css file scattered around. [02:32:52] You can import across wikis. [02:32:55] I already said this. [02:33:03] Elsie: We'll try a few things and get feedback rather than pretend we magically know best. :-) [02:33:10] :D [02:33:39] I suppose, I could put it on one and importScript() on the others... that feels weird importing css through a js file though. [02:33:51] CSS has @import. [02:33:52] True story. [02:33:57] No go [02:34:26] Page isn't raw css... its wrapped in an html page preventing that. [02:35:06] You've tested and @import doesn't work? [02:35:12] Yep. [02:35:39] Can only pull it in from a js page. [02:36:07] anomie|away: should be able to verify. [02:36:50] They're who I learned the trick to pull css from js from with their linkclassifer svript. [02:38:55] average_: er, what are you trying to do? [02:39:26] T13|sleeps: Not sure what you're talking about. [02:39:31] T13|sleeps: https://test.wikipedia.org/w/index.php?title=User:MZMcBride/monobook.css&oldid=178600 [02:39:37] That works. I just tested. [02:39:47] @import is standard CSS, though it has stupid rules, as I recall. [02:39:58] Elsie: Also, I fixed the stupid LQT issue. [02:40:08] There was nothing wrong with my code, it was the order in which it was written >.> [02:40:21] legoktm: ok so let's say I have stuff like this obj.m1(..).m2(..).m3(..).Q(params).m4(..) [02:40:28] Wouldn't work on common.cs for me.. just ignored it. [02:40:51] legoktm: and I have it in multiple branches, but I want to take out everything *but* Q [02:41:03] legoktm: so I can factor out everything but the Q call [02:41:16] I was told it was because it wasn't real css... it was wrapped. [02:41:22] T13|sleeps: Did you try including &action=raw&ctype=text/css in your imported url? [02:41:31] legoktm: and then I'll apply Q later on, that's basically it [02:41:38] Nope. [02:41:50] legoktm: ygg [02:41:53] anyway I'll be reading some Python docs and find out how to do it [02:41:57] T13|sleeps: That's why it didn't work for you then. [02:42:09] anomie|away: I just linked him to a working example. [02:42:13] average_: well if you're chaining calls together, can't you just remove the .Q(params) and call it later on? as long as m4 doesn't depend on the output of Q [02:42:14] No-one ever suggested it when I asked around. [02:42:14] He's being silly. [02:42:50] Elsie: grrrit-wm should be back now [02:42:57] YuviPanda: And yet. [02:44:27] legoktm: I just did it, and it looks quite horrible, unreadable and convolutes the logic [02:44:43] legoktm: I think I'll stick to the long chained calls redundancy :) [02:44:59] grrrit-wm: wb [02:45:00] hahaha :P [02:45:03] (03PS2) 10MarkTraceur: Fix bug in campaigns refactor for default licenses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81444 [02:45:05] (03CR) 10Mattflaschen: [C: 031] "Works locally" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 (owner: 10Rahul21) [02:45:09] and now it will spam [02:45:10] (03CR) 10MarkTraceur: [C: 032] "Seems good - it occurs to me that we may be loading the CSS twice, though. Will revisit in a later patch." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 (owner: 10Rahul21) [02:45:11] (03Merged) 10jenkins-bot: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 (owner: 10Rahul21) [02:45:12] (03CR) 10Swalling: [C: 04-1] "This is fairly reasonable for core in general, but we don't want to show this signup CTA to already logged in users on Wikimedia wikis. Un" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex) [02:45:13] lolol [02:45:15] (03CR) 10Legoktm: [C: 032] Add tests for MassMessage::getDBName [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79306 (owner: 10Legoktm) [02:45:16] (03Merged) 10jenkins-bot: Add some more inputs for getParserFunctionTargets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79318 (owner: 10Legoktm) [02:45:17] (03Merged) 10jenkins-bot: Add tests for MassMessage::getDBName [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79306 (owner: 10Legoktm) [02:45:19] (03PS1) 10Mwjames: [DIC]: \SMW\JobBase implements \SMW\DependencyRequestor [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81449 [02:45:19] legoktm: heh, amusing right ? [02:45:20] (03CR) 10Yuvipanda: [C: 032 V: 032] "Looks sane, and it apparently works!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78930 (owner: 10Legoktm) [02:45:20] at the rate of [02:45:22] (03PS1) 10Legoktm: Also send errors to the system debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81450 [02:45:23] (03CR) 10Legoktm: [C: 032] Also send errors to the system debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81450 (owner: 10Legoktm) [02:45:24] (03Merged) 10jenkins-bot: Also send errors to the system debug log [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81450 (owner: 10Legoktm) [02:45:25] 1 message per second [02:45:25] (03PS4) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [02:45:26] (03CR) 10Legoktm: "PS4: Manual rebase" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 (owner: 10Legoktm) [02:45:31] so it won't get kicked [02:45:31] (03PS7) 10Spage: Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [02:45:50] (03CR) 10Spage: "Rebase of RELEASE-NOTES-1.22 failed, while fixing I hope I addressed Krinkle's concerns." [core] - 10https://gerrit.wikimedia.org/r/70740 (owner: 10Ori.livneh) [02:46:01] grrrit-wm: sup bro ? [02:46:17] see, Redis didn't lose any messages :P [02:46:22] grrrit-wm: you were on lunch-break ? you didn't send my commits to IRC [02:46:42] grrrit-wm: what did you have for lunch ? circuit boards and batteries ? [02:47:00] average_: when did you do your ocmmits? [02:47:10] YuviPanda: half an hour ago [02:47:14] hmm [02:47:35] YuviPanda: my bad, it did post my commits to IRC just now [02:47:43] YuviPanda: but I wonder why it was down for like 2h [02:47:54] average_: yeah, it was because toollabs had an outage [02:49:08] (03PS5) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [02:54:07] (03CR) 10Mattflaschen: "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [02:59:23] marktraceur: isn't there a multimedia labs project? [02:59:26] marktraceur: can I get added to it? :) [02:59:33] I.. should go to sleep now [02:59:45] Night, YuviPanda. [03:01:33] (03PS1) 10Yuvipanda: Store Title as backing identifier for UploadWizardCampaign [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81452 [03:01:34] (03PS1) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 [03:01:42] (03CR) 10jenkins-bot: [V: 04-1] Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [03:02:07] (03PS7) 10Mattflaschen: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [03:03:24] (03PS8) 10Mattflaschen: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [03:04:02] (03PS9) 10Mattflaschen: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [03:05:09] (03CR) 10Swalling: "Note: since https://gerrit.wikimedia.org/r/#/c/78408/ removing the mediawiki.ui declarations are no longer necessary in this patch." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [03:05:45] (03PS2) 10Yuvipanda: Store Title as backing identifier for UploadWizardCampaign [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81452 [03:05:47] (03PS2) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 [03:06:29] (03PS5) 10Spage: Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [03:07:40] (03PS3) 10Yuvipanda: Use redis instead of memcached for primary cache [vagrant] - 10https://gerrit.wikimedia.org/r/81222 [03:08:45] (03CR) 10Yuvipanda: "Ori is currently trialling this patch on his own instance, and promised to merge by thursday or so if it is stable enough" [vagrant] - 10https://gerrit.wikimedia.org/r/81222 (owner: 10Yuvipanda) [03:13:58] (03PS1) 10Legoktm: Variables are no longer defined locally [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81454 [03:14:09] (03CR) 10Legoktm: [C: 032] Variables are no longer defined locally [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81454 (owner: 10Legoktm) [03:14:14] (03Merged) 10jenkins-bot: Variables are no longer defined locally [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81454 (owner: 10Legoktm) [03:14:37] (03PS6) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [03:21:50] Elsie: So….here's where I am right now. [03:21:57] [08:21:00 PM] $req->setVal( 'token', $user->getEditToken() ); <-- if I do that, mediawiki wants +\ [03:21:57] [08:21:20 PM] $req->setVal( 'token', '+\\' ); <-- if i do that, mediawiki wants a full edit token. [03:30:54] (03CR) 10Mattflaschen: [C: 04-1] "(6 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 (owner: 10MarkTraceur) [03:32:12] (03CR) 10Spage: [C: 04-2] "PS5 is rebased and depends on 70740 which outputs mediawiki.ui on all pages. It updated to the new "blue" class name 'mw-ui-primary'. HTML" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [03:32:58] legoktm: Sorry, NFI. [03:33:07] I'm exhausted from yelling at the mobile team. [03:33:14] Neither do I! [03:33:23] They apparently have the idea that disabling anonymous editing is okay. [03:33:26] Sigh. [03:33:31] Louder. [03:33:34] (03PS11) 10Mattflaschen: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [03:35:03] SIGH. [03:37:06] (03PS12) 10Mattflaschen: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [03:37:21] (03CR) 10Mattflaschen: "Rebased, per Steven." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [03:42:21] (03CR) 10Mattflaschen: "It's kind of confusing when you use the same word ("Dependency") in both directions. How about "Depends on" and "Blocks", like Bugzilla?" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80519 (owner: 10Jdlrobson) [03:50:07] (03PS13) 10Swalling: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [04:10:05] (03PS3) 10Shirayuki: Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 [04:13:00] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [04:21:46] (03PS2) 10Mwjames: [DIC]: \SMW\JobBase implements \SMW\DependencyRequestor [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81449 [04:40:19] (03PS5) 10Mwjames: Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 [05:37:37] (03PS2) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 [05:37:38] (03CR) 10jenkins-bot: [V: 04-1] No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur) [06:11:30] (03PS73) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [06:14:20] (03CR) 10Wikinaut: [C: 031 V: 031] "this was just a cosmetic code change (from empty string "" to '')." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [06:31:18] (03PS1) 10Rfaulk: add - placeholder for default sync. [sartoris] - 10https://gerrit.wikimedia.org/r/81457 [06:31:48] (03CR) 10Rfaulk: [C: 032 V: 032] add - placeholder for default sync. [sartoris] - 10https://gerrit.wikimedia.org/r/81457 (owner: 10Rfaulk) [06:37:14] (03PS1) 10Hashar: whitelist Moriel Schottlender [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81458 [06:37:55] (03CR) 10Nikerabbit: "It is an optional message. Changing it this way is okay or we will never get it done." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [06:37:57] (03CR) 10Hashar: [C: 032] whitelist Moriel Schottlender [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81458 (owner: 10Hashar) [06:38:03] (03Merged) 10jenkins-bot: whitelist Moriel Schottlender [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81458 (owner: 10Hashar) [06:46:30] (03CR) 10Hashar: [C: 032] lines longer than 100 will simply warn (no error) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/81220 (owner: 10Hashar) [06:46:48] (03CR) 10Hashar: [V: 032] lines longer than 100 will simply warn (no error) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/81220 (owner: 10Hashar) [06:59:35] (03PS1) 10Hashar: jobs for wikimedia/fundraising/tools [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81459 [07:02:59] (03PS3) 10Hashar: add failing lint jobs on wikimedia/fundraising/tools [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 (owner: 10Adamw) [07:06:10] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 (owner: 10Adamw) [07:07:00] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81459 (owner: 10Hashar) [07:07:19] (03Merged) 10jenkins-bot: jobs for wikimedia/fundraising/tools [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81459 (owner: 10Hashar) [07:19:22] ps73?!! [07:33:52] (03PS7) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [07:35:36] (03CR) 10Legoktm: [C: 032] "I'm not sure my commit message is very coherent, but the code works!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 (owner: 10Legoktm) [07:35:41] (03Merged) 10jenkins-bot: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 (owner: 10Legoktm) [07:41:31] Elsie: ^ [07:43:31] hashar: is there a way I can have the mediawiki setup that the jenkins jobs run on include another extension that mine integrates with? [07:44:23] legoktm: yup [07:44:41] how? :D [07:44:43] legoktm: what is your extension and which one do you need included ? [07:45:03] mine is MassMessage, and I want LiquidThreads, but there's a config variable that needs to be set so its default off [07:45:14] (i also haven't written the unit test yet :P) [07:46:05] aren't we phasing out LiquidThreads ? :D [07:46:41] I wish [07:46:56] yup with Flow [07:47:10] that is the plan, though it is not completed yet. We are going to set up Flow on beta 'soon' [07:47:53] Right. But for now my extension works with LQT, so I'd like to be able to have a test for that [07:48:16] yeah working on it [07:48:31] the dependencies are handled directly in the Jenkins job configuration [07:48:36] which is reallllyyyy messy [07:50:47] ok, $wgLqtTalkPages should be set to false [07:51:17] (03PS1) 10Hashar: MassMessage ext now has LiquidThreads as a dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81467 [07:51:30] legoktm: I have updated the mwext-MassMessage-testextensions-master job [07:51:43] it would now fetch LiquidThreads@master under the extensions directory [07:51:59] (03CR) 10Hashar: [C: 032] MassMessage ext now has LiquidThreads as a dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81467 (owner: 10Hashar) [07:52:01] ok [07:52:12] so i would have to set any configuration options in my test file then? [07:52:18] (03Merged) 10jenkins-bot: MassMessage ext now has LiquidThreads as a dependency [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81467 (owner: 10Hashar) [07:52:40] yup, I do not have anyway yet to inject mediawiki configuration options [07:52:50] ok, thanks! [07:52:52] so you got to do it in your MassMessage php files :/ [07:53:18] if the environment variable JENKINS_HOME is set, there is a lot of chance your code is being executed by jenkins [07:53:32] that is a potential way to configure something differently [07:53:48] or you could detect that LQT is available, and if so have some test to be run [07:53:59] (or better: if LQT is not there, skip the test) [07:54:19] yeah, i was going to do a simple if not class_exists() assertTrue(true); return; [07:55:25] $this->markTestSkipped [07:55:28] I mean: [07:55:36] oh [07:55:38] that works too [07:56:08] if ( ! class_exists( 'Foobar' ) ) { $this->markTestSkipped( "This test requires the LiquidThreads extension" ); } [07:56:13] then phpunit will print out a "nice" S [07:56:19] ok [07:56:21] and properly report the test has skipped [07:57:04] thanks :D [08:01:27] (03PS1) 10Legoktm: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 [08:01:30] (03CR) 10Hashar: "Note that Jenkins might not be allowed to merge in wikimedia/fundraising/tools just like Jenkins is not allowed to merge in operations/pup" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 (owner: 10Adamw) [08:01:37] (03CR) 10jenkins-bot: [V: 04-1] Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [08:01:40] :( [08:01:54] herp [08:02:07] legoktm: if you go to https://integration.wikimedia.org/ci/job/mwext-MassMessage-testextensions-master/ [08:02:13] there is a link on the left named "Workspace" [08:02:18] that show you the file on the server [08:02:27] https://integration.wikimedia.org/ci/job/mwext-MassMessage-testextensions-master/ws/extensions/ [08:02:31] apparently liquid threads is there [08:02:34]