[00:01:03] <marktraceur>	 I guess it depends on a patch though :(
[00:01:10] * marktraceur  is not terribly helpful

[00:03:52] <bawolff>	 marktraceur: What I meant was it should be: up_property LIKE 'beta-feature-%'
[00:04:08] <marktraceur>	 Ah
[00:04:14] * marktraceur  isn't aware of the syntax

[00:04:16] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(5 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain)
[00:05:16] <grrrit-wm>	 (03PS5) 10Brian Wolff: Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 
[00:05:33] * bawolff  has to go

[00:05:37] <marktraceur>	 Mmmkay
[00:05:44] <grrrit-wm>	 (03CR) 10Mwjames: [C: 032] [DIC]: @var type-hinting, /dic/README.mediawiki -> /dic/README.md [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81141 (owner: 10Mwjames)
[00:05:45] <grrrit-wm>	 (03PS1) 10Cmcmahon: Merge commit 'refs/changes/83/80483/1' of ssh://gerrit.wikimedia.org:29418/qa/browsertests into review/rachel99/ve_headings_test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81160 
[00:06:04] <grrrit-wm>	 (03CR) 10Ryan Lane: [C: 032 V: 032] Remove scripts/config that are mainted in puppet [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81151 (owner: 10Ryan Lane)
[00:06:15] <grrrit-wm>	 (03CR) 10Brian Wolff: "PS5: per Aaron" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff)
[00:06:48] <grrrit-wm>	 (03PS1) 10Yuvipanda: Do not skip fields that are not to be parsed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 
[00:06:49] <grrrit-wm>	 (03PS1) 10Yuvipanda: Use parsedConfig instead of rawConfig wherever possible [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81162 
[00:07:00] <YuviPanda>	 marktraceur: ^ help?
[00:07:11] <marktraceur>	 With what?
[00:07:18] <YuviPanda>	 two UW patches I just put up? :)
[00:07:24] <YuviPanda>	 I can look at jshint patches
[00:07:37] <marktraceur>	 "help" === review?
[00:07:42] <YuviPanda>	 yes?
[00:07:50] <marktraceur>	 Aw, it's tiny
[00:07:53] <marktraceur>	 No worries
[00:08:54] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff)
[00:09:17] <grrrit-wm>	 (03PS1) 10Shirayuki: Fix the message "bookmanagerv2-prev-title" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81163 
[00:09:18] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 (owner: 10Yuvipanda)
[00:09:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do not skip fields that are not to be parsed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 (owner: 10Yuvipanda)
[00:09:31] <marktraceur>	 Ouch.
[00:09:51] <marktraceur>	 YuviPanda: ^^
[00:09:57] <YuviPanda>	 marktraceur: that's just jenkins being dicky
[00:10:01] <marktraceur>	 Heh, that was dumb, you already got pinged
[00:10:02] <YuviPanda>	 00:09:15 ERROR: Error cloning remote repo 'origin' : Could not clone /srv/ssd/zuul/git/mediawiki/extensions/UploadWizard
[00:10:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: [DIC]: @var type-hinting, /dic/README.mediawiki -> /dic/README.md [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81141 (owner: 10Mwjames)
[00:10:21] <grrrit-wm>	 (03CR) 10Yuvipanda: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 (owner: 10Yuvipanda)
[00:10:28] <marktraceur>	 Oh huh.
[00:11:00] <grrrit-wm>	 (03CR) 10Yuvipanda: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 (owner: 10Yuvipanda)
[00:11:17] <YuviPanda>	 well that isn't working
[00:11:22] <grrrit-wm>	 (03PS1) 10Ori.livneh: Add 'statsd' EventLogging writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81164 
[00:11:28] <marktraceur>	 Tch
[00:11:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not skip fields that are not to be parsed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81161 (owner: 10Yuvipanda)
[00:11:50] <YuviPanda>	 spoke too soon :)
[00:13:10] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81157 (owner: 10Kaldari)
[00:13:18] <grrrit-wm>	 (03PS4) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 
[00:13:41] <YuviPanda>	 marktraceur: there's also https://gerrit.wikimedia.org/r/#/c/81162/ :)
[00:13:53] <YuviPanda>	 marktraceur: I'm doing https://gerrit.wikimedia.org/r/#/c/80523/ now. tryng to run browsertests on those
[00:13:57] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Tested." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81164 (owner: 10Ori.livneh)
[00:14:14] <marktraceur>	 I'm looking at the 62 one
[00:16:15] <ebernhardson>	 when i set $wgLocalisationCacheConf['store'] = 'accel'; in my LocalSettings.php i end up with : Fatal error: Call to a member function matchStartAndRemove() on a non-object in /vagrant/mediawiki/includes/parser/Parser.php on line 3236
[00:16:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'statsd' EventLogging writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81164 (owner: 10Ori.livneh)
[00:16:32] <grrrit-wm>	 (03CR) 10Mollywhite: [C: 032 V: 032] Fix the message "bookmanagerv2-prev-title" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81163 (owner: 10Shirayuki)
[00:16:34] <YuviPanda>	 ^d: so, Luca, the person who was doing the GitHub Gerrit integration, emailed me today
[00:16:41] <YuviPanda>	 ^d: asked if I wanted to work together on that. 
[00:16:48] <^d>	 orly?
[00:16:48] <ebernhardson>	 this has been working fine for months, and just decided to break this afternoon.  Any idea why?  I specifically use = 'accel' so that i dont have 100+ localisation mysql queries cluttering the query log
[00:16:53] <YuviPanda>	 ^d: not sure how that's going to go, since SuchABot is almost complete and is also... python
[00:16:57] <YuviPanda>	 ^d: yarly
[00:17:21] <YuviPanda>	 ^d: hmm, thought you had put him up to it :P apparently not
[00:20:39] <grrrit-wm>	 (03Abandoned) 10Cmcmahon: Merge commit 'refs/changes/83/80483/1' of ssh://gerrit.wikimedia.org:29418/qa/browsertests into review/rachel99/ve_headings_test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81160 (owner: 10Cmcmahon)
[00:20:45] <grrrit-wm>	 (03PS10) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 
[00:22:50] <grrrit-wm>	 (03CR) 10Mattflaschen: "After thinking about it some more, I think my second suggestion (0 default) above is more consistent. With the latest patch set, if you d" [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446)
[00:25:16] <YuviPanda>	 marktraceur: hmm, browser test fails
[00:25:29] <YuviPanda>	 looks for an 'upload more files' button which apparently doesn't turn up
[00:25:54] <marktraceur>	 Wat
[00:26:01] <marktraceur>	 Is it on beta?
[00:26:08] <YuviPanda>	 marktraceur: no, locally
[00:26:12] <YuviPanda>	 I think it's stable on beta
[00:26:15] <YuviPanda>	 let me run it without the change
[00:26:25] <YuviPanda>	 it's pissy though, because it takes so fucking long to run
[00:26:27] * YuviPanda  stabs macbook air

[00:26:47] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80688 (owner: 10Bsitu)
[00:26:55] * YuviPanda  runs

[00:26:55] <YuviPanda>	 it
[00:26:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Date header should be converted to user local time for comparison [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80688 (owner: 10Bsitu)
[00:27:44] <YuviPanda>	 marktraceur: also, can you tell me where bawolf/ GorillaWarfare's toollabs mediawiki instance is?
[00:27:57] <YuviPanda>	 marktraceur: I need to test the redis cache stuff
[00:28:13] <grrrit-wm>	 (03CR) 10Spage: "(3 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage)
[00:28:32] <marktraceur>	 Which change?
[00:28:52] <YuviPanda>	 marktraceur: 80523
[00:29:03] <marktraceur>	 GorillaWarfare: YuviPanda wishes to play with your mediawiki
[00:29:14] <marktraceur>	 !g 80523 | was that so hard
[00:29:14] <wm-bot>	 was that so hard: https://gerrit.wikimedia.org/r/#q,80523,n,z
[00:29:16] <YuviPanda>	 (on toollabs - if it is on toollabs)
[00:29:35] <GorillaWarfare>	 My Mediawiki?
[00:29:58] <YuviPanda>	 marktraceur: well, it fails on master too. 
[00:30:02] <YuviPanda>	 red herring, perhaps
[00:30:56] <marktraceur>	 No
[00:30:59] <marktraceur>	 It's a rebase thing
[00:31:17] <YuviPanda>	 marktraceur: I can merge 80523 if you do a rebase :)
[00:31:25] <YuviPanda>	 hmm?
[00:31:35] <YuviPanda>	 it needs a manual rebase
[00:31:39] <grrrit-wm>	 (03PS10) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 
[00:31:41] <marktraceur>	 Try them apples
[00:33:17] <grrrit-wm>	 (03PS1) 10Mwjames: [DIC]: Move SMWHooks::onParserAfterTidy to SMW\ParserAfterTidy [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 
[00:34:37] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] "Didn't break anything obvious, and at this point, any changes to UW's code quality can only be trending upwards..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur)
[00:34:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur)
[00:34:46] <YuviPanda>	 marktraceur: done! :)
[00:34:50] <marktraceur>	 Coolio
[00:34:54] <marktraceur>	 It's a start
[00:36:26] <YuviPanda>	 marktraceur: I'm heading to sleep now.
[00:36:43] <grrrit-wm>	 (03PS6) 10MarkTraceur: More jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 
[00:36:44] <YuviPanda>	 marktraceur: do see if you can merge https://gerrit.wikimedia.org/r/#/c/81162/ at some point :)
[00:37:01] <grrrit-wm>	 (03PS5) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 
[00:37:21] <grrrit-wm>	 (03PS5) 10MarkTraceur: Final jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 
[00:37:28] <marktraceur>	 Magical rebase button
[00:37:32] <marktraceur>	 YuviPanda: I'm working on it
[00:37:37] <YuviPanda>	 ty!
[00:39:33] <grrrit-wm>	 (03PS1) 10Cmcmahon: Merge commit 'refs/changes/83/80483/1' of ssh://gerrit.wikimedia.org:29418/qa/browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81168 
[00:43:50] <grrrit-wm>	 (03PS2) 10Mwjames: [DIC]: Move SMWHooks::onParserAfterTidy to SMW\ParserAfterTidy [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 
[00:57:45] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 (owner: 10Mwjames)
[01:02:54] <grrrit-wm>	 (03CR) 10Mwjames: "The problem is that the parser requires it an when running tests on 1.19.7 it will complain that CONTENT_MODEL_WIKITEXT doesn't exists, so" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 (owner: 10Mwjames)
[01:06:30] <grrrit-wm>	 (03PS1) 10Bsitu: archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 
[01:06:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 (owner: 10Bsitu)
[01:08:20] <grrrit-wm>	 (03PS2) 10Bsitu: archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 
[01:08:35] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] archive page and overlay should respect ?uselang=xxx [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81170 (owner: 10Bsitu)
[01:17:35] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Tested successfully with all button types." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 (owner: 10Spage)
[01:17:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Permit specifying a name for default actions [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 (owner: 10Spage)
[01:33:06] <gwicke>	 mwalker: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FParsoid.git/3e8a10c2dd10ffcc36720a0ee5a8b07492ed28a9/js%2Fapi%2Fserver.js
[01:33:28] <mwalker>	 gwicke: awesome; thanks
[01:34:52] <gwicke>	 mwalker: we were lazy and used express which might not be the fastest HTTP server possible. The built-in http server might be faster these days: http://nodejs.org/api/http.html
[01:35:43] <gwicke>	 mwalker: http://stackoverflow.com/questions/6084360/node-js-as-a-simple-web-server
[01:50:42] <gwicke>	 mwalker: http://pastebin.com/TKcidBzc
[01:52:29] <grrrit-wm>	 (03PS3) 10Mwjames: [DIC]: Move SMWHooks::onParserAfterTidy to SMW\ParserAfterTidy [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 
[01:58:18] <grrrit-wm>	 (03CR) 10Mwjames: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 (owner: 10Mwjames)
[02:20:24] <grrrit-wm>	 (03CR) 10Demon: [C: 032] test: run autoloader suite [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80981 (owner: 10Hashar)
[02:20:56] <grrrit-wm>	 (03CR) 10Demon: [C: 032] configuration for pep8/flake8 [tools/release] - 10https://gerrit.wikimedia.org/r/81033 (owner: 10Hashar)
[02:20:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: configuration for pep8/flake8 [tools/release] - 10https://gerrit.wikimedia.org/r/81033 (owner: 10Hashar)
[02:21:58] <grrrit-wm>	 (03CR) 10Demon: [C: 032] make-release: tweaks for pep8 [tools/release] - 10https://gerrit.wikimedia.org/r/81034 (owner: 10Hashar)
[02:22:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: make-release: tweaks for pep8 [tools/release] - 10https://gerrit.wikimedia.org/r/81034 (owner: 10Hashar)
[02:22:41] <grrrit-wm>	 (03CR) 10Demon: [C: 032] make-release: fix up python comparison [tools/release] - 10https://gerrit.wikimedia.org/r/81035 (owner: 10Hashar)
[02:22:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: make-release: fix up python comparison [tools/release] - 10https://gerrit.wikimedia.org/r/81035 (owner: 10Hashar)
[02:23:28] <grrrit-wm>	 (03CR) 10Demon: [C: 032] make-release: use space for indentation [tools/release] - 10https://gerrit.wikimedia.org/r/81036 (owner: 10Hashar)
[02:23:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: make-release: use space for indentation [tools/release] - 10https://gerrit.wikimedia.org/r/81036 (owner: 10Hashar)
[02:24:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: test: run autoloader suite [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80981 (owner: 10Hashar)
[03:15:12] <wmf-selenium-bot>	 Yippie, build fixed!
[03:15:13] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #263: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/263/
[03:19:39] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Add 'RedisPubSubFeedEngine' feed engine [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh)
[03:30:48] <grrrit-wm>	 (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[03:34:37] <grrrit-wm>	 (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[03:38:47] <wmf-selenium-bot>	 Yippie, build fixed!
[03:38:48] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #234: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/234/
[03:56:00] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21)
[04:25:43] <grrrit-wm>	 (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[04:33:01] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Might as well do it the same way as in mw.user. The comment is reasonable, but not essential." [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 (owner: 10Jdlrobson)
[05:03:52] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Per my previous comment and some more discussion." [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex)
[05:04:02] <grrrit-wm>	 (03PS3) 10Burthsceh: Add a hook to MovePageForm::showForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 
[05:07:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove inconsistent font-family declarations [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex)
[05:07:44] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-chrome build #276: FAILURE in 3 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/276/
[05:24:26] <grrrit-wm>	 (03PS4) 10Burthsceh: Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 
[05:24:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh)
[05:28:47] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #223: FAILURE in 6 min 5 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/223/
[05:38:51] <grrrit-wm>	 (03PS9) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 
[05:52:16] <grrrit-wm>	 (03CR) 10Pastakhov: "fix increment operator (have difference with php)" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov)
[07:03:57] <grrrit-wm>	 (03CR) 10Ori.livneh: "Krinkle, the comment was about the commit message, right?" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[07:08:33] <grrrit-wm>	 (03PS5) 10Ori.livneh: (Bug 38894) Abort{New,Auto}Account: error may be Message or HTML. [core] - 10https://gerrit.wikimedia.org/r/64645 
[07:33:19] <hashar>	 hello
[07:34:19] <Nikerabbit>	 hi
[07:52:57] <Nikerabbit>	 ori-l: the less change seems to work well, I've been testing it for few days
[07:53:06] <hashar>	 hello Nikerabbit :-)
[07:53:41] <ori-l>	 hey guys
[07:53:44] <ori-l>	 Nikerabbit: woot! :)
[07:55:01] <grrrit-wm>	 (03CR) 10Wikinaut: "(4 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut)
[07:55:11] <grrrit-wm>	 (03PS70) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 
[07:55:32] <ori-l>	 thanks for testing it
[07:58:06] <grrrit-wm>	 (03PD1) 10Hashar: new phpcs jobs for mediawiki/core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81183 
[07:58:21] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] new phpcs jobs for mediawiki/core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81183 (owner: 10Hashar)
[07:58:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: new phpcs jobs for mediawiki/core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81183 (owner: 10Hashar)
[08:02:19] <Nikerabbit>	 ori-l: one thing I wonder... aren't the RL dependencies and less @import providing kind of overlapping functionality?
[08:02:30] <grrrit-wm>	 (03PS1) 10Hashar: new phpcs jobs for mediawiki/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81184 
[08:05:02] <grrrit-wm>	 (03PS2) 10Hashar: new phpcs jobs for mediawiki/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81184 
[08:06:53] <grrrit-wm>	 (03PS3) 10Hashar: new phpcs jobs for mediawiki/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81184 
[08:07:35] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] new phpcs jobs for mediawiki/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81184 (owner: 10Hashar)
[08:07:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: new phpcs jobs for mediawiki/core (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81184 (owner: 10Hashar)
[08:08:52] <grrrit-wm>	 (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar)
[08:08:55] <grrrit-wm>	 (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 
[08:09:05] <hashar>	 lets see how bad the new phpcs jobs are
[08:11:27] <grrrit-wm>	 (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 
[08:15:28] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar)
[08:51:11] <grrrit-wm>	 (03PS10) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 
[08:51:25] <zeljkof>	 aharoni: is sandbox.translatewiki.net down at the moment?
[08:51:38] <zeljkof>	 do you know who can fix it?
[08:51:45] <aharoni>	 yes, Nikerabbit is working on it AFAIK
[08:51:54] <zeljkof>	 ok, great
[08:52:27] <zeljkof>	 I am moving selenium tests to ULS repo, I wanted to check if the code runs on sandbox 
[08:52:53] <ori-l>	 Nikerabbit: I think RL dependencies are for expressing dependency relations between discrete modules, whereas @import (in LESS) is probably more like an import in Python -- it's a way of loading functionality to make it available for you to use in your module
[08:53:03] <grrrit-wm>	 (03CR) 10Pastakhov: "fix right operators" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov)
[08:53:11] <ori-l>	 but yes, the distinction is not rigid
[09:10:33] <grrrit-wm>	 (03PS11) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 
[09:11:22] <grrrit-wm>	 (03CR) 10Pastakhov: "add T_STRING: true, false, null" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov)
[09:18:12] <Nikerabbit>	 zeljkof: scheduled maintenance window as far as I know, no ETA
[09:19:01] <grrrit-wm>	 (03PS12) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 
[09:20:23] <zeljkof>	 Nikerabbit: thanks
[09:20:23] <grrrit-wm>	 (03CR) 10Pastakhov: "add compare operators: <, >, <=, >=, ==, !=, ===, !==" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov)
[09:21:38] <hashar>	 zeljkof: hey there :-]
[09:22:01] <zeljkof>	 hashar: guten morgen (just got back from Berlin :)
[09:22:44] <zeljkof>	 hashar: I have remembered your recommendation to try currywurst while there :)
[09:22:57] <hashar>	 how have you enjoyed it ?
[09:23:08] <zeljkof>	 hashar: it needed more curry :)
[09:23:12] <hashar>	 :-]
[09:23:41] <zeljkof>	 I have tried it several times, to make sure 
[09:24:18] * hashar  I am going to restart Jenkins in a few minutes for plugins upgrades

[09:29:36] <zeljkof>	 hashar: thanks for letting me know
[09:35:23] <grrrit-wm>	 (03CR) 10J: [C: 031] Added useful headers in MediaHandler::getStreamHeaders. [core] - 10https://gerrit.wikimedia.org/r/51894 (owner: 10Parent5446)
[09:36:13] <grrrit-wm>	 (03CR) 10J: [C: 032] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:36:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:37:22] <Nikerabbit>	 zeljkof: I'm pretty sure putting mediawiki_username to secret.yml used to work, but not anymore
[09:37:27] <Nikerabbit>	 sandbox should be up now btw
[09:37:36] <grrrit-wm>	 (03PS3) 10J: Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:37:55] <zeljkof>	 Nikerabbit: I have just noticed that sandbox is up, thanks :)
[09:38:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:38:19] <zeljkof>	 Nikerabbit: I am done with moving the test code to ULS repo, I will take a look at secret.yml next
[09:39:37] <grrrit-wm>	 (03CR) 10J: [C: 032 V: 031] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:40:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 (owner: 10Shirayuki)
[09:54:49] <Nikerabbit>	 hashar: is jenkins up and running again?
[09:55:03] <ori-l>	 apparently not, some java issues
[09:55:08] <ori-l>	 Nikerabbit: is it ok to remove role::solr::ttm from vanadium, btw?
[09:55:18] <ori-l>	 i know you said it was dependent on some bug but i forgot to bookmark it and now i can't find it
[09:55:28] <hashar>	 Nikerabbit: yup just completed the restart. should be fine now
[09:56:36] <Nikerabbit>	 ori-l: it has been moved to a new server, but I already forgot the name
[09:57:07] <ori-l>	 zinc
[09:57:24] <Nikerabbit>	 yeah
[09:57:33] <ori-l>	 it's an important nutrient :P
[09:58:41] <Nikerabbit>	 zeljkof: so https://gerrit.wikimedia.org/r/#/c/80995 is no longer WIP?
[09:59:05] <MaxSem>	 ori-l, aren't you supposed to sleep?
[09:59:34] <Nikerabbit>	 he never sleeps
[09:59:45] <zeljkof>	 Nikerabbit: now that sandbox is up again I have found something broken with uls_accept_language.feature :)
[10:00:05] <zeljkof>	 Nikerabbit: as soon as I fix it I will remove WIP from the commit message
[10:01:33] <Nikerabbit>	 oki
[10:01:34] <ori-l>	 MaxSem: I liason between PDT and CEST
[10:02:42] <Nikerabbit>	 zeljkof: on unrelated note... if my tests change user preferences, is there recommended way to reset those to defaults?
[10:02:43] <ori-l>	 what on earth is a ttm server anyway?
[10:03:18] <Nikerabbit>	 it's t??? translation memory
[10:04:38] <zeljkof>	 Nikerabbit: every test should ideally prepare everything for itself, and cleanup after itself, but there is not recommended way on how to do it
[10:05:08] <Nikerabbit>	 zeljkof: I read somewhere that it is better to do cleanup before each test, but that might be overkill
[10:05:22] <Nikerabbit>	 zeljkof: would it be okay to use reset all preferences link of Special:Preferences?
[10:06:02] <zeljkof>	 Nikerabbit: Special:Preferences sounds good to me
[10:06:52] <zeljkof>	 Nikerabbit: every test should be completely independent, so they could be run in parallel 
[10:06:57] <MaxSem>	 ori-l, I'm not in CEST - go to bed;)
[10:07:30] <Nikerabbit>	 that might lead to problems mmm
[10:08:09] <ori-l>	 MaxSem: oh, are you in SF already?
[10:10:49] <zeljkof>	 Nikerabbit, aharoni: the move to ULS repo is done! https://gerrit.wikimedia.org/r/#/c/80995/
[10:12:20] <zeljkof>	 I will create jenkins jobs next
[10:15:08] <zeljkof>	 Nikerabbit: what could lead to problems?
[10:15:12] <zeljkof>	 running tests in parallel?
[10:15:21] <zeljkof>	 you can always not do it :)
[10:16:03] <zeljkof>	 but the test(s) and environment(s) should be set up in a way that running test(s) in parallel does not break anything
[10:23:55] <grrrit-wm>	 (03PS1) 10Aude: Update DataValues, fix handling of Mars coordinates, etc. [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81198 
[10:30:22] <Nikerabbit>	 zeljkof: can I drop IE6 and IE7 from config.yml because ULS does not support those browsers?
[10:31:10] <zeljkof>	 Nikerabbit: you are free to do what ever you want with the code in ULS repo, it is now completely owned by ULS team! :)
[10:31:32] <MaxSem>	 ori-l, no
[10:31:50] <Nikerabbit>	 zeljkof: just wondering if anything expects certain browsers to be there
[10:31:59] <zeljkof>	 Nikerabbit: you are also free to add either chrismcmahon or me as reviewers to any commit that you think we could provide valuable feedback
[10:32:14] <zeljkof>	 Nikerabbit: I see. No, feel free to delete them
[10:35:27] <grrrit-wm>	 (03PS2) 10Aklapper: Configure Bugzilla's Guided Bug Entry Form [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 
[10:37:43] <Nikerabbit>	 zeljkof: re @mediawiki_username, I think I just had misisng @login for the scenario
[10:38:12] <grrrit-wm>	 (03PS1) 10Ori.livneh: Workaround for "Unable to determine IP" bug [vagrant] - 10https://gerrit.wikimedia.org/r/81200 
[10:39:00] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Workaround for "Unable to determine IP" bug [vagrant] - 10https://gerrit.wikimedia.org/r/81200 (owner: 10Ori.livneh)
[10:39:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Workaround for "Unable to determine IP" bug [vagrant] - 10https://gerrit.wikimedia.org/r/81200 (owner: 10Ori.livneh)
[10:39:05] <grrrit-wm>	 (03CR) 10Aklapper: [C: 031] "Patch can be tested on Labs, see https://bugzilla.wikimedia.org/show_bug.cgi?id=36762#c8" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper)
[10:41:05] <zeljkof>	 Nikerabbit: @login tag should just output a warning if secret.yml file does not exist https://github.com/wikimedia/qa-browsertests/blob/master/features/support/env.rb#L117-L119
[11:02:27] <Nikerabbit>	 zeljkof: ah, so what oculd it be then
[11:04:19] * zeljkof  is out to lunch

[11:08:06] <grrrit-wm>	 (03Abandoned) 10Nikerabbit: GWT scenarios for checking consistency of webfont selection settings [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80980 (owner: 10Arrbee)
[11:08:29] <Nikerabbit>	 hashar, zeljkof: how to get ruby-lint for ULS?
[11:09:19] <hashar>	 Nikerabbit: have you ever played with jenkins job builder   and edit zuul configuration ? :)
[11:10:15] <Nikerabbit>	 hashar: no
[11:10:25] <hashar>	 let me spam this channel
[11:12:43] <grrrit-wm>	 (03PS1) 10Hashar: ruby 1.9 linter for UniversalLanguageSelector [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81207 
[11:13:16] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "deployed mwext-UniversalLanguageSelector-ruby1.9.3lint" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81207 (owner: 10Hashar)
[11:13:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: ruby 1.9 linter for UniversalLanguageSelector [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81207 (owner: 10Hashar)
[11:13:45] <Nikerabbit>	 three lines is not spam
[11:14:40] <grrrit-wm>	 (03PS1) 10Hashar: trigger mwext-UniversalLanguageSelector-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81208 
[11:15:14] <hashar>	 and here is the zuul diff change https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/373/console
[11:15:27] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] trigger mwext-UniversalLanguageSelector-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81208 (owner: 10Hashar)
[11:15:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: trigger mwext-UniversalLanguageSelector-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81208 (owner: 10Hashar)
[11:17:46] <hashar>	 Nikerabbit: SUCCESS https://integration.wikimedia.org/ci/job/mwext-UniversalLanguageSelector-ruby1.9.3lint/1/console :-]
[11:17:52] <grrrit-wm>	 (03PS2) 10Aude: Update DataValues, fix handling of precision and non-earth coordinates [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81198 
[11:20:12] <Nikerabbit>	 Zidonuke: what's the core test change doing there?
[11:23:02] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Update DataValues, fix handling of precision and non-earth coordinates [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81198 (owner: 10Aude)
[11:25:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update DataValues, fix handling of precision and non-earth coordinates [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81198 (owner: 10Aude)
[11:26:22] <zeljkof>	 Nikerabbit: you should ask hashar for ruby-lint
[11:26:50] <grrrit-wm>	 (03PS1) 10Aklapper: Display link to show list of other bug reports in same component [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/81212 
[11:27:00] <Nikerabbit>	 zeljkof: already done :)
[11:27:11] <zeljkof>	 Nikerabbit: great
[11:27:27] <Nikerabbit>	 zeljkof: want to review the config change?
[11:28:43] <grrrit-wm>	 (03CR) 10Aklapper: [C: 031] "Copy of file from /default to /custom, actual changes are ten lines and can be found by searching for "46413"." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/81212 (owner: 10Aklapper)
[11:29:00] <zeljkof>	 Nikerabbit: can you send me the link to the commit? 
[11:29:53] <Nikerabbit>	 zeljkof: https://gerrit.wikimedia.org/r/#/c/81205/1
[11:30:00] <Nikerabbit>	 or do you want it via email? :)
[11:30:14] <zeljkof>	 Nikerabbit: IRC is fine, or just add me as a reviewer :)
[11:31:46] <hashar>	 zeljkof: ULS has ruby linting now :-]
[11:32:23] <zeljkof>	 hashar: great :)
[11:32:55] <zeljkof>	 hashar: can you check if ruby linting is configured for mobile frontent and cirrus search too?
[11:33:25] <hashar>	 it is enabled for mobile frontend
[11:34:13] <hashar>	 for CirrusSearch, we need changes to JJB and Zuul just like I did for ULS ( https://gerrit.wikimedia.org/r/#/q/I6b36610b47797cdab8af0ffbec9c06fe4f61605b+is:merged,n,z )
[11:35:16] <hashar>	 I should probably write a tutorial: "how to add ruby linting" :-D https://www.mediawiki.org/wiki/Continuous_integration/Tutorial
[11:37:02] <ori-l>	 find . -iname '.rb' -exec rm {} \;
[11:37:15] <ori-l>	 *.rb, damnit.
[11:37:39] <YuviPanda_zz>	 ori-l: thoughts on switching mw vagrant to use redis as default cache? I've a patch almost ready...
[11:37:52] <ori-l>	 YuviPanda_zz: heh
[11:37:53] <ori-l>	 yes
[11:38:02] <ori-l>	 i thought that too :P
[11:38:05] <YuviPanda>	 oohoo, let me finish up and commit
[11:38:06] <ori-l>	 it should persist, too
[11:38:09] <YuviPanda>	 yeah!
[11:38:21] <ori-l>	 so you get a warm cache on startup
[11:38:31] <YuviPanda>	 yup. AOF should do
[11:38:57] <YuviPanda>	 ori-l: so, I want to use the redis module from ops/puppet
[11:38:58] <ori-l>	 cool. thanks!
[11:39:04] <YuviPanda>	 should I just copy paste?
[11:39:07] <YuviPanda>	 feels baddddd
[11:39:48] <ori-l>	 you can print it out and dictate it to a transcription service
[11:40:07] <YuviPanda>	 feels slightly less bad
[11:40:12] <YuviPanda>	 however I'll be 45 when I'm done
[11:40:12] <ori-l>	 but seriously, what do you suggest?
[11:40:13] <YuviPanda>	  :P
[11:40:15] <YuviPanda>	 submodulke
[11:40:18] <YuviPanda>	 *submodule
[11:40:20] <YuviPanda>	 + symlink
[11:40:56] <ori-l>	 ops/puppet is 105 megs
[11:41:00] <YuviPanda>	 ow
[11:41:02] <ori-l>	 well, probably i should gc my repo
[11:41:06] <ori-l>	 but it's still pretty fat
[11:41:12] <YuviPanda>	 yeah
[11:41:19] <YuviPanda>	 copy paste, then
[11:41:25] <ori-l>	 anyways, what does it implement that the redis module in vagrant doesn't?
[11:41:55] <YuviPanda>	 ori-l: it feels odd to me to have two separate modules that do the same thing.
[11:42:35] <hashar>	 off for lunch
[11:43:01] <YuviPanda>	 plus I think (*think*) the one in ops has actual defaults? redis.conf.erb is just a kvp emitter
[11:43:48] <ori-l>	 i like that better
[11:44:01] <YuviPanda>	 the reason? or the kvp emitter? :)
[11:44:13] <ori-l>	 it's painstaking work to produce puppet vars for each config variable
[11:44:18] <ori-l>	 and then map them to those config variables
[11:44:29] <ori-l>	 and update them every time the software changes
[11:45:49] <ori-l>	 i don't really know how to solve it
[11:46:10] <ori-l>	 operations/puppet is a beast; not blaming it -- it has a lot of work to do
[11:46:45] <ori-l>	 some of its modules are good and could be reused, but try and you'll often find that they depend on things outside the module
[11:46:58] <YuviPanda>	 yeah, I think the redis one will also probably depend on something icinga
[11:47:08] <YuviPanda>	 I guess this is all actually puppet's fault
[11:47:45] <ori-l>	 yes, it makes code reuse (a) impossibly difficult and (b) come at the price of legibility and concision
[11:48:02] <YuviPanda>	 indeed.
[11:48:17] <YuviPanda>	 I suppose it is devops' C, or asm :)
[11:48:22] <YuviPanda>	 better tools should come along eventually
[11:48:50] <zeljkof>	 Nikerabbit: sorry, finally took a look at 81205
[11:48:53] <zeljkof>	 looks good to me
[11:49:14] <zeljkof>	 to test the change, "just" run all tests :)
[11:49:19] <ori-l>	 YuviPanda: if you work out a plan in detail for merging the repos or for otherwise facilitating cross-repo module sharing i'd be interested
[11:49:39] <ori-l>	 i don't mind adding operations/puppet as a submodule, esp. if it's not absolutely required
[11:49:43] <YuviPanda>	 ori-l: i could test the waters by extracting out redis as a module into a submodule
[11:49:46] <zeljkof>	 Nikerabbit: I am working on creating Jenkins jobs, the tests should be running today here https://wmf.ci.cloudbees.com/view/r-uls/
[11:50:07] <ori-l>	 i wouldn't
[11:50:07] <YuviPanda>	 ori-l: but for this instance, unless you've strong objections, I'm going to copy paste. 
[11:50:14] <YuviPanda>	 ori-l: why so?
[11:50:14] <ori-l>	 yeah
[11:50:28] <YuviPanda>	 did you try that and get trouted before?
[11:50:31] <ori-l>	 because if you're going to use redis as the primary object cache
[11:50:42] <ori-l>	 mediawiki will heavily depend on it and will not tolerate its absence gracefully
[11:50:51] <ori-l>	 and it's not very well tested
[11:51:02] <YuviPanda>	 'it' -> ? redis?
[11:51:20] <ori-l>	 so in one swoop you'd be replacing the primary object cache and adding a submodule init / update step to the initial setup
[11:51:44] <ori-l>	 and things will break
[11:52:12] <ori-l>	 good lord, it's 5 AM. good night!
[11:52:41] <YuviPanda>	 haha!
[12:13:09] <Nikerabbit>	 zeljkof: will you also remove uls stuff from qa repo?
[12:13:22] <zeljkof>	 Nikerabbit: yes, as soon as I get the builds running
[12:13:46] <zeljkof>	 Nikerabbit: is there a reason to keep ULS tests in browsertests repo?
[12:15:14] <Nikerabbit>	 zeljkof: none that I can think of
[12:15:41] <zeljkof>	 Nikerabbit: great
[12:15:53] <zeljkof>	 will be cleaned up, maybe not today, but this week for sure
[12:17:34] <hashar>	 re
[12:42:49] <zeljkof>	 Nikerabbit, aharoni: the first ULS test run in jenkins! :) https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-chrome/1/console
[12:42:57] <aharoni>	 wee
[12:44:42] <zeljkof>	 Nikerabbit, aharoni: and the first ULS tests in sauce labs: https://saucelabs.com/tests/f017027edaf5466ebacbf40c94f028fd
[12:44:48] <zeljkof>	 (failed) :(
[12:46:18] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update @covers tag [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/81217 
[12:48:42] <zeljkof>	 aharoni, Nikerabbit: moar ULS jenkins jobs at https://wmf.ci.cloudbees.com/view/r-uls/
[12:50:36] <Nikerabbit>	 zeljkof: error doesn't look familiar to me
[12:52:59] <grrrit-wm>	 (03CR) 10IAlex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex)
[12:53:37] <grrrit-wm>	 (03PS2) 10IAlex: Rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/80409 
[12:54:54] <wmf-selenium-bot>	 Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-chrome build #1: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-chrome/1/
[12:56:22] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome build #1: FAILURE in 1 min 27 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-chrome/1/
[12:57:38] <wmf-selenium-bot>	 Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-chrome build #1: FAILURE in 1 min 15 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-chrome/1/
[13:00:29] <zeljkof>	 Nikerabbit, aharoni: looks like the tests fail because of a chromedriver bug :(
[13:00:35] <zeljkof>	 https://wmf.ci.cloudbees.com/view/r-uls/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-chrome/lastCompletedBuild/testReport/
[13:00:45] <zeljkof>	 I will run the tests in firefox, to check
[13:03:37] <Nikerabbit>	 zeljkof: you can trigger builds manually+
[13:03:40] <Nikerabbit>	 ?
[13:04:02] <zeljkof>	 Nikerabbit: yes
[13:04:34] <zeljkof>	 Nikerabbit: jenkins can be set up to trigger a job in several ways, manually, at certain time, after commit...
[13:04:34] <wmf-selenium-bot>	 Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #1: SUCCESS in 2 min 20 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/1/
[13:05:12] <zeljkof>	 Nikerabbit, aharoni: I have created several jenkins jobs, every site runs in both chrome and firefox
[13:05:13] <zeljkof>	 https://wmf.ci.cloudbees.com/view/r-uls/
[13:05:24] <zeljkof>	 commons+firefox is green! :)
[13:05:25] <aharoni>	 zeljkof: the chromedriver issue is about running jenkins, right? not about the bug with the login?
[13:05:38] <Nikerabbit>	 zeljkof: does it need special permission to create jobs?
[13:05:52] <zeljkof>	 aharoni: not related to login problem, that code is not yet merged into master, right?
[13:06:01] <aharoni>	 no, not merged.
[13:06:10] <grrrit-wm>	 (03CR) 10Matmarex: [C: 032] Rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex)
[13:06:17] <zeljkof>	 Nikerabbit: I think you just need an account there, will create accounts for both of you today
[13:10:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex)
[13:12:26] <zeljkof>	 aharoni: does font_selection.feature run fine for you if you remove this change from env.rb? https://gerrit.wikimedia.org/r/#/c/81206/2/tests/browser/features/support/env.rb 
[13:12:44] <zeljkof>	 aharoni: (if you delete this line: mediawiki_username = secret['mediawiki_username'])
[13:14:38] <Nikerabbit>	 awww
[13:14:52] <Nikerabbit>	 how did that get in.. I wasn't supposed to commit that with that change
[13:14:53] <aharoni>	 looking
[13:15:07] <zeljkof>	 Nikerabbit: :)
[13:15:30] <zeljkof>	 Nikerabbit: could you please remove that, so that aharoni can try running the tests again?
[13:15:58] <aharoni>	 looks like it starts to work
[13:16:07] <zeljkof>	 aharoni: that was the problem then
[13:16:37] <Nikerabbit>	 Did you not watch what username is typed into the login form?
[13:17:10] <wmf-selenium-bot>	 Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: SUCCESS in 12 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/1/
[13:17:35] <zeljkof>	 Nikerabbit: I watched the test run and username was not entered when logging in
[13:17:50] <Nikerabbit>	 then it was that line
[13:18:54] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #1: FAILURE in 1 min 43 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/1/
[13:18:57] <zeljkof>	 aharoni: does patch set 3 fix the problem for you?
[13:19:58] <wmf-selenium-bot>	 Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-chrome build #1: FAILURE in 48 min: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-chrome/1/
[13:20:40] <grrrit-wm>	 (03PS1) 10Zfilipin: Created "extension" Jenkins job template [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81218 
[13:23:29] <grrrit-wm>	 (03PS1) 10Hashar: lines longer than 79 will warn (no error) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/81220 
[13:24:35] <zeljkof>	 aharoni: looks like you already have jenkins account, can you log in? https://wmf.ci.cloudbees.com/user/amir.aharoni/
[13:26:36] <grrrit-wm>	 (03PS2) 10Matmarex: Add a dropdown list for the tag selector [core] - 10https://gerrit.wikimedia.org/r/80781 
[13:26:37] <grrrit-wm>	 (03PS1) 10Matmarex: Factor out ChangeTags::tagUsageStatistics() from SpecialTags [core] - 10https://gerrit.wikimedia.org/r/81221 
[13:27:02] <grrrit-wm>	 (03PS3) 10Matmarex: Add a dropdown list for the tag selector [core] - 10https://gerrit.wikimedia.org/r/80781 
[13:27:09] <grrrit-wm>	 (03PS2) 10Matmarex: Factor out ChangeTags::tagUsageStatistics() from SpecialTags [core] - 10https://gerrit.wikimedia.org/r/81221 
[13:30:29] <grrrit-wm>	 (03PS1) 10Yuvipanda: Use redis instead of memcached for primary cache [vagrant] - 10https://gerrit.wikimedia.org/r/81222 
[13:31:32] <grrrit-wm>	 (03PS2) 10Yuvipanda: Use redis instead of memcached for primary cache [vagrant] - 10https://gerrit.wikimedia.org/r/81222 
[13:45:31] <grrrit-wm>	 (03PS2) 10Hashar: lines longer than 100 will simply warn (no error) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/81220 
[13:46:28] <grrrit-wm>	 (03CR) 10Hashar: "Limit back to 100 :-]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/81220 (owner: 10Hashar)
[13:46:30] <grrrit-wm>	 (03PS2) 10Zfilipin: Created "extension" Jenkins job template [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81218 
[13:55:37] <grrrit-wm>	 (03CR) 10Zfilipin: "Is this pushed to gerrit by mistake?" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81168 (owner: 10Cmcmahon)
[14:00:03] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Add stub to make branches for all extensions [tools/release] - 10https://gerrit.wikimedia.org/r/81226 
[14:00:04] <grrrit-wm>	 (03PS1) 10MarkAHershberger: expose fixed makeRelease parameters to cli args re-tabify [tools/release] - 10https://gerrit.wikimedia.org/r/81227 
[14:00:05] <grrrit-wm>	 (03PS9) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 
[14:00:58] <grrrit-wm>	 (03PS2) 10Zfilipin: Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99)
[14:00:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99)
[14:01:56] <grrrit-wm>	 (03PS1) 10Hashar: get rid of -merge jobs (no more triggered) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81228 
[14:02:00] <grrrit-wm>	 (03PS1) 10Zfilipin: Merge "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81229 
[14:02:50] <grrrit-wm>	 (03CR) 10Rjain: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain)
[14:03:12] <grrrit-wm>	 (03Abandoned) 10Zfilipin: Merge "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81229 (owner: 10Zfilipin)
[14:03:15] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "I already deleted them." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81228 (owner: 10Hashar)
[14:03:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: get rid of -merge jobs (no more triggered) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81228 (owner: 10Hashar)
[14:05:00] <grrrit-wm>	 (03Abandoned) 10Zfilipin: Merge commit 'refs/changes/83/80483/1' of ssh://gerrit.wikimedia.org:29418/qa/browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81168 (owner: 10Cmcmahon)
[14:05:42] <zeljkof>	 anybody knows why this can not be merged into master? https://gerrit.wikimedia.org/r/#/c/80483/
[14:05:47] <grrrit-wm>	 (03PS2) 10MarkAHershberger: expose fixed makeRelease parameters to cli args [tools/release] - 10https://gerrit.wikimedia.org/r/81227 
[14:06:02] <grrrit-wm>	 (03CR) 10Rjain: "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain)
[14:06:16] <zeljkof>	 if I pull it to my machine with: git review -d 80483
[14:06:31] <zeljkof>	 and then rebase with master: git rebase master
[14:06:42] <zeljkof>	 and then the usual
[14:06:43] <zeljkof>	 git commit --all --amend
[14:06:48] <zeljkof>	 git review --no-rebase
[14:06:54] <zeljkof>	 a new commit is created
[14:07:06] <zeljkof>	 https://gerrit.wikimedia.org/r/#/c/81229/
[14:15:50] <grrrit-wm>	 (03Abandoned) 10Zfilipin: Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99)
[14:16:24] <grrrit-wm>	 (03Restored) 10Zfilipin: Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99)
[14:19:02] <grrrit-wm>	 (03PS1) 10Aude: Update Wikibase, fix issue with property parser function [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81233 
[14:19:11] <cscott>	 zeljkof: i'll take a look.  looks like you're pushing the merge commit, not the commit itself.  i'd suggest leaving off --no-rebase on your git review, fwiw.
[14:19:19] <rachel99>	 zeljkof: It may be because I finished the test on Friday, so when you rebase it today the code is newer than when the test is created
[14:19:27] <cscott>	 also, have you git pulled from master recently?
[14:19:45] <zeljkof>	 cscott: yes, I did a git pull before git rebase
[14:20:04] <zeljkof>	 cscott: could you try pushing a new patch set from your machine?
[14:24:50] <cscott>	 zeljkof: it appears that that patch has already been merged
[14:25:00] <zeljkof>	 cscott: let me see...
[14:25:21] <zeljkof>	 cscott: this one? https://gerrit.wikimedia.org/r/#/c/80483/
[14:25:25] <zeljkof>	 it is not merged
[14:25:54] <zeljkof>	 as far as I can see
[14:25:59] <cscott>	 the changes in it are included in a614172462d2eec5951b89ae6ce4af1a80fde43b which was merged.
[14:26:07] <zeljkof>	 let me see...
[14:26:11] <cscott>	 so when you rebase you get a no-op
[14:26:28] <grrrit-wm>	 (03PS1) 10Aude: Update Wikibase, fix for property parser function [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81237 
[14:26:46] <cscott>	 https://gerrit.wikimedia.org/r/#/c/79794/ is the gerrit for the merged patch
[14:27:02] <cscott>	 ...which is marked WIP, so it probably shouldn't have been merged
[14:27:14] <zeljkof>	 cscott: thanks
[14:27:23] <grrrit-wm>	 (03CR) 10Cscott: "This patch is marked WIP, did you really mean to merge it?" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 (owner: 10Rachel99)
[14:27:23] <zeljkof>	 I will take a look, not sure what happened there
[14:28:16] <cscott>	 anyway, if you add the '-i' option to rebase in your original command list, you'll get a giveaway as to what's going on, because rebase will tell you it's applying a no-op patch.
[14:28:42] <zeljkof>	 Nikerabbit, aharoni: I have found how to add users to jenkins, would you like me to create an account for each of you, so you can work on https://wmf.ci.cloudbees.com/view/r-uls/ ?
[14:28:50] <cscott>	 the right thing might be to revert 79794, after which your commands to rebase and merge 80483 should work fine.
[14:28:51] <grrrit-wm>	 (03PS1) 10Cmcmahon: Revert "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81238 
[14:29:42] <cscott>	 zeljkof: looks like cmcmahon is doing the revert, see 81238
[14:29:46] <zeljkof>	 chrismcmahon: did you see what cscott said?
[14:29:53] <zeljkof>	 cscott: just saw that
[14:30:22] <cscott>	 anyway, glad I could help ;)
[14:30:34] * cscott  goes back to working on operational transforms for visual editor

[14:30:41] <zeljkof>	 cscott: thanks, it was really over my head :)
[14:30:46] <chrismcmahon>	 cscott: zeljkof I merged that yesterday because I thought it was a a parent commit to https://gerrit.wikimedia.org/r/#/c/80483 that I *would* like to merge
[14:32:28] <cscott>	 chrismcmahon: would it help if I +2'ed 81238?
[14:33:04] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Revert "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81238 (owner: 10Cmcmahon)
[14:33:48] <chrismcmahon>	 cscott: I admit I remain confused about how to get 80483 merged
[14:34:21] <cscott>	 hm, hang on
[14:35:19] <cscott>	 there's another WIP patch: https://gerrit.wikimedia.org/r/#/c/79017/
[14:36:13] <grrrit-wm>	 (03CR) 10Cscott: "This is another patch marked WIP. Usually we (at least) remove that from the patch summary before it is merged." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 (owner: 10Rachel99)
[14:36:25] <cscott>	 but let me take a closer look.
[14:37:45] <chrismcmahon>	 cscott:  I did that because I wanted to build out from 79017, which was a useful step
[14:38:47] <grrrit-wm>	 (03PS2) 10Aude: Update Wikibase, fix issue with property parser function [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81233 
[14:39:31] <cscott>	 ooh, 80483 is itself a merge commit.  ah.  that's not right.
[14:40:43] <cscott>	 so 80483 is actually identical to 79017.  which is merged already.
[14:42:19] <grrrit-wm>	 (03PS1) 10MarkAHershberger: expose fixed makeRelease parameters to cli args flake8/pep8 clean [tools/release] - 10https://gerrit.wikimedia.org/r/81240 
[14:42:34] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Update Wikibase, fix for property parser function [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81237 (owner: 10Aude)
[14:42:35] <grrrit-wm>	 (03Abandoned) 10Cscott: Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99)
[14:45:04] <grrrit-wm>	 (03PS2) 10MarkAHershberger: expose fixed makeRelease parameters to cli args flake8/pep8 clean [tools/release] - 10https://gerrit.wikimedia.org/r/81240 
[14:45:11] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Update Wikibase, fix issue with property parser function [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81233 (owner: 10Aude)
[14:45:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikibase, fix for property parser function [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81237 (owner: 10Aude)
[14:45:32] <cscott>	 chrismcmahon, zeljkof: did you see above ^
[14:46:40] <zeljkof>	 cscott: chrismcmahon will know more about the commits
[14:46:53] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: expose fixed makeRelease parameters to cli args [tools/release] - 10https://gerrit.wikimedia.org/r/81227 (owner: 10MarkAHershberger)
[14:47:13] <grrrit-wm>	 (03PS1) 10Cscott: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81241 
[14:48:06] <cscott>	 zeljkof, chrismcmahon: my fault, i misdiagnosed the problem.  that is, i saw that the patch had already been applied, but i didn't realize that it was because the patch was a merge commit of a *different* patch which had already been applied.
[14:48:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikibase, fix issue with property parser function [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81233 (owner: 10Aude)
[14:48:27] <zeljkof>	 cscott: you are making my head hurt :)
[14:48:33] <cscott>	 yeah.
[14:48:56] <cscott>	 don't upload merge commits to gerrit.  it makes everyone's heads hurt.
[14:49:20] <zeljkof>	 cscott: we usually do not have any merge commits, as far as I understand what a merge commit is
[14:49:39] <cscott>	 yes, that's right.  i don't know how it got there in the first place.
[14:49:49] <cscott>	 usually only jenkins makes merge commits.
[14:51:53] <grrrit-wm>	 (03PS1) 10Zfilipin: There is no need for any Git setup [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81242 
[14:53:27] <cscott>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=53404 <-- suggestion that gerrit disallow upload of merge commits
[15:01:39] <grrrit-wm>	 (03PS1) 10Cmcmahon: this should be the same as https://gerrit.wikimedia.org/r/#/c/80483 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 
[15:02:54] <chrismcmahon>	 hi rachel99 joining ECT mtg? 
[15:03:02] <zeljkof>	 rachel99: are you joining us for ECT weekly meeting?
[15:03:17] <rachel99>	 chrismcmahon: yes, I am having trouble getting in
[15:04:02] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 04-1] "not finished yet" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 (owner: 10Cmcmahon)
[15:05:41] <rachel99>	 chrismcmahon: : can you have Sumnah sent me the invite again?
[15:05:56] <zeljkof>	 rachel99: I have invited you from the hangout
[15:05:58] <zeljkof>	 try now
[15:06:57] <rachel99>	 zeljkof: I am...it seems to stop halfway through loading the hangout page.  I will reboot and try it again.
[15:07:08] <zeljkof>	 rachel99: reboot usually helps :)
[15:17:17] <marktraceur>	 !b 700
[15:17:17] <wm-bot>	 https://bugzilla.wikimedia.org/700
[15:18:10] <marktraceur>	 andre__: As a matter of policy, if a bug is blocking a tracking bug that's also blocking 700, should we block 700 on the child bugs also?
[15:18:29] <marktraceur>	 Seems like a bit of clutter to me
[15:19:04] <andre__>	 marktraceur: I wouldn't, feels like clutter. that's why I reverted
[15:19:14] <marktraceur>	 Ah, good deal
[15:19:19] * marktraceur  didn't see that part

[15:19:22] <YuviPanda>	 nice bug :)
[15:19:38] <marktraceur>	 Ah, g'morning YuviPanda
[15:19:43] <YuviPanda>	 morning, marktraceur
[15:20:32] <grrrit-wm>	 (03PS2) 10Cmcmahon: this should be the same as https://gerrit.wikimedia.org/r/#/c/80483 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 
[15:20:53] <marktraceur>	 andre__: I hope I'm not running amok of bugzilla's purpose in filing all those code quality bugs :)
[15:21:05] <andre__>	 marktraceur, nah, I think it's fine. :)
[15:21:29] <marktraceur>	 Cool
[15:22:10] <grrrit-wm>	 (03PS6) 10Brian Wolff: Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 
[15:23:36] <grrrit-wm>	 (03CR) 10Cmcmahon: "let me know with a +1 or +2 and I will abandon the other ve headings commits" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 (owner: 10Cmcmahon)
[15:26:54] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh)
[15:28:37] <grrrit-wm>	 (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 (owner: 10Cmcmahon)
[15:30:43] <hoo>	 thedj: Are you around?
[15:32:47] <YuviPanda>	 marktraceur: guess what I'm doing :)
[15:35:19] <Amgine>	 Wash your hands after, Yuvi.
[15:36:03] <YuviPanda>	 well played
[15:36:08] * YuviPanda  is making a mcockup

[15:37:11] <YuviPanda>	 bawolff: do you have a link to the page that shows off the new gallery styles handy?
[15:37:14] <YuviPanda>	 the one on commons, not on tools
[15:37:31] <marktraceur>	 YuviPanda: That typo is hilaaarious
[15:38:05] <YuviPanda>	 marktraceur: which typo?
[15:38:13] <marktraceur>	 "mcockup"
[15:38:18] <grrrit-wm>	 (03CR) 10Rachel99: [C: 031] "Looks good to me." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 (owner: 10Cmcmahon)
[15:38:22] <marktraceur>	 Not sure which one you meant
[15:38:27] <YuviPanda>	 ow
[15:38:29] <marktraceur>	 YuviPanda: Anyway, what's the cockup for?
[15:38:30] <YuviPanda>	 i... didn't notice
[15:38:39] <YuviPanda>	 i'm making a cockup for Campaigns
[15:39:01] <marktraceur>	 Cool! An editor, I hope.
[15:39:06] <YuviPanda>	 nope :P
[15:39:09] <marktraceur>	 ...
[15:39:15] <YuviPanda>	 nobody's complained about that yet.
[15:39:16] <marktraceur>	 SOMETHING EVEN MORE MAGICAL!?
[15:39:23] <YuviPanda>	 Phase 3!
[15:39:24] <YuviPanda>	 or 4.
[15:39:26] <YuviPanda>	 not sure about that
[15:39:31] <YuviPanda>	 but actually making Campaign: pages be useful
[15:39:34] <marktraceur>	 Damn! I forgot the phases.
[15:39:35] <YuviPanda>	 than just a display of JSON structure
[15:39:41] <YuviPanda>	 I forgot the phases too
[15:39:47] <marktraceur>	 Execute order 66
[15:40:37] <parent5446>	 marktraceur: Yes milord.
[15:40:39] <YuviPanda>	 marktraceur: I thought order 66 was 'leave channel'
[15:40:48] <marktraceur>	 No, it's "kill all the jedi"
[15:40:51] <marktraceur>	 IMBECILE
[15:40:57] <marktraceur>	 Your death shall be long and painful
[15:41:29] <YuviPanda>	 like, take 60 years?
[15:41:35] <marktraceur>	 1000 years
[15:41:39] <marktraceur>	 Even better
[15:43:23] <YuviPanda>	 'Well, if it can be turned off, then it should never be changed into the default behaviour. That’s basic respect. -- Tuválkin ✉ 23:33, 21 August 2013 (UTC)'
[15:43:28] * YuviPanda  stabs everyone

[15:43:30] <YuviPanda>	 grr
[15:44:20] <marktraceur>	 YuviPanda: Not about your campaigns
[15:44:39] <YuviPanda>	 yeah, but that's mostly because everyone hated the current implementation :P
[15:44:50] <YuviPanda>	 problem is when the current one is considered 'good enough' by a few and 'shitty' by a majority.
[15:45:35] <marktraceur>	 Aha
[15:45:53] <marktraceur>	 YuviPanda: It's a good week for getting into fights with Commons :)
[15:46:11] <marktraceur>	 https://commons.wikimedia.org/wiki/Commons:Requests_for_comment/How_Commons_should_deal_with_TemplateData#Discussion
[15:46:15] <YuviPanda>	 yeah, let's flip bawolff's gallery style to default? :)
[15:46:42] <brion>	 user fight!
[15:46:49] <marktraceur>	 Oh right
[15:46:51] <marktraceur>	 YuviPanda: https://gerrit.wikimedia.org/r/#/c/81162/1/includes/specials/SpecialUploadWizard.php
[15:46:55] <marktraceur>	 Why can you delete those
[15:47:00] <marktraceur>	 Summary, go
[15:47:04] <marktraceur>	 (I'll be commuting)
[15:49:21] * YuviPanda  throws https://gerrit.wikimedia.org/r/#/c/81162/ at brion

[15:49:46] * brion  looks

[15:51:16] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Looks ok offhand, will test at office if not merged by then." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81162 (owner: 10Yuvipanda)
[15:51:23] <YuviPanda>	 ty brion
[15:51:51] <brion>	 shouldn't be any big surprises in there; the editing won't accidentally pick this up since it's generic json edit right?
[15:52:17] <YuviPanda>	 brion: yeah
[15:52:22] <YuviPanda>	 do test, though: )
[15:52:35] <grrrit-wm>	 (03PS1) 10Yuvipanda: Rename getConfig to getRawConfig, to be more explicit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81247 
[15:55:10] <brion>	 ooh that's good
[15:57:22] <grrrit-wm>	 (03CR) 10CSteipp: [C: 031] "Sorry for the delay. I think it looks ok." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper)
[15:58:02] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] this should be the same as https://gerrit.wikimedia.org/r/#/c/80483 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81243 (owner: 10Cmcmahon)
[15:58:25] <grrrit-wm>	 (03Abandoned) 10Cmcmahon: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81241 (owner: 10Cscott)
[16:00:05] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Created "extension" Jenkins job template [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81218 (owner: 10Zfilipin)
[16:00:52] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81242 (owner: 10Zfilipin)
[16:01:02] <grrrit-wm>	 (03PS12) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 
[16:01:10] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78233 (owner: 10Zfilipin)
[16:02:21] <grrrit-wm>	 (03PS13) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 
[16:03:53] <grrrit-wm>	 (03PS2) 10Anomie: Allow for non-web-based consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 
[16:05:14] <grrrit-wm>	 (03CR) 10Anomie: "PS2: Ok, removed the part allowing entry of an empty url and treating that as pointing to Special:MWOAuth/verified. I'll leave figuring ou" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie)
[16:07:14] <kart_>	 Can anyone check if I have permission to create tag on Gerrit (releasing MLEB)
[16:08:01] <kart_>	 shell account is: kartik
[16:08:47] <YuviPanda>	 kart_: you need ^demon, who isn't around right now
[16:08:59] <YuviPanda>	 bawolff: so... http://minus.com/lRX51zHTCdnI9
[16:09:14] <YuviPanda>	 first time I'm doing anything that can be considered a 'mockup'
[16:09:16] <bawolff>	 just a minute
[16:13:31] <YuviPanda>	 kart_: ^d is Chad :)
[16:14:05] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add title and description as parsed properties [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81249 
[16:14:25] <kart_>	 Can anyone check if I have permission to create tag on Gerrit (releasing MLEB) <-- ^d 
[16:14:54] <^d>	 Create tags on what?
[16:15:16] <kart_>	 ^d: MLEB extentions.
[16:15:22] <^d>	 And those are...?
[16:16:23] <kart_>	 ^d: Babel  cldr  CleanChanges  LocalisationUpdate  Translate  UniversalLanguageSelector
[16:16:38] <^d>	 What's your gerrit username?
[16:16:44] <kart_>	 ^d: kartik
[16:18:01] <^d>	 Ok, so those repos seem to be owned by the L10n-team group. Maybe you should ask them if you should be a member?
[16:18:06] <aharoni>	 ^d: i've been doing this in the last few months.
[16:18:16] <aharoni>	 ^d: yes, kart_ should be added there.
[16:19:08] <^d>	 Ok, can do
[16:19:42] <^d>	 aharoni: https://gerrit.wikimedia.org/r/#/admin/groups/18,members look correct to you?
[16:20:43] <grrrit-wm>	 (03CR) 10AndyRussG: "Thanks so much for your comments, Spage and Mattflaschen!! Here's a summary of some issues and options:" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79549 (owner: 10AndyRussG)
[16:20:58] <kart_>	 ^d: Thanks
[16:23:05] <YuviPanda>	 marktraceur: tada! http://minus.com/lRX51zHTCdnI9
[16:23:12] <marktraceur>	 Tada!?
[16:23:21] <marktraceur>	 Wow, it's ugly!
[16:23:32] <YuviPanda>	 marktraceur: i know, right!
[16:23:33] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add title and description as parsed properties [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81249 
[16:24:01] <kart_>	 ^d: still error in: CleanChanges and LocalisationUpdates
[16:24:04] <marktraceur>	 The stylesheets aren't HTTPS probably
[16:24:10] <kart_>	 aharoni: ^^
[16:24:13] <YuviPanda>	 marktraceur: poor choice of imagery, bad copyrighting, comic sans, plus me. I wonder how many other things can go wrong :)
[16:24:26] <aharoni>	 ^d: also arrbee
[16:24:32] <aharoni>	 since you're there
[16:24:37] <YuviPanda>	 http://i.minus.com/jRX51zHTCdnI9.png is slightly less ugly, since it doesn't have min.us ads around
[16:24:38] <marktraceur>	 YuviPanda: No, I mean, the website's JS and CSS are served from an HTTP-only server
[16:24:42] <marktraceur>	 Because they're duuuumb
[16:24:45] <bawolff>	 YuviPanda: I'm back now, what were you asking me earlier
[16:24:48] <YuviPanda>	 bawolff: http://i.minus.com/jRX51zHTCdnI9.png
[16:24:54] <YuviPanda>	 marktraceur: the campaign stuff I was telling you earlier
[16:24:58] <YuviPanda>	 err
[16:24:59] <YuviPanda>	 bawolff: ^
[16:25:00] <^d>	 aharoni: Done.
[16:25:01] <aharoni>	 thanks ^d 
[16:25:12] <YuviPanda>	 note that I am most definitely not a designer.
[16:25:13] <bawolff>	 looks pretty
[16:25:20] <kart_>	 ^d: still error in: CleanChanges and LocalisationUpdates -- too?
[16:25:21] <marktraceur>	 YuviPanda: (1) could be randomized from a category
[16:25:45] <YuviPanda>	 marktraceur: hmm, true! that sounds more maintenably than hand editing JSON
[16:25:46] <marktraceur>	 YuviPanda: Re (2) I'd definitely give it its own line and make it a bright colour
[16:26:07] <YuviPanda>	 yeah, (2) is the biggest problem there, and I'm wondering how to fix that
[16:26:08] <^d>	 kart_: Fixed.
[16:26:17] <marktraceur>	 And <3 new gallery format
[16:26:19] <bawolff>	 YuviPanda: btw, my example gallery was https://commons.wikimedia.org/wiki/User:Bawolff/Space,_the_final_fronteir
[16:26:51] <YuviPanda>	 ah, thanks bawolff
[16:26:52] <kart_>	 ^d: Thanks!
[16:26:57] <marktraceur>	 YuviPanda: Center it, make the text 1.5em or so, give it a big ol' bunch of padding, colour it green
[16:27:11] <YuviPanda>	 marktraceur: hmm, above or below the title?
[16:27:14] <bawolff>	 + the various ones on the VP
[16:27:16] <marktraceur>	 Below, I'd say
[16:27:23] <YuviPanda>	 below the description too?
[16:27:35] <marktraceur>	 Maybe put another one at the very bottom of the page
[16:27:39] <YuviPanda>	 I was going to make it as big as the desc and put it to the right but that sounds wrong
[16:27:40] <bawolff>	 I also made one on WP:VPT that was full of pictures of cats
[16:27:51] <YuviPanda>	 bawolff: haha! :D
[16:27:54] <marktraceur>	 Ooh, maybe you could float it right
[16:28:02] <YuviPanda>	 marktraceur: but it'll be on right!
[16:28:19] <marktraceur>	 *shrug* that's not a terrible consequence
[16:28:29] <YuviPanda>	 better than where it is now, perhaps
[16:28:33] * YuviPanda  makes it

[16:28:33] <bawolff>	 https://en.wikipedia.org/wiki/Wikipedia:VPT#1.22wmf13_added_new_capabilities_to_gallery_tag_-_.22they.22_need_to_update_help.2Fdocumentation
[16:28:49] <YuviPanda>	 bawolff: so when can we make that default? :D
[16:29:21] <bawolff>	 YuviPanda: There's a couple of in master that aren't live yet
[16:30:05] <bawolff>	 I figure I should try and start a vote after those hit commons (which would be sept 2)
[16:30:11] <YuviPanda>	 okay
[16:30:15] <bawolff>	 So far most people like it, with one exception
[16:30:35] <YuviPanda>	 yeah, saw that.
[16:30:59] <YuviPanda>	 the 'criticism' there reminded me of the 'we are becoming like facebook because the blue in the signup form is like facebook blue'
[16:31:47] <marktraceur>	 bawolff: https://gerrit.wikimedia.org/r/76210 I meant to come back to this but failed - I'd imagine that, in future, it'll be even more important to have database records, as we start to track the experiments more and use BetaFeatures to do so
[16:32:03] <marktraceur>	 I was just starting it out with some simple features
[16:32:57] <marktraceur>	 I can at least rewrite the preference storage, but I can see a future where historical data about versions and launches of features could be helpful
[16:33:55] <bawolff>	 I'm not opposed to a new table, it just didn't really seem needed for what it was used for so far
[16:34:01] <marktraceur>	 Right
[16:34:17] <marktraceur>	 I will need to override the handling of the fields, but yeah, that's not really a big issue
[16:34:55] <marktraceur>	 ACtually
[16:35:04] <marktraceur>	 Maybe it is, since the fields aren't currently overridden
[16:35:33] <marktraceur>	 Oh, heh, take that back
[16:35:42] * marktraceur  monologues

[16:36:21] <marktraceur>	 yhager: Hey, Yuval! :)
[16:36:45] <yhager>	 marktraceur: Morning :)
[16:36:47] <bawolff>	 I'd also rather have the auto-enrollment data be handled without resorting to an extra db query if possible
[16:36:59] <marktraceur>	 Agreed
[16:37:02] * marktraceur  does that

[16:37:14] <YuviPanda>	 bawolff: marktraceur http://i.minus.com/jbv2Hnm25PiRcV.png
[16:37:56] <marktraceur>	 YuviPanda: That's not what I said, but interesting take :)
[16:38:15] <YuviPanda>	 marktraceur: the text in the box could be customized
[16:38:18] <YuviPanda>	 to be... whatever
[16:38:29] <YuviPanda>	 also 'interesting good' or 'interesting wtf man?'
[16:38:36] <marktraceur>	 YuviPanda: Thing is, I meant the _button_ should be a bright colour, not the surrounding text
[16:38:45] <marktraceur>	 Grey button...not totally inviting
[16:38:46] <YuviPanda>	 marktraceur: sure, sure. details.
[16:38:46] <bawolff>	 YuviPanda: Always an important distinction
[16:39:00] <marktraceur>	 It's good, just not good in the same way I'd have gone :P
[16:39:02] <YuviPanda>	 marktraceur: i think that is what the comic sans is for
[16:39:12] <YuviPanda>	 marktraceur: to wave around saying 'details are not important!'
[16:39:16] <YuviPanda>	 marktraceur: colors I'll just go with mwui colors
[16:39:21] <marktraceur>	 YuviPanda: Oh, not to be inviting
[16:39:31] <marktraceur>	 Nearly made me vomit coffee on my keyboard
[16:40:57] <YuviPanda>	 marktraceur: the puke green?
[16:41:07] <YuviPanda>	 marktraceur: it's the exact same color as the JSOn structure currently :P
[16:41:42] <grrrit-wm>	 (03PS2) 10Jdlrobson: Enable Campaigns on mobile [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 
[16:44:32] <marktraceur>	 bawolff: OK, I think there's a problem with the proposed solution - true and false are the two possible stored values of an HTMLCheckField, and false gets handled somewhere in the middleware as meaning "delete this from the DB"...
[16:44:44] <marktraceur>	 I'm still digging, but if you have the magical solution
[16:45:17] <bawolff>	 oh. Didn't even think of that
[16:45:36] * marktraceur  is reassured

[16:48:59] <marktraceur>	 bawolff: I'm starting to think I should translate that into "there will need to be all manner of hacks, then"
[16:49:05] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Run Flow definitions insertion on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81253 
[16:49:17] <marktraceur>	 Like, Mark converting a check into an integer storage
[16:49:37] <bawolff>	 you're implementing a new HTMLForm, so I think it should be do-able somehow without a super amount of hacks
[16:50:15] <marktraceur>	 Not a super amount
[16:50:19] <marktraceur>	 Wait
[16:50:21] <marktraceur>	 No I'm not!
[16:50:35] <marktraceur>	 bawolff: I'm implementing an HTMLFormField subclass in Special:Preferences!
[16:50:52] <bawolff>	 that's what I meant
[16:51:47] <marktraceur>	 bawolff: The "if-false-then-delete" business is hardcoded into the User class
[16:51:53] <marktraceur>	 I'm not gonna be able to override that
[16:52:00] <marktraceur>	 I vote integers
[16:52:04] <bawolff>	 true. That part would be hacky
[16:52:10] <bawolff>	 yeah
[16:52:17] <bawolff>	 integers sounds like the way to go
[16:52:26] <bawolff>	 or something other than boolean values
[16:52:40] <marktraceur>	 Yup
[16:52:46] <marktraceur>	 Strings are unnecessarily complex
[16:53:01] <marktraceur>	 I'll just make sure there are consts to refer to the values
[16:57:23] <chrismcmahon>	 manybubbles: got time to look over some CirrusSearch test results today? 
[16:57:31] <YuviPanda>	 marktraceur: also, the strip on top won't be a carousel or anything. 
[16:57:36] <YuviPanda>	 marktraceur: just... different images everytime
[16:57:40] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Run Flow definitions insertion on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81253 (owner: 10Matthias Mullie)
[16:57:54] <marktraceur>	 Right
[16:58:04] <manybubbles>	 chrismcmahon:  yeah!  I looked at the stuff run by Jenkins and it looks like there is some kind of problem with Sauce.  I didn't look long though.
[16:58:21] <YuviPanda>	 multichill: hello! I just made http://i.minus.com/jbv2Hnm25PiRcV.png, a mockup for replacing the currently bland Campaign: pages with something useful
[17:00:18] <YuviPanda>	 multichill: bawolff so next step is... me just doing it?
[17:00:48] <bawolff>	 yeah
[17:00:57] * YuviPanda  considers sending it to design list

[17:01:48] <grrrit-wm>	 (03PS1) 10Reedy: Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 
[17:02:08] <hoo>	 oO AbuseFilter oO
[17:02:32] <chrismcmahon>	 manybubbles: running locally I had to comment out page_steps.rb lines 9&10 to get the test to run.  After doing that, the searches for File:Savepage-greyed.png etc. are all failing in beta, not sure if it's a bug or bad data though
[17:02:55] <chrismcmahon>	 manybubbles: the conditionals in there are a little nuts :-)
[17:03:42] <manybubbles>	 chrismcmahon: I'm doing some clean up of the application code now.  I
[17:04:09] <manybubbles>	 I'll see if I can smooth out some of those conditionals.
[17:04:19] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff)
[17:04:27] <grrrit-wm>	 (03CR) 10Hoo man: "Please make sure that field isn't used in any weird database queries any longer (I hope I removed all these usages) and that the special p" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy)
[17:04:55] <YuviPanda>	 marktraceur: bawolff so is that a +1 from both of you for that 'design', not counting the colors?
[17:05:18] <bawolff>	 YuviPanda: Well I'm the last person you should ask for design advice... but yes
[17:05:23] <YuviPanda>	 :P
[17:05:25] <chrismcmahon>	 manybubbles: OK, also the test for 'nobel prize' is failing but that looks to me like the app is behaving correctly by supplying 1 suggestion and the test is failing by looking for 0 suggestions
[17:05:35] <YuviPanda>	 morning, ori-l :) I expected you to be sleeping more
[17:05:47] <ori-l>	 me too, but my son had other ideas
[17:05:52] <YuviPanda>	 awww
[17:06:20] <marktraceur>	 D'aw
[17:06:59] <YuviPanda>	 ori-l: I put up the patch for redis in vagrant
[17:07:08] <manybubbles>	 chrismcmahon: maybe.... if there is a real article match it is unlikely that there is a better suggestion.  I might disable that test then until we get https://github.com/elasticsearch/elasticsearch/issues/3547
[17:07:45] <grrrit-wm>	 (03PS1) 10Dan-nl: addressing translatewiki requirements [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/81256 
[17:08:57] <ori-l>	 YuviPanda: woot, thanks, i'll look
[17:09:15] <chrismcmahon>	 manybubbles: as for Jenkins, I think the build that's running the CirrusSearch tests is horked.  Zeljko and I have been hacking on build templates and I think we broke it.   
[17:09:49] <manybubbles>	 chrismcmahon: it looks like sauce is complaining about a parameter being missing when it is there.  maybe an encoding issue.
[17:10:23] <grrrit-wm>	 (03CR) 10Reedy: "// IP address" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy)
[17:11:08] <grrrit-wm>	 (03PS1) 10Manybubbles: Reorganize. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81258 
[17:11:34] <YuviPanda>	 ori-l: I've... also been dabbling in making mockups. http://i.minus.com/jbv2Hnm25PiRcV.png for Campaign: pages :)
[17:12:25] <grrrit-wm>	 (03CR) 10Reedy: "I only see one "read" type usage in SpecialAbuseLog.php and another in ApiQueryAbuseLog.php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy)
[17:13:10] <marktraceur>	 bawolff: I guess I should also build a maintenance script to update the feature registration instead of running the query, but I'm still not sure how to start that - do we already have frameworks to do it?
[17:13:23] * marktraceur  looks at update.php

[17:13:36] <bawolff>	 We don't use update.php in production
[17:13:53] <bawolff>	 Generally people run maintinance scripts by hand
[17:13:57] <marktraceur>	 Right
[17:14:00] <Reedy>	 For 3rd party users it's nice to add it anyway
[17:14:05] <marktraceur>	 But it looks like there's an accepted way to use it
[17:14:20] <marktraceur>	 bawolff: I wouldn't be hooking into update.php, I'd be making something parallel, afaict
[17:14:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff)
[17:15:32] <bawolff>	 What updates specificly do you mean?
[17:15:39] <marktraceur>	 bawolff: Registering new features
[17:16:21] <bawolff>	 Having to run a maintinance script every time a new beta feature was introduced, would be unideal
[17:17:21] <bawolff>	 as presumably that's going to happen a lot
[17:17:42] <marktraceur>	 I don't think so
[17:17:58] <marktraceur>	 It can be run every deployment, which isn't *so* often
[17:18:35] <marktraceur>	 Nothing will happen if there aren't new features
[17:18:51] <^d>	 We're trying to make the deployment process shorter, not longer :\
[17:18:59] <^d>	 Adding a new script you have to run sounds kinda...lame
[17:19:12] <marktraceur>	 Well, I'm open to alternate suggestions
[17:19:53] <bawolff>	 Hmm.
[17:20:04] <chrismcmahon>	 manybubbles: actually the Jenkins tests failed because every search the tests ran failed.  the way the failure is reported is hard to read because of how the test is structured. 
[17:20:06] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81259 
[17:20:14] <chrismcmahon>	 manybubbles: I'm re-running that build now
[17:21:18] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81260 
[17:21:24] <bawolff>	 What precisely are the requirements here? It needs to be able to auto-enroll someone if they have auto-enrol enabled, and they haven't specifically opted out of the feature
[17:22:08] <bawolff>	 are there other things beta feature needs to do in regards to the db table?
[17:22:37] <Reedy>	 drop all the tables!
[17:22:43] * YuviPanda  drops Reedy

[17:24:46] <Aaron|home>	 binasher: https://bugzilla.wikimedia.org/show_bug.cgi?id=53400 :(
[17:26:02] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81259 (owner: 10Matthias Mullie)
[17:26:08] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81260 (owner: 10Matthias Mullie)
[17:27:09] <marktraceur>	 bawolff: I can handle "haven't seen before" on page loads
[17:27:34] <marktraceur>	 bawolff: That's not an issue, really. It's just the registration table needs to be updated with the date and version number
[17:27:55] <marktraceur>	 In the future providing a place to put e.g. use statistics and the like, but for now just providing history
[17:28:11] <marktraceur>	 Or, I could simply tear that part out of the patch and ignore it 'til it's needed. :)
[17:28:38] <binasher>	 Aaron|home: lock issues on math have been an issue for a while :( 
[17:28:50] <grrrit-wm>	 (03PS3) 10EBernhardson (WMF): Flow: Implement initial notifications for edit/rename/reply/newtopic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna)
[17:29:04] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Flow: Implement initial notifications for edit/rename/reply/newtopic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna)
[17:29:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81259 (owner: 10Matthias Mullie)
[17:29:25] <bawolff>	 marktraceur: Use statistics would probably better be accomplished by just looking at user_options table I think, I'm not sure how the proposed registration table would help with that
[17:29:51] <marktraceur>	 bawolff: More in-depth use statistics, a la eventlogging
[17:30:24] <grrrit-wm>	 (03CR) 10Raimond Spekking: "(17 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/81256 (owner: 10Dan-nl)
[17:30:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make it slightly easier for extensions to hook into page protection. [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81260 (owner: 10Matthias Mullie)
[17:31:01] * bawolff  likes idea of waiting until feature is needed before adding it

[17:31:27] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81262 
[17:32:34] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81263 
[17:33:42] <Aaron|home>	 binasher: that was actually a regression from the refactoring
[17:34:00] <Aaron|home>	 maybe it should wait till post-commit and batch the REPLACE query?
[17:34:12] <Aaron|home>	 it used to do INSERT IGNORE in the old days
[17:34:50] <Aaron|home>	 doing 100 REPLACEs and file stores in the middle of (maybe big) a parse is not too hot
[17:35:00] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/80721 (owner: 10Umherirrender)
[17:35:01] <Aaron|home>	 I saw this in dbperformance.log too
[17:35:12] * Aaron|home  also caught a double-parse regression in flaggedrevs

[17:35:19] <matanya>	 Aaron|home: can i show you something?
[17:35:39] <Aaron|home>	 ^d: btw, https://gerrit.wikimedia.org/r/#/c/81152/
[17:36:33] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81262 (owner: 10Matthias Mullie)
[17:36:42] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81263 (owner: 10Matthias Mullie)
[17:37:42] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Avoid double-parse on edit regression due to content handler [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/81152 (owner: 10Aaron Schulz)
[17:38:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not show empty metadata section on svgs [core] - 10https://gerrit.wikimedia.org/r/80721 (owner: 10Umherirrender)
[17:40:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81262 (owner: 10Matthias Mullie)
[17:40:34] <grrrit-wm>	 (03PS1) 10Bsitu: wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81264 
[17:41:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update ArticleFeedbackv5 to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81263 (owner: 10Matthias Mullie)
[17:42:28] <Aaron|home>	 matanya: that always sounds like a trap question :)
[17:42:45] <matanya>	 got Reed.y to look at it, thanks
[17:42:50] <grrrit-wm>	 (03PS1) 10Bsitu: wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81265 
[17:47:47] <grrrit-wm>	 (03CR) 10Aaron Schulz: [V: 032] Avoid double-parse on edit regression due to content handler [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/81152 (owner: 10Aaron Schulz)
[17:49:28] <grrrit-wm>	 (03PS1) 10Bsitu: Update Echo, PageTriage, Thanks to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81268 
[17:52:36] <grrrit-wm>	 (03PS1) 10Bsitu: Update Echo, PageTriage and Thanks to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81269 
[17:52:56] <grrrit-wm>	 (03PS1) 10MarkAHershberger: update param names and usage message. [tools/release] - 10https://gerrit.wikimedia.org/r/81270 
[17:53:27] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 032] Add stub to make branches for all extensions [tools/release] - 10https://gerrit.wikimedia.org/r/81226 (owner: 10MarkAHershberger)
[17:53:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add stub to make branches for all extensions [tools/release] - 10https://gerrit.wikimedia.org/r/81226 (owner: 10MarkAHershberger)
[17:54:17] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81264 (owner: 10Bsitu)
[17:54:31] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Update Echo, PageTriage, Thanks to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81268 (owner: 10Bsitu)
[17:57:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81264 (owner: 10Bsitu)
[17:58:16] * YuviPanda  pokes brion with https://gerrit.wikimedia.org/r/#/c/81162/

[17:58:21] <YuviPanda>	 and its two dependent commits
[17:59:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Echo, PageTriage, Thanks to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81268 (owner: 10Bsitu)
[18:00:57] * marktraceur  pokes YuviPanda with a large stick

[18:01:03] <marktraceur>	 Can you review this large stick for me
[18:01:11] <YuviPanda>	 hmm, it is quite sticky
[18:01:18] <marktraceur>	 Thanks, that's what I figured
[18:01:18] <YuviPanda>	 not as brown as me, of course.
[18:01:18] <YuviPanda>	 still
[18:01:43] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #264: FAILURE in 0.42 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/264/
[18:01:46] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #235: FAILURE in 0.42 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/235/
[18:01:50] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-firefox build #263: FAILURE in 0.34 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/263/
[18:01:51] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #136: FAILURE in 0.31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/136/
[18:01:52] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #236: FAILURE in 0.27 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/236/
[18:02:41] <ebernhardson>	 aude: arround?  curious about the rc_external_type column idea, primarily i'm not sure where it would be queried so not sure if we need an index
[18:05:12] <YuviPanda>	 marktraceur: thoughts on using Twig inside UploadWizard?
[18:05:21] <YuviPanda>	 mwalker: doesn't FR use Twig?
[18:05:33] <YuviPanda>	 (http://twig.sensiolabs.org/)
[18:05:38] <marktraceur>	 They do
[18:05:51] <mwalker>	 YuviPanda: yep
[18:05:52] <marktraceur>	 YuviPanda: My thought is "meh"
[18:06:01] <mwalker>	 but but but! it's soooo awesome :D
[18:06:06] <YuviPanda>	 constructing HTML by hand is so 1992!
[18:06:08] <mwalker>	 csteipp: ^ :D
[18:06:19] <marktraceur>	 YuviPanda: Yeah, and 1992 ROCKED
[18:06:32] <YuviPanda>	 marktraceur: I was only a year old, so... :P
[18:06:45] <YuviPanda>	 mwalker: any reason why it isn't being used in other places?
[18:07:00] <mwalker>	 monsieur steipp has yet to do a CR on it
[18:07:00] <marktraceur>	 https://en.wikipedia.org/wiki/Billboard_Top_Hits:_1992
[18:07:09] <marktraceur>	 Baby Got Back AND I'm Too Sexy
[18:07:13] <marktraceur>	 Can't get much better than that
[18:07:17] <YuviPanda>	 mwalker: oh, on moving it to core?
[18:07:30] <marktraceur>	 The Genesis track is just icing on the cake
[18:07:32] <mwalker>	 well; integerating it into an extension and then deploying it on the cluster
[18:07:33] <YuviPanda>	 marktraceur: I don't recognize any of the songs, nor the artists
[18:07:37] <marktraceur>	 Shaaaame
[18:07:40] <YuviPanda>	 mwalker: oh?
[18:07:52] <mwalker>	 right now fundraising really only gets away with it because we control everything
[18:07:55] <marktraceur>	 YuviPanda: https://www.youtube.com/watch?v=kY84MRnxVzo&webm=true
[18:08:02] <mwalker>	 and even then... it's not used for anything critical / user facing
[18:08:34] <mwalker>	 erm; not true that actually -- we do use it in unsubscribe
[18:08:39] <multichill>	 YuviPanda: Back
[18:08:55] <YuviPanda>	 multichill: http://i.minus.com/jbv2Hnm25PiRcV.png
[18:09:02] <mwalker>	 there's also a question of; what does a templating language do for you that HTMLForms does not?
[18:09:06] <marktraceur>	 YuviPanda: I like the idea of templating. But including a huge external library in our repo is always a pain point and I want to be careful about it.
[18:09:13] <YuviPanda>	 mwalker: it reduces the amount of PHP I've to write?
[18:09:18] <YuviPanda>	 mwalker: plus, I'm trying to recreate http://i.minus.com/jbv2Hnm25PiRcV.png
[18:09:23] <ebernhardson>	 what version are we on?  1.23?
[18:09:23] <YuviPanda>	 mwalker: I don't think HTMLForms is meant for that
[18:09:36] <ebernhardson>	 (or what do we call the current version i mean)
[18:09:41] <multichill>	 Yes, looked at it, for which tool exactly?
[18:10:06] <marktraceur>	 YuviPanda: I'd almost feel better if it were a core thing that UW just uses
[18:10:10] <marktraceur>	 ALmost.
[18:10:15] <mwalker>	 YuviPanda: fair point; if all you're doing is composition twig will work -- if you're creating forms though; dont use it -- use HTMLForm because there's a lot of additional protection baked in
[18:10:15] <marktraceur>	 Wait.
[18:10:24] <marktraceur>	 Doesn't the new login form do some templating?
[18:10:35] <marktraceur>	 spagewmf, sup<tab><tab><tab>
[18:10:36] <mwalker>	 ya, spage wrote a new HTMLForm style
[18:10:40] <YuviPanda>	 multichill: not a tool as such, just a replacement for what you  see when you go to https://commons.wikimedia.org/wiki/Campaign:wlm-nl
[18:10:40] <YuviPanda>	 multichill: so you can actually point people to that URL and ask them to contribute, rather than how it is now
[18:10:48] <marktraceur>	 Ah, cool
[18:11:01] <marktraceur>	 YuviPanda: Maybe ask spagewmf if he can generalize it, or if he already has, and use that?
[18:11:04] <YuviPanda>	 mwalker: right, and I don't see any forms there. So I should be okay?
[18:11:05] <multichill>	 Oh right, nice :-)
[18:11:22] <YuviPanda>	 multichill: might not land in time for WLM though, but perhaps later stages.
[18:11:36] <mwalker>	 YuviPanda: so long as chris says OK
[18:11:47] <mwalker>	 which I would love
[18:11:55] <mwalker>	 because then it means I can move more things to Twig :)
[18:12:00] <mwalker>	 like all of our donation forms :D
[18:12:13] <YuviPanda>	 hey csteipp. is using Twig okay, as long as I don't do anything form-y in it? and make sure I escape all the things that need escaping?
[18:12:16] <spagewmf>	 marktraceur: whasSUP<tab><tab><tab> ?
[18:12:29] <marktraceur>	 spagewmf: We were just talking about templating engines
[18:12:42] <YuviPanda>	 mwalker: marktraceur you know that MobileFrontend uses JS templates a lot, right?
[18:12:45] <csteipp>	 YuviPanda: I've been meaning to take a look at the library, and unfortunately haven't been able to yet
[18:12:45] <marktraceur>	 spagewmf: YuviPanda wants to use one for UploadWizard work he's doing
[18:12:55] <marktraceur>	 YuviPanda: What system do you use?
[18:13:05] <spagewmf>	 I like HandlebarsJS but whatdoiknow
[18:13:08] <YuviPanda>	 mwalker: hogan.js, I think. I don't like that one.
[18:13:14] * marktraceur  is familiar with PURE and...something else, I forget

[18:13:15] <YuviPanda>	 it might be handlebars.js
[18:13:18] <YuviPanda>	 not sure :P
[18:13:25] <marktraceur>	 There are officially too many
[18:13:34] <YuviPanda>	 one of the moustachey ones
[18:13:41] <marktraceur>	 YuviPanda: A JS templating system would be way more appropriate for UW
[18:13:52] <marktraceur>	 But alas, that's way down the road.
[18:14:11] <YuviPanda>	 csteipp: well, it's rather big and I guess it'll take a good chunk of time to do it. Can I just use it for templating, avoid doing anything form-y, and we can review it before it gets merged?
[18:14:25] <YuviPanda>	 please? :D
[18:14:52] <YuviPanda>	 mwalker: btw, if you liked twig, look at swig, which is twig but in JS!
[18:14:52] <csteipp>	 YuviPanda: You're free to, but of course if it takes some time to get the review done, you're ok waiting, right?
[18:15:05] <csteipp>	 Also, if it fails, you're ok with rewriting it, right?
[18:15:07] <spagewmf>	 there's always MediaWiki includes/templates/ :)  "PHPTAL without any features" AFAICT
[18:15:20] <mwalker>	 PHPTAL; ick1
[18:15:35] <YuviPanda>	 csteipp: hmm, depends on what exactly are things you're looking for? If it is just XSS issues you want to look at and make sure it is okay, I'm okay with that.
[18:15:36] <marktraceur>	 Another day, another library flamewar :P
[18:15:39] <grrrit-wm>	 (03PS1) 10EBernhardson (WMF): Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 
[18:15:48] <YuviPanda>	 csteipp: since I can help fix anything we discover in the library, and I'm sure otherw sill too
[18:17:15] <YuviPanda>	 csteipp: but will you be looking for things that aren't XSS primarily? I'm trying to think of what else could be security issues in a template library
[18:17:19] <csteipp>	 YuviPanda: The major issue is XSS in the library, if you're using it correctly. But also does the library open up anything else on our servers (I'm pretty sure it's a no, but we'll need to check). The last, and most risky is does it encourage good security from our devs. That will be a bigger evaluation.
[18:17:58] <grrrit-wm>	 (03PS7) 10MarkTraceur: Add convenience functions, fix auto-enroll [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 
[18:18:04] <YuviPanda>	 csteipp: in that case I'm okay, since I think XSS in the library can be fixed, it shouldn't really open up anything else in our servers, and for the third, anything is better than hand concatenating HTML :)
[18:18:22] <mwalker>	 YuviPanda: ish; a lot of our HTML functions autoescape things
[18:18:37] <mwalker>	 twig allows you to shoot yourself in the foot if you're not careful
[18:18:54] <YuviPanda>	 if you're hand-concatenating HTML, you can shoot yourself in the head just as easily
[18:18:54] <ebernhardson>	 mwalker: but at least you can look at a twig file and know what comes out the other end :)
[18:18:59] <YuviPanda>	 at least with twig it'll be *obvious*
[18:19:02] <grrrit-wm>	 (03PS2) 10Manybubbles: Test remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 
[18:19:03] <mwalker>	 true
[18:19:07] <csteipp>	 Exactly. YuviPanda, the (very low) bar is our templating library in MW
[18:19:21] <csteipp>	 Sadly, I'm not sure if twig is above or below it
[18:19:24] <marktraceur>	 YuviPanda: If you're literally doing anything with HTML by hand, you're doing something pretty wrong
[18:19:30] <csteipp>	 +1]
[18:19:33] <YuviPanda>	 marktraceur: see also: a lot of mediawiki :P
[18:19:39] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Merging after manual rebase after Chad approved it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 (owner: 10Manybubbles)
[18:19:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 (owner: 10Manybubbles)
[18:19:47] <marktraceur>	 I mean, carrying HTML elements around a factory or something
[18:19:52] <marktraceur>	 None of this is "by hand"
[18:20:01] <marktraceur>	 It's all magic
[18:20:07] <YuviPanda>	 Xml:: whatever is still 'by hand'
[18:20:10] <ebernhardson>	 marktraceur: but equally, many of us beleive generating one element at a time with functions is equally madness
[18:20:13] <YuviPanda>	 it's a very horrible excuse for magic
[18:20:30] <marktraceur>	 ebernhardson: Hey man, I love me some document.createElement
[18:20:39] <YuviPanda>	 csteipp: I'm just checking if twig does something really stupid, like compile to PHP and then execute :)
[18:20:48] <ebernhardson>	 marktraceur: it reminds me of programming windows back in the 90's to generate all those html tags one at a time
[18:20:51] <YuviPanda>	 heh, it says 'secure' in the title! can't be wrong!
[18:20:53] <csteipp>	 YuviPanda: I disagree. I see far less people mess up with Xml:: than with concating.
[18:21:04] <csteipp>	 YuviPanda: NOt that I know of
[18:21:08] <ebernhardson>	 marktraceur: when i had to create each and every individual widget and it was freaking horrible
[18:21:14] <YuviPanda>	 csteipp: oh, I'm not saying Xml:: is as bad as concatenating. Just not that much better
[18:21:16] <marktraceur>	 Ugh, terrible
[18:21:34] <YuviPanda>	 it might be safer, but it still makes you want to stab yourself in your face.
[18:21:37] <mwalker>	 twig does compile down to PHP
[18:22:05] <marktraceur>	 As opposed to stabbing yourself in mwalker's face
[18:22:07] <wmf-selenium-bot>	 Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #2: FAILURE in 8 min 29 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/2/
[18:22:10] <ebernhardson>	 i'm personally a big fan of twig,  to be convinced it really is bad i would probably need some example code that "looks correct" but generates some sort of XSS
[18:22:22] <grrrit-wm>	 (03PS2) 10Kaldari: Adding allunread param to API for retrieving all unread messages (up to $wgEchoMaxNotificationCount) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81157 
[18:22:34] <YuviPanda>	 I'm a big fan of not generating HTML 'by hand' - aka anything that's not a template. +1 to ebernhardson
[18:22:43] <spagewmf>	 If all you want from templating is localized strings within a chunk of HTML, there's 2011's undocumented http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jquery.localize
[18:22:46] <YuviPanda>	 ebernhardson: it could be used in Flow! :) 
[18:23:06] <YuviPanda>	 spagewmf: I'm going to try implementing http://i3.minus.com/jbv2Hnm25PiRcV.png, and I don't want to do that without a templating engine
[18:23:09] <ebernhardson>	 YuviPanda: we actually have a very tiny templating abstraction waiting to be replaced with twig :)
[18:23:16] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81157 (owner: 10Kaldari)
[18:23:17] <ebernhardson>	 YuviPanda: but i wasn't about to just pull it in
[18:23:30] <YuviPanda>	 ebernhardson: well, we can replace it and then csteipp will have two extensions to look at? :D
[18:23:33] <YuviPanda>	 more code is always better
[18:23:45] <YuviPanda>	 and also more people working on it means it'll be faster to spot actual issues
[18:23:48] <YuviPanda>	 and discard twig if needed
[18:23:52] <YuviPanda>	 or use it more widely if appropriate
[18:24:37] <hoo>	 https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/TemplateRegistry.php
[18:24:39] <YuviPanda>	 ebernhardson: have you looked at client side templating?
[18:24:47] <ebernhardson>	 YuviPanda: seems reasonable, havn't looked at client side though no
[18:24:54] <hoo>	 Wikibase uses that for html-templates
[18:24:57] <spagewmf>	 YuviPanda do you want to template in JS or on the server, or both
[18:25:07] <YuviPanda>	 spagewmf: server now, js later?
[18:25:20] <ebernhardson>	 YuviPanda: i've used twig, but if there was something that did both php and js tempating would be interesting as well,  in flow we resorted to rendering in the backend and delivering html over ajax (Eww)
[18:25:53] <hoo>	 that's the JS side implementation of that: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/resources/templates.js
[18:26:04] <YuviPanda>	 ebernhardson: you could do that with twig + swig - or any of the moustache 'logicless' *gaargahsg* templating libraries that have implementations in php
[18:26:39] <YuviPanda>	 csteipp: looks like there's at least 3 implementations of templating floating around - wikidata, the one spagewmf linked to, and the abstraction ebernhardson is using. Not to mention QuickTemplate, and the templating stuff MobileFrontend uses.
[18:27:18] <YuviPanda>	 so would be nice to pick one :)
[18:27:45] <ebernhardson>	 flow isn't using anything amazing atm, just a thin layer to separate controllers from views: https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/includes/Templating.php
[18:27:59] <ebernhardson>	 (thats already having random hacks added, would be nice to have something architected :)
[18:28:01] <hoo>	 Please, just don't introduce one of the super fancy template engines... I dislike them
[18:28:22] <marktraceur>	 hoo|away: While you were out, we ported all of MediaWiki to Django templates
[18:28:25] <marktraceur>	 Muahahaha
[18:28:28] <csteipp>	 YuviPanda: We're definitely looking at standardizing on one, and twig is a contender. It just hasn't been through much evaluation yet, so if we decide to go with something else, I just want to make sure you're warned :)
[18:28:33] * YuviPanda  pokes brion with https://gerrit.wikimedia.org/r/#/c/81249/ and https://gerrit.wikimedia.org/r/#/c/81247 and  https://gerrit.wikimedia.org/r/#/c/81162

[18:28:37] <mwalker>	 all the libraries I've seen that do both js and PHP templating suck -- we should use two good ones if we decide we need it -- fundamentally they answer different things
[18:28:41] <brion>	 moment
[18:28:43] <hoo|away>	 marktraceur: :P
[18:28:46] <YuviPanda>	 +1 to mwalker
[18:28:53] <YuviPanda>	 csteipp: :) okay! 
[18:29:01] <hoo|away>	 I actually like the Wikibase version best, it's very simple
[18:29:05] <marktraceur>	 YuviPanda: Jeez, yer persistent today :P
[18:30:03] <YuviPanda>	 csteipp: but inventing our own is not preferred, right? :)
[18:30:12] <csteipp>	 Not at all
[18:30:33] <grrrit-wm>	 (03PS5) 10Burthsceh: Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 
[18:30:44] <YuviPanda>	 marktraceur: I think I've just gotten back from post-hongkong sickness :)
[18:30:52] <hoo|away>	 csteipp: Did you see the Wikibase one? It's the simplest possible, that's why I like it...
[18:30:58] <mwalker>	 YuviPanda: but we clearly need a awesome web 3.5 ajaxified dynamic relfective superawesomepossume totally custom purple templating engine!
[18:31:29] * YuviPanda  makes a unicorn fall on mwalker

[18:31:30] <ebernhardson>	 hoo|away: DOS 1.0 is simple too.  Simple doesn't always get the job sdone
[18:31:48] <hoo|away>	 Well, over here it does... in a reasonable fast and secure way
[18:31:48] <ebernhardson>	 hoo|away: not saying it has to be complex, but 'simple as possible' isnt a very good requirement imo
[18:32:06] <hoo|away>	 simple as possible (if it still fits the job)
[18:32:11] <YuviPanda>	 hey, let's not start bikeshedding already!
[18:32:15] <ebernhardson>	 :P
[18:32:48] <hoo|away>	 YuviPanda: They mustn't use empty in there code!!!!! :P
[18:32:57] <hoo|away>	 really away now ;)
[18:33:35] <YuviPanda>	 heh
[18:35:35] <grrrit-wm>	 (03PS1) 10Ori.livneh: Correct StatsD metric format [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81281 
[18:35:58] <YuviPanda>	 marktraceur: now you've jinxed it, and I'm not being persistent anymore :P
[18:36:08] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Correct StatsD metric format [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81281 (owner: 10Ori.livneh)
[18:36:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct StatsD metric format [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/81281 (owner: 10Ori.livneh)
[18:38:39] <marktraceur>	 Muahaha
[18:39:47] <mwalker>	 one of the reasons I'm not a great fan of 'simple' templating engines is because I like the concept of having MW callbacks in twig templates -- for things like message or wikitext expansion
[18:40:26] <mwalker>	 it also allows you to pass common structures into twig and then the frontend layer can extract/format it as it needs in place
[18:40:54] <grrrit-wm>	 (03PS9) 10Rahul21: Reuse mw.UploadWizard.config in mw.LanguageUpWiz so that "config" details are not loaded directly from the server [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 
[18:40:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reuse mw.UploadWizard.config in mw.LanguageUpWiz so that "config" details are not loaded directly from the server [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21)
[18:42:44] <aude>	 hi euvl 
[18:42:46] <aude>	 errr
[18:42:49] <aude>	 ebernhardson: 
[18:43:36] <aude>	 ebernhardson: have you looked at adding the column or is that something you like us to make a patch for?
[18:43:50] <ebernhardson>	 aude: i made a patch(and added you to gerrit)
[18:43:57] <aude>	 cool
[18:43:58] <ebernhardson>	 aude: https://gerrit.wikimedia.org/r/#/c/81277/
[18:44:02] <aude>	 k
[18:44:04] <ebernhardson>	 aude: may need an index though, not sure
[18:44:05] <grrrit-wm>	 (03PS1) 10Manybubbles: Disable a test until an upstream bug is fixed. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81283 
[18:44:17] <ebernhardson>	 aude: with 7 indexes the table already, i'm a little leary of adding more
[18:44:37] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81265 (owner: 10Bsitu)
[18:44:38] <aude>	 having an index for rc_type would be good
[18:44:56] <aude>	 after that, not sure about rc_external_type
[18:45:28] <grrrit-wm>	 (03PS11) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 
[18:45:32] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Update Echo, PageTriage and Thanks to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81269 (owner: 10Bsitu)
[18:45:36] <grrrit-wm>	 (03CR) 10MarkTraceur: "Rebase" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur)
[18:45:39] <ebernhardson>	 aude: hmm, well i we already add an rc_type index, rc_type, rc_external_type is only slightly more work
[18:46:16] <ebernhardson>	 aude: (at the db layer, the main addition of IO comes from the index purely existing, i think indexing a second field is minor comparatively)
[18:47:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: wpUndidRevision should be passed along during 'preview' and 'diff' [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81265 (owner: 10Bsitu)
[18:49:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Echo, PageTriage and Thanks to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81269 (owner: 10Bsitu)
[18:50:02] <aude>	 ebernhardson: patch looks fine, although i'd like it to also work with postgres
[18:50:10] <aude>	 if you need help with that...
[18:50:10] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "PS3 works and is less wordy than xpath, so I'm approving." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage)
[18:51:00] <ebernhardson>	 aude: heh, i almost did postgres but decided since its compeltely different (the updater doesn't work off patch files) and i dont have anything to test it with i would leave it for a postgres person :)
[18:51:22] <aude>	 ok, i could make an additional patch
[18:51:40] * aude  knows nothing about oracle but can do postgres :)

[18:52:05] <ebernhardson>	 aude: oh, well i strictly guessed that oracle works :)  i did test sqlite and mysql though
[18:52:14] <aude>	 those are the most important
[19:00:09] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh)
[19:09:13] <grrrit-wm>	 (03PS1) 10Hashar: pywikibot/core test job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 
[19:12:11] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "Appears to not explode. Yay!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81162 (owner: 10Yuvipanda)
[19:12:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use parsedConfig instead of rawConfig wherever possible [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81162 (owner: 10Yuvipanda)
[19:12:45] <YuviPanda>	 marktraceur: bawolff emailed the design list for good measure
[19:13:06] * bawolff  did what?

[19:13:13] <YuviPanda>	 err
[19:13:24] <YuviPanda>	 marktraceur, bawolff: emailed the design list for good measure
[19:13:28] <YuviPanda>	 autocomplete, etc
[19:13:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "No explosions in testing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81247 (owner: 10Yuvipanda)
[19:13:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename getConfig to getRawConfig, to be more explicit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81247 (owner: 10Yuvipanda)
[19:13:50] <bawolff>	 oh. In that case, sounds good
[19:14:12] <grrrit-wm>	 (03CR) 10Bsitu: [C: 031] "Tested on different browsers and it seemed to be working fine." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77824 (owner: 10Matmarex)
[19:15:09] <grrrit-wm>	 (03PS6) 10Burthsceh: Rewite class MovePageForm on SpecialMovepage.php [core] - 10https://gerrit.wikimedia.org/r/80764 
[19:15:22] <brion>	 YuviPanda: do title and description not go under 'display'?
[19:15:32] <YuviPanda>	 brion: no, because they're more general, no?
[19:15:46] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "(5 comments)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[19:15:46] <YuviPanda>	 brion: plus I'd want to eventually kill 'display' anyway.
[19:15:53] <brion>	 hmm
[19:15:59] <brion>	 reminds me: multilingual support?
[19:16:20] <brion>	 might be easier if the strings are encapsulated
[19:17:08] <YuviPanda>	 brion: there's already multilingual support!
[19:17:13] <YuviPanda>	 brion: that's why they're all wikitext.
[19:17:24] <YuviPanda>	 brion: you can add uselang=de to your API call and they'll 'work as they are supposed to'
[19:17:29] <brion>	 \o/ excellent
[19:17:30] <YuviPanda>	 brion: when coupled with <translate> and Mediawiki: pages
[19:17:37] <brion>	 ok that makes things simpler
[19:17:40] <YuviPanda>	 brion: indeed!
[19:17:46] <YuviPanda>	 brion: no new translation mechanism added :)
[19:17:53] <brion>	 i gotta catch up on <translate>, sounds like it's a big improvement on translatable pages over the old scary templates
[19:17:58] <YuviPanda>	 brion: although when this starts being used a lot more, it'll need caching
[19:18:05] <YuviPanda>	 brion: I've no idea what <translate> does, though :D
[19:18:15] <MatmaRex>	 bsitu: who's going to +2 that if not you? :P
[19:18:57] <MatmaRex>	 bsitu: actually, serious question, who else is working on echo?
[19:19:29] <MatmaRex>	 kaldari and werdna have lots of commits, but i vaguely recall somebody talking about them moving to something else inside wmf
[19:20:03] <Nikerabbit>	 plop
[19:22:54] <bsitu>	 MatmaRex: first question: I am not very good at CSS/html, I am hoping someone in that thread who are specialized in this area who merge it.
[19:23:03] <bsitu>	 2nd question: only me officially
[19:23:03] <grrrit-wm>	 (03CR) 10Dbeeson: "(23 comments)" [extensions/SemanticMediaWiki] (1.8.x) - 10https://gerrit.wikimedia.org/r/70047 (owner: 10Dbeeson)
[19:23:20] <bsitu>	 3rd question: lots of commits for?
[19:23:59] <MatmaRex>	 for echo
[19:24:08] <MatmaRex>	 >git log --format=format:%ae | sort | uniq -c | sort -n
[19:24:31] <MatmaRex>	 kaldari has 162, werdna has 46
[19:24:45] <MatmaRex>	 (actually, this counts merges as well)
[19:24:50] <MatmaRex>	 you have 159
[19:25:15] <bsitu>	 MatmaRex: kaldari transitioned to the mobile team recently
[19:25:19] <MatmaRex>	 without mreges it's 121, 39 and 130
[19:25:42] <MatmaRex>	 ah. okay
[19:25:58] <grrrit-wm>	 (03CR) 10Brion VIBBER: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[19:26:03] <bsitu>	 werdna developed the fundamental for echo, but then left to school and he is now working on flow
[19:26:21] <MatmaRex>	 also, only one person? not too fun, i guess
[19:44:17] <YuviPanda>	 brion: merge for https://gerrit.wikimedia.org/r/#/c/81249/? :)
[19:44:20] <grrrit-wm>	 (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[19:47:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Add title and description as parsed properties [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81249 (owner: 10Yuvipanda)
[19:47:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add title and description as parsed properties [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81249 (owner: 10Yuvipanda)
[19:47:25] <YuviPanda>	 brion: \o/ ty
[19:47:50] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81367 
[19:52:06] <grrrit-wm>	 (03PS1) 10Anomie: Improve linkprefix regular expressions [core] - 10https://gerrit.wikimedia.org/r/81368 
[19:52:09] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Remove explicit direction: ltr [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/80708 (owner: 10Amire80)
[19:52:57] <grrrit-wm>	 (03CR) 10Anomie: "I know that https://www.mediawiki.org/wiki/I18n#Changing_existing_messages says to change only the English message, even if "you're only c" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie)
[19:54:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove explicit direction: ltr [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/80708 (owner: 10Amire80)
[19:55:54] <MatmaRex>	 Krenair: 'round?
[19:58:04] <MatmaRex>	 Krenair: i need somebody brave to merge https://gerrit.wikimedia.org/r/#/c/77824/ :D
[19:58:19] * marktraceur  yells, charges at patch

[19:58:37] <MatmaRex>	 Krenair: and i see oyu have a few merges in Echo
[19:58:44] <MatmaRex>	 marktraceur: please do
[19:58:54] <MatmaRex>	 and please don't recoil in horror before you read the entire commit message ;)
[19:59:05] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81367 (owner: 10MaxSem)
[19:59:34] <marktraceur>	 Working on it
[20:01:39] <bawolff>	 MatmaRex: I like the rhetorical questions in a commit message ;)
[20:02:34] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Make MOTD banner fit in 80 chars. [vagrant] - 10https://gerrit.wikimedia.org/r/77834 (owner: 10BryanDavis)
[20:02:53] <YuviPanda>	 ori-l: are you looking at vagrant patches now?
[20:02:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make MOTD banner fit in 80 chars. [vagrant] - 10https://gerrit.wikimedia.org/r/77834 (owner: 10BryanDavis)
[20:03:04] <MatmaRex>	 bawolff: :D
[20:03:26] <ori-l>	 YuviPanda: yeah, but I'm going to run the redis patch locally for a few days before I merge it
[20:03:31] <MatmaRex>	 that is probably the best commit message i;ve ever written.
[20:03:36] <MatmaRex>	 it has footnotes and attachments, man!
[20:03:47] <YuviPanda>	 ori-l: sounds prudent. I'll poke you again by thurdsay?
[20:03:52] <ori-l>	 YuviPanda: dea
[20:03:53] <ori-l>	 l
[20:05:17] <marktraceur>	 MatmaRex: Sadly I'm off to a meeting for a bit, but I'll look at it when I'm done
[20:05:56] <quiddity>	 MatmaRex, will gerrit 77824 fix the problem with popups?  https://bugzilla.wikimedia.org/show_bug.cgi?id=53291
[20:06:19] <MatmaRex>	 quiddity: possibly, depending on how popups work
[20:06:34] <quiddity>	 nifty. fingers crossed.
[20:06:48] <MatmaRex>	 quiddity: if they don't trigger on the small links in the flyout, then probably not, though
[20:07:01] <quiddity>	 ah, foo.
[20:07:18] <grrrit-wm>	 (03PS1) 10CSteipp: Enforce wgSecureLogin for login pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81373 
[20:09:42] <MatmaRex>	 quiddity: hmmm
[20:09:47] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Enforce wgSecureLogin for login pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81373 (owner: 10CSteipp)
[20:10:03] <MatmaRex>	 quiddity: actually, it looks like Echo is really nice for us and written in a way that'd make this quite easy to fix on popups' side
[20:10:08] <grrrit-wm>	 (03CR) 10Bsitu: "Hey Kaldari" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77824 (owner: 10Matmarex)
[20:10:22] <MatmaRex>	 quiddity: i'll comment on the bug
[20:10:25] <quiddity>	 <3
[20:11:30] <ori-l>	 brion: do you have any suggestions as far as XML schema for recent changes go? I looked at the dump schema and at the atom spec but I got a brain freeze.
[20:11:47] <brion>	 heh
[20:12:17] <brion>	 ori-l: make something up and i'll make some comments on it :)
[20:12:28] <brion>	 our xml dump schema has a certain benefit of reuse, but it's not ideal for log entries i think
[20:12:34] <ori-l>	 that should be the motto of gerrit
[20:12:35] <ori-l>	 in latin
[20:12:46] <MatmaRex>	 quiddity: and actually, it looks like popups ain't half-bad in this regard, too
[20:12:47] <brion>	 but… i think we do have a log extension for dumps since a couple years back, so maybe it would work :D
[20:13:23] <quiddity>	 ori-l, et faciam ut aliquid ex ea commentatur  (according to google translate)
[20:13:32] <ori-l>	 <3
[20:13:52] <ori-l>	 maybe DarTar can check it
[20:13:57] <MatmaRex>	 quiddity: i'll probably make an editprotected request instead, it's going to be easier to write the code myself than try to explain this, as the feature i'm going to use is noit exactly documented yet
[20:14:25] <MatmaRex>	 quiddity: are popups supposed to work with earlier versions of mediawiki?
[20:14:39] <MatmaRex>	 (i know hotcat is intended to work with anything from 1.15 onward or something)
[20:14:42] <quiddity>	 MatmaRex,  that'd be ideal. Nobody else has commented on the enwiki thread, but it's a hugely widely used gadget (across most wikis, afaik)
[20:14:45] <DarTar>	 check in on Latin or xml dumps?
[20:15:08] <quiddity>	 MatmaRex,  I'm not sure about any technical details. Sorry.
[20:15:16] * DarTar  waves at quiddity 

[20:15:21] <grrrit-wm>	 (03PS3) 10Dbeeson: Fixes RDF export of subobjects [extensions/SemanticMediaWiki] (1.8.x) - 10https://gerrit.wikimedia.org/r/70047 
[20:15:28] <quiddity>	 o/
[20:15:51] <DarTar>	 ori-l: chat?
[20:16:05] <ori-l>	 DarTar: sure, sec
[20:16:22] <ori-l>	 brion: thanks, btw -- i'll look up the older work and take a stab at updating it
[20:17:51] <grrrit-wm>	 (03PS4) 10Cmcmahon: Fix Cucumber/Watir/Cheezy locator for edit_ve [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage)
[20:19:39] <grrrit-wm>	 (03PS5) 10Cmcmahon: Fix Cucumber/Watir/Cheezy locator for edit_ve [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage)
[20:20:46] <grrrit-wm>	 (03PS1) 10Adamw: run lint jobs on wikimedia/fundraising/tools [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 
[20:22:08] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "mergin..." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage)
[20:25:49] <grrrit-wm>	 (03PS2) 10MarkTraceur: Throw errors if required fields missing [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 
[20:27:56] <grrrit-wm>	 (03CR) 10Chad: [C: 032] "The duplication between here and core is sickening, but we need this now." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81373 (owner: 10CSteipp)
[20:27:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enforce wgSecureLogin for login pages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81373 (owner: 10CSteipp)
[20:28:31] <grrrit-wm>	 (03PS1) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 
[20:30:03] <grrrit-wm>	 (03PS1) 10Chad: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81380 
[20:31:02] <grrrit-wm>	 (03PS1) 10Chad: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81381 
[20:31:46] <grrrit-wm>	 (03PS2) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 
[20:32:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81381 (owner: 10Chad)
[20:32:56] <mwalker>	 GorillaWarfare: ^ yay!
[20:33:06] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81380 (owner: 10Chad)
[20:33:08] <GorillaWarfare>	 :)
[20:33:35] <GorillaWarfare>	 Still poking at it
[20:33:38] <GorillaWarfare>	 But it should do
[20:35:35] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix link generator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81383 
[20:36:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81381 (owner: 10Chad)
[20:38:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81380 (owner: 10Chad)
[20:38:25] <mwalker>	 GorillaWarfare: awesome; I'm slowly poking at your last large patch -- but I have a large disaster elsewhere I'm trying to avoid exploding
[20:38:37] <mwalker>	 I should have it back to you by the eod though
[20:38:47] <GorillaWarfare>	 No rush
[20:38:58] <GorillaWarfare>	 Plenty of things to work on in the interim
[20:39:23] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81384 
[20:39:39] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81384 (owner: 10MaxSem)
[20:42:36] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Fix link generator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81383 (owner: 10Matthias Mullie)
[20:45:02] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Disable a test until an upstream bug is fixed. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81283 (owner: 10Manybubbles)
[20:45:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable a test until an upstream bug is fixed. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81283 (owner: 10Manybubbles)
[20:45:22] <manybubbles>	 thaks ^d
[20:45:43] <manybubbles>	 it looks like that BacklinkCache is causing tests to fail in beta
[20:46:09] <manybubbles>	 I'm gonna ruminate on that for a bit
[20:46:12] <MatmaRex>	 quiddity: awww yeah, i've got this. are you possibly an admin on en.wp? :D
[20:46:14] <Krenair>	 MatmaRex, I'm not happy with that patch
[20:46:18] <quiddity>	 fraid not
[20:46:36] <Krenair>	 Creating DOM which we know is not valid HTML is a bad idea
[20:46:43] <Krenair>	 dom elements*
[20:46:54] <MatmaRex>	 Krenair: because?
[20:47:22] <ebernhardson>	 well, IE6 is the classical reason for 'why shouldn't we do supported but non-standard things'
[20:47:23] <MatmaRex>	 Krenair: it's valid XHTML, and it works everywhere in HTML mode, too.
[20:47:33] <MatmaRex>	 (even IE6)
[20:47:55] <ebernhardson>	 i didnt mean IE6 support, i mean IE6 did all kinds of things non-standard and we all had to pay for it for +- 10 years
[20:48:20] <ebernhardson>	 but this instance is perhaps isolated, shrug.  i'm ok either way :P
[20:48:31] <quiddity>	 thedj, are you there? If so (or if seen later) pls see the discussion between MatmaRex  and myself 35 minutes prior to this, and just above.
[20:49:32] <MatmaRex>	 quiddity: i'm submitting editprot request
[20:49:39] <MatmaRex>	 quiddity: turns out that what i did has already been suggested :D
[20:49:56] <quiddity>	 ha! great minds think alike?
[20:50:08] <legoktm>	 Krenair: Hey, could you set the default branch of https://github.com/wikimedia/pywikibot-externals-httplib2 to be "master"?
[20:50:30] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81392 
[20:50:38] <legoktm>	 (or anyone with access to the github stuff)
[20:50:47] <MaxSem>	 bsitu, is the  Echo bug with jobs known?
[20:50:52] <grrrit-wm>	 (03PS5) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 
[20:51:03] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81392 (owner: 10MaxSem)
[20:51:16] <Krenair>	 legoktm, how did it become 'origin' in the first place?
[20:51:26] <bsitu>	 MaxSem: not known, what bug is it?
[20:51:29] <legoktm>	 because the first branch that was pushed was origin
[20:51:36] <legoktm>	 so github automatically picked that up as the default
[20:51:43] <MaxSem>	 bsitu, I'll post to BZ then
[20:51:59] <bsitu>	 MaxSem: okay, thx
[20:53:47] <Krenair>	 legoktm, I think that makes sense then. done.
[20:53:53] <legoktm>	 thanks
[20:54:20] <MatmaRex>	 quiddity: thedj: https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-popups.js#Use_the_.27wikipage.content.27_hook
[20:55:14] <quiddity>	 MatmaRex, fantastic :)
[20:56:03] <MaxSem>	 bsitu, https://bugzilla.wikimedia.org/show_bug.cgi?id=53425
[20:57:48] <hoo>	 Krinkle: Where's the doc. for the new mw.hooks, btw? Is there anything within the source itself?
[20:59:02] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81395 
[20:59:18] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81395 (owner: 10MaxSem)
[21:00:27] <grrrit-wm>	 (03PS1) 10Aude: postgresql schema update for rc_external_type column [core] - 10https://gerrit.wikimedia.org/r/81396 
[21:03:20] <grrrit-wm>	 (03CR) 10Hoo man: "(1 comment)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man)
[21:04:30] <grrrit-wm>	 (03CR) 10Brian Wolff: "bump" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff)
[21:05:50] <aude>	 ebernhardson: i am trying to rebase https://gerrit.wikimedia.org/r/#/c/81396/ so it depends on your patch
[21:06:05] * aude  try to do that right

[21:06:15] <grrrit-wm>	 (03PS2) 10Aude: postgresql schema update for rc_external_type column [core] - 10https://gerrit.wikimedia.org/r/81396 
[21:06:16] <grrrit-wm>	 (03PS2) 10Aude: Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF))
[21:06:29] <aude>	 ok, it worked
[21:06:40] <ebernhardson>	 aude: ok cool
[21:07:32] <grrrit-wm>	 (03PS4) 10MarkTraceur: Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 
[21:07:37] <aude>	 i don't think it changed your patch at all
[21:07:50] <aude>	 if we add indexes then i'll need to update
[21:08:47] <hoo>	 aude: We probabl want an index on rc_type together with the new field
[21:09:02] <aude>	 yep
[21:09:09] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "is that still needed ? It seems -smw is already in the code." [tools/release] - 10https://gerrit.wikimedia.org/r/28958 (owner: 10MarkAHershberger)
[21:10:05] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix Echo hook: User::newFromName can return false [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81398 
[21:13:20] <grrrit-wm>	 (03PS3) 10EBernhardson (WMF): Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 
[21:13:26] <ebernhardson>	 aude: just put up new version of patch with the index
[21:14:21] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/81270 (owner: 10MarkAHershberger)
[21:15:23] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Fix Echo hook: User::newFromName can return false [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81398 (owner: 10Matthias Mullie)
[21:15:43] <aude>	 ebernhardson: ok
[21:23:18] <grrrit-wm>	 (03PS3) 10Aude: postgresql schema update for rc_external_type column [core] - 10https://gerrit.wikimedia.org/r/81396 
[21:23:19] <grrrit-wm>	 (03PS4) 10Aude: Add rc_external_type column to recentchanges table [core] - 10https://gerrit.wikimedia.org/r/81277 (owner: 10EBernhardson (WMF))
[21:27:45] <thedj>	 quiddity: k. i haven't looked much at popups over the past few years anymore, but if i have time, i'll look into it. There are also issues with VE that need fixing.
[21:28:05] <thedj>	 the whole thing needs a rewrite actually, but i definetly don't have the time to do that :D
[21:28:31] <ebernhardson>	 i know there is a wikipage somewhere to add requests to update prod database schema, but i cant for the life of me remember where.  anyone?
[21:28:44] <thedj>	 it's amazing what lupin was able to make so long ago (2005 i think ?)
[21:29:00] <quiddity>	 matma might have covered the VE problem, with the update he's made an edit-prot for (linked just a bit lower down)
[21:29:22] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Do not show grant change form if the user cannot submit it. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81400 
[21:34:02] <quiddity>	 thedj: you might be best placed to look at his suggested code ( https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-popups.js#Use_the_.27wikipage.content.27_hook). Or at least, I'm not familiar with the other names under https://en.wikipedia.org/wiki/Wikipedia:POPUPS#Credits_and_external_links   (and yes, Lupin is missed :)
[21:34:03] <aude>	 ebernhardson: on wikitech wiki
[21:34:41] <aude>	 and poke greg-g to help get it scheduled, once approved
[21:35:02] <greg-g>	 ohai
[21:35:10] <grrrit-wm>	 (03CR) 10Cscott: "ping..." [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[21:35:16] <aude>	 https://wikitech.wikimedia.org/wiki/Schema_changes
[21:35:33] <Reedy>	 Which says to open a bug :D
[21:35:37] <aude>	 yes
[21:36:00] <aude>	 once someone merges these, then we can poke
[21:37:03] <aude>	 speaking of which, Reedy can we add the wb_property_info table soon for wikidata?
[21:37:11] <aude>	 or populate it, if not already done
[21:37:18] <Reedy>	 I thought I did it almost immediately
[21:37:29] <Reedy>	 I seem to recall asking on the bug what options it wants to be run with ;)
[21:37:31] <ebernhardson>	 hmm, ok well i just filed a bug to request ops to look it over, reading the page it sounded like someone (probably ksnider or asher) needs to sign off on the patch as "not going to send us down in flames" :)
[21:37:41] <aude>	 i see
[21:38:15] <Reedy>	 ebernhardson: Not ksnider; asher, springle or Tim (among a few others) would be the right people
[21:38:16] <grrrit-wm>	 (03PS1) 10Platonides: Prepare for Wiki Loves Monuments 2013 [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/81405 
[21:38:43] <ebernhardson>	 Reedy: ok.  Also i meant springle not ksnider, getting all these new people confused
[21:38:47] <Reedy>	 :)
[21:40:55] <aude>	 Reedy: replied to the bug
[21:41:16] <Reedy>	 hoo: Still populating gu_home_db :/
[21:41:32] <hoo>	 :/
[21:42:07] <Reedy>	 I keep having to restart it (using a different version to the one from Wikimania!) as mysql goes away
[21:42:26] <Reedy>	 I should look how much there is left to run
[21:42:49] <hoo>	 Did we alter it so that it only selects rows from the DB with empty gu_home_db?
[21:43:01] <grrrit-wm>	 (03PS2) 10Platonides: Prepare for Wiki Loves Monuments 2013 [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/81405 
[21:43:11] <Reedy>	 Exactly
[21:43:22] <Reedy>	 Running the old version multiple times wouldn't get us too far
[21:43:31] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/80381/
[21:43:36] <Reedy>	 ^ I'm using that version
[21:44:14] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Added some extra rights checks to access controllers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81407 
[21:44:15] <grrrit-wm>	 (03PS3) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 
[21:44:39] <hoo>	 Ok, I guess I can merge that change if it's already in prod?!
[21:44:42] <Reedy>	 lol, aude
[21:44:44] <Reedy>	 Done. Updated 647 property info entries.
[21:45:03] <hoo>	 Full table scan on these tables should take less than 10 minutes
[21:45:07] <hoo>	 probably way less
[21:45:22] <Reedy>	 I should just run a count query against a pmtpa slave
[21:45:40] <Reedy>	 It takes a few minutes to find its starting point, but after that runs reasonably
[21:46:27] * Reedy  picks a slave

[21:46:49] <grrrit-wm>	 (03CR) 10Aude: "i have not tried the patch or anything, but just note you'll have the same issue we have with Wikibase... this patch does nothing to suppo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF))
[21:47:08] <aude>	 \o/
[21:47:13] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Already used in prod. by Reedy, looks totally sane" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80381 (owner: 10Reedy)
[21:47:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update populateHomeDB script to only update when home is null [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80381 (owner: 10Reedy)
[21:47:22] <aude>	 thanks Reedy 
[21:47:35] <Reedy>	 Guess there's a config change to come next?; )
[21:47:44] <aude>	 not tonight
[21:47:48] <aude>	 it can be on thursday
[21:51:06] <grrrit-wm>	 (03PS2) 10Cmcmahon: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80964 (owner: 10Zfilipin)
[21:51:26] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80964 (owner: 10Zfilipin)
[21:51:27] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Reorganize. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81258 (owner: 10Manybubbles)
[21:51:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorganize. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81258 (owner: 10Manybubbles)
[21:52:07] <grrrit-wm>	 (03PS3) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 
[22:01:36] <Reedy>	 hoo: Nearly 17M done, just under 12M to go
[22:02:38] <Platonides>	 M of what?
[22:02:46] <legoktm>	 users
[22:03:02] <grrrit-wm>	 (03CR) 10Dzahn: [C: 031] "confirmed it's copied from /srv/org/wikimedia/bugzilla/template/en/default/bug and the diff is just that" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/81212 (owner: 10Aklapper)
[22:03:03] <Reedy>	 populating globaluser.gu_home_db
[22:03:13] <hoo>	 Reedy: How long is it running in total now?
[22:03:15] <Reedy>	 Doing a group by/count query is quite interesting
[22:03:17] <Reedy>	 I've no idea
[22:03:23] <Reedy>	 Err
[22:03:40] <Reedy>	 On and off for about a week
[22:04:10] <hoo>	 mh, let's just wait, then :D
[22:04:27] <Reedy>	 Needs to become array( 'gu_home_db IS NULL OR gu_home_db = ""' ), though
[22:04:38] <Reedy>	 Seemingly 10-11k which have "" set
[22:05:33] <grrrit-wm>	 (03CR) 10Dzahn: [C: 032] "root@kaulen:/srv/org/wikimedia/bugzilla/template/en/default/bug# diff edit.html.tmpl /root/edit.html_new-abeaba33624f7e23c06adafc9a4a10dd9" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/81212 (owner: 10Aklapper)
[22:06:14] <grrrit-wm>	 (03PS1) 10Reedy: Cater for gu_home_db being NULL or '' [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81410 
[22:06:27] <grrrit-wm>	 (03CR) 10Dzahn: [V: 032] "it's regular part of bugzilla, just in custom instead of default pluse those 10 lines" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/81212 (owner: 10Aklapper)
[22:08:38] <grrrit-wm>	 (03PS1) 10Mollywhite: Bug 53431: Adjust so clicking "remove" on new sections removes them. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 
[22:10:28] <grrrit-wm>	 (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81400 (owner: 10Aaron Schulz)
[22:12:12] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Trivial one" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81410 (owner: 10Reedy)
[22:12:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cater for gu_home_db being NULL or '' [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81410 (owner: 10Reedy)
[22:17:59] <grrrit-wm>	 (03PS71) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 
[22:18:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut)
[22:18:19] <awjr>	 greg-g: just a head's up that we're having some issues with the mobile web deployment
[22:18:20] <grrrit-wm>	 (03CR) 10Merlijn van Deen: "http_proxy=nowhere python setup.py test" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81287 (owner: 10Hashar)
[22:18:32] <awjr>	 greg-g: we're trying to get to the bottom of the problem; going to try a quick live hack
[22:18:51] <greg-g>	 uh oh
[22:23:30] <grrrit-wm>	 (03PS72) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 
[22:24:38] <grrrit-wm>	 (03PD72) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 
[22:25:20] <grrrit-wm>	 (03CR) 10Wikinaut: [C: 031 V: 031] "Ryan: here's the cleaned version!" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut)
[22:26:37] <mwalker>	 marktraceur: you free now to poke jenkins for me :D
[22:26:38] <mwalker>	 ?
[22:26:48] <marktraceur>	 Ah right
[22:26:51] <marktraceur>	 Link link link?
[22:27:06] <mwalker>	 https://gerrit.wikimedia.org/r/#/c/81378/ https://gerrit.wikimedia.org/r/#/c/81378/ https://gerrit.wikimedia.org/r/#/c/81378/
[22:27:14] <mwalker>	 linky linky linky!
[22:27:21] <marktraceur>	 Shaaaame
[22:27:27] <mwalker>	 shame?
[22:27:28] <marktraceur>	 :patch:81378
[22:27:31] <marktraceur>	 Damn!
[22:27:39] <marktraceur>	 My completion isn't as cool as I thought it was
[22:27:59] <marktraceur>	 You gave me non-permalinks
[22:28:02] <grrrit-wm>	 (03PS1) 10Reedy: gu_home_db can already be '' in the database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81415 
[22:28:58] <mwalker>	 I don't know how to get permalinks out of gerrit
[22:29:07] <mwalker>	 I just assumed it didn't have those fancy features
[22:29:13] <marktraceur>	 mwalker: https://gerrit.wikimedia.org/r/81378
[22:29:23] <marktraceur>	 mwalker: Also, should these jobs be voting?
[22:29:32] <mwalker>	 that expands to the same thing though!
[22:29:33] <marktraceur>	 i.e. do they all pass now?
[22:29:38] <mwalker>	 no; they don't all pass
[22:29:40] <mwalker>	 not even close
[22:29:41] <marktraceur>	 Expands, yes, but *permanently*
[22:29:49] <marktraceur>	 mwalker: Then you should make 'em nonvoting
[22:30:08] <mwalker>	 isn't that what the check-only does?
[22:30:11] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Matt admitted to me that these are shamefully not passing. Make them nonvoting!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 (owner: 10Adamw)
[22:30:17] <marktraceur>	 Er
[22:30:19] <marktraceur>	 Does it?
[22:30:24] <mwalker>	 thought so
[22:30:40] <marktraceur>	 My perception of check-only vs. check vs. whatever else is pretty tenuous
[22:30:48] <marktraceur>	 Krinkle! What does check-only mean?
[22:31:24] <grrrit-wm>	 (03PS4) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 
[22:32:08] <Krinkle>	 marktraceur: check: V+1, test: V+2, check-only: V+2
[22:32:19] <marktraceur>	 Ahhhh.
[22:32:33] <Krinkle>	 e.g. there are no jenkins jobs that execute code that would warrent the security policy of 'test', and yet you want it to vote V+2
[22:32:36] <marktraceur>	 Krinkle: But check-only will still -1 if jobs are failing and voting.
[22:32:37] <Krinkle>	 that's when you use check-only
[22:32:43] <Krinkle>	 Yes, -1 is either way
[22:32:48] <marktraceur>	 KK
[22:32:51] <marktraceur>	 mwalker: ^^
[22:32:55] <marktraceur>	 Make 'er non-voting!
[22:33:00] <Krinkle>	 if using check-only, there *must* not be 'test' or 'check'.
[22:33:11] <awjr>	 greg-g: our live hack looks good; we're going to commit it and deploy everywhere
[22:33:16] <Krinkle>	 all three vote -1, only check-only and test vote +2
[22:33:22] <marktraceur>	 That seems fine
[22:33:22] <mwalker>	 ok, so I know by default that jslint is non voting; what about pep8 and yamllint
[22:33:40] <Krinkle>	 see macro.yaml in jenkins-job-builder-config.git for the defaults
[22:33:55] <greg-g>	 awjr: go forth
[22:34:01] <marktraceur>	 https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/8f0059ea6944dd9ced5b6dcac550da200d955d84/macro.yaml
[22:34:06] <awjr>	 w00t thanks greg-g
[22:34:32] <Krinkle>	 the default non-voting is on a global level, not repo level. If you're using jshint in your repo's tests, it should be voting or you should be actively working on making master pass so you can make it voting. You shoudn't have any non-voting tests unless they're unstable and basically ignored by everyone.
[22:34:54] <mwalker>	 yep; that's the plan
[22:34:58] <Krinkle>	 (like phpcs right now in core)
[22:36:13] <grrrit-wm>	 (03CR) 10Adamw: "check-only does: Harmless jobs not restricted. Will vote Verified +1/-1." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 (owner: 10Adamw)
[22:36:46] <marktraceur>	 awight: Except not
[22:37:08] <marktraceur>	 awight: It will vote V2/V-1 but won't check if the submitter is WMF
[22:37:11] <grrrit-wm>	 (03PS5) 10Mollywhite: Bug 52350: Allow sections to be indented and outdented [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81379 
[22:37:22] <marktraceur>	 Nothing about the default voting state :)
[22:40:43] <mwalker>	 right; well; pep8 doesn't vote; jslint doesn't vote; I have no idea about yamllint
[22:40:51] <mwalker>	 I cant seem to find it's default anywhere
[22:41:05] <mwalker>	 which probably means it is voting if that's the default in the root template?
[22:41:18] <grrrit-wm>	 (03PS2) 10Adamw: add failing lint jobs on wikimedia/fundraising/tools [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81378 
[22:41:28] <marktraceur>	 Probably so
[22:46:12] <awight>	 marktraceur: I made that change, but now I'm waffling: V-1 is nice cos it gives graphic incentive to clean yr room.
[22:46:34] <awight>	 marktraceur: what were you saying about the submitter?  I see the lines about trusted WMF staff, but what is that whitelisting?
[22:47:56] <marktraceur>	 awight: V-1 will prevent it from getting auto-merged, though. We want Jenkins to merge things, not people
[22:48:53] <marktraceur>	 awight: If the submitter is trusted (not only WMF staff, IIRC), the test pipeline will run, else only check will. check-only is a way to give V+2 automatically to non-trusted users.
[22:50:02] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Remove obsolete code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81419 
[22:51:09] <grrrit-wm>	 (03PS1) 10Kaldari: Update MobileFrontend to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81420 
[22:51:43] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032 V: 032] Update MobileFrontend to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81420 (owner: 10Kaldari)
[22:51:46] <awight>	 marktraceur: ok, thank you for clarifying all of the above.  I see how untrusted tests are a security issue.
[22:52:09] <marktraceur>	 Yuuup
[22:52:14] <awight>	 hopefully, my PS2 will prevent automated voting fail
[22:52:28] <awight>	 hehe, I had it in Diebold mode
[22:52:49] <awight>	 "You want some chad with that nonmerge?"
[22:53:15] <awight>	 "Sorry about that temporary, intermediate audit table, suckas!"
[22:55:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update MobileFrontend to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81420 (owner: 10Kaldari)
[22:57:58] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "I believe this action will still be necessary to support non-javascript users?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81419 (owner: 10Matthias Mullie)
[22:58:28] <YuviPanda>	 hey superm401 / spagewmf! I remember you pointed out a page documenting mwui stuff, but I can't seem to find that link anymore. do you have it handy?
[22:59:11] <superm401>	 YuviPanda, depends what you want.
[22:59:15] <superm401>	 https://www.mediawiki.org/wiki/mediawiki.ui now has the basics.
[22:59:29] <YuviPanda>	 classnames and such
[22:59:31] * YuviPanda  looks

[23:00:10] <grrrit-wm>	 (03PS10) 10Rahul21: Reuse mw.UploadWizard.config in mw.LanguageUpWiz [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 
[23:00:12] <YuviPanda>	 superm401: hmm, so mw-ui-button and mw-ui-primary? that is all? nothing for forms, etc?
[23:00:34] <superm401>	 Yeah, there's some form stuff, e.g. mw-ui-vform on the form itself.
[23:00:41] <superm401>	 It's not 100% complete.
[23:00:48] <YuviPanda>	 hmm, alright
[23:00:51] <superm401>	 Is there something in particular you remember, but don't know the class?
[23:01:02] <YuviPanda>	 I was looking for the button only, so I'm good now :P
[23:01:06] <superm401>	 There's some checkbox stuff that isn't mentioned yet.
[23:01:10] <YuviPanda>	 I... was just trying to browse around
[23:01:14] <YuviPanda>	 to see if there's more I could use
[23:01:31] <superm401>	 Yeah, unfortunately it's not quite where it should be.
[23:02:29] <YuviPanda>	 superm401: will it all eventually end up on that link?
[23:02:33] <grrrit-wm>	 (03PS1) 10Kaldari: Update MobileFrontend to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81422 
[23:02:49] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032 V: 032] Update MobileFrontend to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81422 (owner: 10Kaldari)
[23:02:57] <superm401>	 YuviPanda, yeah, it should.  If it gets too big for the Default modules page, we may redirect mediawiki.ui somewhere else.
[23:03:05] <YuviPanda>	 alright!
[23:03:07] <superm401>	 But I'll make sure https://www.mediawiki.org/wiki/mediawiki.ui goes somewhere sane.
[23:03:49] <YuviPanda>	 superm401: ty!
[23:03:55] <superm401>	 No problem. :)
[23:05:45] <grrrit-wm>	 (03PS6) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 
[23:07:12] <Reedy>	 csteipp: Mind merging https://gerrit.wikimedia.org/r/#/c/81415 please?
[23:07:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update MobileFrontend to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81422 (owner: 10Kaldari)
[23:08:04] <csteipp>	 Reedy: is that a fix for matt's patch?
[23:08:11] <Reedy>	 Uhh..
[23:08:14] <Reedy>	 No?
[23:08:28] <csteipp>	 Oh, nevermind.. 
[23:09:15] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] gu_home_db can already be '' in the database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81415 (owner: 10Reedy)
[23:09:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: gu_home_db can already be '' in the database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81415 (owner: 10Reedy)
[23:09:43] <Reedy>	 Just fighting to get that field populated across the board
[23:10:34] <YuviPanda>	 hmm, is there documentation on using Xml:: ?
[23:10:35] * YuviPanda  looks

[23:10:51] <marktraceur>	 No, we just all sorta know how
[23:11:05] <mwalker>	 or make it up as we go along based on the doxygen comments
[23:11:19] <awight>	 s/we/some of we/
[23:11:20] <mwalker>	 I, for one, never know when to use HTML or XML
[23:11:28] <YuviPanda>	 mwalker: marktraceur not going to do the Twig stuff now, since I realized this is... rather simple, and I don't want to block for a potentially indeterminate period of time
[23:11:39] <mwalker>	 *thumbs up*
[23:11:53] <grrrit-wm>	 (03PS1) 10Reedy: Update CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81425 
[23:12:00] <YuviPanda>	 sorry, mwalker.
[23:12:04] <mwalker>	 :'D
[23:12:15] <mwalker>	 I dont even know what that was supposed to be
[23:12:19] <grrrit-wm>	 (03PS1) 10Reedy: Update CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81426 
[23:12:28] <mwalker>	 but; hopefully maybe sometime soon!
[23:12:31] <mwalker>	 *crosses fingers*
[23:12:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81425 (owner: 10Reedy)
[23:12:59] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81426 (owner: 10Reedy)
[23:14:23] <grrrit-wm>	 (03CR) 10Krinkle: ":ship: :up: :+1:" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 (owner: 10Alex Monk)
[23:14:31] <superm401>	 marktraceur, Rahul did the onevar (for the part related to his change), and I tested successfully.
[23:14:33] <grrrit-wm>	 (03PS1) 10Manybubbles: Get tests passing on beta. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81427 
[23:14:40] <superm401>	 Do you want to review, or is it alright if I +2?
[23:14:54] <grrrit-wm>	 (03PS2) 10Manybubbles: Get tests passing on beta. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81427 
[23:15:07] <marktraceur>	 Cool
[23:15:09] <marktraceur>	 Uh
[23:15:15] <marktraceur>	 superm401: Let me review, one sec
[23:15:27] <superm401>	 mwalker, I try to always use HTML, since I'm always working on HTML.
[23:16:07] <grrrit-wm>	 (03PS1) 10Bsitu: Attempt to fix 'welcome notification' exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81428 
[23:16:07] <superm401>	 I think most of the time we've been able to stick to that.
[23:16:40] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 031] "Onevar issue is addressed, works locally." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21)
[23:16:47] <grrrit-wm>	 (03PS2) 10Bsitu: Attempt to fix 'welcome notification' exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81428 
[23:16:47] <mwalker>	 except when you need things like Xml::dateSelector
[23:16:55] <mwalker>	 which really is a HTML5 thing
[23:16:59] <mwalker>	 but we call it Xml
[23:17:03] <YuviPanda>	 move it! 
[23:17:18] * mwalker  grumbles about moving all the functionality in Xml to Html

[23:17:39] * mwalker  further grumbles about 'legacy'

[23:17:40] <YuviPanda>	 mwalker: I stopped on twig when I realized that that meant installing a package. 
[23:18:18] <superm401>	 mwalker, you mean languageSelector?
[23:18:40] <superm401>	 You're right, we should move it.
[23:18:47] <mwalker>	 that's a good one too
[23:18:49] <superm401>	 After deprecating.
[23:18:57] <mwalker>	 there's really nothing in Xml that is 'Xml'
[23:18:59] <superm401>	 Oh, monthSelector
[23:19:52] <grrrit-wm>	 (03CR) 10Matthias Mullie: "Oh, are we going to support non-JS? :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81419 (owner: 10Matthias Mullie)
[23:20:00] <marktraceur>	 superm401: Remind me what the purpose of this patch is
[23:20:07] <marktraceur>	 Because it seems trivial to me
[23:20:12] <marktraceur>	 Not only that, almost null
[23:20:24] <superm401>	 PronunciationRecorder.
[23:20:36] <superm401>	 We want to try to contain our dependencies on UploadWizard.
[23:20:56] <marktraceur>	 Right
[23:21:15] <superm401>	 The config is supposed to be injected into mw.UploadWizard.js
[23:21:21] <marktraceur>	 But that patch doesn't change any of the function of the module, except that it waits until initialise is called
[23:21:27] <superm401>	 That was true even before we started working on PronunciationRecorder.
[23:22:00] <superm401>	 Right, and that means it uses the config from mw.UploadWizard instead of directly reading mw.config.get( 'UploadWizardConfig' )
[23:22:07] <marktraceur>	 Oh
[23:22:11] <marktraceur>	 I bet I know what happened
[23:22:33] <superm401>	 I thought about doing a more proper dependency injection, but didn't think Rahul and I had time.
[23:25:12] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Seems fine to me! Thanks, Rahul." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21)
[23:25:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reuse mw.UploadWizard.config in mw.LanguageUpWiz [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21)
[23:25:21] <marktraceur>	 {{done}}
[23:26:09] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Attempt to fix 'welcome notification' exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81428 (owner: 10Bsitu)
[23:26:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Attempt to fix 'welcome notification' exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81428 (owner: 10Bsitu)
[23:27:51] <grrrit-wm>	 (03CR) 10Brian Wolff: "When testing some of the excessively large png files on commons like file:Basemap_for_Afil.png and Drapeau_hillion.png, vips seems to crea" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/62233 (owner: 10btongminh)
[23:30:19] <YuviPanda>	 hmm, how do I add a RL module to be loaded on top?
[23:31:56] <grrrit-wm>	 (03PS6) 10MarkTraceur: Final jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 
[23:32:37] <grrrit-wm>	 (03PS6) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 
[23:32:47] <marktraceur>	 Sweet
[23:33:00] <marktraceur>	 YuviPanda: 'position' => 'top',
[23:33:22] <YuviPanda>	 IRC *is* documentation, isn't it?
[23:33:34] <YuviPanda>	 I will be getting jackshit done if I don't keep an inverted sleep cycle
[23:33:37] <marktraceur>	 Basically
[23:34:26] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "Sadly yes :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81419 (owner: 10Matthias Mullie)
[23:41:00] <grrrit-wm>	 (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81434 
[23:43:14] <grrrit-wm>	 (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81435 
[23:43:47] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032 V: 032] Update Echo to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81434 (owner: 10Bsitu)
[23:47:07] <YuviPanda>	 marktraceur: oh dear documentation, how do I make a link to a special page? :D
[23:47:11] <YuviPanda>	 in php, that is?
[23:47:15] <YuviPanda>	 should I get a title?
[23:47:22] <YuviPanda>	 also is this documented?
[23:48:22] <marktraceur>	 YuviPanda: It should be - https://doc.wikimedia.org/mediawiki-core/master/php/html/classSkin.html#aa236f8d29af1a3c4dc732d243b9fa05d e.g.
[23:48:33] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032 V: 032] Update Echo to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/81435 (owner: 10Bsitu)
[23:48:44] <YuviPanda>	 wtf is it in Skin for?!
[23:48:45] <marktraceur>	 You could also probably "just" parse a wikilink to Special:Whatever
[23:48:53] <marktraceur>	 I dunno, it might be elsewhere
[23:49:18] <YuviPanda>	 sigh
[23:49:18] <YuviPanda>	 ok
[23:49:55] <marktraceur>	 That's the one I saw recently
[23:50:30] <YuviPanda>	 can I get a WikiPage or Title object from inside a Content?
[23:50:40] <marktraceur>	 Errr
[23:51:00] <marktraceur>	 Inside of a ContentPage, you mean?
[23:51:07] <marktraceur>	 Er, no
[23:51:11] <marktraceur>	 What bloody class is Content?
[23:51:16] <YuviPanda>	 TextContent
[23:51:18] <YuviPanda>	 CampaignContent
[23:51:42] <marktraceur>	 Ohhh
[23:51:52] <marktraceur>	 Does it extend anything I can actually look up?
[23:52:02] <YuviPanda>	 marktraceur: it extends TextContent, which is in core
[23:52:03] <marktraceur>	 Oh, hm
[23:52:28] <marktraceur>	 It would appear "No" but I'm still looking
[23:52:50] <marktraceur>	 OK now I'm done looking
[23:53:28] <YuviPanda>	 ewugh
[23:57:47] <grrrit-wm>	 (03CR) 10Mwjames: [C: 032] [DIC]: Move SMWHooks::onParserAfterTidy to SMW\ParserAfterTidy [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 (owner: 10Mwjames)
[23:59:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: [DIC]: Move SMWHooks::onParserAfterTidy to SMW\ParserAfterTidy [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81167 (owner: 10Mwjames)