[00:03:10] <grrrit-wm>	 (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon)
[00:19:06] <grrrit-wm>	 (03PS7) 10Matmarex: jquery.tablesorter: Support genitive month names [core] - 10https://gerrit.wikimedia.org/r/55496 
[00:21:01] <grrrit-wm>	 (03PS1) 10CSteipp: Set CentralAuth cookies with correct security [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80784 
[00:30:45] <grrrit-wm>	 (03CR) 10Demon: [C: 032] Set CentralAuth cookies with correct security [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80784 (owner: 10CSteipp)
[00:30:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set CentralAuth cookies with correct security [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80784 (owner: 10CSteipp)
[00:32:17] <grrrit-wm>	 (03PS4) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 
[00:32:43] <grrrit-wm>	 (03PS1) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80785 
[00:33:30] <grrrit-wm>	 (03CR) 10Demon: [C: 032] Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80785 (owner: 10Demon)
[00:33:56] <grrrit-wm>	 (03CR) 10Demon: [C: 032] Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 (owner: 10Demon)
[00:34:33] <grrrit-wm>	 (03Abandoned) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80671 (owner: 10Demon)
[00:38:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80785 (owner: 10Demon)
[00:40:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 (owner: 10Demon)
[00:58:10] <grrrit-wm>	 (03PS1) 10Shirayuki: Fix double-comma [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/80786 
[01:02:37] <grrrit-wm>	 (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon)
[01:24:32] <grrrit-wm>	 (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon)
[01:34:27] <grrrit-wm>	 (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon)
[01:37:32] <grrrit-wm>	 (03PS5) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 
[01:37:52] <grrrit-wm>	 (03PS2) 10Parent5446: [WIP] Extension rewrite [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/76858 
[01:39:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 (owner: 10Mwjames)
[01:43:11] <grrrit-wm>	 (03PS6) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 
[02:00:53] <grrrit-wm>	 (03PS3) 10Parent5446: [WIP] Extension rewrite [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/76858 
[04:02:43] <legoktm>	 YuviPanda_zz: https://www.mediawiki.org/wiki/API:Extensions
[04:33:24] <grrrit-wm>	 (03PS12) 10Parent5446: Added new MWTimestamp::getRelativeTimestamp for pure relative. [core] - 10https://gerrit.wikimedia.org/r/45677 
[05:37:10] <Nemo_bis>	 can someone trigger recheck for this? the tests should pass now https://gerrit.wikimedia.org/r/#/c/78391/
[05:40:53] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Ok, let's try without the space and see if it needs more improvement later." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/60186 (owner: 10Nischayn22)
[05:41:17] <p858snake|l>	 Nemo_bis: just comment with "recheck" iirc
[06:14:32] <Nemo_bis>	 p858snake|l: I can't do that 
[06:14:59] <Nemo_bis>	 one needs to be whitelisted in some way
[06:15:39] <p858snake|l>	 ...it should just rerun the same tests
[06:20:52] <grrrit-wm>	 (03CR) 10Legoktm: "recheck" [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 (owner: 10Nemo bis)
[06:21:05] <legoktm>	 there.
[06:21:10] <legoktm>	 Nemo_bis: just needs to get +2'd again
[06:21:34] <legoktm>	 oh hm
[06:21:44] <legoktm>	 it seems "recheck" just runs the +1 tests, not the full suite
[06:23:44] <Nemo_bis>	 sigh
[06:23:47] <grrrit-wm>	 (03PS2) 10Nemo bis: Clarify maps-displaymap-par-visitedicon [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 
[06:23:56] <Nemo_bis>	 Nikerabbit: please +2
[06:40:32] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Clarify maps-displaymap-par-visitedicon [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 (owner: 10Nemo bis)
[06:40:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clarify maps-displaymap-par-visitedicon [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 (owner: 10Nemo bis)
[06:46:18] <grrrit-wm>	 (03PS3) 10IAlex: Remove duplicate runChild() call [core] - 10https://gerrit.wikimedia.org/r/76632 (owner: 10Reedy)
[06:46:24] <grrrit-wm>	 (03CR) 10IAlex: [C: 032] Remove duplicate runChild() call [core] - 10https://gerrit.wikimedia.org/r/76632 (owner: 10Reedy)
[06:50:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove duplicate runChild() call [core] - 10https://gerrit.wikimedia.org/r/76632 (owner: 10Reedy)
[07:07:19] <grrrit-wm>	 (03CR) 10Wikinaut: [C: 031 V: 031] "Parent4556: thx for code review. I have again to rebase, still waiting for Ryan's code review." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut)
[07:07:30] <grrrit-wm>	 (03PS69) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 
[07:28:30] <grrrit-wm>	 (03PS1) 10IAlex: Removed unneeded else branches in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/80788 
[08:40:57] <grrrit-wm>	 (03PS1) 10Umherirrender: Parse limiation warnings as 'text' [core] - 10https://gerrit.wikimedia.org/r/80791 
[09:44:33] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] "Shouldn't that be ->parse() then? ->text() doesn't parse wikimarkup" [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender)
[10:11:27] <grrrit-wm>	 (03PS2) 10Nemo bis: Parse limiation warnings as 'text' [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender)
[10:44:32] <grrrit-wm>	 (03CR) 10Umherirrender: "HTML is here not needed, because all warnings of the ParserOutput will go through OutputPage::parse before added to the output, see EditPa" [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender)
[11:13:20] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda)
[11:21:18] <grrrit-wm>	 (03CR) 10Fomafix: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80406 (owner: 10Umherirrender)
[12:08:30] <grrrit-wm>	 (03PS1) 10TheDJ: Accessibility: Make jump links work in Safari and Chrome [core] - 10https://gerrit.wikimedia.org/r/80799 
[12:12:35] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] "OK, nobody seems to share my language api concern, so let's just merge." [core] - 10https://gerrit.wikimedia.org/r/36391 (owner: 10Wizardist)
[12:16:01] <hoo>	 thedj: If we get a labs project for accessibility, do we need to use puppet to configure it or can we just hack it up manually?
[12:18:34] <T13|needsCoffee>	 I thought I saw Coren say the other day that not everything had to be puppetized.  You might want better confirmation than me though. ← hoo 
[12:41:24] <grrrit-wm>	 (03CR) 10TheDJ: "If no one has any objections, I'll merge this on the 28th." [core] - 10https://gerrit.wikimedia.org/r/60088 (owner: 10Brian Wolff)
[12:51:15] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(5 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 (owner: 10Rtdwivedi)
[13:03:15] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Enhanced RC: Optimization of the initial collapsing [core] - 10https://gerrit.wikimedia.org/r/74955 (owner: 10Matmarex)
[13:19:19] <grrrit-wm>	 (03CR) 10Aude: [C: 031] "tested and works fine, blocking edits with blacklisted urls in the Wikibase url datatype properties, strings, descriptions, ordinary wikit" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler)
[13:19:42] <grrrit-wm>	 (03PS1) 10Alex Monk: Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 
[13:19:54] <aude>	 hoo:  ^
[13:20:32] <hoo>	 aude: \o/ I tested it a lot with classic wikitext yesterday :)
[13:21:30] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Already tested this a lot yesterday. Should be fine now (also per Aude's +1)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler)
[13:21:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 51621) Make SBL aware of ContentHandler. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler)
[13:21:50] <aude>	 :)
[13:22:34] <hoo>	 Ok, so there's only one more blocker bug for the datatype?! :)
[13:25:03] <grrrit-wm>	 (03PS2) 10Alex Monk: Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 
[13:28:26] <grrrit-wm>	 (03PS1) 10TheDJ: Accessibility: Don't remove focus outline [core] - 10https://gerrit.wikimedia.org/r/80813 
[13:31:14] <grrrit-wm>	 (03PS2) 10Jack Phoenix: SocialProfile: ResourceLoader & RequestContext love. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/79830 
[13:33:07] <hoo>	 thedj: https://gerrit.wikimedia.org/r/80799 doesn't work for me
[13:43:57] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] jquery.suggestions: Use document width instead of <body> width for position calculation [core] - 10https://gerrit.wikimedia.org/r/72937 (owner: 10Matmarex)
[13:44:27] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: ResourceLoader & RequestContext love. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/79830 (owner: 10Jack Phoenix)
[13:45:50] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/80799 (owner: 10TheDJ)
[13:47:36] <thedj>	 hoo: eh that's weird. it worked before.. perhaps i forgot to add the last change into the patchset or something.
[13:48:41] <hoo>	 Indeed... plain .focus() wont just fetch the right thing to focus?
[13:49:03] <thedj>	 ah wait, tabbable is jquery.ui
[13:49:23] <thedj>	 that explains. it depends on wether or not that's loaded on a page then.
[13:49:29] <hoo>	 ewk
[13:49:38] <thedj>	 Fuck
[13:49:40] <hoo>	 we have to stick to plain sizzle, I guess
[13:52:08] <thedj>	 shite, that's not gonna be fun to reimplement :tabbable
[13:52:17] <grrrit-wm>	 (03Abandoned) 10Jack Phoenix: modified for the ResourceLoader [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/47828 (owner: 10Hypergrove)
[13:52:40] <hoo>	 thedj: mhm... just .find( 'a:first' )
[13:52:57] <thedj>	 doesn't work for search
[13:53:04] <hoo>	 oh right
[13:53:28] <thedj>	 .find ( 'input a' ).first()
[13:53:49] <thedj>	 +,
[13:54:09] <hoo>	 that will work, as long as the DOM stays the way it is (eg. if we add a <button> somewhere, it will break)
[13:54:46] <thedj>	 yup, but then we need to reimplement tabbable, and i don't really fancy doing that.
[13:55:35] <hoo>	 I'm fine with input and a for now (with an explaining comment)
[14:00:25] <grrrit-wm>	 (03CR) 10Shirayuki: [C: 031] Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 (owner: 10Alex Monk)
[14:00:48] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ)
[14:19:29] <grrrit-wm>	 (03CR) 10Umherirrender: "The other question is, why was this changed to content language?" [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender)
[14:34:42] <grrrit-wm>	 (03PS2) 10TheDJ: Accessibility: Make jump links work in Safari and Chrome [core] - 10https://gerrit.wikimedia.org/r/80799 
[14:44:13] <grrrit-wm>	 (03CR) 10TheDJ: "Ah. that's the reason. native mac checkboxes and radio buttons aren't style able." [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ)
[14:44:26] <grrrit-wm>	 (03PS1) 10Alex Monk: Save real tabs [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 
[14:45:02] <thedj>	 anyone know a bit of sass ?
[14:45:58] <Reedy>	 Ask Elsie
[14:47:21] <thedj>	 or is it less that we use in mediawiki.ui
[15:00:41] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 031] "Works like a charm!" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 (owner: 10Alex Monk)
[15:01:24] <helderwiki>	 Krenair: thank you for that! I didn't know it was that easy to fix the bug :-)
[15:04:09] <Krenair>	 I didn't either
[15:04:45] <Krenair>	 Hm. We still have arbcom.(de|en|fi|nl).wikipedia.org, noboard.chapters.wikimedia.org and wg.en.wikipedia.org
[15:04:49] <Krenair>	 all private but with broken SSL
[15:06:55] <grrrit-wm>	 (03Abandoned) 10Toniher: recover Time [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/55523 (owner: 10Toniher)
[15:07:29] <grrrit-wm>	 (03Abandoned) 10Toniher: changes to make Timeline compatible with BC [extensions/SemanticResultFormats] - 10https://gerrit.wikimedia.org/r/55522 (owner: 10Toniher)
[15:07:33] <grrrit-wm>	 (03PS2) 10Umherirrender: Add class around diff-empty and add it as notice [core] - 10https://gerrit.wikimedia.org/r/80406 
[15:07:54] <grrrit-wm>	 (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80406 (owner: 10Umherirrender)
[15:11:34] <Krenair>	 looks like this is https://bugzilla.wikimedia.org/show_bug.cgi?id=31335#c8
[15:20:18] <grrrit-wm>	 (03PS2) 10TheDJ: Accessibility: Don't remove checkbox outline on focus [core] - 10https://gerrit.wikimedia.org/r/80813 
[15:21:59] <grrrit-wm>	 (03PS4) 10Yuvipanda: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 
[15:22:00] <grrrit-wm>	 (03PS4) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 
[15:22:01] <grrrit-wm>	 (03PS1) 10Himeshi: Added generating pages with page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/80863 
[15:30:21] <grrrit-wm>	 (03PS1) 10Himeshi: Creating forms with page section via PageSchemas [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/80864 
[16:09:57] <grrrit-wm>	 (03PS8) 10Matmarex: jquery.tablesorter: Support genitive month names [core] - 10https://gerrit.wikimedia.org/r/55496 
[16:28:58] <hoo>	 thedj: Wow... with NVDA enabled the jump to links already work in chromium for me... that just confused me a lot
[16:41:42] <grrrit-wm>	 (03CR) 10Hoo man: "Not fully convinced this a good idea... eg. with IE and Jaws this will skip the announcement of the navigation region and only read the li" [core] - 10https://gerrit.wikimedia.org/r/80799 (owner: 10TheDJ)
[16:42:20] <hoo>	 :/
[16:42:52] <hoo>	 With Jaws and Firefox that's not this much of an issue...
[16:43:28] <grrrit-wm>	 (03PS3) 10Umherirrender: Parse limitation warnings as 'text' and in user language [core] - 10https://gerrit.wikimedia.org/r/80791 
[16:46:42] <thedj>	 hoo: soo much of this is soo confusing...
[16:47:13] <hoo>	 Yes...
[16:48:27] <thedj>	 hoo: we can also enable tabindex on the target, focus it, remove tabindex
[16:49:04] <hoo>	 that sounds insane but should prevent the screen readers from going wild
[16:49:09] <thedj>	 exactly
[16:54:25] <grrrit-wm>	 (03PS4) 10Umherirrender: Parse limitation warnings as 'text' and in user language [core] - 10https://gerrit.wikimedia.org/r/80791 
[16:54:35] <bawolff>	 thedj: Thanks for your comment on  I9e58db1 - that makes me really happy :)
[16:54:53] <grrrit-wm>	 (03CR) 10Hoo man: [C: 031] "(Untested)" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ)
[16:55:31] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3 and 4: Use user language instead of content language from the ParserOptions" [core] - 10https://gerrit.wikimedia.org/r/80791 (owner: 10Umherirrender)
[16:55:42] <MatmaRex>	 hoo: thedj: D:
[16:56:35] <hoo>	 MatmaRex: Screen readers are weird... especially because they are working different with whatever browser you use them...
[16:59:21] <MatmaRex>	 everybody should just use opera
[16:59:39] <thedj>	 hoo: look what happens when do that trick on mw-navigation....
[16:59:40] <thedj>	 http://imagebin.org/268741
[16:59:45] <MatmaRex>	 it even used to have speech and speech recognition built-in
[16:59:52] <thedj>	 wth is that.
[17:00:17] <hoo>	 Browser on drugs?! :P
[17:01:19] <thedj>	 hoo: i think it's an artifact of the focusring due to the collapsing trick on mw-jump
[17:02:03] <thedj>	 ah, mw-navigation is of course rather strangely positioned with that top and left part.
[17:02:30] <thedj>	 it's the focusring of mw-navigation that gets totally messed up.
[17:02:47] <hoo>	 wow
[17:04:01] <thedj>	 btw, you say that the region isn't announded with JAWS ? that's strange actually...
[17:04:27] <thedj>	 it should always mention when you navigate from one landmark region to another...
[17:04:32] <hoo>	 thedj: Not with IE 10, it just reads the link we .focus()
[17:05:24] <hoo>	 that's something Graham could test, but this seems a rather obvious problem to me, screen readers don't like focus/ cursors to be changed by JavaScript
[17:07:32] <grrrit-wm>	 (03CR) 10Matmarex: [C: 032] Add class around diff-empty and add it as notice [core] - 10https://gerrit.wikimedia.org/r/80406 (owner: 10Umherirrender)
[17:08:55] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] "There are more functions with unneeded else parts" [core] - 10https://gerrit.wikimedia.org/r/80788 (owner: 10IAlex)
[17:10:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add class around diff-empty and add it as notice [core] - 10https://gerrit.wikimedia.org/r/80406 (owner: 10Umherirrender)
[17:12:42] <hoo>	 thedj: What about https://gerrit.wikimedia.org/r/79472 ("Add extra accessibility labels to jump to citation (↑) links") do you think we need further testing on it?
[17:12:56] <thedj>	 hoo: graham said "jump up" right ?
[17:13:05] <hoo>	 Yes
[17:13:29] <hoo>	 (comment 4 in the bug)
[17:13:56] <thedj>	 i think we should go with this then for now.
[17:14:02] <thedj>	 we can always change later on.
[17:14:37] <MatmaRex>	 btw guys, is it just me, or does the way Cite uses MediaWiki: messages for everything suck immensely?
[17:14:40] <hoo>	 Yes, changing labels is trivial
[17:14:49] <hoo>	 MatmaRex: It does a lot
[17:15:11] <hoo>	 But changing that would be a *huge* pain, that's why I left it in place
[17:15:25] <MatmaRex>	 yeah :/
[17:15:31] <hoo>	 it also mixes wikitext and html responsibilities a bit
[17:15:32] <thedj>	 probably result of en.wp's "we want to be able to change everything" attitude :D
[17:15:44] <Technical_13>	 MatmaRex: does opera support blink css?
[17:15:48] <hoo>	 Yep, they even changed that symbol for the jump up link...
[17:17:29] <MatmaRex>	 Technical_13: you mean text-decoration:blink? it understands it, but doesn;t do the blinking
[17:17:39] <Technical_13>	 :( 
[17:18:02] <Technical_13>	 Firefox 23 deprecated it, so I'm looking for a new browser.
[17:18:14] <hoo>	 oO
[17:18:33] <hoo>	 Technical_13: You can still emulate it in JS
[17:18:34] <thedj>	 <head><desk/>
[17:18:50] * hoo  slaps himself for having that idea

[17:18:54] <Technical_13>	 hoo: ...
[17:19:13] <Technical_13>	 I can't put .js on pages for all to see...
[17:19:31] <hoo>	 mh?
[17:20:10] <bawolff>	 Technical_13: <blink> is like drugs. Just say no!
[17:20:13] <Technical_13>	 @link [[en:User:Technical 13/Editnotice]]
[17:20:13] <wm-bot>	 http://enwp.org/User:Technical_13/Editnotice
[17:20:38] <thedj>	 hoo: "If you need your extension to be compatible with PHP versions earlier than 5.3.0 (as is MediaWiki 1.19 and below), use dirname( __FILE__ ) instead of __DIR__."
[17:20:38] <YuviPanda>	 Technical_13: didn't you have blink in your onwiki sig at some point?
[17:20:43] <YuviPanda>	 or am I confusing you with someone else?
[17:20:52] <hoo>	 thedj: Nobody cares about PHP 5.2 really
[17:20:57] <MatmaRex>	 Technical_13: heh, actually, that is blinking for me. :P
[17:21:00] <Technical_13>	 bawolff: if that is the worst drug I'm into, I'd say I'm doing well.
[17:21:05] <MatmaRex>	 i was clearly confused earlier.
[17:21:09] <Technical_13>	 YuviPanda: I did...
[17:21:10] <hoo>	 even CentOs is on 5.3 for ages now
[17:21:26] <hoo>	 Technical_13: Not blinking for me, but still hard to read
[17:21:28] <Technical_13>	 MatmaRex: see how useful it is to BLINK!
[17:21:32] <MatmaRex>	 clearly
[17:21:33] <MatmaRex>	 also, guys
[17:21:35] <bawolff>	 Technical_13: When you use <blink>, you're not just hurting yourself, but also hurting those around you
[17:21:44] <YuviPanda>	 bawolff: it was in his sig :P
[17:21:46] <thedj>	 hoo: but we should probably add that to the commit msg i guess..
[17:21:55] <MatmaRex>	 let's say i have a talk page with a few thousand watchers
[17:21:56] <hoo>	 Oh, I guess so
[17:22:02] <MatmaRex>	 if i move it, will the watchers be moved as well?
[17:22:07] <MatmaRex>	 or does this work only for main space?
[17:22:08] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "(1 comment)" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 (owner: 10Alex Monk)
[17:23:07] <Krenair>	 ori-l, what's the recommended way to document JS hooks?
[17:23:11] <Technical_13>	 !blink is <bawolff> Technical_13: When you use <blink>, you're not just hurting yourself, but also hurting those around you
[17:23:11] <wm-bot>	 Key was added
[17:23:19] <ori-l>	 Krenair: good question. Dunno.
[17:23:26] <Technical_13>	 ROFLMMFAO
[17:23:36] <Krenair>	 Nikerabbit suggested a hooks.txt file for LQT
[17:23:37] <grrrit-wm>	 (03PS9) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 
[17:23:42] <MatmaRex>	 Krenair: they're currently not documented at all afaik.
[17:23:49] <YuviPanda>	 !b 1
[17:23:49] <wm-bot>	 https://bugzilla.wikimedia.org/1
[17:23:50] <Krenair>	 So I just put this in lol: https://gerrit.wikimedia.org/r/#/c/77052/2/hooks.txt
[17:24:16] <grrrit-wm>	 (03CR) 10Umherirrender: "Already fixed by I6781420f01d8c90d47f4b9f3ad099cadf0f8ced5" [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke)
[17:24:23] <hoo>	 thedj: Just added a sentence about taht... although it might be possible that it didn't even work with PHP5.2 (or a MW version which supports PHP 5.2) before
[17:24:50] <YuviPanda>	 ori-l: https://gerrit.wikimedia.org/r/#/c/80866/ :)
[17:25:16] <YuviPanda>	 ori-l: also, you can use github code search (rather than site:git.wikimedia.org) - https://github.com/search?q=php_sapi_name+%40wikimedia&type=Code
[17:25:39] <ori-l>	 YuviPanda: the CSS class that quiddity was searching for didn't come up in GitHub
[17:25:56] <YuviPanda>	 ori-l: true, I geuss there is a reason they hide the code search
[17:26:12] <MatmaRex>	 github's very slow at indexing the code
[17:26:15] <Technical_13>	 Does mw support CSS3 yet?
[17:27:19] <Krenair>	 https://github.com/search?q=path%3Aid_rsa&type=Code&ref=searchresults hmmm
[17:27:21] <Nikerabbit>	 hmmm, someone pinged me?
[17:27:27] <grrrit-wm>	 (03CR) 10Umherirrender: "Yes, file is still ignored by jshint, but Krinkle has commited I9df912ee48d30c189394bf07f5e49014220f36a3 already to let the file pass jshi" [core] - 10https://gerrit.wikimedia.org/r/80582 (owner: 10Umherirrender)
[17:28:05] <ori-l>	 Nikerabbit: <Krenair> ori-l, what's the recommended way to document JS hooks? / <Krenair> Nikerabbit suggested a hooks.txt file for LQT
[17:29:00] <Nikerabbit>	 aha
[17:29:08] <Nikerabbit>	 for lack of better idea yes
[17:29:21] <Nikerabbit>	 Translate has hooks.txt which contains both PHP and JS
[17:30:07] <quiddity>	 YuviPanda, they don't hide the search box at https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FEcho which is the problem I ran into yesterday - No matter what text I put in the search box, it just refreshes the page.
[17:30:40] <YuviPanda>	 I don't really expect it to work :P
[17:30:44] <YuviPanda>	 like most of git.
[17:30:48] <quiddity>	 >.<
[17:30:54] <YuviPanda>	 I meant
[17:30:58] <YuviPanda>	 most of git.wikimedia.org
[17:31:01] <YuviPanda>	 git itself is awesome :P
[17:32:35] <Technical_13>	 Does mw support CSS3 yet?
[17:32:44] <MatmaRex>	 define 'support'
[17:33:07] <Technical_13>	 Does the parser strip it out?
[17:33:12] <MatmaRex>	 no
[17:33:15] <MatmaRex>	 why would it?
[17:33:37] <MatmaRex>	 it only strips out url()-references and IE's filter: properties
[17:33:59] <thedj>	 the CSS sanitizer only has a blacklist as far as i know
[17:34:00] <MatmaRex>	 (and this is only for inline CSS, mediawiki:common.css etc pass thru unscathed)
[17:34:38] <Technical_13>	 Blacklist thedj ?
[17:34:42] <Technical_13>	 Link?
[17:34:53] <thedj>	 there might be some issues with RTL flipping for CSS3 attributes though. Resourceloader doesn't support them most likely.
[17:35:08] <hoo>	 Technical_13: MediaWiki rule #1: Don't look at the parser
[17:35:25] <MatmaRex>	 thedj: i added support for some
[17:35:29] <MatmaRex>	 !master includes/Sanitizer.php
[17:35:29] <wm-bot>	 https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/includes%2fSanitizer.php
[17:35:31] <hoo>	 thedj: CSS Janus is pretty up to date, I think... whatever is needed usually get added there
[17:35:38] <Technical_13>	 Maybe I can figure out if/how I can make a CSS3 blink instead... :p
[17:35:53] <MatmaRex>	 Technical_13: https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/includes%2fSanitizer.php#L893
[17:35:59] <hoo>	 Technical_13: That text is already almost unreadable
[17:36:03] <ori-l>	 Krenair: annoying suggestion #145: maybe replace 'includes/rclivefeed' with 'includes/rcfeed', which is in line with your class hierarchy?
[17:36:32] <ori-l>	 in the file path, I mean.
[17:36:42] <Technical_13>	 Hoo it's more readable when some words blink.. :p
[17:36:57] <hoo>	 just edit=sysop it...
[17:38:01] <Krenair>	 Is the ConfEditor class used anywhere?
[17:38:45] <grrrit-wm>	 (03PS20) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[17:38:53] <Krenair>	 ori-l, ^
[17:39:13] <ori-l>	 better, thanks :)
[17:40:00] <Krenair>	 hm, ConfEditor is used in Translate and LocalisationUpdate it seems
[17:45:23] <grrrit-wm>	 (03PS2) 10Alex Monk: Save real tabs and allow configuration by users via JS hook [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 
[17:47:58] <thedj>	 hoo: variant menu patch. why was the focus not visible ?
[17:48:39] <hoo>	 thedj: Because the focus is on an invisible(?) link within the h3
[17:48:56] <hoo>	 but the user visually expects the wrapping element to be focused
[17:49:11] <thedj>	 ah. what about putting tabindex on the element ?
[17:49:32] <hoo>	 mh, that would require extra statehandler logic
[17:49:53] <thedj>	 h3.tabindex=0 and h3.a.tabindex=-1
[17:50:20] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[17:50:34] <hoo>	 I thought about that as well, but I was a bit hesitant because some menus have different DOM structures than others
[17:50:53] <grrrit-wm>	 (03PS3) 10Matmarex: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[17:50:57] <hoo>	 But I guess we should rather do this properly... give me a -1 then...
[17:51:08] <thedj>	 hoo: cause you know, a focus ring on mac isn't a 1px dotted line :D
[17:51:22] <hoo>	 I know, it's different in Opera either...
[17:52:01] <hoo>	 I also thought about letting it already expand on focus, but wasn't sure about that as that will require to tab through all sub-links in order to reach the "next" link
[17:53:04] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[17:53:06] <thedj>	 then you really need a way to close the menu as well.
[17:54:21] <hoo>	 mh
[17:54:34] <hoo>	 I guess being able to open it with enter/ space should be ok for now
[17:55:03] <thedj>	 yeah, as long as you don't open without the user choosing, it's 'acceptable' i think.
[17:56:53] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] "per IRC discussion with TheDJ: We should rather work with tabindices on the h3 and the a instead of faking the focus style." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man)
[17:57:40] <hoo>	 next step will be to make that screen reader accessible, I guess
[17:58:31] <grrrit-wm>	 (03CR) 10Alex Monk: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[17:59:13] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "other comments from PS2 apply" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle)
[18:00:59] <grrrit-wm>	 (03PS4) 10TheDJ: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man)
[18:01:07] <thedj>	 something like that...
[18:03:20] <hoo>	 yes, that looks ok
[18:03:43] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Special:PagesWithProp: Use Language#formatSize [core] - 10https://gerrit.wikimedia.org/r/79468 (owner: 10Matmarex)
[18:04:16] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[18:06:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Special:PagesWithProp: Use Language#formatSize [core] - 10https://gerrit.wikimedia.org/r/79468 (owner: 10Matmarex)
[18:14:05] <thedj>	 hoo: although I should remove that fakefocus then again :D
[18:14:09] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Save real tabs and allow configuration by users via JS hook [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 (owner: 10Alex Monk)
[18:14:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Save real tabs and allow configuration by users via JS hook [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80843 (owner: 10Alex Monk)
[18:14:19] <hoo>	 thedj: I'm already amending that change
[18:14:34] <hoo>	 If you touch it now, we duplicate work :P
[18:15:01] <thedj>	 i'll stay off it :D
[18:15:14] <hoo>	 That introduces the problem I feared :/
[18:15:39] <MatmaRex>	 thedj: looking for something to do? :P
[18:15:58] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/76457/ is rather trivial
[18:16:01] <thedj>	 hoo: missing button role :D
[18:16:04] <hoo>	 Don't steal my only code reviewer :P
[18:16:21] <hoo>	 thedj: Well, you haven't tested it with the variant select, have you?
[18:16:22] <MatmaRex>	 heyyyy, i review your code sometimes, too :P
[18:16:35] <hoo>	 MatmaRex: with a screen reader :P
[18:16:57] <MatmaRex>	 btw, not sure if you two have seen it - https://gerrit.wikimedia.org/r/#/c/72053/ "New language variant 'en-x-piglatin' for easier variant testing" might be useful for you
[18:16:59] <hoo>	 thedj: You can select the variant selection twice, which is a bit weird
[18:17:13] <MatmaRex>	 it's not merged yet because parser sucks, but it basically works
[18:17:34] <thedj>	 hoo: a selected variant has an a in it ?
[18:18:00] <hoo>	 thedj: You can see it on zhwiki
[18:18:09] <hoo>	 the variant selection consists of two h3
[18:18:36] <hoo>	 but I guess we can just use the div for focus
[18:20:34] <thedj>	 hoo: i don't see understand. '> h3 > a:first' should only get h3 with a in it right ?
[18:20:54] <thedj>	 i actually have my language set to zh now. 
[18:21:18] <hoo>	 thedj: right, but I altered that cause I want the whole variant selection to have the focus
[18:21:19] <thedj>	 ah, you changed that
[18:21:29] <thedj>	 yeah, that's exactly why i left that in D:
[18:22:10] <hoo>	 maybe I should try to change the structure of the variant selection?
[18:23:33] <hoo>	 Focus on the whole div is ugly as well, I just changed that and remembered that I had that before :P
[18:23:47] <hoo>	 that also covers the expanded menu...
[18:25:33] <thedj>	 ah true
[18:25:45] <thedj>	 i tried that as well at one point in the past.
[18:26:36] <hoo>	 thedj: Do you think I should work on allowing the whole thing to have focus?
[18:27:00] <hoo>	 at least for sighted users it's fine as it is, but I'm afraid of testing that with screen readers
[18:27:07] <thedj>	 to me it's not really important. considering the amount of complaints we have had so far it doesn't seem as people have been throwing a fit about it.
[18:30:05] <grrrit-wm>	 (03PS1) 10Amire80: Update selenium-webdriver to 2.34 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80870 
[18:30:46] <grrrit-wm>	 (03CR) 10Amire80: "I'm not completely sure that I know what I'm doing. It's based on" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80870 (owner: 10Amire80)
[18:31:15] <grrrit-wm>	 (03PS5) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 
[18:31:34] <hoo>	 that will need further changes for screen reader accessibility, I guess
[18:32:05] <grrrit-wm>	 (03PS6) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 
[18:32:09] <grrrit-wm>	 (03CR) 10Amire80: "I did something similar in I8d9c427e3325913c445235f2951996904856cf74 :)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78233 (owner: 10Zfilipin)
[18:32:13] <hoo>	 forgot a trailing tab
[18:32:51] <grrrit-wm>	 (03PS7) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 
[18:33:09] <hoo|away>	 going to eat something... enough for now :P
[18:34:25] <thedj>	 MatmaRex: i just notice a bug in preview.js when doing first preview and then diff. you get an empty block due to the min-width on the preview div.
[18:35:09] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] mediawiki.action.edit.preview: Assorted fixes [core] - 10https://gerrit.wikimedia.org/r/76457 (owner: 10Matmarex)
[18:35:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man)
[18:36:54] <MatmaRex>	 thedj: oh. hm, true
[18:37:09] <thedj>	 shall i make a ticket out of it ?
[18:38:40] <MatmaRex>	 yeah, i guess
[18:41:43] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex)
[18:42:41] <grrrit-wm>	 (03PS3) 10Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 
[18:44:13] <grrrit-wm>	 (03PS4) 10Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 
[18:44:14] <grrrit-wm>	 (03PS2) 10Matmarex: Enhanced RC: Remove the list of users who edited the page [core] - 10https://gerrit.wikimedia.org/r/75571 
[18:44:42] <grrrit-wm>	 (03CR) 10Matmarex: "Got rid of the dependency (https://gerrit.wikimedia.org/r/#/c/75571/), since it's apparently controversial." [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex)
[18:44:47] <grrrit-wm>	 (03PS5) 10Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 
[18:45:41] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "I'll think about this later. Rebased to remove dependency from https://gerrit.wikimedia.org/r/#/c/75579/." [core] - 10https://gerrit.wikimedia.org/r/75571 (owner: 10Matmarex)
[18:49:06] <MatmaRex>	 git dev
[18:49:14] <MatmaRex>	 hrmph. wrong window.
[19:05:22] <hoo>	 thedj: Will you merge the Cite change today? Tomorrow Daniel K. from WMDE will hopefully be able to have a look at changes too, btw
[19:10:01] <grrrit-wm>	 (03CR) 10Matmarex: "@Nikerabbit, here's a screenshot: http://i.imgur.com/u8grXJp.png" [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex)
[19:10:11] <hoo>	 thedj: Changing the DOM structure for the variants menu seems to be easy, but I'm not sure it's desired...
[19:12:07] <hoo>	 mh, seems he's no longer around :(
[19:12:23] <hoo>	 MatmaRex: Do you maybe have an opinion on that?
[19:13:19] <MatmaRex>	 do eet.
[19:13:49] <hoo>	 MatmaRex: Problem is, that both h3 have different ids and a slightly different purpose -.-
[19:14:33] <MatmaRex>	 the current structure is the best i could come up with when unbreaking the navigation headings
[19:14:52] <hoo>	 MatmaRex: Oh, you did that?
[19:14:56] <MatmaRex>	 previously it was <h1> for page title, <h5>s foir navigation submenus, and <h4>+<h5> for variants
[19:15:10] <MatmaRex>	 now it's <h2> nav heading and <h3> navigation submenus
[19:15:32] <grrrit-wm>	 (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex)
[19:15:51] <hoo>	 MatmaRex: mh, I really want to come from to h3 for variants to one
[19:16:02] <MatmaRex>	 !bug 457
[19:16:03] <wm-bot>	 https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=457
[19:16:05] <MatmaRex>	 'twas the bug
[19:16:50] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/30361/:* Vector's variant menu is deeply broken. I changed the bonkers structure
[19:16:50] <MatmaRex>	 to two <h3>s, one with id=mw-vector-current-variant. This is still
[19:16:50] <MatmaRex>	 broken, but I don't really know how to do it properly.
[19:16:58] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/30361/
[19:17:07] <MatmaRex>	 if you have a better idea, i'll be really happy to review :D
[19:17:40] <hoo>	 let's see whether my idea works and whether you'll like it :P
[19:25:10] <grrrit-wm>	 (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex)
[19:25:14] <grrrit-wm>	 (03PS6) 10Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 
[19:28:05] <hoo>	 MatmaRex: I failed ... :P
[19:28:15] <MatmaRex>	 hoo: heh
[19:28:30] <grrrit-wm>	 (03PS8) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 
[19:28:38] <hoo>	 Don't want to waste to much time on that
[19:29:46] <hoo>	 what I already did :D
[19:33:26] <grrrit-wm>	 (03CR) 10Nikerabbit: "(1 comment)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 (owner: 10Alex Monk)
[19:34:59] <grrrit-wm>	 (03CR) 10Poke: "“Already fixed” – No it’s not? If I look at that patch there correctly, the `$optionalColon` is only set for category or interwiki links. " [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke)
[19:35:07] <grrrit-wm>	 (03CR) 10Hoo man: ""Additionally, this removes the alt, which might affect screenreaders that don't support aria." The alternative text isn't coming via aria" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man)
[19:36:07] <thedj>	 hoo: there probably isn't a better way anyways for that, but i just want to put it in the ticket.
[19:36:26] <thedj>	 it seems that google is also totally not accessible if you disable images.
[19:36:56] <hoo>	 thedj: Kai from WMDE only more or less recently changed the WikiEditor to use <a>, for making it tabable
[19:37:38] <hoo>	 Disabling images only affects that in some browsers, btw as the images are send as base64 with the CSS anyway
[19:42:31] <grrrit-wm>	 (03CR) 10Umherirrender: "Yeah, than you should rebase this change (and resolve the merge conflict) and than also add a optional colon for NS_FILE." [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke)
[19:48:05] <grrrit-wm>	 (03CR) 10Liangent: "See https://gerrit.wikimedia.org/r/#/c/71272/2/includes/content/WikitextContentHandler.php - some people don't like the idea to have it fo" [core] - 10https://gerrit.wikimedia.org/r/61283 (owner: 10Poke)
[19:51:15] <hoo>	 thedj: Have you tried NVDA yet? I keep seeing strange behaviour with aria-pressed
[19:51:40] <hoo>	 It only seems to notice an aria-pressed change if it's the first thing we do with the DOM ...
[19:53:13] <thedj>	 no
[19:54:48] <grrrit-wm>	 (03PS1) 10TheDJ: Accessibility: Add aria-sort to tablesorter [core] - 10https://gerrit.wikimedia.org/r/80872 
[19:54:58] <wmf-selenium-bot>	 Yippie, build fixed!
[19:54:58] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-chrome build #273: FIXED in 3 min 10 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/273/
[19:55:07] <grrrit-wm>	 (03CR) 10TheDJ: [C: 04-1] Accessibility: Add aria-sort to tablesorter [core] - 10https://gerrit.wikimedia.org/r/80872 (owner: 10TheDJ)
[19:55:56] <thedj>	 i'm thinking about removing role setting by tablesorter again. setting multiple roles in browsers is just badly supported.
[19:57:29] <hoo>	 thedj: Do we ahve a bug for the vector sidebar accessibility? I'm not aware of one
[19:57:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Accessibility: Add aria-sort to tablesorter [core] - 10https://gerrit.wikimedia.org/r/80872 (owner: 10TheDJ)
[19:58:10] <thedj>	 hoo: collapsing ?
[19:58:26] <hoo>	 thedj: Yes, that
[19:59:22] <quiddity>	 collapsible sections are evil.{{cn}}
[19:59:29] <hoo>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=46512
[19:59:51] <hoo>	 that's the only bug about the collapsible sidebar I know
[20:00:33] <thedj>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=29199 is somewhat related
[20:01:09] <hoo>	 thedj: oh yes... I already commented on that one... but I don't really have *the* solution for it either
[20:01:45] <thedj>	 there is no *the* solution in a11y :D
[20:01:58] <grrrit-wm>	 (03PS3) 10Alex Monk: Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 
[20:03:07] <hoo>	 ... sadly :D
[20:03:24] <thedj>	 hoo: i want to merge the Cite change, but something inside me keeps telling me "this should really be two patches" refacter Cite and an add backlink one...
[20:04:48] <hoo>	 oh that... I originally only wanted to do as few changes as possible, but then jenkins shouted at me...
[20:05:33] <hoo>	 thedj: Will you stick around longer today? If so, I can split that up and we can still merge it?
[20:05:41] <hoo>	 I really want to get something merged...
[20:06:03] <thedj>	 yeah, i'll be here for about 1,5 hour more
[20:06:47] <hoo>	 ok
[20:07:10] <grrrit-wm>	 (03PS5) 10Yuvipanda: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 
[20:07:11] <grrrit-wm>	 (03PS5) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 
[20:07:12] <grrrit-wm>	 (03PS1) 10Hoo man: Accessibility: Make the collapsible sidebar screen reader friendly [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80927 
[20:07:40] <hoo>	 thedj: ^ that needs a decent amount of testing and I would like to show it to Graham
[20:07:57] <hoo>	 but it already works ways better with Jaws and Nvda than the current thing
[20:08:12] <hoo>	 tomorrow I'll try to get that lab instance
[20:08:46] <thedj>	 was it not granted yet ?
[20:09:02] <hoo>	 Two hours ago it wasn't...
[20:09:07] <thedj>	 :(
[20:09:23] <thedj>	 guess some IRC channel poking will be required
[20:09:27] <hoo>	 https://wikitech.wikimedia.org/wiki/New_Project_Request/accessibility-dev still not
[20:09:49] <hoo>	 I'll be around tomorrow morning (but I guess the folks from the US wont) and in the afternoon again, I guess I can get someone there
[20:09:58] <hoo>	 Probably Ryan
[20:14:48] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda)
[20:16:55] <grrrit-wm>	 (03PS1) 10Hoo man: Refactor Cite extension JavaScript and make it pass Jshint [extensions/Cite] - 10https://gerrit.wikimedia.org/r/80944 
[20:17:07] <hoo>	 untested, yet
[20:17:43] <grrrit-wm>	 (03CR) 10Yuvipanda: "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda)
[20:19:26] <hoo>	 $ git refactor
[20:19:26] <hoo>	 git: 'refactor' is not a git command. See 'git --help'.
[20:19:28] <hoo>	 haha :P
[20:19:49] <grrrit-wm>	 (03PS6) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 
[20:19:59] <YuviPanda>	 MaxSem: ^ should address all the points you made.
[20:20:06] <YuviPanda>	 now to figure out how to do continue
[20:20:19] <marktraceur>	 hoo: for file in `ls`; do cat $file >> everything.php; rm $file; done
[20:20:29] <YuviPanda>	 a wild UploadWizard appears!
[20:20:39] <marktraceur>	 YuviPanda: I've been here for hours
[20:20:47] <YuviPanda>	 i never saw you talk!
[20:20:50] <marktraceur>	 I'm planning on reviewing UW stuff today maybe
[20:20:57] <marktraceur>	 YuviPanda: I didn't realize I was required to
[20:21:19] <YuviPanda>	 hmm, so you were here but you just appeared.
[20:21:22] <YuviPanda>	 still accurate, no?
[20:21:27] <marktraceur>	 ...sorta
[20:21:43] <MaxSem>	 YuviPanda, still  json_encode
[20:21:49] <YuviPanda>	 MaxSem: I responded why
[20:21:56] <YuviPanda>	 hopeuflly those comments got publishe
[20:21:56] <YuviPanda>	 d
[20:22:09] <grrrit-wm>	 (03PS10) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 
[20:22:17] <YuviPanda>	 yes, they did
[20:22:39] <YuviPanda>	 MaxSem: the data is stored natively as JSON, so returning it as that makes sense - rather than trying to convert it to whatever.
[20:23:28] <MaxSem>	 if it's already in json, why encode it again? if getConfig() returns it decoded, why encode back, just throw it at formatter and see what happens
[20:23:38] <grrrit-wm>	 (03PS2) 10Hoo man: Refactor Cite extension JavaScript and make it pass Jshint [extensions/Cite] - 10https://gerrit.wikimedia.org/r/80944 
[20:24:02] <YuviPanda>	 MaxSem: because if I get it via the page stuff, it'll automatically be encoded as it is read anyway (contenthandler)
[20:24:20] <YuviPanda>	 MaxSem: also because the code can then rely on it being JSON, which I think is a good thing. 
[20:24:40] <MaxSem>	 mmm, a fail in this I feel, young padawan
[20:24:55] <YuviPanda>	 Fail because it is storing data as JSON?
[20:25:14] <YuviPanda>	 also the users can make it *any* arbitrary JSON, and I don't really trust our formatters to be sane :P
[20:25:28] <MaxSem>	 because if the format is already json, you feed users double-encoded json
[20:26:16] <YuviPanda>	 MaxSem: yes, they need to json_encode the json. I was thinking about not doing the encode if it is already json
[20:26:21] <MaxSem>	 if JSON can be totally arbitrary, even malformed, just return page content precisely, without decoding of any kind
[20:26:32] <YuviPanda>	 it can't be malformed
[20:27:01] <YuviPanda>	 MaxSem: 'without decoding of any kind'? 
[20:27:24] <YuviPanda>	 MaxSem: oh, use WikiPage directly to get the content? yes, I could do that. 
[20:28:17] <grrrit-wm>	 (03PS3) 10Amire80: Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit)
[20:28:18] <YuviPanda>	 MaxSem: thoughts on letting it be for just JSON format?
[20:28:22] <YuviPanda>	 and encoding for all others?
[20:28:43] <MaxSem>	 ask yurik?:P
[20:28:55] <MaxSem>	 I know, he's not here:)
[20:28:58] <YuviPanda>	 :P
[20:30:41] <thedj>	 ah, i get it now. accessibility doms seem to break on thead...
[20:30:46] * thedj  cries

[20:31:42] <hoo>	 thedj: Gnaaaah
[20:31:53] <hoo>	 that span solution doesn't seem to work in IE with Jaws
[20:32:26] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 (owner: 10Alex Monk)
[20:32:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix for I6234a765 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/80803 (owner: 10Alex Monk)
[20:33:43] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 031] Update selenium-webdriver to 2.34 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80870 (owner: 10Amire80)
[20:34:36] <hoo>	 thedj: But I guess you could already take a look at https://gerrit.wikimedia.org/r/80944 ? going to reboot my windows machine now for another 40 minutes of Jaws...
[20:37:09] <grrrit-wm>	 (03CR) 10Legoktm: "The README should have been updated stating that compatibility would be broken..." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler)
[20:37:47] <hoo>	 legoktm: Go ahead, I'll merge it
[20:38:02] <thedj>	 hoo: get a VM
[20:38:34] <hoo>	 thedj: Don't have a spare Windows license for a local VM, I got one which is remote, but I can't use sound with it :P
[20:38:35] <thedj>	 virtualbox, free download from modern.ie for the instance and go :D
[20:40:10] <hoo>	 oh, that's even official :)
[20:40:27] <thedj>	 yup
[20:40:28] <thedj>	 https://modernievirt.blob.core.windows.net/vhd/virtualmachine_instructions_2013-07-22.pdf
[20:40:29] <hoo>	 and I can get Jaws/ Nvda to work in it (they're not locked down)
[20:40:32] <legoktm>	 hoo: Actually, I want to restore compatability
[20:40:41] <legoktm>	 I don't see why the old hooks had to be removed
[20:40:41] <hoo>	 oO
[20:40:44] <thedj>	 "these license terms override any conflicting license terms"
[20:41:02] <legoktm>	 if USE_CONTENT_HANDLER: $wgHooks['contentthingy'] else $wgHooks['deprecatedstuff']
[20:41:19] <thedj>	 hoo: you are actually not even allowed to activate that copy (which can get a tad annoying, but no more than jaws :D)
[20:41:20] <hoo>	 legoktm: Can't you use a legacy branch for that?
[20:41:31] <Technical_13>	 !blink
[20:41:32] <wm-bot>	 <bawolff> Technical_13: When you use <blink>, you're not just hurting yourself, but also hurting those around you
[20:41:53] <Technical_13>	 Ha..
[20:42:11] <Technical_13>	 Still think that's fun-knee!!!
[20:42:29] <legoktm>	 hoo: i guess, but there's no reason why we can't do this either. unless people keep introducing more non-compatible changes (which i doubt will happen)
[20:42:35] <hoo>	 thedj: Should we maybe built in a browser distinction or something like that? I don't really want to set aria-label onto all links but IE just doesn't seem to handle it properly with the span... *sigh*
[20:42:44] <thedj>	 hoo: it's probably the first strategy to get people to develop for IE that might actually put a dent into the numbers :D
[20:43:14] <hoo>	 legoktm: Well, it gets harder to maintain
[20:43:23] <legoktm>	 no one maintains it anyways :P
[20:43:23] <thedj>	 hoo: perhaps we need to go that far yes :(
[20:43:52] <hoo>	 mh... now Jaws even crashed :P
[20:46:04] <Nemo_bis>	 sounds painful
[20:48:10] <grrrit-wm>	 (03PS8) 10Liangent: Add hook NewAccountApiData for action=apicreate [core] - 10https://gerrit.wikimedia.org/r/53793 (owner: 10Brion VIBBER)
[20:48:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add hook NewAccountApiData for action=createaccount [core] - 10https://gerrit.wikimedia.org/r/53793 (owner: 10Brion VIBBER)
[20:56:21] <grrrit-wm>	 (03CR) 10TheDJ: "Link to aria-pressed problem: https://bugs.webkit.org/show_bug.cgi?id=115298" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man)
[20:57:42] <hoo>	 thedj: Or we add the label with some span and hide it with some CSS voodoo?
[20:57:50] <hoo>	 That'll work in all browsers
[21:01:33] <grrrit-wm>	 (03PS7) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 
[21:01:59] <hoo>	 my current version is if ( $.client.profile().name !== 'firefox' ) ...
[21:03:13] <Technical_13>	 Wait.. what?
[21:03:51] <Technical_13>	 JQuery has a $.client ?
[21:04:06] <hoo>	 Technical_13: That's one of our extensions to it
[21:04:14] <Technical_13>	 Oh
[21:04:33] <MatmaRex>	 hm
[21:04:40] <MatmaRex>	 is it just me, or does VE not load on https://www.mediawiki.org/wiki/VisualEditor:Achey_breaky_lists ?
[21:04:46] <hoo>	 MatmaRex: Did you follow up?
[21:04:57] <MatmaRex>	 hoo: to what?
[21:05:29] <hoo>	 MatmaRex: Cite extension accessibility
[21:06:02] <MatmaRex>	 um, no
[21:06:58] <hoo>	 ok...
[21:07:20] <hoo>	 MatmaRex: Do you know a *good* way to visually hide elements via CSS
[21:07:24] <MatmaRex>	 but looking at your chat here these screen readers seem to be worse than ie6
[21:07:56] <MatmaRex>	 hoo: yes
[21:07:59] <MatmaRex>	 hoo: one sec
[21:08:02] <hoo>	 :)
[21:08:33] <grrrit-wm>	 (03CR) 10TheDJ: "Filed a ticket with webkit, since I can find any example of this that actually works in Safari6+VO." [core] - 10https://gerrit.wikimedia.org/r/80872 (owner: 10TheDJ)
[21:09:59] <MatmaRex>	 ah, the suspense, my irc client decided it's the best moment to break
[21:10:10] <MatmaRex>	 hoo: position: absolute; clip: rect(1px 1px 1px 1px); clip: rect(1px,1px,1px,1px);
[21:10:43] <hoo>	 seems weird... is that used anywhere big scale?
[21:10:52] <MatmaRex>	 position: absolute; top: -9999px; is fine too
[21:11:10] <MatmaRex>	 hoo: dantman once told me to use it :P i think drupal uses it or something
[21:11:14] <MatmaRex>	 !g 879a80c3
[21:11:15] <wm-bot>	 https://gerrit.wikimedia.org/r/#q,879a80c3,n,z
[21:11:36] <thedj>	 both have their downsides
[21:11:51] <hoo>	 thedj: Sure, but I guess it's the only way we have here
[21:12:00] <MatmaRex>	 hm, not on that patch.
[21:12:15] <MatmaRex>	 (i ended up using top: -9999px there)
[21:12:15] <hoo>	 or do you have a better idea? I don't :/
[21:12:15] <thedj>	 i'm checking the cite refactor now btw.
[21:12:21] <hoo>	 :)
[21:12:59] <hoo>	 MatmaRex: If it's used in vector, I guess it's fine for Cite either
[21:13:36] <MatmaRex>	 hoo: the clip thing doesn't seem to be used in core apart from some jquery stuff
[21:14:19] <thedj>	 actually if you look online, i think that they advise you to combine the both of them even.
[21:14:21] <MatmaRex>	 hoo: 9999px might not be enough, depending on where you put it
[21:14:31] <MatmaRex>	 (unless you use left:, i guess)
[21:14:50] <MatmaRex>	 huh, why would you use both?
[21:14:57] <MatmaRex>	 i mean, it shouldn't hurt, but what for?
[21:15:11] <hoo>	 WordPress seems to like this technique: { position: absolute !important; clip: rect(1px 1px 1px 1px); clip: rect(1px, 1px, 1px, 1px); }
[21:15:16] <hoo>	 from https://bugzilla.wikimedia.org/show_bug.cgi?id=41297
[21:17:51] * hoo  slaps himself

[21:18:08] <hoo>	 I forgot... if you only use tab to navigate even that hidden label wont be read
[21:18:15] <hoo>	 thedj: ^ :(
[21:18:35] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Refactor Cite extension JavaScript and make it pass Jshint [extensions/Cite] - 10https://gerrit.wikimedia.org/r/80944 (owner: 10Hoo man)
[21:18:38] <hoo>	 so that was totally useless to implement...
[21:18:47] * hoo  reverts

[21:19:20] <thedj>	 ok, the rest is for another time. I'm done for today :D
[21:19:28] <hoo>	 thedj: :P
[21:19:35] * thedj  high fives hoo

[21:19:41] <hoo>	 \o/
[21:19:52] <hoo>	 thedj: Are you ok with having a browser switch in there?
[21:20:49] <grrrit-wm>	 (03PS11) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 
[21:20:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man)
[21:21:44] <grrrit-wm>	 (03PS12) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 
[21:21:58] <thedj>	 it's ugly and should be avoided at all cost, but if that makes it a fault tolerant  progressive enhancement then /me like
[21:22:32] <hoo>	 well :/
[21:26:30] <hoo>	 thedj: Ok, good night then... I hope to see you around tomorrow, I would really like to get at least the Cite change done soon :) Thanks for all your help
[21:52:03] <grrrit-wm>	 (03PS4) 10Hoo man: Add aria properties to TOC for accessibility [core] - 10https://gerrit.wikimedia.org/r/79053 
[21:53:08] <grrrit-wm>	 (03CR) 10Hoo man: "Use aria-expanded on the button element now. Also use aria-haspopup." [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man)
[22:13:10] <grrrit-wm>	 (03PS5) 10Hoo man: Add aria properties to TOC for accessibility [core] - 10https://gerrit.wikimedia.org/r/79053 
[22:16:35] <grrrit-wm>	 (03CR) 10Hoo man: "Added aria-hidden now." [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man)
[22:43:22] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21)
[22:46:56] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Profiler: remove unnecessary function calls [core] - 10https://gerrit.wikimedia.org/r/80532 (owner: 10PleaseStand)
[22:47:04] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Profiler: remove unnecessary checks Should slightly reduce overhead. [core] - 10https://gerrit.wikimedia.org/r/80532 (owner: 10PleaseStand)
[22:49:24] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 (owner: 10Rahul21)
[22:51:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Profiler: remove unnecessary checks Should slightly reduce overhead. [core] - 10https://gerrit.wikimedia.org/r/80532 (owner: 10PleaseStand)
[23:12:19] <grrrit-wm>	 (03PS21) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[23:32:15] <grrrit-wm>	 (03PS22) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[23:48:17] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev)
[23:51:11] <grrrit-wm>	 (03PS8) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139