[00:00:12] (03CR) 10MarkTraceur: [C: 032] "I faintly remember hashar mumbling about voting defaulting to true, but I must be wrong due to the surrounding code. DEPLOY TIEM" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80518 (owner: 10Mwalker) [00:00:17] (03Merged) 10jenkins-bot: CentralNotice now passes JSLint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80518 (owner: 10Mwalker) [00:00:50] Actually, the raw value of the 'chocolate chip' cookie is 'chocolate+chip' according to my inspector, which seems appropriate [00:03:32] marktraceur: actually; I think the cookiemonster plugin should make gobble sounds whenever you clear out the cookiejar [00:03:36] mwalker: Deployed [00:03:39] rather than just eating a Choco+Chip cookie [00:03:44] yay! thanks :) [00:03:48] My pleasure! [00:03:57] Try breaking it, let me know when you've submitted a test patch [00:06:23] marktraceur: https://gerrit.wikimedia.org/r/80522 [00:06:39] Gratz, you didn't crash zuul! [00:06:51] yaaay [00:07:00] (03CR) 10Spage: [C: 032] "Wording changes look good, it switches layout at about the right size in Firefox." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 (owner: 10Mattflaschen) [00:07:06] (03Merged) 10jenkins-bot: Improve wording of toolbar. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 (owner: 10Mattflaschen) [00:07:29] (03PS3) 10Brian Wolff: Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 [00:08:00] we're now one extension closer to being able to flip the default from false to true [00:10:07] mwalker: I'm right behind you with UW [00:10:14] This fucker is *big* though [00:11:23] it ate too many cookies [00:35:58] (03PS3) 10Brian Wolff: Make thumb_handler.php use MediaHandler::parseParamString [core] - 10https://gerrit.wikimedia.org/r/69027 [00:36:34] (03CR) 10Brian Wolff: "PS3: rebase" [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [00:42:57] (03CR) 10Ori.livneh: "This change came first; on what grounds are you blocking it, exactly?" [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex) [00:48:35] (03PS2) 10Ori.livneh: Remove inconsistent font-family declarations [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex) [00:55:59] (03PS1) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [00:56:40] (03CR) 10MarkTraceur: "Note I'm depending on a commit - closures fix a lot of the jshint failures by making sure mw and $ are defined." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [00:57:10] mwalker: I won't ask you to review it but https://gerrit.wikimedia.org/r/80523 oh my god [00:57:24] If you find me unconscious and frothing that's the reason [00:57:39] Also if you find me murdering JavaScript coders [01:09:53] (03PS2) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [01:11:04] (03CR) 10Mwjames: [C: 032] \SMW\Subobject, SubobjectParserFunction use HashIdGenerator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80502 (owner: 10Mwjames) [01:11:05] (03PS3) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [01:11:27] James_F: ^^ I needed to add a proper .jshintrc but now it's down to ~500 errors total [01:11:34] marktraceur: Yay. [01:11:37] And how [01:12:40] (03Merged) 10jenkins-bot: \SMW\Subobject, SubobjectParserFunction use HashIdGenerator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80502 (owner: 10Mwjames) [01:13:37] (03PS1) 10MarkTraceur: Add a .jshintrc file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80524 [01:14:03] (03PS4) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [01:14:04] (03PS2) 10MarkTraceur: Put closures everywhere [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [01:14:09] All the patches [01:14:44] 972 --> 496 [01:14:47] Not half bad [01:14:57] Not stellar [01:15:45] marktraceur: Yay. [01:17:08] (03PS4) 10Mwjames: Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 [01:17:26] (03CR) 10Reedy: [C: 032 V: 032] Fatal error: Call to a member function formatDuration() on a non-object in SpecialUserlogin.php on line 818 [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80521 (owner: 10Reedy) [01:24:31] Reedy: It's kinda scary that your code review was +2 V+2 and the comment was a Fatal error string [02:33:43] (03CR) 10Mattflaschen: [C: 04-1] "What I said in my previous comment, and at the bug report (https://bugzilla.wikimedia.org/show_bug.cgi?id=44394#c60 and https://bugzilla.w" [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex) [04:21:57] (03PS9) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [04:21:58] (03PS28) 10Rasel160: Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 [04:24:26] Yay! [04:34:41] (03PS10) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [05:54:22] (03CR) 10Krinkle: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [05:54:47] (03CR) 10Ori.livneh: [C: 032] jquery.chosen: set default text width to auto [core] - 10https://gerrit.wikimedia.org/r/80517 (owner: 10Ryan Lane) [05:57:46] (03Merged) 10jenkins-bot: jquery.chosen: set default text width to auto [core] - 10https://gerrit.wikimedia.org/r/80517 (owner: 10Ryan Lane) [06:00:37] ori-l: ^^ thanks! [06:01:01] Ryan_Lane: np [06:01:22] mind taking a quick look at this one? https://gerrit.wikimedia.org/r/#/c/78214/ [06:01:29] you had already +2'd, but it needed a rebase [06:04:52] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex) [06:05:21] sure [06:05:56] (03CR) 10Ori.livneh: [C: 032] htmlform multiselect chosen: Replace lists [core] - 10https://gerrit.wikimedia.org/r/78214 (owner: 10Ryan Lane) [06:06:15] I spent all day closing out my open changes and I'm down to 2 now. It's a good day :D [06:06:23] thanks! [06:07:06] :) [06:08:46] (03Merged) 10jenkins-bot: htmlform multiselect chosen: Replace lists [core] - 10https://gerrit.wikimedia.org/r/78214 (owner: 10Ryan Lane) [06:45:27] (03PS1) 10Rfaulk: fix - missing self refs in class methods. [sartoris] - 10https://gerrit.wikimedia.org/r/80529 [06:45:52] (03CR) 10Rfaulk: [C: 032 V: 032] fix - missing self refs in class methods. [sartoris] - 10https://gerrit.wikimedia.org/r/80529 (owner: 10Rfaulk) [07:06:50] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler) [07:12:54] (03PS1) 10PleaseStand: Profiler: remove unnecessary function calls [core] - 10https://gerrit.wikimedia.org/r/80532 [07:13:41] (03Abandoned) 10PleaseStand: Profiler: remove unnecessary function calls [core] - 10https://gerrit.wikimedia.org/r/80532 (owner: 10PleaseStand) [07:24:44] (03Restored) 10PleaseStand: Profiler: remove unnecessary function calls [core] - 10https://gerrit.wikimedia.org/r/80532 (owner: 10PleaseStand) [07:40:59] (03PS2) 10AndyRussG: Add getTourSpec to public API for mw.guidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79549 [07:49:03] (03CR) 10Huji: [C: 031] "Should solve the bug as desired." [core] - 10https://gerrit.wikimedia.org/r/80492 (owner: 10Amire80) [07:53:37] (03CR) 10AndyRussG: "Now that you mention it, it may indeed make more sense to have a bunch of getters and setters instead of exposing the spec. That would mak" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79549 (owner: 10AndyRussG) [07:57:07] (03CR) 10Amire80: [C: 04-1] "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [07:57:22] (03PS2) 10Nikerabbit: Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 [08:19:36] (03CR) 10AndyRussG: "(2 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 (owner: 10AndyRussG) [08:28:31] (03PS3) 10AndyRussG: Added experimental uncacheable prop to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 [08:50:31] (03PS1) 10Petrb: Fix of oracle installation sql [core] - 10https://gerrit.wikimedia.org/r/80538 [08:54:09] petan: here? ^ [08:54:23] :o [08:54:33] I thought plans for this channel were: remove it [08:54:54] on other hand it's good to keep bots out of #mediawiki [09:00:26] (03CR) 10AndyRussG: "> it might be better for callers to explicitly call a" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 (owner: 10AndyRussG) [09:02:11] (03CR) 10Freakolowsky: [C: 031] "uff ... 10x ... slipped my mind ..." [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [09:12:28] (03CR) 10Yuvipanda: [C: 04-1] "Causes a JS error when the type is set to select but no options are defined. Should have a guard there." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [09:27:44] (03CR) 10TheDJ: "I've been looking at the google products a bit, and it seems that they use aria-expanded on the control that is expanding/collapsing the c" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [10:04:57] (03CR) 10AndyRussG: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79568 (owner: 10AndyRussG) [10:15:08] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex) [10:39:41] (03PS1) 10Matthias Mullie: Don't unhide when declining oversight [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/80545 [11:41:59] (03PS1) 10Shirayuki: Spell check [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/80551 [11:42:54] (03PS2) 10Nemo bis: Rephrase the installer's config-welcome message [core] - 10https://gerrit.wikimedia.org/r/78375 [11:43:06] (03PS2) 10Nemo bis: Add email recipient username as a parameter to emailuser confirmation [core] - 10https://gerrit.wikimedia.org/r/78404 [11:43:15] (03PS2) 10Nemo bis: Make restoreprefs crystal clear about the meaning of *all* [core] - 10https://gerrit.wikimedia.org/r/78616 [11:43:23] (03PS4) 10Nemo bis: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 [11:52:49] (03CR) 10Shirayuki: [C: 031] Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [12:04:09] (03PS7) 10Pastakhov: Refactoring, compiler is used instead of the interpreter (version 1.0.0) [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 [12:13:22] (03CR) 10Pastakhov: "* adds support parentheses" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/72073 (owner: 10Pastakhov) [12:31:49] (03CR) 10Grunny: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [12:48:03] (03PS5) 10Shirayuki: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [12:53:00] (03PS1) 10Yaron Koren: Added DB table name escaping for '_none' option, to allow for prefixes [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80552 [12:56:05] (03CR) 10Yaron Koren: [C: 032 V: 031] Added DB table name escaping for '_none' option, to allow for prefixes [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80552 (owner: 10Yaron Koren) [12:56:07] (03Merged) 10jenkins-bot: Added DB table name escaping for '_none' option, to allow for prefixes [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80552 (owner: 10Yaron Koren) [13:09:38] (03PS1) 10Umherirrender: Remove extra comma to avoid fatal in IE7 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80556 [13:28:10] (03PS1) 10Yaron Koren: More SQL fixes for when SMW ID is not unique [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80558 [13:31:51] (03CR) 10Yaron Koren: [C: 032 V: 031] More SQL fixes for when SMW ID is not unique [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80558 (owner: 10Yaron Koren) [13:31:53] (03Merged) 10jenkins-bot: More SQL fixes for when SMW ID is not unique [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/80558 (owner: 10Yaron Koren) [13:50:52] (03CR) 10Matthias Mullie: [C: 032] Add replication delay handling to page-link formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80497 (owner: 10Bsitu) [13:50:59] (03Merged) 10jenkins-bot: Add replication delay handling to page-link formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80497 (owner: 10Bsitu) [13:57:17] (03CR) 10Matthias Mullie: [C: 031] Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [14:25:56] (03CR) 10TheDJ: [C: 032] Remove extra comma to avoid fatal in IE7 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80556 (owner: 10Umherirrender) [14:26:03] (03Merged) 10jenkins-bot: Remove extra comma to avoid fatal in IE7 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80556 (owner: 10Umherirrender) [14:28:24] (03CR) 10Demon: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 (owner: 10Manybubbles) [14:28:28] Reedy: we should backport that ^ change I fear... [14:28:36] lol [14:29:05] stupid IE fatals [14:31:15] (03CR) 10Demon: [C: 032] "This works for now. I can see this getting really nasty eventually as we come up with other things we're going to strip. We should probabl" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80018 (owner: 10Manybubbles) [14:31:20] (03Merged) 10jenkins-bot: Remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80018 (owner: 10Manybubbles) [14:52:29] (03PS1) 10Reedy: Fix variable typo $kewRow -> $keyRow [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80564 [14:54:13] (03PS1) 10Reedy: Fix undefined $project [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80565 [14:59:23] (03PS1) 10Reedy: Blocked used should be disallowed from being added to shell [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80566 [15:03:44] https://twitter.com/ircmaxell/status/370917906814468096 [15:03:50] (03PS4) 10Anomie: Invalid data should cause an error, not a silent placeholder [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 [15:04:03] (03CR) 10Anomie: "PS4: Add tests" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 (owner: 10Anomie) [15:10:07] (03Abandoned) 10Anomie: Disable logins when OAuth is in use [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/78150 (owner: 10Anomie) [15:10:20] (03Abandoned) 10Anomie: Use core private session handling [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78149 (owner: 10Anomie) [15:49:44] (03PS1) 10Anomie: Allow for non-web-based consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 [15:56:25] (03PS6) 10Siddhartha Ghai: (bug 38863) Add tooltip-like UI beside the title [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/74649 [15:56:26] (03CR) 10jenkins-bot: [V: 04-1] (bug 38863) Add tooltip-like UI beside the title [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/74649 (owner: 10Siddhartha Ghai) [16:05:43] (03PS1) 10Rahul21: Separate module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [16:11:52] (03PS1) 10QChris: Indicate which the relevant time period in section heading [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 [16:12:20] (03PS2) 10QChris: Indicate which the relevant time period in section heading [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 [16:20:00] (03PS1) 10Reedy: Update WikiEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80575 [16:20:35] (03PS1) 10Reedy: Update WikiEditor to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80576 [16:21:16] (03PS2) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [16:22:33] (03CR) 10Reedy: [C: 032 V: 032] Update WikiEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80575 (owner: 10Reedy) [16:22:42] (03CR) 10Reedy: [C: 032 V: 032] Update WikiEditor to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80576 (owner: 10Reedy) [16:29:45] (03CR) 10Demon: [C: 031] "Why can't I verify this? Ugh." [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 (owner: 10QChris) [16:31:21] (03CR) 10Ori.livneh: [C: 04-1] "-1ing just to make sure you saw my previous couple of comments" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [16:32:47] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 (owner: 10Rahul21) [16:33:59] (03CR) 10CSteipp: "My initial thought is that I don't want to violate the protocol quite this much-- the callback url is required by the protocol, and I want" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie) [16:40:55] (03PS1) 10MaxSem: Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 [16:43:41] (03CR) 10jenkins-bot: [V: 04-1] Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [16:48:17] (03CR) 10Anomie: "That's pretty much what this does, except leaving the "callback URL" box empty when registering is treated the same as pasting in the Spec" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie) [16:49:59] ori-l: Sorry, looking through at change now [16:50:17] I can't actually find where we're using typeToString in the code apart from ApiQueryRecentChanges [16:51:47] hey, can I ask a question about rev_parent_id ? [16:53:19] ori-l, looks like I stopped using it in https://gerrit.wikimedia.org/r/#/c/52922/15..16/includes/rclivefeed/JSONRCFeedFormatter.php [16:53:51] Did we discuss that? [17:04:50] (03CR) 10Hoo man: [C: 04-1] "(5 comments)" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 (owner: 10Daniel Kinzler) [17:08:07] hey hey [17:08:10] I just got disconnected [17:08:15] average: just ask :) [17:08:16] !ask [17:08:16] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [17:08:22] if I have a mediawiki question about Mediawiki schema [17:08:25] can I ask here ? [17:08:40] like, Revision.rev_parent_id , is it non-null ? [17:08:56] (03PS7) 10Siddhartha Ghai: (bug 38863) Add tooltip-like UI beside the title [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/74649 [17:09:14] !master maintenance/tables.sql [17:09:14] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/maintenance%2ftables.sql [17:09:25] thanks sir [17:09:41] rev_parent_id int unsigned default NULL, [17:16:28] MatmaRex: yeah, thanks [17:17:01] (03CR) 10CSteipp: "Parent5446: The way that I'm looking at this is that if the user has gone to the trouble of setting their preference, then they do in fact" [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [17:23:16] MatmaRex: http://www.theonion.com/articles/coworker-with-two-computer-screens-not-fucking-aro,29151/ [17:27:47] YuviPanda: :D [17:28:06] YuviPanda: i'm probably the only guy 'round using this resolution combination, though. [17:28:10] MatmaRex: :D I've been a fan of 1.5 screens, which is 1 laptop with 13" + 21" 1080p [17:28:14] (03PS2) 10AndyRussG: Added the gap property to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79568 [17:28:28] MatmaRex: what res? [17:28:36] i ave a 15" laptop and a widescreen which is something like 19" [17:28:53] 1400x1050 + 1280x768 [17:29:20] low res because my desk is small and it's far away, and that's the simplest way to make text bigger :D [17:29:53] MatmaRex: heh. [17:30:15] mine says '1080p' and 1400x900 [17:30:29] i currently only have irc on the larger smaller-res screen. looks funny. [17:30:53] yeah, I do that [17:30:57] IRC + mail on this one [17:31:00] 'productive' work on the other [17:31:08] also, it seems that .flux only handles one display. :( [17:31:12] f.lux* [17:31:43] (03CR) 10AndyRussG: "Done! Note that I've only checked that it works with guiders in the top and bottom positions." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79568 (owner: 10AndyRussG) [17:32:07] MatmaRex: I somehow once had two versions of f.lux running, and they seem to have been configured for different temps. [17:32:12] was interesting watch them 'fight' over it [17:33:02] it also makes ATI's "command center" utility go completely bonkers [17:37:44] (03PS22) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [17:37:45] (03PS4) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [17:37:46] (03PS26) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [17:37:47] (03PS30) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [17:37:48] (03PS33) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [17:38:50] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80421 (owner: 10Aaron Schulz) [17:39:08] (03CR) 10Brian Wolff: "PS3: Do for archive files, and address Arron's concerns." [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [17:42:43] (03CR) 10Ryan Lane: [C: 04-1] "(1 comment)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80566 (owner: 10Reedy) [17:43:34] qgil: http://mehfilindian.com/2ndStreet/2ndStreetLunchMenuToGo.html [17:52:24] hi andre__, what would be a good place for http://www.mediawiki.org/wiki/Community_metrics bugs & feature requests? [17:53:04] (03CR) 10Matmarex: [C: 031] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [17:54:02] qgil, spontaneously I'd say: A component under https://bugzilla.wikimedia.org/describecomponents.cgi?product=Analytics [17:54:13] if none of the Analytics folks has something against that [17:55:52] andre__, works for me. I'll ask at the analytics list for politeness [18:00:17] (03CR) 10Demon: [C: 032] Consider links from redirects in boosts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80246 (owner: 10Manybubbles) [18:00:20] (03Merged) 10jenkins-bot: Consider links from redirects in boosts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80246 (owner: 10Manybubbles) [18:00:43] (03CR) 10Demon: [C: 032] Add some regression tests for search a file. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80074 (owner: 10Manybubbles) [18:00:46] (03Merged) 10jenkins-bot: Add some regression tests for search a file. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80074 (owner: 10Manybubbles) [18:01:11] (03CR) 10Demon: [C: 032] Test to verify page weight considers redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 (owner: 10Manybubbles) [18:01:12] (03CR) 10jenkins-bot: [V: 04-1] Test to verify page weight considers redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 (owner: 10Manybubbles) [18:01:34] !roadmap [18:01:34] For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [18:02:35] (03CR) 10Demon: [C: 032] Move slow deletion purges out of complex DB transactions [core] - 10https://gerrit.wikimedia.org/r/80250 (owner: 10Aaron Schulz) [18:02:56] (03CR) 10Demon: [C: 032] Simplified some tedious profiling code [core] - 10https://gerrit.wikimedia.org/r/80416 (owner: 10Aaron Schulz) [18:03:10] (03CR) 10Demon: [C: 032] Further fix to profiling order for DBPerformance log [core] - 10https://gerrit.wikimedia.org/r/80495 (owner: 10Aaron Schulz) [18:03:19] (03PS1) 10Umherirrender: Remove extra comma to avoid fatal in IE7 [core] - 10https://gerrit.wikimedia.org/r/80582 [18:04:07] (03CR) 10Demon: [C: 032] Mention required key format [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80153 (owner: 10Aaron Schulz) [18:05:16] (03Merged) 10jenkins-bot: Mention required key format [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80153 (owner: 10Aaron Schulz) [18:06:49] (03Merged) 10jenkins-bot: Move slow deletion purges out of complex DB transactions [core] - 10https://gerrit.wikimedia.org/r/80250 (owner: 10Aaron Schulz) [18:08:21] (03Merged) 10jenkins-bot: Simplified some tedious profiling code [core] - 10https://gerrit.wikimedia.org/r/80416 (owner: 10Aaron Schulz) [18:09:37] (03CR) 10Umherirrender: "Introduced with I4a0af8986f924cd127a73828e72da6998f28536c, but jslint does not give a hint about that in the commit." [core] - 10https://gerrit.wikimedia.org/r/80582 (owner: 10Umherirrender) [18:09:59] (03Merged) 10jenkins-bot: Further fix to profiling order for DBPerformance log [core] - 10https://gerrit.wikimedia.org/r/80495 (owner: 10Aaron Schulz) [18:11:43] (03PS1) 10Demon: Default is not necessary for toggle fields [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80583 [18:12:30] (03PS1) 10Demon: Default is not necessary for toggle fields [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80584 [18:15:26] (03CR) 10Demon: [C: 032] Default is not necessary for toggle fields [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80583 (owner: 10Demon) [18:16:54] (03CR) 10Demon: [C: 032] Default is not necessary for toggle fields [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80584 (owner: 10Demon) [18:17:13] (03PS1) 10Umherirrender: Remove extra comma to avoid fatal in IE7 [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80586 [18:18:30] (03Merged) 10jenkins-bot: Default is not necessary for toggle fields [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80583 (owner: 10Demon) [18:20:13] (03Merged) 10jenkins-bot: Default is not necessary for toggle fields [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80584 (owner: 10Demon) [18:21:18] (03CR) 10Demon: [C: 031] "I agree with Chris." [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [18:21:50] (03CR) 10Demon: [C: 031] Use User Preference for logged-in HTTPS choice [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80331 (owner: 10CSteipp) [18:28:06] (03PS1) 10Demon: Remove now pointless $wgSecureLoginDefaultHTTPS [core] - 10https://gerrit.wikimedia.org/r/80587 [18:31:30] (03CR) 10Matmarex: [C: 032] Remove extra comma to avoid fatal in IE7 [core] - 10https://gerrit.wikimedia.org/r/80582 (owner: 10Umherirrender) [18:32:11] (03CR) 10Matmarex: "I think this file is still in jshintignore, so yeah." [core] - 10https://gerrit.wikimedia.org/r/80582 (owner: 10Umherirrender) [18:34:10] (03Merged) 10jenkins-bot: Remove extra comma to avoid fatal in IE7 [core] - 10https://gerrit.wikimedia.org/r/80582 (owner: 10Umherirrender) [18:40:21] (03CR) 10Parent5446: "My reasoning is that the prefershttps preference should be what it sounds like: does the user prefer HTTPS? Let's say there's a wiki that " [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [18:42:56] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80587 (owner: 10Demon) [18:43:36] (03CR) 10Parent5446: [C: 032] Fatal error: Call to a member function formatDuration() on a non-object in SpecialUserlogin.php on line 818 [core] - 10https://gerrit.wikimedia.org/r/80520 (owner: 10Reedy) [18:46:19] (03Merged) 10jenkins-bot: Fatal error: Call to a member function formatDuration() on a non-object in SpecialUserlogin.php on line 818 [core] - 10https://gerrit.wikimedia.org/r/80520 (owner: 10Reedy) [18:46:53] how do I stop GeSHi/syntaxhighlight changing the filename in SOURCE central-auth.sql to "central-auth.SQL" ? [18:48:05] brion: our API 'how to write a new module' documentation sucks really badly :( [18:48:10] as in, I've not been able to find it at all :( [18:48:24] YuviPanda: what i do is cut-n-paste another module as boilerplate [18:48:28] its …. not always pretty ;) [18:48:44] RoanKattouw_away or others -- any doc recommendations for api modules ? [18:48:47] brion: I did that, and am now digging into the base classes there to understand wtf is going on [18:49:01] it's kinda spaghetti in places [18:49:05] brion: also wondering if I should write a list query module or a generator module [18:49:06] would be simpler if we made output json-only ;) [18:49:16] YuviPanda: for campaigns or? [18:49:19] brion: campaigns [18:49:22] can people use some consistent topic for patches related to https? [18:49:32] they pop up frequently these days [18:49:42] liangent: I think ^d mentione done [18:49:43] yeah a generator seems like it might make sense… do we need to be able to do other types of queries in a single fetch? [18:49:43] like the previous topic 'skinremoval [18:49:48] if not then a queyr is probably easier [18:50:25] <^d> I've been using https-fun for mine. Can't control what others do :) [18:51:20] brion: hmm, so currently the things I'm thinking of is 'only enabled' [18:51:34] brion: but eventually we should be able to ask it things like 'with co-ords around x, y' [18:51:40] ooh that'd be handy [18:51:42] brion: or similar. [18:51:47] brion: it'll be trivial to do in the database [18:52:12] brion: so I'm wondering if we should just use a list, rather than a generator. I'm not sure where exactly a generator would be useful [18:52:37] ^d: https://gerrit.wikimedia.org/r/#/q/topic:https-fun,n,z nothing here? [18:53:02] YuviPanda: yeah i think a list query will work just fine for that [18:53:24] brion: yeah, and eventually we might want to have 'parsed' responses too, that give us the responses parsed in a particular language [18:53:24] unless you want to throw in extra queries like pageimages… but sample images can probably go in the json directly [18:53:28] *nod* [18:53:30] <^d> liangent: status:merged perhaps? Probably is assuming status:open since you didn't specify. [18:55:37] ^d: topic:https-fun status:merged doesn't load [18:55:47] waiting forever for me [18:55:55] <^d> Heh, it has to revwalk a ton of repos ;-) [18:56:02] <^d> Shows up for me, just takes a bit. [18:57:29] how long did you wait before it shows up? [18:57:48] <^d> Like...30 seconds? [18:58:43] it has been working for minutes for me [18:58:45] and still working [18:59:43] yeah, "topic:https-fun status:merged" doesn't look like it's going to load for me either [19:01:11] oh finally the result is there [19:01:28] after waiting for maybe 5 minutes [19:08:11] (03CR) 10TheDJ: [C: 032] Remove extra comma to avoid fatal in IE7 [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80586 (owner: 10Umherirrender) [19:08:45] (03Merged) 10jenkins-bot: Remove extra comma to avoid fatal in IE7 [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80586 (owner: 10Umherirrender) [19:17:21] (03PS1) 10TheDJ: Remove extra comma to avoid fatal in IE7 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80589 [19:18:41] (03CR) 10Hoo man: [C: 032] "this really breaks in IE? Wow..." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80589 (owner: 10TheDJ) [19:18:46] (03Merged) 10jenkins-bot: Remove extra comma to avoid fatal in IE7 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/80589 (owner: 10TheDJ) [19:23:48] (03CR) 10Tpt: [C: 04-1] "(9 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [19:30:48] Nikerabbit, is there a way for me to update https://km.m.wikipedia.org/wiki/%E1%9E%98%E1%9F%81%E1%9E%8C%E1%9E%B6%E1%9E%9C%E1%9E%B7%E1%9E%82%E1%9E%B8:Mobile.css so that it would point to a protocol relative location on WMF servers? [19:31:24] Nikerabbit, the reference to Google's servers will induce a charge for Wikipedia Zero users, unfortunately. i thought you may have insight on an RL call or something that i could use for ULS./ [19:32:43] dr0ptp4kt: Thanks for bringing up [19:32:49] dr0ptp4kt: ULS doesn't have those fonts, but you can probably remove those regardless because they violate the privacy policy [19:32:52] I will immediatley kill the 3rd party inclusions [19:33:12] if those fonts are open enough, a bug can be opened to request them added to ULS [19:34:07] Nikerabbit, hoo, thx. i see on https://www.mediawiki.org/wiki/Extension:UniversalLanguageSelector that maybe i can add the font programmatically if it's already available. understand on the licensing of the particular font. we support both asf and ofl right? [19:34:15] ^(i'm guessing) [19:34:16] (03PS1) 10Demon: Only show prefershttps if IP can use HTTPS [core] - 10https://gerrit.wikimedia.org/r/80590 [19:34:52] dr0ptp4kt: most of the current fonts are either gpl or sil open font license [19:35:08] Nikerabbit, got it. hoo, thanks for making the update. [19:44:21] (03PS1) 10Brian Wolff: Add audio/wav to mime.types [core] - 10https://gerrit.wikimedia.org/r/80611 [19:59:02] andre__: you have a new comment awaiting moderation. :) [19:59:37] MatmaRex, if I just knew how to remove moderation. I've already tried several times all these confusing settings. But alright, will approve :) [20:00:05] (03PS4) 10Bsitu: Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 [20:01:47] (03CR) 10Parent5446: [C: 032] Only show prefershttps if IP can use HTTPS [core] - 10https://gerrit.wikimedia.org/r/80590 (owner: 10Demon) [20:02:06] (03CR) 10Bsitu: [C: 032] Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [20:03:35] (03Merged) 10jenkins-bot: Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [20:03:43] MatmaRex, that is pretty damn great. I might steal that ;) [20:04:04] (03PS1) 10Brian Wolff: Make RandomInCat work for cats starting with namespace [core] - 10https://gerrit.wikimedia.org/r/80658 [20:04:42] andre__: :D [20:09:32] (03PS3) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [20:13:16] Yippie, build fixed! [20:13:17] Project browsertests-en.wikipedia.org-linux-chrome build #269: FIXED in 3 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/269/ [20:15:29] (03PS4) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [20:21:32] (03PS5) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [20:26:50] (03CR) 10CSteipp: [C: 032] "I'm going to go ahead and merge this as is, because the functionality does what we want, and whitespace is easy to cleanup with a followup" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [20:27:21] (03CR) 10Umherirrender: "Looks like this helps also for other ForeignRepos like $wgInstantCommons, see bug 42857, where you cannot do purges based on imagelinks ta" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [20:27:53] (03PS6) 10Rahul21: Separated the module "ext.uploadWizard.page" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80570 [20:28:06] (03CR) 10QChris: "> Why can't I verify this?" [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 (owner: 10QChris) [20:29:39] (03Merged) 10jenkins-bot: Only show prefershttps if IP can use HTTPS [core] - 10https://gerrit.wikimedia.org/r/80590 (owner: 10Demon) [20:29:40] (03Merged) 10jenkins-bot: Core support for disabling HTTPS based on GeoIP [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [20:35:49] (03CR) 10Demon: "I figured Administrators should have review rights on refs/meta/*." [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 (owner: 10QChris) [20:37:42] (03CR) 10BryanDavis: [C: 032] "This looks good to me and bawolff promises that it won't break prod." [core] - 10https://gerrit.wikimedia.org/r/79809 (owner: 10Brian Wolff) [20:39:35] (03CR) 10BryanDavis: [C: 032] "LGTM." [core] - 10https://gerrit.wikimedia.org/r/80611 (owner: 10Brian Wolff) [20:39:57] (03PS1) 10Parent5446: Added more Message parameter functions [core] - 10https://gerrit.wikimedia.org/r/80663 [20:40:37] (03Merged) 10jenkins-bot: Add MP4 to mime.types [core] - 10https://gerrit.wikimedia.org/r/79809 (owner: 10Brian Wolff) [20:42:48] (03Merged) 10jenkins-bot: Add audio/wav to mime.types [core] - 10https://gerrit.wikimedia.org/r/80611 (owner: 10Brian Wolff) [20:45:04] (03CR) 10QChris: "> I figured Administrators should have review rights on refs/meta/*." [All-Projects] (refs/meta/dashboards/default) - 10https://gerrit.wikimedia.org/r/80571 (owner: 10QChris) [20:47:59] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [20:48:02] (03PS1) 10Rachel99: WIP VE numbering, bullets, indent, outdent scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80664 [20:49:00] (03CR) 10CSteipp: "I think that would be a good feature, but I'm entirely sure it's worth the complexity. Let me see how ugly it is to add that.." [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [20:50:19] (03PS7) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [20:50:45] (03CR) 10Demon: [C: 032] Use User Preference for logged-in HTTPS choice [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80331 (owner: 10CSteipp) [20:50:48] (03Merged) 10jenkins-bot: Use User Preference for logged-in HTTPS choice [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80331 (owner: 10CSteipp) [20:52:48] (03CR) 10DMaggot: "Fixed JS error and added comment about validation" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [20:58:08] (03CR) 10Parent5446: "Add it? Isn't that the current functionality?" [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [21:01:01] (03CR) 10Brian Wolff: "Our file mime detection thingy seems to be detecting as x-flac: https://commons.wikimedia.org/w/index.php?title=Special%3AMIMESearch&mime=" [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [21:03:37] (03PS2) 10Brian Wolff: Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 [21:04:02] (03CR) 10jenkins-bot: [V: 04-1] Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [21:06:07] (03PS3) 10Brian Wolff: Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 [21:07:03] (03CR) 10Brian Wolff: "PS2: add audio/x-flac" [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [21:07:16] (03PS2) 10MaxSem: Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 [21:10:25] (03CR) 10jenkins-bot: [V: 04-1] Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [21:11:05] (03CR) 10Brian Wolff: "Indeed, that's another major use case." [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [21:22:49] Ryan_Lane: hello [21:25:49] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [21:26:20] (03PS23) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [21:26:21] (03PS5) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [21:26:22] (03PS27) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [21:26:23] (03PS31) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [21:26:24] (03PS34) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [21:27:11] (03PS1) 10Demon: Core support for disabling HTTPS based on GeoIP [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80667 [21:27:12] (03PS1) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80668 [21:27:49] (03PS1) 10Demon: Core support for disabling HTTPS based on GeoIP [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80669 [21:27:50] (03PS1) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80670 [21:29:42] (03PS1) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80671 [21:30:14] (03PS1) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 [21:30:56] ^d: around? [21:31:03] <^d> Sup? [21:31:28] just saw the comment above: Only show prefershttps if IP can use HTTPS [21:31:33] it doesn't look like a good solution [21:32:00] <^d> Why is that? [21:32:27] there're always various technical ways to use https from IPs you blacklisted [21:32:42] and you shouldn't forbid their to choose to use https [21:32:45] *them [21:35:02] ^d: giving them a different default value looks better [21:35:57] <^d> Yeah, you've got a good point. Gonna think on it a bit more and amend. [21:37:55] ^d: how difficult / expensive is it to actually test https availability from client side? [21:37:58] (03CR) 10Kaldari: [C: 04-1] "Personal toolbar font size too small. Footer font size too small." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:38:42] liangent: hi. what's up? [21:39:59] Ryan_Lane: hmm are you still in charge of the https switch? [21:40:20] I'm leading the effort, yeah [21:40:45] do you have more details about the block in Iran ? [21:40:53] (03CR) 10Matmarex: "Is there no nicer way of doing this?" [core] - 10https://gerrit.wikimedia.org/r/80658 (owner: 10Brian Wolff) [21:41:09] is it also ip based? [21:42:02] (03Abandoned) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80668 (owner: 10Demon) [21:42:06] (03Abandoned) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80670 (owner: 10Demon) [21:42:29] (03PS2) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 [21:42:47] Ryan_Lane: ^ [21:42:55] (03PS2) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80671 [21:43:10] liangent: as far as I can tell it's a block on wikimedia-lb [21:43:17] and just wikimedia-lb [21:43:58] it must be IP based, since it's affecting https for only some services [21:44:03] (03PS1) 10Brian Wolff: For new gallery, make nolines mode have caption centered. [core] - 10https://gerrit.wikimedia.org/r/80676 [21:44:41] Ryan_Lane: it can be also domain based.. [21:45:01] we're not doing SNI [21:45:04] so it can't be [21:45:44] (03PS10) 10Jdlrobson: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 [21:45:46] though I guess they could be doing DNS blocking [21:46:01] Ryan_Lane: you mean dns poisoning or something? [21:46:05] yes [21:46:14] that would affect http too [21:46:18] not just https [21:46:28] I'm pretty sure wikimedia-lb is blocked for both http and https [21:46:40] iran has an issue with commons [21:46:46] oh [21:47:13] then our ongoing https change won't really help them [21:47:19] correct [21:48:12] anyway if we really want to resolve something for CN and IR with our technical work, can't we just change our IP? [21:48:27] for login? [21:48:32] that will probably help [21:48:35] for everything [21:48:38] nope [21:48:43] because they'll just block the new one [21:49:01] and if we play that game they'll just block all of our ranges [21:50:04] anyway to what degree do we want to do technical work for them? [21:58:08] Ryan_Lane: also is it a good idea to give users a warning saying you're sent to an insecure mode where your password can be sniffed by others for XXX reason instead of using http silently? [21:59:55] (03CR) 10Kaldari: "The html { font-size: 90%; } feels a bit hackish. Do we really want to do that rather than setting the individual styles appropriately?" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:00:04] (03PS3) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80671 [22:00:59] (03PS3) 10Demon: Updating CentralAuth to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80672 [22:01:22] (03Restored) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80670 (owner: 10Demon) [22:01:31] (03Restored) 10Demon: Only show prefershttps if IP can use HTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80668 (owner: 10Demon) [22:04:11] (03PS1) 10Mollywhite: Bug 53105: Make the extension function independently from the schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 [22:04:12] (03CR) 10jenkins-bot: [V: 04-1] Bug 53105: Make the extension function independently from the schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite) [22:06:43] (03CR) 10Yuvipanda: [C: 032] "What's the worst that could happen, right? :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [22:07:04] (03Merged) 10jenkins-bot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [22:08:39] YuviPanda: Wow, that's not worrying at all [22:08:47] marktraceur: hehe, ty :) [22:08:59] marktraceur: I did test it locally and the code went through a couple of rounds of review [22:09:04] Oh, good. [22:10:16] liangent: so [22:12:21] Ryan_Lane: so if one more country blocks wikipedia and we blacklist it again, it won't be silent from user side and let users still think they're secure [22:12:22] (03PS2) 10Mollywhite: Bug 53105: Make the extension function independently from the schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 [22:12:32] oh, whoops. sorry [22:12:33] so... [22:12:41] we're planning on putting login.wikimedia.org on its own ip [22:12:49] in the hopes that those countries won't block it [22:13:06] countries are blocking because of content, not because of the login itselt [22:13:08] *itself [22:13:27] then session cookies are still open to attack [22:13:44] yeah, but at least passwords will be protected [22:14:07] it's not an ideal solution [22:14:23] but it's a balance between access and security [22:14:29] (03PS1) 10Brian Wolff: Add url parameter to trigger autogenerated gallery type. [core] - 10https://gerrit.wikimedia.org/r/80678 [22:20:10] Ryan_Lane: btw will we be blamed next for being friendly to censors? [22:20:21] I'm sure we will [22:20:25] I'm fine with that [22:20:35] We already are. [22:20:41] already? [22:20:43] we have no political power against china or iran [22:20:44] Yep. [22:20:44] where [22:20:47] one sec [22:21:24] http://www.reddit.com/r/netsec/comments/1ks1e6/wikipedia_will_shortly_enable_https_for_all/cbs6xr4 [22:21:29] so it's a choice between giving people access to knowledge (which is our mission), or protecting people from their government at the cost of knowledge [22:24:03] Ryan_Lane: is logging in a part of "access to knowledge"? [22:24:39] liangent: logging in is part of sharing of knowledge [22:24:59] and I'm sure 1 billion people in china have unique knowledge to share [22:25:37] our data is republishable [22:25:42] and baidupedia appears to exist [22:26:15] so i wouldn't worry too much about the chinese being unable to access knowledge [22:26:17] baidupedia is heavily censored and biased [22:26:26] and it's not really completely editable [22:26:26] heavily censored and biased? no shit [22:26:29] (03CR) 10BryanDavis: [C: 032] Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [22:26:37] maybe that's because it's in a country with strict controls on what you can publish on the internet [22:26:43] yep [22:26:55] hmm, I wonder if there exists a baidu toollabs [22:26:56] probably no [22:26:57] t [22:27:01] :D [22:27:15] if only there were some kind of underground. like people who give knowledge to each other, and help each other get access to the uncensored network [22:27:18] oh wait they exist [22:27:21] let's let them do their jobs [22:27:38] <^d> We could just print out enwiki. [22:27:42] <^d> It only takes 6 printers. [22:27:45] brion: Ryan_Lane anyone talked about setting up an onion service? [22:27:56] we don't allow editing from tor [22:28:03] so, unless we change that, it's not an option [22:28:03] ^d: I bet keeping up all our infra is going to be easier than keeping 6 printers going [22:28:05] brion: they exist [22:28:09] we also don't allow editing from open proxies [22:28:18] YuviPanda: Tor exists, but we have a shitty treatment of it that prevents people from using them [22:28:26] most of the "solutions" the chinese use are blocked from editing, in fact [22:28:28] this is pretty fucking stupid from a mission perspective [22:28:46] but people are all 'ooh vandals!' 'ooh trolls!' [22:28:50] brion: we had a chat with the chinese editors at wikimania :) [22:28:51] and that outweighs everything else in practice [22:28:58] Ryan_Lane: and you're still alive?? [22:29:02] so my knowledge of these things is fresher than normal :D [22:29:03] (03Merged) 10jenkins-bot: Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 (owner: 10Brian Wolff) [22:29:30] brion: it's possible I've been replaced by a PLA member [22:29:36] ^d: put printers on balloons in the stratosphere [22:29:41] wait, that's not the right acronym [22:29:43] PLA? [22:29:46] PRC [22:29:50] people's liberation army? [22:29:52] i think that's right [22:30:04] brion: that's right :p [22:30:09] \o/ https://en.wikipedia.org/wiki/People%27s_Liberation_Army [22:30:16] <^d> Ryan_Lane's actually ex-KGB ;-) [22:30:17] ah. right. it is indeed. [22:30:48] I thought Ryan_Lane was ex-LizardPeople? [22:31:09] <^d> He's the only LizardPerson to ever serve in the KGB. [22:31:42] breaking the glass ceiling [22:31:43] hmm, so is he an ex-LizardPerson KGB or ex-KGB LizardPerson? [22:31:45] for lizard people [22:31:52] or the ex-KGB ex-LizardPerson? [22:32:02] the ceiling was transparent aluminum [22:32:04] and it hurt [22:32:45] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #163: FAILURE in 6 min 15 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/163/ [22:33:01] <^d> Ryan_Lane: That's what you get for trying to break through. You should accept your position in life :p [22:33:39] says ^d, sitting above, looking down [22:34:19] <^d> View's nice from up in my ivory tower ;-) [22:34:20] come back to the original topic: is anyone familiar with any organization providing anticensorship tools? [22:35:03] if so and if we can make an agreement with them (publicly or secretly) to ask them to provide true xff, maybe we can just trustedxff them [22:35:56] trustedxff? [22:36:23] (03CR) 10Matmarex: [C: 04-1] "We definitely don't, Monobook did something similar (body { font: x-small; }) and we are still having issues with things having weird font" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:36:25] liangent: I'm not aware of any specific organization doing this [22:36:56] parent5446: https://meta.wikimedia.org/wiki/XFF_project / https://www.mediawiki.org/wiki/Extension:TrustedXFF [22:37:04] parent5446, the extension that allows us to recognise some IP ranges as trusted to show the IP they're proxying for IIRC [22:37:20] Ryan_Lane: https://en.wikipedia.org/wiki/Freegate [22:37:30] Ah interesting. [22:38:07] indeed. didn't know of that one [22:38:48] liangent, did you read that netsec thread I linked? [22:39:18] Krenair: no. there were too many messages about this recently [22:40:32] Krenair: searching for netsec in my inbox gives nothing... [22:41:25] where [22:41:26] one sec [22:41:26] http://www.reddit.com/r/netsec/comments/1ks1e6/wikipedia_will_shortly_enable_https_for_all/cbs6xr4 [22:41:54] Krenair: oh that one [22:41:58] I read it [22:42:13] I didn't notice that netsec in url [22:42:23] I recognize it as "reddit thread" [22:42:41] Coincidentally, the top comment in that thread praises WMF for accomodating to those who can't use HTTPS. [22:47:40] (03CR) 10Mollywhite: [C: 04-2] "Oops, just remembered I need to fix one more thing." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80677 (owner: 10Mollywhite) [22:53:35] (03CR) 10Aaron Schulz: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/80421 (owner: 10Aaron Schulz) [23:00:08] (03PS1) 10Bsitu: wpUndidRevision should be passed along during 'preview' and 'diff' [core] - 10https://gerrit.wikimedia.org/r/80680 [23:07:12] (03CR) 10BryanDavis: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80421 (owner: 10Aaron Schulz) [23:09:48] (03Merged) 10jenkins-bot: Avoid profiler spam for numeric IN() clauses for each possible number of items [core] - 10https://gerrit.wikimedia.org/r/80421 (owner: 10Aaron Schulz) [23:11:44] Ryan_Lane: do you think we'll get http-blocked if we promote the use of freegate or something explicitly? [23:12:12] (03PS2) 10Parent5446: Cleaned up workflow for fetching nodes to use Status. [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62026 [23:12:19] (03PS2) 10Parent5446: Added If-Modified-Since support to Onionoo loading. [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/62027 [23:14:59] (03PS1) 10Matmarex: Do not show "Mark this page as patrolled" in print [core] - 10https://gerrit.wikimedia.org/r/80682 [23:15:26] ^ trivial [23:16:50] MatmaRex: happy to merge if you tested it :) [23:17:01] (03CR) 10Liangent: [C: 031] Do not show "Mark this page as patrolled" in print [core] - 10https://gerrit.wikimedia.org/r/80682 (owner: 10Matmarex) [23:17:09] +1 to give you more confidence :) [23:17:15] ;) [23:17:55] (03CR) 10Hoo man: [C: 032] Do not show "Mark this page as patrolled" in print [core] - 10https://gerrit.wikimedia.org/r/80682 (owner: 10Matmarex) [23:18:16] dammit, he got to it before i did :P [23:18:25] :D [23:18:42] YuviPanda: hoo: i have a few other trivial patches for you guys to merge :P [23:18:48] Mid-air collision detected! [23:19:01] MatmaRex: I'm actually supposed to be doing other stuff, I guess [23:19:04] :P [23:19:15] URI datatype Wikidata and stuff... [23:19:29] I'm supposed to be sleeping [23:19:30] i think [23:19:33] https://gerrit.wikimedia.org/r/#/c/74955/ in particular [23:19:39] YuviPanda: sleep is for the weak [23:19:47] MatmaRex: hey, it's 5aM! [23:20:07] nocturnal schedule is the best schedule [23:20:21] yeah, but I want to get a patch of mine done before I go to sleep :P [23:20:23] or https://gerrit.wikimedia.org/r/#/c/76506/ [23:20:29] our API module documentation does not exist [23:20:30] that sucks [23:20:38] (03Merged) 10jenkins-bot: Do not show "Mark this page as patrolled" in print [core] - 10https://gerrit.wikimedia.org/r/80682 (owner: 10Matmarex) [23:20:54] or https://gerrit.wikimedia.org/r/#/c/76457/ [23:21:11] i really haven't bitched about my patches not being merged enough recently and people got lazy. :D [23:23:41] MatmaRex: anytime I click a button, Firefox freezes for a while and tells me Gerrit is trying to kill it [23:24:22] (03PS1) 10Brian Wolff: [New gallery] ignore perrow option in this mode, as doesn't make sense. [core] - 10https://gerrit.wikimedia.org/r/80683 [23:24:23] YuviPanda: happens to me when i try to view a diff on something like User.php or EditPage.php [23:24:30] (except that my Opera suffers in silence) [23:24:35] <^d> GWT: "Wait, there's a browser other than Chrome?" [23:25:10] I think a lot of GerritHate is just GWT Hate [23:25:43] (03PS2) 10Bsitu: Improve footer separator [extensions/Echo] - 10https://gerrit.wikimedia.org/r/60186 (owner: 10Nischayn22) [23:26:01] the saddest part is that viewing diffs on large files used not to kill the browser [23:26:04] :( [23:26:56] <^d> They haven't done that for me in...a long time. [23:26:58] <^d> They used to. [23:27:45] well, you're probably not on Opera :P [23:29:26] (03CR) 10Yuvipanda: [C: 032] Expand the info in 'resettokens-watchlist-token' [core] - 10https://gerrit.wikimedia.org/r/76506 (owner: 10Matmarex) [23:29:45] liangent: not sure. it wouldn't help them to block us for that [23:36:12] <^d> MatmaRex: Well, I like using a real browser. [23:38:02] opera is realer. it has history, man. [23:38:10] no future, though :P [23:38:20] IT HAS A FUTURE IN OUR HEARTS. [23:38:39] [23:38:47] <^d> Have they switched to Webkit yet? [23:38:59] ^d: they're switching to blink [23:39:02] not webkit [23:39:03] (but on a more serious note, the few people i know were using opera as still using the 12 version) [23:39:09] are still* [23:39:33] they're pretty much a chromium skin now [23:39:33] <^d> YuviPanda: For the record, "blink" is way harder to google than "webkit." [23:39:35] 15 has more blin[kg] and approximately 0 of 12's features [23:39:48] ^d: easier than 'go' [23:39:57] ^d: but hey, we got away with 'C' [23:47:30] ^d: whatever you do, don't blink. [23:47:40] * ^d blinks [23:49:06] * p858snake|l watches ^d get sucked into the past [23:49:07] * YuviPanda hits ^d with a webkit [23:49:21] * YuviPanda sticks p858snake|l in a marquee