[00:02:49] (03CR) 10Brian Wolff: "How should I resolve this? I prefer this solution, but we could also do what Raymond suggests. Basically a decision needs to be made on wh" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [00:10:16] * legoktm re-pokes werdna  [00:10:22] hmm? [00:10:46] https://gerrit.wikimedia.org/r/#/c/79181/ :P [00:16:26] (03CR) 10Werdna: [C: 032 V: 032] "We can leave it at that for now, then." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/79181 (owner: 10Legoktm) [00:16:43] thanks :) [00:19:12] legoktm: http://www.meetup.com/wikimedia-tech/ [00:19:34] i'll check it out [00:19:47] cool [00:19:50] I think I have a meetup account somewhere... [00:25:53] > Thanks for joining the Wikipedia Engineering Meetup! We plan to have our first one in August 2012 so stay tuned! [00:26:00] sumanah: might want to update that ^ :P [00:27:33] :) [00:27:36] We have actually been having them [00:27:54] (03CR) 10Mollywhite: "The JSON editor is disabled by default for now. Add" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [00:28:31] legoktm: I'll ask the owner to do that, yeah. That is Quim [00:29:40] cool. i'll try and show up for the next one :) [00:34:03] greg-g: is it cool if I push a security patch for centralnotice nowish? [00:34:23] (03PS1) 10Bsitu: Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 [00:34:31] coolish [00:35:47] mwalker: should be fine [00:39:24] (03CR) 10Matmarex: [C: 04-1] "This breaks the display slightly… the line at the middle doesn't extend to the bottom, and the links look terribly off-center: http://i.im" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [01:05:26] greg-g: I just pushed the change -- I'm monitoring ganglia to make sure that when the standard 15 minute CN cache window expires the application servers dont explode [01:42:24] (03PS1) 10Tim Starling: Core support for disabling HTTPS based on GeoIP [core] - 10https://gerrit.wikimedia.org/r/80166 [01:52:05] (03CR) 10Demon: [C: 031] Core support for disabling HTTPS based on GeoIP [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [01:52:34] (03CR) 10Tim Starling: [C: 04-1] "Untested -- will test soon." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [02:32:43] mwalker|away: assuming no exploding :) [03:04:31] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [03:22:15] (03CR) 10CSteipp: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [03:33:42] (03CR) 10CSteipp: "Unfortunately, this doesn't seem to work. If a user unchecks the preference, they are still redirected to an https url after login, their " [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [03:39:38] (03CR) 10Parent5446: "(1 comment)" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [03:58:06] greg-g: correct! no splosions detected [03:58:16] mwalker: weee [03:58:33] it just remains to be seen if the underlying issue itself has gone away [04:04:24] [04:12:33] (03CR) 10Eloquence: "I'd appreciate a brief explanation of the point of this preference. If a user can't use HTTPS, after the switch, they won't be login in th" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [04:20:42] (03CR) 10CSteipp: "This solves the issue for users who want to continue using http after logging in, typically for performance (older browsers did't cache re" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [04:49:03] (03CR) 10Tim Starling: "> Unfortunately, this doesn't seem to work. If a user unchecks the preference, they are still redirected to an https url after login, thei" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [04:52:28] (03PS5) 10PleaseStand: Hide server IP addresses from DB error pages [core] - 10https://gerrit.wikimedia.org/r/52029 [04:55:49] (03CR) 10Mattflaschen: "(1 comment)" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [04:59:04] (03CR) 10Nemo bis: "Brian, I think that the best solution is the one which gets approved and deployed for the next wmf branch at the latest. Choose whichever " [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [05:00:23] (03CR) 10Tim Starling: "I'm working on a commit which will replace wpStickHTTPS with returntoprotocol, a parameter which will be handled like the other two return" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [05:24:26] (03CR) 10Tim Starling: "> I'm working on a commit which will replace wpStickHTTPS with returntoprotocol, a parameter which will be handled like the other two retu" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [05:31:02] * TimStarling shoots everyone who called WebRequest::detectProtocol() except himself [05:31:06] you are all wrong [05:42:34] (03CR) 10Tim Starling: "Removing -1 since the bugs I've found mostly seem to predate this change. In particular, the prefershttps preference seems to be broken." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [06:02:58] TimStarling: there was an open bug about the secure login being broken in 1.21 eg for osm wiki (everyone staying on https), do you know if that was fixed? could not get it clarified [06:04:12] hmm that may be the very bug you are talking about [07:45:39] (03PS1) 10Nikerabbit: ULS to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80180 [07:49:41] (03CR) 10Amire80: [C: 031] ULS to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80180 (owner: 10Nikerabbit) [07:52:14] (03CR) 10Nikerabbit: [C: 032] ULS to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80180 (owner: 10Nikerabbit) [07:54:50] (03Merged) 10jenkins-bot: ULS to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80180 (owner: 10Nikerabbit) [07:56:31] (03CR) 10Matmarex: "Does this make the "UserRequiresHTTPS" hook unnecessary? (It was added just yesterday.)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [08:08:40] (03CR) 10Nemo bis: "that looks like https://bugzilla.wikimedia.org/show_bug.cgi?id=40541#c12" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [08:22:28] (03CR) 10Mattflaschen: [C: 04-1] "(35 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [08:26:42] superm401: that's a *lot* of comments [08:27:18] Yep, it's a decent-size patch, and it's the first time I looked at it. [08:27:38] But some of them are more design discussions (facilitated by code) then low-level code review. [08:28:48] ah ok [08:43:48] (03CR) 10Matthias Mullie: [C: 032] Add gender support to two i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80162 (owner: 10Bsitu) [08:43:51] (03Merged) 10jenkins-bot: Add gender support to two i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80162 (owner: 10Bsitu) [08:48:50] (03CR) 10Matmarex: "Thanks!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80162 (owner: 10Bsitu) [08:50:21] (03CR) 10Yuvipanda: "Hello! Looks good to me, and am happy to merge after testing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [09:10:55] (03PS7) 10Nikerabbit: Try to improve the wording of gender option [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [09:12:17] (03CR) 10Nikerabbit: [C: 032] Try to improve the wording of gender option [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [09:15:23] (03Merged) 10jenkins-bot: Try to improve the wording of gender option [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [09:15:36] ragazzimai: I always want to ask, what is that you're telling folks not to do? :) [09:20:41] (03CR) 10Matmarex: "Actually…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [09:29:20] (03PS2) 10Matmarex: Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [09:29:32] (03CR) 10Matmarex: [C: 04-1] Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [09:31:23] https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page seems broken [09:32:30] Nikerabbit: define 'broken'? [09:32:41] (apart from the https security warnings) [09:32:51] it looks okay at a glance [09:33:23] MatmaRex: Nikerabbit uses chrome [09:33:44] so warnings for him are missing things for him? [09:34:01] * your warnings [09:34:02] heh, seriously? stupid chrome. [09:34:17] i think that's known anyway [09:34:32] is en.wiki seriously not using protocol-relative or what [09:34:35] what where when? [09:35:16] ican'tfind it, actually [09:35:23] but i heard something aboutbits and beta and https [09:35:26] well, it started to be broken for me since it is forcefully redirecting to https [09:35:40] Nemo_bis: that's not en.wp's stuff, that's bits [09:35:48] (that's where the warnings were from for me) [09:36:58] Nikerabbit: https://bugzilla.wikimedia.org/show_bug.cgi?id=48501 [09:37:07] i think that's the relevant bug. [09:37:31] oh, and i found a dup, https://bugzilla.wikimedia.org/show_bug.cgi?id=49533 [09:38:01] (03CR) 10Jeroen De Dauw: [C: 032] Fix course page history SQL error [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 (owner: 10Ragesoss) [09:38:03] and https://bugzilla.wikimedia.org/show_bug.cgi?id=46621 ? [09:38:09] (03Merged) 10jenkins-bot: Fix course page history SQL error [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 (owner: 10Ragesoss) [09:42:26] (03PS1) 10Jeroen De Dauw: Remove verbose GPL headers [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80185 [09:42:34] (03CR) 10jenkins-bot: [V: 04-1] Remove verbose GPL headers [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80185 (owner: 10Jeroen De Dauw) [09:44:18] MatmaRex: I added a comment [09:44:41] it's unfortunate that we have these good test systems but then we have stupid bugs which prevents me from actually running any tests [09:45:25] (03PS1) 10Jeroen De Dauw: Match test namespace rename in DataValues [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80186 [09:45:38] (03CR) 10Jeroen De Dauw: [C: 032] Match test namespace rename in DataValues [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80186 (owner: 10Jeroen De Dauw) [09:45:45] Nikerabbit: use a real browser ;) [09:45:54] (03PS2) 10Jeroen De Dauw: Remove verbose GPL headers [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80185 [09:46:08] Nikerabbit: my opera 12 just showed some large warnings once and now renders the page [09:46:30] (03CR) 10Jeroen De Dauw: [C: 032] Remove verbose GPL headers. [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80185 (owner: 10Jeroen De Dauw) [09:47:01] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [10:04:39] (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [10:17:03] (03PS1) 10Jeroen De Dauw: Update coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80187 [10:27:26] (03CR) 10Nikerabbit: [C: 04-1] "Can we at least add a deprecation note to the messages. Otherwise they will stay there forever wasting translator time." [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [10:31:10] (03CR) 10Matmarex: "Actually, do these messages grep at all? If not, then I'd kill 'em, we can always restore them if they turn out to be needed." [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [10:50:48] MatmaRex: browser doesn't affect unit tests, which have also been broken for years [10:52:39] (03PS2) 10Jeroen De Dauw: Update coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80187 [10:52:43] (03CR) 10Jeroen De Dauw: [C: 032] Update coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80187 (owner: 10Jeroen De Dauw) [10:52:53] (03Merged) 10jenkins-bot: Update coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80187 (owner: 10Jeroen De Dauw) [11:35:28] http://iteration99.com/2013/php-json-removed-from-php-5-5/ [11:35:29] :/ [11:43:28] (03PS2) 10TTO: Remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80018 (owner: 10Manybubbles) [11:45:24] Reedy, those morons coudn't find another JSON package? [11:55:38] (03PS1) 10Jeroen De Dauw: Match changes in DataValues [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80198 [11:56:25] (03CR) 10Jeroen De Dauw: [C: 032] Match changes in DataValues [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80198 (owner: 10Jeroen De Dauw) [12:30:06] (03PS1) 10Platonides: Force a space between password label and reset link. [core] - 10https://gerrit.wikimedia.org/r/80205 [12:41:10] (03CR) 10Mglaser: [C: 031] * Add --smw option for packaging Semantic Bundle [tools/release] - 10https://gerrit.wikimedia.org/r/28958 (owner: 10MarkAHershberger) [12:42:16] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80207 [12:42:49] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80208 [12:44:07] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80208 (owner: 10Jeroen De Dauw) [12:44:11] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80207 (owner: 10Jeroen De Dauw) [12:48:32] (03PS2) 10Shirayuki: Add/remove full-stops [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78918 [12:49:17] (03PS1) 10Nikerabbit: Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 [12:50:37] (03PS2) 10Shirayuki: Simplify right-* messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/78921 [12:53:48] (03CR) 10Mglaser: [C: 04-1] "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/59158 (owner: 10MarkAHershberger) [13:07:05] (03CR) 10Mglaser: [C: 04-1] "See comment of Umherirrender" [core] - 10https://gerrit.wikimedia.org/r/59369 (owner: 10MarkAHershberger) [13:26:39] (03CR) 10Matmarex: [C: 032] Force a space between password label and reset link. [core] - 10https://gerrit.wikimedia.org/r/80205 (owner: 10Platonides) [13:29:42] (03Merged) 10jenkins-bot: Force a space between password label and reset link. [core] - 10https://gerrit.wikimedia.org/r/80205 (owner: 10Platonides) [13:39:36] (03CR) 10Nikerabbit: "Wouldn't it be better to add data-sort-value?" [core] - 10https://gerrit.wikimedia.org/r/80079 (owner: 10Umherirrender) [13:55:13] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80205 (owner: 10Platonides) [14:42:24] (03PS1) 10Jeroen De Dauw: Add link to README [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80216 [14:43:13] (03PS2) 10Jeroen De Dauw: Add link to README [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80216 [14:43:19] (03CR) 10Jeroen De Dauw: [C: 032] Add link to README [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80216 (owner: 10Jeroen De Dauw) [14:43:34] (03Merged) 10jenkins-bot: Add link to README [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80216 (owner: 10Jeroen De Dauw) [14:44:09] (03PS1) 10Aude: update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/80217 [14:46:53] (03CR) 10Anomie: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [14:47:00] (03CR) 10Anomie: [C: 04-1] Core support for disabling HTTPS based on GeoIP [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [15:00:52] StevenW / sumanah / anybody else - Do you happen to remember where is the discussion about potential watchlist improvements? [15:01:05] hi aharoni [15:01:09] aharoni: there are a few [15:01:16] aharoni: I think there is an RfC on mediawiki.org ? [15:01:50] There's a bug by Sue. :-) [15:02:21] But probably also an RFC. [15:02:40] aharoni: I will now spit out into the channel some relevant URIs: [15:02:41] http://mw-watchlist.tumblr.com/ [15:02:48] https://en.wikipedia.org/wiki/Wikipedia:Cross-wiki_watchlist [15:03:45] https://www.mediawiki.org/wiki/Summer_of_Code_Past_Projects#Watchlist_grouping_and_workflow_improvements https://www.mediawiki.org/wiki/Talk:Watchlist_wishlist#Watchlists_27117 https://www.mediawiki.org/wiki/Requests_for_comment/Support_for_user-specific_page_lists_in_core [15:03:55] aha. aharoni I think https://www.mediawiki.org/wiki/Requests_for_comment/Support_for_user-specific_page_lists_in_core is what you might be looking for [15:04:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=33888 [15:04:22] The other bug links can be found on that bug. [15:04:49] There are probably other pages on Meta-Wiki as well. [15:04:54] From years ago. [15:13:25] (03CR) 10JGonera: "Why do we need both JS and PHP implementation of LESS?" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [15:26:31] (03PS2) 10Umherirrender: Add data-sort-type=number to column on Special:Tags [core] - 10https://gerrit.wikimedia.org/r/80079 [15:41:09] (03PS3) 10Umherirrender: Add data-sort-value for better sorting on Special:Tags [core] - 10https://gerrit.wikimedia.org/r/80079 [15:43:31] (03CR) 10Umherirrender: "Patch Set 3: Use data-sort-value" [core] - 10https://gerrit.wikimedia.org/r/80079 (owner: 10Umherirrender) [15:53:22] (03PS5) 10Cmcmahon: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 (owner: 10Rachel99) [15:55:17] we talked about picking up the user-specific page lists thing again in E3 [15:55:47] I think we'll do it soon, though I expect it will take some gerrit time to get it right [15:56:08] (yes, would be nice!) [15:56:32] Jon was talking about how he'd use that for features like having a list of articles to sync for offline reading [15:56:42] and to have a travelog / trip list for wikivoyage [16:11:02] hah wow. how could they be so wrong. http://www.rightscale.com/blog/cloud-cost-analysis/cloud-cost-analysis-how-much-could-wikipedia-save-cloud [16:11:08] this is all based on the wikimedia labs information. [16:11:17] nothing to do with production [16:12:03] On Azure? lols [16:12:14] says the windows user :P [16:12:28] "The Wikimedia production site encompasses 170 projects, including Wikipedia, that run on up to 385 instances" and "The instances are split among five instance types, ranging from extra small to extra large" give it away, along with the link to wikitech [16:12:37] "As of July 2013 Wikimedia used 121GB of database storage, " [16:12:57] lol. [16:12:57] hey, with that much cloud power behind us, maybe we can finally use Semantic MW in prod! [16:13:07] !hss [16:13:07] ZOMG!! http://bit.ly/2sYkfl [16:13:31] enwiki is 725GB alone [16:14:17] I sent a small comment about how wrong this is [16:14:35] Reedy: well, not if you use super awesome sql server enterprise compression edition compression :) [16:14:51] it has to be approved before it appears so hopefully they'll see my comment and take it down [16:16:16] (03PS2) 10Matthias Mullie: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 [16:16:30] Krenair: well, https://twitter.com/hassankhosseini/status/370090365354655744 [16:16:36] * Reedy leaves a comment [16:17:13] if they *actually* do an analysis, I bet it'll point to it being much more expensive on Azure [16:17:25] should be an interesting 'correction', if they do one at all [16:17:28] :) [16:21:46] YuviPanda: We should supply them some diffs when they update it [16:22:10] * YuviPanda saves current article to hard disk [16:22:24] done! [16:22:28] MatmaRex: Yo. [16:22:33] * Reedy saves to PDF [16:22:42] MatmaRex: So when we remove user preferences, we don't clean up the DB, do we? [16:22:53] I'm thinking about the user prefs that have been removed or will be. [16:23:00] jump to/cols/etc. [16:23:34] don't think so, Elsie. I remember someone trying to do analysis on the useroptions stuff and running into a lot of junk [16:23:41] Hrm. [16:23:58] Reedy: JDFI? [16:24:09] Just doing, fuck it. [16:24:30] * Elsie pets Reedy. [16:26:38] hi Elsie [16:26:52] no, we don't. tim wants to remove some, though [16:27:00] there's a bug about this somewhere [16:27:04] you're probably cc'd on it, actually [16:27:53] Hmmmm. [16:28:18] The script is userOptions.php, but it touches user_properties? [16:28:46] https://twitter.com/hassankhosseini/status/370220789842194432 [16:28:47] What? [16:29:12] Chapters are the best idea ever :P [16:30:09] Elsie: yes [16:30:21] THAT'S SUPER-CONFUSING. [16:30:23] it sucks for other reasons too [16:30:37] Chapters? yeah [16:31:16] Setting up chapters distracts the political people. It's a feature, not a bug. [16:32:34] What happened to wm-bot? [16:36:00] * andre__ gets some popcorn and watches the Twitter discussion [16:42:51] is there a Python official API module for Mediawiki ? [16:43:13] Official how so? [16:44:08] pywikipedia is the most used one, but it's not "official" [16:44:09] !pywikipedia [16:44:09] pywikipediabot is a bot framework written in Python that allows for easier automated actions on a wiki. For more information, see . For alternatives, see . [16:44:33] average: ^ [16:59:48] average: https://en.wikipedia.org/wiki/Wikipedia:Creating_a_bot#Python [17:00:07] (03CR) 10Yuvipanda: [C: 04-1] "Works as advertised, but needs a few minor tweaks. Since this introduces 2 new properties in the JSON schema, we'll need to:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [17:03:46] http://www.reddit.com/r/netsec/comments/1ks1e6/wikipedia_will_shortly_enable_https_for_all/cbs6x9w [17:03:47] huh [17:04:07] someone thinks wikipedia is tracking what pages people view and telling the NSA [17:05:26] sshhh, don't tell them about eventlogging! [17:07:23] http://www.reddit.com/r/netsec/comments/1ks1e6/wikipedia_will_shortly_enable_https_for_all/cbs4rw7 [17:07:41] People already commenting on our compliance with the Chinese government. :P [17:09:30] Speaking of which, has that deployment been officially delayed, or is it still on schedule for today? [17:10:18] robla is making that call, I believe. [17:10:22] i ain't heard anything yet [17:10:31] Tim's mailing list post suggested it would be delayed. [17:11:03] Hmm, where is robla... [17:11:14] I'll be off the phone in 15 minutes [17:11:33] :) I figured he'd be busy doing something important. [17:13:17] (03PS3) 10Werdna: Topic folding. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79354 [17:13:33] Ryan_Lane, are we using Server Name Indication? [17:14:10] parent5446: https://bugzilla.wikimedia.org/show_bug.cgi?id=40541 was reopened. [17:14:47] Yeah, I saw. I must have fixed secure login three times already. [17:14:50] :/ [17:15:25] While it's broken, I don't imagine we'll be enabling it anywhere. ;-) [17:15:30] <^d> This would be so much easier if we didn't support anything but https :) [17:15:36] Well it's not broken per se. There's a configuration workaround. [17:15:48] It's because $wgSecureLoginDefaultHTTPS basically forces HTTPS. [17:15:53] ^d: It'd also be a lot easier if we just gathered everyone in the same place and stopped using the Internet. [17:15:57] (It used to be the default value for the checkbox.) [17:16:02] <^d> Elsie: I know, right? [17:17:04] Heh, the VE newsletter just triggered https://en.wikipedia.org/wiki/Special:AbuseFilter/577 [17:17:15] As will each post made by the bot, presumably. [17:17:22] This'll be fun. [17:18:11] Can someone add article_namespace != 3 or equivalent? [17:20:35] Krenair: nope. that's planned, though, so that we can use smaller certificates for clients that support SNI [17:20:50] Would that involve sending the hostname in the clear? [17:22:43] Krenair: yes [17:23:09] Is that already done when the DNS lookup is made? [17:23:20] yes [17:23:40] meh, ok [17:23:42] dnssec fixes that, but we can't support dnssec and geodns [17:23:59] talk to paravoid about dnssec [17:24:03] Ok... Why can't we support that? [17:24:08] and/or bblack [17:24:11] ok [17:24:35] I remember somebody from ops saying it makes DNS less reliable in Asia. [17:24:53] well, rather than trying to remember, you could ask ;) [17:25:02] parent5446: also, since you're here... [17:25:08] Lol good point [17:25:16] what's the deal with forking OATHAuth and using an incompatible license? [17:25:49] O.O I used an incompatible license? [17:26:23] Wait, they're both GPL [17:26:24] ... [17:27:43] (03CR) 10Anomie: [C: 032] Add tests for API action=edit§ion=new [core] - 10https://gerrit.wikimedia.org/r/79309 (owner: 10Legoktm) [17:27:56] :) [17:28:17] parent5446: you're is GPL 3 [17:28:19] mine is GPL 2 [17:28:30] I can't take any of your changes but you can take all of mine [17:28:33] hence, incompatible [17:28:42] and why didn't you just send in patches? [17:28:45] Oooh. Hmm. Goddammit. [17:28:51] I have a good feeling yours is insecure, btw [17:29:01] since you're missing some of the changes I pushed in recently [17:29:13] why don't we merge them? [17:29:16] Well I basically rewrote the entire thing. [17:29:29] If you want I can figure out how to merge mine into yours. [17:29:41] I'm fine with renaming mine to two factor auth [17:29:43] And I'll pretend my code wasn't GPLv3 licensed. [17:29:46] ;) [17:29:55] well, as long as you didn't take any changes, it should be fine [17:30:11] thedj: Around? [17:30:13] (03CR) 10EBernhardson (WMF): "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:30:17] we can rename yours to something else and rename mine to two factor auth [17:30:19] Could just relicense your changes under GPLv2 couldn't you? [17:30:25] Krenair: yep [17:30:32] (03Merged) 10jenkins-bot: Add tests for API action=edit§ion=new [core] - 10https://gerrit.wikimedia.org/r/79309 (owner: 10Legoktm) [17:30:43] OK, so we'll rename mine to something temporary? [17:30:48] parent5446: rewriting from scratch is almost always a bad idea :) [17:30:58] hoo: yes [17:31:01] Well I mainly rewrote the UI parts. [17:31:02] :) [17:31:12] the UI parts? what changed there? [17:31:14] It still uses the HOTP library. [17:31:18] thedj[work]: Do you also have JAWS running? [17:31:30] I added links in preferences and such [17:31:34] some of that needed work, though [17:31:36] I changed it so that it's a single page and it uses FormSpecialPage. [17:31:36] hoo: i can open it. [17:32:11] parent5446: does it still have links in Special:Preferences? [17:32:15] Ok, from time to time it tells me to "use spacebar" for role=button links, but spacebar doesn't work on them [17:32:21] it'll just scroll the page [17:32:29] Yes [17:32:32] * Ryan_Lane nods [17:32:40] cool. push in changes to OATHAuth [17:32:45] and I'll look at getting them renamed [17:32:51] hi parent5446, Elsie: planning to delay [17:32:53] OATHAuth is too close to oauth [17:33:01] hoo: which browser ? [17:33:03] Ryan_Lane: OK, I'll work on that. May take a few days. [17:33:04] it confuses people [17:33:08] parent5446: no rush [17:33:11] thedj[work]: Firefox [17:33:12] Lol I thought the same thing. [17:33:14] I just wanted to get that worked out [17:33:21] robla: Gotcha, thanks for the update. [17:33:33] since we have two extensions that do the same thing and aren't getting help from each other [17:34:03] I forget why I forked it instead of patching it. I'm sure I had some legitimate reason at the time. [17:34:09] heh [17:34:11] (03PS2) 10Brian Wolff: Be stricter for file types where we don't know canonical extension [core] - 10https://gerrit.wikimedia.org/r/79954 [17:34:29] you should always at least talk to the upstream before forking :) [17:34:39] hoo: particular patch that you want me to test ? [17:34:39] I was naive back then. [17:34:45] heh. no worries [17:34:53] (Not that I'm that much better now.) [17:34:55] ;) [17:35:26] thedj[work]: I think I saw it with the WikiEditor change especially [17:35:59] (03CR) 10Anomie: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [17:36:09] https://gerrit.wikimedia.org/r/79639 [17:37:39] (03PS13) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [17:38:31] (03PS1) 10Jeroen De Dauw: Do not use MW test runner in Travis build as it messes up coverage reporting [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80230 [17:38:41] (03CR) 10Jeroen De Dauw: [C: 032] Do not use MW test runner in Travis build as it messes up coverage reporting [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80230 (owner: 10Jeroen De Dauw) [17:38:50] (03Merged) 10jenkins-bot: Do not use MW test runner in Travis build as it messes up coverage reporting [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80230 (owner: 10Jeroen De Dauw) [17:43:05] hmm, so what was at http://www.rightscale.com/blog/cloud-cost-analysis/cloud-cost-analysis-how-much-could-wikipedia-save-cloud-update before it got cut down? [17:43:47] hoo: ok, in IE, it doesn't say that, and hitting space while on a wikieditor button actually does trigger the action. [17:44:19] MaxSem: An analysis about how much money we'd save if we moved labs to windows cloud, and if our entire server budget was devoted just to labs. [17:44:42] what were the numbers? [17:44:55] * bawolff doesn't know [17:45:15] MaxSem: I still have the old one open :P [17:46:07] http://www.rightscale.com/blog/sites/default/files/wikimedia3.png [17:47:53] hoo: same for FF for me. I can just hit space, and it triggers the action. It starts reading from start of region though after that... [17:48:07] possibly due to the ? [17:48:29] mh, for some reason only enter works for me [17:48:47] ah, the reading of 'start of region' is with the section collapsing. [17:48:47] 14G, really? we've got a bunch of servers with 96G RAM put to good use [17:48:49] for links in general only enter works on my system [17:49:19] MaxSem: :D Yes, that's why I wrote that reply on wikitech-l... wasn't hard to find the obvious mistake [17:49:24] would be fun to see how Lucene or MySQL works on their tiny instances [17:49:50] (03PS4) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [17:49:55] hoo: well that's not how it is supposed to be. be it keyboard navigation or the screenreader [17:49:55] (03PS1) 10Brian Wolff: [wip] Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 [17:49:56] (03CR) 10Bsitu: [C: 04-1] "It looks better! The icon is vertically aligned to the center while the text is vertically aligned to the top. When the left cell has lo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 (owner: 10Bsitu) [17:50:11] (03CR) 10jenkins-bot: [V: 04-1] Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [17:50:13] at least for click actions on input elements that is. [17:51:42] oh nice: "namespace navigation region" [17:52:11] ok, 1pm PDT on August 28th is the new date for the HTTPS rollout [17:52:14] so that works in FF+JAWS14 and IE+JAWS14 [17:52:51] sumanah: then we should take that Central notice down asap. [17:52:55] mh, I guess I'm going to reset my JAWS settings [17:53:13] I can take the CN down if needed [17:53:15] hoo: might also have something to do with windows or regional settings of windows of course. [17:53:32] i use windows 7 here. [17:53:38] you're right thedj[work] [17:53:40] German version of Windows 7 [17:54:01] hoo: thedj[work]: well, wait, the Central Notice does not currently have a date on it [17:54:08] i have a US version (i presume, downloaded from modern.ie [17:54:23] hoo: thedj[work] - I think we actually perhaps want to keep it up [17:54:30] it points to https://meta.wikimedia.org/wiki/HTTPS which now has the right date [17:54:31] https://meta.wikimedia.org/wiki/HTTPS#August_28.2C_2013_-_Secure_log-in.2C_with_secure_browsing_and_editing_for_logged_in_users [17:54:40] sumanah: I'm ok with that [17:54:57] (03PS5) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [17:54:59] thedj[work]: But even here on my en-us Linux space doesn't trigger links [17:55:03] is there an Irish localization of windows? [17:55:04] (03CR) 10jenkins-bot: [V: 04-1] Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [17:55:17] sumanah: well then I think someone should start writing a proper one, instead of the emergency style generic maintenance one. [17:55:26] thedj[work]: I think you are right [17:55:37] and this time I still think so, 10 seconds later :-) [17:55:57] :D [17:59:10] thedj[work]: Do you think I should/ have to add an onkeypress handler for space? Real buttons are triggered by space, but not our links [17:59:52] (03CR) 10Parent5446: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [18:01:09] any element that by nature has tabindex=0, should support both space, enter and click as the same action. [18:02:09] hoo: but, i do know that we have a crazy amount of handlers lately, so perhaps something is capturing your keypress before it arrives. [18:02:33] with event.preventDefault... might be possible [18:02:49] i work with an almost plain setup, but if you have a lot of stuff from WMF installed, it might be buggy somewhere. [18:02:55] or gadgets etc... [18:03:18] mh, I can use any links with space, neither here or on the Windows system [18:03:36] * can't [18:04:07] perhaps your keyboard driver is being too smart ? [18:04:26] there can be all kinds of crazy reasons for this kind of stuff of course. [18:05:14] thedj[work]: With JAWS running it seems to work on my Windows 7 system [18:05:23] after exiting JAWS it no longer does... [18:05:27] i need to print some navigation cheatsheets of all these screenreaders btw. I keep forgetting the keys that I need to use. [18:05:49] Yes, please share it [18:06:19] hoo: ah. indeed killing JAWS seems to be the trick... [18:06:27] now my spacebar doesn't work either. [18:07:44] hoo: cu later. I want to get home :D [18:07:55] Oh, do that ;) [18:14:57] (03CR) 10Aaron Schulz: [C: 032] Be stricter for file types where we don't know canonical extension [core] - 10https://gerrit.wikimedia.org/r/79954 (owner: 10Brian Wolff) [18:17:47] (03Merged) 10jenkins-bot: Be stricter for file types where we don't know canonical extension [core] - 10https://gerrit.wikimedia.org/r/79954 (owner: 10Brian Wolff) [18:18:51] (03PS1) 10Jeroen De Dauw: Update code coverage config for travis [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80235 [18:21:05] (03CR) 10Demon: [C: 032] The "masterPos" field in refreshLinks can be false so check for that [core] - 10https://gerrit.wikimedia.org/r/80064 (owner: 10Aaron Schulz) [18:21:08] Silly jQuery question: If I want to namespace off all the jQuery functions that my extension provides, can I put them under $.fn.myExtensionName? I've done that, but when they're called, the 'this' variable holds $('my-selector').myExtensionName, not $('my-selector') [18:21:14] * werdna prods RoanKattouw [18:21:16] (03CR) 10Jeroen De Dauw: [C: 032] Update code coverage config for travis [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80235 (owner: 10Jeroen De Dauw) [18:22:27] slash TrevorP|Away [18:22:38] I guess VE team is visually editing :) [18:23:03] <^d> They only respond to visual communications ;-) [18:23:15] <^d> This text thing is too /antiquated/ [18:23:21] werdna: hmm, why would you do that? [18:23:36] namespacing is always a good practice [18:23:45] if thefunctions are intended to act on jquery object, they should go in $.fn directly [18:23:55] just like every jquery plugin ever does it [18:24:12] and if they're not, make a window.myextension object and stick them there? [18:24:17] I'd really prefer to namespace them [18:24:21] (03Merged) 10jenkins-bot: The "masterPos" field in refreshLinks can be false so check for that [core] - 10https://gerrit.wikimedia.org/r/80064 (owner: 10Aaron Schulz) [18:24:23] or,i dunno, mw.myextension [18:24:27] with something other than $.fn.flow_X [18:24:33] they are intended to act on jQuery objects [18:25:18] if you namepsace them like this, then this won't be "correct", as you noticed [18:25:33] how would you like to call them? [18:25:49] $('stuff').flow.fun() can't be made to work [18:25:50] well, I don't especially care [18:25:57] that's what I had before [18:26:00] $('stuff').flow().fun() possibly could, but this wouldbekinda weird [18:26:16] surely there's some way to namespace other than .flow().fun() [18:26:27] mw.flow.fun( $('stuff') ) would be my personal favorite [18:26:44] * RoanKattouw is prodded by werdna and reads backscroll [18:27:06] If you face this problem you might already be doing something wrong with your JS-design [18:27:10] MatmaRex: that's what I had before, but I didn't like it. [18:27:17] hoo: well, I'm rearchitecting my JS design :) [18:27:53] (03PS1) 10Mollywhite: Bug 53164: Add variable to enable/disable navigtion bars. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80237 [18:27:58] MatmaRex: Up for more accessibility code review maybe? [18:28:25] hoo: ugh, later today [18:28:30] werdna: The standard way to do this (which jQuery UI does as well) is $('#foo').flow('action') [18:28:30] i need to unbreak some crappy gadgets [18:28:36] c.f. $('#foo').dialog('open') [18:28:56] MatmaRex: Thanks for doing that, I don't have the time for stuff like that atm ;) [18:29:04] basically I'm trying to extract some commonly used UI functions into their own file [18:29:10] RoanKattouw: heh, i was just about to suggest that, adding "but this is getting weirder and weirder" at the end. ;) [18:29:11] RoanKattouw: mmmm, okay [18:29:27] RoanKattouw: is that seriously considered a good idea? [18:31:07] * werdna waits for inevitable argument before proceeding ;-) [18:31:24] I don't know [18:31:31] JUI does a lot of things that I don't think are a good idea [18:31:43] (03CR) 10BryanDavis: "New commit message reads much better for me." [core] - 10https://gerrit.wikimedia.org/r/79954 (owner: 10Brian Wolff) [18:31:47] Heck, jQuery does [18:31:57] I think $.fn.flow_foo would be reasonable as well [18:32:52] actually, werdna, what browsers is flow supposed to offer baseline support for? [18:32:57] orrrr .flow().foo() [18:33:06] that actually appeals to me a little :) [18:33:11] you could do some deep wizardry with accessors and use $().flow.foo() :D [18:33:22] .flow('foo') is easy to implement [18:33:28] robla: "or if you prefer http://..." made me smile. [18:33:45] (please note, that's probably not a good idea. :D) [18:33:52] :-) [18:34:02] I don't like flow_foo() [18:34:09] it's still namespace pollution [18:34:19] just with less chance of collision [18:35:17] i'm pretty sure the chance of collision is not any higher than using 'flow' as sole "access point" [18:35:39] the only downside to that would be that it's annoying to use when debugging with JS console [18:35:47] yeah, but pollution is annoying for more reasons than collisions [18:36:01] (and maybe to type if your editor's autocompletion sucks) [18:36:36] (03PS1) 10Jeroen De Dauw: Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 [18:36:55] (03CR) 10jenkins-bot: [V: 04-1] Work on Element classes and their tests [DO NOT MERGE] [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80239 (owner: 10Jeroen De Dauw) [18:37:09] I turned off autocompletion, it had this habit of randomly finishing my sentences when I was perfectly capable of finishing them myself [18:37:21] (03Abandoned) 10Mollywhite: Change the default value of $wgBookManagerv2NavigationNamespaces [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79015 (owner: 10Mollywhite) [18:39:00] heh [18:39:08] (03CR) 10Bsitu: "I have sent an email to the product owner and designer about this change. Regarding this change, I thought trailing whitespace is not all" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/60186 (owner: 10Nischayn22) [18:39:36] (03PS1) 10Jeroen De Dauw: Update code coverage config for travis [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80240 [18:40:06] (03CR) 10Jeroen De Dauw: [C: 032] Update code coverage config for travis [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80240 (owner: 10Jeroen De Dauw) [18:40:49] (03Merged) 10jenkins-bot: Update code coverage config for travis [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80240 (owner: 10Jeroen De Dauw) [18:45:12] ^d: https://gerrit.wikimedia.org/r/#/c/80051/ :) [18:46:33] (03PS6) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [18:48:55] (03CR) 10DMaggot: "Patch set 6 addresses all validation/default things except for the "options" parameter which cannot be properly validated by JsonSchema.ph" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [18:53:33] (03PS2) 10Mollywhite: Bug 52821: Provide link to the JSON page from navbar dropdowns. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 [18:54:41] (03CR) 10Parent5446: [C: 031] Bug 44821: OpenID Consumer wiki stalls with blank page [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 (owner: 10Wikinaut) [18:55:00] (03CR) 10Mattflaschen: [C: 04-1] "(3 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [18:55:25] (03PS3) 10Mollywhite: Bug 52821: Provide link to the JSON page from navbar dropdowns. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 [19:00:43] (03CR) 10Aaron Schulz: [C: 032] Fire Echo event when revision is rejected [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 (owner: 10Alex Monk) [19:01:03] (03CR) 10Aaron Schulz: [V: 032] Fire Echo event when revision is rejected [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 (owner: 10Alex Monk) [19:01:27] why doesn't jenkins-bot do anything on FlaggedRevs +2? :/ [19:03:05] Probably because it's not told to [19:03:27] it doesn't do anything there [19:03:35] (no tests either) [19:03:53] probably because hardly anyone works onflaggedrevs, apart from aaron sometimes [19:04:00] * Reedy vaguely points at a git repo somewhere over there [19:04:03] so nobody bothered to set it up [19:08:36] (03CR) 10Wikinaut: [C: 032 V: 032] "ok, let's go" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 (owner: 10Wikinaut) [19:09:19] (03CR) 10Mattflaschen: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [19:13:05] hey AaronSchulz, wanna merge theother one too? :D [19:16:15] (03PS1) 10Mwjames: [DIC]: Improve CRAP, CC for LinksUpdateConstructed, BeforePageDisplay, UpdateObserver [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80242 [19:17:13] (03CR) 10BryanDavis: "I read the code but have no idea what I'm looking at. *new guy blush*" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J) [19:17:46] (03Abandoned) 10Wikinaut: Bug 44819, 44821, 47151 merged version [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78535 (owner: 10Wikinaut) [19:18:08] (03CR) 10Reedy: "It's called PHP. Scary, huh? Sorry in advance from all MediaWiki developers." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/78235 (owner: 10J) [19:25:13] bsitu: you there, by chance? [19:26:02] MatmaRex: yes, what's up? [19:26:37] (03PS1) 10Manybubbles: Test to verify page weight considers redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 [19:27:52] bsitu: two quick questions :) [19:28:08] bsitu: first, isit intended that the thanks log doesn't show which edit the thanks were for? [19:28:17] (and if no, could it be easily added?) [19:32:10] (03CR) 10Wikinaut: "Parent5446 & Ryan: because I committed the other patch, I now have to rebase. No particular code changes in this commit." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [19:32:22] MatmaRex: kaldari wrote this feature, I am not quite sure why it's not added, but It should be easy to add a rev with a diff link [19:33:26] hm. okay [19:33:31] i'll file a bug [19:33:47] and the second, ETA on https://gerrit.wikimedia.org/r/#/c/79775/ ? :) [19:33:54] (03PS1) 10Werdna: Fix bug in editing title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80245 [19:34:12] can i safely tell people "no later than september, kopefully next week"? :D [19:34:22] (03CR) 10EBernhardson (WMF): [C: 032] Fix bug in editing title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80245 (owner: 10Werdna) [19:34:29] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [19:34:30] (03CR) 10EBernhardson (WMF): [V: 032] Fix bug in editing title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80245 (owner: 10Werdna) [19:36:28] MatmaRex: I will go over it today or later this week, :) [19:36:31] (03CR) 10Jdlrobson: "Juliusz: The JS file for less is only there currently for debug mode as I understand it (adding link tags pointing to less files will not " [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [19:37:08] bsitu: yay, thanks [19:37:12] (03PS1) 10Manybubbles: Consider links from redirects in boosts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80246 [19:38:03] (03PS65) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [19:38:51] (03CR) 10Wikinaut: [C: 031 V: 031] "previous patchset is only a rebased version!" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [19:44:37] (03PS2) 10Manybubbles: Consider links from redirects in boosts. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80246 [19:45:25] (03CR) 10Jeroen De Dauw: [C: 032] [DIC]: Improve CRAP, CC for LinksUpdateConstructed, BeforePageDisplay, UpdateObserver [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80242 (owner: 10Mwjames) [19:51:05] (03PS1) 10Jeroen De Dauw: Add debugging statements to travis config [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80248 [19:51:27] (03CR) 10Jeroen De Dauw: [C: 032] Add debugging statements to travis config [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80248 (owner: 10Jeroen De Dauw) [19:55:08] AaronSchulz: is that rev_time bug on production, or were you testing the new code? a patch just got merged. [19:55:38] production [19:56:06] cool. already fixed. [20:01:53] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #144: ABORTED in 54 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/144/ [20:01:57] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #159: ABORTED in 1 min 3 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/159/ [20:07:07] (03CR) 10Anomie: [C: 031] Return normalized file name on warning "exists-normalized" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [20:09:19] (03CR) 10Matmarex: [C: 031] "(4 comments)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [20:14:47] (03PS1) 10Jeroen De Dauw: Update gitignore and actually add the coveralls config file [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80249 [20:14:59] (03CR) 10Jeroen De Dauw: [C: 032] Update gitignore and actually add the coveralls config file [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80249 (owner: 10Jeroen De Dauw) [20:22:53] (03PS1) 10Aaron Schulz: Move slow deletion purges out of complex DB transactions [core] - 10https://gerrit.wikimedia.org/r/80250 [20:23:27] Yippie, build fixed! [20:23:28] Project _debug-browsertests-template build #202: FIXED in 59 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/202/ [20:30:00] (03PS1) 10Raimond Spekking: Revert i18n part of 78529 [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80252 [20:30:20] greg-g: unrelated to yesterday's centralnotice fun; but I have a bunch of improvements I'd like to push out for it -- I was hoping I could steal a deployment window tomorrow [20:30:52] (03CR) 10Raimond Spekking: [C: 032 V: 032] Revert i18n part of 78529 [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80252 (owner: 10Raimond Spekking) [20:31:14] I was thinking 0900-1100 PST [20:31:43] thedj: Here again/ still? [20:33:32] (03CR) 10Raimond Spekking: "The i18n file was messed up. A whole bunch of changes/translations were accidently changes. I reverted the changes to the i18n file with g" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 (owner: 10Wikinaut) [20:41:28] (03CR) 10Jeroen De Dauw: [C: 032] Add to README [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80253 (owner: 10Jeroen De Dauw) [20:50:26] mwalker: remind me in an hour and a half, in a quarterly review right now ;) [20:50:41] kk [20:54:29] (03CR) 10Wikinaut: "Raimond, what number, hash or commit do you mean by "78529" ?" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80252 (owner: 10Raimond Spekking) [20:54:37] (03CR) 10Mwalker: "(3 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [20:55:18] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [20:55:23] (03CR) 10Raimond Spekking: "Sorry, I mean https://gerrit.wikimedia.org/r/#/c/78529/" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80252 (owner: 10Raimond Spekking) [20:58:18] (03CR) 10Mwalker: [C: 032] Bug 53164: Add variable to enable/disable navigtion bars. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80237 (owner: 10Mollywhite) [20:58:24] (03Merged) 10jenkins-bot: Bug 53164: Add variable to enable/disable navigtion bars. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80237 (owner: 10Mollywhite) [20:58:35] (03PS4) 10Werdna: Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 [20:58:36] (03PS1) 10Werdna: Major reorganisation of Javascript. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80266 [21:00:29] (03CR) 10Mattflaschen: [C: 04-1] "However, it's been mentioned above that ditching less.js and having only one LESS -> CSS path is possible." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [21:01:47] mwalker: I have had no luck getting rid of that toolbar [21:02:02] GorillaWarfare: damnable [21:02:10] needs to be stabbed with a spork! [21:02:19] wonder why it's so persistant [21:02:38] *shrugs* the bigger quibble was the JS error -- fix that and I'm good to commit it and leave the other quibbles for future improvement [21:02:46] (03PS4) 10Werdna: Topic folding. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79354 [21:04:31] Yeah, I'll take a look [21:06:43] (03CR) 10Mwalker: [C: 032] "I like it." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 (owner: 10Mollywhite) [21:07:48] (03CR) 10Mattflaschen: "> An enhancement is to support on-wiki .less files ( mentioned in https://www.mediawiki.org/wiki/Talk:Requests_for_comment/LESS )." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [21:08:11] mwalker: What do you mean by The bottom form area with the 'edit comment' box and submission buttons is missing its top border bar for some reason. [21:08:45] (03CR) 10Brian Wolff: "bump?" [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [21:09:29] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [21:10:42] GorillaWarfare: http://khaosdev.com/foo/JsonEditForm.png [21:11:07] I took the screenshot for a different reason; but there should be a line on top of the box containing summary [21:11:23] aka, the coloured area should have a full border [21:12:38] (03PS3) 10Werdna: Editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 (owner: 10Matthias Mullie) [21:13:24] (03CR) 10Werdna: "Rebased onto JS reorganisation." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79336 (owner: 10Matthias Mullie) [21:13:47] mwalker: Ah, I see this: https://www.dropbox.com/s/cnoean0nfmejo55/Screenshot%20from%202013-08-21%2017%3A12%3A48.png [21:13:57] Hence my confusion :P [21:14:48] (03Merged) 10jenkins-bot: Bug 52821: Provide link to the JSON page from navbar dropdowns. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 (owner: 10Mollywhite) [21:19:32] GorillaWarfare: interesting; I wonder if its because I'm on 1.22 [21:19:35] let me try 1.21 [21:20:32] I thought it was a Monobook/Vector thing, but it doesn't seem to be [21:23:31] GorillaWarfare: ya; they added new styling in 1.22 that puts the bottom controls in a box [21:23:48] REL_1.21 doesn't have it; but master does [21:24:13] Hahaha, so I have a bug that will appear in the future [21:24:25] yep yep :) [21:24:30] Greeeat [21:25:43] So uhh.. hm. [21:25:57] (03PS23) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:26:01] ya; don't really know what to tell you on it [21:26:11] (03CR) 10jenkins-bot: [V: 04-1] Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [21:26:12] ^ That PS should fix the JS bug, at least [21:26:16] Err, maybe not [21:26:33] Oh nvm, just a merge issue [21:26:35] I'll rebase it soon [21:27:20] (03PD5) 10Wikinaut: i18n fix follow up to https://gerrit.wikimedia.org/r/#/c/78529/ [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80295 [21:27:24] cool; works over here :) [21:27:43] rebase it and I'll merge later today [21:27:58] (03CR) 10Wikinaut: [C: 031 V: 031] "Raimond: looks good to me, and briefly tested, but pls. check, too." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80295 (owner: 10Wikinaut) [21:30:16] https folks: people on COM:VP are asking "could the opt-out of https be added to user preferences in advance of rolling it out? This would seem like an easy fix for bot operators. Thanks" [21:31:47] (03CR) 10Raimond Spekking: [C: 032 V: 032] i18n fix follow up to https://gerrit.wikimedia.org/r/#/c/78529/ [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/80295 (owner: 10Wikinaut) [21:32:27] (03PS1) 10EBernhardson (WMF): First stab at content moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 [21:38:02] (03CR) 10Wikinaut: [C: 04-2 V: 04-1] "Reason for -2: sorry, we have a regression/rebase problem in the i18n file. I need to repair it." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:43:23] (03PS24) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:45:14] (03CR) 10jenkins-bot: [V: 04-1] Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [21:53:33] (03CR) 10Wikinaut: [C: 031 V: 031] "Raimond, the i18n file looks okay to me, but I kindly ask you to check this i18n here (in order to avoid a similar problem as with the oth" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:54:38] is there a good 'pattern' for building html in javascript for mediawiki? Basically i'm trying to not have things like this indented 10+ levels: http://i.imgur.com/tVwHpNK.png [21:55:59] ebernhardson: There is some plugin that we used in WikiEditor to do this [21:56:07] (03PS25) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:56:29] The approach we take in VE is to write out the structure as HTML, then manipulate it later to add localized text and event handlers and stuff [21:56:44] mwalker: Rebased [21:57:02] There's also the jquery.localize plugin which allows you to write stuff like

[21:57:11] WikiEditor uses that a lot but nothing else uses it, not even VE [21:57:24] * werdna hates writing literal HTML in any programming language [21:57:27] RoanKattouw: thats nifty, going to use a few of those ideas i think :) [21:57:45] I'll forward you the recent jquery.localize thread [21:58:24] (03CR) 10Raimond Spekking: [C: 031] "only whitespaces changes in translations of i18n file. OK" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:59:26] (03PS2) 10Brian Wolff: [wip] Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 [21:59:34] wow is gerrit slow [21:59:44] but especially JS, because you can't use heredocs [22:01:24] It's not that bad in practice [22:01:27] * RoanKattouw finds code sample [22:01:39] the thing is, more about representing dom nodes within strings i suppose [22:02:12] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js#L165 [22:02:15] also, I don't know, I like building things bit by bit [22:02:29] * werdna prefers to write in DOM rather than in HTML [22:02:37] (03PS3) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [22:02:40] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 (owner: 10Brian Wolff) [22:02:44] And then https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js#L1407 is where the processing happens [22:02:54] werdna: I do too, but in moderation [22:03:20] The linked code sample is 50 lines of HTML [22:05:20] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Major reorganisation of Javascript. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80266 (owner: 10Werdna) [22:10:27] gerrit. Is it totally dead at this point? [22:10:48] lemme ask ^d [22:11:02] who is gone, rats [22:14:18] (03CR) 10Werdna: "We need to get nomenclature straight, I believe 'oversight' has never been the preferred term (it originally referred to the role of overs" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 (owner: 10EBernhardson (WMF)) [22:14:38] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Topic folding. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79354 (owner: 10Werdna) [22:14:45] ebernhardson: RoanKattouw: AFT uses jQuery.localize too [22:15:00] example html: https://github.com/wikimedia/mediawiki-extensions-ArticleFeedbackv5/blob/master/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js#L237 [22:15:10] (03PS3) 10Brian Wolff: [wip] Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 [22:15:11] localize: https://github.com/wikimedia/mediawiki-extensions-ArticleFeedbackv5/blob/master/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js#L2067 [22:15:24] only 10 minutes later [22:15:58] not really sure if/how .localize handles i18n message parameters, though [22:17:47] (03PS1) 10Bsitu: Remove the fixed 600px width from html email [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80305 [22:31:10] (03CR) 10Tim Starling: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:32:22] (03CR) 10EBernhardson (WMF): "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [22:32:32] (03CR) 10Matmarex: "> Does this make the "UserRequiresHTTPS" hook unnecessary? (It was added just yesterday.)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:32:53] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:32:55] (03CR) 10Tim Starling: "> Does this make the "UserRequiresHTTPS" hook unnecessary? (It was added just yesterday.)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:34:32] (03PS1) 10Mollywhite: Bug 51062: Update schema so additional properties aren't allowed. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80308 [22:34:55] (03CR) 10Mollywhite: [C: 032 V: 032] Bug 51062: Update schema so additional properties aren't allowed. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80308 (owner: 10Mollywhite) [22:37:07] (03CR) 10CSteipp: "> Does this make the "UserRequiresHTTPS" hook unnecessary? (It was added just yesterday.)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:37:19] (03CR) 10Matmarex: "It looks to be intended for the very same thing as this commit, see https://gerrit.wikimedia.org/r/#/c/80030/ . That's why I'm asking." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:38:02] (03CR) 10Matmarex: "@CSteipp, but there's a new hook in wfCanIPUseHTTPS in this commit. One of thesesurely is superfluous." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:39:05] (03CR) 10MaxSem: "Actually, I needed it for an opposite - to disable HTTPS for users who can't use it:P" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:44:08] mwalker: ohai, so, what's up? [22:44:42] mwalker: tomorrow morning or lightning deploy are open [22:46:50] (03CR) 10Tim Starling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:51:27] greg-g: yep; it's a bit too big of a deploy for an LD -- there are 4 rather largish feature enhancements [22:52:48] (03CR) 10Parent5446: "Also both hooks fulfill different purposes." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [22:52:53] oh, interesting [22:53:06] mwalker: do you have bugs/something handy? [22:53:44] I'll let you and James_F figure out his issue first [22:55:36] greg-g: https://gerrit.wikimedia.org/r/#/c/80241/ but I'll also try and triage the bug JamesF found [22:56:31] * AaronSchulz gives bawolff https://gerrit.wikimedia.org/r/#/c/80051/ [22:56:55] * bawolff looks [22:59:32] mwalker: Sorry. :-( [22:59:38] no worries [22:59:43] it's good to know about these things [22:59:51] and if I already have a deploy slot -- whoo! :) [23:00:35] now if only I could remember where we store the exception log on the cluster [23:06:27] (03CR) 10Tim Starling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:07:43] (03PS2) 10Tim Starling: Core support for disabling HTTPS based on GeoIP [core] - 10https://gerrit.wikimedia.org/r/80166 [23:10:17] (03CR) 10Tim Starling: "PS2: fix unused variable in SkinTemplate" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:10:39] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #160: SUCCESS in 9 min 51 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/160/ [23:11:33] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #145: SUCCESS in 9 min 52 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/145/ [23:12:21] anomie|away / csteipp : about wpStickHTTPS... [23:12:42] the problem with it is that you don't know the user's preference before you log in as them [23:13:04] so you can't set wpStickHTTPS to something that will reliably tell you whether or not to redirect back to HTTP [23:15:26] (03CR) 10TheDJ: "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [23:15:39] (03CR) 10Brian Wolff: [C: 032] "Looks good to me" [core] - 10https://gerrit.wikimedia.org/r/80051 (owner: 10Aaron Schulz) [23:16:36] but CentralAuth has e.g. [23:16:38] if ( $wgSecureLogin ) { [23:16:38] $finalProto = $request->getCheck( 'wpStickHTTPS' ) ? 'https' : 'http'; [23:16:38] } [23:17:24] this code is in the context of the POST response, so there's no way you can tell whether the user is logged in or not, or what their preferences are, on the basis of the query parameters [23:18:18] (03Merged) 10jenkins-bot: Tweaked location of profiling in query() to split out the implicit BEGIN [core] - 10https://gerrit.wikimedia.org/r/80051 (owner: 10Aaron Schulz) [23:18:24] i.e. you can't set the query parameters to reflect the user's preference before the user is even logged in [23:22:57] greg-g: it looks like the problem James_F discovered is related to CentralNotice's use of revtags to mark banners which need translation (https://bugzilla.wikimedia.org/show_bug.cgi?id=53186) -- the fix for that is more involved than what I'll be able to put together for tomorrow -- but I'd still like to do my features upgrade [23:24:19] * greg-g nods [23:24:25] mwalker: ok [23:24:48] oh hey, look, selenium notes [23:25:06] TimStarling: That CentralAuth code was written well before the preference was added, as far as I can tell, although the patch to do so may have been languishing. [23:27:37] Hmm. Is gerrit down for everyone, or just me? [23:28:29] not just you [23:29:19] looks like one core is maxed out [23:30:06] (03PS1) 10Brian Wolff: Change wording on message per feedback from translatewiki. [core] - 10https://gerrit.wikimedia.org/r/80311 [23:30:35] it's back now [23:30:44] one core was maxed out, and network dropped to zero [23:31:28] anyway, yes, it is a bug with https://gerrit.wikimedia.org/r/#/c/47089/ [23:31:35] (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Matmarex) [23:31:52] I'm just considering how to fix it [23:31:56] (03CR) 10Anomie: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:32:01] (03CR) 10Anomie: [C: 031] "Code seems fine, haven't tested. But it would still be nice not to introduce new style issues." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:34:00] (03CR) 10Parent5446: [C: 04-1] "Remaining code style and whitespace issues from previous commit." [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:35:30] mmm, so we not bikeshed about !! ? [23:35:41] s/not/now/ [23:37:46] I wouldn't, I like !! even though (bool) is somewhat less cryptic. [23:43:18] (03CR) 10Tim Starling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80166 (owner: 10Tim Starling) [23:49:06] but but but [23:49:21] *sumana* said you can't have trailing spaces [23:50:05] and everyone knows, what sumana says, goes [23:50:09] well I guess that settles it [23:52:45] (03PS4) 10Brian Wolff: [wip] Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 [23:53:32] (03CR) 10Spage: "Yes, assuming CentralAuth configured a certain way lets us drop the code in BeforeWelcomeCreation hook which is going to bit-rot. I think" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [23:58:04] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80316 [23:59:15] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80316 (owner: 10Catrope) [23:59:21] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80317 [23:59:26] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80317 (owner: 10Catrope)