[00:05:17] (03CR) 10Aaron Schulz: [C: 032] Change secure login to use a user preference [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [00:05:23] <^d> AaronSchulz: So, maybe we should go back to the old behavior of just redirecting on get? [00:07:17] <^d> The more I think about it, it'll actually come up pretty often. Won't all post requests by logged in users who don't change the preference from default hit this case? [00:08:27] (03Merged) 10jenkins-bot: Change secure login to use a user preference [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [00:09:26] ^d: hrm, why would that be? [00:09:53] <^d> Oh, all posts from http. [00:10:37] maybe bots that don't update their code? [00:10:48] say, if they hardcoded http:// in there [00:11:00] it would just do nothing and get back a wave of 302s [00:11:00] (03PS4) 10Ori.livneh: Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 [00:11:48] (03CR) 10Spage: [C: 04-1] "(1 comment)" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [00:12:00] <^d> AaronSchulz: Maybe I can toss some logging in there for it? You're probably right but it's easy to verify. [00:12:24] ^d: I guess they'd need good advance warning or a follow-up change would be needed to restore the old behavoir [00:12:36] logging would be good in any case [00:13:58] (03PS2) 10Demon: Remove padlock icon from login link [core] - 10https://gerrit.wikimedia.org/r/79825 [00:14:27] (03CR) 10Aaron Schulz: [C: 032] Remove padlock icon from login link [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [00:15:29] (03CR) 10Spage: [C: 032] "Letting the non-use of isAnon slide, this works logged in and not, and forcing ?useformat=mobile&mobileaction=beta" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [00:16:05] (03Merged) 10jenkins-bot: Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [00:17:51] (03PS1) 10Ori.livneh: Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79957 [00:18:17] (03Merged) 10jenkins-bot: Remove padlock icon from login link [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [00:18:30] (03PS1) 10Ori.livneh: Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79958 [00:18:50] (03CR) 10Ori.livneh: [C: 032] Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79957 (owner: 10Ori.livneh) [00:19:08] (03CR) 10Ori.livneh: [C: 032] Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79958 (owner: 10Ori.livneh) [00:20:20] ^demon: ok, heading out now [00:20:35] <^demon> Mmk. I'm working on some logging now. [00:21:14] (03CR) 10MZMcBride: "Cscott: probably ask Tim. I think the usual procedure for testing something like this is writing a tight loop and calling it 1,000,000 tim" [core] - 10https://gerrit.wikimedia.org/r/79822 (owner: 10Cscott) [00:24:47] (03Merged) 10jenkins-bot: Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79957 (owner: 10Ori.livneh) [00:26:17] (03Merged) 10jenkins-bot: Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79958 (owner: 10Ori.livneh) [00:30:15] (03PS1) 10Demon: Add some logging for weird redirected POSTs [core] - 10https://gerrit.wikimedia.org/r/79959 [00:36:20] <^demon> Edge cases are weird. [00:38:55] (03CR) 10Mwalker: [C: 04-1] "(8 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [00:39:58] (03CR) 10Parent5446: [C: 032] Add some logging for weird redirected POSTs [core] - 10https://gerrit.wikimedia.org/r/79959 (owner: 10Demon) [00:42:32] (03Merged) 10jenkins-bot: Add some logging for weird redirected POSTs [core] - 10https://gerrit.wikimedia.org/r/79959 (owner: 10Demon) [00:52:05] (03CR) 10Legoktm: "Bump?" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/69303 (owner: 10Legoktm) [01:01:04] (03PS1) 10Demon: Change secure login to use a user preference [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 [01:01:26] (03PS1) 10Demon: Remove padlock icon from login link [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79961 [01:01:27] (03PS1) 10Demon: Add some logging for weird redirected POSTs [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79962 [01:03:33] (03PS1) 10Demon: Change secure login to use a user preference [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79963 [01:03:43] (03PS1) 10Demon: Remove padlock icon from login link [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79964 [01:03:44] (03PS1) 10Demon: Add some logging for weird redirected POSTs [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79965 [01:16:16] (03PS1) 10Demon: Fix super long line [core] - 10https://gerrit.wikimedia.org/r/79966 [01:32:02] (03PS1) 10Mattflaschen: Preserve returnto when linking anon to create or signup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 [01:35:46] (03PS5) 10Fantasticfears: Sort namespace aliases by id in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 [01:37:00] (03PS2) 10Mattflaschen: Set returnto when linking anon to signup or login [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79967 [01:51:26] (03PS2) 10Werdna: Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 [01:52:20] (03PS3) 10Werdna: Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 [01:52:40] finally hopefully nearly done with this paging stuff [02:03:59] (03CR) 10Parent5446: [C: 031] "I can understand how you might not want to complicate things, but just so you know, when MediaWiki becomes CSP-compliant (which it will ev" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [03:31:33] (03PS2) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [03:32:41] (03PS3) 10DMaggot: Add support for select widget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 [03:34:42] (03CR) 10DMaggot: "Please ignore patch set 2. Patch set 3 addresses all of the issues including the one pointed out by Platonides (thx for the review!). Can " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [03:38:53] (03CR) 10Mattflaschen: "Can you rebase this?" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [04:33:12] (03PS1) 10Hiong3-eng5: OmegaWiki Development CSV update [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/79969 [04:42:15] (03PS1) 10Ryan Lane: Add postgres support [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/79971 [04:42:17] (03CR) 10jenkins-bot: [V: 04-1] Add postgres support [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/79971 (owner: 10Ryan Lane) [04:50:51] (03PS5) 10Spage: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 [04:59:58] (03CR) 10Spage: "I was trying to modularize ext.gettingstarted.return.CTA and getting the dependency with its "parent" code wrong, so PS5 moves all the cod" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [05:16:24] Yippie, build fixed! [05:16:24] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #209: FIXED in 6 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/209/ [05:16:38] (03PS2) 10Ryan Lane: Add postgres support [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/79971 [05:49:24] (03CR) 10Mattflaschen: [C: 04-1] "(12 comments)" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [05:53:51] (03CR) 10Wikinaut: "Content Security Police (CSP) compliance:" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [06:11:43] (03CR) 10Wikinaut: "Parent4556: to make you less anxious: https://bugzilla.wikimedia.org/show_bug.cgi?id=53087" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [06:24:02] (03PS1) 10Spage: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/79976 [06:32:30] (03CR) 10Nikerabbit: [C: 032] Fix super long line [core] - 10https://gerrit.wikimedia.org/r/79966 (owner: 10Demon) [06:35:33] (03Merged) 10jenkins-bot: Fix super long line [core] - 10https://gerrit.wikimedia.org/r/79966 (owner: 10Demon) [07:07:13] (03PS5) 10Wikinaut: Bug 44821: OpenID Consumer wiki stalls with blank page [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 [07:07:43] (03CR) 10Wikinaut: [C: 031 V: 031] "this is a manual "git rebase gerrit/master"." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 (owner: 10Wikinaut) [07:08:32] * ori-l waves at MaxSem [07:12:10] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79980 [07:13:40] (03CR) 10Wikinaut: "Parent5446, Ryan: I just wante to point you (also) to this small separate commit which fixes an annoying problem." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 (owner: 10Wikinaut) [07:16:08] (03CR) 10Kipcool: [C: 032 V: 032] OmegaWiki Development CSV update [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/79969 (owner: 10Hiong3-eng5) [07:17:36] hey ori-l [07:17:48] heyo [07:58:15] (03PS2) 10Shirayuki: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [07:58:39] (03CR) 10jenkins-bot: [V: 04-1] Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [08:09:59] (03PS3) 10Shirayuki: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [08:28:12] (03CR) 10TheDJ: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [08:47:19] (03PS2) 10Nikerabbit: Add diff-multi to classes with explicit direction [core] - 10https://gerrit.wikimedia.org/r/79326 (owner: 10Amire80) [08:47:25] (03CR) 10Nikerabbit: [C: 032] Add diff-multi to classes with explicit direction [core] - 10https://gerrit.wikimedia.org/r/79326 (owner: 10Amire80) [08:51:53] (03Merged) 10jenkins-bot: Add diff-multi to classes with explicit direction [core] - 10https://gerrit.wikimedia.org/r/79326 (owner: 10Amire80) [08:57:41] (03CR) 10Nikerabbit: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [09:01:12] (03CR) 10Nikerabbit: [C: 031] "Is there no but report for this?" [core] - 10https://gerrit.wikimedia.org/r/76632 (owner: 10Reedy) [09:03:32] (03CR) 10Nikerabbit: [C: 04-1] "> It could be nice to decide whether we need it" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [09:06:35] (03CR) 10Nikerabbit: [C: 032] Eliminate confusing redundancy in accmailtext [core] - 10https://gerrit.wikimedia.org/r/78511 (owner: 10Nemo bis) [09:09:00] (03CR) 10Nikerabbit: [C: 031] Remove remaining calls to MWInit methods [core] - 10https://gerrit.wikimedia.org/r/78202 (owner: 10PleaseStand) [09:09:17] (03Merged) 10jenkins-bot: Eliminate confusing redundancy in accmailtext [core] - 10https://gerrit.wikimedia.org/r/78511 (owner: 10Nemo bis) [09:13:14] (03CR) 10Nikerabbit: [C: 04-1] "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/42405 (owner: 10Alex Monk) [09:16:30] (03CR) 10Nikerabbit: [C: 04-1] "The previous version should be aliases to keep existing links working." [core] - 10https://gerrit.wikimedia.org/r/77076 (owner: 10TTO) [09:18:12] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [09:19:39] (03CR) 10Liangent: "> Who can decide this?" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [09:21:19] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76330 (owner: 10Ori.livneh) [09:22:00] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [09:23:13] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [09:33:07] (03CR) 10Nikerabbit: "It is not clear to me what action here is needed to get this resolved." [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [09:36:05] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [09:40:45] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis) [09:41:51] (03PS2) 10TTO: Update Chechen language namespace names from translatewiki [core] - 10https://gerrit.wikimedia.org/r/77076 [09:42:19] (03CR) 10Nikerabbit: [C: 04-1] "(3 comments)" [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 (owner: 10Nemo bis) [09:46:16] (03PS2) 10Nikerabbit: $wgHooks: add closure docs & admonition to register handlers early [core] - 10https://gerrit.wikimedia.org/r/76330 (owner: 10Ori.livneh) [09:47:17] (03CR) 10Ori.livneh: [C: 032] "Nice. Thanks. :)" [core] - 10https://gerrit.wikimedia.org/r/76330 (owner: 10Ori.livneh) [09:50:42] (03PS3) 10Himeshi: Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 [09:51:10] (03CR) 10Nikerabbit: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/77076 (owner: 10TTO) [09:51:34] (03Merged) 10jenkins-bot: $wgHooks: add closure docs & admonition to register handlers early [core] - 10https://gerrit.wikimedia.org/r/76330 (owner: 10Ori.livneh) [09:53:17] (03PS3) 10Himeshi: Added PageSchemas extension handling for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79556 [09:54:24] (03Merged) 10jenkins-bot: Update Chechen language namespace names from translatewiki [core] - 10https://gerrit.wikimedia.org/r/77076 (owner: 10TTO) [10:13:10] (03CR) 10Tpt: [C: 04-1] "(2 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi) [10:14:18] (03CR) 10Tpt: [C: 04-1] "(7 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [10:15:33] (03PS1) 10Ori.livneh: Post-edit confirmation: ensure consistent font-size across skins [core] - 10https://gerrit.wikimedia.org/r/79991 [10:45:03] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79991 (owner: 10Ori.livneh) [10:49:32] (03PS1) 10Jeroen De Dauw: Make use of LatLongValue rather then GeoCoordinateValue [extensions/Maps] - 10https://gerrit.wikimedia.org/r/79993 [10:49:40] (03CR) 10jenkins-bot: [V: 04-1] Make use of LatLongValue rather then GeoCoordinateValue [extensions/Maps] - 10https://gerrit.wikimedia.org/r/79993 (owner: 10Jeroen De Dauw) [10:59:56] (03Abandoned) 10Zfilipin: WIP Testing if Gerrit is setup correctly. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78968 (owner: 10Carolsand) [11:00:39] (03Abandoned) 10Zfilipin: WIP Scenario: Wikilove icon exists if I visit another user page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79325 (owner: 10Zfilipin) [11:18:52] (03CR) 10TMg: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79991 (owner: 10Ori.livneh) [12:03:02] (03CR) 10Jeroen De Dauw: [C: 032] "I do not see all implications yet and probably have more feedback after using this." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [12:04:36] (03Merged) 10jenkins-bot: \SMW\SimpleDependencyBuilder + \SMW\DependencyInjector [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [12:07:38] (03PS20) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [12:07:39] (03PS2) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [12:07:40] (03PS24) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [12:07:41] (03PS28) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:07:42] (03PS32) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [12:07:53] (03CR) 10jenkins-bot: [V: 04-1] Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 (owner: 10Rtdwivedi) [12:08:04] (03CR) 10jenkins-bot: [V: 04-1] Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 (owner: 10Rtdwivedi) [12:08:11] (03CR) 10jenkins-bot: [V: 04-1] Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 (owner: 10Rtdwivedi) [12:13:38] (03PS21) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [12:13:39] (03PS3) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [12:13:40] (03PS25) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [12:13:41] (03PS29) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:14:19] hi Rtdwivedi how are you? [12:14:47] Hi sumanah ! I am fine. How are you? [12:15:44] I'm not bad! [12:15:48] I mentioned you in a wikimediaindia-l post recently [12:16:27] I saw that. I replied to one question as well. [12:16:41] Oh cool! I will see that soon then [12:17:23] Ankur India has a GSoC project on improving the information retrieval methods from OCR for Indic languages. I mentioned that. [12:18:34] I love it when FOSS projects complement each other. :-) [12:19:03] :-) [12:20:36] Rtdwivedi: your mail is not in http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-August/thread.html yet - did you send it to the list? [12:20:46] or was this question in a different place? [12:22:33] I did send it to the list. [12:22:38] (03CR) 10Nemo bis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [12:29:40] Rtdwivedi: I didn't receive your reply, and it didn't make it into the list archives :( [12:32:20] I re-sent the message. [12:34:12] sumanah: Did it work? [12:35:26] Rtdwivedi: as you can see in http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-August/date.html#start , the last email to that list is from sankarshan [12:36:33] How come gmail shows that my message was sent but not the list? :( [12:36:52] Rtdwivedi: It could be that your email has bounced, or is being held by the list moderator. [12:37:10] Rtdwivedi: you might want to check about other emails you have also been sending to mailing lists, to see whether they got through. [12:38:09] http://lists.wikimedia.org/pipermail/wikimediaindia-l/2013-May/thread.html shows my mail. [12:40:19] Rtdwivedi: yes! I see those mails from May. [12:49:19] Rtdwivedi: But I still don't see those August mails showing up on-list. (I saw one you cc'd me on.) [12:49:53] Maybe if you email the list moderators (link at the bottom of https://lists.wikimedia.org/mailman/listinfo/wikimediaindia-l ) they can help [12:49:55] Ouch, I cc'd it to the list as well. :'( [13:06:06] (03PS1) 10Liangent: Make FakeConverter more realistic [core] - 10https://gerrit.wikimedia.org/r/80011 [13:10:26] andre__: https://en.wikipedia.org/wiki/Andy_Goldsworthy [13:10:41] hehe, nice patchset subject :) [13:13:56] (03CR) 10Aude: [C: 031] Make FakeConverter more realistic [core] - 10https://gerrit.wikimedia.org/r/80011 (owner: 10Liangent) [13:24:02] Is a dev around? [13:24:12] s/dev/sysadmin [13:28:46] KittyReaper: depending on what you need a "sysadmin" for, #wikimedia-operations might be more suitable. But really depends on what you refer to [13:32:01] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [14:12:17] (03PS1) 10Manybubbles: Remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80018 [14:15:00] (03PS2) 10Jeroen De Dauw: Make use of LatLongValue rather then GeoCoordinateValue [extensions/Maps] - 10https://gerrit.wikimedia.org/r/79993 [14:15:19] (03CR) 10Jeroen De Dauw: [C: 032] Make use of LatLongValue rather then GeoCoordinateValue [extensions/Maps] - 10https://gerrit.wikimedia.org/r/79993 (owner: 10Jeroen De Dauw) [14:21:21] (03PS4) 10Himeshi: Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 [14:25:38] @notify qgil [14:25:38] I'll let you know when I see qgil around here [14:25:47] @seen qgil [14:25:47] T13: Last time I saw qgil they were quitting the network with reason: Ping timeout: 248 seconds N/A at 8/20/2013 6:47:33 AM (7h38m13s ago) [14:26:16] jeremyb: wm-bot will tell me when he shows up. :) [14:27:41] dzien dobry [14:31:41] bad wm-bot [14:32:09] @seen qgil [14:32:09] jeremyb: qgil is in here, right now [14:32:21] wm-bot: make up your mind [14:32:21] Hi jeremyb, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [14:32:46] jeremyb, are you ok? ;) [14:33:34] qgil: 20 12:47:24 < T13|needsCoffee> Who would I talk to about doing a Wikimedia GSoC project next year as my CIS380 internship for my BS next summer? [14:33:43] 20 14:25:38 < T13> @notify qgil [14:33:43] 20 14:25:38 < wm-bot> I'll let you know when I see qgil around here [14:33:59] Yep. wm-bot let me know. :) [14:34:06] hi qgil [14:34:08] oh, just not in the channel?? [14:34:13] not what i expected [14:34:22] [10:31] T13! qgil just joined #mediawiki. This message was delivered to you because you asked me to notify you about this user's activity. For more information, see http://meta.wikimedia.org/wiki/WM-Bot [14:34:31] in a /query [14:34:38] petan: that URL should be HTTPS [14:34:52] jeremyb: I'll change it later. ;) [14:35:27] to https://meta.wikimedia.org/wiki/wm-bot [14:35:36] jeremyb, we can't assure anybody's participation in GSoC 2014 until it is announced, proposals are sent, we have decided our candidates and Google confirms them [14:36:12] qgil: yes, i was simply announcing that you were a person to talk to about it :) [14:37:03] jeremyb, talking is good. :) Looking at how this year went, determined candidates starting soon (and having the skills, of course) have higher chances. [14:37:05] qgil: I expected that, but I'm sure it is going to take me some time to get my university to all participation. [14:37:20] qgil: seems relatively likely that there would be some sort of GSoC next year. so doesn't hurt to start developing a mentor, etc. [14:37:22] s/all/allow/ [14:37:49] jeremyb, do you need your university to allow you? [14:38:06] qgil: i'm not GSoC eligible AFAIK [14:38:52] (03PS3) 10Rachel99: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 [14:38:57] jeremyb, then how you plan to become eligible? Anyway, you have plenty of time to figure out these things. And indeed, starting soon with a project idea and mentors linking it does help. [14:39:26] (03PS1) 10Manybubbles: Test remove parts of rendered page from search. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 [14:40:12] ooops Linux sotware update. Must restart. [14:42:48] (03CR) 10MZMcBride: "Now that has been merged, I think this commit can safely be abandoned." [core] - 10https://gerrit.wikimedia.org/r/67615 (owner: 10Bharaththiruveedula) [14:47:30] qgil: it's T13 not me [14:50:42] qgil: huh, i was assuming there was some upper bound on age for GSoC. but https://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2013/help_page#1._Are_there_any_age_restrictions_on seems to say otherwise [14:50:47] so maybe i will some day! [14:50:52] first i need to be a student [14:51:37] Being a student is the requirement. [14:51:52] and also being 18 by a certain date [14:52:04] but i figured you had to be e.g. under 30 or something [14:54:15] hmm, I remember some GSoC students who were older [15:05:07] I'm 34, so this would need to be confirmed. [15:08:57] (03PS1) 10Jeroen De Dauw: Update README file [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80023 [15:08:59] (03PS1) 10Jeroen De Dauw: Update release notes [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80024 [15:10:52] (03PS2) 10Jeroen De Dauw: Update release notes [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80024 [15:11:00] (03CR) 10Jeroen De Dauw: [C: 032] Update README file [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80023 (owner: 10Jeroen De Dauw) [15:11:14] (03CR) 10Jeroen De Dauw: [C: 032] Update release notes [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80024 (owner: 10Jeroen De Dauw) [15:14:37] (03PS1) 10Jeroen De Dauw: Add coveralls.io support [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80025 [15:14:54] (03CR) 10Jeroen De Dauw: [C: 032] Add coveralls.io support [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80025 (owner: 10Jeroen De Dauw) [15:22:43] (03CR) 10MaxSem: "Maybe, just use __DIR__ everywhere?" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/76253 (owner: 10Legoktm) [15:26:25] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-chrome build #1: FAILURE in 46 min: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-chrome/1/ [15:58:05] (03CR) 10CSteipp: [C: 032 V: 032] Adding some missing messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79824 (owner: 10Aaron Schulz) [15:58:25] (03CR) 10Yaron Koren: [C: 032 V: 031] Added PageSchemas extension handling for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79556 (owner: 10Himeshi) [15:58:29] (03Merged) 10jenkins-bot: Added PageSchemas extension handling for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79556 (owner: 10Himeshi) [15:58:39] (03PS1) 10MaxSem: New hook, UserRequiresHTTPS [core] - 10https://gerrit.wikimedia.org/r/80030 [15:58:42] (03CR) 10Yaron Koren: [C: 032 V: 031] Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 (owner: 10Himeshi) [16:01:47] (03PS1) 10Jeroen De Dauw: Infrastructure improvements [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80031 [16:01:59] (03CR) 10Jeroen De Dauw: [C: 032] Infrastructure improvements [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80031 (owner: 10Jeroen De Dauw) [16:02:22] (03CR) 10Yaron Koren: [V: 032] Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 (owner: 10Himeshi) [16:02:29] (03Merged) 10jenkins-bot: Infrastructure improvements [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80031 (owner: 10Jeroen De Dauw) [16:06:18] (03PS1) 10Jeroen De Dauw: Add travis and coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80032 [16:08:17] (03CR) 10Jeroen De Dauw: [C: 032] Add travis and coveralls config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80032 (owner: 10Jeroen De Dauw) [16:11:54] (03CR) 10Mollywhite: "(3 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [16:16:43] (03PS1) 10Jeroen De Dauw: Have Travis set up a MW install [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80034 [16:16:51] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Have Travis set up a MW install [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80034 (owner: 10Jeroen De Dauw) [16:17:21] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80030 (owner: 10MaxSem) [16:20:17] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80030 (owner: 10MaxSem) [16:20:49] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80035 [16:21:35] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80035 (owner: 10Jeroen De Dauw) [16:21:48] (03CR) 10Matmarex: "Did you mean UserRequiresHTTP?" [core] - 10https://gerrit.wikimedia.org/r/80030 (owner: 10MaxSem) [16:22:25] (03CR) 10Demon: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80030 (owner: 10MaxSem) [16:25:05] (03Merged) 10jenkins-bot: New hook, UserRequiresHTTPS [core] - 10https://gerrit.wikimedia.org/r/80030 (owner: 10MaxSem) [16:25:19] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80036 [16:25:30] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80036 (owner: 10Jeroen De Dauw) [16:27:10] (03PS1) 10Demon: New hook, UserRequiresHTTPS [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80037 [16:27:54] (03PS1) 10Demon: New hook, UserRequiresHTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80038 [16:30:53] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80040 [16:32:54] (03PS1) 10Yaron Koren: Undid change that made "too many/too few" messages "smarter" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/80041 [16:33:55] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80040 (owner: 10Jeroen De Dauw) [16:36:56] (03PS2) 10Yaron Koren: Undid change that made "too many/too few" messages "smarter" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/80041 [16:37:26] (03PS1) 10Brian Wolff: Follow-up db51c53b8f. Fix already used variable name. [core] - 10https://gerrit.wikimedia.org/r/80042 [16:38:37] (03CR) 10Yaron Koren: [C: 032 V: 031] Undid change that made "too many/too few" messages "smarter" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/80041 (owner: 10Yaron Koren) [16:38:48] (03PS1) 10Brian Wolff: Follow-up db51c53b8f. Fix already used variable name. [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80043 [16:39:00] (03Merged) 10jenkins-bot: Undid change that made "too many/too few" messages "smarter" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/80041 (owner: 10Yaron Koren) [16:39:35] (03CR) 10Alex Monk: [C: 032] "How did I even get this to work? Sorry..." [core] - 10https://gerrit.wikimedia.org/r/80042 (owner: 10Brian Wolff) [16:39:45] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80044 [16:39:54] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80044 (owner: 10Jeroen De Dauw) [16:41:31] (03PS1) 10Jeroen De Dauw: Install coveralls dependencies in Travis build [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80045 [16:41:40] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Install coveralls dependencies in Travis build [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80045 (owner: 10Jeroen De Dauw) [16:43:59] (03Merged) 10jenkins-bot: Follow-up db51c53b8f. Fix already used variable name. [core] - 10https://gerrit.wikimedia.org/r/80042 (owner: 10Brian Wolff) [16:44:45] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80046 [16:44:55] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80046 (owner: 10Jeroen De Dauw) [16:49:51] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80047 [16:51:11] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80047 (owner: 10Jeroen De Dauw) [16:51:15] (03CR) 10Jeroen De Dauw: [C: 032] Improve travis config [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80048 (owner: 10Jeroen De Dauw) [16:57:23] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80050 [16:57:44] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80050 (owner: 10Jeroen De Dauw) [17:00:26] (03PS1) 10Aaron Schulz: Tweaked location of profiling in query() to split out the implicit BEGIN [core] - 10https://gerrit.wikimedia.org/r/80051 [17:03:28] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80052 [17:03:38] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80052 (owner: 10Jeroen De Dauw) [17:06:37] bawolff: "(For example, uploading mp4 files, after renaming it to be .jpg works on commons)" [17:06:44] hmm, that wording sounds off [17:08:25] (03PS1) 10Jeroen De Dauw: Add debugging statements to travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80054 [17:08:34] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add debugging statements to travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80054 (owner: 10Jeroen De Dauw) [17:10:15] (03CR) 10Aaron Schulz: "Can the last bit in the summary be reworded to be clearer?" [core] - 10https://gerrit.wikimedia.org/r/79954 (owner: 10Brian Wolff) [17:12:57] 5.432390 GadgetHooks::getPreferences [17:12:59] why is that so slow? [17:17:38] * Aaron|home eyes RoanKattouw [17:17:47] ? [17:17:57] I have nothing to do with the master implementation of Gadgets [17:18:06] I have everything to do with the RL2 implementation of it but that never got merged [17:18:15] maybe it fixes that ;) [17:18:52] it causes DB locks to be held for an extra 7 seconds due to query order [17:20:40] It theoretically uses memcached [17:20:55] It may be that it does an unreasonable amount of processing on the data it gets from emmc [17:21:09] But normally I can only see it taking 5s when hitting a cold cache [17:25:12] ,/msg Isarra merp erp! :) [17:25:17] well; that works too [17:26:24] * Isarra hugs mwalker and doesn [17:26:27] 't let go. [17:26:46] Don't suppose I could get you to kidnap me and make me do something useful. [17:27:13] (03PS3) 10BryanDavis: Make MOTD banner fit in 80 chars. [vagrant] - 10https://gerrit.wikimedia.org/r/77834 [17:27:23] hurm; kidnapping might be difficult; I already have one friend staying in my apartment -- but usefullness [17:27:29] there's always useful things to be done! [17:27:34] ori-l: ^^^ now with more unicorn [17:27:44] (03PS1) 10Jeroen De Dauw: Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80057 [17:28:33] (03PS1) 10MarkTraceur: Stop using mw.msg [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80058 [17:30:54] * Isarra grabs YuviPanda and runs away. [17:31:30] * YuviPanda wonders where he is being spirited away to [17:32:40] (03CR) 10Jeroen De Dauw: [C: 032] Update Travis config [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80057 (owner: 10Jeroen De Dauw) [17:37:29] (03PS1) 10Jeroen De Dauw: Only run the Maps tests on Travis [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80059 [17:39:13] (03CR) 10Jeroen De Dauw: [C: 032] Only run the Maps tests on Travis [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80059 (owner: 10Jeroen De Dauw) [17:40:16] greg-g: yt? [17:40:24] DarTar: I am. [17:40:43] wanna chat about https? I'm not sure if you guys need something different [17:40:55] or if my assumptions make sense [17:41:06] I haven't looked into the data yet, was tryign to figure out google docs, heh ;) [17:41:26] happy to walk you through them [17:41:31] Ryan_Lane ^^ [17:41:58] (03PS1) 10Bsitu: Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80060 [17:42:13] I'm checking with ori-l the new sampling rates, I was expecting a much higher volume of events for anons since yesterday [17:43:39] (03PS1) 10Demon: Remove cols and rows preferences [core] - 10https://gerrit.wikimedia.org/r/80061 [17:43:41] * werdna prods csteipp, jdlrobson  [17:44:19] (03PS2) 10Demon: Remove cols and rows preferences [core] - 10https://gerrit.wikimedia.org/r/80061 [17:44:31] <^d> Elsie: ^ [17:44:43] DarTar: Ryan's not here yet :) [17:44:51] (03PS1) 10Aaron Schulz: The "masterPos" field in refreshLinks can be false so check for that [core] - 10https://gerrit.wikimedia.org/r/80064 [17:45:29] greg-g: np, ping me if/when you guys want to chat [17:45:53] * greg-g nods [17:45:53] will do [17:45:58] Hmm.? [17:49:21] (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80066 [17:50:31] (03CR) 10Bsitu: [C: 032] Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80060 (owner: 10Bsitu) [17:50:47] (03CR) 10Bsitu: [C: 032] Update Echo to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80066 (owner: 10Bsitu) [17:51:35] werdna: sup? [17:51:50] csteipp: so I want to spend today catching up on some AbuseFilter things. First on the list is the problem that jdlrobson is having with mobile edits, but after that maybe you have some things you'd like to talk over / work on? [17:52:22] AbuseFilter \o/ [17:52:28] * hoo hides below his desk [17:52:36] * werdna traps hoo under his desk [17:53:22] :D [17:53:38] (03Merged) 10jenkins-bot: Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80060 (owner: 10Bsitu) [17:53:40] We still need to fix or kill the condition limit mess [17:55:09] (03CR) 10Bsitu: [V: 032] Update Echo to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80066 (owner: 10Bsitu) [17:55:21] werdna: Yep, condition limits. Automatic hiding/suppression has also come up a few times lately. [17:55:49] csteipp: I think I still got a patch on one of my machines which adds a hook to AF which auto surpresses log entries on page deletions [17:56:12] https://gerrit.wikimedia.org/r/72724 that one should be merged at some time... fixes the read-only UI for editing global filters [17:56:15] csteipp: what do you mean by auto hiding / suppression [17:56:22] what's wrong with condition limits? [17:56:38] hoo: is that already assigned to me? [17:56:42] werdna: It's broken and broken and broken. On top of that it doesn't work [17:56:55] condition limits? [17:56:59] yep [17:57:16] We should find a nicer way to measure performance metrics... getrusage maybe? [17:57:26] or time limit [17:57:48] werdna: Hiding entries on username suppression and page deletion [17:57:50] as a fallback maybe, but time limits tend to be troublesome if you got overloaded servers [17:58:19] csteipp: meaning, when a username is suppressed, the log entries associated with that user should also get that treatment? [17:58:22] And we have to make sure it works fine with global filters either... [17:58:31] werdna: yep [17:59:40] werdna: yep [18:00:03] csteipp: I have the list so far of mobile editing, condition limit updates, better log entry suppression triggers, and some code reviews [18:00:09] anything you want to discuss while I'm in town? [18:00:50] werdna: Depends on how much time you have :) [18:01:01] Integration of SpamBlacklist...? [18:01:20] (03CR) 10Brian Wolff: [C: 032] Purge upstream caches when deleting file assets. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79844 (owner: 10BryanDavis) [18:01:25] csteipp: Do we really want that with the current AbuseFilter [18:01:38] The code isn't especially nice already... [18:01:46] We've discussed it before [18:01:54] well, the code can be gradually improved [18:02:06] (03PS1) 10Bsitu: Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80069 [18:02:08] csteipp: well, that list I have is probably already enough for today [18:02:11] werdna: But only to some point [18:02:23] but I'll revisit it in September. [18:02:23] especially when it comes to the data structure we will face hard times [18:02:27] Project browsertests-en.wikipedia.org-linux-chrome build #263: FAILURE in 3.9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/263/ [18:02:30] hoo: what do you mean? [18:02:31] Project browsertests-en.wikipedia.org-linux-firefox build #249: FAILURE in 4.2 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/249/ [18:02:35] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #122: FAILURE in 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/122/ [18:02:47] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #222: FAILURE in 4.1 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/222/ [18:02:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #210: FAILURE in 3.8 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/210/ [18:02:51] werdna: We saved serialized objects in the database due to that you simply can't alter some of the classes [18:03:20] and AbuseFilter class itself does almost everything wrong you can be doing wrong in OOP [18:03:21] hoo: not true, you can retain both and convert on the fly [18:03:32] heh, the God class. [18:03:36] Yes, but that sounds like a lot of unneeded work [18:03:53] well, you just spent ages telling me that it was needed :) [18:03:56] well, not ages [18:03:59] but a few minutes. [18:04:00] (03CR) 10Brian Wolff: [C: 032] Purge upstream caches when deleting file assets. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:04:10] Chris and I thought it might be better to write a new extension as thats going to give us 1) better results 2) only slightly more work, if at all [18:04:35] (03Merged) 10jenkins-bot: Purge upstream caches when deleting file assets. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79844 (owner: 10BryanDavis) [18:04:43] http://www.joelonsoftware.com/articles/fog0000000069.html [18:05:11] (03CR) 10Brian Wolff: [C: 032] Release note update for bug 51064. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79915 (owner: 10BryanDavis) [18:05:35] I think you're underestimating the amount of work involved in rewriting an extension from scratch. [18:05:43] werdna: We're not rewriting MediaWiki core here, but we want a new abstract interface to be able to listen to user made actions (edits, ...) [18:06:03] I don't, you'd probably need to work on that exclusively for quite some time [18:06:12] (03CR) 10jenkins-bot: [V: 04-1] Purge upstream caches when deleting file assets. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:06:33] I don't know if you're going to get much time from me if it's not in maintaining something I've already written. [18:07:07] (03CR) 10Brian Wolff: "recheck" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:07:44] When I do (yes, less frequently than I'd like to) maintain AbuseFilter, it's because I wrote it originally and it's polite to maintain code you've already written. If your aim is to write a new filtering extension, then that would compete with my other assignments. [18:08:29] I'm maintaining AF for 10 months or so now, it's not a nice job to do that... [18:10:01] true. and I appreciate that, by the way. [18:10:10] I haven't really had enough time to work on WMF stuff the last year. [18:10:55] In my opinion we should just avoid to built more bloat into AbuseFilter (especially into it's fits-it-all super class)... maybe at some point the foundation finds the courage to let someone write up our new extension idea which would be much more flexible ... [18:11:12] s/courage/engineers/ [18:11:18] we don't really have very many of them. [18:11:43] Quote from the article I linked to: The code is not factored correctly. The networking code is popping up its own dialog boxes from the middle of nowhere; this should have been handled in the UI code. These problems can be solved, one at a time, by carefully moving code, refactoring, changing interfaces. They can be done by one programmer working carefully and checking in his changes all at once, so that nobody else is disrupted. Even fairly major [18:11:43] architectural changes can be done without throwing away the code. On the Juno project we spent several months rearchitecting at one point: just moving things around, cleaning them up, creating base classes that made sense, and creating sharp interfaces between the modules. But we did it carefully, with our existing code base, and we didn't introduce new bugs or throw away working code. [18:12:12] (03PS1) 10Mwjames: Move DependencyBuilder into \dic\, improve readability and add README [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80070 [18:14:14] werdna: I guess we could even move the hooks file to the new extension and we could retain the parser as one of the new filter options, but we certainly want brand new logic to handle multiple filter backends in an efficient manner [18:14:46] and probably even some of the UI code (although that one is in parts pretty bad as well) [18:14:54] (03CR) 10Brian Wolff: "try again" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:14:54] - one [18:14:59] (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80071 [18:15:09] UI code was written five years ago, all the UI code from MediaWIki in that era is awful :) [18:15:26] I would say that if I were to rearchitect AbuseFilter, just off the top of my head, here would be a few obvious changes that would help get it towards a more modern state: [18:15:43] (03CR) 10Bsitu: [C: 032] Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80069 (owner: 10Bsitu) [18:15:46] 1. Make a Filter object, and extract all of the filter management logic to that [18:15:59] (03CR) 10Bsitu: [C: 032] Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80071 (owner: 10Bsitu) [18:16:14] 2. Extract actions to their own objects [18:17:08] 3. (probably what I'll have to do today) Separate UI and filtering code, so that running a filter returns a list of filters and their actions rather than an error message [18:17:41] (03Merged) 10jenkins-bot: Release note update for bug 51064. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79915 (owner: 10BryanDavis) [18:17:45] 4. Extract filtering and testing code to their own (related) classes. [18:17:53] (03CR) 10Bsitu: [V: 032] Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80071 (owner: 10Bsitu) [18:17:53] It already does that internally (a bit)... we use Status objects these days [18:18:14] (03CR) 10Bsitu: [V: 032] Adjust two new date formats for Polish (pl) [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80069 (owner: 10Bsitu) [18:18:21] that's a nice change, but it isn't fully complete, or we wouldn't have the problems with Mobile and API edits that we do. [18:18:38] I don't really know these problems... [18:18:51] I'm not fully clear on them either, but apparently: [18:18:58] 1. AbuseFilter is hitting 29% of Mobile edits. [18:19:30] 2. It wasn't clear that this was the case because an AF hit through the API (at least in the way that Mobile is hitting it) resulted in a false success message [18:19:47] (03CR) 10IAlex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79562 (owner: 10IAlex) [18:19:57] 3. It isn't easy to determine why, because there doesn't seem to be any scope for filtering out particular types of edits for analysis from the logs. [18:20:10] (03PS2) 10IAlex: Add new HTMLForm::addHiddenFields() methods [core] - 10https://gerrit.wikimedia.org/r/79562 [18:20:29] Yes, there's much to do there... about 2: Really? [18:20:46] If that's true I must have messed when implementing the API error messages :/ [18:21:00] greg-g: Are all the deployment windows in use today? Or is there any chance of getting a config change deployed before 4? [18:21:20] Prior to that change AF only gave generic hookaborted errors which were extremely useless [18:21:24] (03PS3) 10IAlex: Add new HTMLForm::addHiddenFields() methods [core] - 10https://gerrit.wikimedia.org/r/79562 [18:21:56] csteipp: 3-4 is open [18:21:58] (03CR) 10Parent5446: [C: 032] Add new HTMLForm::addHiddenFields() methods [core] - 10https://gerrit.wikimedia.org/r/79562 (owner: 10IAlex) [18:22:04] (03CR) 10Brian Wolff: [C: 031] Purge upstream caches when deleting file assets. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:22:10] (03CR) 10Brian Wolff: [C: 032] Purge upstream caches when deleting file assets. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:23:00] (03CR) 10Brian Wolff: [V: 032] "screw jenkins." [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 (owner: 10BryanDavis) [18:23:33] greg-g: That will work. Can I use the first 10 minutes of it? [18:23:36] (03CR) 10Brian Wolff: [C: 032] Release note update for bug 51064. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79918 (owner: 10BryanDavis) [18:23:54] csteipp: yes. [18:24:19] csteipp: what's the change? [18:25:45] hoo: mmm, well I'll take a look at it anwyay [18:26:05] greg-g: Updating who can use OAuth (https://gerrit.wikimedia.org/r/#/c/80039/1) [18:26:51] csteipp: hoo: and for condition limits… what's the actual problem? [18:27:02] I've heard "It's broken" and "It doesn't work" [18:27:21] do you mean that in general, the number of conditions is a poor metric for measuring performance, and that we're better off finding a new one? [18:27:32] csteipp: thanks [18:27:36] werdna: They're probably broken in combination with global filters (we haven't tested that) and https://bugzilla.wikimedia.org/show_bug.cgi?id=51294 [18:27:39] oh [18:27:54] anomie is talking about getting that in in the next little bit after bsitu is done with his deploy [18:27:59] csteipp: ^ [18:28:16] and yes, that's a very poor metric... the most expensive options (getting a full sized diff and fun like that is totally underrated) [18:28:20] greg-g: Ah, yeah, let anomie handle it :) [18:28:23] :) [18:28:40] now I gotta delete all that nice recording I did.... [18:29:27] So what do you suggest? getrusage() instead? return when it takes longer than 500ms of user time? [18:29:46] werdna: If getrusage is portable, yes something like that [18:30:30] well, it isn't, but we can fall back to microtime() [18:30:37] (03Merged) 10jenkins-bot: Add new HTMLForm::addHiddenFields() methods [core] - 10https://gerrit.wikimedia.org/r/79562 (owner: 10IAlex) [18:30:48] that sounds sane [18:31:07] sounds like the meaty stuff will be suppression things. [18:31:20] and then I'll finish up by reviewing some pending patches. [18:32:09] Yes... at best we would get the total number of function calls or something like that which we can keep track of, but I don't think PHP provides us these metrics [18:32:10] (03CR) 10Mwjames: [C: 032] Move DependencyBuilder into \dic\, improve readability and add README [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80070 (owner: 10Mwjames) [18:33:37] werdna: We also thought about abusing MediaWiki's profiler, I'm not sure taht's possible, you probably have to ask Tim about that... but that'll probably take more time anyway [18:34:45] hoo: facebook invented xhprof for exactly that reason [18:35:28] but that's not part of PHP itself... [18:35:38] (03Merged) 10jenkins-bot: Move DependencyBuilder into \dic\, improve readability and add README [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80070 (owner: 10Mwjames) [18:36:11] php-pecl-xhprof.x86_64 : PHP extension for XHProf, a Hierarchical Profiler [18:36:24] hoo: correct, its an extension (which is also not likely used at facebook anymore since they are on hhvm, and additionally since we are considering a move to hhvm in the next 6 ish months may not be worth looking at) [18:38:15] (03Merged) 10jenkins-bot: Release note update for bug 51064. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79918 (owner: 10BryanDavis) [18:43:00] power outage (online via mobile network now)... did I miss anything [18:43:50] ? [18:45:23] hoo: No; only you leaving and re-joining. :-) [18:45:34] hoo: Also, you should get an IRC bouncer so you can catch up. :-) [18:45:51] My network usually is very stable :P [18:46:03] I never bother with bouncers [18:46:10] Now my homeserver uptime of 150+ days has been doomed [18:47:02] But how can you hang out on IRC on your 'phone, then your laptop, then your desktop, then your tablet all at once? :-) [18:47:40] James_F: screen -Rx [18:47:55] (attach to not-detached screen session) [18:48:00] I'm usually happy to not have IRC on my phone (I got an android IRC app thing, but I barely use it) :P [18:48:06] although, i dont really use that on my phone :P [18:48:24] ebernhardson: Shell on the phone is a pain, sadly... [18:48:31] ebernhardson: That requires you to use a terrible IRC client, though. :-) [18:48:45] Irssi is fine :P [18:48:57] Although I had to patch it to get it to work properly... [18:49:01] James_F: some of us are old enough that we learned on computers without mice and graphics :P [18:49:14] James_F: just alt-F1-F6 black consoles, and we like it :P [18:49:38] ebernhardson: Some of us are old enough to remember why we switched to GUIs. :-) [18:49:55] James_F: the reason was incompetant users right? [18:50:01] James_F: e.g. PEBKAC [18:50:15] at least, thats what i remember :P [18:51:31] hoo: I heard that you are doing some work on accessibility for the next month or so? are there any details available? [18:51:37] ebernhardson: Pah. :-) [18:52:25] ebernhardson: Indeed I am... what details are you looking for? [18:52:48] chrismcmahon: ^ [18:53:18] hoo: any particular extensions, or features, or pages, or whatever? I ask because I find that accessibility and testability are often essentially the same thing [18:53:48] hoo: and we definitely have widespread accessibility issues [18:54:09] chrismcmahon: Well we're focused on Wikimedia sites so we don't really make a distinction between core and extensions over here. If something's important I should address it, no matter of the component [18:55:24] http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/ we use that report as base to identify the most important issues, but of course there are further ones and I already have a bit of stuff in gerrit [18:56:04] * quite some stuff [18:57:12] (03CR) 10Matthias Mullie: [C: 031] Fire Echo event when revision is rejected [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 (owner: 10Alex Monk) [18:58:08] (03PS1) 10Ragesoss: Fix course page history SQL error [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 [18:58:47] James_F: Just a thing that came into my mind now: If I hosted the IRC bouncer myself it would probably just went down as well (as my server went down as well) [18:59:16] hoo: I'm currently hosting a ZNC on EC2 used by a dozen people; I guess I could give you an account. [18:59:36] hoo: But yes, the first tip for IRC bouncers is: don't run it locally. [18:59:51] (03PS1) 10Mwjames: Fix travis-ci PHP_CodeCoverage_Exception [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80077 [19:00:07] jdlrobson: so I'm checking out AbuseFilter API error messages; I'm getting them just fine [19:00:23] (03CR) 10Mwjames: [C: 032] Fix travis-ci PHP_CodeCoverage_Exception [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80077 (owner: 10Mwjames) [19:00:40] {"edit":{"code":"abusefilter-disallowed","info":"Hit AbuseFilter: Test filter","warning":"This action has been automatically identified as harmful, and therefore disallowed.\nIf you believe your action was constructive, please inform an administrator of what you were trying to do.\nA brief description of the abuse rule which your action matched is: Test filter","result":"Failure"}} [19:01:07] that's exactly how I wanted them to be :) [19:02:48] (03Merged) 10jenkins-bot: Fix travis-ci PHP_CodeCoverage_Exception [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80077 (owner: 10Mwjames) [19:04:14] is there any sort of convention for indicating to code reviewers that you have no idea what the changes you just made mean, but they seem to fix the bug? [19:05:11] what do i need to do to give myself sysop on a (local) test wiki ? [19:08:37] (03CR) 10Demon: [C: 032] Change secure login to use a user preference [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79963 (owner: 10Demon) [19:09:37] (03CR) 10Demon: [C: 032] Remove padlock icon from login link [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79964 (owner: 10Demon) [19:10:14] (03CR) 10Demon: [C: 032] Add some logging for weird redirected POSTs [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79965 (owner: 10Demon) [19:10:28] (03CR) 10Demon: [C: 032] New hook, UserRequiresHTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80038 (owner: 10Demon) [19:11:01] (03CR) 10Demon: [C: 032] Change secure login to use a user preference [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [19:13:20] (03CR) 10Demon: [C: 032] Remove padlock icon from login link [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79961 (owner: 10Demon) [19:13:40] (03CR) 10Demon: [C: 032] Add some logging for weird redirected POSTs [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79962 (owner: 10Demon) [19:13:50] (03CR) 10Demon: [C: 032] New hook, UserRequiresHTTPS [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80037 (owner: 10Demon) [19:15:45] ^d: what's the exact time of https change? [19:15:58] <^d> That's a good question. greg-g? [19:16:16] (03PS2) 10Ragesoss: Change course status "Passed" to "Previous" to avoid ambiguity about "passing" a course. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 [19:16:27] (03CR) 10Reedy: [C: 04-1] "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 (owner: 10Ragesoss) [19:16:27] liangent: 11am Pacific/18:00 UTC [19:16:44] liangent: is when the window starts, will be between then and 12noon/19:00 UTC [19:16:50] when the actual change takes place [19:16:59] ebernhardson: Use the createAndPromote.php maintenance script [19:17:44] Reedy: ahh, perfect. Thanks [19:17:51] greg-g: oh one day later? [19:18:08] I thought it's today [19:18:59] (03Merged) 10jenkins-bot: Change secure login to use a user preference [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79963 (owner: 10Demon) [19:19:39] will it break bots in any aspect? [19:19:54] or, should I just switch to https login now? [19:20:05] (03PS1) 10Umherirrender: Add data-sort-type=number to column on Special:Tags [core] - 10https://gerrit.wikimedia.org/r/80079 [19:20:11] ^d: ^ [19:20:29] <^d> Going ahead and moving to https would be fine. [19:20:44] liangent: nope, "Wednesday" in SF :) [19:20:46] (03Merged) 10jenkins-bot: Remove padlock icon from login link [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79964 (owner: 10Demon) [19:21:00] liangent: only if the bots can't handle https [19:21:28] (03CR) 10Matmarex: [C: 031] "This really should be fixed in tablesorter instead, but oh well. A +1 from me." [core] - 10https://gerrit.wikimedia.org/r/80079 (owner: 10Umherirrender) [19:21:35] greg-g: and redirects I guess? [19:21:40] yeah [19:21:58] redirects happening after POST need some care [19:22:03] but, csteipp thinks that if you use the API to login (for the bot) it won't be redirected to https [19:22:16] and I assume most bots POST to api login directly [19:22:22] (03Merged) 10jenkins-bot: Add some logging for weird redirected POSTs [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79965 (owner: 10Demon) [19:22:55] * greg-g shrugs [19:23:16] greg-g: so I guess leaving bots in http would save some resource? [19:23:40] and it's still secure enough if it runs in WMF cluster (labs / toolserver)? [19:24:07] (03Merged) 10jenkins-bot: New hook, UserRequiresHTTPS [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80038 (owner: 10Demon) [19:24:39] liangent: resources aren't too much of a concern, honestly. [19:25:26] (03Merged) 10jenkins-bot: Change secure login to use a user preference [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79960 (owner: 10Demon) [19:26:57] (03Merged) 10jenkins-bot: Remove padlock icon from login link [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79961 (owner: 10Demon) [19:28:05] (03CR) 10Ragesoss: "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 (owner: 10Ragesoss) [19:28:25] (03Merged) 10jenkins-bot: Add some logging for weird redirected POSTs [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79962 (owner: 10Demon) [19:29:50] (03Merged) 10jenkins-bot: New hook, UserRequiresHTTPS [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80037 (owner: 10Demon) [19:33:07] (03PS1) 10Mollywhite: Bug 52821: Provide link to the JSON page from navbar dropdowns. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 [19:33:32] what does Reply 'Done' mean in gerrit? [19:33:32] I had a look at my bot code and it was coded to always login at $wgCanonicalServer... [19:34:08] ragesoss: adding a reply with "done" as its content [19:34:26] liangent: thanks. [19:35:40] liangent: what's the difference between 'Publish Comments' and 'Publish and Submit'? [19:36:22] ragesoss: submit means submitting this change for merge [19:37:03] or you can just publish a +2 and jenkins-bot will come and submit it automatically (after testing) [19:37:09] liangent: so in the context of a reply to a comment, it means ' no really, despite the -1, I think this should be merged'? [19:37:44] I haven't tried -1 and submit yet :p [19:38:14] liangent: there haven't been any code changes since the original submission, so I was confused. [19:38:33] ragesoss: can you point me to the relevant change? [19:38:43] liangent: https://gerrit.wikimedia.org/r/#/c/80076/ [19:40:40] ragesoss: then I guess you still need to choose +2 to merge (but clicking the submit button shouldn't be required) [19:40:50] but self-merge is discouraged [19:41:08] liangent: I'm not going to self-merge ( I can't, anyway ) [19:41:28] I'm just trying to understand how to use gerrit right. [19:41:35] (03PS1) 10MarkTraceur: Put closures everywhere [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [19:43:11] (03PS1) 10Aaron Schulz: Fixed description validation regex [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80123 [19:43:21] anomie: ^ [19:45:02] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80124 [19:51:19] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80123 (owner: 10Aaron Schulz) [19:58:00] (03CR) 10Mattflaschen: [C: 032] "Looks good. Thanks for the fixes." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/79922 (owner: 10Raimond Spekking) [19:58:26] (03CR) 10Mattflaschen: [V: 032] Some consistency tweaks in preparation for adding extension to translatewiki.net [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/79922 (owner: 10Raimond Spekking) [20:05:17] (03PS2) 10Aaron Schulz: Fixed description validation regex [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80123 [20:06:12] (03PS2) 10MarkTraceur: Stop using mw.msg [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80058 [20:07:37] (03CR) 10Anomie: [C: 032] Fixed description validation regex [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80123 (owner: 10Aaron Schulz) [20:07:39] mwalker: Ping [20:07:40] (03PS1) 10Rahul21: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 [20:07:42] (03Merged) 10jenkins-bot: Fixed description validation regex [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80123 (owner: 10Aaron Schulz) [20:10:02] (03PS1) 10Anomie: Validate RSA key input [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80129 [20:10:27] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #142: FAILURE in 8 min 51 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/142/ [20:11:03] (03PS8) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [20:11:05] (03CR) 10jenkins-bot: [V: 04-1] WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 (owner: 10Rasel160) [20:12:10] hoo: so the complaint about AF errors is that they're not consistent with other error types. [20:15:06] werdna: I know that... [20:15:15] ah gotcha [20:15:22] but we agreed with the VE team that it's fine this way [20:15:47] hmm, so we have a few issues, with varying amounts of importance [20:15:52] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79991 (owner: 10Ori.livneh) [20:16:15] (03PS2) 10Ori.livneh: Post-edit confirmation: ensure consistent font-size across skins [core] - 10https://gerrit.wikimedia.org/r/79991 [20:16:27] 1/ Consistency with other types of error messages. Ideally we would use the standard API convention of { 'error' : { 'code' : X, 'info' : Y, … } } [20:16:55] 2/ Consistency of the error code within abusefilter. Currently we're sending the name of the message used to display warnings [20:17:12] we either didn't want that or it wasn't possible, can't remember, maybe the gerrit change has some history on that [20:18:17] which ranges from abusefilter-disallowed to Misbruikfilter-verboden depending on language and other things [20:18:23] (03PS2) 10Ragesoss: Fix course page history SQL error [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 [20:18:42] so it would be nice to have a consistent message and then to pass the specific error in a separate parameter [20:18:52] Yes, I thought about using the public filter description, but that's not consistent either [20:19:21] I would say error code: 'abusefilter-disallowed' OR perhaps some sort of indication of the action that's been taken [20:19:27] we should probably also pass an array of actions taken [20:20:17] Yes, that wasn't thought out to deep initially, but the VE team wanted it rather yesterday than today back then [20:20:41] nod, so am I going to break anything VE-related by fixing that? [20:20:59] (03CR) 10Swalling: [C: 032] "Tested and confirmed." [core] - 10https://gerrit.wikimedia.org/r/79991 (owner: 10Ori.livneh) [20:21:04] Exactly, you have to tell them and make them fix their code [20:21:14] and you have to coordinate the deploy [20:21:47] which part? the error code, where it is in the result, or elsewhere? [20:22:42] werdna: I don't know how they exactly invoke it, but they use the full reply to show user friendly error messages [20:24:08] nod [20:24:10] RoanKattouw? [20:25:02] Reading backscroll [20:25:24] hoo: in terms of embedding in 'edit' versus in 'error', the correct way to throw an error in the API is to throw an exception. [20:25:25] (03PS1) 10Aaron Schulz: Added a getLazyConnectionRef() function to load balancer [core] - 10https://gerrit.wikimedia.org/r/80130 [20:25:41] hoo: so I'll probably change it to do that [20:26:05] Throw a hook within the hook handler? [20:26:10] * an exception [20:26:21] probably add a custom exception class for an abusefilter hit [20:26:52] (03PS3) 10Ragesoss: Fix course page history SQL error [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 [20:27:07] yeah [20:29:32] Can't believe Groklaw is shutting down [20:29:39] (03CR) 10MaxSem: [C: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80124 (owner: 10MaxSem) [20:29:46] (03CR) 10Ragesoss: "Okay, I've changed it to the form I think you were suggesting, Reedy. (And it works locally for me.) Thanks!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/80076 (owner: 10Ragesoss) [20:31:32] werdna: So what's your specific question? [20:32:47] RoanKattouw: What assumptions does VE make about AbuseFilter API error messages? [20:33:04] Let's see herre [20:35:20] I think we assume that error.info, if present, will be human-readable [20:35:31] (03PS1) 10Brian Wolff: Make thumb.php give http redirects if given a file redirect. [core] - 10https://gerrit.wikimedia.org/r/80135 [20:35:49] The error display logic it ends up falling through to after covering all the cases we know about (which AF isn't one of), is: [20:35:51] document.createTextNode( data.error && ( data.error.info || data.error.code ) || 'Invalid error code' ), [20:36:03] RoanKattouw: I guess you have special case handling for AbuseFilter messages, which are under result.edit [20:37:19] Not really. If in the success callback we detect data.edit.result !== 'Success' we call the error callback with data.edit substituted for data [20:37:24] Or something [20:38:07] RoanKattouw: gotcha [20:38:26] so if I change it to a dieUsage() call with a sane value under info and warning, then there won't be any problem [20:39:04] It's /possible/ that we don't currently handle this well but that would be abug [20:39:15] 'this' being the result=Failure stuff [20:39:17] nod [20:39:22] But yeah if you use dieUsage() we'll be fine [20:39:28] well, I am going to throw a UsageException instead [20:39:28] :D [20:39:37] The 'info' field will be presented to the user [20:39:47] (03PS1) 10Bsitu: Tooltips in preference page get double-escaped [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80136 [20:40:04] Which is suboptimal but we haven't built better integration for this yet, and it's unfortunately not very extensible right now. It should be [20:40:06] RoanKattouw: as HTML or text? [20:40:17] We do have a special case for CAPTCHAs but that's because they're CAPTCHAs [20:40:18] As text [20:40:49] RoanKattouw: right, so it needs to be translatable, too. [20:41:07] oh jesus the AbuseFilter i18n file is enormous [20:41:23] You didn't yet see Wikibase's ... [20:41:49] superm401: re Groklaw - I'm right there with you [20:42:25] Yeah [20:42:49] We should come up with some standardized-ish way to do API responses with localizable error messages, ideally [20:44:27] (03CR) 10Brian Wolff: [C: 032] "Sorry about the breakage. Looks fine to me" [core] - 10https://gerrit.wikimedia.org/r/79850 (owner: 10Reedy) [20:45:55] GorillaWarfare: pong [20:46:14] mwalker: Hey, did you get a minute to look over my replies to your comments? [20:46:29] I want to submit a new patchset, but I wanted to sort that out first [20:47:03] (03Merged) 10jenkins-bot: Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] - 10https://gerrit.wikimedia.org/r/79850 (owner: 10Reedy) [20:47:25] (03PS1) 10Werdna: Bring API error messages for AbuseFilter in line with standard API errors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 [20:47:28] hoo ^^ [20:48:10] (03CR) 10Mwalker: "(3 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [20:48:19] (03CR) 10Werdna: "Typical error message:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 (owner: 10Werdna) [20:48:25] GorillaWarfare: gotcha! I got halfway through and then got distracted [20:48:26] >.> [20:48:27] <.< [20:48:56] Just got the email [20:48:57] Thanks :) [20:50:16] werdna: Looks good on first sight [20:50:23] :) [20:51:14] Why don't we run jshint for AbuseFilter, btw? :P [20:51:44] heh, let's not :P [20:51:58] AbuseFilter JS was written before MediaWiki had jQuery [20:52:04] and also before I had a clue how to write JS [20:52:06] werdna: I've fixed all of them and added a .jshintrc so it should pass [20:52:17] nice! [21:00:25] (03PS20) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:01:19] (03PS21) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:01:32] GorillaWarfare is making me feel like she does more work than me, and I'm full time at the moment. [21:01:40] :) [21:02:04] :) [21:02:12] sumanah: Thanks for introducing me and my current working area on wikitech-l :) [21:02:20] hoo: glad I could! [21:02:25] you can follow up there if you want, of course [21:02:38] (03CR) 10Subramanya Sastry: "ping .. is this still relevant? rebase/upload or abandon?" [core] - 10https://gerrit.wikimedia.org/r/57690 (owner: 10Cscott) [21:02:44] (03PS22) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [21:03:55] sumanah: I guess I'll do that later or tomorrow... do you have anyone in mind who I could also get into code review? I don't want all these changes pile up in gerrit [21:04:21] (03PS1) 10Mwjames: Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [21:04:36] I already got the DJ and of course the WMDE people (although most of them don't have +2 on core) [21:05:50] (03CR) 10jenkins-bot: [V: 04-1] Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 (owner: 10Mwjames) [21:05:57] |- [21:06:07] Oops [21:06:09] hoo: thedj and MatmaRex? [21:06:43] I can try to add MatmaRex to the changes I haven't yet added him on... bad thing I can't duplicate myself for CR :D [21:06:49] i've merged a few accessibility patches already and commited one or two [21:06:55] but actually, i think none of hoo's [21:07:13] adding you just now :) [21:07:31] the ones i saw appeared non-trivial and i don';t have the software to test :) [21:07:35] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80140 [21:07:51] (03CR) 10MaxSem: [C: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80140 (owner: 10MaxSem) [21:07:58] (03CR) 10MaxSem: [V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80140 (owner: 10MaxSem) [21:08:03] Yes, screen reader testing is a bit awry if you're not into it [21:08:36] maybe some of the wikipedians would be willing to test [21:08:40] MatmaRex: But you could have a look at https://gerrit.wikimedia.org/r/79847 which is entirely not screen reader related [21:09:04] bawolff: I guess they would, but I don't think they're able to set up an MW and fetch the changes :/ [21:09:25] hmm, good point [21:10:09] Maybe I should set up a semi-public wiki(s) and mail it to some known and trusted screen reader users [21:10:10] we should have a service that would create wikis with given change deployed [21:10:11] I guess someone could set up a wiki for it, and then they could coordinate with someone who has +2, so they test it sounds good with a screen reader, and the +2 person checks everything else about the code [21:10:24] That'd be cool [21:10:32] (03PS4) 10Rachel99: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 [21:10:34] hoo: hmm, looking at thecss there [21:10:46] different browsers use different focus outline styles [21:11:10] Yes :( But I don't think we can really emulate that reliable, can we? [21:11:24] yeah [21:11:35] why are we actually emulating that? D: [21:11:38] * MatmaRex reads thepatch [21:11:38] That one looked good even in IE if I recall it right [21:11:55] "Also made it appear to have focus (while only the small invisible inline link has focus)." [21:12:00] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80141 [21:12:22] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80141 (owner: 10MaxSem) [21:12:28] also, i'm not sure if faking focus is a good idea, might be misleading [21:12:39] e.g. for keyboard navigation [21:12:51] if the "actual" focus is elsewhere than thevisible one, arrow keys might behave unexpectedly [21:12:52] Well, I did it for keyboard navigation [21:13:07] the behave as you expect them to do AFAIR [21:13:25] but that's a good point [21:13:30] couldn't have have that link have width:100%; heoight: 100% or something like that? [21:13:50] or possibly, couldn't we unbreak the variants menu? [21:14:01] i vaguely recall it sucking supremely [21:14:54] (03CR) 10Brian Wolff: [C: 04-1] "Half the things you added had the variable type before the variable name, the other half you added it after." [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 (owner: 10Reedy) [21:15:20] what exactly do you mean? [21:15:52] hm, i even messed with it some time ago [21:16:41] well, for one, it currently has two h3s [21:16:44] mh, the point is, that it should be usable by keyboard and the user always has to know where the focus is [21:16:58] Yes, that made stuff hard here [21:17:04] (03CR) 10GWicke: [C: 031] "Looks pretty harmless. The // comment style change might be the most controversial, as single-line comments in Parser.php (and most of cor" [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [21:18:57] (03CR) 10Nemo bis: "On who can decide, I've asked the LangCom whether it's them" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [21:19:09] there's gotta be a way to do this more nicely [21:19:14] mh [21:19:18] but it's late and i'm all outta ideas right now [21:20:12] I guess I could convert it to use a single

[21:20:19] but the focus thing remains [21:20:33] that's also broken for the other menus like the one with history, protect, ... [21:23:04] hoo: actually, what's the focus issue? it looks good for me on Opera 12 [21:23:05] (03PS2) 10Mwjames: Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [21:23:19] wheni focus the arrow using keyboard navigaiton [21:23:46] (another case of opera being smarter than other browsers?) [21:24:02] MatmaRex: Is Opera 12 still Presto or already Blink/ WebKit? [21:24:07] 12 is presto [21:24:12] 15+ is blink [21:24:22] ah ok [21:24:33] I killed my Opera install after they moved over [21:24:33] (03CR) 10jenkins-bot: [V: 04-1] Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 (owner: 10Mwjames) [21:24:53] i don't think blink provides keyboard navigation in any similar way [21:25:05] (shift+arrows, you can vosually focus anything clickable on page) [21:25:20] (even elements without tabindex and other accessibility attributes if they have click handlers) [21:25:28] visually* [21:26:26] MatmaRex: I want the focus to be outlined correctly if you just tab through the page [21:26:51] that works with any of the vector tabs but not for the expandable menus (in neither WebKit, Firefox or IE) [21:27:05] ^demon: Threw some reviewers on your cols/rows pref commit. [21:27:15] * Elsie tackles brion. [21:27:17] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Tooltips in preference page get double-escaped [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80136 (owner: 10Bsitu) [21:27:29] uh-oh :) [21:27:32] Elsie: what's up [21:27:40] hoo: but the arrow is not accessible by tabbing? [21:27:49] brion: Responded to you on wikitech-l. I agree about China being silly. But I'm not sure what the best solution is. [21:27:49] yeah [21:27:58] so, just add tabindex? [21:28:06] brion: I'm not sure we can just tell everyone to use HTTPS if HTTP currently works for them. [21:28:28] the inside spans the entire width and height of the arrow "button" [21:28:31] Elsie: yeah there's no "good" solution that "just works" unfortunately [21:28:33] MatmaRex: That would require adding more statehandler logic as we would have to listen to changes on the

or the
[21:28:38] probably the div, actually [21:28:59] if folks are willing to do http exceptions for ease of use at the expense of security, well… i think that's awful but i won't bitch any more than i already have :) [21:29:14] there is a legit complaint though that a lot of folks edit english wikipedia and other "non-local" projects [21:29:15] brion: Are there ridiculous ideas to be considered? Like overlaying a different login link that only loads from HTTPS? [21:29:20] so having exceptions only on some projects is…. sub-ideal [21:29:29] heh [21:29:40] "don't live in china" [21:29:45] hoo: wait, why? [21:29:54] doesn't help for a billion people, but ….. sorry guys :) [21:29:59] brion: I imagine many of our editors would be happy to leave. Can they stay with you? :-) [21:29:59] one of us is clearly missing something obvious, and i'm afraid that it might be me, heh [21:30:23] A little less than half a billion. Most people still don't use the Internet. ;-) [21:30:25] MatmaRex: Clicking on the
itself isn't going to expand the menus, I guess [21:30:42] <^demon> Elsie, brion: We do have a hook in the right place now, so we could make this more fine-grained eventually. [21:30:45] Elsie: if the redirect to force https is based on geoip instead of site language that might help, but …. that sounds like pain to implement [21:30:48] <^demon> When someone comes up with a sane way of doing that. [21:30:50] ^demon: yay [21:30:54] hoo: no, but you always click on the [21:30:54] https://en.wikipedia.org/wiki/List_of_countries_by_number_of_Internet_users [21:31:08] ^demon: In the meantime, we see activity on certain wikis plummet? :-/ [21:31:11] or no? [21:31:21] I'm still not sure of the exact impact here. [21:31:23] MatmaRex: Not If I've tabbed to the
(like you suggested) and press ented [21:31:26] * enter [21:31:30] But it seems potentially very bad for a few projects. [21:31:36] i'm suggesting tabbing to the [21:31:36] <^demon> Elsie: No, that's why certain wikis are exempted. [21:32:09] ^demon: Are you sure? [21:32:16] <^demon> zhwiki and so forth are, yes. [21:32:17] They'll hit login.wikimedia.org via HTTP? [21:32:52] Is there an exempt test wiki currently? [21:33:07] <^demon> All wikis that don't have it enabled? [21:33:10] hoo: ^ [21:33:26] <^demon> It's only enabled on test2 at the moment. [21:33:27] hoo: it appears to work as expected to me when i add the tabindex [21:33:27] ^demon: I mean before this goes live tomorrow, it'd be nice to test the config. [21:33:27] MatmaRex: And then? How should we show the proper focus? [21:33:27] so i believe the theory is that they'll hit login.wikimedia.org on HTTPS (which … we think is not blocked?) and then get redirected back to e.g. en.wikipedia.org on HTTP, with an authentication token [21:33:33] ^demon: is that correct or am i wrong again :D [21:33:49] well not en. but zh. or whatever that is exempt [21:34:08] HTTP zh.wikipedia.org --> HTTPS login.wikimedia.org --> HTTP zh.wikipedia.org [21:34:12] We think that's gonna work? [21:34:28] <^demon> Elsie: The config is live already? Only thing we're changing tomorrow is setting default => true for wgSecureLogin, with the exempted wikis set to false. [21:34:32] hoo: wait. which dropdown are wa talking about? [21:34:33] <^demon> loginwiki is already true. [21:34:38] MatmaRex: Any of them [21:34:44] hoo: i see nothing wrong with how the "regular" right-side one behaves currently [21:34:48] apart from lack of tabindex [21:34:53] the focus is shown nicely [21:34:57] Really? [21:35:00] ^demon: All right. [21:35:00] encompassing the entire button [21:35:02] yep [21:35:02] In which browser? [21:35:05] opera 12 [21:35:18] i'll get a screenshot [21:36:29] While I really like (or used to like) Opera (my favorite non-open browser) I don't think we should consider it an important test platform... what market share does it have? 2.5%? [21:36:46] depends on the country, up to ~20% in some ;) [21:36:49] mh [21:36:59] Still appears broken in all the browsers I have [21:37:03] hoo: can i get a screenshot of current behavior from something? [21:37:20] on opera, it looks like this: http://i.imgur.com/MagyGem.png [21:37:23] MatmaRex: Could you test it in any browser that isn't opera? [21:37:32] ok i gotta get lunch and then assemble furniture at the house… i'll check in on irc in ~an hour if folks need me for anything [21:37:41] MatmaRex: Is that outline by Opera? [21:37:44] yeah [21:37:47] wow [21:38:10] (03PS2) 10Mattflaschen: Added Upload API support ( WIP ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80128 (owner: 10Rahul21) [21:41:56] MatmaRex: So...? Should I try to change the DOM structure of these? [21:42:00] hoo: http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm and http://stats.wikimedia.org/wikimedia/squids/SquidReportCountryBrowser.htm [21:42:30] my 2.5% weren't very wrong, then [21:42:46] but still, we should at least consider other browsers, I guess :D [21:44:16] hoo: one sec, i was distracted [21:44:49] (03CR) 10Aaron Schulz: "Seems to work for PEM format. Maybe the messages could be clarified about that requirement?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80129 (owner: 10Anomie) [21:44:54] hoo: actually, i have to disappear for [21:44:58] ~15 minutes, brb [21:45:06] Well, I have to go to bed :P [21:45:27] MatmaRex: Could you maybe add any further things to the gerrit change and -1 is as appropriate? [21:45:38] That would be great :) [21:45:43] dunno if -1 is appropriate [21:45:46] especially if it works [21:45:55] let's think about it tomorrow [21:45:56] good night :) [21:46:10] good night ;) [21:58:58] (03PS2) 10Liangent: Make FakeConverter more realistic [core] - 10https://gerrit.wikimedia.org/r/80011 [22:08:17] (03CR) 10Mwalker: [C: 031] "More correctly; I attached a screenshot to the bug which explains why I'm not +2'ing at this time. If you don't want to deal with it at th" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 (owner: 10Mollywhite) [22:18:30] (03PS6) 10Nemo bis: Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 [22:19:09] (03CR) 10Nemo bis: "(1 comment)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [22:20:05] (03PS3) 10Mwjames: Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [22:20:06] (03CR) 10Spage: [C: 04-1] "(3 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79549 (owner: 10AndyRussG) [22:20:29] (03PS4) 10Nemo bis: Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 [22:20:50] (03CR) 10Nemo bis: "(1 comment)" [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis) [22:24:51] GorillaWarfare: you there? [22:26:56] (03PS5) 10Nemo bis: Try to improve the wording of gender option [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [22:30:23] (03PS6) 10Nemo bis: Try to improve the wording of gender option [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [22:30:28] (03CR) 10Mwalker: [C: 031] "So the code looks good; I downloaded the patch and tried to test it but the editor didn't load. Is this something that's specific to my in" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [22:30:32] hi TimStarling [22:30:39] hi [22:30:44] (03CR) 10Nemo bis: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/30756 (owner: 10Amire80) [22:30:54] mwalker: I am [22:31:15] ah; re ^; does your JSON editor load on your local? [22:31:21] or is it just mine that's broken [22:31:22] TimStarling: vague question: how bad would a one-time insertion of, say, 500k user prefs into user_properties be? [22:31:35] not very bad [22:31:41] (asking with regards to Echo having separate configs) [22:31:44] ebernhardson: ^ [22:31:46] bsitu: ^ [22:31:46] did you see the bug I wrote about how we need to delete 30M rows from that table [22:31:47] :) [22:31:51] ? [22:31:56] glanced at it [22:32:13] so 500K doesn't sound very bad in that context [22:32:14] MatmaRex: ? [22:32:17] wow, i wouldn't have guessed 30M [22:32:31] (03PS1) 10Aaron Schulz: Make use of item-specific HTMLForm errors which already use styling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 [22:33:26] (03PS2) 10Nemo bis: Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 [22:33:47] (03CR) 10Aaron Schulz: [C: 032] Validate RSA key input [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80129 (owner: 10Anomie) [22:33:55] bsitu: ebernhardson: about switching the behavior of Echo's user prefs [22:34:26] assuming i understood TimStarling's reply correctly and asked the right question, it wouldn't be too bad :) [22:34:38] (03CR) 10Nemo bis: "Nikerabbit, a new wording needed to be uploaded. Tyler agreed with my second last proposal and it's not clear whether someone likes my las" [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [22:35:25] (03PS2) 10Aaron Schulz: Make use of item-specific HTMLForm errors which already use styling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 [22:35:51] MatmaRex: are you referring to running a maintenance script to insert non-default values for all existing users? [22:36:01] (03CR) 10Aaron Schulz: [C: 032] Fix mixed indenting - tabs to spaces [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79924 (owner: 10Reedy) [22:36:05] How long before a change to shared.css gets through all the browser caching on a Wikimedia site? [22:36:15] (03Merged) 10jenkins-bot: Fix mixed indenting - tabs to spaces [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79924 (owner: 10Reedy) [22:36:26] bsitu: if i understand, yes thats his proposal. Basically create the option not for all users, but just the "100k active editors" (i have no clue how to determine that in a maint script) [22:36:58] user_touched is probably a good metric if they are remotely active [22:37:44] bsitu: if we just do the 100k or so active editors (as listed in metrics meetings), then its perhaps 500k to 1M rows, vs the 30M tim reports on the current solution [22:37:45] bawolff: 5 minutes, assuming RL doesn't break for no reason [22:37:53] bsitu: yes [22:37:57] MatmaRex: Well its been a day [22:38:14] and people are still claiming they are not seeing the proper css for my change on commons [22:38:36] then RL clearly is broken for no reason. :P [22:38:36] (03PS2) 10Aaron Schulz: Minor updates to parameter documentation, return types and exceptions thrown [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79938 (owner: 10Reedy) [22:38:42] or something else does the caching [22:38:43] (03CR) 10Aaron Schulz: [C: 032] Minor updates to parameter documentation, return types and exceptions thrown [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79938 (owner: 10Reedy) [22:38:48] (03Merged) 10jenkins-bot: Minor updates to parameter documentation, return types and exceptions thrown [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79938 (owner: 10Reedy) [22:38:49] ISP, their browsers, … [22:39:12] bawolff: poke Krinkle|detached about it [22:39:27] bawolff: sometimes touching the files on the servahs fixes it, i've been told [22:39:33] I think its browser caching [22:40:05] stuff served by RL should have 5 minutes expiration time [22:40:08] i think. [22:40:14] (03PS1) 10Aaron Schulz: Mention required key format [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80153 [22:40:38] bawolff: https://bugzilla.wikimedia.org/show_bug.cgi?id=51766 [22:40:56] bawolff: this is about the last time this happened [22:41:27] (03PS1) 10Ori.livneh: Update to new schema revision; pre-load schema module [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80154 [22:43:49] (03CR) 10Ori.livneh: [C: 032] Update to new schema revision; pre-load schema module [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80154 (owner: 10Ori.livneh) [22:44:22] (03Merged) 10jenkins-bot: Update to new schema revision; pre-load schema module [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/80154 (owner: 10Ori.livneh) [22:46:31] (03CR) 10Spage: [C: 04-1] "(4 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 (owner: 10AndyRussG) [22:46:44] (03PS1) 10Ori.livneh: Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80155 [22:48:42] csteipp: is few bits on https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/OAuth,dashboards/default [22:48:47] *a few [22:49:37] (03PS3) 10Nemo bis: Add PLURAL support to push-tab-*-override [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 [22:49:47] (03CR) 10Ori.livneh: [C: 032] Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80155 (owner: 10Ori.livneh) [22:50:02] (03PS1) 10Ori.livneh: Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80156 [22:50:17] (03CR) 10Nemo bis: "(3 comments)" [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 (owner: 10Nemo bis) [22:50:20] (03CR) 10Ori.livneh: [C: 032] Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80156 (owner: 10Ori.livneh) [22:52:58] MatmaRex, ebernhardson: yeah, that sounds like a nice solution but requires running maint script on every wiki install. [22:53:00] (03Merged) 10jenkins-bot: Update CoreEvents to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80155 (owner: 10Ori.livneh) [22:53:43] bsitu: well, yeah, but doesn't wikimedia's setup have facilities to runnign scripts on multiple wikis in order? [22:53:48] for running* [22:54:30] also, admittedly idon't know how long that would take, but it can't be more than an hour even on the largest wikis, can it? [22:54:39] (and most are noticeably smaller than en.wp) [22:55:58] (03Merged) 10jenkins-bot: Update CoreEvents to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80156 (owner: 10Ori.livneh) [22:57:39] (03CR) 10Spage: "(1 comment)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79568 (owner: 10AndyRussG) [22:58:37] (03CR) 10Parent5446: [C: 032] Clean up Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [22:59:01] (03CR) 10Parent5446: [C: 031] Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 10Nemo bis) [23:01:21] (03Merged) 10jenkins-bot: Clean up Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [23:04:56] (03PS1) 10MarkAHershberger: (bug 50078) Allow a string other than '*' as condition for DatabaseBase::delete() [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80157 [23:08:10] (03PS4) 10Mwjames: Extend DI framework to support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [23:09:40] Yippie, build fixed! [23:09:40] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #143: FIXED in 7 min 57 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/143/ [23:13:49] (03PS1) 10Werdna: Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 [23:13:56] (03CR) 10jenkins-bot: [V: 04-1] Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 (owner: 10Werdna) [23:14:54] (03CR) 10MarkAHershberger: [C: 032 V: 032] "Checked and self-reviewing b/c it is a backport." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80157 (owner: 10MarkAHershberger) [23:16:07] (03PS2) 10Werdna: Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 [23:17:00] (03CR) 10jenkins-bot: [V: 04-1] Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 (owner: 10Werdna) [23:21:05] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80160 [23:22:58] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80161 [23:25:19] (03PS1) 10Bsitu: Add gender support to two i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80162 [23:26:02] (03CR) 10Catrope: [C: 032] Update VisualEditor to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80160 (owner: 10Catrope) [23:35:31] (03PS1) 10Aaron Schulz: Make sure the consumer is applicable to this wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80163 [23:46:12] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80161 (owner: 10Catrope) [23:47:57] (03PS3) 10Werdna: Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 [23:48:01] ugh, my PHPUnit is messed up. [23:48:04] (03CR) 10jenkins-bot: [V: 04-1] Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159 (owner: 10Werdna) [23:48:07] Easier just to use jenkins for testing :p [23:48:10] goddammit [23:55:04] (03PS4) 10Werdna: Work in Progress: Replace condition limit with a time limit. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80159