[00:45:27] (03CR) 10Tim Starling: [C: 032 V: 032] "Needs changelog update." [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/78156 (owner: 10Rillke) [04:55:28] Yippie, build fixed! [04:55:29] Project browsertests-en.wikipedia.org-linux-chrome build #260: FIXED in 3 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/260/ [05:02:55] Happy selenium-bot is adorable. It needs only modern ascii, to be superadorable. ʕ•͡ᴗ•ʔ [05:04:24] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #119: FAILURE in 5 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/119/ [05:14:42] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #207: FAILURE in 6 min 21 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/207/ [05:20:27] (03CR) 10Legoktm: [C: 032] Throw an error on non-TextContent spamlists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79320 (owner: 10Legoktm) [05:20:33] (03Merged) 10jenkins-bot: Throw an error on non-TextContent spamlists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79320 (owner: 10Legoktm) [05:23:09] (03CR) 10Legoktm: [C: 032] Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [05:23:14] (03CR) 10jenkins-bot: [V: 04-1] Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [05:23:20] quiddity_: I think "modern ascii" is Unicode. [05:24:54] whoops, i meant to say "ascii art" (ymmv). But, unicode, ascii art, let's call the whole thing off! [05:26:45] as long as it's not an image file, and not more than 1 line high, emoticons are fine by me. [05:27:09] (03PS2) 10Shirayuki: Fix comments for grep [core] - 10https://gerrit.wikimedia.org/r/79333 [05:31:19] (03PS7) 10Legoktm: Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 [05:33:09] Elsie: Do you want to re-review ^ or should I just merge it? [05:35:39] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [05:35:44] (03Merged) 10jenkins-bot: Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [05:39:27] (03PS2) 10Legoktm: Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 [05:39:33] (03CR) 10jenkins-bot: [V: 04-1] Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 (owner: 10Legoktm) [05:43:07] (03PS3) 10Legoktm: Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 [05:56:02] (03PS4) 10Legoktm: Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 [05:56:45] (03CR) 10Legoktm: [C: 032] Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 (owner: 10Legoktm) [05:56:50] (03Merged) 10jenkins-bot: Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 (owner: 10Legoktm) [06:01:54] (03Abandoned) 10Santhosh: Add Chuvash keyboard layout [extensions/Narayam] - 10https://gerrit.wikimedia.org/r/55520 (owner: 10Mirontoli) [06:01:55] (03PS2) 10Tim Starling: Add a script for fast integration testing during scap [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/71318 [06:02:02] (03CR) 10Tim Starling: [C: 032] Add a script for fast integration testing during scap [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/71318 (owner: 10Tim Starling) [06:02:04] (03Merged) 10jenkins-bot: Add a script for fast integration testing during scap [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/71318 (owner: 10Tim Starling) [06:04:41] (03PS22) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [06:08:42] (03PS3) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [06:15:42] (03PS1) 10Legoktm: Check in both userspace and usertalkspace if the user exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79756 [06:16:11] (03CR) 10Legoktm: [C: 032] Check in both userspace and usertalkspace if the user exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79756 (owner: 10Legoktm) [06:16:16] (03Merged) 10jenkins-bot: Check in both userspace and usertalkspace if the user exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79756 (owner: 10Legoktm) [07:21:27] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [07:23:44] (03CR) 10Mormegil: "Unfortunately, this does not work in Czech. In “wait $1 before trying again”, the time specification needs to be in accusative case, while" [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [07:57:07] (03CR) 10Nikerabbit: [C: 032] Followup Ifb005e7c: some cleanup in comments. [core] - 10https://gerrit.wikimedia.org/r/79063 (owner: 10Liangent) [07:58:20] (03CR) 10Nikerabbit: [C: 032] Fix comments for grep [core] - 10https://gerrit.wikimedia.org/r/79333 (owner: 10Shirayuki) [08:00:35] (03Merged) 10jenkins-bot: Followup Ifb005e7c: some cleanup in comments. [core] - 10https://gerrit.wikimedia.org/r/79063 (owner: 10Liangent) [08:02:08] (03Merged) 10jenkins-bot: Fix comments for grep [core] - 10https://gerrit.wikimedia.org/r/79333 (owner: 10Shirayuki) [08:15:29] (03CR) 10Nikerabbit: "Can you file a new bug so that we do not forget to fix this in the long term?" [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [08:30:42] (03CR) 10TheDJ: [C: 04-1] "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [08:32:23] (03CR) 10TheDJ: [C: 04-1] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 (owner: 10Rtdwivedi) [08:39:55] (03PS19) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [08:39:56] (03PS23) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [08:39:57] (03PS27) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [08:58:31] (03PS1) 10Luis Felipe Schenone: First commit [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79760 [09:00:45] (03PS1) 10MaxSem: Disable slow list=allusers&auactiveusers query in miser mode [core] - 10https://gerrit.wikimedia.org/r/79761 [09:01:56] (03PS2) 10MaxSem: Disable slow list=allusers&auactiveusers query in miser mode [core] - 10https://gerrit.wikimedia.org/r/79761 [09:16:10] (03PS2) 10Luis Felipe Schenone: Submitting the basic extension files [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79760 [09:17:30] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "Double checked that it works and that there are no (obvious) syntax mistakes." [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79760 (owner: 10Luis Felipe Schenone) [09:25:24] thedj: Here? [09:43:16] (03CR) 10Nikerabbit: "(1 comment)" [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/79760 (owner: 10Luis Felipe Schenone) [09:44:38] (03CR) 10Hoo man: "Maybe we could should also use http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed ? We certainly need external help for prop" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [10:01:39] (03PS2) 10Hoo man: Make edit toolbar accessible to screen readers [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 [10:02:25] (03CR) 10Hoo man: "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [10:03:37] (03CR) 10Hoo man: "Fixed the typo found by TheDJ and added aria-pressed to the expand buttons." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [10:18:34] (03PS3) 10Hoo man: Make edit toolbar accessible to screen readers [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 [10:19:04] (03CR) 10Hoo man: "Fixed aria-pressed behaviour and added a work around for NVDA." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [10:47:50] (03Abandoned) 10J: (bug 46650) increase memory limit for frame extraction [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/63418 (owner: 10J) [10:58:25] (03CR) 10J: "Ok, need to update TMH in that case so it extends the headers." [core] - 10https://gerrit.wikimedia.org/r/51894 (owner: 10Parent5446) [11:01:53] (03CR) 10Nemo bis: "Mormegil, I don't think this is a problem of this specific message: if you can't add a GRAMMAR rule for time durations (is this the bug Ni" [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [11:06:11] (03CR) 10J: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/51894 (owner: 10Parent5446) [11:39:06] (03PS5) 10Matmarex: Fire Echo event when revision is rejected [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 (owner: 10Alex Monk) [11:39:09] @notify bsitu [11:39:09] I'll let you know when I see bsitu around here [11:39:11] (03PS1) 10Matmarex: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 [11:41:07] (03CR) 10Matmarex: [C: 031] "Linked the bug. Works and looks good to me." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 (owner: 10Alex Monk) [11:47:33] is fabrice florin ever on irc? [11:48:27] during office hours, i think [11:51:41] http://meta.wikimedia.org/wiki/IRC_office_hours#Upcoming_office_hours [11:52:44] thanks ori-l [11:53:05] meh, i'll just mail him, i need him *now* ;) [11:59:35] @notify ^d [11:59:35] I'll let you know when I see ^d around here [11:59:37] @notify ^demon [11:59:37] I'll let you know when I see ^demon around here [11:59:53] @notify qchris [11:59:53] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [12:00:27] MatmaRex: Hi. What's up? [12:00:36] oh, hi qchris [12:00:52] qchris: tell me, is https://gerrit.wikimedia.org/r/#/q/e96f6e56034ebd3776e83add68c4540e1f286758,n,z a draft change? [12:00:52] * qchris checks if gerrit is up. [12:01:28] qchris: because knowing its sha1, i can view it on gitblit. https://git.wikimedia.org/commit/mediawiki%2Fcore.git/e96f6e56034ebd3776e83add68c4540e1f286758 i don't think that's supposed to work. [12:01:56] Draft changes are not really hidden. [12:02:01] So that's a known problem. [12:02:13] Upstream does not care. [12:02:19] They say drafts are broken. [12:02:23] Drafts are a mess :-( [12:02:33] We have some local fixes for them: [12:02:35] yeah [12:02:42] well, just letting you know :) [12:02:58] Ok. [12:03:13] ^d knows about it. [12:03:23] And we've been discussing since several weeks. [12:03:33] There is even a security bug around it upstream. [12:03:45] Shawn said to redo drafts altogether. [12:03:55] But we do not know when that will happen [12:04:27] i think the feature should be dropped; it's fundamentally ill-conceived [12:04:36] And he does not accept fixes to better hide drafts: https://gerrit-review.googlesource.com/#/q/status:open+project:gerrit+branch:stable-2.7+topic:hide-drafts,n,z [12:05:03] ori-l: Yes, drafts suck. [12:05:28] Recently ^d thought about making drafts more visible. Maybe that would put them to better use. [12:05:37] but yeah, that kind of makes draft useless [12:05:42] if i can browse themanyway [12:05:46] Yes. [12:06:14] nice [12:06:14] I guess everybody agrees that they are just plain broken right now. [12:06:19] (https://git.wikimedia.org/branches/mediawiki%2Fcore.git , grep for "sandbox") [12:07:03] But there is little agreement on the direction. [12:07:34] git already facilitates a workflow that looks as code as a living document that is developed iteratively [12:07:44] and then gerrit patchsets add a layer on top of that [12:07:49] and then drafts add a layer on top of that [12:07:53] :-)) [12:08:25] maybe we should implement a feature for indicating that you're thinking about submitting a draft [12:08:43] i guess those are mw.org RFCs :P [12:09:48] :-) [12:16:35] I am writing on an identification key extension which looks like this: http://ec2-54-234-76-44.compute-1.amazonaws.com/ [12:17:16] I'd like it to become a mediawiki project; how can I get there? [12:17:58] The extension uses Wikibase, and in theory it could also extend wikidata.org. [12:50:10] (03PS2) 10Matmarex: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 [12:52:01] is there a way to filter commit history by path, on gitblit? [12:55:50] Nemo_bis: none i know of, but github can do that [12:55:51] https://github.com/wikimedia/mediawiki-core/commits/master/resources/ [12:58:47] thanks, I'll file a bug then [13:03:49] MatmaRex: actually I think it does :) https://git.wikimedia.org/history/mediawiki%2Fcore/HEAD/includes%2Fdb [13:04:10] tree -> select your path -> history [13:05:42] ah, nice [13:37:16] (03PS1) 10Nemo bis: Use login-throttled properly everywhere [core] - 10https://gerrit.wikimedia.org/r/79784 [13:55:55] (03CR) 10Grunny: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79784 (owner: 10Nemo bis) [14:17:36] (03PS1) 10Manybubbles: Tests for prefix search scoring. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79788 [14:24:04] (03PS1) 10Manybubbles: Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 [14:30:22] (03PS1) 10Mwjames: (Bug 53034) Handling redirects ($redirid == 0) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79790 [14:36:41] (03CR) 10Mwjames: "Writing a test for this change will be nearly impossible because SMW_SQLStore3_Writers is such as mess that any attempt to write a meaning" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79790 (owner: 10Mwjames) [14:39:53] (03PS3) 10Parent5446: Disable slow list=allusers&auactiveusers query in miser mode [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [14:50:46] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [14:53:28] (03PS1) 10Manybubbles: Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 [15:01:41] This is probably a better place to ask this. Is there a way to use htmlspecialchars to clean input with the exception of certain tags? [15:02:36] Specifically, I'm looking at the countdown extension, because the suggested alternative doesn't allow for hours, minutes, seconds, etc. My only problem with it is that input is not cleaned in any way. [15:05:48] (03PS1) 10Rachel99: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 [15:07:35] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79446 (owner: 10Reedy) [15:07:39] (03PS2) 10Manybubbles: Add some return type hints [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79446 (owner: 10Reedy) [15:07:48] (03CR) 10Manybubbles: [C: 032] Add some return type hints [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79446 (owner: 10Reedy) [15:07:51] (03Merged) 10jenkins-bot: Add some return type hints [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79446 (owner: 10Reedy) [15:15:37] (03PS1) 10Manybubbles: Fix suggestion tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79796 [15:17:10] Justin_ZW: you might want to useMediaWiki's Sanitizer class [15:17:29] !class Sanitizer [15:17:29] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classSanitizer.html [15:17:36] but i'm afraid it';s not exactly well-documented [15:17:57] Oh my god. There's a site with documentation for this stuff?! [15:25:42] Justin_ZW: it's autogenerated from comments in source code [15:25:54] Huh. [15:26:02] some classes are documented okay, most badly, some not at all [15:26:14] there's also often useful info on mw.org [15:26:17] !mw Sanitizer [15:26:17] https://www.mediawiki.org/wiki/Sanitizer [15:26:42] Oh, here's something you might be able to help with. http://pastebin.com/PaM4DVPz [15:26:43] well, not for this, i guess, but worth a shot ;) [15:27:01] This shows up when we preview uploads with a certain license template selected. [15:27:41] Looks like information on the preprocessor. But why is it suddenly showing up? [15:28:38] Justin_ZW: define "showing up"? [15:28:49] it's always there in page source, this is a html comment, so it shoudln't be visible [15:29:19] Ah, good. This is what a fellow administrator had told me: [15:29:22] Yo, Justin, could you preview a blank upload and tell me what the code in the HTML comments means? http://zeldawiki.org/Special:Upload [11:23:39 AM] Abdullah: "NewPP limit report" [11:23:58 AM] Abdullah: I'm sure it has something to do with transcluding the template, but none of the other transclusions have this [15:30:36] it should be appearing on all pages, i think [15:30:43] and is sometimes useful when you're really stretching thelimits of MW's parser [15:39:42] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [15:51:29] (03CR) 10Jeroen De Dauw: [C: 031] "Looks good. Want to think a bit more about this before I +2 though." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [16:04:20] (03PS1) 10CSteipp: Add OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79803 [16:05:51] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [16:20:03] (03PS1) 10CSteipp: Update CentralAuth to master - needed by OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79806 [16:20:37] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master - needed by OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79806 (owner: 10CSteipp) [16:24:17] (03Merged) 10jenkins-bot: Update CentralAuth to master - needed by OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79806 (owner: 10CSteipp) [16:28:21] (03PS1) 10Brian Wolff: Add MP4 to mime.types [core] - 10https://gerrit.wikimedia.org/r/79809 [16:40:39] (03CR) 10Cmcmahon: [C: 031] "This should turn my legacy search test green in beta labs" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [16:43:02] what timezone is bsitu in? [16:43:21] MatmaRex: He's in SF normally [16:43:26] I dunno if that applies now [16:45:03] hmph. is he a late sleeper? :P [16:45:19] some ppl start at 10am [16:56:03] (03CR) 10Demon: [C: 032] Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 (owner: 10Manybubbles) [16:56:05] (03CR) 10jenkins-bot: [V: 04-1] Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 (owner: 10Manybubbles) [16:59:31] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:04:52] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:08:20] (03CR) 10CSteipp: [C: 032] Add OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79803 (owner: 10CSteipp) [17:11:14] (03Merged) 10jenkins-bot: Add OAuth [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79803 (owner: 10CSteipp) [17:13:27] (03PS1) 10Yaron Koren: Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 [17:13:29] (03CR) 10jenkins-bot: [V: 04-1] Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 (owner: 10Yaron Koren) [17:22:40] aharoni: our uls_ime test seems to failing as of recently because of how the IME is triggered when clicking in an input [17:22:49] (03CR) 10Yaron Koren: [C: 032 V: 031] Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 (owner: 10Yaron Koren) [17:22:51] (03CR) 10jenkins-bot: [V: 04-1] Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 (owner: 10Yaron Koren) [17:23:17] (03PS11) 10Demon: Change secure login to use a user preference [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [17:23:31] (03PS1) 10Cscott: Optimize Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79822 [17:24:34] (03CR) 10Cscott: "@Parent5446: I applied your suggested optimizations in a separate patch (https://gerrit.wikimedia.org/r/79822) in an attempt to keep only " [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [17:25:58] (03CR) 10Cscott: "Ping! Can we get some review of this patch? I wanted to let a deployment train pass by so I didn't cram too many parser changes into one" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott) [17:26:35] (03CR) 10Demon: [C: 031] "So in addition to a rebase I redid the change to remove the forced groups bit. I do like the idea in principle, but that should be done as" [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [17:27:01] (03PS1) 10CSteipp: Adding OAuth and updating CentralAuth to work around scap [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79823 [17:28:20] (03CR) 10CSteipp: [C: 032] Adding OAuth and updating CentralAuth to work around scap [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79823 (owner: 10CSteipp) [17:31:13] (03Merged) 10jenkins-bot: Adding OAuth and updating CentralAuth to work around scap [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79823 (owner: 10CSteipp) [17:31:59] (03PS1) 10Aaron Schulz: Adding some missing messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79824 [17:33:13] (03PS1) 10Demon: Remove padlock icon from login link [core] - 10https://gerrit.wikimedia.org/r/79825 [17:34:28] (03PS1) 10Cmcmahon: jumps links pref no longer exists [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79826 [17:35:37] (03CR) 10Cmcmahon: [C: 032] "see Bug 53054" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79826 (owner: 10Cmcmahon) [17:37:10] (03PS1) 10CSteipp: Revert "Adding OAuth and updating CentralAuth to work around scap" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79828 [17:37:20] (03CR) 10CSteipp: [C: 032] Revert "Adding OAuth and updating CentralAuth to work around scap" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79828 (owner: 10CSteipp) [17:45:01] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [17:47:18] (03PS1) 10Jack Phoenix: SocialProfile: ResourceLoader & RequestContext love. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/79830 [17:47:36] (03PS1) 10CSteipp: Adding OAuth to wmf12, no CA update [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79831 [17:47:58] (03CR) 10CSteipp: [C: 032] Adding OAuth to wmf12, no CA update [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79831 (owner: 10CSteipp) [17:51:45] (03PS2) 10Rachel99: WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 [17:52:50] (03CR) 10Demon: [C: 032] Basic help for multi-process indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78834 (owner: 10Manybubbles) [17:52:53] (03Merged) 10jenkins-bot: Basic help for multi-process indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78834 (owner: 10Manybubbles) [17:53:00] (03Merged) 10jenkins-bot: Adding OAuth to wmf12, no CA update [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79831 (owner: 10CSteipp) [17:53:14] (03CR) 10Demon: [C: 032] Tests for prefix search scoring. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79788 (owner: 10Manybubbles) [17:53:37] (03CR) 10Demon: [C: 032] Fix suggestion tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79796 (owner: 10Manybubbles) [17:53:58] (03Merged) 10jenkins-bot: Tests for prefix search scoring. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79788 (owner: 10Manybubbles) [17:54:00] (03Merged) 10jenkins-bot: Fix suggestion tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79796 (owner: 10Manybubbles) [17:55:16] (03CR) 10Jdlrobson: [C: 031] "I'd +2 but I'm not sure what protocol is in Echo extension :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 (owner: 10Shirayuki) [17:56:45] (03CR) 10Demon: [C: 032] Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [17:56:46] (03CR) 10jenkins-bot: [V: 04-1] Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [17:59:09] (03PS2) 10Demon: Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 (owner: 10Manybubbles) [17:59:38] (03CR) 10GWicke: [C: 04-1] "Please make these tests PHP-only." [core] - 10https://gerrit.wikimedia.org/r/57538 (owner: 10Cscott) [18:03:56] (03CR) 10Demon: [C: 032] Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 (owner: 10Manybubbles) [18:03:59] (03Merged) 10jenkins-bot: Default to more accurate but slower search_type. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79791 (owner: 10Manybubbles) [18:07:25] (03PS2) 10Demon: Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [18:08:19] (03CR) 10Demon: [C: 032] Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [18:08:22] (03Merged) 10jenkins-bot: Return most relevent prefix search results. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79789 (owner: 10Manybubbles) [18:10:34] (03PS1) 10Demon: Updating Cirrus to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79834 [18:10:52] (03CR) 10Matmarex: "And?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 (owner: 10Matmarex) [18:11:25] aharoni: Around? I heard you got some input to give on accessibility [18:12:13] (03PS23) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [18:12:35] (03PS17) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [18:14:23] hmph, where is bsitu when i need him. [18:14:26] hi hoo [18:15:05] (03CR) 10Demon: [C: 032 V: 032] Add gsql format that returns result set as single Json object [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/79584 (owner: 10QChris) [18:15:07] accessibility? i can try [18:15:21] aharoni: In a nutshell, I'm working on accessibility on the Wikimedia sites for WMDE and I want your input on what I should be working on [18:15:26] ^d: \o/ [18:16:54] (03PS18) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [18:16:58] (03PS1) 10Yaron Koren: Fix for i18 editing error [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79835 [18:18:37] (03PS19) 10Mollywhite: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [18:19:34] (03CR) 10Parent5446: [C: 031] "Sounds good. Thanks Demon." [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [18:19:43] hoo: mmmm, i'm not that much of an expert. I developed a grammar module for a screen reader once, but I'm not really experienced with accessibility assessment. [18:19:58] (03CR) 10Parent5446: [C: 031] "I don't have an issue with this, but what's the motivation for removing the padlock?" [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [18:20:41] (03CR) 10Parent5446: [C: 031] "Reasonable enough." [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [18:20:54] (03CR) 10Demon: "People find it unattractive or something ;-)" [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [18:21:11] there are the usual things - alt for images, completeness of info in text-only mode, completeness of info without JavaScript, ability of full navigation with keyboard and no mouse etc., but you'll find all that if you just google for "usability guidelines" [18:21:28] (03CR) 10Parent5446: [C: 031] Optimize Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79822 (owner: 10Cscott) [18:21:41] I know about those... I just thought you might have something in mind which is important and should be done soon [18:21:54] (03CR) 10Parent5446: "Lol I though it might be something like that." [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [18:22:31] mwalker: Have you had a chance to look over the JSON editor patch? Sorry to keep changing it on you, haha... [18:22:50] no; not yet; it's on my task list for later today [18:22:51] (03CR) 10MZMcBride: "How much faster (just out of curiosity)?" [core] - 10https://gerrit.wikimedia.org/r/79822 (owner: 10Cscott) [18:22:58] mwalker: Alrighty, no problem! [18:24:23] (03CR) 10Cscott: "@MZMcBride good question. This was a suggestion by @Parent5446 on https://gerrit.wikimedia.org/r/79432 . Is there a standard way to meas" [core] - 10https://gerrit.wikimedia.org/r/79822 (owner: 10Cscott) [18:27:08] (03PS1) 10Rjain: Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 [18:27:55] (03Abandoned) 10Demon: Remove "stick HTTPS" option from login page [core] - 10https://gerrit.wikimedia.org/r/76823 (owner: 10Demon) [18:28:37] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Add/move full-stops [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 (owner: 10Shirayuki) [18:31:22] (03PS2) 10Himeshi: Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 [18:33:54] (03PS2) 10Himeshi: Added PageSchemas extension handling for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79556 [18:34:14] (03PS1) 10BryanDavis: Purge upstream caches when deleting file assets. [core] - 10https://gerrit.wikimedia.org/r/79842 [18:37:03] thedj: Around? [18:37:06] (03PS2) 10Jdlrobson: Allow filtering of notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 [18:38:48] (03CR) 10Rjain: "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [18:42:48] (03CR) 10Brian Wolff: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/79842 (owner: 10BryanDavis) [18:45:04] (03PS3) 10Cscott: Clean up Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79432 [18:45:05] (03PS2) 10Cscott: Optimize Parser::doQuotes(). [core] - 10https://gerrit.wikimedia.org/r/79822 [18:45:28] (03CR) 10Cscott: "Fixed an incorrect comment." [core] - 10https://gerrit.wikimedia.org/r/79432 (owner: 10Cscott) [18:45:30] (03Merged) 10jenkins-bot: Purge upstream caches when deleting file assets. [core] - 10https://gerrit.wikimedia.org/r/79842 (owner: 10BryanDavis) [18:45:45] (03PS1) 10BryanDavis: Purge upstream caches when deleting file assets. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79843 [18:46:00] (03CR) 10Cscott: "Rebased on a new version of change Iab2c2c8a565186eb7e7cf02ba6094f762a1b0a99" [core] - 10https://gerrit.wikimedia.org/r/79822 (owner: 10Cscott) [18:53:50] (03PS1) 10BryanDavis: Purge upstream caches when deleting file assets. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79844 [19:00:15] (03PS1) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [19:08:53] (03PS61) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [19:09:23] (03PS7) 10Wikinaut: Bug 44819, 44821, 47151 merged version [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78535 [19:09:35] (03PS4) 10Wikinaut: Bug 44821: OpenID Consumer wiki stalls with blank page [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78529 [19:09:38] (03PS5) 10Rjain: Added the db_patch files for renaming rev_id and user_id column [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 [19:11:43] (03PS4) 10Anomie: (bug 46713) Getting AFTv5 logs via API times out on English Wikipedia [core] - 10https://gerrit.wikimedia.org/r/59418 (owner: 10Matthias Mullie) [19:12:18] (03PS1) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 [19:13:08] (03CR) 10Anomie: [C: 04-2] "-2 until bug 49199 is fixed. Then it looks good to me." [core] - 10https://gerrit.wikimedia.org/r/59418 (owner: 10Matthias Mullie) [19:15:37] (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [19:17:38] (03CR) 10Anomie: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/79309 (owner: 10Legoktm) [19:18:10] (03Abandoned) 10Yaron Koren: Fix for i18 editing error [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79835 (owner: 10Yaron Koren) [19:18:59] (03PS2) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 [19:19:22] (03PS24) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [19:19:51] (03PS1) 10Rillke: Adding changelog entry for debain package [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/79849 [19:21:19] (03CR) 10Reedy: "https://bugzilla.wikimedia.org/show_bug.cgi?id=53065" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [19:22:32] (03CR) 10Rillke: "> Needs changelog update." [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/78156 (owner: 10Rillke) [19:22:58] (03CR) 10Mattflaschen: [C: 032] "Looks good, let's get started on upload." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [19:23:04] (03PS1) 10Reedy: Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] - 10https://gerrit.wikimedia.org/r/79850 [19:23:41] (03PS2) 10Reedy: Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] - 10https://gerrit.wikimedia.org/r/79850 [19:24:10] (03CR) 10Mattflaschen: [V: 032] Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [19:25:06] (03PS1) 10Reedy: Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79851 [19:25:22] (03PS1) 10Aaron Schulz: Added a few more trx sanity checks to DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/79852 [19:25:55] (03CR) 10Reedy: [C: 032] Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79851 (owner: 10Reedy) [19:27:25] (03PS2) 10Yaron Koren: Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 [19:29:58] (03CR) 10Yaron Koren: [C: 032 V: 031] Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 (owner: 10Yaron Koren) [19:30:02] (03Merged) 10jenkins-bot: Massive simplification of filter value display [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79820 (owner: 10Yaron Koren) [19:31:38] (03CR) 10Liangent: "Ah I see the difference now." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:31:50] (03Merged) 10jenkins-bot: Fatal error: Using $this when not in object context in SpecialUpload.php on line 686 [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79851 (owner: 10Reedy) [19:32:43] (03CR) 10Bsitu: [C: 032] ext.echo.special: Move #firstHeading styling from JS to CSS [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77569 (owner: 10Matmarex) [19:33:58] (03Merged) 10jenkins-bot: ext.echo.special: Move #firstHeading styling from JS to CSS [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77569 (owner: 10Matmarex) [19:34:59] (03CR) 10Hoo man: "There's no link in #mw-vector-current-variant so this change wont affect that element." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:36:07] hey, bsitu woke up [19:36:17] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [19:36:37] (03CR) 10Liangent: "Yeah but I guess it would be better make it work on #mw-vector-current-variant too." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:37:40] (03CR) 10Hoo man: "I'm tottaly not sure about that... that would basically mean that a user can tab into two elements with the exact same purpose which is co" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:38:32] (03CR) 10Liangent: "... as the menu appears when that h3 is hovered too, in addition to the down-arrow." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:39:44] (03CR) 10Bsitu: [C: 032] Do not offset the heading of Special:Notifications from the left [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 (owner: 10Matmarex) [19:40:54] (03CR) 10Hoo man: "Yes, but in those cases the user doesn't know that those are two elements, changing that over here would affect everyone using tab to go t" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:41:07] (03CR) 10Liangent: "#mw-vector-current-variant has nothing to get focused (and doesn't have a tabindex attr), so it won't be able to get tab'ed onto." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:41:41] (03CR) 10Hoo man: "Exactly and changing that would cause issues" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:41:45] (03CR) 10Liangent: "... but the onclick thing matters." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [19:42:06] hoo: [19:42:07] hi [19:42:08] (03PS1) 10MarkTraceur: Use $ instead of $j [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79910 [19:42:23] liangent: How should you perform a click without a mouseover? [19:42:48] hoo: touchscreen [19:42:54] eg. tablet [19:43:12] liangent: And that doesn't also trigger a mouseover? [19:43:18] have you tested that? [19:44:09] (03Merged) 10jenkins-bot: Do not offset the heading of Special:Notifications from the left [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 (owner: 10Matmarex) [19:45:35] (03CR) 10Parent5446: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [19:46:30] liangent: Works for me on Android (with zhwp) [19:47:14] Changing that would probably require much more complicated selection logic to make sure we don't get any side effects with extension, user added script or whatever [19:48:03] * scripts [19:48:23] (03CR) 10Anomie: [C: 04-1] "You're still not using the right sorting function. Check your output with format=jsonfm in particular." [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [19:48:23] liangent: ^ [19:52:18] (03PS1) 10Aaron Schulz: Made sanity code to prevent session use actually work. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79912 [19:52:27] (03PS2) 10Aaron Schulz: Made sanity code to prevent session use actually work. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79912 [19:53:19] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [19:54:02] (03CR) 10Hoo man: "hoo: liangent: How should you perform a click without a mouseover?" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [20:02:58] (03CR) 10Liangent: "Hmm it seems so (tested on an Android emulator too)" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [20:03:25] (03PS1) 10Yaron Koren: File existed only for backward compatibility, no longer needed. [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79913 [20:03:54] (03CR) 10Yaron Koren: [C: 032 V: 031] File existed only for backward compatibility, no longer needed. [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79913 (owner: 10Yaron Koren) [20:03:56] (03Merged) 10jenkins-bot: File existed only for backward compatibility, no longer needed. [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79913 (owner: 10Yaron Koren) [20:06:46] (03CR) 10Mattflaschen: [C: 032] "Looks good. MySQL tested thoroughly, SQLite reviewed but not tested (see bug 52893)." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [20:06:47] (03Merged) 10jenkins-bot: Added the db_patch files for renaming rev_id and user_id column [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [20:10:32] (03CR) 10Anomie: [C: 04-1] "(8 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [20:13:05] Yippie, build fixed! [20:13:06] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #120: FIXED in 4 min 14 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/120/ [20:16:05] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [20:16:18] (03PS1) 10BryanDavis: Release note update for bug 51604. [core] - 10https://gerrit.wikimedia.org/r/79914 [20:19:22] (03CR) 10Matmarex: [C: 04-1] "You linked different bugs in release notes and commit messag.e" [core] - 10https://gerrit.wikimedia.org/r/79914 (owner: 10BryanDavis) [20:20:34] (03CR) 10Parent5446: [C: 04-1] "(10 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [20:22:28] (03PS1) 10BryanDavis: Release note update for bug 51064. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/79915 [20:22:54] (03CR) 10Parent5446: [C: 031] "I don't really understand the OpenID extension code, but if this fixes the issues then it looks good." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78535 (owner: 10Wikinaut) [20:23:46] (03PS2) 10BryanDavis: Release note update for bug 51064. [core] - 10https://gerrit.wikimedia.org/r/79914 [20:26:36] Suppose a DB error occurs in production. Is there any reason Wikimedia would need users to be able to see the function name and SQL error code (e.g. to file a bug report)? [20:27:10] (03PS1) 10Cmcmahon: trigger IME properly [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79916 [20:27:18] (03PS3) 10Parent5446: Added useful headers in MediaHandler::getStreamHeaders. [core] - 10https://gerrit.wikimedia.org/r/51894 [20:28:08] (03CR) 10Cmcmahon: [C: 032] "Bug 53056" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79916 (owner: 10Cmcmahon) [20:28:41] (03CR) 10Hoo man: "I'm not into mobile development enough to tell what it exactly triggers but mobile shouldn't be a problem here." [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [20:30:10] (03CR) 10Anomie: [C: 031] "Looks sane, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/78815 (owner: 10Brian Wolff) [20:30:24] (03PS1) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 [20:30:40] (03PS1) 10BryanDavis: Release note update for bug 51064. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79918 [20:31:13] PleaseStand: Well if there was a syntax error, it would be mildly helpful, but I imagine people could find the sql error [20:31:34] PleaseStand: The main issue would be wanting to distinguish "Locks time out" sql errors from other errors [20:32:04] but really, the more info our users get, the more likely they can give a good bug report, and the faster the issue gets fixed [20:32:55] (03CR) 10Brian Wolff: [C: 031] Release note update for bug 51064. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/79918 (owner: 10BryanDavis) [20:34:17] (03CR) 10Brian Wolff: [C: 032] Release note update for bug 51064. [core] - 10https://gerrit.wikimedia.org/r/79914 (owner: 10BryanDavis) [20:34:28] I'm asking from a security and code complexity point of view. I'm revisiting a patch to hide the DB server hostname if $wgShowHostnames is false, and I wanted to know if I could just hide all details if $wgShowSQLErrors is false, though I don't have to. [20:34:49] Currently, on Wikimedia the actual query is hidden. [20:36:00] I don't know for sure about Wikimedia's requirements for security, but I think it can be useful to know which server in question [20:37:01] (03Merged) 10jenkins-bot: Release note update for bug 51064. [core] - 10https://gerrit.wikimedia.org/r/79914 (owner: 10BryanDavis) [20:37:41] We don't tend to use security through obscurity for these type of things [20:39:08] Now I suppose the question to ask is whether $wgShowHostnames = false should suppress the technical info entirely, or just the hostname (and a separate config variable added for the rest) [20:42:16] (03CR) 10Mattflaschen: "This is on http://annotator.wmflabs.org, including all the DB updates." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [20:46:11] (03CR) 10Brian Wolff: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [20:49:19] (03PS1) 10Reedy: When we create a new revision object, we should assign it to something [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79920 [20:49:31] ^d: ^ silly bug is silly [20:49:50] (03CR) 10Mattflaschen: [C: 04-1] "(6 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [20:52:01] (03PS3) 10Hoo man: Make variant selection menu toggleable by keyboard [core] - 10https://gerrit.wikimedia.org/r/79847 [20:52:17] (03CR) 10Parent5446: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [20:57:40] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [21:01:10] PleaseStand: I'm not sure which patch you're working on, but for non-wmf users, I think most of the sql details should be hidden if those options are turned off [21:01:18] (03CR) 10Manybubbles: [C: 032] "Much better than what we had!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79920 (owner: 10Reedy) [21:01:21] (03Merged) 10jenkins-bot: When we create a new revision object, we should assign it to something [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79920 (owner: 10Reedy) [21:04:06] (03CR) 10Wikinaut: "(10 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:06:37] csteipp: , which I am revisiting after having set it aside for a while. I want to know whether I should just show no error details whatsoever when $wgShowSQLErrors is false, or preserve the current behavior of only hiding the actual SQL query, but make it conditional on whether $wgShowHostnames is true. Or something in between? [21:09:18] (03PS1) 10Raimond Spekking: Some consistency tweaks in preparation for adding extension to translatewiki.net [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/79922 [21:12:40] (03PS1) 10EBernhardson (WMF): Repair edit-post API functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79923 [21:18:46] (03PS62) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:19:07] (03PS3) 10Hoo man: Use wfResetOutputBuffers in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74570 [21:19:12] (03CR) 10Hoo man: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74570 (owner: 10Hoo man) [21:20:20] (03CR) 10Hoo man: "Addressed Krinkle's comment on PS2 in the hope to get this merged. About the comment: Updating it makes some sense, but is totally not in " [core] - 10https://gerrit.wikimedia.org/r/74570 (owner: 10Hoo man) [21:20:43] (03CR) 10Alex Monk: [C: 032] Use $ instead of $j [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79910 (owner: 10MarkTraceur) [21:21:06] (03Merged) 10jenkins-bot: Use $ instead of $j [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79910 (owner: 10MarkTraceur) [21:21:07] Thanks Krenair! Threnair. [21:21:19] lol, what [21:25:07] (03PS1) 10Reedy: Fix mixed indenting - tabs to spaces [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79924 [21:27:24] csteipp: Did you get my message? [21:27:44] (03CR) 10Mdale: "Also tested a bit, I would note:" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [21:35:15] (03CR) 10Werdna: [C: 032 V: 032] Repair edit-post API functionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79923 (owner: 10EBernhardson (WMF)) [21:42:21] (03PS63) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:46:57] (03CR) 10Swalling: [C: 04-1] "Looking at http://toro.wmflabs.org/wiki/Special:UserLogin where this style is enabled, I'm inclined to say this needs iteration on the des" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [21:48:30] (03CR) 10Spage: [C: 04-1] "Works in regular mode, nice! Doesn't work in ?debug=1, I find 'mediawiki.debug' is in registered state not ready state; this module is on" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [21:49:40] (03CR) 10Wikinaut: "(5 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:53:02] (03PS64) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:54:27] (03CR) 10Wikinaut: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:54:48] bsitu: http://en.wikipedia.org/w/api.php?action=sitematrix [21:57:44] (03PS1) 10Reedy: parse_str returns void. Swap $_POST for 2nd parameter [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79934 [21:59:54] (03CR) 10Wikinaut: "this commit fixes many of the objections in PS61. Some were not fixed for reasons as mentioned in PS61." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [22:00:16] (03PS8) 10Wikinaut: Bug 44819, 44821, 47151 merged version [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/78535 [22:00:30] jdlrobson, do you need something from me today? I think I'll go to bed early for the first time in weeks [22:00:47] jgonera: 1s let me checj [22:01:01] jdlrobson, hm, wrong channel, but doesn't matter [22:01:42] werdna: did you get a chance to look at my comment on https://gerrit.wikimedia.org/r/#/c/79181/ ? [22:01:49] jgonera: so would be nice to get this one merged - https://gerrit.wikimedia.org/r/#/c/79167/1/javascripts/views/page.js - in respect to your comment yes but luckily talk pages should never get dynamically loaded unless it's the result of an edit. If I add a FIXME will you merge? [22:02:08] (03PS1) 10Yaron Koren: Various code and documentation improvements [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79937 [22:02:09] jgonera: i think we can live without the rest of the fixes [22:02:10] jdlrobson, ok, add a fixme and merge [22:02:26] thanks jgonera [22:02:56] (03PS2) 10Rillke: Return normalized file name on warning "exists-normalized" [core] - 10https://gerrit.wikimedia.org/r/78523 [22:03:08] legoktm: have seen it, haven't replied yet. I think I will tomorrow. [22:03:16] ok thanks [22:03:53] (03CR) 10Yaron Koren: [C: 032 V: 031] Various code and documentation improvements [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79937 (owner: 10Yaron Koren) [22:03:56] (03Merged) 10jenkins-bot: Various code and documentation improvements [extensions/SemanticDrilldown] - 10https://gerrit.wikimedia.org/r/79937 (owner: 10Yaron Koren) [22:04:46] (03PS1) 10Reedy: Minor updates to parameter documentation, return types and exceptions thrown [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79938 [22:09:05] (03CR) 10Wikinaut: [C: 031 V: 031] "looks good to me, and tested ok. Tyler, please can you read and reply to your points in PS61 - some were not fixed in my PS64 for the reas" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [22:09:53] Woah, 64 patchsets [22:10:38] (03CR) 10Demon: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79834 (owner: 10Demon) [22:11:04] Reedy: ? [22:11:12] oh right [22:11:15] never mind me [22:13:47] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79834 (owner: 10Demon) [22:17:10] (03CR) 10Rillke: "At least we must come to a solution as otherwise the clients die ignorant (German idiom)." [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [22:18:42] OAuth consumer access: (manage grants on behalf of this account) [22:19:06] shouldn't it be [22:19:09] OAuth consumer access: (Manage grants on behalf of this account) [22:19:19] based on surrounding text [22:20:02] https://www.mediawiki.org/wiki/Special:MWOAuthConsumerRegistration/propose [22:20:07] You do not have permission to propose new OAuth consumers, for the following reason: [22:20:07] The action you have requested is limited to users in the group: emailconfirmed. [22:20:16] Email confirmation: Your email address was authenticated on 17 February 2012 at 15:10. [22:20:18] (03CR) 10CSteipp: [C: 031] parse_str returns void. Swap $_POST for 2nd parameter [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79934 (owner: 10Reedy) [22:21:40] (03PS1) 10Yaron Koren: Fix to not crash on deleted (?) pages [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/79939 [22:24:21] csteipp: What's the need for the emailconfirmed group? [22:25:11] (03PS1) 10Bsitu: Only last 20 entries shown for non-default timezone settings [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/79940 [22:25:14] (03PS1) 10Ori.livneh: Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 [22:27:48] (03CR) 10Yaron Koren: [C: 032 V: 031] Fix to not crash on deleted (?) pages [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/79939 (owner: 10Yaron Koren) [22:27:52] (03Merged) 10jenkins-bot: Fix to not crash on deleted (?) pages [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/79939 (owner: 10Yaron Koren) [22:28:33] * Reedy pokes around whilst still being confused [22:30:41] (03CR) 10CSteipp: [C: 031] "Concept looks good" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [22:32:24] (03CR) 10Greg Grossmeier: [C: 031] Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [22:33:38] (03PS1) 10Reedy: Capitalise Manage like is done for other messages on Special:Preferences [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79944 [22:37:51] (03PS1) 10Demon: Updating Cirrus to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79947 [22:37:58] (03CR) 10Demon: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79947 (owner: 10Demon) [22:38:03] (03CR) 10Greg Grossmeier: "I should add: If someone wants to +2 this, we can deploy during any LD, including today." [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [22:50:02] (03CR) 10Ori.livneh: "S merged the parent patch and he's also agreed to review this one. (Thanks, S!)" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [22:50:55] Reedy: For owners, we need to be able to get in touch with them (let them know they've been approved, etc), until we get better notifications plugged in [22:50:57] (03CR) 10Aaron Schulz: [C: 032 V: 032] Capitalise Manage like is done for other messages on Special:Preferences [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79944 (owner: 10Reedy) [22:52:30] csteipp: Might want renaming/naming better then... [22:52:37] ori-l: question on eventlogging -- what is the sample rate? [22:52:47] And MediaWiki:group-emailconfirmed and MediaWiki:group-oauthadmin should be created [22:54:09] mwalker: it varies by data collection job. most of them are sufficiently specific in scope that they don't need to be sampled at all [22:54:35] ori-l: I'm guessing this one is... it's the NavigationTiming event [22:56:04] that one is about 1:7,000. the code activates on one in 1 every 5,000 requests, but we log only on user agents that implement the NavigationTiming API, which is ~70% of global traffic according to http://caniuse.com/#feat=nav-timing [22:57:25] (03CR) 10Aaron Schulz: [C: 032 V: 032] parse_str returns void. Swap $_POST for 2nd parameter [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79934 (owner: 10Reedy) [22:57:46] !seen hoo [22:57:46] Did you mean @seen hoo? [22:57:50] @seen hoo [22:57:50] Krenair: Last time I saw hoo they were quitting the network with reason: Quit: Leaving. N/A at 8/19/2013 9:38:14 PM (1h19m35s ago) [23:00:07] (03PS1) 10Jdlrobson: Experimental: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 [23:00:28] (03CR) 10Jdlrobson: [C: 04-2] "Review welcome but note this is a draft." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:02:23] ori-l: awesome -- on a related note; is that something you set manually? [23:02:55] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:04:08] mwalker: yes; it's outside of EL proper. here's an example: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FNavigationTiming/c35e902db71a694a1772d89af1a48a1c964388b7/modules%2Fext.navigationTiming.js#L13 [23:04:11] (03CR) 10Swalling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:05:09] (03PS1) 10Brian Wolff: Add flac to mime.types and mime.info [core] - 10https://gerrit.wikimedia.org/r/79949 [23:05:20] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:05:24] ori-l: gotcha; so the JS self selects to sample [23:05:56] yep [23:06:03] (03CR) 10Mattflaschen: [C: 04-1] "In my opinion, this patch should be the one to remove the custom isolated styles (mediawiki.ui and anywhere else there's a one-off Helveti" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:06:06] any other way would not play nice with caching [23:10:27] (03CR) 10Mattflaschen: "To clarify, first paragraph is the reason for the -1." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:14:08] (03PS3) 10Jdlrobson: Experimental: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 [23:14:18] (03CR) 10Jdlrobson: [C: 04-2] Experimental: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:15:36] (03PS1) 10Reedy: action=edit API with section=new would fail if page didn't exist [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79950 [23:16:27] (03PS2) 10Reedy: action=edit API with section=new would fail if page didn't exist [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79950 [23:17:36] (03CR) 10Mattflaschen: "Also, it would be nice to include some free fonts (see https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Typography). It's not a" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:17:59] (03CR) 10Spage: [C: 04-1] "(1 comment)" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [23:20:16] (03CR) 10Ori.livneh: "(1 comment)" [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [23:24:08] (03PS2) 10Ori.livneh: Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 [23:24:43] (03PS3) 10Ori.livneh: Update for new event schema [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 [23:26:52] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [23:29:06] (03CR) 10Aaron Schulz: [C: 032] Remove padlock icon from login link [core] - 10https://gerrit.wikimedia.org/r/79825 (owner: 10Demon) [23:37:59] (03CR) 10Spage: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:38:38] gwicke: maryana is singing your praises. [23:39:18] (03CR) 10Legoktm: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/79309 (owner: 10Legoktm) [23:39:35] (03PS2) 10Legoktm: Add tests for API action=edit§ion=new [core] - 10https://gerrit.wikimedia.org/r/79309 [23:39:51] (03CR) 10Greg Grossmeier: [C: 031] "What I said before still applies. Let's try to get as much data as possible before Wednesday, so the sooner we deploy, the better." [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/79941 (owner: 10Ori.livneh) [23:43:22] ^d: welcome back :) [23:43:38] <^d> :) [23:48:24] (03PS1) 10Brian Wolff: Be stricter for file types where we don't know canonical extension [core] - 10https://gerrit.wikimedia.org/r/79954 [23:51:24] (03CR) 10BryanDavis: [C: 031] "Paired with Brian on this and watched him verify it locally." [core] - 10https://gerrit.wikimedia.org/r/79954 (owner: 10Brian Wolff) [23:52:44] ^d: added some comments a while ago [23:52:51] <^d> I saw [23:53:08] you may as well add the default value [23:54:11] <^d> Yeah, easily done. [23:56:37] (03PS5) 10Swalling: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [23:57:49] (03PS12) 10Demon: Change secure login to use a user preference [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446)