[00:48:35] (03PS1) 10Shirayuki: Add "taction" parameter [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 [01:01:19] (03PS2) 10Shirayuki: Add "taction" parameter [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/79548 [02:33:46] (03PS1) 10AndyRussG: Add getTourSpec to public API for mw.guidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79549 [06:20:37] (03CR) 10Legoktm: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [06:36:04] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79551 [07:10:09] (03PS2) 10Legoktm: [WIP] Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 [07:10:15] (03CR) 10jenkins-bot: [V: 04-1] Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [07:53:32] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/79552 [07:58:02] (03CR) 10Nikerabbit: [C: 032] Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 (owner: 10Nemo bis) [07:59:27] (03PS1) 10Himeshi: Added handling for page sections [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/79553 [08:00:47] (03Merged) 10jenkins-bot: Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 (owner: 10Nemo bis) [08:01:33] (03PS3) 10Nikerabbit: In login-throttled, specify how long you have to wait before logging in [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [08:01:53] (03CR) 10Nikerabbit: [C: 032] In login-throttled, specify how long you have to wait before logging in [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [08:06:28] (03Merged) 10jenkins-bot: In login-throttled, specify how long you have to wait before logging in [core] - 10https://gerrit.wikimedia.org/r/78649 (owner: 10Nemo bis) [08:10:25] (03PS1) 10AndyRussG: Added experimental uncacheable prop to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 [08:10:30] (03CR) 10jenkins-bot: [V: 04-1] Added experimental uncacheable prop to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 (owner: 10AndyRussG) [08:18:40] (03CR) 10AndyRussG: [C: 04-1] "Whoa, Jenkins, that's harsh!" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 (owner: 10AndyRussG) [08:19:36] (03PS1) 10Himeshi: Added PageSchemas extension handling for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79556 [08:28:16] (03PS2) 10AndyRussG: Added experimental uncacheable prop to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79555 [09:17:51] (03PS1) 10IAlex: Set modes back to 0644 to ImagePage.php and Resources.php [core] - 10https://gerrit.wikimedia.org/r/79558 [09:20:40] (03PS2) 10IAlex: Make msg method of DerivativeContext work properly. [core] - 10https://gerrit.wikimedia.org/r/78837 (owner: 10Brian Wolff) [09:20:45] (03CR) 10IAlex: [C: 032] Make msg method of DerivativeContext work properly. [core] - 10https://gerrit.wikimedia.org/r/78837 (owner: 10Brian Wolff) [09:25:11] (03Merged) 10jenkins-bot: Make msg method of DerivativeContext work properly. [core] - 10https://gerrit.wikimedia.org/r/78837 (owner: 10Brian Wolff) [09:25:44] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/79559 [09:26:55] (03PS2) 10IAlex: Commenting and doc fixes around the spam regexes [core] - 10https://gerrit.wikimedia.org/r/77552 (owner: 10Mattflaschen) [09:27:05] (03CR) 10IAlex: [C: 032] Commenting and doc fixes around the spam regexes [core] - 10https://gerrit.wikimedia.org/r/77552 (owner: 10Mattflaschen) [09:31:13] (03Merged) 10jenkins-bot: Commenting and doc fixes around the spam regexes [core] - 10https://gerrit.wikimedia.org/r/77552 (owner: 10Mattflaschen) [09:37:47] (03PS4) 10IAlex: Do not parse param of newsectionsummary on new section preview [core] - 10https://gerrit.wikimedia.org/r/73519 (owner: 10Umherirrender) [09:37:51] (03CR) 10IAlex: [C: 032] Do not parse param of newsectionsummary on new section preview [core] - 10https://gerrit.wikimedia.org/r/73519 (owner: 10Umherirrender) [09:42:15] (03Merged) 10jenkins-bot: Do not parse param of newsectionsummary on new section preview [core] - 10https://gerrit.wikimedia.org/r/73519 (owner: 10Umherirrender) [09:43:01] (03PS19) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [09:48:05] (03PS11) 10IAlex: Show message when user successfully changed password. [core] - 10https://gerrit.wikimedia.org/r/61748 (owner: 10Jiabao) [09:48:15] (03PS12) 10IAlex: Show message when user successfully changed password. [core] - 10https://gerrit.wikimedia.org/r/61748 (owner: 10Jiabao) [09:51:45] (03CR) 10IAlex: [C: 032] "- Added RELEASE-NOTES entry" [core] - 10https://gerrit.wikimedia.org/r/61748 (owner: 10Jiabao) [09:54:17] (03Merged) 10jenkins-bot: Show message when user successfully changed password. [core] - 10https://gerrit.wikimedia.org/r/61748 (owner: 10Jiabao) [10:14:01] Nemo_bis: hey, are you around and awake now? [10:26:07] (03PS1) 10IAlex: Add new HTMLForm::addHiddenFields() methods [core] - 10https://gerrit.wikimedia.org/r/79562 [11:44:15] (03CR) 10PleaseStand: "(16 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [11:44:42] (03PS2) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [11:45:06] (03CR) 10jenkins-bot: [V: 04-1] Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [11:47:17] (03PS3) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [11:47:53] (03CR) 10jenkins-bot: [V: 04-1] Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [11:50:21] (03PS4) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [11:55:46] (03CR) 10Hoo man: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [11:55:55] thedj: ^ ;) [12:02:32] (03PS3) 10Legoktm: Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 [12:02:50] (03CR) 10jenkins-bot: [V: 04-1] Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [12:05:04] (03CR) 10TheDJ: [C: 032] Set modes back to 0644 to ImagePage.php and Resources.php [core] - 10https://gerrit.wikimedia.org/r/79558 (owner: 10IAlex) [12:08:06] (03CR) 10Hoo man: "This looks good and produces valid HTML, but in my brief testing the screenreaders didn't seem to take anything from this data (at least N" [core] - 10https://gerrit.wikimedia.org/r/78961 (owner: 10TheDJ) [12:08:11] thedj: Around? ;) [12:08:39] grrr. jenkins says the test fails but it works locally :/ [12:09:24] (03PS4) 10Legoktm: Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 [12:09:31] (03CR) 10jenkins-bot: [V: 04-1] Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [12:10:23] does jenkins automatically use the latest master of core? [12:10:42] legoktm: It should, yes [12:11:03] and you should as well :P [12:11:32] i am! [12:12:33] I can't figure out why the function doesn't work now that the core bug was fixed [12:12:58] (03PS2) 10TheDJ: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 [12:13:22] (03CR) 10jenkins-bot: [V: 04-1] Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [12:13:53] (03PS3) 10TheDJ: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 [12:14:39] (03CR) 10TheDJ: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [12:16:02] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/79565 [12:16:41] hoo: did you ever get a chance to review https://gerrit.wikimedia.org/r/#/c/79309/ ? [12:17:43] (03CR) 10Legoktm: [C: 032] The "massmessage-account-blocked" message is no longer used. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79313 (owner: 10Legoktm) [12:17:49] (03Merged) 10jenkins-bot: The "massmessage-account-blocked" message is no longer used. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79313 (owner: 10Legoktm) [12:17:59] legoktm: Nope, currently working on accessibility a lot... [12:18:09] ah, ok [12:22:08] thedj: thedj[work]: Around? [12:24:11] (03PS5) 10Legoktm: Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 [12:25:08] (03CR) 10Legoktm: [C: 032] Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [12:25:13] (03Merged) 10jenkins-bot: Add tests for MassMessageJob::sendMessage and MassMessageJob::editPage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [12:25:46] (03PS1) 10Shirayuki: Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 [12:26:10] (03CR) 10Hoo man: [C: 031] "Looks good and works like a charm, but I still would like to see a way to make it clear to users (not only screenreader ones) that they ca" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [12:28:45] (03PS2) 10Shirayuki: Give grep a chance to find the usages [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79566 [12:30:27] hoo: now i am [12:30:39] :) [12:31:24] I've been doing some CR of your changes today... as always some questions on my side arose... [12:33:02] thedj: But I'd really like to talk with you about https://gerrit.wikimedia.org/r/79472 , did you yet see it? [12:33:44] i saw you made a patch, but i havent' read the patch yet. [12:34:25] thedj: Don't mess with the implementation yet, I only wonder about a proper short description for these links... [12:35:18] The "↑" links, I mean [12:36:25] you mean for the aria-label content ? [12:36:38] Exactly [12:37:29] the current version of the patch uses 'Jump up to citation invocation' which I'm not sure is ideal [12:38:15] "jump to use of citation". might get annoying with 15 uses.... [12:38:25] usage [12:39:03] Certainly, we have citations used more than 20 or even 30 times on a page... [12:39:36] Maybe we should exclude citations used multiple times... but still it needs to be descriptive AND shor [12:39:38] t [12:43:06] thedj: ^ [12:43:37] Maybe just "jump up" which is pretty much what the arrow displays? [12:43:47] (03CR) 10TheDJ: "It works rather well in VO. http://pbrd.co/17AMCnX" [core] - 10https://gerrit.wikimedia.org/r/78961 (owner: 10TheDJ) [12:44:41] hoo: yeah that would be a lot simpler [12:46:27] hoo: i think that if you look at it from top accessibility perspective. when it comes to groups, you would label the group surrounding the links as "jump to" and just read out the individual link as the numbers/letters that they are. [12:48:03] That sounds like a good idea, will do that in a few minutes... patching the extension was rather awry as it didn't seem to have gotten much love recently [12:51:33] (03PS1) 10AndyRussG: Added the bufferOffset property to guiders [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/79568 [12:54:42] (03CR) 10Hoo man: [C: 032] "Seems like NVDA isn't very good with interpreting this... but despite that I totally trust you that this is useful, while it certainly doe" [core] - 10https://gerrit.wikimedia.org/r/78961 (owner: 10TheDJ) [12:56:06] hoo: i trust you are keeping a log of the accessibility improvements ? [12:56:42] thedj: Yes and no... how well is your German? :P [12:57:29] (03Merged) 10jenkins-bot: Accessibility: Add aria-labelledby to the navigation landmarks [core] - 10https://gerrit.wikimedia.org/r/78961 (owner: 10TheDJ) [13:06:10] (03CR) 10TheDJ: "OK, the tabindex on the label doesn't work in Safari. I guess this is because it is reinterpreting the label+checkbox to be one control. I" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [13:06:20] (03CR) 10TheDJ: [C: 04-1] Implement agora-style checkboxes experimentally [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [13:06:34] hoo: good enough when it comes to reading [13:07:12] PMed you my internal chaos table to keep track of things [13:09:22] thedj: Or should we maybe use title for the cite change instead of aria-label [13:09:32] Should also work for the screenreaders [13:10:19] title= is often not read directly [13:10:39] depends on the screenreader and the configuration the user has it running on. [13:10:44] in [13:11:29] mh, maybe both? Although that then might be read twice in certain set ups?! [13:13:37] both is a bad idea i think. repitition is quite annoying. [13:14:31] i remember there were these tabels from tests that folks did with title=... [13:16:19] you could see it like this. aria-label is for 'inline' reading, it should say the same as the visual feedback. title for screenreaders is the same to hovering the link. Normally, you don't do it, unless you can't figure out what a link does. [13:17:36] but to make matters worse, it all starts behaving differently if your link is around and image :D [13:18:13] Yay :P [13:25:08] lol title :D [13:25:08] tl;dr [13:25:09] If you want to hide content from mobile and tablet users as well as assistive tech users and keyboard only users, use the title attribute. [13:27:50] :D [13:29:12] Jaws. It is possible to configure it to pick up the title attribute in a link, but it is not done by default. [13:31:10] thedj: Jaws isn't reading the aria-label if I put it on the surrounding , should I maybe just set if for the first links? Or is "Jump up" short enough for all links? [13:31:18] * first link [13:31:34] hoo: jaws 14 ? [13:31:54] Yep [13:32:50] If I follow the citation's [2] in the article it just reads the links [13:34:36] Well, in fact it does read nothing then, but you have to go on per hand [13:35:49] what if you try adding role=group as well ? [13:36:13] hoo: i suspect that it's because the span has contents. [13:39:41] that does the trick \o/ [13:41:34] cool. so we found a nice interesting jaws exception [13:43:25] (03PS8) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 [13:45:35] (03CR) 10Hoo man: "Revised to not overdo the amount of extra text read to screenreader users." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [13:58:10] (03CR) 10Hoo man: "Ok, so over here we're doing it like the author of that document likes it best or am I wrong? I'm not sure how to go on with this one and " [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [13:59:52] (03CR) 10TheDJ: "+1 in terms of functionality. Still not sure about the label text that we should use here. Jump back is probably better (think timeline, n" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [14:16:20] (03PS20) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [14:20:36] (03PS21) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [15:08:11] (03PS1) 10Matmarex: Adjust two new date formats for Polish (pl) [core] - 10https://gerrit.wikimedia.org/r/79579 [15:43:46] (03PS1) 10Mwjames: Add some docs [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79581 [15:48:59] (03PS2) 10Mwjames: Add some docs [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79581 [15:55:41] (03PS3) 10Mwjames: Add some docs [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79581 [15:58:55] (03CR) 10Mwjames: [C: 032] Add some docs [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79581 (owner: 10Mwjames) [15:59:07] hoo: yes, around the city :) [16:00:19] (03Merged) 10jenkins-bot: Add some docs [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79581 (owner: 10Mwjames) [16:00:35] Nemo_bis: heh :) The discussion about the Cite extension change is on Bugzilla now (https://bugzilla.wikimedia.org/show_bug.cgi?id=38141) [16:01:04] ok [16:01:10] will check it later [16:02:51] (03PS12) 10Mwjames: \SMW\SimpleDependencyBuilder + \SMW\DependencyInjector [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [16:09:39] (03PS5) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [16:13:03] (03PS1) 10QChris: Add gsql format that returns result set as single Json object [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/79584 [16:13:57] (03PS6) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [16:14:42] (03CR) 10QChris: "This patch has been merged upstream at:" [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/79584 (owner: 10QChris) [16:18:53] (03CR) 10MZMcBride: "Sweet. Thanks, Christian! :-)" [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/79584 (owner: 10QChris) [16:37:04] (03CR) 10Reedy: "I don't think anything is particularly blocking this other than maybe wanting it to be on the cluster first." [core] - 10https://gerrit.wikimedia.org/r/51675 (owner: 10Reedy) [16:37:10] (03PS22) 10Reedy: Add archive, externallinks PK [core] - 10https://gerrit.wikimedia.org/r/51675 [17:00:14] thedj: Still here? [17:01:57] was just about to close the laptop :D [17:02:09] :D [17:02:34] I'm currently revamping the WikiEditor edit toolbar... we have a lot of redundant title alt and whatever attributes there [17:03:01] eg. NVDA reads "link link link" for the add link button thing... (because it's a link and not role=button atm) [17:03:12] but then we still have link twice... [17:07:16] the problem is that this isn't an image... [17:07:18] it's a link [17:07:33] Yes, changed it to aria-label in my version now... [17:07:41] which already has a label. which we hide with css, which is currently interpreted by screen readers. [17:09:46] thedj: Mh [17:10:01] We could fully remove the embed text and use aria-label instead [17:10:50] we could even remove the link. it's not a link. [17:11:33] hoo: we have to remember people who disable image loading... [17:11:51] you need either alt or textcontent for that.... [17:13:16] difficult... [17:13:36] Yes... I can't even disable the image loading in Firefox anymore as it seems [17:14:03] at least I don't know how, meh [17:14:12] i'd almost say convert it to a proper img object with alt text, no labels. then put role=button on it. [17:14:33] thedj: That thing uses an image map as background with CSS [17:15:25] empty src is allowed isn't it ? [17:15:42] or