[00:09:24] (03PS1) 10Brian Wolff: Rename Special:RandomInCategory to Special:RandomPageInCategory [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 [00:25:44] (03CR) 10Ori.livneh: [C: 032] "Verified by inspecting the DOM on enwiki." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/78026 (owner: 10Mattflaschen) [00:25:49] (03Merged) 10jenkins-bot: Update VE section edit selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/78026 (owner: 10Mattflaschen) [00:31:14] (03CR) 10MarkTraceur: [C: 031] "Code looks OK at first pass, haven't tested (is there an example extension we could use?)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [00:31:40] marktraceur: Not yet [00:31:42] soon [00:31:46] KK [00:32:18] as a warning, this all might get stuck in review for a while, as its dependant on like 6 unmerged changes [00:33:08] Aha. [00:33:11] Fun times. [00:36:02] (03CR) 10MarkTraceur: [C: 032] New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [00:36:03] (03CR) 10MarkTraceur: [C: 032] [Goes with I33462a8] Support for new gallery. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/69455 (owner: 10Brian Wolff) [00:36:10] yay! [00:36:10] Kablammo [00:36:38] * marktraceur throws a full champagne bottle at the gerrit server [00:36:42] (03Merged) 10jenkins-bot: [Goes with I33462a8] Support for new gallery. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/69455 (owner: 10Brian Wolff) [00:37:59] Get your patches merged, GTFO [00:38:00] Yup [00:38:03] Wikimedia all right [00:38:41] (03Merged) 10jenkins-bot: New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [00:38:47] Sweeeet [00:38:52] Beta here we come. [00:44:29] (03CR) 10Swalling: "Just to comment on what Matt mentioned ("If we merge this, we should rewrite the current SASS/SCSS stuff mediawiki.ui) in LESS. I talked w" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [00:55:35] (03PS3) 10Werdna: edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 (owner: 10EBernhardson (WMF)) [00:55:46] \o/ [00:55:51] edit-post action done [01:01:47] (03CR) 10Werdna: [C: 04-2] "Already merged" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79023 (owner: 10EBernhardson (WMF)) [01:01:49] (03Abandoned) 10Werdna: Permalink to Comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79023 (owner: 10EBernhardson (WMF)) [01:10:06] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79164 (owner: 10Demon) [01:24:44] (03CR) 10Ori.livneh: [C: 04-1] "Tim suggested outputting both old & new formats; that WFM but I need to update the patch." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [01:24:59] (03PS4) 10Werdna: New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [01:25:00] (03PS4) 10Werdna: edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 (owner: 10EBernhardson (WMF)) [01:31:20] (03CR) 10Werdna: [C: 032 V: 032] "I can fix issues later, but this has so many changes that it should be merged now to avoid later merge conflicts." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [02:46:12] (03PS3) 10Fantasticfears: add a anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/74618 [02:46:23] (03Abandoned) 10Fantasticfears: add a anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/74618 (owner: 10Fantasticfears) [03:09:49] (03PS1) 10Fantasticfears: add a anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 [03:17:40] (03PS1) 10Shirayuki: Fix full-stop position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 [03:18:37] (03PS2) 10Shirayuki: Fix full-stop position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 [03:44:45] (03PS8) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [03:56:06] (03PS9) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [03:58:14] (03PS10) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [04:07:53] (03CR) 10Legoktm: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [04:08:07] (03PS4) 10Legoktm: Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 [04:43:48] (03PS1) 10Hiong3-eng5: OWD CSV [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/79176 [05:50:11] Krenair: ping. I'm running into LQT issues >.> [06:30:04] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [06:31:36] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79159 (owner: 10Miguel2706) [06:50:52] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [06:52:49] legoktm: or is LQT running into your issues? [06:53:08] Heheh [06:53:17] It's something to do with context, session data, and tokens [06:59:59] I'm pretty confused myself. [07:08:08] werdna: can I bug you with LQT questions? :) [07:08:25] not now, can you send me an email? [07:08:34] sure [07:08:46] it's midnight and I just got back from something, am kinda drunk and IRC just sort of logged itself in [07:08:51] oh, heh :P [07:08:57] you're in SF? [07:09:59] si [07:10:36] ah, cool [07:12:55] werdna: silly question, what's your email? :P [07:13:04] agarrett@wikimedia.org [07:14:06] thanks [07:20:27] Ha, I figured it out. [07:22:37] (03CR) 10Raimond Spekking: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [07:31:24] (03CR) 10PleaseStand: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [07:36:46] (03PS1) 10Legoktm: Use DerivativeRequest instead of FauxRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/79181 [07:47:06] (03PS2) 10Legoktm: If the page is using LiquidThreads, add a new thread [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 [07:48:17] (03CR) 10Legoktm: "Requires I7d5f42d3c465f262feb180fb60711872d9532c49 to be merged in LiquidThreads." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78781 (owner: 10Legoktm) [08:53:25] (03Abandoned) 10Matthias Mullie: Improve separation of ExternalStore related code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78836 (owner: 10Matthias Mullie) [09:03:24] (03PD1) 10Wikinaut: fixed: do not suppress rc-log-actions; added default option [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79185 [09:03:42] (03CR) 10Wikinaut: [C: 032 V: 032] fixed: do not suppress rc-log-actions; added default option [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79185 (owner: 10Wikinaut) [09:11:07] (03PS1) 10Wikinaut: renamed README.md to README [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79186 [09:11:34] (03CR) 10Wikinaut: [C: 032 V: 032] renamed README.md to README [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79186 (owner: 10Wikinaut) [09:13:36] (03PS1) 10Wikinaut: README [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79187 [09:13:59] (03CR) 10Wikinaut: [C: 032 V: 032] README [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79187 (owner: 10Wikinaut) [09:23:32] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [09:54:15] (03PS2) 10Rjain: Added the db_patch files for renaming rev_id and user_id column [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 [09:58:39] (03CR) 10Rjain: "When i run php maintenance/sqlite.php --check-syntax extensions/Annotator/sql/db_patches/patch-rev_id-rename.sqlite.sql in the mediawiki d" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [10:00:04] (03CR) 10Wikinaut: [C: 04-1] "Checked this with latest core, but unfortunately your version does not work for me, please check on your system." [core] - 10https://gerrit.wikimedia.org/r/48417 (owner: 10Parent5446) [10:02:44] (03CR) 10Matthias Mullie: [C: 031] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 (owner: 10EBernhardson (WMF)) [10:04:56] (03CR) 10Matthias Mullie: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [10:11:20] thedj: Around at any chance? [10:22:20] (03PS3) 10Hoo man: Add aria properties to TOC for accessibility [core] - 10https://gerrit.wikimedia.org/r/79053 [10:38:14] (03PS2) 10Fantasticfears: add a anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 [10:49:54] (03PS1) 10Yorg666: pierwsza zmiana [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/79195 [10:51:20] (03PS3) 10Liangent: add a anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [10:52:25] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [10:52:40] (03CR) 10Liangent: [C: 04-1] Add an anonymous function in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [11:01:36] @notify Reedy [11:01:36] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [11:02:37] (03PS2) 10Yorg666: pierwsza zmiana druga zmiana [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/79195 [11:03:23] hoo: semi [11:04:17] thedj[work]: Ok :P I'm currently loading JAWS to my secondary system as I got the feeling that NVDA isn't fully using the aria-* attributes [11:05:05] hoo: well all of aria is only recently really starting to work if you ask me. [11:05:40] it's been an extension to html5 since 2009, but only now i see browsers+screenreaders really starting to work with it. [11:06:14] also remember that any screenreader is dependant on the browser providing the aria info [11:06:23] I've now adopted the TOC change to match the example you gave me, but neither for the example nor my TOC NVDA gave any more information taken out of the aria-* attributes (only the role) [11:06:45] I used Firefox (latest) with NVDA (latest stable) [11:06:50] ok, well for me with jaws, it automatically starts reading the part that becomes 'opened' [11:07:17] thedj[work]: NVDA doesn't seem to do that until you force a refocus in JS [11:17:14] you should try looking at the differences in browser+screenreaders when it comes to linked images + alt + title attributes. you'll go crazy. [11:18:42] and then you have to think about integrating it in a 'sustainable' way into mediawiki, without breaking 10 extensions :D [11:21:59] hoo: i have to say, browsing with a screenreader on gives you a lot of respect for those who have to do it... [11:23:50] I'm already close that that now :P But I think the TOC patch works now \o/ [11:23:54] today i switched the mboxes to use role="presentation" so that they are no longer announced as a table. But you immediately notice: "wow, this should be a group and it should be labeled". [11:25:30] "Notice group: severity:speedy deletion. This article is nominated..... end group". that would be ideal. Now it's just: "This article is nominated... " immediately followed by the article contents. [11:26:26] but it used to be "table 3 columns 1 row. row 1 cell1. This article is nominated... end table" [11:26:59] which also switches the screenreaders to use table navigation mode [11:28:49] (03PS4) 10Fantasticfears: Sort namespace aliases by id in appendNamespaceAliases for pretty output [core] - 10https://gerrit.wikimedia.org/r/79173 [11:57:28] (03PS1) 10Shirayuki: Fix capitalization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79199 [13:59:00] (03PS1) 10Grunny: Add missing parameters to message call [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 [14:32:00] (03PS1) 10Jeroen De Dauw: Add to README [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79202 [14:32:02] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add to README [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79202 (owner: 10Jeroen De Dauw) [15:13:37] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79185 (owner: 10Wikinaut) [15:15:30] (03PS3) 10Rachel99: WIP continuing Headings test scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 [15:22:17] (03PS4) 10Mwjames: \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 [15:23:42] (03CR) 10jenkins-bot: [V: 04-1] \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames) [15:24:45] (03CR) 10Mwjames: "Same issue ..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames) [15:35:47] (03CR) 10Se4598: [C: 031] "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 (owner: 10Grunny) [15:42:22] (03CR) 10CSteipp: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [15:43:39] (03PS1) 10Mwjames: \SMW\HashObject, \SMW\HashArray, \SMW\ObjectDictionary [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79205 [15:47:25] @notify werdna [15:47:25] I'll let you know when I see werdna around here [15:51:35] cheater [15:51:43] (03PS4) 10Rachel99: WIP continuing Headings test scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 [15:55:03] (03CR) 10Cmcmahon: [C: 032] "Looks good, next steps coming up" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 (owner: 10Rachel99) [15:55:38] (03Abandoned) 10Cmcmahon: VE Headings test for paragraph heading scenario [qa/browsertests] - 10https://gerrit.wikimedia.org/r/77220 (owner: 10Rachel99) [16:01:49] (03CR) 10Parent5446: [C: 032] Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [16:03:54] (03PS2) 10Mwjames: \SMW\HashObject, \SMW\HashArray, \SMW\ObjectDictionary [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/79205 [16:04:43] (03Merged) 10jenkins-bot: Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [16:10:40] (03PS8) 10Parent5446: Make maintenance/userOptions.php subclass Maintenance [core] - 10https://gerrit.wikimedia.org/r/48417 [16:10:49] (03PS9) 10Parent5446: Make maintenance/userOptions.php subclass Maintenance [core] - 10https://gerrit.wikimedia.org/r/48417 [16:11:58] (03PS5) 10Mwjames: \SMW\Maintenance\RebuildConceptCache (rebuildConceptCache.php to replace SMW_conceptCache.php) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77493 [16:14:54] (03PD1) 10Wikinaut: added qqq msg description texts [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79206 [16:15:07] (03CR) 10Wikinaut: [C: 032 V: 032] added qqq msg description texts [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79206 (owner: 10Wikinaut) [16:15:53] (03CR) 10Wikinaut: "(1 comment)" [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79185 (owner: 10Wikinaut) [16:19:28] (03PD1) 10Wikinaut: added italics around a reference to "Display options" in rc preference tab [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79207 [16:19:37] (03CR) 10Wikinaut: [C: 032 V: 032] added italics around a reference to "Display options" in rc preference tab [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79207 (owner: 10Wikinaut) [16:21:25] (03CR) 10Wikinaut: "(1 comment)" [extensions/OnlyRecentRecentChanges] - 10https://gerrit.wikimedia.org/r/79185 (owner: 10Wikinaut) [16:22:13] (03CR) 10Parent5446: "@Wikinaut - the script works fine for me. Not sure why the DB isn't changing or why the output isn't correct." [core] - 10https://gerrit.wikimedia.org/r/48417 (owner: 10Parent5446) [16:26:19] (03CR) 10Wikinaut: [C: 04-1] "I have wikis which share a common core and maintenance code. This is why I need the --conf, and --dbpass and --dbname options." [core] - 10https://gerrit.wikimedia.org/r/48417 (owner: 10Parent5446) [16:31:29] (03CR) 10CSteipp: [C: 032 V: 032] Renamed mwoauthupdateconsumer => mwoauthupdateownconsumer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79166 (owner: 10Aaron Schulz) [16:33:21] !technews [16:33:21] https://meta.wikimedia.org/wiki/Tech/News/Latest [16:34:38] (03PS1) 10Aaron Schulz: Fixed wrong comments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79213 [16:35:05] Catchable fatal error: Argument 1 passed to ContextSource::setContext() must implement interface IContextSource, null given, called in E:\var\www\DevWiki\core\includes\specials\SpecialNewimages.php on line 121 and defined in E:\var\www\DevWiki\core\includes\context\ContextSource.php on line 56 [16:35:08] great NewFiles is broken [16:36:43] Aaron|home: there's a missing () there. [16:36:58] caused by https://gerrit.wikimedia.org/r/#/c/67885/ [16:37:01] Aaron|home: ^ [16:37:55] Aaron|home: i'll merge if you patch it :P [16:38:38] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [16:42:59] (03CR) 10CSteipp: [C: 032 V: 032] Fixed wrong comments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79213 (owner: 10Aaron Schulz) [16:47:13] (03PS2) 10Nemo bis: Rename Special:RandomInCategory to Special:RandomPageInCategory [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [16:54:30] (03CR) 10TheDJ: "I'm now in doubt if the example is actually good." [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [16:58:18] MaxSem: around? [16:58:25] yup [16:58:45] what's that regex you mentioned? [16:58:49] in bug 51753 [16:59:02] I wonder whether it's possible to change to to use a real pathrouter [16:59:16] s/change to/change it [16:59:32] ^http://(?:www\.(?=mediawiki))?((?:commons|species|meta|incubator|outreach|strategy|wikimania2012|wikimania2013)\.(?=wikimedia)|\w+\.(?!wikimedia|mediawiki)|(?=mediawiki|wikimediafoundation))(wikimedia|wikipedia|wiktionary|wikinews|wikisource|wikiquote|wikibooks|wikiversity|wikivoyage|mediawiki|wikimediafoundation)\. [16:59:42] have nice parsing:P [17:00:09] but no, you can't use routing here because redirection is done at Squid/Varnish level [17:00:41] oh [17:00:57] so why can't we redirect everything to .m.*? [17:01:30] because it's helluva undesireable with anything but page views [17:02:45] (03PS5) 10EBernhardson (WMF): edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 [17:02:54] MaxSem: then redirect everything other than /w/*? [17:04:17] that'll leave some weird exceptions like http://en.wikipedia.org/images/wikimedia-button.png [17:04:40] (03CR) 10EBernhardson (WMF): "When using wikitext headers (===Foo===) section edit links are generated, we need to turn those off." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 (owner: 10EBernhardson (WMF)) [17:06:20] MaxSem: ouch .. anyway the list is also configured at https://noc.wikimedia.org/conf/highlight.php?file=main.conf besides InitialiseSettings [17:06:35] ctrl+F for # Variant aliases [17:07:31] ebernhardson: Parser has an option to disable their generation [17:07:32] meh [17:07:41] IT sucks:P [17:08:00] MatmaRex: any idea what that option is? :) (i can go digging too) [17:08:30] ebernhardson: look at MessageCache#parse and #getParserOptions [17:08:42] MaxSem: (there're multiple matches there btw) [17:08:56] ebernhardson: it disables them for parsing messages, you probably want to do it in the same way [17:09:30] (i'm not copy-pasting the code because it's ugly java-stylecrap) [17:09:56] MatmaRex: ok thanks, i'll check it out [17:10:25] MaxSem: and https://bugzilla.wikimedia.org/show_bug.cgi?id=47305 was caused by unsync'ed configurations [17:10:58] hey, it's a bawolff [17:11:07] Hey [17:11:28] you broke special:newimages, good job! :D [17:11:48] Only on Beta, to his credit [17:11:49] Yeah, I was just reading my gerrit mail [17:11:59] Which was why we wanted to merge it yesterday as opposed to later :) [17:12:06] haha [17:12:08] of course something had to go wrong with that patch, it like never dies [17:12:16] you're gonna need a backport, though [17:12:48] oh, and that's a werdna [17:13:00] liangent, how urgent is this problem? I'd like to wait if possible until we switch fully to Varnish so that we don't have to do this fix in 2 places [17:13:02] Si [17:13:07] werdna: please tell me wth is valid_tag table for. (you added it.) [17:13:17] oh that's embarassing, the issue comes down to missing a (). [17:13:20] MatmaRex: a list of change tags that exist [17:13:31] it's only used for reading, never on writing,and is empty on all wikis i checked [17:13:38] for writing* [17:14:16] also, seriously, conflict markers [17:14:23] shouldn't one of those testing things caught that [17:14:31] MaxSem: not sure ... though I've never run into this bug myself [17:14:45] bawolff: Shouldn't one of those testing things catch _fatal errors_? [17:14:58] yeah, that to [17:16:14] bawolff: well, i suggested implementing a tool to fix merge conflicts in release notes [17:16:21] even implemented it, actually [17:19:28] (03PS5) 10EBernhardson (WMF): New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 [17:20:11] (03PS7) 10Wikinaut: add optional id parameter; make extension working in templates [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/76351 [17:21:46] (03PS3) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 [17:23:11] (03PS1) 10Brian Wolff: Follow-up I33462. Some stupid issues with gallery patch [core] - 10https://gerrit.wikimedia.org/r/79214 [17:24:03] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [17:24:18] (03PS1) 10Brian Wolff: Follow-up I33462. Some stupid issues with gallery patch [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79215 [17:25:17] (03CR) 10Rjain: "Let https://gerrit.wikimedia.org/r/#/c/78373/ be reviewed first, then i will make a .sqlite file for adding column here also." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [17:25:49] greg-g: Before 1.22wmf13 gets deployed to wikimedia wikis, its important that https://gerrit.wikimedia.org/r/#/c/79215/ as I did something stupid in my last patch [17:27:01] (03CR) 10Brian Wolff: "see follow-up https://gerrit.wikimedia.org/r/79214" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [17:27:02] (03CR) 10Reedy: [C: 032] Follow-up I33462. Some stupid issues with gallery patch [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79215 (owner: 10Brian Wolff) [17:27:04] Reedy: ^^^^^ re wmf13 [17:27:39] greg-g: 2 seconds late [17:27:40] :D [17:27:51] (03CR) 10MarkTraceur: [C: 031] "Want to let someone else spot-check, it would be a bit of a faux-pas for me to review this too :)" [core] - 10https://gerrit.wikimedia.org/r/79214 (owner: 10Brian Wolff) [17:27:57] fuuuuuuuuuuuu [17:28:01] :) [17:28:21] Reedy: Want to merge it in master too? [17:29:30] (03CR) 10Reedy: [C: 032] Follow-up I33462. Some stupid issues with gallery patch [core] - 10https://gerrit.wikimedia.org/r/79214 (owner: 10Brian Wolff) [17:29:43] thanks :) [17:30:02] Sweet. [17:30:22] (03Merged) 10jenkins-bot: Follow-up I33462. Some stupid issues with gallery patch [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79215 (owner: 10Brian Wolff) [17:31:31] (03CR) 10Umherirrender: "Was I326df820 before." [core] - 10https://gerrit.wikimedia.org/r/79173 (owner: 10Fantasticfears) [17:32:04] (03CR) 10Werdna: "Looks great." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/79181 (owner: 10Legoktm) [17:32:47] (03Merged) 10jenkins-bot: Follow-up I33462. Some stupid issues with gallery patch [core] - 10https://gerrit.wikimedia.org/r/79214 (owner: 10Brian Wolff) [17:33:28] (03PS5) 10Aaron Schulz: Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 (owner: 10CSteipp) [17:36:36] (03PS6) 10EBernhardson (WMF): edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 [17:37:13] (03CR) 10Aaron Schulz: "Rebased onto master" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 (owner: 10CSteipp) [17:38:42] (03CR) 10Aaron Schulz: [C: 032 V: 032] "Handshake can be anywhere, but I guess it's fine to leave it like this for now to keep things simple." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 (owner: 10CSteipp) [17:39:16] ^d: https://gerrit.wikimedia.org/r/#/c/78416/ some setup cleanups [17:39:32] (03PS7) 10EBernhardson (WMF): edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 [17:40:10] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 (owner: 10EBernhardson (WMF)) [17:42:58] (03PS11) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [17:45:48] (03PS6) 10EBernhardson (WMF): New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 [17:48:46] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [17:53:53] (03CR) 10Demon: [C: 032] Avoid "Transaction already in progress" errors in SiteStatsUpdate::doUpdate [core] - 10https://gerrit.wikimedia.org/r/74851 (owner: 10Aaron Schulz) [17:56:37] (03Merged) 10jenkins-bot: Avoid "Transaction already in progress" errors in SiteStatsUpdate::doUpdate [core] - 10https://gerrit.wikimedia.org/r/74851 (owner: 10Aaron Schulz) [17:57:27] (03CR) 10Parent5446: [C: 031] add optional id parameter; make extension working in templates [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/76351 (owner: 10Wikinaut) [18:00:53] (03CR) 10Wikinaut: [C: 032 V: 032] add optional id parameter; make extension working in templates [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/76351 (owner: 10Wikinaut) [18:03:48] (03CR) 10Parent5446: [C: 031] "Does your test wiki use SQLite? Because if it doesn't then there won't be a SQLite DB at all, let alone an Annotator table." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [18:09:56] (03PS1) 10Demon: Removing Vector submodule in vain effort to fix it [extensions] - 10https://gerrit.wikimedia.org/r/79219 [18:10:29] (03CR) 10Demon: [C: 032 V: 032] Removing Vector submodule in vain effort to fix it [extensions] - 10https://gerrit.wikimedia.org/r/79219 (owner: 10Demon) [18:12:20] (03CR) 10Mattflaschen: "I talked to Richa on IRC, and I think it's okay to limit anonymous users to create for now. I don't know a clean way to get the user's IP" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [18:12:45] ^d: you're quite an optimist, aren't you. [18:12:55] <^d> Am today :) [18:12:59] <^d> I have a theory. [18:19:16] (03CR) 10MarkTraceur: [C: 032] "Sure!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79013 (owner: 10Cscott) [18:19:27] cscott: Your wish, my command [18:19:56] (03CR) 10MarkTraceur: [C: 032] "Mighty silly way to do things, but sure" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77471 (owner: 10Cscott) [18:19:59] (03Merged) 10jenkins-bot: New Parsoid test: run parsoid's parserTests file using PHP parser. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79013 (owner: 10Cscott) [18:20:00] (03Merged) 10jenkins-bot: Fix *another* bug in the parsoid-regressions job... then turn it off. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77471 (owner: 10Cscott) [18:21:32] (03PS1) 10Demon: Revert "Removing Vector submodule in vain effort to fix it" [extensions] - 10https://gerrit.wikimedia.org/r/79220 [18:21:38] (03CR) 10Demon: [C: 032 V: 032] Revert "Removing Vector submodule in vain effort to fix it" [extensions] - 10https://gerrit.wikimedia.org/r/79220 (owner: 10Demon) [18:22:47] <^d> MatmaRex: Turns out I have dyslexia or something. [18:22:57] <^d> I nuked Vector when I meant VisualEditor. [18:23:01] (03CR) 10TheDJ: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [18:31:27] (03CR) 10TheDJ: [C: 032] mediawiki.action.edit: Add styles for edit form's footer [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Matmarex) [18:31:44] (03CR) 10TheDJ: [C: 032] EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a [core] - 10https://gerrit.wikimedia.org/r/76068 (owner: 10Matmarex) [18:32:21] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [18:32:26] (03PS1) 10Demon: Removing VisualEditor in vain effort to fix it [extensions] - 10https://gerrit.wikimedia.org/r/79221 [18:32:34] (03CR) 10Demon: [C: 032 V: 032] Removing VisualEditor in vain effort to fix it [extensions] - 10https://gerrit.wikimedia.org/r/79221 (owner: 10Demon) [18:36:27] (03PS6) 10Foxtrott: Added lingo support for ApprovedRevs. To enable feature use [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [18:36:58] (03PS1) 10Demon: Readding VisualEditor extension, plus fixed a few others [extensions] - 10https://gerrit.wikimedia.org/r/79222 [18:37:26] (03CR) 10Demon: [C: 032 V: 032] Readding VisualEditor extension, plus fixed a few others [extensions] - 10https://gerrit.wikimedia.org/r/79222 (owner: 10Demon) [18:38:08] (03CR) 10TheDJ: [C: 032] Hide MediaWiki's "Editing help" link, as we provide it in the toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/76069 (owner: 10Matmarex) [18:38:11] (03Merged) 10jenkins-bot: Hide MediaWiki's "Editing help" link, as we provide it in the toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/76069 (owner: 10Matmarex) [18:41:44] Rtdwivedi: You around? [18:41:58] GorillaWarfare: Hi! [18:42:51] Rtdwivedi: Do you happen to know how on earth you guys are getting the standard editing toolbar not to appear in your includes/index/EditProofreadIndexPage.php? [18:43:01] (03CR) 10TheDJ: [V: 04-1] "Was just about to approve this and last minute noticed that the i18n of footercleanup are still in there." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/76070 (owner: 10Matmarex) [18:43:16] I'm creating a similar page, and need to get it to go away, but can't for the life of me see how you guys are doing it there [18:43:22] (03CR) 10TheDJ: [C: 04-1] "grr, wrong status" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/76070 (owner: 10Matmarex) [18:43:58] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [18:44:30] (03CR) 10Wikinaut: [C: 031] "Tyler, I tested it again: it works!" [core] - 10https://gerrit.wikimedia.org/r/48417 (owner: 10Parent5446) [18:44:37] You are extending EditPage,a aren't you? [18:45:05] Yes [18:45:56] (03CR) 10Wikinaut: "correct in my previous comment:" [core] - 10https://gerrit.wikimedia.org/r/48417 (owner: 10Parent5446) [18:47:26] GorillaWarfare: The standard toolbar is there in my local install. [18:47:40] When you edit an index page? [18:47:47] Yes. [18:48:02] Not for you? [18:48:26] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 (owner: 10Werdna) [18:49:02] (03CR) 10Foxtrott: "See inline comments, please." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/73577 (owner: 10Euvl) [18:49:33] I don't have it enabled in my local wiki; I was assuming it was removed because it doesn't appear for me in enWS [18:50:38] If you want it removed, doing it through JS would be a hack though I am sure there must be a way to disable the toolbar [18:51:39] Indeed [18:54:44] (03PS1) 10MarkTraceur: Re-enable building parsoid-regressions job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79224 [18:58:16] (03CR) 10Umherirrender: [C: 04-1] "Need some investigation about the handling, when given title and current title is equal." [core] - 10https://gerrit.wikimedia.org/r/76534 (owner: 10Umherirrender) [18:58:25] (03PS1) 10CSteipp: Respect audience for usernames [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79226 [18:59:03] thedj: poke [18:59:22] re https://gerrit.wikimedia.org/r/#/c/76070/1 - where is that i18n? it seems to not be there for english and qqq [18:59:33] (03PS1) 10Manybubbles: Fix big writes in tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79227 [18:59:33] removed by one of the other changes [18:59:35] (03PS7) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [19:01:38] MatmaRex: ouch [19:03:44] (03PS1) 10Cscott: Disable parsoid-regressions, enable parsoid-php-parsertests (non-voting). [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79228 [19:05:05] (03PS1) 10Cscott: Silly rabbit, commenting out parsoid-regressions doesn't turn it off. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79229 [19:05:36] cscott: I already submitted that patch but your commit message is wayyyy better [19:06:18] (03CR) 10MarkTraceur: [C: 032] "I'll abandon my patch, this one's way better" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79229 (owner: 10Cscott) [19:06:31] (03Merged) 10jenkins-bot: Silly rabbit, commenting out parsoid-regressions doesn't turn it off. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79229 (owner: 10Cscott) [19:06:47] (03Abandoned) 10MarkTraceur: Re-enable building parsoid-regressions job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79224 (owner: 10MarkTraceur) [19:07:08] marktraceur: it's not what you do, it's the style with which you do it. [19:07:27] especially if "what you do" is, in this case, admitting you're an idiot. [19:07:50] cscott: That's not coding, it's falling...with style! [19:08:29] (03CR) 10MarkTraceur: [C: 032] "Much better solution." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79228 (owner: 10Cscott) [19:08:34] (03Merged) 10jenkins-bot: Disable parsoid-regressions, enable parsoid-php-parsertests (non-voting). [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79228 (owner: 10Cscott) [19:08:35] the trick is aiming for the group, but missing. [19:08:39] *ground [19:08:42] <^d> *snicker* https://code.google.com/p/gerrit/issues/detail?id=2024 [19:08:47] cscott: Seems like a good state to review, yeah? [19:08:49] Er [19:08:50] Deploy [19:09:14] thedj: ? [19:09:17] marktraceur: yeah. let's drop a war in the folder and see what blows up! [19:09:27] oh wait, that was ^d [19:10:58] MatmaRex: ah, you are right [19:11:19] (03CR) 10TheDJ: [C: 032] "all english and qqq removed." [extensions/Vector] - 10https://gerrit.wikimedia.org/r/76070 (owner: 10Matmarex) [19:11:26] (03Merged) 10jenkins-bot: Delete the ext.vector.footerCleanup module [extensions/Vector] - 10https://gerrit.wikimedia.org/r/76070 (owner: 10Matmarex) [19:12:00] yay [19:12:05] nothing like merging four patches in a row [19:14:55] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 (owner: 10Aaron Schulz) [19:16:23] (03CR) 10CSteipp: [C: 032 V: 032] Added logged-in check to some special pages and fixed others [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77822 (owner: 10Aaron Schulz) [19:18:30] (03CR) 10Mwalker: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [19:18:32] cscott: I think it's in a sane state, want to submit a change? [19:18:48] Ping me when you have one up [19:20:20] i'm going to review https://gerrit.wikimedia.org/r/#/c/79223/1 for subbu, i'll let you know before i hit +2 [19:20:34] (assuming that subbu is his usual reliable self and has written nice clean code i can +2) [19:20:41] :-) [19:24:23] cscott, well, i hope so as well, but dont be a lazy reviewer ;-) [19:32:40] subbu|lunch: i -1'ed it. [19:33:27] (03PS2) 10Aaron Schulz: Enforce version format and chronology [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 [19:34:07] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 (owner: 10Aaron Schulz) [19:36:43] mwalker: got it. i'll go trough the code, see if I can get this figured out. [19:41:22] (03CR) 10Aaron Schulz: "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79226 (owner: 10CSteipp) [19:58:02] (03CR) 10Aaron Schulz: "(2 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [20:46:37] Where's WIKIDEBUG set as an environment variable? [20:46:45] where/under what conditions [20:48:04] if ( getenv( 'WIKIDEBUG' ) ) { [20:48:04] $wgDebugLogFile = '/tmp/wiki.log'; [20:48:04] $wgDebugDumpSql = true; [20:48:07] Just testwiki? [21:25:20] (03CR) 10Parent5446: "Yeah I don't think it's currently possible. It would require a core change." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [21:25:21] (03PS1) 10Mattflaschen: Bump GettingStarted for E3 deploy [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79273 [21:25:24] (03PS1) 10Mattflaschen: Bump GuidedTour for E3 deploy [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79274 [21:25:25] (03CR) 10Mattflaschen: [C: 032] "Latest master of GettingStarted" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79273 (owner: 10Mattflaschen) [21:25:26] (03CR) 10TheDJ: [C: 032] "It's better than what we have now, so let's just do this. We can improve it further later on." [core] - 10https://gerrit.wikimedia.org/r/62005 (owner: 10Balloonguy) [21:25:27] (03CR) 10Mattflaschen: [C: 032] "Latest master of GuidedTour" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79274 (owner: 10Mattflaschen) [21:25:29] (03Merged) 10jenkins-bot: Bump GettingStarted for E3 deploy [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79273 (owner: 10Mattflaschen) [21:25:35] (03Merged) 10jenkins-bot: Bump GuidedTour for E3 deploy [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79274 (owner: 10Mattflaschen) [21:25:38] (03CR) 10MarkTraceur: "Abandoned because it was brought into Gerrit here: https://gerrit.wikimedia.org/r/59064" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/59111 (owner: 10SuchABot) [21:25:43] (03CR) 10TheDJ: "I don't think we should make the php and the warnings table of the JS api even further. So I think we should just add the normalizedFile p" [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [21:25:44] (03PS2) 10CSteipp: Respect audience for usernames [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79226 [21:25:45] (03PS2) 10Shirayuki: Fix capitalization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79199 [21:25:46] (03CR) 10Shirayuki: "Rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79199 (owner: 10Shirayuki) [21:25:48] (03CR) 10Aaron Schulz: [C: 032 V: 032] Respect audience for usernames [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79226 (owner: 10CSteipp) [21:25:50] (03CR) 10CSteipp: [C: 032 V: 032] Enforce version format and chronology [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 (owner: 10Aaron Schulz) [21:29:46] (03PS8) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [21:41:33] (03CR) 10Aaron Schulz: [C: 032] Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [21:41:36] (03Merged) 10jenkins-bot: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [21:42:29] (03CR) 10MarkTraceur: [C: 031] "(7 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 (owner: 10Rasel160) [21:42:40] (03PD2) 10Wikinaut: Hotfix for a German translation which I cannot submit via translatewiki.net [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/79278 [21:42:48] (03CR) 10Wikinaut: [C: 032 V: 032] Hotfix for a German translation which I cannot submit via translatewiki.net [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/79278 (owner: 10Wikinaut) [21:46:14] (03CR) 10Legoktm: "LqtView::getInlineEditForm still uses a FauxRequest, and calls LqtView::fixFauxRequestSession. I wasn't really sure of what that function " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/79181 (owner: 10Legoktm) [21:48:24] (03PS1) 10Cscott: Create appropriate LocalSettings.php to allow parsoid-php-parsertests to run. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79280 [21:48:51] (03PS1) 10Nemo bis: Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 [21:49:56] Reedy: and that's for core, it seems the docs were actually wrong? [21:50:20] Say what now? [21:50:46] to use Specialpage and not SpecialPage [21:51:46] $wgQueryPages = array( [21:51:47] array( 'AncientPagesPage', 'Ancientpages' ), [21:51:47] array( 'BrokenRedirectsPage', 'BrokenRedirects' ), [21:51:47] array( 'DeadendPagesPage', 'Deadendpages' ), [21:51:47] etc [21:52:08] PagesPagesPage [21:52:18] they are not consistent? [21:52:34] array( 'DoubleRedirectsPage', 'DoubleRedirects' ), [21:52:34] array( 'FileDuplicateSearchPage', 'FileDuplicateSearch' ), [21:52:34] array( 'LinkSearchPage', 'LinkSearch' ), [21:52:34] array( 'ListredirectsPage', 'Listredirects' ), [21:52:34] array( 'LonelyPagesPage', 'Lonelypages' ), [21:52:36] array( 'LongPagesPage', 'Longpages' ), [21:52:38] What do you think this is? [21:52:45] a mess? [21:53:04] array( 'DoubleRedirectsPage', 'DoubleRedirects' ), [21:53:04] array( 'FileDuplicateSearchPage', 'FileDuplicateSearch' ), [21:53:04] array( 'LinkSearchPage', 'LinkSearch' ), [21:53:04] array( 'ListredirectsPage', 'Listredirects' ), [21:53:05] array( 'LonelyPagesPage', 'Lonelypages' ), [21:53:07] array( 'LongPagesPage', 'Longpages' ), [21:53:09] Fail that time [21:53:14] * DO NOT CHANGE THIS LIST without testing that [21:53:16] * maintenance/updateSpecialPages.php still works. [21:53:27] sigh [21:54:43] (03CR) 10MarkTraceur: [C: 04-1] "(10 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 (owner: 10Rasel160) [21:55:11] Reedy: so needs amending to say that it needs to be one of those names in the list? [21:55:40] or is the list actually wrong [21:55:56] Which list? [21:56:29] includes/QueryPage.php [21:57:16] (03CR) 10Reedy: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79281 (owner: 10Nemo bis) [21:57:36] Some are CamelCase [21:57:41] So those would work as expected [21:58:09] We could have updateSpecialPages.php give a correct list on usage.. [22:01:26] (03PS2) 10Nemo bis: Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 [22:01:45] (03PS3) 10Nemo bis: Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 [22:02:39] (03PS1) 10Reedy: Don't do special page cache updates if --list [core] - 10https://gerrit.wikimedia.org/r/79283 [22:02:46] (03PS1) 10Werdna: Remove some unnecessary images [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79284 [22:03:06] ^ I'm not even sure if $wgSpecialPageCacheUpdates should be done unconditionally anyway.. [22:03:42] But that's another story [22:04:19] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79281 (owner: 10Nemo bis) [22:05:41] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79281 (owner: 10Nemo bis) [22:06:20] (03PS1) 10Demon: Updating Cirrus to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79285 [22:06:32] (03PS2) 10Cscott: Create appropriate LocalSettings.php to allow parsoid-php-parsertests to run. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79280 [22:08:54] spagewmf: on https://www.mediawiki.org/w/index.php?title=Mingle&oldid=764934 , it seems someone at Wikimania said that their WMF team abandoned any tool in favour of Gdocs? [22:10:12] (03CR) 10Demon: [C: 032] Updating Cirrus to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79285 (owner: 10Demon) [22:10:37] Nemo_bis: that's news to me unless it's referring to how the engineering projects get rolled up from a GDocs spreadsheet. Feel free to add it as an alternative [22:12:39] (03CR) 10Werdna: [C: 032 V: 032] Fix capitalization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79199 (owner: 10Shirayuki) [22:12:46] (03Merged) 10jenkins-bot: Updating Cirrus to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79285 (owner: 10Demon) [22:13:28] (03PS2) 10Reedy: Don't do special page cache updates if --list or --only parameters passed [core] - 10https://gerrit.wikimedia.org/r/79283 [22:14:32] spagewmf: absolutely no, that's crazy [22:15:21] spagewmf: and I mean this https://twitter.com/dirkriehle/status/365692116468371457 [22:16:32] Nemo_bis: Hm, I think that was during the product director talk thing [22:17:04] I think James_F said that? Wasn't really paying attention… :/ [22:17:09] (03PS1) 10CSteipp: Add missing aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79287 [22:17:20] yeah, like 80 % of the attendees in any given moment :D [22:17:33] Nemo_bis: Yeah, that was me. [22:18:04] James_F: oki, maybe worth saying on https://www.mediawiki.org/w/index.php?title=Mingle&oldid=764934 [22:18:12] at some point in the future :) [22:18:59] * James_F doesn't really have anything to say. :-) [22:19:27] James_F: just whatever you said at Wikimania? :) [22:19:36] Nemo_bis: :-) [22:19:44] (03PS1) 10Demon: Revert "Updating Cirrus to master" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79288 [22:19:51] so that we have your actual words and not some out of context misunderstanding or whatever [22:19:51] (03CR) 10Demon: [C: 032 V: 032] Revert "Updating Cirrus to master" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/79288 (owner: 10Demon) [22:19:52] (03PS1) 10Reedy: If --only and we've had a hit, no need to continue iteration over $wgQueryPages [core] - 10https://gerrit.wikimedia.org/r/79289 [22:24:52] (03CR) 10Reedy: [C: 032] Add missing aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79287 (owner: 10CSteipp) [22:25:07] (03Merged) 10jenkins-bot: Add missing aliases [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79287 (owner: 10CSteipp) [22:25:40] (03PS4) 10Nemo bis: Fix help for --only: override doesn't work with CamelCase [core] - 10https://gerrit.wikimedia.org/r/79281 [22:27:06] Reedy: heh, for every bug in maintenance script you fix 3 more :D [22:28:37] (03PS1) 10MarkTraceur: Add automatic test for JJB config [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79292 [22:35:23] (03PS1) 10MarkTraceur: Adding jjb config test to the pipelines [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79293 [22:36:09] (03CR) 10MarkTraceur: [C: 032] Create appropriate LocalSettings.php to allow parsoid-php-parsertests to run. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79280 (owner: 10Cscott) [22:36:11] (03Merged) 10jenkins-bot: Create appropriate LocalSettings.php to allow parsoid-php-parsertests to run. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79280 (owner: 10Cscott) [22:38:57] (03CR) 10MarkTraceur: [C: 032] "Only adding a nonvoting job" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79293 (owner: 10MarkTraceur) [22:39:02] (03Merged) 10jenkins-bot: Adding jjb config test to the pipelines [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/79293 (owner: 10MarkTraceur) [22:39:52] (03PS2) 10MarkTraceur: Add automatic test for JJB config [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79292 [22:43:48] (03CR) 10Rillke: "So you suggest returning an array or object instead of a string." [core] - 10https://gerrit.wikimedia.org/r/78523 (owner: 10Rillke) [22:45:33] (03PS3) 10MarkTraceur: Add automatic test for JJB config [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79292 [22:49:11] (03CR) 10MarkTraceur: [C: 032] "Yo dawg, I herd you liek testing changes to your job builder, so we wrote a job that tests the changes you make to your job builder that t" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79292 (owner: 10MarkTraceur) [22:52:11] (03PS1) 10Reedy: Return values to finalSetup() aren't evaluated [core] - 10https://gerrit.wikimedia.org/r/79294 [22:53:41] (03PS2) 10Reedy: Return values to finalSetup() aren't evaluated [core] - 10https://gerrit.wikimedia.org/r/79294 [22:57:55] Looks like a bug. grrrit-wm hasn't used the new commit summary (changed via gerrit web interface) on PS2 [22:59:45] Reedy: i reported it like a week ago [22:59:47] or two [22:59:53] but it's a bug in gerrit [22:59:57] ah [22:59:59] or so says yuvi [23:03:54] Probably gets the commit message before the change is actually applied? [23:11:35] (03CR) 10Parent5446: [C: 032] Return values from finalSetup() aren't evaluated [core] - 10https://gerrit.wikimedia.org/r/79294 (owner: 10Reedy) [23:14:08] (03Merged) 10jenkins-bot: Return values from finalSetup() aren't evaluated [core] - 10https://gerrit.wikimedia.org/r/79294 (owner: 10Reedy) [23:15:20] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Remove some unnecessary images [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79284 (owner: 10Werdna) [23:19:23] reedy@ubuntu64-web-esxi:~/git/operations/mediawiki-config$ grep -i cirrus wmf-config/extension-list [23:19:23] reedy@ubuntu64-web-esxi:~/git/operations/mediawiki-config$ [23:19:37] bah, wrong channel [23:25:35] (03CR) 10MarkTraceur: "TheDJ, we're using the label because it allows us to style the checkbox (which cannot be substantially styled otherwise), and not a span b" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [23:44:30] (03PS17) 10MarkTraceur: Implement agora-style checkboxes experimentally [core] - 10https://gerrit.wikimedia.org/r/74662 [23:44:57] (03CR) 10Bsitu: "(2 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77265 (owner: 10Kaldari) [23:45:14] (03CR) 10MarkTraceur: "I think this fixes the a11y questions, but if not, I'm available to solve more." [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [23:48:15] (03PS1) 10CSteipp: PHPUnit tests for lib/OAuth.php [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79298 [23:55:25] (03PS1) 10Demon: Rename 'backend' param to 'srbackend' to match API [core] - 10https://gerrit.wikimedia.org/r/79299 [23:55:40] (03CR) 10Demon: [C: 032 V: 032] Rename 'backend' param to 'srbackend' to match API [core] - 10https://gerrit.wikimedia.org/r/79299 (owner: 10Demon) [23:56:31] (03PS1) 10Demon: Rename 'backend' param to 'srbackend' to match API [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79300 [23:56:45] (03CR) 10Demon: [C: 032 V: 032] Rename 'backend' param to 'srbackend' to match API [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79300 (owner: 10Demon)