[00:05:33] chrismcmahon: we'll get there I think, but not quite yet. [00:14:43] (03PS8) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [00:35:22] (03CR) 10Mwalker: [C: 032] Bug 50672: JavaScript fallback for navbar [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78932 (owner: 10Mollywhite) [00:35:28] (03Merged) 10jenkins-bot: Bug 50672: JavaScript fallback for navbar [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78932 (owner: 10Mollywhite) [00:36:33] GorillaWarfare: you around? [00:40:14] (03CR) 10Mwalker: [C: 04-1] "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79015 (owner: 10Mollywhite) [00:44:48] (03PS6) 10Ori.livneh: Optionally encode exception log entries as JSON documents [core] - 10https://gerrit.wikimedia.org/r/76304 [00:51:21] Hi I am looking at Special:GlobalBlockList and am curious why it lacks the options Special:BlockList has [00:51:30] such as the ability to select specific types of blocks [00:54:05] ToAruShiroiNeko: like what? global blocking is only for IPs, so the "hide account blocks" option doesn't make sense [00:54:19] i guess the other ones do though [00:54:21] no but I want to be able to choose ranges, indefs etc [00:54:21] ToAruShiroiNeko: file a bug? :) [00:54:30] sure [00:54:34] "Hide temporary blocks", "Hide single IP blocks", "Hide range blocks" would all be valid options for GlobalBlockList [00:54:36] I just wasnt sure if it was intentional [00:57:42] as you can tell ToAruShiroiNeko, that page wasn't designed to be the same as the core single-wiki blocking was [00:57:42] I very much doubt it was intentional [00:58:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=52825 [00:58:58] Krenair guess who I completely ripped off that quote from? :) [00:58:58] hmm [00:58:59] outout perhaps should be a table [00:58:59] rather than a list [00:58:59] easier to grind on excel etc [00:58:59] (meta.wikimedia.org) is probably redundent [00:59:40] no [00:59:47] it's important to know which wiki the global block was made from [01:00:11] the wiki name is only redundant in a wikimedia context where -almost- all global stuff is done from meta [01:00:48] ToAruShiroiNeko, also, you've created a bug for Special:GlobalBlockList in the MediaWiki product... [01:01:11] Krenair: I just moved it :P [01:01:11] ow [01:02:11] should be resolved in 5 years or longer :p [01:02:25] or within the next 5 seconds as a wontfix :p [01:03:15] doesn't look like a wontfix to me [01:03:44] * ToAruShiroiNeko corsses fingers and prays to the wiki gods and goddesses :p [01:03:49] *crosses even [01:05:18] the thing is I almost want it immediately resolved :p [01:05:30] curious about global indefs [01:09:21] could just query the db [01:09:30] assuming globalblocking stuff is replicated publicly [01:11:33] yep [01:11:41] ssh tools-login.wmflabs.org -t sql centralauth [01:11:52] SELECT * FROM globalblocks WHERE gb_expiry = 'infinity'; [01:12:29] only returns 44 rows [01:12:39] ToAruShiroiNeko, ^ [01:19:06] mwalker: I am now [01:20:03] I was wondering how you were rebasing your patches; I noticed some repeated stuff in the last two you pushed to gerrit [01:20:39] Ugh, damn, really? I noticed that was happening, but thought I'd yanked it out [01:20:54] I've just been doing git rebase master and then using a merge tool [01:24:42] Krenair I see [01:24:45] any of them ranges? [01:25:10] can you possibly pastebin the 44 rows? [01:26:21] 16 of them [01:27:32] http://pastebin.com/NJjDT2e2 [01:28:29] (03PS2) 10Demon: Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 [01:28:35] (03CR) 10Demon: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/79025 (owner: 10Demon) [01:37:45] <^d> Why do we still have the TitleKey extension installed? [01:40:56] ikr [01:41:01] GorillaWarfare: sorry; got distracted -- hurm though; that should be working; don't know whats going wrong then [01:41:11] ^d: You mean it shouldn't be installed or it should be in core? [01:41:15] I favor putting it in core. [01:41:28] mwalker: Yeah, it's been confusing me [01:41:32] Where did you see duplication? [01:42:24] <^d> Elsie: I don't know why we install it at WMF. [01:42:50] GorillaWarfare: https://gerrit.wikimedia.org/r/#/c/79015/1/BookManagerv2.hooks.php,unified and https://gerrit.wikimedia.org/r/#/c/78932/1/BookManagerv2.hooks.php,unified line 387 for one [01:42:55] Isn't it used for search suggestions? [01:43:07] <^d> Both TitleKey and MWSearch's implementation's return false, which means whichever one that is registered first will end up halting execution of further hooks. [01:43:32] * Elsie shrugs. [01:43:42] <^d> MWSearch wins because it registers first. [01:43:54] What a pain [01:44:20] <^d> There's not much of a point of having multiple suggestion sources anyway. I can see why it was probably useful, but it hasn't been for a long time afaict. [01:44:38] <^d> At least not at wmf. It may be useful for core or for bundling by default. [01:45:45] GorillaWarfare: *shrugs* it's an oddity -- what I typically do is git rebase master; git mergetool; git rebase --continue; git review -- but really it shouldn't matter because git should not be letting you do things out of order [01:46:28] ^d: Lots of legacy code building up. :-) Probably similar to UploadBlacklist. [01:46:29] mwalker: That's what I do too [01:46:32] (Which is now disabled.) [01:47:11] <^d> :) [01:52:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=52827 [01:52:20] ^d: Filed that for you. ^ [01:54:44] <^d> Thanks, mind if I paste our parts of the conversation in so we don't forget? [01:54:52] No problem. [01:54:59] And no problem. [01:55:10] Though I don't think I said anything valuable. :P [02:07:51] Elsie: what you say is always valuable >> [02:07:53] *>.> [02:08:12] Krenair thanks btw [02:08:15] (03CR) 10Tim Starling: [C: 04-1] "(4 comments)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [02:25:55] (03PS1) 10MaxSem: WIP RFC: Generic data store [core] - 10https://gerrit.wikimedia.org/r/79029 [02:26:40] (03CR) 10MaxSem: [C: 04-2] WIP RFC: Generic data store [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [02:28:32] (03CR) 10jenkins-bot: [V: 04-1] WIP RFC: Generic data store [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [02:35:21] (03CR) 10MZMcBride: "I don't think the -1 here is justified. This change is an improvement over the current situation and perfect is the enemy of the good. Thi" [core] - 10https://gerrit.wikimedia.org/r/57533 (owner: 10Rjain) [02:41:37] (03CR) 10Parent5446: "Looks interesting. What RFC is this for?" [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem) [02:53:03] mwalker: Regarding your comment on the settings change -- do you think it shouldn't be done? [02:53:57] I don't particularly see the need; what you had previously is a known pattern [02:55:33] mwalker: Hm, okay [02:55:40] If it's simpler, there's no real need [03:25:48] (03CR) 10Ori.livneh: [C: 032] "Tested; works." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78407 (owner: 10Ragesoss) [03:26:00] (03Merged) 10jenkins-bot: Add a link to show user subpages for each student in the articles table. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78407 (owner: 10Ragesoss) [03:27:12] thanks ori-l ! [03:27:47] np [03:29:14] (03PS1) 10Ori.livneh: Add 'role::education' [vagrant] - 10https://gerrit.wikimedia.org/r/79030 [03:30:14] (03CR) 10Ori.livneh: "@Ragesoss: are there any non-default settings that should be set for development?" [vagrant] - 10https://gerrit.wikimedia.org/r/79030 (owner: 10Ori.livneh) [03:32:18] ori-l no, not that I know of. [03:32:50] (03CR) 10Ori.livneh: [C: 032] Add 'role::education' [vagrant] - 10https://gerrit.wikimedia.org/r/79030 (owner: 10Ori.livneh) [03:32:53] (03Merged) 10jenkins-bot: Add 'role::education' [vagrant] - 10https://gerrit.wikimedia.org/r/79030 (owner: 10Ori.livneh) [03:38:07] (03PS1) 10Legoktm: If using §ion=new, it is possible the page won't exist. [core] - 10https://gerrit.wikimedia.org/r/79031 [03:44:17] (03CR) 10MZMcBride: "An accompanying unit test might be a good idea." [core] - 10https://gerrit.wikimedia.org/r/79031 (owner: 10Legoktm) [05:03:19] (03CR) 10Legoktm: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [05:06:12] (03PS3) 10Legoktm: Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 [05:06:25] YuviPanda_zz: ^ that was pretty lagged…. [05:06:32] legoktm: NFS [05:06:39] heh [05:06:49] also, good morning :P [05:07:03] :D [05:07:05] good morning! [05:07:20] a hotel with about 30 people staying but only 2 bathrooms isnot good [05:07:32] Sounds like a hostel. [05:08:26] unless they are vry large bathrooms with a lot of stalls... [05:18:47] (03PS4) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [05:19:18] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm) [05:37:31] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [06:23:57] (03PS5) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [07:07:00] legoktm you around [07:07:07] ish [07:07:16] yay [07:07:22] I need a little help geolocating ranges [07:07:30] I want to know which cities are blocked basically [07:07:49] http://tr.wikipedia.org/wiki/%C3%96zel:EngelListesi?wpTarget=&wpOptions%5B%5D=userblocks&wpOptions%5B%5D=addressblocks&limit=50 [07:08:00] aside from proxy ones that is [07:08:05] can you write a script for it [07:08:50] I manually checked 78.172.0.0/16 and for it 78.172.0.*-78.172.191.* is for Bursa and 78.172.192.*-78.172.255.* for Istanbul [07:08:59] stuff like that [07:09:04] how many IPs per city [07:09:23] there are no really good geolocation APIs that are free :/ [07:11:11] http://freegeoip.net/ ? [07:11:47] you dont need to check all 1.8 million IPs individually [07:12:16] a neat algorithm would do the trick [07:13:08] geolocate x.x.x.0, x.x.x.255 if same skip else geolocate x.x.x.127 and so on [07:13:15] seems more feasable? [07:13:28] yeah, i'm not really interested in doing this [07:13:31] sorry [07:13:41] :( [07:14:15] It would really help me demonstrate the impact, can you suggest someone who'd be more interested? [07:14:27] who esle is a script and IP wizzard? [07:18:15] (03CR) 10Legoktm: "Tests fail because of https://bugzilla.wikimedia.org/show_bug.cgi?id=52830" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78785 (owner: 10Legoktm) [07:18:32] ToAruShiroiNeko: maybe betacommand? [07:58:42] YuviPanda_zz: ah, wow [08:48:59] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79031 (owner: 10Legoktm) [08:51:11] (03CR) 10Raimond Spekking: "(5 comments)" [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/77993 (owner: 10tosfos) [09:29:18] (03CR) 10Hoo man: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79031 (owner: 10Legoktm) [09:31:47] (03PS1) 10Zsaigol: Special:ListUsers - add option to filter by blocked status. [core] - 10https://gerrit.wikimedia.org/r/79041 [09:55:37] (03CR) 10Matthias Mullie: "Anyone comfortable reviewing this change?" [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [10:17:57] (03CR) 10Parent5446: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [10:29:26] (03PS1) 10Matthias Mullie: Purge page cache for every AFTv5 protection change [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/79042 [10:36:00] (03CR) 10TheDJ: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [10:47:19] (03CR) 10Netbrain: [C: 031] Clarify maps-displaymap-par-visitedicon [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 (owner: 10Nemo bis) [12:30:48] (03PS2) 10Zsaigol: Special:ListUsers - add option to filter by blocked status. [core] - 10https://gerrit.wikimedia.org/r/79041 [13:26:26] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [13:48:01] (03CR) 10TheDJ: "Seems mShowEmptyLabels was introduced by mwalker. I added him on the review list." [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [13:54:11] (03PS1) 10Wizardist: (Bug 45666) Add profiling calls [extensions/NamespaceRelations] - 10https://gerrit.wikimedia.org/r/79050 [14:05:00] (03CR) 10Matmarex: [C: 04-1] "This is currently on hold per bug 52817." [core] - 10https://gerrit.wikimedia.org/r/78464 (owner: 10Matmarex) [14:11:46] (03PS1) 10MathiasLidal: Commit initial version of new category input type [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79051 [14:12:16] (03Abandoned) 10MathiasLidal: Commit initial version of new category input type [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/79051 (owner: 10MathiasLidal) [14:23:21] thedj: Are you firm with aria stuff? [14:33:06] (03PS1) 10Hoo man: Add aria properties to TOC toggle link [core] - 10https://gerrit.wikimedia.org/r/79053 [14:34:46] Or is anyone else in here? [14:36:39] sup hoo [14:37:08] MatmaRex: hey... are you into that? Working on accessibility [14:39:27] sorta kinda not really [14:39:39] i mostly merged a few of dj's patches [14:39:40] :P [14:40:11] MatmaRex: I need someone to have a look at https://gerrit.wikimedia.org/r/79053 it is more of a start for me, before pondering with the sidebar or something like that [14:41:06] (03CR) 10Manybubbles: "ForkController would certainly be more friendly to windows folks but it doesn't look to handle farming jobs out over ssh which would be re" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78834 (owner: 10Manybubbles) [14:41:39] hoo: eh, i don't think i can help with that, sorry [14:41:44] but why .prop instead of .attr? [14:42:02] because these are properties or not? [14:42:08] i'm pretty sure theseare attributes? [14:42:18] aria-controls (property) [14:42:34] hmm [14:43:55] dj appears to consistently use .attr with aria stuff [14:43:57] https://gerrit.wikimedia.org/r/#/c/78640/1/resources/mediawiki.special/mediawiki.special.preferences.js [14:44:13] and uses them as attributes in html, https://gerrit.wikimedia.org/r/#/c/78950/ [14:44:44] i don't think that "property" is supposed to mean a JS property [14:44:49] even the w3 document messes with this :/ [14:44:49] (but i'm not sure what;s it from) [14:46:34] I already thought someone would complain about that as I wasn't totally sure about this :P That's why I started with such a small thing rather than throwing over a lot of JS [14:47:09] (03CR) 10EBernhardson (WMF): [C: 032] Purge page cache for every AFTv5 protection change [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/79042 (owner: 10Matthias Mullie) [14:47:12] (03Merged) 10jenkins-bot: Purge page cache for every AFTv5 protection change [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/79042 (owner: 10Matthias Mullie) [14:47:25] (03PS3) 10Zsaigol: Special:ListUsers - add option to filter by blocked status. [core] - 10https://gerrit.wikimedia.org/r/79041 [15:14:12] ori-l: wow for which part? [15:14:14] also I should've planned this more [15:14:18] but you live and you learn, I guess [15:20:18] YuviPanda: hey, can i get parsoid added to G2G? [15:20:42] Boooooo [15:26:15] (03CR) 10Matmarex: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [15:28:22] marktraceur: boo? it seems harmless enough, it just bridges github and gerrit right? [15:28:51] cscott: Yes, I booo because of the former [15:29:09] we had a contributor wander by and submit a trivial github pull request. i'd rather not manually pull it and/or convince them that they need to sign up for gerrit for such a trivial thing. [15:29:25] you don't <3 github? [15:30:04] if it makes you happier, think of g2g as a way to pretend github doesn't exist. ;) [15:33:19] cscott: I will in a bit. Currently stranded in hong kong without a place to stay at tomorrow :| [15:33:52] YuviPanda: the moscow airport worked for the last guy in that kind of jam. [15:34:01] cscott: heh :P [15:34:42] YuviPanda: i added some notes on various wiki talk pages and bugzilla too, noting where G2G should be evangelized. ;) no rush. [15:35:16] cscott: yeah, I did a lot of work to make it a lot more stable during wikimania, and it is a lot more stable and monitorable now. Just didn't have time to actually update docs, etc [15:35:43] can everyone also call me an idiot? [15:35:51] yup, i figured i'd just try to point out where a newbie might expect to stumble across docs [15:35:53] I bet that'll help. Should've booked these a long time ago [15:36:08] YuviPanda: i don't think that IRC has a good notion of 'everybody'. as a technical issue, i don't think we can. [15:36:24] hehe :P [15:38:05] (03PS1) 10Liangent: Followup Ifb005e7c: some cleanup in comments. [core] - 10https://gerrit.wikimedia.org/r/79063 [15:41:56] (03CR) 10Liangent: "see bug 52851" [core] - 10https://gerrit.wikimedia.org/r/79063 (owner: 10Liangent) [15:55:14] (03CR) 10Parent5446: [C: 031] "I haven't done any testing, nor do I know much about the UI aspect of this, but the backend queries are all good." [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [16:12:19] (03PS1) 10Liangent: Don't use $wgVariantArticlePath for variants of non-content languages [core] - 10https://gerrit.wikimedia.org/r/79066 [16:44:16] thedj: Around now? [16:54:10] (03PS1) 10EBernhardson (WMF): Extract timestamps from UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79068 [17:03:10] (03CR) 10Brian Wolff: [C: 04-1] "Unless beta features specificly requires js enabled to function, why do this on the js side instead of on the PHP side with PersonalUrls h" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur) [17:04:53] (03CR) 10MarkTraceur: "cf. Krinkle's comment on bug 52718" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur) [17:08:18] (03PS1) 10Cmcmahon: Login by default so no need for conditionals that cause bogus failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79071 [17:08:19] (03CR) 10jenkins-bot: [V: 04-1] Login by default so no need for conditionals that cause bogus failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79071 (owner: 10Cmcmahon) [17:09:02] (03Abandoned) 10Cmcmahon: Login by default so no need for conditionals that cause bogus failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79071 (owner: 10Cmcmahon) [17:34:46] (03PS1) 10Demon: Don't support SearchUpdate in MWSearch [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/79074 [17:36:09] * werdna waves [17:38:31] hi werdna [17:39:45] (03CR) 10EBernhardson (WMF): [C: 032] Don't add feedback comment to logs [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/73182 (owner: 10Matthias Mullie) [17:39:46] (03Merged) 10jenkins-bot: Don't add feedback comment to logs [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/73182 (owner: 10Matthias Mullie) [17:42:10] werdna: wanna do some code review? :D [17:42:15] https://gerrit.wikimedia.org/r/#/c/62005/ [17:42:29] * werdna hides [17:42:40] it's, like, 50 lines of javascript [17:43:32] and it's from may, and it's a first contrib of some guy [17:43:40] so you get mad props for looking at this kind of thing [17:43:59] (even if the guy probably stopped caring by now) [17:44:32] (03PS9) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [17:46:04] werdna: https://gerrit.wikimedia.org/r/#/c/78478/9/modules/discussion/images/JimmyUserPage.png lol [17:46:23] MatmaRex: I just put in all the images from Brandon's prototype :D [17:46:27] I don't think they're all used :p [17:46:28] somehow [17:46:52] heh [17:47:28] werdna: also, you might be interested in https://bugzilla.wikimedia.org/show_bug.cgi?id=50843 [17:47:34] since i see at least two new icons there. :P [17:47:57] (03PS2) 10Demon: Don't support SearchUpdate in MWSearch [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/79074 [17:49:19] ALL THE ICONS [17:49:53] (03CR) 10Aaron Schulz: [C: 032] Don't support SearchUpdate in MWSearch [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/79074 (owner: 10Demon) [17:49:55] (03Merged) 10jenkins-bot: Don't support SearchUpdate in MWSearch [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/79074 (owner: 10Demon) [17:51:16] (03PS3) 10Demon: Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 [17:52:20] (03CR) 10TheDJ: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [17:53:35] (03PS1) 10Demon: SearchUpdate cleanups for CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79077 [17:54:03] hoo|away: am now :D [17:54:08] (03PS2) 10Demon: SearchUpdate cleanups for CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79077 [17:54:45] thedj: \o/ [17:54:48] hoo|away: oh, i'm also working on the sidebar btw :D [17:55:06] (03PS4) 10Demon: Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 [17:55:17] thedj: Well, you're stealing my work, stop it :D [17:55:24] hoo: you can tackle mw-collapsible if you want. Didn't start on that yet. [17:55:38] <^demon> manybubbles: I think I've finished being angry at SearchUpdate :p [17:55:46] <^demon> Removing the entire hook made me feel good. Such a dumb hook. [17:55:47] I'm not sure that's within the scope right now :P [17:56:21] sounds good to me. we never really used it. hell, we turned it off. [17:56:35] but I like the change. I'm gonna look at the core change too. [17:57:03] thedj: Have you yet done much? Maybe you could upload it as draft so that I can amend it [17:57:16] other major problems are basically, the wikieditor, echo, ULS. [17:57:19] hoo: lemme check [17:58:06] hoo: thedj: i want YOU to review https://gerrit.wikimedia.org/r/#/c/62005/6 ! [17:58:24] [19:42] it's, like, 50 lines of javascript [17:58:25] [19:43] and it's from may, and it's a first contrib of some guy [17:58:25] [19:43] so you get mad props for looking at this kind of thing [17:58:41] ah, i'll see if i have some time [17:59:27] thedj: The good thing is I'm going to work on accessibility a lot until October, the bad part is: I've never worked with wai-aria ever before (I only know some theory) [17:59:34] Nemo_bis: hi [17:59:42] hoo: ah, you are doing the contract ? [17:59:56] thedj: Yes, I'm contracted to WMDE [18:00:13] hoo: http://www.mediawiki.org/wiki/Accessibility_guide_for_developers [18:00:27] there is some useful stuff there. [18:00:36] would be appreciated to work that out a lot futher :D [18:00:52] And i do know a fair bit about it now. [18:00:58] (03CR) 10Demon: [C: 032] Regression tests for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 (owner: 10Manybubbles) [18:01:00] (03CR) 10jenkins-bot: [V: 04-1] Regression tests for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 (owner: 10Manybubbles) [18:01:02] se4598: hi [18:01:03] so i can help/review where needed. [18:01:41] does mediawiki have a function that takes a url for a wiki page and outputs the Title? [18:02:08] That's great :) Do you know the report from TAO http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/ ? [18:02:20] hoo: i also made a request for a labs instance, so that we can have some of this tested by Graham for instance [18:02:22] https://wikitech.wikimedia.org/wiki/New_Project_Request/accessibility-dev [18:02:39] hoo: yes. i know it. [18:03:10] it's part of why i started working on some accessibility stuff. [18:03:14] I also thought about setting up a test instance, nice to already see a lot work done... I know regret having written my/ our internal documentation in German :P [18:03:47] hoo: well. i requested the instance. we still need to do the whole setup :D [18:04:08] Nemo_bis: any special about https://gerrit.wikimedia.org/r/78647 ? I wonder why you add me as reviewer. qqq is looking correct [18:04:25] hoo: have you installed screenreaders yet ? [18:04:53] thedj: I planned to install NVDA on my netbook [18:05:30] i have JAWS in a virtual machine now. and i test Voice over. [18:06:16] hoo: are you working at the Accessibility_Test_Report_Wikipedia.pdf I saw on Entlinkt's talk page? [18:06:17] This is one of the few times I would like to own a mac (because of VoiceOver) [18:06:25] se4598: Exactly, yes [18:06:29] se4598: I understand you have some practice with FR and German? [18:08:05] liangent: on http://www.mediawiki.org/wiki/Writing_systems/Syntax the foo-{}-bar syntax has the note "There's another way to achieve this, which is more convenient in templates. See below.". What is the better syntax? [18:08:32] thedj: do you jave suggestions for https://meta.wikimedia.org/wiki/Accessibility#Colour-blind-friendly_images ? I'd like a tool to make an automatic assessment of the accessibility of our graphs etc. for colourblind people [18:08:40] (03CR) 10Manybubbles: "Can't be automatically merged, you say? We'll just see about that." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 (owner: 10Manybubbles) [18:08:53] thedj: Should aria-controls rather point to the
    the JS is really altering the visibility of or to the whole TOC? [18:09:36] hoo: it should point to the 'group' that your are controlling the visibility of [18:10:08] Nemo_bis: french? not a bit, fr-0, but german native as some others like hoo :), but I'm mostly only active in dewiki. should I add 1-2 germans as reviewers? [18:10:32] (03CR) 10Jdlrobson: "I've been thinking about this a lot and I actually think using load.php urls is probably best for a first pass." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [18:10:34] Ok, so I guess I have to add an id to the
      and use that [18:11:10] in theory it might be that you can control the whole div. i'm just not sure if it properly works. [18:11:26] oh, could be FR=FlaggedRevs^^ [18:11:35] cscott: -{zh;zh-hans;zh-hant|foobar}- [18:11:44] (on all screenreaders/browser) [18:11:47] se4598: yes, flaggedrevs [18:12:00] hoo: these things would be good to test and document in a few setups. [18:12:30] and then document on our wikipage. [18:12:49] se4598: I don't think that's going to affect German wikis, but the current pidgin English is allegedly a translation from German so help in finding a better one is appreciated (or confirmation that's ok) [18:12:51] (03CR) 10Manybubbles: [C: 032] SearchUpdate cleanups for CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79077 (owner: 10Demon) [18:12:54] (03Merged) 10jenkins-bot: SearchUpdate cleanups for CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79077 (owner: 10Demon) [18:13:16] I guess I can do that, I really need to test that in a real screen reader [18:13:52] maybe I'm just going to set up an own public wiki (on my server) to show changes to blind users, that's probably faster than on labs for now [18:14:23] (03CR) 10Mattflaschen: ""I think we should only implement this if we are going to use it in core also and adopt it as the convention."" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [18:14:41] hoo: yup. You see, i think that for instance using aria-controls works. I'm just not sure about the control being in a collapsed group. In theory that might remove it from the accessibility dom, so that might break your control [18:16:17] (03PS4) 10Manybubbles: Regression tests for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 [18:16:47] mh, I guess I have to test that with a screenreader... that TOC change was mostly a small "test" before touching the sidebar [18:16:54] (03PS5) 10Manybubbles: Regression tests for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 [18:16:57] it only took me a few minute [18:16:58] s [18:17:33] Nemo_bis: How it is handled must be decided by the wikis, but the docu matched that how dewiki uses it (but depends on the user to which deep a change is checked). Can't tell for other wikis. And I don't expect the translation to be modified for german. I add Raymond as reviewer. [18:19:15] (03CR) 10Manybubbles: [C: 032] "Own +2ing after rebasing what Demon's +2ed. Conflict was resolved by taking change from this patch rather than master." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 (owner: 10Manybubbles) [18:19:17] (03Merged) 10jenkins-bot: Regression tests for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 (owner: 10Manybubbles) [18:19:56] hoo: yeah, it indeed is a 'simple' target [18:21:09] Nemo_bis: I don't have enough knowledge of English to find a better translation. maybe ask on a village pump or something like that? [18:21:42] hoo: actually, i see i threw away my changes for the sidebar. [18:22:32] guys, if you want to poke the collapsible sidebar, please merge it into core first :( [18:22:51] that's fine, I guess... I'm probably going to need a lot of code review soonish so that will probably already eat you're spare time :P [18:22:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=46512 [18:22:56] yeah, that still wasn't moved right ? [18:23:01] liangent: thanks. [18:23:47] se4598: oki; not a big deal [18:23:54] hoo: good. If i didn't already had a job, i would have applied for what you are doing now. It's one of my biggest gripes about the codebase. [18:23:55] MatmaRex: ouch, I'm not sure how much that is a block atm, but we certainly need to do this [18:24:57] also, i cc'd you guys on https://bugzilla.wikimedia.org/show_bug.cgi?id=24581 , which i've just found on my cc list when looking for the other one. :P [18:26:24] thedj: I was really surprised to see various things from the report already done [18:27:03] Sadly several of the issues mentioned are either content related or a real mess to fix (as several extensions would be affected) [18:28:20] hoo: i would focus on finding good rules of conduct for the programmers. solving key problems in the core. solving problems in extensions in order of importance and only then see about content. [18:28:58] (03CR) 10Jdlrobson: [C: 031] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [18:29:34] content is difficult. you can't just make up alt descriptions (we do that now in the form of image file name, which is rather dumb i think and so do most bug reporters on this issue). [18:30:44] Yes, that's a problem, I hope that at some point they're accessible in a nice way from commons (as there's a project on structured data on commons). But that's out of reach for now [18:31:21] hoo: you have internationalisation problems there, context problems... [18:31:25] <^demon> manybubbles: So, we don't implement redirect searches yet, do we? [18:31:35] <^demon> Properly, at least. [18:31:44] ^demon: sure we do, but you have to have search redirects button ticked [18:32:02] thedj: Yes, that's why that only makes sense for a few rather high use images, like flags, ... [18:32:07] (03CR) 10Jdlrobson: "So what's the next steps on this. If I make the fix ups are we happy to merge this or do I need to open an RFC / post an e-mail to wikitec" [core] - 10https://gerrit.wikimedia.org/r/75268 (owner: 10Jdlrobson) [18:32:11] hoo: the current idea is: an alt is set with thought. or not at all. we should n't guess what it is that people are illustrating. [18:32:25] <^demon> manybubbles: Heh, can you find a search result that does it as an example? I've never really understood the feature well and I want to see it in action :) [18:32:29] (03CR) 10Jdlrobson: "(only Krinkle seems to object so far...)" [core] - 10https://gerrit.wikimedia.org/r/75268 (owner: 10Jdlrobson) [18:32:35] That's probably the best way to go [18:32:38] hoo: yeah, that might be a good limited usecase. [18:32:39] ^demon: finding one now [18:35:05] if you want editors to add proper alt, the only thing that might work is making some thoughtful options into the new VE image include wizard. [18:36:36] thedj: They don't already have that? I haven't really checked out VE this deep in quite a while... [18:38:27] hoo: me neither. [18:40:00] (03PS2) 10Hoo man: Add aria properties to TOC toggle link [core] - 10https://gerrit.wikimedia.org/r/79053 [18:40:23] thedj: That uses .attr, but it still has the -controls set to the wrapping
      [18:40:54] ^demon: on another note while I look: I can't shell into solr-mw.pmtpa.wmflabs any more. I just hang [18:41:05] <^demon> Hrm. [18:41:39] (03CR) 10Hoo man: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [18:42:14] beta is neight unusable at this point due to timing out over and over and over again [18:42:26] sometimes a few requests sneak through - that is what I was going to point you to [18:42:45] (03CR) 10Hoo man: "Using jQuery.attr now for the aria-* attributes" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [18:42:52] manybubbles: apaches just melted down on beta labs [18:43:04] solr-mw2 is borken because it `git clean`ed it and that removed orig/LocalSettings.php - I was gonna copy the one on solr-mw [18:43:12] hoo: we should add that .prop vs .attr thing to the mediawiki guideline page btw. [18:43:33] ^demon: now that beta is better: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Search&search=rdir&fulltext=Search&profile=default&redirs=1 [18:43:41] Yes, I've stumbled over it far more than once... [18:43:42] i haven't fully confirmed that that is the reason, but it's my strong suspicion. [18:43:47] manybubbles: beta however is working better than it has been and I think Coren has a fix/workaround for the root cause, being NFS I think [18:44:16] chrismcmahon: I'm really hoping his fix solves the problem. [18:45:17] (03PS1) 10Jdlrobson: Allow filtering of notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79086 [18:57:35] (03CR) 10TheDJ: [C: 032] jquery.tablesorter: buildCollationTable() on first sort, not on load [core] - 10https://gerrit.wikimedia.org/r/75671 (owner: 10Matmarex) [18:58:46] (03CR) 10TheDJ: [C: 04-1] "I can't get this to be actually meaningful in a screenreader. So either i'm doing something wrong or this just isn't implemented in any of" [core] - 10https://gerrit.wikimedia.org/r/78950 (owner: 10TheDJ) [19:02:28] (03CR) 10Matmarex: [C: 032] "Simple enough." [core] - 10https://gerrit.wikimedia.org/r/79066 (owner: 10Liangent) [19:05:25] (03Merged) 10jenkins-bot: Don't use $wgVariantArticlePath for variants of non-content languages [core] - 10https://gerrit.wikimedia.org/r/79066 (owner: 10Liangent) [19:08:45] (03PS1) 10Manybubbles: Boost perfect phrase matches. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79087 [19:10:08] (03CR) 10Manybubbles: [C: 04-1] "We shouldn't submit this until we're using a version of elasticsearch with https://github.com/elasticsearch/elasticsearch/issues/3503 reso" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79087 (owner: 10Manybubbles) [19:11:57] thedj: Going to CR your changes tomorrow and see how far I can get with the other things... looking forward to your input ;) [19:13:53] (03CR) 10Aaron Schulz: [C: 032] Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 (owner: 10Demon) [19:15:02] (03CR) 10Brian Wolff: [C: 04-1] "(8 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 (owner: 10MarkTraceur) [19:15:24] anyone interested in language converter? http://www.mediawiki.org/wiki/Requests_for_comment/Scoped_language_converter [19:16:44] liangent is the main person who works on it [19:18:59] (03Merged) 10jenkins-bot: Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 (owner: 10Demon) [19:29:55] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [19:31:25] (03PS13) 10Matmarex: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [19:33:19] (03CR) 10Parent5446: "Running "make" unqualified has weird behavior. At the very least I'd have a default make target at the top that does like composer install" [core] - 10https://gerrit.wikimedia.org/r/75268 (owner: 10Jdlrobson) [19:34:27] (03CR) 10Brian Wolff: "(3 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur) [19:34:41] Yaaaay a bawolff CR. [19:34:52] :) [19:34:55] (03CR) 10TheDJ: [C: 04-1] "I would also add role=button to the link." [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [19:35:06] I really haven't done code review recently enough [19:36:32] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [19:39:39] MatmaRex: question, that pagination patchset. have all comments that have been raised so far been addressed ? [19:40:36] thedj: i think yes [19:56:12] (03CR) 10Mattflaschen: "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 (owner: 10Rjain) [20:00:37] (03CR) 10Mwalker: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [20:02:56] gwicke: back near your original seat? [20:08:42] (03PS1) 10CSteipp: Fixes for getting signed post variables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79154 [20:09:24] (03Abandoned) 10CSteipp: Simplify handling of API POST requests [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 (owner: 10CSteipp) [20:20:23] Hah, I <3 it when people say "Scribuntu" [20:22:31] (03PS1) 10CSteipp: Start a session for the OAuth user [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79155 [20:25:33] (03PS4) 10Brian Wolff: Don't display empty preference sections [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [20:25:57] (03CR) 10Brian Wolff: "PS4: minor change (whitespace fix, rm unused variable)" [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [20:26:35] (03PS5) 10Brian Wolff: Don't display empty preference sections [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [20:27:17] csteipp: https://gerrit.wikimedia.org/r/#/c/79154/1/backend/MWOAuthRequest.php [20:27:22] (03CR) 10Brian Wolff: [C: 032] "Appears to work as advertised" [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [20:27:22] what's with the tabbing? [20:27:35] Woo, grazie bawolff [20:27:44] No longer important for us, I think, but still [20:28:08] Its something that should be fixed anyhow [20:28:17] Truth [20:29:19] (03PS3) 10Spage: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 [20:31:08] (03Merged) 10jenkins-bot: Don't display empty preference sections [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [20:35:58] (03PS10) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [20:36:58] (03PS2) 10CSteipp: Added $wgMWOAuthSharedUserSource to avoid ambiguity if two extensions handle the hooks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:36:59] (03CR) 10jenkins-bot: [V: 04-1] Added $wgMWOAuthSharedUserSource to avoid ambiguity if two extensions handle the hooks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:37:24] (03PS3) 10CSteipp: Added $wgMWOAuthSharedUserSource to avoid ambiguity if two extensions handle the hooks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:37:25] (03CR) 10jenkins-bot: [V: 04-1] Added $wgMWOAuthSharedUserSource to avoid ambiguity if two extensions handle the hooks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:39:58] (03PS11) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [20:41:03] (03PS4) 10CSteipp: Added $wgMWOAuthSharedUserSource to avoid ambiguity if two extensions handle the hooks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:41:34] (03CR) 10CSteipp: [C: 032 V: 032] "PS4 was a manual rebase to fix conflicts" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77991 (owner: 10Aaron Schulz) [20:41:54] ^d: poke? [20:42:18] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79154 (owner: 10CSteipp) [20:42:49] (03CR) 10Werdna: [C: 032 V: 032] Extract timestamps from UUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79068 (owner: 10EBernhardson (WMF)) [20:46:07] (03PS1) 10Rudolf.grossmann: Added an i18n message used by the applet generated by the extension (2nd try with Linux line endings) [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/79156 [20:46:08] (03PS1) 10Rudolf.grossmann: Added an i18n message used by the applet generated by the extension (2nd try with Linux line endings) Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FormelApplet into permil [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/79157 [20:51:51] (03PS7) 10Alex Monk: i18n issues reported on https://translatewiki.net/wiki/User:Mlitn [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 (owner: 10Matthias Mullie) [20:52:11] (03CR) 10Alex Monk: "(removed dupe thread from links)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 (owner: 10Matthias Mullie) [20:59:04] (03PS1) 10Legoktm: "Also" should be lower case [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79158 [20:59:55] (03CR) 10Legoktm: [C: 032] "Also" should be lower case [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79158 (owner: 10Legoktm) [21:00:00] (03Merged) 10jenkins-bot: "Also" should be lower case [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/79158 (owner: 10Legoktm) [21:00:46] <^d> werdna: Ow! [21:03:36] ^d: Is there a way to add people automatically to all gerrit changesets on a project? [21:03:50] <^d> Add them as reviewers? No. [21:03:58] <^d> You can watch projects though so you'll get notifs. [21:04:11] how does one watch a project? [21:04:13] werdna: there kind of is [21:04:18] werdna: yes there is-ish [21:04:23] werdna: https://www.mediawiki.org/wiki/Git/Reviewers [21:04:26] werdna: so, to watch a project, you can add it in your settings [21:04:59] sumanah: thanks [21:08:55] (03CR) 10Alex Monk: [C: 032] i18n issues reported on https://translatewiki.net/wiki/User:Mlitn [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 (owner: 10Matthias Mullie) [21:08:59] (03Merged) 10jenkins-bot: i18n issues reported on https://translatewiki.net/wiki/User:Mlitn [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 (owner: 10Matthias Mullie) [21:09:32] werdna: glad to help -- it's also possible to favstar a changeset I believe [21:18:46] (03CR) 10Werdna: [C: 032 V: 032] "Looks fine, might be worth letting Matthias take a look over it first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [21:19:45] (03PS3) 10Werdna: New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 (owner: 10EBernhardson (WMF)) [21:25:55] (03CR) 10Werdna: "Can we abandon this?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78836 (owner: 10Matthias Mullie) [21:28:58] (03CR) 10TheDJ: "Ideally, we'd track the selected page in the url fragment, but we don't really have existing conventions for that when it comes to content" [core] - 10https://gerrit.wikimedia.org/r/62005 (owner: 10Balloonguy) [21:36:11] (03PS1) 10Miguel2706: New system release [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79159 [21:36:13] (03PS2) 10Rachel99: WIP continuing Headings test scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 [21:36:14] (03CR) 10Miguel2706: [C: 032 V: 032] New system release [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79159 (owner: 10Miguel2706) [21:41:55] (03CR) 10Legoktm: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79031 (owner: 10Legoktm) [21:42:12] (03PS2) 10Legoktm: action=edit API with section=new would fail if page didn't exist [core] - 10https://gerrit.wikimedia.org/r/79031 [21:42:23] (03PS2) 10CSteipp: Start a session for the OAuth user [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79155 [21:54:13] <^d> manybubbles: The backend query param stuff is live on beta. So on an API request you can use ?srbackend=foo, and on a Special:Search request you can ?backend=foo [21:57:48] ori-l: you in the office today? [21:58:07] Not at his desk [21:58:12] Oh jesus this merge is hell [21:58:21] https://gerrit.wikimedia.org/r/#/c/79023/1/templates/topic.html.php versus https://gerrit.wikimedia.org/r/#/c/78478/11/templates/topic.html.php [22:06:08] (03CR) 10Aaron Schulz: [C: 032 V: 032] Start a session for the OAuth user [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79155 (owner: 10CSteipp) [22:09:34] (03PS2) 10Aaron Schulz: Fixes for getting signed post variables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79154 (owner: 10CSteipp) [22:10:23] (03CR) 10Aaron Schulz: [C: 032 V: 032] Fixes for getting signed post variables [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79154 (owner: 10CSteipp) [22:17:25] <^d> memcached keys with spaces in them suck. [22:17:47] <^d> And mcc.php sucks for not giving you a way to work with them. [22:24:42] (03PS1) 10Demon: Spaces in memcached keys are annoying [core] - 10https://gerrit.wikimedia.org/r/79164 [22:25:16] ^d: :) [22:25:25] [22:25:37] <^d> SpecialVersion::getVersion( 'nodb' ) probably made sense at the time when that was written. [22:25:59] <^d> But nowadays that returns something like "1.22alpha (d51f688)" [22:26:08] (03CR) 10Aaron Schulz: [C: 032] Spaces in memcached keys are annoying [core] - 10https://gerrit.wikimedia.org/r/79164 (owner: 10Demon) [22:29:34] (03Merged) 10jenkins-bot: Spaces in memcached keys are annoying [core] - 10https://gerrit.wikimedia.org/r/79164 (owner: 10Demon) [22:35:52] (03PS1) 10Aaron Schulz: Renamed mwoauthupdateconsumer => mwoauthupdateownconsumer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79166 [22:49:40] (03CR) 10MarkTraceur: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [22:57:03] (03PS5) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [23:01:28] Krinkle|detached: https://gerrit.wikimedia.org/r/67885 is ready to be merged IMO [23:01:43] If you have negative comments, speak soon, we'd like to get it in before the branch [23:17:01] (03CR) 10MarkTraceur: [C: 031] "(4 comments)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/69455 (owner: 10Brian Wolff) [23:21:32] marktraceur: Interesting, I didn't realize rgba worked cross-platform [23:22:04] Doesn't it? [23:22:07] * marktraceur makes sure [23:22:22] http://caniuse.com/#search=rgba [23:22:30] IE 9 and up...hm [23:22:34] *maybe* [23:22:43] that cuts out about 6% of our user base [23:22:57] Yeah [23:23:05] Maybe you had the right idea :) [23:23:31] hmm, I don't even remember at this point how much I tested the opacity thing on IE [23:23:40] I remember it didn't work on IE6, and I decided not to care [23:23:54] Hah [23:24:09] I think not-caring might not be a problem [23:24:21] although that may have been because I was running IE6 under wine, it seemed to not like opacity whatsoever [23:25:48] I'm just going to leave it as is, if that's ok [23:26:19] bawolff: I meant every comment as minor, for followup patches [23:27:47] well they are easy fixes [23:28:06] Yup [23:28:10] (03PS19) 10Brian Wolff: New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 [23:28:27] But, I'd rather get it merged than go down the rabbit hole even more...ah, never mind. [23:28:35] (03CR) 10jenkins-bot: [V: 04-1] New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [23:28:56] damn you jenkins-bot [23:29:00] Muahaha. [23:29:04] Probably merge conflict [23:29:35] yeah, stupid release notes [23:29:42] Heh, yeah [23:30:02] <^d> Hey, they don't conflict as much as they used to ;-) [23:30:18] (03PS20) 10Brian Wolff: New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 [23:30:27] (03CR) 10Brian Wolff: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [23:30:47] bawolff: Wait wait - did you already add getting the "right" description from the information template based on the user language, in core? [23:31:11] ^d: Honestly, they still conflict for me most of the time [23:31:28] <^d> They don't for most people most of the time :p [23:31:30] marktraceur: no. I submitted a patch for the non-commons specific stuff [23:33:29] Ah, cool [23:34:40] (03PS6) 10Aaron Schulz: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [23:38:40] marktraceur: I'm going to fix your minor comments on the TMH patch too [23:39:24] KK [23:42:33] bawolff: Protip, toggleClass takes a second boolean argument [23:43:01] Don't feel bad, I didn't know either until recently [23:43:42] hmm, interesting [23:43:56] That makes it about equivalent to addClass/removeClass though [23:44:20] Pretty much [23:44:36] But shorter. And nicer lookin'. And I think Krinkle|detached said it was a bit faster. [23:46:39] The first comment on the TMH patch, what specificly is wrong with the spacing there? [23:48:44] marktraceur: Do you mean, I should have a space between 'function' and '(' for the inline function definition? [23:48:53] Yup [23:50:00] (03CR) 10Brian Wolff: "(1 comment)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/69455 (owner: 10Brian Wolff) [23:50:38] (03PS6) 10Brian Wolff: [Goes with I33462a8] Support for new gallery. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/69455 [23:55:58] (03PS21) 10Brian Wolff: New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 [23:56:29] --^ is changing to toggleClass