[00:03:32] (03CR) 10DMaggot: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [00:04:43] (03PS7) 10Demon: Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 [00:05:08] (03CR) 10jenkins-bot: [V: 04-1] Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [00:06:39] (03CR) 10DMaggot: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [00:09:17] (03PS8) 10Demon: Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 [00:09:25] ^d: Sweet. :-) Does a lack of an entry mean 0 reviewers? [00:09:36] ^d: It seems to start at 6,619. [00:09:41] (03PS1) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 [00:09:49] <^d> Possibly? I'd have to look at the query again. [00:09:58] <^d> I just kinda copy+pasted what you and Christian gave me :) [00:10:15] Heh. [00:10:28] Wait... [00:10:31] It's .js? [00:10:54] Something strange there. [00:12:13] <^d> Grrr. [00:12:22] <^d> Typos suckkkk [00:12:25] :-) [00:12:47] Yeah, so it should probably be .json. And the results are incomplete. [00:13:11] <^d> Lemme move the file, that's easy. [00:13:43] <^d> Ok, should be .json now [00:14:23] Cool. [00:14:29] Now we just gotta figure out what's wrong with the query. [00:15:19] (03CR) 10Demon: "PS7 took care of the null issue in the API, PS8 was a rebase." [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [00:15:46] <^d> AaronSchulz: Can you look at ^? [00:20:46] <^d> Elsie: Um, this is weird. http://p.defau.lt/?XeY_5g8lrYwjWblQzZVGrQ [00:21:13] <^d> Also, http://p.defau.lt/?jCpuyydNlolPWhMOuN9ekA [00:25:42] ^d: So the change_id table is incomplete, I guess? [00:25:52] <^d> Looks like it might be. [00:26:29] Weird. [00:26:40] We know that there are reviewers for older changes. [00:26:47] So perhaps it's just querying the wrong table or something. [00:27:07] I don't know Gerrit's schema at all or have access to a test copy. [00:37:58] <^d> Elsie: I can get you a copy of the schema :) [00:38:35] I'd rather Gerrit be publicly replicated. [00:38:39] If it were, I would've never had to file this bug. [00:38:50] But, y'know, drafts and shit. [00:38:53] The horror. [00:40:56] <^d> http://gerrit.wikimedia.org/gerrit.sql [00:43:49] (03PS4) 10Mollywhite: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 [00:43:50] (03CR) 10jenkins-bot: [V: 04-1] Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [00:44:06] <^d> Elsie: I've been rethinking the drafts. I'm still pissed how they're implemented, but I'm thinking there's a path forward. [00:45:08] The point wasn't really about drafts. [00:45:52] Wikimedia has invested heavily in setting up replicated databases. [00:46:02] As there's enormous demonstrated value in allowing users to have access. [00:46:03] And yet. [00:47:12] <^d> I've changed my mind, I'm willing to replicate the gerrit db provided 2 things. [00:47:40] <^d> A) Anything security that's not public should either be made public or removed, and gerrit stop being used for security patches. [00:48:23] <^d> B) I can sanitize one column. There's one column I'm not ok with exposing. [00:49:46] Which column? [00:50:53] <^d> account_external_ids.password [00:51:12] <^d> That's used if you generate a password to access gerrit over https :) [00:52:04] Is that even possible? [00:52:09] I thought clones via HTTPS were prohibited. [00:52:30] <^d> Of course it is, always has been. [00:52:51] <^d> How would you anonymously clone without https? :) [00:53:52] ^d: Anonymously cloning with a password? I don't follow. [00:53:57] That doesn't seem very anonymous. [00:54:10] <^d> You'd use the password for write operations. [00:54:12] authenticated clones * [00:54:31] Can you commit via HTTPS? I was told it was disallowed. [00:54:39] (03PS3) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [00:55:07] \o/ [00:55:08] <^d> Elsie: No, it's always been enabled. [00:55:11] Okay. [00:55:20] Well, in any case, okay, filter a column. That's trivial. [00:55:21] Real Flow has AJAX post & reply. It's very sexy. [00:55:26] We filter far more important columns. [00:55:44] <^d> Indeed. [00:56:26] dbbot? [00:57:01] <^d> @replag [00:57:02] ^d: [s2] db1009: 103852s; [s6] db1040: 1s [00:57:10] <^d> werdna: Guess we have that here now too? [00:57:19] ? [00:57:26] <^d> That's all dbbot does. [00:57:32] <^d> It's been in -ops for awhile now. [00:57:33] very exciting [01:00:22] -operations [01:00:29] -ops is IRC-related. [01:03:03] I was in there once, but it was just a cesspool of unnecessary drama [01:03:14] I suppose that any time a channel operator is involved, it's due to drama. [01:03:53] (03PS4) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [01:04:03] hmm, I don't really know what to do next, I don't feel like working on error handling [01:04:10] It *is* 6pm, maybe I should go home. [01:24:41] [07:16:08 AM] The bot cannot be blocked, as I understand it. <-- Yes you can, it's just a normal user account. [01:24:48] Nemo_bis: ^ [01:27:33] (03PS1) 10Legoktm: Use self:: instead of MassMessage:: [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78927 [01:27:34] (03PS1) 10Legoktm: Fix spacing [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78928 [01:27:54] (03PS1) 10Legoktm: The checkbox for sending a global message was removed in 8b5027342. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78929 [01:28:14] (03PS4) 10Legoktm: Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 [01:28:15] (03CR) 10jenkins-bot: [V: 04-1] Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [01:28:27] (03PS1) 10Legoktm: Fix logging of failures [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78930 [01:29:41] (03CR) 10Tim Starling: "Good point." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie) [01:32:52] (03PS2) 10Tim Starling: More-compatible Linux standalone binaries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie) [01:32:58] (03CR) 10Tim Starling: [C: 032] More-compatible Linux standalone binaries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie) [01:34:57] (03Merged) 10jenkins-bot: More-compatible Linux standalone binaries [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie) [01:39:19] (03PS4) 10Tim Starling: getConfiguration.php now supports regex [core] - 10https://gerrit.wikimedia.org/r/17069 (owner: 10Hashar) [01:39:29] (03CR) 10Tim Starling: [C: 032] getConfiguration.php now supports regex [core] - 10https://gerrit.wikimedia.org/r/17069 (owner: 10Hashar) [01:43:48] (03Merged) 10jenkins-bot: getConfiguration.php now supports regex [core] - 10https://gerrit.wikimedia.org/r/17069 (owner: 10Hashar) [01:51:20] (03CR) 10Tim Starling: [C: 04-1] "That's an O(N) regex. It seems like a lot of overhead for something that could be easily dealt with at the one affected caller, with Xml::" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [01:55:10] (03CR) 10Tim Starling: "That is, O(N) in the full length of the string even for strings that have a "bad" character at the start but don't contain a backslash. PC" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [01:55:54] (03CR) 10Parent5446: "Couldn't this easily be solved by just doing a substr() to get the last character and seeing if it's a backslash?" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:14:50] (03CR) 10Tim Starling: "Yes, but I still think the caller is the right place to handle this. The caller needs a particular text string, "+\", so maybe it should j" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:19:43] (03CR) 10Parent5446: "But why is handling it here so bad? The idea that if there's a backslash in an attribute it will be trimmed is not something unique to the" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:20:34] (03CR) 10Tim Starling: [C: 04-1] "The variable name should be prefixed with a string that is specific to the extension." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/63418 (owner: 10J) [02:23:33] (03PS5) 10Mollywhite: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 [02:24:08] (03CR) 10Tim Starling: "The returned string *does* represent the actual requested attribute text, before this change. The issue Daniel is complaining about is tha" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:29:33] (03PS8) 10Tim Starling: Replace remaining sajax use [core] - 10https://gerrit.wikimedia.org/r/65641 (owner: 10Alex Monk) [02:29:49] (03CR) 10Tim Starling: [C: 032] Replace remaining sajax use [core] - 10https://gerrit.wikimedia.org/r/65641 (owner: 10Alex Monk) [02:30:37] (03PS1) 10Mwjames: \SMW\Test\FeedResultPrinterTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78931 [02:34:04] (03CR) 10Mwjames: [C: 032] \SMW\Test\FeedResultPrinterTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78931 (owner: 10Mwjames) [02:34:10] (03Merged) 10jenkins-bot: Replace remaining sajax use [core] - 10https://gerrit.wikimedia.org/r/65641 (owner: 10Alex Monk) [02:35:29] (03Merged) 10jenkins-bot: \SMW\Test\FeedResultPrinterTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78931 (owner: 10Mwjames) [02:37:31] (03CR) 10Mollywhite: [C: 032 V: 032] Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [02:37:33] (03Merged) 10jenkins-bot: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [02:37:36] (03PS4) 10Tim Starling: jobqueue: cleaned up JobQueue exception handling [core] - 10https://gerrit.wikimedia.org/r/69451 (owner: 10Aaron Schulz) [02:37:42] (03CR) 10Tim Starling: [C: 032] jobqueue: cleaned up JobQueue exception handling [core] - 10https://gerrit.wikimedia.org/r/69451 (owner: 10Aaron Schulz) [02:42:08] (03Merged) 10jenkins-bot: jobqueue: cleaned up JobQueue exception handling [core] - 10https://gerrit.wikimedia.org/r/69451 (owner: 10Aaron Schulz) [02:45:09] (03CR) 10Parent5446: [C: 04-1] "Ah, I misunderstood. I agree with Tim now." [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [03:07:50] (03CR) 10Tim Starling: [C: 04-2] "Most of this was superseded by the removal of hphpc support." [core] - 10https://gerrit.wikimedia.org/r/49208 (owner: 10Waldir) [03:53:44] Sigh. [03:56:37] (03PS1) 10Mollywhite: Bug 50672: JavaScript fallback for navbar [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78932 [04:07:36] (03PS5) 10MZMcBride: Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [04:07:37] (03CR) 10jenkins-bot: [V: 04-1] Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [04:21:15] * Nemo_bis is very tempted to quote demon about gerrit DB replication on the bug [04:22:59] Go for it. [04:23:30] I just copied you on https://bugzilla.wikimedia.org/show_bug.cgi?id=52777 [04:29:50] (03CR) 10Tim Starling: [C: 04-2] "I don't think this is acceptable in terms of DB performance. I filed bug 52777 with the details." [core] - 10https://gerrit.wikimedia.org/r/68297 (owner: 10Bsitu) [04:33:31] (03PS1) 10EBernhardson (WMF): edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 [04:36:37] (03PS2) 10Tim Starling: Deleting a page and then immediately create-protecting it caused a PHP Fatal error [core] - 10https://gerrit.wikimedia.org/r/48435 (owner: 10Owyn) [04:39:13] (03CR) 10Tim Starling: "PS2: Rewritten, untested." [core] - 10https://gerrit.wikimedia.org/r/48435 (owner: 10Owyn) [04:42:25] (03PS2) 10Tim Starling: Make wfReadOnly() a wrapper around wfReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/63109 (owner: 10PleaseStand) [04:43:21] (03CR) 10Tim Starling: [C: 032] Make wfReadOnly() a wrapper around wfReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/63109 (owner: 10PleaseStand) [04:46:54] (03Merged) 10jenkins-bot: Make wfReadOnly() a wrapper around wfReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/63109 (owner: 10PleaseStand) [05:09:00] * werdna just fixed another SemanticForms bug. Turns out they were using if ( strpos ) instead of if ( strpos !== false ) [05:09:02] faiiiiil [05:27:53] (03CR) 10Legoktm: [C: 032] The checkbox for sending a global message was removed in 8b5027342. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78929 (owner: 10Legoktm) [05:28:02] (03Merged) 10jenkins-bot: The checkbox for sending a global message was removed in 8b5027342. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78929 (owner: 10Legoktm) [05:28:08] (03CR) 10Legoktm: [C: 032] Use self:: instead of MassMessage:: [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78927 (owner: 10Legoktm) [05:28:12] (03Merged) 10jenkins-bot: Use self:: instead of MassMessage:: [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78927 (owner: 10Legoktm) [05:28:44] (03CR) 10Legoktm: [C: 032] Fix spacing [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78928 (owner: 10Legoktm) [05:28:49] (03Merged) 10jenkins-bot: Fix spacing [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78928 (owner: 10Legoktm) [05:36:45] (03PS6) 10Legoktm: Add an HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 [05:37:08] Elsie: How does ^ look now? [05:37:27] Sleep. [05:38:20] Oh [05:38:23] good night then :) [05:40:32] Night. [05:50:18] (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 (owner: 10Anomie) [05:54:06] (03PS16) 10Tim Starling: Add limit report data on preview pages [core] - 10https://gerrit.wikimedia.org/r/53802 (owner: 10Anomie) [05:54:48] (03CR) 10Tim Starling: [C: 032] Add limit report data on preview pages [core] - 10https://gerrit.wikimedia.org/r/53802 (owner: 10Anomie) [05:58:43] (03Merged) 10jenkins-bot: Add limit report data on preview pages [core] - 10https://gerrit.wikimedia.org/r/53802 (owner: 10Anomie) [06:48:46] (03PS1) 10Raimond Spekking: Make some messages optional [core] - 10https://gerrit.wikimedia.org/r/78936 [06:49:23] (03CR) 10Raimond Spekking: [C: 032] Make some messages optional [core] - 10https://gerrit.wikimedia.org/r/78936 (owner: 10Raimond Spekking) [06:53:02] (03Merged) 10jenkins-bot: Make some messages optional [core] - 10https://gerrit.wikimedia.org/r/78936 (owner: 10Raimond Spekking) [07:11:33] (03PS1) 10Aaron Schulz: Added batchFetchFromURLs() for mwstore backend [core] - 10https://gerrit.wikimedia.org/r/78938 [07:42:22] (03PS1) 10Aaron Schulz: Removed unused $dbw variable and connection [core] - 10https://gerrit.wikimedia.org/r/78940 [07:44:20] (03PS1) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 [07:46:19] (03PS1) 10Legoktm: [WIP] Initial commit [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/78942 [07:54:17] (03CR) 10PleaseStand: "This patch set doesn't include my PHPUnit tests and JSON fuzzer, which currently live in a repo on GitHub (03CR) 10PleaseStand: "Also, which of the possible PHP bugs I found are worth reporting and fixing?" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [09:03:29] (03CR) 10Legoktm: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [09:04:03] (03PS2) 10Legoktm: Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 [09:41:47] (03PS3) 10Legoktm: [WIP] Add a hook for extensions to use to add actions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/78491 [09:42:08] (03CR) 10Legoktm: "(6 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/78491 (owner: 10Legoktm) [09:44:03] (03CR) 10Legoktm: "AbuseFilter::getAvailableActions() now also reads from $wgAbuseFilterCustomActionsHandlers and will add the callback function if set. So i" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/78491 (owner: 10Legoktm) [09:52:36] (03CR) 10Tpt: [C: 032] "Minor change" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/78831 (owner: 10Tpt) [09:52:42] (03Merged) 10jenkins-bot: Multiline templates aren't well escaped [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/78831 (owner: 10Tpt) [10:22:55] (03CR) 10Matthias Mullie: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78915 (owner: 10EBernhardson (WMF)) [10:53:00] (03PS1) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [10:55:51] (03PS3) 10Ori.livneh: Support LESS stylesheets in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/78669 [11:08:27] (03CR) 10Ori.livneh: "PS3: Updating imported files now triggers cache invalidation; '@import' is thus supported." [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [11:23:26] (03PS2) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [11:25:47] (03CR) 10Matthias Mullie: [C: 032 V: 032] "Tested both with & without ES." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78313 (owner: 10EBernhardson (WMF)) [11:34:07] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [11:39:27] (03PS3) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [11:44:35] (03PS1) 10TheDJ: Accessibility: Add directory landmark role to our ToC [core] - 10https://gerrit.wikimedia.org/r/78950 [11:47:22] (03CR) 10jenkins-bot: [V: 04-1] Accessibility: Add directory landmark role to our ToC [core] - 10https://gerrit.wikimedia.org/r/78950 (owner: 10TheDJ) [11:48:27] (03CR) 10TheDJ: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76068 (owner: 10Matmarex) [12:05:33] (03PS2) 10Zfilipin: README update for Windows environment [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75528 (owner: 10Plavi) [12:05:42] (03CR) 10Zfilipin: [C: 032] README update for Windows environment [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75528 (owner: 10Plavi) [12:38:07] (03PS1) 10Matmarex: Throw MWException instead of Exception [extensions/timeline] - 10https://gerrit.wikimedia.org/r/78955 [12:39:06] (03PS2) 10Matmarex: EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a [core] - 10https://gerrit.wikimedia.org/r/76068 [12:39:14] (03PS2) 10Liangent: Remove duplicated blocked parts reported by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43496 [12:39:19] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76068 (owner: 10Matmarex) [12:39:25] (03PS3) 10Liangent: Remove duplicated blocked parts reported by SpamBlacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/43496 [12:39:52] (03PS3) 10Matmarex: EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a [core] - 10https://gerrit.wikimedia.org/r/76068 [12:43:36] (03CR) 10Liangent: "... and I don't think it's a good idea to mix another thing (adding tests for this extension generally) to this patch." [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/47333 (owner: 10Liangent) [12:47:04] (03CR) 10Matmarex: [C: 04-1] "Parser tests need updating to reflect new HTML. Also, is there a simple way we could get someone who will actually use this, like Graham, " [core] - 10https://gerrit.wikimedia.org/r/78950 (owner: 10TheDJ) [12:55:33] (03PS2) 10Liangent: Add converted namespace names as aliases to avoid confusion. [core] - 10https://gerrit.wikimedia.org/r/53740 [12:56:38] (03CR) 10jenkins-bot: [V: 04-1] Add converted namespace names as aliases to avoid confusion. [core] - 10https://gerrit.wikimedia.org/r/53740 (owner: 10Liangent) [12:57:51] (03CR) 10Liangent: "@Nikerabbit: Actually everything in question was designed to keep close to the original findVariantLink function..." [core] - 10https://gerrit.wikimedia.org/r/62600 (owner: 10Liangent) [12:57:56] (03CR) 10Nikerabbit: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm) [13:02:00] (03PS3) 10Liangent: Add converted namespace names as aliases to avoid confusion. [core] - 10https://gerrit.wikimedia.org/r/53740 [13:40:40] (03PS4) 10Alex Monk: Fire Echo event when revision is rejected [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/62193 [13:50:01] (03PS2) 10Alex Monk: Add JS hook for user scripts to add buttons to all LQT textareas as they are created [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 [13:50:57] (03PS2) 10Alex Monk: Don't record changes to subjects if there's no real change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/67558 [13:54:42] (03PS4) 10Alex Monk: Prompt the user to confirm a page change while an LQT edit form is open [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/59159 [14:01:20] hey, Krenair [14:01:30] hi [14:01:55] i think you want to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=52510 :D [14:02:33] (re "Fire Echo event when revision is rejected" patch) [14:04:17] >.> [14:06:45] (03CR) 10Matmarex: [C: 032] Don't record changes to subjects if there's no real change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/67558 (owner: 10Alex Monk) [14:06:47] (03Merged) 10jenkins-bot: Don't record changes to subjects if there's no real change [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/67558 (owner: 10Alex Monk) [14:06:51] <3 [14:07:16] thanks [14:09:02] Krenair: https://gerrit.wikimedia.org/r/#/c/39862/ ready to merge? [14:10:27] I haven't checked the latest patch set of that (by spage) [14:12:25] Perhaps the message key should be reconsidered [14:14:06] i think it's consistent with a bunch of other keys [14:14:38] but probably shouldn't be in the prefs group, actually. [14:14:47] (in messages.inc) [14:15:05] $template->set( 'ownaccount', $this->getUser()->isLoggedIn() ); seems unused? [14:15:35] hm, yeah [14:15:41] letover from previous patchsets? [14:15:42] leftover* [14:17:05] yes [14:17:50] If you compare the english text of prefs-help-realname and createacct-another-realname-tip it does sort of make sense for them to be together [14:18:28] but at the same time it doesn't make sense to rename createacct-another-realname-tip to have a prefs- prefix because it won't be used in prefs, just the signup form [14:19:15] yeah [14:19:30] i think there are a few messageslike this already from the other patch for this [14:19:40] (03PS11) 10Alex Monk: Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 [14:20:25] new PS removes the unused template data var [14:21:14] and yeah the other patch did this with userlogin-yourname-ph and createacct-another-username-ph - https://gerrit.wikimedia.org/r/#/c/72841/5/languages/messages/MessagesEn.php [14:21:30] So I think it's okay to merge [14:22:55] i'll test and merge in a few minutes [14:31:32] (03PS12) 10Matmarex: Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:32:00] (rebased) [14:38:25] (03PS13) 10Matmarex: Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:38:37] Krenair: i poked the commit message. okay with you? [14:39:05] lgtm [14:40:25] (03CR) 10Matmarex: [C: 04-1] "The 'createacct-another-realname-tip' message really should be in the "login" seciton in messages.inc etc." [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:40:27] also, this ^ :) [14:40:37] want me to fix? [14:40:56] well then you couldn't merge it [14:41:32] meh, i could, that's trivial and you'd +1, wouldn't you? [14:41:58] Anyway we already discussed this [14:42:06] that's barely more than fixing a typo or a whitespace issue [14:42:09] and yeah the other patch did this with userlogin-yourname-ph and createacct-another-username-ph - https://gerrit.wikimedia.org/r/#/c/72841/5/languages/messages/MessagesEn.php [14:42:22] So I think it's okay to merge [14:44:43] ipse dixit? [14:44:49] ? [14:45:05] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78915 (owner: 10EBernhardson (WMF)) [14:46:01] yeah, but my point is [14:46:09] actually, i'm not sure what the point is [14:46:36] but i don't like that this message is in the "preferences" group when it'snever shown in preferences [14:46:41] do we want to change that? [14:46:53] (i mean the groups in messages.inc) [14:47:18] (03CR) 10Matthias Mullie: [C: 032 V: 032] New Topic action: edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78915 (owner: 10EBernhardson (WMF)) [14:48:12] MatmaRex: maybe [14:48:45] (03PS2) 10Matthias Mullie: New Topic action: edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78915 (owner: 10EBernhardson (WMF)) [14:49:06] (03CR) 10Matthias Mullie: [C: 032 V: 032] New Topic action: edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78915 (owner: 10EBernhardson (WMF)) [14:49:49] heh [14:50:14] (03PS14) 10Matmarex: Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:50:26] then we do [14:51:04] (03CR) 10Matmarex: "Changed that myself." [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:51:04] Krenair: +1? ^ [14:52:04] (03CR) 10Alex Monk: [C: 031] Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:53:29] (03CR) 10Matmarex: [C: 032] "My changes were trivial, LGTM." [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [14:54:58] (03CR) 10TheDJ: "Well I don't have a public installation (and don't intend to maintain one), but perhaps we could setup a wmf labs instance and cherrypick " [core] - 10https://gerrit.wikimedia.org/r/78950 (owner: 10TheDJ) [14:56:03] (03Merged) 10jenkins-bot: Tweak login/account creation for logged in users [core] - 10https://gerrit.wikimedia.org/r/39862 (owner: 10Alex Monk) [15:02:08] (03PS17) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [15:07:26] Krenair, MatmaRex: are you able to access userlogin on beta after logging in? [15:07:30] Request: GET http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:UserLogin, from 127.0.0.1 via deployment-cache-text1 deployment-cache-text1 ([127.0.0.1]:3128), Varnish XID 1051176945 [15:07:34] Forwarded for: 91.153.141.143, 127.0.0.1 [15:07:36] Error: 503, Service Unavailable at Tue, 13 Aug 2013 15:06:58 GMT [15:12:24] and now it worked [15:18:38] (03CR) 10Alex Monk: [C: 04-1] "Adding this to mw.fileApi.js's isSliceAvailable fixes that:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/3808 (owner: 10Drecodeam) [15:22:24] (03PS2) 10EBernhardson (WMF): edit-post action for Topic block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78933 [15:26:54] (03PS1) 10TheDJ: Accessibility: Add aria-labelledby to the navigation landmarks [core] - 10https://gerrit.wikimedia.org/r/78961 [15:59:58] (03CR) 10Matmarex: [C: 031] "Yep, it looks okay. Thank you, Adam!" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/47336 (owner: 10Matmarex) [16:09:28] (03PS2) 10TheDJ: Accessibility: Add directory landmark role to our ToC [core] - 10https://gerrit.wikimedia.org/r/78950 [16:20:28] (03CR) 10Matmarex: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78500 (owner: 10TheDJ) [16:24:38] (03PS1) 10Mwjames: Add some coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78962 [16:26:24] (03CR) 10Mwjames: [C: 032] Add some coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78962 (owner: 10Mwjames) [16:27:46] (03Merged) 10jenkins-bot: Add some coverage [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78962 (owner: 10Mwjames) [16:41:34] (03PS1) 10Zfilipin: WIP Moved Cucumber hooks to hooks.rb file [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78963 [16:43:51] (03PS1) 10Mwjames: \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 [16:45:14] (03CR) 10jenkins-bot: [V: 04-1] \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames) [16:46:37] (03CR) 10Mwjames: "Fails because of" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames) [17:12:09] (03Abandoned) 10Mwjames: \SMW\Setup + \SMW\HooksExtender, create testable hooks instantiation [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/73551 (owner: 10Mwjames) [17:27:49] (03PS1) 10Subramanya Sastry: Revert "Make line breaks in
behave like
(bug 6200)." See bug 52763 [core] - 10https://gerrit.wikimedia.org/r/78967 [17:28:14] (03CR) 10jenkins-bot: [V: 04-1] Revert "Make line breaks in
behave like
(bug 6200)." See bug 52763 [core] - 10https://gerrit.wikimedia.org/r/78967 (owner: 10Subramanya Sastry) [17:36:04] (03PS1) 10Carolsand: WIP Testing if Gerrit is setup correctly. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78968 [17:41:10] (03CR) 10Adamw: [C: 032 V: 032] Specify width and height of SVG images to ensure they are rasterized properly [extensions/timeline] - 10https://gerrit.wikimedia.org/r/47336 (owner: 10Matmarex) [17:48:42] ^d, ping [17:48:52] <^d> PONG [17:48:55] <^d> whoops, caps. [17:48:57] <^d> Sup? [17:49:14] so, https://gerrit.wikimedia.org/r/#/c/78967/ .. jenkins is complaining about rebase required on a revert. i found out that it is release notes that conflicts. [17:49:42] is there a simple solution to this? one possibility is for me to push a commit to release notes that puts it in a state that git/gerrit is happy with and then revert that patch. [17:49:47] any other ideas? [17:50:08] <^d> Rebase the patch on top of master, then re-submit? [17:50:27] <^d> If it's conflicting in gerrit, it'll likely conflict locally and require resolving. [17:50:39] <^d> We improved the merge algorithm awhile ago :) [17:50:41] yes, it does. [17:51:21] ok, so, revert will work even after rebase? will try. [17:52:04] <^d> Actually, I've got a rebased version, I can just submit that for you. [17:52:15] <^d> It's just a one-line trivial conflict. [17:52:39] (03PS2) 10Demon: Revert "Make line breaks in
behave like
(bug 6200)." See bug 52763 [core] - 10https://gerrit.wikimedia.org/r/78967 (owner: 10Subramanya Sastry) [17:52:51] <^d> subbu: PS2 should take care of it ^ :) [17:53:25] oh, thanks. :-) i just pushed one as well, and thankfully it got rejected since your's went through. [17:57:37] (03PS1) 10Aaron Schulz: Added a "syncviadelete" param to copyFileBackend script [core] - 10https://gerrit.wikimedia.org/r/78969 [17:58:53] (03CR) 10Demon: [C: 032] Removed unused $dbw variable and connection [core] - 10https://gerrit.wikimedia.org/r/78940 (owner: 10Aaron Schulz) [17:59:41] (03CR) 10Demon: [C: 032] Added batchFetchFromURLs() for mwstore backend [core] - 10https://gerrit.wikimedia.org/r/78938 (owner: 10Aaron Schulz) [18:00:16] ^d: https://gerrit.wikimedia.org/r/#/c/70781/ [18:00:23] (03CR) 10Demon: [C: 032] Break some long lines [core] - 10https://gerrit.wikimedia.org/r/78175 (owner: 10Aaron Schulz) [18:01:07] (03CR) 10GWicke: [C: 032] Revert "Make line breaks in
behave like
(bug 6200)." See bug 52763 [core] - 10https://gerrit.wikimedia.org/r/78967 (owner: 10Subramanya Sastry) [18:02:01] (03Merged) 10jenkins-bot: Removed unused $dbw variable and connection [core] - 10https://gerrit.wikimedia.org/r/78940 (owner: 10Aaron Schulz) [18:02:41] (03CR) 10Demon: [C: 032] Made runJobs.php respect time limits better and try to bail before OOMs [core] - 10https://gerrit.wikimedia.org/r/70781 (owner: 10Aaron Schulz) [18:03:54] (03Merged) 10jenkins-bot: Added batchFetchFromURLs() for mwstore backend [core] - 10https://gerrit.wikimedia.org/r/78938 (owner: 10Aaron Schulz) [18:05:54] (03Merged) 10jenkins-bot: Break some long lines [core] - 10https://gerrit.wikimedia.org/r/78175 (owner: 10Aaron Schulz) [18:07:31] (03Merged) 10jenkins-bot: Revert "Make line breaks in
behave like
(bug 6200)." See bug 52763 [core] - 10https://gerrit.wikimedia.org/r/78967 (owner: 10Subramanya Sastry) [18:08:11] (03PS5) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [18:09:12] (03Merged) 10jenkins-bot: Made runJobs.php respect time limits better and try to bail before OOMs [core] - 10https://gerrit.wikimedia.org/r/70781 (owner: 10Aaron Schulz) [18:13:14] (03CR) 10Parent5446: [C: 04-1] "(14 comments)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [18:18:04] (03CR) 10Parent5446: [C: 031] "I haven't tested it, but this looks good." [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent) [18:20:15] hmm, what's the 'official' way to show an error? [18:21:12] <^d> What sort of error? [18:21:35] <^d> Like an "OMG MEDIAWIKI IS FUCKED" error or like a "You put in some wrong text, try again" error? [18:23:15] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [18:23:28] * ^d dangles https://gerrit.wikimedia.org/r/#/c/76950/ in front of Aaron|home [18:24:16] (03CR) 10Martineznovo: "recheck" [core] - 10https://gerrit.wikimedia.org/r/27923 (owner: 10Daniel Friesen) [18:24:58] (03CR) 10jenkins-bot: [V: 04-1] (bug 23772) Implement a "Not what you were looking for?" search feature. [core] - 10https://gerrit.wikimedia.org/r/27923 (owner: 10Daniel Friesen) [18:28:41] timestamp: 20130813182501, edittime: 20130813182554 [18:28:45] how... is that an edit conflict? [18:28:58] the check is if ( $timestamp != $this->edittime ) { [18:29:16] != instead of >... wat? [18:29:16] There is no such key, you probably want to try: !?>, !@, !anglebrackets, !bugsearch, !bzsource, !cookies, !core, !damneditcount, !defaultsettings, !domdocument, !dpl, !easy, !emailconfirmed, !enableapi, !errors, !evilglobals, !exclamation, !externaleditor, !file, !fileurl, !google, !googleit, !IE9, !iis, !imagelink, !info, !line, !lmgtfy, !logs, !nofollow, !numberedparams, !plainlinks, !purge, !reportbug, !rt, !search, !smw, !sqllog, !suggest, !tables.sql, !tidyforidiots, !upload, !vector, !viewvc, !votes, !wf, !wp, !bzqs, !vebug, [18:30:04] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78343 (owner: 10Legoktm) [18:32:01] (03PS7) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [18:41:28] (03PS1) 10Cscott: Indented text in
shouldn't create 
. [core] - 10https://gerrit.wikimedia.org/r/78971 
[18:41:53] 	 (03CR) 10jenkins-bot: [V: 04-1] Indented text in 
 shouldn't create 
. [core] - 10https://gerrit.wikimedia.org/r/78971 (owner: 10Cscott)
[18:46:38] 	 (03CR) 10Aaron Schulz: [C: 032] Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon)
[18:47:20] 	 ^d: https://gerrit.wikimedia.org/r/#/c/75274/ easy
[18:48:39] 	  hmm, what's the 'official' way to show an error?
[18:48:51] 	 Are you looking at LQT's anonymous editing bug?
[18:48:53] 	 no
[18:48:56] 	 I'm writing code for flow
[18:48:57] 	 okay
[18:49:15] 	 (03Merged) 10jenkins-bot: Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon)
[18:49:57] 	 (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh)
[18:52:59] 	 (03CR) 10Matmarex: [C: 032] "Alright." [core] - 10https://gerrit.wikimedia.org/r/78461 (owner: 10TheDJ)
[18:55:31] 	 (03Merged) 10jenkins-bot: CologneBlue: Make editform's textareas 100% wide [core] - 10https://gerrit.wikimedia.org/r/78461 (owner: 10TheDJ)
[18:59:28] 	 (03CR) 10Demon: [C: 032] Fixed dynamic call to static method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75274 (owner: 10Aaron Schulz)
[18:59:38] <^d>	 Aaron|home: Done.
[18:59:38] 	 (03Merged) 10jenkins-bot: Fixed dynamic call to static method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75274 (owner: 10Aaron Schulz)
[19:12:06] 	 csteipp: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/OAuth,n,z
[19:15:19] 	  Anyone know who is familiar with the EditPage code? specifically dealing with edit conflicts
[19:16:02] 	 (03PS1) 10Cscott: Make line breaks in 
 behave like 
 (bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 
[19:16:04] 	 (03Abandoned) 10Cscott: Indented text in 
 shouldn't create 
. [core] - 10https://gerrit.wikimedia.org/r/78971 (owner: 10Cscott)
[19:16:07] * Aaron|home  tries to avoid that class
[19:16:49] 	 (03CR) 10Cscott: "Please don't +2 this patch until it's had a number of reviewers +1 it. As a change to the PHP parser it potentially has wide-ranging visi" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[19:19:28] 	 (03CR) 10Cscott: "See change I3696d4ab7b8ad6ebccf8483d6da1722353c1697d" [core] - 10https://gerrit.wikimedia.org/r/78967 (owner: 10Subramanya Sastry)
[19:20:14] 	 (03CR) 10Cscott: "See change I3696d4ab7b8ad6ebccf8483d6da1722353c1697d for a fix for 
 that doesn't introduce new 
 blocks." [core] - 10https://gerrit.wikimedia.org/r/77961 (owner: 10Cscott)
[19:35:44] 	 (03CR) 10Cscott: "(Note that this is a fixed version of change Iecab69460c6aac36acfe2d9440dc5d3590de8b57 which had to be reverted due to bug 52763.)" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[19:37:18] 	 (03PS4) 10Cscott: Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 
[19:50:07] 	 (03CR) 10Yaron Koren: "Andru - I just saw the notification about this. Did I really ignore this patch for eight months? If so (and it appears so), I apologize - " [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/39761 (owner: 10Andru)
[19:54:36] 	 bd808: ping
[19:56:05] 	 (03PS2) 10Mwjames: \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 
[19:56:21] 	 (03PS1) 10Miguel2706: New release of update system [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79008 
[19:56:22] 	 (03PS1) 10Miguel2706: New version [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79009 
[19:57:30] 	 (03CR) 10jenkins-bot: [V: 04-1] \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) Move $GLOBALS initialization into \SMW\ExtensionSetup [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames)
[19:58:13] 	 (03CR) 10Mwjames: "Same issue" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames)
[19:59:59] 	 (03CR) 10Miguel2706: [C: 032 V: 032] New version [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79009 (owner: 10Miguel2706)
[20:10:16] 	 (03Abandoned) 10Miguel2706: New version [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79009 (owner: 10Miguel2706)
[20:10:33] 	 (03Abandoned) 10Miguel2706: New release of update system [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/79008 (owner: 10Miguel2706)
[20:10:43] 	 (03Abandoned) 10Miguel2706: Changing the UTF-8 encoding in all files of the repo [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/78668 (owner: 10Miguel2706)
[20:12:53] 	 (03PS1) 10Demon: Another Solr leftover [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79010 
[20:14:54] 	 (03PS2) 10Demon: Another Solr leftover [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79010 
[20:16:32] 	 ori-l: hey
[20:16:56] 	 (03PS1) 10EBernhardson (WMF): New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 
[20:18:13] 	 bd808: hey, sorry that my twiddling with your thumb.php patch messed things up. what happened, exactly? i get that putting the directives outside  scopes them to the entire apache instance, but they should still work, no?
[20:19:09] 	 ori-l: nope. the VirtualHost container ignored global config for things like rewrite
[20:19:38] 	 I think some global is inherited (eg log directives) but apparently not all
[20:20:04] 	 (03CR) 10Manybubbles: [C: 032] Another Solr leftover [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79010 (owner: 10Demon)
[20:20:07] 	 (03Merged) 10jenkins-bot: Another Solr leftover [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/79010 (owner: 10Demon)
[20:20:48] 	 (03CR) 10Nemo bis: "@Yaron, it's worth checking your email if you didn't trash it; sometimes gerrit doesn't (or didn't) notify me new patchsets, so that might" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/39761 (owner: 10Andru)
[20:20:51] 	 ori-l: I like the gist of what you ended up refactoring into.
[20:22:38] 	 ooohhh
[20:22:48] 	 I just got what you did with your patch
[20:22:55] 	 that's pretty nice
[20:23:43] 	 using puppetlab's apache::vhost could give a lot more richness, but that's a bigger can of worms
[20:24:44] 	 (03CR) 10Ori.livneh: "(3 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/78830 (owner: 10BryanDavis)
[20:25:59] 	 puppetlab modules are generally about five times more complicated than they ought to be; if the apache module is approaching puppetlabs module complexity i'd be more inclined to take it as a sign that it should be de-fancied, but i'll take a look
[20:27:44] 	 apache::vhost is super fancy, but handles a lot of different use-cases pretty easily. I think it's a pretty commonly used module too.
[20:28:16] 	 we'd still need to have some customization to do the site.d stuff but it would be pretty light
[20:28:43] 	 I't probably a YAGNI for now
[20:28:50] 	 *it's
[20:33:58] 	 (03CR) 10BryanDavis: "(3 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/78830 (owner: 10BryanDavis)
[20:34:05] 	 (03PS3) 10BryanDavis: Place snippets imported by apache::site in . [vagrant] - 10https://gerrit.wikimedia.org/r/78830 
[20:42:47] 	 (03CR) 10Ori.livneh: [C: 032] "LGTM." [vagrant] - 10https://gerrit.wikimedia.org/r/78830 (owner: 10BryanDavis)
[20:42:50] 	 (03Merged) 10jenkins-bot: Place snippets imported by apache::site in . [vagrant] - 10https://gerrit.wikimedia.org/r/78830 (owner: 10BryanDavis)
[20:44:28] 	 (03CR) 10GWicke: [C: 031] "I also did some more grepping with '\n([ \t]*).)*-->){2,}[ \t]*\n' which catches some more cases. The rendering changes seem to" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[20:47:40] 	 (03PS1) 10Ori.livneh: Remove out-of-date docs [vagrant] - 10https://gerrit.wikimedia.org/r/79012 
[20:49:33] 	 (03PS3) 10J: (bug 46650) increase memory limit for frame extraction [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/63418 
[20:49:48] 	 (03CR) 10Ori.livneh: [C: 032] Remove out-of-date docs [vagrant] - 10https://gerrit.wikimedia.org/r/79012 (owner: 10Ori.livneh)
[20:49:50] 	 (03Merged) 10jenkins-bot: Remove out-of-date docs [vagrant] - 10https://gerrit.wikimedia.org/r/79012 (owner: 10Ori.livneh)
[20:53:52] 	 (03CR) 10J: [C: 04-1] "getStreamHeaders is currently used in TimedMediaHandler handlers/OggHandler/OggHandler.php this is only needed for additional metadata not" [core] - 10https://gerrit.wikimedia.org/r/51894 (owner: 10Parent5446)
[20:58:16] 	 (03Abandoned) 10Ori.livneh: Add Wikidata role [vagrant] - 10https://gerrit.wikimedia.org/r/70657 (owner: 10Ori.livneh)
[21:00:02] 	 (03PS1) 10Cscott: New Parsoid test: run parsoid's parserTests file using PHP parser. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79013 
[21:01:22] 	 (03CR) 10GWicke: [C: 031] New Parsoid test: run parsoid's parserTests file using PHP parser. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79013 (owner: 10Cscott)
[21:02:23] 	 (03CR) 10Subramanya Sastry: "We still need tests to verify that blockquote continues to behave like a block tag in its surrounding context, i.e. it continues to behave" [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[21:05:19] 	 (03CR) 10Subramanya Sastry: [C: 031] "I am only +1-ing the expectation, not the jenkins syntax in the yaml file. mark/krinkle/hashar can look at those aspects." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/79013 (owner: 10Cscott)
[21:20:46] 	 (03CR) 10Parent5446: "TimedMediaHandler isn't the only place it's used. As the patch indicates, it's also used in the upload() logic in FileRepo. The idea here " [core] - 10https://gerrit.wikimedia.org/r/51894 (owner: 10Parent5446)
[21:26:05] 	 (03PS1) 10Mollywhite: Change the default value of $wgBookManagerv2NavigationNamespaces [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/79015 
[21:26:55] 	 (03PS6) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 
[21:27:08] 	 \o/
[21:27:12] 	 error handling, rebased
[21:27:30] 	 \o/
[21:30:46] 	 (03PS1) 10Rachel99: WIP continuing Headings test, scenarios for choose heading and choose sub-heading 1 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79017 
[21:33:43] 	 (03PS1) 10tosfos: Changed hook name [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/79018 
[21:34:41] 	 (03CR) 10tosfos: [C: 032 V: 032] Changed hook name [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/79018 (owner: 10tosfos)
[21:35:48] 	 ori-l: I had to change file permissions on vagrant/logs and files within to get debug logging to work. Is that normal/expected? Can puppet fix that automagically?
[21:36:33] 	 ori-l: also very non-intuative that chmod on these from within the vm has no effect
[21:46:33] 	 (03PS1) 10Yaron Koren: Added hook, needed by the upcoming "QuizTabulate" extension [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79020 
[21:54:02] 	 (03PS2) 10Cscott: Make line breaks in 
 behave like 
 (bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 
[21:56:24] 	 (03CR) 10Cscott: "Added tests subbu suggested, and in the process found & fixed an issue if 
 and 
 were on the same line." [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[22:00:05] 	 (03PS1) 10Kiran mathew koshy 1993: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types before storing them to file. [openzim] - 10https://gerrit.wikimedia.org/r/79021 
[22:01:22] 	 (03CR) 10Subramanya Sastry: [C: 031] Make line breaks in 
 behave like 
 (bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[22:04:53] 	 (03CR) 10Demon: "(1 comment)" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79020 (owner: 10Yaron Koren)
[22:11:11] 	 (03CR) 10CSteipp: [C: 032] Remove use of deprecated methods [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77695 (owner: 10Siebrand)
[22:11:14] 	 (03Merged) 10jenkins-bot: Remove use of deprecated methods [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77695 (owner: 10Siebrand)
[22:11:16] 	 (03PS3) 10Cscott: Make line breaks in 
 behave like 
 (bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 
[22:11:53] 	 (03PS1) 10Yaron Koren: Fixed call-by-reference problem [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79022 
[22:12:03] 	 (03CR) 10Cscott: "Fixed whitespace issue." [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[22:12:29] 	 (03CR) 10Demon: [C: 032] Added hook, needed by the upcoming "QuizTabulate" extension [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79020 (owner: 10Yaron Koren)
[22:12:45] 	 (03CR) 10Subramanya Sastry: [C: 031] Make line breaks in 
 behave like 
 (bug 6200). [core] - 10https://gerrit.wikimedia.org/r/78972 (owner: 10Cscott)
[22:12:57] 	 (03Merged) 10jenkins-bot: Added hook, needed by the upcoming "QuizTabulate" extension [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79020 (owner: 10Yaron Koren)
[22:13:16] 	 (03CR) 10Demon: [C: 032] Fixed call-by-reference problem [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79022 (owner: 10Yaron Koren)
[22:13:17] 	 (03Merged) 10jenkins-bot: Fixed call-by-reference problem [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/79022 (owner: 10Yaron Koren)
[22:27:07] 	 (03CR) 10Tim Starling: [C: 032] Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[22:29:42] 	 (03Merged) 10jenkins-bot: Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[22:37:14] 	 (03PS2) 10EBernhardson (WMF): New topic action: thread-history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79011 
[22:50:44] 	 (03PS1) 10EBernhardson (WMF): Permalink to Comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79023 
[22:55:03] 	 (03CR) 10Tim Starling: [C: 04-1] "Why is so much memory needed? 1.5GB is maybe 240 1080p frames. You would expect a thumbnailing operation to only need 2 or 3 frames of buf" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/63418 (owner: 10J)
[22:57:18] 	 (03PS1) 10Demon: Allow individual search backends to control whether they SearchUpdate [core] - 10https://gerrit.wikimedia.org/r/79025 
[22:58:35] 	 (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand)
[23:03:18] 	 (03PS3) 10CSteipp: Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 
[23:03:19] 	 (03CR) 10jenkins-bot: [V: 04-1] Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 (owner: 10CSteipp)
[23:03:36] 	 https://github.com/wikimedia/mediawiki-core/pull/6 Does anyone have any idea what this is about?
[23:04:42] 	 Krenair: http://meta.orain.org/wiki/Main_Page
[23:05:42] <^d>	 If I had to guess, someone was confused.
[23:05:46] <^d>	 Or pressed the wrong button.
[23:07:20] 	 It's for the wmf/1.22wmf12 branch as well
[23:07:33] 	 they have a fork on github
[23:07:51] 	 I guess the pull request was sent to the wrong fork
[23:08:16] 	 That makes the most sense. I've left a comment
[23:10:19] 	 (03PS6) 10Tim Starling: Show profiling data on preview [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/53803 (owner: 10Anomie)
[23:10:28] 	 (03CR) 10Tim Starling: [C: 032] Show profiling data on preview [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/53803 (owner: 10Anomie)
[23:10:30] 	 (03Merged) 10jenkins-bot: Show profiling data on preview [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/53803 (owner: 10Anomie)
[23:10:55] 	 (03PS6) 10Tim Starling: Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie)
[23:17:26] 	 (03PS7) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 
[23:17:55] 	 \o/
[23:18:30] 	 ori-l (bd808) vagrant/logs seems to work fine for me, files owned by me:me on host, owned by vagrant:www-data in VM.
[23:18:32] 	 (03CR) 10CSteipp: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 (owner: 10Aaron Schulz)
[23:18:50] 	 werdna: deploy Thursday? !
[23:19:04] 	 spagewmf: still got a little ways to go
[23:19:18] 	 still, teh awesome
[23:19:21] 	 but I don't mind a test deployment somewhere for people involved in development to play with
[23:22:23] 	 spagewmf, Flow is being deployed thursday? what?
[23:22:49] 	 werdna: ee has various labs instances, like ee-lwelling2 and ee-prototype.
[23:23:00] 	 Krenair: I think he's joking :)
[23:23:41] 	 Krenair, humor is just rumor mispelled 
[23:26:01] 	 (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77972 (owner: 10Aaron Schulz)
[23:28:46] 	 (03Abandoned) 10Demon: Change default logo [core] - 10https://gerrit.wikimedia.org/r/57533 (owner: 10Rjain)
[23:32:22] 	 (03CR) 10Demon: "So, I'm not entirely sure if I'm a fan of this approach. Using ForkController similar to how we do in runJobs might be neat (although we'd" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78834 (owner: 10Manybubbles)
[23:32:56] 	 werdna: might be premature, but I'
[23:33:40] 	 werdna: I'd like to see flow on beta labs too.  that should be possible since it's a new extension, and we have CirrusSearch as an example 
[23:37:44] 	 (03CR) 10CSteipp: "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77822 (owner: 10Aaron Schulz)
[23:39:12] 	 (03CR) 10CSteipp: [C: 032 V: 032] Added hook presence sanity checks [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77760 (owner: 10Aaron Schulz)
[23:39:33] 	 (03Abandoned) 10CSteipp: DO NOT MERGE - OAuth Sessions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77485 (owner: 10CSteipp)
[23:40:38] 	 (03PS2) 10Aaron Schulz: Added logged-in check to some special pages and fixed others [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77822 
[23:44:45] 	 (03PS4) 10CSteipp: Simplify handling of API POST requests [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 
[23:44:46] 	 (03PS4) 10CSteipp: Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 
[23:47:37] 	 (03CR) 10Aaron Schulz: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/79025 (owner: 10Demon)
[23:57:30] 	 (03PS3) 10Jeroen De Dauw: \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) Move $GLOBALS initialization into \SMW\ExtensionSetup [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames)
[23:58:55] 	 (03CR) 10jenkins-bot: [V: 04-1] \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) Move $GLOBALS initialization into \SMW\ExtensionSetup [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78964 (owner: 10Mwjames)