[00:06:02] (03CR) 10Ori.livneh: [C: 04-1] "OK, this is very nearly there. I think that you should drop the 'directives' parameter and instead have the class accept 'content' and 'so" [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [00:30:43] (03CR) 10Ori.livneh: "Woooo, cool to see you submitting patches :)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78407 (owner: 10Ragesoss) [00:31:15] the [01:30:18] I see https://integration.wikimedia.org/cover/mediawiki-core/master/php/ is still broken (I hope) [01:35:53] mwalker: You around? [01:36:01] yeo yeo [01:36:45] what can I do for you today? [01:37:14] I'm suddenly getting 13 failing tests instead of my usual 6 [01:37:17] And I'm not sure why [01:37:31] I even tried testing the pre-JSON editor code, and I'm still getting 13 [01:37:33] http://pastebin.com/mpBgxd16 [01:38:59] * mwalker grumbles about people checking in broken code [01:39:22] these are all core errors -- so I'm guessing you updated your instance of it at some point [01:40:15] you can run unit tests just on your extension if you dont want to see them [01:40:26] or wait [01:40:38] no; you need to keep running the core tests because you hook into things that could break core [01:41:23] mwalker: Okay, so is it safe to assume that those broken tests are due to someone else's broken code? [01:41:24] still; point being -- if, even without, your code you're getting these errors; it's not your fault and you have two options -- 1, ignore it; or 2, try and figure out what broke them [01:42:14] to make sure disable your extension and run php unit [01:42:22] Okay, I'll try it [01:42:23] if you still have 13 errors; not your fault :) [01:43:49] Kay, running now [01:46:32] (03CR) 10Kaldari: [C: 032] Remove unused i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/70750 (owner: 10Bsitu) [01:46:34] (03Merged) 10jenkins-bot: Remove unused i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/70750 (owner: 10Bsitu) [01:51:07] mwalker: Uh oh, appears to be my fault [01:51:15] I only get 6 errors when I disable BMv2 [01:52:09] debugging tests is a bit of a black art -- I prefer to just jump in with a debugger to see wtf [01:52:16] alternately -- print out lots of stuff! [01:56:28] Possibly dumb question: PHPunit tests only run on the currently checked out branch, correct? [02:03:57] mwalker: ^ [02:04:47] Yes [02:05:43] yep [02:07:10] Kay, cool [02:07:48] Well, not cool, because it means some of the currently-merged code is breaking, not just the new stuff [02:12:12] (03PS1) 10Mwalker: Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 [02:12:14] ah; that happens [02:12:44] it's no big deal :) you can try to use git bisect and just run the tests that are failing to determine what commits broke what [02:13:05] (03PS2) 10Mwalker: Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 [02:13:20] Yep, working on it now :) [02:13:39] I guess it's better than the JsonEditor patch breaking it, considering it's less to sift through [02:15:01] truth! [02:16:43] (03PS1) 10Werdna: UI work: try to make Flow look vaguely like Brandon's prototype. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78478 [02:27:16] (03PS3) 10Mwalker: Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 [02:28:54] Elsie: Hey [02:29:37] legoktm: Hi. [02:30:06] legoktm: So my thought was... I think cross-wiki (or global) message delivery should be no different than regular delivery. [02:30:27] legoktm: Until someone can make a reasonable case for a separate user right and other limitations, I don't think it should be in the code. [02:30:44] legoktm: That said, a massmessage-highlimits user right may be prudent, maybe. [02:30:52] And... that's pretty much it. [02:31:02] Elsie: why not? third-party wikis might prefer it [02:31:09] Might prefer what? [02:31:18] [19:30:37] Elsie legoktm: Until someone can make a reasonable case for a separate user right and other limitations, I don't think it should be in the code. [02:31:22] Hm. [02:31:33] Jasper_Deng: "Someone might need it" isn't a reasonable use-case. [02:31:34] I'm not sure its a good idea to let any random sysop spam any wmf wiki [02:31:43] ^ [02:31:51] legoktm: I'm not a sysop and my bot can spam any wiki. [02:31:55] My bot is also not flagged as a bot. [02:31:58] Good point. [02:32:01] Oh, right. I remember the other comment. [02:32:11] You need to add a un-removable HTML comment. [02:32:31] for dupe checking? [02:32:35] Nope. [02:32:41] Then for...? [02:32:42] That says... [02:32:51] So that people have some idea of where the message is coming from. [02:33:06] As long as you have that, I think cross-wiki deliveries are fine. [02:33:06] Ah, that's smart. [02:33:10] Ok [02:33:38] Localization of that may be annoying, but whatever. [02:34:01] [02:34:03] Or something like that. [02:34:50] Ok [02:34:52] Don't get me wrong, this tool will be abused. [02:35:01] But I think that's a social problem, not a technical problem. [02:35:10] And perhaps having a high limits setting would help. [02:35:11] I'm not sure. [02:35:22] well, sysops can be mostly trusted to not abuse it [02:35:30] Not really [02:35:32] I hope so. :-) [02:35:36] Sysops can be trusted. [02:35:38] lego: "mostly" [02:35:43] They can do far worse, so I hope we can trust most of them. [02:35:46] Theoretically. [02:35:47] :P [02:35:59] The high limits thing I would also wait on, though. [02:36:03] Code what you need for now. [02:37:30] (03CR) 10Hoo man: [C: 032] "Looks fine" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78354 (owner: 10Reedy) [02:37:34] (03Merged) 10jenkins-bot: Update header code to newer standards [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78354 (owner: 10Reedy) [02:38:26] legoktm: On a scale of one to ready to deploy, how would you rate the extension? [02:39:29] It's mainly complete, https://gerrit.wikimedia.org/r/#/c/75299/ is really only the main one that *needs* to be merged. [02:40:09] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/MassMessage+status:open,n,z [02:40:25] https://gerrit.wikimedia.org/r/#/c/78334/ [02:40:29] Why is that submitted? [02:40:32] And not merged. [02:40:42] It's dependent on a change that isnt merged [02:40:50] Which I'll fix up in a minute [02:40:54] Oh, also the username thing. [02:40:54] K. [02:41:03] https://gerrit.wikimedia.org/r/#/c/78337/ [02:41:08] Some of this looks trivial to merge. [02:41:13] I can do it if you want. [02:41:30] Sure [02:42:06] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78337 (owner: 10Legoktm) [02:42:12] (03Merged) 10jenkins-bot: Use WikiPage::factory() instead of Article::newFromTitle() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78337 (owner: 10Legoktm) [02:42:20] One down. [02:43:03] Hmmmm. [02:43:37] https://gerrit.wikimedia.org/r/#/c/78344/1/MassMessageJob.php,unified [02:43:45] Hmmmmmmmm. [02:43:52] So that's doing an extra query per target. [02:43:57] I wonder if that's the best approach. [02:44:23] You could retrieve local category membership and store it. [02:45:45] So just cache the output of $wikipage->getCategories()? [02:45:52] No. [02:46:05] I'm saying you're currently looking at each target and getting the categories. [02:46:19] [[User:Foo]]->get all of [[User:Foo]]'s categories [02:46:30] That requires an extra query per target. [02:46:35] So just get [[Category:blah]], and check if [[User:Foo]] is in it? [02:46:40] Yeah. [02:46:50] Though your method may be cleaner, I'm not sure. [02:46:59] There's no way to easily store that unless you stick it in cache [02:47:07] Why's that? [02:47:09] I think its just a question of scale [02:47:16] Can't it just go in memory? [02:47:29] Er yeah, ignore what I said about that. I was thinking of something else [02:48:03] Either way works, I just think that normally User:Foo will have less categories than Category:foo has members [02:48:04] I'm not sure how big a deal getting the categories is. But reducing queries seemed smart. [02:48:20] Right, of course that's true. [02:48:41] But lots of individual queries are more expensive than a single query into memory. [02:48:44] I think. [02:48:54] Er. [02:49:04] How would each job access that one query per site? [02:49:30] I don't know. :-) [02:49:37] Maybe your method is fine. [02:49:41] Yeah, you'd have to use memcache or w/e. [02:49:45] I thought it was doing it in a loop. [02:49:54] But if it's submitting jobs, yeah, you'll just need to do the query. [02:50:06] I guess. [02:50:11] Or not insert the jobs. [02:50:14] If they're not going to be executed. [02:50:34] That's probably saner. [02:50:46] * Elsie looks at the other patchsets. [02:50:55] You can't check if the target is in the remote category unless we're already in the job mode [02:51:25] Not without accessing the remote db. [02:51:36] Right. [02:51:41] Okay, so leave it the way it is, then. [02:52:00] (There really wasn't a getCategories function already?) [02:52:06] Nope >.> [02:52:12] Reedy was surprised too [02:52:24] Well, technically there is. [02:52:29] It's just in the Skin object. [02:53:48] (03Abandoned) 10MZMcBride: Add some FIXMEs based on static code analysis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78182 (owner: 10Siebrand) [02:54:03] It puts the lotion on the skin. [02:54:14] Interesting. All right. [02:54:30] legoktm: You can't get Reedy to review your edit API changeset? [02:54:50] He did-ish. He just needs to re-review it. [02:54:54] * legoktm stabs Reedy  [02:55:13] Do it in real-life. [02:55:14] It hurts more. [02:55:18] And it's more effective. [02:55:32] I'm not sure where he is [02:57:28] (03CR) 10MZMcBride: "I'm in favor of killing the separate global user right altogether (for now). When someone can articulate a reasonable use-case for the cro" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 (owner: 10Legoktm) [03:01:00] (03CR) 10MZMcBride: "Hi Miguel2706." [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/78470 (owner: 10Miguel2706) [03:01:07] (03PS1) 10Legoktm: Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 [03:01:08] (03CR) 10jenkins-bot: [V: 04-1] Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [03:01:30] Hm. [03:01:34] I'll fix that later [03:02:18] The extension descriptions are useless. [03:02:28] "MediaWiki extension XXX" [03:02:49] And they're inconsistent. [03:02:56] Rage. [03:03:14] (03PS9) 10Legoktm: Edit via the API instead of WikiPage::doEditContent. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75299 [03:04:52] (03CR) 10Legoktm: "PS9 calls $user->getEditToken() rather than the deprecated $user->editToken()" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75299 (owner: 10Legoktm) [03:07:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=52685 [03:07:10] Glad I got that out of my system. [03:07:55] legoktm: All right. Let me know if you need anything else. [03:08:05] I'm hoping we can get this deployed by... end of September? [03:08:29] that would be great :D [03:08:31] (03PS4) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 [03:08:32] (03CR) 10jenkins-bot: [V: 04-1] Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 (owner: 10Legoktm) [03:08:53] Erg, I hate rebasing. [03:10:13] (03PS5) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 [03:10:45] Elsie: Ok, ^ is ready. [03:11:02] Er wait [03:11:43] (03PS6) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 [03:11:45] There. [03:11:59] bbl [03:54:32] (03PS2) 10Legoktm: Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 [03:58:39] (03PS7) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 [04:05:58] (03CR) 10Legoktm: [C: 032] "Per discussion on IRC with MZMcBride, this can be re-added if there is a need." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 (owner: 10Legoktm) [04:06:02] (03Merged) 10jenkins-bot: Remove the checkbox for global deliveries, simply use the spamlist. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 (owner: 10Legoktm) [04:06:09] (03PS3) 10Legoktm: Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 [04:06:33] (03CR) 10Legoktm: [C: 032] Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 (owner: 10Legoktm) [04:06:37] (03Merged) 10jenkins-bot: Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 (owner: 10Legoktm) [04:07:06] (03PS1) 10Mollywhite: Bugfix: Forgotten exclamation point [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78482 [04:07:19] mwalker|away: Found it... >.< [04:07:57] (03PS3) 10Ori.livneh: Add apache::conf Puppet class [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [04:07:58] (03PS5) 10Ori.livneh: Add Puppet role for multimedia development [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis) [04:08:43] (03CR) 10Mollywhite: [C: 032 V: 032] Bugfix: Forgotten exclamation point [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78482 (owner: 10Mollywhite) [04:10:32] (03CR) 10Ori.livneh: "I experimented with different ways of implementing this and made some modifications to this patch based on what I learned. The biggest dif" [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [04:11:01] (03PS2) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [04:12:31] (03PS2) 10Legoktm: Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 [04:12:32] (03CR) 10jenkins-bot: [V: 04-1] Add a HTML comment indicating where the message came from [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78479 (owner: 10Legoktm) [04:19:05] (03PS4) 10Ori.livneh: Add apache::conf Puppet class [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [04:19:06] (03PS6) 10Ori.livneh: Add Puppet role for multimedia development [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis) [04:19:22] (03CR) 10Ori.livneh: [C: 032] Add apache::conf Puppet class [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [04:19:28] (03Merged) 10jenkins-bot: Add apache::conf Puppet class [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis) [04:21:05] (03CR) 10Ori.livneh: [C: 032] "I renamed the role class to 'role::multimedia', because thumb.php struck me as too granular. 'role::multimedia' can house optional setting" [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis) [04:21:09] (03Merged) 10jenkins-bot: Add Puppet role for multimedia development [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis) [04:26:48] (03PS7) 10Adamw: Specify width and height of SVG images to ensure they are rasterized properly [extensions/timeline] - 10https://gerrit.wikimedia.org/r/47336 (owner: 10Matmarex) [04:27:32] (03PS4) 10Nikerabbit: Clean up comment style in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/76477 (owner: 10Umherirrender) [04:28:04] (03CR) 10Nikerabbit: [C: 032] Clean up comment style in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/76477 (owner: 10Umherirrender) [04:30:35] (03CR) 10Adamw: "MatmaRex: please +1 if the htmlmap link rectangles still work for you. Thanks for the patch!" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/47336 (owner: 10Matmarex) [04:31:52] (03Merged) 10jenkins-bot: Clean up comment style in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/76477 (owner: 10Umherirrender) [04:43:31] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update README file [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78363 (owner: 10Jeroen De Dauw) [04:45:10] (03PS8) 10Adamw: Specify width and height of SVG images to ensure they are rasterized properly [extensions/timeline] - 10https://gerrit.wikimedia.org/r/47336 (owner: 10Matmarex) [04:47:25] (03PS3) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [04:49:12] (03PS4) 10Mollywhite: Bug 51239: Draft JSON editor (do not merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 [04:49:34] (03CR) 10Aaron Schulz: [C: 032] Reusable external store insertion with fallback [core] - 10https://gerrit.wikimedia.org/r/77979 (owner: 10EBernhardson (WMF)) [04:52:16] (03Merged) 10jenkins-bot: Reusable external store insertion with fallback [core] - 10https://gerrit.wikimedia.org/r/77979 (owner: 10EBernhardson (WMF)) [05:22:29] GorillaWarfare: *high five* that only took a couple of hours [06:05:59] (03CR) 10Nikerabbit: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/78464 (owner: 10Matmarex) [06:12:16] * werdna waves [06:21:08] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [06:24:20] RoanKattouw_away, http://en.wikipedia.org/w/api.php?action=parse&text=[[foo]] [06:28:48] (03PS2) 10Frédéric Wang: Experimental MathJax branch: - use MathJax 2.3 unpacked version - replace use of wiki2jax preprocessor by direct generation of MathJax's