[00:03:12] <TimStarling>	 cscott: what happens to the spaces between the comments? they seem to be lost
[00:04:03] <cscott>	 The leading spaces get dropped on the floor, like the pre-patch did with the leading spaces before the first comment
[00:04:13] <cscott>	 would it be better to such them into the <comment>?
[00:04:16] <cscott>	 *suck
[00:07:56] <cscott>	 or just suck the trailing whitespace in? (so the leading whitespace before the first comment still gets dropped, like pre-patch)
[00:09:59] <cscott>	 TimStarling: ^
[00:10:03] * cscott  steps afk for a moment

[00:10:13] <TimStarling>	 yeah, I'm still testing and reading
[00:17:02] <TimStarling>	 cscott: I was just checking to make sure the spaces were preserved through a pre-save transform
[00:17:25] <TimStarling>	 so the answer I was looking for was "the spaces are included in the <comment> element associated with the preceding comment"
[00:18:13] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Never prefix table names with $wgSharedDB when used in foreign DB [core] - 10https://gerrit.wikimedia.org/r/65489 (owner: 10Liangent)
[00:19:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Never prefix table names with $wgSharedDB when used in foreign DB [core] - 10https://gerrit.wikimedia.org/r/65489 (owner: 10Liangent)
[00:28:29] <grrrit-wm>	 (03PS2) 10Tim Starling: Preprocessor: Don't treat a line containing multiple comments as a blank line. [core] - 10https://gerrit.wikimedia.org/r/77988 (owner: 10Cscott)
[00:28:35] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Preprocessor: Don't treat a line containing multiple comments as a blank line. [core] - 10https://gerrit.wikimedia.org/r/77988 (owner: 10Cscott)
[00:34:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Preprocessor: Don't treat a line containing multiple comments as a blank line. [core] - 10https://gerrit.wikimedia.org/r/77988 (owner: 10Cscott)
[00:36:58] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 04-1] "The "sanity check" is presumably broken:" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[00:46:40] <grrrit-wm>	 (03PS3) 10Ori.livneh: Extract mediawiki::settings from mediawiki::extension. [vagrant] - 10https://gerrit.wikimedia.org/r/78143 (owner: 10BryanDavis)
[00:47:15] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Extract mediawiki::settings from mediawiki::extension. [vagrant] - 10https://gerrit.wikimedia.org/r/78143 (owner: 10BryanDavis)
[00:47:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Extract mediawiki::settings from mediawiki::extension. [vagrant] - 10https://gerrit.wikimedia.org/r/78143 (owner: 10BryanDavis)
[00:57:37] <grrrit-wm>	 (03CR) 10Cscott: "Updated https://www.mediawiki.org/wiki/Preprocessor_ABNF for the parent; it already claimed that tabs were acceptable in line-eating-comme" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[01:01:34] <grrrit-wm>	 (03CR) 10Tim Starling: "line-eating-comment = LF LINE-START *SP +( comment *SP ) LINE-END" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[01:13:21] <grrrit-wm>	 (03PS1) 10Ori.livneh: Puppet: serve 'puppet/files' as custom mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/78328 
[01:14:57] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Puppet: serve 'puppet/files' as custom mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/78328 (owner: 10Ori.livneh)
[01:14:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Puppet: serve 'puppet/files' as custom mountpoint [vagrant] - 10https://gerrit.wikimedia.org/r/78328 (owner: 10Ori.livneh)
[01:23:49] <grrrit-wm>	 (03Restored) 10Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/74938 (owner: 10Legoktm)
[01:26:49] <grrrit-wm>	 (03CR) 10MarkTraceur: "OK! Now we're getting somewhere." [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur)
[01:27:11] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/78260 (owner: 10BryanDavis)
[01:31:20] <grrrit-wm>	 (03CR) 10Mwalker: "(2 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite)
[01:36:11] <grrrit-wm>	 (03CR) 10Reedy: [C: 031] Fix getDBName to read from $wgConf and cache if possible [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78222 (owner: 10Legoktm)
[01:43:38] <grrrit-wm>	 (03PS16) 10MarkTraceur: Implement agora-style checkboxes experimentally [core] - 10https://gerrit.wikimedia.org/r/74662 
[01:46:37] <grrrit-wm>	 (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur)
[01:50:35] <grrrit-wm>	 (03PS6) 10Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/74938 
[01:52:01] <legoktm>	 Reedy: y u no +2?
[01:52:08] <grrrit-wm>	 (03CR) 10Legoktm: "PS6: Manual rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/74938 (owner: 10Legoktm)
[01:52:32] <Reedy>	 I wasn't sure if you wanted it submitting etc now/yet
[01:54:10] <legoktm>	 Oh, well I would like it merged now :)
[01:57:21] <grrrit-wm>	 (03PS2) 10Reedy: Fix getDBName to read from $wgConf and cache if possible [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78222 (owner: 10Legoktm)
[01:57:27] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix getDBName to read from $wgConf and cache if possible [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78222 (owner: 10Legoktm)
[01:57:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix getDBName to read from $wgConf and cache if possible [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78222 (owner: 10Legoktm)
[01:58:44] <legoktm>	 ty :D
[02:01:23] <Reedy>	 legoktm: One thing...
[02:01:45] <Reedy>	 I wonder if this is a case where you might not want to use wfMemcKey()
[02:02:23] <Reedy>	 lol, old code
[02:02:24] <Reedy>	 	public static function getDBName( $host ) {
[02:02:24] <Reedy>	 		if ( isset( $this->dbnames[$host] ) ) {
[02:02:25] <Reedy>	 lolol
[02:02:33] <legoktm>	 >.>
[02:02:38] <legoktm>	 Why would you not want to use it?
[02:02:46] <legoktm>	 https://github.com/wikimedia/mediawiki-core/blob/052f1fcf308c7fabdaf0b177a776a1fe795c2789/includes/GlobalFunctions.php#L3369 looks pretty simple to me
[02:03:02] <Reedy>	 It has the dbname prefix
[02:03:15] <Reedy>	 of the wiki it's being called from
[02:04:15] <legoktm>	 Hm.
[02:06:06] <Reedy>	 The mapping would be the same on all wikis...
[02:06:11] <legoktm>	 Yeah
[02:06:12] <Reedy>	 When/where is that code called?
[02:06:27] <legoktm>	 When you submit the message lemme find it
[02:07:11] <Reedy>	 I'm just updating all my code clone
[02:07:12] <Reedy>	 s
[02:07:13] <legoktm>	 https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessage.body.php#L133
[02:08:11] <legoktm>	 And that is only called when you press submit
[02:10:58] <Reedy>	 That comment at the call point is out of date too ;)
[02:11:15] <legoktm>	 Oh, oops.
[02:15:58] <grrrit-wm>	 (03CR) 10Cscott: "Right you are. I read the sptab = SP / TAB production too quickly and somehow got SP = SP / TAB in my head. I'll update it once this pat" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[02:17:49] <grrrit-wm>	 (03PS2) 10Cscott: Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 
[02:18:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[02:19:42] <grrrit-wm>	 (03PS7) 10Legoktm: [WIP] Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/74938 
[02:21:43] <grrrit-wm>	 (03PS2) 10Legoktm: Fix undefined $dbname variable [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78192 
[02:22:05] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Fix undefined $dbname variable [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78192 (owner: 10Legoktm)
[02:22:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix undefined $dbname variable [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78192 (owner: 10Legoktm)
[02:24:24] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Rename variable to avoid confusion of what class the object is [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78325 (owner: 10Legoktm)
[02:24:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename variable to avoid confusion of what class the object is [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78325 (owner: 10Legoktm)
[02:27:55] <average>	 hey
[02:28:09] <average>	 anybody up for a hackathon ?
[02:28:15] <average>	 http://www.reddit.com/r/pandacodium
[02:29:24] <legoktm>	 Reedy: can you review https://gerrit.wikimedia.org/r/#/c/75299/ ?
[02:35:00] <grrrit-wm>	 (03PS3) 10Cscott: Allow lines empty but for tabs and comments to be ignored. [core] - 10https://gerrit.wikimedia.org/r/78327 
[02:43:01] <grrrit-wm>	 (03CR) 10Reedy: "(3 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75299 (owner: 10Legoktm)
[02:46:21] <grrrit-wm>	 (03CR) 10Cscott: "I worked on this a bit with TimStarling:" [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent)
[02:58:29] <grrrit-wm>	 (03PS1) 10Cscott: Add parserTests for language converter markup. [core] - 10https://gerrit.wikimedia.org/r/78330 
[03:04:36] <grrrit-wm>	 (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott)
[03:10:05] <grrrit-wm>	 (03CR) 10Cscott: "Somewhat surprisingly, there are actually a 3,015 articles in enwiki-20130708 containing a line which would be a line-eating-comment excep" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[03:24:59] <grrrit-wm>	 (03CR) 10Cscott: "What's the expected output with sr-ec? We're using -{R|..}- so I wouldn't expect anything to actually depend on the language selected." [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott)
[03:31:54] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032] Fix up authors: Add self and correct spelling in Matthias' name. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78324 (owner: 10Werdna)
[03:32:05] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [V: 032] Fix up authors: Add self and correct spelling in Matthias' name. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78324 (owner: 10Werdna)
[03:34:12] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Flow: Strip out the Parsoid boilerplate before saving to DB. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78323 (owner: 10Werdna)
[03:34:41] <grrrit-wm>	 (03CR) 10Legoktm: "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75299 (owner: 10Legoktm)
[03:35:31] <grrrit-wm>	 (03PS8) 10Legoktm: Edit via the API instead of WikiPage::doEditContent. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75299 
[03:37:45] <legoktm>	 Reedy: ^
[03:38:31] <grrrit-wm>	 (03CR) 10Liangent: "With no change in output. Just to confirm that -{R| takes effect to prevent text from being converted to Cyrl." [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott)
[03:38:45] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[04:03:40] <grrrit-wm>	 (03PS2) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 
[04:03:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove the checkbox for global deliveries, simply use the spamlist [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 (owner: 10Legoktm)
[04:08:02] <grrrit-wm>	 (03PS3) 10Legoktm: Remove the checkbox for global deliveries, simply use the spamlist [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78047 
[04:10:31] <grrrit-wm>	 (03PS1) 10Legoktm: Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 
[04:11:19] <grrrit-wm>	 (03PS1) 10Legoktm: Update comment to reflect we're using $wgConf, not SiteMatrix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78335 
[04:11:37] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Update comment to reflect we're using $wgConf, not SiteMatrix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78335 (owner: 10Legoktm)
[04:11:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update comment to reflect we're using $wgConf, not SiteMatrix [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78335 (owner: 10Legoktm)
[04:11:55] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Not all target arrays have a 'site' value, but all will have 'dbname' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78334 (owner: 10Legoktm)
[04:19:42] <grrrit-wm>	 (03CR) 10Tim Starling: "Why does compiling against a later libc make it work with more installations? I would have thought that later libc's would have versioned " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie)
[04:27:10] <grrrit-wm>	 (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78181 (owner: 10Siebrand)
[04:31:00] <grrrit-wm>	 (03PS1) 10Legoktm: Use WikiPage::factory() instead of Article::newFromTitle() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78337 
[04:35:59] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 (owner: 10Werdna)
[04:39:43] <grrrit-wm>	 (03PS1) 10Legoktm: Add documentation for member variables, declare isGlobal at the top [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78339 
[04:40:17] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Add documentation for member variables, declare isGlobal at the top [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78339 (owner: 10Legoktm)
[04:43:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add documentation for member variables, declare isGlobal at the top [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78339 (owner: 10Legoktm)
[04:49:40] <grrrit-wm>	 (03PS1) 10MarkTraceur: Initial commit - working demo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/78341 
[05:00:37] <grrrit-wm>	 (03PS1) 10Legoktm: Add a function that returns a list of categories the page is a member of [core] - 10https://gerrit.wikimedia.org/r/78343 
[05:07:12] <grrrit-wm>	 (03PS1) 10Legoktm: Allow users to opt-out of receiving messages by adding the page to a category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 
[05:19:29] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 04-1] "I think the way it is presented in Special:Preferences is too much clutter for a default install, or really, for any wiki other than a lar" [core] - 10https://gerrit.wikimedia.org/r/10243 (owner: 10Liangent)
[05:25:11] <grrrit-wm>	 (03CR) 10Liangent: "Tim: is there a way to have preferences added without adding new fields on Special:Preferences?" [core] - 10https://gerrit.wikimedia.org/r/10243 (owner: 10Liangent)
[05:33:31] <grrrit-wm>	 (03CR) 10Liangent: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/65477 (owner: 10Liangent)
[05:55:20] <grrrit-wm>	 (03PS1) 10Reedy: Actually save value of gu_home_db when saving user [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78349 
[06:05:55] <grrrit-wm>	 (03CR) 10Cscott: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[06:16:13] <grrrit-wm>	 (03PS1) 10Legoktm: Don't create a usergroup, just give the right to sysops and let WMF wikis customize their own setup [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78350 
[06:19:38] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Don't create a usergroup, just give the right to sysops and let WMF wikis customize their own setup [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78350 (owner: 10Legoktm)
[06:19:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't create a usergroup, just give the right to sysops and let WMF wikis customize their own setup [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78350 (owner: 10Legoktm)
[06:22:47] <grrrit-wm>	 (03CR) 10Tim Starling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78327 (owner: 10Cscott)
[06:25:15] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Works like a charm, thanks for fixing :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78349 (owner: 10Reedy)
[06:25:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actually save value of gu_home_db when saving user [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78349 (owner: 10Reedy)
[06:31:18] <grrrit-wm>	 (03PD1) 10Ori.livneh: Add Wikidata role [vagrant] - 10https://gerrit.wikimedia.org/r/70657 
[06:47:56] <grrrit-wm>	 (03PS12) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 
[06:47:57] <grrrit-wm>	 (03PS12) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 
[06:47:58] <grrrit-wm>	 (03PS20) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 
[06:47:59] <grrrit-wm>	 (03PS28) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 
[06:53:21] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix name spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78352 
[06:53:31] <grrrit-wm>	 (03CR) 10Hoo man: "As far as I see now, yes" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598)
[06:53:36] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Fix name spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78352 (owner: 10Matthias Mullie)
[06:53:44] <grrrit-wm>	 (03CR) 10Matthias Mullie: [V: 032] Fix name spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78352 (owner: 10Matthias Mullie)
[06:58:15] <grrrit-wm>	 (03PS2) 10Nemo bis: Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 
[06:58:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 (owner: 10Nemo bis)
[07:07:18] <grrrit-wm>	 (03PS1) 10Reedy: Add a script to populate globaluser.gu_home_db [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78353 
[07:16:41] <grrrit-wm>	 (03CR) 10CSteipp: "Can we keep all the names from globalnames in memory? I'm not sure how big that table is." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78353 (owner: 10Reedy)
[07:18:30] <grrrit-wm>	 (03PS3) 10Nemo bis: Make PLURAL support on foxway-php-fatal-error-max-execution-time explicit [extensions/Foxway] - 10https://gerrit.wikimedia.org/r/78312 
[07:19:05] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "I copied it from older scripts which did the same. Though, of course there'd be less users back then" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78353 (owner: 10Reedy)
[07:24:14] <grrrit-wm>	 (03PS1) 10Reedy: Update header code to newer standards [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78354 
[07:25:44] <grrrit-wm>	 (03PS2) 10Reedy: Add a script to populate globaluser.gu_home_db [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78353 
[07:26:08] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] Add a script to populate globaluser.gu_home_db [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/78353 (owner: 10Reedy)
[07:26:51] <grrrit-wm>	 (03CR) 10Zfilipin: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78118 (owner: 10Manybubbles)
[07:48:00] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi)
[07:51:42] <grrrit-wm>	 (03PS1) 10Nemo bis: Add PLURAL support to push-tab-*-override [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 
[07:54:05] <grrrit-wm>	 (03PS2) 10Nemo bis: Add PLURAL support to push-tab-*-override [extensions/Push] - 10https://gerrit.wikimedia.org/r/78356 
[08:32:58] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update README file [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78363 
[08:33:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update README file [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78363 (owner: 10Jeroen De Dauw)
[08:36:14] <grrrit-wm>	 (03CR) 10Bsitu: "This change needs rebasing. I will bring this layout change to the designer and see what she thinks" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 (owner: 10Matmarex)
[08:46:18] <grrrit-wm>	 (03PS2) 10Bsitu: Message notification-page-linked needs full-stop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/78020 
[08:48:29] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/78020 (owner: 10Bsitu)
[08:49:29] <grrrit-wm>	 (03CR) 10Legoktm: "Should not be merged until https://gerrit.wikimedia.org/r/#/c/78343/ is merged" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78344 (owner: 10Legoktm)
[08:52:19] <grrrit-wm>	 (03CR) 10Bsitu: "Oops, never mind about the rebasing. Did not notice the dependency" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 (owner: 10Matmarex)
[08:59:35] <grrrit-wm>	 (03CR) 10Siebrand: "Yes, there is. You can mark a preference as being of type "api". See extension TranslationNotifications::onGetPreferences in extension Tra" [core] - 10https://gerrit.wikimedia.org/r/10243 (owner: 10Liangent)
[09:02:23] <se4598_2>	 Nemo_bis: What do you mean by https://gerrit.wikimedia.org/r/72496 ? AFTv5 should still be opt-in on enwiki
[09:12:47] <grrrit-wm>	 (03CR) 10TheDJ: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 (owner: 10Rtdwivedi)
[09:14:17] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Message notification-page-linked needs full-stop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/78020 (owner: 10Bsitu)
[09:14:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Message notification-page-linked needs full-stop [extensions/Echo] - 10https://gerrit.wikimedia.org/r/78020 (owner: 10Bsitu)
[09:17:07] <Nemo_bis>	 se4598_2: it's in the toolbox for everyone
[09:17:26] <Nemo_bis>	 se4598_2: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Article_Feedback_Tool/Version_5&diff=prev&oldid=567792462
[09:17:44] <legoktm>	 probably because default=>true
[09:20:08] <se4598_2>	 Nemo_bis: there was/is probably a bug, which caused to set the opt-in-flag (set by this function) is also set on every article, which has the AFT-category (faced an issue on dewiki at deactivation which caused at least that symtoms)
[09:20:15] <grrrit-wm>	 (03PS7) 10Liangent: Allow more than one variant set in user preferences. [core] - 10https://gerrit.wikimedia.org/r/10243 
[09:20:39] <Nemo_bis>	 se4598_2: just try special:random on en.wiki
[09:21:27] <Nemo_bis>	 it's also the only explanation on why this list is needed: the categories are no longer in control http://ee-prototype.wmflabs.org/metrics/aftv5_enabled_pages.php?wiki=enwiki
[09:22:33] <se4598_2>	 thats a feature that you don't need categorys, but also can _enable_ it by one click (this link have logged-in users only)
[09:23:07] <se4598_2>	 Nemo_bis: e,g. I don't see it enabled on https://en.wikipedia.org/wiki/Equilateral_polygon
[09:23:22] <Nemo_bis>	 are you logged out?
[09:23:42] <Nemo_bis>	 I know what the feature does, but it was enabled with a wrong commit message and it wasn't notified to anyone
[09:24:17] <se4598_2>	 Nemo_bis: are we talking about the activation link or the feedbackbox? (which only appear if its enabled)
[09:24:30] <Nemo_bis>	 I'm talking about both
[09:24:53] <Nemo_bis>	 the link is everywhere and can't be removed
[09:25:07] <Nemo_bis>	 the box is everywhere in consequence, just a click away
[09:25:59] <se4598_2>	 Nemo_bis: thats by design afaik, just no need for users to deal with inconvenient categories for activiation
[09:26:55] <se4598_2>	 before users has to insert the category, now you do only a click, so theoretical still opt-in
[09:28:01] <Nemo_bis>	 so what
[09:29:24] <grrrit-wm>	 (03PS8) 10Liangent: Allow more than one variant set in user preferences. [core] - 10https://gerrit.wikimedia.org/r/10243 
[09:30:37] <grrrit-wm>	 (03CR) 10Liangent: "The current patch adds new preferences items as type=api, so some more fancy stuff can be done in ULS." [core] - 10https://gerrit.wikimedia.org/r/10243 (owner: 10Liangent)
[09:30:45] <grrrit-wm>	 (03PS9) 10Liangent: Allow more than one variant set in user preferences. [core] - 10https://gerrit.wikimedia.org/r/10243 
[09:32:14] <grrrit-wm>	 (03PS3) 10Reedy: Attempt to remove a hard-coded "wikipedia". [core] - 10https://gerrit.wikimedia.org/r/66338 (owner: 10Liangent)
[09:33:35] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Attempt to remove a hard-coded "wikipedia". [core] - 10https://gerrit.wikimedia.org/r/66338 (owner: 10Liangent)
[09:34:51] <thedj_>	 marktraceur: i know our accessbiility trackrecord isn't too well, but if we start replacing HTML elements, it really is time to start making this part of our acceptance criteria.
[09:36:09] <thedj_>	 i'm actually working on some vector fixes for accessibility, because we really can and should do more there.
[09:38:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Attempt to remove a hard-coded "wikipedia". [core] - 10https://gerrit.wikimedia.org/r/66338 (owner: 10Liangent)
[09:39:34] <se4598_2>	 Nemo_bis: If feedback is activated by a user clicking on this toolbox-link,feedback-submission can be disabled via a similiar link on the aftv5-special page of this page (top-right: gear icon). And as I previously said I really don't see feedback enabled for users on all pages
[09:40:14] <grrrit-wm>	 (03PS1) 10Nemo bis: Make two info action row headers plural-compatible and consistent [core] - 10https://gerrit.wikimedia.org/r/78371 
[09:40:46] <Nemo_bis>	 se4598_2: I didn't say feedback is enabled on all pages, I said AFT is
[09:44:58] <se4598_2>	 somewhat misleading heading. that's the same for me, but I think I got your point.
[10:18:41] <grrrit-wm>	 (03PS1) 10Nemo bis: Complete PLURAL support in mwe-upwiz-mins-secs-remaining [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78372 
[10:26:06] <grrrit-wm>	 (03PS1) 10Rjain: Added the db_patch files for renaming rev_id and user_id column [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78373 
[10:48:12] <grrrit-wm>	 (03PS1) 10Kiran mathew koshy 1993: Fixed a bug which caused a segmentation fault if the url passed to zimDump was not found in the zim file. [openzim] - 10https://gerrit.wikimedia.org/r/78374 
[10:51:39] <grrrit-wm>	 (03CR) 10Anomie: "Err, 2.5 *is* earlier than 2.11." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/77905 (owner: 10Anomie)
[11:12:51] <grrrit-wm>	 (03PS1) 10Nemo bis: Rephrase the installer's config-welcome message [core] - 10https://gerrit.wikimedia.org/r/78375 
[11:16:00] <grrrit-wm>	 (03CR) 10Liangent: "Reedy: You need to merge another change in configurations as well to make the site work." [core] - 10https://gerrit.wikimedia.org/r/66338 (owner: 10Liangent)
[11:42:02] <grrrit-wm>	 (03PS1) 10Nemo bis: Make logout text simpler and more general [core] - 10https://gerrit.wikimedia.org/r/78376 
[12:21:26] <grrrit-wm>	 (03Abandoned) 10Kiran mathew koshy 1993: Fixed a bug which caused a segmentation fault if the url passed to zimDump was not found in the zim file. [openzim] - 10https://gerrit.wikimedia.org/r/78374 (owner: 10Kiran mathew koshy 1993)
[12:25:41] <grrrit-wm>	 (03PS1) 10Kiran mathew koshy 1993: Fixed a bug in two funnctions which caused zimdump to cause a segmentation fault when the url passed was not found in the zim file. The error occurred when the tool attempts to display the article. [openzim] - 10https://gerrit.wikimedia.org/r/78379 
[12:49:20] <grrrit-wm>	 (03CR) 10Reedy: "I know. But this isn't going to be going live for nearly a week, so there isn't any rush to do so!" [core] - 10https://gerrit.wikimedia.org/r/66338 (owner: 10Liangent)
[13:09:25] <legoktm>	 Elsie: Can you take a look at https://gerrit.wikimedia.org/r/#/c/78047/ ? Do you think that doing it that way is ok?
[13:18:13] <grrrit-wm>	 (03CR) 10Manybubbles: "Luckily it is a random one I keep for that beta system but still." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78118 (owner: 10Manybubbles)
[13:53:14] <grrrit-wm>	 (03PS1) 10Manybubbles: Basic regression test for highlighting found terms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78383 
[14:08:23] <grrrit-wm>	 (03PS1) 10Legoktm: Don't use wfMemcKey so the cache is not split across multiple wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78385 
[14:11:33] <grrrit-wm>	 (03PS1) 10Manybubbles: Move test password overrides to untracked file. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78386 
[14:12:19] <grrrit-wm>	 (03CR) 10Manybubbles: "Fix proposed in https://gerrit.wikimedia.org/r/#/c/78386/" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78118 (owner: 10Manybubbles)
[14:14:46] <grrrit-wm>	 (03PS1) 10Legoktm: move AbuseFilter attribution to the only function that came from it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78387 
[14:17:37] <grrrit-wm>	 (03PS13) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 
[14:17:38] <grrrit-wm>	 (03PS13) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 
[14:17:39] <grrrit-wm>	 (03PS21) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 
[14:17:40] <grrrit-wm>	 (03PS29) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 
[14:17:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 (owner: 10Rtdwivedi)
[14:23:49] <grrrit-wm>	 (03PS1) 10Reedy: Update to master [extensions] - 10https://gerrit.wikimedia.org/r/78388 
[14:24:18] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Update to master [extensions] - 10https://gerrit.wikimedia.org/r/78388 (owner: 10Reedy)
[14:25:13] <grrrit-wm>	 (03CR) 10Reedy: [V: 032] Update to master [extensions] - 10https://gerrit.wikimedia.org/r/78388 (owner: 10Reedy)
[14:28:14] <grrrit-wm>	 (03PS1) 10Nemo bis: Add "Your e-mail address will not be published" to MediaWiki:Requestaccount-acc-text [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/78389 
[14:29:33] <grrrit-wm>	 (03PS1) 10Reedy: Add 6 new extensions [extensions] - 10https://gerrit.wikimedia.org/r/78390 
[14:30:15] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Add 6 new extensions [extensions] - 10https://gerrit.wikimedia.org/r/78390 (owner: 10Reedy)
[14:30:24] <ori-l>	 Reedy: 6?
[14:30:42] <Reedy>	 Indeed
[14:34:19] <grrrit-wm>	 (03PS1) 10Nemo bis: Clarify maps-displaymap-par-visitedicon [extensions/Maps] - 10https://gerrit.wikimedia.org/r/78391 
[14:39:25] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] Reusable external store insertion with fallback [core] - 10https://gerrit.wikimedia.org/r/77979 (owner: 10EBernhardson (WMF))
[14:46:38] <grrrit-wm>	 (03PS1) 10Ragesoss: Change course status "Passed" to "Previous" to avoid ambiguity about "passing" a course. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78392 
[16:09:43] <grrrit-wm>	 (03PS4) 10Se4598: Add triggered filter id as parameter to messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 
[16:11:03] <grrrit-wm>	 (03CR) 10Se4598: "reverting the message change." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598)
[16:21:50] <grrrit-wm>	 (03PS14) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 
[16:21:51] <grrrit-wm>	 (03PS14) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 
[16:21:52] <grrrit-wm>	 (03PS22) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 
[16:22:39] <grrrit-wm>	 (03PS1) 10Ori.livneh: Load 'Edit' schema & register EL as ve.track handler [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/78399 
[16:23:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load 'Edit' schema & register EL as ve.track handler [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/78399 (owner: 10Ori.livneh)
[16:25:50] <grrrit-wm>	 (03PS1) 10BryanDavis: Add apache::config puppet class. [vagrant] - 10https://gerrit.wikimedia.org/r/78401 
[16:54:24] <grrrit-wm>	 (03PS1) 10Nemo bis: Add email recipient username as a parameter to emailuser confirmation [core] - 10https://gerrit.wikimedia.org/r/78404 
[16:59:33] <grrrit-wm>	 (03PS1) 10Ori.livneh: Test for HTTPS support & log results. [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/78405 
[17:03:25] <grrrit-wm>	 (03PS2) 10Ori.livneh: Test for HTTPS support & log results. [extensions/CoreEvents] - 10https://gerrit.wikimedia.org/r/78405 
[17:03:37] <MatmaRex>	 @seen rillke
[17:03:37] <wm-bot>	 MatmaRex: Last time I saw rillke they were quitting the network with reason: Quit: Leaving. N/A at 8/9/2013 9:49:58 AM (7h13m38s ago)
[17:03:59] <MatmaRex>	 why is he not here when i need him, meh.
[17:04:07] <grrrit-wm>	 (03CR) 10BryanDavis: "@Ori" [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis)
[17:04:19] <bd808>	 ori-l: ^^^
[17:04:55] <bd808>	 ori-l: maybe we should discuss in chat?
[17:05:47] <ori-l>	 i'm passing out, though -- it's 1 AM. i glanced through your apache config patch and it looks good, just want to test it a bit before merging
[17:06:18] <bd808>	 damn you HK time!
[17:06:30] <ori-l>	 i read your comment. i think in that case i'd simply make it a template
[17:07:03] <ori-l>	 it's not a very deep objection that i have here -- i just don't like giant string literals (or array of string literals) in puppet
[17:07:25] <bd808>	 I agree. I'll do some more refactoring
[17:07:26] <ori-l>	 i'd keep the class but pass the rendered template as content
[17:07:57] <bd808>	 doesn't that eliminate the need for file {} (at least in this case)
[17:08:24] <bd808>	 in my understanding template() can't read from fileserver
[17:08:45] <ori-l>	 yeah, you'd just put it in puppet/templates
[17:08:51] <ori-l>	 which does eliminate the need for the fileserver
[17:08:59] <ori-l>	 so i may have been overeager there
[17:09:23] <bd808>	 ok. I just didn't want to spin off in a weird direction
[17:09:31] <bd808>	 get some sleeps
[17:10:10] <ori-l>	 thanks; i appreciate the patches & will def. review tomorrow
[17:26:25] <grrrit-wm>	 (03PS1) 10Ragesoss: Add a link to show user subpages for each student in the articles table. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78407 
[17:31:49] <grrrit-wm>	 (03PS1) 10Matmarex: Remove inconsistent font-family declarations [core] - 10https://gerrit.wikimedia.org/r/78408 
[17:35:41] <grrrit-wm>	 (03CR) 10Tpt: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi)
[17:38:20] <grrrit-wm>	 (03PS2) 10Ragesoss: Add a link to show user subpages for each student in the articles table. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/78407 
[17:40:44] <MatmaRex>	 Nikerabbit: you there?
[17:41:03] <MatmaRex>	 Nikerabbit: is $extraUserToggles in MessagesXX.php fies actually used anywhere?
[17:41:18] <MatmaRex>	 Nikerabbit: it seems to only be defined for english, and is an empty array
[17:44:12] <grrrit-wm>	 (03PS1) 10BryanDavis: Add Puppet role for thumb.php 404 handler. [vagrant] - 10https://gerrit.wikimedia.org/r/78409 
[17:44:48] <Nemo_bis>	 MatmaRex: it's 2 am in HK
[17:45:23] <MatmaRex>	 niklas has apparently only been idle for 20 minutes, though, so i was hoping
[17:45:37] <MatmaRex>	 also, i regularly sit here until 3 am, my timezone. :P
[17:50:43] <grrrit-wm>	 (03PS2) 10BryanDavis: Add Puppet role for thumb.php 404 handler. [vagrant] - 10https://gerrit.wikimedia.org/r/78409 
[17:52:09] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 04-2] "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/78260 (owner: 10BryanDavis)
[17:52:22] <grrrit-wm>	 (03Abandoned) 10BryanDavis: Add Puppet role for thumb.php 404 handler. [vagrant] - 10https://gerrit.wikimedia.org/r/78260 (owner: 10BryanDavis)
[17:52:53] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032 V: 032] (bug 22808) Don't count "expensive" calls for cached titles [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/65828 (owner: 10Liangent)
[17:52:56] <grrrit-wm>	 (03CR) 10Demon: [C: 031] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78311 (owner: 10Manybubbles)
[17:54:11] <grrrit-wm>	 (03PS1) 10Matmarex: Remove "Misc" tab from Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/78410 
[17:55:57] <grrrit-wm>	 (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78311 (owner: 10Manybubbles)
[17:56:11] <grrrit-wm>	 (03PS3) 10Manybubbles: Improve suggestion configuration. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/78311 
[17:56:19] <grrrit-wm>	 (03CR) 10Matmarex: "Andrew, you added the extraUserToggles stuff back in 2009, do you by chance remember what it was for?" [core] - 10https://gerrit.wikimedia.org/r/78410 (owner: 10Matmarex)
[18:06:31] <grrrit-wm>	 (03CR) 10Matmarex: [C: 032] "Filed bug 52677 about the jquery.accessibility library." [core] - 10https://gerrit.wikimedia.org/r/78071 (owner: 10TheDJ)
[18:07:23] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Syncing parsoid tests with core [core] - 10https://gerrit.wikimedia.org/r/78411 
[18:07:23] * werdna  waves

[18:07:52] <grrrit-wm>	 (03CR) 10Matmarex: [C: 032] Accessibility: make columnheader the primary role of the element [core] - 10https://gerrit.wikimedia.org/r/78066 (owner: 10TheDJ)
[18:08:11] <MatmaRex>	 hi werdna
[18:08:17] <MatmaRex>	 werdna: [19:56] <grrrit-wm> (CR) Matmarex: "Andrew, you added the extraUserToggles stuff back in 2009, do you by chance remember what it was for?" [core] - https://gerrit.wikimedia.org/r/78410 (owner: Matmarex)
[18:08:28] <werdna>	 saw it in my email
[18:08:41] <werdna>	 I believe it existed in the original preferences
[18:08:49] <werdna>	 used by extensions to add new toggles
[18:09:03] <werdna>	 I don't know how you could remove it except by killing the misc section if it's empty
[18:09:10] <werdna>	 but otherwise it'll need to stay
[18:09:25] <werdna>	 or you'll need to establish that no extension of importance uses
[18:09:27] <werdna>	 it
[18:09:29] <MatmaRex>	 it's not even displayed in the misc section
[18:09:40] <MatmaRex>	 and i don't think extensions can add anything there
[18:09:49] <MatmaRex>	 as this is defined in language files
[18:10:00] <werdna>	 oh maybe it's for languages to add extra options then
[18:10:03] <MatmaRex>	 i'm not killing it anyway
[18:10:17] <werdna>	 I think the sanest handling would be simply to hide the misc section if the array is empty
[18:10:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Accessibility: Don't arbitrarily override role [core] - 10https://gerrit.wikimedia.org/r/78071 (owner: 10TheDJ)
[18:10:20] <werdna>	 and otherwise show it
[18:11:00] <MatmaRex>	 it's not even shown in the misc section
[18:11:02] <MatmaRex>	 and never was
[18:11:11] <MatmaRex>	 it is shown in personal/i18n
[18:12:02] <Nemo_bis>	 language converter?
[18:12:52] <grrrit-wm>	 (03CR) 10Matmarex: "Would the decreased TTL really be this dangerous?" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/73188 (owner: 10Brian Wolff)
[18:12:58] <MatmaRex>	 Nemo_bis: no, it's separate
[18:13:05] <MatmaRex>	 it's a weird little thing that nothing uses anywhere
[18:13:13] <MatmaRex>	 but, i'm not touching that. :P
[18:13:33] <werdna>	 MatmaRex: ah my mistake, I assumed from the title of the change
[18:13:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Accessibility: make columnheader the primary role of the element [core] - 10https://gerrit.wikimedia.org/r/78066 (owner: 10TheDJ)
[18:14:05] <Nemo_bis>	 scary
[18:14:06] <Nemo_bis>	 20.12 < Nemo_bis> language converter?
[18:14:06] <Nemo_bis>	 20.12 -!- liangent [~liangent@wikipedia/Liangent] has joined #wikimedia-dev
[18:14:36] <bawolff>	 lol
[18:14:56] <liangent>	 Nemo_bis: what?
[18:16:22] <Nemo_bis>	 liangent: I mentioned language converter and you appeared few secs later
[18:16:35] <werdna>	 MatmaRex: Anyway, my answer to your question is "It existed in the existing preferences system"
[18:17:11] * liangent  is reading channel logs

[18:18:17] <MatmaRex>	 werdna: okay
[18:18:23] <MatmaRex>	 wanna review that change, btw? :P
[18:19:02] * ^d  wants more review

[18:19:16] <werdna>	 MatmaRex: I could probably take a look
[18:19:28] <werdna>	 it's friday and everybody I'm working with is hong kong or wfh
[18:19:58] <bawolff>	 Anyone know the url to "beta commons"?
[18:20:24] <^d>	 bawolff: http://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page
[18:20:33] <bawolff>	 thanks
[18:20:35] <^d>	 yw
[18:23:14] <grrrit-wm>	 (03CR) 10Matmarex: "Please note that I am intentionally not removing messages for heading text in case some extension used that tab; we already have one such " [core] - 10https://gerrit.wikimedia.org/r/78410 (owner: 10Matmarex)
[18:23:54] <werdna>	 beta commons
[18:25:48] <bawolff>	 oh hmm, beta commons has code editor enabled for js pages. That's really cool
[18:26:00] * bawolff  wonders why we don't do that in general, its really slick

[18:27:44] <Nemo_bis>	 ^d: more incoming or outgoing review? :)
[18:32:02] <werdna>	 ebernhardson: around?
[18:33:06] <werdna>	 subbu|lunch: where are you based?
[18:33:15] <werdna>	 I assumed you were in Hong Kong with everyone else
[18:33:36] <werdna>	 but it's like 2am there so I guess you're not eating lunch at 2am
[18:36:11] <grrrit-wm>	 (03PS1) 10Nemo bis: Clarify info action's "search engine status" [core] - 10https://gerrit.wikimedia.org/r/78413 
[18:40:54] <grrrit-wm>	 (03CR) 10Matmarex: "Re first thing, good point, will do." [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Matmarex)
[18:41:05] <grrrit-wm>	 (03PS2) 10Matmarex: mediawiki.action.edit: Add styles for edit form's footer [core] - 10https://gerrit.wikimedia.org/r/76067 
[18:46:09] <grrrit-wm>	 (03CR) 10TheDJ: [C: 04-1] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 (owner: 10Rtdwivedi)
[18:47:23] <grrrit-wm>	 (03PS3) 10Matmarex: mediawiki.action.edit: Add styles for edit form's footer [core] - 10https://gerrit.wikimedia.org/r/76067 
[18:47:57] <grrrit-wm>	 (03CR) 10Matmarex: [C: 031] Clarify info action's "search engine status" [core] - 10https://gerrit.wikimedia.org/r/78413 (owner: 10Nemo bis)
[18:51:27] <grrrit-wm>	 (03CR) 10TheDJ: "Ah, I happened to test with cologneblue, so that explains. Shall we handle that one separately then ?" [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Matmarex)
[18:54:45] <subbu|lunch>	 werdna, yes, i had an early lunch today, just not 2am early ;-) .. i normally eat around 2pm.  i am in minneapolis
[18:55:01] <werdna>	 ahhh
[18:55:16] <grrrit-wm>	 (03CR) 10Nemo bis: "Well, I intended to say "any less complex", but what I mean is that they're comparably complex." [core] - 10https://gerrit.wikimedia.org/r/78413 (owner: 10Nemo bis)
[18:58:39] <grrrit-wm>	 (03PS15) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 
[18:58:40] <grrrit-wm>	 (03PS15) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 
[18:58:41] <grrrit-wm>	 (03PS23) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 
[19:03:06] <ebernhardson>	 werdna: yea
[19:04:44] <grrrit-wm>	 (03PS8) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[19:04:48] <werdna>	 ebernhardson: sweet. Just addressed your comments
[19:04:50] <werdna>	 one little TODO
[19:05:00] <werdna>	 which I couldn't figure out
[19:06:06] <grrrit-wm>	 (03PS9) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[19:06:11] <werdna>	 (changed commit msg)
[19:06:55] <ebernhardson>	 werdna: hmm, well when you use the RootPostLoader, and fetch the identity map it returns an array mapping from the postId of all posts of any depth to the object
[19:07:19] <ebernhardson>	 werdna: typically we only pull the roots out of it, since it also links all the children together
[19:07:32] <ebernhardson>	 werdna: but perhaps since already loading that, can use it to check if the history post is actually in the topics?
[19:08:17] <Rtdwivedi>	 thedj: Thanks for the review!
[19:08:32] <ebernhardson>	 oh hmm, actually Topic doesn't always have access to the loader, sometimes it just gets the root from TopicList, so its not a simple refactor :)
[19:08:37] <werdna>	 yeah
[19:08:45] <werdna>	 I was hoping I could stick a condition in
[19:08:50] <werdna>	 one little bitty condition
[19:08:53] <werdna>	 like the one I have there
[19:08:57] <werdna>	 but I'm not sure if that plays nice with caching
[19:09:16] <ebernhardson>	 well, the straightforward way would be to request the list of all descendants from the tree repository, which is cached
[19:09:30] <ebernhardson>	 then you can do in_array( $postId, $allDescendants)
[19:09:37] <ebernhardson>	 its a duplicate round trip, but not a big deal
[19:09:38] <werdna>	 well, I mean
[19:09:53] <werdna>	 the thing is that we end up with lots of round trips in this case anyway
[19:10:07] <werdna>	 because you round trip for every topic if any history is requested
[19:10:08] <ebernhardson>	 you want to store the owning topic in each post? that plays ugly with topic splits though
[19:10:28] <werdna>	 if there's a fall through cache then it's not a big deal
[19:10:52] <werdna>	 it roundtrips once, and then loads it from one location in memory to another location in memory for every topic
[19:10:56] <werdna>	 which is not a problem really
[19:11:00] <ebernhardson>	 yea
[19:11:21] <werdna>	 the problem is that if there isn't a cache, it roundtrips looking for history once for every topic, even if no history is requested from that topic
[19:11:48] <grrrit-wm>	 (03PS16) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 
[19:11:49] <grrrit-wm>	 (03PS16) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 
[19:11:50] <grrrit-wm>	 (03PS24) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 
[19:11:56] <werdna>	 if we do have the full post tree in, then we can try flattening that, and then we have something to work off for filtering the array of posts to get history for
[19:12:03] <werdna>	 and I mean, in theory we do have the full post tree
[19:12:36] <ebernhardson>	 shouldn't have to flatten post tree, it comes from loader as flat and nested at same time
[19:12:49] <werdna>	 oh neat
[19:13:31] <werdna>	 but where? I can only assume that when loadRootPost loads the root post, it also loads all the children
[19:13:59] <werdna>	 so then accessing the data is tricky
[19:14:18] <werdna>	 you have to traverse the whole post tree recursively
[19:14:25] <ebernhardson>	 hmm, well i guess it needs a minor tweak, but not major.  The very last think RootPostLoader::getMulti does is take only the roots from the array
[19:14:29] <grrrit-wm>	 (03CR) 10Matmarex: "Yeah, I think that's a good idea." [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Matmarex)
[19:14:30] <ebernhardson>	 s/think/thing/
[19:14:48] <ebernhardson>	 so, just return the full $posts array instead of just the roots 
[19:15:50] <werdna>	 I'm open to some flexibility here, we can move most of getMulti() to its own function and then have getMulti() just do the stripping of nonroot posts.
[19:16:09] <werdna>	 or add a function which will do that stripping for us.
[19:16:10] <werdna>	 or something.
[19:16:19] <ebernhardson>	 yea, either way i'm fine with
[19:16:22] <werdna>	 (though, it seems like that logic could live in loadRootPost()
[19:16:30] <werdna>	 where else is RootPostLoader called from?
[19:16:52] <ebernhardson>	 Topic and TopicList
[19:17:05] <ebernhardson>	 Topic loads just one, topic list loads many in a single batch and provides them to topics
[19:18:05] <werdna>	 hmmm, it seems like post trees are loaded in lots of places
[19:18:18] <werdna>	 maybe it's better not to fight that and to just traverse it
[19:18:37] <werdna>	 it's only O(n)
[19:19:32] <werdna>	 seems like it might be easier and safer than trying to change everywhere that ever loads a post to also pass along a list of all descendants
[19:20:03] <ebernhardson>	 yea, a recursive function isnt going to kill us :)  Alternatly as mentioned before can go to the source that RootPostLoader is using,  TreeRepository::fetchSubtreeNodeList( $listOfPostIds )
[19:20:28] <werdna>	 doesn't even need to be recursive, I can just use a queue
[19:21:34] <werdna>	 does fetchSubtreeNodeList cache? am I going to add a duplicate roundtrip by doing that?
[19:21:38] <werdna>	 if so, I might as well just traverse
[19:21:49] <werdna>	 otherwise it doesn't matter so I can just do that.
[19:22:08] <ebernhardson>	 hmm, actually yea it doesn't cache internally because i wrote the TreeRepository as one of the first classes :) it requires that roundtrip to memcache on each
[19:22:12] <ebernhardson>	 just traverse, sounds like a plan
[19:27:26] <werdna>	 hey TrevorParscal 
[19:29:37] <grrrit-wm>	 (03PS10) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[19:29:58] <werdna>	 ebernhardson: wanna let me know what you think of the changes?
[19:30:02] <werdna>	 I've updated things as you suggested
[19:30:22] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Simplified the setup code by combining some functions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/78416 
[19:33:42] <ebernhardson>	 werdna: looks good :)
[19:33:53] <werdna>	 :D
[19:34:00] <werdna>	 seems to work, too!
[19:34:01] <werdna>	 :o
[19:35:16] <ebernhardson>	 can merge?
[19:35:36] <ebernhardson>	 i suppose i should try it actually :P
[19:37:28] <werdna>	 :p if you feel like it
[19:37:45] <werdna>	 You can use mw.flow.api.* functions in the JS console
[19:37:50] <werdna>	 if you wanna try it
[19:38:17] <werdna>	 try mw.flow.api.read( 'User talk:Andrew' )
[19:38:55] <werdna>	 then mw.flow.api.read( 'User talk:Andrew', undef, { 'topic_list' : { 'showhistoryfor' : ['some-post-id'] } } )
[19:39:30] <werdna>	 and mw.flow.executeAction( 'some-workflow-id', 'delete-post', { 'topic_list' : { 'postId' : 'blahblah' } } )
[19:39:38] <werdna>	 and so on
[19:39:50] <werdna>	 don't merge it just yet, I want to add CSRF protection
[19:41:50] <ebernhardson>	 ok
[19:42:56] <ebernhardson>	 werdna: also has a bug when no summary exists
[19:44:56] <werdna>	 oh yeah? what happens?
[19:46:01] <ebernhardson>	 werdna: Fatal error: Call to a member function getContent() on a non-object in /vagrant/mediawiki/extensions/Flow/includes/Block/Summary.php on line 92
[19:46:31] <MatmaRex>	 werdna: no idea what is being talked about here, but core already has a mediawiki.api module, and a few other modules in that "namespace"
[19:46:50] <MatmaRex>	 like mediawiki.api.edit
[19:46:56] <MatmaRex>	 so you guys might want to use that convention :)
[19:47:15] <MatmaRex>	 (and preferably make it work like the core stuff)
[19:47:25] <werdna>	 MatmaRex: I suppose it could become mw.flow.api rather than mw.api.flow
[19:47:33] <werdna>	 I'm using mw.api internally already
[19:47:44] <werdna>	 erm, the other way around,, you know what I mean
[19:48:18] <MatmaRex>	 yeah
[20:23:18] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] "Still need to review the related patches and check if we might have cache issues, but otherwise looking good." [core] - 10https://gerrit.wikimedia.org/r/76067 (owner: 10Matmarex)
[20:24:17] <grrrit-wm>	 (03PS1) 10TheDJ: Editform: Make editform 100% wide for colgoneblue as well [core] - 10https://gerrit.wikimedia.org/r/78461 
[20:46:12] <grrrit-wm>	 (03CR) 10Spage: "Matmarex raises a good point. The code guesses at what width the browser will lay the benefits out below." [core] - 10https://gerrit.wikimedia.org/r/72877 (owner: 10Spage)
[20:49:05] <grrrit-wm>	 (03PS1) 10Mwjames: spl_autoload_register SMW classes [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/78462 
[20:56:46] <grrrit-wm>	 (03PS11) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[20:56:53] <werdna>	 ebernhardson: now with CSRF protection \o/
[20:58:18] <ebernhardson>	 werdna: excellent
[20:59:30] <grrrit-wm>	 (03PS12) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[20:59:32] <werdna>	 updated API module doc
[21:01:15] <werdna>	 also tested it and posting a new topic works :D
[21:02:21] <grrrit-wm>	 (03CR) 10BryanDavis: "One thing I've noticed with this is that if I enable the role, provision, disable the role and then provision again the apache config snip" [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis)
[21:03:43] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 (owner: 10Werdna)
[21:03:52] <ebernhardson>	 werdna: just the no-summary bug :)
[21:04:03] <werdna>	 ah yeah forgot about that
[21:06:41] <ebernhardson>	 werdna: how odd does it sound to compress revision content from revision storage, but decompress it in the model object?  What i'm thinking is i dont want to decompress a bunch of content that might not be used
[21:07:48] <werdna>	 that's kinda ew.
[21:08:01] <werdna>	 I would lazy-decompress
[21:08:25] <werdna>	 so just store the compressed content and decompress it when somebody calls getContent()
[21:08:37] <werdna>	 in fact, I would retrieve it from external storage when somebody calls getContent()
[21:08:44] <grrrit-wm>	 (03PS1) 10Matmarex: HTMLCheckMatrix: Allow custom input names to be specified [core] - 10https://gerrit.wikimedia.org/r/78463 
[21:08:45] <grrrit-wm>	 (03PS1) 10Matmarex: Preferences: Show search namespace options in a matrix [core] - 10https://gerrit.wikimedia.org/r/78464 
[21:09:02] <MatmaRex>	 ^ this has the beautifullest ascii table in the commit message.
[21:09:09] <grrrit-wm>	 (03PS13) 10Werdna: Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 
[21:09:18] <werdna>	 ebernhardson: fixes the summary issue
[21:09:39] <ebernhardson>	 well, the issue there is two fold:  we want to batch the content requests not do them one at a time,  and the external store isnt natively backed by memcache it would need another layer.  So for initial simplicity, i figured cache the compress revision content in the main obj
[21:10:18] <ebernhardson>	 although,  i suppose another thought is that the memcache client natively compresses any value larger than some threshhold
[21:13:17] <werdna>	 external store is backed by memcached
[21:13:20] <werdna>	 at least afaik
[21:14:00] <ebernhardson>	 its usage in the core revisions is, but not the actual ExternalStore objects
[21:14:07] <werdna>	 mmmph
[21:14:33] <ebernhardson>	 at least, i think thats how it works i can be wrong too :)
[21:14:50] <werdna>	 localhost:externalstore andrew$ ack -i memc
[21:14:51] <werdna>	 localhost:externalstore andrew$
[21:15:27] <ebernhardson>	 yea, the memcache handling is in Revision::loadText
[21:15:35] <werdna>	 yeah, just found it myself
[21:16:07] <ebernhardson>	 could do similar i suppose, just need to make it batchable for tree renders
[21:16:16] <werdna>	 nod
[21:16:45] <werdna>	 though we can also load from the DB and store it along with the postrevision objects
[21:17:17] <ebernhardson>	 thats how its currently don
[21:17:42] <werdna>	 nod, so what's wrong with that? no point in caching twice
[21:17:54] <ebernhardson>	 well, we started with where does content decompression belong :)
[21:18:00] <werdna>	 mmmm, true
[21:18:02] <ebernhardson>	 it transparently inserts and compresses in the backend
[21:18:23] <ebernhardson>	 it doesnt have to retreive on query, because its already in the main cached object
[21:18:28] <ebernhardson>	 but it has to decompress somewhere :)
[21:18:33] <werdna>	 so why can't the decompression also happen in the storage layer?
[21:18:49] <ebernhardson>	 well, it can.  I just thought it might be wastefull when pulling lists of 100 objects that you dont need the content to
[21:19:15] <ebernhardson>	 but i suppose, thats a whole different class of problems, easiest is decompress in the backend as well
[21:19:34] <werdna>	 so you don't need to follow my comment about lazy loading from ES
[21:19:37] <werdna>	 (for caching reasons)
[21:19:38] <ebernhardson>	 will do :0
[21:19:41] <werdna>	 but why not lazily decompress?
[21:20:38] <ebernhardson>	 no great reason, that was the idea i first asked if seemed reasonable :)
[21:21:52] <werdna>	 you wanted to do it in the model layer though?
[21:22:06] <ebernhardson>	 yea, thats where getContent() is and the naturaly place to lazily decompress
[21:22:17] <werdna>	 oh i see what you mean
[21:22:25] <werdna>	 hmph
[21:22:47] <werdna>	 I guess there isn't a sane way to lazily decompress in the storage layer then?
[21:23:23] <ebernhardson>	 not really :)  After looking through the other options now though, doing it in getContent makes alot of sense and simplifies things
[21:24:14] <werdna>	 nod.
[21:24:24] <werdna>	 it would be my first instinct too
[21:24:54] <werdna>	 ebernhardson: are we done with API? Because I have my CSRF change that depends on it which I'd like to push to gerrit too
[21:24:57] <werdna>	 get it off my plate
[21:25:15] <ebernhardson>	 werdna: yea i think so, looks good
[21:25:29] <werdna>	 sweet :)
[21:25:37] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Add API modules to Flow. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78167 (owner: 10Werdna)
[21:26:19] <werdna>	 cheers
[21:26:50] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] More rigorous clearing of image redirect cache [core] - 10https://gerrit.wikimedia.org/r/77562 (owner: 10Brian Wolff)
[21:29:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: More rigorous clearing of image redirect cache [core] - 10https://gerrit.wikimedia.org/r/77562 (owner: 10Brian Wolff)
[21:31:49] <grrrit-wm>	 (03PS1) 10Frédéric Wang: Experimental MathJax branch: - use MathJax 2.3 - replace use of wiki2jax preprocessor by direct generation of MathJax's <script type="math/tex"> - use MediaWiki loader to load the relevant localization data in one go. - remove x-mathjax-config (and its ev [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 
[21:32:14] <grrrit-wm>	 (03PS1) 10Werdna: Flow: Add CSRF protection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78467 
[21:32:26] <werdna>	 theere we go
[21:33:03] <werdna>	 ebernhardson: ok, so I'm going to work on making the UI nice and pretty
[21:33:07] <grrrit-wm>	 (03CR) 10Frédéric Wang: [C: 04-1] "This is just an experimental commit to check how loading MathJax could be improved in MediaWiki." [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang)
[21:35:02] <werdna>	 ebernhardson: whoa, just looked at the prototype UI. I've got some work to do :D
[21:37:17] <ebernhardson>	 werdna: :)
[21:38:14] <grrrit-wm>	 (03PS3) 10BryanDavis: Add Puppet role for thumb.php 404 handler. [vagrant] - 10https://gerrit.wikimedia.org/r/78409 
[21:45:44] <werdna>	 ebernhardson: so editing…
[21:46:28] <werdna>	 ebernhardson: you have to take the Parsoid stuff and convert it back into wikitext? or use the visual editor? or?
[21:48:22] <grrrit-wm>	 (03CR) 10Frédéric Wang: "I think delayStartupUntil=configured is supposed to be passed as a query string for MathJax.js. Unfortunately, it seems that it is not pos" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang)
[21:48:58] <grrrit-wm>	 (03PS1) 10Brian Wolff: Add optional message to define default description for Upload [core] - 10https://gerrit.wikimedia.org/r/78468 
[21:52:02] <ebernhardson>	 werdna: the intention is to store the parsoid HTML5+RDFa representation
[21:52:14] <werdna>	 yeah, so we should technically do that for the summary too
[21:52:16] <ebernhardson>	 werdna: if editing as wikitext, parsoid it from that to wikitext, then back.  When using VE store directly
[21:52:21] <ebernhardson>	 werdna: yes it should be same
[21:52:44] <ebernhardson>	 the one thing i'm not sure, how to verify what the client sends us is actually HTML5+RDFa, and not just gobbleygook 
[21:52:47] <werdna>	 does parsoid have some helper class so we don't have to call parsoid itself
[21:52:50] <grrrit-wm>	 (03CR) 10Frédéric Wang: "FYI, I've created a branch to experiment how the code that loads MathJax could be rewritten/improve:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/69298 (owner: 10Physikerwelt)
[21:53:13] <werdna>	 ebernhardson: well presumably we'll just give them wikitext and let them edit that and parsoid it back into parsoid-format
[21:53:15] <ebernhardson>	 werdna: not sure, when i looked in the VE api classes they did the Http::post directly
[21:53:24] <werdna>	 and for VE, we'll do whatever VE does for editing.
[21:53:34] <werdna>	 ahk
[21:53:44] <werdna>	 we could really use having a VE person handy
[21:53:49] <ebernhardson>	 next week :)
[21:54:35] <grrrit-wm>	 (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Flow: Add CSRF protection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/78467 (owner: 10Werdna)
[21:54:49] <werdna>	 thx
[21:55:00] <ebernhardson>	 np
[22:05:50] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "This doesn't actually work because Preferences.php sucks." [core] - 10https://gerrit.wikimedia.org/r/78463 (owner: 10Matmarex)
[22:06:27] <grrrit-wm>	 (03CR) 10Frédéric Wang: "One additional note: MathJax splits its modules in several small javascript files and tries to only load them when needed. I suspect what " [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang)
[22:09:38] <grrrit-wm>	 (03PS2) 10BryanDavis: Add apache::config puppet class. [vagrant] - 10https://gerrit.wikimedia.org/r/78401 
[22:12:29] <grrrit-wm>	 (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/78401 (owner: 10BryanDavis)
[22:18:41] <grrrit-wm>	 (03PS4) 10BryanDavis: Add Puppet role for thumb.php 404 handler. [vagrant] - 10https://gerrit.wikimedia.org/r/78409 
[22:21:54] <grrrit-wm>	 (03CR) 10BryanDavis: "Purge problem fixed in upstream patch gerrit:78401. Rebased this patch on that latest version." [vagrant] - 10https://gerrit.wikimedia.org/r/78409 (owner: 10BryanDavis)
[22:22:00] <werdna>	 ebernhardson: do we have a touched timestamp for whole topics?
[22:22:33] <ebernhardson>	 werdna: not touched, no.  I wasn't sure the right way about doing that.
[22:22:39] <werdna>	 mmm
[22:22:43] <werdna>	 well we do need it for the interface
[22:22:50] <werdna>	 "last modified X hours ago"
[22:25:08] <ebernhardson>	 storing as a bit of denormalized data isn't too bad, but not sure we want to update the row in db for every new post revision.  I suppose one more query isn't going to kill anything though
[22:25:57] <grrrit-wm>	 (03PS1) 10Matmarex: HistoryAction: There is no mediawiki.legacy.history module [core] - 10https://gerrit.wikimedia.org/r/78469 
[22:26:15] <MatmaRex>	 ^ trivial
[22:26:32] <werdna>	 ebernhardson: well, other option would be to query it on read
[22:26:37] <werdna>	 and i really don't like the sound of that
[22:26:45] <ebernhardson>	 werdna: thats an ugly query though, and its not the same for all workflows
[22:26:50] <werdna>	 right.
[22:27:27] <ebernhardson>	 to query for posts, would have to join the list of nodes descendant from topic against the flow_post_rev, and get the max revision
[22:30:07] <ebernhardson>	 so, i guess update the workflow :)
[22:30:37] <werdna>	 ebernhardson: nod, though we have to make half that query anyway for display
[22:30:41] <werdna>	 but yeah, let's update the workflow
[22:30:52] <werdna>	 I think looking for the data ourselves would be a world of pain
[22:30:56] <werdna>	 kk, I'll add that field later.
[22:33:32] <grrrit-wm>	 (03PS2) 10Matmarex: Editform: Make editform 100% wide for colgoneblue as well [core] - 10https://gerrit.wikimedia.org/r/78461 (owner: 10TheDJ)
[22:34:08] <grrrit-wm>	 (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78461 (owner: 10TheDJ)
[22:40:40] <Elsie>	 legoktm: Yo.
[22:51:55] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] move AbuseFilter attribution to the only function that came from it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78387 (owner: 10Legoktm)
[22:52:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: move AbuseFilter attribution to the only function that came from it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78387 (owner: 10Legoktm)
[23:23:20] <grrrit-wm>	 (03PS1) 10Miguel2706: New and firts version of this extension [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/78470 
[23:24:42] <grrrit-wm>	 (03CR) 10Miguel2706: [C: 032 V: 032] "The firts version is great!!" [extensions/UpdateMediaWiki] - 10https://gerrit.wikimedia.org/r/78470 (owner: 10Miguel2706)
[23:29:00] <Elsie>	 what
[23:33:31] <p858snake|l_>	 is