[00:01:11] (03CR) 10MZMcBride: "(2 comments)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [00:20:24] (03PS3) 10MZMcBride: Add "Developers" link to footer of Wikimedia wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 [03:06:48] ori-l: around? [03:28:45] (03PS1) 10Brian Wolff: Attempt to have more rigorous clearing of image redirect cache [core] - 10https://gerrit.wikimedia.org/r/77562 [03:46:00] (03PS1) 10Brian Wolff: Make action=purge on file redirects purge the file redirect cache. [core] - 10https://gerrit.wikimedia.org/r/77563 [04:02:45] (03CR) 10Parent5446: [C: 031] Attempt to have more rigorous clearing of image redirect cache [core] - 10https://gerrit.wikimedia.org/r/77562 (owner: 10Brian Wolff) [04:16:55] (03CR) 10Parent5446: [C: 032] Make action=purge on file redirects purge the file redirect cache. [core] - 10https://gerrit.wikimedia.org/r/77563 (owner: 10Brian Wolff) [04:19:31] (03Merged) 10jenkins-bot: Make action=purge on file redirects purge the file redirect cache. [core] - 10https://gerrit.wikimedia.org/r/77563 (owner: 10Brian Wolff) [04:32:23] (03PS2) 10Himeshi: Add handling of other parameters for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/77461 [04:32:42] Krenair: hey [04:35:26] ori-l, I've still got to deal with https://gerrit.wikimedia.org/r/#/c/52922/15/includes/rclivefeed/UDPRCFeedEngine.php [04:35:42] I don't fully understand the 64KB limit [04:36:10] nor if/how it would effect the JSON feed (I seriously doubt it) [04:36:30] well, I doubt it too, but let's see if we can answer that definitively [04:37:57] OK, so we have: type, namespace, title, full_title, comment, timestamp, user, bot [04:38:12] The current human-readable feed manages to get everything on one line always AFAICT [04:38:36] you can have a one-gigabyte line, that's not a good enough indicator [04:38:50] according to http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_(technical_restrictions)#Title_length, "Titles must be less than 256 bytes long when encoded in UTF-8. " [04:39:12] IRC commands ("PRIVMSG #targetchannel :yourmessage\r\n") are limited to 512 characters [04:39:24] that leaves us w/ 65,280 to spare [04:39:51] well, yes, but this patch tries to dodge the limitations of the IRC feed, and tylor could plausibly insist that the length limit is one of them. [04:41:04] we're well on our way to proving that the 64k limit is ample, so just bear with me [04:41:09] ok [04:42:09] (03CR) 10Nischayn22: "(2 comments)" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/77461 (owner: 10Himeshi) [04:42:51] I guess you could theoretically give a namespace an arbitrary long name, though various things would start breaking before you reach 64k [04:43:07] older browsers don't deal very well with URLs that are >2,000 characters, for example [04:44:15] oh, but you're using the numeric namespace ID, even better [04:46:11] according to http://www.mediawiki.org/wiki/Manual:Page_table#page_namespace the maximum value for namespace id is 2147483647 [04:47:11] http://www.mediawiki.org/wiki/Manual:User_table#Schema_summary says user name is 255 bytes [04:49:35] 'bot' is just a boolean [04:49:42] comment field in revision table is TINYBLOB, 2^8 = 2x2x2x2x2x2x2x2 = 256 bytes [04:53:01] timestamp is 4 bytes [04:53:19] hm? [04:53:29] timestamp is an ISO 8601 string [04:53:43] looks like "2010-08-09T00:30:06Z" [04:53:46] oh, right. I'm looking at the database schema, but that of course doesn't say anything [04:54:31] you might want to emit an int timestamp, actually [04:54:52] not because of the length limit (which is a non-issue) but because it's easier to handle [04:55:56] might be a good idea [04:57:26] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [04:57:47] ori-l, I think that leaves 'type' [04:59:52] 'move over redirect' is the longest [04:59:54] per https://gerrit.wikimedia.org/r/#/c/52922/15/includes/RecentChange.php [05:00:03] it's not that simple [05:00:30] if the given type was none of those in the map, it will simply be returned as is [05:00:43] as-is meaning the numeric key, though [05:01:18] tinyint(3) unsigned [05:01:21] per http://www.mediawiki.org/wiki/Manual:Recentchanges_table [05:01:30] so 'move over redirect' is really the longest [05:01:38] oops, yes, my bad [05:01:39] though I think you should return int keys [05:02:02] so ok, finally we need to consider the effect of JSON encoding [05:02:27] what about full_title? [05:03:50] guess your comment about the namespace names apply here [05:05:15] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [05:06:55] yeah, it does. i don't think it's a big deal, since unlike titles namespaces can't be created by just anybody [05:07:29] but i do think it might be nicer to exclude it [05:07:47] because it's essentially another notation that combines fields [05:07:51] "Namespace:Title" [05:08:03] maybe just getText instead of getPrefixedText? [05:08:19] then the client would have to look up the namespace name of the given ID to do anything useful [05:09:17] maybe we should just drop the 'title' and 'ns' keys and rename 'full_title' to 'title' [05:10:37] although actually ns would be useful e.g. on basically any non-english wiki [05:10:50] http://www.mediawiki.org/w/api.php?action=query&prop=info&titles=Main%20Page [05:11:22] .... ? [05:11:54] i was just reflecting that it does not include the namespace name [05:13:20] can't you use the english NS name? i don't know the mechanism that is responsible, but i noticed that, for example http://fr.wikipedia.org/wiki/Discussion:Paris === http://fr.wikipedia.org/wiki/Talk:Paris [05:13:37] i mean, if you just need to construct a URL [05:13:48] ... yes the main namespace has no namespace name :| [05:14:10] yes, but say if you want to only look for events in a certain namespace [05:14:27] you probably don't know the name of the namespace in the content language [05:14:40] I think if you're doing something as sophisticated as filtering for edits in a particular namespace by consuming a JSON feed, you can look up the numeric key [05:16:10] I think we should do it like the API [05:16:30] https://www.mediawiki.org/w/api.php?action=query&prop=info&titles=API:Main%20Page - ns="104" title="API:Main Page [05:16:50] full title, namespace id included [05:18:02] can you override namespace names using the mediawiki NS? [05:19:19] ok, let's leave namespace as the one thing that's unknown and figure out the total size of the other fields combined [05:19:28] and leave the remainder for the namespace, and argue that that's plenty [05:19:34] I don't think so... they're defined under namespaceNames instead of messages in the language files [05:19:39] right [05:20:16] so JSON encoding requires that certain characters be escaped; if I were a jokester I could create a title that consists of 256 '"' (double quote) characters [05:21:17] so that's 512 bytes [05:21:40] (because each '"' would be encoded as '\"' [05:21:41] ) [05:23:52] honestly I think what we have is more than enough [05:24:30] draft comment in PM [05:38:57] (03CR) 10Nemo bis: "(1 comment)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [05:41:41] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [05:41:53] ori-l: okay, replied. thanks for your help [05:44:19] Krenair: np. here's a souvenir: https://dpaste.de/w1Nr8/raw/ :D [05:44:31] :D [05:45:14] oops, it's actually incorrect, it's the __repr__ of the string which has double slashes [05:45:29] there it is: https://dpaste.de/YgO6W/raw/ [05:45:42] probably more than you bargained for when you asked for my help, but hey. [05:47:17] (03PS16) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [05:49:02] oh, we forgot about a bunch of fields [05:49:52] but hopefully he'll realize that even with the urls, etc you're not close to hitting the limit [05:52:53] yeah... [05:53:22] minor, patrolled, old_len, new_len, old_revision, new_revision, url_server, url_script_path, url_article_path [05:55:48] they end up looking something like "minor":0,"patrolled":0,"old_len":380,"new_len":383,"old_revision":1858,"new_revision":1859,"url_server":"http://localhost","url_script_path":"/MediaWiki/Git/core/index.php","url_article_path":"/MediaWiki/Git/core/index.php/$1" [05:56:36] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [05:58:17] (03CR) 10Alex Monk: [C: 04-1] "missed Ori's comment from previous patch set" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [06:23:06] (03CR) 10Ori.livneh: [C: 04-1] "(7 comments)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [08:38:21] (03CR) 10Nikerabbit: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [08:45:17] (03PS1) 10Mwjames: \SMW\ObservableDispatcher dispatches state changes from a source to an Observer [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77565 [08:58:47] (03CR) 10Nikerabbit: [C: 032] Fix CodeSniffer errors and warnings [extensions/cldr] - 10https://gerrit.wikimedia.org/r/77319 (owner: 10Siebrand) [08:58:52] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings [extensions/cldr] - 10https://gerrit.wikimedia.org/r/77319 (owner: 10Siebrand) [09:05:56] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/45506 (owner: 10Liangent) [09:16:30] (03PS43) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [09:18:57] (03CR) 10Wikinaut: [C: 04-2] "not yet ready for merging." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [09:36:58] (03CR) 10Wikinaut: "PS 38 commit breaks the OpenID converter page, which works in PS 37. I will fix that together with other issues." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [10:35:14] (03CR) 10Helder.wiki: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77266 (owner: 10Krinkle) [11:49:04] (03PS6) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [11:49:05] (03PS6) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [11:49:06] (03PS14) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [11:49:07] (03PS22) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [11:59:00] (03PS2) 10Mwjames: \SMW\ObservableDispatcher dispatches state changes from a source to an Observer [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77565 [12:12:40] (03PS3) 10Mwjames: \SMW\ObservableDispatcher dispatches state changes from a source to an Observer [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77565 [12:17:02] (03PS7) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [12:17:03] (03PS7) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [12:17:04] (03PS15) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:17:05] (03PS23) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [12:21:19] (03CR) 10Mwjames: [C: 032] "In order to continued to work on other things that need this a base requirement, I going to merge this where finally being able to use the" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77565 (owner: 10Mwjames) [12:22:43] (03Merged) 10jenkins-bot: \SMW\ObservableDispatcher dispatches state changes from a source to an Observer [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77565 (owner: 10Mwjames) [12:26:50] (03CR) 10Esanders: [C: 032] Clean up: Remove wrong or redundant CSS prefixes [core] - 10https://gerrit.wikimedia.org/r/77482 (owner: 10Krinkle) [12:29:25] YuviPanda: so what to do for grrrit-wm ? [12:30:04] (03Merged) 10jenkins-bot: Clean up: Remove wrong or redundant CSS prefixes [core] - 10https://gerrit.wikimedia.org/r/77482 (owner: 10Krinkle) [12:30:14] Nemo_bis: hmm? [12:30:16] for -feed? [12:30:19] would you kill me if I tried a config patch using negative lookahead regex to define the channels writing here by exclusion? [12:30:22] yes [12:31:00] no, I don't think you *can* have a pure config based solution, no [12:31:23] because of the fact that this is the 'fallback', and any attempt to define exactly what comes into -dev would probably not be complete, and also prone to breakage [12:31:56] a simple 'feed' option that just firehoses things elsewhere isn't also going to work, and I'm not sure how exactly to fix this [12:32:47] why would it break, you'd only have to list the "special" repos twice [12:32:57] assuming regex format is supported [12:33:41] see, anything not matching any other channel comes here. [12:33:52] I know... [12:33:57] so you'll have to manually figure out 'list of extensions that are not going elsewhere' and put that under -dev [12:34:04] and then update that everytime a new extension is added [12:34:08] or a new repo is added [12:34:11] it's just what's below [12:34:21] how so [12:34:43] you'll have to update the negative exclusions everytime the list below is updated [12:34:45] no? [12:34:47] if it matches the regex for the specific channel it will match the one for the generic channel too [12:34:47] (03PS1) 10Matmarex: ext.echo.special: Move #firstHeading styling from JS to CSS [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77569 [12:34:48] (03PS1) 10Matmarex: Do not offset the heading of Special:Notifications from the left [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77570 [12:35:02] (negated) [12:35:24] okay, at this point I'm thoroughly confused [12:35:33] I'd still want to implement this in *code* than complicate the config [12:36:06] what's complicate is this concept of considering #wikimedia-dev just a last resort :P [12:36:23] (03PS8) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [12:36:24] (03PS8) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [12:36:25] (03PS16) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:36:26] (03PS24) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [12:36:55] Nemo_bis: :P Put everything here until someone wants to have that moved out is rather simple, no? :) [12:37:06] by default you get notifications here, tweak config to have them go elsewhere [12:37:25] no, it's not simple to me [12:37:54] I don't understand why one person wanting messages in one place should require other persons not having them in another place [12:38:26] it was the simplest thing I could do for the one day hack. Patches welcome :P [12:38:51] but you said you can't change that [12:39:01] not purely with the config! [12:39:05] this has to be fixed in the code [12:39:51] so we could also just send everything mediawiki into here? [12:40:23] to be clear, what you want is: 1. -dev to be as is, 2. -feed to get everything under mediawiki.* [12:40:52] not really, 2. is just a workaround for 1. [12:41:09] the ideal situation is not removing messages from here [12:41:09] that's a fight you'll have to have with the people who decided to have things split, which is not me. [12:41:25] this is gerrit-wm's functionality that I'm simply mimicking. [12:41:29] you just said the contray above, ok, so I understood [12:41:36] err? [12:41:48] what I would welcome patches for is to have a -feed where you get mediawiki.* [12:41:55] which is currently not possible without killing -dev [12:41:56] 14.38 < Nemo_bis> but you said you can't change that [12:41:56] 14.39 < YuviPanda> not purely with the config! [12:41:56] 14.39 < YuviPanda> this has to be fixed in the code [12:42:23] ah, right. confusion over what you meant by 'that', sorry [12:42:26] are there any stats for this claim? [12:42:38] I doubt the traffic i [12:42:39] define 'this'? [12:42:49] 14.38 < Nemo_bis> but you said you can't change that [12:42:49] 14.39 < YuviPanda> not purely with the config! [12:42:53] ouch [12:42:55] 14.41 < YuviPanda> which is currently not possible without killing -dev [12:43:10] to expand, 'without killing the current behavior of grrrit-wm in -dev' [12:43:19] ah [12:43:34] I doubt this channel would suffer [12:43:52] That's not your decision to make. [12:44:05] (03PS9) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [12:44:06] (03PS9) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [12:44:07] (03PS17) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:44:08] (03PS25) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [12:44:09] that's not something I want to decide :P IRC bot flames are things I don't want to touch with a 100m pole [12:44:17] You can't hijack the bot simply because you're unwilling to code a better solution. [12:44:30] Elsie: where was this decided? [12:44:35] To put the bot in here? [12:44:36] I understand the need for -feed, and might code it up later on when I have free time [12:44:54] YuviPanda: sure, I don't want you to, just was confused because you first said it was a decision you can0t change and then said something I interpreted as the opposite [12:45:08] Elsie: no, to exclude some MediaWiki repos from here [12:45:24] Nemo_bis: right, I think I just mixed up discussion of IRC bot 'policy' vs implementation. [12:45:30] I can't change policy :) [12:45:35] (for some definition of 'policy') [12:45:37] It's a design implementation of the bot. [12:46:01] I think wikitech-l is a far far better avenue for that flame than talking to me. [12:46:03] which seems to be quite the opposite of "decision" or "policy" for whatever definition of policy [12:46:18] * Elsie shrugs. [12:46:29] You seem to be looking for a fight and I'm not sure why. [12:46:38] It's too early and too Sunday for that. [12:46:58] dunno why you think so [12:47:04] If you want -feed to have all changes, file a bug. [12:47:14] It's obviously not possible with the current implementation. [12:47:31] not so obvious [12:48:00] It's not possible with the current implementation - we tried it the other day and it didn't work :) [12:48:01] It's pretty obvious if you watched how the bot works. [12:48:02] Elsie: I was not looking for a fight, you said there was a decision and I just asked if it is documented or written somewhere as I've never heard of it [12:48:28] I thought you were discussing the decision to use this channel and move the bot here. [12:48:35] ok [12:48:37] From #mediawiki. [12:48:45] In any case, the bot works pretty simply. [12:48:55] omg please don't repeat again [12:48:59] Wikidata repo changes go to the Wikidata channel. [12:49:08] They don't go here. [12:49:23] &c. [12:49:53] So if you regex all changes to one particular channel, it siphons the changes from every other channel, as I understand it. [12:50:02] wrong [12:50:09] only from the default channel [12:50:17] Elsie> It's pretty obvious if you watched how the bot works. [12:50:40] Elsie: #wikimedia-dev is 'default' channel. If a repo isn't listed anywhere else, it comes here [12:50:53] Got it. [12:51:31] > So if you regex all changes to one particular channel, it siphons the changes from every other channel, as I understand it. [12:51:34] I'm not sure how that's wrong. [12:51:40] That's basically exactly what happened, isn't it? [12:51:51] You told all the changes to go to -feed. [12:53:30] Only this channel lost messages [12:53:33] yeah [12:53:36] to take an example [12:53:38] mediawiki/core [12:53:43] is not mentioned in config.yaml [12:53:49] so it doesn't match any definition [12:53:55] and 'falls back' to the default channel, that is here [12:54:00] when mediawiki.* was added [12:54:02] it matched that [12:54:04] and went to -feed [12:54:18] So you siphoned off the messages from -dev, not every other channel. [12:54:19] Okay. [12:54:23] and didn't come here, since this is the default/fallback channel, and mediawiki/core already matched somewhere else [12:54:23] yeah [12:54:48] it surprised me a bit too. I'll have to re-think the implementation a little, but I guess not right now [12:55:00] So rather than getting a proper feed of all changes, you managed to simply break th feed in -dev and still have not all messages going to -feed. :-) [12:55:04] the feed * [12:55:24] all messages still went to feed :P one message can go to multiple channels [12:55:29] only -dev was broken [12:55:30] Can it? [12:55:34] yeah, it can [12:55:45] I thought that was the whole bug. [12:55:56] when a message comes in, the bot runs through all channel definitions to compile a list of channels that match the repo, and then sends it to them all [12:56:03] Elsie: the bug is the special 'fallback' behavior for -dev [12:56:29] Interesting. [12:56:37] Nemo_bis: Not so obvious after all. :-) [12:56:37] (03CR) 10Zaran: "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [12:56:44] (03PS1) 10Matmarex: ext.echo.special: Cross-skin adjustments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77571 [12:56:50] indeed, it could be considered a subtle bug [12:56:56] in grrrit-wm that needs fixing in the code [12:58:02] and patches welcome for that :) [12:58:27] I'm currently trying to make SuchABot a lot more reliable, so don't want to spend time on grrrit-wm [12:58:59] (03CR) 10Zaran: [C: 04-1] "(2 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [13:24:10] (03PS4) 10MZMcBride: Add "Developers" link to footer of Wikimedia wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 [13:25:33] (03CR) 10MZMcBride: "(7 comments)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [13:31:09] Developers [13:31:09] Developers [13:31:09] Developers [13:31:10] Developers [13:31:10] Developers [13:31:12] Developers [13:31:14] Developers [13:33:13] MOAR [13:37:06] Reedy: fuck it, do it live? [13:41:14] Eh? [13:42:05] DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS [14:58:58] (03CR) 10UnwashedMeme: "> PS 38 commit breaks the OpenID converter page, which works in PS 37" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [15:05:41] (03PS10) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [15:05:42] (03PS10) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [15:05:43] (03PS18) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [15:05:44] (03PS26) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [15:25:50] (03CR) 10Wikinaut: "UnwashedMeme wrote:" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [16:42:27] YuviPanda|Travel, https://github.com/organizations/wikimedia/dashboard/pulls [17:27:31] (03PS1) 10Nemo bis: Add colon to notification-edit-talk-page-email-batch-body2 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77574 [17:35:19] (03PS1) 10Nemo bis: Make mwe-upwiz-license-external-invalid more grammar friendly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 [17:42:44] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [17:43:00] Sorry Nemo_bis [17:50:41] (03CR) 10Nemo bis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [17:53:56] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [17:54:08] (03PS2) 10Nemo bis: Make mwe-upwiz-license-external* more grammar friendly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 [17:55:02] (03PS12) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [17:58:10] (03CR) 10Nemo bis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [17:59:39] (03PS3) 10Nemo bis: Make mwe-upwiz-license-external* more grammar friendly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 [18:00:26] (03CR) 10Nemo bis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:11:57] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:13:55] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:18:13] (03PS1) 10Rjain: (bug 52260) Allow logged out users to view [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/77576 [18:18:47] (03CR) 10Nemo bis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:22:33] (03PS4) 10Nemo bis: Make mwe-upwiz-license-external* more grammar friendly and clearer [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 [18:22:34] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:24:11] (03CR) 10Nemo bis: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77575 (owner: 10Nemo bis) [18:24:30] and that was supposed to be a quick one [18:24:54] Sorry! [18:32:30] (03PS2) 10Parent5446: (bug 52260) Allow logged out users to view [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/77576 (owner: 10Rjain) [18:38:05] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/77576 (owner: 10Rjain) [18:40:53] (03CR) 10Rjain: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/77576 (owner: 10Rjain) [18:41:55] (03CR) 10Ori.livneh: "(1 comment)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [18:57:20] (03CR) 10Wikinaut: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [19:05:15] (03PS44) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [19:10:10] (03CR) 10Wikinaut: [C: 04-1] "1. I introduced a new function SpecialOpenIDConvert::renderProviderIcons which is used by both the login and convert screen." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [20:11:46] ori-l: if you haven't seen already, http://www.python.org/dev/peps/pep-0445/ lets python eventually be used where lua is used a lot now :) [20:11:48] lands in 3.4 [21:56:23] sunday evening [21:56:40] perfect time for some grrrit-wm maintenance, I say! :D [22:08:27] all done! [22:08:30] apologies for the botspam :)