[00:00:45] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68948 (owner: 10Bakert) [00:01:11] (03CR) 10MarkTraceur: "Are you going to try to properly rebase it or should this be abandoned?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/54127 (owner: 10Nischayn22) [00:04:20] greg-g: what do you think about a "pending deployment" state in bugzilla? [00:04:41] (03CR) 10MarkTraceur: [C: 032] "Sure sure" [core] - 10https://gerrit.wikimedia.org/r/73986 (owner: 10Cscott) [00:07:12] (03Merged) 10jenkins-bot: Code style cleanups to parserTest.inc and NewParserTest.php. [core] - 10https://gerrit.wikimedia.org/r/73986 (owner: 10Cscott) [00:08:34] mwalker: I'd rather we simply deploy more often. [00:08:36] :-) [00:08:47] * Reedy beats Elsie [00:08:52] Where are we now? [00:08:54] Now the other cheek. [00:08:56] Where were we a year ago? [00:09:04] BETTERERER [00:09:09] Yes. [00:09:10] I agree. [00:09:15] even if we did that we would still have the issue of patches sitting in limbo between the "Fixed" and "Patch to review" states [00:09:30] Is that an issue? Do you have an example? [00:09:47] sure; I just fixed an issue in CentralNotice [00:09:54] that has been reviewed and merged [00:10:03] but won't be deployed till sometime two weeks from now [00:10:49] I'm not sure an additional bug status would help that problem. [00:11:52] it would at lesat help me search for things better :) [00:21:18] (03PS2) 10Spage: Permit specifying a name for default actions [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 [00:28:19] (03CR) 10Spage: "(4 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 (owner: 10Spage) [00:29:06] ori-l: __KEIN_INHALTSVERZEICHNIS__ [00:31:39] (03CR) 10Krinkle: "OK. Let's add some tests and merge it." [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [00:34:08] Elsie: Is that the actual magic word in German? [00:34:36] RoanKattouw: BITTE is the magic word in german (or so my mother would say) [00:35:45] haha [00:45:35] (03CR) 10MarkTraceur: "This seems like a good plan, but I'm not totally convinced about the version change." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [00:45:43] (03PS1) 10Cscott: Fix *another* bug in the parsoid-regressions job... then turn it off. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77471 [00:47:53] Damn it. [00:48:05] I can't comment on https://gerrit.wikimedia.org/r/74603 despite me being a reviewer [00:48:09] And I just want to say [00:48:13] It should be merged now [00:48:19] * marktraceur sets about emailing ^demon [00:58:22] Whoa, TIL that $.css( { 'margin-left': '10px' } ) and $.css( { marginLeft: '10px' } ) both work [00:58:26] My life is so much better now [01:00:41] (03PS25) 10Rasel160: Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 [01:00:42] (03CR) 10jenkins-bot: [V: 04-1] Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 (owner: 10Rasel160) [01:00:56] Coolio [01:03:27] (03PS1) 10Mattflaschen: Set $wgLegacyJavaScriptGlobals false. [vagrant] - 10https://gerrit.wikimedia.org/r/77474 [01:04:25] (03CR) 10Rasel160: "sorry, pushed my changes after a hard drive crash scare. meant to be more of a backup" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 (owner: 10Rasel160) [01:07:19] (03PS3) 10Mattflaschen: Add getId to mw.user, returning wgUserId (or 0 for anons). [core] - 10https://gerrit.wikimedia.org/r/75836 [01:09:18] (03CR) 10MarkTraceur: [C: 031] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75122 (owner: 10Rillke) [01:13:46] (03CR) 10MarkTraceur: "I changed the login form to use this in the parent commit, as an example - let me know if you still have concerns about it please" [core] - 10https://gerrit.wikimedia.org/r/76471 (owner: 10Spage) [01:23:29] RoanKattouw_away: https://de.wikipedia.org/w/index.php?title=Wikipedia:Kurier&action=info#mw-pageinfo-magic-words [01:25:45] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [01:27:22] (03CR) 10Dan-nl: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 (owner: 10Rasel160) [01:28:01] (03PS4) 10Mattflaschen: Add getId to mw.user, returning wgUserId (or 0 for anons). [core] - 10https://gerrit.wikimedia.org/r/75836 [01:28:42] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [01:35:20] (03CR) 10Rillke: "Here is a copy from what I wrote in Bug 43821 (Why did I wrote that at all):" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [01:38:45] (03CR) 10Rillke: "BTW, you can believe me, that you will not manage to upload a file to Commons with FormData in FF 19." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [01:48:00] superm401: I think the assertion can speak for itself. No need to repeat what it should return. [01:48:13] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [01:48:27] though other assertions do to that, so I suppose its fine, but do get the value right :) [01:49:22] Krinkle, I will. :) [01:50:00] I'll make it more consistent with the other verbiage too. [01:50:48] (03PS5) 10Mattflaschen: Add getId to mw.user, returning wgUserId (or 0 for anons). [core] - 10https://gerrit.wikimedia.org/r/75836 [01:52:16] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [01:55:21] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75122 (owner: 10Rillke) [01:57:10] superm401: if you like, might want to do the same to the other assertion (e.g. logged in > logged-in, and 'when'). Not that I have preference for that phrasing, but if you want it to match :) [01:58:32] (03PS6) 10Mattflaschen: Add getId to mw.user, returning wgUserId (or 0 for anons). [core] - 10https://gerrit.wikimedia.org/r/75836 [01:58:38] Krinkle, done. ^ [01:59:52] (03CR) 10Krinkle: [C: 032] "Thx" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [02:02:59] (03Merged) 10jenkins-bot: Add getId to mw.user, returning wgUserId (or 0 for anons). [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 10Mattflaschen) [02:18:44] (03CR) 10Rillke: "To make things clear:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [02:21:35] mwalker|away: I want something like that, but the confusing part is "deployed where?" [02:21:55] mwalker|away: but yeah, my pie in the sky dream is a unified dashboard for that kind of information [02:22:16] greg-g: soon! [02:22:26] oh? [02:22:29] :) [02:23:07] * ori-l schemes [02:25:53] yay [02:25:59] * greg-g loves scheming [02:26:06] * greg-g also loves Scheme [02:28:53] (03PS26) 10Rasel160: Will allow dynamic form generation in the details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 [02:46:06] (03PS1) 10Krinkle: Clean up: Remove wrong or redundant CSS prefixes [core] - 10https://gerrit.wikimedia.org/r/77482 [02:46:16] (03PS4) 10MZMcBride: Always quote attribute values ending in a backslash [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:47:29] (03CR) 10Krinkle: "I'm currently skipping mediawiki.ui because it uses Compass" [core] - 10https://gerrit.wikimedia.org/r/77482 (owner: 10Krinkle) [02:47:30] (03CR) 10MZMcBride: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/67603 (owner: 10Daniel Friesen) [02:47:39] Krinkle: ^ :-) [02:47:53] I have Compass installed, read the rest of the comment [02:47:57] :) [02:48:29] Krinkle: I was pointing at https://gerrit.wikimedia.org/r/67603 [02:48:43] You'd added a -1 a few months ago and Daniel F. seems to have gone missing. [02:48:51] I amended the change appropriately, I hope. [02:50:56] You and lobbying for a legislation amendment amending a law proposal gerrit change appropriately? [02:51:19] Looks good to me [02:51:43] Oh, it's past 1 UTC. [02:51:50] I wonder if reviewer counts for Gerrit are now available. [02:51:53] Let's see! [02:52:54] #nope [02:52:58] :-( [03:15:34] (03CR) 10Daniel Friesen: "Your summary is a bit messed up:" [core] - 10https://gerrit.wikimedia.org/r/77482 (owner: 10Krinkle) [03:19:49] (03PS2) 10Krinkle: Clean up: Remove wrong or redundant CSS prefixes [core] - 10https://gerrit.wikimedia.org/r/77482 [03:21:09] http://cl.ly/image/3z2E1m182W0R [03:34:56] (03PS1) 10CSteipp: DO NOT MERGE - OAuth Sessions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77485 [03:38:46] (03PS1) 10Mattflaschen: Filter out elements that are not :visible when attaching. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 [03:56:01] (03PS2) 10Mattflaschen: Filter out elements that are not :visible when attaching. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 [03:56:52] (03CR) 10Mattflaschen: "Patch set 2 does it in the remaining places." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77486 (owner: 10Mattflaschen) [04:28:48] (03CR) 10Bsitu: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76538 (owner: 10Kaldari) [04:34:02] (03CR) 10Bsitu: [C: 032] Percentage can be displayed at 0%, just not when there is no feedback at all [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/39032 (owner: 10Matthias Mullie) [04:34:04] (03CR) 10jenkins-bot: [V: 04-1] Percentage can be displayed at 0%, just not when there is no feedback at all [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/39032 (owner: 10Matthias Mullie) [04:39:38] (03CR) 10MZMcBride: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76538 (owner: 10Kaldari) [05:15:08] (03PS1) 10Mattflaschen: Fix detection of VE to use isAvailable [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77488 [05:18:24] (03CR) 10Parent5446: [C: 032] Make wfForeignMemcKey consistent with wfMemcKey [core] - 10https://gerrit.wikimedia.org/r/71740 (owner: 10EBernhardson (WMF)) [05:20:20] (03Merged) 10jenkins-bot: Make wfForeignMemcKey consistent with wfMemcKey [core] - 10https://gerrit.wikimedia.org/r/71740 (owner: 10EBernhardson (WMF)) [05:33:18] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [06:12:15] (03PS1) 10Ori.livneh: Pedantic tweak to README [core] - 10https://gerrit.wikimedia.org/r/77489 [06:12:49] * Elsie NP: "Hallelujah" by Jeff Buckley from "Grace" [06:13:25] ori-l: I think that looks silly in the file itself. [06:13:32] The GitHub renderer is wrong. [06:13:41] (03PS2) 10Ori.livneh: Pedantic tweak to README [core] - 10https://gerrit.wikimedia.org/r/77489 [06:14:10] ugh. [06:14:20] yeah, a little. [06:14:28] i can't decide if it's worth it or not. [06:15:10] * Elsie shrugs. [06:15:14] anyways, you should e-mail wikitech-l about it [06:15:16] it's a nice change [06:15:28] I should mark the bug as resolved too. [06:15:44] But I was going to try to do something productive instead. I just keeping side-tracked. [06:20:07] Elsie, to be fair we can't really blame people for not parsing wikitext correctly [06:20:36] !blame [06:20:36] Whatever happened, it's Domas' fault. For everything else, there's `git blame`. [07:03:58] (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [07:19:04] (03CR) 10MZMcBride: "Meh." [core] - 10https://gerrit.wikimedia.org/r/77489 (owner: 10Ori.livneh) [07:42:03] (03CR) 10Mattflaschen: [C: 032] "I think the root error is on GitHub's side. They have weird things like text not in any element except article (e.g. " For system require" [core] - 10https://gerrit.wikimedia.org/r/77489 (owner: 10Ori.livneh) [07:44:34] (03Merged) 10jenkins-bot: Pedantic tweak to README [core] - 10https://gerrit.wikimedia.org/r/77489 (owner: 10Ori.livneh) [07:49:35] superm401: didn't fix the problem. [07:49:53] (03CR) 10MZMcBride: "This should be reverted. It didn't fix the issue: ." [core] - 10https://gerrit.wikimedia.org/r/77489 (owner: 10Ori.livneh) [07:50:38] ori-l, maybe it needs ?action=purge. [07:50:39] ;) [07:50:49] I'm reverting [07:50:50] Perhaps we should add an HTML comment criticizing GitHub's parser. [07:51:28] (03PS1) 10Ori.livneh: Revert "Pedantic tweak to README" [core] - 10https://gerrit.wikimedia.org/r/77490 [07:51:46] Elsie: no [07:51:50] superm401: merge? [07:52:47] ori-l, I'd prefer to fix it, rather than thrash. [07:52:50] ori-l: As I understand it, GitHub is very remiss in fixing its parsing issues. [07:52:55] Depends how much time you're willing to spend on it. [07:53:13] OK, no rush. [07:53:35] I think that file can live with an extra empty line for a little while if you're actively experimenting. [07:53:42] E3! [07:53:55] ori-l, no, *I'm* not. :) [07:54:55] But there's no real point to reverting either, except maybe as a lesson 'pour les autres'. [07:55:12] If nothing's changed, I'll merge it tomorrow or sometime. [07:55:30] OK, fair. [07:57:49] How can they be HTML5-savvy enough to use article, but not put paragraphs in, well... paragraphs? [07:57:58] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75556 (owner: 10IAlex) [08:01:22] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75556 (owner: 10IAlex) [08:08:51] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add extension description message [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/77277 (owner: 10Raimond Spekking) [08:27:50] (03PS1) 10Rillke: Messages with links in it must be parsed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77491 [09:08:02] (03CR) 10Mattflaschen: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/75556 (owner: 10IAlex) [09:27:20] (03CR) 10Mattflaschen: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/75556 (owner: 10IAlex) [09:40:15] (03PS12) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [09:57:19] (03PS10) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [09:58:16] (03CR) 10Rjain: "Just a rebase with the latest update patch." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [10:12:25] plop [10:12:46] @notify reedy [10:12:46] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [10:12:55] MatmaRex: lol [10:13:02] hi Reedy [10:37:00] (03PS1) 10Mwjames: \SMW\Test\MockObjectBuilder Clean-up and extend [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77492 [10:39:18] (03PS2) 10Mwjames: \SMW\Test\MockObjectBuilder Clean-up and extend [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77492 [10:39:34] (03CR) 10Mwjames: [C: 032] \SMW\Test\MockObjectBuilder clean-up and extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77492 (owner: 10Mwjames) [10:41:53] (03Merged) 10jenkins-bot: \SMW\Test\MockObjectBuilder clean-up and extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77492 (owner: 10Mwjames) [11:03:41] (03PS4) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [11:03:42] (03PS4) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [11:03:43] (03PS12) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [11:03:44] (03PS20) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [11:04:02] (03PS1) 10Mwjames: \SMW\Maintenance\RebuildConceptCache (rebuildConceptCache.php to replace SMW_conceptCache.php) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77493 [11:04:22] (03CR) 10jenkins-bot: [V: 04-1] \SMW\Maintenance\RebuildConceptCache (rebuildConceptCache.php to replace SMW_conceptCache.php) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77493 (owner: 10Mwjames) [11:08:34] (03PS2) 10Mwjames: \SMW\Maintenance\RebuildConceptCache (rebuildConceptCache.php to replace SMW_conceptCache.php) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77493 [11:16:02] (03PS1) 10Mwjames: \SMW\Test\MockObjectBuilder, closeConnection is abstract in 1.21/1.22 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77494 [11:17:34] (03CR) 10Mwjames: [C: 032] \SMW\Test\MockObjectBuilder, closeConnection is abstract in 1.21/1.22 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77494 (owner: 10Mwjames) [11:18:54] (03Merged) 10jenkins-bot: \SMW\Test\MockObjectBuilder, closeConnection is abstract in 1.21/1.22 [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77494 (owner: 10Mwjames) [11:19:06] (03PS3) 10Mwjames: \SMW\Maintenance\RebuildConceptCache (rebuildConceptCache.php to replace SMW_conceptCache.php) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77493 [11:33:10] (03PS41) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [11:34:57] (03CR) 10Wikinaut: [C: 031] "code cosmetics" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [11:49:27] (03CR) 10TTO: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/75643 (owner: 10Krinkle) [12:05:02] (03PS42) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [12:10:33] (03CR) 10Wikinaut: [C: 04-1] "code cosmetics; adding new lines in generated HTML code." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [12:15:06] (03PS6) 10Mwjames: Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [12:17:20] (03CR) 10Mwjames: [C: 032] Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 (owner: 10Mwjames) [12:18:40] (03Merged) 10jenkins-bot: Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 (owner: 10Mwjames) [12:40:14] (03PS1) 10Mwjames: Rename TitleProvider [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77498 [12:41:24] (03CR) 10Mwjames: [C: 032] Rename TitleProvider [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77498 (owner: 10Mwjames) [12:42:45] (03Merged) 10jenkins-bot: Rename TitleProvider [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77498 (owner: 10Mwjames) [13:21:18] (03PS1) 10Mwjames: Rename PropertySubjectsUpdateDispatcherJob [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77500 [13:26:31] (03CR) 10Mwjames: [C: 032] "Thanks to the Observer pattern no changes are required to any other object." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77500 (owner: 10Mwjames) [13:27:51] (03Merged) 10jenkins-bot: Rename PropertySubjectsUpdateDispatcherJob [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77500 (owner: 10Mwjames) [13:43:47] (03PS1) 10Mwjames: Add test to ChangeObserverTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77501 [13:45:31] (03CR) 10Mwjames: [C: 032] Add test to ChangeObserverTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77501 (owner: 10Mwjames) [13:46:52] (03Merged) 10jenkins-bot: Add test to ChangeObserverTest [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77501 (owner: 10Mwjames) [14:05:53] (03PS1) 10Mwjames: \SMW\Test\MockObjectBuilder extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77503 [14:07:45] (03CR) 10Mwjames: [C: 032] \SMW\Test\MockObjectBuilder extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77503 (owner: 10Mwjames) [14:09:05] (03Merged) 10jenkins-bot: \SMW\Test\MockObjectBuilder extension [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77503 (owner: 10Mwjames) [14:12:57] (03PS1) 10Mwjames: \SMW\ContentParser use ContentHandler where available [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77504 [15:01:47] hah, l10n-bot is surpassing MatmaRex :P https://toolserver.org/~nemobis/crstats/core.txt [15:44:59] (03CR) 10Nikerabbit: [C: 031] "I support this, though I wonder if it will surprise people unaware of the change." [vagrant] - 10https://gerrit.wikimedia.org/r/77474 (owner: 10Mattflaschen) [15:55:36] (03PS1) 10Nemo bis: Customise linktrail for Gujarati (gu) [core] - 10https://gerrit.wikimedia.org/r/77509 [17:35:41] (03CR) 10Ori.livneh: [C: 032] "We'll be turning this on in prod eventually, no? Better to be surprised by your dev environment than be surprised by prod." [vagrant] - 10https://gerrit.wikimedia.org/r/77474 (owner: 10Mattflaschen) [17:35:42] (03Merged) 10jenkins-bot: Set $wgLegacyJavaScriptGlobals false. [vagrant] - 10https://gerrit.wikimedia.org/r/77474 (owner: 10Mattflaschen) [17:50:59] (03CR) 10Tpt: [C: 04-1] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [17:52:02] (03CR) 10Helder.wiki: "For the record, that is bug 33837." [vagrant] - 10https://gerrit.wikimedia.org/r/77474 (owner: 10Mattflaschen) [18:33:05] (03CR) 10MZMcBride: "Ori: s/on/off/" [vagrant] - 10https://gerrit.wikimedia.org/r/77474 (owner: 10Mattflaschen) [18:53:03] (03CR) 10Mattflaschen: [C: 04-1] "Sorry, just noticed that annotation_not_recieved is misspelled in the new Update and in Create. It should be annotation_not_received ." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [19:03:09] (03PS13) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [19:12:01] (03PS14) 10Mattflaschen: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [19:12:03] (03PS15) 10Mattflaschen: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [19:43:46] Ryan_Lane or Ryan_Lane1: where's that insecure.wikimedia.org suggestion on bugzilla? [19:43:55] lemme find it [19:44:46] liangent: https://bugzilla.wikimedia.org/show_bug.cgi?id=47832 [19:47:08] Ryan_Lane: thanks [19:47:14] yw [19:57:02] Ryan_Lane btw wmf should have acted earlier to make https default [19:57:21] you're assuming we didn't have plans for this [19:57:44] ops had it on their (to be published) roadmap for this year [19:57:45] so they should be blaming who placed a block on https, rather than wmf [19:57:55] Ryan_Lane: ^ [19:57:59] ahh, I see what you mean [19:58:09] you know very well we'd still get blamed ;) [19:59:15] I should honestly just stop replying to comments on the blog post [20:00:20] Ryan_Lane: I don't know it "very well".. [20:00:30] we'd still get blamed for what? [20:00:36] we're called evil by someone for basically everything we do [20:05:14] Ryan_Lane: "Is it possible to only hard-enable HTTPS in countries that does not block it?" << I guess this idea looks like something to tell all governments: we can make it easier for you to monitor traffics if you want [20:07:37] heh [20:07:40] Ryan_Lane, ooo, is there a progression of "regularly called evil", similar to http://xkcd.com/435/ ? readers->editors->developers->managers->PHBs->? [20:08:16] quiddity_: for foundation employees? yeah, for sure :) [20:08:25] though I think readers is likely end of the list [20:08:48] everyone loves the readers, right? :) [20:09:10] ohhh [20:09:17] sorry, read the direction of that wrong [20:09:27] the further to the right is more likely to be called evil? [20:10:10] cyclical, yah, it should loop. PHBs (and everyone) call the readers evil ;) [20:10:55] hahaha [20:13:15] There've been some nice remixes of the xkcd strip http://imageshack.us/a/img600/636/economists.png http://i119.photobucket.com/albums/o136/yunage/yourmom2.gif http://forums.xkcd.com/download/file.php?id=5012 [20:13:25] There's a circular one somewhere, but i can't find it [20:15:37] that last one you linked is circular [20:16:38] one actually redrawn onto a circle. (still looking) [20:23:28] (03CR) 10Mattflaschen: [C: 031] "Looks good to merge; retested just to confirm" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [20:25:13] (03CR) 10Parent5446: [C: 032] "Yep, looks good to me as well." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [20:25:16] (03Merged) 10jenkins-bot: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [20:25:37] aha https://sansscience.files.wordpress.com/2011/07/xkcd-purity2-by-sansscience-creativecommons-attribution.jpg and https://lh3.ggpht.com/-JgdDxxMGU7Q/TfP3fQjr1_I/AAAAAAAAAqA/dUOf1gLQqws/s320/professions-comic.png and http://i129.photobucket.com/albums/p204/lordike2/xkcd435Response.png also https://farm1.static.flickr.com/82/430561725_4eb7bc5d8a_o.jpg [20:28:06] (03PS11) 10Parent5446: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [20:29:11] (03CR) 10Parent5446: [C: 031] "Haven't tested." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [20:53:08] (03PS1) 10Mattflaschen: Commenting and doc fixes around the spam regexes [core] - 10https://gerrit.wikimedia.org/r/77552 [20:55:31] (03CR) 10Mattflaschen: "Follow-up at https://gerrit.wikimedia.org/r/#/c/77552/" [core] - 10https://gerrit.wikimedia.org/r/75556 (owner: 10IAlex) [21:02:00] +++ Don't forget to switch the Wikipedia Mobile App to https:// +++ [21:02:32] Wikinaut: What are you talking about? [21:02:35] Wikinaut: it's been https for a long time now [21:02:41] except on iOS 4.3 [21:03:02] mobile https also redirects to https for login for a while now [21:03:02] yuvipanda: and how can I check the server fingerprint ? [21:03:26] you can't. it just uses the system's certificates. [21:03:29] is the query (when not logged in) also via https:// ? I cannot determine this [21:03:44] the mobile app does not have a login feature [21:03:45] so [21:03:46] yuvipanda: then a fingerprint viewer should be added [21:04:14] the mobile app is currently in maintenance mode. we'll be re-doing it in a few more months [21:04:33] Wikinaut: a fingerprint viewer might not be so useful, IMO. But it'll definitely have pinned certificates, which are a lot more useful. [21:04:44] and I guess you should be able to view the fingerprint of the certificate in settings [21:04:58] Wikinaut: and as for the mobile web - your webbrowser should have that functionality. [21:05:29] What was the name of that proposed certificate fixing protocol? [21:06:13] yuvipanda: https://github.com/Wikinaut/MySimpleCertViewer is a php standalone viewer (just for the records) [21:06:25] ok :) [21:06:45] parent5446: TACK? [21:06:45] yuvipanda: the app is stand-alone, it does not use a browser [21:07:11] Yes, thanks. I should bookmark it. Also I think there:s a competing one as well. [21:07:15] yuvipanda: what I suggest is (under settings) a way to show the server cert fingerprint [21:07:28] Wikinaut: yeah, I understand. We'll consider it when we re-do the app in a few months' time [21:07:29] shall I file a bugzilla ? [21:08:57] Wikinaut: please do! [21:09:04] parent5446: yeah, there is. I forgot what it is called [21:09:09] yuvipanda: thx [21:09:18] parent5446: I think TACK is the 'competing one', while currently chrome etc implement 'certificate pinning' somewhere [21:09:21] *somehow [21:09:24] not sure if that has a name [21:10:00] Ah yeah, "Public Key Pinning Extension for HTTP" [21:10:04] https://tools.ietf.org/html/draft-ietf-websec-key-pinning-07 [21:10:11] right [21:11:02] And that one is apparently already in Chrome. [21:11:49] yup [21:11:56] we could contact google and get our certificate pinned [21:12:02] but that has consequences when we want to chagne our certs [21:12:03] i think [21:12:26] Yeah, I know Chrome has this "HTTPS always and forever" program [21:12:35] Basically your site will be permanently HSTS. [21:12:42] LastPass and others are on the list. [21:13:20] right. we *could* get on that [21:39:04] (03PS14) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [21:58:58] (03PS5) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [21:58:59] (03PS5) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [21:59:00] (03PS13) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [21:59:01] (03PS21) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [22:40:47] (03PS1) 10MZMcBride: Add "Developers" link to footer of Wikimedia wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 [22:41:16] MatmaRex: :-) [22:41:17] There it is. [22:45:19] (03CR) 10MZMcBride: "Cross-reference: ." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [22:45:36] (03CR) 10MZMcBride: "Cross-reference: ." [core] - 10https://gerrit.wikimedia.org/r/67615 (owner: 10Bharaththiruveedula) [22:51:14] (03CR) 10MarkTraceur: [C: 032] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75122 (owner: 10Rillke) [22:51:29] (03Merged) 10jenkins-bot: Improved file-control positioning [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75122 (owner: 10Rillke) [23:22:12] (03CR) 10Matmarex: [C: 04-1] "Why is 'wikimedia-developers' message inContentLanguage? Shouldn't only the url be treated that way?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [23:48:52] (03PS2) 10MZMcBride: Add "Developers" link to footer of Wikimedia wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 [23:50:20] (03CR) 10MZMcBride: "Matmarex: No better reason than "because it seemed to work." :-)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [23:53:53] (03CR) 10Matmarex: [C: 031] "Looks sane, I didn't test. I'll let somebody more experienced with this WikimediaMessages thing finalize this, though." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride) [23:58:33] (03CR) 10MaxSem: [C: 04-1] "(2 comments)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77557 (owner: 10MZMcBride)