[00:02:31] (03CR) 10LuisVilla: "Krinkle, the removed text (slightly massaged) is handled in the patch currently at https://gerrit.wikimedia.org/r/#/c/77257/1 (though I th" [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [00:03:20] (03PS1) 10Shirayuki: Fix grouppage-* message [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77260 [00:03:34] (03CR) 10Krinkle: "Want me to squash it into this one for you?" [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [00:03:46] Krinkle: please do [00:04:26] i promised luis we'd do the gerrit-twiddling if he got the ball rolling by updating the text [00:05:27] (03PS3) 10Krinkle: Update README w/changes from MediaWiki.org [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [00:05:42] ori-l: message is a mess, but commits are squashed [00:05:55] please do abandon the ones that aren't needed [00:06:20] lvillaWMF: I think we can abandon yours now since Krinkle squashed your changes onto mine [00:06:22] (03Abandoned) 10Krinkle: Update COPYING to match proposed new README [core] - 10https://gerrit.wikimedia.org/r/77257 (owner: 10SuchABot) [00:07:08] (03CR) 10Rillke: "This is new in the plugIn:" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76482 (owner: 10Rillke) [00:07:08] ori-l: no worries [00:07:09] Gerrit' terminology of 'closing' is nicer, but it's the same action. Gerrit's interface is a bit hostile. [00:07:17] GitHub's* [00:07:24] not that I ever had much ego about my 1337 coding skills [00:07:28] but whatever I did have is gone now ;) [00:07:51] (hell, this isn't even coding) [00:07:53] (but shhhh) [00:07:56] (leave me some pride) [00:08:02] (ok) [00:08:11] (cdr YuviPanda) [00:08:11] (are we whispering?) [00:08:21] (car ori-l) [00:08:30] (03Abandoned) 10Rillke: Make jquery.autosize aware of style changes [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 (owner: 10Rillke) [00:08:30] beheadings! [00:08:39] (03CR) 10Krinkle: [C: 04-1] "Per MZMcBride: Trailing whitespace, "Mediawiki" instead of "MediaWiki", and inconsistent casing in headers." [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [00:09:02] betailings! [00:09:09] hmm, it isn't actually called tail, is it? [00:09:33] oh, oof [00:09:36] inconsistent casing [00:09:42] * lvillaWMF is now in fact fully shamed [00:10:59] lvillaWMF: Don't worry, it's rare to get a patch right on the first try :) [00:11:48] (03PS4) 10Ori.livneh: Update README & COPYING [core] - 10https://gerrit.wikimedia.org/r/76643 [00:12:26] hahaha [00:12:31] * lvillaWMF needs lint for lawyers [00:12:43] yeah, that's 4 patches to core via github that never made it [00:12:48] RIP pull requests 1, 2, 3, 4 [00:12:56] (03CR) 10Ori.livneh: "PS4: Update commit message to reflect enlarged scope; fix trailing whitespace & inconsistent casing of "MediaWiki" & header text." [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [00:14:11] (03CR) 10Krinkle: "Rebasing branch parent is 2 month old. Getting inconsistent lint results because of it since a lot changed since 2 months ago." [core] - 10https://gerrit.wikimedia.org/r/65641 (owner: 10Alex Monk) [00:14:16] (03PS7) 10Krinkle: Replace remaining sajax use [core] - 10https://gerrit.wikimedia.org/r/65641 (owner: 10Alex Monk) [00:15:55] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [00:22:14] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [00:23:24] (03PS4) 10MarkAHershberger: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 [00:25:38] (03CR) 10MarkAHershberger: "I think this fixes the problem with a build script and the failing tests -- caused because I didn't store everything in the serialized dat" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [00:42:39] (03PS5) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [00:43:27] (03PS5) 10MarkTraceur: Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [00:45:37] (03PS1) 10Legoktm: Remove trailing whitespace [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77262 [00:46:05] (03CR) 10Legoktm: [C: 032] Remove trailing whitespace [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77262 (owner: 10Legoktm) [00:46:09] (03Merged) 10jenkins-bot: Remove trailing whitespace [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77262 (owner: 10Legoktm) [00:49:28] (03PS1) 10Legoktm: Remove configuration variable for remote account's password [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77263 [00:49:31] (03Abandoned) 10Legoktm: Add a new Special:MassMessageStatus page, which shows how many jobs are queued [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76474 (owner: 10Legoktm) [00:50:12] * lvillaWMF read that as MassageStatus [00:50:17] * lvillaWMF needs to get out more [00:52:14] heheh :P [00:55:18] (03PS1) 10Kaldari: Making title-params no longer required. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77265 [01:00:53] legoktm: Over 9000? [01:01:07] legoktm: Is it going to be an accurate number that people can trust? [01:05:25] (03CR) 10Mwalker: [C: 032] Bug 51194: Localize the publication date in the metadata. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 (owner: 10Mollywhite) [01:05:27] (03Merged) 10jenkins-bot: Bug 51194: Localize the publication date in the metadata. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 (owner: 10Mollywhite) [01:09:23] (03PS6) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [01:09:24] (03PS6) 10MarkTraceur: Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [01:30:59] Reedy: huh? [07:19:34] (03CR) 10Manybubbles: "Thanks so much for looking at this!" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [07:19:35] (03PS1) 10Krinkle: legacy upload.js: Clean up and remove from jshintignore [core] - 10https://gerrit.wikimedia.org/r/77266 [07:19:45] (03PS3) 10Mattflaschen: mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:19:52] (03PS1) 10CSteipp: Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 [07:19:53] TimStarling: Could you review (or +1) https://gerrit.wikimedia.org/r/#/c/77222/ and https://gerrit.wikimedia.org/r/#/c/77219/ (regarding parser options user lang) [07:19:55] (03PS2) 10Tim Starling: doc: Clarify documentation for ParserOptions::getUserLangObj [core] - 10https://gerrit.wikimedia.org/r/77219 (owner: 10Krinkle) [07:19:55] (03CR) 10Tim Starling: [C: 032] doc: Clarify documentation for ParserOptions::getUserLangObj [core] - 10https://gerrit.wikimedia.org/r/77219 (owner: 10Krinkle) [07:19:56] https://www.mediawiki.org/wiki/Special:Contributions/Seobts01?uselang=en [07:19:56] https://www.mediawiki.org/wiki/Special:Contributions/Seobts01?uselang=en-gb [07:19:56] why does the contributions footer disappear on the second [07:19:56] some weird regression somewhere? [07:19:56] Krenair: Unlikely [07:19:56] Krenair: It is a local customization [07:19:56] I swear that used to work [07:19:56] (03Merged) 10jenkins-bot: doc: Clarify documentation for ParserOptions::getUserLangObj [core] - 10https://gerrit.wikimedia.org/r/77219 (owner: 10Krinkle) [07:19:56] maybe I'm just imagining it [07:19:56] Which means it replaces the content language version ('en') [07:19:56] it doesnt show up on uselang=de either because it is english [07:19:56] And the default translation for it is empty. That in itself is something that should be improved. [07:19:56] It should probably be in mediawki-core (at least a sensible default that doesnt' link to toolserver and stuff) [07:19:56] Well shouldn't en-GB fall back to en? [07:19:56] but then again, most of those links are either redundant with the subtitle link traill, or are only wmf specific. [07:19:56] Krenair: yes, but there is already an en-GB translation [07:19:56] '-', which disables it? -.- [07:19:56] Krenair: imagine a message is "Color" in en, and "Colour" en en-gb. And then we change the "Color" one to be a big table with links and stuff, everyting far from a simple word. That entire thing is likely 'en' specific, not 'en-gb'. [07:19:57] It considers the original translation to be more accurate than the non-localized translation [07:19:57] for en-gb it is probably not a big deal, but in this case it works that way because of that. [07:19:57] ugh [07:19:57] if you want you can change the messsage on mw.org and transclude the one from /en if it the box doesnt' contain en-us words [07:19:57] tried that [07:19:57] '$1' showed up in the interface [07:19:57] right [07:19:57] might be a way around that though... hm [07:19:57] you'd have to pass those are transclusion parameters {{{1}}} [07:19:57] and change the 'en' one to use {{{1|$1}}} [07:19:57] and in en-gb |1=$1 [07:19:57] I think that did it [07:19:57] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:19:57] some parts of the en message were already using that hack [07:19:57] just not all [07:19:59] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:19:59] (03CR) 10CSteipp: [C: 032] Fix central session usage in Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76738 (owner: 10Anomie) [07:19:59] (03Merged) 10jenkins-bot: Fix central session usage in Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76738 (owner: 10Anomie) [07:20:00] (03CR) 10Mattflaschen: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:20:01] (03PS4) 10Krinkle: mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 [07:20:02] (03CR) 10Krinkle: "Merged path for CSS and DOM per Mark's suggestion." [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:20:09] (03CR) 10Mattflaschen: [C: 031] mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:20:13] (03PS3) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [07:20:13] (03PS3) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [07:20:13] (03PS11) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [07:20:13] (03PS19) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [07:20:17] (03CR) 10MarkTraceur: [C: 032] "Have I said <3 Krinkle yet today? I don't care. <3 Krinkle." [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:20:18] marktraceur: thx :) [07:20:18] (03PS1) 10Catrope: Update VE to master [extensions] - 10https://gerrit.wikimedia.org/r/77270 [07:20:18] (03CR) 10Catrope: [C: 032 V: 032] Update VE to master [extensions] - 10https://gerrit.wikimedia.org/r/77270 (owner: 10Catrope) [07:20:18] (03Merged) 10jenkins-bot: mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 (owner: 10Krinkle) [07:20:18] RoanKattouw: Did you mean to do that in the meta repo? [07:20:18] I suppose that can't be wrong, that one is supposed to be autoupdating [07:20:18] Yes [07:20:18] The auto-update is broken [07:20:18] still? [07:20:18] ugh [07:20:18] gerrit bug? [07:20:18] Yes [07:20:21] (03PS4) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [07:20:21] (03CR) 10jenkins-bot: [V: 04-1] WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 (owner: 10Rasel160) [07:20:24] (03CR) 10Ori.livneh: "> I am afraid we might want to keep the good old human readable format for sometime." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [07:20:24] Elsie: did you see my reply at https://gerrit.wikimedia.org/r/#/c/76691/ ? [07:20:25] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77272 [07:20:25] legoktm: Probably not. [07:20:25] (03CR) 10Mattflaschen: "I'm fine with finishing update first." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [07:20:27] Elsie: Want to take a look now then? :) [07:20:29] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77272 (owner: 10Catrope) [07:20:29] (03CR) 10Mattflaschen: [C: 04-1] "(4 comments)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 (owner: 10Spage) [07:20:31] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [07:20:31] (03CR) 10jenkins-bot: [V: 04-1] Add unit tests for getParserFunctionTargets and getBaseUrl [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [07:20:31] Erg. [07:20:31] I'll rebase [07:20:31] Oh, that's why submit was greyed out. [07:20:31] (03PS6) 10Legoktm: Add unit tests for getParserFunctionTargets and getBaseUrl [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 [07:20:31] (03CR) 10Legoktm: [C: 032] Add unit tests for getParserFunctionTargets and getBaseUrl [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [07:20:31] (03Merged) 10jenkins-bot: Add unit tests for getParserFunctionTargets and getBaseUrl [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [07:20:32] (03Abandoned) 10Legoktm: sysops can now add/remove the "messenger" group, which now has the proper i18n messages. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75292 (owner: 10Legoktm) [07:20:32] Elsie: Also there's https://gerrit.wikimedia.org/r/#/c/77263/ [07:20:37] (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [07:20:38] legoktm: That variable wasn't used anywhere? [07:20:38] Nope [07:20:38] Interesting. [07:20:38] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77263 (owner: 10Legoktm) [07:20:38] I was planning on using it since we were going to remote edit wikis via the API like translatenotifications did, but now we don't have to [07:20:38] (03Merged) 10jenkins-bot: Remove configuration variable for remote account's password [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/77263 (owner: 10Legoktm) [07:20:38] I'm not sure why you need me to merge this shit. [07:20:38] But if it makes you feel better, all right. [07:20:38] :) [07:20:39] hehe, it's nice to be able to complain about gerrit CR backlog with Elsie too [07:20:39] Code review is gross. [07:51:44] (03CR) 10Hashar: "The main loose argument is "resistance to change" :-] But you are right we can just write simple tool that would let us tail the file wi" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [08:41:40] (03CR) 10Hashar: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [08:42:10] * YuviPanda waves at kart_ [08:42:13] hello! [08:50:33] (03CR) 10Hashar: [C: 032] "Thank you :)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [08:53:11] (03Merged) 10jenkins-bot: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [08:58:21] (03PS1) 10Rotsee: Added MessageFormatter to keep up with latest SMW [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77275 [09:15:57] (03CR) 10Mwjames: [C: 04-1] "Use [1] instead to eliminate the need to know about DI object factoring. See also [2]" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77275 (owner: 10Rotsee) [09:16:44] (03PS8) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [09:24:19] (03CR) 10Parent5446: [C: 032] Add methods to get raw request in WebRequest [core] - 10https://gerrit.wikimedia.org/r/70747 (owner: 10CSteipp) [09:25:27] (03CR) 10Parent5446: [C: 04-1] "(4 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [09:26:59] (03Merged) 10jenkins-bot: Add methods to get raw request in WebRequest [core] - 10https://gerrit.wikimedia.org/r/70747 (owner: 10CSteipp) [09:49:01] (03PS1) 10Rotsee: eliminate the need to know about DI object factoring [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77276 [10:05:10] (03PS1) 10Raimond Spekking: Add extension description message [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/77277 [10:09:04] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77275 (owner: 10Rotsee) [10:10:55] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Added Santhosh as reviewer." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [10:14:40] (03CR) 10Raimond Spekking: "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 10Dan-nl) [10:21:23] (03PS3) 10Siebrand: Update jquery.autosize [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76482 (owner: 10Rillke) [10:23:31] (03CR) 10Siebrand: [C: 032] "PS3 has an update of jquery.autosize.js to v1.17.2 of 2013-07-30. Also updated the URL to point to the branch instead of master." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76482 (owner: 10Rillke) [10:24:46] (03Merged) 10jenkins-bot: Update jquery.autosize [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76482 (owner: 10Rillke) [10:27:29] (03PS1) 10Hashar: run-phpcs-mw: wrapper around phpcs for CI needs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77279 [10:30:45] (03PS1) 10Shirayuki: Add comments for grep & Fix double-whitespaces [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/77280 [10:35:16] (03PS2) 10Hashar: run-phpcs-mw: wrapper around phpcs for CI needs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77279 [10:35:22] (03CR) 10Hashar: [C: 032] run-phpcs-mw.sh: wrapper around phpcs for CI needs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77279 (owner: 10Hashar) [10:38:13] (03CR) 10Hashar: [V: 032] run-phpcs-mw.sh: wrapper around phpcs for CI needs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77279 (owner: 10Hashar) [10:47:31] (03PS1) 10Hashar: new phpcs builder macros [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77281 [10:52:24] (03PS2) 10Hashar: new phpcs builders and job templates [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77281 [10:55:18] (03PS1) 10Hashar: new phpcs jobs for mw/ext/Translate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77282 [10:57:57] (03PS1) 10Hashar: new phpcs jobs for mw/ext/Translate [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77283 [11:00:58] (03PS2) 10Hashar: new phpcs jobs for mw/ext/Translate (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77283 [11:01:36] (03CR) 10Hashar: [C: 032] new phpcs jobs for mw/ext/Translate (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77283 (owner: 10Hashar) [11:01:41] (03Merged) 10jenkins-bot: new phpcs jobs for mw/ext/Translate (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77283 (owner: 10Hashar) [11:02:56] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77284 [11:07:31] (03PS1) 10Hashar: Translate had check-only and test :( [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77285 [11:07:54] (03CR) 10Hashar: [C: 032] Translate had check-only and test :( [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77285 (owner: 10Hashar) [11:08:01] (03Merged) 10jenkins-bot: Translate had check-only and test :( [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77285 (owner: 10Hashar) [11:08:33] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77284 [11:14:38] (03CR) 10Hashar: [C: 032] new phpcs builders and job templates [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77281 (owner: 10Hashar) [11:14:40] (03Merged) 10jenkins-bot: new phpcs builders and job templates [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77281 (owner: 10Hashar) [11:14:46] (03CR) 10Hashar: [C: 032] new phpcs jobs for mw/ext/Translate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77282 (owner: 10Hashar) [11:14:48] (03Merged) 10jenkins-bot: new phpcs jobs for mw/ext/Translate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77282 (owner: 10Hashar) [11:23:42] (03PS1) 10Hashar: phpcs now ignores libs/spyc/spyc.php [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77286 [11:26:25] (03CR) 10Hashar: [C: 031] "The HEAD job https://integration.wikimedia.org/ci/job/mwext-Translate-phpcs-strict-HEAD/3/console does show it is ignored:" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77286 (owner: 10Hashar) [11:34:16] (03CR) 10Siebrand: [C: 032] phpcs now ignores libs/spyc/spyc.php [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77286 (owner: 10Hashar) [11:35:28] (03Merged) 10jenkins-bot: phpcs now ignores libs/spyc/spyc.php [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77286 (owner: 10Hashar) [11:38:17] (03CR) 10Raimond Spekking: [C: 032] Add comments for grep & Fix double-whitespaces [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/77280 (owner: 10Shirayuki) [11:44:28] (03CR) 10Raimond Spekking: [V: 032] Add comments for grep & Fix double-whitespaces [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/77280 (owner: 10Shirayuki) [11:47:58] (03PS1) 10Siebrand: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77289 [11:50:35] (03PS1) 10Siebrand: Fix CodeSniffer errors [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/77290 [11:54:50] (03PS1) 10Hashar: remove Generic.CodeAnalysis.EmptyStatement [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/77293 [11:55:25] (03CR) 10Hashar: [C: 032] remove Generic.CodeAnalysis.EmptyStatement [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/77293 (owner: 10Hashar) [11:56:36] (03CR) 10Hashar: [V: 032] remove Generic.CodeAnalysis.EmptyStatement [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/77293 (owner: 10Hashar) [11:58:34] (03PS1) 10Hashar: remove Generic.CodeAnalysis.EmptyStatement [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77294 [11:58:49] (03CR) 10Hashar: [C: 032 V: 032] remove Generic.CodeAnalysis.EmptyStatement [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77294 (owner: 10Hashar) [12:01:16] (03CR) 10Siebrand: "recheck" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77289 (owner: 10Siebrand) [12:12:42] (03PS1) 10Hashar: phpcs: ignore *.i18n.alias.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77297 [12:12:57] (03CR) 10Hashar: [C: 032] phpcs: ignore *.i18n.alias.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77297 (owner: 10Hashar) [12:13:11] (03CR) 10Hashar: [V: 032] phpcs: ignore *.i18n.alias.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/77297 (owner: 10Hashar) [12:18:59] (03CR) 10Cloudyks: [C: 032 V: 031] Add i18n file [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/73160 (owner: 10Raimond Spekking) [12:19:12] (03CR) 10Cloudyks: [V: 032] Add i18n file [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/73160 (owner: 10Raimond Spekking) [12:22:44] YuviPanda: we should get some Jenkins jobs for grrrit [12:23:04] hashar: yup! Jshint (voting!) at the least [12:23:13] hashar: plus some validation for that yaml config file [12:25:27] hashar: i suppose it is easy to do the jshint one? [12:26:22] not really [12:26:30] the job is hardcoded for mediawiki/core :( [12:26:36] hurr durr bleh [12:27:07] needs some refactoring :( [12:28:21] will do that [12:29:01] :D [12:29:08] I'll probably add qunit tests at some point [12:53:46] (03CR) 10Wikinaut: "Tim, and Ryan(you forgot), please can you +1 ?" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [12:57:18] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77301 [13:06:04] (03PS1) 10Hashar: integration-docroot-jslint never worked (fetch mw/core) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77302 [13:06:05] (03PS1) 10Hashar: {name}-jslint job template is now generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77303 [13:06:06] (03PS1) 10Hashar: restore integration-docroot-jslint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77304 [13:06:08] (03PS1) 10Hashar: labs/tools/grrrit : jslint + yamllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77305 [13:06:57] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77301 (owner: 10Hashar) [13:07:13] (03CR) 10Hashar: [C: 032] integration-docroot-jslint never worked (fetch mw/core) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77302 (owner: 10Hashar) [13:07:16] (03Merged) 10jenkins-bot: integration-docroot-jslint never worked (fetch mw/core) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77302 (owner: 10Hashar) [13:07:22] (03CR) 10Hashar: [C: 032] {name}-jslint job template is now generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77303 (owner: 10Hashar) [13:07:25] (03Merged) 10jenkins-bot: {name}-jslint job template is now generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77303 (owner: 10Hashar) [13:07:33] (03CR) 10Hashar: [C: 032] labs/tools/grrrit : jslint + yamllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77305 (owner: 10Hashar) [13:07:39] (03CR) 10Hashar: [C: 032] restore integration-docroot-jslint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77304 (owner: 10Hashar) [13:07:42] (03Merged) 10jenkins-bot: labs/tools/grrrit : jslint + yamllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77305 (owner: 10Hashar) [13:07:43] (03Merged) 10jenkins-bot: restore integration-docroot-jslint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77304 (owner: 10Hashar) [13:10:47] (03PS1) 10Hashar: triggers for labs/tools/grrrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77306 [13:11:00] YuviPanda|brb: all that mess above for you :-) [13:11:12] (03CR) 10Hashar: [C: 032] triggers for labs/tools/grrrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77306 (owner: 10Hashar) [13:11:17] (03Merged) 10jenkins-bot: triggers for labs/tools/grrrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77306 (owner: 10Hashar) [13:19:07] (03PS1) 10Manybubbles: Fix the broken suggest analyzer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77308 [13:19:55] (03CR) 10Manybubbles: "This is the start of my effort to make a search for "noble prize" on beta actually suggest "nobel prize" again. Currently it suggests "no" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77308 (owner: 10Manybubbles) [13:28:11] (03CR) 10Siebrand: [C: 032] Fix grouppage-* message [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77260 (owner: 10Shirayuki) [13:28:14] (03Merged) 10jenkins-bot: Fix grouppage-* message [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/77260 (owner: 10Shirayuki) [13:29:09] (03CR) 10Siebrand: [C: 04-1] "Can you please put the underscores back in the page names?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 (owner: 10Shirayuki) [13:33:24] hashar: \o/ [13:34:31] (03PS2) 10Shirayuki: Fix group-* and grouppage-* message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 [13:35:00] (03CR) 10Shirayuki: "Sorry." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 (owner: 10Shirayuki) [13:44:00] (03CR) 10Siebrand: [C: 032] Add full-stops & fix quotation marks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 (owner: 10Shirayuki) [13:44:08] (03Merged) 10jenkins-bot: Add full-stops & fix quotation marks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 (owner: 10Shirayuki) [13:44:22] (03CR) 10Siebrand: [C: 032] Fix group-* and grouppage-* message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 (owner: 10Shirayuki) [13:44:30] (03Merged) 10jenkins-bot: Fix group-* and grouppage-* message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 (owner: 10Shirayuki) [13:49:46] (03PS1) 10Yaron Koren: New version: 0.4 [extensions/SemanticSignup] - 10https://gerrit.wikimedia.org/r/77315 [13:51:07] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 0.4 [extensions/SemanticSignup] - 10https://gerrit.wikimedia.org/r/77315 (owner: 10Yaron Koren) [14:14:16] YuviPanda: got a .jshintrc change for grrrit https://gerrit.wikimedia.org/r/#/c/77309/ [14:14:41] hashar: merging [14:14:57] once gerrit stops freezing my system [14:15:34] merged! [14:17:51] and filled a bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 :D [14:18:10] YuviPanda: by defaults jshint ends up using the .js* files that comes from integration/docroot :( [14:18:27] (03PS9) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [14:18:34] (03CR) 10jenkins-bot: [V: 04-1] Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [14:18:53] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [extensions/cldr] - 10https://gerrit.wikimedia.org/r/77319 [14:21:09] (03PS10) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [14:21:13] (03CR) 10jenkins-bot: [V: 04-1] Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [14:32:04] (03CR) 10Rjain: "I rebased the patch and pushed it again but jekins-bot still says -1" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [14:38:47] hashar: are the grrrit-wm changes voting? [14:39:08] YuviPanda: they should [14:39:12] alright :) [14:40:02] YuviPanda: rebased https://gerrit.wikimedia.org/r/#/c/77307/ [14:40:04] (a test change) [14:40:17] passing and voting [14:40:22] sweet! \o/ [14:40:22] ty [14:40:30] there's yamllint too? nice [14:48:53] end of the world for me [14:48:57] I am in vacations now! [14:49:02] happy hacking [14:49:03] oh noooos! [14:49:20] but what about ? [14:49:46] cscott: you all be fine :] [14:50:42] hashar: there's actually an annoying after-merge jenkins test which is always failing for parsoid, because the node path is wrong or some such. [14:50:51] hashar: but i figure it's good exercise for me to fix it myself. ;) [14:51:05] that is unfortunate [14:51:11] you can poke marktraceur about it [14:51:12] probably by disabling the test -- what use is a test that runs *after* the merge? [14:51:18] I guess you could export the node path directly in the test [14:51:34] the other jenkins tests work fine, so it's just something weird with that one [14:51:42] jobs after a merge let you track regressions :) [14:51:45] like i said, it's not high priority, and it will be good for me to fix it ;) [14:51:55] make sure to bug fill it :] [14:52:00] hashar: we like to ensure that there are no regressions *before* the merge ;) [14:52:05] definitely can't work on it today since well I am gone [14:52:30] hashar: yeah, just thought i'd mention it quickly in case there was some hashar secret stored up in your brain which i should know about [14:52:40] like, "all after-merge jobs are broken" or something ;) [14:53:02] anyway, happy vacation! [14:55:51] thanks ;) [15:32:46] (03CR) 10Cmcmahon: "OK, so the 'none pipe' issue is a bug found by the test." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [16:22:14] woot, why does https://gerrit.wikimedia.org/r/#/c/20500/ have release notes for 1.20? D: [16:42:07] is grrrit-wm dead? [16:42:20] i just did things and it didn't report them [17:16:47] MatmaRex: I've heard it's slow because of toollabs [17:22:19] well, but there's "slow", and there's "over 30 minutes of delay" [17:22:37] MatmaRex: Yeah I dunno [17:22:48] YuviPanda_zz: HEY, your bot. It's slow. [17:22:56] is it slow? [17:22:59] or is it dead? [17:23:10] I dunno, maybe it's dancer [17:23:12] * YuviPanda kicks it [17:25:00] MatmaRex: yeah, it was routing everytihng into #mediawiki-feeds. Reverted that, should work now [17:25:27] MatmaRex: should work. try it? [17:25:39] Nemo_bis: I reverted your patch. for some reason it was sending things *only* to -feed [17:26:20] YuviPanda: do you happen to have a change that needs rebasing release notes? [17:26:24] sadly, no [17:26:28] or happily, no [17:26:54] it's funny, but i can get all unmerged changes with all of their changed files and comments with one gerrit rest api request [17:27:17] i think i'm going to make it send such a request every five minutes or so and grep for "needs rebase" [17:28:25] (03CR) 10Matmarex: "Anyone?" [core] - 10https://gerrit.wikimedia.org/r/76506 (owner: 10Matmarex) [17:28:29] YuviPanda: ^ [17:28:44] yeah, that works [17:28:46] I guess [17:30:38] Nemo_bis: I reverted your patch [17:31:04] YuviPanda: you might want to merge that, btw ;) ^ [17:31:37] MatmaRex: looking [17:31:46] well, trying to look - when firefox actually responds [17:32:36] (03CR) 10Matmarex: "With that thinking we could disable just about anything. Hell, every new special page potentially introduces attack vectors." [core] - 10https://gerrit.wikimedia.org/r/64860 (owner: 10MarkAHershberger) [17:32:56] MatmaRex: I think it should be 'Token for' rather than Token of? [17:33:54] YuviPanda: hmm [17:35:10] i don't think i actually have enough knowledge of english to judge this, but i guess i chose 'of' because you don't "use" that token for anything, it's just something that is used by the feed internally [17:35:20] unlike, say, a password reset token [17:35:35] hence 'of', not 'for' [17:35:45] but we probably need a native speaker here ;) [17:35:51] or near-native, i gues.s [17:35:53] true! [17:35:59] I don't count as either. [17:36:06] UploadWizard: ^? [17:36:08] * bawolff would go with "for", but my grammar is horrible [17:36:11] Damn it [17:36:28] What are we talking about? [17:36:38] marktraceur: https://gerrit.wikimedia.org/r/#/c/76506/2/languages/messages/MessagesEn.php [17:36:44] 'Token for' or 'Token of' [17:36:44] On it [17:37:25] MatmaRex: Does the token contain the web feed, or does it refer to the web feed? [17:37:36] (rhetorical) [17:37:45] The former would be "of", the latter is "for" [17:38:20] You could make a case that "of" would work if it came *out* of the web feed, but I would use "from" in that case, in modern American English [17:38:58] YuviPanda: hmpf, ok, any idea of the reason? [17:39:13] Nemo_bis: yeah, I know the reason. [17:39:28] Nemo_bis: so, #wikimedia-dev is considered 'default' channel. If things don't go anywhere else, they come here. [17:39:43] Nemo_bis: so when you added -feed, every message went *somewhere*, so default channel never got used [17:40:07] marktraceur: hmm. alright [17:40:23] YuviPanda: ah, so not literally everything was going just to -feed [17:40:25] Nemo_bis: this should be implemented as code change, with a config property of 'feed-channel' or something that every message is sent to, regardless of other routing [17:41:23] Nemo_bis: no, everything under mediawiki.* *was* going to -feed. #wikimedia-dev is used when the message doesn't match *any* of the repos. So -mobile was going to both -mobile and -feed, while core was going to just -feed [17:41:29] (03PS3) 10Matmarex: Expand the info in 'resettokens-watchlist-token' [core] - 10https://gerrit.wikimedia.org/r/76506 [17:41:35] marktraceur: ^ [17:42:09] YuviPanda: yes, but specific channels were still receiving their stuff [17:42:17] Nemo_bis: yeah, except for -dev. [17:42:19] -dev is special :P [17:42:31] look at the config file, you'll note that -dev is defined as a 'default channel' [17:42:37] yes I know [17:42:49] (I dislike it a lot) [17:43:22] (03CR) 10MarkTraceur: [C: 031] "Siebrand, make sense to you?" [core] - 10https://gerrit.wikimedia.org/r/76506 (owner: 10Matmarex) [17:43:27] Nemo_bis: dislike what? [17:43:40] Nemo_bis: the fragmentation? [17:43:58] anyway, for -feed to work as you want it to, there needs to be a JS patch. rather small, if you want to make one :) [17:44:26] no, I can't, sorry [17:44:57] ok [17:45:59] (03PS3) 10Cscott: Whitelist the element. [core] - 10https://gerrit.wikimedia.org/r/63408 (owner: 10Daniel Friesen) [17:48:21] (03CR) 10Cscott: "@nikerabbit: ping" [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [17:48:39] bad time for ping [17:48:47] heh, marktraceur sortof similar to your 'ping' use case for the bot ^ :) [17:49:13] YuviPanda: Yup :) [17:49:23] marktraceur: I guess this works well enough. [17:49:24] YuviPanda: We've done that in -parsoid for some time actually [17:49:27] nice! [17:49:41] YuviPanda: But it would be waaaaay cooler to have the bot do it automatically [17:49:52] marktraceur: true, but the bot does not know IRC nicks :( [17:50:06] Nikerabbit: don't you mean, "bad ping time"? [17:50:06] YuviPanda: You can tell it IRC nicks, via the Ping: header :) [17:50:16] mmmm, that works. [17:50:27] marktraceur: should it do memoserv? pm? [17:50:50] YuviPanda: If the person doesn't exist on the network just then, memoserv would be a good start [17:50:54] cscott: ug? [17:51:27] I'd just have it do "Nikerabbit ^", or "(ping: Nikerabbit, cscott, YuviPanda)" [17:51:42] But that makes the initial message pretty long [17:51:44] Maybe PM is better [17:51:45] yeah [17:51:47] Reduce noise [17:51:59] also that clutters the Commit message, but I guess we'll want this to be triggered by CR [17:52:00] marktraceur: really, i just want gerrit to start escalating reviews which have been pending for too long. [17:52:12] first red, then blink, then etc. ;) [17:52:28] cscott: That would be pretty effective for me [17:52:38] * marktraceur is a bad person to ask for review :( [17:52:48] Maybe I should do that today. [17:52:51] cscott: in core these tend to be half-finished things no one wants to touch :( [17:53:02] * cscott adds marktraceur to a bunch of reviews [17:53:06] Nemo_bis: do you want to restrict -feed to just mediawiki/*? Or all repos? [17:53:08] Damn it cscott [17:53:10] You're not helping [17:53:18] cscott: you can also ping marktraceur by saying 'UploadWizard' 3 times [17:53:20] anywhere [17:53:28] he'll appear saying 'dammit!' [17:53:33] YuviPanda: Youuuuuuuuuuuuu bastard. [17:53:51] YuviPanda: mediawiki.* should be enough [17:53:55] You realize what you're doing. [17:54:00] Nemo_bis: bleh, that's a little harder :( [17:54:03] than doing 'everything' [17:54:16] You're destroying the meaning of "UploadWizard" as a greppable string in my logs. [17:54:19] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core,n,002310a700000fd7 [17:54:26] marktraceur: it's okay, nobody but cscott can read that, right? :) [17:54:38] Not to mention diluting the nature of "marktraceur" in my logs [17:54:41] * bd808 stares at mirror: "Biggie Smalls, Biggie Smalls, Biggie Smalls" [17:54:43] and /me can't read [17:54:47] YuviPanda: well, again, evreything would be easier if all events were sent here [17:55:06] Nemo_bis: fine, I'll just send everything. is that ok? [17:55:13] *there* [17:55:32] Nemo_bis: and as for everything 'here' that's not something I can control. So... :) [17:55:35] no, not to *mediawiki*-feed [17:56:21] hmm, sigh. I'll just stash this for now. that'll need a fair bit more complex routing, or a horrible hack :( [17:56:31] Nemo_bis: do file a bug though, so we don't forget. (for -feed) [17:57:04] sigh [17:57:34] then for now you may just as well send everything [17:57:43] and then I'll file a bug to make it better [18:02:44] (03PS10) 10Matmarex: tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 (owner: 10Hashar) [18:03:44] (03CR) 10Demon: [C: 032] "I for one welcome our new readme overlord :D" [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [18:04:02] weeee [18:04:04] (03CR) 10jenkins-bot: [V: 04-1] tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 (owner: 10Hashar) [18:06:14] (03Merged) 10jenkins-bot: Update README & COPYING [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [18:06:15] (03PS1) 10Mollywhite: Use inNamespaces instead of comparing getNamespaces. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/77360 [18:06:44] so much better: https://github.com/wikimedia/mediawiki-core [18:07:42] (03CR) 10Cmcmahon: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [18:08:26] ori-l: eh, and in the end no one fixed the bullet list [18:09:09] MatmaRex: i'll fix it. i just hate stalling patches for all eternity. [18:09:27] our code's in git, this readme's better, it takes a while to get momentum and consensus for a change of something like that, let's just go with it and then fix. [18:09:34] :) [18:10:00] (03CR) 10Matmarex: "The alternative patch was abandoned. What now?" [core] - 10https://gerrit.wikimedia.org/r/33273 (owner: 10Olenz) [18:10:21] (03CR) 10Matmarex: [C: 04-1] "Needs update in docs/hooks.txt, also Daniel's inline comment." [core] - 10https://gerrit.wikimedia.org/r/33273 (owner: 10Olenz) [18:10:40] * YuviPanda will happily merge the README patch if everyone feels they've a hand in the pie [18:11:43] (03CR) 10Matmarex: "Poke." [core] - 10https://gerrit.wikimedia.org/r/42405 (owner: 10Alex Monk) [18:15:37] what's the proper for @param in doc comments, again? [18:15:45] @param type $var or param $var type? [18:15:58] MatmaRex: In JS or PHP? [18:16:23] (03CR) 10Anomie: [C: 032] Minor fixes to prevent exceptions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 (owner: 10CSteipp) [18:16:29] (03Merged) 10jenkins-bot: Minor fixes to prevent exceptions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 (owner: 10CSteipp) [18:16:41] @param $name string Some kind of name or something in PHP [18:16:48] (03PS2) 10Anomie: Use one HMAC secret across wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77084 (owner: 10CSteipp) [18:16:52] MatmaRex: I often just follow another comment nearby... [18:17:06] @param varName {string} Some kind of other name in JS [18:17:16] marktraceur: php [18:17:20] (03CR) 10Anomie: [C: 032] Use one HMAC secret across wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77084 (owner: 10CSteipp) [18:17:24] (03Merged) 10jenkins-bot: Use one HMAC secret across wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77084 (owner: 10CSteipp) [18:17:40] <^d> MatmaRex: PHP is supposed to be @param Type $var Description yayayayayay [18:17:50] liangent: i was just rebasing a merge conflict on https://gerrit.wikimedia.org/r/#/c/45506/ and one side had $var type, and the other had type $var [18:18:13] <^d> We got in some bad habits of doing @param $var Type before which "works" but doesn't do the fun type hinting. [18:18:46] Ooh. [18:18:51] * marktraceur bows to ^d [18:20:56] (03CR) 10Manybubbles: "(3 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [18:23:52] MatmaRex [18:23:56] : Who are you poking there? [18:25:32] (03PS4) 10CSteipp: Funnel all central ID <=> name/User lookups through the utils methods [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 (owner: 10Aaron Schulz) [18:27:47] Krenair: anyone [18:27:53] ... ok [18:28:01] including tim and chad, whom i just added as reviewers [18:29:21] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=52469 [18:29:44] I guess I want to file another bug for elements in collapsed blocks [18:31:11] (03CR) 10CSteipp: [C: 032 V: 032] "Seems sane, and a good direction. Working well in testing after rebase." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 (owner: 10Aaron Schulz) [18:31:30] (03PS2) 10CSteipp: Added $wgMWOAuthSharedUserIDs switch to allow using global user IDs [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76218 (owner: 10Aaron Schulz) [18:31:52] (03PS5) 10Matmarex: Change tag improvements. [core] - 10https://gerrit.wikimedia.org/r/45506 (owner: 10Liangent) [18:32:32] (03CR) 10Matmarex: "Rebased, hopefully not breaking anything in the process." [core] - 10https://gerrit.wikimedia.org/r/45506 (owner: 10Liangent) [18:33:16] liangent: hmm [18:34:01] liangent: that should be reasonably easy to solve for preferences, but i don't think that a general roslution for $.makeCollapsbiel and others makes sense [18:34:57] since e.g. the element might be visible when we check it, but hidden a little bit later by some custom script [18:35:44] MatmaRex: I was thinking about makeCollapsible [18:36:23] explicitly, don't collapse a block when it contains the element specified in the hash part of the url [18:36:27] (03CR) 10Anomie: [C: 031] "Code seems sane. Haven't tested though." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 (owner: 10CSteipp) [18:36:39] even if it has class=mw-collapsed [18:39:53] liangent: hm [18:40:13] liangent: what's the use-case? since i really don't see this being useful often [18:41:21] (03PS1) 10Andrew Bogott: Remove hack to comment out private include. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77364 [18:46:58] MatmaRex: {{hideH}}\n== Foobar ==\n{{hideF}} [18:47:10] then linking to #Foobar doesn't work [18:47:27] (03CR) 10Parent5446: "Please note that this does not entirely fix the issue. The problem is mentioned in bug 44718." [core] - 10https://gerrit.wikimedia.org/r/64645 (owner: 10Ori.livneh) [18:48:11] well, okay, but why would you do that? D: [18:48:38] MatmaRex: it's linked from TOC [18:48:51] hmm clicking on toc doesn't trigger a reload [18:48:52] i mean, why would you hide a section [18:49:22] and yeah, this would have to hook to both page load and url target change [18:49:46] (i think html5 has some event that allow for this, but i don't remember what they ar eright now) [18:50:00] MatmaRex: they like to do it, to hide a large bulk of discussion in village pump [18:50:08] maybe with section titles in it [18:50:17] but the heading usually stay visible [18:50:20] headings [18:51:52] MatmaRex: they don't often do it, or should I just ask the community to do so? [18:52:20] heh [18:52:59] i literally don't remember a single instance of wanting to link to something and this thing just happening to be hidden, apart from linking to single prefs [18:53:08] MatmaRex: https://zh.wikipedia.org/wiki/Wikipedia_talk:%E6%8A%95%E7%A5%A8/%E4%BA%BA%E7%89%A9%E6%A2%9D%E7%9B%AE%E5%8B%B3%E9%8A%9C%E4%BD%BF%E7%94%A8%E6%96%B9%E6%A1%88%E6%8A%95%E7%A5%A8#.E6.94.AF.E6.8C.81.E5.8D.80 [18:53:43] try 正式投票 and its subheadings [18:54:05] MatmaRex: also 人物条目勋衔使用方案投票 and subheadings [18:56:59] liangent: i dunno. feel free to implement this, but i don't really like the idea [18:57:11] (03PS11) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [18:57:16] (03CR) 10MarkTraceur: [C: 04-1] "(5 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/66561 (owner: 10Rasel160) [19:08:04] (03CR) 10MarkTraceur: [C: 032] "Seems good to me." [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [19:10:51] (03Merged) 10jenkins-bot: Code style cleanups to Sanitizer.php. [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [19:11:30] (03PS3) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [19:12:33] (03PS2) 10Release notes rebase bot: Add parser tests for bug 52468 and bug 52363. [core] - 10https://gerrit.wikimedia.org/r/77352 (owner: 10Cscott) [19:12:34] (03PS4) 10Release notes rebase bot: Whitelist the element. [core] - 10https://gerrit.wikimedia.org/r/63408 (owner: 10Daniel Friesen) [19:12:59] (03CR) 10CSteipp: [C: 032 V: 032] "Seems sane, and the right direction for identity handling cross wiki. Working in test after rebase." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76218 (owner: 10Aaron Schulz) [19:13:38] (03CR) 10Mwalker: [C: 032] "Cool, didn't know about those functions." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/77360 (owner: 10Mollywhite) [19:13:55] (03Merged) 10jenkins-bot: Use inNamespaces instead of comparing getNamespaces. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/77360 (owner: 10Mollywhite) [19:15:40] (03CR) 10MarkTraceur: [C: 04-1] "(5 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 (owner: 10Rasel160) [19:40:09] ori-l: Ahalan. https://meta.wikimedia.org/wiki/Schema:UniversalLanguageSelector says "interlanguge". How can I change it to "interlanguage"? [19:40:29] where? [19:40:31] (03CR) 10Hashar: [C: 032] "Good catch! I have updated the job with this change :]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77364 (owner: 10Andrew Bogott) [19:40:34] (03Merged) 10jenkins-bot: Remove hack to comment out private include. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77364 (owner: 10Andrew Bogott) [19:40:48] in values or descriptions? [19:44:26] Nikerabbit: ctrl-f for it :) [19:44:54] well i cant [19:44:58] oh. [19:45:00] in description of context. [19:45:10] but that page should be editable, no? [19:45:27] oh, part 2 :) [19:45:36] (03PS10) 10Manybubbles: Add tests for CirrusSearch. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 [19:45:52] it is editable BUT NOT RTL COMPLIANT [19:46:04] (03PS11) 10Manybubbles: Add tests for CirrusSearch. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 [19:47:51] Nikerabbit: ori-l - I fixed it, but now I'd love to fix the CodeEditor to show it correctly to the crazy guy who views meta in Hebrew. [19:48:26] (03CR) 10Manybubbles: "I've added some more documentation and streamlined the setup process so it runs much more quickly by not deleting articles by default and " [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [19:48:32] * Elsie is not RTL compliant. [19:50:17] aharoni: we should fix CodeEditor by moving to CodeMirror [19:50:38] <^d> CodeMirror <3 [19:51:01] ^d: aharoni have you seen http://codemirror.net/demo/bidi.html [19:51:01] ? [19:51:18] aharoni: can you tell me if that is sane bidi bhavior? [19:51:24] <^d> Seen it. [19:51:28] yeah, you showed it to me [19:51:38] <^d> I only speak english though so I don't know how good it is :) [19:52:00] ^d: I think we can rely on aharoni to give us a verdict :) [19:52:05] (03PS2) 10CSteipp: Simplify handling of API POST requests [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 [19:52:06] (03PS2) 10CSteipp: Simplify Multi-wiki setups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77267 [19:52:32] as good as a general text editor on most desktop operating systems [19:59:21] (03CR) 10MarkTraceur: [C: 031] "The code looks fine (yay for deleting things), but http://caniuse.com/#search=hover suggests that IE6 might not support the :hover selecto" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (owner: 10Nischayn22) [19:59:22] (03PS1) 10Hashar: operations-puppet-validate now enforce color output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77376 [19:59:24] (03PS38) 10UnwashedMeme: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [19:59:54] (03CR) 10Hashar: [C: 032] operations-puppet-validate now enforce color output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77376 (owner: 10Hashar) [19:59:56] (03Merged) 10jenkins-bot: operations-puppet-validate now enforce color output [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77376 (owner: 10Hashar) [20:06:01] ori-l: I'm playing around with vagrant and looking at bug#51782 for automatting build [20:06:07] (03CR) 10UnwashedMeme: [C: 031] "Some changes to the existing patch:" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [20:06:23] already have a pull request for puphpet [20:07:47] !autopromote is https://www.mediawiki.org/wiki/Manual:$wgAutopromote [20:07:48] Key was added [20:14:24] (03CR) 10CSteipp: "Yep, I think that normalization is going to mess things up. Let me see how badly $_POST works.." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 (owner: 10CSteipp) [20:25:27] (03PS7) 10Matmarex: Bug 39466: Fix Media: links so that hooks are called [core] - 10https://gerrit.wikimedia.org/r/20500 (owner: 10MarkAHershberger) [20:26:50] (03PS8) 10Matmarex: Bug 39466: Fix Media: links so that hooks are called [core] - 10https://gerrit.wikimedia.org/r/20500 (owner: 10MarkAHershberger) [20:27:02] (03CR) 10Matmarex: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/20500 (owner: 10MarkAHershberger) [20:28:13] (03PS2) 10Spage: Towards OB6 show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 [20:33:55] (03CR) 10Swalling: "One nitpick on the draft: I'd encourage us to try and choose something less verbose than postCreateAccountGettingStarted, at least for the" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [20:37:23] (03PS1) 10Mattflaschen: Update to match new VisualEditor edit tab selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77387 [20:41:20] (03CR) 10Cscott: "@Matmarex yes, I believe this addresses all of the comments so far." [core] - 10https://gerrit.wikimedia.org/r/63408 (owner: 10Daniel Friesen) [20:43:14] (03CR) 10Cscott: [C: 031] Whitelist the element. [core] - 10https://gerrit.wikimedia.org/r/63408 (owner: 10Daniel Friesen) [20:45:02] (03PS2) 10Swalling: Update to match new VisualEditor edit tab selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77387 (owner: 10Mattflaschen) [20:45:05] <^d> Elsie: The cron is live. You should have the weekly stats starting tomorrow morning. If for some reason it doesn't work lemme know on the bug and we'll fix it up. [20:47:54] (03PS6) 10MarkTraceur: Test titles in Details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (owner: 10Nischayn22) [20:48:05] (03CR) 10MarkTraceur: "Rebase. I'll try to rework it in a sec." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (owner: 10Nischayn22) [20:49:42] (03PS3) 10CSteipp: Simplify handling of API POST requests [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 [20:51:24] Argh, I'm so angry that $.validator doesn't have async support [20:52:17] (03PS1) 10CSteipp: Fix error display for Special:MWOAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77390 [20:53:15] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [20:54:58] <^d> Who wants to review a change to core? :) [20:55:51] (03CR) 10Cscott: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/73991 (owner: 10Cscott) [20:55:56] <^d> Don't everyone volunteer at once! [20:56:31] ^d: i don't have +2 bits for core, so i'm off the hook. ;) [20:56:47] <^d> Lucky you :p [20:57:01] I failed Software Engineering for 3 years, so I'm off the hook too! [20:57:02] :D [20:57:22] also, every patch of mine to core gets code-styled to death, so apparently I'm not a reliable reviewer for that most-important of all patch qualities [20:57:51] ^d: https://gerrit.wikimedia.org/r/#/c/76950 ? [20:57:53] i am in particular notoriously guilty of assuming that if the rest of the php file in question does something 1 way, that I should do it that way in my patch as well. [20:58:01] (03PS3) 10Mattflaschen: Update to match new VisualEditor edit tab selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77387 [20:58:10] <^d> Krinkle: Indeed, that's the one. [21:00:04] ^d: PARAM_TYPE means allowed values [21:00:12] what a terrible name of that key [21:00:43] I had to look it up twice, I couldn't believe it. you're assigning an array of allowed values to PARAM_TYPE, and that's actually correct. [21:00:46] weird [21:01:55] (03PS2) 10Bsitu: Remove unused i18n message [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/75491 [21:02:01] <^d> Krinkle: Yeah, it's weird. [21:02:08] (03PS2) 10CSteipp: Fix error display for Special:MWOAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77390 [21:03:24] (03CR) 10Krinkle: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [21:03:29] Krinkle: It also means type [21:03:39] PARAM_TYPE => 'string' and PARAM_TYPE => 'integer' work [21:03:42] As do a few others [21:03:42] ^d: Yes, I looked it up again. if is_array( type ) [21:03:50] RoanKattouw: ^ [21:03:52] But yes, for multival it's PARAM_TYPE => array( values ) [21:04:03] ^d: btw, I'm not going to merge it (not my area I feel comfortable over changing) [21:04:23] * ^d needs someone with +2 on core who's not afraid of it :) [21:04:31] (03CR) 10Catrope: [C: 032] Update to match new VisualEditor edit tab selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77387 (owner: 10Mattflaschen) [21:04:35] (03Merged) 10jenkins-bot: Update to match new VisualEditor edit tab selector [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77387 (owner: 10Mattflaschen) [21:05:09] ^d: how many +1s do you need to make a +2? ;) [21:06:09] (03PS3) 10CSteipp: Fix error display for Special:MWOAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77390 [21:06:43] <^d> cscott: Over 9000! [21:07:06] (03PS2) 10Rachel99: WIP VE Headings test. W [qa/browsertests] - 10https://gerrit.wikimedia.org/r/77220 [21:08:54] (03CR) 10Anomie: [C: 032] "Looks fine to me." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77390 (owner: 10CSteipp) [21:09:01] (03Merged) 10jenkins-bot: Fix error display for Special:MWOAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77390 (owner: 10CSteipp) [21:09:09] (03PS4) 10Bsitu: Remove unused i18n message [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/75491 [21:14:48] (03CR) 10Rachel99: "Chris I did my best to finish this, but the diff line on this test needs some more work. It locates the paragraph_page_diff element, but i" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/77220 (owner: 10Rachel99) [21:16:31] yuvipanda: Are you feeling UploadWizard-y? https://gerrit.wikimedia.org/r/50953 is now async. [21:17:15] (03PS7) 10MarkTraceur: Test titles in Details step. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (owner: 10Nischayn22) [21:17:16] (03CR) 10MarkTraceur: "See e.g. https://github.com/jzaefferer/jquery-validation/blob/master/src/core.js#L1128" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50953 (owner: 10Nischayn22) [21:17:29] I don't have titleblacklist locally but it seems like that's the way to do it [21:17:54] marktraceur: mm, not right now (neck deep in puppet), but hopefully in hong kong / flight [21:18:05] Byokay [21:33:05] (03CR) 10MarkTraceur: "(10 comments)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/39038 (owner: 10Matthias Mullie) [21:33:22] (03PS5) 10Bsitu: Remove unused i18n messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/70750 [21:33:59] (03PS12) 10MarkTraceur: (bug 27995) Added support for screen width upto 800px [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61289 (owner: 10Rasel160) [21:37:57] (03CR) 10MarkTraceur: [C: 04-1] "The CSS application should probably happen on resize events, conditionally, as well. That way I can test it in my browser without much tro" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61289 (owner: 10Rasel160) [21:39:48] A good evening. I'm looking for someone who is knowledgeable about the MediaWiki Parser, specifically the formatHeadings function. [21:40:20] lordfarin: Hi! What do you want to know? [21:41:12] (03CR) 10MarkTraceur: "However, some of the fields in the details step still seem to overflow. Sadness." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61289 (owner: 10Rasel160) [21:42:26] marktraceur: I've been trying to develop an extension for MW, which introduces some sections through a custom tag. These don't show up in the TOC, and I've come to suspect the formatHeadings function as the culprit. Cf. https://bugzilla.wikimedia.org/show_bug.cgi?id=45317 [21:43:08] There seems to be an issue with this function acting erratically when called by recursiveTagParse. [21:43:09] lordfarin: Do you have code somewhere that we can look at? [21:43:43] The link I just gave includes the code for the extension and a minimal working example. [21:45:22] Oh, cool [21:48:28] lordfarin: I'm going to guess that the parser has some internal list of headings that it uses, and that you need to stick your headings in there too [21:48:35] But I've only glanced briefly [21:52:53] (03CR) 10MZMcBride: "As I understand it (and please correct me if I'm mistaken), by default MediaWiki disables all file uploads as a security precaution ($wgEn" [core] - 10https://gerrit.wikimedia.org/r/64860 (owner: 10MarkAHershberger) [21:55:53] marktraceur: Thanks, I guess something like that could work. But without at least a tiny bit of understanding of how the TOC is generated, I feel like I'm trying to nail a headshot with a shotgun -- from a kilometer away. [21:59:02] (03PS39) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:59:34] (03Abandoned) 10MarkAHershberger: Disable chunked uploads by default. [core] - 10https://gerrit.wikimedia.org/r/64860 (owner: 10MarkAHershberger) [21:59:53] ori-l: Yo. [22:00:08] ori-l: With the README update now merged, do we keep the associated bug open? [22:00:12] Or simply point to the wiki page? [22:00:25] the latter, I'd say. [22:00:32] K. [22:01:04] it could be improved, but the same could be said of everything. it's not 'zomg awful', and hence not a bug. that's my thinking, anyways. [22:01:21] * Elsie nods. [22:01:28] I know we discussed perhaps tweaking the formatting. [22:01:34] I'll leave a note on the bug when I mark it resolved. [22:01:44] Oh, hrmph. [22:01:53] The links aren't even clickable. [22:01:58] That sucks. [22:02:11] https://github.com/wikimedia/mediawiki-core#readme [22:02:26] Well, we need to fix that, at least. [22:03:06] * Elsie forks. [22:04:55] (03PS40) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [22:05:49] ori-l: https://github.com/mzmcbride/mediawiki-core#readme is kind of ugly. [22:05:56] So much spacing. [22:06:08] And italics came from nowhere. [22:06:15] let me know if anyone wants core github pull request syncing. (it's not automatic for core) [22:06:57] * Elsie thinks. [22:07:05] What other formatting can we try? [22:07:08]
? [22:08:08] (03CR) 10Wikinaut: [C: 031] "thanks for your commit. I reverted your change for the cookie-not-present-selection of the the first provider." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [22:08:29] MatmaRex: You about? [22:10:08] Elsie: I think we should forfeit the '.wikitext' symlink (albeit admittedly cute) [22:10:14] and thus have the file formatted as plain text instead [22:10:24] .mediawiki [22:10:53] I mean, if mediawiki-core isn't using the .mediawiki formatting, what the hell is the point of it? :-) [22:10:55] lordfarin|afk: I'm definitely still interested in figuring this out, just had to step away for a bit [22:11:07] Elsie: not really. 'sup? [22:11:23] MatmaRex: https://github.com/mzmcbride/mediawiki-core#readme [22:11:26] ah. [22:11:29] MatmaRex: I was trying to make that less ugly. [22:11:30] Markdown! [22:11:33] yeah, i suggested some
s before [22:11:37] We could use Markdown. [22:11:45] But I like the idea of using MediaWiki markup. [22:11:48] or just dropping those newlines [22:11:50] Again, this is for mediawiki-core. [22:12:00] And having the links on the same line? [22:12:01] I don't think it's admitting defeat. Consider this: [22:12:04] yes [22:12:14] I don't like that either. :-/ [22:12:19] Wikitext was never designed to be crisp and readable as plain text [22:12:28] it's a mark-up language that is designed to be parsed [22:12:43] markdown is superior for this particular purpose because it was consciously designed to look good unrendered [22:12:46] anyway, i'm afk. PM if you need me [22:13:25] ori-l: Well, we'd have to switch the symlink then, I think. [22:13:29] To be .markdown. [22:13:45] or remove the symlink and rename the file to README.{md,mkd,markdown} [22:13:46] Or .md, I guess. [22:14:06] Not having the README be named README makes my soul hurt. [22:14:21] yeah, maybe you're right [22:14:26] plus I think core's aesthetic is too low-fi and anti-hipster to use Markdown [22:14:41] so I say keep as-is, or just remove the symlink and have it render as plain text. [22:14:44] Plaintext eats preceding spaces, apparently. [22:14:52] I think it looks fine now. [22:14:52] (03CR) 10Wikinaut: [V: 031] "checked." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [22:15:01] ori-l: Now --> https://github.com/atdt/mediawiki-core#readme [22:15:04] You mean that? [22:15:11] The current one at mediawiki-core has unclickable links. [22:15:16] Which are a greater sin than anything else. [22:15:20] Even murder. [22:17:00] Elsie: will you follow-up on wikitech-l? [22:17:21] Maybe. [22:17:26] I'd like to resolve this first. [22:17:52] Otherwise the next fifteen posts will be about the lack of clickable links. [22:18:03] And how MediaWiki doesn't build the Web. [22:20:32] https://github.com/mzmcbride/mediawiki-core#readme [22:20:35] lordfarin|afk: Yeah, I don't see why your solution wouldn't work [22:20:39] Sorry I can't be of more help [22:24:09] ori-l: https://github.com/mzmcbride/mediawiki-core#readme [22:24:23] So minus the fact that GitHub's parser is kind of a piece of shit, I think that's fine. [22:26:18] ori-l: if you're up for some puppet advice, https://gerrit.wikimedia.org/r/77454 :) [22:26:32] How do I squash those commits? [22:26:38] https://github.com/mzmcbride/mediawiki-core/compare/wikimedia:master...master [22:26:58] (Do I need to?) [22:27:18] if you are planning on doing a pull request, no you don't [22:28:17] I sent a pull request. [22:28:22] I think. [22:28:42] link? [22:28:47] https://github.com/wikimedia/mediawiki-core/pull/5 [22:29:44] on it [22:29:48] marktraceur: Np, thanks for your time in any case. :) [22:30:12] Yup [22:30:56] (03PS1) 10MZMcBride: Tweaked README's formatting [core] - 10https://gerrit.wikimedia.org/r/77459 (via SuchABot) [22:31:07] there we go Elsie ^ [22:31:32] Hey-o. [22:31:56] i'm in the process of making this a lot more robust and automated. One of the things to do during wikimania, I suppose [22:32:20] Wanna merge that? [22:32:45] hi manybubbles I have found another odd thing about new search... [22:33:47] (03CR) 10Yuvipanda: [C: 032] "Definitely looks better!" [core] - 10https://gerrit.wikimedia.org/r/77459 (owner: 10SuchABot) [22:33:49] Elsie: done [22:33:57] yuvipanda: Thanks. :-) [22:34:09] * Elsie awaits jenkins-bot. [22:34:16] I synced https://www.mediawiki.org/wiki/README as well. [22:34:26] :) [22:34:36] You're so lowercase today. [22:36:31] (03Merged) 10jenkins-bot: Tweaked README's formatting [core] - 10https://gerrit.wikimedia.org/r/77459 (owner: 10SuchABot) [22:37:04] (03PS1) 10Himeshi: Add handling of other parameters for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/77461 [22:37:28] (03PS4) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [22:37:42] Elsie: jenkins-bot finally got to it [22:39:44] so I was editing a bunch of enWP articles when the new VE version went up and the beta appeared and it threw me off - then excited me - then made me feel silly for being excited - it's the little things.. [22:40:26] https://github.com/wikimedia/mediawiki-core#readme [22:40:28] There we go. [22:51:04] (03CR) 10Cmcmahon: "The old search.feature test is now failing for me in beta." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [23:06:20] (03CR) 10Cmcmahon: "You're going to have to figure out how to trigger diffs for headings that the test can check in the diff view." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/77220 (owner: 10Rachel99) [23:09:01] (03PS12) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [23:12:03] (03PS13) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [23:37:57] (03PS1) 10Cscott: Fix parsoid-regressions job, which wasn't checking out parsoid's node_modules. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77467 [23:39:33] (03CR) 10MarkTraceur: [C: 032] "There's probably a waaaay better way to do this, but that's not really a high priority. I'll chat with hashar during wikimania, maybe." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77467 (owner: 10Cscott) [23:39:35] (03Merged) 10jenkins-bot: Fix parsoid-regressions job, which wasn't checking out parsoid's node_modules. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77467 (owner: 10Cscott) [23:40:53] (03CR) 10Mattflaschen: [C: 04-1] "(4 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [23:45:06] (03PS2) 10EBernhardson (WMF): Batch retreival of ES data with minimal round trips [core] - 10https://gerrit.wikimedia.org/r/71740 [23:45:51] (03CR) 10MarkTraceur: [C: 04-1] "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65548 (owner: 10TheDJ) [23:46:15] (03PS4) 10MarkTraceur: Properly center arrowheads text [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22) [23:46:50] (03CR) 10EBernhardson (WMF): [C: 04-1] "doh...somehow this didnt cherry pick right...fixing soon" [core] - 10https://gerrit.wikimedia.org/r/71740 (owner: 10EBernhardson (WMF)) [23:47:29] (03PS1) 10EBernhardson (WMF): Batch retreival of ES data with minimal round trips [core] - 10https://gerrit.wikimedia.org/r/77468 [23:49:15] (03CR) 10MarkTraceur: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22) [23:49:40] (03CR) 10jenkins-bot: [V: 04-1] Properly center arrowheads text [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22) [23:50:38] (03PS3) 10EBernhardson (WMF): Make wfForeignMemcKey consistent with wfMemcKey [core] - 10https://gerrit.wikimedia.org/r/71740 [23:51:47] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22) [23:56:15] (03PS2) 10MarkTraceur: Mark required fields under "Release Rights" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68948 (owner: 10Bakert) [23:58:04] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/64556 (owner: 10Nischayn22)