[00:03:42] (03PS2) 10Mwjames: Move SMWHooks::onArticlePurge to \SMW\ArticlePurge + tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [00:07:29] (03CR) 10Parent5446: "Why would this break? This is how the "pretty" date format was added for Language::getHumanTimestamp()." [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [00:12:53] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [00:15:43] (03PS3) 10Krinkle: mediawiki.js: Document that default message format is 'text' [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:17:15] (03CR) 10Krinkle: "* Clarified comment." [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:17:25] (03PS4) 10Krinkle: mediawiki.js: Document that default message format is 'text' [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:19:54] (03PS1) 10Bsitu: user-rights notification primary link has incorrect message key [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77073 [00:22:28] (03CR) 10Alex Monk: [C: 032] user-rights notification primary link has incorrect message key [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77073 (owner: 10Bsitu) [00:22:33] (03Merged) 10jenkins-bot: user-rights notification primary link has incorrect message key [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77073 (owner: 10Bsitu) [00:23:12] (03PS1) 10MarkTraceur: Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 [00:25:25] (03CR) 10Mattflaschen: [C: 031] "Krinkle's tweaks look good to me." [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:25:50] (03CR) 10Krinkle: [C: 032] "OK" [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:27:45] (03CR) 10Krinkle: "Nice work so far! Noticed a trailing new line between php and /**, and a few mentions of HotCat (you probably know that already, just obse" [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/76858 (owner: 10Parent5446) [00:27:54] get(): "Retrieves a configuration setting for a given wiki." getSetting: "Really retrieves a configuration setting for a given wiki." Well alright then [00:28:08] (03PS1) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [00:28:49] (03Merged) 10jenkins-bot: mediawiki.js: Document that default message format is 'text' [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [00:42:12] (03CR) 10Krinkle: "Don't run a jQuery object through $() again." [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [00:42:16] (03Abandoned) 10MarkTraceur: Disable and dim other fields if enable-all is on [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/74298 (owner: 10MarkTraceur) [00:42:44] (03Abandoned) 10MarkTraceur: Add user count, play with layout a bit [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/74307 (owner: 10MarkTraceur) [00:42:53] (03Abandoned) 10MarkTraceur: Dynamically change user count on frontend [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/74325 (owner: 10MarkTraceur) [00:43:26] (03CR) 10MarkTraceur: "This is no longer needed for BetaFeatures, since I changed the way it works, but would still be nice to merge it at some point. Let me kno" [core] - 10https://gerrit.wikimedia.org/r/73921 (owner: 10MarkTraceur) [00:43:56] Krinkle: How should I check that it _is_ a jQuery object? [00:44:09] constructor === $? [00:44:18] Or instanceof $ or something [00:44:45] Yeah I'll go with instanceof $ [00:44:47] marktraceur: you coulf probably see if it has a 'jquery' property [00:44:51] could* [00:45:20] as in, ('jquery' in $('whatevs')), i think [00:45:26] http://api.jquery.com/jquery-2/ [00:46:10] Ew, in keyword. [00:46:33] I like instanceof, unless Krinkle wants to tell me that I'm foolish for doing so [00:46:52] (03PS2) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [00:48:23] i wonder how jQuery(whatevs) checks that [00:48:33] Dunno [00:48:47] don't use instanceof [00:48:50] not for jQuery [00:49:21] not reliable because of cross-frame references (for the same reason instanceof Array or Object would be no-go) [00:49:23] heh, it checks for $().selector [00:49:59] MatmaRex: yes, but for something else [00:50:00] and if .selector is present, it assumed that .context is present as well [00:50:01] bleh [00:50:07] assumes* [00:50:08] that's what copies over selector and context, not the elemenets [00:50:16] feels like a bad idea [00:50:27] jquery uses ducktype .jquery just like we ducktype .nodeType [00:50:33] $foo.jquery [00:50:37] foo.nodeType [00:50:58] also takes care of version conflicts on certain wikis where they have their own jquery or jquery compatible lib [00:51:11] This came up on jquery-dev-l recently, ducktype is the norm. [00:52:02] (03PS3) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [00:52:06] alternatively (though far less common) is !$.isPlainObject( x ) && !!x.jquery but just !!x.jquery is widely used and considered good enough and also what jQuery and official plugins use [00:52:19] the !! is of course not needed [00:54:39] (03CR) 10jenkins-bot: [V: 04-1] Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [00:55:20] (03PS3) 10Mwjames: Move SMWHooks::onArticlePurge to \SMW\ArticlePurge + tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [01:00:42] Srsly jenkins [01:01:23] Ah, yeah, good point jenknis [01:01:58] (03PS4) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [01:04:08] marktraceur: add a test and we can merge it [01:04:18] * marktraceur sighs, so many barriers [01:04:40] well, the test just pointed out something important. No better excuse. [01:10:08] Heh, true [01:11:18] * marktraceur hopes he did that right [01:11:25] grrrit-wm: Wake up [01:11:43] YuviPanda_zz: grrrit-wm is sleeping too [01:13:18] (03PS5) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [01:13:45] Bloody hell [01:13:48] (03CR) 10jenkins-bot: [V: 04-1] Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [01:14:10] (03PS6) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [01:16:49] (03CR) 10jenkins-bot: [V: 04-1] Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [01:17:19] (03PS7) 10MarkTraceur: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [01:17:23] * marktraceur swears loudly [01:20:05] Much better [01:20:36] Krinkle: K, I'm done flailing around with qunit, sorry about the noise [01:41:07] (03PS1) 10TTO: Update Chechen language namespace names from translatewiki [core] - 10https://gerrit.wikimedia.org/r/77076 [01:51:45] (03PS1) 10Catrope: Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77078 [01:52:11] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77078 (owner: 10Catrope) [02:12:44] TimStarling: Yes, on save we use the default parser options. This is e.g. what fixed Commons' bug where categories on a page changed based on who saved the page (their {{int}} and {{switchLang}} usage and stuff) [02:14:04] TimStarling: Taking that for granted though, I can understand why uselang=de works but uselang=en not. I suppose if uselang is set to the content language it just uses the one from when the page was saved. [02:14:23] but that still doenst' explain why it saved it french [02:14:33] or did I miss that? [02:14:40] * Krinkle scrolls back up [02:15:38] TimStarling: So you're saying I need to explicitly use $parser->mOptions->mUserLang in the extension? Or does the parser set the context correctly? I'd wonder why it woudn't do that by default. [02:16:04] ah, global state, of course. Context provides userlanguage, I'm using it worng. [02:16:30] short of the parser overriding the main context to be in the default options user lang, it can't fix it [02:18:05] Krinkle: There is some sort of function in ParserOutput somewhere that gives you the userlang and at the same time records that you used it for cache splitting purposes [02:18:47] ParserOptions::getUserLangObj() [02:19:30] RoanKattouw: The comment above that doens't sounds encouraging [02:19:49] I was looking for a comment that says that method avoids link table inconsistencies [02:20:01] not that I'm making any links in tpldata though [02:20:02] Yes [02:20:04] And it does [02:20:05] But [02:20:13] You really shouldn't be using the user language in parser output [02:20:16] Is what they're trying to say [02:20:34] It's not a "don't use this function, use another function" kind of comment, it's "don't use the feature that this function provides" kind of thing [02:21:00] RoanKattouw: so that function will return default language instead of user language when saving, and user langauges when viewing. Right? [02:21:26] I don't know [02:21:36] Ahm, yes [02:21:38] Yes it does [02:21:40] it should probably say that (if so) in the docs for it, and mention that because of this, link tables are not inconsistent.. [02:22:13] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/89706 [02:30:50] (03PS8) 10Krinkle: mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [02:30:54] hey, I am searching for how to enable an extension to Portuguese Wikipedia [02:31:11] who should I talk to? [02:34:24] jonas_agx: There's a process for requesting configuration changes, including enabling extensions. It's documented at https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes [02:34:39] Additionally, if the extension you're talking about has never been enabled on any Wikimedia wiki before, it'll have to go through code review [02:35:00] Perfect RoanKattouw, thanks [02:35:42] It's an extension for Educational Program -- which is already enabled for English Wikipedia [02:40:55] Hi kids. [02:42:49] (03CR) 10Krinkle: "* Made tests more consistent" [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [02:45:02] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [02:49:22] Krinkle: But if I assigned nextnode = nextnode[0] then it would need to get passed through jQuery again [02:49:35] $( nextnode ).before( $item ) [02:49:41] Better not to have to do that [02:57:14] marktraceur: So do it the other way around? [02:57:26] Hm, point. [02:57:31] actually [02:57:37] there's an even better way [02:57:49] let me test first, not sure [02:57:51] KK [02:59:25] marktraceur: yep, two options that will both make it even better (not create a jQuery object for the nextnode if it is a DOM element) [03:00:14] 1) item.insertBefore( nextnode ); // not jquery!; 2) $item.after( nextnode ); // after() doesn't instantiate a jquery object, it takes all arguments and flattens array-like objects including jquery objects [03:00:53] so not only avoid re-creating an object for jquery-nextnode, but even avoid it all together for dom-nextnode [03:01:54] marktraceur: you can put item =$item[0] in a variable, which you'll re-use in the return statement. [03:02:03] Krinkle: DOM .insertBefore() doesn't work that way [03:02:19] https://developer.mozilla.org/en-US/docs/Web/API/Node.insertBefore [03:02:20] RoanKattouw: I think I'm using it correctly here [03:02:53] oh, it needs parentNode [03:02:54] yeah [03:03:30] nextnode.parentNode.insertBefore( item, nextnode ) [03:03:36] meh [03:04:42] marktraceur: and #2 wont' work either because jQuery#after operates from the item point of view [03:04:48] rrr [03:05:14] marktraceur: so yeah, like we had originally. optimise not creating a jquery object twice, but if it isn't already we'll turn it into one [03:07:26] KK [03:11:02] /msg NickServ identify <38911422> [03:12:34] Whooops [03:14:28] http://result.dabblet.com/gist/6127923/b774fa5a44a0d7b6a1c752868cd47c67c31327b8 [03:15:10] ^^ a pretty cool way of tagging articles for cleanup/deletion/errors/etc [03:18:54] I thought the blank white page was a bug for a second. [03:18:57] The tabs are neat. [03:19:12] Though I imagine the animation would bother a lot of people. [03:19:55] maybe. most people wouldn't need to mouse over it [03:20:08] once they do it a couple times they'd know what it meant [03:46:50] http://blog.togo.io/redisphere/how-youporn-uses-redis-sfw-edition/ [03:51:32] #old [03:52:03] p858snake|l: https://www.mediawiki.org/wiki/Redis [03:52:07] That's linked there, BTW. [03:52:11] ori-l: Yo yo yo. [03:56:04] (03PS2) 10MZMcBride: Update README w/changes from MediaWiki.org [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [04:01:39] (03CR) 10Santhosh: "What is changed in patchset 2?" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 (owner: 10KartikMistry) [04:32:52] (03PS1) 10Ori.livneh: Update VisualEditor to bug/52368 [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77081 [04:33:04] What? [04:33:28] (03CR) 10Ori.livneh: [C: 032] Update VisualEditor to bug/52368 [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77081 (owner: 10Ori.livneh) [04:37:29] (03Merged) 10jenkins-bot: Update VisualEditor to bug/52368 [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77081 (owner: 10Ori.livneh) [04:38:20] (03PS3) 10KartikMistry: Fonts for angwiki [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 [04:45:19] (03CR) 10Alex Monk: [C: 04-1] "Looks like we're still waiting for a slight clarification from legal." [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [05:18:41] (03PS1) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [05:29:09] (03PS1) 10CSteipp: Minor fixes to prevent exceptions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 [05:32:40] (03PS1) 10CSteipp: Use one HMAC secret across wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77084 [06:05:11] (03CR) 10Santhosh: [C: 032] Fonts for angwiki [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 (owner: 10KartikMistry) [06:05:20] (03Merged) 10jenkins-bot: Fonts for angwiki [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 (owner: 10KartikMistry) [06:08:08] https://bugzilla.wikimedia.org/show_bug.cgi?id=52253#c6 [06:08:17] If anyone has an interest in an HTTPS question. ^ [06:17:59] (03PS1) 10Ori.livneh: Supply an example 'Vagrantfile-extra.rb' customization file [vagrant] - 10https://gerrit.wikimedia.org/r/77085 [06:18:17] (03CR) 10Ori.livneh: [C: 032] Supply an example 'Vagrantfile-extra.rb' customization file [vagrant] - 10https://gerrit.wikimedia.org/r/77085 (owner: 10Ori.livneh) [06:18:20] (03Merged) 10jenkins-bot: Supply an example 'Vagrantfile-extra.rb' customization file [vagrant] - 10https://gerrit.wikimedia.org/r/77085 (owner: 10Ori.livneh) [06:19:17] (03CR) 10Mwalker: "The comments in the Languages file even says it'll fallback to en just like everything else if it's not defined..." [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [06:30:25] (03CR) 10Parent5446: "Yes, but what's wrong with that. Unless "month-only" has a different format in another language it should be fine (note that the names of " [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [07:51:22] marktraceur: that's toollabs acting up, mostly [07:51:26] grrrit-wm: being slow [07:54:19] Fair enough [07:59:01] marktraceur: still, doesn't lose anything. just delayed [07:59:18] marktraceur: funnily, the reason it is slow is probably 'NFS getting stuck', and the only reason I touch the disk is... for logging [07:59:43] YuviPanda: And it's written in node.js? [07:59:55] And...you're doing it synchronously? [08:02:24] Does anyone log asynchronously? [08:03:11] If you're logging to a file in node.js, probably :/ [08:09:09] hello [08:10:20] marktraceur: well, the bot is in nodejs, and I suppose that's not sync [08:10:25] marktraceur: I am just using winston logging [08:10:32] Hm [08:10:38] marktraceur: however, the part that handles gerrit to redis is in python [08:10:42] so that's probably synchronous [08:11:02] marktraceur: gerrit-to-redis takes gerrit streams, publishes them to redis for anyone to consume. So far grrrit-wm and SuchABot do. [08:21:45] (03PS1) 10Spage: Towards OB6 show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 [09:10:16] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [09:10:37] (03PS6) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [09:11:59] (03CR) 10Siebrand: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73713 (owner: 10Siebrand) [09:13:16] (03CR) 10Siebrand: [C: 032] Allow text selection in page mode [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69972 (owner: 10Nikerabbit) [09:13:54] (03CR) 10Siebrand: [C: 032] Add upload user group [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/74832 (owner: 10Raimond Spekking) [09:14:00] (03Merged) 10jenkins-bot: Add upload user group [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/74832 (owner: 10Raimond Spekking) [09:14:36] (03Merged) 10jenkins-bot: Allow text selection in page mode [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69972 (owner: 10Nikerabbit) [09:18:00] (03CR) 10Siebrand: [V: 04-1] "Has a merge conflict again. Sorry, I didn't review in time..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 (owner: 10Shirayuki) [09:18:02] (03CR) 10Siebrand: [C: 032] Update comments for grep [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76868 (owner: 10Shirayuki) [09:18:03] (03Merged) 10jenkins-bot: Update comments for grep [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76868 (owner: 10Shirayuki) [09:18:57] (03CR) 10Siebrand: [C: 032] Unify @license tags where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76911 (owner: 10Nikerabbit) [09:20:18] (03Merged) 10jenkins-bot: Unify @license tags where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76911 (owner: 10Nikerabbit) [09:20:40] (03CR) 10Siebrand: [C: 032] Fix incorrect behavior with non-capitalized namespace [extensions/Translate] - 10https://gerrit.wikimedia.org/r/75835 (owner: 10Nikerabbit) [09:22:01] (03Merged) 10jenkins-bot: Fix incorrect behavior with non-capitalized namespace [extensions/Translate] - 10https://gerrit.wikimedia.org/r/75835 (owner: 10Nikerabbit) [09:23:15] (03CR) 10Siebrand: [C: 031] Remove Special:QueryCreator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69073 (owner: 10Nikerabbit) [09:24:16] (03CR) 10Siebrand: [C: 032] Check that response.error exists before using it [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69975 (owner: 10Nikerabbit) [09:25:34] (03Merged) 10jenkins-bot: Check that response.error exists before using it [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69975 (owner: 10Nikerabbit) [09:27:57] (03PS4) 10Mwjames: Remove Special:QueryCreator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69073 (owner: 10Nikerabbit) [09:31:24] (03CR) 10Mwjames: [C: 032] "Thanks for the contribution." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69073 (owner: 10Nikerabbit) [09:32:43] (03Merged) 10jenkins-bot: Remove Special:QueryCreator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69073 (owner: 10Nikerabbit) [10:33:34] YuviPanda: Hallo. Apparently, I cannot import an XML dump to http://he.wikipedia.beta.wmflabs.org . [10:33:48] Looks like being a bureaucrat is not enough. [10:34:03] And I can't make myself importer. [10:40:16] (03CR) 10Santhosh: "we need to write qunit tests for this to verify." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69634 (owner: 10Nikerabbit) [10:44:29] aharoni: you should be able to grant yourself whatever you want as 'crat, no? [10:44:41] apparently, no. [10:47:48] aharoni: poke hashar? [10:50:57] hashar is being poked by me in more than one window :) [10:52:34] aharoni: heh :) [11:00:47] (03PS1) 10Nikerabbit: Use better method to add header [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77092 [11:05:16] (03CR) 10Nikerabbit: [C: 04-1] "Can you document somewhere that this hook exists?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [11:06:49] hashar: ^ ... [11:15:20] hashar: Apparently, I cannot import an XML dump to http://he.wikipedia.beta.wmflabs.org , even though I'm a bureaucract. [11:15:39] looks like 'crats don't have the importer right. [11:16:35] I have exactly zero clue how it works :] [11:16:45] YuviPanda|Away: ^ any idea? [11:19:42] aharoni: https://he.wikipedia.beta.wmflabs.org/w/index.php?title=מיוחד%3Aניהול+הרשאות+משתמש&user=amire80 [11:19:45] can you access that ? [11:22:52] aharoni: I have added you to the 'importer' group [11:23:06] our user rights management interface is really bad [11:27:55] (03PS4) 10Siebrand: Add "notify translators" link when marking page for translation [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76115 [11:27:56] (03PS1) 10Siebrand: Replace getActivityColor by StatsTable::getBackgroundColor [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77093 [11:27:57] (03PS1) 10Siebrand: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 [11:37:05] (03CR) 10Nikerabbit: [C: 032] Replace getActivityColor by StatsTable::getBackgroundColor [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77093 (owner: 10Siebrand) [11:46:34] (03PS5) 10Siebrand: Add "notify translators" link when marking page for translation [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76115 [11:47:56] (03PS2) 10Siebrand: Replace getActivityColor by StatsTable::getBackgroundColor [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77093 [11:48:29] (03CR) 10Siebrand: [C: 032] "Removed dependency on other patch set. +2 again per Niklas." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77093 (owner: 10Siebrand) [11:48:47] (03PS2) 10Siebrand: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 [11:50:18] (03Merged) 10jenkins-bot: Replace getActivityColor by StatsTable::getBackgroundColor [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77093 (owner: 10Siebrand) [11:55:34] (03PS3) 10Siebrand: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 [11:55:35] (03CR) 10Siebrand: "PS3 fixes some residual warnings and errors." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 (owner: 10Siebrand) [11:59:14] (03CR) 10Nikerabbit: "(7 comments)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 (owner: 10Siebrand) [12:00:29] (03CR) 10Nikerabbit: [C: 032] Add "notify translators" link when marking page for translation [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76115 (owner: 10Siebrand) [12:04:27] (03CR) 10Nikerabbit: [C: 032] Accept article ID as default setting for translatable page [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/76117 (owner: 10Siebrand) [12:04:29] (03Merged) 10jenkins-bot: Add "notify translators" link when marking page for translation [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76115 (owner: 10Siebrand) [12:04:32] (03Merged) 10jenkins-bot: Accept article ID as default setting for translatable page [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/76117 (owner: 10Siebrand) [12:10:08] (03CR) 10Siebrand: "(6 comments)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 (owner: 10Siebrand) [12:10:10] (03PS4) 10Siebrand: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 [12:17:24] (03CR) 10Siebrand: [C: 032] Use better method to add header [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77092 (owner: 10Nikerabbit) [12:18:16] (03CR) 10Amire80: "(2 comments)" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73950 (owner: 10Nikerabbit) [12:18:55] (03Merged) 10jenkins-bot: Use better method to add header [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77092 (owner: 10Nikerabbit) [12:36:29] (03PS1) 10Hashar: beta: db upgrade for loginwiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77108 [12:36:56] (03CR) 10Hashar: [C: 032] beta: db upgrade for loginwiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/77108 (owner: 10Hashar) [13:24:04] (03CR) 10Mark Bergsma: [C: 031] Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem) [13:26:35] (03CR) 10Mark Bergsma: "I'm not sure whether the premise "the cache already varies on session cookies" holds - it will only do that if MediaWiki tells it to using" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76726 (owner: 10Anomie) [13:27:07] (03PS1) 10Anomie: Fix non-JS login check [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77117 [13:29:57] (03PS1) 10Hashar: get rid of 'gate' pipeline, use 'gate-and-submit' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77118 [13:30:33] (03CR) 10Hashar: [C: 032] get rid of 'gate' pipeline, use 'gate-and-submit' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77118 (owner: 10Hashar) [13:30:40] (03Merged) 10jenkins-bot: get rid of 'gate' pipeline, use 'gate-and-submit' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77118 (owner: 10Hashar) [13:48:53] (03PS2) 10Anomie: Allow caching of Special:CentralAutoLogin when safe [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76726 [13:53:29] (03PS1) 10Mwjames: (Bug 52396) use getSubject()->getDBkey() instead [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/77126 [13:54:50] (03PS1) 10Manybubbles: Stop forceSearchIndex.php from going into loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77127 [13:57:42] (03CR) 10Anomie: "> it will only do that if MediaWiki tells it to using the X-Vary-Options and Vary headers. Whether this code indeed makes sure of that for" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76726 (owner: 10Anomie) [13:59:33] (03CR) 10Siebrand: [C: 04-1] "Per comment on PS1." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur) [14:00:37] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur) [14:08:05] (03CR) 10Manybubbles: "This change looks good to me in spirit except for the whole array_merge with a string thing." [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [14:08:42] I suppose I just forgot to unaway myself this morning.... [14:21:28] (03PS2) 10Manybubbles: Select search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [14:48:30] (03CR) 10Siebrand: [C: 032] Add special page to the media group of Special:Specialpages [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76903 (owner: 10Raimond Spekking) [14:48:34] (03Merged) 10jenkins-bot: Add special page to the media group of Special:Specialpages [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76903 (owner: 10Raimond Spekking) [14:48:37] (03CR) 10Anomie: [C: 031] mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [14:49:06] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweaks for translatewiki.net [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/74621 (owner: 10Raimond Spekking) [14:50:09] (03CR) 10Siebrand: "(1 comment)" [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/73160 (owner: 10Raimond Spekking) [14:51:09] (03CR) 10Siebrand: [C: 031 V: 04-1] "Does not merge cleanly." [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/67963 (owner: 10Raimond Spekking) [14:51:54] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/67858 (owner: 10Raimond Spekking) [14:52:21] (03CR) 10Siebrand: [C: 032 V: 032] Concistency tweak in preparation for adding extension to translatewiki.net [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/54657 (owner: 10Raimond Spekking) [14:53:44] (03CR) 10Siebrand: [C: 04-1 V: 04-1] "Does not merge and needs updating (use HTTPS links to formal policy)." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/49783 (owner: 10Raimond Spekking) [14:55:44] (03CR) 10Siebrand: "Brad, please revisit your blocking code review score, as the patch set was updated over 4 months ago to address the issue you pointed out." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53971 (owner: 10Raimond Spekking) [15:06:23] (03CR) 10Alex Monk: "Where do you have in mind?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [15:06:31] hexmode: .. [15:06:38] hexmode: you killed the jenkins dev box :-] [15:07:13] (03CR) 10Alex Monk: "Demon, please see the latest patch set." [core] - 10https://gerrit.wikimedia.org/r/74678 (owner: 10Alex Monk) [15:09:27] (03PS4) 10MarkTraceur: Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [15:19:05] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [15:38:15] (03PS1) 10Nikerabbit: Log ui-lang-revert [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/77134 [15:49:40] (03CR) 10Nikerabbit: "(2 comments)" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73950 (owner: 10Nikerabbit) [15:50:42] (03PS1) 10CSteipp: Efficiently reset null user tokens [core] - 10https://gerrit.wikimedia.org/r/77136 [15:53:50] (03CR) 10Nikerabbit: "Translate has hooks.txt (a bit different from hooks.txt in core). I guess wiki page could also do but that is even more likely to get out " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [15:53:55] (03CR) 10Anomie: "I see it addressed it by allowing template expansion in the message. What happens when someone puts an {{#invoke}} in the message, conside" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53971 (owner: 10Raimond Spekking) [15:55:09] (03CR) 10Mollywhite: "Ah, I guess the way I was testing it when I said "it breaks a bit" was a bit flawed. I assumed another language would act the same way tha" [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [15:55:43] (03PS4) 10Mwjames: \SMW\SimpleDependencyBuilder + \SMW\DependencyInjector [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [15:57:08] (03CR) 10jenkins-bot: [V: 04-1] \SMW\SimpleDependencyBuilder + \SMW\DependencyInjector [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [15:58:46] (03PS1) 10Matthias Mullie: Add a variant without free-form text field [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/77138 [16:00:48] (03CR) 10Mwjames: "Its a Scribunto, not SMW" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [16:02:09] (03CR) 10Siebrand: "(7 comments)" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76938 (owner: 10Raimond Spekking) [16:02:46] (03PS5) 10Mwjames: \SMW\SimpleDependencyBuilder + \SMW\DependencyInjector [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [16:06:24] (03CR) 10Demon: [C: 032] Fix missing default blacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/76899 (owner: 10Daniel Kinzler) [16:06:25] (03CR) 10Matmarex: Add month-only date format. [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [16:06:28] (03Merged) 10jenkins-bot: Fix missing default blacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/76899 (owner: 10Daniel Kinzler) [16:07:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Nice qqq. Thanks for making the effort." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/77138 (owner: 10Matthias Mullie) [16:07:34] (03CR) 10Mwjames: "Jeroen, surely this is not as fancy as the WikiBaseQuery DI framework but this gets the Job done and can be replaced with a more "heavy" i" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [16:08:06] (03PS2) 10MarkTraceur: Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 [16:11:20] (03PS1) 10Raimond Spekking: Add newline at end of file [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/77139 [16:11:43] (03CR) 10Raimond Spekking: [C: 032 V: 032] Add newline at end of file [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/77139 (owner: 10Raimond Spekking) [16:14:42] (03CR) 10Ori.livneh: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [16:22:11] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur) [16:26:37] (03CR) 10Siebrand: "(1 comment)" [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/75343 (owner: 10Himeshi) [16:33:19] (03PS2) 10Nikerabbit: Stricter parsing for external links in JavaScript [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69634 [16:33:32] (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77141 [16:34:13] (03CR) 10Siebrand: [C: 032] "Thanks for this!" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [16:35:06] (03CR) 10Bsitu: [C: 032] Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77141 (owner: 10Bsitu) [16:36:11] (03Merged) 10jenkins-bot: Make Special:AggregateGroups using jquery.chosen [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [16:36:48] (03CR) 10Siebrand: [C: 04-2] "As noted on Change-Id: I9049e8479c8a77d42cdd6d8c6909a30da8005f3c, we don't like making changes to libraries that are maintained upstream. " [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 (owner: 10Rillke) [16:38:36] (03CR) 10Bsitu: [V: 032] Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77141 (owner: 10Bsitu) [16:54:41] (03PS5) 10Mwjames: Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [16:55:38] (03CR) 10Siebrand: "Can you please explain if this patch set should change any behavior (per bug 48817), or if it's just a prerequisite for fixing that issue?" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76482 (owner: 10Rillke) [16:57:37] (03CR) 10Anomie: [C: 04-1] "(3 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 (owner: 10CSteipp) [17:02:39] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 (owner: 10CSteipp) [17:02:55] (03PS7) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [17:04:33] (03CR) 10Anomie: [C: 031] "Looks sane. Haven't tested." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77084 (owner: 10CSteipp) [17:05:15] bsitu: We will postpone the daily scrum until you upgrade your Hangouts plugin. Speak to you shortly. [17:08:08] (03CR) 10Demon: [C: 032] Stop forceSearchIndex.php from going into loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77127 (owner: 10Manybubbles) [17:08:10] (03Merged) 10jenkins-bot: Stop forceSearchIndex.php from going into loops. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77127 (owner: 10Manybubbles) [17:22:55] (03PS1) 10Jack Phoenix: Configure: add a hook to the database handler. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/77149 [17:25:59] (03PS1) 10Manybubbles: Escape forwad slashes in queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77150 [17:28:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "All right, let's do the API module as a second set. Meeeeeeerge!" [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [17:28:30] (03CR) 10jenkins-bot: [V: 04-1] Add Special:RandomInCategory. [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [17:29:05] oh jenkins bot, so cruel [17:29:45] woo rebase time [17:29:59] brion: <3 nice to merge! :D [17:30:29] brion: too bad we'll have to wait two weeks for this to be deployed [17:30:45] hey two weeks is pretty good [17:30:53] try a couple years ago, nothing was getting synced for months :) [17:31:03] :P [17:31:09] I vaguely remember that [17:31:16] i'm glad that got mostly fixed…. [17:31:36] I remember when things finally did get merged, how everything exploded [17:31:50] kerboooooooomf [17:32:26] brion: Should I rebase that? (As in, are you already in the process of rebasing it?) [17:32:29] merge conflict in release notes, lol [17:32:34] bawolff: i'm on it :) [17:32:37] cool :) [17:32:39] there's a script MatmaRex has for that :P [17:33:01] alas, his script doesn't work in a wide variety of cases :( [17:33:22] (03PS12) 10Brion VIBBER: Add Special:RandomInCategory. [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [17:33:35] i keep saying old-fashioned text release notes files are nothing but an annoyance to maintain, but nobody agrees with me :) [17:33:45] what kind of release notes do you want? [17:34:02] (out of curiosity, and yes I have read some of the threads but can't keep track of who has which views) [17:34:16] preferably, automatically built from commit summaries [17:34:25] perhaps with a little manual massaging [17:34:34] we could tag things perhaps [17:34:41] but eh, not top of the priority list [17:34:50] ok did that go in? /me waits for gerrit irc bot [17:35:01] ergh [17:35:08] and please, nobody say "that's what she said" [17:35:09] * apergos despairs of commit summaries ever being that good [17:35:19] you said it yerself. thanks buddy [17:35:24] shit [17:35:26] heh [17:35:30] * brion hands self a pamplhet [17:35:34] exactly [17:36:07] omg if people on a certain thread eveer knew about 'the pamphlet' we would all belooking for other jobs... [17:36:43] ok i don't' see my patch set….. blame gerrit or git-review? :P [17:37:20] jenkins-bot verified +2 it [17:37:26] Its there [17:37:43] aha [17:37:49] page must not have refreshed properly [17:38:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Rebased for release notes conflict. Let's try this..." [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [17:38:15] \o/ [17:38:17] yay! [17:39:12] YuviPanda: yeah, i got some feedback on it and i though that it should work like forcing jenkins to recheck the change works [17:39:14] or worked [17:39:26] you just say "rebase"on the patch and wait a few minutes [17:40:00] (03PS2) 10CSteipp: Minor fixes to prevent exceptions [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 [17:40:19] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77083 (owner: 10CSteipp) [17:45:57] (03CR) 10Demon: "preg_quote() might be of use here rather than maintaining a list of regex special thingies we want to escape." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77150 (owner: 10Manybubbles) [17:48:10] (03PS1) 10Yaron Koren: New version: 1.6.2 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77153 [17:51:47] (03CR) 10Manybubbles: "Conceptually we're not escaping a regular expression at all though - it is a elasticsearch query string. Also, we want $ and * to get thr" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77150 (owner: 10Manybubbles) [17:52:20] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 1.6.2 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/77153 (owner: 10Yaron Koren) [18:07:41] csteipp: Sigh. It might be appropriate for you to say something here: https://en.wikipedia.org/wiki/Wikipedia:ANI#Message_forgery [18:11:49] Krenair: Thanks, I'll try and ease their fears [18:23:07] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [18:25:51] csteipp, basically code made by a local wiki admin (https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-twa1.js ) is run when a certain GuidedTour ('twa1') starts [18:26:37] It makes an edit (without warning or being asked to), which of course as it's run in a user's browser means it's authenticated as the user, to the user's talk page [18:27:23] (03PS1) 10Siebrand: Use page instead of article in UI [core] - 10https://gerrit.wikimedia.org/r/77158 [18:28:08] (03PS8) 10Manybubbles: Add tests for CirrusSearch. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 [18:28:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] Use page instead of article in UI [core] - 10https://gerrit.wikimedia.org/r/77158 (owner: 10Siebrand) [18:29:07] brion: I wonder if the addition "The selection process of this page may be biased towards certain pages and should not be used for statistical purposes." to the special page is really useful. [18:29:21] brion: I'd rather get rid of it; would that be okay? [18:29:34] meh, i don't mind either way :) [18:29:43] YuviPanda: any strong opinion on that? :) [18:29:56] I don't mind either way, either [18:30:11] siebrand: go ahead then :D [18:30:37] * YuviPanda adds more 'either's to that sentence [18:31:05] eithernet [18:31:25] brion: submitting... [18:31:57] YuviPanda: Dude, what's up with failing "Software Engineering"? [18:32:11] siebrand: for the third year running! [18:32:13] (btw, I avoided that by never taking such a class) [18:32:18] I had no choice [18:32:26] (03PS1) 10Siebrand: Remove verbosity in message [core] - 10https://gerrit.wikimedia.org/r/77160 [18:32:33] uggggggh [18:32:34] college :P [18:33:01] siebrand: I'll ask them to 'reevaluate' the paper, there's a 50/50 chance of it getting through that [18:33:06] Luckily passing Software Engineering class in an Indian college is not a +2 prerequisite. [18:33:55] YuviPanda / brion: https://gerrit.wikimedia.org/r/#/c/77160/ [18:34:44] all right, javascript diff freezing my browser [18:35:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove verbosity in message [core] - 10https://gerrit.wikimedia.org/r/77160 (owner: 10Siebrand) [18:35:30] brion: hehe, did to me too [18:35:32] YuviPanda: for future reference, it's good to do things like that as two separate messages -- then you can easily remove one and let the translations for the other one stand [18:35:48] siebrand: heh, yeah. At worst I should be done with this by January, but it's still pissing off. [18:35:54] siebrand: at least they could've failed me in a *real* subject [18:37:30] (03CR) 10CSteipp: [C: 032] "Fixes the issue. Thanks!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77117 (owner: 10Anomie) [18:37:35] (03Merged) 10jenkins-bot: Fix non-JS login check [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77117 (owner: 10Anomie) [18:43:09] (03CR) 10Rjain: "Let update be done first, then i will carry on with this." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [18:50:18] * hashar waves at brion [18:50:32] * brion waves hashar  [18:50:34] when do you relocate your sense of humor here in Europe ? [18:50:40] we get 4G everywhere! [18:50:47] :) [18:58:16] (03CR) 10Siebrand: "(2 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [18:58:17] (03Merged) 10jenkins-bot: Fix CodeSniffer warnings and errors [extensions/Translate] - 10https://gerrit.wikimedia.org/r/77094 (owner: 10Siebrand) [18:59:56] (03PS5) 10Hashar: Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [19:00:14] (03CR) 10Hashar: [C: 032] "Thank you Frederico!" [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [19:01:58] (03CR) 10Hashar: "I am afraid we might want to keep the good old human readeable format for sometime. Though we could probably create a small CLI utility t" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [19:05:31] (03Merged) 10jenkins-bot: Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [19:07:55] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75346 (owner: 10Matmarex) [19:17:21] (03CR) 10Siebrand: [C: 032 V: 032] Explicitly support GENDER on communitytwitter-logged-in-as [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/76301 (owner: 10Nemo bis) [19:22:35] (03PS1) 10Hashar: describe the gate-and-submit pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77166 [19:23:23] (03CR) 10Hashar: [C: 032] describe the gate-and-submit pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77166 (owner: 10Hashar) [19:23:27] (03Merged) 10jenkins-bot: describe the gate-and-submit pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77166 (owner: 10Hashar) [19:31:30] (03CR) 10Demon: [C: 032] Escape forwad slashes in queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77150 (owner: 10Manybubbles) [19:31:32] (03Merged) 10jenkins-bot: Escape forwad slashes in queries. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77150 (owner: 10Manybubbles) [19:31:36] (03PS1) 10Hashar: more pipelines descriptions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77168 [19:31:58] (03CR) 10Hashar: [C: 032] more pipelines descriptions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77168 (owner: 10Hashar) [19:32:11] (03Merged) 10jenkins-bot: more pipelines descriptions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/77168 (owner: 10Hashar) [19:32:33] (03CR) 10Legoktm: "Eventually that will be possible. Right now the validation code (invalid titles, invalid site) are scattered in various places, making it " [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [19:39:47] (03PS3) 10Mollywhite: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 [19:40:45] (03CR) 10Swalling: "(1 comment)" [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/73160 (owner: 10Raimond Spekking) [19:41:37] (03PS1) 10tosfos: Code from wiki page BreadCrumbs2, oldid=691806 with whitespace fixes [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/77170 [19:44:07] (03PS2) 10Raimond Spekking: Add i18n file [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/73160 [19:47:14] (03CR) 10tosfos: [C: 032 V: 032] Code from wiki page BreadCrumbs2, oldid=691806 with whitespace fixes [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/77170 (owner: 10tosfos) [19:50:31] Tim-away: https://code.google.com/p/chromium/issues/detail?id=267059 [19:51:00] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [19:52:34] (03Abandoned) 10Umherirrender: Make list=allimages&aimime= working in miser mode [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [19:56:27] (03CR) 10Umherirrender: "I am not sure, if a rvprop=editnotices is a good idea." [core] - 10https://gerrit.wikimedia.org/r/74963 (owner: 10Umherirrender) [19:56:46] hello? [20:06:40] (03CR) 10Parent5446: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/77136 (owner: 10CSteipp) [20:08:14] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/77136 (owner: 10CSteipp) [20:11:50] (03CR) 10Parent5446: [C: 032] Add month-only date format. [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [20:13:18] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [20:14:00] (03PS1) 10Manybubbles: Skip redirects in forceSearchIndex run by id. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77196 [20:15:10] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [20:16:12] (03Merged) 10jenkins-bot: Add month-only date format. [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [20:16:32] O.o [20:16:33] That was quick [20:19:50] (03PS9) 10MarkTraceur: mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 [20:37:58] (03PS2) 10CSteipp: Implement OAuth user checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/77082 [20:46:37] (03PS1) 10Krinkle: doc: Clarify documentation for ParserOptions::getUserLangObj [core] - 10https://gerrit.wikimedia.org/r/77219 [20:46:58] (03PS1) 10Rachel99: WIP VE Headings test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/77220 [20:49:19] (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [21:00:50] (03PS1) 10tosfos: cleaned code, moved breadcrumbs out of contentSub, minor bugfixes [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/77221 [21:06:12] (03PS1) 10Anomie: Tag changes when OAuth is used [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77223 [21:09:20] grrrit-wm: is dead because gerrit is [21:12:33] can someone make a commit / comment so I can check if grrrit-wm needs restarting? [21:12:36] (03PS1) 10Mattflaschen: Bump GuidedTour for E3 deployment [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77226 [21:12:41] heh, apparently not \o/ [21:13:09] (03CR) 10tosfos: [C: 032 V: 032] cleaned code, moved breadcrumbs out of contentSub, minor bugfixes [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/77221 (owner: 10tosfos) [21:15:25] (03CR) 10Matmarex: "Actually, shouldn't this have release notes and possibly be documented somewhere on mw.org?" [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [21:15:59] (03CR) 10Spage: [C: 032] "the latest" [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77226 (owner: 10Mattflaschen) [21:19:23] (03Merged) 10jenkins-bot: Bump GuidedTour for E3 deployment [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77226 (owner: 10Mattflaschen) [21:22:11] (03CR) 10Parent5446: "Maybe, but I don't see the current formats documented anywhere anyway." [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [21:24:34] when requesting pages via the API one can control the # of images retunred with imlimit. but this returns imlimit images *overall*. so when the first article already has that many images no images for the other articles will be returned! [21:24:39] is there a way to tell the api that I want 5 images for *each* article I'm passing to the api? [21:24:41] (03PS1) 10Spage: Permit specifying a name for default actions [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 [21:24:44] if not, then I have to do 20 api requests instead of 2 when looking at 10 articles [21:27:02] (03CR) 10Mollywhite: "I'm a bit unfamiliar with where the documentation would go, but if someone points me in the right direction, I'm happy to do it." [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [21:30:29] mwalker: You around? [21:30:36] GorillaWarfare: yep yep [21:32:14] panzi: Sadly not [21:34:10] mwalker: If you look at BookManagerv2.hooks.php on line 399, you'll see it's getting the prev/next sections by looping through each section [21:34:18] mwalker: But some books have literally 40,000 sections [21:34:26] mwalker: Any thoughts on how to deal wiht that better? [21:34:32] looking [21:34:52] Sure [21:38:12] RoanKattouw: I see. thanks anyway. Such an API feature would also reduce load for wikimedia.org [21:39:26] GorillaWarfare: so two things come to mind -- first that this if you keep it this way could be cached [21:39:37] the second thing is; why is it unsuitable to use the list order given in the JSON? [21:39:50] that way it could be numerically indexed and you wouldn't have this problem [21:40:37] Use the list order? [21:41:05] the order in which they were listed in the raw file [21:42:49] you have an implicit ordering there which you can actually use as an index -- and if you wanted on page save; you could turn that into an explicit ordering which you can then pass down to JS [21:44:31] or... because I'm an idiot and now see what you're trying to do [21:44:37] this hook gets run for a specific page [21:44:55] so... find the page you're rendering for; and then use that implicit index to construct just those forward/backward links? [21:55:33] How would it know which page was which index? [21:57:36] GorillaWarfare: for more generic cases it's in_array; but in this case you can use array_walk() [21:58:02] or [22:00:09] hurm... that's not impressively efficient; your best bet might just be to make an array of index => section name on json page save [22:00:13] save that in cache [22:00:19] and then retrieve it [22:01:10] this is where I wish php had proper trees and tree searching [22:03:40] Wait, how is index => section name different from what it's doing now? [22:05:40] it's not; except for the bit where you can't search for a section name to find it's index [22:05:50] what you're doing right now is actually probably totally fine so long as you cache it [22:06:28] it's just that you dont want to do this operation for every page [22:06:33] Even for 40,000 sections? [22:06:39] Ohh; it is doing it for every page [22:06:43] And the navbars aren't currently cached [22:06:47] check [22:06:47] So it could be slooow [22:06:54] indeed! [22:07:22] Hmm... so how would we do this.. [22:07:30] Create each navbar at once and cache them sometime? [22:07:30] the smaller advantage of just having a simple lookup table without the rest of the metadata is that then you dont have to store all the metadata into memcache [22:07:56] well; pre-generate the metadata required for each navbar [22:09:27] but with 20k sections you're going to run into other problems -- like how do you even display that [22:09:53] Yeaaaah [22:10:05] When Raylton was talking about "big books", I don't think I quite envisioned the true scale [22:10:15] do they have subsections? [22:10:24] because then you could cache it sort of as a tree [22:12:10] We can't count on it [22:12:57] grrr [22:13:18] ok -- so we know we have some limited structured data here [22:13:48] it might make sense to put this into a database table and then it's persistent and queryable [22:13:53] Eek [22:14:05] That... doesn't sound simple [22:14:30] probably easier than you think; but it will force you to make some modifications to your algorithms [22:14:49] because you'll pull in the section ordering data from the database; and the rest of the book metadata from json [22:15:03] this might help http://mikehillyer.com/articles/managing-hierarchical-data-in-mysql/ [22:15:11] just for a concept [22:20:32] mwalker: Alrighty, thank you :) I'll probably come back with questions, but for now I need to go offline [22:21:08] kk [22:26:25] Is ^demon around? [22:35:00] (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [22:52:09] (03CR) 10Mattflaschen: [C: 04-1] "(3 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [23:00:14] (03PS1) 10CSteipp: Simplify handling of API POST requests [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/77254 [23:06:23] (03PS4) 10Shirayuki: Add full-stops & fix quotation marks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 [23:23:05] (03PS9) 10Cmcmahon: Add tests for CirrusSearch. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [23:29:41] (03CR) 10Krinkle: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:30:47] (03PS10) 10Krinkle: mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:30:55] marktraceur: are you OK with PS10 ? ^ [23:31:12] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:31:23] (03CR) 10Krinkle: "Adding release notes because it is a new feature. Though it was already mentioned in the typehint, I think that was a typo in confusion wi" [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:32:04] (03PS11) 10Krinkle: mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:32:35] (03CR) 10Krinkle: [C: 031] "Resolved merge conflict." [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:33:34] Krinkle: I'll check it [23:34:46] (03CR) 10MarkTraceur: [C: 031] "<3 Krinkle" [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:35:47] marktraceur: Do I detect favoritism? :O [23:36:05] Reedy: No, or yes but not for Krinkle [23:36:15] Just a rouse? [23:36:29] Besides, he is halping with code review, which is always worth a few hearts [23:38:44] (03CR) 10Krinkle: [C: 032] mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:38:56] Yaaay [23:39:02] (03PS1) 10Krinkle: mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 [23:40:02] YuviPanda: is your github<->gerrit bot running? [23:40:04] (03PS2) 10Krinkle: mediawiki.util: Optimise logic in addPortletLink [core] - 10https://gerrit.wikimedia.org/r/77256 [23:40:17] MatmaRex: for which repo? [23:40:21] core [23:40:21] https://github.com/wikimedia/mediawiki-core/pull/4 [23:40:42] core needs manual triggering for now [23:40:42] lol @ Zuul "Harmless jobs being run for untrusted users. " [23:40:44] let met rigger [23:40:54] https://integration.wikimedia.org/zuul/ [23:41:15] Looks like hashar added some description [23:41:16] on its way [23:41:29] (03Merged) 10jenkins-bot: mediawiki.util: Fix addPortletLink to allow jQuery objects [core] - 10https://gerrit.wikimedia.org/r/77075 (owner: 10MarkTraceur) [23:41:56] Krinkle: I would lurv it if that method returned a jQuery object but it seems silly to make a breaking change [23:42:06] indeed [23:42:20] Well [23:42:24] we can do that when we phase out mw.util and introduce mw.skin.addPortletLink [23:42:25] No, yeah, it would be breaking [23:42:31] fair 'nuff [23:42:38] which is an open bug in fact [23:42:39] (03PS1) 10Luis Villa: Update COPYING to match proposed new README [core] - 10https://gerrit.wikimedia.org/r/77257 (via SuchABot) [23:42:45] MatmaRex: ^ [23:42:49] thanks YuviPanda [23:43:41] (03CR) 10Cmcmahon: "sorry this is languishing, beta has been off this week." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75793 (owner: 10Manybubbles) [23:43:46] Aw, lvillaWMF, you have whitespace at the end of every line [23:44:12] :D [23:44:45] i'll amend [23:45:09] (03CR) 10Matmarex: "Luis submitted a corresponding change to COPYING: https://gerrit.wikimedia.org/r/#/c/77257/" [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [23:45:42] ori-l: I was going to make it a learning experience, but never mind [23:45:49] I'm in ur repos, churning ur codez [23:46:05] marktraceur: we should respect his time, i think [23:46:34] also, guy's got a sassy domain for his website. http://lu.is/. nice. [23:46:35] MatmaRex, Krenair: because i didn't want to delay things, i told luis to go ahead and submit the changes he thinks should be made, and that i would update or abandon my patch accordingly [23:46:48] ok [23:47:03] ori-l: we should probably merge both of these is they're okay [23:47:06] I think Elsie was interested in these changes [23:47:08] ori-l: Indeed, since he's saying in -staff that he's too busy to do it in a real editor :P [23:47:11] (03CR) 10Parent5446: "What clarification are we waiting for and when will we get it? Also, since when does the README file have any legal significance in softwa" [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [23:47:36] tyler's timing is impeccable, as usual [23:47:42] heh [23:47:44] "Also, since when does the README file have any legal significance in software?" [23:47:57] umm... I'm guessing since it had those notes about legal licensing stuff in it? [23:48:39] (03PS2) 10Matmarex: Update COPYING to match proposed new README [core] - 10https://gerrit.wikimedia.org/r/77257 (owner: 10SuchABot) [23:48:49] as for the clarification I mentioned, it was about how exactly to integrate those bits into the copying file (which currently is just the full text of GPLv2) [23:48:51] (03PS3) 10Matmarex: Update COPYING to match proposed new README [core] - 10https://gerrit.wikimedia.org/r/77257 (owner: 10SuchABot) [23:49:42] Oh, danke MatmaRex [23:50:11] I wonder if this is the sort of thing we should review, or if other legal folk are going to merge it [23:50:21] (03CR) 10Krinkle: [C: 04-1] "Avoid patching the change that isn't committed yet. Please bring this up on https://gerrit.wikimedia.org/r/#/c/76643 so that we don't remo" [core] - 10https://gerrit.wikimedia.org/r/77257 (owner: 10SuchABot) [23:50:21] I don't think legal can merge stuff? [23:50:37] man, if that gets merged that'll be the first GitHub based contribution that's merged on Gerrit [23:50:43] oh come on! -1. sigh [23:50:58] YuviPanda: What about your UW patch? [23:51:03] marktraceur: not to core. [23:51:10] ah, I should've mentioned that [23:51:12] Ah, see, there's the distinction [23:51:17] it's unlikely to get merged. If it did it would mean we allow merging the other first which will put the repo in a sortof illegal state. [23:51:18] EMISSING_DETAILS [23:51:26] YuviPanda: eh, currently it looks like it'll be squashed to the other one ;) [23:51:39] Aw. [23:51:41] MatmaRex: yeah, probably. and this will get abandoned [23:51:43] again! [23:51:45] * marktraceur pats YuviPanda [23:51:49] Krinkle: luis's patch could be merged first ;) [23:51:50] (the bot will autoclose the pull request) [23:51:57] I'd help, but, you know. GitHub. [23:52:16] (03CR) 10Krinkle: [C: 04-1] "The text removed is partially required for copyright purposes. Should be moved to COPYING or kept as-is." [core] - 10https://gerrit.wikimedia.org/r/76643 (owner: 10Ori.livneh) [23:52:21] marktraceur: I'm currently distracted by https://wikitech.wikimedia.org/wiki/User:Yuvipanda/Dynamic_http_routing, which is not github :) [23:52:28] Ha, here's a thought for the github<>gerrit bot. It can't sync commit message changes and amendments. [23:52:50] I suppose it could sync commit message changes if it has access to the core repo. Thoguh it can't amend the actual commit message, we don't use that. we use the PR message, which is editable [23:52:51] Krinkle: yeah, Gerrit -> GitHub can be only 'comments'. Hard to do code [23:52:56] is that currently synced YuviPanda? [23:53:00] (03CR) 10MZMcBride: "Trailing whitespace, "Mediawiki" instead of "MediaWiki", and inconsistent casing in headers." [core] - 10https://gerrit.wikimedia.org/r/77257 (owner: 10SuchABot) [23:53:09] Krinkle: the PR message is sync'd, yes. [23:53:14] great [23:53:16] though not on edit (yet), only when there's a next push on it [23:53:45] (03PS4) 10Kaldari: More accurate function descriptions [core] - 10https://gerrit.wikimedia.org/r/74575 [23:53:57] YuviPanda: Hm.. how does it juggle between the PR message being separate from commit on github, but being the same on gerrit? [23:54:35] Krinkle: it squashes all commits from PR into one commit, puts that on gerrit, and makes the commit message be same as PR message [23:54:41] it discards all commit messages [23:54:42] i suppose commit message is kept from gerrit -> github, and commit contents always overridden? [23:54:56] (03CR) 10Kaldari: [C: 032] More accurate function descriptions [core] - 10https://gerrit.wikimedia.org/r/74575 (owner: 10Kaldari) [23:54:58] gerrit -> github no changes are sync'd - only comments [23:55:12] YuviPanda: but you said it does use the new commit message from gerrit on push [23:55:16] github -> gerrit, currently code is sync'd. no comments. [23:55:24] Krinkle: ah, no. I meant the new commit message from *github*. [23:55:26] sorry, didn't notice [23:55:29] but yeah, I can add that! [23:55:31] ah, I see [23:55:39] (03PS1) 10Shirayuki: Fix group-* and grouppage-* message [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/77258 [23:55:40] so MatmaRex's edits to the commit message woudl be overridden [23:55:42] Hi lvillaWMF [23:55:45] hey [23:55:48] if someone pushes to that pull request [23:55:49] yes [23:55:50] i just wrapped the textr [23:55:56] I can close it as a precaution [23:56:09] (03PS1) 10Ori.livneh: Fix broken 'unless' condition for Exec['set mysql password'] [vagrant] - 10https://gerrit.wikimedia.org/r/77259 [23:57:00] (03CR) 10Ori.livneh: [C: 032] Fix broken 'unless' condition for Exec['set mysql password'] [vagrant] - 10https://gerrit.wikimedia.org/r/77259 (owner: 10Ori.livneh) [23:57:35] (03Merged) 10jenkins-bot: Fix broken 'unless' condition for Exec['set mysql password'] [vagrant] - 10https://gerrit.wikimedia.org/r/77259 (owner: 10Ori.livneh) [23:58:50] (03Merged) 10jenkins-bot: More accurate function descriptions [core] - 10https://gerrit.wikimedia.org/r/74575 (owner: 10Kaldari) [23:59:39] (03CR) 10Swalling: [C: 031] "Seems like a simple idea that'd be good for tour writers." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/77229 (owner: 10Spage)