[00:00:33] (03PS12) 10MarkTraceur: Add a 'feature' field type to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/75143 [00:05:08] (03PS15) 10MarkTraceur: Implement agora-style checkboxes experimentally [core] - 10https://gerrit.wikimedia.org/r/74662 [00:05:54] (03PS13) 10MarkTraceur: Add a 'feature' field type to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/75143 [00:24:37] (03PS3) 10Mollywhite: Bug 50762: Add variables to show/hide items in the navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76463 [00:25:50] (03CR) 10Mollywhite: [C: 032 V: 032] Bug 50762: Add variables to show/hide items in the navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76463 (owner: 10Mollywhite) [00:27:02] (03PS14) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [00:36:53] (03PS3) 10Shirayuki: Add full-stops & fix quotation marks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 [00:39:30] (03PS2) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [00:45:38] (03PS1) 10Shirayuki: Update comments for grep [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76868 [00:48:55] (03CR) 10Mwjames: [C: 04-1] "Adoption needed in order to use the HooksLoader." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/73551 (owner: 10Mwjames) [00:49:56] (03CR) 10Mwjames: [C: 04-1] "If I have time I have to re-visit this change." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/72891 (owner: 10Mwjames) [01:01:04] (03CR) 10Mwalker: [C: 032 V: 032] amazon-recurring and value change form support [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/62562 (owner: 10Adamw) [01:02:40] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [01:15:48] (03PS3) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [01:25:01] (03PS2) 10MarkTraceur: WIP Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [01:28:58] * ori-l pokes grrrit-wm [01:33:35] (03PS4) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [01:33:36] (03PS3) 10MarkTraceur: Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [01:37:20] (03PS1) 10Mwjames: \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76872 [01:39:22] (03CR) 10Mwjames: [C: 032] \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76872 (owner: 10Mwjames) [01:40:43] (03Merged) 10jenkins-bot: \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76872 (owner: 10Mwjames) [01:46:44] (03PS15) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [02:03:21] (03PS1) 10Bsitu: (bug 52298) The email should be set in the user's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 [02:05:11] (03PS1) 10Mwjames: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76875 [02:05:47] (03PS2) 10Mwjames: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76875 [02:07:01] (03PS1) 10Ori.livneh: Add a usage note to 'CanonicalNamespaces' hook docs [core] - 10https://gerrit.wikimedia.org/r/76876 [02:07:10] (03PS2) 10Bsitu: (bug 52298) The email should be set in the user's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 [02:07:25] ^ yurik [02:08:19] ori-l, which? :) [02:08:43] anyone knows what we do if we have a spammer in a channel and all the ops are away? [02:08:55] i forgot the name of the channel we're supposed to go to [02:08:57] (03CR) 10Mwjames: [C: 032] Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76875 (owner: 10Mwjames) [02:10:14] the usage note [02:10:16] (03Merged) 10jenkins-bot: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76875 (owner: 10Mwjames) [02:15:41] (03CR) 10Yurik: [C: 032] Add a usage note to 'CanonicalNamespaces' hook docs [core] - 10https://gerrit.wikimedia.org/r/76876 (owner: 10Ori.livneh) [02:18:08] ori-l, will finish reviewing tomorrow, sleepy time [02:18:10] (03Merged) 10jenkins-bot: Add a usage note to 'CanonicalNamespaces' hook docs [core] - 10https://gerrit.wikimedia.org/r/76876 (owner: 10Ori.livneh) [02:20:09] (03PS16) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [02:26:22] (03CR) 10Mwjames: "Now tests are also passed on MW 1.19." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 (owner: 10Mwjames) [02:26:52] (03PS1) 10Nilesh: Servlet JSON output is now done using GSON library [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 [02:33:12] (03PS1) 10Nilesh: Fixed tests to work properly with changed WebClientRecommender [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 [02:45:49] (03PS3) 10Alex Monk: (bug 52298) The email should be set in the user's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 (owner: 10Bsitu) [02:49:01] (03PS4) 10Alex Monk: The email should be set in the recipient's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 (owner: 10Bsitu) [02:51:46] (03PS2) 10Mollywhite: Create contents page when JSON block is saved [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/75152 [03:08:37] (03PS1) 10Mollywhite: Add globals that were removed in rebase. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76879 [03:08:57] (03CR) 10Mollywhite: [C: 032 V: 032] Add globals that were removed in rebase. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76879 (owner: 10Mollywhite) [03:10:54] (03Abandoned) 10Mollywhite: Create contents page when JSON block is saved [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/75152 (owner: 10Mollywhite) [03:25:11] (03PS1) 10Mollywhite: Minor capitalization issue. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76880 [03:25:30] (03CR) 10Mollywhite: [C: 032 V: 032] Minor capitalization issue. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76880 (owner: 10Mollywhite) [03:50:02] (03CR) 10Alex Monk: [C: 032] The email should be sent in the recipient's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 (owner: 10Bsitu) [03:50:07] (03Merged) 10jenkins-bot: The email should be sent in the recipient's language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76874 (owner: 10Bsitu) [04:17:59] Elsie: Have time to do some code review? [04:27:54] Catchable fatal error: Argument 1 passed to UDPRCFeedEngine::send() must be an instance of string, string given [04:27:55] oh php [04:30:02] haha [04:30:13] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [04:30:24] Turns out you can't type hint strings [04:30:31] Only arrays and objects [04:30:36] still, that error message [04:31:10] (although actually not being able to type hint string/integer etc. is still pretty silly itself) [04:33:05] (03PS1) 10Demon: Simplify return in XCFHandler::getXCFMetaData(), no need for assert() [core] - 10https://gerrit.wikimedia.org/r/76881 [04:35:57] (03CR) 10Santhosh: [C: 04-1] "The Junicode regular font has lot of private area glyphs making the font large in size- 1.4 MB. That much big sized font is generally not " [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 (owner: 10KartikMistry) [04:37:47] Krenair: wanna review https://gerrit.wikimedia.org/r/#/c/76671/ ? [04:38:08] maybe later [04:38:19] ok [04:38:25] oh it's that [04:38:29] why did you want this id? [04:38:57] Elsie wanted to we could select stuff with CSS. See https://gerrit.wikimedia.org/r/#/c/76647/ [04:39:02] also it's not equal to the message key when you prepend 'mw-' onto it [04:39:32] should mention that in the commit message [04:39:39] Ah, right [04:40:12] grrrit-wm? [04:40:17] (03PS3) 10Legoktm: For rows added by the SpecialStatsAddExtra hook, add an HTML id equal to the message key [core] - 10https://gerrit.wikimedia.org/r/76671 [04:41:39] legoktm, should mention why it's wanted as well [04:41:54] ok [04:43:26] (03CR) 10Alex Monk: "(14 comments)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [04:43:40] (03PS4) 10Legoktm: For rows added by the SpecialStatsAddExtra hook, add an HTML id of "mw-" plus the message key Change-Id: Ib93e05d1ef89666ddcb132b5eb4b620b160b5565 [core] - 10https://gerrit.wikimedia.org/r/76671 [04:45:00] (03PS14) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [04:45:43] Krenair: so, I'm reading https://www.mediawiki.org/wiki/Extension:CentralAuth for the first time [04:45:54] oops, pushed code to gerrit with my debugging calls left in [04:46:25] ori-l: ok [04:46:32] (03PS15) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [04:47:39] does central-auth.sql do everything? [04:47:59] schema-changes-wise [04:48:10] I suppose I could just read the code [04:48:39] that might be a good idea [04:49:15] (03CR) 10Alex Monk: [C: 032] For rows added by the SpecialStatsAddExtra hook, add an HTML id of "mw-" plus the message key [core] - 10https://gerrit.wikimedia.org/r/76671 (owner: 10Legoktm) [04:49:29] one doesn't simply read centralauth [04:49:36] Krenair: thanks! [04:49:41] came for the sql, stayed for 'evil-plans.txt' [04:49:59] oshi he's on to us [04:50:11] <^demon> ori-l: We should really use that naming convention in other places. [04:50:48] +2! [04:51:43] ori-l, it doesn't do everything we need to in the DB... I mentioned in my comment on BZ that we might want to insert into the global_group_permissions table ourselves [04:51:48] (03Merged) 10jenkins-bot: For rows added by the SpecialStatsAddExtra hook, add an HTML id of "mw-" plus the message key [core] - 10https://gerrit.wikimedia.org/r/76671 (owner: 10Legoktm) [04:51:55] but it should set up the schema of the CA DB, yeah [04:52:18] (03PS1) 10PleaseStand: Generate Utf8Case.ser directly from UnicodeData.txt [core] - 10https://gerrit.wikimedia.org/r/76882 [04:54:02] we should just burn central auth and go to a shared table! [04:55:33] <^demon> Oh man. [04:55:40] <^demon> I always wanted to clean up that normalization code. [04:55:43] <^demon> <3 PleaseStand [04:56:36] <^demon> Step 2 is moving the test junk out of there and into phpunit [04:58:44] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [05:00:38] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [05:00:59] ^demon: oh yeah, i thought you shut down svn? cuz siebrand via twn was able to commit today [05:01:44] <^demon> Hmm. [05:01:57] (03PS2) 10PleaseStand: Generate Utf8Case.ser directly from UnicodeData.txt [core] - 10https://gerrit.wikimedia.org/r/76882 [05:02:06] [10:56:06 AM] [pywikipedia] siebrand * : [11781] branches/rewrite/scripts/i18n - http://www.mediawiki.org/wiki/Special:Code/pywikipedia/11781 - Localisation updates from http://translatewiki.net. [05:04:39] <^demon> legoktm: Fixed. [05:04:42] <^demon> I see what I missed. [05:05:20] cool :) [05:06:54] <^demon> Thanks for letting me know. [05:07:01] <^demon> That server is an unpuppetized mess. [05:07:34] (03PS9) 10Parent5446: Change secure login to use a user preference; add secure groups option. [core] - 10https://gerrit.wikimedia.org/r/47089 [05:08:29] it's a bit annoying that the mysqladmin command line tool lets you create databases but not users [05:10:19] (03CR) 10jenkins-bot: [V: 04-1] Change secure login to use a user preference; add secure groups option. [core] - 10https://gerrit.wikimedia.org/r/47089 (owner: 10Parent5446) [05:13:53] (03CR) 10Tim Starling: [C: 032] Add index to securepoll_options.op_election [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/62857 (owner: 10Reedy) [05:13:56] (03Merged) 10jenkins-bot: Add index to securepoll_options.op_election [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/62857 (owner: 10Reedy) [05:15:24] (03PS10) 10Parent5446: Change secure login to use a user preference; add secure groups option. [core] - 10https://gerrit.wikimedia.org/r/47089 [05:23:02] (03CR) 10Demon: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [05:23:19] (03CR) 10Demon: "(Crap I totally didn't mean to +2, wrong button)" [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [05:23:22] (03PS1) 10Mollywhite: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 [05:23:34] (03CR) 10jenkins-bot: [V: 04-1] Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [05:26:30] (03PS2) 10Mollywhite: Bug 50989: Add view frontend to the JSON page. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 [05:41:37] (03PS2) 10KartikMistry: Fonts for angwiki [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76689 [07:10:43] (03PS1) 10Ori.livneh: Add 'mysql::sql', 'mysql::user' & 'mysql::db' types [vagrant] - 10https://gerrit.wikimedia.org/r/76886 [07:12:39] (03PS2) 10Ori.livneh: Add 'mysql::sql', 'mysql::user' & 'mysql::db' types [vagrant] - 10https://gerrit.wikimedia.org/r/76886 [07:12:55] (03CR) 10Ori.livneh: [C: 032] Add 'mysql::sql', 'mysql::user' & 'mysql::db' types [vagrant] - 10https://gerrit.wikimedia.org/r/76886 (owner: 10Ori.livneh) [07:12:57] (03Merged) 10jenkins-bot: Add 'mysql::sql', 'mysql::user' & 'mysql::db' types [vagrant] - 10https://gerrit.wikimedia.org/r/76886 (owner: 10Ori.livneh) [07:54:45] ori-l: re: replacing IRC RC Feeds with something saner, thoughts on redis pubsub exposed to the internet vs 0mq pubsub exposed to the internet? [07:54:49] (readonly redis, of course) [07:56:08] I have to review your patches, still. Have you seen vvv / Krenair's patch https://gerrit.wikimedia.org/r/#/c/52922/ ? [07:56:42] I've heard of it, but havne't looked into it closley. When I read the wikitech-l discussion around it it seemed to use its own pubsub mechanism of sorts, which I wasn't a fan of [07:56:46] let me look through it again [07:57:05] Not really; it just emits JSON via UDP [07:57:11] ah, okay. [07:57:15] so something on the other side still needs writing [07:57:16] ok [07:57:23] but the crucial thing is: it abstracts the notion of dispatcher and formatter [07:57:37] and retains support for the current IRC feed format [07:57:54] so I think once it's merged we should add a redis pubsub dispatcher on top [07:58:09] mmm right [07:58:15] * Yuvi|NoPowerGrrr reads some more [07:58:43] redis would be easier to implement because the redis PHP extension is already deployed everywhere because we depend on it for the job queue and other things [07:58:54] yeah, I think so too [07:59:01] 0MQ requires deploying the ZeroMQ extension [07:59:04] plus I don't think our throughput requirements are *that* high [07:59:29] plus we can setup redis slaves if we need more throughput and load balance via something simple (dns?) [07:59:40] I don't even know that 0MQ would be faster than redis [08:00:03] 0MQ makes it easy to connect network segments and represent different messaging patterns [08:00:23] easier, I mean. [08:00:42] there were a couple of benchmarks I was looking at y'day, but I think with proper message batching on redis' end it wasn't that much of a difference [08:00:42] (http://blog.jupo.org/2013/02/23/a-tale-of-two-queues/) [08:01:06] but no, I was preferring redis too anyway :) [08:03:18] I'd like to find some way to introduce 0MQ to the PHP stack, but that's a different battle I guess [08:03:34] I guess we should be able to eventually kill UDP in favor of 0mq [08:03:51] I remember Tim mentioning it a few times at several places, so I am guessing there should be support for that [08:04:28] so maybe we should try 0MQ first? :) [08:04:39] I think redis will do fine for this use case, but it's already installed [08:04:58] and 0MQ is like redis in that it's a library that will enable a whole range of cool things [08:05:15] yeah [08:05:15] but it needs a single compelling use-case to drive it, rather than 'range of cool things' [08:05:32] with redis it was cross-DC replication, IIRC [08:05:38] which vanilla memcached couldn't do [08:05:41] one step at a time, I'll be happy if we can just get redis on the 'edge' nodes for this [08:05:41] aah [08:05:53] ori-l: for this, we'll need new redis servers that are exposed to the internet, right? [08:06:39] no, I don't think we'd do that [08:06:57] seems risky [08:07:08] maybe a thin redis->websockets bridge [08:07:47] see, this is why I was thinking 0mq, since I don't know how easy it is to consume websockets from non-browser-thingies [08:08:28] ori-l: also why is exposing Redis risky? We'll make it completely, readonly, disable all commands except for the sub related ones... [08:09:21] dunno, maybe it'd be fine. I intuitively think of it as an internal service, so it feels vulnerable somehow to expose it, but maybe the worry is unfounded. [08:09:40] I do think it's important that the stream is consumable by webapps, so websockets are probably essential. [08:10:20] ori-l: well, if we have a redis pubsub that's available for people, they can write whatever they want. I'll probably write a store/queue thing for toollabs, for example. [08:10:27] ori-l: also websockets directly - woulnd't we run into at least *some* CORS issues? [08:10:58] Access-Control-Allow-Origin: * [08:11:40] oh, nevermind. [08:11:56] no, we won't run into CORS issues, because websockets isn't HTTP, and it does allow cross-domain stuff [08:12:22] https://en.wikipedia.org/wiki/WebSockets#WebSocket_protocol_handshake [08:13:28] ori-l: ah, right. but that'll need someone to write it, and that'll probably have to be twisted/tornado/nodejs. [08:13:59] i wrote two redis->websockets bridges a while back, one in node and one in gevent [08:14:07] the node one is like 20 lines [08:14:14] just glue [08:14:25] let me see if i can dig it up [08:14:43] ori-l: I agree we should have websocket outs, but we should also have direct redis outs [08:15:04] (03CR) 10Nikerabbit: "I'm running "make safe" for unit tests in core with plenty of extensions enabled." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76703 (owner: 10Nikerabbit) [08:16:12] Yuvi|NoPowerGrrr: node: https://dpaste.de/aKNKy/ [08:17:08] heh :D [08:17:19] ori-l: but question is can we get that deployed? in a public facing way? :) [08:17:49] ori-l: I was thinking that what we should do is to go mediawiki -> central place, then central place -> redis pubsub, then central place -> IRC, etc [08:18:16] so we can get rid of IRC code from core [08:18:17] why have something between mediawiki and redis? [08:18:30] aren't we already sending UDP packets somewhere? [08:18:31] redis is ideally suited for being that central place [08:18:46] sure, central place can be redis. [08:18:48] well, yeah, but i'm proposing that we just add direct support to writing to redis from core [08:18:54] I'd like that :) [08:18:55] since we already load the php driver [08:19:13] we could have a short interim phase in which something translates udp to redis [08:19:31] 'python-django-websocket' is in apt [08:19:39] hmm, django [08:19:58] ditto 'python-mod-pywebsocket', whatever that is [08:20:20] so I suppose we need to setup the current patch in labs somewhere. [08:20:40] python-redis is in apt too [08:20:45] and replicate the current setup [08:20:49] so the ingredients for a python-based redis->websocket bridge are packaged [08:21:14] yeah, but I still think we should expose raw redis pubsub too [08:21:28] it's worth a try, sure [08:22:08] ori-l: that'll need redoing the current patch, I think? [08:22:10] if we go direct to redis [08:22:22] (03PS1) 10Hashar: puppet-doc generation to the dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/76888 [08:22:31] ori-l: also, thoughts on connection overhead? minimal, I suppose... [08:22:36] (03CR) 10Hashar: [C: 032] puppet-doc generation to the dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/76888 (owner: 10Hashar) [08:22:37] (03Merged) 10jenkins-bot: puppet-doc generation to the dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/76888 (owner: 10Hashar) [08:22:38] nah, we'd just add a direct-to-redis dispatch [08:22:47] and keep the UDP one but just not use it [08:22:53] dead code! [08:23:23] have you looked at aaron's redis connection pool thing? [08:23:39] it's nice, reliable, carefully-wrought stuff [08:23:46] oooo [08:23:49] nicee! [08:24:32] ori-l: okay, I'm going to setup that patch on vagrant, see how things go. [08:24:45] ori-l: can you look at those 3 python patches? :) only one of them is 0mq centric tho [08:24:54] 0mq is probably overkill for what I'm doing, but meh. [08:24:56] (03PS1) 10Hashar: tweak integration-docroot-deploy success message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76889 [08:25:06] (03CR) 10Hashar: [C: 032] tweak integration-docroot-deploy success message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76889 (owner: 10Hashar) [08:25:09] ok [08:25:13] hi hashar, btw [08:25:16] (03Merged) 10jenkins-bot: tweak integration-docroot-deploy success message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76889 (owner: 10Hashar) [08:25:30] hello ori [08:25:38] so when are you relocating in Europe ? :D [08:26:14] i need to brush up on my languages first i think [08:26:52] yeah, I'd die on your sleep schedule, ori-l [08:27:02] ori-l: don't you already speak a dozen languages? [08:27:10] no, that's my wife [08:27:14] i speak hebrew and english fluently [08:27:31] such a pity none of those languages are spoken in France [08:27:32] and i can trick people into thinking i know german by using by very limited vocabulary in a confident manner [08:27:54] do you speak yiddish as well ? [08:28:00] * Yuvi|NoPowerGrrr took two years of french in high school and remembers absolutely nothing [08:28:14] Yuvi|NoPowerGrrr: je peux t'apprendre [08:28:29] best thing in France: we have no power cut :D [08:28:36] hashar: a tiny bit, but almost by accident [08:28:53] hashar: I understood 'je' :) [08:29:38] Yuvi|NoPowerGrrr: translation is "I can teach you" [08:29:41] i was really intimidated by french people :P [08:29:41] ah :D [08:29:55] if you speak a little bit of german, german people are like "awesome! you speak german!" [08:29:59] je -> I | peux -> can | apprendre -> teach | t' => you [08:30:00] for some reason remembering meeting hashar makes me want to head out for a smoke :D [08:30:04] but french people are like, "oh my god, you are destroying our language" [08:30:37] well, probably that's just my imagination [08:30:40] foux du fafa! [08:30:41] that is probably because our whole education system is geared toward creating an elit [08:30:41] elite [08:30:55] 'we write only in haskell! we are elite!' [08:31:00] most french don't even try to speak english because they are too afraid to make mistake and look dumb [08:31:14] so they wont even try and usually will tell you "Sorry I don't speak english" (in english ahha) [08:31:51] * Yuvi|NoPowerGrrr pokes ori-l about patchsets  [08:32:04] and lot of french are jerks when it comes to english people. That must have its root with all the war France and England conducted over a few centuries [08:35:01] d'accord, i will review [08:39:21] (03PS2) 10Nikerabbit: Use getPageLanguage() to for source language in WikiPageMessageGroup [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69661 (owner: 10Mboisson) [08:41:14] (03PS3) 10Nikerabbit: Use getPageLanguage() to for source language in WikiPageMessageGroup [extensions/Translate] - 10https://gerrit.wikimedia.org/r/69661 (owner: 10Mboisson) [08:50:09] woooo, GPRS speeds [08:50:12] * Yuvi|NoPowerGrrr stabs self repeatedly [08:55:00] Yuvi|NoPowerGrrr: https://gerrit.wikimedia.org/r/#/c/76764/ [08:56:14] (03PS1) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [08:57:44] ori-l: ty! [08:58:15] np, i owe teammates some CR so i'll defer the other ones for now [08:59:07] :) this was the one I majorly wanted, so it is ok [09:23:15] Yuvi|NoPowerGrrr: awww [09:23:21] :( [09:23:32] Nikerabbit: still no power, btw. I hope it comes back before our meeting tonight [09:23:41] Yuvi|NoPowerGrrr: me too [09:23:44] I've like an hour of battery left [09:24:00] Nikerabbit: do we both need to file mid term reports? or just you? [09:24:10] Yuvi|NoPowerGrrr: at least me [09:24:18] I'm trying to open the project in android studio [09:25:00] managed? [09:25:26] Yuvi|NoPowerGrrr: not quite... I'm trying to use open and import with varios options but not seeing the files yet in the project [09:30:51] Yuvi|NoPowerGrrr: I think I succeeded now [09:37:51] (03PS1) 10Ori.livneh: Some small touch-ups to plug-in code [vagrant] - 10https://gerrit.wikimedia.org/r/76892 [09:42:08] (03CR) 10Tpt: "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 (owner: 10Rtdwivedi) [09:48:48] (03CR) 10Tpt: [C: 04-1] "(3 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [10:03:58] (03PS3) 10Ori.livneh: Move guiders submodule into this repository (GuidedTour) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76688 (owner: 10Mattflaschen) [10:04:10] (03CR) 10Ori.livneh: [C: 032] Move guiders submodule into this repository (GuidedTour) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76688 (owner: 10Mattflaschen) [10:04:38] (03Merged) 10jenkins-bot: Move guiders submodule into this repository (GuidedTour) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76688 (owner: 10Mattflaschen) [10:05:36] (03PS1) 10Daniel Kinzler: Fix compatibility with MW 1.21 [extensions/News] - 10https://gerrit.wikimedia.org/r/76893 [10:06:18] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "self-approving compat fix" [extensions/News] - 10https://gerrit.wikimedia.org/r/76893 (owner: 10Daniel Kinzler) [10:14:55] (03PS2) 10Nikerabbit: Log login-click event [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73950 [10:26:43] (03PS1) 10Pastakhov: fix minor bug with nowiki tag [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/76894 [10:28:08] (03CR) 10Pastakhov: [C: 032 V: 032] fix minor bug with nowiki tag [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/76894 (owner: 10Pastakhov) [10:38:24] (03PS3) 10Daniel Kinzler: (bug 51621) Make SBL aware of ContentHandler. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/75867 [10:47:49] (03PS1) 10Pastakhov: fix minor bug with nowiki tag [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/76896 [10:49:11] (03CR) 10Pastakhov: [C: 032 V: 032] fix minor bug with nowiki tag [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/76896 (owner: 10Pastakhov) [10:51:41] (03Abandoned) 10Pastakhov: fix minor bug with nowiki tag [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/76894 (owner: 10Pastakhov) [10:53:03] (03PS1) 10Pastakhov: fix minor bug with nowiki tag [extensions/MagicNoCache] (REL1_21) - 10https://gerrit.wikimedia.org/r/76898 [10:53:38] (03CR) 10Pastakhov: [C: 032 V: 032] fix minor bug with nowiki tag [extensions/MagicNoCache] (REL1_21) - 10https://gerrit.wikimedia.org/r/76898 (owner: 10Pastakhov) [10:54:48] (03PS1) 10Daniel Kinzler: Fix missing default blacklist. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/76899 [10:57:19] looks like SpamBlacklist came without a default blacklist since january 2012... ---^ [11:11:29] (03PS1) 10Hashar: switch beta autoupdater to use the python version [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76901 [11:11:41] (03CR) 10Hashar: [C: 032] switch beta autoupdater to use the python version [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76901 (owner: 10Hashar) [11:12:59] (03PS1) 10Hashar: gate-and-submit for JJB config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76902 [11:13:06] (03CR) 10jenkins-bot: [V: 04-1] gate-and-submit for JJB config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76902 (owner: 10Hashar) [11:13:39] (03PS2) 10Hashar: gate-and-submit for JJB config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76902 [11:14:12] (03CR) 10Hashar: [C: 032] gate-and-submit for JJB config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76902 (owner: 10Hashar) [11:14:26] (03Merged) 10jenkins-bot: gate-and-submit for JJB config [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76902 (owner: 10Hashar) [11:14:49] (03PS1) 10Raimond Spekking: Add special page to the media group of Special:Specialpages [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76903 [11:17:05] (03PS1) 10Raimond Spekking: Fix extension name in header [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/76904 [11:17:56] (03CR) 10Raimond Spekking: [C: 032] "Trivial, self merging" [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/76904 (owner: 10Raimond Spekking) [11:18:15] (03PS4) 10Rillke: Make Special:AggregateGroups using jquery.chosen [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 [11:18:34] (03CR) 10Raimond Spekking: [V: 032] Fix extension name in header [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/76904 (owner: 10Raimond Spekking) [11:19:22] (03CR) 10Rillke: "Triggering the plugIn's change handler now." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [11:19:53] (03CR) 10Rillke: "(3 comments)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [11:22:20] (03CR) 10Rillke: "Please mention whether you are inclined to merge this generally; if so I will run some tests on slow machines and older browsers." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [11:35:48] (03PS3) 10Nikerabbit: Log login-click event [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73950 [12:02:14] (03CR) 10Nikerabbit: "There aren't any fundamental blockers for merging this." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76503 (owner: 10Rillke) [12:16:08] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [12:18:07] (03PS2) 10Jeroen De Dauw: Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76747 [12:26:49] (03PS1) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [12:35:21] (03PS1) 10Jeroen De Dauw: Fix method call [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76910 [12:37:13] (03PS1) 10Nikerabbit: Unify @license tags where possible [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76911 [13:00:36] (03PS2) 10Rtdwivedi: Removed JavaScript which is to be rewritten. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76761 [13:00:38] (03PS20) 10Rtdwivedi: Addition of code that will be used for setting up of editing system in PHP instead of JS. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 [13:00:39] (03PS2) 10Rtdwivedi: Added preliminary model of ViewProofreadPage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [13:00:40] (03PS10) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [13:00:41] (03PS18) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [13:13:57] (03CR) 10Hashar: "Changing the default colormap has been filled upstream: https://issues.jenkins-ci.org/browse/JENKINS-19018" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71805 (owner: 10Hashar) [13:13:58] (03Abandoned) 10Hashar: set ansicolor colormap to vga [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71805 (owner: 10Hashar) [13:18:48] (03CR) 10Mwjames: [C: 032] "Good call, I did wrote a test yet since it is not used yet, so it would have eventually turned up in the test." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76910 (owner: 10Jeroen De Dauw) [13:19:05] (03CR) 10Mwjames: "I mean I didn't wrote a test ..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76910 (owner: 10Jeroen De Dauw) [13:20:08] (03Merged) 10jenkins-bot: Fix method call [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76910 (owner: 10Jeroen De Dauw) [13:25:58] (03CR) 10Mwjames: [C: 032] Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76747 (owner: 10Jeroen De Dauw) [13:26:10] (03PS1) 10Jack Phoenix: PollNY: even better i18n, as per Nikerabbit's CR. [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76914 [13:26:41] (03CR) 10Jack Phoenix: [C: 032 V: 032] PollNY: even better i18n, as per Nikerabbit's CR. [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76914 (owner: 10Jack Phoenix) [13:27:25] (03Merged) 10jenkins-bot: Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76747 (owner: 10Jeroen De Dauw) [13:27:46] (03CR) 10Jack Phoenix: "(1 comment)" [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76611 (owner: 10Jack Phoenix) [13:40:34] (03CR) 10Daniel Kinzler: [V: 04-1] "[ERROR] Failed to execute goal on project myrrix-web: Could not resolve dependencies for project org.wikimedia.wikibase:myrrix-web:war:0.1" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [13:46:05] (03PS31) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [13:46:05] (03PS32) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [13:46:06] (03CR) 10Daniel Kinzler: [V: 04-1] "Trying to test this, I get the following error message:" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 (owner: 10Nilesh) [13:46:07] (03PS1) 10Jack Phoenix: QuizGame: swap i18n message prefix to quizgame- per request. [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76916 [13:46:08] (03CR) 10Jack Phoenix: [C: 032 V: 032] QuizGame: swap i18n message prefix to quizgame- per request. [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76916 (owner: 10Jack Phoenix) [13:47:18] (03PS39) 10Wikinaut: SpecialVersion: Add last local update timestamp for core and extensions [core] - 10https://gerrit.wikimedia.org/r/59373 [13:47:21] (03CR) 10Daniel Kinzler: "On a second look, this does seem to be a proper compilation error, maven is just complaining on top of that. Here's what looks relevant:" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 (owner: 10Nilesh) [13:48:48] Hi, can a bugzilla logged in user non-admin check whether this URS is accessible, pease? https://bugzilla.wikimedia.org/chart.cgi?category=Parsoid&subcategory=-All-&name=1139&label0=RESOLVED&line0=1139&datefrom=01-10-2010&dateto=01-08-2013&action-wrap=Chart+This+List [13:49:09] qgil: Works ;) [13:49:14] thanks hoo! [13:49:32] hoo you no bugzilla admin, right? [13:49:39] Sadly not, np [13:49:41] * no [13:49:48] good, thank you [13:50:42] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 10Hoo man) [13:50:43] (03CR) 10Yaron Koren: [C: 032 V: 032] Small improvements to syntax and comments [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/76724 (owner: 10Yaron Koren) [13:52:17] (03CR) 10Yaron Koren: [C: 032 V: 031] Modified Special:CreateForm for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/75343 (owner: 10Himeshi) [13:52:20] (03Merged) 10jenkins-bot: Modified Special:CreateForm for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/75343 (owner: 10Himeshi) [13:52:22] (03CR) 10Jack Phoenix: "I've swapped the message prefix per your request to quizgame- in Change-Id: Iaf03344246aea41e520c3913de186039ae70b913" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76219 (owner: 10Jack Phoenix) [13:59:08] (03PS1) 10Mwjames: Split interfaces [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [14:02:26] (03CR) 10Mwjames: "If not utilities, where should it go?" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 (owner: 10Mwjames) [14:07:23] (03PS6) 10Hashar: $wgHTCPMulticastRouting rename + multi hosts support [core] - 10https://gerrit.wikimedia.org/r/71597 [14:07:30] (03PS33) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [14:07:56] (03CR) 10Anomie: "No, didn't bother filing a bug. The problem is that centralauth_Session (on all wikis, but particularly loginwiki) expires at the end of t" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76738 (owner: 10Anomie) [14:08:31] (03CR) 10Hashar: [C: 032] "Lets land this in and configure beta." [core] - 10https://gerrit.wikimedia.org/r/71597 (owner: 10Hashar) [14:10:39] (03PS7) 10Rachel99: Internal Link Scenario [qa/browsertests] - 10https://gerrit.wikimedia.org/r/73753 [14:10:43] (03PS34) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [14:12:06] (03Merged) 10jenkins-bot: $wgHTCPMulticastRouting rename + multi hosts support [core] - 10https://gerrit.wikimedia.org/r/71597 (owner: 10Hashar) [14:17:38] (03PS35) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [14:20:54] (03PS36) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [14:23:15] (03PS2) 10Mwjames: Split interfaces [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [14:25:07] (03PS17) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [14:25:41] (03CR) 10Mwjames: "Eliminate GPL header" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 (owner: 10Mwjames) [14:25:42] (03CR) 10Wikinaut: [C: 031 V: 031] "Ryan, pls. have a look. I tested thoroughly. http://openid-wiki.instance-proxy.wmflabs.org/wiki/ runs this code now." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [14:53:20] (03CR) 10Tpt: [C: 032] "Looks pretty nice" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 (owner: 10Rtdwivedi) [14:53:32] (03Merged) 10jenkins-bot: Addition of code that will be used for setting up of editing system in PHP instead of JS. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 (owner: 10Rtdwivedi) [14:59:12] (03CR) 10Tpt: [C: 04-1] "See patch set 17 for comments" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [15:00:27] (03PS3) 10Mwjames: Split interfaces [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [15:04:20] (03PS4) 10Mwjames: Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76917 [15:07:59] (03PS3) 10Matthias Mullie: Split the code to generate a proper URL/link from setTitleLink() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/74617 [15:10:42] (03PS1) 10Matthias Mullie: If there's a fragment, it's probably important enough to include it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76923 [15:13:38] (03PS1) 10Mwjames: Update Aliases.php [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76925 [15:14:16] (03CR) 10Jeroen De Dauw: [C: 032] Update Aliases.php [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76925 (owner: 10Mwjames) [15:14:28] (03PS1) 10Jqnatividad: added urldecode support when parsing name to GeoSearch API. This allows using spaces (%20), underscores (%5F) and other special characters when specifying the name extra parameter. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 [15:16:10] (03Merged) 10jenkins-bot: Update Aliases.php [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76925 (owner: 10Mwjames) [15:20:45] anomie: Do you have AbuseFilter installed for testing? [15:21:00] hoo: It's not like it's hard too install :p [15:21:13] Reedy: But maybe he's to lazy to do it :P [15:22:03] hoo: Yes, although I don't know the ins and outs of the codebase well enough to make sure I hit the necessary code paths for big things. And yes, I need to get around to testing that one patch. [15:22:04] echo "require_once(\"$IP/extensions/AbuseFilter/AbuseFilter.php\");" >> /var/www/wiki/LocalSettings.php && php /var/www/wiki/maintenance/update.php [15:23:02] anomie: I just had something weird locally... the filter always warned me, even after the 1st attempt... then I logged in and out and it worked :/ [15:23:20] With the API hook and the patch [15:26:13] (03PS11) 10Hoo man: Make APIEditBeforeSave give the whole revision [core] - 10https://gerrit.wikimedia.org/r/76082 [15:28:57] Reedy: anomie: hey there :] I got a tiny change to mctest.php output for you two https://gerrit.wikimedia.org/r/76909 [15:29:21] and going to deploy "set some paths to use $wmfHostnames 'bits' and 'test'" https://gerrit.wikimedia.org/r/#/c/71774/ [15:29:54] hashar: what is this vodoo!? [15:30:11] I should have put an example :)] [15:30:59] $ mwscript mctest.php --wiki=enwiki [15:31:00] (03CR) 10Hoo man: "Addressed Daniel's comments. Although this is rather critical, I would like to see some more testing, especially with AbuseFilter." [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 10Hoo man) [15:31:00] 10.4.1.86:11211 set: 100 incr: 100 get: 100 time: 0.17192602157593 [15:31:01] 10.4.1.106:11211 set: 100 incr: 100 get: 100 time: 0.19056081771851 [15:31:03] (03CR) 10MaxSem: [C: 04-2] "If we're to use urldecoding, we should use it on storing, not retrieval. However, we shouldn't: by using named parameters to {{#coordinate" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [15:31:03] they are not properly aligned [15:31:16] OCD much? ;) [15:31:44] Yuvi|NoPowerGrrr, grrrit-wm looks slow:) [15:31:45] (03PS2) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [15:31:53] Reedy: I have pasted an example :] [15:32:11] 010.004.001.086 [15:32:11] ;D [15:33:05] That looks seriously weird [15:34:43] hehe [15:36:05] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [15:36:18] how do you test out code that has been fetched on tin before it got synced? [15:36:30] I think it used to be that running commands on fenari would load the config from /home/wikipedia/common [15:36:37] sync-common locally? [15:37:18] I keep forgetting about that one [15:38:15] :) [15:39:01] and [15:39:10] to sync? is that still: sync-dir wmf-config [15:44:25] yup [15:45:53] \O/ [15:46:22] anomie: did I told you I hate php ? [15:46:35] hashar: Not recently [15:46:39] anomie: or I have done too much python [15:46:48] in python reduce is (a,b) and you return the result [15:46:49] :( [15:50:51] now I am confused [15:52:53] (03PS11) 10Rahul21: Pronunciation Recording Tool [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [15:55:51] anomie: fixed up https://gerrit.wikimedia.org/r/#/c/76909/ :-] [15:56:37] (03PS3) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [15:56:38] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:00:54] hashar: It looks like the difference between python's reduce and php's array_reduce is just in the first iteration when no "initializer" is passed. Your function from PS2 would break in python too, I think, except when the list contains only 1 or 2 elements. [16:02:29] python would be: max = reduce( lambda: a, b: max(a,b), servers) [16:04:49] (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:05:26] len(reduce( lambda a, b: max(a,b), servers)) [16:05:26] :)D [16:05:26] but yeah slightly different [16:06:00] hashar: Wouldn't that give you the length of whichever string is alphabetically last, not whichever has the max length? [16:06:33] * anomie s/alphabetically/lexically/ [16:09:21] (03PS18) 10Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 [16:10:07] (03CR) 10Mwjames: "What can I say, missed a header ..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 (owner: 10Mwjames) [16:10:16] (03CR) 10Hashar: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:10:37] (03PS4) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [16:10:44] anomie: not sure [16:10:57] anomie: anyway I have addressed both issues. I did know about str_pad() :] [16:17:05] (03CR) 10Anomie: [C: 031] "Code looks ok, functions as advertised with a simple hook function. Not +2ing right now because Hoo wants to test with AbuseFilter specifi" [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 10Hoo man) [16:17:56] anomie: Could you test it with AbuseFilter? Just create a dummy filter with "1" in it and make it throw a warning before accepting the edit [16:18:11] then test with API edits (the 2nd one should always pass) [16:18:15] I'd love you for that :P [16:18:19] hoo: I can do that easily enough, sure. [16:18:43] hashar: $maxSrvLen + 1 in the str_pad, so the longest string still has a space after it? [16:18:54] and of course check the AbuseLog... with the old logging format, we would have not found this bug this easy, btw :) [16:19:44] (03CR) 10Mwjames: [C: 031] \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/61171 (owner: 10Mwjames) [16:19:54] anomie: yup :) [16:20:23] anomie: or the longest servers ends up sticked to the set: after it [16:20:44] hahrar [16:20:46] aargh [16:20:49] (03PS1) 10Jack Phoenix: WikiForum: version 1.3.0-SW (bugfix release). [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/76937 [16:20:52] (03PS2) 10MaxSem: Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 [16:21:09] (03CR) 10Jack Phoenix: [C: 032 V: 032] WikiForum: version 1.3.0-SW (bugfix release). [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/76937 (owner: 10Jack Phoenix) [16:21:13] (03CR) 10Jqnatividad: "Thanks Max for the quick review." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [16:21:50] (03PS7) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [16:21:57] hoo: Your suggested test worked fine, first submission warned and the second made the edit. ApiSandbox is useful for testing stuff like this, BTW. [16:21:59] anomie: sorry :( [16:21:59] (03PS5) 10Hashar: mctest.php: nicely align server names [core] - 10https://gerrit.wikimedia.org/r/76909 [16:22:33] anomie: :) Both logged in and out? [16:22:44] hoo: Oh, logged out too? Just a minute. [16:23:33] (03CR) 10Anomie: [C: 031] "Looks ok. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:25:19] (03CR) 10Jqnatividad: "I meant Central Park Boathouse as Resource/Restaurant/Central_Park_Boathouse" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [16:25:37] hoo: Failing when logged out. First guess is that it's the same thing as bug 37643 was in ConfirmEdit. [16:26:00] (and unrelated to this changeset) [16:26:28] anomie: That might explain, why it worked for me after some playing around [16:26:37] ok, I'm fine with the change then [16:26:56] (03CR) 10MaxSem: "Please do {{#coordinates|40.7820|-73.9660|type:landmark_region:US|name=Central Park Boathouse}} instead." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [16:27:57] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:28:09] (03CR) 10Anomie: [C: 032] "AbuseFilter is tested, seems to work (modulo an unrelated bug with anon editing)." [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 10Hoo man) [16:30:39] (03Merged) 10jenkins-bot: Make APIEditBeforeSave give the whole revision [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 10Hoo man) [16:30:46] :) [16:30:56] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76909 (owner: 10Hashar) [16:31:19] and I am off *wave* [16:31:23] thank you anomie for the reviews [16:31:36] my PHP is really awful :( [16:32:35] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/60952 (owner: 10Mattflaschen) [16:33:32] s/my// :) [16:37:07] (03PS1) 10Raimond Spekking: Consistency tweaks: Remove Title Case [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76938 [16:40:20] (03PS1) 10Hoo man: Use content format for unserializing in ApiEditPage [core] - 10https://gerrit.wikimedia.org/r/76940 [16:40:44] (03CR) 10Anomie: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [16:43:51] (03CR) 10Mdale: "(6 comments)" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 10Mdale) [16:48:38] (03PS1) 10Hoo man: Make sure a session has been started prior to using it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76941 [16:48:46] anomie: ^^ [16:51:02] anomie: and https://gerrit.wikimedia.org/r/76940 :P [16:54:53] (03CR) 10Anomie: [C: 032] Use content format for unserializing in ApiEditPage [core] - 10https://gerrit.wikimedia.org/r/76940 (owner: 10Hoo man) [16:55:47] (03CR) 10Anomie: [C: 032] "Same issue as bug 37643 in ConfirmEdit, and same fix too." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76941 (owner: 10Hoo man) [16:56:09] (03Merged) 10jenkins-bot: Make sure a session has been started prior to using it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76941 (owner: 10Hoo man) [16:56:14] \o/ [16:57:29] (03Merged) 10jenkins-bot: Use content format for unserializing in ApiEditPage [core] - 10https://gerrit.wikimedia.org/r/76940 (owner: 10Hoo man) [17:01:52] (03CR) 10Parent5446: [C: 031] Normalize IPv6 addresses in XFF chains [core] - 10https://gerrit.wikimedia.org/r/76843 (owner: 10MaxSem) [17:03:52] (03CR) 10Jqnatividad: "When I do that, the geo_tags table only stores "Central" in gt_name and gt_type (which should be landmark) and gt_region (which should be " [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [17:12:42] (03CR) 10MaxSem: "Then you're doing something wrong: https://www.mediawiki.org/wiki/Special:ApiSandbox#action=query&prop=coordinates&format=json&coprop=type" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [17:13:24] (03CR) 10Demon: [C: 032] Stop producing nonsense words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76832 (owner: 10Manybubbles) [17:13:27] (03Merged) 10jenkins-bot: Stop producing nonsense words in suggestions. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76832 (owner: 10Manybubbles) [17:16:48] (03PS8) 10Cmcmahon: Check for internal link and link that doesn't exist [qa/browsertests] - 10https://gerrit.wikimedia.org/r/73753 (owner: 10Rachel99) [17:17:30] (03CR) 10Cmcmahon: [C: 032] "looks good, coverage for links functionality in VisualEditor" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/73753 (owner: 10Rachel99) [17:19:51] (03PS1) 10Demon: Remove old Solr-specific config building stuff [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76942 [17:22:39] (03CR) 10CSteipp: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [17:23:02] (03PS1) 10Alex Monk: Fix middle click on notifications in the overlay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76943 [17:23:10] (03CR) 10jenkins-bot: [V: 04-1] Fix middle click on notifications in the overlay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76943 (owner: 10Alex Monk) [17:23:35] (03CR) 10Manybubbles: [C: 032 V: 032] Remove old Solr-specific config building stuff [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76942 (owner: 10Demon) [17:23:37] (03Merged) 10jenkins-bot: Remove old Solr-specific config building stuff [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76942 (owner: 10Demon) [17:24:21] (03CR) 10Brian Wolff: "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 10Dan-nl) [17:24:35] (03PS2) 10Alex Monk: Fix middle click on notifications in the overlay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76943 [17:25:27] (03CR) 10Rachel99: [C: 031] test for VE behavior for anonymous users [qa/browsertests] - 10https://gerrit.wikimedia.org/r/76833 (owner: 10Cmcmahon) [17:26:15] marktraceur: I'm going to approve the gwtoolset patch so that future stuff can go in smaller patches per siebrand's suggestion [17:26:29] Sounds excellent [17:26:59] (03CR) 10Brian Wolff: [C: 032 V: 032] "Merging this into repo, so that future fixes can go in independent patches, to make it easier to keep track of things." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 10Dan-nl) [17:27:27] * siebrand cheers bawolff on! [17:28:08] siebrand: Honestly, its one of the biggest problems with gerrit review work flow - when first putting a new extension in, everyone comments, and then the initial commit never gets merged until its perfect [17:28:30] * bawolff is reminded of the CML extension, which i think the author eventually lost interest [17:28:48] ^d: Any progress on reviewer counts? :-) [17:28:53] Also, good morning. [17:29:25] bawolff: yep:( We have the same problem with some German's UI rating extension elsewhere. [17:29:28] <^d> Elsie: Do we have a bug for this? [17:29:28] bawolff: Big patches in general, not just new extensions [17:29:31] bawolff: I think I made the same proposal there. [17:29:48] What's the german ui extension? [17:29:51] ^d: Not yet! I'd be happy to file one, though. [17:30:03] (I asked a few days ago if that would be helpful.) [17:30:13] <^d> Nevermind, found the old e-mail :) [17:30:23] I can move the e-mail contents to a bug. [17:30:27] If that would help move things forward. [17:30:56] Let me just do that anyway, as I'll be able to re-find a bug. [17:31:21] bawolff: I can try to look it up, but don't knioow if I can find it. IIRC it's called UIFeedback [17:31:27] (03PS4) 10CSteipp: Add eventlogging for SUL2 activity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 [17:31:30] that's ok [17:31:58] bawolff: https://gerrit.wikimedia.org/r/#/c/50004 [17:32:19] bawolff: In review for 5+ months now. [17:32:26] oh that one. I remember that one [17:32:30] (he still hangs out in -labs, btw) [17:33:53] ^d: https://bugzilla.wikimedia.org/show_bug.cgi?id=52329 [17:43:29] <^d> Elsie: https://gerrit.wikimedia.org/r/#/c/76945/ :) [17:44:15] ^d: \o/ [17:44:34] <^d> So that'll output as JSON, and update each day at 1am UTC. [17:44:40] Sweeeeeeeeeeet. [17:44:59] <^d> And be available from gerrit.wikimedia.org/reviewer-counts.json [17:45:11] * Elsie nods. [17:45:22] <^d> Now to just pester for a merge :) [17:45:53] That's a Daniel Z. thing? [17:46:01] <^d> Anyone I can bribe in ops. [17:46:13] <^d> Ryan usually merges my gerrit-related puppet changes. [17:46:54] that isn't gonna work [17:47:16] hm [17:47:18] maybe it will [17:47:28] is gerrit in the path? [17:47:56] (03CR) 10Ori.livneh: "Anomie: to test," [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [17:48:00] nopw [17:48:02] *nope [17:48:29] -1'd ;) [17:48:30] (03PS8) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [17:50:48] Heh, I nearly caught that too. [17:51:16] I got distracted by figuring out which user it should use. [17:51:26] And trying to prevent VE from imploding. [17:55:11] (03CR) 10Jqnatividad: "Great! Got it working!" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [17:58:17] (03Abandoned) 10Jqnatividad: added urldecode support when parsing name to GeoSearch API. This allows using spaces (%20), underscores (%5F) and other special characters when specifying the name extra parameter. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/76926 (owner: 10Jqnatividad) [18:05:47] (03PS9) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [18:11:22] (03PS12) 10Kaldari: Adding hook handler for creating human-friendly relative timestamp [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 [18:16:40] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76647 (owner: 10Legoktm) [18:16:47] (03Merged) 10jenkins-bot: Add a row to Special:Statistics with the number of queued messages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76647 (owner: 10Legoktm) [18:17:26] (03CR) 10Ryan Lane: [C: 04-1] "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [18:19:20] Elsie: have you disable this tool? http://toolserver.org/~mzmcbride/watcher/ [18:20:18] se4598: I haven't. [18:20:20] Is it broken? [18:20:27] 500 - Server error [18:20:30] Lame. [18:20:37] Probably related to broken replication. [18:21:46] ok, I though it could have been removed in favor of page information in mediawiki [18:21:55] It can be, it's just a slow process. [18:22:06] $ toolserver [18:22:06] ssh: Could not resolve hostname willow.toolserver.org: nodename nor servname provided, or not known [18:22:09] wtffff [18:22:24] ... [18:23:24] se4598: I think DNS is broken. [18:26:23] (03PS13) 10Kaldari: Adding hook handler for creating human-friendly relative timestamp [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 [18:28:06] (03CR) 10MZMcBride: "I'm a bit confused by this change." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76691 (owner: 10Legoktm) [18:28:56] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76686 (owner: 10Legoktm) [18:30:25] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76655 (owner: 10Legoktm) [18:30:29] (03Merged) 10jenkins-bot: Make getParserFunctionTargets a static method for easier unit testing [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76686 (owner: 10Legoktm) [18:30:30] (03Merged) 10jenkins-bot: Remove unused code and rename functions that were called "Local" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76655 (owner: 10Legoktm) [18:30:32] Elsie: just wanted to know. most other TS i looked at tools work in a way or not, but not fail with 500. And one other user reported that your tool doesn't worked already for some time. [18:31:02] se4598: http://lists.wikimedia.org/pipermail/toolserver-l/2013-July/006218.html [18:31:19] se4598: Until I can ssh in, I don't know what's going on. watcher _should_ still be working. [18:31:35] se4598: It can be replaced by ?action=info, but many URLs still need to be updated. [18:35:06] (03PS1) 10Demon: Allow users to choose a search backend by query parameter [core] - 10https://gerrit.wikimedia.org/r/76950 [18:37:19] ^d: Hi. I'd be happy to amend your patchset, but I need someone to run "which gerrit" or equivalent. [18:37:36] <^d> Hm? [18:38:15] <^d> Oh, herp derp. [18:38:16] se4598: Short answer: the Toolserver is falling apart. [18:38:17] <^d> Copy+paste fail. [18:38:28] https://gerrit.wikimedia.org/r/#/c/76945/1/manifests/gerrit.pp,unified [18:39:33] <^d> Amended. It's not actually a binary. [18:39:39] <^d> I just forgot part of what I needed. [18:40:21] ^d: we can't just ssh in and run that query, can we? :) [18:41:15] ^d: Thanks. :-) [18:42:01] I'm not totally sure I understand why \" is needed. [18:45:24] (03PS4) 10Cmcmahon: test for VE behavior for anonymous users [qa/browsertests] - 10https://gerrit.wikimedia.org/r/76833 [18:45:47] (03CR) 10Cmcmahon: [C: 032] test for VE behavior for anonymous users [qa/browsertests] - 10https://gerrit.wikimedia.org/r/76833 (owner: 10Cmcmahon) [18:46:12] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [18:48:08] <^d> YuviPanda: No, that gsql thing is restricted to the gerrit2 user and me. [18:48:16] <^d> Since it has full DB access, not just read-only :) [18:48:29] ah [18:48:50] there's a bug about replicating that db to labs somewhere [18:49:16] <^d> Which I wontfix'd. [18:49:25] <^d> There's a fair bit of private data I don't feel like sanitizing. [18:50:09] that got wontfixed? [18:50:22] ^d: what private data? other than drafts [18:50:40] and meh, I don't feel enough about it to pester you [18:50:43] * YuviPanda stops pestering [18:54:26] (03CR) 10Yuvipanda: [C: 031] "We should merge this if folks are okay with it, and then write the API module as a separate patch." [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [18:54:50] @seen dantman [18:54:50] MatmaRex: Last time I saw dantman they were quitting the network with reason: Ping timeout: 264 seconds N/A at 7/29/2013 8:31:18 PM (1d22h23m32s ago) [18:55:10] (03CR) 10Wikinaut: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [18:55:17] <^d> YuviPanda: Drafts, comments on drafts, e-mail addresses, ssh keys [18:55:28] ^d: we don't have private keys there, do we? [18:55:34] but yeah, makes sense [18:55:42] <^d> No, but I'm still not going to broadcast people's public keys :) [18:55:56] github.com/yuvipanda.keys, if you haven't seen ;) [18:56:03] (works for everyone, IIRC) [18:56:07] What? [18:56:19] https://github.com/brion.keys [18:56:26] Interesting. [18:56:36] that's a lot of keys. [18:56:39] yeah [18:56:57] I guess brion creates a new key for every device of his [18:57:03] and considering the amount of devices he has [18:57:13] that's still a bit excessive :) [18:57:29] <^d> https://github.com/demon.keys [18:57:36] <^d> Some people only use one key for github :p [18:57:48] <^d> (Actually just shows how little I use github) [18:58:00] heh, [18:59:08] YuviPanda: so do i… and i only have two keys. :( [18:59:12] Elsie: seems TS is glued together again. btw I noticed that I get redirected on the listed request path " /~mzmcbride/cgi-bin/watcher.py" on "/~mzmcbride/watcher/" back to it [18:59:31] ^d: btw, http://gerrit.aokp.co/Documentation/rest-api-accounts.html#get-ssh-key ;) [19:00:03] MatmaRex: :( so do I [19:00:17] I can whittle it to one now, since my other device was destroyed by rat poop [19:00:25] <^d> YuviPanda: lol, so maybe I'm just being paranoid. [19:00:33] ^d: you're just being paranoid [19:00:41] <^d> But I'm still lazy and don't wanna sanitize draft info. [19:00:44] <^d> So still wontfix. [19:00:47] <^d> Life goes on [19:00:49] That's not a reason to wontfix. [19:01:03] <^d> It's a reason it'll never get done then. [19:01:11] There's a mountain of evidence that providing DB replication supports development. [19:01:12] hehe, I don't care enough about it to pester, but maybe other people do [19:01:26] <^d> Elsie: I prefer beaches. [19:01:46] heh, my other device was destroyed by moore's law [19:02:02] So what private info is there? [19:02:04] i can barely run a browser on 768 mb ram these days [19:02:07] Drafts aren't private. [19:02:24] Gerrit may treat them as private, who cares? [19:02:31] drafts should be banner. [19:02:34] ~d* [19:03:15] <^d> Elsie: Drafts should be private, and we've actively worked to try and make them more private. [19:03:32] <^d> They're "not private" because the people writing the feature cut corners. [19:03:56] What's the virtue in private drafts? [19:04:02] Why should they be supported? [19:04:03] Why would you want them to be private? [19:04:05] Security patches [19:04:12] "Drafts" is a bad term for the feature [19:04:20] <^d> The whole feature sucks. [19:04:24] And once again the edge cases trump all practical considerations? [19:04:24] security patches are done on bugzilla anyway, no? [19:04:30] This was the same argument with Bugzilla adminship. [19:04:39] That six "Security" bugs should restrict the whole system. [19:04:40] They're done on BZ *because* we can't manage them in Gerrit securely [19:04:43] It's patently retarded. [19:04:51] (03CR) 10Jack Phoenix: [C: 032 V: 032] Consistency tweaks: Remove Title Case [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76938 (owner: 10Raimond Spekking) [19:05:17] <^d> Drafts in gerrit were designed to be private. But like I said, corners were cut so they've never been really private. [19:05:27] Elsie: We need some sort of facility to have private patches. We additionally need some sort of facility to have public draft/WIP patches that are filterable from review dashboards [19:05:52] Which part of Gerrit we hack/repurpose to provide which of those is largely irrelevant [19:05:55] <^d> Instead we get the worst of both worlds combined as one feature: drafts :) [19:06:11] Is that really needed. Security issues seem rare enough that surely people could just post patches to bugzilla? [19:06:23] What bawolff said. [19:06:39] It's a huge pain for people to review patches in bugzilla [19:06:43] The work in progress issue seems tangential. [19:07:08] csteipp: It's also a huge pain to release a security patch and apply it. :-) [19:07:18] There's going to be some pain. [19:07:24] csteipp: eh, `curl | git apply && gitk`? [19:07:36] What? [19:07:50] If they're on a private bug, I hope you can't just curl them [19:07:57] MatmaRex: And then when we need to make comments and improve the patch? [19:08:13] (03PS10) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [19:08:20] Reedy: you can't. I accidentally tried to once, and was very confused when it didn't work [19:08:22] cscott: well, make comments and improve the patch? :P [19:08:28] csteipp: ^ [19:08:37] bawolff: Good! [19:08:50] Again, the edge cases drown out the practical considerations. [19:08:52] Reedy: meeeeh, okay. [19:09:00] Security bugs are rare and are the exception. [19:09:00] Yeah, there's a csrf token in the url [19:09:04] but come on. [19:09:11] Restricting Gerrit or Bugzilla access is stupid. [19:09:27] <^d> Nobody is talking about restricting any access to Gerrit. [19:09:33] Except DB access? [19:09:36] Elsie: What I'm saying is that we need two different facilities, one for security patches (which aren't as rare as you think, you're not on security@ ;) ) and one for draft/WIP stuff [19:09:54] RoanKattouw: Agreed. [19:10:40] RoanKattouw: We should just write better code [19:10:42] And so what ^d is doing is improving the first facility, as well as musing about the second [19:10:43] Problem solved [19:10:49] <^d> MAYBE WE SHOULD JUST WRITE OUR OWN TOOL SINCE GERRIT IS SO OBVIOUSLY FLAWED. [19:10:54] Reedy: I totally agree :) [19:10:56] ^d: OMFG [19:10:57] DO IT [19:10:57] * sumanah requests decrease in sarcasm [19:10:58] <^d> AND WRITING CODE REVIEW TOOLS IS NEVER A TIMESINK. [19:11:07] In VE we don't use drafts anyway, we just mark commit summaries with [WIP] and self-minus-2 [19:11:10] ^d++ [19:12:06] <^d> Screw git, anonymous ftp for everyone! [19:12:13] index2.php.final [19:12:48] ^d: CAN IT BE A MEDIAWIKI EXTENSION? [19:12:52] RoanKattouw: in parsoid we just mark commit summaries with WIP. we assume reviewers can read. ;) [19:13:01] Yeah well [19:13:19] <^d> bawolff: SPECIAL:FTP [19:13:22] I once submitted a patch that had DON'T MERGE in the tag line and it was merged after 5 minutes (not in VE, other repo) [19:13:36] Gerrit should support [19:13:45] <^d> YuviPanda: Webkit would have to first. [19:14:11] ^d: they already use GWT to sortof pretend that Js never exists, I am sure they can rig something up [19:14:16] ^d: via Java applets! [19:14:28] Or flash! [19:14:33] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/60952 (owner: 10Mattflaschen) [19:14:42] no, ActionScript is too sane! Java! [19:15:11] * Elsie bites csteipp. [19:15:34] (03CR) 10Jeroen De Dauw: [C: 032] Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69668 (owner: 10Nischayn22) [19:15:36] (03CR) 10jenkins-bot: [V: 04-1] Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69668 (owner: 10Nischayn22) [19:15:37] csteipp: We're not going to set up a global AbuseFilter filter for a decades-old hash list that nobody is hitting. [19:15:52] decade-old, rather. [19:16:38] (03CR) 10Jeroen De Dauw: "Nischayn, did you test this?" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69306 (owner: 10Nischayn22) [19:18:10] <^d> RoanKattouw: I wonder if I could just disable the whole hair-brained feature. [19:18:26] Elsie: Checking the sha1 is pretty trivial. Why leave it open, even if it's not being hit? [19:18:35] <^d> RoanKattouw: It's so stupidly implemented to the point of being absolutely useless. [19:18:39] Yeah [19:18:43] It's just confusing really [19:18:49] csteipp: It's a violation of our core principles to unnecessarily restrict users. [19:19:02] I'd be for disabling it, if Gerrit allows that [19:19:06] csteipp: We restrict when absolutely necessary, not "because it may be useful maybe." [19:19:07] (03PS1) 10Umherirrender: Make list=allimages&aimime= working in miser mode [core] - 10https://gerrit.wikimedia.org/r/76954 [19:19:17] <^d> RoanKattouw: Or...go the other direction and open them up. Shawn didn't seem to like our ideas of making them private-er (not that he's right, he's totally wrong in thinking the feature is "fine as it is.) [19:19:29] csteipp: Also, adding global filters that check hashes is relatively expensive, as I understand it. [19:19:41] Elsie: I'll let you take that up with the stewards. [19:19:44] That could work too. Make "drafts" the WIP feature and add a new private commit feature separately [19:19:45] csteipp: There's a cost to running these filters on every upload/edit/whatever. [19:19:55] As for performance, not really. We already have to take the sha1 [19:20:07] So checking it against a list of static strings is trivial [19:20:18] csteipp: Not according to Hoo. [19:20:25] csteipp: The AbuseFilter implementation isn't very fast. [19:20:39] It apparently doesn't support arrays or dicts in a way you'd expect. [19:20:47] (03PS11) 10Matthias Mullie: Send Echo notifications for AFTv5 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 [19:20:49] And doing anything on every action Wikimedia wiki-wide adds a cost. [19:21:10] Even if the hashing part is relatively cheap/inexpensive. [19:21:21] Well, it has to crawl over every char within the filter... I guess that's why it doesn't support comments [19:21:33] In any case, the stewards shouldn't be deploying such a filter. [19:21:35] And likely won't. [19:21:43] vvv: ^^ [19:21:43] Because it would be stupid and ineffective. [19:21:58] The whole idea of filtering by hashes is kind of broken anyway. [19:22:01] (03PS1) 10Mattflaschen: mediawiki.js: Document that default message format is 'text' [core] - 10https://gerrit.wikimedia.org/r/76955 [19:22:12] But at the cost of additional time per edit, it becomes mind-boggling. [19:22:13] Download image [19:22:13] Change 1 pixel [19:22:14] Upload image [19:22:17] PROFIT [19:22:17] Right. [19:22:33] I'm drowning in bugspam. [19:22:54] And jenkinsspam. [19:24:36] i recently started unccing myself from bugs and removing as a reviewer from changesets [19:24:39] (03CR) 10Mwalker: [C: 031] "(2 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 (owner: 10Mollywhite) [19:25:21] it was a turning point in my life, really. [19:26:03] I just delete a lot of e-mail. [19:26:13] I may need to filter jenkins-bot, though. [19:26:46] i just mark it as read. [19:26:58] (03PS11) 10Mwjames: Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/69668 (owner: 10Nischayn22) [19:27:51] (03PS1) 10Mwjames: Move SMWHooks::onArticlePurge to \SMW\ArticlePurge + tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 [19:29:46] (03CR) 10Mwalker: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 (owner: 10Mollywhite) [19:34:49] mwalker: Looking at your reviews... how would I add an IContextSource? [19:36:01] (hi GorillaWarfare - you might be interested to know that I am hanging out with 2 other GSoC interns today here in NYC) [19:36:18] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [19:36:33] sumanah: Hey sumanah. Sounds fun! [19:37:34] (03CR) 10MZMcBride: "Yes, please kill this user preference with fire." [core] - 10https://gerrit.wikimedia.org/r/25751 (owner: 10Daniel Friesen) [19:37:38] :) [19:37:48] (03PS1) 10Manybubbles: Add at least basic support for all languages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76957 [19:39:58] hey folks. i'm having a little trouble with page layout. any idea how I can get these page elements not to overlap? https://en.wikipedia.org/wiki/Wikipedia:TWA/1/End?tour=twa1&step=21 [19:45:44] (03CR) 10Mollywhite: "(1 comment)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 (owner: 10Mollywhite) [19:46:53] (03CR) 10Nilesh: "The rescorer was removed, but it seems that I forgot to remove the rescorer dependency from a pom.xml. Strangely though this doesn't cause" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [19:53:16] (03CR) 10Mollywhite: [C: 04-2] "Need to fix an issue with the diff view." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [19:53:28] (03CR) 10Demon: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [19:56:01] (03CR) 10Demon: [C: 032] Add at least basic support for all languages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76957 (owner: 10Manybubbles) [19:56:04] (03Merged) 10jenkins-bot: Add at least basic support for all languages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/76957 (owner: 10Manybubbles) [19:56:29] ^d: cools. now I'll turn it on in beta for everyone - ie, undo the hack [19:57:02] <^d> Oh, and I put in a change for to let people pick their backend of choice. [19:57:09] <^d> I hadn't tested it thoroughly yet. [19:57:29] GorillaWarfare: *waves* [19:58:34] mwalker: Hello! [19:59:21] mwalker: Did you see my above question about IContextSource? [19:59:32] not yet! was reviewing your add view frontend patch [19:59:37] and I had a horrible thought [19:59:40] but it may be premature [19:59:51] mwalker: Uh oh.. [20:00:25] I'll voice it anyway though -- if you are creating the navigation bar in php; that means it gets cached for logged out users; which means that you would have to invalidate all constituent pages in a book every time the json changes [20:01:00] mwalker: Caching is different for logged out vs. logged in users? [20:01:10] GorillaWarfare: sadly yes [20:01:23] logged in users don't get cached for most pages [20:01:35] *dont get front end cached [20:02:23] (03CR) 10Nilesh: "I'll have to add a dependency on the fixed tests change, ie. https://gerrit.wikimedia.org/r/76878. But I'll do this after I get the tests " [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 (owner: 10Nilesh) [20:02:29] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [20:02:33] mwalker: Interesting... so how difficult would it be to invalidate the pages? [20:03:13] not terribly hard; there's a method on the page object to do it [20:03:14] * mwalker looks [20:03:38] (03CR) 10Daniel Kinzler: "simple recipe for making this change depend on some other change:" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [20:04:06] GorillaWarfare: yep; it's Title::makeTitle(1, 'foo')->purgeSquid() [20:04:35] mwalker: Alrighty, I'll file a bug [20:05:01] The view frontend still needs some work; I need to add a hook for viewing diffs [20:05:46] GorillaWarfare: re your question about IContextSource; I don't actually see it, I saw only one comment on that patch which was about you filing a bug about historical date formats [20:05:53] GorillaWarfare: baby steps! :) [20:06:31] mwalker: Sorry, I asked in IRC [20:06:40] oh; completely missed it... hang on [20:06:46] 12:34 < GorillaWarfare> mwalker: Looking at your reviews... how would I add an IContextSource? [20:08:59] (03CR) 10Mwjames: "(1 comment)" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76956 (owner: 10Mwjames) [20:12:12] (03CR) 10Anomie: [C: 031] "Thanks Ori. Code seems to function when I try it on the oauth test wiki in Labs." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [20:14:07] GorillaWarfare: got distracted, sorry -- you would add an argument to the function and then pass $this->getContext() if you're in a special page or something [20:14:20] It's not a special page, though [20:14:36] GorillaWarfare: https://www.mediawiki.org/wiki/Manual:RequestContext explains it pretty well [20:15:27] GorillaWarfare: it may be complete overkill; I didn't chase up the call stack to find where the easiest source of context was; but, in general, you should use it instead of globals [20:16:44] (03CR) 10Nilesh: "Okay, thanks, I'm trying with the proper rebase method." [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [20:17:44] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [20:18:04] mwalker: Alrighty, Ill look [20:18:15] GorillaWarfare: you can pass down the context from addNavigationBar, $out->getContext; but that chain gets somewhat long [20:18:17] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76950 (owner: 10Demon) [20:20:09] GorillaWarfare: might be worth it though; you can then use the context to format all your messages in addString() [20:20:22] GorillaWarfare: I would say file a bug about it and worry about it later because this rabbit hole could get quite long [20:20:55] Hmm, okay [20:21:15] the war on globals continues! [20:21:39] :) [20:21:58] hashar: ping [20:22:04] hashar: did you change something in phpcs-HEAD? [20:22:04] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/978/console [20:22:10] VE gate is broken [20:22:22] this is not postmerge [20:24:18] it shoudl not trigger that job if there are no matching changed files [20:24:29] however there are changed files that match (a php file changed) [20:24:37] but it is being excluded apparaerently by changed files, but not by zuul [20:24:42] I don't think i changed it [20:24:44] i18n [20:24:49] you get the job configuration history if needed [20:24:49] it broken 2 minutes ago [20:25:00] I was having sex^Ha beer [20:25:04] (03PS1) 10Nilesh: Remove rescorer references from pom.xml and web.xml files. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77038 [20:25:12] I'll check it out [20:25:12] Krinkle: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/jobConfigHistory/? [20:25:20] last changed on June 26 [20:26:02] sounds like a bug in /var/lib/jenkins/bin/git-changed-in-head [20:26:28] hashar: if you were doing either 2 minutes ago; I'm not sure how I feel about you being able to respond at the same time :p [20:27:59] Krinkle: I am reproducing it on gallium [20:28:04] cd /srv/ssd/jenkins-slave/workspace/mwext-VisualEditor-phpcs-HEAD [20:28:11] $ /var/lib/jenkins/bin/git-changed-in-head php php5 inc sample [20:28:12] $ [20:28:12] hashar: figured it out [20:28:23] hashar: The commit had changed php files, so Zuul let it though [20:28:32] hashar: the jenkins job however looks at it after merge [20:28:41] hashar: the commit as a no-op when compared to master. [20:28:52] it was outdated, it made a change that another commit made already [20:29:04] ah so the merge is a noop [20:29:35] so rebasing the change would result in an empty commit maybe ? [20:29:45] (03CR) 10Ori.livneh: [C: 032] Some small touch-ups to plug-in code [vagrant] - 10https://gerrit.wikimedia.org/r/76892 (owner: 10Ori.livneh) [20:29:49] funny corner case bug [20:29:50] (03Merged) 10jenkins-bot: Some small touch-ups to plug-in code [vagrant] - 10https://gerrit.wikimedia.org/r/76892 (owner: 10Ori.livneh) [20:30:17] I can't even rebase on that repo :/ [20:31:06] Krinkle: the only way to fix it up would be for zuul to merge first and then check the file filtering with the resulting merge [20:31:06] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/25751 (owner: 10Daniel Friesen) [20:31:14] Krinkle: so that would be for upstream. [20:31:29] Krinkle: I am inclined to let that bug go. That is a corner case. [20:31:36] (03PS5) 10Matmarex: Remove the showjumplinks user preference [core] - 10https://gerrit.wikimedia.org/r/25751 (owner: 10Daniel Friesen) [20:31:50] mwalker: yeah was merely attempting to confuse Timo :-] [20:33:01] (03PS2) 10Nilesh: Fixed tests to work properly with changed WebClientRecommender [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 [20:33:02] (03PS2) 10Nilesh: Remove rescorer references from pom.xml and web.xml files. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77038 [20:34:01] hashar: well, the real issue is that phpcs-HEAD should not fail on an empty list. [20:34:10] hashar: The filtering from zuul is an optimisation, not an API [20:34:13] (03CR) 10Ryan Lane: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [20:35:45] hashar: btw, I'm catching up on The Big Bang Theory series, reminds me of a scene where Raj says: "Yeah, that would have been great. You and Penny having sex in the tent while I sit out here and watch Howard hump a cactus." [20:36:26] Krinkle: in theory, when git-changed-in-head returns nothing, PHPCS_FILES should be -z and thus the job should skip with exit 0 [20:38:46] (03PS3) 10Mattflaschen: Get jshint passing on migrated Guiders code, other style fixes [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76699 [20:38:48] (03CR) 10Mattflaschen: "Needs more testing." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76699 (owner: 10Mattflaschen) [20:38:49] (03PS3) 10Nilesh: Fixed tests to work properly with changed WebClientRecommender [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 [20:38:50] (03PS2) 10Nilesh: Servlet JSON output is now done using GSON library [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 [20:38:52] hashar: it doesn't do that. We've seen for months now that the postmerge phpcs job (which doesnt' ahve the filter in zuul) is constnatly failing FILES= being empty [20:38:57] (03CR) 10Mattflaschen: "On toro for testing." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76699 (owner: 10Mattflaschen) [20:38:58] apparently the empty assignment cause an error and shell returns some non 0 exit code [20:39:25] that is new to me, never heard of it [20:39:29] sorry :/ [20:39:43] we would need a way to reproduce it locally and fix up the shell part [20:43:06] cscott: dgerard, not dgerald :-) [20:43:26] hashar: Apparently free.fr doesn't like my mail host. [20:43:32] hashar: I sent you an e-mail, but it got queued. [20:48:09] (03CR) 10Wikinaut: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [20:48:23] Elsie: might be greylisting [20:49:07] Elsie: like if it is a new IP / emitter, the mail is dropped for a few hours till your host resend it. If one assume the spammer does not retry, the spam never land on the server :] [20:49:14] > [20:49:17] SMTP error from remote server in greeting: [20:49:17] host mx1.free.fr[212.27.48.7]: [20:49:17] 421 Too many spams from your IP (74.208.4.194), please visit http://postmaster.free.fr/ [20:49:20] > [20:49:23] Might be. :-) [20:49:24] ahh you are a spammer see [20:50:04] Elsie: blacklisted for 15042 seconds [20:50:24] I'm patient. :-) [20:50:35] Elsie: c'est ton propre serveur mail? [20:50:49] No hablo. [20:50:55] damn context switching [20:51:16] !bug hashar sometimes fails to context switch between english and french, specially when browsing a french language technical web page [20:51:16] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=hashar+sometimes+fails+to+context+switch+between+english+and+french%2c+specially+when+browsing+a+french+language+technical+web+page [20:51:22] crap [20:51:32] Elsie: is the IP your personal server ? [20:53:44] Elsie: the IP is blacklisted in several lists http://www.dnsbl.info/dnsbl-database-check.php [20:53:55] Elsie: http://www.spamcannibal.org/cannibal.cgi finds out at least one spam. [20:54:08] Elsie: sorry. You can try my @wikimedia.org email amusso .. [20:56:54] hashar: Nope, shared hosting host. [20:57:01] It's not a big deal. [20:57:17] Though I hope I'm not getting filtered elsewhere. [20:57:19] one of your "room"mate is spamming :-] [20:58:44] (03PS4) 10Daniel Kinzler: Fixed tests to work properly with changed WebClientRecommender [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [20:58:45] (03PS3) 10Daniel Kinzler: Servlet JSON output is now done using GSON library [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 (owner: 10Nilesh) [20:58:46] (03PS1) 10Mattflaschen: Close out this repo and point to where the ongoing GuidedTour work is [extensions/GuidedTour/guiders] - 10https://gerrit.wikimedia.org/r/77048 [20:58:48] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/62157 (owner: 10Waldir) [20:59:08] I am out *wave* [20:59:30] (03Abandoned) 10Mattflaschen: Add guiders to .gitignore [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76021 (owner: 10Reedy) [21:00:20] (03CR) 10Krinkle: "Has this change become obsolete, is it going to be done later in a different change, or is this still en route?" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [21:02:45] (03CR) 10TheDJ: [C: 032] "Tested in IE6. Seems like a proper improvement, and I agree with Matmarex that the title is at least still accessible/visible from other p" [core] - 10https://gerrit.wikimedia.org/r/45944 (owner: 10Matmarex) [21:06:58] (03CR) 10Mattflaschen: "I think it's en route. It's just that no one's been focusing on it lately." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [21:08:31] (03CR) 10Ryan Lane: [C: 031] "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:10:17] (03PS37) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:10:40] (03CR) 10Anomie: [C: 032] Add eventlogging for SUL2 activity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [21:10:44] (03Merged) 10jenkins-bot: Add eventlogging for SUL2 activity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/76829 (owner: 10CSteipp) [21:19:09] (03CR) 10Mwalker: "Apart from the diff issue; seems good to me" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76883 (owner: 10Mollywhite) [21:20:14] (03CR) 10Wikinaut: [C: 031] "(5 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:20:32] (03CR) 10Wikinaut: [V: 031] (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [21:26:42] (03PS1) 10Demon: There is no $content, just $rev->getContent() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77050 [21:28:00] (03CR) 10Manybubbles: [C: 032] There is no $content, just $rev->getContent() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77050 (owner: 10Demon) [21:28:07] (03Merged) 10jenkins-bot: There is no $content, just $rev->getContent() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77050 (owner: 10Demon) [21:29:15] reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/Bootstrap$ git submodule update --init --recursive [21:29:15] Submodule 'bootstrap' (https://github.com/twitter/bootstrap.git) registered for path 'bootstrap' [21:29:15] Cloning into 'bootstrap'... [21:29:15] Username for 'https://github.com': [21:29:26] ^ why's it asking for a password? :/ [21:30:34] Because you're using https:// instead of git://? [21:31:38] If I just clone the same repo it doesn't [21:31:42] Or ssh://? [21:32:26] Ooh [21:32:26] https://github.com/twitter/bootstrap.git [21:32:30] It 404s :/ [21:32:45] (03PS1) 10Demon: Unconditionally define indexing rate to avoid warnings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77051 [21:33:26] (03CR) 10Manybubbles: [C: 032] Unconditionally define indexing rate to avoid warnings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77051 (owner: 10Demon) [21:33:31] (03Merged) 10jenkins-bot: Unconditionally define indexing rate to avoid warnings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/77051 (owner: 10Demon) [21:34:21] (03PS1) 10Alex Monk: Add JS hook for user scripts to add buttons to all LQT textareas as they are created [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 [21:34:29] https://github.com/twbs/bootstrap.git [21:34:32] Reedy: It's https://github.com/twbs/bootstrap [21:34:34] Oh, damn it. [21:34:35] Beaten. [21:34:49] I guess they moved it. [21:34:54] Kind of nasty thing to do. [21:35:47] (03PS1) 10Reedy: Use new/correct url for bootstrap [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/77053 [21:36:12] (03CR) 10Helder.wiki: [C: 031] Add JS hook for user scripts to add buttons to all LQT textareas as they are created [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/77052 (owner: 10Alex Monk) [21:37:06] (03CR) 10Reedy: [C: 032 V: 032] Use new/correct url for bootstrap [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/77053 (owner: 10Reedy) [21:37:52] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Remove rescorer references from pom.xml and web.xml files. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77038 (owner: 10Nilesh) [21:38:40] reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/Bootstrap$ git submodule update [21:38:40] Cloning into 'bootstrap'... [21:38:40] Username for 'https://github.com': [21:38:41] ffs [21:38:56] --init --recursive [21:38:58] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Fixed tests to work properly with changed WebClientRecommender [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76878 (owner: 10Nilesh) [21:39:06] How is that going to help? [21:39:23] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Servlet JSON output is now done using GSON library [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76877 (owner: 10Nilesh) [21:40:42] nileshc: ---^ [21:40:57] Hmm [21:41:00] Something is cached [21:41:19] DanielK_WMDE: Yup! It'd be great if we could route those to wikidata too as you said. [21:41:25] Cloning ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Bootstrap.git fresh somewhere else [21:42:10] Did you pull? [21:43:33] Missing a works [21:43:46] What? [21:43:49] /clear [21:44:12] Cloning ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Bootstrap.git fresh somewhere else works fine [21:44:29] I (03PS1) 10Bsitu: (bug 52313) Do not show text snippet with undecoded chars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77055 [21:45:43] > Line 1, Column 5: Garbage after Reedy: The fresh clone working is why I suggested that perhaps you forgot to pull. [21:46:50] I hadn't [21:46:53] Well! [21:55:22] (03PS1) 10CSteipp: Update CentralAuth to master -- add eventlogging [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77056 [21:56:23] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master -- add eventlogging [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77056 (owner: 10CSteipp) [21:59:20] ori-l: You've confused me terribly. [22:01:17] hm? [22:01:39] (03PS5) 10Mollywhite: Bug 51194: Localize the publication date in the metadata. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 [22:01:58] ori-l: Unless I'm missing something, you uploaded two very similar changesets. [22:02:07] ori-l: https://bugzilla.wikimedia.org/show_bug.cgi?id=45031#c27 [22:02:17] (03Merged) 10jenkins-bot: Update CentralAuth to master -- add eventlogging [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77056 (owner: 10CSteipp) [22:02:34] oh, just a dupe. [22:02:43] I probably amended the commit message and deleted the change-id line by accident. [22:02:52] Ahh, all right. [22:02:53] i abandoned the dupe now. [22:03:04] ori-l: Thanks. Is that bug resolved now? [22:03:04] and yes, the bug is closable, thanks. [22:03:08] :) [22:03:10] Cool. :-) [22:08:12] (03PS1) 10Mollywhite: Add month-only date format. [core] - 10https://gerrit.wikimedia.org/r/77059 [22:10:21] (03PS2) 10Krinkle: mediawiki.js: Document that default message format is 'text' [core] - 10https://gerrit.wikimedia.org/r/76955 (owner: 10Mattflaschen) [22:11:53] (03CR) 10Matmarex: "I think this won't be available in other languages if done in this way, no?" [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [22:12:39] MatmaRex: What's wrong with the l18n change? I'm not quite sure what you mean [22:13:43] GorillaWarfare: $dateFormats are different for each languages [22:13:53] or at least for many of them [22:13:54] see e.g. MessagesPl.php [22:14:16] so i'm not sure what this change actually does [22:15:09] MatmaRex: It complements this patch: https://gerrit.wikimedia.org/r/#/c/76454/ [22:15:30] The publication date there can be just a month and a year, without a day, and there's no support for that in the current date formats [22:15:41] Other languages would presumably add their own localized versions [22:16:01] what happens if they don't? [22:17:18] (03CR) 10EBernhardson (WMF): [C: 032] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77055 (owner: 10Bsitu) [22:17:41] (03Merged) 10jenkins-bot: (bug 52313) Do not show text snippet with undecoded chars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77055 (owner: 10Bsitu) [22:18:48] One second [22:20:14] MatmaRex: It breaks a bit.. The publication date isn't shown at all [22:21:16] well, that's not cool. :) [22:21:37] GorillaWarfare: you might want to introduce another variable in MessagesXx, say $monthYearFormat [22:21:48] GorillaWarfare: and a method to format these in Language.php [22:22:00] GorillaWarfare: but i'm no expert onlocalisation things, ask Nikerabbit or siebrand [22:22:14] MatmaRex: Indeed; Nikerabbit is on the review list [22:22:20] csteipp: still no SUL2 love, I'm getting fatals from WIkiMap::getWiki(), even after $wgLocalDatabases = array( $wgDBname ). I can't find any doc on WIkiMap [22:22:22] i have no idea how such a change would play with caching, translatewiki and everything else [22:22:53] spagewmf: There's a few docs on Manual:$wgConf [22:23:27] (03CR) 10Matmarex: [C: 04-1] "[00:16] what happens if they don't?" [core] - 10https://gerrit.wikimedia.org/r/77059 (owner: 10Mollywhite) [22:23:40] GorillaWarfare: i forwarded this there :) [22:23:45] brb [22:25:34] spagewmf: are you in the office? [22:26:21] csteipp: Yes I am! bawolff thanks, yeah I think WikiMap assumes $wgConf->siteFromDB() works. [22:26:25] greg-g: http://gdash.wikimedia.org/dashboards/reqerror/deploys [22:27:23] Reedy: well then... [22:27:25] spagewmf: if you come down to 3, I can probably get you setup. I can show you how I have wgConf setup, and hopefully get your's working [22:27:30] (03PS2) 10Umherirrender: Make list=allimages&aimime= working in miser mode [core] - 10https://gerrit.wikimedia.org/r/76954 [22:27:37] spagewmf: Also, I listed some minimal config to get things working locally that worked once upon a time for me at https://www.mediawiki.org/wiki/Manual_talk:$wgLBFactoryConf (ymmv) [22:28:31] bawolff: oh no not the load balancer! :-) I just want WikiMap::getWiki( 'my_wiki' ) to not die :) csteipp will do [22:28:33] (03CR) 10Umherirrender: "Patch Set 2: Exclude aimime from aisort=timestamp and added release notes" [core] - 10https://gerrit.wikimedia.org/r/76954 (owner: 10Umherirrender) [22:28:53] spagewmf: I think WikiMap needs the load balancer config possibly, not sure [22:28:59] d'oh [22:29:23] I'm going off vauge memories of last time I tried, I mostly just remember it being annoying, but I may wrong [22:29:32] $wgConf->wikis = array_map( 'trim', file( getRealmSpecificFilename( "$IP/../all.dblist" ) ) ); [22:30:03] * greg-g wonders why that info wasn't showing up in graphite proper... [22:31:37] I suspect you're missing something somewhere [22:31:51] ie a parameter etc [22:49:05] * greg-g closes loop here... [22:49:06] yep [22:58:29] (03CR) 10MZMcBride: "All right. Should this changeset be abandoned, then?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/75292 (owner: 10Legoktm) [22:58:51] (03PS1) 10Bsitu: Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77067 [23:01:12] (03CR) 10Bsitu: [C: 032] Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77067 (owner: 10Bsitu) [23:02:48] bsitu: Could you ping rmoen when you're done? He's doing a training VE deploy after you [23:03:27] RoanKattouw: will do [23:04:31] (03Merged) 10jenkins-bot: Update Echo to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77067 (owner: 10Bsitu) [23:07:48] (03PS1) 10Robmoen: update visualeditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77068 [23:09:10] RoanKattouw, rmoen: I pulled the code on tin, but I want to do some test on testwiki before sync-dir. [23:09:16] OK take your time [23:09:34] thx [23:17:21] RoanKattouw, rmoen: LD window is urs now [23:17:32] bsitu: OK, Thanks :) [23:17:48] Awesome [23:18:00] (03CR) 10Robmoen: [C: 032 V: 032] update visualeditor to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/77068 (owner: 10Robmoen) [23:41:07] TimStarling: We fragment parser cache by userlanguage, right? Any idea what could cause things to get mixed up? https://en.wikipedia.org/wiki/Template:Cite_web/doc?uselang=fr#Template_data shows French for table headers, but https://en.wikipedia.org/wiki/Template:Cite_web/doc?uselang=en#Template_data (and without ?uselang) doesn't English but French (lang of user who last saved) [23:41:34] uselang=de shows German [23:41:43] it uses {{int:}}? [23:41:48] https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/TemplateDataBlob.php#L340-L359 [23:41:49] no [23:45:25] maybe ULS is screwing it up [23:48:33] csteipp: Sorry, didn't find the time to hack the AbuseFilter stuff... need to sleep now, flying tomorrow [23:48:41] See you in HK [23:48:47] ah, no [23:49:18] you do actually have to use $parser->mOptions->mUserLang if you want the language to be correct [23:51:31] on page view, that is the user language, but on save, the default parser options are used [23:51:44] because you need to use the default parser options to update the link table correctly