[00:00:01] (03CR) 10Reedy: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76042 (owner: 10Reedy) [00:00:08] needs a ca_user column to store the user ID, there is already a ca_user_text in that table [00:00:35] Krenair: pretty sure that was reported already, lemme see if I can find the relevant ticket [00:01:12] Reedy: if you foreach over an assoc array, you don't have to do the => thing if you just want the values? [00:01:22] Exactly [00:01:29] ashley: 410 rows [00:01:32] ah, ok [00:01:37] It's a jfdi schema change [00:01:52] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76042 (owner: 10Reedy) [00:02:03] (03Merged) 10jenkins-bot: Fixup comment blocks [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76042 (owner: 10Reedy) [00:02:57] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=50152 [00:03:24] (03PS8) 10Matmarex: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:04:30] ashley, thanks. ran into it when trying to be helpful on https://bugzilla.wikimedia.org/show_bug.cgi?id=52150 [00:04:35] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:07:25] legoktm: Yes, I dont know what happened, but I've reset the breakage for now. Until we know more, it might happen again, but it should be good for hte moment. [00:07:36] Krinkle: Ok thanks [00:12:04] (03PS9) 10Matmarex: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:13:17] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:16:04] damn language converter bullshit. [00:17:30] (03PS10) 10Matmarex: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:18:38] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:20:01] fuck. [00:20:16] (03PS11) 10Matmarex: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:22:55] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:23:40] (03CR) 10Matmarex: "I addressed my own comments from PS4, rewrote the actual translation code and added release notes. (Sorry it took me 7 patchsets to do tha" [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [00:23:42] Krinkle: So is there a reason it didn't merge here? https://gerrit.wikimedia.org/r/#/c/76319/ [00:24:02] wtf is that. it doesn't even touch the parser [00:24:46] legoktm: Depends. Did it ever merge in that repository? Why is there no build results (only a blank "Verified") [00:25:08] legoktm: Usually this means the repository is incorrectly configured and does not grant jenkins-bot the right to do a merge. Nothing I can do from my end. [00:25:18] Krinkle: I don't think so, we just switched to git yesterday. [00:25:20] Let me check [00:26:25] Krinkle: So I just need to add jenkins-bot to https://gerrit.wikimedia.org/r/#/admin/groups/514,members ? [00:27:45] Did that [00:27:55] legoktm: https://gerrit.wikimedia.org/r/#/admin/projects/pywikibot,access [00:28:11] Should match https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki,access as far as JenkinsBot goes [00:28:19] Label Verified, and Submit [00:28:20] ok [00:29:00] i gtg right now, ill fiddle with that when i get back. thanks for the help [00:29:03] You have more than one commit that you are about to submit. [00:29:03] The outstanding commits are: [00:29:04] ←[33md87a657 (←[1;36mHEAD←[m←[33m, ←[1;32mmaster←[m←[33m)←[m Add Renameuser supp [00:29:04] ort to CodeReview. [00:29:04] ←[33m476162a←[m Correctly nest comments. [00:29:05] Is this really what you meant to do? [00:29:08] what is this and why does it do this? [00:29:37] ashley: What command did you execute [00:29:45] git-review [00:29:46] ashley: it's git-review sucking [00:29:56] ashley: `git remote update` [00:30:58] did that, then tried git-review again, still getting the same message :-/ [00:31:17] ashley: Then the message is probably correct. [00:31:48] It means you are in a local branch that contains more than 1 commit (compared to master) [00:31:50] is that correct? [00:31:55] yep [00:32:10] And you want to submit them both to Gerrit (reviewed separately, one dependent on the other) [00:32:35] well https://gerrit.wikimedia.org/r/#/c/76282/ has already been submitted, it's only a matter of someone reviewing and approving it [00:32:52] * ashley eyes Reedy :P [00:33:02] ashley: If you didn't intend to change that one, verify the git hash is the same as on Gerrit, then just say 'yes' [00:33:22] If it is different, rebase on the hash of the change already in gerrit (476162a48c3cd92bf985b03daee74157f15bb87a) [00:37:07] "verify the git hash is the same as on Gerrit" -- sorry, how do I do this? this is all new to me and waaaaaaay over my head... [00:37:55] ashley: Check git log --oneline [00:38:04] You'll see the top 2 changes, which are yours [00:38:14] one which you intend to add, and one which is already submitted that you intend to build upon [00:38:58] unless you intended to overwrite that earlier one, you can verify that you didn't accidentially change that commit. You can do so by looking at the hash in your git log and comparing it to the hash on https://gerrit.wikimedia.org/r/#/c/76282/ [00:39:16] you'll see that yours says 476162, and the one on gerrit 476162a48c3cd92bf985b03daee74157f15bb87a [00:39:20] they match so go ahead :) [00:39:46] otherwise you would've done a diff and looked if the change is OK to override or alternatively `git rebase 476162a48c3cd92bf985b03daee74157f15bb87a` [00:39:57] to reject those changed and apply your top commit to that one instead [00:39:58] $ git log --oneline [00:39:59] d87a657 Add Renameuser support to CodeReview. [00:39:59] 476162a Correctly nest comments. [00:40:09] it's a match \o/ [00:41:12] (03PS1) 10Jack Phoenix: Add Renameuser support to CodeReview. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76320 [00:53:39] (03CR) 10TTO: "Fine about the comments, but I think most other locales keep the ymd/etc possibilities. So for consistency they should be staying here too" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [01:03:14] (03CR) 10TTO: "Also the user Calak at the bug seemed happy to have these included on behalf of the ckb community." [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [01:40:47] (03CR) 10Parent5446: "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [01:45:22] (03CR) 10Parent5446: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain) [02:06:24] (03PS1) 10Shirayuki: Add tags [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76321 [02:19:26] (03CR) 10Alex Monk: "(1 comment)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/59159 (owner: 10Alex Monk) [02:19:51] (03PS3) 10Alex Monk: Prompt the user to confirm a page change while an LQT edit form is open [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/59159 [03:32:40] (03PS3) 10TTO: Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 [04:06:12] (03PS1) 10Mwjames: Some renaming + some tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76322 [04:16:40] (03PS1) 10Mwjames: Rename to keep commit history [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76323 [04:18:26] (03CR) 10Mwjames: [C: 032] Rename to keep commit history [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76323 (owner: 10Mwjames) [04:19:46] (03Merged) 10jenkins-bot: Rename to keep commit history [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76323 (owner: 10Mwjames) [04:25:33] (03PS2) 10Mwjames: Some renaming + some tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76322 [04:28:44] (03CR) 10Mollywhite: [C: 032 V: 032] Add tags [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76321 (owner: 10Shirayuki) [04:37:32] (03CR) 10Parent5446: [C: 032] Code format cleanup [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/76063 (owner: 10Santhosh) [04:37:37] (03Merged) 10jenkins-bot: Code format cleanup [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/76063 (owner: 10Santhosh) [04:57:46] (03PS3) 10Mwjames: Some renaming + some tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76322 [05:07:13] That was me. [05:07:17] I hope it comes back. [05:07:30] Blessed be. [05:07:39] What did you do? [05:07:50] I restarted it. [05:07:51] * mooeypoo hands Elsie some tictacs [05:07:59] o: [05:08:02] oh, so much less anticlamactic than I expected. [05:08:15] -c there somewhere [05:08:47] anticlimactic [05:09:07] oh, I knew that looked wrong, but it wasn't the 'c' it was the 'a'. [05:09:40] Actually, I should've known. "Climate"... [05:09:42] bah. [05:10:05] https://wikitech.wikimedia.org/wiki/Grrrit-wm#Config_changes [05:10:07] I updated the docs. [05:10:10] But regardless, don't let that ruin my wit. I was good, just before botching my spelling. [05:10:59] I didn't understand the tictacs reference. Bad breath? [05:11:16] Yep, I thought that was especially fitting. [05:11:23] Well, the bot left and you said "That was me." [05:11:30] It was either a tictac or air freshener. [05:14:29] Ahh. [05:14:30] :-) [05:24:58] (03CR) 10Mwjames: [C: 032] Some renaming + some tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76322 (owner: 10Mwjames) [05:26:19] (03Merged) 10jenkins-bot: Some renaming + some tests [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76322 (owner: 10Mwjames) [05:36:09] ori-l: I'm butchering your lead again. :-/ [05:37:23] whatever floats your boat [05:38:31] It's very nearly at the level of conflict at which I lose interest [05:39:19] You sunk my battleship. [05:39:19] What kind of Wikipedian are you?! [05:39:43] I thought about the whole MediaWiki != Wikipedia thing, and while it's true, the suggestion that Wikipedia is just another installation or even just 'the largest installation' is insincere, as https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture makes patently clear. [05:40:49] it is by far the most immediate, obvious and compelling way to explain to readers what they're looking at. [05:41:08] That architecture document is heavily biased. [05:41:29] s/very nearly at/at/. [05:42:25] Lame. [05:43:58] https://www.mediawiki.org/w/index.php?title=README&diff=748861&oldid=748859 [05:45:22] ori-l: Do you have any thoughts about the FAQ and Category:Extensions links? [05:45:34] I like the edit, FWIW. [05:45:50] :-) [05:46:00] I think the whole document is significantly better than where we started. [05:46:45] I'm not sure about the links. Leaning towards keep for the FAQ and remove for Category:Extensions. [05:47:02] I'm not sure how to integrate either. [05:47:10] There's a FAQ file, BTW. [05:47:13] That just points to that URL. [05:47:41] how did you get 280 languages, btw? [05:48:02] https://wikimediafoundation.org/wiki/Wikipedia [05:48:22] mzmcbride@gonzo:messages$ pwd [05:48:22] /Users/mzmcbride/Downloads/mediawiki-latest/languages/messages [05:48:23] mzmcbride@gonzo:messages$ ls | wc -l [05:48:23] 373 [05:48:32] Though I think a lot of those are variants. [05:48:48] right, and some are so badly incomplete that we shouldn't boast about supporting them [05:49:03] $ ls | grep -v _ | wc -l [05:49:03] 316 [05:49:16] I imagine TranslateWiki has proper stats. [05:49:20] I think 100 is low, though. [05:49:42] 280 sounds true enough [05:50:10] Much like anything on Wikipedia, you just have to state it with authority and it'll become true. ;-) [05:50:15] 280[1][2][3] [05:50:23] heh [05:50:52] One of us should e-mail wikitech-l. [05:51:04] I think you just volunteered [05:51:34] Fine. [05:51:36] Elsie: Can you find someone who can review https://gerrit.wikimedia.org/r/#/c/75299/ ? [05:51:56] I'm not asking you to formally review that, but perhaps you can take a peek and make suggestions? [05:52:14] ok [05:53:27] what exactly is it doing? [05:54:03] making an edit via the API as the entity formerly known as edwardsbot [05:54:06] but why? [05:54:54] using the API automatically checks stuff like protection levels, block status, etc. it also automatically formats the edit summary and adds the header [05:55:13] https://www.mediawiki.org/wiki/Extension:MassMessage [05:55:21] https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=core-1.21&suppressempty=1#sortable:3=desc is actually a little depressing. [05:55:24] WikiPage::doEditContent overrides most of those checks [05:56:05] ori-l: I'm not sure what you're asking. [05:56:48] what is the edit that it's making? [05:57:02] It takes content from a Special page form. [05:57:14] legoktm can get the link to that code. [05:57:18] And then delivers that message via the job queue to the user [05:57:40] https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/SpecialMassMessage.php [05:58:19] Special page is a simple target list / subject / body form. [05:58:30] You preview the message and then send a delivery, which gets queued. [05:58:39] The editing part is commit 75299. [06:00:38] it's a little over my head, to be honest [06:00:50] and more than i feel capable of absorbing this late [06:01:01] Fair enough. [06:01:17] legoktm was asking me if I knew anyone who would be good to review it. [06:01:22] I actually can't think of anyone off-hand. [06:01:27] ori-l: Thanks for looking though [06:02:30] maybe niklas or someone in platform [06:02:59] I considered Nike, especially as this extension is modeled after TranslationNotification. [06:03:54] I added him and Reedy. [06:04:10] The whole extension has to go through review at some point anyway to be deployed. [06:04:25] So one way or another Platform is going to have to make sure it's sane enough. [06:04:50] legoktm: Did you clean up the unbound query thing? [06:05:14] No, I'm looking into that [06:05:30] K. [06:09:25] So if I understand this correctly, some of the refreshlinks2 jobs are basically just queuing more jobs, and the other ones actually run stuff. But I'm not sure what this has to do with fixing an unbound query.... [06:11:18] ori-l: E-mailed wikitech-l. [06:11:52] thanks! [06:12:00] http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070858.html [06:12:02] No problem. [06:12:08] yeah, i read it. [06:12:34] You're too fast for me. [06:14:55] (03PS1) 10Ori.livneh: Register NS_SCHEMA early if running on schema wiki [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/76326 [06:18:37] wow [06:18:47] I am apparently credited as author on BookManagerv2 [06:19:11] GorillaWarfare, that's extremely kind of you, but that's probably giving me too much credit and yourself not enough. [06:20:42] Elsie: everyone is too fast for you [06:20:47] Elsie: Have you had a chance to look at the new version of https://gerrit.wikimedia.org/r/#/c/74941/3 ? [06:24:13] legoktm: I'm not sure what the design philosophy is exactly. [06:24:26] I imagine some people are going to want to mix local page links and interwiki links. [06:24:39] Hm [06:24:43] * [[User:Foo]] \n * [[w:en:User:Bar]] [06:24:55] Which would present further problems for you, I imagine. [06:24:56] That wouldn't be hard to account for [06:25:03] Well, you'd need to de-dupe. [06:25:10] Er, why? [06:25:20] Let's say you're on Meta-Wiki. [06:25:20] [[User:Foo]] != [[w:en:User:Bar]].... [06:25:37] * [[User:Foo]] \n * [[m:User talk:Foo]] [06:25:50] Would the extension notice that those are the same? [06:25:52] What about... [06:25:59] [[w:User:Foo]] and [[w:en:User:Foo]] ? [06:26:03] Or... [06:26:13] I dunno, there are probably other crazy cases. [06:26:29] I'd recommend setting up tests. :-) [06:26:38] [11:25:37 PM] * [[User:Foo]] \n * [[m:User talk:Foo]] <-- that would be reasonably easy to fix [06:26:52] Yes. [06:26:54] Right now it can't parse double prefixes properly. [06:26:59] But I'm worried about regressions and such. [06:27:07] I think a testing infrastructure would serve the extension well. [06:27:15] Something where you can pass various input lists. [06:27:21] Sure [06:27:36] I'll have to look into how people write unit tests [06:27:38] I think the two functions (global and local) make sense, given the database. [06:27:43] Awesome. :-) [06:28:17] Once you have a format/structure, I'd be happy to help write some sample input lists. [06:28:18] And sample outputs. [06:28:57] So one of the issues with using interwiki prefixes is the double prefix issue. [06:29:39] So it reads w:, and then you go to en.wikipedia.org/wiki/en:User:blah, and then enwp parses en:, etc [06:29:56] Which means if you're on meta, you can't easily parse w:en:User:blah [06:30:10] Doesn't the API abstract that somehow? [06:30:36] No...? [06:30:54] I thought interwiki links were tracked now. [06:30:57] [[w:q:b:d:n:w:User:MZMcBride]] <-- valid link [06:31:07] Right. [06:31:39] https://test.wikipedia.org/wiki/Interwiki_links [06:32:30] So it would be much easier to just use external links [06:32:42] https://test.wikipedia.org/w/api.php?action=query&prop=iwlinks&titles=Interwiki%20links [06:32:49] Heh, I was about to say that. [06:32:54] But then people would format the links as http://en.wikipedia.org/wiki/User:Blah [06:33:10] using wfParseUrl you can break that down into "en.wikipedia.org" and "/wiki/User:Blah" [06:33:21] how do you know how to trim the /wiki/ to get the page title? [06:33:45] You don't. [06:34:08] This, by the way, is why I used a {{target}} template. ;-) [06:34:34] No regex is a design requirement :P [06:36:42] Hmmmmmm. [06:36:52] So, just brainstorming, one option is to provide your own parser function. [06:37:17] That would give you a defined format, similar to the target template. [06:37:21] {{#target|enwiki|User talk:blah}}? [06:37:22] yeah [06:37:25] Basically, yeah. [06:37:37] {{#target:en.wikipedia.org|user talk:blah}} [06:38:07] Going from url --> dbname requires SiteMatrix which I'd like to avoid [06:38:25] Users don't know database names. [06:38:33] The domain name they can figure out. [06:38:33] True [06:38:47] Also it makes it harder for making it human readable [06:38:54] It? [06:39:13] The output of the parser function [06:39:27] What's the first it? [06:39:41] So many its. [06:39:42] Oh, using database name [06:39:53] Right. I don't think database name --> URL is a big hurdle. [06:39:57] It's a very simple array. [06:40:11] That's already defined for you. [06:40:42] Even with a parser function, you'd need to define the article path. [06:40:54] I guess in a ... global configuration variable? [06:40:57] No you don't [06:41:01] You just need the article name [06:41:05] Er, full page name [06:41:14] How are you going to create a link to the page? [06:41:24] Oh [06:41:27] :-) [06:41:32] I was thinking of just using a message [06:41:48] If you go with a parser function, it adds complexity. [06:41:50] * [[//$1/wiki/{{urlencode:$2}}] [06:41:57] er, single bracket in the front [06:42:06] I think I'd offset the complexity by banning local page link support. [06:42:16] That is, always require {{#target:}}, then. [06:42:24] But I'm still not sure about a parser function. [06:42:29] Even for local deliveries? [06:42:32] Yes. [06:43:04] MediaWiki message isn't bad. [06:43:26] legoktm: If you use (only) a parser function, it also makes the de-duping much easier. [06:43:35] Yes [06:43:35] No more dealing with local and interwiki links. [06:43:47] One function to parse the input page and extract the targets. [06:43:51] How would we do automatic namespace conversion? [06:44:03] Or exclusion of namespaces? [06:44:04] What do you mean? [06:44:13] Hmmm. [06:44:17] User:blah --> User talk:blah [06:44:27] {{#target:en.wikipedia.org|Main Page}} [06:44:54] I'd be inclined to say "you wouldn't." [06:45:39] Users would be forced to specify an actual target. [06:45:45] Though local redirects would still be followed. [06:45:48] To a depth of one. [06:45:59] But {{#target:en.wikipedia.org|User:Foo}} would post to the User page. [06:46:05] Ok [06:46:15] You'd need to specify User talk: to get it to post to the User talk page. [06:46:24] Actually [06:46:25] As for limiting which namespaces it posts to... [06:46:27] It wouldn't be that hard. [06:46:37] I don't think namespace mapping is a good idea. [06:46:56] It makes sense if you're explicitly defining a user instead of a page. [06:47:05] Otherwise, it just creates a lot of ambiguity. [06:47:11] Does Project map to Project talk? [06:47:11] if ( $title->getNamespace == NS_USER ) { $title = Title::newFromThing( NS_USER_TALK, $title->getSomething() } [06:47:16] No [06:47:20] Right. [06:47:27] You want the notification on WP:VPT, not WT:VPT :P [06:47:28] So I would just say that the user has to provide a sane target. [06:47:32] Right. [06:47:42] But if you specify User, it'll go to User talk. [06:47:48] If you specify Project, it'll go to... Project. [06:47:53] I think the mapping is confusing. [06:48:16] It makes sense with {{target|user=}}, but if everything is just a generic target, just follow the target. [06:48:33] The only reason I supported {{target|user=}} was poor foresight on my part. [06:49:05] It ended up with people creating fake user accounts to redirect User talk pages to Project pages. [06:49:12] And eventually I added {{target|page=}}. [06:49:20] Let's just skip the user part altogether this time. ;-) [06:49:32] Heh [06:49:33] Ok [06:49:47] And local page links were a hack because I couldn't provide my own parser function. [06:50:02] I eventually created the abomination that is {{target}}. [06:50:03] But you have server-side access. [06:50:10] I'm liking this idea more. [06:50:21] I'm not sure what the parser function should be called. [06:50:27] I like the MediaWiki message idea a lot. [06:50:42] I'm also not sure what the format should be. [06:50:47] {{#foo:domain|page}} [06:50:51] {{#foo:page|domain}} [06:51:00] Either is reasonable. [06:51:30] I think this adds a bit of complexity, but simplifies the overall process. [06:52:13] I'm not sure anyone's going to like the idea of adding a parser function. [06:52:18] Esp. on all wikis. [06:52:21] Ok so I'm reading through the documentation, and I don't see how you extract this out of a page. The documentation is mainly geared to generating custom output [06:52:51] I think you have create a Parser object and then parse the page. [06:53:01] to create * [06:53:05] Yeah [06:53:11] I'm looking at that right now :P [06:53:33] ParserFunctions (the extension) does this with #time and shit. [06:53:38] I imagine you can look there, maybe. [06:53:50] Though it doesn't do extraction, exactly. [06:54:04] I'm trying to think of a comparable example. [06:54:14] https://www.mediawiki.org/wiki/Help:Magic_words [06:55:06] Yeah, I'm not quite sure how to extract the data, but it should be possible. [06:55:09] I think. Maybe. [06:57:09] (03PS1) 10Ori.livneh: Declare NS_BOOK namespace unconditionally [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76327 [06:57:54] 3 down, 1 to go. [07:05:21] Elsie: damn, you're fast, I was about to comment on that bug [07:05:26] it's a dupe. [07:21:37] Elsie: So I did some more digging. The Babel extension just uses categories: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FBabel/07be658000c3eb338b27f70a53caa0e260a246fd/Babel.class.php#L439 [07:24:00] mooeypoo: I have a lot of practice. ;-) [07:24:25] legoktm: It should be possible to parse arbitrary wikitext and extract parser functions. [07:24:30] (03PS1) 10Ori.livneh: Register NS_CAMPAIGN at file level in extension's entry point [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76328 [07:24:58] {{done}} [07:25:01] Elsie: I think so. MatmaRex would probably know [07:26:09] Elsie: why did you restart the bot, btw? [07:27:43] Yuvi|RanAway: So that I could write documentation. :-) [07:27:51] ah right [07:28:03] https://wikitech.wikimedia.org/wiki/Grrrit-wm#Config_changes [07:28:11] Yuvi|RanAway: breakfast is important! [07:28:14] I updated that section to be more explicit about "become" and such. [07:28:27] Before, it was a little hand-wavy. [07:28:28] ori-l: but it's 1 PM! [07:28:42] Elsie: yeah, thanks [07:28:43] No problem. [07:28:51] Yuvi|RanAway: yeah, but you probably just woke up :P [07:28:54] I'm just glad it worked. [07:29:08] ori-l: that is true. I'm feeling incredibly lazy though :) [07:29:13] After it quit, I was like "uhhh, probably should've done this when Yuvi was around." [07:29:20] (03PS2) 10Yuvipanda: Use proper paramterization and escaping of SQL query conditions [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76057 (owner: 10Legoktm) [07:30:14] http://bug-attachment.wikimedia.org/attachment.cgi?id=12990 [07:30:44] VisualEditor is slowly exposing how insane certain warnings are. [07:30:56] "By submitting this edit, your first-born is ours, bitches." [07:30:57] (03CR) 10Yuvipanda: [C: 032 V: 032] Use proper paramterization and escaping of SQL query conditions [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76057 (owner: 10Legoktm) [07:31:04] Grah. [07:31:06] parameterization [07:31:13] You missed an E. [07:31:15] FOREVER. [07:31:20] Oops. [07:31:28] Well I linked it to you yesterday! [07:32:01] I admit I only just noticed. [07:32:13] Still, rage. [07:33:01] (03Abandoned) 10Ori.livneh: Force re-cache of Canonical Namespaces [core] - 10https://gerrit.wikimedia.org/r/74523 (owner: 10SuchABot) [07:33:04] Well, there's always force pushing :P [07:33:05] I still haven't forgiven you for . [07:34:15] What's pywikibot-compat? [07:35:56] https://github.com/yuvipanda/gerrit-to-redis/blob/master/README.md [07:36:05] The markup is a bit wonky. [07:36:15] Elsie: yeah, forgot to add links [07:36:28] I hate markdown. [07:36:38] I should probably also delete that at some point, since there exists labs/tools/gerrit-to-redis now [07:36:39] Do I hate it? [07:36:45] I don't like it. [07:36:56] My dislike is exacerbated by GitHub's stupid parsing. [07:36:58] * Yuvi|RanAway quite likes it [07:37:09] GitHub apparently can't understand . [07:37:14] And it drives me fucking crazy. [07:37:57] Elsie: pywikibot-compat is the trunk branch from SVN. pwb-core is the /branches/rewrite [07:38:19] pywikipediabot still makes me pretty sad inside. [07:38:22] I try not to think about it. [07:39:25] Why? [07:39:29] The rewrite is pretty good [07:39:31] Er [07:39:32] core* [07:40:04] I haven't looked closely at the rewrite. [07:40:09] The original scared me away. [07:40:53] Yeah, wikipedia.py was pretty bad. Hence why it got rewritten :O [07:41:39] :P* [07:42:01] There were big and small things that bothered me. [07:42:09] .put() instead of .edit(). [07:42:20] Unicode handling. [07:42:48] I dunno. [07:42:55] In some ways, it was way ahead of its time. [07:43:00] It pre-dates the MediaWiki API. [07:43:26] It's page.save() now [07:43:41] Unicode handling in python generally sucked [07:43:44] It also had weird concepts about properties versus functions. [07:45:37] I'm not sure, you'll have to spend some time looking at the code now, its pretty different. [07:46:33] it's [07:46:42] page.exists() v. page.exists [07:46:46] That kind of thing, I mean. [07:50:56] Er no, that should be a function. [07:51:17] It's a property, isn't it? [07:52:10] No, it s a function [07:52:14] it's* [07:52:27] I mean: shouldn't it be a property? [07:52:44] If you have a page object, why would page existence be a function? It's a property. [07:54:48] Functions should be used where the is computation/IO/etc time taken, properties should be quick [07:55:14] * Elsie shrugs. [07:55:27] I preferred wikitools for things like this. [07:55:40] Because it establishes a page object, gets its properties, and then stores them. [07:55:50] As I understand it. [07:55:55] (And I really don't.) [07:56:48] A page object shouldn't fetch properties until you explicitly ask for them [07:57:20] Individually? [07:57:44] No, just in general [07:58:11] Doesn't establishing a page object imply that it'll come with properties? [07:58:22] Objects still kind of confuse me. [07:58:26] Like if you call .exists(), pwb will fetch things most basic page attributes (except for text), and store those internally [07:58:30] But an object without properties seems kind of silly. [07:58:33] Ideally they should be lazy [07:58:56] https://www.mediawiki.org/w/index.php?title=README&diff=748948&oldid=748861 [07:59:14] I think scalable and "suitable for both small and enterprise applications" is kind of redundant. [07:59:21] But I feel owner-y. [08:02:30] The third word being "popular" kind of feels weird to me as well. [08:03:00] Ah, found it [08:03:10] https://github.com/kennethreitz/requests/issues/1028#issuecomment-11474800 <-- difference between methods and properties [08:03:53] "you shouldn't get exceptions when accessing an attribute" [08:04:30] Calling .exists() can throw errors like invalidtitle, badpermission (if you dont have read access), etc [08:04:43] Or it can just return False. ;-) [08:05:36] But that would be wrong [08:05:37] legoktm: Have you given more thought to the parser function idea? [08:05:40] Would it? [08:05:46] Elsie: fixed that README [08:05:51] \o/ [08:06:13] for... some definition of 'fixd [08:06:14] ' [08:06:25] Elsie: I like it, and I've slowly been reading parser.php trying to figure out how to extract them [08:06:31] https://github.com/yuvipanda/gerrit-to-redis/blob/master/README.md [08:13:21] legoktm: How do you extract a single parser function? [08:13:31] Er, what do you mean? [08:13:49] If I have {{#foo:bar}} on a page, do you know how I'd extract "bar"? [08:13:59] No, that's what I'm looking into [08:14:08] Okay. [08:14:18] parserfunctions are primarily geared to modifying output rather than storing data [08:15:23] Tell that to DEFAULTSORT:! [08:17:09] Hm. [08:18:34] https://github.com/wikimedia/mediawiki-core/blob/dfb07c036f9b46d65ecb78f550bad5d48b9b2a12/includes/parser/Parser.php#L5705 [08:20:02] So it just sets it and then retrieves it? [08:20:08] Seems really straightforward. [08:20:16] Yeah. [08:21:07] So rather than setting a string like defaultsort does, you'd return a k/v array, right? [08:21:14] Yes. [08:21:24] I wonder if setProperty() supports that. [08:21:41] $this->mOutput = new ParserOutput; [08:24:07] (03CR) 10Edokter: "To explain my reason for the padding: it is currently the only 'boxed' content that has such a wide padding compared to other boxes, so do" [core] - 10https://gerrit.wikimedia.org/r/75643 (owner: 10Krinkle) [08:25:51] https://github.com/wikimedia/mediawiki-core/blob/dfb07c036f9b46d65ecb78f550bad5d48b9b2a12/includes/parser/ParserOutput.php#L406 [08:27:09] That should work. [08:29:26] (03PS1) 10Ori.livneh: $wgHooks: add closure docs & admonition to register handlers early [core] - 10https://gerrit.wikimedia.org/r/76330 [08:45:49] (03PS4) 10Release notes rebase bot: Have separate timeouts for upload by url ($wgCopyUpload[Async]Timeout) [core] - 10https://gerrit.wikimedia.org/r/67229 (owner: 10Brian Wolff) [08:49:30] (03PS3) 10Nemo bis: Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 [08:50:01] (03CR) 10jenkins-bot: [V: 04-1] Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [08:56:33] (03PS4) 10Nemo bis: Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 [08:57:34] (03CR) 10Nemo bis: "Krinkle, ok, done. I just initially didn't like the idea of adding yet another lego message." [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [08:57:45] pung. [08:58:22] pang. [08:59:15] Ohai MatmaRex [08:59:21] I have a parser question for you [08:59:43] If I have a parser function like {{#target:url|page}}, is there an easy way to extract all uses of that from a page? [08:59:52] (03PS3) 10Release notes rebase bot: Add support for skin classes that are not prefixed with 'Skin'. [core] - 10https://gerrit.wikimedia.org/r/56426 (owner: 10Daniel Friesen) [09:00:49] MatmaRex: ^ [09:01:01] legoktm: if you store those as pareproperties, yes [09:01:09] !wp special:pageswithprops [09:01:09] https://en.wikipedia.org/?title=special%3apageswithprops [09:01:14] !wp special:pageswithprop [09:01:14] https://en.wikipedia.org/?title=special%3apageswithprop [09:01:20] page properties* [09:01:24] i can't type, sorry [09:01:43] (03PS2) 10Release notes rebase bot: Always send headers with a 304 response in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74400 (owner: 10Catrope) [09:01:44] in core for example {{defaultsort: is handled in this way [09:02:17] I don't think thats going to work since we were thinking of having the parserfunction used multiple times for page [09:02:51] well, then you'd have to get a little clever and store serialized data in page props or something [09:03:29] :/ [09:03:44] (03PS19) 10Release notes rebase bot: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [09:03:44] I don't think thats a very good idea if we're talking about 2k uses per page [09:04:05] heh, i dunno [09:04:15] you can store 65k bytes of data in a page prop [09:04:23] lol [09:04:48] you can also compress it before storage [09:05:07] i have a patch that does that for E:TemplateData, because it failed on exra-large templates :D [09:05:35] (03PS5) 10Release notes rebase bot: $wgHTCPMulticastRouting rename + multi hosts support [core] - 10https://gerrit.wikimedia.org/r/71597 (owner: 10Hashar) [09:06:09] What if we just stored it as an array with ParserOutput::setProperty? [09:06:20] And then used getProperties? [09:07:23] legoktm: i don't think that's saved in the database [09:07:34] so if you only need it for the length of a request, it'd do [09:07:43] (or maybe that is saved in page_props, i'm notsure right now) [09:07:48] it'll do* [09:08:10] Oh yeah, we just need to access it in a special page [09:09:23] (03PS1) 10Karima Rafes: Add tag extension lwgraph to insert a graph in the page (first graph : horizontal flow graph) [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/76331 [09:11:19] I'll play with it a bit [09:13:29] (03PS16) 10Release notes rebase bot: New more slick gallery display [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [09:16:03] (03CR) 10Karima Rafes: [C: 032 V: 032] Add tag extension lwgraph to insert a graph in the page (first graph : horizontal flow graph) [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/76331 (owner: 10Karima Rafes) [09:17:03] (03PS12) 10Release notes rebase bot: Correct section anchor for post-edit redirect [core] - 10https://gerrit.wikimedia.org/r/55508 (owner: 10IAlex) [09:19:00] (03PS2) 10Release notes rebase bot: Make wfMatchesDomainList not match partial domains [core] - 10https://gerrit.wikimedia.org/r/72312 (owner: 10PleaseStand) [09:24:12] (03CR) 10Matmarex: [C: 032] Make wfMatchesDomainList not match partial domains [core] - 10https://gerrit.wikimedia.org/r/72312 (owner: 10PleaseStand) [09:26:43] (03Merged) 10jenkins-bot: Make wfMatchesDomainList not match partial domains [core] - 10https://gerrit.wikimedia.org/r/72312 (owner: 10PleaseStand) [09:56:12] (03PS1) 10Legoktm: [WIP] Parse the input list using parser functions [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 [09:56:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Parse the input list using parser functions [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 (owner: 10Legoktm) [09:57:19] meh. [09:57:24] MatmaRex: what do you think of ^ [09:57:30] just as a concept [10:03:27] legoktm: looking [10:03:35] thanks [10:06:10] (03CR) 10Matmarex: "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 (owner: 10Legoktm) [10:07:15] Hm [10:07:41] MatmaRex: I just copied the hook part from https://www.mediawiki.org/wiki/Manual:Parser_functions#Simple_example [10:08:21] legoktm: i meant the way you specify function name [10:08:37] Oh. Yeah I'm missing a : there [10:08:39] first, there should be two colons, not one [10:08:44] and i'm not sure if that works anyway [10:08:47] you might need… [10:09:08] $parser->setFunctionHook( 'target', array( 'MassMessageHooks', 'ParserFunction' ) ); [10:09:28] just check which version works. :D [10:10:45] ok :P [10:13:00] (03PS4) 10Ori.livneh: Support inter-page JSON references [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/68941 [10:13:59] (03PS6) 10Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - 10https://gerrit.wikimedia.org/r/75343 [10:34:47] (03CR) 10Liangent: "Anomie:" [core] - 10https://gerrit.wikimedia.org/r/74977 (owner: 10Liangent) [10:37:08] (03PS1) 10Ori.livneh: Enable 'box_download_insecure' if Vagrant 1.2.6+ [vagrant] - 10https://gerrit.wikimedia.org/r/76339 [10:38:15] (03CR) 10Ori.livneh: [C: 032] Enable 'box_download_insecure' if Vagrant 1.2.6+ [vagrant] - 10https://gerrit.wikimedia.org/r/76339 (owner: 10Ori.livneh) [10:38:17] (03Merged) 10jenkins-bot: Enable 'box_download_insecure' if Vagrant 1.2.6+ [vagrant] - 10https://gerrit.wikimedia.org/r/76339 (owner: 10Ori.livneh) [10:45:04] (03CR) 10Zaran: [C: 04-1] "(2 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [10:49:14] (03PS1) 10Liangent: Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 [10:51:53] (03CR) 10jenkins-bot: [V: 04-1] Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent) [11:09:11] (03PS2) 10Liangent: Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 [11:11:13] (03PS3) 10Liangent: Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 [11:13:43] (03CR) 10jenkins-bot: [V: 04-1] Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent) [11:35:14] (03PS4) 10Liangent: Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 [11:37:34] (03CR) 10jenkins-bot: [V: 04-1] Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent) [11:52:37] (03PS5) 10Liangent: Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 [11:55:07] (03CR) 10jenkins-bot: [V: 04-1] Failing parser tests with LanguageConverter applied [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent) [12:15:35] (03PS6) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [12:18:00] (03PS2) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [12:18:01] (03PS10) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [12:52:01] (03PS6) 10Liangent: LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 [12:52:54] (03CR) 10jenkins-bot: [V: 04-1] LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 (owner: 10Liangent) [12:53:35] (03PS12) 10Liangent: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 [12:58:41] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [13:10:08] (03CR) 10Zaran: [C: 04-1] "(4 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [13:36:01] (03CR) 10Sumanah: "Just noting that I ran into this bug: bug 52191 has a screenshot. Since this is part of the account creation workflow I'm going to ask Ste" [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [13:46:33] (03PS2) 10TheDJ: All non-custom toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 [13:46:53] (03PS3) 10TheDJ: All non-custom toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 [13:47:51] (03CR) 10TheDJ: "Amended commit message to clarify that it only applies to non-custom togglers." [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [13:48:54] thedj[work]: hm, wouldn't it be better to actually apply that style to all togglers? ^ [13:51:36] (03CR) 10Matmarex: "Wouldn't it be better to actually apply that style to all togglers?" [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [13:54:39] (03PS1) 10Tpt: Improve EditProofreadIndexPage code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/76344 [13:55:07] (03PS1) 10TheDJ: Use one call to .attr instead of two and linebreak consistency [core] - 10https://gerrit.wikimedia.org/r/76345 [13:55:49] (03CR) 10TheDJ: "@Krinkle: followup in https://gerrit.wikimedia.org/r/#/c/76345/" [core] - 10https://gerrit.wikimedia.org/r/72259 (owner: 10TheDJ) [14:04:05] (03CR) 10Reedy: [C: 04-1] "(1 comment)" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76320 (owner: 10Jack Phoenix) [14:04:14] (03CR) 10Tpt: [C: 04-1] "(9 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 (owner: 10Rtdwivedi) [14:07:47] any idea why https://gerrit.wikimedia.org/r/#/c/76329/ does not get merged? [14:07:50] qchris: ^ [14:08:59] Yuvi|RanAway: I am not sure about our Jenkins setup. [14:09:30] YuviPanda: Does Jenkis automatically pick up all V+2, C+2 comments? [14:09:34] (On all projects?) [14:09:43] qchris: no I think it has to be specifically configured [14:09:54] you created that repo y'day, so I guess no jenkins on it [14:10:06] I did not set up any jenkins on it. [14:10:29] But you could submit by hand I guess? [14:10:33] yeah, so I guess no jenkins [14:10:38] qchris: I have been hitting 'submit' multiple times [14:10:40] nothing happens [14:10:49] :-D [14:10:57] qchris: actually, I don't know if I see a 'submit' button [14:11:02] do I have perms to submit on that repo? [14:11:11] Let me check ... [14:13:23] I set it up just like the other labs/tools projects were set up. [14:13:33] Turns out, you do not have submit permission [14:14:07] qchris: ah, can you grant me? [14:14:17] Was just about to do that ... [14:14:41] (03CR) 10Steinsplitter: [C: 031] Make jquery.autosize aware of style changes [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 (owner: 10Rillke) [14:15:12] YuviPanda: Can you submit now? [14:15:28] qchris: yup! :D [14:15:37] qchris: can you grant me submit for the other ones too? [14:15:49] YuviPanda: Yes. [14:15:52] qchris: ty! [14:17:06] qchris: merged. ty! [14:17:45] yw. Ganno ask ^demon about his policy on granting submit vs. forcing to set up Jenkins. [14:17:51] qchris: yeah :) [14:17:52] s/Ganno/Gonna/ [14:21:20] (03PS2) 10TheDJ: Move unsortable class into tablesorter config [core] - 10https://gerrit.wikimedia.org/r/74500 [14:22:32] (03PS1) 10Yuvipanda: [WIP] Move away from ActionBarSherlock into AppCompat [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76346 (via SuchABot) [14:23:13] (03CR) 10TheDJ: "removed dependency" [core] - 10https://gerrit.wikimedia.org/r/74500 (owner: 10TheDJ) [14:26:21] (03CR) 10TheDJ: [C: 032] jquery.makeCollapsible: Tests for collapse and expand text [core] - 10https://gerrit.wikimedia.org/r/74959 (owner: 10Matmarex) [14:26:22] (03Merged) 10jenkins-bot: jquery.makeCollapsible: Consistency in test names [core] - 10https://gerrit.wikimedia.org/r/74962 (owner: 10Matmarex) [14:40:43] (03CR) 10Rillke: "> If you can get rid of the "|| ''" for the latInput and" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75595 (owner: 10Rillke) [14:52:31] (03CR) 10Yuvipanda: "Will test and merge when I'm at a computer next. Should be done at worst by monday." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75595 (owner: 10Rillke) [15:06:09] (03CR) 10Matmarex: [C: 032] Move unsortable class into tablesorter config [core] - 10https://gerrit.wikimedia.org/r/74500 (owner: 10TheDJ) [15:08:39] (03Merged) 10jenkins-bot: Move unsortable class into tablesorter config [core] - 10https://gerrit.wikimedia.org/r/74500 (owner: 10TheDJ) [15:14:47] (03PS2) 10Matmarex: Tablesorter: Remove some config variables and docs that are not in use [core] - 10https://gerrit.wikimedia.org/r/74501 (owner: 10TheDJ) [15:15:04] (03CR) 10Matmarex: [C: 04-1] "Needs release notes." [core] - 10https://gerrit.wikimedia.org/r/74501 (owner: 10TheDJ) [15:25:51] (03PS11) 10Dan-nl: initial draft [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 [15:30:50] (03PS2) 10Jack Phoenix: Add Renameuser support to CodeReview. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76320 [15:31:48] Reedy: ^^maintenance script added + comment in CodeReviewHooks.php fixed, as per your code review [15:35:38] maintenance scripts are for sissies, real men execute SQL from command line [15:36:22] (03Abandoned) 10MarkAHershberger: Fix a typo [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/76303 (owner: 10MarkAHershberger) [15:40:14] (03CR) 10Hoo man: [C: 032] ":)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76314 (owner: 10Legoktm) [15:40:15] (03Merged) 10jenkins-bot: Remove call to deprecated MWInit::methodExists with method_exists [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76314 (owner: 10Legoktm) [15:53:42] \o/ just updated https everywhere and now it works for wikivoyage :) [15:55:10] I wish it wasn't necessary to keep a config file for each HTTPS-enabled site [15:55:23] or group of sites in our case [16:00:05] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76306 (owner: 10Nemo bis) [16:01:43] (03PS1) 10Ebrahim: Add Nazli font for Persian Script [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 [16:02:07] hoo: I did tell you I fixed it a while ago :p [16:02:29] e.g. our one is https://gitweb.torproject.org/https-everywhere.git/blob/HEAD:/src/chrome/content/rules/Wikimedia.xml [16:02:35] why is securecookie only for wikipedia [16:03:07] Reedy: I know, but https everywhere sucks on this [16:03:35] I like how it shows the Wikipedia W with Wikimedia on the used rulesets [16:03:35] if you try to view a rule it shows you the rule from git master rather than the one you are actually using :P [16:03:49] and why doesn't https work on ^http://lists\.wikimedia\.org/pipermail(?:$|/) [16:04:40] (03CR) 10Nikerabbit: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76345 (owner: 10TheDJ) [16:04:41] Krenair: Lists was http only until some time ago AFAIR [16:04:43] no cert? [16:05:23] https://lists.wikimedia.org/mailman/listinfo works [16:06:06] Try to visit the archives (pipermail) via HTTPS and it just redirects you to HTTP though [16:31:58] (03CR) 10Ladsgroup: [C: 031] "Nazli is a good font for Persian" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 (owner: 10Ebrahim) [16:32:38] (03CR) 10Swalling: "I've added S Page as a reviewer. He's seen and dealt with similar error parsing issues on account creation/login, so he'll probably be a g" [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [16:32:44] (03PS2) 10Ebrahim: Add Nazli font for Persian Script [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 [16:41:18] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75270 (owner: 10Catrope) [16:44:13] (03PS5) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [16:44:14] (03CR) 10jenkins-bot: [V: 04-1] Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [16:58:48] (03PS6) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [17:01:32] (03PS7) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [17:10:12] (03CR) 10Rjain: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain) [17:27:58] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/75270 (owner: 10Catrope) [17:47:37] (03CR) 10Zaran: [C: 031] "The documentation of importContentFormData in the EditPage class is a bit confusing, but return a string instead of setting is indeed bett" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/76344 (owner: 10Tpt) [18:00:03] (03PS1) 10Mollywhite: Remove "pages" property from the JSON schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76353 [18:00:55] (03CR) 10Mollywhite: [C: 032 V: 032] Remove "pages" property from the JSON schema. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76353 (owner: 10Mollywhite) [18:08:20] whaat [18:08:24] my mail was rejected! [18:08:26] to wikitech-l! [18:10:11] * Yuvi|Away looks around to find someone to blame [18:16:09] (03PS2) 10Nemo bis: 4-digits numbers in Spanish should not have a group separator [core] - 10https://gerrit.wikimedia.org/r/76306 [18:16:41] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76306 (owner: 10Nemo bis) [18:17:49] (03PS1) 10Rasel160: WIP loads templates using Extention TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76355 [18:25:04] (03CR) 10Matmarex: [C: 031] Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 10Nemo bis) [18:25:58] (03CR) 10Matmarex: [C: 04-1] "It mostly needs to be rewritten." [core] - 10https://gerrit.wikimedia.org/r/64615 (owner: 10Matmarex) [18:28:15] (03PS7) 10Matmarex: (bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [18:31:15] (03CR) 10MarkTraceur: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76355 (owner: 10Rasel160) [18:38:47] (03CR) 10Nemo bis: "Again needing rebase. :(" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 (owner: 10Matthias Mullie) [18:43:23] (03PS1) 10Rasel160: WIP loads templates with Extention TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [18:45:55] (03Abandoned) 10Rasel160: WIP loads templates using Extention TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76355 (owner: 10Rasel160) [18:50:06] (03CR) 10Tpt: [C: 032] "Minor change reviewed by Zaran." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/76344 (owner: 10Tpt) [18:50:13] (03Merged) 10jenkins-bot: Improve EditProofreadIndexPage code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/76344 (owner: 10Tpt) [18:54:00] (03CR) 10Mollywhite: [C: 031 V: 031] "Looks good to me, but I'm going to wait for a review by mwalker before merging :)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76327 (owner: 10Ori.livneh) [19:01:58] (03PS2) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [19:03:22] (03PS1) 10Karima Rafes: Add a special page for the Flint Sparql Editor and fix bugs [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/76358 [19:05:20] (03CR) 10Karima Rafes: [C: 032 V: 032] Add a special page for the Flint Sparql Editor and fix bugs [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/76358 (owner: 10Karima Rafes) [19:10:15] (03PS3) 10Rasel160: WIP loads templates with Extension TemplateData [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/76356 [19:36:41] Hello, I have 1143 errors in Jenkins about javascript... are there a tool to help me to clean my code ? [19:38:03] karima, can you send me a link? [19:38:17] https://integration.wikimedia.org/ci/job/mwext-LinkedWiki-jslint/6/consoleFull [19:39:50] karima, well you can use .jshintrc to configure which warnings you get [19:40:35] Also note that there's a lot more than 1143 errors - see the "Too many errors" lines [19:40:52] Yes I saw ;) [19:41:43] there are not tool for that ? [19:44:16] (03CR) 10Nilesh: "(6 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76035 (owner: 10Nilesh) [19:44:41] (03CR) 10Nilesh: "(1 comment)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76034 (owner: 10Nilesh) [19:44:48] Krenair : thanks I will look .jshintrc bye [19:45:03] I'm not sure about tools for automated cleaning, sorry karima [19:45:08] bye [19:45:17] ok ++ [19:56:23] (03PS1) 10Mollywhite: Change back to using dot concatenation. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76451 [20:00:27] (03PS1) 10Orsagi: login demo mwapi dependent [apps/android/translate] - 10https://gerrit.wikimedia.org/r/76452 [20:03:53] (03CR) 10Daniel Kinzler: "(4 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76035 (owner: 10Nilesh) [20:05:31] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76034 (owner: 10Nilesh) [20:11:05] (03CR) 10Orsagi: [C: 032 V: 032] login demo mwapi dependent [apps/android/translate] - 10https://gerrit.wikimedia.org/r/76452 (owner: 10Orsagi) [20:16:04] (03PS2) 10TheDJ: Use one call to .attr instead of two and linebreak consistency [core] - 10https://gerrit.wikimedia.org/r/76345 [20:24:21] (03PS15) 10Rtdwivedi: Addition of code that will be used for setting up of editing system in PHP instead of JS. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 [20:24:22] (03PS3) 10Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76307 [20:24:23] (03PS11) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [20:27:53] (03CR) 10Krinkle: "(2 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/72933 (owner: 10Rtdwivedi) [20:35:03] (03CR) 10Nilesh: "(1 comment)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/76034 (owner: 10Nilesh) [20:35:33] (03PS6) 10Matthias Mullie: i18n issues reported on https://translatewiki.net/wiki/User:Mlitn [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/56877 [21:07:06] (03PS1) 10Mollywhite: Bug 51194: Localize the publication date in the metadata. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76454 [21:08:56] (03PS2) 10Nikerabbit: Improve documentation for $wgRecentChangesFlags [core] - 10https://gerrit.wikimedia.org/r/74659 (owner: 10Umherirrender) [21:21:07] (03PS1) 10Jack Phoenix: Comments: version 2.8 with lots of changes. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/76455 [21:23:08] (03CR) 10Jack Phoenix: [C: 032 V: 032] Comments: version 2.8 with lots of changes. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/76455 (owner: 10Jack Phoenix) [21:23:34] (03PS2) 10Nikerabbit: TypeError: window.navigator.userLanguage is undefined [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73448 (owner: 10Umherirrender) [21:26:44] (03CR) 10Krinkle: [C: 04-1] "(4 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [21:30:03] (03CR) 10Krinkle: "(2 comments)" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73448 (owner: 10Umherirrender) [21:41:05] (03CR) 10Umherirrender: "Changes from Patch Set 1 to 2 looks good." [core] - 10https://gerrit.wikimedia.org/r/74659 (owner: 10Umherirrender) [21:41:59] (03CR) 10Umherirrender: "(1 comment)" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/73448 (owner: 10Umherirrender) [22:04:20] No sir, https://en.wikipedia.org/wiki/Copyright is not a valid license for "All rights reserved", it is a page explaining the concept of copyright which you ironically didn't appear to understand. [22:12:59] Krinkle: may I ask whom you are talking to? [22:13:10] Nobody, just an observation. [22:13:35] I often notice these silly things on websites from people just doing things without having the slightest clue of what they're doing. [22:13:53] like writing