[00:00:02] (03CR) 10Mattflaschen: "It turns out we can set readOnly: true so anons can still view annotations. I wrote some quick documentation at https://github.com/okfn/a" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 07Rjain) [00:08:15] (03PS1) 10Ori.livneh: Increase vertical offset of post-edit confirmation in MonoBook [core] - 10https://gerrit.wikimedia.org/r/76222 [00:21:03] (03CR) 10Adamw: "Parent5446: Thanks for taking a look. I should probably create a bugzilla tracker to discuss this." [core] - 10https://gerrit.wikimedia.org/r/76208 (owner: 07Adamw) [00:30:33] (03CR) 10Parent5446: "Indeed, and I apologize for the sort of harsh -2. Once some discussion takes place we'll see where it goes." [core] - 10https://gerrit.wikimedia.org/r/76208 (owner: 07Adamw) [00:30:59] (03PS1) 10Ori.livneh: For clarity, use PyYAML to generate output of puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/76224 [00:31:56] (03CR) 10Ori.livneh: [ C: 122] For clarity, use PyYAML to generate output of puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/76224 (owner: 07Ori.livneh) [00:31:56] (03Merged) 10jenkins-bot: For clarity, use PyYAML to generate output of puppet-classifier [vagrant] - 10https://gerrit.wikimedia.org/r/76224 (owner: 07Ori.livneh) [01:06:24] (03CR) 10Adamw: "Not at all! -2 usually means I've come across something interesting ;)" [core] - 10https://gerrit.wikimedia.org/r/76208 (owner: 07Adamw) [01:45:46] (03PS1) 10Reedy: Remove UploadBlacklist [tools/release] - 10https://gerrit.wikimedia.org/r/76230 [01:46:41] (03PS2) 10MZMcBride: Remove UploadBlacklist [tools/release] - 10https://gerrit.wikimedia.org/r/76230 (owner: 07Reedy) [01:48:40] Who needs consensus when we have Reedy? Now seriously... do we have consensus for that? :P [01:48:44] Elsie: ^? [01:49:02] Consensus? [01:49:02] The the extension hasn't done anything useful this year [01:49:19] caffeineexcess: Eh, there's no rush to merge/deploy. :-) [01:49:26] We can wait a week or two for objections. [01:49:28] That's a somewhat valid point [01:49:44] Considering it's a Friday night/Saturday morning... Otherwise I would've deployed it [01:49:45] I thought it's still blocking around 10-15 image hashes [01:49:54] it is [01:50:01] But not hits/attempts to upload those images this year [01:50:01] It's blocking them in theory, not in practice. [01:50:14] And even if there are bad uploads, we have the AbuseFilter. [01:50:37] Which is painfully slow if you want to filter against more than a few hashes :/ [01:50:50] But I guess that approach doesn't scale to well either [01:50:56] Still more useful than the extension is being currently [01:50:58] Errrrrr. [01:51:01] Why is it slow? [01:51:12] Nothing about it should be slow. [01:51:12] And local admins can block them [01:51:23] rather than a bug, a changeset, a deploy.. [01:51:24] Elsie: Because the AbuseFilter parser has to iterate over every char [01:51:38] In the hash? [01:51:45] It doesn't support an array or dict or something? [01:51:45] Yep [01:51:52] Well, that's AbuseFilter stupidity. :-) [01:51:59] It does... but it still has to parse them... which is expensive [01:52:02] Lua for AbuseFilter! [01:52:19] Kill AbuseFilter... I'm saying that as the maintainer... [01:52:36] What would you prefer? [01:52:41] I got like so many better ideas... and yet have so few time to work on [01:53:13] An abstract interface to observe actions of various kind which we could then hook into with various backends/ parsers [01:53:28] like the old parser, Lua, titleblacklist, spamblacklist, ... [01:54:18] With a centralized hook interface and centralized logging [01:54:37] [01:55:10] You'll need a lot more caffeine [01:55:42] Funny thing is, I didn't have any caffeine today and I'm still alive [01:55:55] on the other side, I'm not working much right now either :D [02:20:51] (03PS1) 10Shirayuki: Add a full-stop [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76231 [02:23:37] (03PS2) 10Shirayuki: Add a full-stop [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76231 [02:31:14] (03PS1) 10TTO: (bug 52009) set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 [02:52:05] (03PS1) 10Shirayuki: Add full-stops to the messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76233 [02:58:52] (03CR) 10Brian Wolff: "What specifically?" [core] - 10https://gerrit.wikimedia.org/r/67229 (owner: 07Brian Wolff) [03:00:21] dejavu https://www.mediawiki.org/wiki/MediaWiki_architecture_document [03:00:29] https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture [03:00:36] robla: Tim-away: [03:01:56] (03PS2) 10Parent5446: (bug 52009) set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 07TTO) [03:51:26] (03PS1) 10Mwjames: \SMW\HooksLoader and \SMW\MediaWikiHook [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76234 [03:56:34] (03PS2) 10Mwjames: \SMW\HooksLoader and \SMW\MediaWikiHook [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76234 [04:09:17] (03CR) 10Mwjames: [ C: 122] "Well, I'm charging forward since this is bugging me for some time now because MW's hooks testing environment sucks ..." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76234 (owner: 07Mwjames) [04:10:38] (03Merged) 10jenkins-bot: \SMW\HooksLoader and \SMW\MediaWikiHook [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76234 (owner: 07Mwjames) [04:20:23] (03CR) 10Krinkle: "Perhaps do it in that extension though? I mean, this repo is empty. And the code you'd add will have nothing to do with HotCat code-wise (" [extensions/HotCat] - 10https://gerrit.wikimedia.org/r/75534 (owner: 07Parent5446) [04:47:40] (03PS1) 10Santhosh: Compress the eot font more using microtype express compression [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76236 [05:38:03] (03PS1) 10Brian Wolff: Add Special:UnwatchedChanges page. [core] - 10https://gerrit.wikimedia.org/r/76238 [06:00:06] (03PS1) 10Krinkle: jquery.placeholder: Fixup for 7ec7d879ee [core] - 10https://gerrit.wikimedia.org/r/76239 [06:11:46] Krinkle: do I need to explicitly add the jquery.ui module? I can't find this in the docs, and doing $('#elid').dialog(); doesn't work [06:12:06] it's included in the default modules, it says.. but it doesn't work :\ [06:12:29] We don't load 217 modules by default [06:12:35] we define 217 modules by default [06:12:48] yeah I figured as much, but how do I know what the name of the module is? [06:13:05] http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jQuery_UI <-- just the name without .js ? [06:13:08] Add a dependency on jquery.ui.dialog (if you're using $.fn.dialog) and jquery.ui.button for button() etc. [06:13:12] so.. jquery.ui.core ? [06:13:13] see Resources.php for a complete list [06:13:15] no [06:13:19] never depend on that [06:13:27] unless you're using jQuery()._uicore() [06:13:36] which you probably aren't [06:13:38] oh, okay. I thought that brings 'em all. [06:13:46] no, but I'll likely use dialog and some others. [06:13:54] nope, it doesn't bring any of them. .core is the internal framework of jquery ui that all jquery ui plugins use [06:14:06] I see, ok. [06:14:20] a common dependency between them. automatically loaded if you load ui.dialog, ui.button or which ever [06:15:20] * mooeypoo nods [06:18:09] woo [06:18:14] works now :D thanks Krinkle [06:23:48] yw [07:07:24] * Elsie tickles ori-l. [07:09:14] guillom: Hi. [07:09:26] Hello, Elsie. [07:09:56] guillom: https://bugzilla.wikimedia.org/show_bug.cgi?id=50552 [07:12:48] Elsie: What should I do with that? [07:13:31] guillom: Help! [07:13:49] guillom: do what you do every night? attempt to take over the world? [07:14:17] same thing we do every night, pinky^Wp858snake|l [07:15:25] Same thing I do every night. I go to bed early, because (to paraphrase a French saying) the world belongs to early birds. [07:15:50] the early bird gets the worm [07:15:50] apergos: :) [07:16:04] as a vegetarian I try to sleep in :-P [07:16:08] (however I usually fail) [07:16:14] Elsie: meh. It seems that they're doing fine without me. [07:16:37] guillom: No emo shit. [07:16:37] https://www.mediawiki.org/wiki/README [07:16:40] (03PS1) 10Legoktm: 'Cleaning up unused variables in the global space [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76243 [07:16:49] apergos: The second mouse gets the cheese. [07:16:51] it worked :D [07:17:04] ish, [07:17:31] (03PS2) 10Legoktm: 'Cleaning up unused variables in the global space [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76243 [07:17:33] Elsie: I'm lazy. It's the week-end. It's sunny outside. You can't tell me what to do. You're not my real dad. [07:17:44] :-) [07:19:55] I like cheese. think i'll adopt that strategy [07:20:34] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/76244 [07:23:34] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/76245 [07:26:54] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Ads] - 10https://gerrit.wikimedia.org/r/76246 [07:27:32] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Agora] - 10https://gerrit.wikimedia.org/r/76247 [07:28:35] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/76248 [07:29:35] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/76249 [07:29:56] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/76250 [07:30:15] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/76251 [07:30:35] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/APC] - 10https://gerrit.wikimedia.org/r/76252 [07:31:14] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/76253 [07:31:32] legoktm: Bug:, with a colon. [07:31:42] Elsie: If I do that, it'll spam the bug [07:32:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=47514#c3 [07:32:18] There are 484 extensions my script will do, and about 100 that might need to be done by hand [07:32:26] or will need guidance [07:32:58] You have a preceding space before "Cleaning up". [07:33:33] Hm. [07:34:48] Elsie: If I hit the edit message button in gerrit, it removes the space :/ [07:36:19] I'm not really sure how its getting added [07:36:31] it's [07:36:38] sigh. [07:36:39] RAN: '/usr/local/bin/git commit -m Cleaning up unused variables in the global space\n\nBug 47514' [07:37:07] Well, lets see what happens if I remove the space. [07:37:16] legoktm: it should be Bug:47514 btw [07:37:24] Already said that. [07:37:29] p858snake|l: [12:31:41 AM] Elsie: If I do that, it'll spam the bug [07:37:29] [12:32:00 AM] https://bugzilla.wikimedia.org/show_bug.cgi?id=47514#c3 [07:37:47] You can still search it by topic: so it's not that big of an issue [07:38:22] https://gerrit.wikimedia.org/r/#/q/topic:bug/47514,n,z [07:38:44] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/ApiSVGProxy] - 10https://gerrit.wikimedia.org/r/76254 [07:38:56] Hm. [07:38:58] Guess that worked [07:39:51] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/76255 [07:40:16] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/76256 [07:41:27] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AssertEdit] - 10https://gerrit.wikimedia.org/r/76257 [07:42:51] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/76258 [07:42:56] ori-l: Well, since you weren't around, I rewrote the README. [07:43:42] Elsie: "https://bugs.mediawiki.org/"? [07:44:06] Certainly makes more sense than https://bugzilla.wikimedia.org, surely. [07:44:20] I guess. [07:44:30] I have URL hax. [07:44:38] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/AWSSDK] - 10https://gerrit.wikimedia.org/r/76259 [07:44:53] I found a few extensions that have ?> :( [07:44:59] :-( [07:45:15] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Babel] - 10https://gerrit.wikimedia.org/r/76260 [07:46:05] ori-l: https://www.mediawiki.org/wiki/README [07:46:10] I also found one that had the line "$dir = dirname(__FILE__);" twice without ever redefining it >.< [07:46:49] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/76261 [07:46:50] Elsie: the lead isn't great (too many parentheticals, for one) [07:47:23] ori-l: So rewrite it. :-) [07:47:28] It could use bullets. [07:47:35] But then I figured you'd just complain about that. [07:47:50] THERE'S NO WINNING WITH YOU. [07:47:51] nah. bullet are: [07:47:53] * OK [07:47:55] * Really. [07:47:55] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/76262 [07:47:59] * No complaints here. [07:48:08] bullets * [07:48:48] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/76263 [07:49:00] you're very deeply enchanted with caching for reasons i don't quite understand [07:49:14] aggressively enchanted, even [07:49:45] Am I? [07:49:51] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/76264 [07:50:10] ori-l: Without an aggressive caching layer, Wikipedia wouldn't exist. [07:50:13] Just saying! [07:50:22] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/76265 [07:50:41] it's true, to its discredit [07:51:01] You just be glad that I didn't call it webscale. [07:51:14] well, that's not exactly fair to say: caching as a general strategy is legitimate and used everywhere, right down to the CPU level [07:51:20] but we use it to hide performance problems [07:51:37] Also, I'm finished editing for now. You can edit without fear of edit conflicts from me. [07:51:45] thank goodness [07:51:51] I know you were worried. [07:52:19] Erik Moeller and Lee Daniel Crocker released their contributions into the public domain. [07:52:23] Before you do anything else, know that. [07:52:42] And something about California and Sajax. [07:52:44] syntaxhighlight doesn't work with VE? [07:53:00] VE barely works with VE at the moment. [07:53:19] Hmmm. There are VE/VD jokes to be had. [07:53:35] Why has this taken me so long. [07:53:46] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/76266 [07:54:17] ori-l: If anything, CodeEditor should take over blocks. [07:54:31] Maybe one day. [07:55:12] I find your caching aggressive, sir. [07:55:34] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/76267 [07:55:46] You could kill the "If you are:" line and add question marks to the bullets below. [07:55:53] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/CategorySlideShow] - 10https://gerrit.wikimedia.org/r/76268 [07:56:11] (03PS1) 10Legoktm: Cleaning up unused variables in the global space [extensions/CategorySortHeaders] - 10https://gerrit.wikimedia.org/r/76269 [07:56:49] I'm far less concerned about unused variables in the global namespace than I am about that fucking bot. [07:56:51] legoktm: I'd wait for input from someone else before continuing to do that [07:57:00] ^ [07:57:28] ori-l: Ok [07:57:44] Like….from who? [07:57:59] whom [07:58:03] * Elsie hides. [07:58:16] E-mail wikitech-l? [07:58:20] yeah. [07:58:40] https://www.mediawiki.org/wiki/Development [07:58:49] I have no idea what the point of this page is. ^ [07:58:55] i don't really see the harm in not cleaning up [07:59:19] Other than providing nerd-cred to MediaWiki. [07:59:24] and arguably the 'proper' solution is to use namespaces, which some newer extensions do [07:59:35] Proper or final? [07:59:42] * legoktm finds what Reedy said [07:59:51] yeah, i read the bug [08:00:04] I'm looking from what we talked about on IRC [08:00:22] Is this a theoretical problem or do people actually hit this issue? [08:00:34] there's no issue [08:00:46] Isn't there a bug? [08:00:52] The bug is a lie. [08:00:53] [05:42:15 PM] legoktm: Nothing much really [08:00:53] [05:42:23 PM] Though, if an extension after yours doesn't set it [08:00:53] [05:42:32 PM] *unset it [08:00:53] [05:42:42 PM] They'll be wtfing when it's the wrong dir [08:00:53] [05:42:45 PM] It's more just tidyness [08:00:54] [05:43:20 PM] Minimal effort to do it [08:01:11] Minimal effort, maximum pain. [08:01:18] $dir = dirname( __FILE__ ) can almost always be replaced with __DIR__, which is newish so not all devs know about it [08:01:41] You need someone with +2 rights to commit to follow you around and merge these changes. [08:01:43] Reedy is being slightly OCD here, I think [08:01:50] Otherwise it'll just create mess. [08:01:58] And you know how I feel about mess-makers. [08:02:11] Elsie: :P [08:02:25] "What is your plan to clean up the mess you made?" [08:02:33] Hmmmmmmmmmmm? [08:02:39] there's the __DIR__ thing, namespaces, and the possibility that you'll unset a global that is actually needed [08:02:58] plus the noise of all those commits [08:03:24] I feel like it used to be easier to do batch changes like this. [08:03:27] ori-l: Well I'm manually reviewing all of them, and they've all been just $dir and resourceloader template stuff [08:03:35] When SVN had everything in a single repo. [08:03:42] well, all the $dir ones should be __DIR__, since it's faster anyway. [08:03:52] How recent is __DIR__? [08:03:59] __RECENT__. [08:04:15] Are you going to break PHP compatibility for no good reason? [08:04:37] __NO__. [08:05:16] it's all over core [08:06:11] Other than parse time, what performance problems are being hidden by cache? [08:06:29] Aggressive or otherwise. [08:06:40] we should employ passive-aggressive caching [08:06:54] We do. It's called code review. [08:07:06] heh [08:13:28] legoktm: https://dpaste.de/7riLq/raw/ [08:13:42] With unset(): 0.16610980033875 [08:13:42] Without unset(): 0.056993007659912 [08:13:50] Huh. [08:13:57] why 'huh'? [08:14:05] it's cheaper to leave something be than to go and explicitly free it [08:14:22] Right, but I didn't think it would be that much of a difference [08:14:30] well, it's for 1 million trials [08:14:30] I think that's a very PHP/Python philosophy. [08:15:10] it's just brute fact [08:16:26] so: chance of unsetting needed global; noise for reviewers; __DIR__ being better than $dir anyhow; no convincing rationale other than 'tidyness' === don't do it [08:16:51] I already corrected his spelling. [08:16:56] And gave him a spanking. [08:17:08] Yeah, makes sense. [08:17:15] So should I abandon everything now? [08:17:23] wait for the bot to crash first [08:17:30] Which bot? [08:17:50] morebots. [08:17:55] maybe amend them to replace $dir with __DIR__? [08:19:03] or just assign reedy as reviewer to all of them, so he gets the email notifications, and then abandon them, so he gets the emails for that, too [08:19:18] that should be suitable punishment for reedy for sending you on this adventure [08:19:20] I think jenkins-bot needs to be involved one way or another. [08:19:42] It isn't punishment unless there's jenkinsspam. [08:20:00] I already cleared 10+ emails from my inbox from it [08:20:27] * jenkinss̈pam [08:23:00] __DIAERESIS__ [08:23:29] * ori-l unsets( ori-l ); [08:23:32] goodnight [08:23:35] Night. [08:24:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=47514#c5 [08:24:35] gnite ori-l [08:40:00] (03CR) 10Matmarex: "If this is "[b]asically Recentchanges for pages that aren't watched", then why implement it as a separate special page and not a checkbox " [core] - 10https://gerrit.wikimedia.org/r/76238 (owner: 07Brian Wolff) [08:46:12] (03CR) 10Matmarex: [ C: 122] jquery.placeholder: Fixup for 7ec7d879ee [core] - 10https://gerrit.wikimedia.org/r/76239 (owner: 07Krinkle) [08:48:39] (03PS25) 10Wikinaut: (bug 44819) introduction of array of $wgOpenIDProviders [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [08:48:46] (03Merged) 10jenkins-bot: jquery.placeholder: Fixup for 7ec7d879ee [core] - 10https://gerrit.wikimedia.org/r/76239 (owner: 07Krinkle) [08:54:12] (03CR) 10Matmarex: [ C: 122] Increase vertical offset of post-edit confirmation in MonoBook [core] - 10https://gerrit.wikimedia.org/r/76222 (owner: 07Ori.livneh) [08:56:41] (03Merged) 10jenkins-bot: Increase vertical offset of post-edit confirmation in MonoBook [core] - 10https://gerrit.wikimedia.org/r/76222 (owner: 07Ori.livneh) [09:08:00] (03CR) 10Zaran: [ C: 04-1] "(8 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 07Rtdwivedi) [09:12:13] (03PS1) 10Hashar: jobs for mw/ext/Oauth [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76272 [09:14:09] (03PS1) 10Hashar: triggers for mw/ext/Oauth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76273 [09:14:37] (03CR) 10Hashar: [ C: 122] jobs for mw/ext/Oauth [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76272 (owner: 07Hashar) [09:14:43] (03CR) 10Hashar: [ C: 122] triggers for mw/ext/Oauth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76273 (owner: 07Hashar) [09:14:51] (03Merged) 10jenkins-bot: triggers for mw/ext/Oauth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76273 (owner: 07Hashar) [09:17:00] (03PS1) 10Hashar: Oauth -> OAuth [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76274 [09:17:59] (03PS1) 10Hashar: Oauth -> OAuth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76275 [09:18:28] (03CR) 10Hashar: [ C: 122] Oauth -> OAuth [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/76274 (owner: 07Hashar) [09:18:35] (03CR) 10Hashar: [ C: 122] Oauth -> OAuth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/76275 (owner: 07Hashar) [09:19:30] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76276 [09:29:58] (03PS26) 10Wikinaut: (bug 44819) introduction of array of $wgOpenIDProviders [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [09:39:06] (03PS27) 10Wikinaut: (bug 44819) introduction of array of $wgOpenIDProviders [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [09:50:13] (03PS10) 10Santhosh: Adding hook handler for creating human-friendly relative timestamp [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 (owner: 07Kaldari) [09:52:00] (03CR) 10Santhosh: "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 (owner: 07Kaldari) [09:53:18] (03PS28) 10Wikinaut: (bug 44819) introduction of array of $wgOpenIDProviders [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [09:56:41] (03PS29) 10Wikinaut: (bug 44819) introduction of array of $wgOpenIDProviders [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [11:04:45] (03PS3) 10Matmarex: Don't pass crap to Html::input. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76090 (owner: 07Jack Phoenix) [11:05:42] (03CR) 10Matmarex: [ C: 122] "Rewrapped the commit message and remove the bit about myself from it :)" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76090 (owner: 07Jack Phoenix) [11:05:46] (03Merged) 10jenkins-bot: Don't pass crap to Html::input. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76090 (owner: 07Jack Phoenix) [11:36:38] (03CR) 10Rillke: "This is done in 7ec7d879ee20e9bf1dec618ec701fba3982a44b0" [core] - 10https://gerrit.wikimedia.org/r/74333 (owner: 07Rillke) [11:39:32] (03PS1) 10Mwjames: Clean-up and code coverage improvements [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76278 [11:41:23] (03CR) 10Mwjames: [ C: 122] Clean-up and code coverage improvements [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76278 (owner: 07Mwjames) [11:42:17] MatmaRex: do you have some idea what the future of Extension:CodeReview will be? [11:42:41] (03Merged) 10jenkins-bot: Clean-up and code coverage improvements [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76278 (owner: 07Mwjames) [11:42:47] liangent: slow and painful death, most likely :) but ashley apparnetly wants to use it somewhere [11:49:01] MatmaRex: but will be kept forever on mediawiki.org to keep codereview history? [11:49:37] or all data get dumped in some static form then remove the extension [11:51:28] liangent: ah, i don't know [11:51:37] but i haven't heard anybody wanting to remove it [11:54:19] (03PS7) 10Mwjames: \SMW\ChangeObserver [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75850 [12:02:54] (03CR) 10Mwjames: [ C: 122] "I'm going to be bold here as time flies and I'd like to clean-up some other stuff which means I need this but as always feel free to rever" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75850 (owner: 07Mwjames) [12:04:14] (03Merged) 10jenkins-bot: \SMW\ChangeObserver [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/75850 (owner: 07Mwjames) [12:06:43] (03CR) 10Rillke: "And the result of using fancy stuff like "arguments" together with $.each Follow-up --> 4f2e5fe2a096c64cbaa23b0bed3d9c9655bf2dd4" [core] - 10https://gerrit.wikimedia.org/r/76116 (owner: 07Hoo man) [12:21:43] (03PS1) 10Mwjames: Some minor renaming [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76279 [12:34:44] (03PS1) 10Jack Phoenix: Correctly nest comments. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76282 [13:15:05] (03PS5) 10Rjain: Added the update class [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 [13:35:48] (03CR) 10Mwjames: [ C: 122] Some minor renaming [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76279 (owner: 07Mwjames) [13:37:33] (03Merged) 10jenkins-bot: Some minor renaming [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/76279 (owner: 07Mwjames) [13:52:33] (03PS2) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 [14:40:59] (03CR) 10Rillke: "This triggered bug 48817" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/60969 (owner: 07Nikerabbit) [15:03:52] (03PS3) 10Physikerwelt: Expose LaTeXML Settings [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 [15:13:35] (03PS1) 10Nikerabbit: Use content language for edit summary [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76287 [15:34:52] (03CR) 10Nikerabbit: [ C: 04-1] "I find it unlikely that they need all of ymd/dmy/mdy variants since that is mostly specific to English language only to work around the li" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 07TTO) [15:41:54] (03CR) 10Nikerabbit: [ C: 122] Add a full-stop [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76231 (owner: 07Shirayuki) [15:57:54] YuviPanda: why owners in yellow? [15:58:54] (03PS3) 10Nikerabbit: Sort groups alphabetically in Special:Translate export tab [extensions/Translate] - 10https://gerrit.wikimedia.org/r/70332 (owner: 07Nemo bis) [15:59:29] Nemo_bis: it's apparently olive. And also, AzaToth [15:59:33] not my choice of colors :) [15:59:42] I'm thinking of removing them [16:01:22] Nemo_bis: I'm thinking of making that... rainbow! :P [16:02:57] (03CR) 10Nikerabbit: [ C: 122] Sort groups alphabetically in Special:Translate export tab [extensions/Translate] - 10https://gerrit.wikimedia.org/r/70332 (owner: 07Nemo bis) [16:04:27] (03Merged) 10jenkins-bot: Sort groups alphabetically in Special:Translate export tab [extensions/Translate] - 10https://gerrit.wikimedia.org/r/70332 (owner: 07Nemo bis) [16:06:50] YuviPanda: colours are not bad, ops can remove them if they wish with the +c flag on their channel [16:07:02] yeah [16:07:05] Nemo_bis: I'm reducing the number of them [16:07:15] but yellow is used for stalked messages at least on my irssi (default) configuration, so it doesn't seem that smart [16:07:15] only inside C: and V:, and owner [16:07:17] nothing else [16:07:22] 01 colors! [16:07:22] well, they look orange to me [16:07:23] so [16:07:34] and the technical name is 'olive' [16:07:35] sadly I appear to have randomly selected black [16:07:47] I seem to have raondomly selected dark pink [16:08:03] 4 better colors! [16:08:05] mostly they should be less bright, e.g. how StewardBot does on #wikimedia-stewards [16:08:14] the colors are up to your client [16:08:36] well, I don't know how it does but StewardBot does it better :) [16:08:38] it will be given something like 'red' or 'bright red' [16:08:47] and then it does whatever your client thinks it should be [16:13:07] hm, dbbot-wm [16:15:36] YuviPanda, Yo. [16:15:44] hey :) [16:17:33] sucheta: which repository is this? [16:20:04] sucheta: if you do `git log --oneline ` [16:20:23] it will give you list of commits that have changed this particular file [16:21:37] sucheta: oi [16:22:16] YuviPanda, Sorry. Yes. I was looking at jquery.ime repository. [16:22:23] Okay. Hmm. [16:22:32] sucheta: so you can parse that out to check what exactly happened [16:22:55] Walk me through your suchabot script for the same. [16:23:06] sucheta: let me find the script, moment [16:23:37] (03CR) 10Siebrand: [ C: 122] Use content language for edit summary [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76287 (owner: 07Nikerabbit) [16:23:45] sucheta: look at https://git.wikimedia.org/blob/labs%2Ftools%2FSuchABot/58ab984efa07e791179b81bc2b13e7af79d514e7/suchabot%2Fsync.py [16:24:06] sucheta: there's the 'sh' module [16:24:30] YuviPanda: where are pages/docs/whatever on grrrit-wm ? [16:24:48] (03Merged) 10jenkins-bot: Use content language for edit summary [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76287 (owner: 07Nikerabbit) [16:25:26] sucheta: i use it to run git commands, get output and then parse the output myself [16:25:40] (03CR) 10Siebrand: [ C: 04-1] "(1 comment)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/75835 (owner: 07Nikerabbit) [16:25:42] sucheta: http://amoffat.github.io/sh/ [16:27:55] (03CR) 10Nikerabbit: [ C: 122] Update formatting [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/76121 (owner: 07Siebrand) [16:27:57] (03CR) 10Siebrand: "(1 comment)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74944 (owner: 07Nikerabbit) [16:28:52] (03CR) 10Siebrand: [ C: 122] Use constant group name in examples [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74943 (owner: 07Nikerabbit) [16:29:11] (03Merged) 10jenkins-bot: Update formatting [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/76121 (owner: 07Siebrand) [16:29:32] (03CR) 10Siebrand: [ C: 122] Correct ApiQueryLanguageStats example [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74942 (owner: 07Nikerabbit) [16:30:03] (03CR) 10Siebrand: [ C: 122] Add getFileExtensions to XliffFFS [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74946 (owner: 07Nikerabbit) [16:30:19] YuviPanda, Okay. I think I am confused. A bit. [16:30:24] why [16:30:32] want to call? [16:30:43] (03CR) 10Nikerabbit: [ C: 122] Fix casing in User::isAllowed() [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76058 (owner: 07Siebrand) [16:30:51] (03CR) 10Siebrand: [ C: 122] Add composer.json [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/68145 (owner: 07Nikerabbit) [16:30:56] (03Merged) 10jenkins-bot: Add composer.json [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/68145 (owner: 07Nikerabbit) [16:32:21] (03Merged) 10jenkins-bot: Use constant group name in examples [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74943 (owner: 07Nikerabbit) [16:32:22] (03Merged) 10jenkins-bot: Correct ApiQueryLanguageStats example [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74942 (owner: 07Nikerabbit) [16:32:23] (03CR) 10Siebrand: [ C: 122] Update some docs in Translate.php [extensions/Translate] - 10https://gerrit.wikimedia.org/r/70592 (owner: 07Nikerabbit) [16:32:24] (03CR) 10Siebrand: [ C: 122] Use little bit longer GPL-2.0+ instead of GPL2+ [extensions/Translate] - 10https://gerrit.wikimedia.org/r/72249 (owner: 07Nikerabbit) [16:32:30] (03Merged) 10jenkins-bot: Add getFileExtensions to XliffFFS [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74946 (owner: 07Nikerabbit) [16:34:21] (03Merged) 10jenkins-bot: Fix casing in User::isAllowed() [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76058 (owner: 07Siebrand) [16:34:56] (03Merged) 10jenkins-bot: Update some docs in Translate.php [extensions/Translate] - 10https://gerrit.wikimedia.org/r/70592 (owner: 07Nikerabbit) [16:36:05] (03Merged) 10jenkins-bot: Use little bit longer GPL-2.0+ instead of GPL2+ [extensions/Translate] - 10https://gerrit.wikimedia.org/r/72249 (owner: 07Nikerabbit) [16:37:43] (03CR) 10Siebrand: [ C: 122] Compress the eot font more using microtype express compression [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76236 (owner: 07Santhosh) [16:37:52] (03Merged) 10jenkins-bot: Compress the eot font more using microtype express compression [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76236 (owner: 07Santhosh) [16:39:20] (03CR) 10Nikerabbit: "(1 comment)" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/74944 (owner: 07Nikerabbit) [16:39:28] (03PS1) 10Nemo bis: Change name of Neapolitan language from "Nnapulitano" to "Napulitano" [core] - 10https://gerrit.wikimedia.org/r/76289 [16:42:15] (03CR) 10Nikerabbit: [ C: 122] Remove call to wfArrayMerge [extensions/Translate] - 10https://gerrit.wikimedia.org/r/72237 (owner: 07PleaseStand) [16:42:40] (03CR) 10Nemo bis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76289 (owner: 07Nemo bis) [16:43:34] (03Merged) 10jenkins-bot: Remove call to wfArrayMerge [extensions/Translate] - 10https://gerrit.wikimedia.org/r/72237 (owner: 07PleaseStand) [16:47:16] (03PS2) 10Nemo bis: Fix incorrect behavior with non-capitalized namespace [extensions/Translate] - 10https://gerrit.wikimedia.org/r/75835 (owner: 07Nikerabbit) [16:49:51] (03PS1) 10Nemo bis: Fix typo "varios" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76291 [16:56:53] (03CR) 10Nikerabbit: [ C: 122] Fix typo "varios" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76291 (owner: 07Nemo bis) [16:58:07] (03Merged) 10jenkins-bot: Fix typo "varios" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76291 (owner: 07Nemo bis) [17:00:40] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 07Mattflaschen) [17:02:15] (03PS1) 10Nemo bis: Clarify exif-copyrighted-false means only Copyright flag not set [core] - 10https://gerrit.wikimedia.org/r/76292 [17:03:29] (03CR) 10Krinkle: [ C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75836 (owner: 07Mattflaschen) [17:06:14] (03PS1) 10Nemo bis: Clarify userrights-conflict [core] - 10https://gerrit.wikimedia.org/r/76293 [17:06:41] (03CR) 10Nikerabbit: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/74313 (owner: 07Krinkle) [17:09:54] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/74313 (owner: 07Krinkle) [17:10:54] (03PS1) 10Krinkle: mediawiki.page.startup: Fix typo in @event wikipage_content [core] - 10https://gerrit.wikimedia.org/r/76294 [17:11:25] (03PS2) 10Krinkle: mediawiki.page.startup: Fix typo in @event wikipage_content [core] - 10https://gerrit.wikimedia.org/r/76294 [17:13:06] (03PS1) 10Nemo bis: Make morenotlisted more grammar-friendly [core] - 10https://gerrit.wikimedia.org/r/76295 [17:15:13] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 07Nemo bis) [17:15:29] YuviPanda: ping [17:16:00] (03CR) 10Robert Vogel: [ C: 122 V: 122] "That looks okay." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/76263 (owner: 07Legoktm) [17:20:26] (03PS1) 10Nemo bis: Make prefs-advancedediting more consistent [core] - 10https://gerrit.wikimedia.org/r/76296 [17:20:29] (03CR) 10Nikerabbit: [ C: 122] mediawiki.page.startup: Fix typo in @event [core] - 10https://gerrit.wikimedia.org/r/76294 (owner: 07Krinkle) [17:23:21] (03Merged) 10jenkins-bot: mediawiki.page.startup: Fix typo in @event [core] - 10https://gerrit.wikimedia.org/r/76294 (owner: 07Krinkle) [17:24:22] (03PS1) 10Nemo bis: More consistency with "Email options" preferences subsection [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76297 [17:39:00] (03CR) 10Nikerabbit: "This reduces readability and greb'ality of the code." [core] - 10https://gerrit.wikimedia.org/r/74079 (owner: 07Krinkle) [17:40:13] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/74313 (owner: 07Krinkle) [17:44:06] (03CR) 10Nikerabbit: "If the content is now the same, do we even need two different messages or can these be merged?" [core] - 10https://gerrit.wikimedia.org/r/76295 (owner: 07Nemo bis) [17:44:21] (03PS1) 10Rillke: Make jquery.autosize aware of style changes [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 [17:46:16] (03CR) 10Nikerabbit: [ C: 122] Make prefs-advancedediting more consistent [core] - 10https://gerrit.wikimedia.org/r/76296 (owner: 07Nemo bis) [17:48:59] (03Merged) 10jenkins-bot: Make prefs-advancedediting more consistent [core] - 10https://gerrit.wikimedia.org/r/76296 (owner: 07Nemo bis) [17:50:01] (03PS2) 10Rillke: Make jquery.autosize aware of style changes [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 [17:54:04] (03PS3) 10Rillke: Make jquery.autosize aware of style changes [extensions/Translate] - 10https://gerrit.wikimedia.org/r/76298 [18:06:54] (03CR) 10Nikerabbit: [ C: 122] More consistency with "Email options" preferences subsection [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76297 (owner: 07Nemo bis) [18:07:06] (03Merged) 10jenkins-bot: More consistency with "Email options" preferences subsection [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76297 (owner: 07Nemo bis) [18:07:35] (03CR) 10Nikerabbit: [ C: 122] Change name of Neapolitan language from "Nnapulitano" to "Napulitano" [core] - 10https://gerrit.wikimedia.org/r/76289 (owner: 07Nemo bis) [18:09:11] (03PS9) 10Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 [18:09:27] (03CR) 10Nikerabbit: [ C: 122] Clarify exif-copyrighted-false means only Copyright flag not set [core] - 10https://gerrit.wikimedia.org/r/76292 (owner: 07Nemo bis) [18:10:10] (03Merged) 10jenkins-bot: Change name of Neapolitan language from "Nnapulitano" to "Napulitano" [core] - 10https://gerrit.wikimedia.org/r/76289 (owner: 07Nemo bis) [18:12:42] (03Merged) 10jenkins-bot: Clarify exif-copyrighted-false means only Copyright flag not set [core] - 10https://gerrit.wikimedia.org/r/76292 (owner: 07Nemo bis) [18:15:18] (03CR) 10Krinkle: [ C: 04-1] "(1 comment)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/59159 (owner: 07Alex Monk) [18:23:51] (03PS4) 10Rjain: Added the permissions plugin [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 [18:24:18] (03CR) 10Rjain: "(2 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 07Rjain) [18:28:19] (03CR) 10Nikerabbit: [ C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 07Matmarex) [18:33:16] (03PS1) 10Nemo bis: Explicitly support GENDER on communitytwitter-logged-in-as [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/76301 [18:34:14] (03CR) 10Nemo bis: "Done on https://gerrit.wikimedia.org/r/#/c/76301/ , docs on wiki" [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/73137 (owner: 07RAN1) [18:37:38] Krinkle: pong [18:38:00] YuviPanda: grrrit-wm has a one-off issues when changesets have their summary changed [18:38:10] Krinkle: yeah, there's a bug filed. It's a gerrit issue [18:38:25] Afaik the original gerrit-wm didn't have that problem [18:38:32] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=52016 [18:38:34] OK [18:38:58] Krinkle: ideed, because they are using different methods of getting data out of gerrit [18:40:39] (03CR) 10Nikerabbit: [ C: 04-1] "1) Would still be nice to see the name if all edits are from single user." [core] - 10https://gerrit.wikimedia.org/r/75571 (owner: 07Matmarex) [18:41:32] (03PS1) 10MarkAHershberger: Fix a typo [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/76303 [18:42:44] (03CR) 10Miguel2706: [ C: 122 V: 122] Cleaning up unused variables in the global space [extensions/Ads] - 10https://gerrit.wikimedia.org/r/76246 (owner: 07Legoktm) [18:49:31] (03PS2) 10Nikerabbit: Opt-out Persian from links underline removal [core] - 10https://gerrit.wikimedia.org/r/75570 (owner: 07Ebrahim) [18:49:47] (03CR) 10Nikerabbit: [ C: 122] Remove Persian from link underlining removal [core] - 10https://gerrit.wikimedia.org/r/75570 (owner: 07Ebrahim) [18:54:13] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75570 (owner: 07Ebrahim) [18:54:14] (03CR) 10Krinkle: "Does this follow-up a certain backported commit, or should this go to master instead?" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/76303 (owner: 07MarkAHershberger) [18:54:15] (03Merged) 10jenkins-bot: Remove Persian from link underlining removal [core] - 10https://gerrit.wikimedia.org/r/75570 (owner: 07Ebrahim) [18:56:44] (03PS1) 10Ori.livneh: Optionally encode exception log entries as JSON documents [core] - 10https://gerrit.wikimedia.org/r/76304 [19:06:26] Nemo_bis: https://bugzilla.wikimedia.org/show_bug.cgi?id=46452 [19:08:30] (03CR) 10Krinkle: [ C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 07Ori.livneh) [19:09:09] ori-l: nice [19:10:28] heh, i have no idea where that 'early' came from. [19:10:58] ghostpaste [19:11:18] he, my fingers tend to tell stories of their own sometimes. [19:11:48] happens sometimes when I'm thinking about something (else) while typing. usaully results in skipping a word or typing it twice, not adding different words. [19:12:36] (03PS2) 10Ori.livneh: Update README with better explanation and instructions [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/73994 (owner: 07Spage) [19:12:45] (03CR) 10Ori.livneh: [ C: 122] Update README with better explanation and instructions [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/73994 (owner: 07Spage) [19:12:47] (03Merged) 10jenkins-bot: Update README with better explanation and instructions [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/73994 (owner: 07Spage) [19:17:48] (03CR) 10MarkAHershberger: "You're right. This should go into master. Thanks for pointing that out." [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/76303 (owner: 07MarkAHershberger) [19:18:07] (03PS2) 10Ori.livneh: Optionally encode exception log entries as JSON documents [core] - 10https://gerrit.wikimedia.org/r/76304 [19:19:11] (03CR) 10Ori.livneh: "PS2 addresses Krinkle's comments." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 07Ori.livneh) [19:20:19] (03PS1) 10MarkAHershberger: Fix a typo [core] - 10https://gerrit.wikimedia.org/r/76305 [19:20:47] YuviPanda: Does the bot have data to show which branch a new change set is for? [19:20:51] > grrrit-wm: (PS1) MarkAHershberger: Fix a typo [core] - https://gerrit.wikimedia.org/r/76305 [19:20:56] doesn't mention (master) [19:21:02] or does it strip that just if it is master (default) [19:21:03] (03CR) 10Ori.livneh: [ C: 122] Fix a typo [core] - 10https://gerrit.wikimedia.org/r/76305 (owner: 07MarkAHershberger) [19:21:06] Krinkle: yup. it doesn't mention (master) or (production) [19:21:10] Krinkle: mentions everything else [19:21:12] Right, OK. [19:21:28] that change was REL1_21 first, and so it wasn't obvious that it is for master now [19:22:08] Krinkle: heh, yeah. but that's a minor thing, I guess. Mostly (master) is noise, I believe [19:22:22] maybe [19:23:20] hexmode: Hm.. generated a new Change-Id for it. [19:23:28] (03PS2) 10Krinkle: Fix a typo [core] - 10https://gerrit.wikimedia.org/r/76305 (owner: 07MarkAHershberger) [19:23:32] (03CR) 10Krinkle: [ C: 122] ContentHandler: Fix a typo [core] - 10https://gerrit.wikimedia.org/r/76305 (owner: 07MarkAHershberger) [19:24:04] could've re-used the same one. [19:24:31] Krinkle: gerrit is so confusing. Or is that git? [19:24:38] definitely gerrit [19:24:40] Neither [19:24:42] :P [19:24:53] hexmode: How did you change it to master? [19:25:51] Krinkle: I just checked out master and fixed it there. Its just a typo, after all. Wasn't too worried about reusing the commit for that. [19:26:19] Right [19:26:56] So if you'd used cherry-pick (without the silly "cherry-picked from", but just plain cherry-pick) or copied the Change-Id: line from the commit message, it would've linked it to the REL1_21 change, which is nice :) [19:27:01] anyway [19:27:28] actually, that would've been easier this time around, since Gerrit now has Cherry-Pick in the web interface. [19:27:41] so you don't even have to leave the browser [19:27:48] (03Merged) 10jenkins-bot: ContentHandler: Fix a typo [core] - 10https://gerrit.wikimedia.org/r/76305 (owner: 07MarkAHershberger) [19:29:15] that would be easier. Using the webui. thanks for the inffo. [19:29:20] info [19:30:23] amazing http://stackoverflow.com/q/6841333/319266 http://www.timeanddate.com/worldclock/clockchange.html?n=237&year=1927 [19:38:25] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/75570 (owner: 07Ebrahim) [19:39:44] (03CR) 10Nikerabbit: [ V: 122] Add a full-stop [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/76231 (owner: 07Shirayuki) [19:56:34] (03PS2) 10Nemo bis: Move translators credits list to a wiki page [core] - 10https://gerrit.wikimedia.org/r/73611 [19:58:10] (03CR) 10Nemo bis: "Matmarex, thanks, fixed now. It's a bit ugly but better than unintentionally breaking compatibility with some translations." [core] - 10https://gerrit.wikimedia.org/r/73611 (owner: 07Nemo bis) [20:05:45] (03CR) 10Nikerabbit: [ C: 122] "Good catch." [core] - 10https://gerrit.wikimedia.org/r/75341 (owner: 07Santhosh) [20:08:18] (03Merged) 10jenkins-bot: Correct the regular expression for explicit plural forms [core] - 10https://gerrit.wikimedia.org/r/75341 (owner: 07Santhosh) [20:15:25] 
SyntaxError: Unexpected token - at Object.Function (unknown source) at createRenderFunc (/data/project/lolrrit-wm/lolrrit-wm/node_modules/swig/lib/swig.js:44:10) at createTemplate (/data/project/lolrrit-wm/lolrrit-wm/node_modules/swig/lib/swig.js:96:14) at getTemplate (/data/project/lolrrit-wm/lolrrit-wm/node_modules/swig/lib/swig.js:124:20) at exports.compileFile.getSingle (/data/project/lolrrit-wm/lolrrit-wm/node_modules/swig/lib/swig.js:
[20:15:26] 	 lrrit-wm/node_modules/swig/lib/swig.js:159:7) at Object.exports.compileFile (/data/project/lolrrit-wm/lolrrit-wm/node_modules/swig/lib/swig.js:177:7) at Object. (/data/project/lolrrit-wm/lolrrit-wm/src/relay.js:50:21) at Module._compile (module.js:449:26) at Object.Module._extensions..js (module.js:467:10)
[20:15:40] lawl [20:15:46] SillyPanda: ^^^ [20:15:52] i blame AzaToth [20:16:03] Don't we all. [20:16:08] we do [20:16:13] * AzaToth is innocent [20:16:13] add it to blame wheel please :) [20:24:06] (CR) Nemo bis: "Krinkle, sure, it's not substantially different from how it was before. We'd only have to remove all current translations." [core] - https://gerrit.wikimedia.org/r/73611 (owner: Nemo bis) [20:25:00] (CR) Krinkle: "How so? keep -others as label for 'others' and add a new message for the other label and use it on Special:Version. that also keeps the ur" [core] - https://gerrit.wikimedia.org/r/73611 (owner: Nemo bis) [20:25:09] Colors dropped [20:25:22] Krinkle: yeah, will be back soon. [20:25:32] I'm not complaining :P [20:25:32] testing happening in ##legoktm-bots-chatter right now [20:25:45] Ah, it restarted in the middle. [20:25:55] Thanks [20:26:17] yeah [20:28:39] (PS1) Nemo bis: 4-digits numbers in Spanish should not have a group separator [core] - https://gerrit.wikimedia.org/r/76306 [20:30:21] (PS1) Rtdwivedi: Toggle header-footer visibility. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/76307 [20:38:32] (CR) Parent5446: "Yep that's what I'm gonna do." [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [20:41:29] (CR) Parent5446: "Before this is merged, I'd just like to point out the original reason this message was added." [core] - https://gerrit.wikimedia.org/r/76295 (owner: Nemo bis) [20:42:30] (03CR) 10Parent5446: [C: 032] Cleaning up unused variables in the global space [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/76250 (owner: 10Legoktm) [20:42:33] (03Merged) 10jenkins-bot: Cleaning up unused variables in the global space [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/76250 (owner: 10Legoktm) [20:42:36] Oh God. [20:42:44] What's wrong with black and white? [20:42:52] Elsie: it's black and white [20:42:55] we're done with settling on colors, I swear. [20:42:55] And? [20:43:02] Now there's underlining? [20:43:14] Elsie: SillyPanda wanted it bold through out [20:43:24] so I made +2 and -2 underline [20:43:40] really? I thought you were going to bold it :| [20:43:41] grr [20:43:46] I did [20:43:48] As much as I enjoy needless underlining... [20:44:14] Are we concerned that people might think 2 is a 6 if it isn't underlined? ;-) [20:45:05] Elsie: it's all about how we as normal humans react to stimuli [20:45:07] well, that patchset for colors was past 20 patchsets [20:45:17] SillyPanda: not my fault :-P [20:45:21] :P [20:45:22] * AzaToth hides [20:45:26] saturday nights are boring [20:46:31] Elsie: why it borked before, was because swig couldn't handle value == -1 [20:46:39] had to change it to value == "-1" [20:47:22] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/76117 (owner: 10Siebrand) [20:53:49] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76238 (owner: 10Brian Wolff) [21:03:42] (03PS1) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/76310 [21:04:35] (03PS2) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/76310 [21:08:49] (03PS1) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/76312 [21:10:17] legoktm: wtf? [21:10:22] AzaToth: ? [21:10:23] ah [21:10:40] sorry, didn't see the extension changed ツ [21:10:46] :P [21:12:57] (03PS1) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76314 [21:13:18] (03PS2) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/76314 [21:13:30] (03PS2) 10Legoktm: Remove call to deprecated MWInit::methodExists with method_exists [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/76312 [21:15:40] (03CR) 10Matmarex: [C: 031] "Same things as in Polish, which should be good if I understand the request on the bug correctly." [core] - 10https://gerrit.wikimedia.org/r/76306 (owner: 10Nemo bis) [21:19:56] * Elsie NP: "All I Want for Christmas Is You" by Mariah Carey from "Merry Christmas" [21:22:50] (03CR) 10Brian Wolff: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/76238 (owner: 10Brian Wolff) [21:27:09] (03CR) 10Matmarex: "Anomie? Yurik? Care to review?" [core] - 10https://gerrit.wikimedia.org/r/64649 (owner: 10Parent5446) [21:33:36] (03PS2) 10Brian Wolff: Add Special:UnwatchedChanges page. [core] - 10https://gerrit.wikimedia.org/r/76238 [21:34:11] (03CR) 10Brian Wolff: "PS2: Address one of the comments. Please see my reply for the other comments." [core] - 10https://gerrit.wikimedia.org/r/76238 (owner: 10Brian Wolff) [21:37:22] (03PS5) 10Matmarex: (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [21:39:56] (03CR) 10jenkins-bot: [V: 04-1] (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [21:49:27] (03CR) 10Ori.livneh: [C: 032] Remove call to deprecated MWInit::methodExists with method_exists [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/76312 (owner: 10Legoktm) [21:49:29] (03Merged) 10jenkins-bot: Remove call to deprecated MWInit::methodExists with method_exists [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/76312 (owner: 10Legoktm) [21:49:58] (03PS10) 10Brian Wolff: Add Special:RandomInCategory. [core] - 10https://gerrit.wikimedia.org/r/71997 [21:50:21] (03CR) 10jenkins-bot: [V: 04-1] Add Special:RandomInCategory. [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [21:52:17] (03PS11) 10Brian Wolff: Add Special:RandomInCategory. [core] - 10https://gerrit.wikimedia.org/r/71997 [21:55:24] (03CR) 10Brian Wolff: "PS10: per CR - write out message names, use sql wrapper alias syntax, etc. + add a colon in the message when the form is displayed" [core] - 10https://gerrit.wikimedia.org/r/71997 (owner: 10Brian Wolff) [22:14:08] ori-l: I think it's more important to mention that MediaWiki is written in PHP and is wiki software than it is to mention that it powers Wikipedia. [22:14:22] Given user goals. [22:15:12] I was just reading http://phalconphp.com/about and I'm depressed about how much better they are at this. [22:15:20] MediaWiki: Riding on the coat tails of Wikipedia's fame! [22:15:38] that's a _really_ good page, if you ask me. [22:15:53] Its certainly prettier than anything we've got [22:16:35] * Yuvi|RanAway wonders if mediawiki will get a grid system in his lifetime [22:16:40] ori-l: Minus the typos, perhaps. [22:17:18] i wasn't even considering the design. it's just so crisp and engaging. it made me feel like contributing. [22:17:26] https://github.com/drupal/drupal#readme [22:17:42] I was reading that yesterday. [22:17:47] WordPress doesn't really have a README. [22:17:55] I think it has some HTML page something. [22:18:28] Drupal's is pretty good, yeah. [22:18:39] It's long. [22:18:49] Anyway, the bit about half a billion whatever is just dick-measuring. [22:18:56] As far as I'm concerned, at least. [22:19:41] maybe we should look at https://github.com/languages/PHP 'Most forked overall' [22:20:35] Symfony and CodeIgniter have nearly identical READMEs, but it looks like a good structure [22:20:49] https://github.com/mathiasbynens/dotfiles#readme doesn't explain what it is. [22:21:10] yeah, it doesn't properly belong in that list [22:21:23] what is it? / requirements / installation / documentation / contributing [22:21:37] A lot of these READMEs duplicate the requirements section. [22:21:38] I thought one of our goals was to not do that. [22:21:49] REQUIREMENTS file, rather. [22:22:50] I think https://www.mediawiki.org/wiki/README is still about 1,000 times better than the live README. [22:22:58] Even with the FIXMEs and [comments]. [22:24:01] I mostly agree. I think we could merge a change pretty quickly. [22:24:25] I would assume a README file would include a quick one line about required software [22:24:51] Well, it mentions PHP. [22:24:55] That's really the only hard requirement. [22:25:11] There's no version requirement. There's no Web server requirement. There's no database backend requirement. [22:25:45] ori-l: can you abandon https://gerrit.wikimedia.org/r/#/c/74523/ with an appropriate message? [22:25:48] That is, you can use various versions of PHP, Web server software, or database backends. [22:26:26] I think you have to start by wowing the reader and you have to mention Wikipedia. It's a fact that MediaWiki development is very largely shaped by Wikimedia wikis and as a result MediaWiki doesn't really have as good end-user support as some of these other PHP frameworks we mentioned [22:26:33] https://github.com/facebook/facebook-php-sdk#readme [22:26:52] so I think you need to give a kind of value-proposition statement, explaining why you might want to give it a shot. [22:27:00] So that you can create Wikipedia? [22:27:09] I don't see what the value proposition is. [22:27:32] As I said, Wikipedia also runs on Apache and MySQL. I don't think installing either of those will create Wikipedia either. [22:27:40] Wikipedia is its content and community, not MediaWiki. [22:27:48] no, but it sends a strong message about performance and reliability [22:28:19] I see what you're saying, but the association I was going for is "this software is used to power a very visible and highly-trafficked site, so it must be pretty robust" [22:28:36] You think that's engaging and not overwhelming? [22:28:52] I mean, for most cases, MediaWiki really is the tank when you need a lawnmower. [22:28:54] I don't know, it's entirely possible that I get the tone wrong. [22:28:59] got [22:29:11] but I think your rewritten lead is too dry. [22:29:13] I think scalability is a fine place to mention Wikipedia. [22:30:14] well, the connection with Wikipedia is also relevant because it says "you may not know it, but you've likely interacted with this software quite a bit and are probably more familiar with it than you might realize" [22:30:43] I tied that in with popularity. [22:31:00] Popularity is pretty important, I think. [22:31:04] When evaluating a software package. [22:31:28] It speaks to an active user community that can help if you get stuck. [22:32:16] And better hosting support. [22:33:12] well, [22:33:36] some reading the README has either just typed 'ls' in the directory created by unzipping the source tarball [22:33:52] or scrolled past the repository root file listing on github [22:33:53] someone [22:33:57] someone. [22:34:19] so I think the fact that it's in PHP is significant enough to merit mention, but it's also not a novel fact for the reader [22:34:24] ditto the free and open-source bit [22:34:58] so maybe we should start by formulating what someone encountering that file might *not* know that we'd like them to know [22:35:24] Yuvi|RanAway: will do, btw. [22:35:26] Like the fact that Lee Daniel Crocker's contributions are released under the public domain? [22:35:45] Elsie: I'm just thinking out loud, not arguing. [22:35:59] ah, forgot what that was about. Just realized :) [22:35:59] thanks ori-l [22:36:12] I'm not arguing either. [22:36:18] I also don't think it needs to be perfect. [22:36:23] Just better than the current mess. [22:36:26] I like 'MediaWiki is the software that powers Wikipedia' (or something to that effect) because it helps clear up the confusion engendered by the over-cute naming scheme (MediaWiki, Wikipedia, Wikimedia) [22:36:57] What? WIKIMON is evolving! [22:37:15] ori-l: I think that presents ethical and political problems. [22:37:30] Elsie, tell that to Lee Daniel Crocker [22:37:32] It powers Wikivoyage. And Wikiversity. And Wiktionary. [22:37:53] LDC is still active! [22:37:54] And the Hannah Montana Wikia. [22:38:11] And the LimeSurvey Manual! [22:38:24] Elsie: yes, but one of those projects is disproportionately more visible than the rest, and it's therefore strategic to make explicit the connection with that project specifically [22:38:53] Perhaps strategic, but still probelmatic. [22:38:59] problematic, too. [22:39:07] Also conservapedia [22:39:17] And the jQuery documentation site! [22:39:19] ori-l: You could probably accomplish the strategy but still promote some less-known Wikimedia projects at the same time [22:39:29] We usually say "Wikimedia wikis". [22:39:36] If someone doesn't understand what that means, they can look it up. [22:39:40] marktraceur: you could also accomplish the strategy and solicit donations for children in uganda like the VIM startup screen does, but you have to pick your battles. [22:39:55] VIM or vim? [22:40:03] __VIM__. [22:40:08] "MediaWiki is used by the Wikimedia movement to power Wikiversity, Wiktionary, Wikipedia, and many other projects" [22:40:09] Heh. [22:40:16] * Elsie laughs. [22:40:22] I'm not sure we're gonna lead with Wikiversity. [22:40:24] I actually think it does make sense to mention Wikipedia [22:40:34] What's Wikipedia? [22:40:57] MediawWiki is used to power many internet sites around the world, including large sites like Wikipedia [22:41:46] come on, that's a bit dishonest. you'd say that about PHP, maybe. but the mediawiki/wikipedia connection is stronger. [22:42:11] What's a bit dishonest? [22:42:40] * Yuvi|RanAway starts a discussion about one or two spaces after periods. [22:43:01] Yuvi|RanAway: https://en.wikipedia.org/wiki/Sentence_spacing [22:43:16] Yuvi|RanAway: https://en.wikipedia.org/wiki/History_of_sentence_spacing [22:43:19] Read those first. [22:43:34] you need to know about things to discuss them? I refuse to believe that [22:44:01] i just think it's a bit ridiculous to insist on being broadly representative in a statement that is expressly and unapologetically intended to be a bit of compelling PR. it will have been successful if you're drawn to read on and check out another file or mediawiki.org. It's not like the Voyager golden record or something. [22:44:02] Yuvi|RanAway: Do you know about not knowing? if you do, you can't discuss it [22:44:22] > MediaWiki is a free software open source wiki package written in PHP, originally for use on Wikipedia. It is now also used by several other projects of the non-profit Wikimedia Foundation and by many other wikis, including this website, the home of MediaWiki. [22:44:29] I want three spaces after a period. And line's ending with CRLRCR [22:44:33] Elsie: dig. I like that. [22:44:37] *CRLFCR [22:44:45] That's from . [22:44:46] ;-) [22:44:48] bawolff: are we still talking about punctuation? [22:44:55] mooeypoo: I'm pretty sure that I can just make up stuff as I go along, and then selectively interpret supporting evidence as it comes along to support my initial conclusion, no? :) [22:45:12] Yuvi|RanAway: touche [22:45:20] I should ragequit soon. It's too late to make sense. [22:46:31] mooeypoo: :) [22:46:37] I have to pee. [22:46:49] PR is (mostly) the abuse of psychological rules of how people understand and relate to stuff. That doesn't mean all the tools that PR abuses are bad on their own right. [22:47:38] ori-l: for that matter, even though the principle that "you should make the description as short and clear as possible" is abused by PR, that doesn't mean you shouldn't make descriptive sentences as such :P [22:47:50] mooeypoo: I named my son after Noam Chomsky [22:48:03] Heh. [22:48:04] I'm aware of the issues in the background [22:48:45] O.O [22:48:59] Does he know? [22:49:13] Not yet! [22:49:19] chomsky, or my son? :P [22:49:28] 'free software open source wiki package' is a bit noun-heavy [22:49:29] Both. Either. :D [22:50:06] 'free/libre open source software wiki package' [22:50:07] mooeypoo: neither; we've been meaning to send Chomsky a picture. I met him once. [22:50:11] but anyways, I'm not sure what target-audience is viewing this, but I felt compelled to relate strictly to your "it sounds PRish" point. [22:51:01] mooeypoo: yeah, I agree with your point. [22:51:15] Yuvi|RanAway: 4 out of 5 dentists prefer to use FLOSS software [22:51:19] 'free software open source wiki package' sounds like the sequel to red hot chilly pepper's 'blood sugar sex magik' [22:51:29] bawolff: I think you meant to say GNU/dentists. [22:51:32] bawolff: and the 5th was bought by Microsoft. [22:52:08] mooeypoo: More like, 1 out 5 dentists understood the question [22:52:12] Replace "software" with "and". [22:52:21] the 5th one could not be reached for comment since his mutt config was corrupted [22:52:36] More like his .ost file. [22:53:41] * mooeypoo is outgeeked [22:53:56] he was clearly defragmenting [22:53:57] outlooked, rather. [22:54:26] no, no, I'm pretty sure I was outgeeked. [22:54:45] I suppose you only need to know of ost files to make fun of them [22:54:53] I made that the lead, but I didn't fix the noun-train yet. [22:55:26] * Yuvi|RanAway heads to bed [22:55:40] Yuvi|RanAway: good night! [22:55:43] night Yuvi|RanAway [22:55:47] nite, ori-l, mooeypoo [22:56:01] * mooeypoo needs to go do her midterm [22:56:03] meh. [22:56:54] I think the problem with the current lead is that it supports rather than dispels a common misconception which is worth dispelling early, which is that MediaWiki isn't designed for third-party use. [22:57:10] Current lead? [22:57:13] Which, can you quote? [22:57:22] it was what you pasted above [22:57:35] "MediaWiki is a free software open source wiki package written in PHP, originally for use on Wikipedia. It is now also used by several other projects of the non-profit Wikimedia Foundation and by many other wikis." [22:59:11] Is MediaWiki good for third-party use? [23:01:38] third-parties seem to think so [23:01:48] Despite the fact we don't do very much for their use case [23:03:37] https://integration.wikimedia.org/zuul/ <-- jenkins is stuck? [23:10:02] bbl [23:33:41] Krinkle: [04:03:36 PM] https://integration.wikimedia.org/zuul/ <-- jenkins is stuck? [23:34:10] checking [23:34:24] thanks [23:39:06] ashley: Committing schema changes first helps ;) [23:47:00] (03PS6) 10Matmarex: (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [23:48:10] (03CR) 10jenkins-bot: [V: 04-1] (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [23:51:27] (03PS7) 10Matmarex: (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [23:52:36] (03CR) 10jenkins-bot: [V: 04-1] (bug 43547) New language variant en-x-piglatin DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/72053 (owner: 10Liangent) [23:52:46] Krinkle: So… should it work now? [23:56:46] Reedy: well yeah, I'm not exactly sure what's the procedure as this is my first time writing a schema change thingy for something deployed on WMF sites (and as an additional bonus, I most certainly don't fucking around with git & gerrit), hence the question [23:57:29] https://git.wikimedia.org/blob/operations%2Fpuppet.git/ae908d3f6c6e7486b1b3d184a1edc99ff0ee0232/templates%2Fgerrit%2Fgerrit.config.erb [23:57:32] click 'HEAD' [23:57:38] Internal error [23:58:07] * legoktm pokes Reedy about https://gerrit.wikimedia.org/r/#/c/76042/ [23:58:30] https://git.wikimedia.org/log/operations%2Fpuppet.git -> "Failed to find commit "HEAD" in operations/puppet.git!" [23:58:36] (03CR) 10Rillke: "This will look weird at https://commons.wikimedia.org/wiki/Help:VisualFileChange.js#Step_0:_How_to_Install" [core] - 10https://gerrit.wikimedia.org/r/75643 (owner: 10Krinkle) [23:59:14] ashley: Which table is it? [23:59:36] code_authors [23:59:42] Maybe this is to do with 'production' being the default branch name in that repo instead of 'master' or something