[00:01:25] (PS1) Jack Phoenix: Load MediaWiki:CodeReview.css on Special:Code [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76045 [00:01:47] Oh Lord. [00:02:00] ashley: Really now? :-) [00:02:30] really! [00:02:52] lol ashley [00:02:55] closing notes: [00:02:56] if given the choice between a visit at the dentists and submitting a change via git review... [00:02:56] I pick my dentist. [00:03:14] My mum would rather give birth than go to the dentist [00:03:33] (CR) Ori.livneh: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:03:40] ashley: git push gerrit HEAD:refs/for/master [00:03:50] All right, kids. I've logged in to wikitech.wikimedia.org. [00:04:08] and the best part of that command is, all bits of it make perfect sense [00:04:11] well, except that last [00:04:14] but that's gerrit's fault [00:04:21] Reedy: British people and their teeth... [00:05:42] ashley: Are you using CR somewhere else? [00:06:49] Reedy: aye, ShoutWiki's using it at least, and maybe some other third parties that we don't know about (I know I saw a public wiki using CR somewhere but it was a while ago) [00:07:25] (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76048 [00:07:29] It's going to have to stay around on mw.org for quite a long time for historic data.. [00:07:38] Yup. [00:07:48] (PS6) Krinkle: mediawiki.page.ready: Use wikipage.content instead of domready [core] - https://gerrit.wikimedia.org/r/74313 [00:07:57] (CR) Krinkle: "Resolved merge conflict" [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:08:03] I hope my patch doesn't have to stay on gerrit equally long >.> [00:08:13] (CR) Reedy: [C: 2] Load MediaWiki:CodeReview.css on Special:Code [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76045 (owner: Jack Phoenix) [00:08:34] (PS7) Krinkle: mediawiki.page.ready: Use wikipage.content instead of domready [core] - https://gerrit.wikimedia.org/r/74313 [00:08:35] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:08:37] I suspect gerrit isn't going to do anything is it.. [00:08:41] (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76048 (owner: MaxSem) [00:08:51] (CR) Krinkle: "Renamed variable per Ori's comment." [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:08:54] (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf12) - https://gerrit.wikimedia.org/r/76046 (owner: MaxSem) [00:09:02] (CR) Reedy: [V: 2] Load MediaWiki:CodeReview.css on Special:Code [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76045 (owner: Jack Phoenix) [00:09:21] (CR) Ori.livneh: [C: 2] mediawiki.page.ready: Use wikipage.content instead of domready [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:18:09] (Merged) jenkins-bot: mediawiki.page.ready: Use wikipage.content instead of domready [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle) [00:20:15] (PS6) Krinkle: mediawiki.action.edit.preview: Fire "wikipage.content" mw.hook [core] - https://gerrit.wikimedia.org/r/74314 [00:35:45] (CR) Krinkle: "Resolved merge conflict." [core] - https://gerrit.wikimedia.org/r/74314 (owner: Krinkle) [01:04:36] (PS1) Reedy: Remove redundant namespaceAliases [core] (wmf/1.22wmf12) - https://gerrit.wikimedia.org/r/76055 [01:04:50] (PS1) Reedy: Remove redundant namespaceAliases [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76056 [01:05:08] (Abandoned) Reedy: Remove redundant namespaceAliases [core] (wmf/1.22wmf12) - https://gerrit.wikimedia.org/r/76055 (owner: Reedy) [01:06:45] (CR) Reedy: [C: 2 V: 2] Remove redundant namespaceAliases [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76056 (owner: Reedy) [01:07:41] (CR) Aaron Schulz: [C: 2] Fix the target URL of HTMLForm [core] - https://gerrit.wikimedia.org/r/56610 (owner: IAlex) [01:10:15] (CR) Matmarex: [C: 2] "Let's do this, and we'll worry about a hook-based replacement for LivePreviewPrepare later (discussion on PS1: https://gerrit.wikimedia.or" [core] - https://gerrit.wikimedia.org/r/74314 (owner: Krinkle) [01:11:50] (Merged) jenkins-bot: Fix the target URL of HTMLForm [core] - https://gerrit.wikimedia.org/r/56610 (owner: IAlex) [01:13:05] (Merged) jenkins-bot: mediawiki.action.edit.preview: Fire "wikipage.content" mw.hook [core] - https://gerrit.wikimedia.org/r/74314 (owner: Krinkle) [01:13:23] (CR) Aaron Schulz: [C: 2 V: 2] "Returning callback_confirmed is redundant for /token though not wrong per http://oauth.net/core/1.0a/#access_grant" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [01:13:56] (CR) Matmarex: "I filed bug 52071 about that part." [core] - https://gerrit.wikimedia.org/r/74314 (owner: Krinkle) [01:16:01] (PS4) Aaron Schulz: Enforce 1.0a callback param handling [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [01:16:39] (CR) Aaron Schulz: [C: 2 V: 2] "Rebased" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [02:27:50] (CR) Tim Starling: [C: -1] "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie) [02:29:35] (CR) Mattflaschen: [C: -1] "This almost works. However, https://bugzilla.wikimedia.org/show_bug.cgi?id=52072 is a blocker for it. You can see the problem if you cre" [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 (owner: Rjain) [02:29:52] (CR) Mattflaschen: "Also, this needs a rebase onto master." [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 (owner: Rjain) [02:40:42] (PS1) Legoktm: Use proper paramterization and escaping of SQL query conditions [extensions/MassMessage] - https://gerrit.wikimedia.org/r/76057 [02:45:45] (CR) Legoktm: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/76042 (owner: Reedy) [02:46:57] TimStarling: I was suggesting a separate function for request-dependent checks [02:48:03] yeah, it's not really request-dependent though [02:48:03] isEveryoneAllowed() wouldn't cause excess bolding since it would not be hooked onto by oauth, but rather the other function [02:48:20] either everyone is allowed or they're not [02:48:50] that's more or less how it should be [02:49:39] there needs to be some more complex logic for deciding if a special page is restricted [02:49:54] but whether it's restricted or not shouldn't depend on request context [02:50:00] so that doesn't need a request-dependent function either [02:50:05] that's what I was saying [02:50:34] so there could be two functions, but there's no need for either of them to be request-dependent [02:51:22] I suggested using User::groupHasPermission() as the second function, but following your scheme and using User::isMaybeAllowed() or some such would be fine too [02:51:41] not sure about that exact name, but some user static method [02:51:58] static? [02:52:21] well, I guess it still depends on global state, though so do isBlocked and friends [02:52:49] SpecialPage::isRestricted() doesn't care who you are, a page is either restricted or it isn't, right? [02:53:20] yes [02:53:37] that's why I say static [02:54:23] why that over isEveryoneAllowed? [02:54:45] either way it should use some static request-independed method...maybe there is just some bikeshedding going on [02:54:56] whatever it's called :) [02:55:00] sure [02:55:30] the other callers of isEveryoneAllowed() really just want a short-circuit method (that can be request-dependent) [02:56:48] my only concern is that we should be careful to avoid having RawAction and ApiMain::setCacheMode() accidentally call the more permissive function [02:57:03] if the documentation is unclear then someone will do it while we're not looking, in the name of cleanup [03:54:36] (CR) Mattflaschen: "(1 comment)" [extensions/Math] - https://gerrit.wikimedia.org/r/75828 (owner: Physikerwelt) [05:06:29] (PS3) Tim Starling: jobqueue: made federated queue use HashRing for root job de-duplication [core] - https://gerrit.wikimedia.org/r/66227 (owner: Aaron Schulz) [05:06:37] (CR) Tim Starling: [C: 2] jobqueue: made federated queue use HashRing for root job de-duplication [core] - https://gerrit.wikimedia.org/r/66227 (owner: Aaron Schulz) [05:10:49] (Merged) jenkins-bot: jobqueue: made federated queue use HashRing for root job de-duplication [core] - https://gerrit.wikimedia.org/r/66227 (owner: Aaron Schulz) [05:15:22] (PS2) Tim Starling: Add mw.logObject [extensions/Scribunto] - https://gerrit.wikimedia.org/r/70857 (owner: Anomie) [05:15:29] (CR) Tim Starling: [C: 2] Add mw.logObject [extensions/Scribunto] - https://gerrit.wikimedia.org/r/70857 (owner: Anomie) [05:17:27] (Merged) jenkins-bot: Add mw.logObject [extensions/Scribunto] - https://gerrit.wikimedia.org/r/70857 (owner: Anomie) [05:17:50] (Abandoned) Tim Starling: (bug 50347) have mergeMessageFileList check if extension files in file-list are available [core] - https://gerrit.wikimedia.org/r/71056 (owner: Aude) [05:20:34] (PS36) Tim Starling: Make the templates/category lists on edit page collapsible [core] - https://gerrit.wikimedia.org/r/54089 (owner: Matmarex) [05:20:44] (CR) Tim Starling: [C: 2] Make the templates/category lists on edit page collapsible [core] - https://gerrit.wikimedia.org/r/54089 (owner: Matmarex) [05:21:59] finally \o/ [05:22:18] that UI change is way overdue [05:22:24] TimStarling: I'm not sure why you abandoned aude's patch. [05:22:44] it's been a month [05:23:05] she can restore it if she still wants to amend it [05:24:18] Seems bizarre. I think it was fine to close the bug, but patches are typically abandoned by reviewers only if another patch superseded somehow. [05:24:55] I set up my SSH key for Labs earlier today. [05:25:03] (Merged) jenkins-bot: Make the templates/category lists on edit page collapsible [core] - https://gerrit.wikimedia.org/r/54089 (owner: Matmarex) [05:25:03] I think I'm going to make my first Gerrit changeset soon. [05:25:10] Assuming that kind of thing is possible. [05:25:19] ori-l: well it does spam dashboards if left alone [05:26:18] Yeah, sure, I was just a bit surprised. [05:26:31] I sometimes thinking of marking something abandoned as reflecting the reality of something being "abandoned" (someone starts something and then walks away for ages) [05:27:05] the "restore" button is just a click away [05:28:21] What's the status column in Gerrit's SSH Public Keys section? [05:29:57] (PS5) Tim Starling: Move jquery.footerCollapsibleList to core [extensions/Vector] - https://gerrit.wikimedia.org/r/65987 (owner: Anomie) [05:31:09] (CR) Tim Starling: [C: 2] "PS5: rebase, including removing the "mw" variable that Krinkle added, since this change means it is no longer referenced." [extensions/Vector] - https://gerrit.wikimedia.org/r/65987 (owner: Anomie) [05:31:13] (Merged) jenkins-bot: Move jquery.footerCollapsibleList to core [extensions/Vector] - https://gerrit.wikimedia.org/r/65987 (owner: Anomie) [05:33:04] did you know that Timo and Tim are cognates? [05:33:41] * Aaron|home should start pronouncing it "tim-o", heh [05:33:42] I think Roan and Rob are cognates. [05:36:07] don't think so: http://www.surnamedb.com/Surname/Roan [05:37:47] from "red" in gaelic, whereas Robert is from "bright" in german [05:38:43] https://en.wikipedia.org/wiki/Robert_(name) https://en.wikipedia.org/wiki/Roan_(name) [05:38:48] Hmmm, guess so. [05:39:33] interesting that Roan seems to have a british origin, all sources agree on that [05:41:18] (CR) Mattflaschen: [C: -1] "(2 comments)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/75645 (owner: Rjain) [05:41:56] maybe just because I'm using english search terms [05:41:57] ori-l: git-review is your friend. [05:43:49] Okay, I have my keys set up and I've installed git-review. Time to clone. [05:48:14] Seems I need to specify which private key to use in ~/.ssh/config. [05:50:44] Hey-o, there we go. All right, cloned. [05:52:20] Heh, of course the bug I was going to fix was already fixed... [05:52:23] Sigh. [05:54:42] (CR) MZMcBride: "This fixed bug 51695." [integration/docroot] - https://gerrit.wikimedia.org/r/75352 (owner: Krinkle) [05:56:49] I guess I need to find another easy bug to work on. [05:58:30] Elsie: Heh, I have a search called "non-assigned easy bugs" [05:58:40] https://bugzilla.wikimedia.org/buglist.cgi?keywords=easy&resolution=---&list_id=221216 [05:58:44] I'm looking through that now. [06:04:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=33464 [06:05:06] Should that be done in the WikimediaMessages extension or in Wikimedia's configuration files? [06:09:14] > The current tab order is pants, and is not what was requested in comment 1 or [06:09:17] Heh. [06:09:20] comment 5. [06:12:50] Hmmm. I guess if I'm doing extension work, I'm going to need a dev copy of MediaWiki. [06:13:41] Elsie: https://www.mediawiki.org/wiki/Vagrant [06:13:48] Hah. [06:13:56] I was just going to set up a public copy. [06:15:05] I guess the old test site I had was using 1.17. [06:15:12] And I think used SVN. [06:15:16] Probably time to update. [06:15:23] RIP, SVN. [06:22:07] git clone isn't so awful at 15 MiB/s. ;-) [06:26:50] (PS1) IAlex: Fix PHP notice in Special:PagesWithProp where there are no page properties in the database [core] - https://gerrit.wikimedia.org/r/76061 [06:28:02] Hmmm. [06:28:13] It seems MediaWiki 1.12 isn't compatible with PHP 5.4. [06:30:51] Works fine with 5.2, though. [06:36:34] (PS6) Mwjames: \SMW\ChangeAgent a general purpose change Observer [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75850 [06:39:56] # FUCK YOU DATE-DELINKING PRATS [06:39:56] $wgUseDynamicDates = false; [06:40:04] I make myself smile sometimes. [06:42:06] The fact that a default install uses wiki.png instead of mediawiki.png is kind of silly. [06:43:04] (PS2) Legoktm: [WIP] Add a function to extract GMD links from a spamlist. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74941 [06:44:28] (PS3) Legoktm: [WIP] Add a function to extract global message links from a spamlist. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74941 [06:46:39] And a default install still comes with the editing toolbar that looks like it's from 1992. [06:46:49] God bless MediaWiki. [06:49:25] (CR) Mwjames: "I'd appreciate a quick look as this blocks me from adding loose coupling to [1]." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75850 (owner: Mwjames) [06:50:22] ohai Elsie [06:50:27] there's documentation in the README [06:50:59] YuviPanda: I looked at https://wikitech.wikimedia.org/wiki/Grrrit-wm [06:51:08] Sorry, should've mentioned that. [06:51:11] I could copy paste [06:51:12] moment [06:51:18] :-) [06:51:22] how long was it out, btw? [06:51:37] A few minutes. Ryan added himself to the group and restarted it. [06:51:44] And then I think Ori and AzaToth had their way with the bot. [06:51:48] right [06:51:49] heh [06:51:55] do you want me to add you to it too? [06:52:03] having more people be able to kick it might be a good thing [06:52:09] That'd be great, yeah. [06:52:21] I finally set up SSH access to Labs earlier today. [06:52:24] And I almost made my first Gerrit changeset! [06:52:27] But Krinkle thwarted me. [06:52:51] Elsie: heh [06:52:58] Elsie: your wikitech name? [06:53:02] YuviPanda: mzmcbride [06:53:56] Elsie: done [06:54:04] Elsie: do you want to copy the docs over? :D [06:54:19] project-tools ? [06:54:29] hmm? [06:54:33] Hmmm. [06:54:51] mzmcbride@bastion1:~$ id [06:54:51] uid=2671(mzmcbride) gid=500(wikidev) groups=500(wikidev),50062(project-bastion),50380(project-tools) [06:54:54] I'm not sure I'm in the group yet? [06:55:19] Which group should I be in? [06:55:48] Elsie: log out and back in [06:55:59] groups are determined on login, methinks [06:56:12] Same thing. [06:56:28] YuviPanda: Can you paste your id? [06:56:32] `id` rather. [06:56:50] (paste!) [06:56:50] uid=2029(yuvipanda) gid=550(svn) groups=550(svn),1003(wmf),40032(local-suchaserver),50062(project-bastion),50064(project-bots),50070(project-etherpad),50090(project-analytics),50120(project-deployment-prep),50174(project-integration),50214(project-mobile),50380(project-tools),50390(project-eventlogging),50394(project-whatcanido),50416(local-stats),50513(local-dumpscan),50537(local-logger),50545(local-bugello),50576( [06:56:50] local-editcountitis),50608(local-sulinfo),50610(project-toolsbeta),50642(local-bingle),50644(local-code-essay),50663(local-wp-signpost),50674(local-lolrrit-wm) [06:56:56] Hey-o. [06:56:58] Elsie: this is on tools-login [06:57:02] Oh. [06:57:04] I'm on bastion1. [06:57:05] I think there might be some magic going on here [06:57:05] :-) [06:57:08] :P [06:57:21] hmm, I'm in a 'wmf' group [06:57:24] mzmcbride@tools-login:~$ id [06:57:24] uid=2671(mzmcbride) gid=500(wikidev) groups=500(wikidev),50062(project-bastion),50380(project-tools),50440(local-dbreps),50674(local-lolrrit-wm) [06:57:24] I wonder what that means :D [06:57:29] Elsie: sweet [06:57:31] You're staff. [06:57:45] So... how do I access the bot's home? [06:57:51] Elsie: 'become lolrrit-wm' [06:57:56] `become lolrrit-wm` [06:58:09] local-lolrrit-wm@tools-login:~$ pwd [06:58:09] /data/project/lolrrit-wm [06:58:25] yeah [06:58:26] Hmmm, you've got a core dump in the home dir. [06:58:29] that's on NFS [06:58:30] And no pstack installed. [06:58:51] oh, that's unexpected [06:59:02] but at least azatoth added enough logging to tell me why this was crashing [06:59:05] logs inside logs/ [06:59:12] Every time I log in to someone else's account, I creep on their .bash_history. [06:59:21] hehe [06:59:34] What's with the #137... [06:59:49] Unix timestamp? [06:59:58] yeah I guess [07:00:03] Weird. [07:00:30] $ egrep -v '^#' .bash_history [07:00:31] ;-) [07:01:02] Someone used tail -n50 rather than tail -50. :-) [07:01:12] * Elsie stops creeping. [07:01:28] :P [07:01:30] Where's this famed README? [07:01:42] Elsie: in the repo. look under ~/lolrrit-wm [07:01:48] * Elsie nods. [07:01:48] or labs/tools/grrrit-wm [07:03:28] https://wikitech.wikimedia.org/wiki/Grrrit-wm [07:03:46] I'm a little lazy. [07:04:00] very, you mean :P [07:04:06] want me to wikify it? [07:04:11] Some call it efficient! [07:04:15] Sure. :-) [07:04:29] :P [07:04:45] So to run the bot, I just need to run.... [07:04:49] ./run.bash [07:04:55] That's all I really need to know. [07:05:11] Or should I use stat? [07:05:12] qstat [07:05:17] Thanks, auto-correct. [07:05:25] (Abandoned) Aude: Add index for rc_type in recentchanges [core] - https://gerrit.wikimedia.org/r/51191 (owner: Aude) [07:07:08] YuviPanda: So does the bot have any mechanism to keep it alive? [07:07:16] Or does it just run on prayer and uptime? [07:07:40] Elsie: there's no natural exit path, so if it exits it has a non zero exit value [07:07:43] Elsie: and SGE will restart it [07:07:45] automatically [07:08:10] (We hope.) [07:08:23] All right. [07:08:30] Is there anything else I need to know about it? [07:08:36] And... how did you add me to the group? [07:08:58] Elsie: on wikitech, to the left 'manage instances', select tools, go to lolrrit-wm, 'add user to service group' [07:09:15] Fancy. [07:09:15] Elsie: I added list of people with access https://wikitech.wikimedia.org/wiki/Grrrit-wm [07:10:47] I don't have a Manage instances link. [07:11:14] Elsie: Hit the toggle "Labs Projectadmins" [07:11:20] on the sidebar. [07:11:55] I don't see that. [07:12:12] * Elsie smiles at legoktm's edit. [07:12:17] :) [07:12:21] Elsie: http://cl.ly/image/380U2z0e290H [07:12:33] I don't have that whole section. [07:12:41] I only have navigation --> help --> toolbox. [07:12:51] grr, disconnected [07:13:03] It's not in the HTML source. [07:13:12] Special:NovaInstance then. [07:13:22] Why am I missing a sidebar section? [07:14:23] I think I'm not in a particular group. [07:14:45] Hmmmmmm. [07:16:00] Ryan_Lane: Any idea why the GROUP-SIDEBAR section wouldn't be displaying for my account? [07:18:09] legoktm: Not sure I understand this NovaInstance interface. [07:18:15] I was trying to look up who's in the dbreps group. [07:18:26] use https://tools.wmflabs.org/ [07:18:40] That seems like cheating. [07:19:08] Special:NovaGroupService, apparently. [07:22:56] (PS7) Legoktm: Edit via the API instead of WikiPage::doEditContent. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75299 [07:24:23] YuviPanda, Elsie: ^ review plz [07:24:47] legoktm: Can you add me to that repo? [07:24:52] Or is that a Chad thing? [07:25:16] Let me see [07:25:30] Yeah, I can't edit it [07:25:33] https://gerrit.wikimedia.org/r/#/admin/groups/535,members [07:25:49] Gay. [07:25:58] Clearly I should just have +2 on everything. [07:26:11] added [07:26:21] Extension:Massage [07:26:25] sounds relaxing. [07:27:04] ori-l: thanks [07:27:14] ori-l: Thanks. :-) [07:27:30] ori-l: added yiy ti tge tiik [07:27:31] err [07:27:34] added you to the tool [07:27:36] (PS1) Santhosh: Code format cleanup [extensions/Annotator] - https://gerrit.wikimedia.org/r/76063 [07:29:08] (PS2) Santhosh: Code format cleanup [extensions/Annotator] - https://gerrit.wikimedia.org/r/76063 [07:32:53] YuviPanda: what tool? [07:33:17] ori-l: grrrit-wm [07:33:34] (PS1) Legoktm: Add MassMessage.alias.php file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/76064 [07:34:17] ori-l: did something come out of the canonical namespaces discussion? [07:35:30] nothing canonical [07:36:57] heh [07:38:19] ori-l: http://theoatmeal.com/comics/running3 #kraken [07:39:58] ori-l: http://pruebita.com/wiki/Special:UserLogin?type=signup [07:40:08] Is the -1 bug known? [07:43:58] (PS7) Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/74850 [07:44:15] (PS1) Mwjames: MW 1.19 / Job::getTitle() does not exists [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76065 [07:48:16] (PS2) Mwjames: MW 1.19 / Job::getTitle() does not exists [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76065 [07:49:47] (CR) Mwjames: [C: 2] MW 1.19 / Job::getTitle() does not exists [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76065 (owner: Mwjames) [07:51:06] (Merged) jenkins-bot: MW 1.19 / Job::getTitle() does not exists [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76065 (owner: Mwjames) [07:55:06] (CR) Raimond Spekking: [C: 2] Add MassMessage.alias.php file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/76064 (owner: Legoktm) [07:55:10] (Merged) jenkins-bot: Add MassMessage.alias.php file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/76064 (owner: Legoktm) [08:03:07] (CR) Mattflaschen: [C: -1] "I don't follow. Can you explain why this is needed?" [extensions/GuidedTour] - https://gerrit.wikimedia.org/r/76021 (owner: Reedy) [08:11:36] good morning [08:13:22] Morning, hashar. [08:13:47] Elsie: have you followed the VisualEditor option drama ? [08:14:00] do you know whether it is now possible to disable it? [08:14:10] A temporary disable option was added, yes. [08:14:21] Under Special:Preferences --> Editing. [08:14:30] I followed the drama, yes. Some would say I contributed to it. ;-) [08:14:35] https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing [08:14:40] > Temporarily disable VisualEditor while it is in beta [08:14:44] hashar: ^ [08:14:46] great [08:15:21] > Show preview on first edit [08:15:27] That's a silly preference name. [08:15:31] which leads me to VE commit https://gerrit.wikimedia.org/r/#/c/75541/ [08:15:55] Yes, that was merged and deployed. [08:16:36] so I am abandoning the change submitted to core [08:16:42] err to mw config https://gerrit.wikimedia.org/r/#/c/73565/ [08:16:42] :) [08:16:55] Hmmm. [08:17:03] You may want to propose that first. [08:17:11] Oh, it's already abandoend. [08:17:27] abandoned, rather. [08:17:29] All right. [08:17:39] and I closed https://bugzilla.wikimedia.org/show_bug.cgi?id=50929 [08:17:56] Fair enough. [08:17:57] I am glad I did not have to get involved :-] [08:18:13] :-) [08:21:27] Elsie: I noticed a comment by you to do a simple change on the integration.wikimedia.org website [08:21:37] can't find it anymore though [08:21:46] I was wondering why you don't submit patch directly [08:22:16] hashar: Heh. I set up my Gerrit commit access today, intending to submit my first patch. [08:22:23] It turns out Krinkle already fixed the issue, though. :-) [08:22:25] It was bug... [08:22:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=51695 [08:22:43] I don't usually do code commits/review. [08:22:43] ahh greet [08:22:52] if you need help to submit patch let me know [08:22:57] Will do. :-) [08:22:57] I will be more than happy to guide you [08:23:08] The docs on mediawiki.org are surprisingly good. [08:23:22] I was following . [08:23:43] when we did the SVN to GIT migration we had some kind of community drama about git being too hard [08:23:54] when it was really only about properly managing the change [08:23:58] that is the usual trouble in our domain [08:24:22] people get used to some habits and are disrupted whenever a checkbox/tool change hehe [08:24:31] so lot of people invested lot of time producing guides / tutorials [08:25:03] Elsie: those docs have been worked on a lot [08:25:08] Elsie: that getting started page is excellent [08:25:49] so lot of people invested lot of time producing guides / tutorials :] [08:27:25] I am biased, I love VE. Iwanted that for as long as I have been an editor [08:27:36] (CR) Mattflaschen: [C: -1] "(4 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [08:32:40] VE has great potential. [08:32:46] It's still very much beta, though. [08:35:54] I agree [08:36:14] the main concern I have with it right now is that it is a CPU heater :] [08:37:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=52084 [08:43:23] (CR) Physikerwelt: "Thanks for this comment. I'd like that as well. Is there a common way to convert the array to a string within the mediawiki framework?" [extensions/Math] - https://gerrit.wikimedia.org/r/75828 (owner: Physikerwelt) [08:44:22] Someone named Michael Jackson worked on ArticleFeedback? [08:44:25] https://en.wikipedia.org/wiki/Special:Version [08:45:17] easter egg ? :D [08:45:33] (CR) Physikerwelt: "ok that won't work since there is no key" [extensions/Math] - https://gerrit.wikimedia.org/r/75828 (owner: Physikerwelt) [08:45:40] The Special:Version easter egg is gone. :-( [08:47:04] (PS2) Mattflaschen: Add a test for changeset Ifed2860bb7cde7d3a5fc2fba82571a94e13128ba [core] - https://gerrit.wikimedia.org/r/75794 (owner: MarkTraceur) [08:48:07] (CR) jenkins-bot: [V: -1] Add a test for changeset Ifed2860bb7cde7d3a5fc2fba82571a94e13128ba [core] - https://gerrit.wikimedia.org/r/75794 (owner: MarkTraceur) [08:49:48] Elsie: Michael Orion Jackson from Omniti :) [08:49:58] :-) [08:50:24] https://gerrit.wikimedia.org/r/#/c/9699/3/ArticleFeedbackv5.php,unified :-] [08:50:37] (CR) Mattflaschen: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [08:56:03] (PS23) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [08:56:12] (PS24) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [08:57:02] qchris: we should perhaps rewrite that to run on toollabs :P [08:57:31] :-) [08:57:42] YuviPanda: Now it seems to work as expected. [08:57:56] So I won't have to run that in future. [08:58:04] Sorry for the nouse [08:58:21] s/nouse/noise/ [08:58:21] :) [08:58:26] qchris: you can't create gerrit repos, can you? [08:58:52] YuviPanda: In fact ... maybe we can make grrrit-wm ignore this change completely (also for future stuff)? [08:59:08] qchris: everything from test/gerrit-ping? [08:59:09] qchris: I could create repos when I last tried :-) [08:59:10] nah, let's keep it [08:59:23] qchris: ooh, can you create labs/tools/SuchABot [08:59:28] qchris: What's with the All-Projects repo? [08:59:35] YuviPanda: Yes, ignoring everything from test/gerrit-ping would be great :-D [08:59:36] qchris: and import http://github.com/yuvipanda/SuchaBot to it? [09:00:52] YuviPanda: Yes, I can try. Let me review the category etc, then I'll bring it up on http://www.mediawiki.org/wiki/Git/New_repositories/Requests [09:01:17] Elsie: I do not understand, what you mean. Is something wrong with the All-Projects repo? [09:01:49] qchris: ty [09:01:52] qchris: I don't understand why it exists. [09:02:03] It always sorts to the top because it's the only repo using a capitalized letter, I think. [09:02:51] Elsie: This repo is kind of a special repo. All Projects inherit from this repo one way or another. [09:03:04] It's a Gerrit thing? [09:03:07] Elsie: Yes. [09:03:10] Hmm. [09:03:15] All right. [09:07:34] superm401: OH MY GOD GO TO SLEEP SOMETIME [09:07:38] * marktraceur does so too [09:34:03] Any VE staff around? [09:36:02] Hi hoo. [09:36:43] hi Elsie... you aren't VE staff, are you? :P [09:37:00] I'm not sure such a thing exists. [09:37:09] There are Wikimedia Foundation staff who work primarily on VE. [09:37:13] What's up? [09:37:13] Yep [09:37:38] They seem to do evil things with sections which cause problems [09:37:59] And you'd like to berate in person? ;-) [09:38:16] What evil things? [09:38:38] You almost surely want Bugzilla, but I can try to verify/confirm any bugs for you. [09:38:39] Elsie: Well, see https://en.wikipedia.org/wiki/Special:AbuseLog/9045766 vs. https://en.wikipedia.org/w/index.php?title=Eddie_Vedder&diff=prev&oldid=565713096 [09:39:16] tag: blanking [09:39:18] Hmmmmm. [09:39:59] Looks like an AbuseFilter bug? [09:40:23] Elsie: Nope [09:40:32] The problem lies deeper [09:40:38] VE doesn't do anythingwith sections afaik. [09:40:46] Is VE passing bad data to AF? [09:41:06] and that wasn't a VE edit according to tags anyway? [09:41:11] Might be the edit api eitehr [09:41:25] MatmaRex: I think revs can only have one tag. [09:41:33] Elsie: no, theycan have many [09:41:40] Hmmm. [09:41:57] hoo: Why do you suspect VE? [09:42:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=51254 is about a bug which wiped out multiple tags, but there can bemany. [09:42:16] Elsie: Because it's the only thing that changed recently [09:42:39] hoo: VE has a grand total of like 100 lines of PHP code [09:43:03] MatmaRex: They did many changes on EditPage and relevant code especially in the early phase of the project [09:43:03] Well, looking at this from the outside, I'd say it's an AbuseFilter bug until proven otherwise. :-) [09:43:08] that's why I want to talk to them [09:43:21] #mediawiki-visualeditor is probably where you want. [09:43:24] Elsie: We're already proven otherwise [09:43:24] hoo: i think they're all in SF timezone [09:43:29] and what Elsie said [09:43:31] Though it's like 3 in the morning in SF. [09:43:35] AF isn't generating that data on it's own [09:43:46] hoo: Is there a bug in Bugzilla about this? :-) [09:43:54] You may have to work asynchronously. [09:43:57] Elsie: Yep, for AbuseFilter [09:44:05] Link? [09:44:10] I guess I have to investigate that at my own [09:44:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=52077 [09:47:51] What's grrrit-wm's quit message? [09:47:54] hoo: to me this looks like the filter AF uses is being run prematurely [09:47:57] hoo: I copied a few folks. [09:48:10] * MatmaRex looks at recent changes to EditPage [09:48:46] (me and AzaToth are experimenting with grrrit-wm) [09:48:50] Oh. [09:48:57] All right. [10:05:37] (CR) Daniel Kinzler: [C: -2] "If I understand correctly, this uses the data in the suggester engine to find out which properties are already present in a given wikibase" [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/76012 (owner: Nilesh) [10:12:24] Elsie: I could reproduce it locally now... the problem is the edit API [10:12:28] and VE is using that [10:17:46] (CR) Daniel Kinzler: [C: 2] Removed rescorer, added maven dependencies for testing [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/76033 (owner: Nilesh) [10:19:59] (CR) Daniel Kinzler: [C: 1] "(2 comments)" [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/76034 (owner: Nilesh) [10:26:41] (PS1) Matmarex: mediawiki.action.edit: Add styles for edit form's footer [core] - https://gerrit.wikimedia.org/r/76067 [10:26:46] (PS1) Matmarex: EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a [core] - https://gerrit.wikimedia.org/r/76068 [10:27:06] (PS1) Matmarex: Hide MediaWiki's "Editing help" link, as we provide it in the toolbar [extensions/WikiEditor] - https://gerrit.wikimedia.org/r/76069 [10:27:24] (PS1) Matmarex: Delete the ext.vector.footerCleanup module [extensions/Vector] - https://gerrit.wikimedia.org/r/76070 [10:27:37] pow. [10:32:03] (PS2) Matmarex: Fix PHP notice in Special:PagesWithProp where there are no page properties in the database [core] - https://gerrit.wikimedia.org/r/76061 (owner: IAlex) [10:32:23] (CR) Matmarex: [C: 1] "Trivial, I messed with the commit message." [core] - https://gerrit.wikimedia.org/r/76061 (owner: IAlex) [10:53:00] (CR) Daniel Kinzler: [C: -1] "(6 comments)" [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/76035 (owner: Nilesh) [11:00:31] (CR) Daniel Kinzler: [C: 1] "seems sane, but i don't even know what this extension does :)" [extensions/Insider] - https://gerrit.wikimedia.org/r/75877 (owner: Aude) [11:01:07] (CR) Daniel Kinzler: [C: 1] "seems sane, but i don't even... :P" [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 (owner: Aude) [11:05:04] (CR) Amire80: [C: 2] Lazy initialization of language settings for IME menu [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75564 (owner: Santhosh) [11:06:49] (Merged) jenkins-bot: Lazy initialization of language settings for IME menu [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75564 (owner: Santhosh) [11:14:10] andre__: you there? [11:14:31] andre__: could the gerrit notif. bot be made to add the link and set the status in one change, instead of two? [11:14:41] everybody's already getting enough bugmail :) [11:19:39] (CR) Amire80: [C: 2] Lazy initilization of language settings from ULS [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75574 (owner: Santhosh) [11:20:10] (Merged) jenkins-bot: Lazy initilization of language settings from ULS [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75574 (owner: Santhosh) [11:21:16] (PS1) Shirayuki: Add full-stops [extensions/PollNY] - https://gerrit.wikimedia.org/r/76081 [11:21:29] MatmaRex, I just chatted with qchris about this, and the bugzilla-hooks design is bad enough that this requires some changes. I was also surprised [11:23:02] alright. thanks [11:41:59] hmmm. i wonder if abusefilter is compatible with mw 1.16. [11:44:05] (CR) Parent5446: [C: 2] Special:PagesWithProp: Fix PHP notice if no page properties are present [core] - https://gerrit.wikimedia.org/r/76061 (owner: IAlex) [11:44:06] (CR) Reedy: "So, if you do a recursive checkout of all of our repos (which when you need a lot of the git tree, it is much simpler to do it this way), " [extensions/GuidedTour] - https://gerrit.wikimedia.org/r/76021 (owner: Reedy) [11:45:34] (CR) Reedy: "Well, isn't that screwed up. Thanks gerrit" [extensions/GuidedTour] - https://gerrit.wikimedia.org/r/76021 (owner: Reedy) [11:46:51] (PS1) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [11:47:17] (Merged) jenkins-bot: Special:PagesWithProp: Fix PHP notice if no page properties are present [core] - https://gerrit.wikimedia.org/r/76061 (owner: IAlex) [11:49:12] Freshly uploaded change... and already needs a rebase [11:50:31] (PS2) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [11:51:18] Elsie: ^ [11:51:32] that kind of sucks, but I don't see a nicer way :/ [12:00:01] (PS1) Jack Phoenix: Moved hooks into their own file + bumped version [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76083 [12:01:17] Reedy or someone else wanting to do an easy CR? ;) ^ [12:01:46] hey, hoo, you're the abusefilter guru [12:01:54] will it even work on 1.16? [12:02:49] MatmaRex: 1.16... it'll work back to 1.19 [12:03:03] I guess you have to test any earlier version per hand [12:03:29] i have been coaxed into helping a site with their spambot problem [12:03:34] and they're still on 1.16 [12:03:43] (CR) MaxSem: [C: 2] Moved hooks into their own file + bumped version [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76083 (owner: Jack Phoenix) [12:03:51] (Merged) jenkins-bot: Moved hooks into their own file + bumped version [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76083 (owner: Jack Phoenix) [12:03:57] okay, it doesn't work. [12:04:01] :/ [12:04:08] (CR) Daniel Kinzler: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:04:09] i wonder if there is an old enough version that might work [12:04:22] There is... [12:05:27] MatmaRex: use (an old version of) SpamBlacklist [12:05:28] lessee. [12:05:49] DanielK_WMDE: i think they already have spamblacklist [12:05:52] cheers MaxSem =) [12:05:57] so it either doesn't help or is somehow misconfigured [12:05:59] (PS2) Shirayuki: Add full-stops [extensions/PollNY] - https://gerrit.wikimedia.org/r/76081 [12:06:09] !e SpamBlacklist [12:06:09] https://www.mediawiki.org/w/index.php?title=Extension:SpamBlacklist [12:06:09] MatmaRex: do they know how to configure/customize it? it might be sufficient if nicely tweaked [12:06:31] 274dcd06a27f0675441d850afebf803ba9ab740f Pass one of converting AbuseFilter to use ContextSource [12:06:42] so i guess anything older than this might work. [12:07:53] (CR) Jack Phoenix: [C: 2 V: 2] Add full-stops [extensions/PollNY] - https://gerrit.wikimedia.org/r/76081 (owner: Shirayuki) [12:08:37] (CR) Shirayuki: "Thanks for quick response." [extensions/PollNY] - https://gerrit.wikimedia.org/r/76081 (owner: Shirayuki) [12:17:20] (PS3) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [12:18:40] heh, actually, 1.16 doesn't have ResourceLoader yet [12:18:49] so i have to go a litle further back in time [12:18:54] (CR) Hoo man: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:19:47] oh yes... I remember when all of WMF went down because they first started to roll out 1.17wmf1 :P [12:20:39] (CR) Hoo man: "More efficient, thanks Daniel" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:20:44] (CR) Daniel Kinzler: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:20:50] hoo: --^ [12:21:17] DanielK_WMDE: You should have read that new comment ;) [12:22:22] hoo: hm? which one? [12:22:32] i see "done" and "thanks"... [12:23:47] "// The content supports sections (has already been checked). " [12:25:00] (CR) Santhosh: [C: 1] (bug 51870) fix html in toolbox for related articles [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 (owner: Aude) [12:27:04] (PS2) Aude: (bug 51870) fix html in toolbox for related articles [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 [12:27:57] yay [12:28:00] look ma, no fatals! [12:28:21] * YuviPanda gives MatmaRex fractals [12:28:23] DanielK_WMDE: Seeing it again, I'm no longer sure about that... I better check for sanity... that API module does a lot in execute :/ [12:29:10] (PS4) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [12:29:40] (CR) Hoo man: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:30:18] (CR) Hoo man: "Better check for supportsSections explicitly." [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [12:30:23] (PS4) Rjain: Added the update class [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 [12:31:54] (PS1) IAlex: Fix documentation of $wgTranscludeCacheExpiry [core] - https://gerrit.wikimedia.org/r/76087 [12:32:32] (CR) Amire80: [C: 2] Lazy initialization of language settings and ULS from interface triggers [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75582 (owner: Santhosh) [12:32:43] (Merged) jenkins-bot: Lazy initialization of language settings and ULS from interface triggers [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75582 (owner: Santhosh) [12:33:02] (PS2) Matmarex: Fix documentation of $wgTranscludeCacheExpiry [core] - https://gerrit.wikimedia.org/r/76087 (owner: IAlex) [12:33:19] (CR) Matmarex: ""Bug:" in the commit message really should be uppercased." [core] - https://gerrit.wikimedia.org/r/76087 (owner: IAlex) [12:34:18] (CR) Matmarex: [C: 2] Fix documentation of $wgTranscludeCacheExpiry [core] - https://gerrit.wikimedia.org/r/76087 (owner: IAlex) [12:35:12] (PS1) Jack Phoenix: Don't pass crap to Html::input. [extensions/CodeReview] - https://gerrit.wikimedia.org/r/76090 [12:36:40] found a bug and fixed it, no Bugzilla involved :) [12:37:16] (Merged) jenkins-bot: Fix documentation of $wgTranscludeCacheExpiry [core] - https://gerrit.wikimedia.org/r/76087 (owner: IAlex) [12:38:55] (CR) Rjain: "The problem above is solved. But when the annotation is updated, the id is also stored in the json text (Don't know why). So, there are so" [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 (owner: Rjain) [12:41:12] hashar: Hallo. Several people told me that you can help me log in to the server that hosts http://en.wikipedia.beta.wmflabs.org/wiki/Boleyn_family . [12:41:20] I have a labs account, though I haven't used it much. [12:59:25] (PS2) Amire80: Delay loading of language settings javascript [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75830 (owner: Santhosh) [12:59:57] (CR) Amire80: [C: 2] "Patch set 2 - rebase and spelling fix in commit message." [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75830 (owner: Santhosh) [13:00:07] (Merged) jenkins-bot: Delay loading of language settings javascript [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75830 (owner: Santhosh) [13:05:35] (CR) Hoo man: [C: -1] "This will probably give less meaningful error messages for failed API edits. The VisualEditor team is probably interested in this as they " [extensions/SpamBlacklist] - https://gerrit.wikimedia.org/r/75867 (owner: Daniel Kinzler) [13:08:48] (PS4) Amire80: Load jquery.ime only when user focus on editable fields [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75853 (owner: Santhosh) [13:42:40] hashar: ^ [13:42:50] or anybody who knows stuff about beta labs? [13:43:29] aharoni: what's up with beta labs? [13:43:39] how can I log in there? [13:43:47] aharoni: i think I can add you [13:43:54] aharoni: one moment, let me find link [13:43:56] to the server that hosts http://en.wikipedia.beta.wmflabs.org/wiki/Boleyn_family . [13:44:07] I have a labs account, if it helps, though I hardly use it. [13:44:20] aharoni: is it all setup? [13:44:27] aharoni: what is your labs username? [13:44:43] (CR) Amire80: [C: 2] Load jquery.ime only when user focus on editable fields [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75853 (owner: Santhosh) [13:44:54] (Merged) jenkins-bot: Load jquery.ime only when user focus on editable fields [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75853 (owner: Santhosh) [13:45:29] aharoni: I'll need to grant you access, and then you can login using instructions on https://wikitech.wikimedia.org/wiki/Help:Access [13:45:51] YuviPanda: should be amire80 [13:46:25] aharoni: added. [13:46:46] dhanywad [13:46:58] aharoni: ssh deployment-bastion.pmtpa.wmflabs should work, if you have setup the config right [13:47:11] aharoni: I've played with it a bit before, so poke me (or hashar) if you need help :) [13:47:16] aharoni: also come over to #wikimedia-labs :) [13:47:19] c88l [13:48:22] aharoni: oh you want to log on beta ? :-] [13:48:40] whatever hosts http://en.wikipedia.beta.wmflabs.org/wiki/Boleyn_family [13:48:50] what is your labs account ? [13:48:52] hashar: I added him to the project [13:48:53] that's where the cucumber tests are supposed to run [13:48:54] amire80 [13:49:19] so you can already connect there [13:49:24] <<>> [13:49:27] the main working machine is deployment-bastion.pmtpa.wmflabs [13:49:39] it is similar to the good old fenari or the shinny new tin.eqiad.wmnet [13:50:29] https://wikitech.wikimedia.org/wiki/Help:Access is 8 pages in print [13:50:36] i need to write a tldr version :) [13:50:47] 8 pages? wtf [13:51:20] what you really want is setting up ssh ProxyCommand https://wikitech.wikimedia.org/wiki/Help:Access#Using_ProxyCommand_ssh_option [13:51:26] let me dump my ssh config somewhere [13:51:52] really? that doesn't look like 8 pages to me :| [13:52:49] YuviPanda: hashar try print preview [13:52:53] aharoni: https://gist.github.com/hashar/6089014 [13:53:08] aharoni: if the doc page is more than 2 page, it is not worth reading it will get you confused [13:53:14] mediawiki.org git/workflow was 30 pages, [13:53:18] stick the above gist somewhere in your ~/.ssh/config [13:53:26] adjust the User stanzas to be amire80 [13:53:37] so somebody wrote git/tutorial, and it quickly got to 30 pages, too [13:53:41] from there you can connect to the instance with ssh deployment-bastion.pmtpa.wmflabs [13:54:00] so I wrote git/tldr with the explicit intent of being no longer than a single page in print preview :) [13:54:01] ssh will lookup that host according tot he config, will find out it needs to Proxy to bastion.pmtpa.wmflabs [13:54:25] looking up bastion.pmtpa.wmflabs it will find the host bastion.wmflabs.org, connect to it and relay all your ssh client commands directly to the instance [13:54:30] bam you are logged in (or should be) [13:55:09] It does not even explain how to sign up for an account :( [13:57:10] oh, now I know why the number of bugs in my favorite search dropped this much recently... htere's a new status [13:59:21] (PS5) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [13:59:39] (CR) Hoo man: "Rebased again..." [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:01:37] i need to make a bot to autorebase stuff. [14:02:02] YuviPanda: you there? [14:02:12] MatmaRex: hello! [14:02:17] hi [14:02:26] that ssh command you gave me the other day doesn't work :( [14:02:33] which one? [14:02:35] (the one to get streamed events from gerrit) [14:02:36] stream events? [14:02:53] complains that i don't have thepermission or something [14:03:08] MatmaRex: grr, I think we need ^demon or someone back to grant you perms for that [14:03:14] are you going to write a rebase bot? [14:03:31] why does it even need a permission? D: [14:03:32] maybe [14:03:41] depending on how hard this will turn out to be [14:03:52] if so, please use gerrit-to-redis. Don't call stream events directly :) [14:04:11] with gerrit-to-redis, you give me a secret key, and bam - you've a reliable redis queue that is constantly populated with all changes from stream evenets [14:04:13] (on toollabs) [14:04:16] that sounds like more stuff to install [14:04:32] well, it's *less* stuff to install [14:04:38] provided you are running this on toollabs [14:04:42] gerrit-to-redis is a service there. [14:04:46] i want to listen for V-1, then `git review -d`, `git rebase master` with a magic merge driver, and `git review -f` [14:05:00] should be rather trivial [14:05:02] that's gonna be like 30 lines of code, hopefully [14:05:24] so depending on how this will turn out, i'll have it finished by this evening or never ;) [14:05:34] heh [14:06:02] aharoni: have you managed to connect? [14:07:13] doesn't gerrit have a more traditional form of providing "news"? [14:07:34] RSS, anyone? :( [14:08:21] qchris: alive? [14:08:22] like? [14:08:23] there's a 'REST' API [14:08:23] but that's not 'news' [14:08:29] it probably has a simpler way to trigger Rebase [14:08:58] hm, or maybe i could look for changes which don't merge [14:09:01] * YuviPanda should document gerrit-to-redis at some point [14:09:49] (CR) Hoo man: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74170 (owner: Daniel Kinzler) [14:10:57] MatmaRex: Yes, qchris is alive. However, I am not sure that adding further stream event consumers is the best idea. [14:11:29] MatmaRex: Using the redis stuff does not sound too bad to me. [14:11:44] MatmaRex: Any particular problem you are running into when using it? [14:12:07] well, haven't tried yet [14:12:16] hm, maybe the REST API will do for my needs [14:24:31] (PS1) Yaron Koren: Added optional header message for pages with no approved revision [extensions/ApprovedRevs] - https://gerrit.wikimedia.org/r/76098 [14:26:01] (CR) Anomie: [C: -1] "At a general level, I'm not entirely sure about this. Is APIEditBeforeSave supposed to be more-or-less equivalent to EditFilterMerged, or " [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:27:00] (CR) Anomie: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:32:03] (CR) Hoo man: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:32:31] (PS6) Hoo man: Make APIEditBeforeSave give the whole revision [core] - https://gerrit.wikimedia.org/r/76082 [14:33:24] (CR) Hoo man: "Addressed Anomie's comment... thanks" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:36:38] (CR) Hoo man: "The documentation says "$text : the new text of the article (has yet to be saved)" and I think the hook should follow its documentation wh" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [14:41:11] (CR) Yaron Koren: [C: 2 V: 1] Added optional header message for pages with no approved revision [extensions/ApprovedRevs] - https://gerrit.wikimedia.org/r/76098 (owner: Yaron Koren) [14:41:26] (Merged) jenkins-bot: Added optional header message for pages with no approved revision [extensions/ApprovedRevs] - https://gerrit.wikimedia.org/r/76098 (owner: Yaron Koren) [14:53:54] (PS2) Hoo man: (bug 49694) Apply $wgSpamRegex to the new section name in action=edit§ion=new [core] - https://gerrit.wikimedia.org/r/75556 (owner: IAlex) [14:54:00] (PS1) Robert Vogel: Latest version from 'Hallo Welt! Medienwerkstatt GmbH'. There may be newer versions on the webplatform.org webserver [extensions/WebPlatformSearchAutocomplete] - https://gerrit.wikimedia.org/r/76101 [14:54:05] (PS5) Anomie: Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 [14:54:12] (CR) Hoo man: "Rebased" [core] - https://gerrit.wikimedia.org/r/75556 (owner: IAlex) [14:54:26] (PS6) Anomie: Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 [14:54:30] (CR) Anomie: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie) [14:58:45] (PS1) Robert Vogel: Latest sources from 'Hallo Welt! Medienwerkstatt GmbH' There may be a newer version on the servers of webplatform.org [extensions/WebPlatformAuth] - https://gerrit.wikimedia.org/r/76102 [15:00:02] (CR) Hoo man: [C: 2] "Worked in a brief test and looks sane... thanks" [core] - https://gerrit.wikimedia.org/r/75556 (owner: IAlex) [15:02:33] (Merged) jenkins-bot: (bug 49694) Apply $wgSpamRegex to the new section name in action=edit§ion=new [core] - https://gerrit.wikimedia.org/r/75556 (owner: IAlex) [15:04:13] (PS1) Anomie: Followup Idfee1b4d per Tim [core] - https://gerrit.wikimedia.org/r/76103 [15:06:09] (CR) Anomie: "PS6: Update per comments. See also I381553e7." [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie) [15:08:38] (CR) Daniel Kinzler: [C: 1] "Seems fine, but I havn't tested it, and we have no unit tests for this either. So, before merging, please test :)" [core] - https://gerrit.wikimedia.org/r/76082 (owner: Hoo man) [15:13:11] (PS1) Cmcmahon: Some links are more flaky post-VE [qa/browsertests] - https://gerrit.wikimedia.org/r/76104 [15:13:26] (CR) Cmcmahon: [C: 2] Some links are more flaky post-VE [qa/browsertests] - https://gerrit.wikimedia.org/r/76104 (owner: Cmcmahon) [15:14:47] (PS1) Aklapper: Add bmo extension InlineHistory [wikimedia/bugzilla/modifications] - https://gerrit.wikimedia.org/r/76105 [15:15:25] (CR) Matmarex: "<3" [wikimedia/bugzilla/modifications] - https://gerrit.wikimedia.org/r/76105 (owner: Aklapper) [15:15:58] We should install ALL of the extensions [15:16:03] * Reedy modifies MatmaRex [15:20:57] (PS1) Aude: Update Wikibase [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76107 [15:26:49] (PS7) Cmcmahon: WIP Test central-domain login, cross-domain login and central login for anons [qa/browsertests] - https://gerrit.wikimedia.org/r/74128 (owner: Zfilipin) [15:26:51] (PS1) Aude: Update Wikibase [core] (wmf/1.22wmf12) - https://gerrit.wikimedia.org/r/76108 [15:27:34] (CR) Reedy: [C: 2 V: 2] Update Wikibase [core] (wmf/1.22wmf12) - https://gerrit.wikimedia.org/r/76108 (owner: Aude) [15:27:40] (CR) Reedy: [C: 2 V: 2] Update Wikibase [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/76107 (owner: Aude) [15:41:47] (CR) Daniel Kinzler: [C: 1] "restore +1" [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 (owner: Aude) [15:48:00] (CR) Mglaser: [C: 2 V: 2] "This is just a test to make sure our connect works" [skins/BlueSpiceSkin] - https://gerrit.wikimedia.org/r/76109 (owner: Robert Vogel) [15:52:13] (PS1) Cmcmahon: another fix for flaky post-VE editing [qa/browsertests] - https://gerrit.wikimedia.org/r/76111 [15:52:24] (CR) Cmcmahon: [C: 2] another fix for flaky post-VE editing [qa/browsertests] - https://gerrit.wikimedia.org/r/76111 (owner: Cmcmahon) [16:03:04] (CR) Hoo man: [C: 2] "Works fine, see also https://bugzilla.wikimedia.org/show_bug.cgi?id=52099" [core] - https://gerrit.wikimedia.org/r/74224 (owner: Daniel Kinzler) [16:05:35] (Merged) jenkins-bot: Allow debugging of unit tests via wfDebugLog. [core] - https://gerrit.wikimedia.org/r/74224 (owner: Daniel Kinzler) [16:05:46] (CR) Daniel Kinzler: [C: 2] Added unit tests for AbstractEntitySuggesterServlet and WebClientRecommender [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/76013 (owner: Nilesh) [16:12:18] I am off see you on monday [16:12:59] Bye, hashar. [16:19:56] (PS1) Cmcmahon: temporarily disable this test pending https://gerrit.wikimedia.org/r/#/c/74128/ [qa/browsertests] - https://gerrit.wikimedia.org/r/76112 [16:20:09] (CR) Cmcmahon: [C: 2] temporarily disable this test pending https://gerrit.wikimedia.org/r/#/c/74128/ [qa/browsertests] - https://gerrit.wikimedia.org/r/76112 (owner: Cmcmahon) [16:33:57] (CR) Hoo man: [C: 2] "Looks fine now, thanks for improving this :)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [16:35:29] (CR) Hoo man: [C: 1] "Looks fine, but I don't really want to install the extension for testing either." [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 (owner: Aude) [16:36:04] (CR) Hoo man: [C: 1] "Looks fine, but I don't really want to install the extension for testing either." [extensions/Insider] - https://gerrit.wikimedia.org/r/75877 (owner: Aude) [16:36:31] (Merged) jenkins-bot: Watchlist: Separate non-form parts out of the
[core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [16:37:14] hoo: awww :) [16:37:22] aude: Did you test those? [16:37:25] yes [16:37:40] * aude has all the deployed extensions, so it's simple as adding a local settings line [16:37:43] If no one maintains the extension I can probably merge the changes then [16:37:51] i don't think they do [16:38:04] They are deployed? [16:38:11] on wikivoyage, yes [16:38:32] e.g. https://de.wikivoyage.org/wiki/Berlin [16:39:12] another patch takes care of fix for the h3 /h5 heading [16:39:23] this takes care of the cog wheel appearing in the wrong place [16:41:17] (PS11) Release notes rebase bot: Create maintenance script to populate archive.ar_len [core] - https://gerrit.wikimedia.org/r/54111 (owner: Reedy) [16:41:22] awwww yeah [16:41:24] YuviPanda: ^ [16:41:52] i rewrote my driver thing to do this right [16:41:52] https://github.com/MatmaRex/mediawikireleasenotes-driver [16:45:28] (CR) Hoo man: [C: 2 V: 2] "Applied these changes live via the firefox debug toolbar and they seem fine." [extensions/RelatedArticles] - https://gerrit.wikimedia.org/r/75872 (owner: Aude) [16:45:50] thanks hoo [16:46:04] * aude heading out for a while.... [16:46:09] ok :) [16:47:37] (CR) Hoo man: [C: 2 V: 2] "Probably fine like the analogue changes to the RelatedArticles extension." [extensions/Insider] - https://gerrit.wikimedia.org/r/75877 (owner: Aude) [16:51:55] (CR) Huji: [C: -1] "I beg to disagree. The decision of one community (Persian Wikipedia) shall not affect the code. Wikipedia can override it by locally enabl" [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [16:53:09] (CR) Huji: [C: 1] "Disregard! I misunderstood the problem and the solution. I think it is a valid solution and support its implementation into the MediaWiki " [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [16:53:22] (CR) Matmarex: [C: 1] "> The decision of one community (Persian Wikipedia) shall not affect the code." [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [17:03:41] (PS2) Hoo man: jquery.placeholder: Take placeholder text as parameter [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:04:30] (CR) Hoo man: [C: 2] "Looks good, works and seems useful" [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:07:35] (Merged) jenkins-bot: jquery.placeholder: Take placeholder text as parameter [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:08:38] ^demon: help [17:08:56] I'm here for you, MatmaRex. [17:09:00] Elsie: fine [17:09:11] Elsie: is "file:^RELEASE-NOTES-" avalid search expression in gerrit? [17:09:29] the documentation says it is [17:09:29] gerrit disagrees [17:09:40] ah, or maybe it's not [17:09:43] Currently this operator is only available on a watched project and may not be used in the search bar. [17:09:44] wtf [17:10:20] qchris is the resident Gerrit expert. :-) [17:10:33] But it sounds like you just figured out what the issue is. [17:10:41] I wouldn't trust Gerrit to search anything. [17:11:16] (CR) Bsitu: [C: -1] More accurate function descriptions [core] - https://gerrit.wikimedia.org/r/74575 (owner: Kaldari) [17:11:46] I wonder where my bawolff is today. He *should* be online. [17:13:53] (CR) Krinkle: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:14:29] ^demon: jfyi, the gerrit "Tab Width" ui preference stopped working. [17:15:20] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:15:25] Hallo. [17:15:47] Yay, a bawolff. [17:15:56] You summoned him. [17:16:05] * bawolff is summoned [17:16:11] (CR) Hoo man: [C: -1] "Needs a rebase, fine despite" [core] - https://gerrit.wikimedia.org/r/74962 (owner: Matmarex) [17:16:28] bawolff: FYI and Fabrice's, I'm working on responding more to code review on the core patches and possibly getting 'round to working on the extension again since it's stabilizing [17:16:39] (Abandoned) Cmcmahon: fixed the scenario because anonymous user behavior changed [qa/browsertests] - https://gerrit.wikimedia.org/r/75868 (owner: Rachel99) [17:16:40] bsitu: Hi. [17:16:46] Elsie: hi [17:16:55] bsitu: Nemo_bis seems to be frustrated with Echo on Meta-Wiki. :-) [17:16:57] Is fabrice not here? [17:17:12] bawolff: Tell him to be, I guess? He may be in -ee [17:17:20] bsitu: Not sure if there's anything that can be done immediately, but perhaps you can take a look at the relevant thread when you have a minute? [17:17:25] Nope [17:17:25] Let me get a link. [17:17:28] hmm, he's not in the google hangout thing [17:17:42] bawolff: He's WFHing today, but said he'd be standing up with you [17:17:46] So...Iunno. [17:17:49] so I have access to bastion.pmtpa.wmflab . The MediaWiki installation that runs http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version is there, right? [17:17:51] marktracur: he was just done with the e2 scrum via hangout [17:18:06] MatmaRex: Yes, the file operator is a mess. [17:18:17] Elsie: yeap, I will take a look [17:18:21] bsitu: https://meta.wikimedia.org/wiki/Meta:Babel#Notifications_are_now_live_on_Meta [17:18:24] MatmaRex: Indeed it only works when watching projects (just as the documentation says) [17:18:25] Thanks. :-) [17:18:42] marktraceur: oh here he is [17:18:42] MatmaRex: Additionally, I am running into problems using it even there ... [17:18:55] qchris: i'll just filter this client-side [17:19:03] MatmaRex: Ok. [17:19:20] (CR) Hoo man: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74333 (owner: Rillke) [17:19:35] bsitu: Hrmmmm. There's less actionable there than I thought/hoped. :-/ [17:19:40] bawolff: Actually, if you could tell him to get on IRC that'd be good [17:19:44] Mostly vague comments of hate, heh. [17:19:47] God bless Meta-Wiki. [17:19:50] * marktraceur cannot communicate properly with the world [17:20:08] Try typing with your forehead. [17:20:11] Krinkle: Where in the Release notes does such a change belong? [17:20:20] other changes? [17:20:25] Elsie: I'd need to put a spike on it [17:20:31] Unicorn typing [17:20:36] Nope, just a plain forehead. [17:20:37] ;-) [17:20:51] marktraceur: Hi there. [17:20:54] Huzzah! [17:21:10] marktraceur: I'm on Google Hangouts with bawolff [17:21:22] hoo: new features? [17:21:32] (CR) Anomie: [C: -1] "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74935 (owner: Aaron Schulz) [17:21:48] hoo: just so I know, is that the reason you didn't account for it (not knowing where to put it?) cause you can always ask :) [17:22:00] (CR) Aaron Schulz: [C: 2] Followup Idfee1b4d per Tim [core] - https://gerrit.wikimedia.org/r/76103 (owner: Anomie) [17:22:05] mh, ok... although that's a really minor jquery module change rather than a software feature [17:22:12] <^demon> awight: The tab width thing is finicky. If memory serves, it conflicts with the source highlighting preference. [17:22:13] I disagree [17:22:14] fabriceflorin: I heard that, just PM'd you a note about developments in the past hour [17:22:17] This is a public API [17:22:18] <^demon> Disabling the latter makes the former work. [17:22:23] Ok [17:22:25] It is by all means a software change [17:23:10] ^demon: wow, you are correct [17:23:22] (PS1) Siebrand: WIP [extensions/Translate] - https://gerrit.wikimedia.org/r/76115 [17:24:29] (Merged) jenkins-bot: Followup Idfee1b4d per Tim [core] - https://gerrit.wikimedia.org/r/76103 (owner: Anomie) [17:24:45] (PS1) Hoo man: Style changes to jquery.placeholder [core] - https://gerrit.wikimedia.org/r/76116 [17:25:42] (CR) Anomie: "(2 comments)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74936 (owner: Aaron Schulz) [17:25:44] Krinkle: https://gerrit.wikimedia.org/r/76116 should be a fast merge [17:27:33] (CR) MarkTraceur: "1. I don't think it's true that there are problems with addModules and addModuleStyles - I think addModules is acceptable here because I r" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [17:28:30] (CR) Anomie: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/75274 (owner: Aaron Schulz) [17:30:25] (CR) Krinkle: [C: -1] "(3 comments)" [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [17:34:00] hmmmm. [17:34:02] (PS2) Aaron Schulz: Added CLI guards around test scripts [extensions/OAuth] - https://gerrit.wikimedia.org/r/74936 [17:34:24] how do i find changesets that don't merge cleanly, but jenkins hasn't complained because they merged when they were submitted? [17:34:46] (CR) Aaron Schulz: "This whole thing should be a maintenance script though...but that's for later" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74936 (owner: Aaron Schulz) [17:35:11] (PS2) Hoo man: Style changes to jquery.placeholder [core] - https://gerrit.wikimedia.org/r/76116 [17:35:22] (CR) Hoo man: "(3 comments)" [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [17:35:49] (CR) Hoo man: "Addressed Krinkle's comments now (it would have been faster for you to fix those things yourself)" [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [17:36:44] (PS2) Siebrand: Add "notify translators" link when marking page for translation [extensions/Translate] - https://gerrit.wikimedia.org/r/76115 [17:39:26] hoo: I am aware, but I didn't merge it. [17:40:24] MatmaRex: nice. How're you doing this? is it manually triggered? [17:40:37] I could also revert it, and re-submit the original with a -1 saying ''I don't have time but it is unacceptable'' and have it wait a month when I get to it. I wouldn't do that, instead I did it this way. [17:42:13] chrismcmahon: I have access to bastion.pmtpa.wmflab . The MediaWiki installation that runs http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version is there, right? [17:42:33] Krinkle: I meant hte nit picks on the follow up... but it would be nice if you could merge this now... [17:48:01] (CR) Anomie: [C: 2] Added $wgMWOAuthSecureTokenTransfer to redirect users to HTTPS in some cases [extensions/OAuth] - https://gerrit.wikimedia.org/r/75490 (owner: Aaron Schulz) [17:49:57] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [17:50:01] (CR) Krinkle: [C: -1] Style changes to jquery.placeholder [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [17:50:07] hoo: It didn't fix it [17:50:31] use undefined as check or arguments.length, eg. like jQuery does for .attr(), text(), .css() etc. [17:50:44] when you pass .attr('foo', ..) it always sets foo, no matter what you set it [17:50:50] (CR) MarkTraceur: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [17:51:06] (CR) Manybubbles: "I'm confused about this change but probably because I'm confused about git submodules. Shouldn't this modify the .gitmodule file? Right " [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/76029 (owner: Reedy) [17:51:07] hoo: this also causes an extra problem the previous patch set didn't have, it makes it impossible to empty the placeholder. [17:51:19] (e.g. passing '' or undefined) [17:51:25] didn't test this one [17:51:41] aharoni: you might like https://wikitech.wikimedia.org/wiki/Beta [17:51:45] I agree, we should've had unit tests for this. [17:51:51] (PS12) MarkTraceur: Implement agora-style checkboxes experimentally [core] - https://gerrit.wikimedia.org/r/74662 [17:52:51] Krinkle: if ( typeof text !== 'undefined' ) { are you fine with that? [17:53:31] It's an improvement, but we might as well just make it what it should be (like jQuery uses as of jQuery 1.7, we use 1.8) [17:53:39] which involves arguments.length [17:53:46] since undefined can be passed as well. [17:54:15] which would be a bug in the users code by all means, but it should surface as 'undefined' showing up, not as the old placeholder showing up [17:54:22] mh, k [17:54:44] arguments.length ... do you want me check explicit for === 1 or is an implicit == true check enough? [17:54:59] implicit would be good enough [17:56:06] explicit would be better in some way, but that breaks compatibility and expectations with other modules. arguments.length and allowing unused parameters to be passed is what other plugins do. [17:56:52] (PS3) Siebrand: Add "notify translators" link when marking page for translation [extensions/Translate] - https://gerrit.wikimedia.org/r/76115 [17:59:11] (CR) Anomie: [C: 2] "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/75481 (owner: Aaron Schulz) [17:59:21] (PS1) Siebrand: Accept article ID as default setting for translatable page [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/76117 [17:59:44] (PS3) Hoo man: Style changes to jquery.placeholder [core] - https://gerrit.wikimedia.org/r/76116 [18:00:46] (PS3) Aaron Schulz: Made $wgMWOAuthCentralWiki default to the current wiki [extensions/OAuth] - https://gerrit.wikimedia.org/r/75481 [18:01:05] (CR) Brion VIBBER: "(1 comment)" [apps/android/commons] (campaigns) - https://gerrit.wikimedia.org/r/75998 (owner: Yuvipanda) [18:03:41] (CR) Brion VIBBER: [ C: 2 V: 2] "doesn't appear to explode \o/" [apps/android/commons] (campaigns) - https://gerrit.wikimedia.org/r/75998 (owner: Yuvipanda) [18:03:43] brion: don't think we should clone. we're just going to use it internally, not worth the extra garbage [18:04:06] YuviPanda: yep, no biggie. just code hygiene :) [18:04:11] brion: yeah. [18:04:26] brion: once you merge the 'controller' patch, I want to cherry pick that to master to [18:04:50] (PS1) MarkTraceur: Add .sass-cache to .gitignore [core] - https://gerrit.wikimedia.org/r/76118 [18:09:10] (PS2) Siebrand: Accept article ID as default setting for translatable page [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/76117 [18:09:37] (PS4) Krinkle: Style changes to jquery.placeholder [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [18:09:42] (CR) Krinkle: [ C: 2] jquery.placeholder: Fixup for a8145d6fa2 [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [18:09:56] thanks :) [18:10:04] (CR) Brion VIBBER: [ C: 2 V: 2] "Just a note -- I don't like the separate launcher here, in part because it doesn't actually work if the app is already open, but mostly be" [apps/android/commons] (campaigns) - https://gerrit.wikimedia.org/r/75999 (owner: Yuvipanda) [18:11:09] hoo: no pressure, but if you're interested in writing unit tests for this module, that's be awesome (now, next week/month, whenever). I'll add it to my todo list as well [18:11:52] Krinkle: I doubt I'll find to for that... maybe prior to the Wikimania, but after it I'm going to be 100% occupied, I guess [18:12:43] ^demon: you mentioned you were working on getting elasticsearch deployed in beta a couple days ago. is there anything I can/should do to help with that? [18:13:08] hoo: Oh? What're you up to? Vacation, work, study? [18:13:41] Krinkle: Combination... going to work on accessibility within MW then, watch out ;) [18:13:53] (Merged) jenkins-bot: jquery.placeholder: Fixup for a8145d6fa2 [core] - https://gerrit.wikimedia.org/r/76116 (owner: Hoo man) [18:14:29] alrighty, sounds exciting! Have fun. We'll meet at Wikimania before that though I presume. [18:15:29] Yes :) [18:15:43] (PS2) Aaron Schulz: Use MWOAuthUtils::grantName() to fix broken messages [extensions/OAuth] - https://gerrit.wikimedia.org/r/74935 [18:16:11] <^demon> manybubbles: Yeah, I setup the labs instances but then I got sick :( [18:16:54] ^demon: damn sickness! I was just wondering if there was anything I can do to help. Otherwise I might have to go back to writing more integration tests. [18:17:12] <^demon> Was the puppet stuff ready to apply to the es[0-3] instances? [18:17:20] already applied [18:17:25] (CR) Aaron Schulz: [ C: 2 V: 2] "Only change was summary typo" [extensions/OAuth] - https://gerrit.wikimedia.org/r/75481 (owner: Aaron Schulz) [18:17:32] rather, to our ones in labs [18:17:50] in the "solr" project [18:18:04] <^demon> Gotcha [18:18:06] is there something I can do to get it to apply to the ones you set up in beta? [18:18:52] huh, google notifications use "their" in place of he/she [18:19:11] to bad there isn't a proper english word for that [18:19:14] *too [18:19:35] (CR) Brion VIBBER: [ C: 2 V: 2] Split up contributions related code into separate classes [apps/android/commons] (campaigns) - https://gerrit.wikimedia.org/r/76000 (owner: Yuvipanda) [18:20:39] AaronShulz: I've always used their/your for that. Technically the gender neutral pronoun in english is "he" but that is pretty silly. [18:20:49] AaronSchulz: that is the english word [18:21:02] "your" is fine [18:21:02] "their" is technically wrong [18:21:14] hrm [18:21:35] I'm thinking of "they" ;) [18:22:01] http://www.merriam-webster.com/dictionary/they [18:22:03] https://en.wikipedia.org/wiki/Singular_they#Acceptability [18:22:19] usage determines wat's gender neutral [18:22:25] and "he" has flucked that test soundly [18:22:28] (CR) Anomie: "(12 comments)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/75773 (owner: Aaron Schulz) [18:22:29] *flunked [18:22:34] I agree that "he or she" gets really annoying [18:22:41] * AaronSchulz would like a new short word [18:22:54] * apergos looks at the topic... well if it gets too off someone can tell us to go somewhere else with it [18:22:59] if one is annoyed by 'he or she', one should use different phrasing [18:23:27] paraphrasing has its limits [18:23:45] many new short words have come (and not lasted)... so 'they' it is [18:24:36] <^demon> apergos: Speaking of, I had an abbreviation problem yesterday. Was expecting a package, and the sender had abbreviated my street as Msn. [18:24:45] <^demon> Which UPS thought meant "Mason" and not "Mission." [18:25:03] woooops [18:25:11] apergos: I'd love to see all the failed words for that [18:25:44] http://en.wikipedia.org/wiki/Gender-specific_and_gender-neutral_pronouns#Invented_pronouns [18:25:54] you knew I would link you right? [18:26:35] "While this usage is accepted in casual contexts, it is still considered ungrammatical in formal writing" [18:26:54] apergos: I should ask tim about this, he always has interesting opinions on this stuff [18:27:48] CITATIONNEEDED [18:28:04] I'll say it is [18:28:14] I remember talking about how daemon is pronounced for a good while [18:28:28] (CR) Anomie: [ C: 2] A few UI cleanups [extensions/OAuth] - https://gerrit.wikimedia.org/r/75994 (owner: Aaron Schulz) [18:28:50] none of the proposed (invented) pronouns ever really worked for me [18:30:24] ^demon: That's better than OnTrac shipping. "Where's my package? Signature required!" "Sir, says here 'FDS' signed for your package, talk to _them_". FDS are the initials of... Front DoorStep. [18:30:29] * AaronSchulz wanders to lunch [18:32:52] (PS2) Manybubbles: Reindex pages on template changes. [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/75151 [18:37:43] YuviPanda: yeah, manual right now [18:37:58] how do i find changesets that don't merge cleanly, but jenkins hasn't complained because they merged when they were submitted? [18:38:04] MatmaRex: hmm, I just split gerrit-to-redis out. Should be simple to integrate [18:38:09] MatmaRex: yeah, that was in my mind too [18:38:11] things that need rebasing [18:38:17] YuviPanda: it's using the rest api [18:38:35] https://gerrit.wikimedia.org/r/changes/?q=status:open+label:v%3C=-1+project:mediawiki/core&n=5000&o=CURRENT_REVISION&o=CURRENT_FILES [18:38:37] MatmaRex: true, but I'm talking about having it *find* changesets that need rebasing and then autorebasing them [18:38:51] hmm [18:38:57] i could probably just get allof the changes [18:38:58] well, with stream events it will be done instantly [18:39:05] and see which ones aren't "mergeable" [18:39:13] how do you test for that? [18:39:20] it syas it in the JSON :) [18:39:22] says* [18:39:32] (PS1) Siebrand: Update formatting [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/76121 [18:39:46] (although i think it also considers changesets with unmerged dependencies unmergealbe, but oh well( [18:39:50] )) [18:40:31] (PS13) MarkTraceur: Implement agora-style checkboxes experimentally [core] - https://gerrit.wikimedia.org/r/74662 [18:40:47] YuviPanda: and the actual code is like 30 lines [18:41:02] oh? [18:41:12] that's nice [18:41:23] http://pastebin.com/mvEyjnqm [18:41:52] heh, pastebin doesn't highlight it well [18:42:52] mmm ruby! [18:43:05] MatmaRex: the API also has a method that is the equivalent of hitting 'rebase' [18:43:16] on the interface [18:43:33] (PS1) Anomie: Add i18n messages for rights [extensions/OAuth] - https://gerrit.wikimedia.org/r/76122 [18:44:59] (CR) Anomie: [ V: 2] "Oh, yeah. No Jenkins here yet." [extensions/OAuth] - https://gerrit.wikimedia.org/r/75490 (owner: Aaron Schulz) [18:45:07] (CR) Anomie: [ V: 2] "Oh, yeah. No Jenkins here yet." [extensions/OAuth] - https://gerrit.wikimedia.org/r/75994 (owner: Aaron Schulz) [18:46:37] (PS8) Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/74850 [18:48:15] (PS2) Siebrand: Update formatting [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/76121 [18:48:37] YuviPanda: yeah, but how is that supposed to help when it doesn't rebase cleanly? [18:48:55] in that case manual intervention is required, no? [18:49:04] can't really autorebase, can it? [18:49:05] YuviPanda: i wrote a custom rebase driver which makes it rebase cleanly [18:49:12] https://github.com/MatmaRex/mediawikireleasenotes-driver [18:49:16] for everything? [18:49:22] for release notes [18:49:37] that's the most common and most annoying merge conflict [18:49:55] ah, right [18:49:59] * YuviPanda wouldn't know, thankfully [18:51:30] hey, grrrit-wm on #-visualeditor has colors! [18:51:34] why not here? [18:51:50] colours are evil! [18:52:17] (CR) Matmarex: "Duh." [core] - https://gerrit.wikimedia.org/r/74962 (owner: Matmarex) [18:52:20] (PS2) Matmarex: jquery.makeCollapsible: Consistency in test names [core] - https://gerrit.wikimedia.org/r/74962 [18:52:30] (PS2) Matmarex: jquery.makeCollapsible: Some low-level tests [core] - https://gerrit.wikimedia.org/r/74965 [18:52:44] MatmaRex: it has colors everywhere [18:52:51] (CR) Anomie: [ C: 2 V: 2] "Maintenance script, or unit test?" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74936 (owner: Aaron Schulz) [18:52:58] MatmaRex: legoktm explained to me that some channels have +c set, so no colors [18:53:52] just need to find an op to remove it [18:54:49] ree [18:54:53] crap, reedy's not here. [18:55:36] (PS2) Bsitu: Split the code to generate a proper URL/link from setTitleLink() [extensions/Echo] - https://gerrit.wikimedia.org/r/74617 (owner: Matthias Mullie) [18:55:45] what has the world come to!? [18:55:46] ^demon: ^ [18:56:55] <^demon> MatmaRex: Your ping has been acknowledged and will be responded to in the order in which it was received. You are currently [NUMBER 348] in line [18:57:35] (CR) Anomie: [ C: 2 V: 2] Use MWOAuthUtils::grantName() to fix broken messages [extensions/OAuth] - https://gerrit.wikimedia.org/r/74935 (owner: Aaron Schulz) [18:57:44] * YuviPanda presses 0 for ^demon's operator [18:57:55] it must have taken you longer to type that out than it would to make this channel -c. :D [18:58:05] <^demon> YuviPanda: Sorry, [0] is not a valid entry. [18:58:30] <^demon> MatmaRex: I don't know anything about colors. I don't use colors on IRC, didn't even know the bot had them. [18:58:39] it didn't until like an hour or so ago [18:58:43] ^demon: you're an op here? [18:58:43] <^demon> (And despite having access, I know zilch about the new bot, that was the intent ;-)) [18:58:47] <^demon> Nope :D [18:58:49] D: [18:58:52] who is? [18:58:57] <^demon> Ask chanserv? [18:59:12] i left my chanserv cheatsheet in the other pair of pants [19:01:13] ^demon: btw, the new bot has docs https://wikitech.wikimedia.org/wiki/Grrrit-wm and has *plenty* of maintainers [19:01:21] you don't have know anything for the forseeable future, I think [19:01:31] <^demon> That was the whole plan ;-) [19:01:40] <^demon> I hated maintaining an IRC bot! [19:02:10] RoanKattouw_away or Ryan_Lane? [19:03:20] legoktm: ? [19:03:39] Ryan_Lane: can you set mode -c on this channel so we can see grrrit-wm's colors? [19:04:24] command for that? [19:05:01] nevermind. there you go [19:05:26] * Ryan_Lane can't see colors from bots anyway [19:05:32] Ryan_Lane: heh [19:05:46] my client doesn't support it [19:06:22] Ryan_Lane: Purple IRC? [19:06:30] google says: "PurpleIRC is an IRC to Minecraft bridge plugin" [19:06:39] Ryan_Lane: thanks! [19:06:41] YuviPanda: ^^ [19:06:47] * AzaToth is clueless [19:06:55] (03CR) 10Hoo man: [ C: 122] "As noted earlier, still an improvement :)" [core] - 10https://gerrit.wikimedia.org/r/74962 (owner: 07Matmarex) [19:07:00] ooo [19:07:00] AzaToth: it's a plugin for adium, a chat client on OS X [19:07:01] oO [19:07:08] do you see colors? [19:07:10] * bawolff is blinded by the colourfulness :P [19:07:13] sexy time colors [19:07:30] YuviPanda: need to fix the spaces [19:07:38] AzaToth: yeah, will do when I'm out of meetings [19:07:41] k [19:08:09] you - those are colors. They kind of blend in with all the other colors you guys have tnough. [19:08:15] *though* [19:08:21] need to work on particular colors [19:08:23] but yay, colors! [19:08:28] manybubbles: there aint many usable colors to choose from [19:08:44] manybubbles: yellow and lime aint a good combo [19:08:44] [C: -2] [19:08:50] [19:08:53] ツ [19:09:05] AzaToth: now if you could get the owner's color to line up with the color that weechat picks for that person, that'd be kind of nice. [19:10:16] manybubbles: there are like 16 colors to choose from [19:10:59] 04T07h08i03s 12i02s 06r04a07i08n03b12o02w 06c04o07l08o03r12i02n06g [19:11:05] ow my eeyyyeesss [19:11:50] > console.log(require('irc-colors').rainbow(" ow my eeyyyeesss")) [19:11:50] 04<07a08p03e12r02g06o04s07> 08o03w 12m02y 06e04e07y08y03y12e02e06s04s07s [19:12:00] * MatmaRex slaps AzaToth around a bit with a large trout [19:12:07] ツ [19:12:38] manybubbles, YuviPanda: https://github.com/fent/irc-colors.js#colors [19:13:10] > console.log(require('irc-colors').bold.rainbow(" ow my eeyyyeesss")) [19:13:10] 0407<08a03p12e02r06g04o07s08> 03o12w 02m06y 04e07e08y03y12y02e06e04s07s08s03 [19:13:48] AzaToth: looks like you can reverse them too [19:14:36] > console.log(require('irc-colors').bold.rainbow(" will this work?")) [19:14:42] > console.log(require('irc-colors').bold.rainbow(" will this work?")) [19:14:48] what? :) [19:14:49] 0407008103,1210230604<07a08p03e12r02g06o04s07> 08o03w 12m02y 06e04e07y08y03y12e02e06s04s07s0803 [19:14:57] subbu: No ecmabot-wm in this channel :) [19:15:03] > console.log(require('irc-colors').bold.bgpink.rainbow(" ow my eeyyyeesss")) [19:15:03] 0407008103,1210230604<07a08p03e12r02g06o04s07> 08o03w 12m02y 06e04e07y08y03y12e02e06s04s07s0803 [19:15:05] gah [19:15:07] ah. [19:15:14] Also I think it's >>> or something [19:15:39] subbu: I would assume ecmabot-wm hasn't that package installed [19:15:55] <^demon> I'm so glad I leave colors disabled. [19:15:58] <^demon> Colors on IRC annoy me [19:16:06] 0407008103,1200210604e07y08e0312 [19:16:31] 04,0107e08y03e12 [19:16:42] ^demon: are you one of those people that turns off colors in ls too? [19:16:42] AzaToth: …is there a reason you're doing that? [19:16:55] rainbow...what a...not terribly useful feature [19:16:57] don't need no steenkin colors in ls [19:17:02] MatmaRex: sorry [19:17:23] <^demon> manybubbles: No, I have lots of colors in my terminal, makes me productive. [19:17:41] (03PS10) 10MarkTraceur: Add a 'feature' field type to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/75143 [19:17:51] <^demon> AaronSchulz knows how colorful my terminal is. [19:17:57] I feel like there was a reason this channel had +c [19:18:01] ^demon: colors on IRC depends [19:18:04] colors in editors makes sense to me, ls colors don't so much [19:18:57] <^demon> marktraceur: This channel exists because people didn't like the bots in #mediawiki ;-) [19:18:59] apergos: colors in ls gives clues what you are looking at [19:19:31] if I need details that's what -l is for [19:19:44] apergos: details != clues [19:19:48] <^demon> More typing [19:19:54] ^demon: No, this channel existed before we moved the bots here [19:20:12] It's for discussion of Wikimedia-specific development as opposed to general MediaWiki development and use [19:20:17] <^demon> marktraceur: I mean that people didn't like the bots in #mediawiki, so they created this channel to get away. [19:20:23] <^demon> Now the bots have mostly moved here too ;-) [19:20:23] Ah. [19:20:30] Hilaaaarious. [19:20:45] instead we have ben chatting about color use in irc, neutral gender prnouns and etc etc :-) [19:21:33] (03PS7) 10Hoo man: Make APIEditBeforeSave give the whole revision [core] - 10https://gerrit.wikimedia.org/r/76082 [19:21:50] I don't see any problem having bots mark with colors, as it for most people give clues what it is without having to read it all fully [19:22:03] (03CR) 10Hoo man: "Rebased again" [core] - 10https://gerrit.wikimedia.org/r/76082 (owner: 07Hoo man) [19:22:21] ughhh. but neon orange? [19:22:26] AzaToth: whyyyy. [19:22:28] now I see directly without having to think too much that "Hoo man" isn't part of the commit message [19:22:37] MatmaRex: neon orange? [19:22:48] in the "(owner: Hoo man)" part? [19:23:07] MatmaRex: it's bold olive [19:23:21] lol, bold olive [19:23:28] bawolff: it IS [19:23:30] who came up with the choices of colours [19:23:35] heh [19:23:38] bawolff: AzaToth did, i think [19:23:39] :D [19:23:40] http://i.imgur.com/xHxLxwN.png [19:23:44] (owner: {{ owner |color('bold.olive')}}) [19:23:46] this ain't no bold olive [19:23:53] yep, same here [19:23:54] I mean for irc colour spec [19:24:01] bawolff: ah [19:24:06] is it just the original 16 vga colours or whatever? [19:24:08] bawolff: there aint any real spec [19:24:41] bawolff: it's basically the mIRC interpretation in combnination with *NIX interpretation [19:24:42] oh, wait, my client does support colors, they were just turned off [19:24:50] heh [19:25:32] <^demon> Ryan_Lane: Mine does too, but I leave them off :p [19:25:54] (03CR) 10Matmarex: [ C: 04-1] "(1 comment)" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76090 (owner: 07Jack Phoenix) [19:26:06] wow. that's terrible [19:26:10] those colors hurt [19:26:13] whoaaa, red? [19:26:14] Ooh, I like the red -1 [19:26:33] the blue-green text on a white background is incredibly hard to read [19:26:35] MatmaRex: http://i.imgur.com/4MvZWqe.png?1 [19:26:40] that's not orange on mine. http://i.imgur.com/foQQoAU.png [19:26:52] MatmaRex: negative values are bold red, positive values are blue [19:27:11] -1 was blue/green for me [19:27:21] lol, it's red [19:27:24] Ryan_Lane: impossibru [19:27:25] https://en.wikipedia.org/wiki/Gender-neutral_pronoun#Invented_pronouns [19:27:36] "humself"...haha [19:27:36] AzaToth: i think you should stick to the green on CR and MatmaRex [19:27:54] AzaToth: that's what wikibugs uses (right?) and i haven't seen anybody complain about it ever [19:28:03] Ryan_Lane: https://git.wikimedia.org/blob/labs%2Ftools%2Fgrrrit/576731238de03b60d7de6fc473fe649840b574a8/src%2Ftemplate.txt [19:28:29] MatmaRex: well, I made the colors for wikibugs as well back in the days... [19:28:38] AzaToth: that just redirects me to git.wikimedia.org [19:28:43] :) [19:28:57] Ryan_Lane: https://git.wikimedia.org/raw/labs%2Ftools%2Fgrrrit/576731238de03b60d7de6fc473fe649840b574a8/src%2Ftemplate.txt [19:29:11] Ryan_Lane: that link works. fix your browser [19:29:29] that link also doesn't work for me :) [19:29:30] Ryan_Lane: decoding the %2F to / will break thelink [19:29:34] MatmaRex: he's prolly using a OS X browser plugin [19:30:05] that link is unclickable for me in XChat, but if i copy and paste to browser it works fine [19:30:17] Ryan_Lane: if whatever it is you're using does that, then whoever coded it is incompetent. <3 [19:30:25] probably [19:30:34] quiddity_: I'm using xchat, and it works for me [19:30:35] adium for irc is not exactly great [19:31:10] Ryan_Lane: I'm using Xchat and I've felt it works optimally most of times [19:31:36] I'm not someone who likes to sit in a shell poking with irssi [19:31:39] I used to use xchat [19:31:45] I hate every irc client I've ever used [19:32:13] in what way? [19:32:33] they all have something I hate about them [19:32:41] nothing specific? [19:32:51] i used mIrc in '96/'97, and then ZMud. It's been downhill ever since. >.> [19:32:58] I don't remember exactly what I hated about xchat [19:33:25] the only thing I truly hate about adium is that it doesn't show topics in the interface and I have to type /topic [19:33:30] what I like with xchat is that you can write plugins in both perl and python etc... [19:33:43] oh, and it does auto-correct bullshit [19:34:04] so you can't type teh? [19:34:35] is it also one of the clients who pushed smileys up yer arse? [19:35:59] (03CR) 10Aaron Schulz: [ C: 122 V: 122] Add i18n messages for rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76122 (owner: 07Anomie) [19:36:41] AzaToth: no, I mean it turns -- into —, for instance [19:36:53] it doesn't force smileys [19:37:06] but little annoying changes where it thinks it's being helpful, but it isn't [19:37:31] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75274 (owner: 07Aaron Schulz) [19:37:46] oh great. I turned the colors off and they are still showing up [19:37:46] heh [19:38:16] Ryan_Lane: :'( [19:38:18] Ryan_Lane: http://paste.debian.net/18827/ [19:38:27] that's the code I tried to link you to [19:38:40] that's the template [19:38:40] ah [19:41:55] \o/ [19:42:11] wow. it seems that I can disable the substitutions! [19:45:37] (03PS1) 10Ryan Lane: Don't mask token on input [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/76124 [19:46:20] Ryan_Lane: I like seeing OAuth/OAUTHAuth commits interspersed [19:46:35] AaronSchulz: what do you mean? [19:46:41] rather than giant changes? :) [19:46:46] oh [19:46:49] I see what you mean [19:46:50] now I mean watching gerrit-wm [19:46:55] it's kind of funny [19:47:02] :D [19:47:02] indeed [19:47:27] I'd rename the extension two factor auth, but someone already forked me and made an incompatible license [19:47:40] maybe I should name it "Better two factor authentication" [19:49:29] <^demon> That's not how we name extensions [19:49:35] <^demon> BetterTwoFactorAuthentication [19:49:42] :D [19:50:07] BetterTwoFactorAuthenticationDontUseThatOtherCrappierOne [19:50:19] (03PS6) 10Rahul21: Pronunciation Recording Tool ( Not Working ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 07Mdale) [20:06:17] (03CR) 10Aaron Schulz: [ C: 04-1] "(4 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 (owner: 07Anomie) [20:11:31] (03PS7) 10Rahul21: Pronunciation Recording Tool ( Not Working ) [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/74413 (owner: 07Mdale) [20:13:06] (03CR) 10MarkTraceur: [ C: 04-1] "There are some problems when the fields aren't all there, I'll be working on this in tandem with a patch to Extension:BetaFeatures that st" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 07MarkTraceur) [20:15:04] (03PS1) 10Yuvipanda: Inherit About and Welcome screen from SherlockActivity [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (via SuchABot) [20:15:14] brion: ^ can you merge? [20:15:21] trivial [20:15:50] YuviPanda: i thought you were going to remove actionbarsherlock? [20:15:57] does the inherit fix a current problem? [20:16:15] brion: yeah, it makes the about screen look consistent in both versions [20:16:36] ah spiff [20:16:43] current one doesn't show actionbar [20:16:45] on 2.3 [20:16:50] (shouldn't, at least) - just shows a title [20:17:00] there are no actions there, but there is the title being displayed [20:17:03] * brion scrounges around for nexus 1 [20:19:45] YuviPanda, Ryan_Lane (or whoever) - what's the "LocalSettings" for http://en.wikipedia.beta.wmflabs.org/ ? [20:19:58] aharoni: moment [20:20:30] YuviPanda: wtf is SuchABot? [20:20:43] It's _such_ a bot. [20:20:44] aharoni: see https://wikitech.wikimedia.org/wiki/Beta [20:20:56] marktraceur: orly [20:21:26] I actually don't know what SuchA is supposed to mean [20:21:36] YuviPanda's naming scheme makes very little sense to me [20:21:46] Such A Bot, yes. [20:21:53] that's what it *really* is [20:21:55] suck a bot? [20:22:07] aharoni: see also the 'mediawiki' section of https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/Help [20:22:27] I'm no bender, but that sounds nasty [20:22:45] heh [20:22:49] no, really, it is just such a bot [20:23:07] hmm [20:23:11] it is such a bot that it pulls github pull requests into gerrit patchsets and keeps them in sync [20:23:38] YuviPanda: The first few times I saw it I mis-parsed the name and wondered why sucheta had a bot [20:23:38] YuviPanda: so on JB we currently don't have an action bar on the welcome screen, but this patch adds it on GB [20:25:12] aharoni: settings files for beta labs are controlled from https://gerrit.wikimedia.org/r/#/admin/projects/operations/mediawiki-config [20:25:51] marktraceur: haha [20:25:51] brion: ow, that's bad. [20:25:51] brion: does gb have an actionbar in GB without the patch? [20:26:06] welcome screen? [20:26:10] or…. ? [20:26:14] me confused now :D [20:26:28] brion: about screen [20:29:20] What about YB? [20:29:58] or the notorious KB [20:34:28] (03PS7) 10Anomie: Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 [20:34:42] (03CR) 10Anomie: "PS7: Rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 (owner: 07Anomie) [20:36:13] (03CR) 10Krinkle: [ C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/75511 (owner: 07Helder.wiki) [20:37:47] (03CR) 10Anomie: "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 (owner: 07Anomie) [20:38:36] (03PS8) 10Anomie: Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 [20:45:07] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 (owner: 07Anomie) [20:45:29] (03CR) 10Aaron Schulz: [ C: 121] Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73977 (owner: 07Anomie) [20:51:39] (03CR) 10Helder.wiki: "Since it is still being considered imposing the CAPTCHA on all edits for ptwiki (change 69982 / bug 49860), I think we need to have at lea" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/40553 (owner: 07Helder.wiki) [20:59:14] (03CR) 10Brion VIBBER: [ C: 04-1] "Note: this fixes missing action bar on about screen on Gingerbread, but also adds one on the welcome screen that isn't there on Jelly Bean" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (owner: 07SuchABot) [21:08:22] chrismcmahon: i'm checking that ellipsis bug [21:08:41] aharoni: browser tests ftw! [21:10:47] i [21:10:49] Hi [21:11:11] So, I'm trying to figure out how I can ensure that return value of parser extensions is gonna be interpreted as a block level element [21:11:31] so for instance if it is in the middle of the line of the text - that line of the text will get splited into two paragraphs [21:11:56] for instance

Lorem

Ipsum

, instead of

Lorem

Ipsum

[21:12:06] where
is the output of my parser extension [21:12:15] brion: ^ [21:13:08] (03PS11) 10MarkTraceur: Add a 'feature' field type to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/75143 [21:13:44] heh [21:13:52] InezK: that's a good question, not sure how to solve best :) [21:15:09] I have a black and white terminal. [21:15:31] Though mostly as a result of defaults. [21:16:42] InezK: do you handle splitting up

in regular text as well? [21:21:17] (03PS1) 10MarkTraceur: WIP Use the new feature field in core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [21:24:19] (03PS3) 10Helder.wiki: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 [21:33:52] (03PS3) 10Siebrand: Add explicit GENDER for log entries [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73713 [21:33:59] chrismcmahon: i can reproduce it, and I may be able to even fix it soon, but i'm wondering: aren't these tests triggered by the commit? [21:34:12] brion: actually current Parser output for this wikitext is very surprising [21:34:15] (03CR) 10Siebrand: "PS3 is a manual rebase, including solving merge conflicts." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/73713 (owner: 07Siebrand) [21:37:02] brion:

1

2

this would split in wikitext into what I want [21:37:19]

1

2

[21:37:28] last but is surprising but still does what I need [21:37:53] (03CR) 10MZMcBride: "This needs to be rebased." [core] - 10https://gerrit.wikimedia.org/r/64615 (owner: 07Matmarex) [21:37:54] aharoni: they are not triggered by commit, but in the case of ULS that might make sense [21:38:06] i wonder if tidy is doing that or if we actually put in the logic :) [21:38:14] chrismcmahon: why ULS? :) [21:38:20] i suspect we originally assumed tag extensions were going to be inline [21:38:31] so this '12' vs '

12

' is different [21:38:48] aharoni: because only a few commits per day for ULS. some repos have much more frequent commits [21:39:09] aharoni: I should say merges though not commits [21:40:08] chrismcmahon: it would actually be great for commits. gated trunk and all that. [21:41:45] aharoni: I'll make a bug for that, it's something we've talked about before but not had a good use case, this is a good use case [21:43:13] (03PS1) 10Alex Monk: Add thanks log to $wgFilterLogTypes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/76200 [21:43:55] ^demon: Yo. Any progress on reviewer counts for Gerrit? [21:44:07] <^demon> I got really sick yesterday :( [21:44:10] Gerrit notification bot makes a separate request to set status=PATCH_TO_REVIEW? [21:44:11] <^demon> Sorry [21:44:16] ^demon: Would it help to have a bug about it? Or is there anything else I can do to help move it forward? [21:44:24] ^demon: No need to apologize for being sick. :-) [21:44:32] Maybe next week. [21:44:47] <^demon> I'm trying to wrap up the pywikibot migration today. [21:44:50] <^demon> Next week 4sure [21:45:00] Great, thanks. :-) [21:49:56] (03PS2) 10Yuvipanda: Inherit About and Welcome screen from SherlockActivity [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (via SuchABot) [21:50:00] brion: ^ [21:50:07] brion: (IMO) hacky fix but should work [21:50:45] whee [21:50:58] (03CR) 10Siebrand: [ C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 07MarkTraceur) [21:53:04] (03CR) 10Brion VIBBER: "(1 comment)" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (owner: 07SuchABot) [21:53:18] (03CR) 10MarkTraceur: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 07MarkTraceur) [21:53:28] YuviPanda: you left in an import :) [21:53:45] brion: in where? [21:53:52] YuviPanda: see inline comment [21:53:55] ah right [21:54:15] (03PS1) 10Umherirrender: Fix EditPageTest for non-english test wikis [core] - 10https://gerrit.wikimedia.org/r/76202 [21:54:21] brion: pushing [21:54:37] (03PS3) 10Yuvipanda: Inherit About and Welcome screen from SherlockActivity [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (via SuchABot) [21:54:48] brion: ^ [21:56:34] (03PS1) 10Amire80: Revert "Load jquery.ime only when user focus on editable fields" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76204 [21:58:04] (03CR) 10Brion VIBBER: [ C: 122 V: 122] "\o/ whee" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76128 (owner: 07SuchABot) [21:58:09] brion: ty! [21:58:33] :D [21:58:54] (03PS10) 10Dan-nl: initial draft [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 [22:01:16] (03CR) 10Dan-nl: "(66 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/59405 (owner: 07Dan-nl) [22:02:39] chrismcmahon: can you please +2 https://gerrit.wikimedia.org/r/#/c/76204/ ? [22:02:47] it's a revert of the patch that broke it. [22:02:54] it's too late for me to do a proper fix now. [22:04:28] aharoni: I'm a little nervous about +2 for code I've never seen before, but OK :-) [22:05:10] chrismcmahon: the rest of my team is asleep or offline for other reasons, and that's just a revert [22:05:36] (03CR) 10Cmcmahon: [ C: 122] "merged at Amir's request to resolve Bug 52115" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76204 (owner: 07Amire80) [22:05:42] <^demon> YuviPanda: nodejs + go + mongodb? I think I just threw up in my mouth ;-) [22:05:46] (03Merged) 10jenkins-bot: Revert "Load jquery.ime only when user focus on editable fields" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76204 (owner: 07Amire80) [22:05:47] YuviPanda: go? [22:06:18] ^demon: I missed mentioning moving our SCM to daarcs, and moving from JS to coco/clojurescript [22:06:29] aharoni: Go is a programming language that is getting popular of late. [22:06:45] i know, a google thingy, but is there a reason for it to be useful for us? [22:07:07] aharoni: well, for the same reason mongodb would be useful for building mediawiki 3.0.... [22:07:08] :D [22:07:11] <^demon> YuviPanda: Luckily we're not big on doing the popular thing around here :) [22:07:22] ^demon: awww, no angularjs in mediawiki? saaaadd [22:07:35] how will we ever raise VC funding? [22:07:37] aharoni: <^demon> YuviPanda: nodejs + go + mongodb? I think I just threw up in my mouth ;-) [22:07:42] was the intended effect :) [22:07:47] hi YuviPanda & aharoni how's it going? [22:07:51] perl 6, I'm telling you, that's the real thing. [22:07:58] Heh. [22:08:06] aharoni: MSSQL + C# 5.0, you mean [22:08:08] hey sumanah [22:08:32] sumanah: pretty good! productive week, I think :) [22:08:33] (03PS1) 10Adamw: Example fix for implicitly declared globals [core] - 10https://gerrit.wikimedia.org/r/76208 [22:08:36] <^demon> aharoni: I hear that PHP6 is gonna be sweet, have full unicode support. [22:08:40] sumanah: and grrrit-wm now has colors! [22:08:44] :D [22:08:54] <^demon> sumanah: And SVN is dead! [22:09:01] What a great week! [22:09:03] sumanah: thanks to AzaToth. I still need to review and fully merge it though [22:09:05] congrats all around! [22:09:12] YuviPanda: I went to an open source meetup last night at the New York Times and discovered some tools you might like [22:09:17] oooh? [22:09:20] https://github.com/jsoma/tabletop [22:09:29] "Tabletop.js takes a Google Spreadsheet and makes it easily accessible through JavaScript. With zero dependencies! [22:09:29] Tabletop.js easily integrates Google Spreadsheets with Backbone.js, Handlebars, and anything else that is hip and cool. It will also help you make new friends and play jazz piano." [22:09:59] https://github.com/jazzido/tabula [22:10:00] sumanah: wooo, one of the projects I'm going to work on starting *tomorrow* with a friend of mine could definitely use this [22:10:05] Tabula is a tool for liberating data tables trapped inside PDF files [22:10:17] "If you�ve ever tried to do anything with data provided to you in PDFs, you know how painful this is � you can�t easily copy-and-paste rows of data out of PDF files. Tabula allows you to extract that data in CSV format, through a simple web interface" [22:11:13] (03PS2) 10Jack Phoenix: Don't pass crap to Html::input. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/76090 [22:11:26] http://nvd3.org/ Re-usable charts for d3.js [22:11:54] sumanah: hipster! [22:12:05] https://github.com/mynameisfiber/countmemaybe/ countmemaybe is a set of probabilistic data structures that can estimate the cardinality of a set and also support unions. [22:12:20] ori-l: is that a description, an accusation, or an oath? [22:12:42] a jokey accusation [22:12:50] sumanah: so, the project I was going to work on tomorrow involved... extracting data from pdfs into a google spreadsheet and then visualizing it [22:13:21] HAHAHA [22:14:01] so yeah :) [22:14:05] YuviPanda: And in general I think you might also like to skim http://source.mozillaopennews.org/ which includes code, some blog posts, and a directory sort of thing [22:14:17] <^demon> Whenever I hear someone talk about rewriting mediawiki in node.js I get the feeling they're only half joking. [22:14:19] sumanah: were you freaked out by the button-less elevators at the nyt building? [22:14:21] <^demon> This scares me. [22:14:37] ^demon: Are you kidding, the Parsoid team is already making great progress! [22:14:38] Button-less elevators? [22:14:47] MediaWiki 2.0 will be in Java. [22:14:51] sumanah: that looks wonderful [22:14:57] Elsie: you clearly mean Scala/Clojure/Coco [22:15:00] <^demon> marktraceur: Luckily it's only an extension and that means I won't have to install it! [22:15:23] * ^demon - running MediaWiki since 2006 with no extensions except the one he's actively working on [22:15:33] Elsie: you indicate the floor you want to go to using a console that is situated on the wall outside the elevator, and the elevator just goes there. there are no floor buttons on the elevators themselves. it's a bit freaky. [22:15:40] ori-l: they were novel! but yes once you are inside and thinking that you have less control than usual over your destination..... [22:15:43] on the elevator walls i mean [22:15:43] ^demon: It'll just keep merging bits and pieces of the MediaWiki functionality into itself, eventually all of the coolest features will be put into it exclusively [22:15:45] I tend to just add on extensions as I mess with them [22:15:52] ^demon: you realize that the biggest hurdle towards writing an equivalent 'thing' is the parser? [22:15:54] ending up with dozens of extensions I hardly touch again [22:15:59] ^demon: parsoid is the trojan horse! [22:16:06] ori-l: when I got interviewed by Fog Creek in 2005 I had to answer that "design elevator system for busy office bldg" question [22:16:09] YuviPanda: That's the biggest hurdle? [22:16:14] YuviPanda: Beware gwickes bearing APIs [22:16:15] What about the half-million lines of code? [22:16:31] <^demon> Luckily most of those are crap and we can just get rid of them. [22:16:34] they are all multiple smaller ones [22:16:39] Actually you can sorta pronounce "gwicke" so it sounds like a 5 year old saying "Greek" [22:16:40] and yeah, we can kick all of them out [22:16:49] marktraceur: i just did that. TRUE! [22:16:54] YuviPanda: so, I am glad I was right and these are cool things you like :D [22:16:58] sumanah: indeed! [22:17:13] I'll poke you to show if we manage to build something cool off it :) [22:17:21] <^demon> Anyway...I've managed to get this far without ever writing javascript, and I won't start now! No node.js bandwagon can pick me up :P [22:17:56] marktraceur: ^demon we can start by kicking out our entire theming system and replacing it with sane templates. and also by replacing mysql with postgres. And also haskell. [22:18:06] * YuviPanda has an anuerism.  [22:18:12] YuviPanda: :D tell http://mozillaopennews.org/ if you do. Also tell your pals about http://mozillaopennews.org/fellowships/ which is a ten-month paid fellowship program to work in data journalism [22:18:34] sumanah: 'pal' in this case is Arun Ganesh (planemad), who I believe you've already met [22:18:49] I have! makes a lot of sense. [22:19:04] sumanah: we're going to work together to produce printed information visualization sheets to be placed across local bus stops, to inform people about routes, etc. [22:19:10] YuviPanda: say hi. i really, really miss Arun. [22:19:11] will tell him anyway. I bet he already knows [22:19:18] aharoni: you know where he is, right? [22:19:35] aharoni: we all should definitely visit him when you guys come here next [22:19:41] somewhere in some heaven on earth? [22:19:54] aharoni: http://en.wikivoyage.org/wiki/Sidhbari [22:19:59] (03CR) 10Parent5446: [ C: 04-2] "This isn't really necessary. You shouldn't be including WebStart.php outside of global scope anyway, considering its sole purpose is to se" [core] - 10https://gerrit.wikimedia.org/r/76208 (owner: 07Adamw) [22:20:21] YuviPanda: do you know what a "science fair" event is? [22:20:33] do those happen in schools in India? [22:20:51] sumanah: indeed. I remember making 'volcanos', and then graduating to demonstrating text to speech engines... :) [22:21:24] :D so, the event last night was structured as a "science fair." A room with lots of people's demos, and you could walk around and talk to them and look at their demos and signage [22:21:29] YuviPanda: as i imagined. I just recalled yesterday how he recites [something] in Sanskrit by heart. [22:21:41] http://opensourcesciencefair.com/events.html [22:21:42] aharoni: yeah, sounds like him :) [22:21:45] sumanah: nice! [22:21:54] sumanah: that sounds like a wonderful format [22:22:06] it's a GREAT format and if we had a few more weeks before Wikimania I would be copying it. [22:22:12] well, next time [22:23:12] sumanah: anyway, thanks for the links! I shall head to sleep now! [22:23:16] If I lived in the same city as the event I would feel comfortable trying to do it anyway, even on such short notice. But I'd want to set people up to be successful -- have cardboard and monitors and internet and helpful assistants and everything [22:23:23] Great! Sleep well and I'm glad I could help. :) [22:25:57] sumanah: ty! [22:25:57] (03PS3) 10Kaldari: More accurate function descriptions [core] - 10https://gerrit.wikimedia.org/r/74575 [22:34:11] (03PS1) 10MarkTraceur: Add registration table, convenience functions [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 [22:38:44] (03CR) 10Aaron Schulz: "The uses look correct for the old scheme, though yes those Pager classes and friends need to change here too (for global ID use later)." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 (owner: 07Aaron Schulz) [22:42:34] (03CR) 10Amire80: [ C: 122] Add Shapour font for Pahlavi script [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/75844 (owner: 07Ebrahim) [22:42:44] (03Merged) 10jenkins-bot: Add Shapour font for Pahlavi script [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/75844 (owner: 07Ebrahim) [22:53:24] has anyone set up CentralAuth/SUL2 on a development machine? [22:53:43] (03PS2) 10Aaron Schulz: Funnel all central ID <=> name/User lookups through the utils methods [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 [22:54:02] (03CR) 10Aaron Schulz: "Manual rebase (conflict merge of SpecialMWOAuthConsumerRegistration)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 (owner: 07Aaron Schulz) [22:59:00] spagewmf, well I guess the people who developed SUL2 did :) [22:59:12] I have CentralAuth setup locally but haven't messed with the new login system [22:59:47] Krenair: yes, csteipp is out and anomie not around. hashar's working on setting it up for beta labs [23:00:10] Is he having any particular issue? [23:01:36] Krenair: I don't know, but I am. Can $wgCentralAuthLoginWiki be my own wiki or must it be a separate loginwiki? [23:02:13] I set $wgCentralAuthSilentLogin = true; and $wgCentralAuthUseOldAutoLogin = false; but I don't think I'm getting the new behavior. [23:04:12] I'm actually not sure, sorry [23:04:42] that's OK, it's open source :o) [23:09:16] (03PS3) 10Aaron Schulz: Funnel all central ID <=> name/User lookups through the utils methods [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 [23:09:34] (03CR) 10Aaron Schulz: "(3 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/75773 (owner: 07Aaron Schulz) [23:18:08] (03CR) 10Mattflaschen: "That's not really a correct way of doing the recursive checkout. It should use clone --init --recursive. That should put the guiders sub" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76021 (owner: 07Reedy) [23:23:53] (03CR) 10Reedy: "That's recursive submodules. GuidedTour is a submodule of mediawiki/extensions.git. With guiders going to modules/externals/mediawiki.libs" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/76021 (owner: 07Reedy) [23:35:01] (03PS1) 10Aaron Schulz: Added $wgMWOAuthSharedUserIDs switch to allow using global user IDs [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/76218 [23:41:59] (03PS1) 10Jack Phoenix: QuizGame: made compatible with MW 1.21.1. [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76219 [23:42:33] (03CR) 10Jack Phoenix: [ C: 122 V: 122] QuizGame: made compatible with MW 1.21.1. [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/76219 (owner: 07Jack Phoenix) [23:48:42] Krenair: FYI the missing setting for the SUL2 behavior was $wgCentralAuthCookies = true; [23:59:01] (03CR) 10Aaron Schulz: [ C: 122 V: 122] Add class to stabilization link [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/75669 (owner: 07Umherirrender)