[00:01:14] Pywikipediabot moving to git on July 26: Wikipedia isn’t written just by humans! Bots have made great contributions to Wikipedia and other wikis like Wikidata (where bots have made over 90 percent of the edits so far). ̶... [00:01:15] Amir Sarabadani, July 23, 2013 [00:01:20] Well, isn't that fail? [00:02:58] (CR) Spage: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [00:02:59] (PS1) Parent5446: Initial extension code [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 [00:03:23] https://wikimediafoundation.org/wiki/Home [00:04:11] https://wikimediafoundation.org/wiki/Template:Blogbox [00:06:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=51916 [00:06:54] Oh my, Google Plus' "circle box" certainly isn't designed for round logos [00:06:55] http://cl.ly/image/1u0Q1w2h3E3D [00:06:58] awful [00:08:43] (PS4) Mollywhite: Cache the JSON blocks using memcached [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 [00:12:59] (CR) Krinkle: "(4 comments)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite) [00:14:17] Krinkle: Avoid empty? [00:14:34] php empty() is an anti-pattern. [00:14:54] Why? [00:15:05] It is way too tolerant. [00:15:20] variable can even be undefined (so it includes isset() ) [00:15:33] aside from null values, empty arrays, string '0', and more [00:15:58] afaik cache get() will return explicit boolean false if there is no cache value [00:16:06] anything else is a value you inserted into it, so that shouldn't be rejected. [00:16:56] Krinkle: Alrighty. I did see it returns false if there's not value, but the example here threw me off: https://www.mediawiki.org/wiki/Memcached#Using_memcached_in_your_code [00:16:57] "if there is no cache value" -> if there is no cache value or the cache has been expired/invalidated. [00:17:12] Because it checks $data != '' [00:17:18] But perhaps that's just a poorly-written example [00:17:22] Indeed [00:18:59] (CR) Reedy: "(8 comments)" [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [00:21:50] GorillaWarfare: updated, https://www.mediawiki.org/wiki/Memcached#Using_memcached_in_your_code [00:22:11] Cool :) [00:23:29] Krinkle: Regarding the generic memcached key, are you suggesting prepending something like "BookManagerv2_book_json_" [00:23:30] GorillaWarfare: Depending on how these values get updated (how does the cache get updated if the values are no longer up to date?), you may want to use the pageid instead of the page title [00:23:44] GorillaWarfare: This is what wgMemcKey does for you [00:24:00] pass it a list and it will generate a somethign-separated string as key [00:24:10] I think it uses colons, but that's just a detail. [00:24:24] it also prefixes wikiid, so that e.g. page titles from one wiki don't conflict with another wiki [00:24:33] since at Wikimedia everything uses a shared infrastructure. [00:24:37] Krinkle: The cache is updated when the JSON block is edited [00:24:59] Why use the page id? [00:25:35] So that 1) when a page is renamed, the values still work without needing to be regenerated [00:25:57] 2) when a page is edited after the rename, it will re-use the same cache key instead of creating a new one and leaving the old one hanging around somewhere [00:26:42] if the values in question require to be regenerated after a rename (this is possible, you'd know better than me) then you should probably hook into page rename and call a invalidation or regeneration from there. [00:27:26] Hm, the page id probably makes more sense then [00:29:31] (CR) Krinkle: "Why a new extension instead of improving InlineCategorizer? The original version of both do the same (all javascript), this will make a ch" [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [00:29:38] (PS2) Parent5446: Initial extension code [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 [00:29:56] (PS1) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] - https://gerrit.wikimedia.org/r/75536 [00:31:17] (CR) Parent5446: [C: -1] "I'll check out InlineCategorizer for the UI stuff since the UI stuff here sucks. I just wrote this up over the weekend; it's not ready to " [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [00:31:40] (PS2) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] - https://gerrit.wikimedia.org/r/75536 [00:32:52] (CR) Parent5446: [C: -2] Initial extension code [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [00:35:37] (CR) Krinkle: "Sure, no worries. Thanks for everything so far. Great to have some activity around this." [extensions/HotCat] - https://gerrit.wikimedia.org/r/75534 (owner: Parent5446) [00:37:16] (PS1) Catrope: [WIP] Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75537 [00:40:18] (CR) Mwalker: [C: -1] "(3 comments)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524 (owner: Mollywhite) [00:41:47] (CR) Alex Monk: "(2 comments)" [extensions/Oversight] - https://gerrit.wikimedia.org/r/18229 (owner: Alex Monk) [00:42:24] Krinkle: I just saw a comment you made on a patch to avoid the use of empty() -- what do you propose to use instead and why? [00:42:47] mwalker: anything is better than empty(), there's few ways to go worse. [00:44:00] Essentially 2 problems. 1) It's implementation is (albeit documented) very tolerant (includes unset variables, variables with no value, empty array, empty string, string '0' and lots more), 2) Aside from being tolerant in nature, as for the function name it isn't very explanatory either what you (developer) are intending to check for (what you're expecting) [00:44:16] it's an unmaintainable factor that is hard to support in future iterations. [00:44:33] fair enough -- I was wondering if you were complaining about the fact that it doesn't throw warnings on non existent variables [00:44:38] === false, === 0, count() === 0, === ''. isset(). Whatever it is you want to check for, check for that. [00:44:52] 5:38PM 23/Jul/2013 [00:44:52] mwalker: yes, that is probably the biggest problem with empty(), that is includes isset() [00:56:36] (CR) Mwalker: "(2 comments)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite) [00:57:33] Yo jdlrobson or anyone, what's a simple precommit hook that avoids the embarrassment of red trailing whitespace in gerrit? http://stackoverflow.com/a/6262715/451712 and similar seem way too complicated [01:02:46] spagewmf: I read my diffs before committing, and on my system 'git diff' highlights this in red [01:10:21] spagewmf: in your .gitconfig, add [01:10:23] [apply] [01:10:28] whitespace = fix [01:10:55] i learned that one from YuviPanda the other day [01:11:25] oh, that was on the SO answer. [01:14:54] legoktm: How's it going? [01:15:20] Every mainspace page on el.wikivoyage is connected to a Wikidata item! [01:16:32] Today was mainly a learning day though [01:16:58] :-) [01:17:01] Learning is good! [01:17:05] Better than the opposite, at least. [01:20:52] I have to go offline for a bit, but I'm going to start working on the confirmation screen [01:20:58] (CR) Aaron Schulz: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [01:20:58] legoktm Doesn't work for me, but then neither do all the ~/.git/hooks/pre-commit examples. I Weird. [01:21:23] (PS2) Catrope: [WIP] Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75537 [01:21:36] spagewmf: Well since I've installed it, either I've gotten really good with noticing whitespace, or it works :P I did note that it didn't remove only whitespace on it's own line. [01:22:06] (CR) MZMcBride: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [01:23:14] Elsie: I'm thinking of at the top it shows a preview of the message body in context of the first target, then have some kind of summary like "Will deliver to XX talk pages, and XX project pages" [01:24:01] Sounds good to me. [01:24:23] legoktm: You'll need to re-label the form submit button to be "next" or "review" or something. [01:24:30] On the first screen, I mean. [01:24:32] Right. [01:24:39] Can't wait to see it! [01:30:10] legoktm: BTW, - is the bullet delimiter in Gerrit comments, not *. [01:30:16] Grrrrrrrrrrrrit. [01:31:01] (CR) MZMcBride: "Related: I2418e33ebd91dc0dc6968ba003a46857ec7524d3" [core] - https://gerrit.wikimedia.org/r/61073 (owner: Cscott) [01:34:23] (CR) MZMcBride: "- Needs a way to get an edit token" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75299 (owner: Legoktm) [01:37:13] (CR) MZMcBride: "Yay. :-)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75473 (owner: Legoktm) [01:41:36] FWIW https://gist.github.com/holysugar/1318698 worked for me as a warning , but it's a hassle to have to copy it into every project. I will set an init.templatedir to replace Ubuntu's "Here's yet another set of .sample hooks". [01:50:47] legoktm, [apply] whitespace= only applies when applying patches with git apply, so it doesn't apply to `git commit` :) And [core] whitespace= only applies when running diff, as RoanKattouw points out. http://git-scm.com/book/ch7-1.html So I have to futz around with pre-commit. [02:04:16] I have 164 useless duplicate .git/hooks/*.sample files, 2.2 MB That's a lot of floppies :) [02:04:38] Two? [02:05:07] Or do you mean each file is 2.2 MB? [02:13:30] (CR) MZMcBride: "Do we want to continue pursuing this changeset given bug 41522 comment 10 and bug 41522 comment 11?" [extensions/ConfirmEdit] - https://gerrit.wikimedia.org/r/40553 (owner: Helder.wiki) [02:14:23] Elsie, my floppy disks are 5¼ in Shugart SA400 160kB single-sided, as used in the IBM PC :) [02:15:02] Ah, I thought we were talking about the "traditional" 1.4 MB ones. [02:23:08] (PS1) Ori.livneh: Report calls to deprecated methods as errors in PHP log [vagrant] - https://gerrit.wikimedia.org/r/75544 [03:10:59] (PS3) Catrope: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75537 [03:11:33] AaronSchulz: Are you around? Do you have time for some CR? ---^^ [03:11:56] (I apologize for the hackiness of that commit. My only excuse is that I really hate EditPage and I hope it dies the most painful of deaths) [03:27:06] (Merged) jenkins-bot: mediawiki.notification: Make notification area sticky to window [core] - https://gerrit.wikimedia.org/r/72322 (owner: Matmarex) [03:32:29] (CR) Shirayuki: "The messages "inlinecategorizer-edit-category-error" and "inlinecategorizer-remove-category-error" contain "$1"," [extensions/InlineCategorizer] - https://gerrit.wikimedia.org/r/73719 (owner: Shirayuki) [03:34:28] (CR) Ori.livneh: "Prior to merging please try out the setting and see if it's disruptive. (I'll try to do the same.)" [vagrant] - https://gerrit.wikimedia.org/r/75544 (owner: Ori.livneh) [03:34:32] (PS2) Shirayuki: Fix parameters for messages [extensions/InlineCategorizer] - https://gerrit.wikimedia.org/r/73719 [03:52:54] (PS1) Bsitu: user talk and mention notification improvement [extensions/Echo] - https://gerrit.wikimedia.org/r/75546 [03:53:01] (CR) jenkins-bot: [V: -1] user talk and mention notification improvement [extensions/Echo] - https://gerrit.wikimedia.org/r/75546 (owner: Bsitu) [04:02:30] (PS4) Catrope: Add 'top' flag to allow Gadgets to top-load [extensions/Gadgets] - https://gerrit.wikimedia.org/r/75506 [04:09:09] Elsie: It kinda works! [04:09:19] deploy! [04:09:26] * ori-l scaps. [04:10:49] (PS1) Mwjames: \SMW\ParserOutputGenerator [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75547 [04:21:00] (PS1) Santhosh: Fix javascript error with language fallbacks [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75548 [04:24:03] (CR) Amire80: [C: 2] Fix javascript error with language fallbacks [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75548 (owner: Santhosh) [04:24:19] (Merged) jenkins-bot: Fix javascript error with language fallbacks [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75548 (owner: Santhosh) [04:30:51] (PS2) Mwjames: \SMW\ParserOutputGenerator [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75547 [04:39:43] (CR) Tim Starling: [C: -1] "I think that's too hacky. Language::$mLangObjCache shouldn't be accessed from outside the Language class. And it should support lazy initi" [core] - https://gerrit.wikimedia.org/r/74523 (owner: SuchABot) [04:41:30] (CR) Trevor Parscal: [C: 2 V: 2] Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75537 (owner: Catrope) [04:43:19] (PS1) KartikMistry: Add the Gentium font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75549 [04:43:37] legoktm: Does it? [04:43:45] (Merged) Trevor Parscal: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75537 (owner: Catrope) [04:44:28] Elsie: Well the functionality of seeing the preview works. Just the workflow of going from form --> preview --> submit is broken. Working on that right now. [04:44:49] Yay. [04:45:36] (CR) Trevor Parscal: [C: 2] Add a hook to Title::getEditNotices() so extensions can add them [core] - https://gerrit.wikimedia.org/r/75536 (owner: Catrope) [04:48:16] (Merged) jenkins-bot: Add a hook to Title::getEditNotices() so extensions can add them [core] - https://gerrit.wikimedia.org/r/75536 (owner: Catrope) [04:51:09] (CR) Mwjames: [C: 2] "Before people start complaining something weird is happing when running the updatejob, I'll be so free to deploy this rather quickly ..." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75547 (owner: Mwjames) [04:52:28] (Merged) jenkins-bot: \SMW\ParserOutputGenerator [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75547 (owner: Mwjames) [04:55:10] (CR) Tim Starling: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74550 (owner: Ori.livneh) [04:56:30] (CR) Mollywhite: "(2 comments)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524 (owner: Mollywhite) [05:00:53] (PS2) Ori.livneh: Discard comments in mergeMessageFileList.php's --list-file file [core] - https://gerrit.wikimedia.org/r/74550 [05:02:23] (CR) Tim Starling: [C: 2] Discard comments in mergeMessageFileList.php's --list-file file [core] - https://gerrit.wikimedia.org/r/74550 (owner: Ori.livneh) [05:07:17] (Merged) jenkins-bot: Discard comments in mergeMessageFileList.php's --list-file file [core] - https://gerrit.wikimedia.org/r/74550 (owner: Ori.livneh) [05:20:40] (PS5) Mollywhite: Cache the JSON blocks using memcached [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 [06:00:22] Elsie: It works! [06:03:24] legoktm successfully installed Apache. [06:03:38] Heheh [06:03:46] I'm just cleaning it up before posting it [06:15:44] (PS1) Legoktm: Add a preview/confirmation menu. Also major internal restructuring of the special page. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 [06:16:08] * Elsie clicks. [06:17:23] Elsie: I just enabled it live on the labs wiki if you want to play with it [06:19:59] legoktm: The behavior is a bit wonky. [06:20:10] (PS17) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [06:20:22] legoktm: I think you'll want a Preview button on the preview screen. [06:20:25] To allow re-previews. [06:20:49] Yeah, I need to figure out how to add a second button [06:22:19] (PS18) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [06:23:29] legoktm: It's difficult to test with it out. :-) [06:23:46] Heh, without it. * [06:23:49] Words are hard. [06:24:41] (PS1) Catrope: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75551 [06:25:00] legoktm: It'd be good to get some of the pending changes merged. [06:25:14] Intro message, message cleanup, subject line limitation, etc. [06:25:50] Yeah, I'll do that in a bit [06:26:27] This still needs a bit of design love, but overall it's getting much closer. [06:27:55] (PS1) Catrope: Pass through request parameters in API action=edit [core] - https://gerrit.wikimedia.org/r/75552 [06:28:15] (CR) Trevor Parscal: [C: 2 V: 2] Call ->load() in addReviewCheck() [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75551 (owner: Catrope) [06:28:16] (Merged) Trevor Parscal: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75551 (owner: Catrope) [06:28:49] legoktm: Looks like the error-checking for blank subject/body either is broken or isn't yet merged. [06:29:16] Not merged yet [06:29:47] https://gerrit.wikimedia.org/r/#/c/75285/ <-- do those messages look fine to you? [06:31:02] (CR) MZMcBride: "This looks good to me." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75285 (owner: Legoktm) [06:31:13] (CR) Trevor Parscal: [C: 2] Pass through request parameters in API action=edit [core] - https://gerrit.wikimedia.org/r/75552 (owner: Catrope) [06:31:32] (CR) Legoktm: [C: 2 V: 2] Give users an error if they try to send a message with no subject line and/or message body. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75285 (owner: Legoktm) [06:31:33] (Merged) Legoktm: Give users an error if they try to send a message with no subject line and/or message body. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75285 (owner: Legoktm) [06:31:49] Ok, I'll rebase on top of that once I finish adding the second preview button [06:33:39] (Merged) jenkins-bot: Pass through request parameters in API action=edit [core] - https://gerrit.wikimedia.org/r/75552 (owner: Catrope) [06:39:19] (PS1) Ori.livneh: MWInit::classExists -> class_exists [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75553 [06:39:34] (PS1) Ryan Lane: Up OpenStackManager version [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75554 [06:40:53] ori-l: https://github.com/search?q=MWInit%3A%3AclassExists+%40wikimedia&ref=cmdform&type=Code [06:40:58] (CR) Ryan Lane: [C: 2 V: 2] Up OpenStackManager version [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75554 (owner: Ryan Lane) [06:41:00] (Merged) Ryan Lane: Up OpenStackManager version [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75554 (owner: Ryan Lane) [06:41:36] legoktm: I did one [06:42:07] that fulfills the "leave it better than you found it" rule [06:42:19] Now the other cheek. [06:43:18] :P [06:45:49] ori-l: https://bugzilla.wikimedia.org/show_bug.cgi?id=45031#c14 [06:45:51] I'm pretty sure there's a bug in the RSS extension where it occasionally displays the blog post description. [06:47:07] TimStarling: yep, replying [06:51:49] https://en.wikipedia.org/wiki/Wikipedia:Your_first_article [06:51:53] I'm looking at ZeroRatedMobileAccess [06:51:54] I wonder if anyone's ever read that. [06:52:31] it sets hooks based on a boolean configuration variable, obviously you can't do that from the file scope [06:52:49] it should instead have the configuration variable checks inside unconditionally-registered hook functions [06:52:55] Elsie: We frequently link that in -en-help [06:53:07] It's quite long. [06:53:12] i.e. static function onCanonicalNamespaces( array &$namespaces ) { [06:53:24] if ( !$GLOBALS['wgZeroRatedMobileAccessEnableZeroConfigPages'] ) return; [06:53:25] ... [06:53:25] Elsie: WP:42 is better imo [06:53:56] ^ yurik [06:54:01] It should just say "we're going to delete your article, just resume Facebooking." [06:54:08] Or Twittering. [06:55:06] https://bits.wikimedia.org/static-1.22wmf10/extensions/Thanks/ThankYou.png [06:55:06] but most of the content of zero's onCanonicalNamespaces() can be in the file scope [06:55:08] TimStarling: it isn't file scope; it's deferred to $wgExtensionFunctions[] too, but yurik's is an anonymous function in the same file [06:55:16] Am I really the only person who finds that image a little disturbing? [06:55:36] I'm saying that it shouldn't be deferred [06:55:41] for example: [06:55:42] $wgNamespaceContentModels[NS_ZERO] = 'JsonZeroConfig'; [06:55:46] this can just be in the file scope [06:55:57] it's harmless to configure a non-existent namespace [06:56:34] there definitely shouldn't be global variable assignments in a CanonicalNamespaces hook handler [06:56:50] it's not guaranteed that the hook will be called before the variables are accessed [06:58:09] what's guaranteed is that there will be no hook calls between execution of the file scope and setting of the configuration variables [06:58:34] OK, that makes sense [06:58:36] so you can reference configuration globals from hook functions with confidence [06:58:46] right, so that's the value of the hook [06:59:44] gtg [06:59:51] gl;hf [07:01:03] (PS2) Legoktm: Add a preview/confirmation menu. Also major internal restructuring of the special page. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 [07:01:18] (CR) Legoktm: "PS2: Manual rebase" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 (owner: Legoktm) [07:01:32] 75550 is a pretty number. [07:06:44] (OT) W3C India, people. http://www.w3cindia.in/HTML5-tour-2013/index.html straight out of 1993! [07:08:36] Image scaling is hard. [07:09:36] it doesn't scale [07:09:54] (PS3) Legoktm: Add a preview/confirmation menu. Also major internal restructuring of the special page. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 [07:10:14] It's WebScale. [07:11:49] (CR) MZMcBride: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 (owner: Legoktm) [07:12:33] Elsie: I copied that out of TranslationNotifications :P [07:12:39] But I can make that a real word. [07:12:52] (CR) MZMcBride: "After previewing the message, the form should have two buttons: re-preview and send." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 (owner: Legoktm) [07:13:19] It's pretty adorable how much attribution you give. [07:13:34] If only as a reminder of how little attribution other coders give when copying and pasting code. [07:13:58] :/ [07:15:28] (CR) Legoktm: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [07:15:34] Elsie: ^ [07:15:50] (CR) Santhosh: [C: 2] Add the Gentium font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75549 (owner: KartikMistry) [07:16:00] (Merged) jenkins-bot: Add the Gentium font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75549 (owner: KartikMistry) [07:16:29] (CR) Legoktm: [C: 2] "Syntactically correct, and seems to work." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75522 (owner: Legoktm) [07:16:37] (Merged) jenkins-bot: Add .jshintrc [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75522 (owner: Legoktm) [07:17:23] legoktm: self-merging even trivial patches will make it harder to get the extension deployed [07:17:27] (CR) Aude: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 (owner: Legoktm) [07:17:49] legoktm: left you a comment :) [07:17:56] aude: thanks! [07:18:31] so this would replace Elsie's bot ? [07:18:56] ori-l: I realize, but there aren't really that many people who want to review a non-deployed still in development extension. It's just been me, Elsie and YuviPanda pretty much. [07:19:02] aude: that's the goal :D [07:19:03] aude: That's the hope. :-) [07:19:12] legoktm: sounds like good-sized crowd to me [07:19:29] yay! [07:19:33] The self-merge rule doesn't apply to non-deployed extensions. [07:19:37] Or the operations repo, apparently. [07:20:00] Elsie: it is intended for deployment, though, no? [07:20:01] i'd say self-merge is preferred, but either way the extension would need a code / security review [07:20:18] and then after deployment, then self-merge is a no no :) [07:20:24] What aude said. [07:20:40] anyways, I'm not a stickler for CR rules and violate them myself sometimes [07:20:41] errr, self merge not preferred [07:20:50] ori-l: Basically the extension is in draft currently. [07:20:50] it was purely strategic advice, but I still think it is sound. [07:20:54] having someone else review, is nice but not always practical for nondeployed stuff [07:21:09] It doesn't make much sense to hold off on improving the extension while it's being drafted. [07:21:29] Though if you want to give me merge rights on the extension, I can do some of it. [07:21:30] if only git had branching [07:21:44] I'm told it's easier to just commit to master. [07:21:58] ok, touche [07:21:59] proceed [07:22:37] aude: Seems SpecialPage implements its own getUser function, which is just "$this->getContext()->getUser()" [07:22:40] aude hates my bot, BTW. You can see how she jumped for joy at the thought of its early demise. ;-) [07:23:06] legoktm: yes you can use $this->getUser() [07:24:32] (PS4) Legoktm: Add a preview/confirmation menu. Also major internal restructuring of the special page. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 [07:24:44] > * Killed all non-configuration globals :D [07:25:31] (CR) Legoktm: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75550 (owner: Legoktm) [07:25:35] Death to globals. Death to EditPage.php. Death to ... [07:26:36] Elsie: https://gerrit.wikimedia.org/r/#/c/75293/ <-- review plz [07:27:06] Death to Elsie. [07:27:12] Working ... [07:28:22] * YuviPanda has no power, and no idea when it'll be back [07:28:26] When I finally lose my mind, I'll just sit in the corner muttering about puppet freshness, repeating "working ...", and occasionally shouting "CODE REVIEW ERROR, UNSUPPORTED QUERY." [07:28:26] so much for waking up early [07:28:40] YuviPanda: :( [07:28:58] legoktm: even funnier is that there's no water either, and there can be no water without power [07:29:00] so yay. [07:29:07] battery's gonna die in a few mins [07:29:12] RIP. [07:29:21] YuviPanda: :( [07:29:22] No power means no fans :( [07:29:29] that too. [07:29:38] at least it isn't unbearably hot [07:29:44] Yet! [07:30:12] I'm in a different city which doesn't have the traditional 'hot all the year' season :) [07:30:17] so I won't roast, at least [07:30:45] my camera's lens also broke today. fell into two [07:30:48] great day so far :D [07:32:07] YuviPanda: Campaigns live! [07:32:23] ori-l: they were live on Monday :D [07:32:32] s/live/continue to live/! [07:32:35] :D [07:32:52] (CR) MZMcBride: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 (owner: Legoktm) [07:33:10] I don't think ! is valid sed syntax. [07:33:17] Won't that just cause an expression error? [07:33:18] (CR) Legoktm: [C: -2] "If we use the JobQueue to submit remote jobs, we don't need this anymore." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm) [07:34:21] Hmm. It seems to simply be ignored. [07:34:33] (CR) Aaron Schulz: "(1 comment)" [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/71537 (owner: Anomie) [07:34:45] (PS2) Legoktm: Clarify post-submit message that the messages have been queued, not sent. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 [07:35:42] (CR) Legoktm: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 (owner: Legoktm) [07:36:15] (CR) MZMcBride: "This looks fine to me. We'll deal with the larger issue of effectively monitoring a delivery some other time." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 (owner: Legoktm) [07:37:05] (CR) Legoktm: [C: 2] Clarify post-submit message that the messages have been queued, not sent. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 (owner: Legoktm) [07:37:10] (Merged) jenkins-bot: Clarify post-submit message that the messages have been queued, not sent. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 (owner: Legoktm) [07:37:30] ori-l: something you might be able to comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=51929 [07:37:50] Elsie: Now https://gerrit.wikimedia.org/r/#/c/75446/ :) [07:38:50] YuviPanda: #2 sounds reasonable [07:39:02] ori-l: hmm, but can't track deleted things. But that's fine, I think. [07:39:24] what about edit tags? [07:39:42] we could just microchip new users, as Elsie has repeatedly suggested [07:39:53] ori-l: hmm, that is possible. [07:40:15] ori-l: but won't that add a lot of tags? [07:40:20] one tag per campaign [07:40:26] and since people can create campaigns.. [07:40:37] and also there's no way to add a tag from the API [07:40:43] not sure if there will ever be, either [07:41:10] there was a long thread on wikitech-l about that a long time ago which descended into bikeshed enforced quietness [07:41:18] YuviPanda: https://www.mediawiki.org/wiki/Revtagging [07:41:49] i don't think having a tag per campaign is necessarily awful [07:41:55] (CR) MZMcBride: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [07:42:10] just have them share a common prefix ('Campaign: ' or something) so you can still query for them in aggregate [07:42:35] Somebody bring me some water, can't you see I'm burnin' alive. [07:42:58] ori-l: revtagging is implemented? I think not [07:42:58] :O [07:43:18] YuviPanda: Revision tagging has existed for a few version of MediaWiki. [07:43:25] versions [07:43:27] (PS3) Legoktm: Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 [07:43:28] (CR) jenkins-bot: [V: -1] Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [07:43:32] That too. [07:43:33] It's late. [07:43:34] Elsie: not the same as revtagging. [07:43:38] Why am I still awake? [07:43:47] * YuviPanda tucks Elsie in [07:44:01] because puppet freshness on zinc [07:44:15] I check the puppet freshness every nine hours. [07:44:16] And yet. [07:44:28] YuviPanda: Yeah, that page should probably just be deleted. [07:44:45] it's very, *very* useful [07:44:49] It was created before anyone realized that the feature already existed. [07:45:06] (PS4) Legoktm: Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 [07:45:10] Elsie: you can't add tags from the API [07:45:15] and it's also jst a string, IIRC. [07:45:18] don't delete it just yet, please [07:45:41] good night ori-l [07:45:42] it's marked as a draft, which is good enough [07:45:44] YuviPanda: I didn't say it was implemented well. [07:45:50] hi hashar :) [07:46:09] YuviPanda: The current implementation has a number of problems. But it's probably a better base than simply starting over. [07:46:24] Night, Ori. [07:46:26] oh yeah, but that doesn't mean that page has to be deleted. We can implement those things on top of this. [07:46:40] That page should probably be an RFC. [07:46:46] I know that starting over is not what life's about. / But my thoughts were so loud I couldn't hear my mouth. [07:46:51] night [07:47:54] I will be FORCED TO RETIRE now [07:48:00] due to TECHNICAL REASONS! [07:48:12] my laptop just gave me a low power warning :( [07:48:32] (CR) Legoktm: [C: 2] Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [07:48:37] (Merged) jenkins-bot: Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [07:48:48] YuviPanda: don't you have power cords ? :( [07:48:53] hashar: no power. [07:48:57] no idea when it'll be back [07:49:01] and no water either [07:49:12] but you get internet … go figure :-] [07:49:13] and my camera's lens also broke earlier today. [07:49:15] wonderful day [07:49:18] oh my [07:49:19] hashar: yeah, phone's fully charged :) [07:49:25] we can fund raise you a new lens [07:49:29] :D [07:49:38] I'll probably ask someone coming from the US to buy it for me [07:49:38] (PS1) IAlex: (bug 49694) Apply $wgSpamRegex to the new section name in action=edit§ion=new [core] - https://gerrit.wikimedia.org/r/75556 [07:49:43] and give me in Hong Kong [07:49:51] that is a good idea [07:50:01] and ask them some battery while you are it [07:50:22] if there was a haswell thinkpad or xps dev editoon, I'd have asked for that [07:50:23] enjoy your afternoon and get out for some fresh air [07:50:26] one of those solar charger back packs >.> [07:50:28] but those don't exist yet [07:50:40] will do, hashar :) [07:50:48] seeya YuviPanda [07:52:21] see you YuviNoPower ! [07:53:14] (CR) Legoktm: [C: 2] "Tested, works fine." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75473 (owner: Legoktm) [07:53:31] (Merged) jenkins-bot: Use jquery.byteLimit to ensure we don't end up with truncated edit summaries [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75473 (owner: Legoktm) [07:56:37] (PS6) Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/74850 [07:56:46] (PS3) Nikerabbit: Turn edit tab to translate tab on translation pages [extensions/Translate] - https://gerrit.wikimedia.org/r/69162 [07:57:58] (CR) Legoktm: [C: 1] MWInit::classExists -> class_exists [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75553 (owner: Ori.livneh) [07:58:52] (PS11) Eranroz: Support ApiPageSet in ApiWatch [core] - https://gerrit.wikimedia.org/r/53964 [08:00:30] (PS1) Legoktm: Use PHP's built-in class_exists instead of MWInit::classExists [extensions/ConfirmEdit] - https://gerrit.wikimedia.org/r/75557 [08:02:39] (PS1) Legoktm: Use PHP's built-in class_exists instead of MWInit::classExists [extensions/TimedMediaHandler] - https://gerrit.wikimedia.org/r/75558 [08:05:32] (CR) Rillke: "How about executing updateAreaMode only if at least one notification is/ becomes visible at all?" [core] - https://gerrit.wikimedia.org/r/72322 (owner: Matmarex) [08:41:31] (CR) TheDJ: "@Jdlrobson Krinkle is right that make is not available by default. You need to have the Xcode commandline tools installed before it is ava" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [08:48:50] (PS1) Ori.livneh: (WIP) Parse errors and write to MongoDB [tools/fluoride] - https://gerrit.wikimedia.org/r/75560 [08:49:17] hashar: ^ [08:49:19] good night [08:49:47] (CR) Matmarex: "> How about executing updateAreaMode only if at least one notification is/ becomes visible at all?" [core] - https://gerrit.wikimedia.org/r/72322 (owner: Matmarex) [08:50:08] ori-l: thanks! have a good night!:) [09:08:48] (CR) J: [C: 2] Use PHP's built-in class_exists instead of MWInit::classExists [extensions/TimedMediaHandler] - https://gerrit.wikimedia.org/r/75558 (owner: Legoktm) [09:08:50] (Merged) jenkins-bot: Use PHP's built-in class_exists instead of MWInit::classExists [extensions/TimedMediaHandler] - https://gerrit.wikimedia.org/r/75558 (owner: Legoktm) [09:45:30] Nikerabbit, you there? [09:46:38] (Abandoned) Aude: Update Wikibase to handle exception for missing sites [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75372 (owner: Aude) [09:49:15] MaxSem: on the road, just going for lunch [09:50:24] Nikerabbit, the ops have prepared for you a dedicated solr server zinc, and ask you to leave vanadium asap:) [09:51:06] (CR) Hashar: "(9 comments)" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar) [09:51:33] (PS4) Hashar: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 [09:53:23] MaxSem: oh? [09:53:27] what is needed [09:53:38] I'm still on vacation for this week [09:53:51] ah, vacation... [09:54:31] Nikerabbit, I could try it myslef, if you explain me how to reindex it from scratch [09:54:47] definitely don't want to disturb you:) [09:57:17] (PS1) Santhosh: Lazy initialization of language settings for IME menu [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75564 [09:57:45] (CR) Matmarex: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar) [09:58:30] (CR) Hashar: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar) [09:58:42] MatmaRex: hope that property vs function argument makes sense [09:58:43] (CR) Matmarex: [C: 1] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar) [09:59:12] (PS1) Santhosh: Typo fix [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75565 [09:59:15] hashar: yeah, that code is a mess [09:59:26] MaxSem: just run the ttmsever-export script for each wiki after updating config [09:59:39] MatmaRex: can you believe that we used to have copy pasted code in special pages ? : -] [09:59:48] for each wiki with Translate? [09:59:49] MatmaRex: aka before QueryPage got introduced :) [10:00:08] MaxSem: yeah [10:00:15] cool [10:00:16] try with a small one first [10:00:17] thanks [10:00:51] hashar: sure i can. just look at special:rc and compare with special:watchlist [10:01:17] they are only different because RC was rewirtten to suck less, and watchlist never was. [10:01:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=48641 [10:03:26] santhosh, yt? I need someone to verify that TTM migration works before going ahead:) [10:08:17] (PS1) Amire80: Add the environment variable KEEP_BROWSER_OPEN [qa/browsertests] - https://gerrit.wikimedia.org/r/75568 [10:09:19] oh, aharoni is there [10:10:32] MaxSem: Nikerabbit is the TTM wizard, but what is it about exactly? [10:11:16] (I read the scrollup) [10:11:29] MaxSem: did you run that? do I need to test it? [10:12:03] aharoni, Niklas is on vacation. I need someone from your team to check if I'm doing it right. I didn't do anything yet, need to be sure that someone's around:) [10:15:10] MaxSem: i don't know much about the technicalities of the scripts, but I'm around and I can do a sanity check. [10:15:21] is it on the cluster? sites like meta, mw.org and stuff? [10:15:37] aharoni, I just need to verify that it works from user's perspective [10:15:40] (PS1) Hashar: SpecialPrefixindex formatting methods are now protected [core] - https://gerrit.wikimedia.org/r/75569 [10:15:41] Ok [10:15:46] just ping me [10:15:49] I'll start with testwiki [10:16:41] MatmaRex: I wish we had a way to easily generate form and handle the parameters by using conventions [10:17:37] (CR) Hashar: "The hideredirect is made a property with https://gerrit.wikimedia.org/r/#/c/75569/" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar) [10:17:55] (CR) Hashar: "Maybe we should add accessor/mutator for the new property, but that might be overkill :-]" [core] - https://gerrit.wikimedia.org/r/75569 (owner: Hashar) [10:18:03] meh, apparently it's possible to add a bug without a description to Bugzilla [10:18:26] (PS1) Ebrahim: Opt-out Persian from links underline removal [core] - https://gerrit.wikimedia.org/r/75570 [10:21:11] hmm, Empty $mTitle in OutputPage::parse [10:21:31] FAIL [10:21:46] !!ask [10:21:46] There is no such key, you probably want to try: !tooquiet, [10:21:52] !tooquiet [10:21:52] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [10:22:01] !alias !ask tooquiet [10:22:06] ... [10:22:12] not like this [10:22:19] !ask alias tooquiet [10:22:19] Created new alias for this key [10:22:22] @alias !ask tooquiet [10:22:30] !!ask [10:22:30] There is no such key, you probably want to try: !tooquiet, [10:22:33] !alias [10:22:37] ah, wait [10:22:39] !!ask alias tooquiet [10:22:40] Created new alias for this key [10:22:40] !ask [10:22:41] https://www.mediawiki.org/wiki/Extension:Ask [10:22:46] !ask unalias [10:22:47] Alias removed! [10:22:47] !ask [10:22:48] https://www.mediawiki.org/wiki/Extension:Ask [10:22:49] !!ask [10:22:49] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [10:22:58] yeah well, wm-bot doesn't really handle this well [10:23:02] !ask alias !!ask [10:23:02] Unable to create alias for !!ask because there is no such key, if you really want to create this broken alias do !ask force-alias !!ask [10:23:12] !ask alias !ask [10:23:12] Unable to create alias for !ask because the target is alias, but not a key, if you really want to create this broken alias do !ask force-alias !ask [10:23:17] hashar: what are you trying to do? :D [10:23:21] !ask alias tooquiet [10:23:22] Created new alias for this key [10:23:25] !ask [10:23:25] https://www.mediawiki.org/wiki/Extension:Ask [10:23:32] for god sake [10:23:36] !ask del [10:23:37] Successfully removed ask [10:23:38] !!ask [10:23:38] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [10:23:43] aliases and keys are separate [10:23:51] !ask [10:23:52] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [10:23:52] MatmaRex: I am not sure what I want to do hehe [10:24:10] hm [10:24:16] now it's self-referential [10:47:29] (CR) KartikMistry: [C: 1] "LGTM!" [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75565 (owner: Santhosh) [10:53:47] (PS1) Matmarex: Enhanced RC: Remove the list of users who edited the page [core] - https://gerrit.wikimedia.org/r/75571 [11:02:23] aharoni, I've aborted due to https://bugzilla.wikimedia.org/51956 [11:05:32] (CR) Hoo man: [C: 2] MWInit::classExists -> class_exists [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75553 (owner: Ori.livneh) [11:05:35] (Merged) jenkins-bot: MWInit::classExists -> class_exists [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75553 (owner: Ori.livneh) [11:07:21] (PS1) Santhosh: Lazy initilization of language settins from ULS [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75574 [11:08:20] (PS2) Santhosh: Lazy initilization of language settins from ULS [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75574 [11:08:59] (CR) Hoo man: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/75556 (owner: IAlex) [11:11:48] (PS3) Santhosh: Lazy initilization of language settings from ULS [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75574 [11:12:02] (PS2) Santhosh: Lazy initialization of language settings for IME menu [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75564 [11:25:48] (PS4) Rillke: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 [11:28:51] (CR) Rillke: "(1 comment)" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke) [11:52:13] (CR) Zfilipin: "Scenario fails for me (Mac, Firefox, en.wikipedia.beta.wmflabs.org):" [qa/browsertests] - https://gerrit.wikimedia.org/r/75328 (owner: Amire80) [11:52:53] (PS1) Lewis Cawte: Push version 0.3.3 upstream from ShoutWiki's repository. [extensions/ShoutWikiAds] - https://gerrit.wikimedia.org/r/75577 [11:53:55] (PS1) TTO: (bug 51934) remove redundant namespaceAliases for Tagalog [core] - https://gerrit.wikimedia.org/r/75578 [11:54:49] (CR) Zfilipin: [C: -1] "Should the user be configured? I am running the test as "Selenium user"." [qa/browsertests] - https://gerrit.wikimedia.org/r/75328 (owner: Amire80) [11:56:35] (CR) Jack Phoenix: [C: 2 V: 2] Push version 0.3.3 upstream from ShoutWiki's repository. [extensions/ShoutWikiAds] - https://gerrit.wikimedia.org/r/75577 (owner: Lewis Cawte) [11:56:36] (Merged) Jack Phoenix: Push version 0.3.3 upstream from ShoutWiki's repository. [extensions/ShoutWikiAds] - https://gerrit.wikimedia.org/r/75577 (owner: Lewis Cawte) [12:04:35] (PS1) Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - https://gerrit.wikimedia.org/r/75579 [12:05:07] (CR) jenkins-bot: [V: -1] Enhanced RC: Add a "view changes since my last visit" link [core] - https://gerrit.wikimedia.org/r/75579 (owner: Matmarex) [12:07:46] (PS2) Matmarex: Enhanced RC: Add a "view changes since my last visit" link [core] - https://gerrit.wikimedia.org/r/75579 [12:10:11] (PS1) Njw: Fix overlap of headings and table for Special:SpecialPages [skins/erudite] - https://gerrit.wikimedia.org/r/75580 [12:11:06] (CR) Matmarex: [C: 2] Remove override of skin behaviour for inline anchor's text-decoration [extensions/Echo] - https://gerrit.wikimedia.org/r/74374 (owner: Krinkle) [12:11:13] (Merged) jenkins-bot: Remove override of skin behaviour for inline anchor's text-decoration [extensions/Echo] - https://gerrit.wikimedia.org/r/74374 (owner: Krinkle) [12:19:43] (CR) Matmarex: [C: 2] Move firing of "wikipage.content" mw.hook out of mediawiki.util [core] - https://gerrit.wikimedia.org/r/74312 (owner: Krinkle) [12:21:22] hoo: you there? [12:21:55] hoo: can you look at https://gerrit.wikimedia.org/r/#/c/36391/ ? there's a disagreement and i'm looking for someone toweigh in :) [12:22:00] yooooohoooooooo [12:22:17] (Merged) jenkins-bot: Move firing of "wikipage.content" mw.hook out of mediawiki.util [core] - https://gerrit.wikimedia.org/r/74312 (owner: Krinkle) [12:25:08] * hoo looks :D [12:25:14] (PS1) Santhosh: Lazy initialization of language settings and ULS from interface triggers [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75582 [12:26:55] Reedy: and you could totally look at https://gerrit.wikimedia.org/r/#/c/64565/ . just let me rebase the release notes [12:28:53] (PS15) Matmarex: Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565 [12:29:56] (CR) Matmarex: "Rebased." [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex) [12:40:21] MatmaRex: What do other mediawiki.language methods return? [12:41:26] hoo: what methods? :D [12:41:35] there is nothing similar t othis incore yet afaik [12:41:52] language only has some Language.php-like methods [12:41:57] I thought so as well... just .numbers and stuff [12:56:25] (CR) Dalba: [C: 1] "It's been tested since Nov. 26, 2012 using a change in local common.css [http://goo.gl/QFXUxf] and there have been no complaints about it." [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [13:13:51] (PS3) Zfilipin: WIP Test central-domain login, cross-domain login and central login for anons [qa/browsertests] - https://gerrit.wikimedia.org/r/74128 [13:42:16] (CR) Yuvipanda: "Y U NO USE LOGSTASH" [tools/fluoride] - https://gerrit.wikimedia.org/r/75560 (owner: Ori.livneh) [13:48:28] (PS1) Rillke: Do not pre-fill longitude and latitude inputs with 0 values [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 [13:50:42] (PS2) Rillke: Do not pre-fill longitude and latitude inputs with 0 values [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 [13:52:44] (PS3) Rillke: Do not pre-fill longitude and latitude inputs with 0 values [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 [13:53:35] MatmaRex: I think you pinged me on IRC before, but I lost scrollback. [13:54:16] Nikerabbit: meeting in 30 [13:54:17] hi ori-l [13:54:18] err [13:54:19] orsa: [13:54:36] YuviNoPower: Hi [13:54:36] YuviNoPower: hm [13:54:47] * YuviPanda has power back [13:54:50] YuviNoPower: maybe when i complained about grrrit-wm yesterday [13:54:52] orsa: :) Exams, etc over? [13:54:56] MatmaRex: ah, what was it doing? [13:55:10] that it reports outdated commit message summary if the lastest patchset changes it [13:55:17] latest* [13:55:19] YuviPanda: indeed.. :) [13:55:28] orsa: \o/ nice. Time to get coding, I think :) [13:55:47] YuviPanda: sure! we have a meeting today [13:55:50] orsa: yeah [13:55:58] YuviPanda: in 30 mins, right? [13:55:59] Nikerabbit is on vacation, not sure if he's going to come [13:56:03] orsa: 34 minutes, yeah [13:57:10] YuviPanda: see ya [13:57:14] ok :) [14:01:03] (CR) ZxxZxxZ: [C: 1] Opt-out Persian from links underline removal [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [14:08:04] (PS1) Rillke: Default value for lon and lat from 0 to empty String [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75597 [14:19:30] (CR) Matmarex: "Can you link the discussion for posterity?" [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [14:20:33] (CR) Yuvipanda: [C: 1] "Hello! This looks good, but can you split them into two patches - one with the lat/lon stuff and one with everything else? Easier to merge" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 (owner: Rillke) [14:20:44] MatmaRex: hmm, I just report whatever Gerrit tells me [14:21:02] YuviPanda: hm. [14:22:30] MatmaRex: you can run 'ssh gerrit.wikimedia.org -p29418 gerrit stream-events' from your commandline to see the data [14:30:39] * YuviPanda pokes orsa [14:38:21] (CR) Ebrahim: "http://fa.wikipedia.org/wiki/%D8%A8%D8%AD%D8%AB_%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Common.css#.D8.B2.DB.8C.D8.B1.D8.AE.D8.B7" [core] - https://gerrit.wikimedia.org/r/75570 (owner: Ebrahim) [14:38:36] (CR) Rillke: "We would get rid of the symptoms if" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 (owner: Rillke) [14:38:40] (PS1) Siebrand: Remove namespace aliases identical to namespace names [core] - https://gerrit.wikimedia.org/r/75603 [14:39:40] (PS2) Siebrand: (bug 51934) remove redundant namespaceAliases for Tagalog [core] - https://gerrit.wikimedia.org/r/75578 (owner: TTO) [14:39:52] (CR) Siebrand: [C: 2] Remove redundant namespaceAliases [core] - https://gerrit.wikimedia.org/r/75578 (owner: TTO) [14:40:07] (Abandoned) Siebrand: Remove namespace aliases identical to namespace names [core] - https://gerrit.wikimedia.org/r/75603 (owner: Siebrand) [14:40:48] hey orsa [14:40:55] orsa: I just remembered, we should put more things on trello [14:40:58] orsa: can we do that now? [14:41:02] no need to get on video call, I think [14:42:55] YuviPanda: ok sure [14:43:40] orsa: can you break down the tasks for this week, until 'login demonstration', and put them in the list/ [14:43:44] 'To Do' list [14:44:15] YuviPanda: ok, im on it! [14:44:32] (PS2) Hashar: experimental HTLM console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 [14:45:44] (Merged) jenkins-bot: Remove redundant namespaceAliases [core] - https://gerrit.wikimedia.org/r/75578 (owner: TTO) [14:50:10] (CR) Yuvipanda: "Just split lines 157-160 into a separate patch - since that'll fix the actual problem on Commons right now." [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 (owner: Rillke) [14:51:58] moauahah https://integration.wikimedia.org/logs/12/74312,5/mediawiki-core-regression-phpcs-HEAD-1447/console.html :D [14:52:06] how to get rid of jenkins [14:52:11] sort of [14:52:14] Reedy: can you +2 https://gerrit.wikimedia.org/r/#/c/75602/ [14:52:29] (PS5) J: add unique constraint on transcode name, key [extensions/TimedMediaHandler] - https://gerrit.wikimedia.org/r/57536 [14:53:29] (CR) Yuvipanda: "Testing..." [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75597 (owner: Rillke) [15:00:35] (PS1) Hashar: logs dir to host Jenkins console outputs [integration/docroot] - https://gerrit.wikimedia.org/r/75609 [15:01:10] (CR) Hashar: [C: 2] "related puppet change is https://gerrit.wikimedia.org/r/#/c/75608/" [integration/docroot] - https://gerrit.wikimedia.org/r/75609 (owner: Hashar) [15:01:12] (Merged) jenkins-bot: logs dir to host Jenkins console outputs [integration/docroot] - https://gerrit.wikimedia.org/r/75609 (owner: Hashar) [15:05:38] (PS3) Hashar: experimental HTLM console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 [15:07:12] (CR) Hashar: [C: -1] "I should make that a standalone script. Would be easier to amend if needed." [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 (owner: Hashar) [15:08:59] (PS1) Catrope: mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75611 [15:10:35] (PS1) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75612 [15:10:36] (PS1) Catrope: Pass through request parameters in API action=edit [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75613 [15:12:31] (PS1) Catrope: mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75614 [15:12:34] (PS1) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75615 [15:12:35] (PS1) Catrope: Pass through request parameters in API action=edit [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75616 [15:19:03] YuviPanda: What do you think this is!? [15:19:35] hmm? [15:19:35] (CR) Rillke: "Yes, but I renamed latInput to $latInput, won't this throw a conflict?" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75595 (owner: Rillke) [15:20:38] (PS1) Catrope: Create wmf/1.22wmf10 branch [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75618 [15:21:03] Reedy: ty [15:22:15] RoanKattouw: for like, 24 hours? ;) [15:22:32] (PS1) Catrope: Create wmf/1.22wmf11 branch [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75619 [15:22:43] Reedy: :) [15:22:55] I didnt' really want to update FR to master [15:23:01] I'm already deploying a ton of code [15:25:47] (PS1) Catrope: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75620 [15:25:48] (PS1) Catrope: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75621 [15:26:29] (PS1) Catrope: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75622 [15:26:30] (PS1) Catrope: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75623 [15:28:17] (CR) Catrope: [C: 2 V: 2] mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75611 (owner: Catrope) [15:28:18] (Merged) Catrope: mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75611 (owner: Catrope) [15:28:44] (CR) Catrope: [C: 2 V: 2] Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75612 (owner: Catrope) [15:28:45] (Merged) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75612 (owner: Catrope) [15:29:18] orsa: you should move the cards you've finished to the 'done' list, and move the ones you are currently working on to the 'doing' [15:29:21] you can click and drag them [15:29:23] (CR) Catrope: [C: 2 V: 2] Pass through request parameters in API action=edit [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75613 (owner: Catrope) [15:29:24] (Merged) Catrope: Pass through request parameters in API action=edit [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75613 (owner: Catrope) [15:29:56] YuviPanda: I will [15:30:01] orsa: :) [15:30:09] (CR) Catrope: [C: 2 V: 2] mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75614 (owner: Catrope) [15:30:16] (Merged) Catrope: mediawiki.notification: Make notification area sticky to window [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75614 (owner: Catrope) [15:33:10] (CR) Catrope: [C: 2] Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75615 (owner: Catrope) [15:33:11] (Merged) Catrope: Add a hook to Title::getEditNotices() so extensions can add them [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75615 (owner: Catrope) [15:33:12] (CR) Anomie: "(1 comment)" [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/71537 (owner: Anomie) [15:33:32] (CR) Catrope: [C: 2 V: 2] Pass through request parameters in API action=edit [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75616 (owner: Catrope) [15:33:38] (Merged) Catrope: Pass through request parameters in API action=edit [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75616 (owner: Catrope) [15:33:54] (CR) Catrope: [C: 2 V: 2] Create wmf/1.22wmf10 branch [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75618 (owner: Catrope) [15:33:55] (Merged) Catrope: Create wmf/1.22wmf10 branch [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75618 (owner: Catrope) [15:34:08] (CR) Catrope: [C: 2 V: 2] Create wmf/1.22wmf11 branch [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75619 (owner: Catrope) [15:34:09] (Merged) Catrope: Create wmf/1.22wmf11 branch [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75619 (owner: Catrope) [15:34:24] (CR) Catrope: [C: 2 V: 2] Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75620 (owner: Catrope) [15:34:25] (Merged) Catrope: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75620 (owner: Catrope) [15:34:49] (CR) Catrope: [C: 2 V: 2] Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75621 (owner: Catrope) [15:34:53] (Merged) Catrope: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75621 (owner: Catrope) [15:35:36] (CR) Catrope: [C: 2 V: 2] Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75622 (owner: Catrope) [15:35:37] (Merged) Catrope: Expose edit notices so VisualEditor can see them [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75622 (owner: Catrope) [15:38:05] (CR) Catrope: [C: 2 V: 2] Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75623 (owner: Catrope) [15:38:06] (Merged) Catrope: Call ->load() in addReviewCheck() [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75623 (owner: Catrope) [15:39:57] (PS1) Catrope: Update VisualEditor to master [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75626 [15:41:06] (PS3) Anomie: Update protection handling for core change I6bf650a3 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/71537 [15:41:20] (PS4) Anomie: Update protection handling for core change I6bf650a3 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/71537 [15:42:42] (PS1) Catrope: Update FlaggedRevs to the head of its wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75627 [15:43:00] (CR) Kghbln: "Ouch, I should have checked this JS before authoring this change. It is not that I do not know that this does not work. Should'nt this be " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/73571 (owner: Kghbln) [15:44:05] (PS1) Catrope: Update VisualEditor to master [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75629 [15:44:06] (PS1) Catrope: Update FlaggedRevs to the head of its wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75630 [15:47:14] (CR) Catrope: [C: 2 V: 2] Update VisualEditor to master [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75626 (owner: Catrope) [15:47:15] (Merged) Catrope: Update VisualEditor to master [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75626 (owner: Catrope) [15:47:21] (CR) Catrope: [C: 2 V: 2] Update VisualEditor to master [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75629 (owner: Catrope) [15:47:22] (Merged) Catrope: Update VisualEditor to master [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75629 (owner: Catrope) [15:47:29] (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to the head of its wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75630 (owner: Catrope) [15:47:30] (Merged) Catrope: Update FlaggedRevs to the head of its wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75630 (owner: Catrope) [15:47:38] (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to the head of its wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75627 (owner: Catrope) [15:47:39] (Merged) Catrope: Update FlaggedRevs to the head of its wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75627 (owner: Catrope) [15:58:12] (CR) Yaron Koren: "Yes... if I knew how to do that, I would. :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/73571 (owner: Kghbln) [15:58:54] YuviPanda: sorry, forgot it again [15:59:04] Nikerabbit: it's your vacation, you aren't even supposed to be here :) [15:59:25] it's fine, and I didn't invite you either (vacation). orsa's exams are done and he's started working [15:59:52] YuviPanda: yeah it wasnt on my calendar so... [16:00:32] Nikerabbit: see trello, I've asked orsa to fill that up [16:00:46] oki [16:04:22] (CR) Catrope: [C: -1] "We may want to move this to prop=revisions in the light of https://gerrit.wikimedia.org/r/#/c/75536/" [core] - https://gerrit.wikimedia.org/r/74963 (owner: Umherirrender) [16:04:33] (CR) Yuvipanda: "My dev environ is messed up (vagrant grr), will check this right after fixing it." [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75597 (owner: Rillke) [16:06:17] (CR) Catrope: "Code looks OK otherwise" [core] - https://gerrit.wikimedia.org/r/74963 (owner: Umherirrender) [16:25:21] (PS3) Cmcmahon: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088 (owner: Zfilipin) [16:25:29] (CR) Cmcmahon: [C: 2] Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088 (owner: Zfilipin) [16:25:30] (Merged) Cmcmahon: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088 (owner: Zfilipin) [16:26:02] (PS1) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637 [16:31:25] (PS4) Hashar: experimental HTLM console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 [16:32:43] (PS2) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637 [16:33:38] (CR) Hashar: "Made a standalone script with https://gerrit.wikimedia.org/r/#/c/75637/" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 (owner: Hashar) [16:34:00] (PS1) Catrope: Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75638 [16:35:30] (CR) Catrope: [C: 2] Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75638 (owner: Catrope) [16:35:37] (CR) Catrope: [V: 2] Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75638 (owner: Catrope) [16:35:40] (Merged) Catrope: Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75638 (owner: Catrope) [16:35:52] (PS1) Catrope: Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75639 [16:35:58] (CR) Catrope: [C: 2 V: 2] Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75639 (owner: Catrope) [16:35:59] (Merged) Catrope: Update VisualEditor to pick up 98977e02 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75639 (owner: Catrope) [16:40:52] MaxSem: did anyone check your thing? [16:41:38] Nikerabbit, I encountered https://bugzilla.wikimedia.org/show_bug.cgi?id=51956 and bailed out [16:42:08] Abort! [16:43:49] MaxSem: oh curious, can you add the fundraising people to CC in case they have time to look at it before me? [16:44:06] FR? [16:44:29] Yeah they wrote most of the Translate&CentralNotice integration [16:44:51] I haven't seen that error before.. likely I run the scripts before that integration went live [16:46:19] whom exactly? [16:53:41] MaxSem: iirc it was kaldari and mwalker [16:53:49] oh, ok [16:54:16] Can we all agree that http://xkcd.com/1242/ should be an imagemap? [16:55:30] agreed [16:56:27] maybe [16:56:38] Hi ^d. [16:56:46] <^d> Hi [16:56:50] ^d: Thanks for fixing up GitBlit. :-) [16:57:06] <^d> you're welcome :) [16:57:13] ^d: Do you have an idea of how easy it'll be to get that shell script automated for reviewer counts? [16:57:20] Is that a puppet thing? [16:57:30] <^d> Pretty easy. Probably do it as a cron via puppet. [16:59:18] (PS1) Isarra: Bug 27047: COMMONS MAN [core] - https://gerrit.wikimedia.org/r/75641 (via SuchABot) [16:59:23] Isarra: ^ [17:00:28] YuviPanda: Whoo! [17:00:40] Will it crash again if I do that again? [17:01:02] Quick, find me something to change so I can crash it! [17:01:05] Isarra: nope, that should be fixed now. I special cased it [17:01:12] Aww. [17:01:15] * bawolff would argue it should have a more descriptive first line of the commit message :P [17:01:18] What happened? [17:01:38] bawolff: Shuddup I dunno how to use github. >.> [17:01:49] Isarra: *pulling* latest version of mediawiki/core from gerrit caused problems, so I just started pulling from github instead :D [17:01:55] That's ok, me neither [17:01:59] since I only need master this works [17:01:59] fin [17:02:05] I mean, you're right, but I wasn't even sure what I was doing with... well... [17:02:15] YuviPanda: Damn. [17:02:40] (PS1) Krinkle: skins: Make border style of 
 more subtle for common skins [core] - https://gerrit.wikimedia.org/r/75643
[17:03:34] 	 (PS2) Krinkle: skins: Make border style of 
 more subtle for common skins [core] - https://gerrit.wikimedia.org/r/75643
[17:03:42] 	 Isarra: Krinkle also seems to be fixing the same bug? :)
[17:03:43] 	 ^
[17:03:51] 	 >.<
[17:04:01] 	 Isarra: https://bugzilla.wikimedia.org/show_bug.cgi?id=27047#c12
[17:04:02] 	 Krinkle: I just did that. >.>
[17:04:22] 	 Avoiding introduction of new shades of grey
[17:04:46] 	 I didn't see your commit (I saw it in this channel, but the summary didn't seem related :P )
[17:05:16] 	 (PS1) Rjain: Added the permissions plugin [extensions/Annotator] - https://gerrit.wikimedia.org/r/75645
[17:05:20] 	 Yeah, well, I'd like you to come up with a good summary while trying to avoid puking all over your computer.
[17:06:05] 	 (CR) Njw: [C: -1] "(1 comment)" [skins/webplatform] - https://gerrit.wikimedia.org/r/57450 (owner: Haroldherbert)
[17:06:12] 	 I'm not sure what that's supposed to mean, but I guess.. Get well?
[17:07:05] 	 Sorry, I'm just bitter because whenever I try to do something it turns out to be utterly pointless anyone because someone immediately decides to do it better and why do I even bother.
[17:07:13] 	 Or some such.
[17:07:57] 	 It's a good change, at any rate.
[17:08:32] 	 (CR) Matthias Mullie: [C: 2] hook to intercept upload_by_url [core] - https://gerrit.wikimedia.org/r/65102 (owner: Nischayn22)
[17:08:39] 	 Isarra: If it's any consolation, I would've forgotten about that bug if it weren't for your message on the bug
[17:08:56] 	 (CR) jenkins-bot: [V: -1] hook to intercept upload_by_url [core] - https://gerrit.wikimedia.org/r/65102 (owner: Nischayn22)
[17:08:58] 	 (PS1) Orsagi: first code. login skeleton [apps/android/translate] - https://gerrit.wikimedia.org/r/75646
[17:09:13] 	 however I also had a topic branch locally waiting with it from like a year ago (or even before that? I think I had the .patch file from svn even)
[17:09:20] 	 Blame MatmaRex.
[17:09:43] 	 I was surprised that it got reverted, but then I forgot about it.
[17:09:54] 	 I mean, we had it fixed at some point ;P
[17:10:37] 	 (CR) Njw: [C: 1] "I like it :)" [core] - https://gerrit.wikimedia.org/r/75643 (owner: Krinkle)
[17:11:58] 	 (PS10) Matthias Mullie: hook to intercept upload_by_url [core] - https://gerrit.wikimedia.org/r/65102 (owner: Nischayn22)
[17:12:14] 	 (CR) Matthias Mullie: [C: 2] hook to intercept upload_by_url [core] - https://gerrit.wikimedia.org/r/65102 (owner: Nischayn22)
[17:12:32] * legoktm  stabs YuviPanda into reviewing https://gerrit.wikimedia.org/r/#/c/75550/
[17:12:47] 	 you aren't going to set me on fire? :P
[17:12:49] * YuviPanda  clicks
[17:16:20] 	 (Merged) jenkins-bot: hook to intercept upload_by_url [core] - https://gerrit.wikimedia.org/r/65102 (owner: Nischayn22)
[17:17:28] 	 (PS8) Kaldari: Adding hook handler for creating human-friendly relative timestamp [extensions/cldr] - https://gerrit.wikimedia.org/r/45499
[17:18:02] 	 (PS9) Kaldari: Adding hook handler for creating human-friendly relative timestamp [extensions/cldr] - https://gerrit.wikimedia.org/r/45499
[17:18:52] 	 legoktm: on a video call, will look after
[17:19:00] 	 ok thanks
[17:19:02] * legoktm  goes off to https://twitter.com/dentist_visit
[17:19:03] 	 (CR) Kaldari: [C: 1] "Updated the commit message. The hook has been added in core, so this change can be merged now." [extensions/cldr] - https://gerrit.wikimedia.org/r/45499 (owner: Kaldari)
[17:19:37] 	 (CR) Njw: "I certainly agree that something like this would be really useful." [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson)
[17:20:18] 	 (PS1) Catrope: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75648
[17:23:42] 	 (CR) Aaron Schulz: [C: 2 V: 2] Only display edit notices if the page is reviewable [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75648 (owner: Catrope)
[17:23:43] 	 (Merged) Aaron Schulz: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75648 (owner: Catrope)
[17:24:04] 	 AaronSchulz: Thanks man
[17:24:45] 	 I looked at the other changes last night after they were merged...died a little on the inside though it's understandable
[17:24:52] 	 (CR) Demon: [C: -1] "(1 comment)" [extensions/Scribunto] - https://gerrit.wikimedia.org/r/72089 (owner: Anomie)
[17:24:53] 	 Yeah :(
[17:25:00] 	 I, too, died a little on the inside writing that
[17:25:10] 	 I wrote *two* commits that construct fake EditPage instances yesterday
[17:25:14] 	 (another one in a VE API module)
[17:25:49] 	 (PS1) Catrope: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75649
[17:25:54] 	 (CR) Catrope: [C: 2 V: 2] Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75649 (owner: Catrope)
[17:25:55] 	 (Merged) Catrope: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75649 (owner: Catrope)
[17:26:01] 	 (PS1) Catrope: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75650
[17:26:06] 	 (CR) Catrope: [C: 2 V: 2] Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75650 (owner: Catrope)
[17:26:07] 	 (Merged) Catrope: Only display edit notices if the page is reviewable [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75650 (owner: Catrope)
[17:27:59] <^d>	 Elsie: You think we can close out bug 51769 now?
[17:28:00] 	 (PS1) Catrope: Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75651
[17:29:00] 	 (PS1) Catrope: Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75652
[17:29:01] 	 (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75651 (owner: Catrope)
[17:29:02] 	 (Merged) Catrope: Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75651 (owner: Catrope)
[17:29:11] 	 (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75652 (owner: Catrope)
[17:29:12] 	 (Merged) Catrope: Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75652 (owner: Catrope)
[17:30:47] 	 (CR) Aaron Schulz: [C: 1] add unique constraint on transcode name, key [extensions/TimedMediaHandler] - https://gerrit.wikimedia.org/r/57536 (owner: J)
[17:33:53] 	 (PS1) Catrope: Fix fatal in 112d817 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75653
[17:34:03] 	 AaronSchulz: WHOOOPS ---^
[17:34:27] 	 (PS1) Catrope: Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75654
[17:34:36] 	 (PS1) Catrope: Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75655
[17:34:57] 	 (CR) Aaron Schulz: [C: 2 V: 2] Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75654 (owner: Catrope)
[17:34:58] 	 (Merged) Aaron Schulz: Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75654 (owner: Catrope)
[17:35:13] 	 (CR) Catrope: [C: 2 V: 2] Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75655 (owner: Catrope)
[17:35:14] 	 (Merged) Catrope: Fix fatal in 112d817 [extensions/FlaggedRevs] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75655 (owner: Catrope)
[17:35:45] 	 (CR) Catrope: [C: 2] "Merging as Aaron +2ed https://gerrit.wikimedia.org/r/75654" [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75653 (owner: Catrope)
[17:36:00] 	 ^d: re: bug 51769, I'm not sure.
[17:36:31] 	 ^d: Were there further perf improvements to make?
[17:36:38] 	 ^d: Or a caching layer?
[17:36:38] 	 (PS1) Catrope: Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75656
[17:36:42] <^d>	 I jacked the JVM's heap from 1G to 4G.
[17:36:49] <^d>	 And I enabled browser-side caching of resources.
[17:37:08] 	 (CR) Aaron Schulz: [V: 2] Fix fatal in 112d817 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75653 (owner: Catrope)
[17:37:09] 	 (Merged) Aaron Schulz: Fix fatal in 112d817 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75653 (owner: Catrope)
[17:37:34] 	 (PS1) Catrope: Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75657
[17:37:44] 	 (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75657 (owner: Catrope)
[17:37:45] 	 (Merged) Catrope: Update FlaggedRevs to head of wmf/1.22wmf10 branch [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75657 (owner: Catrope)
[17:37:54] 	 (CR) Catrope: [C: 2 V: 2] Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75656 (owner: Catrope)
[17:37:55] 	 hmm, should I hide MERGED messages for non jenkins-bot users?
[17:37:55] 	 (Merged) Catrope: Update FlaggedRevs to head of wmf/1.22wmf11 branch [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75656 (owner: Catrope)
[17:38:03] 	 since they'll have an immediate CR +2 right before
[17:38:08] 	 ^d: ^
[17:38:17] <^d>	 That's why I hid +2 with no comments before.
[17:38:39] 	 so... I'll hide jenkins bots merges
[17:38:42] * YuviPanda  makes it
[17:38:42] 	 so
[17:38:46] 	 I still get like 13s response times, but gitblit isn't down.
[17:38:50] 	 I've marked the bug resolved/fixed.
[17:39:02] 	 13s is better than 13m, at least. ;-)
[17:39:32] <^d>	 Elsie: Maybe about 3-5s for me for the main page (which has always been slow, it has a ton of data to load). Other pages seem pretty snappy.
[17:39:39] <^d>	 (For me, at least)
[17:40:18] 	 MatmaRex: https://en.wikipedia.org/wiki/MediaWiki_talk:Geshi.css#Remove_superfluous_code where in core can I find that code?
[17:40:34] 	 We should remove it from there, GeSHi specific code shouldn't be in core ...
[17:41:23] 	 ^d: Yeah.
[17:41:27] 	 hoo: it's for "pre, .mw-code" in commonElements
[17:41:44] 	 hoo: so that is superfluous, even though it uses a different selector
[17:42:17] 	 i wanted to avoid explaining the details :D
[17:52:03] 	 MatmaRex: Did it now ;)
[17:55:59] 	 hoo: hey, thanks
[17:56:16] 	 (PS1) Krinkle: (DRAFT) mw notif offset race condition [core] - https://gerrit.wikimedia.org/r/75662
[17:57:24] 	 (PS1) Nilesh: Fixed a few small errors in docs [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75663
[17:59:23] 	 (CR) Catrope: [C: 2] (DRAFT) mw notif offset race condition [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[17:59:38] 	 (PS1) Catrope: (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75664
[17:59:49] 	 RoanKattouw: Undid your CR2 as the commit is in draft and has a horrible message
[18:00:29] 	 (PS1) Catrope: (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75666
[18:00:36] 	 (CR) Catrope: [C: 2 V: 2] (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75666 (owner: Catrope)
[18:00:37] 	 (Merged) Catrope: (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75666 (owner: Catrope)
[18:00:46] 	 give me a second
[18:00:50] 	 (CR) Catrope: [C: 2 V: 2] (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75664 (owner: Catrope)
[18:00:51] 	 (Merged) Catrope: (DRAFT) mw notif offset race condition [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75664 (owner: Catrope)
[18:00:58] 	 Krinkle: OK
[18:01:05] 	 Sorry :(
[18:01:07] 	 heh, draft
[18:01:09] 	 Is the code fine, though
[18:01:10] 	 :D
[18:01:17] 	 (PS2) Krinkle: (DRAFT) mw notif offset race condition [core] - https://gerrit.wikimedia.org/r/75662
[18:01:19] 	 Since I just ... cherry-picked it into wmf
[18:01:32] 	 RoanKattouw: Go ahead :) https://gerrit.wikimedia.org/r/#/c/75662/2,publish
[18:01:45] 	 (CR) Catrope: [C: 2] mw.notification: Fix incorrect initial offset [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[18:01:47] 	 oh god, that link doesn't work directly
[18:01:50] 	 only when getting there through js
[18:01:52] 	 crap gerrit
[18:06:10] 	 (PS3) Matmarex: mw.notification: Fix incorrect initial offset [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[18:06:39] 	 (CR) Matmarex: [C: 2] "Three times the charm :)" [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[18:07:20] 	 MatmaRex: that bug is unrelated sort of, this fixes a different bug.
[18:07:32] 	 The way it is in master without this patch solved that bug, it is visible during scrolling, always
[18:07:45] 	 Krinkle: it was reported there
[18:07:56] 	 and it's a followup to a fix of that bug
[18:08:02] 	 makes sense to mention it, no?
[18:08:27] 	 I'd do it in one-direction only, not from the commit. It alreadt mentions the commit it fixes up
[18:08:44] 	 feel free to undo. :)
[18:08:55] 	 before jenkins is finished
[18:08:56] 	 (PS4) Krinkle: mw.notification: Fix incorrect initial offset [core] - https://gerrit.wikimedia.org/r/75662
[18:09:06] 	 meeting
[18:09:35] 	 (CR) Matmarex: [C: 2] "Okay." [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[18:10:31] 	 (CR) MarkTraceur: "I guess at least one alternative would be for me to split up the HTML generation to multiple functions and subclass to an HTMLAgoraCheckFi" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[18:16:20] 	 (Merged) jenkins-bot: mw.notification: Fix incorrect initial offset [core] - https://gerrit.wikimedia.org/r/75662 (owner: Krinkle)
[18:18:30] 	 (CR) Siebrand: "Should we just merge this, or will this be reviewed?" [apps/android/translate] - https://gerrit.wikimedia.org/r/75646 (owner: Orsagi)
[18:20:35] 	 (CR) Orsagi: [C: 2 V: 2] first code. login skeleton [apps/android/translate] - https://gerrit.wikimedia.org/r/75646 (owner: Orsagi)
[18:20:36] 	 (Merged) Orsagi: first code. login skeleton [apps/android/translate] - https://gerrit.wikimedia.org/r/75646 (owner: Orsagi)
[18:24:34] 	 (CR) Hashar: "(2 comments)" [integration/docroot] - https://gerrit.wikimedia.org/r/75364 (owner: Krinkle)
[18:28:55] 	 (PS1) Umherirrender: Add class to stabilization link [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/75669
[18:29:10] 	 (PS1) Yuvipanda: Update Support SDK to v18 [apps/android/commons] - https://gerrit.wikimedia.org/r/75670 (via SuchABot)
[18:29:53] 	 (CR) Aaron Schulz: [C: 2 V: 2] Add 2 new hooks to fix mobile logins [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75154 (owner: MaxSem)
[18:29:54] 	 (Merged) Aaron Schulz: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75154 (owner: MaxSem)
[18:32:08] 	 @notify hashar
[18:32:08] 	 I'll let you know when I see hashar around here
[18:33:53] 	 (PS1) Matmarex: jquery.tablesorter: buildCollationTable() on first sort, not on load [core] - https://gerrit.wikimedia.org/r/75671
[18:37:09] 	 (CR) Krinkle: [C: -1] "Will test soon, however I have a bad feeling about this." [core] - https://gerrit.wikimedia.org/r/75671 (owner: Matmarex)
[18:40:07] 	 (CR) Matmarex: "Well, I guess *technically* somebody still could try sorting the table at just the wrong time. I don't think we should worry about this, e" [core] - https://gerrit.wikimedia.org/r/75671 (owner: Matmarex)
[18:41:19] 	 (CR) Brion VIBBER: [C: 2 V: 2] "Still builds!" [apps/android/commons] - https://gerrit.wikimedia.org/r/75670 (owner: SuchABot)
[18:41:20] 	 (Merged) Brion VIBBER: Update Support SDK to v18 [apps/android/commons] - https://gerrit.wikimedia.org/r/75670 (owner: SuchABot)
[18:48:34] 	 (CR) Matthias Mullie: [C: 2] Update email copy text [extensions/PageTriage] - https://gerrit.wikimedia.org/r/75408 (owner: Bsitu)
[18:48:45] 	 (Merged) jenkins-bot: Update email copy text [extensions/PageTriage] - https://gerrit.wikimedia.org/r/75408 (owner: Bsitu)
[18:53:22] 	 (CR) Edokter: [C: 1] "Looks good. On a personal note, I would decrease the padding to 0.5em." [core] - https://gerrit.wikimedia.org/r/75643 (owner: Krinkle)
[19:00:02] 	 (PS1) Catrope: Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75673
[19:00:55] 	 (CR) Catrope: [C: 2 V: 2] Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75673 (owner: Catrope)
[19:00:56] 	 (Merged) Catrope: Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75673 (owner: Catrope)
[19:01:01] 	 (PS1) Catrope: Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75675
[19:01:08] 	 (CR) Catrope: [C: 2 V: 2] Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75675 (owner: Catrope)
[19:01:09] 	 (Merged) Catrope: Update VisualEditor to master to pick up 81d3bde4405 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75675 (owner: Catrope)
[19:02:11] 	 (CR) Anomie: "(1 comment)" [extensions/Scribunto] - https://gerrit.wikimedia.org/r/72089 (owner: Anomie)
[19:02:19] 	 (PS2) Anomie: Improve disable_functions handling in LuaStandalone [extensions/Scribunto] - https://gerrit.wikimedia.org/r/72089
[19:06:00] 	 (CR) Matmarex: "This fixed bug 45316." [core] - https://gerrit.wikimedia.org/r/44260 (owner: Anomie)
[19:15:23] 	 (PS1) Amire80: Add a request to write the browser to feedback-bugornote [core] - https://gerrit.wikimedia.org/r/75678
[19:18:55] 	 mwalker, Hey! are you around?
[19:19:23] 	 yep!
[19:19:25] 	 what's up?
[19:20:16] 	 (CR) Ori.livneh: [C: 2] Use PHP's built-in class_exists instead of MWInit::classExists [extensions/ConfirmEdit] - https://gerrit.wikimedia.org/r/75557 (owner: Legoktm)
[19:20:18] 	 (Merged) jenkins-bot: Use PHP's built-in class_exists instead of MWInit::classExists [extensions/ConfirmEdit] - https://gerrit.wikimedia.org/r/75557 (owner: Legoktm)
[19:22:55] 	 mwalker, I sent you an email now, want you to see
[19:22:55] 	 ^d: grrrit-wm updated to ignore Merges from non-jenkins-bot people.
[19:23:20] 	 mwalker, about midterms
[19:23:57] * mwalker  reads
[19:25:52] 	 (CR) Ori.livneh: [C: -1] "(2 comments)" [extensions/GuidedTour/guiders] - https://gerrit.wikimedia.org/r/74820 (owner: Mattflaschen)
[19:27:34] 	 (CR) Ori.livneh: "> Y U NO USE LOGSTASH" [tools/fluoride] - https://gerrit.wikimedia.org/r/75560 (owner: Ori.livneh)
[19:28:39] 	 (CR) Yuvipanda: "Take the fatals / exceptions and put them into LogStash, instead of Mongo?" [tools/fluoride] - https://gerrit.wikimedia.org/r/75560 (owner: Ori.livneh)
[19:30:26] 	 (CR) Ori.livneh: "> Take the fatals / exceptions and put them into LogStash, instead of Mongo?" [tools/fluoride] - https://gerrit.wikimedia.org/r/75560 (owner: Ori.livneh)
[19:31:26] 	 ori-l: YuviPanda: do we even have logstash ?
[19:31:45] 	 well, we don't :P
[19:31:53] 	 but it's built for this, unlike Mongo...
[19:32:00] 	 so mongoDB/ redis /mysql whatever :]
[19:32:07] 	 'store and let people run queries on errors' *is* logstash's use case
[19:32:18] 	 well, i freely admit that mongo isn't a principled choice here
[19:32:33] 	 more of a 'need to shove data somewhere, what do i have laying around?'
[19:32:43] 	 but it'd help if you'd explain the actual things logstash lets you do
[19:32:53] 	 sure!
[19:33:08] 	 the basic idea is you feed logs into logstash from various sources, and tell it what format they are in
[19:33:30] 	 then it feeds them into elastic search, and has a nice clean GUI interface where people can perform complex queries
[19:34:01] 	 it's sortof like spleunk, the closed-source logging tool, except open source.
[19:34:01] 	 http://logstash.net/
[19:34:11] 	 http://logstash.net/docs/1.1.13/inputs/udp
[19:34:12] 	 sold
[19:34:31] 	 :D
[19:34:33] 	 \o/
[19:34:52] 	 (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/72259 (owner: TheDJ)
[19:34:54] 	 it outputs to mongodb too, if you want
[19:35:16] 	 well, i figured it's easier to build something out that's basic just to demonstrate value
[19:35:23] 	 and then ask for packaging / deployment help
[19:35:24] 	 elastic search is 'reccomended output', however
[19:35:24] 	 http://logstash.net/docs/1.1.13/outputs/elasticsearch
[19:35:32] 	 rather than just send ops a shopping list of stuff
[19:35:32] 	 right
[19:35:38] 	 so mongodb would be a good start
[19:35:42] 	 so i don't think it's toooooo important where this goes initially
[19:35:43] 	 we can pipe it to elasticsearch later
[19:35:58] 	 indeed
[19:36:15] 	 also I was wrong - it doesnt' do graphs by tiself but can integrate with graphite/ganglie
[19:36:46] 	 https://getsentry.com/welcome/ looks cool too
[19:37:09] 	 ori-l: yeah, there's also greylog
[19:37:26] 	 but that's elsewhere on the spectrum
[19:37:54] 	 the thing with logstash and greylog is that they seem better suited to logs that are generated continuously at large volume
[19:38:07] 	 ori-l: well, getsentry also says 'To start, you'll want to signup for a subscription on getsentry.com.'
[19:38:10] 	 which... is.. ugh?
[19:38:17] 	 YuviPanda: it's on github
[19:38:22] 	 so generic individual datapoints aren't as interesting as trends or anomalies
[19:38:43] 	 but exceptions should be.. exceptional!:)
[19:38:45] 	 :)
[19:39:01] 	 openstack has a public logstash installation at http://logstash.openstack.org/
[19:39:23] 	 yeah, openstack / Ryan_Lane is where I got logstash from
[19:39:35] 	 that's the logstash web gui, I think?
[19:39:54] 	 meantime, I am going to extract the Jenkins console logs to some good old plain files
[19:40:32] 	 grep™
[19:41:10] 	 I wrote an ugly python script to curl the console logs :D
[19:44:37] 	 ori-l: I think anaother advantage is that we avoid NIHness :)
[19:44:53] 	 (PS3) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637
[19:46:10] 	 (CR) Anomie: "(3 comments)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie)
[19:47:08] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75679
[19:48:19] 	 hashar: i like requests too, but it's not worth adding an external dependency for something as simple as this. just import urllib2 and return urllib2.urlopen(url_console).read()
[19:48:47] * YuviPanda  murmurs something about virtualenv, then wanders away
[19:48:53] 	 ori-l: requests for the win :D
[19:49:03] 	 r.get( http://foo )
[19:49:05] 	 +1, let's add it to everywhere!
[19:49:10] 	 you can't be that simplicity :-
[19:49:11] 	 )
[19:49:27] 	 and I got high karma with ops, so I should get it installed on my boxes :-]
[19:50:14] 	 (PS1) MaxSem: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75680
[19:50:29] 	 YuviPanda: https://github.com/wikimedia/mediawiki-core/pull/3#issuecomment-21499063 that error seems reoccurring (second time now)
[19:50:38] 	 though it seems to work fine
[19:50:51] 	 hashar: https://github.com/kennethreitz/requests/blame/master/AUTHORS.rst#L69
[19:51:03] 	 Krinkle: yeah, it worked fine 'coz it pinged me and i logged into toollabs and kicked it :)
[19:51:26] 	 YuviPanda: Interesting, your bot also ensures the Change-Id, so users don't even need the precommit hook, right?
[19:51:26] 	 Krinkle: problem is that core is apparently causing git to use a lot of memory, and it gets killed by SGE
[19:51:39] 	 aha
[19:51:40] 	 Krinkle: indeed
[19:51:40] 	 ori-l: :-]]]]]]]
[19:51:50] 	 ori-l: \o/
[19:52:11] 	 YuviPanda: It does do squash, right (It should imho, just checking)
[19:52:16] 	 Krinkle: yes, it does squash
[19:52:20] 	 i'd still use urllib2 (or urllib.request for py3) for something like this, but your call
[19:52:33] 	 YuviPanda: what about commit message? first one, last one, all of them, or the PR message ?
[19:52:35] 	 Krinkle: and keeps the base correct to where the pullrequest was started from (no automatic rebasing to new commits)
[19:52:38] 	 Krinkle: just PR message
[19:52:52] 	 Krinkle: I used to include PR message + all commit messages but that was just... messy
[19:53:17] 	 YuviPanda: That's recent though right? I recall just a little while ago it appeared to implicitly rebase each time a commit was added, making it hard to review on gerrit
[19:53:30] 	 Krinkle: no, it doesn't? that's been there from the beginning
[19:53:41] 	 Hm.. maybe double check sometime in a test repo.
[19:53:56] 	 Krinkle: if I rebase and force push to github, then yeah, it also does a rebase
[19:53:57] 	 else not
[19:54:00] 	 e.g. new PR, then merge something else, add a commit to the PR and see what happens
[19:54:02] 	 Krinkle: it squashes on everything, though
[19:54:17] 	 but the parent of that squash is the parent of the first commit, not latest master
[19:54:23] 	 Krinkle: github api gives me the 'parent commit' of the  pull request
[19:54:24] 	 yes
[19:54:28] 	 as it should be
[19:54:31] 	 I base it on top of that, than master.
[19:54:32] 	 OK
[19:54:40] 	 YuviPanda: Uh?
[19:54:42] 	 Why
[19:54:50] 	 ? because otherwise it'll be rebasing?
[19:54:58] 	 (CR) Parent5446: [C: 2] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[19:54:58] 	  but the parent of that squash is the parent of the first commit, not latest master
[19:55:00] 	 is correct
[19:55:01] 	 "than master"
[19:55:14] 	 you "rather than"?
[19:55:24] 	 (instead of)
[19:55:24] 	 (CR) jenkins-bot: [V: -1] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[19:55:27] 	 Krinkle: indeed.
[19:55:29] 	 I thought you said it does both
[19:55:30] 	 OK
[19:55:37] 	 Krinkle: you are looking for the word 'then' :)
[19:55:41] 	 (PS3) Mattflaschen: Document additional methods [extensions/GuidedTour/guiders] - https://gerrit.wikimedia.org/r/73141
[19:55:42] 	 'than' means 'rather than' :)
[19:55:48] 	 'then' means 'after' / 'and'
[19:56:01] 	 yeah, but afaik you can't use 'than' standalone to mean 'rather than'. without rather it looks like a typo of then.
[19:56:04] 	 (CR) Mattflaschen: "(6 comments)" [extensions/GuidedTour/guiders] - https://gerrit.wikimedia.org/r/73141 (owner: Mattflaschen)
[19:56:21] 	 really? I've been using that, and hearing that used for a long time
[19:56:30] 	 I might be wrong, of course.
[19:56:39] 	 Same here
[19:57:01] 	 hehe
[19:57:06] 	 Krinkle: but yeah, it does 'the right thing'
[19:57:12] 	 anyway, it seemed to cause an unwanted rebase in between. Could be that the user rebased on github and force-pushed there.
[19:57:14] 	 e.g. new PR, then merge something else, add a commit to the PR and see what happens
[19:57:20] 	 Krinkle: where exactly?
[19:57:29] 	 If you have some time, maybe verify it. Or if you know for sure, nevermind :)
[19:57:31] 	 Krinkle: it shouldn't, really. When I was doing that marathon Upload Wizard commit
[19:57:33] 	 I don't recall where.
[19:57:37] 	 it wasn't rebasing
[19:57:46] 	 because a bunch of patches got merged in the meantime
[19:57:48] 	 I'll let you know if I see it again
[19:57:59] 	 Krinkle: please do. It's explicitly not supposed to do that :)
[19:59:49] 	 (PS5) Hashar: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911
[20:00:05] 	 (CR) Hashar: "rebased (conflict in release notes)" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:00:30] 	 Krinkle: I'm hoping to get it completely stable (and two way!) before wikimania, and then try to get more people to use it :)
[20:00:30] 	 I've been sending all my patches through it for the last month or so
[20:00:38] 	 (CR) Parent5446: [C: 2] Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:00:52] 	 hashar: ping
[20:01:30] 	 (CR) Parent5446: [C: -1] "Merge conflict" [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:01:40] 	 YuviPanda: Perhaps you could improve the style of the comments. The plain text way it is right now makes it somewhat confusing (especially when the comment itself also contains references to other usernames and what they said)
[20:01:53] 	 perhaps make use of the fact that github allows 
 and other markup
[20:02:02] 	 (CR) MaxSem: [C: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75679 (owner: MaxSem)
[20:02:03] 	 Krinkle: ah, right. That makes sense.
[20:02:19] 	 Krinkle: I should also kill jenkins-bot spam
[20:02:21] 	 e.g. like * User said on .. * (italic): \n\n 
 comment 

[20:02:22] 	 (CR) Matmarex: "Oh come on, I've fixed one today already." [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:02:35] 	 only have it comment if it gives a < 0 V, and let it go otherwise
[20:05:15] 	 (CR) Mwalker: "(2 comments)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524 (owner: Mollywhite)
[20:05:54] 	 (CR) jenkins-bot: [V: -1] Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:06:06] 	 (CR) jenkins-bot: [V: -1] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:06:44] 	 (PS16) Matmarex: Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565
[20:11:27] 	 (CR) Aaron Schulz: "(3 comments)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie)
[20:12:18] 	 (PS4) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637
[20:13:08] 	 (CR) Aaron Schulz: [C: 2] Improve disable_functions handling in LuaStandalone [extensions/Scribunto] - https://gerrit.wikimedia.org/r/72089 (owner: Anomie)
[20:13:25] 	 (CR) Hashar: "* The build URL is unneeded, we can craft it from other parameters" [integration/jenkins] - https://gerrit.wikimedia.org/r/75637 (owner: Hashar)
[20:13:40] 	 (CR) Parent5446: [C: -1] "(2 comments)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/75645 (owner: Rjain)
[20:14:53] 	 (CR) Mwalker: "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite)
[20:16:18] 	 (Merged) jenkins-bot: Improve disable_functions handling in LuaStandalone [extensions/Scribunto] - https://gerrit.wikimedia.org/r/72089 (owner: Anomie)
[20:18:26] 	 (PS5) Hashar: experimental HTLM console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424
[20:18:53] 	 (PS6) Hashar: experimental HTLM console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424
[20:19:49] 	 (PS7) Parent5446: Make maintenance/userOptions.php subclass Maintenance [core] - https://gerrit.wikimedia.org/r/48417
[20:20:09] 	 (PS5) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637
[20:20:15] 	 (PS2) Rachel99: Fscenario visual editor appears if user is logged in (finished) [qa/browsertests] - https://gerrit.wikimedia.org/r/75110
[20:21:18] 	 (CR) Matmarex: "The feedback module can also be used in contexts where the browser doesn't matter, so I'm not sure if it's a good idea to do it like this." [core] - https://gerrit.wikimedia.org/r/75678 (owner: Amire80)
[20:22:07] 	 (PS6) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637
[20:22:10] 	 (PS1) MaxSem: Create branch wmf/1.22wmf10 [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75768
[20:23:09] 	 (PS7) Hashar: experimental HTML console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424
[20:23:22] 	 (PS1) MaxSem: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75769
[20:23:56] 	 (CR) MaxSem: [C: 2] Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75680 (owner: MaxSem)
[20:23:58] 	 (Merged) jenkins-bot: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75680 (owner: MaxSem)
[20:24:07] 	 (PS1) Rahul21: Pronunciation Recording Tool( Not working ) [extensions/PronunciationRecording] - https://gerrit.wikimedia.org/r/75770
[20:24:14] 	 (CR) MaxSem: [C: 2] Create branch wmf/1.22wmf10 [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75768 (owner: MaxSem)
[20:24:16] 	 (Merged) jenkins-bot: Create branch wmf/1.22wmf10 [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75768 (owner: MaxSem)
[20:24:40] 	 (CR) MaxSem: [C: 2] Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75769 (owner: MaxSem)
[20:24:42] 	 (Merged) jenkins-bot: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75769 (owner: MaxSem)
[20:25:51] 	 (PS20) Parent5446: Notify user by email when password changed [core] - https://gerrit.wikimedia.org/r/48578
[20:26:12] 	 (PS1) MaxSem: Update CentralAuth [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75772
[20:26:20] 	 (CR) jenkins-bot: [V: -1] Notify user by email when password changed [core] - https://gerrit.wikimedia.org/r/48578 (owner: Parent5446)
[20:26:21] 	 (PS1) Aaron Schulz: Funnel all central ID <=> name/User lookups through the utils methods [extensions/OAuth] - https://gerrit.wikimedia.org/r/75773
[20:27:09] 	 (CR) Aaron Schulz: "A follow up patch might build on this to use CA global IDs instead of metawiki ones." [extensions/OAuth] - https://gerrit.wikimedia.org/r/75773 (owner: Aaron Schulz)
[20:27:42] 	 (CR) Parent5446: [C: 2] Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:28:43] 	 (PS6) Parent5446: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:29:07] 	 (PS2) Mollywhite: Bug 51258: Add title and alt attributes for icons. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524
[20:30:58] 	 (PS3) Mollywhite: Bug 51258: Add title and alt attributes for icons. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524
[20:31:04] 	 (Merged) jenkins-bot: Refactor watchlist token handling [core] - https://gerrit.wikimedia.org/r/64565 (owner: Matmarex)
[20:31:18] 	 wooo
[20:32:03] 	 (PS1) MaxSem: Update CentralAuth to wmf/1.22wmf11 tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75774
[20:32:18] 	 (CR) MaxSem: [C: 2] Update CentralAuth to wmf/1.22wmf11 tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75774 (owner: MaxSem)
[20:35:44] 	 (CR) Mollywhite: "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite)
[20:36:43] 	 (Merged) jenkins-bot: Update CentralAuth to wmf/1.22wmf11 tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75774 (owner: MaxSem)
[20:36:55] 	 (CR) Parent5446: [C: -1] "I'm so sorry Hashar, but this needs another rebase. XD" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:40:17] 	 (CR) Mattflaschen: [C: -1] "It all looks good, except the upstream auto-generated header is gone (it's useful, since among other things it shows the upstream git comm" [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 (owner: Rjain)
[20:40:57] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75778
[20:41:16] 	 (PS7) Hashar: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911
[20:41:18] 	 (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75778 (owner: MaxSem)
[20:41:32] 	 (CR) MaxSem: [C: 2 V: 2] Update CentralAuth [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75772 (owner: MaxSem)
[20:47:30] 	 (PS2) Ori.livneh: Re-vamp Roles file [vagrant] - https://gerrit.wikimedia.org/r/75069
[20:53:03] 	 (PS3) Karun: MysqlInstaller: use default character set of utf8 [core] - https://gerrit.wikimedia.org/r/67422
[20:53:56] 	 (Abandoned) Rahul21: Pronunciation Recording Tool( Not working ) [extensions/PronunciationRecording] - https://gerrit.wikimedia.org/r/75770 (owner: Rahul21)
[20:54:53] 	 (CR) Mattflaschen: "Haven't tested yet, but looks good. It needs to do some of the same things as destroy, though. See inline." [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 (owner: Rjain)
[20:55:04] 	 (CR) Parent5446: [C: 2] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:57:34] 	 (CR) Mattflaschen: [C: -1] "(2 comments)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 (owner: Rjain)
[20:57:56] 	 (Merged) jenkins-bot: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:58:08] 	 (CR) Cmcmahon: "I think this might have just now caused Bug 51988" [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75772 (owner: MaxSem)
[20:59:58] 	 (CR) Ori.livneh: [C: 2] Re-vamp Roles file [vagrant] - https://gerrit.wikimedia.org/r/75069 (owner: Ori.livneh)
[21:00:00] 	 (Merged) jenkins-bot: Re-vamp Roles file [vagrant] - https://gerrit.wikimedia.org/r/75069 (owner: Ori.livneh)
[21:00:54] 	 (PS1) Bsitu: link-from-page should be linked in html email outputformat [extensions/Echo] - https://gerrit.wikimedia.org/r/75781
[21:01:16] 	 (PS1) Lewis Cawte: Add .gitreview [skins/Nimbus] - https://gerrit.wikimedia.org/r/75782
[21:01:53] 	 (PS2) Bsitu: link-from-page should be linked in html email outputformat [extensions/Echo] - https://gerrit.wikimedia.org/r/75781
[21:03:36] 	 (PS4) Alex Monk: WIP - Special:GroupPermissions (CA-like group editor) [core] - https://gerrit.wikimedia.org/r/74678
[21:03:52] 	 (CR) Alex Monk: "Reverted in I16917a36 as I intend to use it." [core] - https://gerrit.wikimedia.org/r/29467 (owner: Reedy)
[21:04:12] 	 (PS3) Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343
[21:05:01] 	 (PS1) MaxSem: Revert "Add 2 new hooks to fix mobile logins" - test 4 beta [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75783
[21:05:29] 	 (Abandoned) MaxSem: Revert "Add 2 new hooks to fix mobile logins" - test 4 beta [extensions/CentralAuth] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75783 (owner: MaxSem)
[21:06:03] 	 (PS1) MaxSem: temp tevert "Add 2 new hooks to fix mobile logins" - testing [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75784
[21:06:10] 	 (CR) MaxSem: [C: 2] temp tevert "Add 2 new hooks to fix mobile logins" - testing [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75784 (owner: MaxSem)
[21:06:12] 	 (Merged) jenkins-bot: temp tevert "Add 2 new hooks to fix mobile logins" - testing [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75784 (owner: MaxSem)
[21:07:30] 	 (CR) Lewis Cawte: [C: 2 V: 2] Add .gitreview [skins/Nimbus] - https://gerrit.wikimedia.org/r/75782 (owner: Lewis Cawte)
[21:07:40] 	 (PS4) Rahul21: Pronunciation Recording Tool ( Not Working ) [extensions/PronunciationRecording] - https://gerrit.wikimedia.org/r/74413 (owner: Mdale)
[21:08:57] 	 (PS5) Rahul21: Pronunciation Recording Tool ( Not Working ) [extensions/PronunciationRecording] - https://gerrit.wikimedia.org/r/74413 (owner: Mdale)
[21:09:28] 	 (PS19) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821
[21:16:27] 	 http://www.mediawiki.org/wiki/Git/Reviewers?veaction=edit
[21:16:29] 	 man that's slow for me
[21:17:01] 	 (CR) Mwalker: [C: 2] "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite)
[21:17:04] 	 (Merged) jenkins-bot: Cache the JSON blocks using memcached [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74803 (owner: Mollywhite)
[21:17:09] 	 AaronSchulz: That frooze my Firefox...
[21:17:21] 	 (PS3) MarkTraceur: Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[21:18:23] 	 (CR) jenkins-bot: [V: -1] Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[21:18:58] 	 Aw, Jenkins, you ruin all of my fun.
[21:20:24] 	 (PS4) MarkTraceur: Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[21:21:29] 	 (CR) jenkins-bot: [V: -1] Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[21:22:44] 	 MatmaRex: If you held off on https://gerrit.wikimedia.org/r/#/c/74578/ because you changed it, I +1'ed the change.
[21:23:02] 	 (CR) Parent5446: "What needs to happen is that there needs to be a way for the Message class and Status class to work together. Unfortunately, it might take" [core] - https://gerrit.wikimedia.org/r/47821 (owner: Parent5446)
[21:23:59] 	 (PS1) MaxSem: Revert "temp tevert "Add 2 new hooks to fix mobile logins" - testing" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75790
[21:24:06] 	 (CR) MaxSem: [C: 2 V: 2] Revert "temp tevert "Add 2 new hooks to fix mobile logins" - testing" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75790 (owner: MaxSem)
[21:24:19] * AaronSchulz  is baffled by http://www.mediawiki.org/w/index.php?title=Git/Reviewers&diff=745374&oldid=743654
[21:24:32] 	 http://www.mediawiki.org/w/index.php?title=Git%2FReviewers&diff=745374&oldid=688894 suggest some undetected edit conflict
[21:24:47] 	 Krinkle: Is https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/10485/console failing because Jenkins doesn't run database setup before running the tests, or what?
[21:25:03] 	 Krinkle: "I messed with the commit message and it's the larger part of this commit ;), so not merging on principle. Looks trivial, though."
[21:25:20] 	 Maybe I should just catch the error and use zero as the value there.
[21:25:27] 	 (CR) Matmarex: [C: 2] User#getOption: Check ignoreHidden before $wgHiddenPrefs [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle)
[21:25:31] 	 but whatever.
[21:25:35] 	 :)
[21:25:42] 	 k :)
[21:25:54] 	 marktraceur: cheecking
[21:25:58] 	 Thankee :)
[21:27:25] 	 marktraceur: We run phpunit-databaseless before install-sqlite and the other phpunit tests
[21:27:31] 	 (PS20) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821
[21:27:41] 	 So, ah
[21:27:53] 	 (PS5) Alex Monk: WIP - Special:GroupPermissions (CA-like group editor) [core] - https://gerrit.wikimedia.org/r/74678
[21:27:56] 	 marktraceur: Apparently there are not tests in the databaseless group that make mediawiki query the database, which fails if there is no database even set up or mw installed
[21:28:00] 	 now*
[21:28:14] 	 Actually, Krinkle, I'm OK with that part failing the tests since I'm going to split it into a separate commit for testing purposes
[21:28:16] 	 so move the tests out of the databaseless group or fix them to not use the database.
[21:28:20] 	 (Merged) jenkins-bot: User#getOption: Check ignoreHidden before $wgHiddenPrefs [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle)
[21:28:28] * marktraceur  skips away merrily
[21:28:31] 	 (CR) MZMcBride: "Related: https://gerrit.wikimedia.org/r/75641" [core] - https://gerrit.wikimedia.org/r/75643 (owner: Krinkle)
[21:29:09] 	 Isarra: Do you relate to my rationale at https://bugzilla.wikimedia.org/show_bug.cgi?id=27047#c12 ?
[21:29:19] 	 I'd like to close one of the changes that are now fixing the same bug
[21:30:02] 	 (CR) Aaron Schulz: [C: 2 V: 2] Update protection handling for core change I6bf650a3 [extensions/FlaggedRevs] - https://gerrit.wikimedia.org/r/71537 (owner: Anomie)
[21:31:31] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75792
[21:31:42] 	 (PS1) Manybubbles: Add tests for CirrusSearch. [qa/browsertests] - https://gerrit.wikimedia.org/r/75793
[21:31:43] 	 (CR) Mwalker: [C: 2] Bug 51258: Add title and alt attributes for icons. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524 (owner: Mollywhite)
[21:31:50] 	 (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75792 (owner: MaxSem)
[21:32:01] 	 (Merged) jenkins-bot: Bug 51258: Add title and alt attributes for icons. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75524 (owner: Mollywhite)
[21:32:37] 	 (PS5) MarkTraceur: Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[21:32:38] 	 (PS1) MarkTraceur: Add a test for changeset Ifed2860bb7cde7d3a5fc2fba82571a94e13128ba [core] - https://gerrit.wikimedia.org/r/75794
[21:35:34] 	 (CR) jenkins-bot: [V: -1] Add a test for changeset Ifed2860bb7cde7d3a5fc2fba82571a94e13128ba [core] - https://gerrit.wikimedia.org/r/75794 (owner: MarkTraceur)
[21:35:42] 	 Well duh, Jenkins.
[21:36:08] 	 marktraceur: what does "Add a 'feature' field type to HTMLForm" actually do?
[21:36:13] 	 Krinkle: It's sensible, but when applying it to the common css it doesn't really seem doable, since different skins use different shades of grey.
[21:36:23] 	 MatmaRex: Sec, let me give you a sexy screenshot
[21:36:29] 	 Well, maybe just a screenshot
[21:36:54] 	 Isarra: Not really, I thought about this
[21:36:58] 	 Isarra: common !== shared
[21:37:15] 	 You thought about this? Okay.
[21:37:20] 	 Isarra: common is only used by vector and monobook, and even if other skins would use it, the colors I refer to are also defined by common.
[21:37:22] 	 Since I didn't think about this I'll just go away.
[21:37:40] 	 I meant, I encountered this particular thing.
[21:37:58] 	 em on this, not I.
[21:39:18] 	 I'm not sure what you would have me say. I didn't think about it but I happen to know it isn't a problem?
[21:40:03] 	 No, it's fine. The specific colours really don't matter, but if there's reason for others, then use them.
[21:40:14] 	 hm, how does 
 look on cologneblue?
[21:40:38] 	 Sorry, I shouldn't be snapping at you. I'm just having a hard time with things in general and I guess this isn't helping.
[21:40:45] 	 cologneblue doesn't use commmon.
[21:40:56] 	 'tis why i'm wondering.
[21:41:20] 	 Isarra: Will you be in Hong Kong?
[21:41:32] 	 Hah.
[21:41:33] 	 Hah.
[21:41:35] 	 Hah.
[21:41:54] 	 Like I have any money or am worth anything to anyone else.
[21:42:31] 	 ah, it's not styled at all. fair enough
[21:43:09] 	 (CR) Hashar: "Finally! :) Thank you all for the reviews." [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[21:44:50] 	 MatmaRex: http://media.marktraceur.info/u/marktraceur/m/feature-field-in-mediawiki-preferences/
[21:45:16] 	 marktraceur: woot
[21:45:44] 	 interesting
[21:45:46] 	 The live preview example isn't meant to be merged, but useful for testing
[21:46:00] 	 Isarra: If you'd be there (scholarship perhaps?) I'd offer you a drink on me :)
[21:46:16] 	 (CR) MarkTraceur: [C: -2] "This is only a test case for the linked patchset, will be abandoned after it's merged." [core] - https://gerrit.wikimedia.org/r/75794 (owner: MarkTraceur)
[21:46:46] 	 (CR) MarkTraceur: "You can use patchset Idc4a4d262c0c70d78e809c49752fbd051fb8cd2d to test this if you want, or just add your own test case." [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[21:47:43] 	 marktraceur: That looks a lot like what I'm hoping Gadgets v3 will look like
[21:47:46] 	 Isarra: Seconded - if planes ran on beer you'd be halfway there I'm sure
[21:47:56] 	 Krinkle: You could probably use the field type to design it :)
[21:48:05] 	 I'm not worth a scholarship.
[21:48:13] 	 Not worth the beer either.
[21:48:37] 	 Don't think of it as getting a beer. Think of it as the beer getting you.
[21:48:51] 	 (PS4) Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343
[21:49:30] 	 I suppose there's more truth in that than I anticipated.
[21:50:00] 	 marktraceur: Did you design this?
[21:50:18] 	 Ryan_Lane: yo you there?
[21:50:23] 	 yes
[21:50:50] 	 Krinkle: Naw, credit to Jared and May
[21:50:56] 	 Nice
[21:50:58] 	 I'm just the codemonkey
[21:51:49] 	 (PS6) MarkTraceur: Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[21:52:21] 	 marktraceur: https://www.mediawiki.org/wiki/User:Krinkle/Gadgets_3.0 https://addons.mozilla.org/en-US/firefox/search/
[21:52:38] 	 heh, 3.0
[21:53:03] 	 Krinkle: I suspect a large part of their motivation was GMail Labs
[21:53:21] 	 Especially since they (IMO, unknowingly) used the term "WMF Labs" in multiple places
[21:53:32] 	 (CR) Krinkle: "rm s99fef9ea93.png?" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[21:54:23] 	 Krinkle: We generate the files necessary for styling and resources because we don't want to have to have users doing that
[21:54:45] 	 Krinkle: Same reason I checked in the new versions of the generated CSS files as opposed to just adding the scss files
[21:55:20] 	 GorillaWarfare: you seem to be on a roll; but wanted to check in -- things still rolling along merrily?
[21:55:57] 	 mwalker: Things are rolling :) https://meta.wikimedia.org/wiki/Book_management/Bug_priority
[21:56:24] 	 mwalker: About to tackle the wrapped text thing, then hoping to deal with the date localization... somehow
[21:57:08] 	 GorillaWarfare: we have date-formatting functions in core?
[21:57:36] 	 good luck with date formatting!
[21:58:15] 	 (CR) Krinkle: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[21:58:17] 	 GorillaWarfare: you probably want Language#userTimeAndDate
[21:58:42] 	 marktraceur: left a few ideas that may be able to optimise it, I haven't looked further though. so I could be wrong.
[22:00:17] 	 Thankee
[22:00:20] 	 MatmaRex: Thanks, I'll look into that
[22:03:39] 	 (CR) MarkTraceur: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[22:03:48] 	 YuviPanda: Booo, (2 comments)
[22:03:57] 	 Krinkle: I left responses inline
[22:04:26] 	 (PS21) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821
[22:05:38] 	 (PS22) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821
[22:05:49] 	 superm401, if you could chime in on the agora checkbox patch and/or the feature field patch, the Multimedia team would rather like to get those merged this week so we can get Extension:BetaFeatures working by mid-next week
[22:06:02] * marktraceur  CCs bawolff who isn't here
[22:06:17] 	 Curse him for having a life and not having a bouncer
[22:09:25] 	 (CR) Krinkle: "(3 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[22:09:33] 	 Krinkle: Oh, the Gadgets 3.0 thing looks pretty intense. Awesome, but...it looks like there'll be a lot of features we aren't used to in Special:Preferences
[22:09:56] 	 Gadget 3.0 will not be on preferences
[22:20:12] 	 (CR) Bsitu: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74575 (owner: Kaldari)
[22:25:47] 	 marktraceur, I'll look at it again.
[22:26:08] 	 Thanks! I'm just uploading fixes for Krinkle.
[22:26:45] 	 (PS6) MarkTraceur: Implement agora-style checkboxes [core] - https://gerrit.wikimedia.org/r/74662
[22:27:24] 	 (CR) MarkTraceur: "(3 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[22:27:28] 	 (PS5) Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343
[22:31:15] 	 (PS1) Mollywhite: Bug 51196: Fix the appearance of wrapped text in navbar [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75801
[22:32:01] 	 marktraceur: what about s99fef9ea93.png
[22:34:02] 	 Krinkle: It's a generated file, but so are all the CSS files
[22:34:12] 	 Krinkle: I don't want people to have to run compass to run MediaWiki
[22:34:34] 	 marktraceur: What is compass doing to the image file?
[22:34:47] 	 It should just refer to checked.png and keep doing so
[22:34:57] 	 Krinkle: It compiles all the icons (in the first patch, a whopping 1 icons) and puts them in a big png
[22:35:13] 	 Krinkle: See the second patch, where the generated file has three icons
[22:35:21] 	 Sprites are inferior to image embedding, we shouldn't do sprites anymore.
[22:35:27] 	 Welp
[22:35:30] 	 My bad
[22:35:51] 	 That was the only documented way I could find to include images via the SCSS
[22:35:54] 	 But I'll dig moar
[22:35:55] 	 Is this a toggleable feature in compass?
[22:36:02] 	 OK
[22:36:30] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75804
[22:37:06] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75805
[22:37:26] 	 (CR) MaxSem: [C: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75804 (owner: MaxSem)
[22:37:27] * Krinkle  doesn't use compass/scss much. I think it abstracts things too much and generates bad code. The only useful thing it has is variables imho and perhaps abstraction of which vendor prefixes to use, though doing that internally is overrated, we have different browser support than someone else, so it should probably be a local macro not a built-in one.
[22:37:28] 	 Anyway..
[22:37:49] 	 (CR) MaxSem: [C: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75805 (owner: MaxSem)
[22:39:51] 	 Krinkle: I agree, but someone made the decision and I'd rather not screw their stuff up
[22:40:08] 	 (CR) MaxSem: [V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75804 (owner: MaxSem)
[22:40:13] 	 (CR) Raylton P. Sousa: [C: 2 V: 2] Bug 51196: Fix the appearance of wrapped text in navbar [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75801 (owner: Mollywhite)
[22:40:22] 	 (CR) MaxSem: [V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75805 (owner: MaxSem)
[22:40:24] 	 Krinkle: Or rather I'd rather not they screw mine up
[22:40:39] 	 marktraceur: Sure, we can phase that out some other time.
[22:40:44] 	 INdeed
[22:40:49] 	 (Merged) jenkins-bot: Bug 51196: Fix the appearance of wrapped text in navbar [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75801 (owner: Mollywhite)
[22:41:09] 	 marktraceur: However unless we already merged sprites, I'd like to really prevent this, even if it takes some messing with scss to make it happen.
[22:41:58] 	 Krinkle: Yeah, don't worry, they aren't merged
[22:42:04] 	 k :)
[22:42:08] 	 Krinkle: there's a bunch of sprites in core in jquery.ui :(
[22:42:36] 	 resources\jquery.ui\themes\default\images
[22:42:48] 	 vector\images, too.
[22:42:48] 	 Well, that's not our problem, it's jquery's
[22:42:49] 	 Oh wait
[22:43:01] 	 MatmaRex: Are you using...DOS path separators?
[22:43:09] * marktraceur  looks sideways
[22:43:33] 	 marktraceur: i'm not going to change them when copy-pasting, dude. :D
[22:43:47] 	 and yeah, i'm on windows.
[22:43:58] 	 it's bearable when you set up mingw
[22:44:01] * marktraceur  casts smite evil
[22:44:01] 	 siebrand: https://gerrit.wikimedia.org/r/#/c/73713/ rebase man :)
[22:44:37] 	 AaronSchulz: I was thinking of abandoning
[22:45:11] 	 Krinkle: Coincidentally this means I can also use SVG images for the other patch, which is maybe nicer
[22:46:01] 	 (PS7) MarkTraceur: Implement agora-style checkboxes [core] - https://gerrit.wikimedia.org/r/74662
[22:46:33] 	 marktraceur: indeed, upstream libs and a legacy image (vector watch star) are the only two exceptions right now.
[22:46:36] 	 (CR) MarkTraceur: "Deleted the spriting stuff. Pretty useless." [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[22:46:59] 	 Krinkle: Not exactly shining endorsements then
[22:47:03] 	 #vaguepun
[22:47:16] 	 both of which are fairly harmless as they (afaik) don't embed it multiple times but instead use icon-* classes or at least share the image through css inheritance
[22:47:31] 	 instead of referencing the same sprite multiple times by file name
[22:48:33] 	 though even then with embedding it is not terrible as gzip will deduplicate them. Not as efficient as using embedding the way it is supposed to be, but not effectively xN the size either
[22:52:06] 	 (CR) Siebrand: "(1 comment)" [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu)
[22:53:20] 	 (PS1) Mollywhite: Fix bug where cache values were being stored incorrectly. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75806
[22:53:52] 	 (CR) Mollywhite: [C: 2 V: 2] "Small bugfix" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75806 (owner: Mollywhite)
[22:57:34] 	 YuviPanda, how does grrrit-wm get events from gerrit?
[22:57:50] 	 It guesses them
[22:58:19] 	 ...
[22:58:46] 	 ssh feed I think?
[22:58:59] 	 ssh gerrit.wikimedia.org -p29418 gerrit stream-events
[22:59:05] 	 that's what yuvi pasted for me earlier
[22:59:11] 	 (it doesn't work, though :( )
[22:59:44] 	 It looks like it gets stuff from redis but I don't know how they go into redis
[22:59:48] 	 fatal: krenair does not have "streamEvents" capability.
[22:59:48] 	 hm
[23:00:25] 	 yeah, that's what i was getting, too
[23:01:38] 	 Krenair: he has one thing that listens to stream-events and dumps it into redis, and a bunch of other things that read from it
[23:05:03] 	 (PS8) MarkTraceur: Implement agora-style checkboxes [core] - https://gerrit.wikimedia.org/r/74662
[23:05:26] 	 (CR) MarkTraceur: "Use .client-js instead of a stupid .agora class, sorry about being stubborn" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[23:07:32] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75810
[23:07:52] 	 (PS2) Cmcmahon: A test for IME help links [qa/browsertests] - https://gerrit.wikimedia.org/r/75328 (owner: Amire80)
[23:08:14] 	 (PS1) MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75811
[23:08:37] 	 (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75810 (owner: MaxSem)
[23:08:52] 	 (CR) MaxSem: [C: 2 V: 2] Update MobileFrontend to production tip [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75811 (owner: MaxSem)
[23:09:23] 	 (PS1) Ryan Lane: Remove redundant LowerCaseUsernameScheme global [extensions/LdapAuthentication] - https://gerrit.wikimedia.org/r/75812
[23:09:34] 	 hm
[23:09:51] 	 shouldn't grrrit-wm post stuff about wmf/ branches to #-operations instead of here?
[23:10:23] 	 Or -tech
[23:10:27] 	 No, bad plan.
[23:10:46] 	 MatmaRex: I'd say this makes sense, since when it's being merged to a production branch, it's still in the hands of the devs
[23:10:47] 	 (PS1) Ebrahim: Adding Old Persian web font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75813
[23:10:56] 	 (CR) Demon: "I've always wondering what the actual use for this page was." [core] - https://gerrit.wikimedia.org/r/67468 (owner: Brian Wolff)
[23:13:42] 	 marktraceur: only a few people have merge rights in wmf/ branches, so i dunno
[23:14:00] 	 Really?
[23:14:03] * marktraceur  feels special
[23:14:21] 	 well, none of the volunteerscan do that, for one
[23:14:28] 	 i guess most wmf employees can
[23:14:46] 	 Aw.
[23:14:56] * marktraceur  feels less special
[23:15:00] 	 but i don't really know
[23:16:38] 	 (CR) Reedy: [C: 2] Remove redundant LowerCaseUsernameScheme global [extensions/LdapAuthentication] - https://gerrit.wikimedia.org/r/75812 (owner: Ryan Lane)
[23:16:39] 	 (Merged) jenkins-bot: Remove redundant LowerCaseUsernameScheme global [extensions/LdapAuthentication] - https://gerrit.wikimedia.org/r/75812 (owner: Ryan Lane)
[23:17:09] 	 on a side note
[23:17:12] 	 wtf is https://gerrit.wikimedia.org/r/#/c/51806/
[23:17:26] 	 an open patch on wmf/1.21wmf10
[23:19:43] 	 (PS2) Ebrahim: Adding Old Persian web font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75813
[23:27:09] 	 (PS3) Ebrahim: Adding Old Persian web font [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75813
[23:29:21] 	 (PS1) Reedy: Minor code cleanup [extensions/LdapAuthentication] - https://gerrit.wikimedia.org/r/75815
[23:29:46] 	 (PS3) Cmcmahon: Fscenario visual editor appears if user is logged in (finished) [qa/browsertests] - https://gerrit.wikimedia.org/r/75110 (owner: Rachel99)
[23:32:17] 	 (PS1) Krinkle: Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75816
[23:36:15] 	 (PS1) Krinkle: Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75817
[23:37:26] 	 (CR) Cmcmahon: [C: -1] "VE is enabled for both logged-in and anonymous users now. However, that should be fairly stable now, and the Save interface is different f" [qa/browsertests] - https://gerrit.wikimedia.org/r/75110 (owner: Rachel99)
[23:42:04] 	 (CR) Krinkle: [C: 2] Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75817 (owner: Krinkle)
[23:42:14] 	 (CR) Krinkle: [C: 2] Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75816 (owner: Krinkle)
[23:44:36] 	 (Merged) jenkins-bot: Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75817 (owner: Krinkle)
[23:46:03] 	 (Merged) jenkins-bot: Update VisualEditor to master to pick up acb30c3 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75816 (owner: Krinkle)
[23:51:49] 	 (PS3) Cmcmahon: Several refactorings, see comment [qa/browsertests] - https://gerrit.wikimedia.org/r/74564
[23:53:43] 	 (CR) Parent5446: [C: -1] "Needs release notes rebase. After that we can probably merge since nobody else has complained." [core] - https://gerrit.wikimedia.org/r/67468 (owner: Brian Wolff)