[00:05:40] (PS1) Jdlrobson: Add Makefile to core [core] - https://gerrit.wikimedia.org/r/75268 [00:08:14] (CR) jenkins-bot: [V: -1] Add Makefile to core [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [00:16:00] Gitblit's back [00:16:32] (PS2) Jdlrobson: Add Makefile to core [core] - https://gerrit.wikimedia.org/r/75268 [00:18:50] (PS3) Jdlrobson: Add Makefile to core [core] - https://gerrit.wikimedia.org/r/75268 [00:19:46] (PS5) Alex Monk: (bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights [core] - https://gerrit.wikimedia.org/r/40096 [00:20:09] (CR) jenkins-bot: [V: -1] (bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights [core] - https://gerrit.wikimedia.org/r/40096 (owner: Alex Monk) [00:26:31] (PS6) Alex Monk: (bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights [core] - https://gerrit.wikimedia.org/r/40096 [00:31:32] Elsie: where are you running your gerrit reports stuff from? [00:45:59] (Restored) Spage: Tweak account creation interface messages for logged in users [core] - https://gerrit.wikimedia.org/r/39862 (owner: Alex Monk) [00:47:32] Elsie, what parts of 16860#c19 are not done? [00:48:08] Krenair: Sorry, I got a little confused. I'll follow up with a better comment. [00:48:15] (PS10) Spage: Tweak login/account creation for logged in users [core] - https://gerrit.wikimedia.org/r/39862 (owner: Alex Monk) [00:48:22] I re-read your comment and it all seemed done [00:49:45] Krenair, I apologize for ignoring your change. I restored it and submitted the remaining bits. [00:51:28] Oh, it's okay [00:56:20] Krenair: Clarified. Sorry about the confusion. [00:56:25] That bug got a bit messy early on. [00:57:00] Elsie, heh, you could've just said comments 3 - 10 :) [00:57:13] rather than " comment 3, comment 4, comment 5, comment 6, comment 7, comment 8, comment 9, and comment 10" [00:57:24] I like links. :P [00:57:37] Krenair, your change removed the "Keep me logged in (for up to 30 days)" if the browsers already logged in and e.g. someone logs into a different account on this computer). I'm not sure that's the right behavior, so the checkbox is always there on Login form only. [00:57:57] Also, en dash! [00:58:22] spagewmf, I hadn't considered that possibility. Nice catch! [00:59:10] - – ‒ — ― [00:59:28] ? [00:59:53] offering Elsie a choice of https://en.wikipedia.org/wiki/Dash [00:59:57] :) [01:00:31] ah :) [01:02:43] spagewmf: Monospace fonts kind of ruin that. :P [01:02:55] Elsie, mass locking is done, setstatus via API is done, globalblocking API is doing (in gerrit, but not a CentralAuth thing) [01:03:01] I can't find much more suggestions [01:03:04] many* [01:04:22] https://gerrit.wikimedia.org/r/#/c/47539/ - globalblocking api [01:07:34] Krenair: I didn't really know what that long comment by Jesse was about. [01:07:37] Maybe GlobalBlocking. [01:07:43] Though it seemed more like global locking? [01:08:12] comment 9? [01:09:10] In that comment he goes through the process of locking and hiding (from public lists, not oversight) a global account, not GlobalBlocking [01:11:10] All right. [01:11:26] This is almost totally outside of my area. :-) [01:11:34] I was just trying to keep that bug focused last year. [01:12:10] (CR) Alex Monk: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74678 (owner: Alex Monk) [01:12:42] ^ that's a local version of CA's GlobalGroupPermissions [01:23:10] (PS1) Catrope: When a module is blocking (position=top), never defer its execution [core] - https://gerrit.wikimedia.org/r/75270 [01:27:44] Elsie, cross-wiki user rights groups (https://bugzilla.wikimedia.org/show_bug.cgi?id=12518) were stuck for a few months while I didn't have any good ideas to get remote group info [01:28:17] Then someone suggested making HTTP requests to the API and it seems so ridiculously obvious now -.- [01:30:53] One issue with the new version is that for a few days it will be possible to add people to the autopatrolled group on frwiki [01:31:10] Someone. ;-) [01:31:55] (that shouldn't be possible because 'autopatrolled' on frwiki is implicit - the only exception on WMF wikis to the default '*', 'user', 'autoconfirmed' list ) [01:32:12] Krenair: if that's really an issue, you can backport and deploy at once [01:32:23] It's not going to be a big issue [01:32:54] (CR) Parent5446: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74678 (owner: Alex Monk) [01:34:51] (CR) MZMcBride: "What's the status of this changeset?" [core] - https://gerrit.wikimedia.org/r/51675 (owner: Reedy) [01:34:51] Actually that seems to be an issue with the current system... hah, okay then, I guess it doesn't matter at all [01:36:58] ok [01:37:55] hoo: do you have any ideas for https://gerrit.wikimedia.org/r/#/c/74678/2/includes/Wiki.php ? [01:38:43] I'd like to avoid temporary file caching :/ [01:39:51] Krenair: why can't we use memcached there? [01:39:59] ... [01:40:38] that's our way to save serialized objects [01:41:18] We can't require Memcache [01:41:43] We could just default new setups to the old config file group permissions system [01:43:08] But I'd really like it to be on by default [01:43:40] I see... how bad is the performance for an average data set actually? [01:44:10] use SQLite for such tests as taht's the slowest RDMS we support [01:44:29] * RDBMS [01:51:28] (CR) Hoo man: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/36330 (owner: Alex Monk) [01:52:06] Maybe websites that would suffer performance-wise because of this commit already use memcached [01:55:37] Krenair: Do regular MW installs have write rights to $IP/cache ? If so, you could dump it there (serialized) [01:56:11] with a decent OS side IO cache that's going to be rather fast [01:58:06] They should do. I might do it in that case. [01:58:42] 2.3KiB on a normal MW install [02:04:05] php > $start = microtime(true); for ( $i = 0; $i < 100000; $i++ ) { unserialize( file_get_contents( 'foo' ) ); } $end = microtime(true); [02:04:05] php > echo $end - $start; [02:04:05] 28.515572071075 [02:04:51] Krenair: That contained the default wgGroupPermissions of MediaWiki ... the installation is on /dev/shm (tmpfs, but shouldn't be much faster than any other decently cached FS) [02:08:24] (CR) Yuvipanda: [C: 1] "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:11:20] (CR) Yuvipanda: [C: 2 V: 1] "LGTM" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072 (owner: Legoktm) [02:11:36] (CR) Demon: [C: -2] "This is the wrong way to go about this, it's hacky and I won't let it in core." [core] - https://gerrit.wikimedia.org/r/74678 (owner: Alex Monk) [02:12:59] "you need to resurrect my config mgmt proposals" [02:13:38] I thought you still planned to do that, ^demon? What happened? [02:14:57] <^demon> It's been on my back-burner forever, but I've never had the time to do it right. [02:15:46] There's no way I'm implementing the entire config mgmt thing myself [02:16:06] <^demon> There's two big parts of it, which can be done separately. [02:16:11] Mainly because of the UI that would be required [02:16:20] <^demon> Backend and UI don't have to be co-developed. [02:16:21] I have to agree, we probably should do new things in MediaWiki more properly than we used to do [02:16:31] The backend itself... maye [02:16:32] maybe [02:16:44] having an abstract backend can be a first step, migrating can then be done step by step, I presume [02:16:45] <^demon> The backend's actually not terribly hard, and I'd be more than happy to advise & review any work on it. [02:17:15] <^demon> hoo: That was always my plan: to write the backend properly for core and then pull over things from the Configure extension as needed for UI :) [02:17:59] Don't we already have some KV store abstraction? [02:18:08] $wgMemc only deals with memcached doesn't it? [02:18:24] Krenair: Nope, it's a wrapper around various caches [02:18:25] <^demon> $wgMemc is whatever is the $wgMainCacheType backend. [02:18:35] <^demon> Could be CACHE_MEMCACHED, could be CACHE_DB or CACHE_NONE :) [02:18:39] From the name I'm guessing it started as intended for memcached. [02:18:43] but that's not what I consider a sane and modern abstraction of a configuration system :P [02:18:47] Then got made generic? [02:18:50] Yep [02:18:54] sigh [02:19:16] <^demon> But yeah, a basic key => value store with abstraction for backends is the easy part. [02:19:20] So that system could be used for this? [02:19:38] <^demon> No, stuff in the cache shouldn't be rely'd on. [02:19:41] <^demon> *relied even [02:19:51] <^demon> That data may disappear at any time. [02:20:09] <^demon> For config mgmt, you'd want to have fallback so even if nothing is stored you return the default. [02:20:17] ^demon: We already do that in CA, you just have to make sure you invalidate caches properly and that caches can always go away [02:20:24] but all that can be unit tested [02:20:41] <^demon> Anyway, the key => value bit with fallback isn't hard, and I've done that bit before. [02:20:54] <^demon> The slightly more annoying bit is the importing of $wgFoos for back-compat :) [02:20:57] (PS3) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 [02:21:12] (back in a few minutes. please keep discussing but I won't reply for a bit) [02:21:25] <^demon> Importing and exporting, actually, so you'd be compat in both directions. [02:22:45] (CR) Yuvipanda: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:23:35] (PS4) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 [02:24:10] (CR) Legoktm: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:24:20] ^demon: This could also be the beginning of reducing the number of globals used within MW... we could pass a Settings object by context and use that... that would be great, I suppose [02:25:05] <^demon> That was the plan ;-) [02:25:08] (CR) Yuvipanda: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:25:12] \o/ [02:25:17] <^demon> Basically it would allow us to start killing global variables for configuration. [02:25:30] <^demon> Harder has always been killing global state objects, but that's orthogonal :) [02:26:05] legoktm: I'll +2 with a more detailed comment explaining why it is an assoc array :) [02:26:12] Ok :P [02:26:55] Yes... there are some classes which are very very bad :P Like the Article one (although I took part in bloating that even more :/) [02:26:58] legoktm: not like you need me to do that, but still... :) [02:27:18] YuviPanda: I think it also depends on a change that hasn't been merged if you want to look at that :) [02:27:29] legoktm: I +2'd that, I think? [02:27:31] * YuviPanda checks [02:27:50] https://gerrit.wikimedia.org/r/#/c/75073/3 [02:27:54] <^demon> hoo: Article is also very very old, and lots of things use it :) [02:28:16] It's like EditPage... a do it all class for everything slightly related to the name... [02:28:55] ^demon, what do you guys plan to do about private config variables? [02:29:27] (CR) Yuvipanda: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:29:29] How the hell is a UI going to work considering you can't really guess the type of each variable (forget when dealing with arrays and objects..)? [02:29:38] <^demon> Krenair: Wasn't going to treat them any special. It would be up to the UI/API to provide access to them, so presumably we wouldn't allow those. [02:29:50] <^demon> The lower-level backend stuff won't care and will treat all config as the same. [02:29:58] Exposed in the UI on a whitelist basis? [02:30:08] <^demon> That was my original thought, yep [02:30:15] make 'em all JSON! [02:30:17] As variable types - Are we going to end up with TemplateData for config variables? [02:30:24] Ok... 4:30am... good night ;) [02:30:26] and use JSONSchema! [02:30:30] YuviPanda we can't make everything JSON [02:30:42] config variables can be expressed as JSON, no? [02:30:52] is there something you can represent in PHP that you can't in JSON? [02:30:59] although maybe config variables are some things we could... please don't json all the things :) [02:31:07] <^demon> For the default implementation we could use JSON or maybe a database-backed thing. [02:31:20] either way, you can use JSONSchema and autogenerate UI from that [02:31:21] <^demon> Or just stuff serialized php into a blob column ;-) [02:31:28] * YuviPanda stuffs ^demon into maven [02:31:28] You mentioned the Configure extension - how does that deal with it? (I'm too lazy to set it up) [02:31:43] <^demon> YuviPanda: Ow! [02:31:52] UploadWizard has a JSONSchema now, I need to write the UI generation code at some point [02:31:57] <^demon> Krenair: It wouldn't, Configure would be effectively deprecated. [02:32:05] I mean [02:32:12] <^demon> I thought we might steal^H^H^H^H^H borrow some of the UI from configure [02:32:18] ^demon: those are implementation details, you don't really have to think about this early :P Keep it abstract and you can provide a bazillion backend [02:32:19] Yes I understand that [02:32:28] <^demon> hoo: Yep yep :) [02:32:29] I'm wondering how Configure builds a UI for such a thing [02:32:32] YuviPanda: I could probably justify working on that in the near-mid future [02:32:37] marktraceur: \o/ [02:32:38] <^demon> Krenair: Nfc, never used it :D [02:32:46] Like...3 weeks out-ish [02:32:54] Or maybe more [02:33:09] <^demon> Anyway, I've got some old code in the history of master somewhere that was in includes/conf/*. [02:33:10] marktraceur: but I'd like to think that Phase 4 of http://mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace%20proposal would take precedence [02:33:20] since the campaign admins are perfectly happy editing JSON [02:33:51] <^demon> That combined with what exists with ConfEditor/SiteConfiguration is a decent place to start. [02:34:06] I'm still not comfortable about replacing the (admittedly not perfect) UW campaigns UI with JSON [02:34:21] <^demon> Anyway, dinner time. Krenair if you wanna talk about this more sometime I'd be more than happy to guide you. [02:34:26] Krenair: why so? [02:34:41] Krenair: it was deployed today, and Romain / odder / other wlm folks were very happy [02:34:53] Great, thanks ^demon. I will probably have a go at the backend part of it for Special:GroupPermissions [02:35:06] I guess, if the users are okay with it... But it still feels wrong [02:35:27] Krenair: https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal which I wrote up specifices 'phase 3' as implementing an UI for campaign editors [02:35:48] I also need to write an Query Generator module for it [02:37:48] (CR) Yuvipanda: [C: -1] "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:44:09] (PS5) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 [02:44:53] (CR) Yuvipanda: [C: 2] Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:47:45] Hello. [02:47:59] Does anyone here know about ULS, particularly how it applies to Wikimedia wikis? [02:48:43] PiRSquared: Maybe #mediawiki-i18n? [02:48:59] Isn't that the channel for translatewiki.net? [02:50:05] legoktm: if you think you can help - https://ang.wikipedia.org/wiki/Gesprec:Hēafodtramet#Fonts_again_.28add_Junicode_to_.22Universal_Language_Selector.22.3F.29 [02:50:23] it is, but they're also the people who wrote ULS [02:50:26] theyre more likely to know about it than people here [02:50:47] (PS4) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 [02:51:21] (CR) Yuvipanda: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:51:21] (CR) Legoktm: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:51:58] (PS5) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 [02:52:18] Is there any kind of git pre-commit hook I can add to automatically fix whitespace? [02:53:18] (CR) Yuvipanda: [C: 2] If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:53:24] legoktm: yes! [02:53:24] I just stumbled upon https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Whitespace heheh [02:53:29] legoktm: there's a config variable [02:53:29] YuviPanda: link plox [02:53:32] moment [02:53:44] add [02:53:47] [apply] [02:53:47] whitespace = fix [02:53:50] to ~/.gitconfig [02:54:09] its that simple??? <333 [02:54:16] yeah [02:54:17] :D [02:55:11] (CR) Legoktm: [C: 2 V: 2] If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:55:12] (Merged) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm) [02:55:27] (PS6) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 [02:56:00] legoktm: all that got merged, so yay :) [02:56:14] (CR) Legoktm: [C: 2 V: 2] Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:56:15] (Merged) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm) [02:56:18] :D [02:56:29] (PS3) Legoktm: Don't leave messages for non-existent users [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072 [02:56:54] (CR) Legoktm: [C: 2 V: 2] Don't leave messages for non-existent users [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072 (owner: Legoktm) [02:56:54] (Merged) Legoktm: Don't leave messages for non-existent users [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072 (owner: Legoktm) [02:57:08] Phew. [02:57:10] I think that's it [02:57:13] * legoktm hugs YuviPanda  [02:57:19] <3 [03:01:10] Elsie: I just updated the labs wiki with all the stuff that just got merged. I'm also going to try and set it up using a redis job queue so we can test with that. [03:02:45] wooo redis :) [03:03:07] legoktm: there's redis puppet classes that set everything up, if you want to use that. Might take a while to understand puppet, tho [03:04:35] Is it easy to use? [03:05:15] once you've spent a few days understanding puppet, yes :) [03:05:21] :/ [03:05:26] if you don't want to do that, you can just apt-get install redis on your labs instance [03:05:28] and it should be fine [03:07:11] Oh, goodie. [03:07:43] > Create the page "Manual:$wgJobTypeConf" on this wiki! :( [03:11:51] legoktm: have you written API query generator modules? :D [03:12:04] Nope, but it shouldn't be that hard [03:12:14] Look at the abusefilter ones for examples [03:12:48] hmm, will do [03:12:54] i've to understand how ApiPageSets work [03:12:58] and who exactly should do the query [03:13:06] I guess being half aslseep isn't a good environment for that [03:16:34] YuviPanda: Does redis by default have a password enabled? [03:16:41] legoktm: nope [03:16:48] ok [03:17:00] is it [03:17:01] redis-server - Persistent key-value database with network interface [03:17:01] ? [03:17:25] installed [03:17:56] legoktm: yeah [03:18:04] legoktm@legoktm:~$ man redis-server [03:18:04] -bash: man: command not found [03:18:06] ?????? [03:18:17] How do I make redis run in the backround? [03:19:21] legoktm: this is ubuntu right? [03:19:25] try service redis start? [03:19:25] Yes [03:19:35] redis: unrecognized service [03:19:40] ah [03:19:41] -server [03:19:54] Starting redis-server: [32123] 23 Jul 03:19:47.551 # Fatal error, can't open config file '/etc/redis/redis.conf' [03:20:04] oh i see [03:20:11] you need to do a cp or mv there [03:20:12] i think [03:20:19] yeah [03:20:19] legoktm@legoktm:~$ sudo mv /etc/redis/redis.conf.sample /etc/redis/redis.conf [03:20:33] nice [03:20:37] heh [03:20:40] still not in dameon mode [03:20:48] service redis-server start? [03:20:49] i think i need to edit the file [03:20:52] maybe [03:20:57] it's very well commented file [03:21:09] # By default Redis does not run as a daemon. Use 'yes' if you need it. [03:21:09] # Note that Redis will write a pid file in /var/run/redis.pid when daemonized. [03:21:10] daemonize no [03:21:25] woot! [03:21:43] :D [03:22:05] (PS3) Clancer: [WIP] Moodle Extension [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109 [03:23:24] (PS4) Clancer: [WIP] Moodle Extension [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109 [03:24:47] (CR) Aaron Schulz: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74400 (owner: Catrope) [03:25:01] i think it works :D [03:25:21] legoktm: \o/ [03:25:33] heh [03:25:35] Parse error: syntax error, unexpected ':' in /srv/mediawiki/extensions/MassMessage/SpecialMassMessage.php on line 111 [03:26:19] (PS1) Legoktm: syntax terror [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75272 [03:26:19] legoktm: you gave it V+2! :) [03:26:27] I tested everything! [03:26:40] Just not necessarily using that actual patch. [03:26:52] (CR) Yuvipanda: [C: 2 V: 2] "Whoops!" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75272 (owner: Legoktm) [03:26:52] (Merged) Yuvipanda: syntax terror [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75272 (owner: Legoktm) [03:26:58] heh, i was too slow. [03:27:32] I should probably set up jenkins-bot... [03:27:35] (PS5) Clancer: [WIP] Moodle Extension [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109 [03:27:37] Would have caught that one [03:27:41] legoktm: yeah [03:27:51] and follow phpcs and jshint fromd ay 0 too [03:28:07] > Warning: Illegal offset type in /srv/mediawiki/extensions/MassMessage/SpecialMassMessage.php on line 113 [03:28:32] $pages[$title] = true; // Use an assoc array to quickly and easily filter out duplicates [03:40:26] (PS1) Legoktm: Can't use an object as an array key, so use Title::getFullText() instead. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75273 [03:41:02] (PS2) Legoktm: Can't use an object as an array key, so use Title::getFullText() instead. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75273 [03:41:34] (CR) Legoktm: [C: 2 V: 2] "Tested, works." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75273 (owner: Legoktm) [03:41:35] (Merged) Legoktm: Can't use an object as an array key, so use Title::getFullText() instead. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75273 (owner: Legoktm) [03:47:01] Hmm… I'm not sure why it's not picking up that I've installed phpredis…I'll debug it later I guess. [03:47:06] dinner, bbl [04:21:02] (PS2) Aaron Schulz: Added an HMAC step to secret key usage [extensions/OAuth] - https://gerrit.wikimedia.org/r/75259 [04:26:00] (PS1) Aaron Schulz: Fixed dynamic call to static method [extensions/OAuth] - https://gerrit.wikimedia.org/r/75274 [04:29:41] (CR) Santhosh: [C: 2] Fix an i18n message [extensions/Echo] - https://gerrit.wikimedia.org/r/75144 (owner: Bsitu) [04:29:48] (Merged) jenkins-bot: Fix an i18n message [extensions/Echo] - https://gerrit.wikimedia.org/r/75144 (owner: Bsitu) [04:30:58] (PS3) Mwjames: \SMW\JobBase improve testability and eliminate GLOBALS from SMW\UpdateJob [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/74840 [04:50:33] (PS4) Mwjames: \SMW\JobBase improve testability and eliminate GLOBALS from SMW\UpdateJob [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/74840 [04:54:55] (PS5) Mwjames: \SMW\JobBase improve testability and eliminate GLOBALS from SMW\UpdateJob [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/74840 [04:56:44] (CR) Mwjames: [C: 2] \SMW\JobBase improve testability and eliminate GLOBALS from SMW\UpdateJob [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/74840 (owner: Mwjames) [04:57:45] (Merged) jenkins-bot: \SMW\JobBase improve testability and eliminate GLOBALS from SMW\UpdateJob [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/74840 (owner: Mwjames) [05:22:17] legoktm: $wgNamespacesToExtractLinksFor doesn't seem like it'll work. [05:22:32] The name or the actual implementation? [05:22:44] (PS1) Ori.livneh: Unit test for http_get; minor clean-ups [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75275 [05:23:16] (CR) Ori.livneh: [C: 2] Unit test for http_get; minor clean-ups [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75275 (owner: Ori.livneh) [05:23:22] Hmmmm. [05:23:28] I guess most wikis use the project namespace. [05:23:35] (Merged) jenkins-bot: Unit test for http_get; minor clean-ups [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75275 (owner: Ori.livneh) [05:23:56] legoktm: I always think of [[Wikimedia Forum]], but perhaps Meta-Wiki should just be special-cased. [05:24:23] Hm [05:24:45] I think that's fine. [05:24:49] Right now it works in that it extracts links. [05:25:02] Maybe rather than a check at the beginning, it should be a check right before posting? [05:25:17] I was worried about the default value of the variable, but I think it's fine. [05:25:25] Oh, ok. [05:25:39] And, yeah, you raise a good point. [05:25:43] You need a confirmation screen. :-) [05:25:58] That shows a message preview and the full list of targets. [05:26:19] (PS1) Legoktm: Use the same edit summary that section=new would. Code taken from EditPage.php [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75276 [05:26:33] A full list of targets would be pretty long. [05:26:34] And that can warn about unclosed tags. [05:26:41] The signpost spamlist is > 2k iirc [05:26:50] That's fine. [05:27:02] message sounds like a good idea to me though. [05:28:21] (PS1) Mwjames: (Bug 50755) Remove MigrationJob/SMWMigrate [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75277 [05:29:05] Elsie: Can you add these to the Design page? [05:32:20] Elsie: "catch blank subject" how does EdwardsBot currently handle that? I'm thinking of when people want to use something like {{subst:template}}, where template already has a header? [05:32:46] People shouldn't do that. [05:33:11] A header is distinct from the body. [05:33:14] That's why there are two fields. [05:33:20] Same as e-mail. [05:34:46] Email doesn't stop you if you don't have a subject. [05:34:59] It warns you. [05:35:09] So a warning then? [05:35:11] At least my client does. [05:35:24] Well, it warns you and then if you still don't provide a subject, it usually uses "(no subject)". [05:35:37] I'd just prevent submission. [05:35:43] == (no subject) == would look pretty stupid. [05:35:45] :P [05:35:57] Right. Just prevent form submission. [05:36:03] There's no reasonable case for not including a header. [05:36:16] By the way, the wiki does the same thing. [05:36:25] It provides two inputs and warns you if you leave the subject blank. [05:36:50] Isn't that only if you have the preference telling you to use an edit summary enabled? But yes, I understand your point. [05:36:55] Should be easy to implement [05:37:23] I think the subject line check is independent of the user preference. [05:37:45] (CR) Mwjames: [C: 2] "For obvious reason MigrationJob/SMWMigrat are going into the bin since it adds no value and is causing a fatal due to" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75277 (owner: Mwjames) [05:38:40] legoktm: In the introductory message that you add, you can say "all fields are required." [05:39:04] (Merged) jenkins-bot: (Bug 50755) Remove MigrationJob/SMWMigrate [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75277 (owner: Mwjames) [05:39:11] legoktm: I think you're right about the user preference. [05:39:15] https://test.wikipedia.org/w/index.php?title=Talk:Main_Page&diff=176346&oldid=176087 [05:39:21] Weird. [05:43:15] (PS1) Ori.livneh: Skip test that requires socket usage on Travis.CI [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75278 [05:43:48] (CR) Ori.livneh: [C: 2] Skip test that requires socket usage on Travis.CI [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75278 (owner: Ori.livneh) [05:43:50] (Merged) jenkins-bot: Skip test that requires socket usage on Travis.CI [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75278 (owner: Ori.livneh) [05:52:50] (PS1) Mwjames: \SMW\QueryData use UnknownIdException instead of MWException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75279 [05:54:33] (CR) Mwjames: [C: 2] \SMW\QueryData use UnknownIdException instead of MWException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75279 (owner: Mwjames) [05:56:47] (Merged) jenkins-bot: \SMW\QueryData use UnknownIdException instead of MWException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75279 (owner: Mwjames) [06:08:29] (PS2) Mgrover: Created python script to git logs [tools/release] - https://gerrit.wikimedia.org/r/59138 [06:08:30] (PS1) Mgrover: added additional logic to grep the output file for Story and Bug [tools/release] - https://gerrit.wikimedia.org/r/75280 [06:08:32] (CR) jenkins-bot: [V: -1] Created python script to git logs [tools/release] - https://gerrit.wikimedia.org/r/59138 (owner: Mgrover) [06:12:47] (PS1) Ori.livneh: Update Ganglia metric module [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75282 [06:13:39] (CR) Ori.livneh: [C: 2] Update Ganglia metric module [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75282 (owner: Ori.livneh) [06:13:57] (Merged) jenkins-bot: Update Ganglia metric module [extensions/EventLogging] - https://gerrit.wikimedia.org/r/75282 (owner: Ori.livneh) [06:15:04] (PS1) Legoktm: Add mw extension jobs for MassMessage extension [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/75283 [06:15:10] YuviPanda: ^ [06:20:04] (PS2) Zfilipin: Change to click Edit source, VE is enabled for anonymous users now [qa/browsertests] - https://gerrit.wikimedia.org/r/75145 (owner: Cmcmahon) [06:20:11] legoktm: nice. [06:20:15] (CR) Zfilipin: [C: 2] Change to click Edit source, VE is enabled for anonymous users now [qa/browsertests] - https://gerrit.wikimedia.org/r/75145 (owner: Cmcmahon) [06:20:16] (Merged) Zfilipin: Change to click Edit source, VE is enabled for anonymous users now [qa/browsertests] - https://gerrit.wikimedia.org/r/75145 (owner: Cmcmahon) [06:20:17] legoktm: not sure if I can +2, though. [06:20:39] Well I added hashar to it, not in a rush to get it done [06:21:24] legoktm: yeah, he'll probably +2 it whenever [06:21:34] and I'll ask him if others can +2 trivial changes, because apparently I've the perms [06:21:46] I'm not sure for whom the tests will trigger, so I'm going to wait for him anyway [06:23:14] (PS1) Legoktm: Give users an error if they try to send a message with no subject line and/or message body. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75285 [06:25:09] (PS2) Legoktm: Give users an error if they try to send a message with no subject line and/or message body. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75285 [06:30:19] (PS1) Mwjames: \SMW\QueryData use HashIdGenerator instead [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75286 [06:34:03] (CR) Mwjames: [C: 2] \SMW\QueryData use HashIdGenerator instead [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75286 (owner: Mwjames) [06:35:22] (Merged) jenkins-bot: \SMW\QueryData use HashIdGenerator instead [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75286 (owner: Mwjames) [06:42:14] For some reason I get Michelle Grover and Michelle Paulson confused. [06:42:39] So I'm always really surprised to see one committing changes to Gerrit. [06:51:11] (PS1) Mwjames: Some \SMW\ namespace clean-up [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75287 [06:51:50] (CR) Mattflaschen: "(1 comment)" [extensions/GuidedTour/guiders] - https://gerrit.wikimedia.org/r/74820 (owner: Mattflaschen) [06:53:51] (CR) Mwjames: [C: 2] Some \SMW\ namespace clean-up [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75287 (owner: Mwjames) [06:55:10] (Merged) jenkins-bot: Some \SMW\ namespace clean-up [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75287 (owner: Mwjames) [07:02:59] (PS1) Raimond Spekking: Define message array to unbreak translatewiki.net script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75290 [07:03:23] (CR) Raimond Spekking: [C: 2 V: 2] Define message array to unbreak translatewiki.net script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75290 (owner: Raimond Spekking) [07:03:24] (Merged) Raimond Spekking: Define message array to unbreak translatewiki.net script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75290 (owner: Raimond Spekking) [07:05:06] (PS2) Raimond Spekking: Consistency tweaks for translatewiki.net [extensions/BetaFeatures] - https://gerrit.wikimedia.org/r/74621 [07:19:03] (PS1) Raimond Spekking: Add newline at end of file to unbreak twn script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75291 [07:19:15] (CR) Raimond Spekking: [C: 2 V: 2] Add newline at end of file to unbreak twn script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75291 (owner: Raimond Spekking) [07:19:16] (Merged) Raimond Spekking: Add newline at end of file to unbreak twn script [extensions/Annotator] - https://gerrit.wikimedia.org/r/75291 (owner: Raimond Spekking) [07:24:27] (PS1) Legoktm: sysops can now add/remove the "messenger" group, but can no longer send messages themselves. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75292 [07:29:41] Krenair: I updated [[meta:wm-bot]] [07:29:45] !meta [07:29:45] https://meta.wikimedia.org/wiki/$1 [07:29:48] !meta wm-bot [07:29:49] https://meta.wikimedia.org/wiki/wm-bot [07:30:57] (PS1) Legoktm: Clarify post-submit message that the messages have been queued, not sent. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75293 [07:34:09] legoktm: What's the rationale behind restricting sysops? [07:34:44] Elsie: Just so it matches the current state of how things work [07:35:29] They can easily add themselves to the group [07:35:32] what you two talk about :P [07:35:38] restricting sysops? [07:35:47] (CR) MZMcBride: "I think not assigning the user right to admins by default goes against general MediaWiki extension behavior." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75292 (owner: Legoktm) [07:35:55] petan: ^ [07:36:09] aha [07:36:17] Do sysops normally get most userrights? [07:36:23] It's not really a big deal to me [07:36:24] probably [07:36:34] legoktm: Ever checked out DefaultSettings.php? ;-0 [07:36:35] ;-) [07:36:42] if you don't want permissions but you want to be able to grant them, become bureaucrat [07:36:50] (and revoke sysop from yourself) [07:37:08] legoktm: Think about it this way, if you installed this extension on your own personal wiki, would you expect to also have to assign yourself to a user group? [07:37:15] way: * [07:37:21] Heh, probably not. [07:37:40] Though as petan says, you could use the bureaucrat user group for this, maybe. [07:38:02] legoktm: your change is following the standard way how it's done everywhere, but mediawiki does the things exactly opposite than everyone else :D [07:38:16] hence own url decoding which isn't compatible with standards [07:38:16] Wikimedia wikis vs. MediaWiki wikis. :-) [07:39:11] (PS2) Legoktm: sysops can now add/remove the "messenger" group, which now has the proper i18n messages. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75292 [07:41:26] yeah it is [07:41:29] and its running a redis job queue now [07:41:59] "Main Page <" still fails. :-) [07:41:59] > Fatal error: Call to a member function isRedirect() on a non-object in /srv/mediawiki/extensions/MassMessage/MassMessage.body.php on line 23 [07:41:59] Hmmm. [07:41:59] That's a regression then :P [07:42:03] Does redis queue mean it's faster/automatic? [07:42:30] Seems not. [07:43:03] No, just that it supposedly matches what production is using. [07:43:28] The code seems to have a few regressions. [07:43:36] :/ [07:45:42] Oh. [07:45:45] !ping [07:45:46] Pong. [07:45:46] I see why [07:50:53] (PS1) Legoktm: If the page doesn't exist or is invalid, don't bother checking redirects [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75294 [07:51:20] (CR) Legoktm: [C: 2 V: 2] "Works, and fixes a regression." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75294 (owner: Legoktm) [07:51:21] (Merged) Legoktm: If the page doesn't exist or is invalid, don't bother checking redirects [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75294 (owner: Legoktm) [07:51:22] jesus christ Java [07:51:27] Elsie: ^ [07:51:32] * YuviPanda stabs java generics [07:51:41] Elsie: Deployed it to labs. [07:51:45] Any other regressions? [07:52:02] (CR) MZMcBride: "I'd like to revisit how the extension posts to talk pages." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75276 (owner: Legoktm) [07:52:36] legoktm: Looks better. [07:53:14] What part do you want to revisit? [07:53:36] Why it's not using the MediaWiki API. [07:53:49] Web API, rather. [07:53:59] (PS1) Mwjames: Remove addPropertyValue logic from ParserData (further compartmentalize of ParserData) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75295 [07:54:02] What's the advantage to using the Web API? [07:54:15] It reduces code duplication. [07:54:24] You're copying and pasting code from EditPage.php. [07:54:28] That's almost always a bad sign. [07:54:52] There's an abstraction layer on top of talk pages. I don't see why it's not being used. [07:55:00] It handles a subject line and body text. [07:55:08] It's basically made for this. [07:56:05] Hm. [07:56:06] https://www.mediawiki.org/wiki/API:Calling_internally [07:56:14] > If your code is just going to edit some content, please consider using WikiPage::doEdit() instead of an API. [07:58:09] And then right below it there's an example from WikiLove that shows how to edit a page :P [07:58:31] What does WikiLove use? [07:58:53] DerivativeRequest via the Web API. [07:59:08] Also related https://bugzilla.wikimedia.org/show_bug.cgi?id=34838 [07:59:29] Though, we can use a FauxRequest since this is supposed to be a bot. [07:59:50] So instead of FauxRequest, use DerivativeRequest? [08:00:01] Either way, pass standard API parameters and you won't have to fake an edit summary. [08:00:19] That part should be handled by separate app logic. [08:00:28] I updated the /Design page, BTW. [08:00:37] And... [08:01:50] (CR) MZMcBride: "I'm still not sure about this changeset. I think Wikimedia wikis and MediaWiki wikis are being conflated." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75292 (owner: Legoktm) [08:02:03] ghelllo [08:02:11] Morning, hashar. [08:03:06] legoktm: I'd focus on cleaning up the form and adding a confirmation screen. [08:03:13] Ok [08:03:28] I'm working on the editing thing write now, it should be rather simple [08:03:30] No more HTML table, labels above inputs, add an introductory message. [08:03:46] Well I'm using the HTMLForm class right now.... [08:03:55] I'll have to look into how to customize that. [08:04:01] And then confirmation screen, with message preview and a (truncated) targets list. [08:04:07] The HTMLForm class uses a table? [08:04:18] Blergh. [08:04:21] Apparently. [08:04:31] I'm just using stock settings with no CSS or anything. [08:06:31] Erghhhhh [08:06:36] How do I fetch an edit token??? [08:06:44] And of course git.wikimedia.org is broken again. [08:06:47] Grahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh. [08:10:48] availableDisplayFormats in HTMLForm.php, BTW. [08:11:06] legoktm: ^ [08:11:17] Ok, I'll take a look [08:11:48] It only took me an extra few minutes to rage about git.wikimedia.org before going to github.com to look up HTMLForm.php's source. [08:11:54] This is efficient and a great use of my time. [08:11:56] Rage. [08:12:09] github has an amazing code search [08:12:35] When I don't understand something from the documentation, I can just search the function name and "@wikimedia" to find examples in various extensions [08:12:57] Maybe one day we'll be able to do that without GitHub. [08:13:05] We can dream. [08:13:13] * Elsie cages YuviPanda. [08:15:49] (PS1) Legoktm: [WIP] Edit via the API [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75299 [08:15:59] Elsie: It would look something like ^ [08:17:40] (CR) Legoktm: [C: -1] "Needs:" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75299 (owner: Legoktm) [08:23:11] Elsie: setting it to "div" looks like http://cl.ly/image/3P1W2J2a2D1E [08:24:29] (PS1) Legoktm: Set form's display format to "div". This moves the labels on top of the fields. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75300 [08:24:40] Probably needs some CSS though. [08:27:15] (CR) Mattflaschen: "(1 comment)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 (owner: Rjain) [08:39:44] (PS1) Santhosh: Remove some unwanted top RL module definitions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75302 [08:58:03] (CR) Mattflaschen: [C: -1] "I need to look at this more, but I lean towards preferring the https://gerrit.wikimedia.org/r/#/c/56058/ approach (opt in to a display sty" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [09:13:58] (CR) Legoktm: "Related: Ib51f2f4a65a45d70e278c13c198733fd47bc3229" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75276 (owner: Legoktm) [09:29:46] (PS1) Jeroen De Dauw: Fix IDe understanding of SMWDataItemException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75307 [09:33:15] (PS1) Hashar: triggers for mw/ext/MassMessage [integration/zuul-config] - https://gerrit.wikimedia.org/r/75308 [09:33:34] (CR) Hashar: [C: 2] "Jobs deployed. The Zuul triggers are made with https://gerrit.wikimedia.org/r/75308" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/75283 (owner: Legoktm) [09:33:35] (Merged) Hashar: Add mw extension jobs for MassMessage extension [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/75283 (owner: Legoktm) [09:34:02] hashar: thanks! [09:34:26] (PS2) Hashar: triggers for mw/ext/MassMessage [integration/zuul-config] - https://gerrit.wikimedia.org/r/75308 [09:34:42] legoktm: I am enabling phpunit tests there to test out how it behave when there is no test in the extension [09:34:56] sure [09:35:14] (PS1) Jeroen De Dauw: Update some class names to non-deprecated version [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75309 [09:35:24] (CR) Hashar: [C: 2] "Trying out with PHPUnit tests although there are none in that extension." [integration/zuul-config] - https://gerrit.wikimedia.org/r/75308 (owner: Hashar) [09:35:29] (Merged) jenkins-bot: triggers for mw/ext/MassMessage [integration/zuul-config] - https://gerrit.wikimedia.org/r/75308 (owner: Hashar) [09:36:00] (PS1) IAlex: (bug 51542) make "Special:FilePath?file=.." work again [core] - https://gerrit.wikimedia.org/r/75310 [09:39:21] (CR) Hashar: [C: -1] "Apparently got introduced by https://gerrit.wikimedia.org/r/#/c/61073/ / 83bcc4835e36877 which is not in 1.21 and we havent released 1.22" [core] - https://gerrit.wikimedia.org/r/75310 (owner: IAlex) [09:39:49] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75311 [09:40:01] legoktm: https://gerrit.wikimedia.org/r/75311 is a test for MassMessage jobs [09:40:33] the unit tests works \O/ https://integration.wikimedia.org/ci/job/mwext-MassMessage-testextensions-master/1/console [09:40:46] Neat thanks! [09:40:46] legoktm: whenever you write some unit tests, Jenkins will run them for you [09:40:50] woot! [09:40:53] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75311 (owner: Hashar) [09:41:18] you still have to write them though 8) Jenkins can't help on that [09:42:16] (CR) Santhosh: "still. the top loading of ext.uls.interface module need to be re-evaluated." [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75302 (owner: Santhosh) [09:42:43] heheh [09:45:00] (CR) Mwjames: "SemanticData has already a CRAP of 2920 which is beyond insanity, it also means adding something can only make it worse even with tests th" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75295 (owner: Mwjames) [09:47:53] (PS2) IAlex: (bug 51542) make "Special:FilePath?file=.." work again [core] - https://gerrit.wikimedia.org/r/75310 [09:49:56] (CR) IAlex: "Done. (The bug was marked as 1.21...)" [core] - https://gerrit.wikimedia.org/r/75310 (owner: IAlex) [10:06:49] (PS1) Santhosh: Update jquery.i18n from upstream, use its default message store [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75315 [10:08:50] (PS13) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [10:11:36] (PS2) Jeroen De Dauw: Fix IDe understanding of SMWDataItemException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75307 [10:16:35] (CR) Mwjames: [C: 2] Update some class names to non-deprecated version [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75309 (owner: Jeroen De Dauw) [10:17:55] (Merged) jenkins-bot: Update some class names to non-deprecated version [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75309 (owner: Jeroen De Dauw) [10:18:34] (CR) Mwjames: [C: 2] Fix IDD understanding of SMWDataItemException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75307 (owner: Jeroen De Dauw) [10:19:52] (Merged) jenkins-bot: Fix IDD understanding of SMWDataItemException [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75307 (owner: Jeroen De Dauw) [10:25:30] (CR) Nikerabbit: [C: 2] (Bug 50861) Support for Yandex Translate API v1.5 [extensions/Translate] - https://gerrit.wikimedia.org/r/74853 (owner: Lockal) [10:26:48] (Merged) jenkins-bot: (Bug 50861) Support for Yandex Translate API v1.5 [extensions/Translate] - https://gerrit.wikimedia.org/r/74853 (owner: Lockal) [10:47:44] Nikerabbit: so now keys have to be requested and configured for twn? [10:48:16] Nemo_bis: you're late [10:53:29] better son :) [10:53:33] *so [10:57:11] (PS1) Yuvipanda: [WIP] Add support for browsing + contributing to campaigns [apps/android/commons] - https://gerrit.wikimedia.org/r/75320 (via SuchABot) [11:02:12] (CR) Amire80: [C: 2] Update jquery.i18n from upstream, use its default message store [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75315 (owner: Santhosh) [11:02:45] (Merged) jenkins-bot: Update jquery.i18n from upstream, use its default message store [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75315 (owner: Santhosh) [11:11:02] (PS2) Amire80: Fix the logic of apply and cancel actions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75096 (owner: Santhosh) [11:17:39] (CR) Matthias Mullie: [C: 2] (bug 46664) Add HTML email support to Echo notification [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu) [11:17:41] (CR) jenkins-bot: [V: -1] (bug 46664) Add HTML email support to Echo notification [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu) [11:21:00] (PS18) Matthias Mullie: (bug 46665) Add HTML email support to email digest [extensions/Echo] - https://gerrit.wikimedia.org/r/72672 (owner: Bsitu) [11:21:02] (PS26) Matthias Mullie: Add HTML email support to Echo notification [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu) [11:21:33] (CR) Matthias Mullie: [C: 2] (bug 46665) Add HTML email support to email digest [extensions/Echo] - https://gerrit.wikimedia.org/r/72672 (owner: Bsitu) [11:35:44] (CR) Amire80: [C: 2] Fix the logic of apply and cancel actions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75096 (owner: Santhosh) [11:35:52] (Merged) jenkins-bot: Fix the logic of apply and cancel actions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75096 (owner: Santhosh) [11:40:53] (CR) Amire80: [C: 2] Remove some unwanted top RL module definitions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75302 (owner: Santhosh) [11:41:02] (Merged) jenkins-bot: Remove some unwanted top RL module definitions [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75302 (owner: Santhosh) [11:47:23] (CR) Matthias Mullie: [C: 2] Add HTML email support to Echo notification [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu) [11:47:29] (Merged) jenkins-bot: (bug 46665) Add HTML email support to email digest [extensions/Echo] - https://gerrit.wikimedia.org/r/72672 (owner: Bsitu) [11:47:31] (Merged) jenkins-bot: Add HTML email support to Echo notification [extensions/Echo] - https://gerrit.wikimedia.org/r/70112 (owner: Bsitu) [11:54:45] marktraceur: config undefined? [11:56:08] (PS3) Parent5446: (bug 51542) make "Special:FilePath?file=.." work again [core] - https://gerrit.wikimedia.org/r/75310 (owner: IAlex) [11:56:58] (CR) Parent5446: [C: 2] Make "Special:FilePath?file=.." work again [core] - https://gerrit.wikimedia.org/r/75310 (owner: IAlex) [12:00:30] (Merged) jenkins-bot: Make "Special:FilePath?file=.." work again [core] - https://gerrit.wikimedia.org/r/75310 (owner: IAlex) [12:14:50] (PS14) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [12:29:24] (PS15) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [12:29:36] (PS16) QChris: Testing bugzilla comments [test/gerrit-ping] - https://gerrit.wikimedia.org/r/70821 [12:45:32] (PS1) Amire80: Ignore config/secret.yml [qa/browsertests] - https://gerrit.wikimedia.org/r/75325 [12:55:37] (CR) Pginer: [C: -1] "The behaviour is as expected when displaying both original and translated pages. However, the label is displaying the following: <trans" [extensions/Translate] - https://gerrit.wikimedia.org/r/69162 (owner: Nikerabbit) [12:56:10] (CR) Pginer: "The behaviour is as expected when displaying both original and translated pages. However, the label is displaying "translate-tag-tab-trans" [extensions/Translate] - https://gerrit.wikimedia.org/r/69162 (owner: Nikerabbit) [13:10:00] (CR) Zfilipin: [C: 2] Ignore config/secret.yml [qa/browsertests] - https://gerrit.wikimedia.org/r/75325 (owner: Amire80) [13:10:01] (Merged) Zfilipin: Ignore config/secret.yml [qa/browsertests] - https://gerrit.wikimedia.org/r/75325 (owner: Amire80) [13:16:12] (PS1) Karima Rafes: Export table to CSV [extensions/LinkedWiki] - https://gerrit.wikimedia.org/r/75326 [13:18:58] (CR) Hoo man: [C: 2] "Yay for accessibility :)" [core] - https://gerrit.wikimedia.org/r/72259 (owner: TheDJ) [13:19:15] (CR) Karima Rafes: [V: 2] Export table to CSV [extensions/LinkedWiki] - https://gerrit.wikimedia.org/r/75326 (owner: Karima Rafes) [13:19:39] (CR) Karima Rafes: [C: 2] Export table to CSV [extensions/LinkedWiki] - https://gerrit.wikimedia.org/r/75326 (owner: Karima Rafes) [13:19:40] (Merged) Karima Rafes: Export table to CSV [extensions/LinkedWiki] - https://gerrit.wikimedia.org/r/75326 (owner: Karima Rafes) [13:22:07] (Merged) jenkins-bot: tablesorter: Keyboard accessibility for sort headers. [core] - https://gerrit.wikimedia.org/r/72259 (owner: TheDJ) [13:26:59] (PS2) Zfilipin: WIP Test central-domain login, cross-domain login and central login for anons [qa/browsertests] - https://gerrit.wikimedia.org/r/74128 [13:30:10] (PS1) Amire80: A test for IME help links [qa/browsertests] - https://gerrit.wikimedia.org/r/75328 [13:35:21] (CR) Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75295 (owner: Mwjames) [13:37:01] (CR) Jeroen De Dauw: "Looks good after a quick glance." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/75295 (owner: Mwjames) [13:41:09] (CR) TheDJ: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [13:46:57] (PS1) Yuvipanda: Re-organize classes to be a bit more organized [apps/android/commons] - https://gerrit.wikimedia.org/r/75333 (via SuchABot) [13:49:11] (CR) Yuvipanda: [C: 2 V: 2] "Trivial but large file move." [apps/android/commons] - https://gerrit.wikimedia.org/r/75333 (owner: SuchABot) [13:49:12] (Merged) Yuvipanda: Re-organize classes to be a bit more organized [apps/android/commons] - https://gerrit.wikimedia.org/r/75333 (owner: SuchABot) [13:51:41] (PS2) Yuvipanda: [WIP] Add support for browsing + contributing to campaigns [apps/android/commons] - https://gerrit.wikimedia.org/r/75320 (via SuchABot) [14:01:58] (CR) Hoo man: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [14:08:16] (CR) Krinkle: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [14:14:41] (CR) Krinkle: "Can't the unit test setup/teardown flush these caches instead?" [core] - https://gerrit.wikimedia.org/r/73520 (owner: Hoo man) [14:15:38] qgil: are we adding the Mid-term evaluation: WIP to the 'updates' column of that table? [14:16:25] apergos, yes [14:16:30] ok thanks [14:16:45] apergos, thanks for the fast response :) [14:17:14] (CR) Matmarex: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [14:17:29] hashar: is broken https://integration.wikimedia.org/ci/job/mediawiki-core-regression-phpcs-HEAD/1371/console [14:17:31] hashar: (shows up on every post-merge jenkins-bot comment on gerrit) [14:17:33] https://integration.wikimedia.org/ci/job/mediawiki-core-regression-phpcs-HEAD/1371/console : ERROR! It seems this job introduced a regression although it might be caused by a previous commit. in 4s [14:17:33] (PS6) Matmarex: Watchlist: Separate non-form parts out of the
[core] - https://gerrit.wikimedia.org/r/64557 [14:18:18] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [14:18:36] (CR) Hoo man: "Hardly in a sane way ... this is a static method with a static function scope var." [core] - https://gerrit.wikimedia.org/r/73520 (owner: Hoo man) [14:20:21] (CR) Krinkle: "Perhaps it should be cached elsewhere :)" [core] - https://gerrit.wikimedia.org/r/73520 (owner: Hoo man) [14:21:20] (PS1) Reedy: Fix double description [extensions/Sarcasm] - https://gerrit.wikimedia.org/r/75336 [14:22:44] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/73567 (owner: Santhosh) [14:31:01] Krinkle: yeh:) [14:31:30] Krinkle: yeah I guess that phpcs stuff can be removed [14:31:40] ? [14:31:55] How is that a logical conclusion [14:32:37] ahhh [14:33:24] Krinkle: the phpcs-HEAD are not supposed to be triggered unless there is a php / sample / php5 file [14:34:05] hashar: Yes, we did that already, so we just need to make sure it does that post-merge as well, right? [14:34:19] 2013-07-23 09:38:52,936 INFO zuul.IndependentPipelineManager: [14:34:20] I see no need to remove the job, unless it is redundant [14:34:33] Zuul did not apply the filter [14:36:07] (CR) Hoo man: "What would you suggest?" [core] - https://gerrit.wikimedia.org/r/73520 (owner: Hoo man) [14:37:26] hoo: Write your own caching system [14:38:14] Like carving the data into stone? :D [14:38:32] Krinkle: - name: ^.*-phpcs-HEAD$ is supposed to apply the files filtering [15:03:38] (CR) MarkTraceur: "I'm not sure why it's important, but Jared suggested it and May gave me the resources." [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [15:10:15] (PS1) Santhosh: Correct the regular expression for explicit plural forms [core] - https://gerrit.wikimedia.org/r/75341 [15:10:42] (CR) MarkTraceur: "Control-by-control makes sense because of the dependent change Ifed2860bb7cde7d3a5fc2fba82571a94e13128ba - if an entire form is set up wit" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur) [15:17:56] (CR) Umherirrender: "The added external_user was a bad merge from Patch Set 15 to Patch Set 16 and should be removed." [core] - https://gerrit.wikimedia.org/r/51675 (owner: Reedy) [15:21:18] (PS20) Reedy: Add archive, externallinks PK [core] - https://gerrit.wikimedia.org/r/51675 [15:21:21] (CR) Umherirrender: [C: 1] (bug 43282) Add per-namespace restrictions and rights to Special:ListGroupRights [core] - https://gerrit.wikimedia.org/r/40096 (owner: Alex Monk) [15:21:39] (PS21) Reedy: Add archive, externallinks PK [core] - https://gerrit.wikimedia.org/r/51675 [15:21:47] (PS1) Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343 [15:32:54] (CR) Reedy: "This could just be merged to core. It's not actually used for anything in MW itself yet, but would need pushing to WMF before doing that." [core] - https://gerrit.wikimedia.org/r/51675 (owner: Reedy) [15:36:28] andre__, yay status PATCH_TO_REVIEW :) [15:36:56] Krenair, ssh, I still need to announce that! [15:37:12] automatically setting it via the gerrit notification bot does not seem to work yet [15:37:17] but is planned soon(TM) [15:42:33] (PS1) Matmarex: Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 [15:46:01] (CR) Krinkle: "Do we need to introduce anoter syntax for this? Perhaps we can combine with the autoloader and/or class_exists, combined with fallback to " [core] - https://gerrit.wikimedia.org/r/56426 (owner: Daniel Friesen) [15:47:52] (CR) Krinkle: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/56426 (owner: Daniel Friesen) [16:00:37] (PS2) Matmarex: Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 [16:14:18] (CR) Parent5446: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/75346 (owner: Matmarex) [16:24:46] (CR) Anomie: [C: 2 V: 2] Process cache the central user ID [extensions/OAuth] - https://gerrit.wikimedia.org/r/74931 (owner: Aaron Schulz) [16:24:47] (Merged) Anomie: Process cache the central user ID [extensions/OAuth] - https://gerrit.wikimedia.org/r/74931 (owner: Aaron Schulz) [16:24:56] ^demon, why has Krinkle's -1 on https://gerrit.wikimedia.org/r/#/c/18229/ disappeared? [16:25:37] <^demon> Don't know. At the moment that's about the lowest priority thing on my list. [16:25:51] (PS2) Himeshi: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343 [16:25:57] Maybe he removed himself from the list or something [16:26:15] Not sure how long I've been ignoring his comments because it wasn't showing on my dashboard though [16:26:51] (PS3) Matmarex: Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 [16:27:20] (CR) Matmarex: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/75346 (owner: Matmarex) [16:27:26] parent5446: ^ thanks [16:27:50] np, I was thinking there must be a function for that. :P [16:28:08] (CR) Anomie: [C: 1] "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74932 (owner: Aaron Schulz) [16:28:13] yeah, so was i [16:28:18] but apparently there isn't [16:28:30] so many crappy useless functions in stdlib and this one is missing :P [16:28:40] Mhm [16:29:47] (CR) Parent5446: [C: 1] Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 (owner: Matmarex) [16:30:47] (CR) Anomie: [C: 2 V: 2] "I assume you've already checked any callers." [extensions/OAuth] - https://gerrit.wikimedia.org/r/74933 (owner: Aaron Schulz) [16:30:48] (Merged) Anomie: Made newFromNameVersionUser() not accept User objects to avoid confusion [extensions/OAuth] - https://gerrit.wikimedia.org/r/74933 (owner: Aaron Schulz) [16:42:34] (CR) Parent5446: [C: 2] Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 (owner: Matmarex) [16:43:27] yay parent5446. that was quick [16:44:09] Needed to test it first. Also wanted to make sure Language::formatNum handles decimals, which it does. So it's all good. [16:45:09] (Merged) jenkins-bot: Special:PagesWithProp: Do not show very long or binary values [core] - https://gerrit.wikimedia.org/r/75346 (owner: Matmarex) [16:47:12] (PS1) Krinkle: Fixup recently introduced regressions in HTML, UX, HiDPI and HTTPS [integration/docroot] - https://gerrit.wikimedia.org/r/75352 [16:47:35] (CR) Krinkle: [C: 2] Fixup recently introduced regressions in HTML, UX, HiDPI and HTTPS [integration/docroot] - https://gerrit.wikimedia.org/r/75352 (owner: Krinkle) [16:47:36] (Merged) Krinkle: Fixup recently introduced regressions in HTML, UX, HiDPI and HTTPS [integration/docroot] - https://gerrit.wikimedia.org/r/75352 (owner: Krinkle) [16:49:56] (CR) Santhosh: "(1 comment)" [extensions/cldr] - https://gerrit.wikimedia.org/r/45499 (owner: Kaldari) [16:50:00] (CR) Alex Monk: [C: -1] "Looks like Krinkle removed himself from the reviewers list, revoking his -1 and making it look okay from my review dashboard. -1ing myself" [extensions/Oversight] - https://gerrit.wikimedia.org/r/18229 (owner: Alex Monk) [16:57:38] (CR) Parent5446: [C: -1] "(2 comments)" [extensions/Oversight] - https://gerrit.wikimedia.org/r/18229 (owner: Alex Monk) [17:00:01] (PS13) Rjain: Added the destroy class [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 [17:00:56] (PS2) Rjain: Added the update class [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106 [17:01:46] (PS3) Helder.wiki: Load filter conditions when the user presses ENTER [extensions/AbuseFilter] - https://gerrit.wikimedia.org/r/74152 [17:18:18] (PS1) Aude: Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75359 [17:19:20] (CR) Nemo bis: "Before merging, please also briefly mention what was wrong with the previous situation, just "fix X" is not a very helpful commit message." [extensions/InlineCategorizer] - https://gerrit.wikimedia.org/r/73719 (owner: Shirayuki) [17:20:05] (PS2) Reedy: Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75359 (owner: Aude) [17:20:16] (CR) Reedy: [C: 2 V: 2] Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75359 (owner: Aude) [17:20:17] (Merged) Reedy: Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75359 (owner: Aude) [17:20:36] (PS1) Aude: Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75360 [17:21:21] (CR) Reedy: [C: 2 V: 2] Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75360 (owner: Aude) [17:21:22] (Merged) Reedy: Update Wikibase with patches for wikivoyage [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75360 (owner: Aude) [17:25:39] (PS2) Aaron Schulz: jobqueue: various cleanups to JobQueueFederated. [core] - https://gerrit.wikimedia.org/r/69448 [17:28:57] (CR) Hoo man: [C: 2] "Works like a charm, thanks for fixing :)" [extensions/AbuseFilter] - https://gerrit.wikimedia.org/r/74152 (owner: Helder.wiki) [17:29:14] (Merged) jenkins-bot: Load filter conditions when the user presses ENTER [extensions/AbuseFilter] - https://gerrit.wikimedia.org/r/74152 (owner: Helder.wiki) [17:29:40] (PS1) Krinkle: Fix broken navigation on doc.wikimedia.org [integration/docroot] - https://gerrit.wikimedia.org/r/75364 [17:30:25] (CR) Krinkle: [C: 2] Fix broken navigation on doc.wikimedia.org [integration/docroot] - https://gerrit.wikimedia.org/r/75364 (owner: Krinkle) [17:30:27] (Merged) jenkins-bot: Fix broken navigation on doc.wikimedia.org [integration/docroot] - https://gerrit.wikimedia.org/r/75364 (owner: Krinkle) [17:32:56] (CR) Hoo man: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [17:37:13] (PS7) Matmarex: Watchlist: Separate non-form parts out of the
[core] - https://gerrit.wikimedia.org/r/64557 [17:37:50] (CR) Matmarex: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/64557 (owner: Matmarex) [17:44:36] (PS1) Nilesh: Added doc comments to ClientRecommender classes and their methods [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75365 [17:48:05] mwalker: You around? [17:48:25] GorillaWarfare: yep [17:48:43] mwalker: Raylton and I are talking about the edit interface for the JSON [17:49:00] mwalker: And considering the possibility of using a special page for it [17:49:16] And were hoping for input from you [17:50:06] Raylton suggested the special page because it would allow going to Special:BookManagerv2 or similar to create the page, instead of having to go to [[$prefix:$bookname]] [17:51:00] what I've found in CentralNotice is that if you give people raw edit access to the page; they will edit the raw page [17:51:00] and damn the consequences [17:51:30] mwalker: Yeah, we need to prevent people from editing the raw JSON if at all possible [17:51:48] the SpecialPage isn't a bad idea; but you might want to just make it a redirect to the [[$prefix:$bookname]] [17:52:56] Well, if that's the end behavior, why use a special page at all? [17:54:08] easier discoverability? [17:54:17] and you can create a wizard process or something [17:54:39] Hmm [17:54:48] but; ya; there's not a huge amount of point right now if what you're focusing on is just the editor [17:55:59] (CR) Krinkle: "(1 comment)" [integration/docroot] - https://gerrit.wikimedia.org/r/74624 (owner: Hashar) [17:58:01] (PS1) Krinkle: More clean up [integration/docroot] - https://gerrit.wikimedia.org/r/75367 [17:58:15] (CR) Krinkle: [C: 2] More clean up [integration/docroot] - https://gerrit.wikimedia.org/r/75367 (owner: Krinkle) [17:58:16] (Merged) jenkins-bot: More clean up [integration/docroot] - https://gerrit.wikimedia.org/r/75367 (owner: Krinkle) [18:02:22] mwalker: Not a huge amount of point... to using special pages, you mean? [18:02:33] aye [18:02:38] at this point in time [18:02:52] from my perspective [18:17:14] (CR) TheDJ: "I don't fully agree with you on that Krinkle. With the limited time I spent on the actual codebase of MediaWiki, I need to look up that st" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [18:19:59] (PS1) Aude: Update Wikibase [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75370 [18:20:25] (CR) Krinkle: "Yes, so. Grunt. Certainly even easier to work, install, set up, and allows to be re-used with Jenkins (so we don't need to maintain two co" [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [18:22:14] thedj: for example Make doesn't work on Mac by default (need to install Xcode cli tools, which is harder than simple "npm install", which only requires nodejs) [18:22:32] and besides, it would still require npm install for jsint. [18:22:34] jshint* [18:25:41] (PS1) Aude: Update Wikibase to handle exception for missing sites [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75372 [18:26:05] (PS1) Nilesh: Added doc comments to Servlet classes and their methods [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75373 [18:26:44] (CR) Krinkle: "Also, Make is harder to install on Mac OS X for example (doesn't come by default, usually done by installing Xcode or Xcode-cli), whereas " [core] - https://gerrit.wikimedia.org/r/75268 (owner: Jdlrobson) [18:28:07] (PS1) Nilesh: Removed some autogenerated comments [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75374 [18:30:04] (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74400 (owner: Catrope) [18:35:24] (PS1) Nilesh: Added documentation for Hadoop InputFormat classes [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75381 [18:35:25] (PS1) Nilesh: Fixed extra space [extensions/WikidataEntitySuggester] - https://gerrit.wikimedia.org/r/75382 [18:36:07] I wonder if I'm the only one wondering why http://en.wikipedia.org/wiki/Template:Convert isn't a builtin feature [18:36:27] legoktm: The div form looks substantially better. :-)_ [18:36:29] :-) [18:36:48] :D [18:37:32] (CR) Reedy: [C: 2 V: 2] Update Wikibase [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75370 (owner: Aude) [18:37:33] (Merged) Reedy: Update Wikibase [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75370 (owner: Aude) [18:38:03] (CR) Legoktm: [C: 2 V: 2] Set form's display format to "div". This moves the labels on top of the fields. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75300 (owner: Legoktm) [18:38:04] (Merged) Legoktm: Set form's display format to "div". This moves the labels on top of the fields. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75300 (owner: Legoktm) [18:38:41] (PS1) Bsitu: Update email copy text [extensions/PageTriage] - https://gerrit.wikimedia.org/r/75408 [18:39:05] legoktm: Add an intro message and a confirmation screen? [18:39:10] I think you're getting closer. :-) [18:39:26] Ah, I have the intro message one locally, just never pushed to gerrit [18:40:14] > Subject of the message (also used in the edit summary): [18:40:21] Lowercase A, s/as/in/ [18:40:32] That field should also have a sanity check on its limit. [18:40:37] No more than like 240 bytes or something. [18:40:47] You can put the check on the HTML and/or in the PHP logic. [18:40:58] Probably just in the HTML is fine, if you have a confirmation screen. [18:41:07] If people really want truncated edit summaries, mehhh. [18:43:17] (PS1) Legoktm: Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 [18:43:19] (CR) jenkins-bot: [V: -1] Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 (owner: Legoktm) [18:43:37] heh [18:44:05] (PS2) Legoktm: Add an introduction message at the top of the form. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75446 [18:46:08] (CR) Aaron Schulz: "(3 comments)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977 (owner: Anomie) [18:46:13] Elsie: The message is kinda sucky and needs to be improved ^ [18:52:28] * legoktm pokes grrrit-wm? [18:52:37] Elsie: https://gerrit.wikimedia.org/r/#/c/75473/ [18:55:54] (PS1) Legoktm: Set a maxlength for the subject line so we don't end up with truncated edit summaries [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75473 [18:58:37] (CR) Nikerabbit: "There is JavaScript module which does this on bytes instead of characters." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75473 (owner: Legoktm) [18:59:09] Nikerabbit: Ooh. Do you know where I can find said module? [18:59:17] legoktm: jquery.byteLimit incore [18:59:29] legoktm: it's used for edit summaries and on special:movepage [18:59:43] Ok, I'll look to see how its used there [19:00:00] $( '#wpReason, #wpNewTitleMain' ).byteLimit(); [19:00:05] :) [19:00:27] errr…I'm not very good with JS so I'm not sure what that means [19:01:41] https://github.com/wikimedia/mediawiki-core/blob/master/resources/mediawiki.special/mediawiki.special.movePage.js [19:02:09] MatmaRex: Do I need to pass 240 to byteLimit somehow or does it automatically know that? [19:02:21] oh. well, that is basically what's needed to make this run [19:02:38] legoktm: i think it uses the value from maxlength attribute by default [19:02:45] Ok. [19:06:23] MatmaRex: Is the '#blah', the id or the name of the