[00:40:21] <grrrit-wm>	 (CR) Krinkle: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/75056 (owner: SuchABot)
[00:53:13] <grrrit-wm>	 (CR) Parent5446: [C: 2 V: 2] Fix issue with images not being uploaded [extensions/AWS] - https://gerrit.wikimedia.org/r/73737 (owner: Thaiphan)
[00:53:14] <grrrit-wm>	 (Merged) Parent5446: Fix issue with images not being uploaded [extensions/AWS] - https://gerrit.wikimedia.org/r/73737 (owner: Thaiphan)
[02:07:09] <grrrit-wm>	 (PS1) Shirayuki: Remove leading whitespace from message [extensions/EtherEditor] - https://gerrit.wikimedia.org/r/75060
[02:39:44] <grrrit-wm>	 (PS1) Shirayuki: Fix double-whitespace [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/75061
[02:40:13] <grrrit-wm>	 (CR) Siebrand: [C: 2] "I don't think this is worth the bikeshed. Thanks for harmonizing, Timo." [core] - https://gerrit.wikimedia.org/r/74079 (owner: Krinkle)
[02:42:56] <grrrit-wm>	 (Merged) jenkins-bot: Clean up: Consistently use "$" instead of "$( document ).ready" [core] - https://gerrit.wikimedia.org/r/74079 (owner: Krinkle)
[02:50:20] <grrrit-wm>	 (CR) MZMcBride: ""GMD" is an opaque initialism." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74941 (owner: Legoktm)
[02:50:22] <grrrit-wm>	 (PS1) Shirayuki: Replace "X-query" by "XQuery" [extensions/MathSearch] - https://gerrit.wikimedia.org/r/75062
[02:50:58] <legoktm>	 Elsie: Heh.
[02:51:38] <Elsie>	 legoktm: Also, God help me, I hope this is only installed on Meta-Wiki. :-/
[02:51:56] <Elsie>	 Though I can see its application on individual wikis.
[02:51:59] <Elsie>	 So much spam, though. :-(
[02:52:22] <Elsie>	 legoktm: Have you implemented local pagelinks support?
[02:52:32] <legoktm>	 Elsie: Ideally meta would be the only wiki you could send global messages from, but it's local features are still useful
[02:52:34] <legoktm>	 Yes
[02:52:48] <legoktm>	 It is currently working if you want to send local messages
[02:53:03] <Elsie>	 Do you have a public test wiki with the extension installed?
[02:53:29] <legoktm>	 No…should I do that?
[02:53:54] <Elsie>	 I was just curious for myself personally.
[02:54:09] <Elsie>	 A Labs wiki might be nice.
[02:54:26] <legoktm>	 I'll look into setting one up
[02:54:26] <Elsie>	 But not at all necessary or expected.
[02:54:26] <Elsie>	 Cool. :-)
[02:54:27] <Elsie>	 Then I can break it!
[02:54:59] <legoktm>	 :D
[02:55:32] <legoktm>	 I was looking into how to go from interwiki prefix --> api url, and I think I've figured it out.
[02:58:01] <legoktm>	 interwiki prefix --> url (en.w.o/wiki/$1) --> some regex to get the base url (en.w.o) --> SiteMatrix to get the database id --> WikiMap (which uses $wgConf i think) to get a SiteReference object!
[03:00:30] <Elsie>	 Errrrrrrr.
[03:00:38] <Elsie>	 No regex, please.
[03:00:49] <legoktm>	 Heh.
[03:00:53] <legoktm>	 Well it doesn't have to be regex
[03:01:03] <Elsie>	 I think PHP has an equivalent to Python's urlparse.
[03:01:08] <Elsie>	 Or I think MediaWiki does, at least.
[03:01:09] <legoktm>	 I'm not sure how PHP does it, but in Python it would be url.split('/', 1)[0]
[03:01:14] <legoktm>	 Oh, that would be even better
[03:01:19] <Elsie>	 It wouldn't be that in Python. ;-)
[03:01:45] <legoktm>	 Oh yeah. I'd need to remove the http:// from the front first.
[03:02:07] <Elsie>	 You're going to have a SiteMatrix dependency?
[03:03:04] <legoktm>	 I might.
[03:03:08] <legoktm>	 I'm hoping I don't.
[03:03:51] <legoktm>	 It's the only way I know how to go from url --> database id though.
[03:04:25] <grrrit-wm>	 (CR) Parent5446: [C: -2] "Other change was merged. Not starting a commit war here." [core] - https://gerrit.wikimedia.org/r/75056 (owner: SuchABot)
[03:04:43] <legoktm>	 MariaDB [metawiki_p]> select * from interwiki;
[03:04:43] <legoktm>	 Empty set (0.03 sec)
[03:04:46] <legoktm>	 Hmmmm.
[03:05:24] <legoktm>	 Same on the toolserver….it's not populated I guess?
[03:06:19] <Elsie>	 The Interwiki extension is reading from something.
[03:06:30] <Elsie>	 I'm not honestly sure what.
[03:06:36] <Elsie>	 I got distracted.
[03:10:25] <grrrit-wm>	 (PS3) Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938
[03:11:11] <grrrit-wm>	 (CR) Legoktm: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm)
[03:16:46] <grrrit-wm>	 (CR) Legoktm: "The account should never be renamed unless the configuration variable ($wgMassMessageAccountUsername) is also updated at the same time." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm)
[03:19:51] <grrrit-wm>	 (CR) MZMcBride: "(6 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm)
[03:33:58] <grrrit-wm>	 (CR) MZMcBride: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74939 (owner: Legoktm)
[04:20:01] <grrrit-wm>	 (PS1) Santhosh: Add linktrail for Malayalam [core] - https://gerrit.wikimedia.org/r/75063
[04:26:20] <grrrit-wm>	 (CR) Santhosh: [C: 2] Fix double-whitespace [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/75061 (owner: Shirayuki)
[04:27:34] <grrrit-wm>	 (Merged) jenkins-bot: Fix double-whitespace [extensions/TranslationNotifications] - https://gerrit.wikimedia.org/r/75061 (owner: Shirayuki)
[04:27:52] <grrrit-wm>	 (CR) Santhosh: [C: 2] Fixed case in i18n messages [extensions/ThrottleOverride] - https://gerrit.wikimedia.org/r/75057 (owner: Parent5446)
[04:34:11] <grrrit-wm>	 (CR) Santhosh: [C: 2] Fill i18n file [extensions/Annotator] - https://gerrit.wikimedia.org/r/74830 (owner: Raimond Spekking)
[04:34:11] <grrrit-wm>	 (Merged) jenkins-bot: Fill i18n file [extensions/Annotator] - https://gerrit.wikimedia.org/r/74830 (owner: Raimond Spekking)
[04:37:26] <grrrit-wm>	 (CR) Santhosh: "(1 comment)" [extensions/GuidedTour/guiders] - https://gerrit.wikimedia.org/r/74820 (owner: Mattflaschen)
[05:26:14] <grrrit-wm>	 (PS2) Nikerabbit: (Bug 50861) Debug Yandex translation service failures [extensions/Translate] - https://gerrit.wikimedia.org/r/74853 (owner: Lockal)
[05:28:18] <grrrit-wm>	 (CR) Nikerabbit: "This looks good! I have two questions though:" [extensions/Translate] - https://gerrit.wikimedia.org/r/74853 (owner: Lockal)
[06:20:46] <legoktm>	 Elsie: http://legoktm.instance-proxy.wmflabs.org/wiki/Special:MassMessage
[06:21:46] <legoktm>	 That's running the version that's currently in the repo
[06:22:23] <Elsie>	 Thanks!
[06:22:53] <legoktm>	 Oh hm
[06:23:04] <legoktm>	 It uses the job queue to send messages, and right now I set that for hourly
[06:23:29] <Elsie>	 Can you set that to minutely? :-)
[06:23:30] <legoktm>	 Lemme just set it to every minute...
[06:23:32] <legoktm>	 Yes :P
[06:23:34] <Elsie>	 Also, I think I caused a PHP fatal error.
[06:23:43] <legoktm>	 What did you do o.O
[06:23:51] <Elsie>	 Can you enable error reporting?
[06:23:57] <legoktm>	 Sure, one sec
[06:24:25] <Elsie>	 That's a pretty logo, BTW.
[06:24:32] <Elsie>	 Not sure if you had anything to do with it.
[06:25:02] <legoktm>	 Nope!
[06:25:05] <legoktm>	 Should be enabled now
[06:25:21] <Elsie>	 > Notice: Undefined index: global in /srv/mediawiki/extensions/MassMessage/SpecialMassMessage.php on line 138 Fatal error: Call to a member function getArticleID() on a non-object in /srv/mediawiki/extensions/MassMessage/SpecialMassMessage.php on line 141
[06:25:39] <Elsie>	 Input was:
[06:25:45] <Elsie>	 "Main Pageeeeee<"
[06:25:55] <Elsie>	 [blank]
[06:25:56] <Elsie>	 [blank]
[06:25:58] <Elsie>	 For the three inputs.
[06:26:06] <Elsie>	 That form is wicked ugly, BTW. But that's unimportant.
[06:26:14] <Elsie>	 For now, at least.
[06:26:32] <Elsie>	 You wanna fix that fatal or should I keep going?
[06:26:45] <legoktm>	 Keep going, I'm looking into it right now
[06:27:14] <legoktm>	 		if ( $spamlist->getArticleID() == 0 ) {
[06:27:14] <legoktm>	 			$status->fatal( 'massmessage-spamlist-doesnotexist' );
[06:27:33] <legoktm>	 		$spamlist = Title::newFromText( $data['spamlist'] ); <-- I'm guessing that failed because of your <
[06:27:51] <Elsie>	 With a valid page list, I got...
[06:27:54] <Elsie>	 Notice: Undefined index: global in /srv/mediawiki/extensions/MassMessage/SpecialMassMessage.php on line 138
[06:27:57] <Elsie>	 After form submission.
[06:28:03] <Elsie>	 But it says it was sent.
[06:28:14] <Elsie>	 A lot of these messages are gonna need to be re-worked.
[06:28:31] <Elsie>	 If possible, I'd hold off on having people translate anything until this is a bit more stable, personally.
[06:29:16] <legoktm>	 The global one is because I added a line of code for GMD, but never really finished it.
[06:29:28] <Elsie>	 K.
[06:29:36] <Elsie>	 It says the message was sent and it logged it.
[06:29:54] <Elsie>	 Not sure what it's supposed to do next.
[06:30:17] <legoktm>	 Ah, I never set the crontab
[06:30:40] <legoktm>	 I just ran the job queue manually
[06:30:47] <Elsie>	 Can't you just set the jobs to run immediately?
[06:31:07] <legoktm>	 Can you? I set it to run every minute.
[06:31:16] <legoktm>	 Anyways, you should have "new messages"
[06:31:21] <Elsie>	 I dunno.
[06:31:35] <Elsie>	 Whee, it worked. :-)
[06:31:43] <Elsie>	 http://legoktm.instance-proxy.wmflabs.org/wiki/Special:Contributions/MessengerBot
[06:31:54] <legoktm>	 :D
[06:32:15] <Elsie>	 Marked as a bot and everything.
[06:32:29] <Elsie>	 It should be using &section=new.
[06:33:09] <legoktm>	 Does it make a difference?
[06:33:13] <legoktm>	 Besides edit summary I guess.
[06:33:18] <Elsie>	 Edit summary, yeah.
[06:33:48] <Elsie>	 "[[Main Page]]" as an input for page list also blows up.
[06:33:57] <Elsie>	 Gonna need some better error handling there. :-)
[06:33:58] <legoktm>	 Hold on, I'm committing the fix
[06:34:07] <Elsie>	 Sweet.
[06:34:25] <Elsie>	 That dropdown should also use title suggestions, BTW.
[06:34:37] <Elsie>	 But that's an enhancement request.
[06:36:05] <grrrit-wm>	 (PS1) Legoktm: Title::newFromText will return null if the user provides an invalid title [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75064
[06:36:12] <legoktm>	 Elsie: ^
[06:38:21] <Elsie>	 I feel like if !$spamlist is better there.
[06:38:26] <Elsie>	 But I really don't know PHP.
[06:38:43] <Elsie>	 === null feels weird, but could be perfectly sane.
[06:38:59] <legoktm>	 From what I've seen in reading other people's code, most people use === null, whereas !$var is normally used for false.
[06:39:08] <Elsie>	 if !$spamlist or maybe is_null($spamlist) ?
[06:39:14] <Elsie>	 K.
[06:39:24] <Elsie>	 I have other notes. I suppose I should put them on the wiki.
[06:39:59] <legoktm>	 Er, put them on mw.o, not the labs wiki.
[06:40:04] <Elsie>	 Right.
[06:40:19] <Elsie>	 I've learned my lesson about trying to use a labs wiki for that kind of thing. ;-)
[06:41:57] <legoktm>	 :
[06:42:00] <legoktm>	 P
[06:46:59] <Elsie>	 https://www.mediawiki.org/w/index.php?title=Extension:MassMessage/Design&diff=743367&oldid=743336
[06:47:04] <Elsie>	 VisualEditor said I was using wikitext there.
[06:47:05] <Elsie>	 wtf
[06:47:36] <Elsie>	 Hmmmm. Maybe the {{nobots}} above.
[06:47:56] <legoktm>	 Heh.
[06:47:57] <Elsie>	 legoktm: This is exciting. :-)
[06:48:07] <legoktm>	 I know :D
[06:48:16] <Elsie>	 I think the job queue is stuck again.
[06:48:21] <legoktm>	 erp
[06:48:31] <legoktm>	 No, it's empty
[06:48:43] <legoktm>	 Or at least when I ran it manually a second ago it was
[06:48:46] <Elsie>	 If I leave body and subject blank, it says it was successful.
[06:48:56] <Elsie>	 It may just silently discard my delivery, though?
[06:49:07] <Elsie>	 http://legoktm.instance-proxy.wmflabs.org/wiki/Special:Log
[06:49:26] <legoktm>	 No, it queues the jobs, but will make no edits
[06:49:49] <legoktm>	 Well it will attempt to make an edit, but newtext == original text, so nothing is ever edited.
[06:50:11] <Elsie>	 I tell you what, MediaWiki is crazy fast on this proxy, though.
[06:50:14] <Elsie>	 Crazy fast.
[06:50:33] <Elsie>	 legoktm: K, so it'll just need better error catching during form submission.
[06:50:55] <legoktm>	 Yeah. Right now it just validates title
[06:51:02] <Elsie>	 Right.
[06:51:07] <Elsie>	 I use edit summaries on test wikis.
[06:51:09] <Elsie>	 Because I'm insane.
[06:51:56] <legoktm>	 Hm
[06:52:12] <legoktm>	 (Mass message log); 06:44 . . Admin (Talk | contribs | block) sent a message to Gravy ‎ <-- Actually I think that one didn't make any edits is because Gravy is a redirect and has no page links.
[06:52:24] <legoktm>	 And also because I assume it had no content.
[06:52:31] <Elsie>	 Probably a mixture.
[06:52:37] <Elsie>	 I sent another.
[06:52:43] <Elsie>	 But that third run also seems to not be working.
[06:52:46] <Elsie>	 No idea why.
[06:53:25] <legoktm>	 Because [[Gravy]] is a redirect page....
[06:53:33] <Elsie>	 I'll add that to my notes, then.
[06:53:35] <legoktm>	 it doesn't follow redirects.
[06:53:53] <Elsie>	 Not yet!
[06:54:08] <Elsie>	 https://www.mediawiki.org/wiki/Extension:MassMessage/Design#MZ_notes
[06:54:40] <Elsie>	 legoktm: How's the job queue look now?
[06:54:53] <Elsie>	 I've logged four deliveries, but only one has worked, I think.
[06:54:59] <legoktm>	 I just emptied it manually
[06:55:00] <Elsie>	 Oop, there it goes.
[06:55:06] <Elsie>	 Okay, the fourth run looks to have worked.
[06:56:13] <grrrit-wm>	 (PS1) Legoktm: Check that a value for global messaging is set before using it's value [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75066
[06:56:27] <legoktm>	 ^That fixes the global undefined variable bug
[06:58:38] <Elsie>	 https://www.mediawiki.org/wiki/Extension:MassMessage/Design#MZ_notes should keep you busy for a while.
[06:59:20] <legoktm>	 > possible to spam the same talk page twice with a single delivery (ouch) <-- isnt the pagelinks table unique?
[06:59:38] <Elsie>	 It should be.
[06:59:45] <Elsie>	 http://legoktm.instance-proxy.wmflabs.org/w/index.php?title=User_talk:Admin&action=history
[07:00:05] <Elsie>	 legoktm: [[User:Admin]] and [[User talk:Admin]] on the same page. :-)
[07:00:21] <legoktm>	 > possible to deliver to user talk pages of non-existent users <-- i don't think thats a bug…we let messages get sent to [[Project:Blah]]
[07:00:27] <legoktm>	 Elsie: Ah. Hmm
[07:00:28] <Elsie>	 That counts as two targets currently.
[07:00:28] <Elsie>	 You may need to de-dupe in app logic.
[07:00:43] <Elsie>	 You shouldn't post to user talk pages of non-existent users.
[07:00:49] <Elsie>	 Project pages are different.
[07:00:56] <Elsie>	 User talk pages have an owner (or not).
[07:01:27] <legoktm>	 Ok
[07:02:12] <Elsie>	 legoktm: Can you clear the queue once more?
[07:02:16] <legoktm>	 sure
[07:02:21] <legoktm>	 done
[07:03:43] <Elsie>	 Any other questions for me while I'm here and focused on this?
[07:03:57] <Elsie>	 legoktm: ^
[07:04:58] <legoktm>	 Er, not off the top of my head.
[07:05:28] <Elsie>	 K.
[07:05:30] <Elsie>	 Let me know when I can test again.
[07:08:37] <Elsie>	 https://en.wikipedia.org/wiki/Tin_foil_hat
[07:08:40] <grrrit-wm>	 (PS1) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068
[07:09:04] <legoktm>	 I'm not sure about the performance impacts about that, nor have I tested it yet.
[07:09:30] <grrrit-wm>	 (CR) Legoktm: [C: 2 V: 2] "Works." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75064 (owner: Legoktm)
[07:09:31] <grrrit-wm>	 (Merged) Legoktm: Title::newFromText will return null if the user provides an invalid title [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75064 (owner: Legoktm)
[07:10:14] <grrrit-wm>	 (Abandoned) Legoktm: Add a configuration option to respect the {{nobots}} exclusion syntax [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74939 (owner: Legoktm)
[07:10:37] <Elsie>	 legoktm: Do you want me to tell you how to do that? ^
[07:10:41] <Elsie>	 Or do you want to figure that out on your own?
[07:10:56] <legoktm>	 Elsie: The de-duping feature?
[07:11:05] <Elsie>	 The nobots thing.
[07:11:16] <legoktm>	 Oh, not really. I think {{nobots}} is stupid.
[07:11:21] <Elsie>	 K.
[07:11:30] <legoktm>	 $wgNoNoBots
[07:11:35] <Elsie>	 :D
[07:12:10] <legoktm>	 >  [[user talk:Admin/{{#time:Y|20130722065908}}]]  <-- heh, I didn't install ParserFunctions.
[07:12:35] <Elsie>	 So I noticed. ;-)
[07:13:35] <Elsie>	 legoktm: I'm not sure how to properly catch invalid input.
[07:13:42] <Elsie>	 But I think it's probably an important feature.
[07:13:49] <Elsie>	 Because users are idiots.
[07:13:54] <legoktm>	 In the body of the message?
[07:14:03] <Elsie>	 Or the subject, yeah.
[07:14:04] <legoktm>	 Like if someone left a <small> tag open at the end?
[07:14:12] <Elsie>	 Or worse, <!--, yeah.
[07:14:27] <legoktm>	 Hm.
[07:14:34] <Elsie>	 http://legoktm.instance-proxy.wmflabs.org/w/index.php?title=Testwiki:Hello&diff=23&oldid=22
[07:14:49] <Elsie>	 Fun fact: an unclosed HTML comment prevents subsequent expansion of wikitext.
[07:14:53] <Elsie>	 Such as ~~~.
[07:15:08] <legoktm>	 Maybe some javascript parser that pops up a huge red stop sign if you don't close your tags? :P
[07:15:21] <Elsie>	 Maybe.
[07:15:28] <legoktm>	 A preview button would probably be nice.
[07:15:30] <Elsie>	 Even more fun, people make constructs such as <nowiki>{{</nowiki>foo}}.
[07:15:41] <legoktm>	 Let people use the VisualEditor!
[07:15:43] <Elsie>	 Which then can carry across pages in really bizarre ways.
[07:15:58] <Elsie>	 Or more like...
[07:16:10] <Elsie>	 {{foo<nowiki>}}</nowiki> in a top section.
[07:16:46] <Elsie>	 And then later on }} ends up closing the template several sections below.
[07:16:46] <Elsie>	 Wikitext is the worst.
[07:20:35] <legoktm>	 Elsie: Ok, the "Main Page :>>>" title bug should be fixed on the testwiki.
[07:24:43] <grrrit-wm>	 (CR) Legoktm: "I'm mainly concerned about the performance impacts of this if the spamlist has ~2k entries." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068 (owner: Legoktm)
[07:28:21] <grrrit-wm>	 (CR) Legoktm: [C: 2 V: 2] "Works." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75066 (owner: Legoktm)
[07:28:22] <grrrit-wm>	 (Merged) Legoktm: Check that a value for global messaging is set before using it's value [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75066 (owner: Legoktm)
[07:28:44] <Elsie>	 its
[07:28:45] <Elsie>	 itsssssssssss
[07:29:14] <legoktm>	 Oops.
[07:29:32] <mose>	 :)
[07:42:16] <grrrit-wm>	 (PS3) Hashar: option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911
[07:42:39] <grrrit-wm>	 (CR) Hashar: "Rebased to fix conflict in release notes" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[07:44:37] <grrrit-wm>	 (PS1) Legoktm: Don't leave messages for non-existent users [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072
[08:04:58] <grrrit-wm>	 (PS1) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073
[08:12:36] <grrrit-wm>	 (PS1) Santhosh: Close language settings when clicked outside [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75076
[08:22:25] <grrrit-wm>	 (CR) Zfilipin: "I think this should be merged into master." [qa/browsertests] - https://gerrit.wikimedia.org/r/74386 (owner: Zfilipin)
[08:42:56] <grrrit-wm>	 (CR) Hashar: [C: 2] Add linktrail for Malayalam [core] - https://gerrit.wikimedia.org/r/75063 (owner: Santhosh)
[08:44:32] <grrrit-wm>	 (PS1) Santhosh: Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75077
[08:45:29] <grrrit-wm>	 (Merged) jenkins-bot: Add linktrail for Malayalam [core] - https://gerrit.wikimedia.org/r/75063 (owner: Santhosh)
[08:50:55] <grrrit-wm>	 (CR) Amire80: [C: 2] Close language settings when clicked outside [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75076 (owner: Santhosh)
[08:51:15] <grrrit-wm>	 (Merged) jenkins-bot: Close language settings when clicked outside [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75076 (owner: Santhosh)
[08:51:52] <grrrit-wm>	 (CR) Amire80: [C: 2] Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75077 (owner: Santhosh)
[08:52:08] <grrrit-wm>	 (Merged) jenkins-bot: Update jquery.ime from upstream [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75077 (owner: Santhosh)
[09:26:52] <grrrit-wm>	 (PS1) Pginer: inline-block mixin added to button groups [core] - https://gerrit.wikimedia.org/r/75079
[09:37:51] <grrrit-wm>	 (Abandoned) Yuvipanda: Consistently use $( document ).ready( fn ) everywhere [core] - https://gerrit.wikimedia.org/r/75056 (owner: SuchABot)
[09:45:29] <grrrit-wm>	 (PS1) Legoktm: Possible error messages for action=createaccount should be in English and not show local modifications [core] - https://gerrit.wikimedia.org/r/75081
[09:56:01] <grrrit-wm>	 (PS3) Matthias Mullie: Send Echo notification upon submitting/moderating feedback [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/74166
[10:17:47] <grrrit-wm>	 (CR) Tobias Gritschacher: "The fix here causes problems: e.g. on" [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75076 (owner: Santhosh)
[10:40:46] <grrrit-wm>	 (PS2) Matthias Mullie: Improve oversight request email [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979
[10:42:55] <grrrit-wm>	 (PS1) Santhosh: Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086
[10:45:33] <grrrit-wm>	 (CR) Amire80: [C: 2] Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[10:48:03] <grrrit-wm>	 (CR) Daniel Kinzler: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74176 (owner: Daniel Kinzler)
[10:52:53] <grrrit-wm>	 (PS3) Matmarex: jquery.makeCollapsible: tests for collapse and expand text [core] - https://gerrit.wikimedia.org/r/74959
[10:59:15] <grrrit-wm>	 (PS1) Zfilipin: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088
[11:02:30] <hashar>	 I am restarting Jenkins it is deadlocked
[11:05:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Improve oversight request email [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979 (owner: Matthias Mullie)
[11:05:46] <grrrit-wm>	 (CR) Lockal: "1) There is no RSS or maillist for this. The documentation at http://api.yandex.com/translate/doc/dg/ is the only recommended way to obtai" [extensions/Translate] - https://gerrit.wikimedia.org/r/74853 (owner: Lockal)
[11:06:18] <grrrit-wm>	 (CR) Matmarex: [C: -1] "Needs rebase because of the $.ready consistency fix." [core] - https://gerrit.wikimedia.org/r/74312 (owner: Krinkle)
[11:06:19] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[11:06:32] <grrrit-wm>	 (PS1) Yuvipanda: Remove defunct androlog properties file [apps/android/commons] - https://gerrit.wikimedia.org/r/75089 (via SuchABot)
[11:06:54] <grrrit-wm>	 (CR) Yuvipanda: [C: 2 V: 2] "Trivial merge" [apps/android/commons] - https://gerrit.wikimedia.org/r/75089 (owner: SuchABot)
[11:06:55] <grrrit-wm>	 (Merged) Yuvipanda: Remove defunct androlog properties file [apps/android/commons] - https://gerrit.wikimedia.org/r/75089 (owner: SuchABot)
[11:08:32] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[11:08:43] <grrrit-wm>	 (PS1) Rillke: Filename: Using text instead of HTML to avoid exploitable [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090
[11:12:15] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] jquery.makeCollapsible: Tests for collapse and expand text [core] - https://gerrit.wikimedia.org/r/74959 (owner: Matmarex)
[11:12:23] <grrrit-wm>	 (CR) Yuvipanda: "Thanks for the patch! Looks good to me, let me test locally and then merge." [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090 (owner: Rillke)
[11:12:54] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088 (owner: Zfilipin)
[11:15:40] <grrrit-wm>	 (PS4) Matmarex: jquery.makeCollapsible: Tests for collapse and expand text [core] - https://gerrit.wikimedia.org/r/74959
[11:15:47] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Filename: Using text instead of HTML to avoid exploitable [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090 (owner: Rillke)
[11:20:36] <grrrit-wm>	 (PS1) Yuvipanda: Add Prateek to CREDITS [apps/android/commons] - https://gerrit.wikimedia.org/r/75092 (via SuchABot)
[11:20:55] <grrrit-wm>	 (CR) Yuvipanda: [C: 2 V: 2] "Trivial" [apps/android/commons] - https://gerrit.wikimedia.org/r/75092 (owner: SuchABot)
[11:20:57] <grrrit-wm>	 (Merged) Yuvipanda: Add Prateek to CREDITS [apps/android/commons] - https://gerrit.wikimedia.org/r/75092 (owner: SuchABot)
[11:22:35] <grrrit-wm>	 (CR) Matmarex: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[11:23:35] <grrrit-wm>	 (CR) Matmarex: [C: 1] "jenkins was being restarted when you submitted this, ignore it. (And blame hashar :D)" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090 (owner: Rillke)
[11:24:16] <grrrit-wm>	 (PS3) Hashar: Improve oversight request email [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979 (owner: Matthias Mullie)
[11:24:26] <grrrit-wm>	 (CR) Hashar: "retriggering (jenkins outage)" [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979 (owner: Matthias Mullie)
[11:25:31] <grrrit-wm>	 (PS2) Hashar: Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[11:25:50] <grrrit-wm>	 (CR) Hashar: "tweaked commit summary to reference the commit sha1 and to retrigger jenkins jobs." [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[11:26:32] <grrrit-wm>	 (PS2) Hashar: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/75088 (owner: Zfilipin)
[11:27:22] <grrrit-wm>	 (CR) Matmarex: "Bonk?" [core] - https://gerrit.wikimedia.org/r/47821 (owner: Parent5446)
[11:29:58] <grrrit-wm>	 (CR) Matmarex: [C: 2] "Doesn't grep, let's do this." [extensions/LiquidThreads] - https://gerrit.wikimedia.org/r/67595 (owner: Nemo bis)
[11:30:01] <grrrit-wm>	 (Merged) jenkins-bot: Remove unused lqt_rc CSS classes [extensions/LiquidThreads] - https://gerrit.wikimedia.org/r/67595 (owner: Nemo bis)
[11:35:52] <grrrit-wm>	 (CR) Matmarex: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/72844 (owner: MarkTraceur)
[11:41:31] <grrrit-wm>	 (CR) Yuvipanda: [C: 2] DifferenceEngine: Remove broken comment [core] - https://gerrit.wikimedia.org/r/67850 (owner: Matmarex)
[11:44:01] <grrrit-wm>	 (CR) Yuvipanda: [C: -1] "What Roan said." [core] - https://gerrit.wikimedia.org/r/73177 (owner: Matmarex)
[11:44:04] <grrrit-wm>	 (Merged) jenkins-bot: DifferenceEngine: Remove broken comment [core] - https://gerrit.wikimedia.org/r/67850 (owner: Matmarex)
[11:44:41] <grrrit-wm>	 (CR) Matmarex: [C: -2] "Pending better times." [core] - https://gerrit.wikimedia.org/r/73177 (owner: Matmarex)
[11:48:42] <grrrit-wm>	 (CR) Matmarex: [C: -1] "Per Siebrand." [core] - https://gerrit.wikimedia.org/r/38743 (owner: Luis Felipe Schenone)
[11:48:54] <grrrit-wm>	 (CR) Matmarex: "Also, needs rebase." [core] - https://gerrit.wikimedia.org/r/38743 (owner: Luis Felipe Schenone)
[11:54:29] <grrrit-wm>	 (CR) Matmarex: [C: -1] "There's a merge conflict in ApiWatch.php." [core] - https://gerrit.wikimedia.org/r/53964 (owner: Eranroz)
[12:00:25] <grrrit-wm>	 (CR) Matmarex: [C: -1] "The way the message is defined causes one of the links to be embedded inside the other, breaking formatting." [core] - https://gerrit.wikimedia.org/r/73611 (owner: Nemo bis)
[12:03:50] <grrrit-wm>	 (PS1) Zfilipin: WIP script that checks how often NewPagesFeed page breaks [qa/browsertests] - https://gerrit.wikimedia.org/r/75093
[12:06:25] <grrrit-wm>	 (CR) Parent5446: [C: 1] option to strip requested prefix index in the list [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[12:06:46] <grrrit-wm>	 (Merged) Parent5446: Fixed case in i18n messages [extensions/ThrottleOverride] - https://gerrit.wikimedia.org/r/75057 (owner: Parent5446)
[12:08:11] <grrrit-wm>	 (CR) Yuvipanda: [C: 2] Filename: Using text instead of HTML to avoid exploitable [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090 (owner: Rillke)
[12:08:37] <grrrit-wm>	 (CR) Parent5446: [C: 2] Possible error messages for action=createaccount should be in English and not show local modifications [core] - https://gerrit.wikimedia.org/r/75081 (owner: Legoktm)
[12:09:00] <grrrit-wm>	 (Merged) jenkins-bot: Filename: Using text instead of HTML to avoid exploitable [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75090 (owner: Rillke)
[12:11:33] <grrrit-wm>	 (Merged) jenkins-bot: Possible error messages for action=createaccount should be in English and not show local modifications [core] - https://gerrit.wikimedia.org/r/75081 (owner: Legoktm)
[12:11:54] <grrrit-wm>	 (CR) Yuvipanda: [C: 2] Special:ListGroupRights: Display the legend at the top [core] - https://gerrit.wikimedia.org/r/74660 (owner: Matmarex)
[12:12:08] <YuviPanda>	 MatmaRex: I think that's all the trivial patchsets
[12:12:31] <YuviPanda>	 MatmaRex: tell me if I'm wrong.
[12:15:07] <grrrit-wm>	 (Merged) jenkins-bot: Special:ListGroupRights: Display the legend at the top [core] - https://gerrit.wikimedia.org/r/74660 (owner: Matmarex)
[12:16:09] <MatmaRex>	 YuviPanda: how about the tests for makeCollapsible?
[12:18:03] <YuviPanda>	 MatmaRex: I've not really worked with any of the unit testing stuff in mediawiki, so a bit reluctant
[12:18:33] <YuviPanda>	 MatmaRex: however, if it is still unmerged by saturday, I'll happily read up on our unit testing stuff and then merge it
[12:19:53] <MatmaRex>	 YuviPanda: JS unit tests are quite easy to graspand run
[12:19:58] <MatmaRex>	 unlike the PHP ones, which suck ass
[12:23:27] <MatmaRex>	 you toggle a wg variables and visit [[special:javascripttest]], and that's it
[12:23:27] <YuviPanda>	 hmm, tempting
[12:23:27] <MatmaRex>	 wg variable*
[12:23:27] <MatmaRex>	 whose name i've forgotten, but can look up
[12:23:27] <MatmaRex>	 wgEnableJavaScriptTest
[12:23:28] <YuviPanda>	 MatmaRex: hmm, true. But I think I need to get back to android stuff now, haven't done any 'work' since last thursday.
[12:23:28] <YuviPanda>	 MatmaRex: will look at it later. At *worst*, saturday, if it isn't merged by then
[12:23:28] <MatmaRex>	 thanks
[12:23:28] <YuviPanda>	 jenkins also has given a -1 to the base-most commit, so that should be fixed? Either in jenkins config or the test
[12:23:31] <MatmaRex>	 no, the last commit is -1'd?
[12:23:39] <MatmaRex>	 i haven't had time to figure out why
[12:23:55] <YuviPanda>	 ah, gah. right. i mixed depends on and needed by
[12:23:59] <MatmaRex>	 it seems to run one of the test cases twice, somehow
[12:24:09] <MatmaRex>	 and i haven't done anything that weird in there
[12:24:31] <YuviPanda>	 poke hashar?
[12:24:34] <YuviPanda>	 or is that Krinkle|detached?
[12:25:03] <MatmaRex>	 krinkle, most likely, but there are more important things i want him to do :D
[12:25:15] <grrrit-wm>	 (CR) Hashar: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/50364 (owner: Daniel Kinzler)
[12:25:45] <YuviPanda>	 heh :)
[12:25:59] <YuviPanda>	 now I need to go back to JavaLand.
[12:27:23] <grrrit-wm>	 (PS15) Zfilipin: A test for bug 50790 [qa/browsertests] - https://gerrit.wikimedia.org/r/72365 (owner: Amire80)
[12:27:39] <grrrit-wm>	 (CR) Zfilipin: [C: 2] A test for bug 50790 [qa/browsertests] - https://gerrit.wikimedia.org/r/72365 (owner: Amire80)
[12:27:40] <grrrit-wm>	 (Merged) Zfilipin: A test for bug 50790 [qa/browsertests] - https://gerrit.wikimedia.org/r/72365 (owner: Amire80)
[12:27:47] <grrrit-wm>	 (PS1) Santhosh: Refactor language settings [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75096
[12:35:27] <BlackBeast>	 hello.. can any one help with something?
[12:39:46] <BlackBeast>	 hello?
[12:43:01] <grrrit-wm>	 (CR) Amire80: [C: 2] Fix regression of bf1d62ba4 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[12:43:09] <grrrit-wm>	 (Merged) jenkins-bot: Fix regression of bf1d62ba4 [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/75086 (owner: Santhosh)
[12:43:53] <MatmaRex>	 !ask | BlackBeast
[12:43:53] <wm-bot>	 BlackBeast: Hi, how can we help you? Just ask your question.
[12:47:00] <MatmaRex>	 andre__: you there?
[12:47:48] <MatmaRex>	 BlackBeast: see, that's why you should juts ask. now we're waiting fot you to reply, while your answer could have already been answered
[12:47:55] <MatmaRex>	 @notify andre__
[12:47:55] <wm-bot>	 This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.)
[12:50:21] <grrrit-wm>	 (CR) Helder.wiki: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[12:58:55] <BlackBeast>	 sorry
[12:59:00] <BlackBeast>	 i was eating
[12:59:05] <BlackBeast>	 a question:
[12:59:36] <BlackBeast>	 it's there a posibillity to watch HTML code of a wikimedia's page?
[13:00:13] <MatmaRex>	 depends on what doyou mean :) "watch HTML code"?
[13:00:27] <sumanah>	 do you mean "view" or "look at"?
[13:00:33] <BlackBeast>	 look at
[13:00:39] <BlackBeast>	 my english it's not good
[13:00:42] <BlackBeast>	 sorry
[13:00:44] <BlackBeast>	 well
[13:00:57] <sumanah>	 We understand. :)
[13:01:17] <sumanah>	 BlackBeast: in a browser, do you know how to find "view source"? It's an option inside a menu, usually
[13:01:21] <MatmaRex>	 i don't understand, you can view the generated HTML source in your browser, usually - or you can see the wikitext source code on the "Edit" /"View source" tab
[13:01:38] <MatmaRex>	 (or "Edit source", sometimes)
[13:01:51] <MatmaRex>	 hm alright, i'll let sumanah handle this, she's faster ;)
[13:01:59] <BlackBeast>	 i know that, but i mean, the code of a page in MediaWiki
[13:02:16] <BlackBeast>	 thanks MatmaRex
[13:02:18] <sumanah>	 MatmaRex: Actually I need to dash off to some meetings, sorry :) but thanks for the compliment
[13:02:48] <MatmaRex>	 hm
[13:02:58] <BlackBeast>	 http://kn.wikipedia.org/wiki/%E0%B2%AE%E0%B3%8D%E0%B2%AF%E0%B2%BE%E0%B2%AE%E0%B2%A4%E0%B3%8D <-- example, i want to see HTML code in MediWiki
[13:03:36] <MatmaRex>	 this? https://kn.wikipedia.org/w/index.php?title=%E0%B2%AE%E0%B3%8D%E0%B2%AF%E0%B2%BE%E0%B2%AE%E0%B2%A4%E0%B3%8D&action=edit
[13:04:15] <MatmaRex>	 hm, html code - tyr pressing Ctrl+U or Ctrl+F3, this should show the HTML code of the page
[13:04:16] <BlackBeast>	 no, deeper.. like PHP code.. i mean programing code
[13:04:20] <MatmaRex>	 aaah
[13:04:29] <MatmaRex>	 sure you can, the PHP code is in git
[13:04:31] <MatmaRex>	 !master
[13:04:31] <wm-bot>	 https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/$url_encoded_1
[13:04:36] <BlackBeast>	 ohh
[13:04:40] <MatmaRex>	 sorry,wrong link
[13:04:52] <BlackBeast>	 no problem
[13:05:01] <MatmaRex>	 one sec
[13:05:14] <MatmaRex>	 https://www.mediawiki.org/wiki/Download_from_Git
[13:05:20] <BlackBeast>	 MatmaRex: another question
[13:05:47] <BlackBeast>	 a page in wikipedia have or can have a script code?
[13:06:04] <MatmaRex>	 and you can browse the code online on https://git.wikimedia.org/blob/mediawiki%2Fcore.git/ or on https://github.com/wikimedia/mediawiki-core/
[13:06:34] <grrrit-wm>	 (CR) Matthias Mullie: "I'm not really sure if introducing 2 distinct validation groups would make sense here." [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/73954 (owner: Matthias Mullie)
[13:06:43] <MatmaRex>	 BlackBeast: a specificpage, no; but you can add wiki-specific JavaScript on the [[MediaWiki:Common.js]] page
[13:07:22] <BlackBeast>	 MatmaRex: how can i see that JavaScript?
[13:08:31] <MatmaRex>	 i don't understand? for example the page for the English WIkipedia is https://en.wikipedia.org/wiki/MediaWiki:Common.js
[13:09:23] <BlackBeast>	 MatmaRex: mmm ok, you mean a complete code of a wikipedia
[13:09:46] <BlackBeast>	 MatmaRex: but i like to se an specific code
[13:09:52] <BlackBeast>	 on a specific page
[13:09:59] <andre__>	 MatmaRex, pong
[13:10:38] <MatmaRex>	 BlackBeast: sorry, but i really have no idea what you mean :(
[13:10:56] <MatmaRex>	 BlackBeast: that page i linked contains only customizations - most of the javascript code is stored in git as well
[13:11:00] <MatmaRex>	 andre__: hi
[13:11:18] <MatmaRex>	 andre__: bugzilla has an option to mark attachments as obsolete, right?
[13:11:31] <MatmaRex>	 andre__: can i get the permission to do that? or can you mark a few attachments obsolete for me?
[13:11:57] <BlackBeast>	 MatmaRex: private?
[13:12:00] <BlackBeast>	 can you
[13:12:02] <BlackBeast>	 ?
[13:12:13] <andre__>	 MatmaRex, anybody can
[13:12:28] <MatmaRex>	 andre__: only when submitting a new one to obsolete the old one, i think
[13:12:43] <andre__>	 MatmaRex, Click "Details". Then click "(edit details)"
[13:12:58] <MatmaRex>	 aaah
[13:13:02] <andre__>	 You see "obsolete" (and "private" if you have sufficient rights) on the left
[13:13:03] <MatmaRex>	 wow, i never noticed that link
[13:13:09] <andre__>	 yeah, it's not very obvious
[13:13:12] <andre__>	 might be our theme though
[13:13:24] <MatmaRex>	 it's even less obvious than other things
[13:13:32] <MatmaRex>	 i mean, i tend to notice these ;)
[13:14:38] <andre__>	 It was easier when Netscape still had <blink> tags :P
[13:15:26] <sumanah>	 BlackBeast: you might like to read https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture to understand how everything in MediaWiki fits together
[13:15:51] <BlackBeast>	 thanks sumanah
[13:16:19] <sumanah>	 BlackBeast: which browser do you use? Chrome, Firefox, or something else?
[13:16:25] <BlackBeast>	 both
[13:16:36] <BlackBeast>	 chrome and firefox with bugzilla
[13:17:23] <BlackBeast>	 sumanah, MatmaRex: let me try again to explain myself
[13:19:45] <BlackBeast>	 how can i see, not HTML code, but a code (like a script) of a specific page in wikipedia (any language), like a PHP code, where is programming that page, like MediaWiki.
[13:21:07] <grrrit-wm>	 (PS5) Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/74850
[13:21:16] <BlackBeast>	 for example, if a code exist in a specific wikipedia page, like a script, where is it (not HTML code) but, deeper, like MediaWiki programing
[13:21:32] <MatmaRex>	 BlackBeast: this might be hard to tell. the script might be part of core mediawiki, part of one of the extensions, or a local customization
[13:21:45] <MatmaRex>	 what script in particular? what does it do?
[13:22:00] <BlackBeast>	 that's what i want to know..
[13:22:14] <BlackBeast>	 well.. how can i see local customization?
[13:23:00] <MatmaRex>	 there are multiple ways to customize stuff :/
[13:23:17] <sumanah>	 BlackBeast: have you already read that architecture document?
[13:23:24] <MatmaRex>	 i can't really help unless i know which feature you want to "track"
[13:23:53] <BlackBeast>	 sumanah: a little.. im reading really slowly to get it well
[13:24:09] <sumanah>	 BlackBeast: I suggest you try skimming it at first and then reading it slowly :)
[13:24:38] <MatmaRex>	 there are literally megabytes of javascript code in all of mediawiki and the extensions running on Wikipedias
[13:25:07] <grrrit-wm>	 (PS5) Krinkle: mediawiki.action.edit.preview: Fire "wikipage.content" mw.hook [core] - https://gerrit.wikimedia.org/r/74314
[13:25:08] <grrrit-wm>	 (PS5) Krinkle: mediawiki.page.ready: Use wikipage.content instead of domready [core] - https://gerrit.wikimedia.org/r/74313
[13:25:09] <grrrit-wm>	 (PS5) Krinkle: Move firing of "wikipage.content" mw.hook out of mediawiki.util [core] - https://gerrit.wikimedia.org/r/74312
[13:25:26] <grrrit-wm>	 (CR) Krinkle: "Resolved merge conflict" [core] - https://gerrit.wikimedia.org/r/74312 (owner: Krinkle)
[13:25:34] <grrrit-wm>	 (CR) Krinkle: "Trivial rebase" [core] - https://gerrit.wikimedia.org/r/74313 (owner: Krinkle)
[13:25:40] <grrrit-wm>	 (CR) Krinkle: "Trivial rebase" [core] - https://gerrit.wikimedia.org/r/74314 (owner: Krinkle)
[13:26:14] <BlackBeast>	 sumanah: that's right
[13:28:18] <BlackBeast>	 well..
[13:29:32] <grrrit-wm>	 (PS2) Krinkle: User: Perform ignoreHidden check before searching for name [core] - https://gerrit.wikimedia.org/r/74578
[13:31:27] <BlackBeast>	 thanks a lot sumanah and MatmaRex
[13:31:44] <BlackBeast>	 sorry for my english.. i will try to find it somehow
[13:31:59] <BlackBeast>	 by the way, any of you are going to Wikimania?
[13:32:18] <MatmaRex>	 i'm not, sumanah is, i think
[13:32:38] <BlackBeast>	 we will met there :D
[13:33:34] <hoo>	 anomie: Just in case you wondered why I use another function to get the group names in the globalallusers API: https://meta.wikimedia.org/w/api.php?action=query&list=allusers&augroup=oversight&aulimit=5&auprop=groups
[13:40:18] <grrrit-wm>	 (PS12) Rjain: Added the destroy class [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150
[13:44:00] <grrrit-wm>	 (PS3) Matmarex: User: Move ignoreHidden check to before prefname lookup in #getOption [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle)
[13:45:19] <grrrit-wm>	 (CR) Matmarex: [C: 1] "I messed with the commit message and it's the larger part of this commit ;), so not merging on principle. Looks trivial, though." [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle)
[13:47:01] <Krinkle>	 MatmaRex: Though MediaWiki's back-end code base isn't as modular as it could be, the idea of the commit subject prefix is to refer to a module/component. User#getOption would not constitute a module. I considered that.
[13:47:49] <Krinkle>	 anyhow, it's fine for now
[13:48:09] <MatmaRex>	 Krinkle: we don't really have a reasonable-enough concept of a module to have them be commit subject prefixes, methinks
[13:48:13] <MatmaRex>	 feel free to change it back
[13:48:34] <MatmaRex>	 i tend to use prefixes, but they're often "freeform:
[13:48:37] <MatmaRex>	 "freeform" *
[13:48:46] <MatmaRex>	 like "Enhanced RC:"
[13:49:45] <Krinkle>	 For js there are module names. For PHP there are come clear modules (e.g. the directory names in includes/, so all content classes fall under "content: ", and "filebackend" etc.), for the rest I tend to use the class name for lack of a better one at the moment
[13:50:35] <Krinkle>	 These would also map to components in future iteration of our issue tracker.
[13:52:04] <grrrit-wm>	 (PS4) Matmarex: Reorder SpecialRecentChanges::webOutput [core] - https://gerrit.wikimedia.org/r/65325
[13:57:14] <Krinkle>	 nodejs shows a great example of this. https://github.com/joyent/node/issues  https://github.com/joyent/node/commits/master
[14:00:22] <MatmaRex>	 btw Krinkle, if you could quickly glance at https://gerrit.wikimedia.org/r/#/c/74969/2/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js - QUnit does weird stuff when running the "basic operation (<ul>, <ol>)" test - am i doing something obviously wrong there?
[14:01:02] <MatmaRex>	 or should i stop complaining and start debugging? ;)
[14:04:05] <Krinkle>	 MatmaRex: Can you reproduce it locally?
[14:04:28] <sumanah>	 BlackBeast: I'm almost certainly going to be at Wikimania, yes. https://wikimania2013.wikimedia.org/wiki/Attendees
[14:04:46] <Krinkle>	 MatmaRex: Note that you have a loop for both ul/ol, so it does essentially run twice
[14:05:14] <Krinkle>	 maybe something with the start() call
[14:06:14] <MatmaRex>	 Krinkle: yes, when i tried placing a breakpoint inside of that test it seemed to go into infinite loop
[14:06:25] <MatmaRex>	 running the test over and over again
[14:06:39] <MatmaRex>	 Krinkle: yeah, it does run twice - 2 times 8assertions is 16
[14:06:44] <MatmaRex>	 jenkins rpeorts 32 have been run
[14:08:09] <BlackBeast>	 sumanah: nice! we will meet there.. Im Samuel, by the way, from venezuela
[14:08:35] <Krinkle>	 MatmaRex: done = 0; until done === 2. So it runs 3 times?
[14:08:55] <Krinkle>	 oh nvm. yoi're incrementing before
[14:10:29] <sumanah>	 BlackBeast: Hope your travel goes fine :)
[14:18:47] <YuviPanda>	 aharoni: ping. has jquery.i18n been used elsewhere, other than in mediawiki?
[14:19:36] <aharoni>	 YuviPanda: not that I know. santhosh, has jquery.i18n been used elsewhere, other than in mediawiki?
[14:20:14] <YuviPanda>	 aharoni: I've been contributing to a (very nice!) js based blog editor client for wordpress, and filed https://github.com/AlexTatiyants/platen/issues/6
[14:20:23] <YuviPanda>	 looking to see if i can use .i18n + twn
[14:20:52] <aharoni>	 YuviPanda: I do suggest it to people who ask about how to do i18n in JavaScript on stackoverflow, but I don't know how many of them actually picked the advice.
[14:21:01] <YuviPanda>	 aharoni: also how extensively is .i18n used in mw?
[14:21:20] <aharoni>	 only in ULS.
[14:21:31] <YuviPanda>	 are there plans to expand that?
[14:21:43] <aharoni>	 nothing solid
[14:21:50] <YuviPanda>	 :(
[14:22:41] <grrrit-wm>	 (CR) Brian Wolff: [C: 1] "Sorry for the delay, looks good." [core] - https://gerrit.wikimedia.org/r/71597 (owner: Hashar)
[14:22:49] <BlackBeast>	 sumanah: thanks! I will depart august 3 and arrive august 5
[14:22:50] <YuviPanda>	 http://4vanger.github.io/angular-l10n/ seems to be the alternative, but I don't think it even supports plurals
[14:22:51] <aharoni>	 YuviPanda: it really should be used in the parts of VisualEditor that are supposed to be MediaWiki independent. The switch should be quite easy.
[14:23:22] <YuviPanda>	 aharoni: is it actively being developed? IIRC ULS is now in maintenance mode
[14:23:58] <aharoni>	 ULS still has a lot of bugs which we are fixing.
[14:24:38] <aharoni>	 and jquery.i18n *is* being developed. In fact, Santhosh is showing me a big change that he did there *right now*.
[14:26:03] <YuviPanda>	 aharoni: hmm, and twn.net fully supports the export format used by .i18n?
[14:26:04] <YuviPanda>	 right
[14:28:05] <grrrit-wm>	 (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/65325 (owner: Matmarex)
[14:30:47] <grrrit-wm>	 (PS1) Rjain: Added the update class [extensions/Annotator] - https://gerrit.wikimedia.org/r/75106
[14:34:31] <grrrit-wm>	 (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[14:34:53] <grrrit-wm>	 (CR) Krinkle: [C: 1] User#getOption: Check ignoreHidden before $wgHiddenPrefs [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle)
[14:35:55] <grrrit-wm>	 (PS1) Clancer: [WIP] Moodle Extension [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109
[14:36:15] <grrrit-wm>	 (PS1) Rachel99: Visual editor appears if user is logged in [qa/browsertests] - https://gerrit.wikimedia.org/r/75110
[14:38:14] <aharoni>	 YuviPanda: yes, TWN supports the jquery.i18n format. That's how ULS is translated. It's very simple JSON.
[14:38:22] <YuviPanda>	 yeah, saw that
[14:38:32] <YuviPanda>	 aharoni: I'll write an angularjs wrapper and use it in that app when I get to it :)
[14:39:50] <YuviPanda>	 aharoni: it's currently chrome only, but I"ll port it to firefox when https://developer.mozilla.org/en-US/docs/Web/Apps/Packaged_apps gets to desktop
[14:42:08] <grrrit-wm>	 (PS6) Alex Monk: Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176
[14:42:38] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[15:02:36] <grrrit-wm>	 (CR) Brian Wolff: "(3 comments)" [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109 (owner: Clancer)
[15:09:17] <grrrit-wm>	 (CR) Siebrand: [C: 2 V: 2] Replace "X-query" by "XQuery" [extensions/MathSearch] - https://gerrit.wikimedia.org/r/75062 (owner: Shirayuki)
[15:09:18] <grrrit-wm>	 (Merged) Siebrand: Replace "X-query" by "XQuery" [extensions/MathSearch] - https://gerrit.wikimedia.org/r/75062 (owner: Shirayuki)
[15:10:20] <grrrit-wm>	 (CR) Siebrand: [C: 2] Remove leading whitespace from message [extensions/EtherEditor] - https://gerrit.wikimedia.org/r/75060 (owner: Shirayuki)
[15:10:29] <grrrit-wm>	 (PS7) Alex Monk: Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176
[15:11:00] <grrrit-wm>	 (Merged) jenkins-bot: Remove leading whitespace from message [extensions/EtherEditor] - https://gerrit.wikimedia.org/r/75060 (owner: Shirayuki)
[15:12:47] <Krenair>	 Why does Parent5446 never use IRC? :/
[15:13:27] <bawolff>	 I wish he did. I want all devs to be addicted to irc
[15:13:29] <MatmaRex>	 he sometimes does, rarely
[15:13:34] <MatmaRex>	 @seen parent5446
[15:13:34] <wm-bot>	 MatmaRex: Last time I saw parent5446 they were quitting the network with reason: Quit: leaving N/A at 7/19/2013 4:56:37 PM (2.22:16:57.2415150 ago)
[15:15:25] <grrrit-wm>	 (PS2) Clancer: [WIP] Moodle Extension [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109
[15:16:21] <Krenair>	 @seen csteipp
[15:16:21] <wm-bot>	 Krenair: Last time I saw csteipp they were quitting the network with reason: Ping timeout: 246 seconds N/A at 7/20/2013 1:52:09 AM (2.13:24:12.6511690 ago)
[15:16:38] <Krenair>	 what kind of a timestamp is that?
[15:16:55] <Krenair>	 I mean the "2.13:24:12.6511690 ago"
[15:17:20] <siebrand>	 2d13h24m12.65s?
[15:17:33] <siebrand>	 Bit hard to read, but possible to decipher? ;)
[15:17:55] <Krenair>	 .6511690 seconds? hmm
[15:18:03] <MatmaRex>	 PRECISION
[15:18:08] <MatmaRex>	 blame petan
[15:18:13] <MatmaRex>	 or file a bug :D
[15:18:14] <petan>	 hi
[15:18:22] <Krenair>	 petan, where is wm-bot's code?
[15:18:25] <petan>	 @hel
[15:18:27] <wm-bot>	 I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.0.6 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features
[15:18:29] <petan>	 ^
[15:18:36] <petan>	 siebrand is correct
[15:18:40] <petan>	 first number is days
[15:18:53] <petan>	 if you want it to look different you need to a) fix it b) request fix :P
[15:19:00] <petan>	 either
[15:19:54] <Krenair>	 doing
[15:20:25] <bawolff>	 could be worse. It could be returning the number of seconds after 1970
[15:20:44] <peachey|laptop__>	 bawolff: isn't that how all real gentlement handle time?
[15:20:53] <bawolff>	 indeed
[15:21:06] <Krenair>	 oh it's TimeSpan.toString
[15:21:21] <Krenair>	 I am not familiar with the API used in C#...
[15:22:34] <Krenair>	 Oh sorry, TimeSpan.ToString
[15:22:39] * Krenair  grumbles

[15:24:31] <marktraceur>	 YuviPanda: We gonna need a UW deploy today for the fix that got merged overnight?
[15:28:07] <grrrit-wm>	 (PS2) Fantasticfears: add a anonymous function in appendNamespaceAliases for pretty output [core] - https://gerrit.wikimedia.org/r/74618
[15:40:58] <Krenair>	 petan: "Main configuration file of a bot is wmib"
[15:41:03] <Krenair>	 created a file called wmib
[15:41:10] <Krenair>	 but
[15:41:12] <Krenair>	 LOG (WARNING)[22/07/2013 16:40:41]: Error while loading the config file, exiting
[15:41:39] <petan>	 Krenair oh yes this suck, hold on
[15:43:36] <petan>	 Krenair: use this example config http://tools.wmflabs.org/paste/view/c128cc0d
[15:43:45] <petan>	 also that file needs to be in folder configuration
[15:43:48] <petan>	 configuration/wmib
[15:44:27] <Krenair>	 ... That's not mentioned on meta:Wm-bot
[15:44:27] <grrrit-wm>	 (CR) Brian Wolff: "(4 comments)" [extensions/Moodle] - https://gerrit.wikimedia.org/r/75109 (owner: Clancer)
[15:44:50] <petan>	 Krenair: there is so much not mentioned on meta :(
[15:44:55] <petan>	 shame on me
[15:45:24] <Krenair>	 What is instancename0?
[15:45:57] <petan>	 http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070375.html
[15:46:06] <petan>	 it's name of first instance
[15:46:15] <petan>	 basically it can be a nickname
[15:46:30] <petan>	 oh wait
[15:46:33] <petan>	 no I am lying
[15:46:48] <petan>	 it's a name of second (first additional) instance
[15:46:53] <petan>	 it doesn't need to be present in config at all
[15:47:07] <petan>	 so you can remove it from there
[15:48:28] <Krenair>	 Error there is no login for bot
[15:48:28] <Krenair>	 LOG (WARNING)[22/07/2013 16:48:20]: Error while loading the config file, exiting
[15:48:38] <grrrit-wm>	 (CR) Helder.wiki: "By keeping the key 'usebetatoolbar' we will always have scripts trating the toolbar as a 'beta' feature, e.g.:" [extensions/WikiEditor] - https://gerrit.wikimedia.org/r/65468 (owner: TMg)
[15:48:49] <Krenair>	 It would help if it actually outputted the error to the console
[15:51:11] <petan>	 Krenair: you are right :P but in fact it does
[15:51:36] <Krenair>	 What?
[15:51:46] <petan>	 if (string.IsNullOrEmpty(login))
[15:51:47] <petan>	 {
[15:51:48] <petan>	 Console.WriteLine("Error there is no login for bot");
[15:51:49] <petan>	 return 1;
[15:51:50] <petan>	 }
[15:52:18] <petan>	 it prints the exact error to console, it's just a bit cryptic for non-developer what does it mean...
[15:52:29] <hashar>	 I killed Jenkins by mistake sorry :(
[15:52:31] <Krenair>	 It's not empty
[15:52:34] <Krenair>	 I have a nickname defined
[15:52:36] <petan>	 hashar: happens
[15:52:41] <petan>	 Krenair: pastebin your config
[15:53:07] <petan>	 Krenair: it needs to be nick=yourbot'snick;
[15:53:17] <petan>	 not, for example nick = yourbot'snick;
[15:53:18] <Krenair>	 http://pastebin.com/2ziTusr1
[15:53:34] <grrrit-wm>	 (PS1) Rillke: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122
[15:53:37] <Krenair>	 nick=Krenair|test-wm-bot;
[15:54:02] <petan>	 seems correct to me
[15:54:04] <petan>	 let me try it myself
[15:54:43] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[15:56:17] <petan>	 your configuration file works to me
[15:56:24] <cscott>	 OMG, hashar killed Jenkins!  You bastard!
[15:56:40] <grrrit-wm>	 (PS6) Jiabao: Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748
[15:56:40] <petan>	 you need to have it located at `pwd`/configuration/wmib
[15:56:54] <petan>	 and you start bot from `pwd`
[15:57:05] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748 (owner: Jiabao)
[15:57:05] <Krenair>	 Oh yeah I forgot that bit
[15:57:07] <Krenair>	 my bad
[15:57:23] <petan>	 well it should have say "I don't see a config file in `pwd`/configuration/wmib" :D
[15:57:27] <hashar>	 cscott: yeah upstream is to blame :-]
[15:57:39] <petan>	 but I never expected anyone but me to every play with the bot
[15:57:47] <petan>	 so I didn't make debug messages so descriptive
[15:57:55] <Krenair>	 Still fails
[15:58:01] <petan>	 with?
[15:58:02] <Krenair>	 Maybe it doesn't like being run from monodevelop?
[15:58:10] <petan>	 maybe... idk
[15:58:16] <petan>	 who knows where monodevelop start it from
[15:58:16] <Krenair>	 not sure how to run it any other way :P
[15:58:20] <cscott>	 hashar: i think i've like to have a chat about composer w/ you at some point
[15:58:26] <petan>	 open terminal, cd into the path where binary is
[15:58:33] <petan>	 type: mono wmib.exe
[15:58:37] <Krenair>	 There is no binary petan
[15:58:42] <petan>	 it's in bin
[15:58:43] <Krenair>	 That's why I was running it from monodevelop
[15:58:48] <petan>	 project folder/bin/Debug
[15:58:51] <petan>	 that's my guess
[15:58:54] <cscott>	 hashar: maybe after jenkins has been regrown and a new clone jenkins is masquerading as our old jenkins
[15:58:58] <petan>	 unless you are targetting for Release
[15:59:24] <petan>	 the configuration folder needs to be there
[15:59:31] <petan>	 in bin/Debug/configuration/.....
[15:59:44] <petan>	 which would be your pwd
[15:59:52] <petan>	 * wd
[16:00:00] <petan>	 I don't know why I keep callind wd pwd
[16:00:01] <petan>	 :P
[16:00:08] <Krenair>	 alex@alex:~/Git/wikimedia-bot (master)$ mono bin/Debug/wmib.exe
[16:00:12] * cscott  imagines jenkins as a villain in http://en.wikipedia.org/wiki/The_6th_Day

[16:00:19] <petan>	 that's not a best way
[16:00:24] <petan>	 cd bin/Debug
[16:00:24] <Krenair>	 It wants a parameter called format?
[16:00:26] <cscott>	 petan: cwd
[16:00:32] <petan>	 mono wmib.exe
[16:00:39] <cscott>	 petan: pwd prints your cwd
[16:00:41] <Krenair>	 still wants 'format'
[16:00:47] <petan>	 huh?
[16:00:51] <grrrit-wm>	 (CR) Matmarex: "Doing that would break that script and possibly many others, and in result would get the developers shouted at. I see no reason to break b" [extensions/WikiEditor] - https://gerrit.wikimedia.org/r/65468 (owner: TMg)
[16:00:51] <petan>	 what's the message you see
[16:01:00] <petan>	 I really think you should first cd in bin/Debug
[16:01:04] <Krenair>	 PM spam incoming
[16:01:08] <petan>	 ok
[16:02:00] <petan>	 are you running solaris or what :D
[16:02:08] <Krenair>	 no
[16:02:23] <petan>	 it looks to me it just can't recognize your terminal or something... mhm weird
[16:02:24] <petan>	 what's your OS
[16:02:37] <Krenair>	 Ubuntu 13.04
[16:03:03] <petan>	 wait, maybe not
[16:03:15] <petan>	 maybe someone recently commited some crap I accidentaly merged without review
[16:03:21] <petan>	 let me check if latest HEAD actually works
[16:03:48] <MatmaRex>	 lol
[16:04:19] * Krenair  facepalms

[16:04:47] <petan>	 hm... not really, can you pastebin whole log as it is
[16:04:55] <petan>	 I mean what is ALL printed since you start the bot
[16:05:24] <petan>	 do you see it coloured at least XD
[16:05:34] <Krenair>	 nothing coloured
[16:05:38] <petan>	 meh
[16:05:44] <petan>	 the bot output should have colors...
[16:06:10] <Krenair>	 apart from my $PS1
[16:06:40] <Krenair>	 petan: http://pastebin.com/4eHHzaj6
[16:06:55] <grrrit-wm>	 (CR) MarkTraceur: "(7 comments)" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[16:07:04] <grrrit-wm>	 (CR) MarkTraceur: [C: -1] Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[16:10:16] <petan>	 Krenair: this is really weird, for some reason it's not able to set colors for your terminal and that makes it crash (or that's what it seems to me from stack trace) let me implement some no-colors parameter
[16:10:44] <Krenair>	 What other linux distributions have you tested this on?
[16:10:50] <petan>	 debian / ubuntu
[16:10:55] <petan>	 never saw this before
[16:15:59] <petan>	 Krenair: git pull && xbuild
[16:16:06] <petan>	 then you start mono wmib.exe --nocolors
[16:17:51] <Krenair>	 same exception
[16:17:57] <Krenair>	 Unhandled Exception: System.ArgumentNullException: Argument cannot be null.
[16:17:57] <Krenair>	 Parameter name: format
[16:17:57] <Krenair>	 etc.
[16:18:00] <petan>	 wtf
[16:18:01] <MatmaRex>	 hi parent5456, we'd just been complaining that you're never on irc ;)
[16:18:26] <petan>	 Krenair how do you actually start it?
[16:18:27] <Krenair>	 I don't think he's looking at his IRC client at the moment :/
[16:18:33] <Krenair>	 alex@alex:~/Git/wikimedia-bot/bin/Debug (master)$ mono wmib.exe --no-colors
[16:18:45] <petan>	 Krenair do you have access to bots project?
[16:18:51] <petan>	 there is working testing instance...
[16:18:54] <Krenair>	 Oh it was with no - wasn't it
[16:19:01] <Krenair>	 dammit
[16:19:02] <petan>	 sure
[16:19:04] <petan>	 --nocolors
[16:19:12] <Krenair>	 okay, now I'm back to the original error
[16:19:16] <Krenair>	 Error there is no login for bot
[16:19:16] <Krenair>	 LOG (WARNING)[22/07/2013 17:18:58]: Error while loading the config file, exiting
[16:19:31] <petan>	 can you add --nocolors -vvvvvvv
[16:19:38] <Krenair>	 ... ok, running it from Git/wikimedia-bot makes it work
[16:19:40] <petan>	 that increases verbosity a bit
[16:19:43] <Krenair>	 as in
[16:19:44] <Krenair>	 alex@alex:~/Git/wikimedia-bot (master)$ mono bin/Debug/wmib.exe --nocolors
[16:19:54] <petan>	 well because you had no configuration folder in bin/Debug I guess
[16:20:03] <petan>	 you need to have that folder in `pwd`
[16:20:11] <petan>	 that means a folder you start binary from
[16:22:23] <Krenair>	 Now I need to figure out how to get it to recognise @seen
[16:22:28] <Krenair>	 Guess I need to include the seen plugin somehow
[16:23:11] <petan>	 of course you need to
[16:23:38] <petan>	 look, throw monodevelop somewhere, I hate gui tools
[16:23:45] <petan>	 open terminal
[16:24:18] <petan>	 cd root of git (wikimedia-bot)
[16:24:21] <petan>	 now type
[16:24:28] <petan>	 cp -r bin/Debug bin/Release
[16:24:31] <petan>	 cd plugins/seen/plugin/
[16:24:34] <petan>	 xbuild
[16:24:58] <Krenair>	 done
[16:25:26] <petan>	 mkdir ../../../bin/Debug/modules
[16:25:29] <petan>	 cp bin/Debug/plugin.dll ../../../bin/Debug/modules
[16:25:38] <petan>	 eh
[16:25:43] <petan>	 cp bin/Debug/plugin.dll ../../../bin/Debug/modules/seen.bin
[16:25:45] <petan>	 that way
[16:26:04] <petan>	 now when you start wm-bot (from bin/Debug) it will auto-load seen
[16:26:08] <petan>	 you will see that in a log
[16:26:43] <petan>	 LOG [7/22/2013 4:26:33 PM]: Loading module: SEEN v2.2.1.9
[16:27:08] <petan>	 don't forget to have EVERYTHING (modules folder and configuration folder) in bin/Debug
[16:27:14] <petan>	 then just cd bin/Debug
[16:27:22] <petan>	 and run mono wmib.exe --nocolors -vvvvvvvvvv
[16:27:38] <MatmaRex>	 !wp VVVV
[16:27:39] <wm-bot>	 https://en.wikipedia.org/?title=VVVV
[16:27:51] <MatmaRex>	 oh, it's deleted.
[16:27:53] <petan>	 wtf is that
[16:28:06] <MatmaRex>	 ah
[16:28:09] <MatmaRex>	 !wp VVVVVV
[16:28:09] <wm-bot>	 https://en.wikipedia.org/?title=VVVVVV
[16:28:12] <MatmaRex>	 that's the name.
[16:28:13] <MatmaRex>	 :D
[16:36:14] <grrrit-wm>	 (CR) Anomie: [C: 1 V: 1] "Code works. Is it supposed to run on all wikis, though, or just the central one?" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[16:42:59] <grrrit-wm>	 (PS4) Anomie: Hooks to tie OAuth in with User rights and the API [extensions/OAuth] - https://gerrit.wikimedia.org/r/73977
[16:50:47] <grrrit-wm>	 (CR) Anomie: "Yeah, not touching the old style since we're going to remove that anyway. Speaking of which, I should update If81765b2." [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[16:52:29] <grrrit-wm>	 (CR) Krinkle: [C: 1] Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[16:55:40] <grrrit-wm>	 (PS7) Jiabao: Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748
[16:56:10] <grrrit-wm>	 (PS4) Anomie: Remove Special:AutoLogin [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/64253
[16:57:48] <grrrit-wm>	 (CR) Parent5446: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/61748 (owner: Jiabao)
[16:57:56] <grrrit-wm>	 (CR) Krinkle: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74176 (owner: Daniel Kinzler)
[16:58:09] <grrrit-wm>	 (CR) Anomie: Remove Special:AutoLogin [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/64253 (owner: Anomie)
[16:58:12] <grrrit-wm>	 (PS8) Jiabao: Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748
[17:05:04] <grrrit-wm>	 (PS1) Manybubbles: Create a hook for bulk html cache invalidation. [core] - https://gerrit.wikimedia.org/r/75131
[17:07:11] <grrrit-wm>	 (CR) Aaron Schulz: "Just the central one. Actually we normally don't use the hook in that case. But the smarter thing might be to just make the hook not fire " [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[17:08:24] <grrrit-wm>	 (CR) Manybubbles: "I'm not particularly happy with hooking search index updates to the html cache invalidation stuff but we'd want to duplicate most of the i" [core] - https://gerrit.wikimedia.org/r/75131 (owner: Manybubbles)
[17:09:09] <grrrit-wm>	 (PS2) Aaron Schulz: Enabled the schema updater hook [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685
[17:10:12] <grrrit-wm>	 (CR) Hoo man: "(1 comment)" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/23177 (owner: jan)
[17:11:12] <grrrit-wm>	 (PS9) Jiabao: Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748
[17:11:40] <grrrit-wm>	 (PS1) MarkAHershberger: Initial attempt at backporting [extensions/Scribunto] - https://gerrit.wikimedia.org/r/75133
[17:12:18] <grrrit-wm>	 (Abandoned) MarkAHershberger: Initial attempt at backporting [extensions/Scribunto] - https://gerrit.wikimedia.org/r/75133 (owner: MarkAHershberger)
[17:13:14] <grrrit-wm>	 (CR) Rillke: "(1 comment)" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[17:13:28] <grrrit-wm>	 (PS1) Anomie: Fix exception in ApiPageSet [core] - https://gerrit.wikimedia.org/r/75134
[17:13:46] <grrrit-wm>	 (Abandoned) Rillke: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[17:16:00] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Fix exception in ApiPageSet [core] - https://gerrit.wikimedia.org/r/75134 (owner: Anomie)
[17:16:27] <grrrit-wm>	 (PS1) Manybubbles: Reindex pages on template changes. [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/75135
[17:16:28] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Reindex pages on template changes. [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/75135 (owner: Manybubbles)
[17:21:34] <grrrit-wm>	 (PS2) Manybubbles: Reindex pages on template changes. [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/75135
[17:21:57] <YuviPanda>	 ^demon: how is the gerrit bot that pings bugzilla running?
[17:21:58] <YuviPanda>	 hook?
[17:22:00] <YuviPanda>	 or plugin?
[17:22:05] <^demon>	 plugin
[17:24:17] <YuviPanda>	 ^demon: ah, damn. ok
[17:24:31] <^demon>	 It's open source :)
[17:24:40] <YuviPanda>	 and GWT :P
[17:24:47] <YuviPanda>	 and I think it's fairly bug free
[17:24:47] <YuviPanda>	 so
[17:25:46] <^demon>	 There's no GWT in hooks-bugzilla :)
[17:26:00] <YuviPanda>	 but it's bug free!
[17:28:41] <grrrit-wm>	 (CR) Anomie: "(1 comment)" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/23177 (owner: jan)
[17:35:50] <grrrit-wm>	 (PS10) Jiabao: Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748
[17:38:53] <grrrit-wm>	 (CR) Matmarex: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[17:39:41] <grrrit-wm>	 (CR) Jiabao: "Thank you for the review. Now I give a successbox to the message, with the method used in SpecialPreferences.php when the preference is sa" [core] - https://gerrit.wikimedia.org/r/61748 (owner: Jiabao)
[17:40:14] <grrrit-wm>	 (PS8) Matmarex: Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[17:40:53] <grrrit-wm>	 (CR) Matmarex: [C: 1] Make mwCustomEditButtons a no-op and mark it as deprecated [core] - https://gerrit.wikimedia.org/r/71176 (owner: Alex Monk)
[17:41:02] <MatmaRex>	 Krenair: ^
[17:41:06] <MatmaRex>	 (sorry :) )
[17:41:40] <grrrit-wm>	 (CR) Anomie: [C: 2] (bug 16860) Add api for getting all global user [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/23177 (owner: jan)
[17:42:01] <grrrit-wm>	 (Merged) jenkins-bot: (bug 16860) Add api for getting all global user [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/23177 (owner: jan)
[17:42:16] <grrrit-wm>	 (CR) Matmarex: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/65325 (owner: Matmarex)
[17:42:20] <grrrit-wm>	 (PS1) MarkAHershberger: set upstream branch [extensions/Scribunto] (REL1_19) - https://gerrit.wikimedia.org/r/75139
[17:43:17] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] set upstream branch [extensions/Scribunto] (REL1_19) - https://gerrit.wikimedia.org/r/75139 (owner: MarkAHershberger)
[17:43:44] <grrrit-wm>	 (Abandoned) MarkAHershberger: set upstream branch [extensions/Scribunto] (REL1_19) - https://gerrit.wikimedia.org/r/75139 (owner: MarkAHershberger)
[17:43:55] <grrrit-wm>	 (PS5) Matmarex: Reorder SpecialRecentChanges::webOutput [core] - https://gerrit.wikimedia.org/r/65325
[17:44:13] <hoo>	 anomie: If we keep it this way, I guess we should have the if on line 145 over the === previousname thing? https://gerrit.wikimedia.org/r/#/c/23177/18/api/ApiQueryGlobalAllUsers.php
[17:44:40] <YuviPanda>	 Reedy: do you know when the deployment is going to happen?
[17:45:02] <anomie>	 hoo: Shouldn't be a need to, why?
[17:46:11] <hoo>	 let me test that
[17:46:49] <grrrit-wm>	 (CR) Parent5446: [C: 1] Show message when user successfully changed password. [core] - https://gerrit.wikimedia.org/r/61748 (owner: Jiabao)
[17:51:01] <Krenair>	 MatmaRex, feel free to do that more often :P
[17:51:21] <MatmaRex>	 Krenair: :P
[17:52:00] <MatmaRex>	 Krenair: feel like pushing me around a little now? i've got some stuff that wants to be reviewed
[17:52:55] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/q/owner%3A%22Matmarex%22+project%3Amediawiki%2Fcore+status%3Aopen,n,z
[17:53:39] <Reedy>	 YuviPanda: Window starts in 7 minutes
[17:54:06] <grrrit-wm>	 (PS1) MarkAHershberger: Initial attempt at backporting [extensions/Scribunto] (REL1_19) - https://gerrit.wikimedia.org/r/75142
[17:54:09] <Krenair>	 MatmaRex, actually about to have dinner, but maybe afterwards
[17:55:06] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Initial attempt at backporting [extensions/Scribunto] (REL1_19) - https://gerrit.wikimedia.org/r/75142 (owner: MarkAHershberger)
[17:55:42] <MatmaRex>	 Krenair: alright, thanks
[17:56:00] <MatmaRex>	 hey, i merge more changes than l10n-bot. https://toolserver.org/~nemobis/crstats/core.txt
[17:57:21] <Reedy>	 o_0
[17:58:55] <bawolff>	 impressive
[18:00:30] <grrrit-wm>	 (PS1) MarkTraceur: WIP Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[18:01:29] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[18:03:40] <grrrit-wm>	 (PS1) Bsitu: Fix an i18n message [extensions/Echo] - https://gerrit.wikimedia.org/r/75144
[18:03:41] <marktraceur>	 Thanks jenkins
[18:03:55] <YuviPanda>	 Reedy: ah, okay. poke me when you run the migrate script
[18:04:58] <nileshc>	 Anyone have experience with using MySQL tables having ~700 columns? I'm trying not to add another dependency like MongoDB or HBase to wikibase, so investigating MySQL first.
[18:05:29] <nileshc>	 I need to run queries like this: http://stackoverflow.com/questions/2681408/how-would-i-order-a-table-by-the-number-of-matching-params-in-the-where-clause-o
[18:10:50] <Reedy>	 700 columns would feel very much like you're doing it wrong (tm)
[18:10:55] <grrrit-wm>	 (CR) MarkTraceur: "OK, what I'm thinking of doing is this:" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[18:12:02] <grrrit-wm>	 (PS1) Cmcmahon: Change to click Edit source, VE is enabled for anonymous users now [qa/browsertests] - https://gerrit.wikimedia.org/r/75145
[18:13:33] <grrrit-wm>	 (PS2) Anomie: Fix exception in ApiPageSet [core] - https://gerrit.wikimedia.org/r/75134
[18:16:19] <grrrit-wm>	 (CR) Anomie: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[18:22:27] <grrrit-wm>	 (CR) Anomie: [C: 1] "Code looks good. Haven't tested." [core] - https://gerrit.wikimedia.org/r/74855 (owner: Hoo man)
[18:22:36] <grrrit-wm>	 (PS3) Cmcmahon: Scenario: Wikilove window appears [qa/browsertests] - https://gerrit.wikimedia.org/r/74386 (owner: Zfilipin)
[18:22:45] <grrrit-wm>	 (CR) Cmcmahon: [C: 2] Scenario: Wikilove window appears [qa/browsertests] - https://gerrit.wikimedia.org/r/74386 (owner: Zfilipin)
[18:22:46] <grrrit-wm>	 (Merged) Cmcmahon: Scenario: Wikilove window appears [qa/browsertests] - https://gerrit.wikimedia.org/r/74386 (owner: Zfilipin)
[18:25:58] <grrrit-wm>	 (CR) Rachel99: "Looks good to me." [qa/browsertests] - https://gerrit.wikimedia.org/r/74386 (owner: Zfilipin)
[18:26:57] <grrrit-wm>	 (CR) Anomie: [C: -1] "No indication as to what error message this is "fixing". If I had to guess, I'd guess that Iaa5a71ec is fixing the real issue here." [core] - https://gerrit.wikimedia.org/r/74977 (owner: Liangent)
[18:30:07] <chrismcmahon>	 Reedy: is this the right way to enable VE for anons on test2wiki?  https://gerrit.wikimedia.org/r/#/c/75140/ (and if so, could you merge that?)
[18:34:05] <Reedy>	 It would look right, but I'm not familiar with any of its config
[18:36:24] <Krenair>	 @seen csteipp
[18:36:24] <wm-bot>	 Krenair: Last time I saw csteipp they were quitting the network with reason: Ping timeout: 246 seconds N/A at 7/20/2013 1:52:09 AM (2.16:44:15.0417230 ago)
[18:39:11] <sactage>	 How can I get the gender of a user?
[18:40:07] <Nikerabbit>	 sactage: in what context
[18:41:13] <Nikerabbit>	 we don't store gender information specifically, but we have the gender option in user preferences for how they want to be addressed
[18:41:53] <sactage>	 I want to get the value of the preference option
[18:41:54] <sactage>	 for a user
[18:42:13] <grrrit-wm>	 (CR) Anomie: [C: -1] "You're doing it wrong if you have generators involved. In that case you need to ignore the generator's continuation parameters until you s" [core] - https://gerrit.wikimedia.org/r/72844 (owner: MarkTraceur)
[18:42:21] <Nikerabbit>	 in what context? php? js? wikitext?
[18:42:25] <sactage>	 php
[18:42:39] <Nikerabbit>	 $user->getOption( 'gender' ) ?
[18:44:50] <grrrit-wm>	 (CR) Mwalker: "(1 comment)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/72635 (owner: Mwalker)
[18:46:24] <grrrit-wm>	 (CR) Mwalker: [C: 1] Bug 51257: Improve chapter dropdown for books with many chapters. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74658 (owner: Mollywhite)
[18:46:40] <grrrit-wm>	 (Restored) Alex Monk: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[18:50:31] <grrrit-wm>	 (PS2) Alex Monk: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[18:50:42] <marktraceur>	 Krenair: Thanks for that
[18:51:06] <Krenair>	 There's still some comments from PS1 to take care of
[18:51:12] <Krenair>	 But I fixed the whitespace stuff
[18:52:26] <grrrit-wm>	 (CR) Aaron Schulz: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[18:54:37] <marktraceur>	 I guess he's right about unbind, it just looked weird
[18:54:43] * Nemo_bis  is happy crstats see some use :)

[18:55:48] <grrrit-wm>	 (CR) Hoo man: [C: 1] "Looks sane, didn't yet test." [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[18:57:20] <Krenair>	 marktraceur, so .off or .unbind?
[18:57:32] <Krenair>	 with both 'resize' and onResize parameters either way
[18:57:45] <grrrit-wm>	 (PS1) Manybubbles: Reindex pages on template changes. [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/75151
[18:57:46] <grrrit-wm>	 (CR) Adamw: [C: 2 V: 2] Updating Brazil Form Layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/72635 (owner: Mwalker)
[18:57:47] <grrrit-wm>	 (Merged) Adamw: Updating Brazil Form Layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/72635 (owner: Mwalker)
[18:58:17] <grrrit-wm>	 (CR) MarkTraceur: "1. Our code conventions aren't only for core, they're around for pretty good reason." [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[18:58:41] <marktraceur>	 Krenair: Either one works, no need to change it
[18:58:59] <grrrit-wm>	 (PS3) Alex Monk: Improved file-control positioning [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[18:59:05] <grrrit-wm>	 (CR) Alex Monk: "(6 comments)" [extensions/UploadWizard] - https://gerrit.wikimedia.org/r/75122 (owner: Rillke)
[19:03:57] <grrrit-wm>	 (CR) Bsitu: [C: 2] Improve oversight request email [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979 (owner: Matthias Mullie)
[19:04:10] <grrrit-wm>	 (Merged) jenkins-bot: Improve oversight request email [extensions/ArticleFeedbackv5] - https://gerrit.wikimedia.org/r/72979 (owner: Matthias Mullie)
[19:06:55] <grrrit-wm>	 (PS1) Mollywhite: Create contents page when JSON block is saved [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75152
[19:09:22] <grrrit-wm>	 (CR) Mollywhite: [C: 2 V: 2] Bug 51257: Improve chapter dropdown for books with many chapters. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74658 (owner: Mollywhite)
[19:09:23] <grrrit-wm>	 (Merged) Mollywhite: Bug 51257: Improve chapter dropdown for books with many chapters. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74658 (owner: Mollywhite)
[19:13:37] <grrrit-wm>	 (CR) Anomie: [C: 2] "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[19:14:44] <grrrit-wm>	 (CR) Mwalker: [C: 2] Amazon recurring gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/62516 (owner: Adamw)
[19:17:41] <grrrit-wm>	 (PS3) Adamw: Amazon recurring gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/62516
[19:20:28] <grrrit-wm>	 (CR) Mwalker: [C: 2] Amazon recurring gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/62516 (owner: Adamw)
[19:20:30] <grrrit-wm>	 (Merged) Mwalker: Amazon recurring gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/62516 (owner: Adamw)
[19:22:43] <mwalker>	 GorillaWarfare: wrt your latest patch generating [BookTitle]/Contents automatically... two questions! for what purpose? and more importantly, how can you guarentee that valid content isn't already in that page?
[19:23:34] <Reedy>	 YuviPanda: commons done...
[19:23:40] <YuviPanda>	 Reedy: script ran?
[19:23:45] <Reedy>	 Yes
[19:23:49] <grrrit-wm>	 (PS14) Adamw: Amazon IPN listener [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/60958
[19:23:50] <Reedy>	 That's what I mean by done
[19:23:50] <Reedy>	 :p
[19:23:57] * YuviPanda  loads RC

[19:24:09] <YuviPanda>	 woot!
[19:24:11] <YuviPanda>	 Reedy:  ty :)
[19:24:20] <grrrit-wm>	 (CR) Anomie: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74618 (owner: Fantasticfears)
[19:25:47] <GorillaWarfare>	 mwalker: JS fallback, and because it's somethign we were hoping to do eventually anyway
[19:25:57] <GorillaWarfare>	 mwalker: As for the second bit, I'm still figuring that out :P
[19:29:01] <grrrit-wm>	 (CR) Yurik: [C: -1] "Please take a look at the logic in our maintenance script (python) to handle continuations." [core] - https://gerrit.wikimedia.org/r/72844 (owner: MarkTraceur)
[19:29:46] <yurik>	 i suspect anomie leads in the number of [C: -1] gerrit reviews...
[19:30:35] * anomie  wonders if that should be taken in a good way or a bad way

[19:31:29] <GorillaWarfare>	 Just noticed "grrrit" xD
[19:32:15] <GorillaWarfare>	 mwalker: What are your thoughts?
[19:32:19] <grrrit-wm>	 (CR) Adamw: "(7 comments)" [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/60958 (owner: Adamw)
[19:33:16] <mwalker>	 GorillaWarfare: gotcha... hurm... probably a parser hook/magic word
[19:39:10] <GorillaWarfare>	 mwalker: Agreed
[19:39:11] <grrrit-wm>	 (PS16) Adamw: Amazon IPN listener [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/60958
[19:39:11] <grrrit-wm>	 (PS2) MaxSem: Add 2 new hooks to fix mobile logins [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/75154
[19:39:11] <GorillaWarfare>	 mwalker: I just want to make sure that there _is_ a page to fall back to, for people who don't have JS enabled
[19:39:18] <GorillaWarfare>	 mwalker: I wonder if it makes sense to, when I make the edit form for the JSON, include a bit that allows either autocreating the TOC page or selecting an existing page to use instead
[19:40:35] <petan>	 @seen hashar
[19:40:36] <wm-bot>	 petan: Last time I saw hashar they were quitting the network with reason: Quit: I am a manual virus, please copy me to your quit message. N/A at 7/22/2013 4:19:08 PM (03h21m27s ago)
[19:40:51] <petan>	 Krenair ^^^
[19:41:00] <petan>	 deployed
[19:41:03] <Krenair>	 yay
[19:41:36] <mwalker>	 GorillaWarfare: yep yep; and that sorta makes sense; I probably would make the default some i18n string so that the site admins could modify it as needed
[19:41:57] <GorillaWarfare>	 mwalker: The default what?
[19:42:08] <mwalker>	 sorry; default name
[19:42:15] <mwalker>	 so it could be [BookName]/Contents
[19:42:17] <GorillaWarfare>	 Oh, yeah
[19:42:21] <mwalker>	 or [BookName]/ToC
[19:42:31] <GorillaWarfare>	 God, I'm awful at realizing when I'm forgetting to localize things, haha
[19:44:09] <mwalker>	 it's somewhat tricky... and ^ might not even be a good place for it because then you might be suggesting different strings for people in different UI languages
[19:44:19] <mwalker>	 your other option would be a config variable
[19:44:34] <mwalker>	 or... stating in qqq that it should be the same site wide
[19:44:37] <mwalker>	 or... *shrugs*
[19:44:45] <mwalker>	 no good answer
[19:45:25] <GorillaWarfare>	 Hmm
[19:46:16] <GorillaWarfare>	 mwalker: Would it be possible to have the localized version just be "Contents", but allow that to be overridden?
[19:46:55] <mwalker>	 sure; that's what you would set your initial string to
[19:47:01] <mwalker>	 but then that gets translated into everything!
[19:47:13] <mwalker>	 I suppose you could force the suggestion to be in the content language
[19:47:23] <mwalker>	 that might actually be the best method
[19:47:25] <GorillaWarfare>	 Wouldn't that make sense?
[19:47:34] <mwalker>	 yep
[19:47:47] <GorillaWarfare>	 Heh, okay
[19:48:27] <GorillaWarfare>	 Now to figure out what to do with this patch until I make the edit form...
[19:50:04] <grrrit-wm>	 (PS1) Adamw: Letter Subject is templated the same as the body [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/75157
[19:53:42] <grrrit-wm>	 (CR) Hoo man: [C: 2] "Works like a charm :) Also per Chris" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[19:53:43] <grrrit-wm>	 (Merged) jenkins-bot: Have Special:CentralAutoLogin honor "Keep me logged in" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[20:07:38] <grrrit-wm>	 (CR) Aaron Schulz: "(2 comments)" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[20:10:58] <grrrit-wm>	 (CR) Anomie: "(1 comment)" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[20:15:30] <grrrit-wm>	 (CR) Aaron Schulz: "Otherwise, this looks fine to me and seems to work" [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74682 (owner: Anomie)
[20:17:41] <grrrit-wm>	 (CR) Aaron Schulz: [C: -1] "Per Tyler, otherwise fine" [core] - https://gerrit.wikimedia.org/r/70747 (owner: CSteipp)
[20:33:37] <grrrit-wm>	 (CR) Helder.wiki: "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75152 (owner: Mollywhite)
[20:35:53] <grrrit-wm>	 (CR) Mollywhite: "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/75152 (owner: Mollywhite)
[20:40:02] <grrrit-wm>	 (CR) Matmarex: [C: -1] "(6 comments)" [core] - https://gerrit.wikimedia.org/r/71911 (owner: Hashar)
[20:40:59] <grrrit-wm>	 (Abandoned) Jqnatividad: Added try catch block around MongoClient call to suppress MW error message that shows the entire MongoDB connection string when a connection can't be established. [extensions/ExternalData] - https://gerrit.wikimedia.org/r/72156 (owner: Jqnatividad)
[20:46:07] <reza1615>	 is there any one can deploy an enhancement bug?
[20:46:12] <grrrit-wm>	 (PS6) Legoktm: Log blacklist hits to Special:Log [extensions/SpamBlacklist] - https://gerrit.wikimedia.org/r/69303
[20:46:37] <reza1615>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=50311
[20:47:09] <reza1615>	 now it is 1.22wmf10 so we can do it!
[20:47:18] <bawolff>	 reza1615: oh, I totally forgot about the uca-fa stuff
[20:47:23] <bawolff>	 I should be paying more attention
[20:47:25] <reza1615>	 thanks
[20:47:28] <reza1615>	 :D
[20:47:55] <grrrit-wm>	 (PS7) Legoktm: Log blacklist hits to Special:Log [extensions/SpamBlacklist] - https://gerrit.wikimedia.org/r/69303
[20:48:17] <bawolff>	 reza1615: I personally cannot deploy it, but I can "suggest" the fix, and yell at people who can deploy it
[20:49:50] <reza1615_>	 exxuse I am disconnected!
[20:50:59] <grrrit-wm>	 (PS8) Legoktm: Log blacklist hits to Special:Log [extensions/SpamBlacklist] - https://gerrit.wikimedia.org/r/69303
[20:51:29] <reza1615_>	 bawolff: thats great
[20:51:54] <bawolff>	 reza1615_: So yes, I promise to nag people who have power to get it done
[20:52:26] <reza1615_>	 thanks!
[20:54:25] <grrrit-wm>	 (CR) Legoktm: "PS6-8: Updated the README with information about the logging features, moved the logging code into its own function, and revamped the comm" [extensions/SpamBlacklist] - https://gerrit.wikimedia.org/r/69303 (owner: Legoktm)
[20:56:11] <bawolff>	 reza1615_: Is that bug just for fa.wikipedia.org, or for all fa wikis?
[20:56:43] <reza1615_>	 for all farsi wikis
[20:57:35] <reza1615_>	 because of 4 letters (گ پ ژ چ) which are not in arabic
[20:58:04] <reza1615_>	 also arabic;s sorting is diffrent
[20:58:39] <bawolff>	 ok. Sometimes the wiktionary sites don't like the custom sort order as they have categories containing words not in the native language
[21:00:21] <grrrit-wm>	 (CR) Aaron Schulz: [V: 2] Enabled the schema updater hook [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[21:00:22] <grrrit-wm>	 (Merged) Aaron Schulz: Enabled the schema updater hook [extensions/OAuth] - https://gerrit.wikimedia.org/r/74685 (owner: Aaron Schulz)
[21:02:00] <reza1615_>	 bawolff: it has bug also in wikitanary http://fa.wiktionary.org/w/index.php?title=%D8%B1%D8%AF%D9%87:%D9%81%D8%B9%D9%84%E2%80%8C%D9%87%D8%A7%DB%8C_%D9%81%D8%A7%D8%B1%D8%B3%DB%8C&pagefrom=%D9%81%D8%B1%D9%88%D8%AE%D8%AA%D9%86#mw-pages
[21:03:13] <grrrit-wm>	 (PS1) Jqnatividad: added connect exception handling to suppress error message that may reveal sensitive info - e.g. the entire MongoDB connect string; turned on MongoCursor::$slaveOkay so ED will use secondary/slaves in a replica set should the primary/master MongoDB instan [extensions/ExternalData] - https://gerrit.wikimedia.org/r/75249
[21:10:15] <grrrit-wm>	 (CR) Brian Wolff: "In regards to namespaces. We don't exactly like them, but I think they're ok. Wikidata uses namespaces" [extensions/GWToolset] - https://gerrit.wikimedia.org/r/59405 (owner: Dan-nl)
[21:12:33] <MaxSem>	 hey hashar, how are you looking up PHP errors on beta?
[21:21:53] <hashar>	 MaxSem: just like in production, by looking at fatal.log
[21:21:53] <hashar>	 under /data/project/logs/
[21:26:42] <grrrit-wm>	 (CR) Parent5446: "(1 comment)" [extensions/GWToolset] - https://gerrit.wikimedia.org/r/59405 (owner: Dan-nl)
[21:39:16] <grrrit-wm>	 (PS1) Anomie: Have Special:CentralAutoLogin honor "Keep me logged in" [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75251
[21:40:07] <grrrit-wm>	 (CR) Anomie: [C: 2] "Backport of already-merged change to fix bug 51644." [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75251 (owner: Anomie)
[21:40:08] <grrrit-wm>	 (Merged) jenkins-bot: Have Special:CentralAutoLogin honor "Keep me logged in" [extensions/CentralAuth] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75251 (owner: Anomie)
[21:48:47] <grrrit-wm>	 (PS1) Legoktm: A checkbox is "check" in HTMLForm, not "checkbox" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75254
[21:50:32] <grrrit-wm>	 (PS5) MarkTraceur: Implement agora-style checkboxes [core] - https://gerrit.wikimedia.org/r/74662
[21:51:30] <grrrit-wm>	 (CR) MarkTraceur: "(3 comments)" [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[21:51:40] <grrrit-wm>	 (PS1) Legoktm: Allow for values to be prefilled via the URL [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255
[21:51:49] <grrrit-wm>	 (CR) MarkTraceur: "Addressed the comments, toned back the rollout strategy a titch." [core] - https://gerrit.wikimedia.org/r/74662 (owner: MarkTraceur)
[21:52:16] <grrrit-wm>	 (CR) Legoktm: [C: 2 V: 2] A checkbox is "check" in HTMLForm, not "checkbox" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75254 (owner: Legoktm)
[21:52:17] <grrrit-wm>	 (Merged) Legoktm: A checkbox is "check" in HTMLForm, not "checkbox" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75254 (owner: Legoktm)
[21:55:56] <legoktm>	 Elsie: https://gerrit.wikimedia.org/r/#/c/75255/
[21:56:52] <YuviPanda>	 aharoni: around?
[21:57:02] <aharoni>	 yup
[21:57:48] <Elsie>	 legoktm: Hi.
[21:57:53] <legoktm>	  Hi
[21:58:39] <Elsie>	 legoktm: Is the Labs instance up-to-date?
[21:58:45] <Elsie>	 I can do further notes, maybe.
[21:58:50] <legoktm>	 Not with that patch, no
[21:58:53] <legoktm>	 I can enable it if you want
[21:59:14] <legoktm>	 YuviPanda: ^
[21:59:24] <YuviPanda>	 legoktm: i left comments
[21:59:33] <grrrit-wm>	 (CR) Yuvipanda: [C: 1] "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255 (owner: Legoktm)
[21:59:33] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] added connect exception handling to suppress error message that may reveal sensitive info - e.g. the entire MongoDB connect string; turned o [extensions/ExternalData] - https://gerrit.wikimedia.org/r/75249 (owner: Jqnatividad)
[21:59:34] <grrrit-wm>	 (CR) Yaron Koren: [V: 2] added connect exception handling to suppress error message that may reveal sensitive info - e.g. the entire MongoDB connect string; turned o [extensions/ExternalData] - https://gerrit.wikimedia.org/r/75249 (owner: Jqnatividad)
[21:59:35] <grrrit-wm>	 (Merged) Yaron Koren: added connect exception handling to suppress error message that may reveal sensitive info - e.g. the entire MongoDB connect string; turned on MongoCursor::$slaveOkay so ED will use secondary/slaves in a replica set should the primary/master MongoDB instan [extensions/ExternalData] - https://gerrit.wikimedia.org/r/75249 (owner: Jqnatividad)
[21:59:42] * Elsie  blinks.

[21:59:44] <YuviPanda>	 legoktm: toollabs being weird
[21:59:48] <legoktm>	 Ah, ok
[21:59:53] <legoktm>	 Also, thanks :)
[22:00:37] <marktraceur>	 YuviPanda: Things I would love: Being able to set Ping: headers in a commit message that grrrit-wm then uses to actually ping those people when a commit is updated
[22:00:56] <YuviPanda>	 good feature, I'll probaly add that!
[22:00:58] <marktraceur>	 Easier than submitting, waiting for grrrit-wm to say something, then going "YuviPanda ^^"
[22:01:06] <legoktm>	 heheh
[22:01:07] <Elsie>	 Hrmmmm.
[22:01:09] <YuviPanda>	 marktraceur: I am, however, currently wondering if I broke UW in commons. Testing.
[22:01:15] <marktraceur>	 Oh, great jerb
[22:01:17] <Elsie>	 I'm not sure about a Ping: header.
[22:01:26] <YuviPanda>	 marktraceur: no, I didn't :) Just a cache thing
[22:01:32] <marktraceur>	 Ah, good
[22:01:40] <YuviPanda>	 marktraceur: can you, uh, confirm?
[22:01:48] <marktraceur>	 Elsie: I'd like something like it...I do that often enough
[22:02:18] <Elsie>	 I dunno. It feels kind of cluttery, especially as there's already a reviewer list.
[22:02:23] <Elsie>	 And you can star commits.
[22:02:37] <marktraceur>	 Elsie: "Ping:" would be for "this needs attention now-ish"
[22:03:14] <Elsie>	 Heh, I doubt that's how it would be used.
[22:03:29] * marktraceur  uses IRC way more than email anyway

[22:03:42] <marktraceur>	 I just breeze through the emails looking for important stuff
[22:04:15] <grrrit-wm>	 (PS2) Legoktm: Allow for values to be prefilled via the URL [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255
[22:04:16] <grrrit-wm>	 (CR) Legoktm: "(1 comment)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255 (owner: Legoktm)
[22:04:19] <marktraceur>	 But IRC pings mean "Oi, you, look at this now"
[22:04:24] <YuviPanda>	 marktraceur: you know what is horrible about email gerrit?
[22:04:26] <YuviPanda>	 marktraceur: jenkins-bot
[22:04:31] <legoktm>	 ^^^^
[22:04:40] <marktraceur>	 Yeah.
[22:04:47] <marktraceur>	 Well, that's one thing
[22:05:31] <marktraceur>	 I was actually hoping to stick emails from gerrit and bugzilla into a TODO list format
[22:05:36] <marktraceur>	 But, ah, that hasn't happened
[22:06:12] <marktraceur>	 YuviPanda: I can't step to the deed window
[22:06:18] <YuviPanda>	 marktraceur: cache issue.
[22:06:24] <YuviPanda>	 marktraceur: I refreshed my cache and it went away
[22:06:27] <Elsie>	 I complained about jenkins-bot mail on wikitech-l.
[22:06:29] <Elsie>	 I was told to get over it.
[22:06:30] <YuviPanda>	 marktraceur: or use debug=True
[22:06:32] <YuviPanda>	 and it goes away
[22:06:35] <marktraceur>	 I'm doing that
[22:06:41] <marktraceur>	 But we've had a problem like that before
[22:06:55] <marktraceur>	 And it wasn't *just* the cache
[22:07:01] <YuviPanda>	 oh?
[22:07:23] <marktraceur>	 It had to do with part of the JavaScript being cached before the update and some other part being cached after the update
[22:07:24] <legoktm>	 Elsie: I've updated the labs wiki and applied the url pre-filling patch
[22:07:28] <marktraceur>	 Which was a scary timing thing
[22:07:35] <marktraceur>	 So let's wait a few minutes and see what's up
[22:07:39] <YuviPanda>	 marktraceur: ... okay.
[22:07:51] <YuviPanda>	 ?debug=True wfm, so at least it's not my code.
[22:08:01] <YuviPanda>	 but yes, I'll give it another 5 minutes and then see what is up
[22:08:33] <Elsie>	 legoktm: Is page list redirect support there now?
[22:08:33] <grrrit-wm>	 (CR) Yuvipanda: [C: 2 V: 2] "lgtm, assuming 'default' is actually picked up :)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255 (owner: Legoktm)
[22:08:37] <YuviPanda>	 legoktm: ^
[22:08:41] <legoktm>	 YuviPanda: thanks.
[22:08:59] <Elsie>	 legoktm: We've really got to figure out a way to provide feedback to message senders.
[22:09:00] <marktraceur>	 YuviPanda: debug=true skips the cache so it makes sense that it would work
[22:09:08] <YuviPanda>	 marktraceur: indeed
[22:09:32] <legoktm>	 Elsie: Not yet. Maybe YuviPanda wants to review https://gerrit.wikimedia.org/r/#/c/75073/1 :)
[22:10:09] <legoktm>	 Elsie: Yeah, I was looking into that and it seems complicated. The issue is that now that the job queue is no longer mysql based, there's no way to get an easy overview of all the jobs
[22:10:33] <marktraceur>	 "config is undefined" is almost certainly a cache problem
[22:10:51] <YuviPanda>	 marktraceur: are we to poke Reedy?
[22:10:57] <marktraceur>	 Krinkle|detached, Reedy, see ^^
[22:11:16] <marktraceur>	 UW update seems to have caught the cache update funny again
[22:12:19] <YuviPanda>	 marktraceur: do you remember how it was fixed last time?
[22:12:31] <marktraceur>	 I don't
[22:12:38] <marktraceur>	 Krinkle and/or Reedy waved their wand(s)
[22:12:56] <grrrit-wm>	 (CR) Legoktm: [C: -1] "Actually, I want to do this differently. It's likely we'll need a "followRedirect" type function in multiple places, so this should really" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073 (owner: Legoktm)
[22:16:20] <YuviPanda>	 MaxSem: when mobile web did cache purges, was it to fix js cache problems? Or for something else?
[22:16:35] <YuviPanda>	 UploadWizard deployment hit a cache bug, wondering if it is something MObile has hit before
[22:16:48] * YuviPanda  pokes RoanKattouw_away

[22:20:05] <Reedy>	 Mobile use a different cache
[22:20:14] <Reedy>	 And they just purge everything
[22:20:24] <YuviPanda>	 Reedy: do you know what is happening with UW now?
[22:20:29] <Reedy>	 No
[22:20:49] <Reedy>	 The question is which files need touching/syncing
[22:21:34] <grrrit-wm>	 (PS2) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073
[22:21:48] <YuviPanda>	 Reedy: hmm, touching the js files causes the caches to refresh?
[22:21:52] <YuviPanda>	 touch them all? :D
[22:23:51] <grrrit-wm>	 (PS2) Aaron Schulz: Changed token updates to reset-only checkbox [extensions/OAuth] - https://gerrit.wikimedia.org/r/74923
[22:23:52] <grrrit-wm>	 (PS1) Aaron Schulz: Added an HMAC step to secret key usage [extensions/OAuth] - https://gerrit.wikimedia.org/r/75259
[22:24:43] <MaxSem>	 YuviPanda, we had a problem with non-standard resource delivery
[22:24:58] <MaxSem>	 as soon as we switched to full-fledged RL, they were gone
[22:26:12] <YuviPanda>	 ah, okay
[22:26:53] <Reedy>	 YuviPanda: I guess if there's some relevant JS files in UW..
[22:27:09] <YuviPanda>	 Reedy: want me to make a list of files that were changed since last deployment?
[22:27:45] <Reedy>	 Is there a lot? :p
[22:27:57] <YuviPanda>	 not thatmany
[22:29:04] <grrrit-wm>	 (PS3) Legoktm: If the spamlist is a redirect, follow it. If it's an interwiki redirect, throw an error. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75073
[22:29:05] <YuviPanda>	 Reedy: https://dpaste.de/6FdwS/
[22:32:12] <RoanKattouw>	 YuviPanda: ?
[22:32:38] <YuviPanda>	 RoanKattouw: just some JS caching issues with latest UploadWizard deploy, I believe Reedy is on it now
[22:33:31] <legoktm>	 YuviPanda: Once you're done with that, can you review https://gerrit.wikimedia.org/r/75073 please
[22:33:48] <RoanKattouw>	 OK
[22:34:48] <grrrit-wm>	 (CR) Aaron Schulz: [C: 2] Fix exception in ApiPageSet [core] - https://gerrit.wikimedia.org/r/75134 (owner: Anomie)
[22:37:06] <MatmaRex>	 speaking of RL caching issues… https://bugzilla.wikimedia.org/show_bug.cgi?id=51766
[22:37:14] <grrrit-wm>	 (Merged) jenkins-bot: Fix exception in ApiPageSet [core] - https://gerrit.wikimedia.org/r/75134 (owner: Anomie)
[22:40:00] <grrrit-wm>	 (PS2) Legoktm: Add a primitive de-duping feature when getting local pagelinks. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75068
[22:41:13] <grrrit-wm>	 (CR) Legoktm: "It does." [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255 (owner: Legoktm)
[22:41:14] <grrrit-wm>	 (Merged) Legoktm: Allow for values to be prefilled via the URL [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75255 (owner: Legoktm)
[22:44:24] <YuviPanda>	 Reedy: wfm now, did you do the cache touching?
[22:44:37] <YuviPanda>	 marktraceur: ^
[22:44:37] <Reedy>	 Yup
[22:44:37] <YuviPanda>	 Reedy: ty!
[22:44:42] <Reedy>	 [23:30:59] <logmsgbot> !log reedy synchronized php-1.22wmf11/extensions/UploadWizard
[22:44:47] <YuviPanda>	 ah, missed that
[22:46:15] <grrrit-wm>	 (PS2) Legoktm: Don't leave messages for non-existent users [extensions/MassMessage] - https://gerrit.wikimedia.org/r/75072
[22:53:08] <grrrit-wm>	 (PS4) Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938
[22:53:47] <grrrit-wm>	 (CR) Legoktm: "(6 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm)
[22:56:30] <grrrit-wm>	 (PS5) Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938
[22:56:45] <grrrit-wm>	 (CR) Legoktm: "PS5: Manual rebase" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm)
[23:01:16] <grrrit-wm>	 (PS1) Anomie: Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75261
[23:01:30] <grrrit-wm>	 (PS1) Anomie: Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75262
[23:02:05] <YuviPanda>	 how exactly do i construct a link to a special page from php code?
[23:02:10] * YuviPanda  attempts to check docs

[23:03:23] <grrrit-wm>	 (CR) Anomie: [C: 2 V: 2] Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75261 (owner: Anomie)
[23:03:24] <grrrit-wm>	 (Merged) Anomie: Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/75261 (owner: Anomie)
[23:03:30] <grrrit-wm>	 (CR) Anomie: [C: 2 V: 2] Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75262 (owner: Anomie)
[23:03:31] <grrrit-wm>	 (Merged) Anomie: Update CentralAuth to fix bug 51644 [core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/75262 (owner: Anomie)
[23:04:50] * Elsie  tickles legoktm.

[23:05:53] <legoktm>	 :>
[23:21:12] <legoktm>	 Does the database abstraction layer automatically unserialize data if it is serialized?
[23:21:56] <RoanKattouw>	 I don't believe so
[23:22:13] <RoanKattouw>	 Although I think the memcached abstraction layer does serialize/unserialize transparently
[23:23:02] <legoktm>	 Ok, thanks
[23:25:32] <legoktm>	 Yup, just confirmed it's not done automatically
[23:27:24] <grrrit-wm>	 (CR) Parent5446: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74580 (owner: Legoktm)
[23:35:43] <grrrit-wm>	 (PS2) MarkTraceur: WIP Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143
[23:36:01] <grrrit-wm>	 (CR) MarkTraceur: "Just rebasing to the new version of the parent commit" [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[23:36:45] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Add a 'feature' field type to HTMLForm [core] - https://gerrit.wikimedia.org/r/75143 (owner: MarkTraceur)
[23:36:57] <legoktm>	 Elsie: So I'm looking at https://doc.wikimedia.org/mediawiki-core/master/php/html/classJobQueueGroup.html#a5d7a2b7985e122684f8d3cce2c8939b2 and it seems it takes an optional $wiki, which means we might be able to insert jobs into another wiki's queue, solving a ton of GMD issues.
[23:50:15] <Hazard-SJ>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=51769 :/
[23:50:50] <Hazard-SJ>	 I guess I'll just use the GitHub clone for now :/
[23:55:13] <^d>	 HOLY MOTHER OF GOD.
[23:55:26] <^d>	 I HATE GITBLIT
[23:55:29] <^d>	 Hazard-SJ: Just clone from gerrit?
[23:59:56] <Hazard-SJ>	 ^d: I want to look at the files first :P