[00:19:59] grrrit-wm: github.com/yuvipanda/lolrrit-wm [00:20:00] err [00:20:02] Krenair: ^ [00:20:05] Krenair: it is, needs to be configurable. will do at osme point [00:20:06] the mediawiki/ replace [00:20:35] would prefer not to do it at all [00:20:40] Krenair: it also doesn't follow the mediawiki spacing guidelines, because that feels very unnatural to me. [00:20:44] well, I think that's redundant info. [00:20:54] will change my mind when we start having drupal/extensions [00:21:07] lol [00:21:14] :D [00:21:26] It still feels wrong to me :P [00:21:50] file a bug, I'll happily ignore it ;) [00:22:11] Krenair: but CR of the codebase would be nice. I'm writing JS after a break of about 6 months [00:22:16] I... even forgot that [] is true. [00:25:29] (that's also why I wrote that in JS than in Python) [00:44:22] YuviPanda: what is https://github.com/yuvipanda/lolrrit-wm/blob/master/src/preprocess.js#L12 for? [00:44:32] Does that mean changes for REL1_XX branches won't show up? [00:44:47] legoktm: anything that *isn't* master or production will show up [00:44:57] so REL1_XX, 1.22wmf11 etc will show up [00:44:59] (master) will not [00:45:06] Ohohoh. [00:45:07] Gotcha [00:45:10] :) [00:45:28] (PS1) Ori.livneh: Set ZMQ_HWM, ZMQ_LINGER & ZMQ_(SND|RCV)BUF on all sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74927 [00:45:46] (CR) Ori.livneh: [C: 2] Set ZMQ_HWM, ZMQ_LINGER & ZMQ_(SND|RCV)BUF on all sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74927 (owner: Ori.livneh) [00:46:07] (Merged) jenkins-bot: Set ZMQ_HWM, ZMQ_LINGER & ZMQ_(SND|RCV)BUF on all sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74927 (owner: Ori.livneh) [00:52:14] (PS1) Ori.livneh: Ganglia module: set ZMQ_HWM, ZMQ_LINGER & ZMQ_SNDRCV on SUB sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74928 [00:52:24] fucking fuck [00:52:35] (CR) Ori.livneh: [C: 2] Ganglia module: set ZMQ_HWM, ZMQ_LINGER & ZMQ_SNDRCV on SUB sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74928 (owner: Ori.livneh) [00:52:54] (Merged) jenkins-bot: Ganglia module: set ZMQ_HWM, ZMQ_LINGER & ZMQ_SNDRCV on SUB sockets [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74928 (owner: Ori.livneh) [00:54:12] I... should probably filter out jenkins-bot merged messages [00:54:39] don't talk to me about event filtering right now :P [00:55:22] Event Filtering Filtering Event SEO Good Best Filter Paper Filter xxx meta Event Organizing [00:56:12] * ori-l gets off the computer for a bit [00:56:17] smoke coming out of ears and all that [00:56:50] *that* is why there are helicopters over SF [00:57:07] It's just code, I guess it'll wait :) [00:57:09] * YuviPanda goes to sleep [01:53:37] (CR) Parent5446: "(3 comments)" [core] - https://gerrit.wikimedia.org/r/74678 (owner: Alex Monk) [02:19:17] (PS3) Alex Monk: WIP - Special:GroupPermissions (CA-like group editor) [core] - https://gerrit.wikimedia.org/r/74678 [03:09:08] (PS2) Hiong3-eng5: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 [03:12:43] (PS1) Aaron Schulz: Process cache the central user ID [extensions/OAuth] - https://gerrit.wikimedia.org/r/74931 [03:12:48] Yippie, build fixed! [03:12:48] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #201: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/201/ [03:19:02] (PS3) Hiong3-eng5: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 [03:21:23] (PS1) Aaron Schulz: Fixed remaining misuse of central user ID [extensions/OAuth] - https://gerrit.wikimedia.org/r/74932 [03:23:42] (PS4) Hiong3-eng5: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 [03:25:13] Yippie, build fixed! [03:25:13] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #123: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/123/ [03:27:03] (CR) Siddhartha Ghai: "(5 comments)" [extensions/ShortUrl] - https://gerrit.wikimedia.org/r/74649 (owner: Siddhartha Ghai) [03:29:42] Yippie, build fixed! [03:29:43] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #123: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/123/ [04:04:59] (CR) Mattflaschen: [C: -1] "(5 comments)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 (owner: Rjain) [04:05:29] grrr. [04:05:43] YuviPanda: That bot could use a cloak! [04:06:23] YuviPanda: Also some helpful WHOIS data (like a link to the source code!) [04:07:01] * marktraceur muses [04:07:07] wikimedia/code-review [04:07:13] wikimedia/Gerrit [04:07:28] bot@wikimedia/Gerrit might be cool [04:08:04] (CR) Santhosh: [C: -1] "(21 comments)" [extensions/ShortUrl] - https://gerrit.wikimedia.org/r/74649 (owner: Siddhartha Ghai) [04:08:45] (CR) Mattflaschen: "No, I meant for people testing locally. I just put it on toro, though." [extensions/GettingStarted] - https://gerrit.wikimedia.org/r/74822 (owner: Mattflaschen) [04:10:52] (PS1) Aaron Schulz: Made newFromNameVersionUser() not accept User objects to avoid confusion [extensions/OAuth] - https://gerrit.wikimedia.org/r/74933 [04:15:16] (CR) Santhosh: "(1 comment)" [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74658 (owner: Mollywhite) [04:16:08] (PS1) CSteipp: Enforce 1.0a callback param handling [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 [04:23:49] (CR) Aaron Schulz: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [04:27:26] (PS2) Mollywhite: Bug 51257: Improve chapter dropdown for books with many chapters. [extensions/BookManagerv2] - https://gerrit.wikimedia.org/r/74658 [04:31:26] (PS2) CSteipp: Enforce 1.0a callback param handling [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 [04:31:44] (CR) CSteipp: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [04:43:09] (CR) Aaron Schulz: "(1 comment)" [extensions/OAuth] - https://gerrit.wikimedia.org/r/74934 (owner: CSteipp) [04:45:30] (PS1) Aaron Schulz: Use MWOAuthUtils::grantName() to fix broken messages [extensions/OAuth] - https://gerrit.wikimedia.org/r/74935 [04:48:29] (PS1) Aaron Schulz: Added CLI guards around test scripts [extensions/OAuth] - https://gerrit.wikimedia.org/r/74936 [04:51:36] Project browsertests-en.wikipedia.org-linux-chrome build #199: FAILURE in 3 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/199/ [05:10:33] Yippie, build fixed! [05:10:33] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #151: FIXED in 5 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/151/ [05:26:01] (PS1) Legoktm: Make the user a bot, not a sysop. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74937 [05:26:16] (CR) Legoktm: [C: 2 V: 2] Make the user a bot, not a sysop. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74937 (owner: Legoktm) [05:26:17] (Merged) Legoktm: Make the user a bot, not a sysop. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74937 (owner: Legoktm) [05:56:16] (PS1) Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 [06:17:35] (PS1) Legoktm: Add a configuration option to respect the {{nobots}} exclusion syntax [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74939 [06:22:00] (PS1) Legoktm: Add a newline at the end of the file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74940 [06:22:17] (CR) Legoktm: [C: 2 V: 2] Add a newline at the end of the file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74940 (owner: Legoktm) [06:22:18] (Merged) Legoktm: Add a newline at the end of the file [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74940 (owner: Legoktm) [06:43:49] (PS11) Rjain: Added the destroy class [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 [07:40:17] (CR) Mattflaschen: [C: -1] "(3 comments)" [extensions/Annotator] - https://gerrit.wikimedia.org/r/74150 (owner: Rjain) [07:46:43] (PS1) Legoktm: [WIP] Add a function to extract GMD links from a spamlist. [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74941 [07:59:36] (PS1) Nikerabbit: Correct ApiQueryLanguageStats example [extensions/Translate] - https://gerrit.wikimedia.org/r/74942 [07:59:37] (PS1) Nikerabbit: Use constant group name in examples [extensions/Translate] - https://gerrit.wikimedia.org/r/74943 [07:59:38] (PS1) Nikerabbit: Check and disallowe dynamic groups in ApiQueryMessageGroupStats [extensions/Translate] - https://gerrit.wikimedia.org/r/74944 [08:00:06] (PS2) Nikerabbit: Check and disallowe dynamic groups in ApiQueryMessageGroupStats [extensions/Translate] - https://gerrit.wikimedia.org/r/74944 [08:09:01] (PS2) Legoktm: Hardcode the bot's username as $wgMassMessageAccountUsername [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 [08:14:44] (PS1) Legoktm: Merge action-globalunblock message into action-globalblock. [extensions/GlobalBlocking] - https://gerrit.wikimedia.org/r/74945 [08:15:47] (CR) Legoktm: "(1 comment)" [extensions/GlobalBlocking] - https://gerrit.wikimedia.org/r/48608 (owner: Legoktm) [08:16:15] (PS1) Nikerabbit: Add getFileExtensions to XliffFFS [extensions/Translate] - https://gerrit.wikimedia.org/r/74946 [08:17:17] (Abandoned) Legoktm: testing gerrit-wm [Do not merge] [pywikibot/core] - https://gerrit.wikimedia.org/r/72141 (owner: Legoktm) [08:17:39] YuviPanda: ^ heh, wrong channel. [08:20:47] (PS1) Ori.livneh: Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 [08:21:07] (CR) jenkins-bot: [V: -1] Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 (owner: Ori.livneh) [08:21:37] E126 continuation line over-indented for hanging indent [08:21:39] catastrophic [08:22:29] (PS2) Ori.livneh: Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 [08:24:05] (PS3) Ori.livneh: Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 [08:24:36] (CR) Ori.livneh: [C: 2] Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 (owner: Ori.livneh) [08:24:56] (Merged) jenkins-bot: Centralize the configuration of ZeroMQ sockets. [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74947 (owner: Ori.livneh) [08:35:03] (CR) Raimond Spekking: [C: 2] Merge action-globalunblock message into action-globalblock. [extensions/GlobalBlocking] - https://gerrit.wikimedia.org/r/74945 (owner: Legoktm) [08:35:04] (Merged) jenkins-bot: Merge action-globalunblock message into action-globalblock. [extensions/GlobalBlocking] - https://gerrit.wikimedia.org/r/74945 (owner: Legoktm) [08:41:08] (PS1) Ori.livneh: Update test descriptions and fix bug in string handling [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74948 [08:41:35] (CR) Ori.livneh: [C: 2] Update test descriptions and fix bug in string handling [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74948 (owner: Ori.livneh) [08:41:53] (Merged) jenkins-bot: Update test descriptions and fix bug in string handling [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74948 (owner: Ori.livneh) [08:51:15] (PS1) Ori.livneh: Update scripts to use stream.py API [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74949 [08:51:35] (CR) Ori.livneh: [C: 2] Update scripts to use stream.py API [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74949 (owner: Ori.livneh) [08:51:52] (Merged) jenkins-bot: Update scripts to use stream.py API [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74949 (owner: Ori.livneh) [09:18:23] legoktm: pywikibot config fixed :) [09:29:57] (CR) Amire80: [C: 2] "Tested. Thanks for the patch." [core] - https://gerrit.wikimedia.org/r/74675 (owner: Ebrahim) [09:32:20] (Merged) jenkins-bot: Tweak Special:Log/block for supporting RTL wikis [core] - https://gerrit.wikimedia.org/r/74675 (owner: Ebrahim) [09:38:58] (CR) Yuvipanda: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74938 (owner: Legoktm) [09:42:01] (CR) Yuvipanda: "(2 comments)" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74939 (owner: Legoktm) [09:45:57] YuviPanda: I like the bot's output so much better now [09:46:05] ori-l: :D [09:46:20] ori-l: my only remaining pet peeve is the '(2 comments)' thing, but not sure how to fix that. [09:46:20] what with it being actually useful now [09:46:37] ori-l: indeed. pinging owner when their code is reviewed sounds useful. [09:46:54] (PS1) Amire80: Document the block duration tooltip [core] - https://gerrit.wikimedia.org/r/74950 [09:47:00] i think it's an upstream bug, tbh [09:47:26] ori-l: indeed, stream events doesn't give me the data for inline comments. And I dont' want to make a REST api call for every thing. [09:47:49] yeah, I think the bot's behavior is correct [09:48:10] true. [09:48:23] I'm trying to figure out if I should filter out merged messages from jenkins-bot more [09:48:25] aggressively [09:49:01] unsure though, since one gets a message and the other gets subject [09:49:23] ori-l: do look at the code when you have time. I just realized that I've not been writing any serious javascript for the last 8-9 months [09:49:37] i just looked :) [09:50:03] :D [09:50:23] concious decision to not use mediawiki style spacing, since that has always felt 'wrong' to me. [09:51:08] what's so wrong about it? [09:51:37] nothing , i am sure [09:52:25] I should rewrite wikibugs at some point, in some other language. Not sure if it can run outside of production tho [09:53:13] ori-l: I also wrote up about the Redis setup on toollabs (http://yuvi.in/blog/attempting-to-secure-redis-in-a-multi-tenant-environment/) [09:53:17] i think it's ok to have other languages in production [09:53:20] slowly easing back to blogging regularly. [09:53:38] ori-l: sure, but I prefer running things in toollabs, since it is more maintainable / accesible that way [09:54:21] and it also means it is easy enough to add other things. SuchABot populating a stable Gerrit queue meant I could trivially add this new bot without having to worry about message reliability [09:54:25] oh, i see what you're saying [09:55:27] yeah, so a similar queue for bugzilla will also make it trivial to do other tools [09:55:29] for everyone [09:56:46] with liberty and justice for all [09:56:59] Redis for all! [09:57:12] heh [09:57:24] ori-l: I'm going to start writing up a patch for JsonContent starting later today. [09:57:40] and then write an RFC. Don't want it to be one of those floating RFCs that have no code behind. [09:58:00] not too sure if an RFC is required at all, tbh [09:58:30] * ori-l has a floating RFC at the moment :/. Need to update it. [09:58:34] I've also been thinking of replacing our IRC RC Feed with Redis based pubsub. [09:58:52] I don't think an RFC would be required, because: [09:59:09] - Existing use in 4 extensions demonstrates utility [09:59:47] - The code you'd be adding would consist of a couple of self-contained files/classes and require no (or very little) modification of existing interfaces [09:59:58] so that seems uncontroversial [10:00:02] indeed [10:00:16] only question in my mind is if I should make it JsonContent or AbstractJsonContent [10:00:31] hmmm, JsonContent is fine [10:00:36] since TextContent is TextContent too [10:00:44] yeah, I think so [10:00:51] and validation is optional [10:00:54] and not required [10:01:05] it always validates that it *is* JSON [10:01:06] but nothing more [10:01:40] hmm, and prettify while storage also makes sense [10:01:55] because diffs [10:04:15] i also figured that having the input beautified is a way of thoroughly reconstructing it and thus getting some additional insurance that there's no bizarre json making it in [10:04:56] indeed [10:24:21] YuviPanda: can you change your username from admin to something else in http://yuvi.in/blog/attempting-to-secure-redis-in-a-multi-tenant-environment/ ? [10:24:56] when running that from en.planet.wikimedia it only says "admin" [10:28:23] Nikerabbit: whoops. will do [10:29:26] YuviPanda: wordpress allows you to customize it somewhere [10:29:27] (CR) Umherirrender: "The added code should be in an own function, because the added if-return can make problems, when another piece of information will be adde" [core] - https://gerrit.wikimedia.org/r/40096 (owner: Alex Monk) [10:29:38] Nikerabbit: yeah, i Just checked. Those are already 'yuvipanda' [10:29:49] aha, got it [10:29:50] fixing [10:30:35] done [10:30:57] ([Keysone][3] perhaps) <- is that supposed to be a link or something? [10:31:21] gah, yes. [10:31:22] markdown [10:31:32] link to http://keystone.openstack.org/ it was supposed to be [10:31:36] let me fix [10:31:59] updated [10:32:37] you might also want to fix the typo then [10:32:54] (CR) Umherirrender: "Bad spacing." [core] - https://gerrit.wikimedia.org/r/74618 (owner: Fantasticfears) [10:33:14] Nikerabbit: done again. [10:33:21] and maybe add a verb to "I don't handrolling auth code" ;) [10:34:37] this is what I get for writing blog posts at 5AM [10:36:08] brb [10:36:54] (CR) Umherirrender: [C: 1] "Only mini optimization, but looks good. Maybe you can add the word "option" to the commit message, because at the moment it reads like thi" [core] - https://gerrit.wikimedia.org/r/74578 (owner: Krinkle) [10:42:07] (PS1) Ori.livneh: (WIP) Consolidate stream processing logic in stream.py [extensions/EventLogging] - https://gerrit.wikimedia.org/r/74951 [10:50:56] hello YuviPanda [10:51:14] your bot is printing duplicated lines [11:04:25] liangent: heya [11:04:27] liangent: where? [11:04:44] YuviPanda: #wikimedia-wikidata [11:21:09] (PS1) Matmarex: Enhanced RC: Optimization of the initial collapsing [core] - https://gerrit.wikimedia.org/r/74955 [11:24:03] (PS5) Kipcool: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 (owner: Hiong3-eng5) [11:25:54] (PS6) Kipcool: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 (owner: Hiong3-eng5) [11:27:10] (CR) Kipcool: [C: 2 V: 2] Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 (owner: Hiong3-eng5) [11:27:11] (Merged) Kipcool: Created Expressions Class;Jobs cleaned;some Setup [extensions/WikiLexicalData] - https://gerrit.wikimedia.org/r/74311 (owner: Hiong3-eng5) [11:41:15] (PS1) Matmarex: jquery.makeCollapsible: tests for collapse and expand text [core] - https://gerrit.wikimedia.org/r/74959 [11:53:10] (PS2) Matmarex: jquery.makeCollapsible: tests for collapse and expand text [core] - https://gerrit.wikimedia.org/r/74959 [11:53:11] (PS1) Matmarex: jquery.makeCollapsible: Consistency in test names [core] - https://gerrit.wikimedia.org/r/74962 [12:01:38] (PS1) Umherirrender: Api: Add editnotices to prop=info [core] - https://gerrit.wikimedia.org/r/74963 [12:02:46] (Abandoned) Karima Rafes: I forget to remove gems [qa/browsertests] - https://gerrit.wikimedia.org/r/71917 (owner: Karima Rafes) [12:16:33] (PS1) Matmarex: jquery.makeCollapsible: Some low-level tests [core] - https://gerrit.wikimedia.org/r/74965 [12:33:25] (PS2) Rtdwivedi: Moved the whole display of fields to PHP. [extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/74850 [12:38:13] (CR) Siebrand: "(1 comment)" [extensions/Translate] - https://gerrit.wikimedia.org/r/74944 (owner: Nikerabbit) [12:45:34] (CR) jenkins-bot: [V: -1] jquery.makeCollapsible: Tests for collapsible ,
    ,
      [core] - https://gerrit.wikimedia.org/r/74969 (owner: Matmarex) [12:45:35] (CR) Nikerabbit: "(1 comment)" [extensions/Translate] - https://gerrit.wikimedia.org/r/74944 (owner: Nikerabbit) [12:47:04] (PS1) Jeroen De Dauw: Add PHP coveralls to the TravisCI build [extensions/Serialization] - https://gerrit.wikimedia.org/r/74970 [12:47:38] (CR) Jeroen De Dauw: [C: 2 V: 2] Add PHP coveralls to the TravisCI build [extensions/Serialization] - https://gerrit.wikimedia.org/r/74970 (owner: Jeroen De Dauw) [12:47:39] (Merged) Jeroen De Dauw: Add PHP coveralls to the TravisCI build [extensions/Serialization] - https://gerrit.wikimedia.org/r/74970 (owner: Jeroen De Dauw) [12:51:59] (PS2) Matmarex: jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - https://gerrit.wikimedia.org/r/74969 [12:54:31] (CR) jenkins-bot: [V: -1] jquery.makeCollapsible: Tests for collapsible
,
    ,
      [core] - https://gerrit.wikimedia.org/r/74969 (owner: Matmarex) [13:09:28] (CR) Matmarex: "I have no idea why the tests are failing… it seems like QUnit is running the assertions twice?" [core] - https://gerrit.wikimedia.org/r/74969 (owner: Matmarex) [13:17:24] (CR) Siddhartha Ghai: "(6 comments)" [extensions/ShortUrl] - https://gerrit.wikimedia.org/r/74649 (owner: Siddhartha Ghai) [13:40:39] (Abandoned) Matmarex: ext.centralauth.centralautologin.css: Use transition instead of animation [extensions/CentralAuth] - https://gerrit.wikimedia.org/r/74485 (owner: Matmarex) [13:46:18] (CR) Helder.wiki: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74955 (owner: Matmarex) [13:54:54] (PS2) Matmarex: Enhanced RC: Optimization of the initial collapsing [core] - https://gerrit.wikimedia.org/r/74955 [13:58:29] (CR) Matmarex: "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74955 (owner: Matmarex) [14:11:59] (PS1) Shirayuki: Fix labels and error messages [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74976 [14:31:49] (PS1) Liangent: Fix API error message when titlePartToKey / keyPartToTitle are used [core] - https://gerrit.wikimedia.org/r/74977 [14:39:40] (CR) Matmarex: "Krinkle: still working on this?" [core] - https://gerrit.wikimedia.org/r/72322 (owner: Matmarex) [14:47:09] (CR) Matmarex: [C: -1] "(3 comments)" [core] - https://gerrit.wikimedia.org/r/74407 (owner: Alex Monk) [14:47:45] MatmaRex, the proxy thing was not my idea. [14:48:35] yeah, i know [14:48:39] i still don't like it :) [14:48:53] Groan... I wish I could have two git repos tied today with uncommitted changes on one while fixing up other commits on the other [14:49:00] s/today/together - wtf brain [14:52:03] Krenair: it's called git stash :) [14:52:12] I really should learn how to use it [14:52:24] $ git stash; …do stuff…; git stash pop; [14:53:08] very simple until you do something silly like pop changes when you're on a different branch than the one you stashed them on, and get a weird-ass merge conflict [14:53:12] so don't do that. :D [14:55:29] I never manage not to do things considered stupid by git, apparently; if only I knew which they are :) [14:56:02] (PS7) Alex Monk: mediawiki.notification: Expose close method to hide a Notification [core] - https://gerrit.wikimedia.org/r/74407 [14:56:16] (CR) Matmarex: "This doesn't actually depend on the dependency? I'll rebase it." [core] - https://gerrit.wikimedia.org/r/74401 (owner: TheDJ) [14:56:25] (PS2) TheDJ: Tablesorter: Add testcase for unsortable column [core] - https://gerrit.wikimedia.org/r/74401 [14:56:41] Nemo_bis: it'snot considered stupid by git [14:56:58] Nemo_bis: the trouble is, `git stash`can stash both changes in working directory and in index [14:57:12] Nemo_bis: and this directly conflicts with how merge conflicts are handled [14:57:24] with unmerged (conflicted) files being in working directory only, and merged ones being in index [14:57:34] i don't remember how thisis handled right now [14:57:40] but ican tell you it's not handled well [15:09:56] (CR) Matmarex: [C: -1] "(1 comment)" [core] - https://gerrit.wikimedia.org/r/74401 (owner: TheDJ) [15:11:01] (PS3) Matmarex: Tablesorter: Add testcase for unsortable column [core] - https://gerrit.wikimedia.org/r/74401 (owner: TheDJ) [15:11:18] (CR) Matmarex: [C: 2] "Fixed whitespace issue. Good to go." [core] - https://gerrit.wikimedia.org/r/74401 (owner: TheDJ) [15:15:02] (Merged) jenkins-bot: Tablesorter: Add testcase for unsortable column [core] - https://gerrit.wikimedia.org/r/74401 (owner: TheDJ) [15:17:04] (CR) Matmarex: [C: -1] "(2 comments)" [core] - https://gerrit.wikimedia.org/r/74500 (owner: TheDJ) [15:17:59] (PS1) Umherirrender: Do not override OutputPage properties in addParserOutputNoText [core] - https://gerrit.wikimedia.org/r/74978 [16:01:29] (CR) Matmarex: [C: 1] mediawiki.notification: Expose close method to hide a Notification [core] - https://gerrit.wikimedia.org/r/74407 (owner: Alex Monk) [16:03:44] I want a magic wand of git blame acceleration [16:04:10] (PS5) Alex Monk: Provide a JSON recent changes feed. [core] - https://gerrit.wikimedia.org/r/52922 (owner: Victor Vasiliev) [16:06:40] (CR) jenkins-bot: [V: -1] Provide a JSON recent changes feed. [core] - https://gerrit.wikimedia.org/r/52922 (owner: Victor Vasiliev) [16:08:38] (CR) Amire80: [C: 2] Naming convention fix. [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74582 (owner: Santhosh) [16:08:49] (Merged) jenkins-bot: Naming convention fix. [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74582 (owner: Santhosh) [16:11:46] (PS6) Alex Monk: Provide a JSON recent changes feed. [core] - https://gerrit.wikimedia.org/r/52922 (owner: Victor Vasiliev) [16:20:23] (CR) Amire80: [C: 2] Update the previous UI and content font whenever font value changes [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74583 (owner: Santhosh) [16:20:31] (Merged) jenkins-bot: Update the previous UI and content font whenever font value changes [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74583 (owner: Santhosh) [16:21:26] (CR) Amire80: [C: 2] Remove unused test html file [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74587 (owner: Santhosh) [16:21:33] (Merged) jenkins-bot: Remove unused test html file [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74587 (owner: Santhosh) [16:22:15] (Abandoned) Alex Monk: Tweak account creation interface messages for logged in users [core] - https://gerrit.wikimedia.org/r/39862 (owner: Alex Monk) [16:25:55] Krenair: thanks for https://bugzilla.wikimedia.org/show_bug.cgi?id=43172 cleanup, sorry about duplication :( [16:26:29] I went through all my commits to do rebases, and when I got to this one I noticed it looked like it had been done by someone else [16:27:19] My one had been sitting there for 7 months with spage on the reviewer list before that one was even uploaded [16:27:57] And it was merged in 9 days [16:28:55] heh, normal [16:29:04] (CR) Legoktm: [C: 2 V: 2] "Thanks!" [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74976 (owner: Shirayuki) [16:29:05] (Merged) Legoktm: Fix labels and error messages [extensions/MassMessage] - https://gerrit.wikimedia.org/r/74976 (owner: Shirayuki) [16:29:07] perhaps the second bug was somehow clearer, or just luckier [16:30:25] normal? [16:30:30] Pretty sure it's happened to me before [16:30:36] but it's not what I'd call normal [16:32:46] Oh, and there was some (not good) discussion about my own commit in the e3 channel in February as well. PMing you [16:36:29] (PS2) Amire80: Better blacklisting of browsers using $.client [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74584 (owner: Santhosh) [16:37:26] (CR) Amire80: [C: 2] Better blacklisting of browsers using $.client [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74584 (owner: Santhosh) [16:37:36] (Merged) jenkins-bot: Better blacklisting of browsers using $.client [extensions/UniversalLanguageSelector] - https://gerrit.wikimedia.org/r/74584 (owner: Santhosh) [16:57:17] (CR) Amire80: [C: -1] "An and a