[00:05:48] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74267 [00:06:00] New patchset: Ori.livneh; "Load plug-in data sinks from preconfigured location" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74303 [00:06:49] New patchset: Ori.livneh; "Load plug-in data sinks from preconfigured location" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74303 [00:11:49] New patchset: Mollywhite; "Fix PHPunit failure" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74304 [00:12:06] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74304 [00:15:29] New review: Ori.livneh; "> this change will severely limit the instant readability of the code for people who don't dream jqu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [00:19:14] New patchset: Adamw; "Generalized mailing job queue" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [00:20:51] New review: Yuvipanda; "+1 to having it be greppable." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [00:24:49] New patchset: SuchABot; "Scroll down to show some new categories when they turn up" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/74306 [00:41:34] New patchset: MarkTraceur; "Add user count, play with layout a bit" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/74307 [00:46:09] GorillaWarfare: I'm going to love it when you have a form to edit the JSON blobs :p [00:47:00] especially since it seems like I might be missing a param some where... I get the following stack trace: http://pastebin.com/p9mLhBRq [00:47:36] mwalker: Ummm [00:47:37] Hmm [00:48:21] using the following json: {"title":"FooBar","authors":["Matt Walker"], "sections": [{"name":"Section Name","link":"Foo" }] } [00:48:23] It should display an error above the edit box if there's an issue with the JSON... you're saying it's breaking altogether? [00:48:42] well; it's 'breaking' on the NS_MAIN page [00:48:51] it accepted my NS_BOOK json [00:49:07] New patchset: Hoo man; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [00:50:11] Yikes, so it is [00:50:12] O.o [00:50:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71596 [00:50:48] New review: Hoo man; "Fixed the loop for getting the group assignments, minor changes, per Anomie" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [00:50:49] it'll actually also accept a blank {} [00:50:57] and then break in a similar manner [00:51:21] The blank foo is a bug that I have filed [00:52:17] I'm going to poke at it a bit. What's the name of the page you put that JSON in? [00:52:23] awww, no ^demon. [00:53:32] FooBar [00:53:53] I think part of it is that it doesn't like that there's not a section named "FooBar" in the sections list [00:54:29] * GorillaWarfare files a bug [00:54:39] heh, I confused marktraceur with hexmode, since I've never heard of marktraceur as 'Mark H.' :) [00:55:04] GorillaWarfare: yep [00:55:24] the whole big grossness goes away if the section is named after the page [00:55:51] anyways... back to what I was really trying to do --- with your patch that you put in my queue; is this just temporary testingness? [00:56:06] because if so; it works and I'll +2 it [00:56:14] otherwise; I'll -1 it because you should i18nize messages [00:56:37] mwalker: Not temporary [00:56:39] And damn, habit :P [00:56:42] I'll fix that [00:57:18] YuviPanda Context? [00:57:20] GorillaWarfare: ok; whilst you're in there you might want to consider how you can merge those two if statements together [00:57:31] marktraceur: wikitech-l, the hotcat thread [00:57:37] GorillaWarfare: so you have less duplicated code [00:58:17] Oh, YuviPanda, you thought hexmode was doing the BetaFeatures business? Hilaaaarious. [00:58:35] marktraceur: indeed. I was... confused. [00:58:39] marktraceur: but who calls you Mark H. [00:59:08] *shrug* almost nobody in the Foundation [00:59:18] indeed. [00:59:26] people who don't want to confuse mr traceur with mark bergsma? [00:59:27] A) Because it's still ambiguous B) Because I'm marktraceur, damn it [01:00:05] yeah, calling people IRL with their IRC nicks ftw! [01:00:16] I still call tfinc tee-fink [01:00:20] Yes [01:00:34] YuviPanda: I think it's maybe worse that I call Tina Mrs. tfinc [01:00:42] hah! [01:00:55] Mrs. Tea Fink! [01:03:33] * marktraceur goes home [01:03:38] Bloody well late enough [01:06:07] New patchset: Hiong3-eng5; "Created Expressions Class;Jobs cleaned;some Setup" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/74311 [01:07:54] anyone who can give me more rights on gerrit? [01:36:39] New patchset: Ori.livneh; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [01:37:41] New review: AzaToth; "You can't just separate debian dir in a separate repo, no tools assumes such setup and you would hav..." [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [01:39:28] New patchset: Krinkle; "Move firing of "wikipage.content" mw.hook out of mediawiki.util" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74312 [01:39:36] New review: Ori.livneh; "Code looks good. Have you tested this?" [mediawiki/extensions/GuidedTour] (master) C: 1; - https://gerrit.wikimedia.org/r/64981 [01:39:37] New patchset: Krinkle; "mediawiki.page.ready: Use wikipage.content instead of domready" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74313 [01:39:40] New patchset: Krinkle; "mediawiki.action.edit.preview: Fire "wikipage.content" mw.hook" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74314 [01:40:39] New review: Mwalker; "@Nikerabbit; not sure why you would be getting empty license links... Empty columns I understand, bu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [01:41:10] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [01:41:40] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [01:49:29] New patchset: Krinkle; "Remove cache group "ext.vector" from modules definitions" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/74315 [01:52:00] New patchset: Mwalker; "Further Cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [01:52:35] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [01:54:51] Change merged: jenkins-bot; [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [01:55:35] TimStarling: Any idea on why the first patch set worked now? [01:55:59] it didn't work for me [01:56:04] mh [01:58:03] TimStarling: how is RfC land going? [01:58:03] When you edit a PHP extension, do you have to recompile PHP to test the changes? [01:58:26] (Just out of curiosity.) [01:58:51] I tried to identify the core change that caused it... but no luck... the bug can is there for quite some time (couldn't go back further than 1.21wmf9 due to my extensions) [01:59:05] AaronSchulz: lots of fun [01:59:49] Elsie: no, it lets you compile extensions as shared libraries [02:00:01] TimStarling: How will the deployment of that patch work? Is puppet recompiling the extension or do you have to do that per hand? [02:00:09] unlike HipHop, btw, which apparently has no binary interface [02:00:13] So you can just directly edit the files and it has immediate effect? [02:00:27] you recompile and install the extension, and restart apache [02:00:50] hoo: I have to do it by hand [02:00:51] TimStarling: Sure, I did that several times today... I meant in WMF-production [02:00:58] ok [02:01:06] I was talking to Elsie [02:01:11] liangent just commented on the bug, BTW. [02:01:58] The initial version isn't working for me now either... maybe I was on the if-version when running the parser tests etc. ... dunno :/ Sorry for the confusion [02:06:24] hoo: Thanks for working on that bug. :-) [02:07:46] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74303 [02:08:05] Elsie: You're welcome... although I probably mostly caused confusion instead of really helping :P [02:09:54] Re: "zval_ptr_dtor", is there any good reason for such abbreviations these days? [02:10:15] I think ptr is pointer. No idea what dtor and zval are supposed to expand to. [02:11:03] Elsie: That's a fancy name... I'm already glad they didn't make zpd out of it or something like that :P [02:11:14] Heh. [02:12:04] Now seriously... those are really poor documented black magic-like functions... they are simple, but you have to read the source to get what they exactly do [02:12:26] There's *no* real reference for those AFAIK (Tim might know better) [02:12:50] It just seems like it punishes every future developer in favor of saving very little time and very few bytes. [02:14:52] Yeah... I'm not really looking forward to touch PHP extension ever again :P [02:25:27] New review: Mattflaschen; "Makes sense, works locally." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74314 [02:25:48] New review: Krinkle; "Just checking: Did you generate, push or test any of these job updates/creations?" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74284 [02:26:07] New patchset: Krinkle; "Add DataTypes" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74282 [02:27:11] New patchset: Krinkle; "Release notes for Ie04f23c1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74183 [02:28:52] TimStarling: Rebase with CR+2 is nicer indeed. I've come around, found myself doing it several times and it just feels right. [02:29:51] There's no wg JavaScript variable for the actual revision ID (e.g. if you're looking at an oldid page)? [02:30:59] superm401: there is [02:31:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74183 [02:31:43] https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific [02:31:49] wgCurRevisionId [02:32:19] Krinkle, that's the top one. [02:32:25] No, it isn't. [02:32:32] Documentation is just confusing. [02:33:00] https://en.wikipedia.org/wiki/?oldid=1 [02:33:12] New patchset: Rasel160; "Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:33:17] Hm.. it was [02:33:24] uh? [02:33:36] I would've sworn.. [02:33:48] I vaguely remember it being, but this is the first use case I've had. [02:33:53] Plus it makes sense this way. [02:33:58] I'll do a blame anyway to check. [02:34:05] There's *no* real reference for those AFAIK (Tim might know better) [02:34:09] you just have to read the source [02:34:25] superm401: var revisionId = new mw.Uri().query.oldid || mw.config.get( 'wgCurRevisionId' ) [02:34:28] not much in the way of references of any kind, let alone real references [02:34:36] very few comments, as well [02:34:50] yes :/ [02:37:51] Krinkle, that will fail for diff=next and similar. [02:38:24] True, but do you want to execute your script when action !== view ? [02:38:49] this snippet is from VE which is inside an isViewPage condition, so it excludes diff [02:39:26] Krinkle, in this case, probably yes. [02:39:33] This came up when I was testing Richa's annotation code. [02:39:41] also because on a diff, even without diff=next and magic values alike, param 'oldid' means something else. The 'diff' value is the one rendered below the diff. [02:39:51] I think it would be useful to show the annotations on diff pages, since the page content shows. [02:40:01] Krinkle, right, I know. [02:40:19] annotations? [02:40:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 [02:45:48] New patchset: Tim Starling; "Changelog for version 1.0" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74317 [02:46:35] Change merged: jenkins-bot; [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74317 [02:48:34] hoo: you merged a faulty change [02:49:12] New patchset: Tim Starling; "Fix distribution" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74318 [02:49:17] maybe you should just let me click the buttons [02:49:42] Change merged: Tim Starling; [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74318 [02:50:11] Krinkle, traced it all the way back to when it was added out of curiosity: 66055b27a7e0b997d50897300936f64b0a4641b8 [02:50:17] Though of course that was really the SVN days. [02:50:25] Seems like it was always really the latest. [02:50:45] Definitely unintuitive, though. I think we should add a wgRevisionId, will submit a bug for it. [02:54:59] New review: MarkTraceur; "http://media.marktraceur.info/u/marktraceur/m/input-is-too-big/" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [02:55:57] Sorry again... time to sleep now [03:08:10] New review: Krinkle; "not tested, but I suspect this causes it to emit the warning on every page by default because we rea..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [03:09:20] New review: Krinkle; "I'd be for removing it from mw.toolbar and making it into a no-op (effectively no longer supporting ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [03:19:28] New patchset: Alex Monk; "Deprecate mwCustomEditButtons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [03:27:28] New patchset: Rasel160; "Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [03:28:29] New review: Mattflaschen; "Works if the JavaScript error is fixed." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72361 [03:32:29] New patchset: Mattflaschen; "Added the destroy class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/74150 [03:37:55] New patchset: Mattflaschen; "Added the destroy class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/74150 [03:39:51] New patchset: Aaron Schulz; "Allow for IDatabase to be used as type hints for DatabaseBase|DBConnRef" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74320 [03:40:37] TimStarling: ^ [03:40:49] seemed like the simplest way [03:41:16] heh [03:41:22] you see why I don't like type hinting [03:42:05] right, of course, IDatabase can't actually specify any methods [03:42:17] it's enough to make a real architect cry isn't it? ;) [03:43:17] TimStarling: well I could add a bunch of boilerplate, but meh [03:43:21] New patchset: Tim Starling; "Allow for IDatabase to be used as type hints for DatabaseBase|DBConnRef" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74320 [03:43:34] that would just be OCD purity [03:44:20] if you specified the methods in IDatabase, then you would have to specify them in DBConnRef as well, I don't think __call() is enough to avoid a fatal error [03:44:33] that's what I mean by boilerplate [03:45:00] yeah, but then you have a maintenance overhead [03:45:12] which is why I didn't go that route ;) [03:45:30] I trust __call() better than a programmer [03:45:59] I would have just removed all the type hints [03:46:08] but each to their own :) [03:47:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74320 [03:54:51] TimStarling: hmm, so for DBConnRef, I think it should not auto-call the reuse function if it's in a TRX (which can happen with DBO_TRX) [03:55:47] it would still get reused for same DB conns its seems (which is good) but not for ones that would need selectDB() (since cross-DB trxs are not supported) [03:55:58] at least from reading openForeignConnection() [03:56:14] fair enough [03:59:14] TimStarling: I can probably also set onTransactionIdle() to call reuse in that case to clean it up [04:01:00] presumably a transaction opened by the DBConnRef itself should just be closed [04:01:56] since there wouldn't be any way to access it after the DBConnRef is deleted [04:03:00] there would be no way to access the ref but not the connection handle [04:03:27] if I call a() and b() and they both make writes to the same foreign DB, they can/should reuse the handle [04:04:18] and reuse the same transaction? [04:04:23] hmm, reuse might get called twice, though that probably doesn't matter [04:04:27] right [04:05:21] ok, but that suggests that there will still be a need to explicitly clean up DBO_TRX connections [04:05:26] which seems to defeat the purpose of DBConnRef [04:08:15] I think one could go the route of having the trx wrapped in the scope, hmm [04:09:07] or have LoadBalancer keep track of a reference count for the transaction [04:09:23] the same way it keeps a reference count for the connection [04:09:34] when the trx ref count goes to zero, it can do a commit [04:24:04] New review: Parent5446; "This is terrible software design at its worst. Why did this get merged? At the very, very least, the..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74320 [04:28:23] Aaron|home: oh dear, we seem to have annoyed Tyler [04:28:33] TimStarling: though that would mean commit() would lose the guarantee that anything actually happened [04:29:58] DBConnRef::commit() can have different semantics than DatabaseBase::commit() [04:30:13] assuming DBConnRef will only be used in special cases, the code that uses it can be reviewed [04:36:11] * Aaron|home would prefer it work the same [04:39:29] ok [04:40:14] like I say, it's a choice between weakening the utility of DBConnRef::__destruct() and weakening transaction semantics [04:40:18] anyway, it works fine for maintenance scripts as well as non-write queries [04:40:43] really I'd be checking writesOrCallbacksPending() not trxLevel() [04:41:10] ok [04:41:14] * Aaron|home thinks about the oauth case [04:43:29] so the main case I made this for was to avoid racking up dozens to hundreds of connections by mistake in some code doing some selects and/or writes [04:44:15] since maintenance scripts are in autocommit mode and writes should not hit dozens of dbs anyone for web requests, that problem should be dealt with [04:45:53] New patchset: Aaron Schulz; "Improved DBConnRef handling when write transactions are still open" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74323 [04:46:04] TimStarling: ^ that's kind of what I had in mind atm [04:51:17] New review: Mattflaschen; "Sorry for the two rebases. I realized it's better to test this one on top of search." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/74150 [04:51:20] TimStarling: the choice to me is that if you want to reuse the connection but write to several DBs either you (a) commit/autocommit them in series or (b) do begin for each in a separate connection, do the writes, and commit each connection [04:51:53] the later might be a bit more atomic but involves more connections whereas the former makes the opposite trade-off [04:52:17] maybe that should just be up to the caller? [04:56:31] I remember trying to see how USE handled transactions exactly though http://dev.mysql.com/doc/refman/5.0/en/use.html didn't mention it [04:59:04] * Aaron|home tests [05:01:08] maybe we should worry about it when an application needing b) appears [05:01:24] it hasn't already, has it? [05:01:27] New review: Aaron Schulz; "Still a bit WIP" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/74323 [05:03:42] It's not possible to push to Gerrit via HTTPS, is it? [05:04:01] Obviusly, the recommended way is SSH, but richa is having firewall issues with that. [05:04:52] no, it's not possible [05:05:06] Why is that? [05:06:21] TimStarling: actually using BEGIN ... USE ... writes ... USE ... writes ... COMMIT gives no problems testing it [05:06:37] so that may moot (b) all together [05:06:46] TimStarling, thanks. [05:07:51] superm401: it's definitely port 29418 that is blocked for richa, right? not port 22? [05:08:25] sometimes people miss the port number and get an access denied error [05:08:33] TimStarling, not sure, she's probably not at her computer right now due to time zones. [05:08:44] I will mention that in my email, not sure if she actually tried, or just heard that SSH is blocked. [05:10:37] TimStarling: I think I can just abandon that patch then [05:11:23] * Aaron|home though that didn't work for some reason [05:11:28] *thought [05:13:10] well that was a waste of time ;) [05:15:59] New patchset: MarkTraceur; "Dynamically change user count on frontend" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/74325 [05:18:45] New review: MarkTraceur; "This is broken - unchecking "enable all" and then checking a preference doesn't enable the preferenc..." [mediawiki/extensions/BetaFeatures] (master) C: -1; - https://gerrit.wikimedia.org/r/74325 [05:22:16] Project browsertests-test2.wikipedia.org-linux-firefox build #418: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/418/ [05:24:18] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [05:26:45] New review: Mattflaschen; "Minor fixes look good, still works." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/72841 [05:29:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [05:30:11] New review: Mattflaschen; "S is taking the lead on this now. Not sure if it's ready for review or not." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [05:34:05] New patchset: Spage; "support CentralAuthPostLoginRedirect (SUL2) hook" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [05:35:19] New patchset: Spage; "support CentralAuthPostLoginRedirect (SUL2) hook" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [06:01:30] New review: Netbrain; "(1 comment)" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/73738 [06:09:48] New review: Mattflaschen; "I have no problem with you writing $( function ) in your code. I just don't think the benefits you ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [06:22:54] Fuuunn... now we have a spambot that understands how to hit LQT. [06:23:19] And too top it off LQT doesn't seem to play nicely with deletion sometimes and ends up with errors like these https://www.mediawiki.org/wiki/Thread:Manual_talk:FAQ/Lassen_Sie_sicberraschen!_Als_Urlaubsdomizil_eine_Ferienwohnung_zu_suchen/reply_%282%29 [06:26:07] deutsch klingt manchmal so wunderbar. 'urlaubsdomizil'! spass auszusprechen. [06:28:07] New patchset: Mwjames; "\SMW\PropertyAnnotationComplementor (eliminate scope creep in ParserData)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74326 [06:35:03] New patchset: Legoktm; "Change message to say deleting "unused" accounts rather than "inactive"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74327 [06:46:10] New review: Mattflaschen; "Fair enough. It's not necessary to have a PHPUnit test for that part (is_callable)." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [06:52:22] New review: Mwjames; "[1] is already in the queue to eliminate more of the scope creep which means that this change need t..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [06:57:31] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74292 [06:58:28] New review: Shirayuki; "Thanks." [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74292 [07:03:55] New review: PleaseStand; "As you can tell from the failing tests, the library is still in use for JavaScript validation purposes:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74283 [07:37:05] New review: Mwjames; "Needs rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306 [07:39:55] New patchset: Mwjames; "Remove Special:QueryCreator" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69073 [08:07:59] New patchset: Rillke; "Removing space between buttons in Buttonset in Vector" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74328 [08:19:46] New patchset: Netbrain; "enabled parameter "transpose" and added phpunit test." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74329 [08:21:45] New patchset: Netbrain; "enabled parameter "transpose" and added phpunit test." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74329 [08:24:28] New patchset: Netbrain; "enabled parameter "transpose" and added phpunit test." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74329 [08:37:32] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [08:50:10] New patchset: Daniel Kinzler; "Allow debugging of unit tests via wfDebugLog." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74224 [09:02:19] New patchset: Hashar; "Add DataTypes" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74284 [09:03:08] New patchset: Hashar; "jobs for mwext-DataTypes + wikibase dependencies" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74284 [09:03:19] New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/74284 [09:03:19] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74284 [09:04:52] New patchset: Hashar; "triggers for mw/ext/DataTypes" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74282 [09:05:57] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74282 [09:06:04] New patchset: Rillke; "jquery.placeholder: Take placeholder text as parameter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74332 [09:08:24] New review: Mattflaschen; "I tested, and it almost works for me. With Chrome (the version of Chromium I have doesn't work quit..." [mediawiki/extensions/PronunciationRecording] (master) C: -1; - https://gerrit.wikimedia.org/r/73017 [09:36:41] New patchset: Daniel Kinzler; "Allow debugging of unit tests via wfDebugLog." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74224 [09:36:48] hashar: --^ [09:45:42] New patchset: Rillke; "jquery.placeholder: Take placeholder text as parameter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74333 [09:45:57] Hi all! [09:47:46] Anyone there?? [09:48:34] The Malagasy Wiktionary has a problem: http://mg.wiktionary.org/w/index.php?title=expresie&uselang=en. The deletion log is empty, and any change done manually is not taken in account... Also, any bot change results in Server Errors [11:56:33] New patchset: Matmarex; "Fixing width of icon-only-buttons in Vector skin" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74345 [11:57:37] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [11:58:56] New patchset: Hashar; "python script to sync with gerrit projects" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74343 [11:58:59] New review: Matmarex; "Works as advertised. Thanks." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/74345 [11:59:18] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74343 [11:59:56] New patchset: Njw; "Release 1.2.1 Set initial-scale in the viewport, for iOS browsers." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/74348 [12:00:35] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/74348 [12:01:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74345 [12:06:55] New review: Zaran; "(1 comment)" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/72933 [12:14:37] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [12:14:41] New patchset: Matmarex; "vector: Move right tabs from behind to below left tabs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [12:21:16] Hi, does http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page use the same SUL as Wikipedia et al? [12:21:21] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [12:21:37] I can't log in, and it doesn't allow me to create a new account either [12:24:21] New patchset: Hashar; "sync-with-gerrit: now continues on submodule error" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74351 [12:24:21] New patchset: Hashar; "sync-with-gerrit: strip out submodules from extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74352 [12:24:22] New patchset: Hashar; "insert more extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74353 [12:24:36] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74351 [12:25:09] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74352 [12:25:32] qgil: it is a different sul [12:25:54] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/74353 [12:26:01] qgil: and you should use a different password on there :-] [12:26:30] hashar, ok, I can't even create an account. It says I had 6 accounts created in the last hours from my ip (?) [12:29:00] hmm [12:29:03] qgil: need to find out :) [12:29:40] hashar, I just need a dummy account for https://www.mediawiki.org/wiki/Meetings/2013-07-18 [12:29:44] today [12:29:53] I am digging in http://en.wikipedia.beta.wmflabs.org/wiki/Special:Log [12:31:03] hashar, I haven't touched this site before 18 July 2013 [12:31:47] Account creation error [12:31:47] Visitors to Wikipedia using your IP address have created 6 accounts in the last 24 hours, [12:31:48] ahhh [12:31:49] I know [12:31:52] what is the reason [12:34:49] I hate our code [12:39:32] https://gerrit.wikimedia.org/r/74355 [12:39:33] :°D [12:40:33] qgil: should be fixed now. I have managed to create an account [12:42:19] qgil: you should be able to create an account now -) [12:42:31] hashar, just did! Thank you [12:42:42] next: making Vagrant work ;) [13:05:50] New patchset: Amire80; "A test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [13:05:51] New review: Hashar; "We split sources and deb packages. So the debian files should really be in operations/debs/gerrit th..." [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [13:07:48] hashar: I don't think we are on the same wavelength [13:08:16] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74176 [13:08:42] AzaToth: follow up with ^demon :-] [13:09:10] hashar: If we where to pull the source from gerrit.git into operations/debs/gerrit.git we would need to reinvent hte whole wheel [13:09:24] hashar: well, you commented [13:09:27] you can just do it locally [13:09:37] without pushing the gerrit source back in operations/debs/gerrit [13:09:54] hashar: can't have the build procedure depend on git [13:09:58] New review: Matmarex; "Oh man, this is an awful, awful workaround. My eyes are bleeding. This fixes the immediate issue, th..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/74328 [13:10:29] hashar: no one separates packages like that [13:10:52] except those when using svn had mergeWithUpStream functionality [13:11:07] we do [13:11:42] hashar: if you want to reinvent the wheel, then go ahead, but [13:12:10] hashar: remember the package must be able to build from source without access to git [13:12:10] anyway, follow up with ^demon and find out with him what should be done [13:12:16] I don't really care, just point that it introduces duplication [13:12:28] hashar: operations/debs/gerrit should be deleted [13:12:28] but maybe ^demon wants to phaseout / delete operations/debs/gerrit [13:12:33] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74328 [13:13:25] hashar: anyway, I would need a real review of the package, i.e. if it's functional as assumed [13:13:33] i.e. the gerrit part [13:14:10] I don't want to merge it straight off without some input [13:16:36] New review: Hashar; "I guess that would be caused by someone calling wfSuppressWarnings() and forgetting to call wfRestor..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74170 [13:17:55] AzaToth: well get ^demon to get rid of the operations/debs/gerrit for first. For Debian packages you could get in touch with the upstream community and contact the ops folks. Both akosiaris paravoid are Debian enabled :) [13:25:51] New patchset: Alex Monk; "Make mwCustomEditButtons a no-op and mark it as deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [13:26:04] New patchset: Rjain; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361 [13:31:05] New patchset: Alex Monk; "Make mwCustomEditButtons a no-op and mark it as deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [13:36:29] New patchset: Rjain; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361 [13:39:55] New patchset: Aklapper; "Configure Bugzilla's Guided Bug Entry Form" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/74360 [13:57:09] <^demon> Friendly reminder: Gerrit is coming down in a few minutes for some hardware work. Please don't panic. [14:07:22] qgil : Hi there is a meeting ? [14:07:44] hi karima , in 2h [14:07:51] oki... [14:07:58] karima, https://www.mediawiki.org/wiki/Meetings/2013-07-18 [14:08:06] karima, there is a convenient link with timezones :) [14:08:41] It's a good news...I have the time to update my repo lol [14:25:16] ^demon: I did a reset password on en.wikipedia, put in my email, but never got instructions. Can you send manual instructions to me on how I can reset that password? [14:26:00] <^demon> No, we can't do manual password resets for people. [14:27:05] rachel99, reset again? [14:27:10] ^demon: Does it even work when you put your email address into reset password field? [14:27:21] qgil: yes [14:27:26] <^demon> It should, yes. [14:27:37] rachel99, also check the spam folder [14:28:49] ^demon: Well, it didn't email me, and I did check spam folder. Have also tried this on another day and got no email. [14:29:36] Are you sure you are resetting the right username? and checking the right email address? [14:30:37] p858snake|l_: yes, I believe. Unless someone else has Rachel99 login on en.wikipedia. [14:32:56] <^demon> Ok, gerrit's back up. Things might be a little slow for a bit while the disks finish sync'ing, but nothing to worry about. [14:35:06] ^demon- Can you investigate this matter for me, or else tell me who to contact? [14:35:16] ^demon: I can haz streamEvents permission for user Yuvipanda also? [14:35:43] no random characters in email this time :) [14:36:34] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/71176 [14:36:55] !technews [14:40:35] <^demon> YuviPanda: I'm getting ready to head in to the office. Ping me again in a bit. [14:40:44] ^demon: ok! [14:40:51] <^demon> rachel99: Not really. I'm in the middle of some things. [14:41:05] !ping [14:41:19] damned wm-bot is down again [14:41:22] petan: damned wm-bot is down again [14:41:23] ^demon: alright then. I will ask Coren in labs [14:41:30] :( [14:41:39] really? [14:41:42] wm-bot: ping [14:41:42] Hi petan, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [14:41:49] D: [14:41:54] it seems to work to me [14:41:55] it should respond to !ping too, no? [14:41:57] !ping [14:41:57] !ping [14:42:00] !ping is pong [14:42:00] Unable to modify db, access denied, link to database isn't valid [14:42:03] oh [14:42:04] lololol [14:42:06] interesting [14:42:10] only responds on #mediawiki [14:42:19] i've already filed a bug about accesslist here being borked [14:42:21] @trusted [14:42:21] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), [14:42:49] !ping [14:42:49] Pong. [14:42:52] fixed [14:42:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=51246 [14:43:01] "wm-bot on #wikimedia-dev slightly borked" [14:43:08] probably same for #-operations [14:43:14] it didn't respond there either [14:43:19] @trusted [14:43:19] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), [14:43:40] ^ dafuq is this, really. two krinkles, no wildcards? :D [14:44:09] The mediawiki one can go [14:44:28] I trust: petan\|w!.*@wikimedia/Petrb (admin), .*@wikimedia/.* (trusted), .*@wikipedia/.* (trusted), .*@mediawiki/..* (trusted), .*@wikipedia/MZMcBride (admin), .*@wikimedia/Krinkle (admin), .*@fsf/.* (trusted), .*@unaffiliated/valhallasw (trusted), .*@wikinews/bawolff (admin), [14:44:32] this is on#mediawiki [14:45:02] !g 1 [14:45:02] https://gerrit.wikimedia.org/r/#q,1,n,z [14:45:05] yay [14:45:47] petan: It doesn't seem to work on #mediawiki-visualeditor either. It's supposed to be linked to the same infobot as dev and mediawiki. [14:46:33] petan, I tried earlier restarting the two bouncers and then shooting the exe process as documented on wikitech [14:46:54] after some delay it rejoined the channel I was sitting in watching, that was as far as I got with it [14:47:01] cool [14:47:22] Krinkle are you admin or not lol, type @whoami [14:47:44] isn't Reedy global admin o.o you guys can easily fix this [14:47:53] @trustadd .*@wikimedia/.* trusted [14:47:54] Successfuly added .*@wikimedia/.* [14:48:02] we should just have less channels [14:48:04] @trustadd .*@wikipedia/.* trusted [14:48:04] Successfuly added .*@wikipedia/.* [14:48:07] less channels = less problems [14:48:14] @trustadd .*@mediawiki/..* trusted [14:48:14] Successfuly added .*@mediawiki/..* [14:48:22] @trustadd .*@wikipedia/MZMcBride admin [14:48:22] Successfuly added .*@wikipedia/MZMcBride [14:48:30] @trustadd .*@wikimedia/Krinkle admin [14:48:30] Unable to add user because this user is already in a list [14:48:45] @trustadd .*@wikinews/bawolff admin [14:48:45] Successfuly added .*@wikinews/bawolff [14:48:48] here we go [14:49:29] @trustadd .*@wikipedia/matma-rex admin [14:49:29] Successfuly added .*@wikipedia/matma-rex [14:49:54] You are admin identified by name .*@wikimedia/Krinkle [14:51:09] petan: What's up with the link in visualeditor channel though? Did it get reset somehow? [14:51:11] woot [14:51:15] thanks petan [14:51:23] , !ping, !g, !b, doesnt' respond to any of them [14:51:37] now, where do i find a list of things i can do now? :P [14:51:38] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [14:51:38] MatmaRex: Invalid arguments [14:51:47] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.0.0 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [14:52:43] You are admin identified by name .*@wikipedia/matma-rex [14:53:06] link me to visual channel [14:53:14] #mediawiki-visualeditor [14:53:43] petan: am i supposed to be an admin here and not be one on #mediawiki? (also, is this a bug?) [14:54:21] no that's by design :P [14:54:44] when you decide to share a db of local channel with other channels, you can set up access list (to define which channels can access the db or not) [14:54:54] every channel with access can has own access list for people [14:55:25] like you could have user a, b in master channel, but there could be user c in access list of slave channel [14:56:22] magic [15:04:37] New patchset: Reedy; "Update Wikidata extensions to mw1.22-wmf11 branches" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/74366 [15:04:57] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/74366 [15:06:03] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74314 [15:09:11] YuviPanda, maybe I've missed something, but users now have to edit campaigns as JSON instead of through a UI? [15:09:37] New review: Anomie; "Code looks good. I'll try to test it later today." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/23177 [15:14:40] New patchset: Anomie; "Central login check should fail if local is unattached" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74369 [15:15:06] New patchset: Anomie; "Central login check should fail if local is unattached" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74369 [15:19:10] New patchset: Krinkle; "Remove inappropiate executable flag on Echo.php and echo.sql" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/74370 [15:20:19] error: could not apply 249d131... Commit of various wmf-branch live hacks [15:20:19] hint: after resolving the conflicts, mark the corrected paths [15:20:20] grrrr [15:20:51] Squid update needs updating [15:21:19] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74314 [15:21:35] <^d> Reedy: I hate those hacks :( [15:21:41] see, Reedy, that's why code hacks are bad [15:21:49] you get problems when updating. [15:21:50] :D [15:24:39] MatmaRex: Nice to see you are offering to fix them... [15:25:08] New patchset: Cmcmahon; "Don't run create-account test on prod, IP gets blocked" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74371 [15:26:45] New patchset: Anomie; "Central login check should fail if local is unattached" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74369 [15:26:54] Robla and I did talk about ways of reducing these further.. [15:27:45] * Reedy wonders who updated it [15:28:14] * Reedy blames hashar [15:28:31] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/9cf0a3d81ffd77202450731f6b1d38e2fe129022 [15:28:32] heh [15:30:24] Yippie, build fixed! [15:30:24] Project browsertests-test2.wikipedia.org-linux-firefox build #419: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/419/ [15:31:48] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74369 [15:34:25] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74314 [15:36:04] New patchset: Reedy; "Commit of various wmf-branch live hacks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [15:36:21] New patchset: CSteipp; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74372 [15:39:27] New patchset: CSteipp; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74373 [15:40:04] New patchset: Reedy; "Update patch revision to 9" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/74375 [15:40:05] New patchset: Krinkle; "Remove override of skin behaviour for inline anchor's text-docaration" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/74374 [15:40:30] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/74375 [15:41:29] Reedy: Are you just getting the branch ready, or are you actually deploy stuff right now? [15:41:39] I just had to rebase our live hacks [15:41:52] So I'm re-running the script to build the branch [15:42:04] I try and get the code out before the window to save time waiting around for sync-dir etc [15:42:09] New patchset: Matmarex; "Remove override of skin behaviour for inline anchor's text-decoration" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/74374 [15:42:39] Yeah, understandable. So can I do an update to centralauth in wmf9 & 10 right now? Or will that mess you up? [15:43:03] Go ahead, won't affect me [15:44:37] New review: CSteipp; "Fix bug in SUL deploy (bug 51603)." [mediawiki/core] (wmf/1.22wmf10) C: 2; - https://gerrit.wikimedia.org/r/74372 [15:45:10] New review: CSteipp; "Fix bug in SUL deploy (bug 51603)" [mediawiki/core] (wmf/1.22wmf9) C: 2; - https://gerrit.wikimedia.org/r/74373 [15:47:12] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74372 [15:48:35] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74373 [15:51:15] csteipp: wmf11 is now branched. CA is using 082047f3082a902581055c03bb4452551d064e88 does it need updating to master again, or is that fine? [15:51:50] Reedy: Needs master [15:51:58] (sorry) [15:52:10] Hi, anybody here ready to join the Browser Testing Automation workshop? https://www.mediawiki.org/wiki/Meetings/2013-07-18 [15:52:25] It's finehttps://git.wikimedia.org/commit/mediawiki%2Fextensions%2FCentralAuth.git/082047f3082a902581055c03bb4452551d064e88 [15:52:35] It's already using the master commit that Brad made [15:52:46] Cool :) [15:53:15] Yay for having to rebase the hack patch ;) [15:53:34] New patchset: Cmcmahon; "Removed page-object gem deprecation warnings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74091 [16:12:58] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/74370 [16:13:51] New review: Cmcmahon; "Tested, this is great. Thanks very much Tomislav!" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/74091 [16:13:51] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74091 [16:21:38] qgil: Where is https://www.mediawiki.org/wiki/Talk:Quality_Assurance/Browser_testing#July_2013_workshop_30153 being held? [16:23:22] in CYBERSPACE [16:23:32] *laser soundeffects* [16:24:16] Krenair: yes [16:24:18] marktraceur: https://www.mediawiki.org/wiki/Meetings/2013-07-18 [16:24:18] Krenair: I'll write up a GUI at some point [16:24:41] Krenair: but the people who do the WLM stuff seem happy with it, mostly because they get a bunch of other things they really like [16:26:14] Arghhhh google hangout [16:26:16] * marktraceur is slain [16:30:25] New review: Ori.livneh; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [16:31:04] New patchset: Ori.livneh; "Add support for VisualEditor" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [16:31:28] qgil, if there's time, could zjelko go into some depth on the "support" primitives in the directory "features/support/pages" of the qa git project's directory structure? [16:31:42] qgil, if there isn't time, no problem. i'm on the youtube stream. [16:33:59] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74338 [16:34:43] dr0ptp4kt, you can tell this to zeljko directly :) [16:35:14] dr0ptp4kt, ah, you say in the strem, sorry [16:35:56] bawolff: I don't think I've told you yet: I love you so much for including GPL file headers [16:35:57] New review: Ori.livneh; "I don't know what is up with Jenkins." [mediawiki/extensions/GuidedTour] (master); V: 2 - https://gerrit.wikimedia.org/r/72677 [16:36:00] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [16:36:13] marktraceur: I included GPL headers? [16:36:22] I believe so [16:36:26] lol [16:36:29] Your files seemed to have them [16:36:30] bawolff: quick [16:36:32] REVERT [16:36:32] REVERT [16:36:34] REVERT [16:36:37] * YuviPanda reverts bawolff [16:36:46] If you say I did, I'll believe you [16:36:47] :P [16:36:49] e.g. https://gerrit.wikimedia.org/r/#/c/67885/15/includes/gallery/TraditionalImageGallery.php [16:36:56] hi dr0ptp4kt we'll cover the support/pages details in a little while [16:37:07] chrismcmahon, sweet [16:37:14] bawolff: Maybe you just copied them from elsewhere, but this is better than a lot of projects. [16:37:21] Oh well, that was more copying and pasting from the original file [16:37:36] *nod* [16:37:38] I'm cool with that [16:38:03] Normally I hold the view that GPL headers aren't really needed, since the file is still clearly GPL regardless of if there is a header there [16:38:03] In other news, how's the revision coming? :) [16:38:10] but they certainly don't hurt [16:38:42] Still have some stuff to do on it [16:38:53] but I'll hopefully have a fixed up version soon [16:39:01] bawolff: The use case is that someone uses the file in another project - they won't copy over your COPYING file unless they're really paying attention, so having the copyright header is a good help for people who need to know the license of the files in the project [16:39:02] holy cow it was a parent5448... [16:39:14] marktraceur: Then we sue them :P [16:39:15] parent\d{4}!? [16:39:16] chrismcmahon, qgil: not suggesting anything additional; just excited to gain some insight on the thought process. i get it somewhat, but it helps to learn from masters of the craft. [16:39:27] Reedy: poke me before / while running https://bugzilla.wikimedia.org/show_bug.cgi?id=51197 [16:39:28] ? [16:39:54] hokay [16:40:10] marktraceur: Did you notice that for our irc meeting with the commons community, we actually now have 1 non-dev going :D [16:40:14] halright [16:40:20] harro [16:40:24] Gasp! Awesome! [16:40:33] Reedy: :D [16:40:37] :H [16:40:42] H: [16:41:03] What on earth kind of face is that [16:41:03] \h/ [16:41:03] hopefully we can double that number to 2 before the actual meeting! [16:41:09] \h/ is a chair in a ditch? [16:41:35] I think we just started the genre "abstract modern emoticon art" [16:41:57] bawolff: We could just spam -commons with the link [16:41:59] \o/ is someone buried neck deep in a ditch [16:42:13] \_o_/ [16:42:18] yeah [16:43:17] Oh holy crap, I should get to work before our daily meeting [16:43:47] [x] Do stuff [16:43:58] [x] Sit in a particular location [16:43:58] [ ] Do other stuff [16:44:13] Collaborative TODO list creation, I love it [16:44:21] s/particular location/hammock/ [16:44:48] we've only one hammock, don't we? [16:44:49] ... so far [16:44:49] * marktraceur reserves hammock for his 1:1 with robla later [16:44:57] BYOH [16:45:10] * marktraceur --> office [16:46:32] When I saw the office, I think the fact that there was a hammock in it, was my favourite part [16:46:47] bawolff: the Mobile Team can take credit for tha [16:46:48] t [16:46:52] specifically jdlrobson [16:48:10] greg-g: Yo. [16:48:17] greg-g: What's going on with the MediaWiki RFP? [16:48:48] from what I hear, greg-g has the flu today [16:49:41] Well that's lame. [16:57:44] New review: Brian Wolff; "Still think there's a couple places where $wgUser should not be used, but that can be fixed later. 9..." [mediawiki/extensions/BetaFeatures] (master) C: 2; - https://gerrit.wikimedia.org/r/73903 [16:57:48] 110 Warning: gzinflate() [function.gzinflate]: data error in /usr/local/apache/common-local/php-1.22wmf10/includes/Revision.php on line 1212 [16:58:21] Change merged: Brian Wolff; [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [17:02:29] Krenair: yes [17:02:48] did you check with commons campaign editors? :/ [17:04:34] Krenair: yes? [17:04:42] Krenair: they've also been testing this for me on betalabs [17:04:49] Oh, well, I guess it should be okay then... [17:04:52] Krenair: odder, Romaine, Jean, multichill [17:05:03] Krenair: and see responses on the wlm mailing list, rather positive :) [17:06:08] Krenair: I've not managed to find the editors for the 3 non-wlm campaigns that exist on commons, but I guess that can be fine. [17:06:14] YuviPanda: I could run maintenance/migrateCampaigns.php on test2wiki now.. [17:06:30] hmm, I wonder who fabrice considers "Friends of Multimedia" [17:06:33] Reedy: can you give me 5 minutes? [17:06:37] sure [17:08:21] Reedy: err, can you give me sysop on test2? [17:08:23] New patchset: Aude; "add script for adding wikidata and testwikidata to sites table" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [17:08:29] bawolff, EE list it seems [17:08:33] Reedy: actually, nevermind. just run it, it's okay. [17:08:53] That's an interesting choice, I would assume the video list, and maybe the commons list [17:09:14] could be those as well for all I know [17:09:19] I just got the EE mail [17:09:39] reedy@tin:/a/common/php-1.22wmf11$ mwscript extensions/UploadWizard/maintenance/migrateCampaigns.php --wiki=test2wiki [17:09:39] reedy@tin:/a/common/php-1.22wmf11$ [17:09:40] Helpful [17:09:56] Reedy: yeah, :) Nothing to migrate [17:10:13] Reedy: don't migrate testwiki yet, I'm creating something to migrate there [17:10:15] Surely you'd output something at least? :p [17:10:28] testwiki wont be going to wmf11 for 50 minutes or so [17:10:28] they can be created only on wmf10 [17:10:32] yeah, that's good [17:10:47] New review: Brian Wolff; "looks good" [mediawiki/extensions/BetaFeatures] (master) C: 2; - https://gerrit.wikimedia.org/r/73916 [17:10:58] New review: Brian Wolff; "looks good" [mediawiki/extensions/BetaFeatures] (master); V: 2 - https://gerrit.wikimedia.org/r/73916 [17:10:59] Change merged: Brian Wolff; [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73916 [17:11:15] Reedy: testwiki already has campaigns, so migration will be actually tested :) I'm taking copies of the current config so I can compare easily [17:14:50] New review: Reedy; "(1 comment)" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [17:15:19] New patchset: Zfilipin; "Scenario: Wikilove window appears" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74386 [17:16:30] Krenair: I should also move JsonContent + Handler into core. There are now ~4 extensions that have their own duplicated copies... [17:17:48] Jeroen would be proud [17:17:48] ;) [17:18:29] bawolff: Woo merge, also standup [17:18:50] marktraceur: my interent was hating on me for a bit there [17:19:19] Reedy: I did rip out almost all of his code from UW... :) [17:21:16] New patchset: Aude; "add script for adding wikidata and testwikidata to sites table" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [17:21:50] New review: Aude; "(1 comment)" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [17:24:59] New patchset: Aaron Schulz; "Various code cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74300 [17:25:27] New review: Brion VIBBER; "Testing on Nexus 1 / Gingerbread..." [apps/android/commons] (master) C: -1; - https://gerrit.wikimedia.org/r/73981 [17:26:17] YuviPanda: i'm still having trouble with the scrolling on the share activity, both the title/desc page and the categories page [17:26:32] the screen doesn't scroll, so i have to hide the keyboard to get from field to field [17:26:43] brion: hmm, that's weird. wfm, let me check [17:27:18] brion: there's another unrelated patchset that's much simpler. merge? :) [17:27:55] New patchset: SuchABot; "Added new launcher icons" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73748 [17:28:57] New patchset: Reedy; "Output something even if 0 campaigns migrated." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74387 [17:31:18] Reedy: are you using an IDE that adds those automatically? :) [17:31:31] New patchset: Bsitu; "(bug 48568) Bust IE browser ajax cache + some API clenaup" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73531 [17:32:26] Reedy: let me test that real quick and hten merge [17:32:46] bawolff: Is there anything you want on multimedia-alpha so we can show it off during the office hour? [17:33:09] YuviPanda: semi automatically, yeah [17:33:32] Umm, I suppose we could put the gallery stuff there [17:33:45] New review: Swalling; "Tested and working as expected on Labs." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/72682 [17:34:47] bawolff: You said it depends on a specific commit in core? [17:35:23] The gallery stuff doesn't [17:35:33] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73531 [17:35:40] that was the file feedback prototype [17:35:41] New patchset: MarkTraceur; "Work with the newer versions of BetaFeatures" [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [17:35:45] Ah, K [17:37:07] bawolff: Is it just that one commit in gerrit? [17:37:37] yeah [17:37:41] or [17:37:48] for the gallery is just one commit [17:37:55] New review: Brion VIBBER; "Let's try em out! wheeeee" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73748 [17:37:56] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73748 [17:38:07] the image review thingy depends on a branch from like 6 months ago [17:38:47] I don't think we should put it on multimedia alpha for now, as its a bit complicated with the dependency on the old branch, and rebasing that will not be fun [17:39:54] New patchset: Ori.livneh; "If nothin to migrate, print a message to inform user." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [17:40:03] Reedy, YuviPanda ^ [17:40:14] bawolff: How would you like it configured? I think you could probably do it yourself, the permissions *should be* right [17:40:37] ori-l: too late, reedy already put up another patch. [17:40:49] dat reedy [17:40:50] oris is probably cleaner [17:40:55] yeah [17:41:01] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73531 [17:41:05] New patchset: TheDJ; "All toggles for makeCollapsible should use the pointer cursor." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74391 [17:41:17] For now I'd be fine with just using the crappy thing I had set up on the toolserver, since it already has examples set up [17:41:29] * bawolff is also lazy [17:41:29] Reedy: can I merge ori-l's? Cleaner since it doesn't add docs + output counting in the same one. [17:41:34] lol [17:41:35] Reedy: I'll rework yours to add counting [17:41:41] bawolff: Does it take much effort to set the config variables? [17:41:43] Merg oris [17:41:43] and... merge that as a separate patch :P [17:41:46] um, isn't Reedy's better? [17:41:46] Then rease mine and update [17:41:52] Reedy: yeah, let me do that [17:41:55] not really [17:42:04] ori-l: atomic commits! [17:42:06] New patchset: Alex Monk; "Make mwCustomEditButtons a no-op and mark it as deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71176 [17:42:24] YuviPanda: mine wasn't atomic either; couldn't resist fixing whitespace and replacing the echo with $this-output [17:42:48] $wgGalleryOptions['mode'] = 'packed'; // bawolff, this seem OK? [17:42:57] but whatevs :) [17:43:04] marktraceur: yep [17:43:28] I think on my demo site I had the widths increased a little bit too [17:44:04] Hm [17:44:39] I had https://dpaste.de/7KqGe/ [17:45:07] New patchset: Aude; "add script for adding wikidata and testwikidata to sites table" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [17:45:09] New review: Demon; "recheck" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [17:46:36] bawolff: http://multimedia-alpha.wmflabs.org/w/index.php/Main_Page because I'm lazy [17:46:50] I'll keep adding images [17:47:11] marktraceur: Could you enable error reporting? [17:47:14] http://multimedia-alpha.wmflabs.org/w/index.php/Special:NewFiles isn't working [17:47:25] New review: Yuvipanda; "Too lazy to rework ori-l's patch, and we just had a -1800 commit, so meh atomicity." [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/74387 [17:47:29] Argh [17:47:29] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74387 [17:47:58] ori-l: Reedy sorry, laziness won over :) [17:48:02] [Thu Jul 18 17:47:22 2013] [error] [client 216.38.130.164] PHP Catchable fatal error: Argument 1 passed to ContextSource::setContext() must implement interface IContextSource, null given, called in /var/www/w/includes/specials/SpecialNewimages.php on line 121 and defined in /var/www/w/includes/context/ContextSource.php on line 56 [17:48:07] bawolff: ^^ [17:48:09] ugh not quite fast enough [17:48:18] * marktraceur looks up error reporting [17:48:30] marktraceur: ugh, that might even be my fault ;) [17:48:50] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74387 [17:48:54] New review: Reedy; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74387 [17:49:03] YuviPanda: you killed gerrit [17:49:11] {{done}} [17:49:12] oh, working again. [17:49:14] bawolff: It appears to be [17:49:15] good riddance! [17:49:23] <^demon> Who killed gerrit? [17:49:25] <^demon> What did you do? [17:49:31] * ^demon grabs his flamethrower [17:49:31] New review: Brion VIBBER; "Seems plausible. Merge it!" [apps/android/commons] (master) C: 2; - https://gerrit.wikimedia.org/r/74306 [17:49:40] ^demon: merged a patch [17:49:40] New review: Brion VIBBER; "Seems plausible. Merge it!" [apps/android/commons] (master); V: 2 - https://gerrit.wikimedia.org/r/74306 [17:49:41] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/74306 [17:49:53] <^demon> YuviPanda: Don't do that, you know gerrit can't handle that! ;-0 [17:49:57] <^demon> *;-) [17:50:08] ^demon: i know, all my other patches have been via GitHub. blame Reedy :) [17:50:23] <^demon> Oh yeah, you wanted stream-events. [17:50:29] ^demon: oh yeah, that too! [17:50:31] moment, brb [17:50:38] <^demon> Now I gotta make a new group, lame. [17:52:20] <^demon> YuviPanda: Doned, enjoy your new feature :D [17:53:23] New patchset: Rillke; "RelatedArticles: Heading level in sidebar: h5 to h3" [mediawiki/extensions/RelatedArticles] (master) - https://gerrit.wikimedia.org/r/74396 [17:55:04] New patchset: Reedy; "If nothin to migrate, print a message to inform user." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [17:55:25] New patchset: Catrope; "Always send headers with a 304 response in ResourceLoader" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74400 [17:56:04] New patchset: Reedy; "If nothin to migrate, print a message to inform user." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [17:57:26] New review: Demon; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/74390 [17:57:59] New patchset: TheDJ; "TableSorter: Add option to mark rows as unsortable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74270 [17:57:59] New patchset: TheDJ; "Tablesorter: Add testcase for unsortable column" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74401 [17:58:08] New patchset: Reedy; "If nothing to migrate, print a message to inform user." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [17:58:13] New patchset: Cscott; "Sync up with Parsoid parserTests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74402 [17:58:25] ^demon: It would've been less typing to just fix the typo ;) [17:58:33] <^demon> o rly? [17:59:55] New review: Swalling; "Tested via http://w2-oauth.wiktionary.wmflabs.org/w/index.php?title=Test_GettingStarted and working,..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [18:00:02] irc office hours with multimedia team happening now in #wikimedia-office [18:00:32] New patchset: MarkTraceur; "Dynamically change user count on frontend" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/74325 [18:02:01] ^demon: sorry, was disconnected. did i get stream events? [18:02:19] <^demon> Maybe you did, and maybe you didn't. [18:02:22] <^demon> Bwahahahaha ;-) [18:02:38] easy enough to check :P [18:03:34] ^demon: thanks :) [18:03:37] <^demon> yw [18:03:39] New patchset: Anomie; "Hooks to tie OAuth in with User rights and the API" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73977 [18:04:09] New review: Anomie; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73977 [18:05:01] YuviPanda: testwiki time [18:05:06] woo :) [18:05:18] New patchset: Rillke; "Insider: Heading level in sidebar: h5 to h3" [mediawiki/extensions/Insider] (master) - https://gerrit.wikimedia.org/r/74406 [18:06:16] 8 done [18:06:29] yeah, sounds about right [18:06:34] let me go to the new pages and check [18:06:42] New review: Subramanya Sastry; "Once some of my pending reviews are merged in parsoid, there will be a lot more changes to parser te..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74402 [18:07:14] New patchset: Alex Monk; "Return Notification object from mw.notification.notify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74407 [18:08:59] New review: Mdale; "I did a checkout and am able to here the recorded sound. So we can merge this POC." [mediawiki/extensions/PronunciationRecording] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73017 [18:08:59] Change merged: Mdale; [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [18:13:13] New review: Cscott; "How close are your other patches to being merged? I had to resolve some conflicts manually in this ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74402 [18:15:33] New review: Subramanya Sastry; "Ah, if we have to sync back into parsoid, then let us do it once we do the merge from parsoid -> php..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74402 [18:17:35] New patchset: Reedy; "If nothing to migrate, print a message to inform user." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [18:18:07] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74390 [18:22:29] bawolff: marktraceur I guess 'not enough people' is not going to be a problem for this office hours :) [18:22:36] lol [18:22:41] bawolff: marktraceur I guess RSVP isn't really a wiki concept [18:22:45] Heh. [18:22:50] No it really isn't [18:23:02] * quiddity_ resists the urge to meow. [18:23:20] yeah, let's not do that next time :P [18:23:28] just the three of us signing looked odd :P [18:23:50] YuviPanda: Hey man, odd is how we roll [18:24:04] :D [18:24:35] I hope Fabrice is getting all he needs, it seems like a lot of text [18:25:07] New patchset: Cmcmahon; "Don't run create-account test on prod, IP gets blocked" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74371 [18:25:17] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/70860 [18:25:31] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74371 [18:25:37] New patchset: Rillke; "Removing redundant styles for icon-only buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74412 [18:25:48] I think he would have preferred it more structured, but at the end of the day, irc meetings aren't exactly good for structured discussion. They're better for Q/A type things [18:26:22] marktraceur: you can keep poking him if he hasn't, so there's that :) [18:26:25] New patchset: Mollywhite; "Bug 50674: Allow display of example navbars." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [18:26:28] bawolff: of course. But I have no idea what else would've worked [18:26:46] New patchset: Rillke; "Removing redundant styles for icon-only buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74412 [18:27:34] New patchset: Mdale; "Revert "Pronunciation Recording Tool"" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/74413 [18:27:43] New patchset: Rillke; "Removing redundant styles for icon-only buttons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74412 [18:29:46] siebrand: Hey, I wanted to ask whether it's on the horizon to add a commafy function to the JavaScript l10n libraries - had to hack something together yesterday and would really love to have a better option in the future [18:32:04] liangent: ping? [18:35:04] New patchset: Spage; "Remove styling from returnto link" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74414 [18:49:23] New review: Swalling; "This is on http://w2-oauth.wiktionary.wmflabs.org/ along with the SUL2 integration, and this works f..." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/74414 [18:50:35] New review: Mwalker; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) C: 2; - https://gerrit.wikimedia.org/r/74289 [18:50:35] Change merged: jenkins-bot; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [18:52:13] https://gerrit.wikimedia.org/r/#/c/36330/ [18:52:41] I was wondering if it might be possible to create an API module which would expose all public config, and whether it could be used for something like this [18:52:48] Tim-away, ^ [18:53:33] People have got upset when we've attempted to expose some globals before now [18:53:53] :/ [18:54:10] I'm not sure what you mean by "all public config." [18:54:26] db hosts? passwords? [18:54:29] Plenty of wiki configuration variables are roundaboutly exposed through the MediaWiki Web API already. [18:54:36] stuff would need to be filtered [18:54:39] var_dump( $GLOBALS ); [18:54:44] Yes that's why I said public aude [18:54:53] which ones are public? [18:55:03] All except certain ones [18:55:03] I don't think we want that in the bigger picture. [18:55:24] For this particular change just wgGroupPermissions/wgRevokePermissions would be okay [18:55:31] oh and wgImplicitGroups [18:55:38] If we add an API to expose wiki configuration variables, we'd have to then support it when we get rid of all of them (God willing). [18:55:40] New review: Catrope; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [18:55:42] Krenair: Special:Listgrouprights ? [18:55:49] bawolff, yeah what about it? [18:55:51] You can certainly have an API module to expose the information from them. [18:55:54] anomie: You broke VisualEditor :( ---^^ [18:55:56] This feels very de javu [18:55:58] Which we probably already do. [18:56:04] bawolff: I hope you're not proposing I parse HTML for this [18:56:04] It has $wgGroupPermissions listed [18:56:06] siteinfo has some [18:56:07] déjà vu [18:56:27] Avoiding WebKit rendering bugs by setting CSS properties on the body apparently causes other WebKit rendering bugs that affect us [18:56:30] There was that config DB thing... I think ^demon was going to work on it last year? Would that have helped here? [18:56:37] New patchset: TheDJ; "TableSorter: Add option to mark rows as unsortable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74270 [18:56:54] RoanKattouw: Thank the UX people, they insisted on that code. [18:56:57] Krenair: Probably. But with or without that, you still want an abstraction layer to keep re-use sane. [18:57:10] The implementation details of how settings are set should be irrelevant. [18:57:12] anomie: Could it at least be applied to only the element that needs it, rather than the entire body? [18:57:22] Just expose the necessary info you need via the Web API as necessary. [18:57:26] But with a sane interface. [18:57:34] RoanKattouw: I have no idea [18:57:34] If you need groups info, add groups info. [18:57:41] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [18:57:57] anomie: woot, css animations? D: [18:58:01] We work around the problem right now by setting opacity:0; on the thing that would otherwise be black (interestingly, even opacity: 0.999; works for making it not black), but it's still not highlighting correctly. Removing that rule (or making it more specific so it doesn't apply to VE) fixes it [18:58:52] anomie: whyis thisdone with animations instead of transitions? and what does htis do,actually? [18:59:18] I'm wondering about performance stuff now... Would it be possible to make an HTTP request to another wiki like this? [18:59:43] MatmaRex: No idea. It makes the p-personal bar "slide" in when being replaced, if you are logged in on login.wikimedia.org and then visit another SUL wiki while not being logged in there. [18:59:50] OK, well [18:59:55] I'll take a stab at it after lunch [19:00:00] It would slow down page load time but it's user rights stuff, so.. [19:00:12] An internal HTTP request is fine. [19:00:22] anomie: hm. [19:00:40] anomie: i'm pretty sure you actually want transitions there, not animaitons. [19:00:45] * MatmaRex looks what thisdoes in practice [19:00:47] MatmaRex, RoanKattouw_away: I don't even know what bug in WebKit it's supposed to be fixing. [19:02:29] MatmaRex: Jared recommended the library. It's for when user's browsers don't accept third party cookies, but are centrally logged in, so we update their personal toolbar when the javascript logs them in on pageview. [19:03:14] mwalker: Damn, quick code review there! Confused me :P [19:03:27] hm, is this deployed everywhere now? how do i trigger it? [19:03:31] do i have to log out and back in? [19:03:33] GorillaWarfare: you caught me at a good time [19:03:36] New patchset: Adamw; "Generalized mailing job queue" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [19:03:37] (to reproduce, login, then delete your centralauth_Session and centralauth_User cookies for one wiki, then view a page on that wiki to see the login happen and the animated update [19:03:49] :) [19:04:46] and on that note; hows the coding going wrt your schedule? [19:04:48] Krenair: I think the slow down would be negligible, FWIW. [19:04:57] MatmaRex: I'm running to lunch, but ping me if that ^doesn't work for you [19:05:32] it did work [19:05:35] New patchset: Adamw; "Generalized mailing job queue" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [19:05:38] mwalker: It's going well. Raylton and I worked out a priority list for the bugs (https://meta.wikimedia.org/wiki/Book_management/Bug_priority) which is helping organize things [19:05:45] mwalker: I'm hoping to get 1–5 done this week [19:06:14] GorillaWarfare: awesome! *high five* [19:06:16] New review: Ori.livneh; "Nice change." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/73922 [19:06:17] ^.^ [19:06:18] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [19:06:30] Which reminds me, I should update that list.. [19:09:25] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74414 [19:19:23] anomie: "// Sigh." [19:19:24] heh. [19:20:18] New patchset: Aaron Schulz; "Added conflict detection to some special pages" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74423 [19:21:32] bawolff: saw more comments in RandomInCategory patch? :) [19:22:07] yes, I'm going to work on it soon :) [19:22:36] bawolff: nice :) [19:22:48] I think it has enough interest to get merged soon. wmf12 mabbe even! :) [19:24:05] YuviPanda: so can I see the campaigns stuff live somewhere? [19:24:13] ori-l: testwiki! [19:24:25] it got deployed earlier today [19:24:31] where should i look? [19:25:20] ori-l: okay, that seems to have been botched somehow [19:25:27] see https://test.wikipedia.org/wiki/Special:RecentChanges [19:25:32] the namespace is missing? [19:25:53] Reedy: ^ [19:26:00] not sure what happened there. [19:26:12] is there a way to list all namespaces? [19:26:18] this worked fine on betalabs. [19:26:27] New patchset: Hashar; "experimental HTLM console publishing" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74424 [19:26:52] https://test.wikipedia.org/w/index.php?title=:wlm-pl&curid=71322&action=history [19:27:04] https://test.wikipedia.org/w/index.php?title=Campaign:wlm-pl&oldid=176109 exists [19:27:23] YuviPanda: namespaces here: https://test.wikipedia.org/wiki/Special:PrefixIndex [19:27:24] https://test.wikipedia.org/w/index.php?title=Campaign:wlm-pl exists [19:27:36] but RC was messed up? [19:27:52] ori-l: the namespace doesn't seem to have registered somehow [19:27:59] * YuviPanda checks test2 [19:28:22] YuviPanda: maybe you ran into the same issue I ran into. [19:28:25] oh? [19:28:26] let me pull up the bug. [19:28:57] http://commons.wikimedia.beta.wmflabs.org/wiki/Special:Contributions/Maintenance_script is fine [19:29:07] not in test2 either [19:29:14] YuviPanda: Agh suchabot spam [19:29:18] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=45031 [19:29:18] Uncle [19:29:27] how's that for an apropos bug title for you :) [19:29:27] marktraceur: what where [19:29:46] anomie: you there? [19:29:46] YuviPanda: I just got like 40 emails about comments left on gerrit that just got forwarded to github [19:30:00] anomie: is ext.centralauth.centralautologin.css loaded only when needed, or on all pages? [19:30:09] YuviPanda: seems like the exact same issue. [19:30:17] ori-l: reading through [19:30:19] marktraceur: for UW? [19:30:24] Yeah, your patch [19:30:28] marktraceur: that's... weird. let me look. [19:30:35] Oh look, even more [19:30:37] marktraceur: apologies. [19:30:42] MatmaRex: It's loaded whenever the .js is, which is on anonymous pageviews. We can't really do "as needed" for those because they're heavily cached, so the JS has to determine if it's needed. [19:30:56] marktraceur: okay, I just got that too [19:31:36] YuviPanda: adding the NS to CommonSettings.php should fix it, but you may want to get someone from platform to take a look to see if they can figure out the underlying issue [19:31:42] New patchset: Mwalker; "Further cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [19:31:46] otherwise it'll just bite the next namespace in line [19:31:54] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=45031? [19:32:02] anomie: hm, i was going to redo that with transforms, but it would make the JS part slightly uglier [19:32:13] anomie: have you tried just animating margin-top instead of transforms? [19:32:25] anomie: that could fix the webkit bug, whatever it is [19:33:02] ori-l: true, I'm poking Reedy. Not sure who else to poke. [19:33:04] MatmaRex: The UX people said "Here, use this". And it seemed to work, so we used it. Feel free to fix it in whatever manner makes sense. [19:33:22] New patchset: Rillke; "Replacing deprecated $j.browser with $.client" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74425 [19:33:26] MatmaRex: And if you can rewrite the CSS file entirely so we don't need the huge licensing header, even better. [19:33:32] ano [19:33:45] YuviPanda: if Reedy isn't around, see if you can rope anomie to help :P [19:33:46] anomie: alright, then i'lldo the transition version [19:34:32] yeah, https://test.wikipedia.org/wiki/Special:UploadWizard?campaign=wlm-pl isn't 'registering' either [19:34:38] even though Campaign:wlm-pl exists [19:35:06] anomie: can I convince you to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=45031? [19:35:18] YuviPanda: I'll look [19:37:42] ori-l-afk: bttw, if you want to look at it, you can at http://commons.wikimedia.beta.wmflabs.org/wiki/Special:Contributions/Maintenance_script and http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard?campaign=wlm-nl [19:41:20] New patchset: Rillke; "Replacing deprecated $j.browser with $.client" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74425 [19:47:14] YuviPanda: Where's the code that adds the "Campaign" namespace? [19:47:37] anomie: Extension:UploadWizard. let me find the exact file [19:48:17] It'll be a hook [19:48:32] anomie: CampaignHooks.php [19:48:33] anomie: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/includes/CampaignHooks.php#L123 [19:49:24] New patchset: Matmarex; "SpecialCentralAutoLogin: Inline JavaScript cleanup" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74484 [19:49:24] New patchset: Matmarex; "ext.centralauth.centralautologin.css: Use transition instead of animation" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74485 [19:49:27] anomie: ^^ [19:49:30] untested [19:49:58] New patchset: Mollywhite; "Bug 51591: NS_MAIN pages break on JSON edge cases." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74490 [19:50:24] New patchset: Matmarex; "ext.centralauth.centralautologin.css: Use transition instead of animation" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74485 [19:50:43] New review: Matmarex; "UNTESTED" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74485 [19:51:24] New patchset: TheDJ; "Move unsortable class into tablesorter config" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74500 [19:51:25] New patchset: TheDJ; "Tablesorter: Remove some config variables and docs that are not in use" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74501 [19:51:25] New review: Matmarex; "This is your friendly monthly bump." [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/47336 [19:54:39] Yippie, build fixed! [19:54:40] Project browsertests-en.wikipedia.org-linux-chrome build #194: FIXED in 3 min 27 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/194/ [19:54:46] New review: Swalling; "I see the flicker as well in some cases. I don't think it's a blocker for the other changes, which a..." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/74126 [19:58:18] Yippie, build fixed! [19:58:19] Project browsertests-en.wikipedia.org-linux-firefox build #183: FIXED in 3 min 39 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/183/ [19:59:59] New review: Matmarex; "Simple enough, thanks." [mediawiki/extensions/Insider] (master) C: 2; - https://gerrit.wikimedia.org/r/74406 [20:02:04] New patchset: Mollywhite; "Re-add minor CSS change that got lost in a rebase." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74510 [20:02:20] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74510 [20:02:46] anomie: Reedy any luck? [20:02:54] I've not looked [20:03:00] YuviPanda: Somewhat [20:03:18] New patchset: Mollywhite; "Bug 51591: NS_MAIN pages break on JSON edge cases." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74490 [20:03:20] okay [20:03:31] Change merged: jenkins-bot; [mediawiki/extensions/Insider] (master) - https://gerrit.wikimedia.org/r/74406 [20:05:52] New patchset: Mattflaschen; "Always hide old guiders if skipping." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/74126 [20:06:48] New review: Matmarex; "Simple enough, thanks." [mediawiki/extensions/RelatedArticles] (master) C: 2; - https://gerrit.wikimedia.org/r/74396 [20:06:48] Change merged: jenkins-bot; [mediawiki/extensions/RelatedArticles] (master) - https://gerrit.wikimedia.org/r/74396 [20:09:26] New review: Rillke; "While also other browsers (like Camino, Flock, Iceweasel and SeaMonkey) using gecko could suffer fro..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/74425 [20:13:33] YuviPanda: Commented on the bug. At the moment the ShortUrl extension is triggering the early call of the CanonicalNamespaces hook. [20:13:35] New review: Rillke; "Please note that this makes the master version of this extension incompatible" [mediawiki/extensions/RelatedSites] (master) - https://gerrit.wikimedia.org/r/74139 [20:13:58] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74511 [20:14:18] anomie: sorry, did I miss anything? got disconnected [20:14:21] * YuviPanda looks at bug [20:16:17] New patchset: JGonera; "Make User::getEditCount() always return an integer" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74512 [20:16:55] anomie: so since ShortUrl isn't deployed anywhere where UploadWizard also is, do I need to do anything now? I am not sure if I can fix the core issue... [20:17:32] anomie: also unsure if this is a bug in ShortUrl itself. If so that needs to be fixed (by me, I guess - since I'm *that* one's primary maintainer :) ) [20:18:13] New review: Aude; "not urgent but good to have deployed to keep the code in sync" [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74511 [20:19:35] New review: Spage; "With this change my (unlikely) test case of getting started toolbar [Show Help], click [Edit] for VE..." [mediawiki/extensions/GuidedTour/guiders] (master) C: 2; - https://gerrit.wikimedia.org/r/74126 [20:19:37] anomie: thanks very much for that! that's very good sleuthing. [20:20:11] YuviPanda: I don't really know whether it's a bug in ShortUrl, or whether Setup.php should flush that namespace cache, or whether adding namespaces from $wgExtensionFunctions isn't supposed to work. But it's a really simple fix to core, just add the one line with an appropriate comment to near the end of Setup.php. [20:20:22] Change merged: Mattflaschen; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/74126 [20:21:27] New patchset: JGonera; "Make User::getEditCount() always return an integer" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74512 [20:21:40] New review: Spage; "Updates since PS9 look fine. Tested on toro with required guiders change 74126." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/72682 [20:22:02] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [20:23:47] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74511 [20:23:50] New patchset: Reedy; "add script for adding wikidata and testwikidata to sites table" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [20:24:55] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/74384 [20:25:39] New review: Mwalker; "Fenceposting! Exciting! I don't know if you want to; but you could add a subtitle to the page statin..." [mediawiki/extensions/BookManagerv2] (master) C: 2; - https://gerrit.wikimedia.org/r/74490 [20:25:45] Change merged: jenkins-bot; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74490 [20:26:39] Reedy: greg had asked me to suggest settings for VIPS, which I did at https://gerrit.wikimedia.org/r/#/c/74514/ . Given he's not here, I thought I'd ping you about it [20:27:11] Project browsertests-test2.wikipedia.org-linux-firefox build #420: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/420/ [20:28:02] New review: Kaldari; "I agree that in most cases we should only be excluding QueryPages that don't work or are problematic..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73034 [20:29:37] anomie: I'd happily put up a patch, but I do not understand the underlying code, so feel a little uncomfortable. Let me do that anyway [20:30:59] New review: Helder.wiki; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [20:31:00] New patchset: Adamw; "Generalized mailing job queue" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [20:31:14] Yippie, build fixed! [20:31:15] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #85: FIXED in 4 min 3 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/85/ [20:38:47] anomie: I'm back from lunch, did you and/or MatmaRex get anywhere on the CentralAuth-breaks-VE-rendering issue, or should I take a stab at it? [20:39:08] RoanKattouw: MatmaRex made a patch of some sort [20:39:11] New review: Kaldari; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74512 [20:39:22] New patchset: Alex Monk; "Cross-wiki user rights UI should show target wiki groups instead of local" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36330 [20:39:24] Oh, I'll check [20:39:39] New review: Mollywhite; "Ah, I think you are right, Helder. I will submit a patch shortly." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [20:40:27] RoanKattouw: it's completely untested, though, so tread lightly [20:40:38] i don't really have a CA-enabled testing environment :) [20:40:58] Yippie, build fixed! [20:40:58] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #57: FIXED in 5 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/57/ [20:44:47] New patchset: Alex Monk; "Cross-wiki user rights UI should show target wiki groups instead of local" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36330 [20:45:20] MatmaRex: It looks good to me but I'm not sure I have a testing env either [20:45:22] New patchset: Mollywhite; "Change NS_MAIN to $wgContentNamespaces." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74518 [20:45:58] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74512 [20:46:10] New patchset: Cmcmahon; "A test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [20:46:42] New review: Cmcmahon; "I like this, let's see if it it passes the linter" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/72365 [20:47:06] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [20:49:28] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/74413 [20:49:31] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [20:49:46] New review: Raimond Spekking; "+2 per Luis" [mediawiki/extensions/Hovergallery] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73766 [20:49:47] Change merged: Raimond Spekking; [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/73766 [20:51:18] MatmaRex: Thanks for writing that patch! We'll hopefully have someone who does have a CA testing env test it today. I reviewed it and I would +2 it as written but I'd like testing to be done first :) [20:52:10] New review: Raimond Spekking; "(1 comment)" [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73160 [20:53:57] New review: Anomie; "Not animating in Firefox 22." [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/74485 [20:55:28] marktraceur: do you know off hand if .wav support was merged? I remember bawfollf saying something about that [20:56:24] New review: Catrope; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/74485 [20:56:34] New patchset: Mattflaschen; "Don't show GettingStarted toolbar when VisualEditor is open" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74522 [20:57:08] bawfollf, huh [20:57:22] He did say it was working, but I dunno [20:57:26] Maybe it's still in review [20:57:28] New review: Raimond Spekking; "(1 comment)" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/48608 [20:57:37] I suck without aotoucomptele [20:57:57] New review: Mattflaschen; "On toro for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74522 [21:03:16] New patchset: Rahul21; "Pronunciation Recording Tool (Fixed small issues in the README and COPYING)" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/74413 [21:04:59] New patchset: SuchABot; "Force re-cache of Canonical Namespaces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74523 [21:05:09] anomie|away: https://gerrit.wikimedia.org/r/74523 [21:05:17] Yippie, build fixed! [21:05:18] Project browsertests-test2.wikipedia.org-linux-firefox build #421: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/421/ [21:06:50] ori-l: ^demon first patchset for core from github :) https://gerrit.wikimedia.org/r/74523 [21:06:56] high probability of getting abandoned tho [21:07:30] New patchset: Mwalker; "Update Special:Version licensing for extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [21:07:38] New patchset: Mwalker; "Further cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [21:08:05] New review: Yuvipanda; "Also unsure if the return value of getCanonicalNamespaces should be assigned back to $wgCanonicalNam..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74523 [21:09:18] New patchset: Physikerwelt; "allow for pages with a combination of mathml and tex elements" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/74524 [21:10:52] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74518 [21:11:57] <^demon> YuviPanda: Two things. 1) What does SuchABot do if the change lacks a Change-Id? 2) If the last line is already something like Bug: or RT:, can we not add the \n before Change-Id: so we keep it all in the same footer block? [21:12:03] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74512 [21:12:33] mwalker: My next project is to initially load a few chapters in the chapterlist, and dynamically load the rest on scroll. Any suggestions on where to start or how to tackle it? [21:12:36] <^demon> Rephrase (1): rather, if the change-id already exists. [21:13:13] ^demon: so the commit messages is from the Pull Request's description, not commit messages [21:13:25] ^demon: and the desc isn't supposed to have a description. I need to write some code to strip that out [21:13:53] New review: Swalling; "Working as expected for me." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/74522 [21:14:02] ^demon: This is because there's squashing happening [21:14:12] <^demon> gotcha [21:14:23] ^demon: but yes, it sortof gets very confused if there is a Change-Id in the Pull Request description, but people usually don't put those there [21:14:28] ^demon: and let me file bugs for both [21:14:35] ^demon: this should get on gerrit at some point. [21:16:46] New review: Matmarex; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74485 [21:20:33] New review: Spage; "Toolbar hides on edit, reappears when I click [Page] (the latter isn't obvious)." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/74522 [21:20:33] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74522 [21:23:39] New patchset: Aaron Schulz; "Various code cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74300 [21:27:00] New patchset: Mattflaschen; "Fix Guiders submodule (just a commit message change to the submodule)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/74529 [21:27:50] New review: Mattflaschen; "Just changed the Guiders commit message." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/74529 [21:27:56] New review: Matmarex; "Looks straightforward." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74407 [21:28:07] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/74529 [21:29:50] New patchset: Mattflaschen; "Bump GuidedTour for E3 deploy" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74530 [21:32:25] ori-l: did you see my patch linked on that bug? [21:32:30] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74299 [21:32:35] New review: Spage; "latest master, latest submodule" [mediawiki/core] (wmf/1.22wmf10) C: 2; - https://gerrit.wikimedia.org/r/74530 [21:32:36] New patchset: Mattflaschen; "Bump GettingStarted for E3 deploy" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74531 [21:34:00] YuviPanda: no, lost context. link? [21:34:06] moment [21:34:13] ori-l: https://bugzilla.wikimedia.org/show_bug.cgi?id=45031 [21:34:28] New review: Spage; "yup latest" [mediawiki/core] (wmf/1.22wmf10) C: 2; - https://gerrit.wikimedia.org/r/74531 [21:34:30] ori-l: and https://gerrit.wikimedia.org/r/74523 is the patch that I"m uncomfortable about, since I do not know what exactly it is doing [21:35:20] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [21:35:42] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74530 [21:36:18] New review: Matmarex; "True. Thanks, less code is always better! :D" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/74412 [21:36:59] New patchset: Catrope; "Remove backface-visibility: hidden CSS that breaks VisualEditor" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74532 [21:37:30] New patchset: Hashar; "A test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [21:37:34] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [21:37:41] csteipp: I can haz merge? https://gerrit.wikimedia.org/r/#/c/74532/ [21:38:12] chrismcmahon: around ? :-D [21:38:14] YuviPanda: I'll look, but it's not exactly the part of the stack I'm most comfortable in [21:38:15] done [21:38:19] Yay thnaks [21:38:22] hi hashar [21:38:28] YuviPanda: so it'll take me time and I'd probably only +/- 1 [21:38:31] ori-l: yeah, me neither. I suppose I/we'll just wait for anomie|away [21:38:36] ori-l: yeah, that's fine. [21:38:42] chrismcmahon: so i looked at your unicode issue in ruby 1.9.3 linter :] [21:38:44] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74531 [21:38:51] ori-l: and I assume you didn't have this problem when you deployed to a non-testwiki location [21:38:53] ? [21:39:06] correct [21:39:08] New review: MZMcBride; "Does this changeset have an associated bug report in Bugzilla?" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [21:39:15] ori-l: okay. [21:40:18] New review: Hashar; "(1 comment)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [21:40:20] chrismcmahon: turns out one need to specify to ruby the file encoding :/ [21:41:06] hashar: that makes sense [21:42:15] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/74532 [21:42:34] New patchset: Cscott; "Sync up with Parsoid parserTests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74533 [21:44:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74412 [21:45:22] chrismcmahon: that passed :) https://integration.wikimedia.org/ci/job/qa-browsertests-ruby1.9.3lint/429/console [21:46:32] thanks hashar and thanks from Amir also :) [21:48:27] New review: Matmarex; "Why?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877 [21:48:58] New review: Swalling; "Please see the bug." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877 [21:49:03] New patchset: SuchABot; "Force re-cache of Canonical Namespaces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74523 [21:49:29] is it possible to link to a specific line of a gerrit review? [21:49:37] copy link location gets me a semicolon :P [21:49:43] New review: Matmarex; "The bug doesn't answer that question." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877 [21:50:23] New review: EBernhardson; "@MZMcbride Hooks.php line 307 for the user preference" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [21:50:33] ebernhardson: no, i don't think so. that's annoying. [21:51:02] ori-l: shrug, ok. could be worse i suppose :) [21:51:04] it would only take adding id="NN" to one of the elements that make up each line [21:51:15] well, that and understanding GWT :) [21:51:20] might be worth filing a bug upstream [21:51:28] ebernhardson: Thank you! [21:51:44] Elsie: umm, your welcome? [21:51:49] Elsie: not sure why :) [21:52:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74533 [21:52:13] ebernhardson: For the pointer to Hooks.php at https://gerrit.wikimedia.org/r/#/c/70112/ :-) [21:52:18] you're * ;-) [21:52:19] Elsie: oh :) [21:53:33] New patchset: Bsitu; "(bug 46664) Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [21:53:56] <^demon> Seriously? That's no an ID? [21:54:24] New review: Swalling; "Yes it does. The reason we're doing this is because it's a usability enhancement." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877 [21:55:27] New patchset: Bsitu; "(bug 46665) Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [21:55:47] ^demon: i don't see one, no [21:56:16] though it's possible there's some fragment identifier pattern that triggers javascript code to highlight a particular line [21:56:21] New review: Krinkle; "@Matt: Regardless of the arguments, something I value more and should've mentioned beforehand is con..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [21:57:15] ^angry: What causes your rancor? [21:57:54] <^angry> Crappy UI decisions. [21:58:04] marktraceur: and gerrit [21:58:26] this is about lack of ids/anchors for line numbers, I think [21:58:58] <^angry> And other stuff. [21:59:03] right. [22:00:00] Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [22:00:18] YuviPanda: I think "and gerrit" was redundant [22:00:27] hehe [22:01:00] New patchset: Krinkle; "Clean up: Consistently use "$" instead of "$( document ).ready"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [22:01:09] New patchset: Adamw; "Amazon IPN listener" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/60958 [22:09:35] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74314 [22:16:17] New patchset: Mattflaschen; "Bump GettingStarted for 1.22wmf11" [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74540 [22:17:21] New patchset: Mattflaschen; "Bump GuidedTour for 1.22wmf11" [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74541 [22:19:04] New review: Spage; "yup latest" [mediawiki/core] (wmf/1.22wmf11) C: 2; - https://gerrit.wikimedia.org/r/74541 [22:19:42] New review: Spage; "yup, latest" [mediawiki/core] (wmf/1.22wmf11) C: 2; - https://gerrit.wikimedia.org/r/74540 [22:22:23] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74541 [22:23:40] New patchset: Adamw; "Generalized mailing job queue" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [22:23:50] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74540 [22:30:06] New patchset: JGonera; "Make User::getEditCount() always return an integer" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74512 [22:30:09] csteipp: btw, the thread at https://commons.wikimedia.org/wiki/Commons:Village_pump#Commons_sign-in_bug.3F - some people are speculating may be related to new sul deployment [22:32:31] Testing [22:32:34] nice :) [22:32:49] durrit-wm [22:33:58] Elsie: I'm building it to replace gerrit-wm, alternative name ideas welcome :) [22:34:16] current ideas for what it should do at https://www.mediawiki.org/wiki/User:Yuvipanda/Gerrot-Bot [22:34:24] since current setup is a hacky hacky hackety ircecho [22:34:50] ircecho is pretty stable and well-tested code. [22:34:50] New patchset: CSteipp; "Adding re-authorize flow" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74543 [22:36:02] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74512 [22:36:40] ori-l, ^angry: I was cut off from internet, so maybe that has been discussed in the meantime, but while adding ids to gerrit diff lines would be easy, using them is hard, as the urls already contain # :-/ [22:37:04] I once had a look but stopped as that would require major refactorings to get it working as expected. [22:37:34] <^angry> I'm wondering if codemirror makes that any nicer. [22:38:02] Is there any good reason Gerrit URLs contain #? [22:38:06] Maybe, but I doubt that. That's somewhat inherent to gerrit's understanding of urls. [22:38:42] Elsie: Partly yes. One page loads the main app. Then any further click does noth reload the app again, but just fetches new data into the app. [22:38:52] Elsie: At least that's the main idea. [22:39:02] yeah, the single page javascript app makes for very responsive, usable and fast UI! [22:39:10] * Elsie pets YuviPanda. [22:39:12] Elsie: Se they use # and some magic to know what page to show within the main app. [22:39:19] New review: Tim Starling; "Why was it deleted? https://gerrit.wikimedia.org/r/#/c/7008/ suggests it may have been by accident, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74337 [22:39:35] YuviPanda: Yeah :-D Gerrit rocks. ... wait what was the verb I was looking for? [22:39:55] qchris_away: 'throw rocks at gerrit', you mean :) [22:40:02] YuviPanda: *gg* [22:40:09] qchris_: :) [22:40:20] <^angry> qchris: I posted a mockup of how I think ChangeScreen2 should do diffs between patchsets. [22:40:30] <^angry> It's kind of a major lacking feature in the new UI :( [22:40:55] ^angry: I saw your comments on the list. Do you like ChangeScreen2? [22:41:10] <^angry> I'm trying to like it. [22:41:15] <^angry> I think it needs a ton of work though. [22:41:15] ^angry: :-) [22:41:52] everything's possible with Stockholm Syndrome! :) [22:42:01] ^angry: Seems like the gerrit way �Half implement a feature� ... and afterwards instead of completing it or fixing bugs, rip out the old implementation and add another half backed solution :-) [22:43:18] ^angry: where did you post the mockup ... I did not recall seeing a mock up and cannot find a link when reading the posts again. [22:43:34] <^angry> Oh, I just posted to repo-discuss like 5m ago, image uploaded to mw.org [22:43:37] ^angry: Now I found it. Sorry. [22:43:47] https://www.mediawiki.org/wiki/File:ComparePatchSets.png [22:43:57] ^ For those who want to take a look. [22:44:27] <^angry> That was from just lazily adding some junk to the HTML output of gerrit-review, I didn't even try hard to make it look nice ;-) [22:44:57] �Look nice� would not fit ChangeScreen2 anyways :-) [22:45:35] <^angry> Just remove the border and it'll look just like ChangeScreen2 ;-) [22:46:28] New patchset: JGonera; "Make User::getEditCount() always return an integer" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74512 [22:46:29] New review: JGonera; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74512 [22:47:53] New review: Matmarex; "Thanks for the explanation. But I honestly don't see how removing a piece of information which is s..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877 [22:47:54] New patchset: Kaldari; "Making sure wgUserNewMsgRevisionId works even for the first post" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74547 [22:49:32] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74300 [22:50:38] New patchset: Aaron Schulz; "profiler: log slow methods that worsen DB locks in transactions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70923 [22:56:58] New patchset: Ori.livneh; "Discard comments in mergeMessageFileList.php's --list-file file" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74550 [23:00:18] New review: MarkTraceur; "o.O" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [23:04:55] goddamit, someone do something on gerrit! [23:05:01] this happens only when I'm waiting to test something. grr [23:05:12] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #86: FAILURE in 4 min 13 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/86/ [23:05:46] New patchset: Anomie; "Force re-cache of Canonical Namespaces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74523 [23:06:15] New patchset: Cmcmahon; "Scenario: Visual editor does not appear if user is not logged in" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73967 [23:06:25] New review: Cmcmahon; "checked" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/73967 [23:06:26] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73967 [23:06:48] New patchset: Cmcmahon; "A test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [23:06:57] New review: Cmcmahon; "looks good" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/72365 [23:07:34] New patchset: Cmcmahon; "Scenario: Wikilove window appears" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74386 [23:08:13] New review: Anomie; "Code looks good. A second opinion on whether this seems like the right way to fix the bug would be n..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74523 [23:09:50] New patchset: Demon; "Merge branch 'elastic'" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [23:13:46] New patchset: Demon; "Use secure resources, getting mixed content warnings" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/74553 [23:14:19] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74305 [23:18:49] OK, let's do this lightning deploy thing [23:19:22] New review: Demon; "recheck" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [23:20:31] New review: Demon; "recheck" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [23:22:34] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [23:25:02] New patchset: Catrope; "Update CentralAuth and VisualEditor to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74555 [23:25:23] New review: Tim Starling; "The concept of a command line "Wikimedia mode" dates back to r4037. The relevant code has now moved ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74337 [23:25:35] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74555 [23:26:17] New patchset: Catrope; "Update CentralAuth and VisualEditor to master" [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74556 [23:26:29] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf11) - https://gerrit.wikimedia.org/r/74556 [23:27:53] New patchset: Adamw; "Mailing job test will check message contents and headers." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74557 [23:31:32] New patchset: Adamw; "Job recipients are processed in FIFO order" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/74558 [23:32:13] New review: Yuvipanda; "Any idea who could provide the second opinion?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74523 [23:32:58] New review: Matmarex; "For the record, ").ready" matches 25 files on master (including some occurences in docs and comments..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [23:34:35] hey YuviPanda [23:34:45] hey MatmaRex [23:35:01] 'sup [23:35:12] you and rillke should really play with that github<->gerrit communication thing you've done [23:35:27] oh? [23:35:29] New review: Swalling; "Thanks for the heads up about i18n issues MatmaRex. We'll get this up on a Labs instance to test cro..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72877 [23:35:31] he already complained about gerrit sucking and github being nice on two unrelated bugs today ~ [23:35:32] :D [23:36:09] MatmaRex: :D It's already functional for about 15-20 repos now, and I have been doing 99% of my contributions that way. [23:36:17] needs work tho [23:37:09] New patchset: Legoktm; "Remove duplicate [[Special:Tags]] link now that 5abf6fc is merged." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/74559 [23:37:42] MatmaRex: does rillke hang out on IRC? I've no idea who they are [23:38:35] he's commons admin... maybe in #wikimedia-commons [23:38:42] New review: Matmarex; "Paging Raimond for Translatewiki import. :)" [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/74559 [23:38:50] not today, but I'll do that later [23:38:51] but as he's from Germany, I doubt you'll find him now (1:38am here) [23:38:51] thanks hoo [23:39:00] well, I'm from India and it is 5AM... :P [23:39:05] i should go sleep though. good night [23:39:10] New patchset: Krinkle; "Return Notification object from mw.notification.notify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74407 [23:39:12] MatmaRex: that was fast :D [23:39:14] :D good night ;) [23:39:15] You're just silly YuviPanda [23:39:18] YuviPanda: yeah, hedoes hang out [23:39:20] Reedy: oh, you're still up [23:39:22] i think as rillke [23:39:28] @seen rillke [23:39:28] MatmaRex: Last time I saw rillke they were quitting the network with reason: Quit: Leaving. N/A at 7/18/2013 9:37:19 PM (02:02:08.5738450 ago) [23:39:31] New patchset: Demon; "Don't use empty() to check if array has 0 items" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74560 [23:39:37] Reedy: can you deploy https://gerrit.wikimedia.org/r/#/c/74523/ on testwiki and run the migration script again? [23:39:41] Reedy: should verify if that fixes it [23:39:54] New patchset: Krinkle; "mediawiki.notification: Return Notification object from notify()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74407 [23:39:54] Reedy: or is this too late for that and I should poke you tomorrow? [23:40:13] legoktm: making changes to non-english messages in commits is troublesome in general, i've been rold [23:40:14] told* [23:40:22] Roan is mid scap.. [23:40:25] Reedy: aaand, do look at the patch too :) Anomie was looking for someone else... [23:40:32] MatmaRex: Hm. I just ran a regex find/replace to remove them all. [23:40:34] legoktm: and raimond is apparently the go-to guy to ask about this [23:40:37] Not really the best time to start pushing other changes [23:40:57] Reedy: just testing, but yes. let me poke you tomorrow [23:41:04] lucky me ;) [23:41:06] legoktm: yeah, but the repo/twn import/expont is rather unidirectional [23:41:18] legoktm: twn has an extension to do mass text replacements, i think [23:41:26] Ah, ok [23:41:33] legoktm: and i think that's what they use usually instead of importing the changed messages from the commit [23:41:54] * YuviPanda goes to sleep, for real. [23:42:01] * ori-l waves. [23:42:22] legoktm: post the regex there, maybe? [23:43:12] New review: Krinkle; "I'm not sure all of these methods should be public, we may want to abstract it to a submit that we c..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74407 [23:43:45] YuviPanda: i hate that fake sleep [23:47:29] New review: Kaldari; "Probably a bad idea to query the Revision table without some caching. It's a start at least." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74547 [23:52:49] New review: Krinkle; "Perhaps count()? Though unfortunately all of these are way too tolerant in interpretation on PHPs en..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74560 [23:59:09] New review: Demon; "Well count() and implicit conversion both end up with the same basic result (I did this since it's l..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74560 [23:59:13] New review: CSteipp; "All minor stuff. I made the fixes locally, and afterward, I have a test client that's accessing the ..." [mediawiki/extensions/OAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/73977