[00:01:42] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742 [00:01:42] New review: Yaron Koren; "The tabbing in headerHTML() is messed up now. Anyway, that whole check of whether $header_name is nu..." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [00:01:42] New patchset: Aaron Schulz; "Fixed return type of getContentNamespaces()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72111 [00:01:42] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74092 [00:03:05] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74093 [00:09:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72111 [00:14:59] New patchset: Mwjames; "(Bug 51498) SMW\RedirectBuilder move responsibility out of ParserTextProcessor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74095 [00:19:56] New patchset: Kaldari; "Removing all disambiguation code from core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74096 [00:25:11] spagewmf: got a sec? wanted to talk about the GettingStarted/SUL work [00:25:32] robla, sure [00:25:54] no rush on our side, btw, just checking in to see if you're tapping your foot waiting for us. we're debating whether to deploy the new hook [00:26:54] we're leaning toward waiting until tomorrow to deploy, but if you're all like "WHY ARE YOU WAITING", we'd reconsider :-) [00:27:55] robla, the new hook is merged. Are you saying it won't be backported tomorrow unless I'm all like CAPS LETTERS? [00:28:20] spagewmf: pretty much :-) [00:28:26] oh, wait [00:28:46] it will be backported tomorrow, it's more a questoin of whether we should try to cram it in tonight [00:28:54] tomorrow is fine. [00:29:06] sweet, it's settled then [00:29:06] we're going to deploy our GS changes Thursday, afaik [00:29:14] robla are you going to deploy the SUL changes tomorrow regardless? Because we'd like that hook in there so that in our Thursday we can revive GettingStarted. [00:29:39] yup, we'll deploy tomorrow regardless, assuming we get the go decision at 10am [00:33:11] New review: Parent5446; "Definitely needs release notes. This is a breaking change." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74096 [00:50:31] New patchset: Kaldari; "Removing all disambiguation code from core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74096 [00:52:45] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74096 [01:01:02] New review: Kaldari; "Need to update ProofreadPage first" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/74096 [01:17:56] New patchset: Kaldari; "Removing dependancy on SpecialDisambiguations since it's being axed." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/74103 [01:25:34] New patchset: Kaldari; "Removing all disambiguation code from core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74096 [01:36:13] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844 [01:37:08] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844 [01:47:56] New review: Krinkle; "I disagree. Per these points:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [01:48:21] New review: Krinkle; "@Daniel: That sounds like how it should be." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [01:50:05] New review: Krinkle; "And that's how it is. Interesting." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [01:54:00] New review: Krinkle; "It shows up too low right now (it keeps the offset of the skin header). Makes it appear almost half-..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72322 [01:56:11] New review: Krinkle; "Instead of offsetting each individual item, we could also do this on the container instead. It would..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [02:08:24] New patchset: Krinkle; "CSSJanus: Fix handling for border-radius" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [02:08:51] New review: Krinkle; "Rebased and pulled out of 498ee6b3c3d0552c98." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [02:16:00] New patchset: Himeshi; "Added parsing of the {{{section}}} tag." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [02:52:25] New review: Spage; "It shows the VE tour if VE is enabled in the NS_MAIN namespace of my vagrant wiki, and shows the reg..." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/72682 [02:53:06] New review: Mattflaschen; "Why?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74079 [03:09:40] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #192: FAILURE in 8 min 46 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/192/ [03:10:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #170: FAILURE in 9 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/170/ [03:13:22] New review: Yaron Koren; "Looks good!" [mediawiki/extensions/SemanticForms] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/72051 [03:13:28] Change merged: jenkins-bot; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [03:20:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #115: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/115/ [03:24:43] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #115: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/115/ [03:30:13] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #153: FAILURE in 9 min 20 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/153/ [03:37:50] New review: Spage; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/72677 [03:39:17] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #164: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/164/ [03:43:51] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [03:48:21] New review: Thaiphan; "It's your extension. Why you no fix? :(" [mediawiki/extensions/AWS] (master) C: 1; - https://gerrit.wikimedia.org/r/73737 [03:57:40] New review: Bsitu; "Apple mail ignores the last empty table cell, I added another redundant dummy row to handle this." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [04:23:27] New patchset: Spage; "support CentralAuthPostLoginRedirect hook" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [04:42:44] New review: Spage; "Thanks, minor suggestions addressed in PS2." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [05:08:04] New review: Ori.livneh; "Went for it." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/74061 [05:08:09] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74061 [07:34:55] ori-l: I feel guilty of not being able to help you on the event logging in labs stuff :D [07:35:59] hashar: it was only hard because i made it hard by writing crappy puppet manifests the first time around [07:36:29] but i'm pleased that it works now :) [07:38:42] ori-l: and you will be able to use the beta instance as a playground :-) [07:39:14] yeah, that'll come in handy [07:39:16] is vanadium the event receiver ? [07:39:21] yep [07:39:31] I think I have seen beta sending some packets to vanadium [07:40:07] maybe the varnish bits instance of beta uses it [07:40:20] hashar: the mongodb sink is called 'vanadium' on both labs and prod [07:40:30] in both cases it's 127.0.0.1, but in labs the name is inappropriate [07:40:38] but it has no practical consequence [07:40:54] maybe that's what you saw? [07:40:58] maybe [07:41:19] wmf-config/CommonSettings.php: 'host' => 'vanadium.eqiad.wmnet', [07:41:20] wmf-config/CommonSettings.php: $wgEventLoggingFile = 'udp://10.64.21.123:8421/EventLogging'; // vanadium [07:42:06] the $wgEventLogging* on beta seems to be set the same as in prod [07:43:11] ommonSettings-labs.php [07:43:11] 32: $wgEventLoggingFile = 'udp://deployment-eventlogging.pmtpa.wmflabs:8421/EventLogging'; [07:43:43] > return $wgEventLoggingDBname [07:43:44] metawiki [07:43:45] > return $wgEventLoggingFile [07:43:47] udp://deployment-eventlogging.pmtpa.wmflabs:8421/EventLogging [07:43:48] > return $wgEventLoggingSchemaApiUri [07:43:48] http://meta.wikimedia.org/w/api.php [07:44:10] yeah, that's deliberate [07:44:17] it means that events are validated against schemas on meta [07:44:20] so that seems to be fine [07:44:35] what is wgEventLoggingDBname for ? [07:44:46] cause I don't think the metawiki wiki is enabled on beta [07:44:48] oh, that is very ugly [07:44:57] the central wiki is known as labswiki [07:45:20] if $wgEventLoggingDBname == $wgDBname, the schema namespace is activated [07:45:21] ah all-labs.db has a metawiki [07:45:39] it's very weird and roundabout logic, artifact of old code that was mostly deleted [07:46:38] it probably does not matter that much [07:46:40] i think it's OK that $wgEventLoggingSchemaApiUri references metawiki [07:46:46] at least the events are sent to the proper instance :-) [07:46:58] otherwise people would have to remember to copy every schema (and every change to every schema) over to labs [07:47:02] yeah this way you get the same events capabilities as in production [07:47:15] right, which is what, e.g. mobile cares about [07:48:03] there's a schema namespace over on test2wiki for testing that stuff specifically [08:01:23] New review: Mattflaschen; "Works locally." [mediawiki/vagrant] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/74115 [08:01:29] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74115 [08:03:46] New patchset: Shirayuki; "Fix spelling & Add full-stops" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74118 [08:20:56] New patchset: Hashar; "beta job status on the main page" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/74120 [08:21:31] Change merged: Hashar; [integration/docroot] (master) - https://gerrit.wikimedia.org/r/74120 [08:47:17] New patchset: Mattflaschen; "Document additional methods" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/73141 [09:20:03] New patchset: Hashar; "operations-dns-lint" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74124 [09:25:38] New patchset: Hashar; "operations-dns-lint (non voting)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74125 [10:01:35] New patchset: Mattflaschen; "Always hide old guiders if skipping." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/74126 [10:04:10] New review: Mattflaschen; "On toro for testing. I think I see a slight increased flicker, but I'm not sure. I'm interested in..." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/74126 [10:09:51] New patchset: Mattflaschen; "Add support for VisualEditor" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [10:11:28] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [10:22:00] New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [10:25:43] New review: Mattflaschen; "Patch set 10 is on toro for testing. " [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [10:28:19] New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [10:39:54] New patchset: Zfilipin; "WIP Test central-domain login, cross-domain login and central login for anons" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74128 [10:47:29] New patchset: Krinkle; "CSSJanus: Handle values of border-radius correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [10:47:52] New review: Krinkle; "Added release notes." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67264 [10:52:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [10:53:53] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74125 [11:37:52] New patchset: SuchABot; "[WIP] Initial move to Holo Light than Holo Dark" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [11:43:23] New review: Krinkle; "* Rationale given in I9ed231ef759372." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [11:47:34] New review: Krinkle; "Essentially it is a textbook example of a "bad part" with an alternative where the bad part has a fe..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [12:24:34] New patchset: Rillke; "RelatedSites: Heading level in sidebar: h5 to h3" [mediawiki/extensions/RelatedSites] (master) - https://gerrit.wikimedia.org/r/74139 [12:42:11] Change merged: jenkins-bot; [mediawiki/extensions/RelatedSites] (master) - https://gerrit.wikimedia.org/r/74139 [12:53:44] New patchset: Rjain; "Separated the OKFN modules to mediawiki.libs.okfn/" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/73612 [14:02:57] New review: Physikerwelt; "the new vagrant version introduces \r to all files... I'don't like that" [mediawiki/extensions/MathSearch] (master) C: -1; - https://gerrit.wikimedia.org/r/74153 [14:03:05] do you mean a I should create a (named) function such as e.g. the existing hideDeselectedActions which is outside the $( document ).ready()? [14:03:17] and just $( '#mw-abusefilter-load-filter' ).keypress( theNewFunction) ? [14:03:32] yep [14:09:47] New patchset: Physikerwelt; "Little improvements in MathDebug" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74153 [14:14:38] New patchset: Physikerwelt; "Little improvements in MathDebug" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74153 [14:15:17] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74153 [15:03:27] New patchset: Helder.wiki; "Load filter conditions when the user press ENTER" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/74152 [15:20:37] New patchset: Hoo man; "API: Fix abuse log detail visibility for private filters" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/74164 [15:23:03] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74118 [15:41:39] New patchset: SuchABot; "[WIP] Initial move to Holo Light than Holo Dark" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [15:41:40] New patchset: Matthias Mullie; "Send Echo notification upon submitting/moderating feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/74166 [15:42:27] New review: Matthias Mullie; "WIP" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -2; - https://gerrit.wikimedia.org/r/74166 [16:08:40] New patchset: SuchABot; "[WIP] Initial move to Holo Light than Holo Dark" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [16:13:13] New review: Anomie; "I was meaning to ask you about the canSeePrivate calls in that module at some point. Code seems fine..." [mediawiki/extensions/AbuseFilter] (master) C: 1; - https://gerrit.wikimedia.org/r/74164 [16:21:54] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73973 [16:25:04] Hey ori-l, just wanted to check in on bugs 51062 and 51063 [16:25:10] New patchset: Hashar; "getConfiguration.php now supports regex" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17069 [16:25:29] Is this something you guys are actively looking in to? Or should I be trying to come up with a solution for it independently? [16:25:37] New review: Ori.livneh; "I don't even think `$( document ).ready` is clearer; it makes sense to have a syntactic form for wha..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74079 [16:25:48] New review: Hashar; "PS2 integrates the code in maintenance/getConfiguration.php " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17069 [16:25:59] GorillaWarfare: i'll look; hang on. [16:26:14] Sure [16:31:18] GorillaWarfare: yeah, the kind of validation you're inquiring about is unimplemented [16:31:38] and not something I'm looking into actively [16:31:41] can't imagine robla is, either [16:32:00] but happy to code-review if you feel up to it [16:32:13] Okay, thanks for letting me know :) I'll speak with my mentor about it [16:33:01] np, sorry for being unresponsive on BZ; i suck at multitasking. [16:33:31] No worries [16:35:05] New review: Jdlrobson; "This is a good pattern to adopt. It also reduces the size of our JavaScript ever so slightly.. alway..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74079 [16:44:28] New patchset: Daniel Kinzler; "Detect leakage of error_reporting state in tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74170 [16:44:48] New review: Nikerabbit; "What side effects? Can you point to the exact line?" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73448 [16:58:23] New patchset: Ori.livneh; "'shell::var' -> 'env::var'" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74174 [16:58:37] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74174 [17:02:25] New patchset: Ori.livneh; "Reference env::var resource in mediawiki/manifests/user.pp" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74175 [17:02:57] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74175 [17:16:11] New patchset: Daniel Kinzler; "(bug 49338) Fix error handling in RollbackAction." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74176 [17:19:26] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/74176 [17:21:51] New review: Krinkle; "fyi: I'm working on this now per raised priority in blocking a change in VisualEditor." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [17:23:02] New review: Krinkle; "This change was not deployed. Please revert or deploy soon." [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73321 [17:25:30] New patchset: Daniel Kinzler; "Return messages in a consistent form from Status objects." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74176 [17:25:43] Krinkle: better? [17:28:32] hi liangent! [17:29:11] DanielK_WMDE__: hi [17:29:20] you have quite a few changes open on gerrit... i'm not sure which of them are still up to the current state of discussion. [17:29:39] could you mark them as needing work (-1) or abandon them, as appropriate? [17:29:45] DanielK_WMDE__: a few are not, and others need to be edited [17:29:57] that'S what i thought [17:30:18] if you marked them, i would get a better idea what i should look at when going over my gerrit dashboard [17:30:22] thanks! [17:30:28] DanielK_WMDE__: ok [17:31:07] DanielK_WMDE__: ":wq" [17:31:33] Krinkle: >_< [17:31:59] New patchset: Daniel Kinzler; "Return messages in a consistent form from Status objects." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74176 [17:32:09] yay for typing into the wrong window [17:32:12] windows are overrated [17:32:24] even Windows is phasing out windows [17:32:29] :P [17:32:59] Apple is starting to use the word "windows" (lowercase "w") more often lately in their documentation and messaging. [17:35:48] New review: Jdlrobson; "I personally think this would make a lot of skin code much neater." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/73548 [17:38:49] New patchset: Krinkle; "Return messages in a consistent form from Status objects" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74176 [17:43:41] New review: Krinkle; "Method looks fine (maybe isset instead of array key exists, not sure)." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73548 [17:44:35] New review: Mwjames; "Why did Zuul stop ????" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74095 [17:44:53] New patchset: Mwjames; "(Bug 51498) SMW\RedirectBuilder move responsibility out of ParserTextProcessor Change-Id: Ie4b95c0db250f01c25c71d312a4f8af8b812bc71" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74095 [17:46:45] New review: Mwjames; "Let's try this again ..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/74095 [17:48:24] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74095 [17:53:54] New patchset: Mwjames; "Move some files into utilities folder" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74179 [17:56:37] New patchset: Robmoen; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74180 [17:58:18] New patchset: Robmoen; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74181 [17:58:42] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74179 [17:59:59] New review: Jdlrobson; "Agreed that it would be good to promote best practices to show how it is used by replacing current u..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [18:10:40] New review: Umherirrender; "Maybe it can have side effects, but I know not enough about this extension to be sure, there are no ..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73448 [18:19:43] New review: Matmarex; "Fair enough, but I'd really like the word "ready" to appear somewhere in those calls. Oh well." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74078 [18:20:15] New review: Matmarex; "Fair enough, but I'd really like the word "ready" to appear somewhere in those calls, like Matt. Oh ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/74079 [18:20:40] New patchset: Cmcmahon; "Update VE tests for current behavior, verified no bugs" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74182 [18:23:38] New review: Matmarex; "I30aa881a2ad962bee7a0710c6693afae9881118f" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66092 [18:24:01] New patchset: Matmarex; "Release notes for Ie04f23c1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74183 [18:24:08] hi rachel99 if you [18:24:29] hi rachel99 if you're around take a look at https://gerrit.wikimedia.org/r/#/c/74182/ [18:27:00] New patchset: Adamw; "log if we cannot insert a contribution_tracking record" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/74184 [18:28:11] chrismcmahon: Were you trying to get in touch with me? [18:28:25] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/74184 [18:30:55] rachel99: I thought you should look over the changes in that commit https://gerrit.wikimedia.org/r/#/c/74182/ [18:30:56] New patchset: Matmarex; "CSSJanus: Support text-shadow and box-shadow flipping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52611 [18:31:15] rachel99: that's the sort of thing I'm hoping you'll be doing in the not too distant future [18:31:21] New review: Matmarex; "Rebased because somebodyhas decided to mess with my dependency chain and not fix what theybroke." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52611 [18:31:31] chrismcmahon: OK, I will look at it. [18:32:57] rachel99: yesterday's deploy changed the UI a bit. I checked that we didn't have a new bug and made the tests pass again, didn't take too long [18:35:15] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [18:35:16] New patchset: Adamw; "log when in "cache" mode" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/74185 [18:35:23] chrismcmahon: Ok, will take a look. [18:36:08] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/74185 [18:36:28] chrismcmahon: Did Zeljko tell you that I am now working on a test to see if VE appears if user is not logged in? [18:36:59] chrismcmahon: He wanted me to work on that one, and put the internal links test aside for now. [18:37:10] rachel99: OK [18:37:43] Ok, great! thanks [18:38:14] New patchset: Hoo man; "Fix the calculation of fss_resource_t->replace_size" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [18:39:06] I manually had to create a .gitreview to upload that change -.- [18:40:07] New patchset: Cmcmahon; "Update VE tests for current behavior, verified no bugs" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74182 [18:40:12] hoo: Could you commit that .gitreview file then? That would help everyone else :) [18:40:51] RoanKattouw: Sure :D [18:41:01] New patchset: Matmarex; "diff: Display "(No difference)" instead of an empty diff" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [18:41:34] New review: Matmarex; "Fixed inconsistency between commit message / release notes and the message text." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/73014 [18:43:31] New patchset: Hoo man; "Add .gitreview" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74187 [18:44:07] RoanKattouw: https://gerrit.wikimedia.org/r/74187 MERGE NOWWW! :D ;) [18:44:25] Change merged: Catrope; [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74187 [18:45:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [18:45:21] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74182 [18:53:12] New patchset: Kaldari; "Adding getter method for QuickTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [19:04:19] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [19:06:06] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [19:18:31] New patchset: Demon; "Merge branch 'elastic'" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/74192 [19:19:47] <^d> manybubbles: ^ mostly clean merge, only problem was i18n (trivial fix). [19:20:07] <^d> That being said, I think we'll need to import the elastica repo to our own gerrit. [19:20:24] ^d: not as a subrepo from github/ [19:20:26] ? [19:20:42] <^d> As a submodule, but in our gerrit. [19:20:54] <^d> like CirrusSearch/elastica or somesuch. I'll think on it during lunch. [19:23:04] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [19:23:20] ^d: cool. so that change you linked me, it only shows the conflicts - is intentional? I'm kind of confused [19:23:35] <^d> Yeah, that's how gerrit displays merge commits. It's lame :) [19:24:02] New patchset: Ryan Lane; "Add support for custom namespace for projects" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/74211 [19:25:32] New patchset: Daniel Kinzler; "Allow debugging of unit tests via wfDebugLog." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74224 [19:25:37] ^d: so if I +2 this it'll merge my sandbox branch into master? [19:27:50] <^d> Should :) [19:27:54] helderwiki: Thanks a lot for all your help :) I know you're busy [19:28:38] you're welcome [19:28:42] GorillaWarfare: ^ [19:34:06] New patchset: Mollywhite; "Bug 51256: Load primary CSS separately from JavaScript." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73784 [19:34:33] !g 72844 | Krinkle, I'd like to have a slightly higher bandwidth conversation about this patch if you have a few minutes [19:34:42] wm-bot: Take your time [19:34:43] Hi marktraceur, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [19:34:46] Damn it [19:34:51] !gerrit 72844 | Krinkle, I'd like to have a slightly higher bandwidth conversation about this patch if you have a few minutes [19:35:02] I got the ping [19:35:07] *nod* [19:35:22] I'm just sad about the failed bot message [19:35:23] wm-bot's brain is broken. The db is stored in #mediawiki, the link with -dev and -visualeditor e.a. seems to be broken [19:35:34] it works in #mediawiki [19:35:44] Yeah. [19:35:45] Anyway [19:36:02] New patchset: Mollywhite; "Bug 51256: Load primary CSS separately from JavaScript." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73784 [19:36:06] Krinkle: I was wondering what you envisioned happening in your proposed solution [19:36:26] Because it's still not super clear [19:36:34] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73784 [19:36:44] I mean, the storage is, sort of, but the reset action doesn't seem like it would work [19:38:14] marktraceur: I think you're overthinking it [19:38:18] Oh, wait, you mean just store the whole JSON object [19:38:21] You're right, I am [19:38:28] marktraceur: I'm not even reviewing the logic itself [19:38:49] I was just commenting about a seemingly redundant cloning of an object (where the clone is even more verbose than the original) [19:38:53] New review: Aaron Schulz; "Conflicted" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73713 [19:39:09] Yeah [19:39:22] When you mentioned you didn't know what I meant I elaborated and that probably made it look like something big... [19:39:28] sorry for the confusion. [19:39:44] Does my suggestion make sense though? [19:40:02] Sort of [19:40:33] Krinkle: I think the problem is, I expect that there might be multiple returned tokens in different categories [19:40:43] (also semantics, but it's an object, not JSON, JSON is a string serialisation of an object. e.g. like php-serialise vs. an actual object) [19:41:13] e.g. if someone's querying, for whatever reason, allpages and categorymembers at the same time, I need to handle both of those continue keys [19:41:16] marktraceur: see the longer comment I left. from what I can see there is nothing in the current way that makes that work more than the simple method. [19:41:44] This is't about that. you'd still have store[token] = obj. [19:41:54] So maybe I actually still am misunderstanding [19:42:30] Krinkle: I don't see how you'd accomplish continueToken = { a: ..., b: ..., c: ... } without a loop. [19:42:34] this is about storing store[token] = obj. instead of store[token] = [ { name: obj.1key, value: obj.1value }, { name: obj.2key, value: obj.2value } .. ]; [19:42:41] marktraceur: You don't need a loop [19:42:41] Yeah, that much I get. [19:42:56] OK, now I don't. [19:43:28] And even if you'd do the loop, it's simple. Instead of store[token] = []. and push({name: key, value: value}) you'd do store[token][key] = value; [19:43:39] Yeah [19:43:48] but you don't need the loop [19:44:00] there is no spoon ;-) [19:44:08] How on earth would I be able to do it without the loop and still support multiple query-continue token types? [19:44:31] you'll have the outer loop of course, but not the inner one where you clone the object. you can just store it directly. [19:44:56] See e.g. http://en.wikipedia.org/w/api.php?action=query&list=allpages|allusers&format=json - I need to merge the data['query-continue'].allusers and .allpages objects, and I can't do that trivially AFAIK. Maybe with $.extend. [19:45:26] But $.extend won't delete the existing token if there isn't a new one - I also need to reset the tokens after I get a result [19:45:42] ... [19:45:58] I'll take a look at it tomorrow and make a patch if I still know what I was thinking. [19:46:04] OK then [19:46:24] I'm sorry I'm making this seem complicated. I suspect it's really not. [19:46:32] I'll upload a patch that at least doesn't use arrays [19:46:36] k [19:50:01] New review: TheDJ; "I'd also rather see the word ready in there. Now it is easy to spot what block is in a .ready() and ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74079 [19:56:14] New review: coren; "Seems sane enough." [mediawiki/extensions/OpenStackManager] (master) C: 2; - https://gerrit.wikimedia.org/r/74211 [19:56:16] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/74211 [19:56:47] New patchset: Reedy; "Script to delete private data" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [19:57:35] New patchset: Mwjames; "SpecialPages inject store at the top and disentangle QueryPage class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74258 [19:57:42] New patchset: Reedy; "Script to delete private data" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [20:04:03] New patchset: Reedy; "Script to delete private data" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [20:04:46] New review: Reedy; "print replaced with $this->output()" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [20:07:14] New review: Mwjames; "Run tests against 1.19.7 as well ..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/74258 [20:08:32] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74258 [20:09:47] New patchset: MarkTraceur; "Work with the newer versions of BetaFeatures" [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [20:10:01] New patchset: CSteipp; "Update CentralAuth to master for SUL redir hooks" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74259 [20:10:57] New patchset: MarkTraceur; "Add mediawiki.api.query and getAndContinue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844 [20:13:09] New patchset: CSteipp; "Update CentralAuth to master for SUL redir hooks" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74260 [20:17:36] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74260 [20:18:58] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74259 [20:33:36] csteipp thanks for the hook [20:33:56] AND THERE WAS A HOOK STUCK IN THE DOOR! [20:34:16] brion: it'll be badass if you have a hook on a hand. [20:34:21] not *for* a hand, but just on one [20:34:45] it's all fun and games until you go to scratch your face and lose an eye [20:35:10] brion: hehe, that can be fixed by having it shoot lasers instead of being a hook [20:35:22] :) [20:37:44] You can't top "Chemo" in Skin Tight, an ex-Amish hit man with a weed whacker for an arm after a pet barracuda bites it off [20:39:06] http://en.wikipedia.org/wiki/Blondell_Wayne_Tatum [20:40:09] nice [20:41:54] Yippie, build fixed! [20:41:55] Project browsertests-test2.wikipedia.org-linux-firefox build #417: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/417/ [20:43:16] MatmaRex: ping [20:43:35] Krinkle: pong [20:43:56] MatmaRex: I'm currently working on 2 things, one of which is https://gerrit.wikimedia.org/r/#/c/72322/ [20:44:04] however now that you're online, perhaps you want to do that one/ [20:44:40] feel free to [20:44:50] New patchset: Mwjames; "Add test for some class aliases" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74263 [20:45:30] i was planning to just position #mw-notification-area absolutely, then add another wrapper inside of it with position: relative, per the advice on the bug [20:45:30] position: fixed* [20:45:33] oh hooray one freakin' green build, thanks wmf-selenium-bot [20:49:37] MatmaRex: Why would the area be positioned absolutely, what does that fix? The only thing I currently see is a bit unpleasant is that it keeps the offset from the skin header. [20:50:07] so once you scroll past the header, it should have a generic margin independent of the skin header (e.g. much less tall) [20:50:14] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74263 [20:50:15] not a big gap on top [20:51:04] btw, I haven't written more code than is on that patch. I'm working on another issue and this would be the next thing, I've only thought about it for now. [20:51:16] feel free to do it if you feel like it. [20:52:03] Krinkle: position: fixed is always viewport-relative [20:52:14] Krinkle: while position: asolute is relative to the positioned parent [20:52:26] changing one to the other can break stuff here [20:52:37] I know [20:52:43] even if it still behaves mostly snaely onall skins, whichi haven't even tested [20:52:52] on all core skins* [20:52:57] sanely on all [20:53:24] i'm currently trying to figure out https://bugzilla.wikimedia.org/show_bug.cgi?id=51486 , since it's rather… amusing [20:53:30] The initial offset is overridable by the skin (e.g. in vector it is below the search bar, on the top right of content area) [20:53:59] but once you start scrolling beyond the initial offset, the container should just be fixec positioned at like top: 1em, right: 1em or something like that [20:54:01] fixed* [20:54:45] yeah,i understood that :) [20:54:58] i really don't feel like implementing it, though [20:55:09] ok [20:55:37] and don't really like the idea of having more javascript onscroll event either, but oh well [20:57:13] MatmaRex: yes, hence me asking. You and/or rillke seemed to have an idea that would work without scroll handlers, but I'm not sure whether either those hypotheses don't cover this case or whether I don't understand them yet [20:58:19] yeah, i don't think either of us considered that [20:58:23] idon't mind it personally [20:59:06] (it = notifications staying in their current position, but fixed) [21:04:40] New review: Shirayuki; "Thanks." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74118 [21:13:18] New patchset: Ori.livneh; "Use JSON schema API module rather than action=raw" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/74267 [21:20:46] New patchset: TheDJ; "TableSorter: Add option to mark rows as unsortable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74270 [21:23:01] New patchset: Mwalker; "SmashPig now Uses Composer! (And Symfony/HttpFramework)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69839 [21:24:16] New patchset: Mwjames; "Some docs+ styling" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74271 [21:26:14] New patchset: Mwalker; "SmashPig now Uses Composer! (And Symfony/HttpFramework)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69839 [21:27:09] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/74271 [21:35:21] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71379 [21:39:43] New patchset: TheDJ; "TableSorter: Add option to mark rows as unsortable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74270 [21:46:43] New patchset: Mwalker; "STOMP Datastore Correctly Switches Selectors" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/74275 [21:49:57] New review: Hoo man; "Some notes I can also address myself while testing at some point" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/74152 [21:55:43] New review: Adamw; "(1 comment)" [wikimedia/fundraising/PaymentsListeners] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/74275 [21:55:43] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/74275 [21:58:37] New patchset: Mwjames; "(Bug 51577) SMW\PropertyDisparityDetector (lift some scope creep in ParserData)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [22:01:40] New review: Mwjames; "Tests failing because of ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [22:02:26] New review: Mattflaschen; "Looks good, tested successfully." [mediawiki/extensions/Annotator] (master) C: 2; - https://gerrit.wikimedia.org/r/73612 [22:02:40] Change merged: jenkins-bot; [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/73612 [22:02:55] New review: Spage; "Next patch addresses nits, thanks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [22:03:35] New patchset: Jeroen De Dauw; "Add DataTypes" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74282 [22:05:15] New patchset: MaxSem; "Remove JSMinPlus" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74283 [22:05:29] New patchset: Spage; "Form improvements when creating another's account" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [22:05:37] New patchset: Jeroen De Dauw; "Add DataTypes" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/74284 [22:08:34] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73732 [22:20:11] New review: Zaran; "Ok, but please read comments for suggested improvements" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: 1; - https://gerrit.wikimedia.org/r/72933 [22:21:55] Change merged: jenkins-bot; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [22:25:03] New patchset: Mattflaschen; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [22:26:33] New review: Mattflaschen; "Looks good. Rebased then tested successfully." [mediawiki/extensions/Annotator] (master) C: 2; - https://gerrit.wikimedia.org/r/72360 [22:26:37] Change merged: jenkins-bot; [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [22:28:21] New patchset: Jeroen De Dauw; "Fix incorrect dependency" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/74287 [22:28:27] New patchset: Mwjames; "(Bug 51577) SMW\PropertyDisparityDetector (lift some scope creep in ParserData)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [22:30:45] New patchset: Mattflaschen; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361 [22:31:56] Change merged: jenkins-bot; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/74287 [22:32:43] New patchset: Mwjames; "(Bug 51577) SMW\PropertyDisparityDetector (lift some scope creep in ParserData) " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [22:35:12] New patchset: Mwjames; "(Bug 51577) SMW\PropertyDisparityDetector (lift some scope creep in ParserData) " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [22:35:45] New patchset: MarkTraceur; "Redesign and add more information" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73916 [22:39:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [22:42:22] * legoktm pokes hoo about reviewing https://gerrit.wikimedia.org/r/#/c/48120/ [22:42:52] New review: Tim Starling; "I don't see why that would help. Don't you just need a" [mediawiki/php/FastStringSearch] (master) C: -1; - https://gerrit.wikimedia.org/r/74186 [22:44:05] legoktm: Will take a look before the next code freeze [22:44:38] hoo: thanks. i'm also not sure why https://gerrit.wikimedia.org/r/#/c/48121/ isn't working :/ [22:45:41] New review: Hoo man; "I tested that as well and it also fixes the segfault, I just thought this would be saner... (as repl..." [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [22:49:01] New patchset: Mollywhite; "Bug 50674: Allow display of example navbars." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [22:52:39] New patchset: MarkTraceur; "Add convenience function for checking preferences" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/74290 [23:02:12] New patchset: SuchABot; "[WIP] Initial move to Holo Light than Holo Dark" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [23:06:25] TimStarling: About the FFS patch... how do you prefer it? I'm ok with the if-solution as well, I doubt it will break anything [23:07:40] I don't see how your patch would prevent the segfault [23:07:55] do you have a theory on why it would? [23:09:41] I don't really know how the zend_hash_* functions work... but it seems like the for loop I've altered is being executed exactly hash->nNumOfElements -1 times in the case we see the error [23:10:12] for (i = 0; i < res->replace_size; i++) { if you change that to for (i = 0; i < (res->replace_size -1); i++) { it'll magically work as well [23:10:26] So I guess somethings counting different in there [23:12:47] In case I confused, the for loop I mentioned first is the one belonging to fss_prep_replace and the second one the one in _php_fss_close (which is calling the function that makes us segfault) [23:12:57] New patchset: Shirayuki; "Give grep a chance to find the usages" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/74292 [23:14:47] do you have a simplified test case? [23:15:01] To trigger the error in PHP? No [23:15:42] I looked in core to find what has recently changed and I could find nothing... might be worth a bisect [23:16:27] fss_prep_replace(array('' => 'blah')); seems to work [23:16:54] Yes... I played it with various combinations of empty and half-empty arrays [23:18:26] New patchset: MaxSem; "Make ResourceLoader minifiers extendable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74293 [23:18:54] TimStarling: Nailed it... after looking briefly at the hash_* function [23:18:56] s [23:19:26] Use null as array key [23:19:46] Like array( null => 'd' ) [23:21:15] that's the same as array('' => 'd') isn't it? [23:21:28] array key is a const char*, it can't be null [23:21:44] either way, it still segfaults for me with your patch [23:21:46] probably [23:21:50] Same here [23:21:59] So our PHP has to do something else [23:22:24] New review: Krinkle; "Architectural blocker needing discussion. Not judging intend or implementation." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/74293 [23:22:28] what do you mean? [23:22:45] MediaWiki has to do something else wrong to cause the segfault we see in production [23:22:52] cause I could fix that reproducible [23:23:20] with both the if and the _size patch [23:23:34] MaxSem: Nice idea, a bit unexpected though. Would be nice to have some bug or discussion about this first. There's various impacts this will have that will change several design principles of RL. [23:23:50] ie. before you spend more time on the implementation. [23:24:40] your suggestion is that zend_hash_get_current_data_ex() fails in some case other than at the end of the array? [23:25:03] Krinkle, this particular change is good on its own:) [23:25:11] TimStarling: I thought so, yes [23:25:53] New patchset: Jeroen De Dauw; "Remove verbose GPL headers" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74295 [23:25:53] New patchset: Jeroen De Dauw; "Add link to release blog post" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74296 [23:26:00] and I still think so... if not the condition should be equivalent to i < hash->nNumOfElements [23:26:04] If I'm not mistaken [23:26:08] MaxSem: That is not a fact yet. [23:26:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74295 [23:26:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74296 [23:26:44] At least from quick scan it looks like it will allow things that are principly against the design of RL, namely that filters will do things that don't fallback. [23:27:02] I assume your intention is not to provide a different minifier. [23:27:35] anyway, in a meeting. [23:27:37] "don't fallback"? [23:28:00] New patchset: Jeroen De Dauw; "Tweaks to readme file" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74297 [23:28:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/74297 [23:29:11] I'm pretty sure I borrowed that iteration style from some other extension [23:29:28] look at php_implode() for instance [23:29:41] if zend_hash_get_current_data_ex() fails before the end of the array, it will add a delimiter to the end of the string [23:30:24] New patchset: MarkTraceur; "Disable and dim other fields if enable-all is on" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/74298 [23:30:25] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74293 [23:31:57] or look at SPL_METHOD(SplFixedArray, __wakeup), it uses almost exactly the same code [23:32:03] GorillaWarfare: oooh; new patch :) I guess this might be an opportune time to ask -- what do I need to do to get this working on my local? you're just standalone now correct? [23:32:23] http://paste.tstarling.com/p/rAafAz.html [23:33:45] Ok, true, mh [23:35:17] I'm going to try this with the original test case [23:37:08] mwalker: Should work with the require_once [23:37:14] New patchset: Shirayuki; "Give grep a chance to find the usages" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74299 [23:37:40] mwalker: To play with it, you have to add a JSON block to [[Book:Book title]] [23:37:51] Then edit [[Book title]] and make sure it contains [[Category:Book:Book title]] [23:37:59] nifty! [23:38:00] I shall play [23:40:08] TimStarling: But I still don't get how this is supposed to stay sane if the for loop isn't running for nNumOfElements iterations... am I missing something here? [23:40:36] well, the theory is that the loop always will run for exactly that number of iterations [23:41:40] Then I don't get how my change could solve that segfault we saw with MediaWiki [23:42:00] New patchset: Hoo man; "Fix the calculation of fss_resource_t->replace_size" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [23:42:53] New patchset: Hoo man; "Fix a segfault with zval_ptr_dtor" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [23:42:56] right, that is my problem also [23:43:52] mwalker: You wouldn't happen to know why PHPUnit is giving me this failure, would you? http://pastebin.com/vBF2XCmj [23:44:00] looking [23:44:44] MaxSem: Are you into RL (especially with performance)? [23:44:53] * mwalker blinks [23:45:02] GorillaWarfare: I've got nothing; that one is new to me [23:45:11] mwalker: :( kay [23:45:42] hoo, I am. as a mobile dev, I always look for fun ways to squeeze more out of it:) [23:45:48] GorillaWarfare: you're going to have to look at that specific test case and figure out what it's trying to do [23:45:59] I'll keep poking around.. I've been looking at the test itself, but I can't even really tell what it's checking for [23:45:59] hurm [23:46:02] New review: Hoo man; "Different approach now... also killed trailing spaces (by accident)" [mediawiki/php/FastStringSearch] (master) - https://gerrit.wikimedia.org/r/74186 [23:46:08] * mwalker extracts himself from git hell somewhere else [23:47:24] MaxSem: I got a "fun" draft patch in gerrit, it does some optimization on the startup module (by recursively removing redundant dependencies), but no one seems to really want to review it [23:47:25] New review: Malvineous; "Comment change only" [mediawiki/extensions/MassEditRegex] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73726 [23:47:26] Change merged: Malvineous; [mediawiki/extensions/MassEditRegex] (master) - https://gerrit.wikimedia.org/r/73726 [23:49:00] hoo, the JS part of it is not something I'm familiar with, but fire away:) [23:49:43] Krinkle: question for you if you're there... you wrote an AutoLoader test called checkAutoLoadConf() and I cannot figure out what it's trying to test... any insight? [23:49:55] MaxSem: Added you... it's mostly juggling with the big array of modules [23:50:11] mwalker: I remember no such thing, link? [23:50:11] https://gerrit.wikimedia.org/r/72534 [23:50:35] https://github.com/wikimedia/mediawiki-core/search?q=checkAutoLoadConf [23:50:52] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74299 [23:51:21] Krinkle: yep; that one [23:51:48] New patchset: Aaron Schulz; "Various code cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74300 [23:51:48] mwalker: It asserts that you don't have classes in files that aren't in autoloader [23:52:11] Ohhh, that would make sense.. [23:52:13] mwalker: E.g. if you have class Foo and class Bar in 1 file, and do register the file but only for one of the classes, that is a problem. [23:52:27] gotcha [23:52:37] Because you shouldn't rely on that class being referenced first and triggering the autoloader for it [23:53:00] admitted though, this test is suprisingly undocumented [23:53:05] hoo, a few tests would be great [23:53:22] New patchset: Mollywhite; "Bug 50674: Allow display of example navbars." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74289 [23:53:26] adding documentation for it now [23:54:03] MaxSem: Sure, but I wont write them unless someone tells me, that the approach isn't totally wrong [23:56:05] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74087 [23:57:03] New patchset: Mwalker; "Added a Descriptive Comment to the AutoLoaderTest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/74301